Re: [Libreoffice] [PATCH] [WIP] Remove most of dead code in libs-core
shell part pushed. Christina Am 20.03.2011 00:52, schrieb Xisco Faulí: Here we go with the first round of patches. Whitespaces are not deleted anymore and all the bogus have been deleted. Everything builds allright. Part 1 -- http://dl.dropbox.com/u/1274885/removed-commented-code-part1.tar.gz I'll post the second part soon Greetings ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] [WIP] Remove most of dead code in libs-core
Pushed the linguistic part. Christina Am 20.03.2011 00:52, schrieb Xisco Faulí: Here we go with the first round of patches. Whitespaces are not deleted anymore and all the bogus have been deleted. Everything builds allright. Part 1 -- http://dl.dropbox.com/u/1274885/removed-commented-code-part1.tar.gz I'll post the second part soon ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] [WIP] Remove most of dead code in libs-core
Hi, pushed the framework part. Again a lot of files changed their place so it was quite a lot of work to apply the patch. Additionally I removed lots of dates, comments above removed commented methods, {} not needed anymore after the if () has gone and changed if ( bState = sal_True) to if ( bState == sal_True) in test.cxx. Hope you don't mind that the additional changes are pushed under your name? What about these comments (task.hxx): /*-//** @short- @descr- @seealso- @seealso- @param- @return- @onerror- *//*-*/ I'd suggest to remove them... Christina Am 20.03.2011 00:52, schrieb Xisco Faulí: Here we go with the first round of patches. Whitespaces are not deleted anymore and all the bogus have been deleted. Everything builds allright. Part 1 -- http://dl.dropbox.com/u/1274885/removed-commented-code-part1.tar.gz I'll post the second part soon ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] [WIP] Remove most of dead code in libs-core
Hi, formula and sfx2 pushed. The files WriterHelper.java and DocumentMetadataAccess.java changed their place in the code tree but DocumentMetaData.java seems to have been removed. Christina Am 20.03.2011 00:52, schrieb Xisco Faulí: Here we go with the first round of patches. Whitespaces are not deleted anymore and all the bogus have been deleted. Everything builds allright. Part 1 -- http://dl.dropbox.com/u/1274885/removed-commented-code-part1.tar.gz I'll post the second part soon Greetings 2011/3/18 Christina Roßmanith chrrossman...@web.de mailto:chrrossman...@web.de Patch 0025 now is already pushed but I'll wait until I see a new version on the ML. Christina ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] [WIP] Remove most of dead code in libs-core
Here we go with the first round of patches. Whitespaces are not deleted anymore and all the bogus have been deleted. Everything builds allright. Part 1 -- http://dl.dropbox.com/u/1274885/removed-commented-code-part1.tar.gz I'll post the second part soon Greetings 2011/3/18 Christina Roßmanith chrrossman...@web.de Patch 0025 now is already pushed but I'll wait until I see a new version on the ML. Christina Am 18.03.2011 22:01, schrieb Xisco Faulí: Well, i'm working on it again, so it would be better to forget this patches and wait for the new ones i'm working on. I'll let you know asap 2011/3/18 Christina Roßmanith chrrossman...@web.de Hi, I've applied patch-0025 locally waiting for a successful build. As mentioned earlier whitespace-only changes were skipped. I'd suggest that you break patch-0001 into smaller pieces because 1 lines are simply too much. Christina Am 08.03.2011 21:06, schrieb Xisco Faulí: Hello, I've been working on removing dead code in libs-core for a while ago. I'd say libs-core it's now 98-99% dead code free. I built all the modules I worked in, and everything is allright. I tried to attach the patches into a previous email but it was too big so the mailing list refused it. I copy a rar file with 25 patches in my dropbox: http://dl.dropbox.com/u/1274885/remove-dead-code.zip . I swear it's 100% virus free. Cheers ___ LibreOffice mailing list LibreOffice@lists.freedesktop.orghttp://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing listLibreOffice@lists.freedesktop.orghttp://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice