Re: [Libreoffice] [PATCH] If there's no java, don't do the java stuff
H On Mon, Jan 9, 2012 at 19:04, Christophe Strobbe christophe.stro...@esat.kuleuven.be wrote: I noticed on the mailing list that David Tardon has already pushed your patch, but I'm still curious to know: did you have the Java Access Bridge [1] installed when you tested this patch (I assume you didn't have it because the build broke)? No, I don't have Java Access Bridge, nor have heard of it. :-) Best Regards, -- Korrawit Pruegsanusak ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] If there's no java, don't do the java stuff
On Mon, Jan 09, 2012 at 01:04:20PM +0100, Christophe Strobbe wrote: Hi Korrawit, At 18:24 8-1-2012, Korrawit Pruegsanusak wrote: Hello all, This attached patch fixes build on windows / cygwin. I'm building --without-java, and it breaks because not found java_uno_accessbridge, which seems java-related. I noticed on the mailing list that David Tardon has already pushed your patch, but I'm still curious to know: did you have the Java Access Bridge [1] installed when you tested this patch (I assume you didn't have it because the build broke)? [1] http://www.oracle.com/technetwork/java/javase/tech/index-jsp-136191.html java_uno_accessbridge.jar is one of two jars we build in module accessibility (only for Windows). So, I add a check whether we have SOLAR_JAVA before doing this thing. So java_uno_accessbridge is only added when SOLAR_JAVA is set to TRUE, which AFAICT is something that happens at compile time. Yes, because when SOLAR_JAVA is not set, it might mean there is not any Java compiler avaliable, so we can hardly build any jars :) D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] If there's no java, don't do the java stuff
Hi Korrawit, At 18:24 8-1-2012, Korrawit Pruegsanusak wrote: Hello all, This attached patch fixes build on windows / cygwin. I'm building --without-java, and it breaks because not found java_uno_accessbridge, which seems java-related. I noticed on the mailing list that David Tardon has already pushed your patch, but I'm still curious to know: did you have the Java Access Bridge [1] installed when you tested this patch (I assume you didn't have it because the build broke)? [1] http://www.oracle.com/technetwork/java/javase/tech/index-jsp-136191.html So, I add a check whether we have SOLAR_JAVA before doing this thing. So java_uno_accessbridge is only added when SOLAR_JAVA is set to TRUE, which AFAICT is something that happens at compile time. I assume this patch is part of the work to (locate and) reduce Java dependencies in order to (1) make it easier for developers to build LibreOffice (e.g. when working on patches that have nothing to do with Java), and (2) eventually transition to a LibreOffice without any Java (i.e. for everybody, not just developers). So when the Java Accessibility API has been replaced by the IAccessible2 API, and when the Java-dependent wizards have been replaced, SOLAR_JAVA will become irrelevant. I'm basically trying to increase my understanding of what's going on, so feel free to correct me of I get it wrong :-) Best regards, Christophe My incremental build went fine after this patch, and the program started well :-) Please feel free to comment :-) Best Regards, -- Korrawit Pruegsanusak -- Christophe Strobbe K.U.Leuven - Dept. of Electrical Engineering - SCD Research Group on Document Architectures Kasteelpark Arenberg 10 bus 2442 B-3001 Leuven-Heverlee BELGIUM tel: +32 16 32 85 51 http://www.docarch.be/ Twitter: @RabelaisA11y --- Open source for accessibility: results from the AEGIS project www.aegis-project.eu --- Please don't invite me to Facebook, Quechup or other social networks. You may have agreed to their privacy policy, but I haven't. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] If there's no java, don't do the java stuff
On 09/01/12 13:04, Christophe Strobbe wrote: So java_uno_accessbridge is only added when SOLAR_JAVA is set to TRUE, which AFAICT is something that happens at compile time. I assume this patch is part of the work to (locate and) reduce Java dependencies in order to (1) make it easier for developers to build LibreOffice (e.g. when working on patches that have nothing to do with Java), and (2) eventually transition to a LibreOffice without any Java (i.e. for everybody, not just developers). So when the Java Accessibility API has been replaced by the IAccessible2 API, and when the Java-dependent wizards have been replaced, SOLAR_JAVA will become irrelevant. I'm basically trying to increase my understanding of what's going on, so feel free to correct me of I get it wrong :-) indeed SOLAR_JAVA is essentially just for developers to get a (marginally) faster build, and for esoteric platforms where Java isn't available; release builds on mainstream platforms are going to have Java enabled (as it's necessary for Base, extensions, a11y and a couple other things). ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
