Re: [Libreoffice] [PATCH] use the correct tar binary on OpenBSD

2010-11-12 Thread Sebastian Spaeth 
On Thu, 11 Nov 2010 21:32:44 +0100, Robert Nagy rob...@openbsd.org wrote:
 +if test z`uname -s` = zOpenBSD; then
 + TAR=gtar
 +else
 + TAR=tar
 +fi

Just out of curiosity. In what ways is the BSD tar different that it
breaks?

Sebastian
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] use the correct tar binary on OpenBSD

2010-11-12 Thread Sebastian Spaeth 
 Al the stupid GNU double dash arguments, in this case --exclude :)

It tries to exclude .svn. Do we need that or can't we get rid of it? We
are a git-shop. :)

Sebastian
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] use the correct tar binary on OpenBSD

2010-11-12 Thread Tor Lillqvist 
The outer configure.in already takes a --with-gnu-tar option and sets the 
GNUTAR autoconf substitution, isn't it easier to use that, and make the 
indicated GNU tar propagate to bin/install-artwork some way? (Sourcing 
bin/setup and using $GNUTAR is probably the easiest way.) Probably it would be 
good to automate finding GNU tar on OpenBSD in configure.in, too.

--tml


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] use the correct tar binary on OpenBSD

2010-11-12 Thread Robert Nagy 
ACK

On (2010-11-12 03:41), Tor Lillqvist wrote:
 The outer configure.in already takes a --with-gnu-tar option and sets the 
 GNUTAR autoconf substitution, isn't it easier to use that, and make the 
 indicated GNU tar propagate to bin/install-artwork some way? (Sourcing 
 bin/setup and using $GNUTAR is probably the easiest way.) Probably it would 
 be good to automate finding GNU tar on OpenBSD in configure.in, too.
 
 --tml
 
 
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] use the correct tar binary on OpenBSD

2010-11-12 Thread Sebastian Spaeth 
On Fri, 12 Nov 2010 03:41:05 -0700, Tor Lillqvist tlillqv...@novell.com 
wrote:
 The outer configure.in already takes a --with-gnu-tar option and
 sets the GNUTAR autoconf substitution, isn't it easier to use that,
 and make the indicated GNU tar propagate to bin/install-artwork some
 way?

The inner configure.in doesn't have that option, it will always bomb out
if gnu tar is not installed and 

does AC_SUBST(GNUTAR), so we could use and propagate that as well.

BTW, when do we unify our build methods? :-)
Sebastian


pgp5X5THx89sx.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] use the correct tar binary on OpenBSD

2010-11-11 Thread Caolán McNamara 
On Thu, 2010-11-11 at 21:32 +0100, Robert Nagy wrote:
 - tar -C $src/layout --exclude=.svn -cf- default_images ooo_custom_images 
 | tar -C $dest -xf-
 + ${TAR} -C $src/layout --exclude=.svn -cf- default_images 
 ooo_custom_images | tar -C $dest -xf-

Want to replace the other tar at the end of the line while you're at
it ? rather than mix two tars, not that I guess it really matters.

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] use the correct tar binary on OpenBSD

2010-11-11 Thread Robert Nagy 
Oh sure I missed that. Otherwise can I push it?

On (2010-11-11 20:55), Caolán McNamara wrote:
 On Thu, 2010-11-11 at 21:32 +0100, Robert Nagy wrote:
  -   tar -C $src/layout --exclude=.svn -cf- default_images ooo_custom_images 
  | tar -C $dest -xf-
  +   ${TAR} -C $src/layout --exclude=.svn -cf- default_images 
  ooo_custom_images | tar -C $dest -xf-
 
 Want to replace the other tar at the end of the line while you're at
 it ? rather than mix two tars, not that I guess it really matters.
 
 C.
 
 ___
 LibreOffice mailing list
 LibreOffice@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/libreoffice
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice