Re: [Libreoffice] Java build problem identified | findhome | MacOSX location ?
Hi *, On Mon, Dec 6, 2010 at 2:21 PM, Wols Lists wrote: > On 06/12/10 12:57, Norbert Thiebaud wrote: > > The problem as I saw it was making sure Mac still went through the old > path first, because findhome is successful but returns a dud path. Yes - having the Mac check first is perfectly fine, since then the JAVA_HOME will neither be emtpy nor set to /usr, thus the findhome based check will be skipped. ciao Christian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Java build problem identified | findhome | MacOSX location ?
Ok, I pushed a new version that should be doing 'The Right thing(tm)' on MacOS It is still doing the readlink stuf on other platforms... Norbert On Mon, Dec 6, 2010 at 7:21 AM, Wols Lists wrote: > On 06/12/10 12:57, Norbert Thiebaud wrote: >>> Hmm - but the result of the IRC-discussion was to use (for Mac) >>> > /usr/libexec/java_home where available (10.5 and newer), and the >>> > hardcoded fallbackpath of either >>> > /System/Library/Frameworks/JavaVM.framework/Versions/CurrentJDK/Home >>> > or /Library/Java/Home (which in the end points to the >>> > /System/Library. one. >>> > >>> > http://developer.apple.com/library/mac/#qa/qa2001/qa1170.html >>> > wasn't it? >>> > >> Yes indeed. >> >> Which is not what the result is. since the readlink cruf is still >> attempted before that... I'll have a pass at it to re-order these. >> >> Norbert >> > Sorry - that's my fault, but I was a bit out of my depth and it was late. > > The problem as I saw it was making sure Mac still went through the old > path first, because findhome is successful but returns a dud path. > > And it was the trap the comments said was for mac that was the trap that > made gentoo bomb. > > Cheers, > Wol > ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Java build problem identified | findhome | MacOSX location ?
On 06/12/10 12:57, Norbert Thiebaud wrote: >> Hmm - but the result of the IRC-discussion was to use (for Mac) >> > /usr/libexec/java_home where available (10.5 and newer), and the >> > hardcoded fallbackpath of either >> > /System/Library/Frameworks/JavaVM.framework/Versions/CurrentJDK/Home >> > or /Library/Java/Home (which in the end points to the >> > /System/Library. one. >> > >> > http://developer.apple.com/library/mac/#qa/qa2001/qa1170.html >> > wasn't it? >> > > Yes indeed. > > Which is not what the result is. since the readlink cruf is still > attempted before that... I'll have a pass at it to re-order these. > > Norbert > Sorry - that's my fault, but I was a bit out of my depth and it was late. The problem as I saw it was making sure Mac still went through the old path first, because findhome is successful but returns a dud path. And it was the trap the comments said was for mac that was the trap that made gentoo bomb. Cheers, Wol ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Java build problem identified | findhome | MacOSX location ?
On Mon, Dec 6, 2010 at 6:53 AM, Christian Lohmaier wrote: > Hi Norbert, *, > > On Mon, Dec 6, 2010 at 8:28 AM, Norbert Thiebaud wrote: >> On Sun, Dec 5, 2010 at 9:39 PM, Thorsten Behrens >> wrote: >>> Caolan McNamara wrote: IIRC I tried this before, and there was some cockup under MacOSX, so if someone on MacOSX could see what findhome says and if its correct/wrong vs what works correctly there, that'd be helpful. >>> About 4k miles away from my MacBook currently - Norbert, Cloph, >>> any chance to give this a try? >> >> Cloph, Wol and me have been working on it on IRC, resulting in >> bootstrap:474e4b60fec1f859bc16f268d6340d7850c7874e > > Hmm - but the result of the IRC-discussion was to use (for Mac) > /usr/libexec/java_home where available (10.5 and newer), and the > hardcoded fallbackpath of either > /System/Library/Frameworks/JavaVM.framework/Versions/CurrentJDK/Home > or /Library/Java/Home (which in the end points to the > /System/Library. one. > > http://developer.apple.com/library/mac/#qa/qa2001/qa1170.html > wasn't it? > Yes indeed. Which is not what the result is. since the readlink cruf is still attempted before that... I'll have a pass at it to re-order these. Norbert > I quit IRC early, so have to read some of the backlog, but my > impression was that this was the way to go.. > > ciao > Christian > ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Java build problem identified | findhome | MacOSX location ?
Hi Norbert, *, On Mon, Dec 6, 2010 at 8:28 AM, Norbert Thiebaud wrote: > On Sun, Dec 5, 2010 at 9:39 PM, Thorsten Behrens > wrote: >> Caolan McNamara wrote: >>> IIRC I tried this before, and there was some cockup under MacOSX, so if >>> someone on MacOSX could see what findhome says and if its correct/wrong >>> vs what works correctly there, that'd be helpful. >>> >> About 4k miles away from my MacBook currently - Norbert, Cloph, >> any chance to give this a try? > > Cloph, Wol and me have been working on it on IRC, resulting in > bootstrap:474e4b60fec1f859bc16f268d6340d7850c7874e Hmm - but the result of the IRC-discussion was to use (for Mac) /usr/libexec/java_home where available (10.5 and newer), and the hardcoded fallbackpath of either /System/Library/Frameworks/JavaVM.framework/Versions/CurrentJDK/Home or /Library/Java/Home (which in the end points to the /System/Library. one. http://developer.apple.com/library/mac/#qa/qa2001/qa1170.html wasn't it? I quit IRC early, so have to read some of the backlog, but my impression was that this was the way to go.. ciao Christian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Java build problem identified | findhome | MacOSX location ?
On Mon, 2010-12-06 at 01:28 -0600, Norbert Thiebaud wrote: > Cloph, Wol and me have been working on it on IRC, resulting in > bootstrap:474e4b60fec1f859bc16f268d6340d7850c7874e Well, if it works it works. Still think that all the readlink stuff before trying findhome.java is fairly dubious and that trying findhome first and then falling back to scraping the possible JAVA_HOME out of the paths and readlink should be the fallback position. But I don't have access to all platforms to take on that fight. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Java build problem identified | findhome | MacOSX location ?
On Sun, Dec 5, 2010 at 9:39 PM, Thorsten Behrens wrote: > Caolan McNamara wrote: >> IIRC I tried this before, and there was some cockup under MacOSX, so if >> someone on MacOSX could see what findhome says and if its correct/wrong >> vs what works correctly there, that'd be helpful. >> > About 4k miles away from my MacBook currently - Norbert, Cloph, > any chance to give this a try? Cloph, Wol and me have been working on it on IRC, resulting in bootstrap:474e4b60fec1f859bc16f268d6340d7850c7874e Norbert > > Cheers, > > -- Thorsten > ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Java build problem identified | findhome | MacOSX location ?
Caolan McNamara wrote: > IIRC I tried this before, and there was some cockup under MacOSX, so if > someone on MacOSX could see what findhome says and if its correct/wrong > vs what works correctly there, that'd be helpful. > About 4k miles away from my MacBook currently - Norbert, Cloph, any chance to give this a try? Cheers, -- Thorsten pgpdiK3NtDHFG.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Java build problem identified | findhome | MacOSX location ?
On 05/12/10 20:40, Caolán McNamara wrote: > On Sun, 2010-12-05 at 17:24 +, Wols Lists wrote: >> Yup. findhome found the right place (or I assume it did). >> >> /opt/icedtea6-bin-1.9.1 > Yeah, so what I'd like to see is that findhome (or something like it) is > the normal way to get the jdk home when one is not set via the > --with-jdk-home. And if that fails for some reason then fall back to the > "get the path to java and cut bits off it and hope for the best" route > rather than trying that first. > > IIRC I tried this before, and there was some cockup under MacOSX, so if > someone on MacOSX could see what findhome says and if its correct/wrong > vs what works correctly there, that'd be helpful. > HMMM!!! It's the MacOS test that's messing up gentoo ...! So what someone (me? you?) might do is just put the findhome test in regardless, or put it at the start with a wrapper "if OS != mac". ( I'd actually rather it tried "whereis" first, but I don't think that's always there, and my sed-awk-whatsit-fu isn't up to that... anth...@ashdown ~/gitstuff/lotest $ whereis javac javac: /usr/bin/javac /opt/icedtea6-bin-1.9.1/bin/javac anth...@ashdown ~/gitstuff/lotest $ It seems so simple - take the last entry and strip the last two bits off - bet there's a snag ... ) Let's wait til tomorrow night to see if anyone on a mac bites, and if they don't we can try and do this and get it in the build. Cheers, Wol ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Java build problem identified | findhome | MacOSX location ?
On Sun, 2010-12-05 at 17:24 +, Wols Lists wrote: > Yup. findhome found the right place (or I assume it did). > > /opt/icedtea6-bin-1.9.1 Yeah, so what I'd like to see is that findhome (or something like it) is the normal way to get the jdk home when one is not set via the --with-jdk-home. And if that fails for some reason then fall back to the "get the path to java and cut bits off it and hope for the best" route rather than trying that first. IIRC I tried this before, and there was some cockup under MacOSX, so if someone on MacOSX could see what findhome says and if its correct/wrong vs what works correctly there, that'd be helpful. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
