Re: [Libreoffice] deliver.pl defaulting to strip

2011-02-17 Thread Jan Holesovsky
Hi Caolan,

On 2011-02-15 at 09:09 +, Caolán McNamara wrote:

  Correct, thanks for the hint - so what about to default to provide
  --disable-symbols instead, and default to building with symbols? ;-)
 
 Are symbols insanely large under windows ?. I'd randomly guess that in
 an ideal world we default symbols on when building with gcc and strip
 them at the very last stage when making the final .rpms/.debs when using
 the epm packing mode.

Right, good idea - so I added that as an Easy Hack :-)

Thank you,
Kendy

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] deliver.pl defaulting to strip

2011-02-15 Thread Caolán McNamara
On Tue, 2011-02-15 at 09:32 +0100, Jan Holesovsky wrote:
 Hi Caolan,
 
 On 2011-02-11 at 20:27 +, Caolán McNamara wrote:
 
   deliver.pl now defaults to stripping binaries / libraries when it
   delivers to solver, unless you export DISABLE_STRIP.
  
  It doesn't strip if you have --enable-symbols on FWIW, right ?
 
 Correct, thanks for the hint - so what about to default to provide
 --disable-symbols instead, and default to building with symbols? ;-)

Are symbols insanely large under windows ?. I'd randomly guess that in
an ideal world we default symbols on when building with gcc and strip
them at the very last stage when making the final .rpms/.debs when using
the epm packing mode.

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] deliver.pl defaulting to strip

2011-02-15 Thread Bjoern Michaelsen
Hi Caolán,

On Tue, 15 Feb 2011 09:09:48 +
Caolán McNamara caol...@redhat.com wrote:

 Are symbols insanely large under windows ?. I'd randomly guess that in
 an ideal world we default symbols on when building with gcc and strip
 them at the very last stage when making the final .rpms/.debs when
 using the epm packing mode.

Size is one thing. Build times are another issue to look at -- and
Windows is already slow.

Best Regards,

Bjoern

-- 
https://launchpad.net/~bjoern-michaelsen


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] deliver.pl defaulting to strip

2011-02-11 Thread Bjoern Michaelsen
Hi kendy,

On Fri, 11 Feb 2011 17:07:17 +0100
Jan Holesovsky ke...@novell.com wrote:

 deliver.pl now defaults to stripping binaries / libraries when it
 delivers to solver, unless you export DISABLE_STRIP.
 
 I think it is a bad idea - breaks debugging of the unit tests (unless
 you know that you have to rebuild with debug, and deliver without
 stripping), and the distros need need the symbols too, to be able to
 produce the debuginfo packages.
 
 So - I'd like to change the logic there, and use ENABLE_STRIP envvar
 to control this, defaulting to not stripping; how does that sound to
 you?

I think stripping on deliver was always broken by design, although I
understand why the shortcut was taken. Stripping should be either be
done directly in the workdir, or upon packing the instset IMHO. I tend
to favor the second option, as it keeps information in the binaries as
long as possible. Also IIRC even in the current build there is some
stripping stuff implemented upon packing which would just strip the
already stripped binaries. But I might be wrong there.

Best Regards,

Bjoern Michaelsen


-- 
https://launchpad.net/~bjoern-michaelsen


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] deliver.pl defaulting to strip

2011-02-11 Thread Caolán McNamara
On Fri, 2011-02-11 at 17:07 +0100, Jan Holesovsky wrote:
 Hi,
 
 deliver.pl now defaults to stripping binaries / libraries when it
 delivers to solver, unless you export DISABLE_STRIP.

It doesn't strip if you have --enable-symbols on FWIW, right ?

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice