Re: [PATCH] Remove unused code (ImpSvtData)
On Wed, 2012-04-25 at 05:16 -0700, Javier Catala wrote: Hi everyone, This patch removes unused destructor in the ImpSvtData class, as listed in unusedcode.easy Yeah, but see unusedcode.README and f. If the constructor used, but the destructor is unused. Then its probably a leak and we should try and fix the leak and call the destructor somewhere rather than removing the destructor. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] Re: [PATCH] Remove unused code (vcl)
Hello, On 4 April 2012 17:14, Thomas Collerton tom.col...@gmail.com wrote: Hello all, this patch removes unused code in the Slider class as listed in unusedcode.easy Looks good = pushed Thanks, Matúš ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] Re: [PATCH] remove unused code (oox)
Hi Petr, Petr Vorel píše v Po 02. 04. 2012 v 16:18 +0200: removed unused classes from oox. Pushed: http://cgit.freedesktop.org/libreoffice/core/commit/?id=07ff032c805835355ff0dff75b8ad534dfb770e9 Thank you! :-) Regards, Kendy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH] Remove unused code from gtkframe
On Wed, 2012-02-15 at 22:55 +0100, Michael Stahl wrote: On 15/02/12 21:31, Kate Goss wrote: Hi Michael, Caolan, How accurate/ up to date is unusedcode.easy? Is there a way to make sure the methods I'm removing are genuinely unused? Its generally up to date, but it always requires at least some casual manual inspection to see if the code is used in some specific configuration, e.g. sticking the name into opengrok.libreoffice.org to see if there are some uses hidden behind #ifdef WNT or something of that nature. If it was a completely automatizable operation we could just script up something to remove them all in one go :-( I've now moved those two unused-in-normal-configuration methods behind GTK3 conditionals where the rest of the similar code lived already. the problem is that unusedcode.easy is generated from a single configuration of LO. because there is a huge number of potential configurations, there may be some false positives I don't consider them false positives btw. e.g. if there was, say, 300MB of binary in our Linux install which was only called on some Windows specific code-path then I imagine we'd like to only conditionally include it on the appropriate platform. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] Re: [PATCH] Remove unused code
Hi Björgvin, looks good to me. Pushed. Thanks! Cheers Radek On Wed, 2012-02-15 at 01:10 +, Björgvin Ragnarsson wrote: Hi, Attached is a patch for removal of unused code in files core/basegfx/source/polygon/b3dpolygontools.cxx and core/basegfx/inc/basegfx/polygon/b3dpolygontools.hxx thanks, Björgvin ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] Re: [PATCH] Remove unused code
Just adding [PUSHED] :-) Radek Doulik píše v Út 14. 02. 2012 v 19:03 +0100: Hi Santiago, thanks for you patch, pushed. Cheers Radek On Mon, 2012-02-13 at 21:55 +0100, Santiago Martinez wrote: This patch removes unused code as listed in unusedcode.easy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH] Remove unused code from gtkframe
Hi Kate, On Tue, 2012-02-14 at 21:33 +, Kate Goss wrote: Please find attached a patch to remove a couple of methods listed in unusedcode.easy, from gtkframe. Sadly they are used - but only for the gtk3 mode that caolan is not compiling. Perhaps instead if you could move up the #if GTK_CHECK_VERSION(3,0,0) outside the methods themselves, that'd solve the problem for the gtk2 bakend. Caolan - any chance of call-catching with gtk3 enabled ? Sorry about that :-) Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH] Remove unused code from connectivity::odbc
On Tue, 2012-02-14 at 06:06 +0100, Lionel Elie Mamane wrote: Thanks, but this one should actually be used in ODatabaseMetaData::getTableTypes. It is probably a bug that it is not, I'll convert getTableTypes to using it How about the other one ? C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH] Remove unused code
Hi Santiago, thanks for you patch, pushed. Cheers Radek On Mon, 2012-02-13 at 21:55 +0100, Santiago Martinez wrote: This patch removes unused code as listed in unusedcode.easy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH] Remove unused code
On Mon, 2012-02-13 at 00:08 +, Björgvin Ragnarsson wrote: Hello, Attached is my first contribution to Libreoffice Looks good to me, pushed now, thanks for this. C. You should add yourself to http://wiki.documentfoundation.org/Development/Developers and link back to your last email via the archives ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH] Remove unused code (9)
On Sat, 2012-02-11 at 12:01 +0800, Elton Chung wrote: This patch removes 11 unused methods. Lovely, it seems our delay at reviewing caused a few conflicts with others; hopefully you'll be able to pull / re-base any bits you have on top of what I pushed here. Thanks ! Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH] Remove unused code from connectivity::odbc
On Mon, Feb 13, 2012 at 10:06:17PM +, Kate Goss wrote: Please see attached. From 099415fb77eddd7d211ae6ed547cb31b10484a37 Mon Sep 17 00:00:00 2001 From: Kate Goss katherine.g...@gmail.com Date: Sun, 12 Feb 2012 13:57:46 + Subject: [PATCH 1/2] Remove unused method ODatabaseMetaDataResultSet::openTablesTypes( ) Thanks, but this one should actually be used in ODatabaseMetaData::getTableTypes. It is probably a bug that it is not, I'll convert getTableTypes to using it. -- Lionel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH] Remove unused code (5)
On 10.02.2012 18:24, Elton Chung wrote: This patch removes 5 unused methods. Pushed, thank you. Regards, Ivan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PUSHED] Re: [PATCH] Remove unused code
On Tue, 2011-01-11 at 22:23 +0100, Anders Jonsson wrote: Some more commented code, this time in calc. All code has been commented out at least since 2005. Looks good, pushed, thanks for this. From the patch, it seems that means that ScRedlineOptionsTabPage is now an empty function that just returns 0 which suggests a follow up patch to remove it and all references to it, (note IMPL_LINK generally have a matching DECL_LINK somewhere). C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PUSHED] Re: [PATCH] Remove unused code and fix typos
On Sun, 2011-01-09 at 02:06 +0900, Takeshi Abe wrote: Hi, Here is a bunch of cleanup on base. Looks good to me, pushed, thanks for this. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PUSHED] Re: [PATCH] Remove unused code
On Sat, 2010-12-18 at 14:06 +0100, Anders Jonsson wrote: Some more blocks of unused code in libs-gui and libs-core. All have been commented out since at least 2006. All looks good, into the bin with it, thanks for this. Pushed now. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
