Re: [PATCH] disable unit tests wich depend on xmlsec was: sc filter test failures

[Riccardo Magliocchetti]

Hello,

Il 28/05/2012 23:08, David Ostrovsky ha scritto:

On 28.05.2012 22:30, Markus Mohrhard wrote:

Hey,




The problem is --disable-xmlsec. You should not specify this flag as
long as you plan to build on a normal platform. Behind xmlsec are also
all our password related libraries so you can't open password
protected documents. This option makes only sense for platforms where
we don't yet support them.

I was getting the same error on feature/gbuild_merge branch and reported
it here: [1].
I think we should handle this properly: if some feature is disabled,
unit tests have to be disabled too.
Attached patch does it.

[1] http://lists.freedesktop.org/archives/libreoffice/2012-May/032345.html


Or at least say it straight in the help that you are going to waste time 
if you don't know what you are doing :) See attached patch.


thanks,
riccardo
From 216f4e4d6064d0f996ec1978717bd615afd89086 Mon Sep 17 00:00:00 2001
From: Riccardo Magliocchetti riccardo.magliocche...@gmail.com
Date: Tue, 29 May 2012 09:16:25 +0200
Subject: [PATCH] configure: warn about disabling XML security

Some tests will fail and bad things will happen.

Change-Id: Ic4b36a030e527b0869d8f8875e6a7c3dfe0a4ff9
---
 configure.in |3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/configure.in b/configure.in
index 2382c83..52c937d 100644
--- a/configure.in
+++ b/configure.in
@@ -778,7 +778,8 @@ AC_ARG_ENABLE(build-mozilla,
 
 AC_ARG_ENABLE(xmlsec,
 AS_HELP_STRING([--disable-xmlsec],
-[Whether to enable XMLsec for open document signing.]),
+[Whether to enable XMLsec for open document signing. Be warned,
+ building without XML Security will likely give you test failures.]),
 )
 
 AC_ARG_ENABLE(tde,
-- 
1.7.5.4

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PATCH] disable unit tests wich depend on xmlsec was: sc filter test failures

[Markus Mohrhard]

Hey,


 I was getting the same error on feature/gbuild_merge branch and reported it
 here: [1].
 I think we should handle this properly: if some feature is disabled, unit
 tests have to be disabled too.
 Attached patch does it.


Personally I would prefer if we make nss a hard requirement at least
on Linux. We already had too much trouble with nss since 3.4.5 and we
should try to spot them as early as possible to prevent again such
problems that we can't open password protected documents.

Back when I wrote that unit test it was a decision not add an option
to disable it after the problems with 3.4.5/3.5.0RCX with password
related documents and the ubuntu/debian bugs around nss
initialization.

Regards,
Markus
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice