Re: Can #32260 and 51135 be closed? -- both: Request for account
On Tue, 2012-06-26 at 01:55 +0200, Muhammad Haggag wrote: On 06/25/2012 05:56 PM, Philipp Riemer wrote: (2) Also Muhammad Haggag's request https://bugs.freedesktop.org/show_bug.cgi?id=51135 from 2012-06-15 is in UNCONFIRMED state. But here the situation seems to be different since I can only find three mails in total from him in Feb 2012 on the I'm actually interested :) Oh drat - did I really not create that ! Let me close these both out today - thanks for the heads up Philipp :-) ATB, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Can #32260 and 51135 be closed? -- both: Request for account
On Tue, Jun 26, 2012 at 10:59:05AM +0100, Michael Meeks wrote: On Tue, 2012-06-26 at 01:55 +0200, Muhammad Haggag wrote: On 06/25/2012 05:56 PM, Philipp Riemer wrote: (2) Also Muhammad Haggag's request https://bugs.freedesktop.org/show_bug.cgi?id=51135 from 2012-06-15 is in UNCONFIRMED state. But here the situation seems to be different since I can only find three mails in total from him in Feb 2012 on the I'm actually interested :) Oh drat - did I really not create that ! Let me close these both out today - thanks for the heads up Philipp :-) And as penality you can review/cherry-pick Muhammads patch at: https://gerrit.libreoffice.org/#/c/236/ j/k ;) Best, Bjoern ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Can #32260 and 51135 be closed? -- both: Request for account
On Tue, 2012-06-26 at 13:09 +0200, Bjoern Michaelsen wrote: And as penality you can review/cherry-pick Muhammads patch at: https://gerrit.libreoffice.org/#/c/236/ I tried and failed ;-) there is some unexpected complexity with logerrit cherry-pick of a patch that is already merged in gerrit (or something) ? Thanks :-) Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Can #32260 and 51135 be closed? -- both: Request for account
Hi, On Tue, Jun 26, 2012 at 05:03:43PM +0100, Michael Meeks wrote: On Tue, 2012-06-26 at 13:09 +0200, Bjoern Michaelsen wrote: And as penality you can review/cherry-pick Muhammads patch at: https://gerrit.libreoffice.org/#/c/236/ I tried and failed ;-) there is some unexpected complexity with logerrit cherry-pick of a patch that is already merged in gerrit (or something) ? Yes, it seems that you cannot cherrypick _after_ it is merged in gerrit. Usually that makes a lot of sense, as the patch will be on master at that time. Its only an issue as long as we need to manually push over to fd.o. So for now one should not click publish and submit, but use publish comments instead unless one has pushed the patch to fd.o too. Gerrit will notice the change to be merged anyway on the next sync. I tweaked logerrit (for now) to not do the Wrong Thing(tm) with: http://cgit.freedesktop.org/libreoffice/core/commit/?id=b0cb1955daf41617a3abc72f153d858570d6e515 So again, this is a temporary issue that will be gone when gerrit owns the repo as then you do not need the ref anymore once the patch is in. Best, Bjoern ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Can #32260 and 51135 be closed? -- both: Request for account
On 06/25/2012 05:56 PM, Philipp Riemer wrote: (2) Also Muhammad Haggag's request https://bugs.freedesktop.org/show_bug.cgi?id=51135 from 2012-06-15 is in UNCONFIRMED state. But here the situation seems to be different since I can only find three mails in total from him in Feb 2012 on the mailing list (see https://www.google.com/search?q=Muhammad%20Haggagsitesearch=%25%28archive_url%29s%2F#hl=entbs=cdr:1%2Ccd_min%3A1%2F1%2F2010%2Ccd_max%3A6%2F25%2F2012sclient=psy-abq=Muhammad+Haggag+site%3Ahttp%3A%2F%2Flists.freedesktop.org%2Farchives%2Flibreoffice%2Foq=Muhammad+Haggag+site:http%3A%2F%2Flists.freedesktop.org%2Farchives%2Flibreoffice%2Faq=faqi=aql=gs_l=serp.12...9421.9795.0.13069.3.3.0.0.0.0.63.177.3.3.0...0.0.uYm14PDWpJgpbx=1bav=on.2,or.r_gc.r_pw.r_qf.,cf.osbfp=3892739cde4f876ebiw=1440bih=812). Since Muhammad seems to be not interested anymore - can this request be changed into a closed state as well? I'm actually interested :) Michael told me to file the bug and ping him, which I did. He hasn't responded yet, so I didn't want to pester him about it yet in case he's busy (especially with the move to gerrit, I assumed this might not be needed anymore). Regards, --Muhammad ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice