Re: LO 4.3 build broken (related to bnc#891663)

2014-09-24 Thread Lubos Lunak
On Tuesday 23 of September 2014, Andras Timar wrote:
 On Tue, Sep 23, 2014 at 10:10 PM, Jean-Baptiste Faure

 jbfa...@libreoffice.org wrote:
  Hi,
 
  The build of 4.3 branch fails on the following unit test :
 
  [build CUT] sw_ooxmlimport
  File tested,Execution Time (ms)
  bnc891663.docx,[...]/LibO/lo43/sw/qa/extras/ooxmlimport/ooxmlimport.cxx:2
 284:testBnc891663::Import assertion failed
  - Expression: textNextRowTop = imageTop + imageHeight

 Unfortunately the fix worked only for master. I accepted the patch for
 libreoffice-4-3, but it was a mistake. I reverted it.

 My bad, the original code had several unhandled switch cases together and I 
overlooked that (not that I get how the fix worked in master).

 Andras, could you please include the commit back to 4.2+4.3 together with 
74c6ba1b741ae76ad9e2f2b81be3e3178163f085 ? Thanks.

-- 
 Lubos Lunak
 l.lu...@collabora.com
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: LO 4.3 build broken (related to bnc#891663)

2014-09-23 Thread Andras Timar
On Tue, Sep 23, 2014 at 10:10 PM, Jean-Baptiste Faure
jbfa...@libreoffice.org wrote:
 Hi,

 The build of 4.3 branch fails on the following unit test :

 [build CUT] sw_ooxmlimport
 File tested,Execution Time (ms)
 bnc891663.docx,[...]/LibO/lo43/sw/qa/extras/ooxmlimport/ooxmlimport.cxx:2284:testBnc891663::Import
 assertion failed
 - Expression: textNextRowTop = imageTop + imageHeight


Unfortunately the fix worked only for master. I accepted the patch for
libreoffice-4-3, but it was a mistake. I reverted it.

Andras
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: LO 4.3 build broken (related to bnc#891663)

2014-09-23 Thread Jean-Baptiste Faure
Le 23/09/2014 23:37, Andras Timar a écrit :
 On Tue, Sep 23, 2014 at 10:10 PM, Jean-Baptiste Faure
 jbfa...@libreoffice.org wrote:
 Hi,

 The build of 4.3 branch fails on the following unit test :

 [build CUT] sw_ooxmlimport
 File tested,Execution Time (ms)
 bnc891663.docx,[...]/LibO/lo43/sw/qa/extras/ooxmlimport/ooxmlimport.cxx:2284:testBnc891663::Import
 assertion failed
 - Expression: textNextRowTop = imageTop + imageHeight

 
 Unfortunately the fix worked only for master. I accepted the patch for
 libreoffice-4-3, but it was a mistake. I reverted it.

Ok, thank you very much.

Best regards.

JBF

-- 
Seuls des formats ouverts peuvent assurer la pérennité de vos documents.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice