Re: Missing image warning
Yow, sorry Maxim - just saw this, I'm way behind on my mail. When I checked, it didn't have the image. Chris On Fri, Sep 12, 2014 at 11:00 PM, Maxim Monastirsky momonas...@gmail.com wrote: On Friday 12 September 2014 21:11:16 Chris Sherlock wrote: I can't see where in the code it goes to a fallback theme. Any pointers? Was surprised to discover that it's actually done at build time. Missing images are simply copied from galaxy to any other zip. It's specified at [1]. Does your images_tango.zip have this svx/res/notcertificate_16.png inside? Maxim [1] http://opengrok.libreoffice.org/xref/core/postprocess/CustomTarget_images.mk#39 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Missing image warning
OK, so it looks like a commit was made to attempt to fix this for fdo#83315 - cf https://bugs.freedesktop.org/show_bug.cgi?id=83315 in commit here: http://cgit.freedesktop.org/libreoffice/core/commit/?id=1387027aa9acf9e62f2d7bf50f71a5889626d194 However, I don't think this is a proper resolution because the actual problem is that the statusbar doesn't show an image to say that the certificate has a problem! Tango has a security-low icon, but we don't seem to have it. How do we add this, if at all possible? Chris On Fri, Sep 12, 2014 at 12:55 AM, Chris Sherlock chris.sherloc...@gmail.com wrote: Hi all, I'm getting the following warning in a debug build of master: warn:legacy.osl:28252:1:vcl/source/gdi/bitmapex.cxx:109: BitmapEx::BitmapEx( const ResId rResId ): could not load image svx/res/notcertificate_16.png via icon theme tango. The BitmapEx constructor that utilizes resources is trying to locate this, but calls on ImplImageTree::loadImage with the default parameter loadMissing set to false, which means it doesn't substitute a default image for the missing PNG. Can someone explain how the icon themes are meant to work? How does it detect tango as the theme and is there meant to be fallback code? Also, can we repackage the tango theme to include this image? It's being called by a security statusbar I believe, but I have no idea where abouts this is in the UI for writer. Thanks, Chris ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Missing image warning
Hi Chris, On Friday 12 September 2014 20:26:12 Chris Sherlock wrote: OK, so it looks like a commit was made to attempt to fix this for fdo#83315 - cf https://bugs.freedesktop.org/show_bug.cgi?id=83315 in commit here: http://cgit.freedesktop.org/libreoffice/core/commit/?id=1387027aa9acf9e62f2d 7bf50f71a5889626d194 However, I don't think this is a proper resolution because the actual problem is that the statusbar doesn't show an image to say that the certificate has a problem! After this commit it does show the icon in the statusbar for me (taking it from Galaxy as a fallback). Maxim ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Missing image warning
That's odd... I'm still not seeing it :( I'm recompiling again, perhaps something has gone wrong on my local system. I can't see where in the code it goes to a fallback theme. Any pointers? Chris On Fri, Sep 12, 2014 at 8:45 PM, Maxim Monastirsky momonas...@gmail.com wrote: Hi Chris, On Friday 12 September 2014 20:26:12 Chris Sherlock wrote: OK, so it looks like a commit was made to attempt to fix this for fdo#83315 - cf https://bugs.freedesktop.org/show_bug.cgi?id=83315 in commit here: http://cgit.freedesktop.org/libreoffice/core/commit/?id=1387027aa9acf9e62f2d 7bf50f71a5889626d194 However, I don't think this is a proper resolution because the actual problem is that the statusbar doesn't show an image to say that the certificate has a problem! After this commit it does show the icon in the statusbar for me (taking it from Galaxy as a fallback). Maxim ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Missing image warning
On Friday 12 September 2014 21:11:16 Chris Sherlock wrote: I can't see where in the code it goes to a fallback theme. Any pointers? Was surprised to discover that it's actually done at build time. Missing images are simply copied from galaxy to any other zip. It's specified at [1]. Does your images_tango.zip have this svx/res/notcertificate_16.png inside? Maxim [1] http://opengrok.libreoffice.org/xref/core/postprocess/CustomTarget_images.mk#39 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Missing image warning
Hello Chris, You might be interested in this bugtracker: https://bugs.freedesktop.org/show_bug.cgi?id=83315 Other: could not load image svx/res/notcertificate_16.png :-) Julien -- View this message in context: http://nabble.documentfoundation.org/Missing-image-warning-tp4121972p4122004.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
