Re: Module build broken on master.
Sorry, It should be lastword. Thanks for fixing, Peter On Wed, Mar 27, 2013 at 8:52 AM, Stephan Bergmann sberg...@redhat.com wrote: On 03/27/2013 08:07 AM, Bjoern Michaelsen wrote: On Tue, Mar 26, 2013 at 05:07:15PM -0400, Kohei Yoshida wrote: So, reverting this commit http://cgit.freedesktop.org/libreoffice/core/commit/?id=207e370a167b7856346c1bff0c735cd2688e2e6e fixes this. Since keeping the module build working is quite important, I'll have to revert this for now. Peter, could you take a second look at this, and hopefully come up with a change that doesn't break module build? seems like lastword - firstword causes the trouble. Any reason for that? I'd fixed that last night, being hit by this in parallel with Kohei but not being aware of this thread, http://cgit.freedesktop.org/libreoffice/core/commit/?id=a13c905f8d9f2e062a1bb3d3882347b47c3359ce Revert 'Revert 'make partial_build work in separate builddir,'' but while that was apparently enough to make the non--separate-builddir case work again, I've no idea whether it is an adequate fix also for the separate-builddir case. So feel free to re^3-vert again... Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Module build broken on master.
On Tue, Mar 26, 2013 at 05:07:15PM -0400, Kohei Yoshida wrote: On 03/26/2013 04:52 PM, Kohei Yoshida wrote: Any ideas? So, reverting this commit http://cgit.freedesktop.org/libreoffice/core/commit/?id=207e370a167b7856346c1bff0c735cd2688e2e6e fixes this. Since keeping the module build working is quite important, I'll have to revert this for now. Peter, could you take a second look at this, and hopefully come up with a change that doesn't break module build? seems like lastword - firstword causes the trouble. Any reason for that? Best, Bjoern ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Module build broken on master.
On 03/27/2013 08:07 AM, Bjoern Michaelsen wrote: On Tue, Mar 26, 2013 at 05:07:15PM -0400, Kohei Yoshida wrote: So, reverting this commit http://cgit.freedesktop.org/libreoffice/core/commit/?id=207e370a167b7856346c1bff0c735cd2688e2e6e fixes this. Since keeping the module build working is quite important, I'll have to revert this for now. Peter, could you take a second look at this, and hopefully come up with a change that doesn't break module build? seems like lastword - firstword causes the trouble. Any reason for that? I'd fixed that last night, being hit by this in parallel with Kohei but not being aware of this thread, http://cgit.freedesktop.org/libreoffice/core/commit/?id=a13c905f8d9f2e062a1bb3d3882347b47c3359ce Revert 'Revert 'make partial_build work in separate builddir,'' but while that was apparently enough to make the non--separate-builddir case work again, I've no idea whether it is an adequate fix also for the separate-builddir case. So feel free to re^3-vert again... Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Module build broken on master.
On 03/26/2013 04:52 PM, Kohei Yoshida wrote: Any ideas? So, reverting this commit http://cgit.freedesktop.org/libreoffice/core/commit/?id=207e370a167b7856346c1bff0c735cd2688e2e6e fixes this. Since keeping the module build working is quite important, I'll have to revert this for now. Peter, could you take a second look at this, and hopefully come up with a change that doesn't break module build? Thanks! Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
