Re: What is the best way to pass a flag from a unit test?

2017-02-02 Thread Stephan Bergmann 

On 02/01/2017 10:57 PM, Khaled Hosny wrote:

It seems that LO_TESTNAME name is currently not set on Windows (or that
is my reading of sal/cppunittester/cppunittester.cxx).

I’m rather not sure if we want to do this unconditionally for all tests
or not, but if that is the consensus, I think we can make sure
LO_TESTNAME is set also on Windows (assuming there is no reason not to
do so) and use it.


Not sure why Norbert introduced that as UNX-only in 
 
"decorate tempfile name's to help identify leaks' author".  I see no 
good reason not to also enable it on Windows.


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: What is the best way to pass a flag from a unit test?

2017-02-01 Thread Khaled Hosny 
On Wed, Feb 01, 2017 at 10:41:33AM +0100, Miklos Vajna wrote:
> Hi Khaled,
> 
> On Wed, Feb 01, 2017 at 09:38:02AM +0200, Khaled Hosny 
>  wrote:
> > What the best way to detect, inside VCL, that a given CppunitTest is
> > being run and do something conditionally? I basically want to detect if
> > a given class of unit tests is run and disable all font searching and
> > fallback and just use a hard-coded font name so that the tests are not
> > affected by what fonts are available or not on the system (or that the
> > theory).
> 
> At one place vcl code already checks for LO_TESTNAME.
>
> (That may be a better option compared to the one in the comment of
> .)

It seems that LO_TESTNAME name is currently not set on Windows (or that
is my reading of sal/cppunittester/cppunittester.cxx).

I’m rather not sure if we want to do this unconditionally for all tests
or not, but if that is the consensus, I think we can make sure
LO_TESTNAME is set also on Windows (assuming there is no reason not to
do so) and use it.

Regards,
Khaled


signature.asc
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: What is the best way to pass a flag from a unit test?

2017-02-01 Thread Miklos Vajna 
Hi Khaled,

On Wed, Feb 01, 2017 at 09:38:02AM +0200, Khaled Hosny  
wrote:
> What the best way to detect, inside VCL, that a given CppunitTest is
> being run and do something conditionally? I basically want to detect if
> a given class of unit tests is run and disable all font searching and
> fallback and just use a hard-coded font name so that the tests are not
> affected by what fonts are available or not on the system (or that the
> theory).

At one place vcl code already checks for LO_TESTNAME.

(That may be a better option compared to the one in the comment of
.)

Regards,

Miklos


signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice