Re: Request for late push to 4.4.1
@Tamás, Getting the first in to correct the MAB for 4.4.1 is probably enough. Thank you. As to even bringing the second down to 4.4, I'll have to do some bench marking comparing t a 4.4.2 nightly and a 4.5.0 master with the "sw: avoid temporary object creation to build GraphicPrimitive2D" patch. I don't have a test case canned against it. @Pierre-Eric did you have any performance metrics from working these up? -- View this message in context: http://nabble.documentfoundation.org/Request-for-late-push-to-4-4-1-tp4139801p4140028.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Request for late push to 4.4.1
2015-02-12 2:46 GMT+01:00 V Stuart Foote : > Request for late review for 4.4.1 > > http://cgit.freedesktop.org/libreoffice/core/commit/?id=c7e907f58f8d0791ee304b42de769f43102522e9 > > http://cgit.freedesktop.org/libreoffice/core/commit/?id=ad14ed0bbf80dd95dca6e0dea6edbe5fb68f9f26 > > The first corrects 4.4 MAB tdf#88935 and has been picked up in 4.4 for > the 4.4.2 branch, the later further improves image drawing frame refresh > handling of image cache. Believe both to be worthwhile late pushes for the > 4.4.1 cycle. First commit is pushed now also to 4.4.1 branch. It fixes a MAB so it worth to do that. On the other hand for the second commit we would need some test case with which we can verify that this change has a visible effect. Do you have a test document or a reproducible user case which we can use for that? Best Regards, Tamás ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Request for late push to 4.4.1
@Miklos, *, Of course that is how it would work if all participants of the project were able and currently building from source. I don't. No excuses, I just don't. I should, and freely acknowledge that I need to. So, that said and out of the way--opportunity here to fix a nasty 4.4 MAB regression with linked images prior to the 4.4.1 release, I wouldn't have made the suggestion if it did not have merit in making the first bug fix for 4.4 I do what I can do for the project, but at this point someone else other than me needs to act on it. Stuart -- View this message in context: http://nabble.documentfoundation.org/Request-for-late-push-to-4-4-1-tp4139801p4139819.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Request for late push to 4.4.1
Hi Stuart, On Wed, Feb 11, 2015 at 06:46:29PM -0700, V Stuart Foote wrote: > Request for late review for 4.4.1 > > http://cgit.freedesktop.org/libreoffice/core/commit/?id=c7e907f58f8d0791ee304b42de769f43102522e9 > > http://cgit.freedesktop.org/libreoffice/core/commit/?id=ad14ed0bbf80dd95dca6e0dea6edbe5fb68f9f26 > > The first corrects 4.4 MAB tdf#88935 and has been picked up in 4.4 for > the 4.4.2 branch, the later further improves image drawing frame refresh > handling of image cache. Believe both to be worthwhile late pushes for the > 4.4.1 cycle. This is not how things work. :-) If you want to see a commit backported to 4-4-1, then please build 4-4-1 yourself, cherry-pick the commit, build-test it, then test that the commit on 4-4-1 indeed fixes the problem (otherwise there is no point in backporting it), and if so, push to gerrit. Once it's on gerrit, it'll get reviewed as usual, and at the end either rejected or submitted to the release branch. The point is that who wants to have something on a branch does the work of backporting (which may or may not be trivial depending on how much conflicts you get), not the reviewers, who are already the bottleneck. Thanks, Miklos signature.asc Description: Digital signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Request for late push to 4.4.1
Request for late review for 4.4.1 http://cgit.freedesktop.org/libreoffice/core/commit/?id=c7e907f58f8d0791ee304b42de769f43102522e9 http://cgit.freedesktop.org/libreoffice/core/commit/?id=ad14ed0bbf80dd95dca6e0dea6edbe5fb68f9f26 The first corrects 4.4 MAB tdf#88935 and has been picked up in 4.4 for the 4.4.2 branch, the later further improves image drawing frame refresh handling of image cache. Believe both to be worthwhile late pushes for the 4.4.1 cycle. Please review. -- View this message in context: http://nabble.documentfoundation.org/Request-for-late-push-to-4-4-1-tp4139801.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
