Re: There is a problem with Gerrit WIP.
Hi, On Wednesday, 2021-02-03 18:39:02 +0100, Eike Rathke wrote: > Unfortunately git-review (which I prefer due to its check for multiple > outstanding commits and easy topic handling) seems to not have a similar > switch for that. I stand corrected.. As of v1.27 git-review has the -w or --work-in-progress option that does exactly that. It's not documented in the man page but with git-review --help. Thanks to David Ostrovsky for pointing out. Eike -- GPG key 0x6A6CD5B765632D3A - 2265 D7F3 A7B0 95CC 3918 630B 6A6C D5B7 6563 2D3A signature.asc Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: There is a problem with Gerrit WIP.
Hi, On Wednesday, 2021-02-03 08:02:28 +0200, Ilmari Lauhakangas wrote: > you can submit > your patch as WIP from the start with > > ./logerrit submit-wip master Just to mention for people not using ./logerrit but git push instead, that appends %wip to the remote gerrit refspec, so equals git push ssh://logerrit/core HEAD:refs/for/master%wip Unfortunately git-review (which I prefer due to its check for multiple outstanding commits and easy topic handling) seems to not have a similar switch for that. Eike -- GPG key 0x6A6CD5B765632D3A - 2265 D7F3 A7B0 95CC 3918 630B 6A6C D5B7 6563 2D3A signature.asc Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: There is a problem with Gerrit WIP.
On 3.2.2021 1.41, Dante Doménech wrote: There is a problem with Gerrit WIP. After setting a patch as WIP a build is scheduled. Over here: built started after setting it as work in progress: https://gerrit.libreoffice.org/c/core/+/110255/8 <https://gerrit.libreoffice.org/c/core/+/110255/8> https://ci.libreoffice.org/job/gerrit_master/77366/ <https://ci.libreoffice.org/job/gerrit_master/77366/> https://gerrit.libreoffice.org/c/core/+/110166/3 <https://gerrit.libreoffice.org/c/core/+/110166/3> This was discussed in the dev chat after you mentioned it. The logic is that a build is triggered whenever the WIP state is changed. It does not matter, if the WIP is activated or deactivated. So to go around this, you can submit your patch as WIP from the start with ./logerrit submit-wip master Ilmari ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
There is a problem with Gerrit WIP.
There is a problem with Gerrit WIP. After setting a patch as WIP a build is scheduled. Over here: built started after setting it as work in progress: https://gerrit.libreoffice.org/c/core/+/110255/8 https://ci.libreoffice.org/job/gerrit_master/77366/ https://gerrit.libreoffice.org/c/core/+/110166/3 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
