Re: WB_3DLOOK

2014-05-09 Thread Caolán McNamara
On Mon, 2014-05-05 at 17:59 +1000, Chris Sherlock wrote:
 Hi all,
 
 
 I have been review the Window classes in VCL and I noticed a window
 style WB_3DLOOK. It appears to set 

 I guess my question is: is this still desirable behaviour? Do we still
 want to specify a 3D or non-3D look in the window style? Almost
 everything sets it to on anyway from what I can see.

IIRC WB_3DLOOK now means to make the buttons etc look like the desktop
theme, while without it you get a different basic look. I'd leave them
alone unless there is proof that they are always set. I'm thinking about
maybe cases where we use the widgets inside in the document area or
something and deliberately don't want a desktop-theme look

C.


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


WB_3DLOOK

2014-05-05 Thread Chris Sherlock
Hi all,

I have been review the Window classes in VCL and I noticed a window style 
WB_3DLOOK. It appears to set 

* the window button colour and the window text color - see 
http://opengrok.libreoffice.org/xref/core/vcl/source/window/window.cxx#1144

* face colour for split windows, docking windows and toolboxes - see 
http://opengrok.libreoffice.org/xref/core/vcl/source/window/splitwin.cxx#1343 
and 
http://opengrok.libreoffice.org/xref/core/vcl/source/window/dockwin.cxx#357 and 
also http://opengrok.libreoffice.org/xref/core/vcl/source/window/toolbox.cxx#551

I guess my question is: is this still desirable behaviour? Do we still want to 
specify a 3D or non-3D look in the window style? Almost everything sets it to 
on anyway from what I can see.

Chris___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice