Re: Why is PolyPolygonShape excluded from DML export?
Hi Regina, On Tue, Aug 24, 2021 at 03:05:30PM +0200, Regina Henschel wrote: > Excluding polygon shapes from DML export (done as fix for tdf#75254) is no > longer needed. But I'm still unsure whether to remove this restriction. > > Pro: > Polygon shapes are already exported as DML in Impress and Calc. So the > behavior would become consistent. > Polygon shapes could use the same improvements in wrapping as made for > Bézier curves. > > Contra: > On reopening the polygon shape would be converted to a custom shape. That > means, that the user can no longer edit the points. Having only VML in the > file opens the shape as PolyPolygonShape which allows point editing. > > So what to you suggest? I would lean towards writing the polygon shape as a PolyPolygonShape to allow editing. We used to write just VML in the past, so some may see this as a regression if the drawingML output doesn't allow editing anymore. Regards, Miklos
Re: Why is PolyPolygonShape excluded from DML export?
Hi Miklos, hi all, Excluding polygon shapes from DML export (done as fix for tdf#75254) is no longer needed. But I'm still unsure whether to remove this restriction. Pro: Polygon shapes are already exported as DML in Impress and Calc. So the behavior would become consistent. Polygon shapes could use the same improvements in wrapping as made for Bézier curves. Contra: On reopening the polygon shape would be converted to a custom shape. That means, that the user can no longer edit the points. Having only VML in the file opens the shape as PolyPolygonShape which allows point editing. So what to you suggest? Kind regards Regina
Re: Why is PolyPolygonShape excluded from DML export?
Hi Miklos, hi all, I have attached a file to tdf#75254 which was produced by LO7.3 with DML enabled. It shows well in LO 7.3 and in Word 365. Miklos, I think you have got a Word 2010. Could you please try, whether this new file shows well in Word 2010 too? Or someone else has got Word 2010 and can try it? Background is, that in case Word 2010 does not show it, the exclusion of DML for PolyPolygon-shapes needs to be kept for docx version 12. Otherwise I would simple remove that part from DocxSdrExport::Impl::isSupportedDMLShape() Kind regards Regina Regina Henschel schrieb am 21.07.2021 um 13:29: Hi Miklos, thank you for pointing me to that bug report. Miklos Vajna schrieb am 21.07.2021 um 08:46: Hi Regina, On Tue, Jul 20, 2021 at 12:08:30AM +0200, Regina Henschel wrote: Is it possible, that the exclusion was only forgotten to remove, or is there a valid reason? This was added in 3c0a7cf4f67720f2cca2c4eb543f838d5b644e7f for https://bugs.documentfoundation.org/show_bug.cgi?id=75254. If that problem no longer happens when you remove the PolyPolygonShape from isSupportedDMLShape(), then I see no problems with that. The document attached to that bug report has no problem with roundtrip. I have put removing the restriction on my ToDo-List. Kind regards Regina ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Why is PolyPolygonShape excluded from DML export?
Hi Miklos, thank you for pointing me to that bug report. Miklos Vajna schrieb am 21.07.2021 um 08:46: Hi Regina, On Tue, Jul 20, 2021 at 12:08:30AM +0200, Regina Henschel wrote: Is it possible, that the exclusion was only forgotten to remove, or is there a valid reason? This was added in 3c0a7cf4f67720f2cca2c4eb543f838d5b644e7f for https://bugs.documentfoundation.org/show_bug.cgi?id=75254. If that problem no longer happens when you remove the PolyPolygonShape from isSupportedDMLShape(), then I see no problems with that. The document attached to that bug report has no problem with roundtrip. I have put removing the restriction on my ToDo-List. Kind regards Regina ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Why is PolyPolygonShape excluded from DML export?
Hi Regina, On Tue, Jul 20, 2021 at 12:08:30AM +0200, Regina Henschel wrote: > Is it possible, that the exclusion was only forgotten to remove, or is there > a valid reason? This was added in 3c0a7cf4f67720f2cca2c4eb543f838d5b644e7f for https://bugs.documentfoundation.org/show_bug.cgi?id=75254. If that problem no longer happens when you remove the PolyPolygonShape from isSupportedDMLShape(), then I see no problems with that. Regards, Miklos ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
Why is PolyPolygonShape excluded from DML export?
Hi all,
this is about export ODF shape -> OOXML.
bool DocxSdrExport::Impl::isSupportedDMLShape(const
uno::Reference& xShape)
{
uno::Reference xServiceInfo(xShape,
uno::UNO_QUERY_THROW);
if
(xServiceInfo->supportsService("com.sun.star.drawing.PolyPolygonShape")
||
xServiceInfo->supportsService("com.sun.star.drawing.PolyLineShape"))
return false;
excludes SdrPathObj objects from DML export, in case they have no
control points. I see no reason, why a simple polygon is excluded, but a
bezier curve is allowed.
Effect is, that it is only exported as VML and so looses e.g. line
transparency.
Is it possible, that the exclusion was only forgotten to remove, or is
there a valid reason?
Kind regards
Regina
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice
