Re: bug 49610 in impress: suspicious commit found, but help needed
Hello, I locally reverted bdfbbb33a491f3ce34375de14ba33436b04 > - sadly the change mixes a lot of reformatting with that fix. Hard > to tell if that is now causing some ripple effects. :/ I can confirm this is the origin of the problem. The generated bug is very nasty (creates data loss) and the fix has to / should be in 3.6 as well as in 3.5.5 I also have to say honestly that fixing this patch is beyond my knowledge of LibO code in this area. So if you say OK, I will push my revert to master. This is not the most polite way of fixing it. destroying your correction, but the one that fit to my knowledge there. Or have you time to investigate it and fix it ? Sorry, this sounds not very constructive, but in this period I do not have a lot of free time, so I can not offer more. Tack regards Pierre-André On 06/20/2012 11:10 PM, Thorsten Behrens wrote: Pierre-André Jacquod wrote: As I just do not understand what it is about here, (neither the goal of the change nor the actual content), could you have a look about it? I guess it will be the quickest way. Hi Pierre-André, well the goal was to decouple live cycles of Outliner and ViewShell Cheers, -- Thorsten ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
bug 49610 in impress: suspicious commit found, but help needed
hello, this bug is a bad regression. Following with debugger, I had as suspect the function void Outliner::ProvideNextTextObject (void) line 979 in sd/source/ui/view/Outliner.cxx (or something called late from this) as main suspect. After bibisect from QA the commit bdfbbb33a491f3ce34375de14ba33436b04 slidesorter1: #i116014# Outliner holds ViewShell as weak_ptr. * found as LGPLv3-only fix at svn rev 1172131 (http://svn.apache.org/viewvc?view=revision&revision=1172131) touch the suspected function, within the commit frame between last good and first bad binaries. As I just do not understand what it is about here, (neither the goal of the change nor the actual content), could you have a look about it? I guess it will be the quickest way. Beware: currently this commit is just a suspect, since I need more than 4 hours to compile (I am on linux, yeah, but with my hardware...) I am still compiling the checkout to try & test. If / when I get more info (means I have compiled it), I will update to confirm (or not) my suspect. Thanks and regards Pierre-André ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: bug 49610 in impress: suspicious commit found, but help needed
Pierre-André Jacquod wrote: > As I just do not understand what it is about here, (neither the goal > of the change nor the actual content), could you have a look about > it? I guess it will be the quickest way. > Hi Pierre-André, well the goal was to decouple live cycles of Outliner and ViewShell - sadly the change mixes a lot of reformatting with that fix. Hard to tell if that is now causing some ripple effects. :/ Cheers, -- Thorsten pgpojxxFG0bmz.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice