Re: [REVIEW 3-5] Re: build breaks - icu49 ?
Hi Tomáš, On Tuesday, 2012-04-03 00:54:22 +0200, Eike Rathke wrote: http://cgit.freedesktop.org/libreoffice/core/commit/?id=43084e8b30c101a44510b7a8267d5c2b316a17bb Could you check if that works with your ICU 4.9 build and if so commit it to the 3-5 branch? Thanks Eike -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer. GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3 9E96 2F1A D073 293C 05FD pgp2ucvwoPMLn.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED][REVIEW 3-5] Re: build breaks - icu49 ?
Hi, On Tuesday, 2012-04-03 15:08:41 +0200, Eike Rathke wrote: http://cgit.freedesktop.org/libreoffice/core/commit/?id=43084e8b30c101a44510b7a8267d5c2b316a17bb Could you check if that works with your ICU 4.9 build and if so commit it to the 3-5 branch? Needed some backporting love, still pushed with Tomáš' sign-off from IRC, so beat me if I fouled anything up ;-) http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5id=ba3550bc82b8fb697b905c9913e399e1835b7cc0 Eike -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer. GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3 9E96 2F1A D073 293C 05FD pgps5U0QWKJJZ.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH] Re: build breaks - icu49 ?
Hi Tomáš, On Saturday, 2012-03-31 21:52:06 +0200, Tomáš Chvátal wrote: Gentoo dev reporting the issue actually tried to write patch. [1] It is backported from ICU upstream. [2] Let me know if it is correct enough for commiting and I will do it. [1] http://people.apache.org/~Arfrever/libreoffice-3.5.2.2-icu-49.patch [2] https://ssl.icu- project.org/trac/changeset/31071/icu/trunk/source/data/brkitr/char.txt It took me some digging around to find what actually the comment in [2] TODO: Restore if the Prepend set becomes non-empty again was referring.. so, according to UAX #29 rev19 for Unicode version 6.1 we have in section 3.1 http://www.unicode.org/reports/tr29/tr29-19.html#Default_Grapheme_Cluster_Table Prepend: (Currently there are no characters with this value.) UAX #29 rev17 for Unicode Version 6.0 was the last revision that listed some characters for Prepend, and Unicode Version 6.1 changed that handling. Note that Prepend characters were defined only for THAI, LAO and TAI VIET, see http://www.unicode.org/reports/tr29/tr29-17.html#Default_Grapheme_Cluster_Table and as our char_in.txt is used only for Indic languages the Prepend rule shouldn't have any effect there anyway. Or I think so ... So yes, Tomáš, I think it's safe to commit the patch. Btw, we have a slight problem here, specifically the case if Prepend became non-empty again we wouldn't notice other than polling UAX #29 changes, and in general using modified RBBI rules based on maybe completely outdated rules we once adapted for an ancient ICU version. Problem is that no one can judge on them other than native speakers AND those have to be Unicode segmentation rules and ICU RBBI rules savvy ... Eike -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer. GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3 9E96 2F1A D073 293C 05FD pgpiFJjOFIKtK.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [REVIEW 3-5] Re: build breaks - icu49 ?
Ok, I commited the patch to the master, as the distros will mostly add icu49 now and libreoffice is the only offender that wont compile against it now please review the patch for 3-5 branch and commit if applicable. [1] Cheers Tom [1] http://cgit.freedesktop.org/libreoffice/core/commit/?id=0c08a84c04b166ab6479716e2c33cd444d7e3dbe signature.asc Description: This is a digitally signed message part. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [REVIEW 3-5] Re: build breaks - icu49 ?
Hi Tomáš, On Monday, 2012-04-02 18:53:16 +0200, Tomáš Chvátal wrote: I commited the patch to the master, as the distros will mostly add icu49 now and libreoffice is the only offender that wont compile against it now please review the patch for 3-5 branch and commit if applicable. [1] Bah, I initially overlooked that the patch also changes the general char.txt, not only char_in.txt We have a problem here, as that changes behavior for Thai and Lao with existing ICU versions. Ideally the change of char.txt should depend on the actual ICU version being used, e.g. by duplicating the data file and in makefile check the ICU version, ugly but I don't see other means. Anyone else? Eike -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer. GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3 9E96 2F1A D073 293C 05FD pgp2PjT6xlJ7W.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [REVIEW 3-5] Re: build breaks - icu49 ?
On Mon, 2012-04-02 at 19:31 +0200, Eike Rathke wrote: Bah, I initially overlooked that the patch also changes the general char.txt, not only char_in.txt We have a problem here, as that changes behavior for Thai and Lao with existing ICU versions. Would be worth adding some sample text that's affected by it to i18npool/qa/cppunit/test_breakiterator.cxx Ideally the change of char.txt should depend on the actual ICU version being used, e.g. by duplicating the data file and in makefile check the ICU version, ugly but I don't see other means. Anyone else? https://bugs.freedesktop.org/attachment.cgi?id=42460 is the kind of hack I tried out the last time something like this happened C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [REVIEW 3-5] Re: build breaks - icu49 ?
Hi Caolán, On Monday, 2012-04-02 20:10:23 +0100, Caolán McNamara wrote: On Mon, 2012-04-02 at 19:31 +0200, Eike Rathke wrote: Bah, I initially overlooked that the patch also changes the general char.txt, not only char_in.txt We have a problem here, as that changes behavior for Thai and Lao with existing ICU versions. Actually it does not ... Would be worth adding some sample text that's affected by it to i18npool/qa/cppunit/test_breakiterator.cxx Hmm.. a year ago Martin Hosken introduced char.txt and commented out the use of SpacingMark and Prepend according to UAX #29 updates, along with changes in breakiterator script identification. So we already have the changed behavior since then. It seems that so far no Thai user complained, so maybe this is indeed desired. Or never was used with the internal ICU, i.e. on Windows. Ideally the change of char.txt should depend on the actual ICU version being used, e.g. by duplicating the data file and in makefile check the ICU version, ugly but I don't see other means. Anyone else? https://bugs.freedesktop.org/attachment.cgi?id=42460 is the kind of hack I tried out the last time something like this happened Great, thanks. Though not exactly needed because of the above I changed things to follow the same pattern, which allows to easily reintroduce the Prepend set if needed. http://cgit.freedesktop.org/libreoffice/core/commit/?id=43084e8b30c101a44510b7a8267d5c2b316a17bb Eike -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer. GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3 9E96 2F1A D073 293C 05FD pgp8Hg1SJvezO.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: build breaks - icu49 ?
Dne Ne 25. března 2012 10:08:38, Andreas Radke napsal(a): While doing a icu49.1 rebuild I'm running into this build break with 3.5.1: genbrk: tool completed successfully. /usr/bin/genbrk -r count_word_fi.txt.p -o count_word_fi.brk LD_LIBRARY_PATH=/build/src/libreoffice-core-3.5.1.2/solver/unxlngx6.pro/lib /build/src/libreoffice-core-3.5.1.2/solver/unxlngx6.pro/bin/gencoll_rule /build/src/libreoffice-core-3.5.1.2/i18npool/source/collator/data/zh_stroke .txt collator_zh_stroke_invis.cxx zh_stroke genbrk: tool completed successfully. sed 's/\(^.*get_\)/SAL_DLLPUBLIC_EXPORT \1/' indexdata_ko_dict_invis.cxx indexdata_ko_dict.cxx /usr/bin/genbrk -r dict_word_he.txt.p -o dict_word_he.brk /usr/bin/genbrk -r char.txt.p -o char.brk sed 's/\(^.*get_\)/SAL_DLLPUBLIC_EXPORT \1/' zh_zhuyin_invis.cxx zh_zhuyin.cxx createRuleBasedBreakIterator: ICU Error U_BRK_RULE_EMPTY_SET at line 19, column 16 make[3]: *** [char.brk] Error 11 make[3]: *** Waiting for unfinished jobs Do we have a fix for this? -Andy ArchLinux No fix yet, just confirming on Gentoo. https://bugs.gentoo.org/show_bug.cgi?idA0307 Cheers Tom signature.asc Description: This is a digitally signed message part. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Re: build breaks - icu49 ?
Gentoo dev reporting the issue actually tried to write patch. [1] It is backported from ICU upstream. [2] Let me know if it is correct enough for commiting and I will do it. Cheers Tom [1] http://people.apache.org/~Arfrever/libreoffice-3.5.2.2-icu-49.patch [2] https://ssl.icu- project.org/trac/changeset/31071/icu/trunk/source/data/brkitr/char.txt signature.asc Description: This is a digitally signed message part. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: build breaks - icu49 ?
On Sun, Mar 25, 2012 at 10:08:38AM +0200, Andreas Radke a.ra...@arcor.de wrote: genbrk: tool completed successfully. /usr/bin/genbrk -r count_word_fi.txt.p -o count_word_fi.brk LD_LIBRARY_PATH=/build/src/libreoffice-core-3.5.1.2/solver/unxlngx6.pro/lib /build/src/libreoffice-core-3.5.1.2/solver/unxlngx6.pro/bin/gencoll_rule /build/src/libreoffice-core-3.5.1.2/i18npool/source/collator/data/zh_stroke.txt collator_zh_stroke_invis.cxx zh_stroke genbrk: tool completed successfully. sed 's/\(^.*get_\)/SAL_DLLPUBLIC_EXPORT \1/' indexdata_ko_dict_invis.cxx indexdata_ko_dict.cxx /usr/bin/genbrk -r dict_word_he.txt.p -o dict_word_he.brk /usr/bin/genbrk -r char.txt.p -o char.brk sed 's/\(^.*get_\)/SAL_DLLPUBLIC_EXPORT \1/' zh_zhuyin_invis.cxx zh_zhuyin.cxx createRuleBasedBreakIterator: ICU Error U_BRK_RULE_EMPTY_SET at line 19, column 16 make[3]: *** [char.brk] Error 11 make[3]: *** Waiting for unfinished jobs Do we have a fix for this? I'm not aware of any such fix yet (I build with icu 4.8 and 4.6 on two different machines, no 4.9 here ATM). ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: build breaks - icu49 ?
confirmed. builds well with internal ICU. anyone who can have a look at this? -Andy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
build breaks - icu49 ?
While doing a icu49.1 rebuild I'm running into this build break with 3.5.1: genbrk: tool completed successfully. /usr/bin/genbrk -r count_word_fi.txt.p -o count_word_fi.brk LD_LIBRARY_PATH=/build/src/libreoffice-core-3.5.1.2/solver/unxlngx6.pro/lib /build/src/libreoffice-core-3.5.1.2/solver/unxlngx6.pro/bin/gencoll_rule /build/src/libreoffice-core-3.5.1.2/i18npool/source/collator/data/zh_stroke.txt collator_zh_stroke_invis.cxx zh_stroke genbrk: tool completed successfully. sed 's/\(^.*get_\)/SAL_DLLPUBLIC_EXPORT \1/' indexdata_ko_dict_invis.cxx indexdata_ko_dict.cxx /usr/bin/genbrk -r dict_word_he.txt.p -o dict_word_he.brk /usr/bin/genbrk -r char.txt.p -o char.brk sed 's/\(^.*get_\)/SAL_DLLPUBLIC_EXPORT \1/' zh_zhuyin_invis.cxx zh_zhuyin.cxx createRuleBasedBreakIterator: ICU Error U_BRK_RULE_EMPTY_SET at line 19, column 16 make[3]: *** [char.brk] Error 11 make[3]: *** Waiting for unfinished jobs Do we have a fix for this? -Andy ArchLinux ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
