core.git: test/qa

2024-02-15 Thread Noel Grandin (via logerrit)
 test/qa/cppunit/dialog.cxx |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit 79eb7a29ab5d37e2a96ec2b4066edb66b5d5feda
Author: Noel Grandin 
AuthorDate: Thu Feb 15 19:52:00 2024 +0200
Commit: Noel Grandin 
CommitDate: Thu Feb 15 20:45:32 2024 +0100

disable CppunitTest_test_a11y on Windows

keeps crashing on the Windows jenkins boxes

Change-Id: I80415432dab9a2967c9a85fcf89f3840eecc91e9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163454
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/test/qa/cppunit/dialog.cxx b/test/qa/cppunit/dialog.cxx
index eb6996fa68f4..f5f861371443 100644
--- a/test/qa/cppunit/dialog.cxx
+++ b/test/qa/cppunit/dialog.cxx
@@ -10,7 +10,8 @@
 #include 
 
 // FIXME: dialog API doesn't work on macos yet
-#if !defined(MACOSX)
+// and this test crashes on some jenkins Windows boxes
+#if !defined(MACOSX) && !defined(_WIN32)
 
 /* Checks an unexpected dialog opening (instead of the expected one) is 
properly caught, as it would
  * otherwise block the test potentially indefinitely */


[Libreoffice-commits] core.git: test/qa test/source testtools/IwyuFilter_testtools.yaml testtools/source toolkit/inc toolkit/IwyuFilter_toolkit.yaml toolkit/qa toolkit/source tools/IwyuFilter_tools.ya

2022-04-02 Thread Gabor Kelemen (via logerrit)
 test/qa/cppunit/test_xpath.cxx  |5 ++-
 test/source/diff/diff.cxx   |3 --
 testtools/IwyuFilter_testtools.yaml |   17 
 testtools/source/bridgetest/bridgetest.cxx  |3 --
 testtools/source/bridgetest/constructors.cxx|3 --
 testtools/source/bridgetest/cppobj.cxx  |2 -
 testtools/source/bridgetest/currentcontextchecker.cxx   |2 -
 testtools/source/bridgetest/currentcontextchecker.hxx   |1 
 testtools/source/bridgetest/multi.cxx   |1 
 testtools/source/bridgetest/multi.hxx   |1 
 toolkit/IwyuFilter_toolkit.yaml |   14 +
 toolkit/inc/awt/animatedimagespeer.hxx  |2 -
 toolkit/inc/awt/vclxbitmap.hxx  |1 
 toolkit/inc/awt/vclxgraphics.hxx|2 -
 toolkit/inc/awt/vclxregion.hxx  |1 
 toolkit/inc/awt/vclxwindows.hxx |1 
 toolkit/inc/controls/accessiblecontrolcontext.hxx   |2 -
 toolkit/inc/controls/animatedimages.hxx |1 
 toolkit/inc/controls/controlmodelcontainerbase.hxx  |1 
 toolkit/inc/helper/msgbox.hxx   |1 
 toolkit/inc/helper/servicenames.hxx |2 -
 toolkit/inc/helper/unopropertyarrayhelper.hxx   |1 
 toolkit/qa/cppunit/EventContainer.cxx   |2 -
 toolkit/source/awt/animatedimagespeer.cxx   |1 
 toolkit/source/awt/stylesettings.hxx|2 -
 toolkit/source/awt/vclxbitmap.cxx   |2 -
 toolkit/source/awt/vclxdevice.cxx   |4 --
 toolkit/source/awt/vclxfont.cxx |2 -
 toolkit/source/awt/vclxgraphics.cxx |2 -
 toolkit/source/awt/vclxmenu.cxx |2 -
 toolkit/source/awt/vclxprinter.cxx  |2 -
 toolkit/source/awt/vclxregion.cxx   |2 -
 toolkit/source/awt/vclxwindows.cxx  |3 --
 toolkit/source/controls/dialogcontrol.cxx   |1 
 toolkit/source/controls/filectrl.cxx|1 
 toolkit/source/controls/formattedcontrol.cxx|1 
 toolkit/source/controls/grid/defaultgridcolumnmodel.cxx |1 
 toolkit/source/controls/roadmapcontrol.cxx  |1 
 toolkit/source/controls/stdtabcontroller.cxx|1 
 toolkit/source/controls/stdtabcontrollermodel.cxx   |1 
 toolkit/source/controls/tkscrollbar.cxx |2 -
 toolkit/source/controls/unocontrolcontainermodel.cxx|1 
 toolkit/source/controls/unocontrols.cxx |2 -
 toolkit/source/hatchwindow/documentcloser.cxx   |1 
 toolkit/source/hatchwindow/hatchwindowfactory.cxx   |1 
 toolkit/source/helper/formpdfexport.cxx |1 
 toolkit/source/helper/servicenames.cxx  |1 
 toolkit/source/helper/unowrapper.cxx|2 -
 tools/IwyuFilter_tools.yaml |   14 +++--
 tools/qa/cppunit/test_100mm2twips.cxx   |1 
 tools/qa/cppunit/test_cpu_runtime_detection_AVX2.cxx|3 --
 tools/qa/cppunit/test_cpu_runtime_detection_SSE2.cxx|4 --
 tools/qa/cppunit/test_cpu_runtime_detection_SSE2_check.cxx  |1 
 tools/qa/cppunit/test_cpu_runtime_detection_SSSE3.cxx   |4 --
 tools/qa/cppunit/test_cpu_runtime_detection_SSSE3_check.cxx |1 
 tools/qa/cppunit/test_cpuid.cxx |1 
 tools/qa/cppunit/test_json_writer.cxx   |3 --
 tools/qa/cppunit/test_xmlwriter.cxx |1 
 tools/source/debug/debug.cxx|3 --
 tools/source/generic/fract.cxx  |1 
 tools/source/generic/gen.cxx|6 +---
 tools/source/generic/point.cxx  |1 
 tools/source/generic/poly.cxx   |2 -
 tools/source/inet/inetstrm.cxx  |1 
 tools/source/misc/json_writer.cxx   |1 
 65 files changed, 51 insertions(+), 106 deletions(-)

New commits:
commit 52ef78f4923283e6e52d575bec81985b031cb30b
Author: Gabor Kelemen 
AuthorDate: Thu Mar 31 23:57:29 2022 +0200
Commit: Thorsten Behrens 
CommitDate: Sat Apr 2 23:32:08 2022 +0200

Recheck modules t* with IWYU

See tdf#42949 for motivation

Change-Id: I109fa07d52721fd10354de07a2ed995ffa2f27c5
Reviewed-on: https://gerrit.libreoffice.org

[Libreoffice-commits] core.git: test/qa test/source

2021-07-14 Thread Mike Kaganski (via logerrit)
 test/qa/cppunit/test_xpath.cxx |3 +++
 test/source/xmltesttools.cxx   |4 ++--
 2 files changed, 5 insertions(+), 2 deletions(-)

New commits:
commit 798d19c80853166042ce8a14edf4a25cd491d6aa
Author: Mike Kaganski 
AuthorDate: Thu Jul 15 00:03:13 2021 +0200
Commit: Mike Kaganski 
CommitDate: Thu Jul 15 08:01:29 2021 +0200

Fix UB calling operator<<(std::basic_ostream) with nullptr

This resulted in segfault instead of a useful test failure message.
Was this way ever since 548b360c0e4693aac0cbdd2fcc1aab433fc54010,
and before in 6e31cbb4eaea3c6600248ba59a22853acc1d6606 and
9791453283407a0a129a71767a290058ac759da2.

Change-Id: I498d1c84a4eaf3e8180dedd67d1176cf6f8c1a60
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118916
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/test/qa/cppunit/test_xpath.cxx b/test/qa/cppunit/test_xpath.cxx
index 12852fc7dc6e..87d6a7ac177e 100644
--- a/test/qa/cppunit/test_xpath.cxx
+++ b/test/qa/cppunit/test_xpath.cxx
@@ -35,6 +35,9 @@ CPPUNIT_TEST_FIXTURE(TestXPath, test_getXPath)
 CPPUNIT_ASSERT_EQUAL(OUString("val"), getXPath(pTable, "/xml/item", 
"attrib"));
 // Trying to get position of missing child of a node must fail assertion
 CPPUNIT_ASSERT_ASSERTION_FAIL(getXPathPosition(pTable, "/xml/item", 
"absent"));
+// Asserting that an attribute is absent
+CPPUNIT_ASSERT_ASSERTION_FAIL(assertXPathNoAttribute(pTable, "/xml/item", 
"attrib"));
+CPPUNIT_ASSERT_ASSERTION_PASS(assertXPathNoAttribute(pTable, "/xml/item", 
"foo"));
 }
 
 CPPUNIT_PLUGIN_IMPLEMENT();
diff --git a/test/source/xmltesttools.cxx b/test/source/xmltesttools.cxx
index 12aed37f18e0..f92c380d9bf8 100644
--- a/test/source/xmltesttools.cxx
+++ b/test/source/xmltesttools.cxx
@@ -247,8 +247,8 @@ void XmlTestTools::assertXPathNoAttribute(const 
xmlDocUniquePtr& pXmlDoc, const
 CPPUNIT_ASSERT_EQUAL_MESSAGE(OString(OString::Concat("In <") + 
pXmlDoc->name + ">, XPath '" + rXPath + "' number of nodes is 
incorrect").getStr(),
  1, xmlXPathNodeSetGetLength(pXmlNodes));
 xmlNodePtr pXmlNode = pXmlNodes->nodeTab[0];
-CPPUNIT_ASSERT_EQUAL_MESSAGE(OString(OString::Concat("In <") + 
pXmlDoc->name + ">, XPath '" + rXPath + "' unexpected '" + rAttribute + "' 
attribute").getStr(),
- static_cast(nullptr), 
xmlGetProp(pXmlNode, BAD_CAST(rAttribute.getStr(;
+CPPUNIT_ASSERT_MESSAGE(OString(OString::Concat("In <") + pXmlDoc->name + 
">, XPath '" + rXPath + "' unexpected '" + rAttribute + "' attribute").getStr(),
+ !xmlGetProp(pXmlNode, 
BAD_CAST(rAttribute.getStr(;
 xmlXPathFreeObject(pXmlObj);
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits