[Libreoffice] OString += OString + char ... ?
Hullo List, I hope this isn't a silly question, but I'm a little confused by a current behavior of the O*String classes, and wondering if it's A) known, and B) expected. Please consider this code snippet: - using ::rtl::OString; OString a( My Test String: ); OString b( Gobble Wobble ); OSL_TRACE( \n\n ); OSL_TRACE( a : %s, a.getStr() ); OSL_TRACE( b : %s, b.getStr() ); a += b; OSL_TRACE( a+b: %s, a.getStr() ); // a += '\n'; Does not work. Should it? a += b + '\n'; // This is the suspect line OSL_TRACE( a+n: %s, a.getStr() ); /* OUTPUT: Thread: 10 :a : My Test String: Thread: 10 :b : Gobble Wobble Thread: 10 :a+b: My Test String: Gobble Wobble Thread: 10 :a+n: My Test String: Gobble Wobbleble */ - The a+b line is as expected, but adding a newline single character seems to break. I expected to receive this: a+n: My Test String: Gobble WobbleGobbleWobble (Note the newline at the end, and repeated Gobble Wobble bit.) Is that + operator expected to work with an O*String and a single character? From analysis with Sébastien Le Ray, it looks like what's happening is that the b OString is converted to sal_Char *, and the compiler uses int( '\n' ) (=10) for the + operator. So, the pointer of Gobble Wobble is moved to ble before the += operator takes over. Changing the suspect line to a += b + \n; gives me the results I was originally expecting. (double quotes for the single quotes '). Is this expected behavior? It's admittedly a corner case, but I'm wondering if the is a bug in the API. Cheers, Kevin P.S. I'm aware that I should be using O*StringBuffer for concatenation, but that doesn't detract from this issue. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Compilation failed in libs-gui/toolkit
Hello,
I've got a compilation error in libs-gui/toolkit.
Entering /home/maryline/compile-libreoffice/libo/toolkit/uiconfig/layout
dmake: Warning: -- Found file corresponding to virtual target
[message-box.xml].
dmake: Warning: -- Found file corresponding to virtual target
[tab-dialog.xml].
mkdir: cannot create directory `../../unxlngi6.pro/lib/en-US/': File exists
../../unxlngi6.pro/lib/en-US/%.xml: %.xml
:
LD_LIBRARY_PATH=${LD_LIBRARY_PATH+${LD_LIBRARY_PATH}:}/home/maryline/compile-libreoffice/libo/solver/330/unxlngi6.pro/lib
tralay -m localize.sdf -o ../../unxlngi6.pro/lib -l en-US
message-box.xml
/bin/bash: tralay: command not found
dmake: Error code 127, while making
'../../unxlngi6.pro/lib/en-US/message-box.xml'
Forcing regeneration of dependency info
dmake: Warning: -- Found file corresponding to virtual target
[message-box.xml].
dmake: Warning: -- Found file corresponding to virtual target
[tab-dialog.xml].
mkdir: cannot create directory `../../unxlngi6.pro/lib/en-US/': File exists
../../unxlngi6.pro/lib/en-US/%.xml: %.xml
:
LD_LIBRARY_PATH=${LD_LIBRARY_PATH+${LD_LIBRARY_PATH}:}/home/maryline/compile-libreoffice/libo/solver/330/unxlngi6.pro/lib
tralay -m localize.sdf -o ../../unxlngi6.pro/lib -l en-US
message-box.xml
/bin/bash: tralay: command not found
dmake: Error code 127, while making
'../../unxlngi6.pro/lib/en-US/message-box.xml'
Retrying /home/maryline/compile-libreoffice/libo/toolkit/uiconfig/layout
dmake: Warning: -- Found file corresponding to virtual target
[message-box.xml].
dmake: Warning: -- Found file corresponding to virtual target
[tab-dialog.xml].
mkdir: cannot create directory `../../unxlngi6.pro/lib/en-US/': File exists
../../unxlngi6.pro/lib/en-US/%.xml: %.xml
:
LD_LIBRARY_PATH=${LD_LIBRARY_PATH+${LD_LIBRARY_PATH}:}/home/maryline/compile-libreoffice/libo/solver/330/unxlngi6.pro/lib
tralay -m localize.sdf -o ../../unxlngi6.pro/lib -l en-US
message-box.xml
/bin/bash: tralay: command not found
dmake: Error code 127, while making
'../../unxlngi6.pro/lib/en-US/message-box.xml'
Here are my autogen parameters :
'--enable-ext-barcode' '--enable-ext-diagram'
'--enable-ext-google-docs--enable-ext-hunart' '--enable-ext-lightproof'
'--enable-ext-lightproof' '--enable-ext-mysql-connector'
'--enable-ext-nlpsolver' '--enable-ext-numbertext'
'--enable-ext-oooblogger' '--enable-ext-pdfimport'
'--enable-ext-presenter-console' '--enable-ext-presenter-minimizer'
'--enable-ext-presenter-ui' '--enable-ext-report-builder'
'--enable-ext-scripting-beanshell' '--enable-ext-scripting-javascript'
'--enable-ext-scripting-python' '--enable-ext-typo'
'--enable-ext-validator' '--enable-ext-watch-window'
'--enable-ext-wiki-publisher' '--enable-graphite' '--enable-evolution2'
'--enable-epm' '--enable-dbus' '--enable-gio' '--enable-layout'
'--enable-kde4' '--enable-binfilter' '--enable-extra-gallery'
'--enable-extra-template' '--enable-extra-sample' '--enable-extra-font'
'--with-system-mysql' '--disable-gnome-vfs'
(Debian testing, x86 32, gcc 4.4.5)
Julien.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] Remove deprecated list container for sw.
More list cleaning for writer. 0001-Remove-deprecated-List-for-std-vector-String.writer.patch Description: Binary data 0002-Change-deprecated-List-for-std-vector-Stri.libs-core.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] Remove deprecated list container.
More list container cleaning. 0001-Remove-SvULongs-and-replace-it-with-std-ve.libs-core.patch Description: Binary data 0001-Remove-deprecated-container-List-and-update.libs-gui.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] bug 34647
Le 27/02/2011 07:59, Jean-Baptiste Faure a écrit : Hi, I fixed bug 34647 : Load/Save General option : room for a FR string https://bugs.freedesktop.org/show_bug.cgi?id=34647 My patch is attached to the bug report and is under the LGPLv3+/MPL dual license. Sorry, the link goes to the wrong bug report if you click it (34498 instead of 34647) The correct one is https://bugs.freedesktop.org/show_bug.cgi?id=34647 Have a nice day JBF -- Seuls des formats ouverts peuvent assurer la pérennité de vos documents. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH][WIP] fdo#31251 - Improve default page layout
Hi list,
Attached is a patch that improves Writer page as described in
fdo#31251[1]. After a quick poll on various LibreOffice user it appears
that a halo on the four borders is confusing so we have a smooth shadow
on two borders.
There are still some little glitches and book mode is not fully handled
but I'd rather post the patch before Murphy's Law crashes my disk or
burn my house and to get comments before going .
If you want to do an incremental build, you'll have to build and
deliver sw and then run packimages (cd packimages build), if all is
fine images should end up in images.zip.
Sébastien
[1] https://bugs.freedesktop.org/show_bug.cgi?id=31251
From 56bceaec5cef9593f23219b6d257e8073ec34426 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?S=C3=A9bastien=20Le=20Ray?= sebastien-libreoff...@orniz.org
Date: Sun, 27 Feb 2011 18:06:13 +0100
Subject: [PATCH] Added shadow images.
---
default_images/sw/res/page-bottom-shadow.png | Bin 0 - 193 bytes
default_images/sw/res/page-bottomleft-shadow.png | Bin 0 - 285 bytes
default_images/sw/res/page-bottomright-shadow.png | Bin 0 - 289 bytes
default_images/sw/res/page-right-shadow.png | Bin 0 - 191 bytes
default_images/sw/res/page-topright-shadow.png| Bin 0 - 306 bytes
5 files changed, 0 insertions(+), 0 deletions(-)
create mode 100644 default_images/sw/res/page-bottom-shadow.png
create mode 100644 default_images/sw/res/page-bottomleft-shadow.png
create mode 100644 default_images/sw/res/page-bottomright-shadow.png
create mode 100644 default_images/sw/res/page-right-shadow.png
create mode 100644 default_images/sw/res/page-topright-shadow.png
diff --git a/default_images/sw/res/page-bottom-shadow.png b/default_images/sw/res/page-bottom-shadow.png
new file mode 100644
index ..fe881a97cc14556d3da978024cbff78912d9c1f6
GIT binary patch
literal 193
zcmeAS@N?(olHy`uVBq!ia0vp^j6lrA!3HEtFPV6O1d4;)ofy`glX(f`uqAoByDC*
z!3BGlPXx`7I;J!Gca%qgD@k*tT_@uLG}_)Usv|qOwv5Ef(_TEPz6iC9V-AiT2y
zsd*~PAz-C8;S2(VZJ3hti10pX2;y^_*o-U3d9M_X~)cpNZug1pK_S}buhv)o*
dBgJ!)7y`CFFSDR?joQ%22WQ%mvv4FO#nZmHPrwB
literal 0
HcmV?d1
diff --git a/default_images/sw/res/page-bottomleft-shadow.png b/default_images/sw/res/page-bottomleft-shadow.png
new file mode 100644
index ..9e4a72b1acacb82f99f323cdaf415f39f6cf4774
GIT binary patch
literal 285
zcmeAS@N?(olHy`uVBq!ia0vp^AT}2V86ZZI=f4F%}28J29*~C-V}VN3FMcVYMs
zf(!O8p9~b?EbxddW?kJ24O~qS#uSg6t)pzOL-InWTB7S!Zr$J`5C^*?YcB5}F
z{OPy4m=JQjSWm3V6A%C;tCGUuV+^^^)+FS^@J~U1bCtvtFK(`hDu#l3gpk)-)Ma
zRPYxZjMtxEEwkZZ`Z2-f8tCp*BD+qR^E3^??sE|Jf~ZVolCpkMehMFTOIbsNG_
zK2+_h)2xad)Uuw7d@Q-3^*a-3)VjFP0X?)4}B-uE+f@_MIqu7b0x{^*3_{9LzP
ZOgjP$+h*;pA+a%22WQ%mvv4FO#mOpXPsR
literal 0
HcmV?d1
diff --git a/default_images/sw/res/page-bottomright-shadow.png b/default_images/sw/res/page-bottomright-shadow.png
new file mode 100644
index ..ff00470bc5f24ee6ede99cbc892430cb9cbea8c9
GIT binary patch
literal 289
zcmeAS@N?(olHy`uVBq!ia0vp^AT}2V86ZZI=f4F%}28J29*~C-V}VN3FMcVYMs
zf(!O8p9~b?EbxddW?kJ24O~qS#uSg6t)pzOL-InWTB7v}5Y*eSty?JzX3_BreBZ
zu+BSdAkgyAzfpgQ|r64iU{7=H=cgo*Q-C`$go~+QcL#DEz-Gx#^e1{`WtQJWbsz
zbN=3@p9h(_!*VXhm3Uoe4)2*^;J*K2;iqcb~`@dyrnNiUYm*^_6xU_Zfj6p7G7{H
z!dAJY^HOrot8e$KxGhpIiQa!PYuDR_4b^fb{`5L_b=)CIJ+_3Hs@vIlMN8zg7F
dDl1%J-z5}XI;H;3ZPdJYD@);T3K0RYisYEb|H
literal 0
HcmV?d1
diff --git a/default_images/sw/res/page-right-shadow.png b/default_images/sw/res/page-right-shadow.png
new file mode 100644
index ..7b8870ed042f72bb7da4e0c6abcc1930b778cb0f
GIT binary patch
literal 191
zcmeAS@N?(olHy`uVBq!ia0vp^AT}ch82ed)xHkIDGqXXVpw-h|UBBmgMd3!tfsi
z7wla=87RV8;1OBOz`!jG!i)^F=12eq*-JcqUDClN%P2%ck|0SZZ$xJHyX=jZ08
z=9Mrw7o{eaq^2m8XO?6rxO@5rgg5eu0~JYmx;Tb#TuIp^Y3Z8(Z6R9v+_a3w~Id
a*)i}JaZe36ll2Cuiowt;ucLK6Tx@?;%
literal 0
HcmV?d1
diff --git a/default_images/sw/res/page-topright-shadow.png b/default_images/sw/res/page-topright-shadow.png
new file mode 100644
index ..2603731527826eb1143d6191c4e27950b0d67d81
GIT binary patch
literal 306
zcmeAS@N?(olHy`uVBq!ia0vp^AT}2V86ZZI=f4F%}28J29*~C-V}VN3FMcVYMs
zf(!O8p9~b?EbxddW?kJ24O~qS#uSg6t)pzOL-InWTB7g%!lO#%vS@^owk+Xt
z-Zt-0fPm}6^LO++yfUWC~aou;`+9qLtJl9rv|G4M_+TWfwJPflG*0y3luV0Zc
ze9-c^YOCa(Jwm5FWFxo4elFtnOR{(*Tf-@yUe$B{nxBwzk%bw~L`-z|D$9DY6g
z=K-1b6^FC4QXa=|$#qvdx-`?FKl!$4I}7`pKv9v0)m+crZJrp~raipEzM*@+g%MT
vWH0zLT=o#H`d)eF^3|m?FS#yu`N)6J*I4l5y#Ka9*E4v!`njxgN@xNA0Viz
literal 0
HcmV?d1
--
1.7.2.3
From bbcce6e250f5bafa61aac8ed099d47bc99a4f6cc Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?S=C3=A9bastien=20Le=20Ray?= sebastien-libreoff...@orniz.org
Date: Sun, 27 Feb 2011 17:23:48 +0100
Subject: [PATCH 1/2] FDO#31251 - Add resources files for page shadow
---
sw/inc/rcid.hrc |5
sw/source/core/inc/pagefrm.hrc| 49 +
sw/source/core/layout/makefile.mk |
[Libreoffice] Revert some changing from last commit
In a previous commit, OSL_ASSERT were changed into OSL_FAIL but 2 of them
created the build fail.
From 6a1c81ffb1bfdb5361cf885a89d29b8fcb362e2d Mon Sep 17 00:00:00 2001
From: Xisco Fauli aniste...@gmail.com
Date: Sun, 27 Feb 2011 21:12:58 +0100
Subject: [PATCH] Revert 2 OSL_FAIL
---
sfx2/source/doc/guisaveas.cxx |2 +-
sfx2/source/doc/objstor.cxx |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/sfx2/source/doc/guisaveas.cxx b/sfx2/source/doc/guisaveas.cxx
index 940e3e9..aa68646 100644
--- a/sfx2/source/doc/guisaveas.cxx
+++ b/sfx2/source/doc/guisaveas.cxx
@@ -230,7 +230,7 @@ public:
}
catch( uno::Exception )
{
-OSL_FAIL( Unexpected exception! );
+OSL_ASSERT( Unexpected exception! );
}
}
}
diff --git a/sfx2/source/doc/objstor.cxx b/sfx2/source/doc/objstor.cxx
index e6cb611..eb45ce0 100644
--- a/sfx2/source/doc/objstor.cxx
+++ b/sfx2/source/doc/objstor.cxx
@@ -1605,7 +1605,7 @@ sal_Bool SfxObjectShell::SaveTo_Impl
{
// it should not happen, the copies signature is invalid!
// throw the changes away
-OSL_FAIL( An invalid signature was copied! );
+OSL_ASSERT( An invalid signature was copied! );
}
}
}
--
1.7.1
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH 1/2] Translate german comments in gloshdl.cxx
This translates all german code comments in gloshdl.cxx to english.
This is contributed under the terms of the MPL 1.1 / GPLv3+ / LGPLv3+ triple
license.
---
sw/source/ui/dochdl/gloshdl.cxx | 75 +++
1 files changed, 37 insertions(+), 38 deletions(-)
diff --git a/sw/source/ui/dochdl/gloshdl.cxx b/sw/source/ui/dochdl/gloshdl.cxx
index ca39ce1..2673d23 100644
--- a/sw/source/ui/dochdl/gloshdl.cxx
+++ b/sw/source/ui/dochdl/gloshdl.cxx
@@ -48,15 +48,15 @@
#include fmtcol.hxx
#include docary.hxx
#include wrtsh.hxx
-#include uitool.hxx // Fehlermeldungen
+#include uitool.hxx // error messages
#include view.hxx
#include swevent.hxx
#include gloshdl.hxx
#include glosdoc.hxx
#include shellio.hxx
-#include swundo.hxx // fuer Undo-Ids
+#include swundo.hxx // for Undo-Ids
#include expfld.hxx
-#include initui.hxx // fuer
::GetGlossaries()
+#include initui.hxx // for ::GetGlossaries()
#include gloslst.hxx
#include swdtflvr.hxx
#include docsh.hxx
@@ -91,7 +91,7 @@ SV_IMPL_PTRARR( TextBlockInfoArr, TextBlockInfo_ImplPtr )
SV_IMPL_REF( SwDocShell )
/*
-Beschreibung: Dialog fuer Bearbeiten Vorlagen
+Description: Dialog for edit templates
*/
void SwGlossaryHdl::GlossaryDlg()
{
@@ -120,9 +120,8 @@ void SwGlossaryHdl::GlossaryDlg()
}
/*
-Beschreibung: Setzen der aktuellen Gruppe; falls aus dem Dialog
-gerufen, wird die Gruppe temp. erzeugt fuer einen
-schnelleren Zugriff
+Description: set the default group; if called from the dialog
+the group is created temporarily for faster access
*/
void SwGlossaryHdl::SetCurGroup(const String rGrp, BOOL bApi, BOOL
bAlwaysCreateNew )
{
@@ -158,7 +157,7 @@ void SwGlossaryHdl::SetCurGroup(const String rGrp, BOOL
bApi, BOOL bAlwaysCreat
bPathEqual = TRUE;
}
-// Beim Pfadwechsel kann man sich auf den Namen nicht verlassen
+// When path changed, the name is not reliable
if(!bAlwaysCreateNew bPathEqual)
return;
}
@@ -247,13 +246,13 @@ BOOL SwGlossaryHdl::CopyOrMove( const String
rSourceGroupName, String rSource
if(pDestGroup-IsReadOnly() || (bMove pSourceGroup-IsReadOnly()) )
return FALSE;
-//Der Index muss hier ermittelt werden, weil rSourceShortName in CopyBlock
evtl veraendert wird
+//The index must be determined here because rSourceShortName maybe changed
in CopyBlock
USHORT nDeleteIdx = pSourceGroup-GetIndex( rSourceShortName );
OSL_ENSURE(USHRT_MAX != nDeleteIdx, entry not found);
ULONG nRet = pSourceGroup-CopyBlock( *pDestGroup, rSourceShortName,
rLongName );
if(!nRet bMove)
{
-// der Index muss existieren
+// the index must be existing
nRet = pSourceGroup-Delete( nDeleteIdx ) ? 0 : 1;
}
rStatGlossaries.PutGroupDoc( pSourceGroup );
@@ -262,7 +261,7 @@ BOOL SwGlossaryHdl::CopyOrMove( const String
rSourceGroupName, String rSource
}
/*
-Beschreibung: Loeschen einer Textbausteindatei-Gruppe
+Description: delete a text block file-group
*/
BOOL SwGlossaryHdl::DelGroup(const String rGrpName)
{
@@ -283,7 +282,7 @@ BOOL SwGlossaryHdl::DelGroup(const String rGrpName)
}
/*
-Beschreibung: Anzahl Textbausteine erfragen
+Description: ask for number of text blocks
*/
USHORT SwGlossaryHdl::GetGlossaryCnt()
{
@@ -303,7 +302,7 @@ String SwGlossaryHdl::GetGlossaryShortName(USHORT nId)
}
/*
-Beschreibung: Kurzname erfragen
+Description: ask for short name
*/
String SwGlossaryHdl::GetGlossaryShortName(const String rName)
{
@@ -322,7 +321,7 @@ String SwGlossaryHdl::GetGlossaryShortName(const String
rName)
}
/*
- Beschreibung: Kuerzel fuer Textbaustein bereits verwendet?
+Description: abbreviation for text block already used?
*/
BOOL SwGlossaryHdl::HasShortName(const String rShortName) const
{
@@ -340,7 +339,7 @@
[Libreoffice] [PATCH 2/2] Translate german comments
This translates all remaining german code comments of
writer/sw/source/ui/dochdl to english.
This is contributed under the terms of the MPL 1.1 / GPLv3+ / LGPLv3+ triple
license.
---
sw/source/ui/dochdl/selglos.cxx |2 +-
sw/source/ui/dochdl/selglos.src |4 +-
sw/source/ui/dochdl/swdtflvr.cxx | 233 ++
3 files changed, 115 insertions(+), 124 deletions(-)
diff --git a/sw/source/ui/dochdl/selglos.cxx b/sw/source/ui/dochdl/selglos.cxx
index dc57690..c01644a 100644
--- a/sw/source/ui/dochdl/selglos.cxx
+++ b/sw/source/ui/dochdl/selglos.cxx
@@ -65,7 +65,7 @@ SwSelGlossaryDlg::SwSelGlossaryDlg(Window * pParent, const
String rShortName)
}
/*--
- dtor ueberladen
+ overcharge dtor
--*/
SwSelGlossaryDlg::~SwSelGlossaryDlg() {}
diff --git a/sw/source/ui/dochdl/selglos.src b/sw/source/ui/dochdl/selglos.src
index 8116251..9a5a425 100644
--- a/sw/source/ui/dochdl/selglos.src
+++ b/sw/source/ui/dochdl/selglos.src
@@ -37,7 +37,7 @@ ModalDialog DLG_SEL_GLOS
OutputSize = TRUE ;
SVLook = TRUE ;
Size = MAP_APPFONT ( 220 , 100 ) ;
-/* ### ACHTUNG: Neuer Text in Resource? AutoText einfügen : AutoText
einf³gen */
+/* ### ATTENTION: new text in resource? add AutoText : add AutoText */
Text [ en-US ] = Insert AutoText ;
Moveable = TRUE ;
OKButton BT_OK
@@ -63,7 +63,7 @@ ModalDialog DLG_SEL_GLOS
{
Pos = MAP_APPFONT ( 6 , 3 ) ;
Size = MAP_APPFONT ( 152 , 8 ) ;
-/* ### ACHTUNG: Neuer Text in Resource? AutoTexte zum Kürzel :
AutoTexte zum K³rzel */
+/* ### ATTENTION: new text in resource? AutoTexts to abbreviation :
AutoTexts to abbreviation */
Text [ en-US ] = AutoTexts for shortcut ;
};
ListBox LB_GLOS
diff --git a/sw/source/ui/dochdl/swdtflvr.cxx b/sw/source/ui/dochdl/swdtflvr.cxx
index 871ee66..6778699 100644
--- a/sw/source/ui/dochdl/swdtflvr.cxx
+++ b/sw/source/ui/dochdl/swdtflvr.cxx
@@ -103,7 +103,7 @@
#include docsh.hxx
#include wdocsh.hxx
#include fldbas.hxx //DDE
-#include swundo.hxx // fuer Undo-Ids
+#include swundo.hxx // for Undo-Ids
#include pam.hxx
#include ndole.hxx
#include swwait.hxx
@@ -268,7 +268,7 @@ SwTransferable::~SwTransferable()
{
Application::GetSolarMutex().acquire();
-// der DDELink braucht noch die WrtShell!
+// the DDELink still needs the WrtShell!
if( refDdeLink.Is() )
{
((SwTrnsfrDdeLink*)refDdeLink)-Disconnect( TRUE );
@@ -283,8 +283,8 @@ SwTransferable::~SwTransferable()
// dead.
delete pClpDocFac;
-//JP 22.04.95: erst schliessen, dann kann die Ref. auch gecleared werden,
-// so das die DocShell auch tatsaechlich geloescht
wird!
+//JP 22.04.95: first close, then the Ref. can be cleared as well, so that
+// the DocShell really gets deleted!
if( aDocShellRef.Is() )
{
SfxObjectShell * pObj = aDocShellRef;
@@ -346,8 +346,8 @@ void SwTransferable::AddSupportedFormats()
void SwTransferable::InitOle( SfxObjectShell* pDoc, SwDoc rDoc )
{
-//OleVisArea einstellen. Linke obere Ecke der Seite und Groesse
-//der RealSize in Twips.
+//set OleVisArea. Upper left corner of the page and size of
+//RealSize in Twips.
const Size aSz( OLESIZE );
SwRect aVis( Point( DOCUMENTBORDER, DOCUMENTBORDER ), aSz );
pDoc-SetVisArea( aVis.SVRect() );
@@ -411,7 +411,7 @@ sal_Bool SwTransferable::GetData( const DATA_FLAVOR
rFlavor )
{
SelectionType nSelectionType = pWrtShell-GetSelectionType();
-// SEL_GRF kommt vom ContentType der editsh
+// SEL_GRF comes from ContentType of editsh
if( (nsSelectionType::SEL_GRF | nsSelectionType::SEL_DRW_FORM)
nSelectionType )
{
pClpGraphic = new Graphic;
@@ -421,7 +421,7 @@ sal_Bool SwTransferable::GetData( const DATA_FLAVOR
rFlavor )
if( !pWrtShell-GetDrawObjGraphic( FORMAT_BITMAP, *pClpBitmap ))
pOrigGrf = pClpBitmap;
-// ist es ein URL-Button ?
+// is it an URL-Button ?
String sURL, sDesc;
if( pWrtShell-GetURLFromButton( sURL, sDesc ) )
{
@@ -434,10 +434,10 @@ sal_Bool SwTransferable::GetData( const DATA_FLAVOR
rFlavor )
SwDoc *const pTmpDoc = lcl_GetDoc(*pClpDocFac);
pTmpDoc-SetRefForDocShell( boost::addressof(aDocShellRef) );
-pTmpDoc-LockExpFlds();// nie die Felder updaten - Text so
belassen
+pTmpDoc-LockExpFlds();// never update fields - leave text as
it is
pWrtShell-Copy( pTmpDoc );
-// es wurde in der CORE eine neu angelegt (OLE-Objekte kopiert!)
+// in CORE a new one was created (OLE-Objekte copied!)
if( aDocShellRef.Is() )
SwTransferable::InitOle( aDocShellRef, *pTmpDoc );
Re: [Libreoffice] [PUSHED] Re: [PATCH] bug 34498
2011.02.22. 14:59 keltezéssel, Jan Holesovsky írta: Hi Jean-Baptiste, On 2011-02-20 at 17:00 +0100, Jean-Baptiste Faure wrote: I fixed bug 34498 : Checkbox label truncated when translated in French https://bugs.freedesktop.org/show_bug.cgi?id=34498 My patch attached to the bug report is under the LGPLv3+/MPL dual license. Pushed, thank you for that! :-) Andras - do you think worth cherry-picking for libreoffice-3-3? Can you do it, please (I suppose without the string change that adds '~' though). I accidentally pushed it with the '~'. It does not break existing localizations, though. Cheers, Andras ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Missing parts in Print dialog of Calc when translation is not complete
2011.02.19. 0:39 keltezéssel, Andras Timar írta: Hi, Can you please check this bug: https://bugs.freedesktop.org/show_bug.cgi?id=33189 If it is not easy to fix, I'll work-around it for 3.3.2. OOo also has this bug, reported at http://www.openoffice.org/issues/show_bug.cgi?id=115999 (no sign of developer activity there). I found a bug in l10ntools/source/export.cxx. When I fixed it and compared the generated resource files with the saved old resource files I found tons of l10n fixes because of the re-enabled language fallback mechanism. Unfortunately I cannot push this fix, because it triggered another bug. See all details in the bug report. Any help is appreciated. https://bugs.freedesktop.org/show_bug.cgi?id=33189 Best regards, Andras ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] Code cleanliness
Hi, Please find attached 2 patches in base/ which clean useless comments up. Regards, Guillaume (still under LGPLv3+/MPL) ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Code cleanliness
Better with files attached :) 2011/2/27 Guillaume Poussel gpous...@gmail.com: Hi, Please find attached 2 patches in base/ which clean useless comments up. Regards, Guillaume (still under LGPLv3+/MPL) 0001-Remove-date-comments-in-base.patch Description: Binary data 0002-Remove-bogus-comments.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] Remove bogus comments
Hi, Here's a patch who removes bogus comments. It's realeased under LGPLv3+ / MPL. I also have a question: do we need to remove the lines @author OD? Antoine 0001-Remove-bogus-comments.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] OpenSuse 11-4-rc2 claiims LibreOffice has minor bugs
We just had this posted on the Marketing list. I am not sure if this is true. Can anyone comment on this? Are there reports of loss of data? I am not sure if this is the official news blog for OpenSuse. = http://news.opensuse.org/2011/02/26/opensuse-11-4-rc2-steps-out/ The transition from OpenOffice.org to LibreOffice still has a few minor documentation blips but more importantly, users should be cautious. The raft of new functionality has created a few specific issues, such as loss of data in tables. Though not quite ready for the production environment, user feedback is critical for smoothing performance and reliability. == Cheers Marc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Joseph Taylor - Attn: Purchasing
Greetings, We are having a special on a selection ofcustom imprintedpens below. My name is Joseph Taylor and I would like to talk to the person who handles the marketing. Please letme know if you would like toreceive samples.I can also provide a virtualimage showing your logo on any item. If you would like a catalog mail to you please let us know which one. 1: Corporate Products Catalog2: Green Products Catalog3: Trade Show Products Catalog4: Ceramic Mugs Catalog5: Calendars Catalog Sincerely,Joseph Taylor WLC PROMOTIONS1012 West Beverly Blvd.Montebello, CA 90640 Office 626.692.7198 Phone 562.443.1367 Fax 206.350.5967 Confidentiality, Privacy, and Security Notice:The content, materials, and accompanying attachment(s) containedwithin any eMail (electronic mail transmission) is intended solelyfor the individual or entity to which it is addressed [authorizedrecipient(s)] which may be confidential, exempt from disclosureunder the Electronic Communications Privacy Act, and/or legallyprivileged. The message facilitates a previous agreement of thetransaction/service of a transactional relationship for whichthe intended recipient explicitly has double confirmed agreementto be contacted and informed in an ongoing capacity. If you arenot the intended recipient(s), responsible for delivering partiallyor in full any transmission to the intended recipient(s), and/or have received the transmission in error, you are hereby notifiedyou are strictly prohibited from reading, copying, printing,distributing and/or disclosing any of the content, materials, andaccompanying attachment(s) contained within. If you have receivedany portion of the transmission in error, please notify theoriginal sender by forwarding all transmissions tocompanyp...@gmx.com and delete the original along with allcopies of the transmission to include any accompanying attachment(s). Any views, commentary, and/or opinions presented within aresolely those of the author(s) and do not necessarily representthose of any other company(s) or parent entity(s).At anytime you may stop further transactional communications byletting us know by emailing us at unsubscribeyourem...@gmx.us and you will no longer receive communications from us.This advertisement is in complete Compliance with the FEDERAL CANSPAM ACT of 2003. You may unsubscribe at anytime by simply clicking hereUnsubscribe me from this list within the email.To Report SPAM ABUSE Please Email The Hosting Company At: ab...@unitedhostingservers.com http://www.unitedhostingservers.com/spam.html ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Remove deprecated list container.[PUSHED]
On Feb 27, 2011, at 8:38 AM, Rafael Dominguez wrote: More list container cleaning. 0001-Remove-SvULongs-and-replace-it-with-std-ve.libs-core.patch0001-Remove-deprecated-container-List-and-update.libs-gui.patch ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Remove deprecated list in svx/clonelist.hxx[PUSHED]
On Feb 27, 2011, at 1:56 PM, Rafael Dominguez wrote: 0001-Remove-deprecated-container-list-for-std-vector.patch ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
