RE: [PATCH]bug 44516 improved label and business card document creation
Norbert Thiebaud wrote (27 februari 2012 08:26) With hindsight it would probably have been better to make a constant for this colour. It is not good practice to leave such colour definitions in the code. yes, my point exactly :-) It is not too late to do the 'Right Thing'(tm) including in master. Have made proper code, am testing now and will submit when ok (may take a day or so beacuse of other running modifications). I hope my explanations will help you. I not, please say so. ... In order for _me_ to sign-off for 3.5 branch, I would need you to break your patch along the lines discussed earlier... But hey, maybe someone else will review and sign-off as is... If you can't reformat with diff + sed magic, I certainly can't. I am quite bad at magic tricks :-) I'll wait for a proper diff/sed magician to announce him/herself, or as you say, maybe someone else will review and sign-off as is. Anyway, your comment will make my future contributions better; thank you. Winfried ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Most elegant way to disable all BASIC functionality?
The 'disabling' of interpreter is not technically inherent to IOS, nor is it necessarily the only platform concerned by it. Indeed; 4c737b647078f35a2435e27d9f7f94039db9d6c3 --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Replace getLength() with isEmpty() where appropriate
Hi,
some more getLength() - isEmpty() replacements. Would be nice if
someone could review the patch.
Christina
From c77cd19f5ebbd2fffc5a44886b5f22abc87d78c7 Mon Sep 17 00:00:00 2001
From: Christina Rossmanith chrrossman...@web.de
Date: Tue, 21 Feb 2012 20:57:21 +0100
Subject: [PATCH] Replace getLength() with isEmpty() where appropriate
---
vcl/aqua/source/app/salinst.cxx |6 +++---
vcl/aqua/source/app/salsys.cxx |4 ++--
vcl/aqua/source/dtrans/HtmlFmtFlt.cxx |4 ++--
vcl/aqua/source/dtrans/PictToBmpFlt.cxx |4 ++--
vcl/source/gdi/pdfwriter_impl.cxx |5 ++---
vcl/source/gdi/print3.cxx |2 +-
6 files changed, 12 insertions(+), 13 deletions(-)
diff --git a/vcl/aqua/source/app/salinst.cxx b/vcl/aqua/source/app/salinst.cxx
index 7a01b0b..794dd84 100644
--- a/vcl/aqua/source/app/salinst.cxx
+++ b/vcl/aqua/source/app/salinst.cxx
@@ -997,7 +997,7 @@ rtl::OUString AquaSalInstance::GetDefaultPrinter()
// #i113170# may not be the main thread if called from UNO API
SalData::ensureThreadAutoreleasePool();
-if( ! maDefaultPrinter.getLength() )
+if( maDefaultPrinter.isEmpty() )
{
NSPrintInfo* pPI = [NSPrintInfo sharedPrintInfo];
DBG_ASSERT( pPI, no print info );
@@ -1138,10 +1138,10 @@ void AquaSalInstance::AddToRecentDocumentList(const rtl::OUString rFileUrl, con
{
// Convert file URL for external use (see above)
rtl::OUString externalUrl = translateToExternalUrl(rFileUrl);
-if( 0 == externalUrl.getLength() )
+if( externalUrl.isEmpty() )
externalUrl = rFileUrl;
-if( externalUrl.getLength() !isDangerousUrl( externalUrl ) )
+if( !externalUrl.isEmpty() !isDangerousUrl( externalUrl ) )
{
NSString* pString = CreateNSString( externalUrl );
NSURL* pURL = [NSURL URLWithString: pString];
diff --git a/vcl/aqua/source/app/salsys.cxx b/vcl/aqua/source/app/salsys.cxx
index 8a371d6..7c6f683 100644
--- a/vcl/aqua/source/app/salsys.cxx
+++ b/vcl/aqua/source/app/salsys.cxx
@@ -109,7 +109,7 @@ rtl::OUString AquaSalSystem::GetDisplayScreenName( unsigned int nScreen )
static NSString* getStandardString( int nButtonId )
{
rtl::OUString aText( Button::GetStandardText( nButtonId ) );
-if( ! aText.getLength() ) // this is for bad cases, we might be missing the vcl resource
+if( aText.isEmpty() ) // this is for bad cases, we might be missing the vcl resource
{
switch( nButtonId )
{
@@ -121,7 +121,7 @@ static NSString* getStandardString( int nButtonId )
case BUTTON_NO :aText = rtl::OUString( RTL_CONSTASCII_USTRINGPARAM( No ) );break;
}
}
-return aText.getLength() ? CreateNSString( aText) : nil;
+return aText.isEmpty() ? nil : CreateNSString( aText);
}
int AquaSalSystem::ShowNativeMessageBox( const rtl::OUString rTitle,
diff --git a/vcl/aqua/source/dtrans/HtmlFmtFlt.cxx b/vcl/aqua/source/dtrans/HtmlFmtFlt.cxx
index 0bd461d..275f5a1 100644
--- a/vcl/aqua/source/dtrans/HtmlFmtFlt.cxx
+++ b/vcl/aqua/source/dtrans/HtmlFmtFlt.cxx
@@ -65,9 +65,9 @@ const std::string TAG_END_BODY = std::string(/BODY);
Sequencesal_Int8 SAL_CALL TextHtmlToHTMLFormat(Sequencesal_Int8 aTextHtml)
{
-OSL_ASSERT(aTextHtml.getLength() 0);
+OSL_ASSERT(!aTextHtml.isEmpty());
-if (!(aTextHtml.getLength() 0))
+if (aTextHtml.isEmpty())
return Sequencesal_Int8();
// fill the buffer with dummy values to calc the exact length
diff --git a/vcl/aqua/source/dtrans/PictToBmpFlt.cxx b/vcl/aqua/source/dtrans/PictToBmpFlt.cxx
index 3eb4fb8..4b3d371 100644
--- a/vcl/aqua/source/dtrans/PictToBmpFlt.cxx
+++ b/vcl/aqua/source/dtrans/PictToBmpFlt.cxx
@@ -161,7 +161,7 @@ bool ImageToBMP( com::sun::star::uno::Sequencesal_Int8 aPict,
{
aBmp.realloc( [pOut length] );
[pOut getBytes: aBmp.getArray() length: aBmp.getLength()];
-bResult = (aBmp.getLength() != 0);
+bResult = (!aBmp.isEmpty());
}
}
}
@@ -190,7 +190,7 @@ bool BMPToImage( com::sun::star::uno::Sequencesal_Int8 aBmp,
{
aPict.realloc( [pOut length] );
[pOut getBytes: aPict.getArray() length: aPict.getLength()];
-bResult = (aPict.getLength() != 0);
+bResult = (!aPict.isEmpty());
}
}
}
diff --git a/vcl/source/gdi/pdfwriter_impl.cxx b/vcl/source/gdi/pdfwriter_impl.cxx
index 8456d86..3820d81 100644
--- a/vcl/source/gdi/pdfwriter_impl.cxx
+++ b/vcl/source/gdi/pdfwriter_impl.cxx
@@ -6698,11 +6698,10 @@ PDFStreamIf::~PDFStreamIf()
void SAL_CALL PDFStreamIf::writeBytes( const com::sun::star::uno::Sequence sal_Int8 aData ) throw()
{
-if( m_bWrite )
+if( m_bWrite aData.getLength() )
{
sal_Int32 nBytes = aData.getLength();
-if( nBytes 0 )
-m_pWriter-writeBuffer( aData.getConstArray(), nBytes );
+
Re: [Libreoffice-commits] .: Makefile
On 2/26/12 13:00 , Peter Foley wrote: Makefile |7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) New commits: commit a75873dea15719b5216cfd0476d30003ffc76e80 Author: Peter Foley pefol...@verizon.net Date: Sun Feb 26 13:53:09 2012 -0500 allow autogen.sh to be run automatically diff --git a/Makefile b/Makefile index a37bca3..68bea91 100644 --- a/Makefile +++ b/Makefile @@ -342,12 +342,15 @@ ifneq ($(filter-out clean distclean,$(MAKECMDGOALS)),) # restart since autogen can have changed # config_host.k which is included in this # Makefile -Makefile: config_host.mk +Makefile: $(SRCDIR)/config_host.mk why did you have to add $SRCDIR here ? Makefile has to be run in the top dir... and if not the dependencies below would not be found (config_host.mk.in for instance) Norbert touch $@ -config_host.mk : config_host.mk.in bin/repo-list.in ooo.lst.in configure.in autogen.lastrun +$(SRCDIR)/config_host.mk : config_host.mk.in bin/repo-list.in ooo.lst.in configure.in autogen.lastrun ./autogen.sh +autogen.lastrun: + @true + # # Fetch # ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Duplicate code: GlyphSet::DrawGlyphs() and GlyphSet::ImplDrawText()
Hi, the method GlyphSet::DrawGlyphs() is nearly a total subset of GlyphSet::ImplDrawText(). The only difference is the declaration of OString aGlyphSetName(GetGlyphSetName(*aSet)); -- DrawGlyphs() vs. OString aGlyphSetName(GetCharSetName(*aSet)); -- ImplDrawText() DrawGlyphs() is only rarely used. I'd suggest to add a parameter bUseGlyphSet to switch between the declarations of aGlyphSetName and replace the duplicate code in ImplDrawText() with a call to DrawGlyphs(). Or are there reasons for not adding an additional parameter to DrawGlyphs() ? You find the source code in vcl/generic/print/glyphset.cxx. Christina ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] 39468 Translate German comments
Hello,
git diff attached for comphelper directory. Sent this in last week but
looks like the message got flagged somehow.
This is my first submission; please let me know if I've done something
incorrectly!
-Tom Thorogood
(do you need GPL stuff for comments? If so: I'm submitting this under
the Gnu Public License--do whatever you want with it forever and ever).
diff --git a/comphelper/inc/comphelper/oslfile2streamwrap.hxx
b/comphelper/inc/comphelper/oslfile2streamwrap.hxx
index 6199ea5..754be72 100644
--- a/comphelper/inc/comphelper/oslfile2streamwrap.hxx
+++ b/comphelper/inc/comphelper/oslfile2streamwrap.hxx
@@ -42,7 +42,7 @@ namespace comphelper
//==
// FmUnoIOStream,
-// strem to read and write from data read from a file
+// stream zum schreiben un lesen von Daten, basieren auf File
//==
class COMPHELPER_DLLPUBLIC OSLInputStreamWrapper : public
::cppu::WeakImplHelper1stario::XInputStream
{
@@ -63,7 +63,7 @@ public:
//==
// FmUnoOutStream,
-// sync data for the files
+// Datensenke fuer Files
//==
class OSLOutputStreamWrapper : public
::cppu::WeakImplHelper1stario::XOutputStream
{
diff --git a/comphelper/source/container/container.cxx
b/comphelper/source/container/container.cxx
index 39ab7ba..7bf2f8f 100644
--- a/comphelper/source/container/container.cxx
+++ b/comphelper/source/container/container.cxx
@@ -51,9 +51,9 @@ IndexAccessIterator::~IndexAccessIterator() {}
::com::sun::star::uno::Reference ::com::sun::star::uno::XInterface
IndexAccessIterator::Next()
{
sal_Bool bCheckingStartingPoint = !m_xCurrentObject.is();
-// Is the current node the starting point ?
+// ist die aktuelle Node der Anfangspunkt ?
sal_Bool bAlreadyCheckedCurrent = m_xCurrentObject.is();
-// Have I already tested the current node through ShouldHandleElement ?
+// habe ich die aktuelle Node schon mal mittels ShouldHandleElement
testen ?
if (!m_xCurrentObject.is())
m_xCurrentObject = m_xStartingPoint;
@@ -62,7 +62,7 @@ IndexAccessIterator::~IndexAccessIterator() {}
sal_Bool bFoundSomething = sal_False;
while (!bFoundSomething bHasMoreToSearch)
{
-// Priming loop
+// pre-order-traversierung
if (!bAlreadyCheckedCurrent ShouldHandleElement(xSearchLoop))
{
m_xCurrentObject = xSearchLoop;
@@ -70,10 +70,10 @@ IndexAccessIterator::~IndexAccessIterator() {}
}
else
{
-// First, see if there's something below
+// zuerst absteigen, wenn moeglich
::com::sun::star::uno::Reference
::com::sun::star::container::XIndexAccess xContainerAccess(xSearchLoop,
::com::sun::star::uno::UNO_QUERY);
if (xContainerAccess.is() xContainerAccess-getCount()
ShouldStepInto(xContainerAccess))
-{
+{ // zum ersten Child
::com::sun::star::uno::Any
aElement(xContainerAccess-getByIndex(0));
xSearchLoop = *(::com::sun::star::uno::Reference
::com::sun::star::uno::XInterface*)aElement.getValue();
bCheckingStartingPoint = sal_False;
@@ -82,9 +82,9 @@ IndexAccessIterator::~IndexAccessIterator() {}
}
else
{
-// Otherwise, look above and to the right, if possible
+// dann nach oben und nach rechts, wenn moeglich
while (m_arrChildIndizies.size() 0)
-{ // If the list isn't empty and there's nothing above
+{ // (mein Stack ist nich leer, also kann ich noch nach oben
gehen)
::com::sun::star::uno::Reference
::com::sun::star::container::XChild xChild(xSearchLoop,
::com::sun::star::uno::UNO_QUERY);
OSL_ENSURE(xChild.is(), IndexAccessIterator::Next : a
content has no approriate interface !);
@@ -92,35 +92,36 @@ IndexAccessIterator::~IndexAccessIterator() {}
xContainerAccess = ::com::sun::star::uno::Reference
::com::sun::star::container::XIndexAccess(xParent,
::com::sun::star::uno::UNO_QUERY);
OSL_ENSURE(xContainerAccess.is(),
IndexAccessIterator::Next : a content has an invalid parent !);
-// Update the SearchLoop index
+// den Index, den SearchLoop in diesem Parent hatte, von
meinem 'Stack'
sal_Int32 nOldSearchChildIndex =
m_arrChildIndizies[m_arrChildIndizies.size() - 1];
m_arrChildIndizies.pop_back();
if (nOldSearchChildIndex xContainerAccess-getCount() -
1)
-{ // Search to the right in this row
+{ // auf dieser Ebene geht es noch nach rechts
Disabling Temporary Files?
Hello everybody,
I am working on something for which we want the document to stay in
memory, with no temp file on disk.
So far, we open the file as such:
com.sun.star.beans.PropertyValue[] args = new
com.sun.star.beans.PropertyValue[] {
new PropertyValue(ReadOnly, -1, true, PropertyState.DIRECT_VALUE),
new PropertyValue(Hidden, -1,true,PropertyState.DIRECT_VALUE),
new PropertyValue(Overwrite,-1,true,PropertyState.DIRECT_VALUE),
new PropertyValue(InputStream, 0,new
ByteArrayToXInputStreamAdapter(myData), PropertyState.DIRECT_VALUE),
};
xComponent = xLoader.loadComponentFromURL(private:stream,_self, 0,args);
And the result is that we have a temporary file in
C:\Users\meh\AppData|local\Temp\
Is there any PropertyValue that we can set that will disable all
temporary files?
Marc-André LAVERDIÈRE
Perseverance must finish its work so that you may be mature and complete,
not lacking anything. -James 1:4
http://asimplediscipleslife.blogspot.com/
mlaverd.theunixplace.com
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 37361] LibreOffice 3.5 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=37361 sasha.libreoff...@gmail.com changed: What|Removed |Added Depends on||44664 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Question: How do I rasterize an SVG to a BitmapEx
Andrew Higginson wrote: I can see there are various classes (i.e. vcl::SVGReader and vcl::RenderGraphicRasterizer) which may do the job, however I need to rasterize it to a specific resolution (pretty much what vcl::RenderGraphicRasterizer::Rasterize does) however I don't want to duplicate any code. Hi Andrew, this should do: const ::vcl::RenderGraphicRasterizer aRaster( image/svg+xml, aSvgData.getLength(), aSvgData.getConstArray() ); BitmapEx aBmpEx = aRaster.Rasterize( Size(200,300) ); (with your desired size filled in above, of course) HTH, -- Thorsten pgpl7uRx4SUwu.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Most elegant way to disable all BASIC functionality?
On Mon, 2012-02-27 at 10:14 +0200, Tor Lillqvist wrote: The 'disabling' of interpreter is not technically inherent to IOS, nor is it necessarily the only platform concerned by it. Indeed; 4c737b647078f35a2435e27d9f7f94039db9d6c3 Looks ok to me; I guess what this really means is disable scripting right ? our Java / Javascript stuff is jitted-bytecode, python and basic are rather similar, 'beanshell' ;-) etc. likewise. So - is it just a --disable-scripting we really want ? All the best, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Most elegant way to disable all BASIC functionality?
Looks ok to me; I guess what this really means is disable scripting right ? That's better, yes. Will do s/interpreters/scripting --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Trying to understand why LO seems freezed for some seconds when a module is started
On Sat, 2012-02-25 at 17:21 +0100, Tommy wrote: do u have many autocorrect entries as well? ... as I said before in my experience OOo/LibO performances gets worse when you have a lot of autocorrect items. Dezsi has a patch to fix the horrible slow-down when selecting large autocorrect lists, from minutes to seconds ;-) but he didn't post it last week. Are there other instances / operations where big auto-correct lists cause horrible slow-downs that you know of ? and/or is there a tracker / bug about this ? Thanks ! Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice-commits] .: Makefile
On 02/27/2012 09:28 AM, Norbert Thiebaud wrote: On 2/26/12 13:00 , Peter Foley wrote: Makefile |7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) New commits: commit a75873dea15719b5216cfd0476d30003ffc76e80 Author: Peter Foleypefol...@verizon.net Date: Sun Feb 26 13:53:09 2012 -0500 allow autogen.sh to be run automatically diff --git a/Makefile b/Makefile index a37bca3..68bea91 100644 --- a/Makefile +++ b/Makefile @@ -342,12 +342,15 @@ ifneq ($(filter-out clean distclean,$(MAKECMDGOALS)),) # restart since autogen can have changed # config_host.k which is included in this # Makefile -Makefile: config_host.mk +Makefile: $(SRCDIR)/config_host.mk why did you have to add $SRCDIR here ? Makefile has to be run in the top dir... and if not the dependencies below would not be found (config_host.mk.in for instance) Norbert touch $@ -config_host.mk : config_host.mk.in bin/repo-list.in ooo.lst.in configure.in autogen.lastrun +$(SRCDIR)/config_host.mk : config_host.mk.in bin/repo-list.in ooo.lst.in configure.in autogen.lastrun ./autogen.sh I think one problem is include $(SRCDIR)/config_$(gb_Side).mk near the top of Makefile. If there is no config_host.mk already, there would be no rule to make it. Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED] Reduced loadtime of autocorrect tables
2012/2/24 Dézsi Szabolcs dezsisz...@hotmail.com: There was an issue with acor_* files containing lots of entries (takes forever to load in Autocorrection options). With a small modification in cui/source/tabpages/autocdlg.cxx the issue seems to be gone. Thanks Michael Meeks! I tested it with the attached acor_it-IT.dat file. Autocorrection worked, and it loaded all entries. Load time before patch: ? minutes (didn't wait) Load time after patch: 1.5-2 seconds (and i have an old comp.) Pushed to master, thanks. Andras ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Google Summer of Code
Hi Giorik, On Sun, 2012-02-26 at 16:02 +0200, Giorik Giorik wrote: I'm Thanasis from Greece and I study computer science in TEI of Athens. Great to meet you :-) I want to participate in Google Summer of Code and I would like some help to get me started. Sure - so, I would get a Linux machine installed, and get your first build going - I'd start with an Easy Hack - in previous GSOC's a requirement for getting considered was having submitted a patch to the project first: so we can be sure people are familiar with and able to go around the development loop. eg. removing an unused method from unusedcode.easy and submitting a patch. Getting start is fairly easy, you need to read: http://www.libreoffice.org/developers-2/ And reading Julien's nice links would be a good tip too. Hope that helps :-) Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH] Reduced loadtime of autocorrect tables
On Fri, 24 Feb 2012 16:52:20 +0100, Dézsi Szabolcs dezsisz...@hotmail.com wrote: Hello! There was an issue with acor_* files containing lots of entries (takes forever to load in Autocorrection options). With a small modification in cui/source/tabpages/autocdlg.cxx the issue seems to be gone. Thanks Michael Meeks! I tested it with the attached acor_it-IT.dat file. Autocorrection worked, and it loaded all entries. Load time before patch: ? minutes (didn't wait) Load time after patch: 1.5-2 seconds (and i have an old comp.) Szabolcs great!!! I love you!!! the huge acor_ file you used is mine!!! I'm the one who opened this issue: https://issues.apache.org/ooo/show_bug.cgi?id=101726 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED] Reduced loadtime of autocorrect tables
On Mon, 27 Feb 2012 11:12:50 +0100, Andras Timar tima...@gmail.com wrote: 2012/2/24 Dézsi Szabolcs dezsisz...@hotmail.com: I tested it with the attached acor_it-IT.dat file. Autocorrection worked, and it loaded all entries. Load time before patch: ? minutes (didn't wait) Load time after patch: 1.5-2 seconds (and i have an old comp.) Pushed to master, thanks. Andras since it's a considerable performance improvement for LibO vs. OOo and avoids users wih lots of autocorrect entries to see their PC frozen for 15-10 minutes (that's what it takes to show up in OOo), is there any chance that this push could be cherry picked in LibO 3.5.1 or 3.5.2 ? thanks. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
RE: [PATCH] Reduced loadtime of autocorrect tables
great!!! I love you!!! the huge acor_ file you used is mine!!! I'm the one who opened this issue: https://issues.apache.org/ooo/show_bug.cgi?id=101726 Yes, I used that file, hope it's not a problem :) I know that i could generate an xml file with random entries (with a script), but finding your .dat file was easier. :) Btw. I sent this letter a few days ago, but the message body was too big, so it had to wait for moderator's approval. And yes it would be great to see this in final. Szabolcs ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [REVIEW 3-5-1] Reduced loadtime of autocorrect tables
2012/2/27 Dézsi Szabolcs dezsisz...@hotmail.com: Btw. I sent this letter a few days ago, but the message body was too big, so it had to wait for moderator's approval. And yes it would be great to see this in final. I cherry picked it to libreoffice-3-5 branch. http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5id=3a90b7fea7de8860dfdb92925df39dac3d0ed4fc 2 more signoffs needed for libreoffice-3-5-1. Thanks, Andras ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: JUnit sc_complex fails in Localized enviroment
Hi there, On Sat, 2012-02-25 at 17:52 +0100, Maciej Rumianowski wrote: I hjave discovered a problem when checking libreoffice build (master), below is log. It seems that test is not fully localized. Interesting - what locale are you using out of interest ? Is make check meant to work in non-English enviroment? Yes, naturally :-) I had once such problem with filters_tests in Calc (http://nabble.documentfoundation.org/calc-filters-test-problem-in-Localized-enviroment-td3382023.html). I don't know How Michael fixed it. That was fixed by: commit 6f1dbfbe71b57f70fee88c49487436cb1e23ec6f Author: Michael Meeks michael.me...@suse.com Date: Fri Sep 30 14:57:15 2011 +0100 set the core locale as well as the UI one to English But I think this problem is unrelated. Can you confirm that this passes with a LANG=en_US.UTF8 set ? are you sure it's locale related ? :-) There were 2 failures: 1) checkEmptyCell(complex.cellRanges.CheckXCellRangesQuery) java.lang.AssertionError: Query column differences did not return the correct value. at complex.cellRanges.CheckXCellRangesQuery.checkEmptyCell(CheckXCellRangesQuery.java:179) 2) checkFilledCell(complex.cellRanges.CheckXCellRangesQuery) java.lang.AssertionError: Query column differences did not return the correct value. at complex.cellRanges.CheckXCellRangesQuery.checkFilledCell(CheckXCellRangesQuery.java:207) Nasty. So - the JUnit stuff does a lot more heavy lifting, and (no doubt) could more easily hit one of our multiple, duplicate ways of fetching / acting on the translation / environment :-) 'make check' and the JUnit stuff is Stephan's baby really. HTH, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
REVIEW 3-5, 3-5-1
Please review these three patches that are needed currently for the build of 3.5.1-rc1 with internal libxml on MacOSX 10.4 PPC Cheers F. From 9a36bae8ff7fcf3ee901b6b7b0c3198914ae2c37 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fridrich=20=C5=A0trba?= fridrich.st...@bluewin.ch Date: Sun, 26 Feb 2012 00:02:28 +0100 Subject: [PATCH 1/3] Fix libcroco build against internal libxml2 --- libcroco/makefile.mk |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libcroco/makefile.mk b/libcroco/makefile.mk index 28c588b..8855f8d 100644 --- a/libcroco/makefile.mk +++ b/libcroco/makefile.mk @@ -55,7 +55,7 @@ CONFIGURE_DIR= my_libxml2_cflags=$(LIBXML_CFLAGS) my_libxml2_libs=$(LIBXML_LIBS) .ELSE -my_libxml2_cflags=-I$(SOLARINCDIR)/external/libxml +my_libxml2_cflags=-I$(SOLARINCDIR)/external/libxml -DCROCO_HAVE_LIBXML2=1 my_libxml2_libs=-L$(SOLARLIBDIR) -lxml2 .ENDIF CONFIGURE_ACTION=./configure --prefix=$(SRC_ROOT)/$(PRJNAME)/$(MISC) \ -- 1.7.3.1 From cd437fd8831032d47a1cf3794e3b19e08f7b94fb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fridrich=20=C5=A0trba?= fridrich.st...@bluewin.ch Date: Mon, 27 Feb 2012 09:24:42 +0100 Subject: [PATCH 2/3] Make librsvg link with internal libxml --- librsvg/makefile.mk | 16 +--- 1 files changed, 13 insertions(+), 3 deletions(-) diff --git a/librsvg/makefile.mk b/librsvg/makefile.mk index 63f45e3..0ffbdee 100755 --- a/librsvg/makefile.mk +++ b/librsvg/makefile.mk @@ -57,14 +57,24 @@ PATCH_FILES=librsvg-2.32.1.patch LIBXML_LIBS=-lxml2 .ENDIF +.IF $(SYSTEM_LIBXML) == YES +my_libxml2_cflags=$(LIBXML_CFLAGS) +my_libxml2_libs=$(LIBXML_LIBS) +my_dylib_file= +.ELSE +my_libxml2_cflags=-I$(SOLARINCDIR)/external/libxml +my_libxml2_libs=-L$(SOLARLIBDIR) -lxml2 +my_dylib_file=-Wl,-dylib_file,@loader_path/../ure-link/lib/libxml2.2.dylib:$(SOLARLIBDIR)/libxml2.2.dylib +.ENDIF + CONFIGURE_LDFLAGS=-L$(SOLARLIBDIR) $(eq,$(OS),MACOSX $(EXTRA_LINKFLAGS) $(NULL)) CONFIGURE_DIR= CONFIGURE_ACTION=$(AUGMENT_LIBRARY_PATH) ./configure \ --prefix=$(SRC_ROOT)/$(PRJNAME)/$(MISC) CONFIGURE_FLAGS=--disable-gtk-theme --disable-tools --with-croco --with-svgz \ --disable-pixbuf-loader --disable-dependency-tracking $(eq,$(VERBOSE),$(NULL) --enable-silent-rules --disable-silent-rules) \ - LIBRSVG_CFLAGS=-I$(SOLARINCDIR)/external/glib-2.0 -I$(SOLARINCDIR)/external/gdk-pixbuf-2.0 -I$(SOLARINCDIR)/external/pango-1.0 -I$(SOLARINCDIR)/cairo $(LIBXML_CFLAGS) \ - LIBRSVG_LIBS=-L$(SOLARLIBDIR) -lgdk_pixbuf-2.0 -lpango-1.0 -lpangocairo-1.0 -lgthread-2.0 -lgio-2.0 -lgmodule-2.0 -lgobject-2.0 -lglib-2.0 $(LIBXML_LIBS) -lcairo -lintl \ + LIBRSVG_CFLAGS=-I$(SOLARINCDIR)/external/glib-2.0 -I$(SOLARINCDIR)/external/gdk-pixbuf-2.0 -I$(SOLARINCDIR)/external/pango-1.0 -I$(SOLARINCDIR)/cairo $(my_libxml2_cflags) \ + LIBRSVG_LIBS=-L$(SOLARLIBDIR) -lgdk_pixbuf-2.0 -lpango-1.0 -lpangocairo-1.0 -lgthread-2.0 -lgio-2.0 -lgmodule-2.0 -lgobject-2.0 -lglib-2.0 $(my_libxml2_libs) -lcairo -lintl \ GDK_PIXBUF_CFLAGS=-I$(SOLARINCDIR)/external/gdk-pixbuf-2.0 \ GDK_PIXBUF_LIBS=-lgdk_pixbuf-2.0 \ GTHREAD_CFLAGS=-I$(SOLARINCDIR)/external/glib-2.0 \ @@ -72,7 +82,7 @@ CONFIGURE_FLAGS=--disable-gtk-theme --disable-tools --with-croco --with-svgz \ LIBCROCO_CFLAGS=-I$(SOLARINCDIR)/external/libcroco-0.6 \ LIBCROCO_LIBS=-lcroco-0.6 \ CFLAGS=$(ARCH_FLAGS) $(EXTRA_CFLAGS) -I$(SOLARINCDIR)/external -I$(SOLARINCDIR)/external/glib-2.0 -I$(SOLARINCDIR)/external/gdk-pixbuf-2.0 -I$(SOLARINCDIR)/external/pango-1.0 -I$(SOLARINCDIR)/cairo \ - LDFLAGS=$(CONFIGURE_LDFLAGS) + LDFLAGS=$(CONFIGURE_LDFLAGS) $(my_dylib_file) CONFIGURE_FLAGS+= CPPFLAGS=$(ARCH_FLAGS) $(EXTRA_CDEFS) -- 1.7.3.1 From e1a72a4454b64b5139c7f1f3b9e2a945dbce1293 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fridrich=20=C5=A0trba?= fridrich.st...@bluewin.ch Date: Mon, 27 Feb 2012 10:52:50 +0100 Subject: [PATCH 3/3] Make redland build on Mac with internal libxml --- redland/rasqal/makefile.mk |4 redland/redland/makefile.mk |4 2 files changed, 8 insertions(+), 0 deletions(-) diff --git a/redland/rasqal/makefile.mk b/redland/rasqal/makefile.mk index 71bee48..7a37759 100644 --- a/redland/rasqal/makefile.mk +++ b/redland/rasqal/makefile.mk @@ -113,6 +113,10 @@ LDFLAGS+:=-L$(SYSBASE)$/lib -L$(SYSBASE)$/usr$/lib -lpthread -ldl .ENDIF .ENDIF # $(SYSBASE)!= +.IF $(OS)==MACOSX $(SYSTEM_LIBXML) != YES +LDFLAGS+:=-Wl,-dylib_file,@loader_path/../ure-link/lib/libxml2.2.dylib:$(SOLARLIBDIR)/libxml2.2.dylib +.ENDIF + CPPFLAGS+:=$(EXTRA_CDEFS) $(EXTRA_CFLAGS) LDFLAGS+:=$(EXTRA_LINKFLAGS) XSLTLIB!:=$(XSLTLIB) # expand dmake variables for xslt-config diff --git a/redland/redland/makefile.mk b/redland/redland/makefile.mk index 6113531..1268cbe 100644 --- a/redland/redland/makefile.mk +++
Re: [PUSHED][REVIEW-3-5, 3-5-1] fdo#46571 add Gurmukhi MT to pa-IN font list
On Fri, 2012-02-24 at 23:21 +0100, Andras Timar wrote: Hi, http://cgit.freedesktop.org/libreoffice/core/commit/?id=1e343276ecb7e88482e0dd8b2a1e170dbffbe8ba done for 3-5 and 3-5-1 C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
ByteString finally gone
After a long 12+ year illness ByteString finally went away this morning C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED][PATCH] Removed unused code
On Thu, 2012-02-23 at 22:54 +0100, Dézsi Szabolcs wrote: Hi! I removed the following unused functions: ye gads!, that's a mega-patch. Thanks for this, pushed now. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[REVIEW:3-5, 3-4-5] do not pack stdlibs twice (fdo#46658)
Hi, we moved the stdlibs into separate optional package for LO-3.5.1-rc1. Unfortunately, the related gid entries were still listed in the the ure module in scp2. It causes installation conflicts, see https://bugs.freedesktop.org/show_bug.cgi?id=46658 It should get fixed by http://cgit.freedesktop.org/libreoffice/core/commit/?id=550cc3e9dbe7a86797fc946f40d9ae5529d6ce2c Please, review this for 3-5 and 3-5-1 branches. Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH] Reduced loadtime of autocorrect tables
On Mon, 27 Feb 2012 11:44:10 +0100, Dézsi Szabolcs dezsisz...@hotmail.com wrote: great!!! I love you!!! the huge acor_ file you used is mine!!! I'm the one who opened this issue: https://issues.apache.org/ooo/show_bug.cgi?id=101726 Yes, I used that file, hope it's not a problem :) I know that i could generate an xml file with random entries (with a script), but finding your .dat file was easier. :) you did the right thing!!! great catch!!! ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Trying to understand why LO seems freezed for some seconds when a module is started
On Mon, 27 Feb 2012 10:49:09 +0100, Michael Meeks michael.me...@suse.com wrote: On Sat, 2012-02-25 at 17:21 +0100, Tommy wrote: do u have many autocorrect entries as well? ... as I said before in my experience OOo/LibO performances gets worse when you have a lot of autocorrect items. Dezsi has a patch to fix the horrible slow-down when selecting large autocorrect lists, from minutes to seconds ;-) but he didn't post it last week. Are there other instances / operations where big auto-correct lists cause horrible slow-downs that you know of ? and/or is there a tracker / bug about this ? Thanks ! Michael. I've seen dezsi patch right now and I asked to cherry pick to 3.5.1 or .2 As I told before, the big list of autocorrect has effects on the loading time of the replacement table (that dezsi just fixed) and also on the starting of each module when you first write something... i write a word then hit space... the cursor seems frozen for 5 to 9 seconds (depending how fast is the machine i'm working with) and then moves to the space and let you write other words. if I use a virgin setup of OOo/LibO without my user profile I do not see that freeze ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: MinGW-Port: Problems with UnoUrlResolver
Am Donnerstag, 23. Februar 2012, 12:49:13 schrieb Michael Stahl: (...) earlier this week i bootstrapped a little python thingy on Linux with these variables (found by trial and error, not by actual understanding), perhaps URE_BOOTSTRAP could be of interest to you: I tried it - unfortunately there was no change in th behavior. However, those variables seem to be very sensitive; after several test I got LibreOffice being started by the UNO bootstrap procedure - after setting UNO_PATH to L:\myPathToTheInstallation\program (a little bit weird, since the notation FILE:///L:/myPathToTheInstallation/program which should be used for other variables definitely does NOT work in this place). Helmar URE_BOOTSTRAP=file:///data/lo/core_3_5/solver/unxlngx6/installation/opt/prog ram/fundamentalrc LD_LIBRARY_PATH=/data/lo/core_3_5/solver/unxlngx6/installation/opt/program PYTHONPATH=/data/lo/core_3_5/solver/unxlngx6/installation/opt/program ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [REVIEW 3-5-1] Reduced loadtime of autocorrect tables
On Mon, 2012-02-27 at 11:57 +0100, Andras Timar wrote: I cherry picked it to libreoffice-3-5 branch. http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5id=3a90b7fea7de8860dfdb92925df39dac3d0ed4fc 2 more signoffs needed for libreoffice-3-5-1. Looks safe to me, +1 C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[REVIEW 3-5] duplicate fonts, one broken, one not, results in neither being detected
i.e. https://bugs.freedesktop.org/show_bug.cgi?id=42901 and this commit to fix: http://cgit.freedesktop.org/libreoffice/core/commit/?id=65a3ec97b5032d1748c8f84eeb0b8656e1c25918 broken duplicate seen before working duplicate, first rejected for being broken, second rejected for being a duplicate. So remove broken fonts as we go along allowing non-broken duplicate fonts to be processed. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
User installation migrated onto itself
I wondered why https://bugs.freedesktop.org/show_bug.cgi?id=46074 FILEOPEN: No Recent Documents... reportedly hits Mac and Windows users going from LO 3.4 to 3.5, when it should only hit in cases where the user installation is migrated (which happens on Linux when going from LO 3.4 to 3.5, thanks to http://cgit.freedesktop.org/libreoffice/core/commit/?id=9276f7d5740a28b342db2a9bcd8644ff2f4f5742 fdo#32263 committed towards LO 3.5, fixing https://bugs.freedesktop.org/show_bug.cgi?id=32263 Config file location, which changed the user installation location on Linux from ~/.libreoffice/3 to ~/.config/libreoffice/3). So I dug a little deeper and noticed that, at least on Mac, the first start of LO 3.5 (or later) migrates any existing user installation in ~/Library/Application Support/LibreOffice/3 onto itself. This appears to be due to http://cgit.freedesktop.org/libreoffice/core/commit/?id=6b522673373797bbf53d795d53e0ec45175a5d67 default config location has changed, look in old config dir when migrating, committed towards LO 3.5, which added Libreoffice 3=libreoffice/3 to /org.openoffice.Setup/Migration/SupportedVersions/VersionIdentifiers. On a case-insensitive file system (as is common for Mac and Windows), this causes MigrationImpl::findInstallation (desktop/source/migration/migration.cxx) to identify ~/Library/Application Support/LibreOffice/3 (which would be used by both LO 3.4 and 3.5 just fine and without requiring any migration) as an old user installation at ~/Library/Application Support/libreoffice/3 that needs migration. The migration happens only on the first start of LO 3.5, due to http://cgit.freedesktop.org/libreoffice/core/commit/?id=995a87e5cf63fe1626245b62fef4aa71fa02dc94 disable multiple migrations via MIGRATED stamp file. I do not understand what propblem exactly that is supposed to solve. And would it not be better anyway to only migrate an old user installation if the new user installation does not yet exist? That should also fix the case-insensitivity problem on Mac and Windows leading to that dubious self-migration, I think. Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 37361] LibreOffice 3.5 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Bug 37361 depends on bug 46144, which changed state. Bug 46144 Summary: Distributy Columns Evenly does not work with the selected columns, but affects all columns in the table https://bugs.freedesktop.org/show_bug.cgi?id=46144 What|Old Value |New Value Resolution||FIXED Status|NEW |RESOLVED -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: ByteString finally gone
Then it can be removed from the wiki (Development/String Classes) http://wiki.documentfoundation.org/Development/String_Classes#Cross_reference_for_OString.2FOUString_vs._String.2FByteString.2FUniString as well? Christina Am 27.02.2012 12:13, schrieb Caolán McNamara: After a long 12+ year illness ByteString finally went away this morning C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Ligatures in arabic fonts
Hello guys, I have bug reported at gentoo [1] which I am not entirely sure how to sort out. I suspected graphite2 to be the culprit but it is indeed broken with both system and internal one. Also if I build the libreoffice on the same machine with generic ./autogen.sh build which pulls most of the packages as internal the feature works as desired. So my question is, do you know what area of LO is responsible for this ligatures and any suggestions how to debug this? There is testcase attached to the bug which I can reproduce so anyone who can do so on different distro that built with system libs (debian) and confirm they have the issue or tell me that the issue is not present there would be helpful. Cheers Tom [1] https://bugs.gentoo.org/show_bug.cgi?id=405143 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: MinGW-Port: Problems with UnoUrlResolver
Am Donnerstag, 23. Februar 2012, 11:24:00 schrieb Michael Meeks: On Thu, 2012-02-23 at 11:07 +0100, Helmar Spangenberg wrote: In the meantime I am a step further - having found some very annoying things: The recent MinGW cross tool chain supplied for SuSE 12.1 (64bit) seems to be broken - at least with regards to the LibreOffice code. Are you not using Fridrich's toolchain / bits from here: https://build.opensuse.org/project/show?project=windows%3Amingw%3Awin32 All the best, Michael. Ok, it really seems that the SuSE 12.1 (64 bit) toolchain is broken - on another computer I had the same problems. Anyway - using the older toolchain I got a working testing environment and proceded a little bit. I have the impression that the difficulties rise building the local context. As far as I could debug it, everything looks fine until a UnoUrlResolver instance shall be created using the local context. That fails - obviously when checking the_instance.is(). So my guess is, the created local context is incomplete. Checking a little further, it seems that the file uno.ini in my actual working directory is analyzed to set up te local context (unfortunately I do not understand the entries in that file - any hint?); but a little bit further down in the code my debugs signal a NULL context, so that something else is created as local context. I tried to find out where the ini-file is analyzed and/or the local context is created, but I got stuck - the code as a whole is somewhat confusing... Is there anybody who can tell where I should seek to find the context creation functions? Helmar ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Weird undefined symbol: ReferenceXInterface::operator ReferenceXInterface const() const
Anybody have a clue what might cause this (in a build for the iOS simulator, using the llvm-g++ 4.2.1 in Xcode 4.3): Undefined symbols for architecture i386: com::sun::star::uno::Referencecom::sun::star::uno::XInterface::operator com::sun::star::uno::Referencecom::sun::star::uno::XInterface const() const, referenced from: non-virtual thunk to framework::RootItemContainer::createInstanceWithArgumentsAndContext(com::sun::star::uno::Sequencecom::sun::star::uno::Any const, com::sun::star::uno::Referencecom::sun::star::uno::XComponentContext const)in libfwilo.a(rootitemcontainer.o) non-virtual thunk to framework::RootItemContainer::createInstanceWithContext(com::sun::star::uno::Referencecom::sun::star::uno::XComponentContext const)in libfwilo.a(rootitemcontainer.o) If I rebuild framework with -fkeep-inline-functions the error goes away. But surely it shouldn't be necessary to use that option? And can't using that everywhere cause multiply defined symbols then instead? A compiler problem and/or some weird underspecified corner case relating to inline and templates? Is there something weird or vague in that cast operator in Reference, or in those createInstanceWithArgumentsAndContext and createInstanceWithContext methods in rootitemcontainer.cxx? --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Ligatures in arabic fonts
On Mon, Feb 27, 2012 at 01:11:03PM +0100, Tomáš Chvátal wrote: Hello guys, I have bug reported at gentoo [1] which I am not entirely sure how to sort out. I suspected graphite2 to be the culprit but it is indeed broken with both system and internal one. Also if I build the libreoffice on the same machine with generic ./autogen.sh build which pulls most of the packages as internal the feature works as desired. So my question is, do you know what area of LO is responsible for this ligatures and any suggestions how to debug this? This is likely to be an ICU issue, may be it is this issue: https://www.libreoffice.org/bugzilla/show_bug.cgi?id=39955 and ICU bug ticket: http://bugs.icu-project.org/trac/ticket/8764 There is testcase attached to the bug which I can reproduce so anyone who can do so on different distro that built with system libs (debian) and confirm they have the issue or tell me that the issue is not present there would be helpful. No problem here with official 3.5 build as will as git master. Regards, Khaled ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [REVIEW 3-5-1] Reduced loadtime of autocorrect tables
On Mon, 27 Feb 2012 12:47:43 +0100, Caolán McNamara caol...@redhat.com wrote: On Mon, 2012-02-27 at 11:57 +0100, Andras Timar wrote: I cherry picked it to libreoffice-3-5 branch. http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5id=3a90b7fea7de8860dfdb92925df39dac3d0ed4fc 2 more signoffs needed for libreoffice-3-5-1. Looks safe to me, +1 C. one more needed!!! I crave for this bug to be fixed!!! ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Java issues ...
Dear Michael, Thank you very much for your response. Yes I am aware that we need OpenOffice/ LO to be installed on local machine in order to run it in applet. This is not a good option but do we have others? Code is exactly same as described in the sample. I will try it myself first and then report in details ( if I will failed) . Does LO have a network installation? Best Regards, Nick. On 2/24/2012 8:59 PM, Michael Meeks wrote: Hi there, On Fri, 2012-02-24 at 18:17 +0400, Libreoffice Ge wrote: java.lang.RuntimeException: java.lang.NoClassDefFoundError: com/sun/star/comp/beans/OOoBean It's really rather hard to help with this sort of thing without more information, the code you're using etc. Is that publicly available somewhere ? Could you please let me know if there is any new document o libreoffice.org community or wiki with more comprehensive description of the steps how to run LO/OO in Browser applet. Not that I know of, and here be dragons, it is an under-tested piece of code in general. P.S. Actually my goal is to run open office in browser, like an online LO announced during the conference in Parris.Applet was selected because on line LO will be available only 2013 (as we are informed). You appreciate that for the Applet to work you have to have LibreOffice installed on the local computer running that applet ? :-) All the best, Michael. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[REVIEW:3-5,3-5-1] PostgreSQL regression wrt 3.5.0: privileges via groups
Attached patch fixes fdo#46675, a regression in 3.5.1rc1 wrt to 3.5.0
introduced in the fix for fdo#45254. It is a backport of my
corresponding commit in master; in 3.5.1 only getTablePrivileges is
affected, not getColumnPrivileges.
A PostgreSQL role can be member of another role. Think of the first
role as a user and of the second role as a group; a role can be both a
user and a group.
PostgreSQL-SDBC in LibreOffice 3.5.1 leads the rest of the system to
ignore privileges (permissions) given to a user via a group
membership. This has the consequence that Base (e.g. in a form) won't
allow the user to make things he is allowed to do: e.g. edit data,
insert new data, ...: The corresponding UI elements are locked /
greyed out, in the case that the user does not have that privilege
directly, but only via a group membership.
The bug has a testcase, but one needs a PostgreSQL server to test.
The patch duplicates every privilege description line given to a role
(group) for each member of that role, by doing a cross-product with
every existing role, and restricting to rows such that the role is a
member of the grantee group. PUBLIC is the special role anyone.
pg_has_role(pr.oid, dp.grantee, 'USAGE') is true if and only of
pr.oid is a member of dp.grantee; it is false otherwise.
Please apply to libreoffice-3-5 and libreoffice-3-5-1.
--
Lionel
From d538307b355ac150847cd9671c3db1715e03 Mon Sep 17 00:00:00 2001
From: Lionel Elie Mamane lio...@mamane.lu
Date: Mon, 27 Feb 2012 13:10:40 +0100
Subject: [PATCH] fdo#46675: expand group memberships in PostgreSQL-SDBC
get*Privileges
---
.../drivers/postgresql/pq_databasemetadata.cxx |8 +---
1 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/connectivity/source/drivers/postgresql/pq_databasemetadata.cxx b/connectivity/source/drivers/postgresql/pq_databasemetadata.cxx
index bfc7be0..3da7db4 100644
--- a/connectivity/source/drivers/postgresql/pq_databasemetadata.cxx
+++ b/connectivity/source/drivers/postgresql/pq_databasemetadata.cxx
@@ -1732,7 +1732,8 @@ static void columnMetaData2DatabaseTypeDescription(
rtl::OUStringBuffer sSQL(260);
sSQL.append( ASCII_STR(
- SELECT * FROM (
+ SELECT dp.TABLE_CAT, dp.TABLE_SCHEM, dp.TABLE_NAME, dp.GRANTOR, pr.rolname AS GRANTEE, dp.privilege, dp.is_grantable
+ FROM (
SELECT table_catalog AS TABLE_CAT, table_schema AS TABLE_SCHEM, table_name,
grantor, grantee, privilege_type AS PRIVILEGE, is_grantable
FROM information_schema.table_privileges) );
@@ -1754,8 +1755,9 @@ static void columnMetaData2DatabaseTypeDescription(
WHERE c.relkind IN ('r', 'v') AND c.relacl IS NULL AND pg_has_role(rg.oid, c.relowner, 'USAGE')
AND c.relowner=ro.oid AND c.relnamespace = pn.oid) );
sSQL.append( ASCII_STR(
- ) s
- WHERE table_schem LIKE ? AND table_name LIKE ?
+ ) dp,
+ (SELECT oid, rolname FROM pg_catalog.pg_roles UNION ALL VALUES (0, 'PUBLIC')) pr
+ WHERE table_schem LIKE ? AND table_name LIKE ? AND (dp.grantee = 'PUBLIC' OR pg_has_role(pr.oid, dp.grantee, 'USAGE')
ORDER BY table_schem, table_name, privilege ) );
Reference XPreparedStatement statement = m_origin-prepareStatement( sSQL.makeStringAndClear() );
--
1.7.7.3
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH][REVIEW 3-4] fdo#31966: do not create an empty slide when printing handouts
Hi,
https://bugs.freedesktop.org/show_bug.cgi?id=31966
This bug was fixed in 3-5, but I didn't propose it for 3-4, and that was
confusing to the bug reporter. So, taking into account the simplicity of
the patch, I'd like to see it in 3-4. The patch for the impress
repository is attached.
Sorry if it is insignificant for that branch.
Thanks,
Ivan
From 57acc16017ec7313b047066b1177a088aecaa2ed Mon Sep 17 00:00:00 2001
From: Ivan Timofeev timofeev@gmail.com
Date: Mon, 27 Feb 2012 16:26:39 +0400
Subject: [PATCH] fdo#31966: do not create an empty slide when printing
handouts
---
sd/source/ui/view/DocumentRenderer.cxx |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/sd/source/ui/view/DocumentRenderer.cxx b/sd/source/ui/view/DocumentRenderer.cxx
index 758e5ed..64cd478 100644
--- a/sd/source/ui/view/DocumentRenderer.cxx
+++ b/sd/source/ui/view/DocumentRenderer.cxx
@@ -1967,8 +1967,8 @@ private:
// Create a printer page when we have found one page for each
// placeholder or when this is the last (and special) loop.
-if (aPageIndices.size() == nShapeCount
-|| nIndex==nCount)
+if (!aPageIndices.empty()
+(aPageIndices.size() == nShapeCount || nIndex == nCount))
{
maPrinterPages.push_back(
::boost::shared_ptrPrinterPage(
--
1.7.9
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [REVIEWED 3-5-1] Reduced loadtime of autocorrect tables
On Mon, 2012-02-27 at 11:47 +, Caolán McNamara wrote: Looks safe to me, +1 And of course I love it ;-) so ... I cherry-picked it - thanks Szabolcs :-) Thanks, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
REVISED PATCH [REVIEW:3-5,3-5-1] PostgreSQL regression wrt 3.5.0: privileges via groups
Forgot to regenerate the patch after last-minute fix before sending
email... Missing closing parenthesis in previous patch. New patch
attached.
On Mon, Feb 27, 2012 at 01:41:21PM +0100, Lionel Elie Mamane wrote:
Attached patch fixes fdo#46675, a regression in 3.5.1rc1 wrt to 3.5.0
introduced in the fix for fdo#45254. It is a backport of my
corresponding commit in master; in 3.5.1 only getTablePrivileges is
affected, not getColumnPrivileges.
A PostgreSQL role can be member of another role. Think of the first
role as a user and of the second role as a group; a role can be both a
user and a group.
PostgreSQL-SDBC in LibreOffice 3.5.1 leads the rest of the system to
ignore privileges (permissions) given to a user via a group
membership. This has the consequence that Base (e.g. in a form) won't
allow the user to make things he is allowed to do: e.g. edit data,
insert new data, ...: The corresponding UI elements are locked /
greyed out, in the case that the user does not have that privilege
directly, but only via a group membership.
The bug has a testcase, but one needs a PostgreSQL server to test.
The patch duplicates every privilege description line given to a role
(group) for each member of that role, by doing a cross-product with
every existing role, and restricting to rows such that the role is a
member of the grantee group. PUBLIC is the special role anyone.
pg_has_role(pr.oid, dp.grantee, 'USAGE') is true if and only of
pr.oid is a member of dp.grantee; it is false otherwise.
Please apply to libreoffice-3-5 and libreoffice-3-5-1.
From 72e2ca2d1e915cc998ae286ede8b47eae2b45b09 Mon Sep 17 00:00:00 2001
From: Lionel Elie Mamane lio...@mamane.lu
Date: Mon, 27 Feb 2012 13:10:40 +0100
Subject: [PATCH] fdo#46675: expand group memberships in PostgreSQL-SDBC
get*Privileges
---
.../drivers/postgresql/pq_databasemetadata.cxx |8 +---
1 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/connectivity/source/drivers/postgresql/pq_databasemetadata.cxx b/connectivity/source/drivers/postgresql/pq_databasemetadata.cxx
index bfc7be0..6b6b8fe 100644
--- a/connectivity/source/drivers/postgresql/pq_databasemetadata.cxx
+++ b/connectivity/source/drivers/postgresql/pq_databasemetadata.cxx
@@ -1732,7 +1732,8 @@ static void columnMetaData2DatabaseTypeDescription(
rtl::OUStringBuffer sSQL(260);
sSQL.append( ASCII_STR(
- SELECT * FROM (
+ SELECT dp.TABLE_CAT, dp.TABLE_SCHEM, dp.TABLE_NAME, dp.GRANTOR, pr.rolname AS GRANTEE, dp.privilege, dp.is_grantable
+ FROM (
SELECT table_catalog AS TABLE_CAT, table_schema AS TABLE_SCHEM, table_name,
grantor, grantee, privilege_type AS PRIVILEGE, is_grantable
FROM information_schema.table_privileges) );
@@ -1754,8 +1755,9 @@ static void columnMetaData2DatabaseTypeDescription(
WHERE c.relkind IN ('r', 'v') AND c.relacl IS NULL AND pg_has_role(rg.oid, c.relowner, 'USAGE')
AND c.relowner=ro.oid AND c.relnamespace = pn.oid) );
sSQL.append( ASCII_STR(
- ) s
- WHERE table_schem LIKE ? AND table_name LIKE ?
+ ) dp,
+ (SELECT oid, rolname FROM pg_catalog.pg_roles UNION ALL VALUES (0, 'PUBLIC')) pr
+ WHERE table_schem LIKE ? AND table_name LIKE ? AND (dp.grantee = 'PUBLIC' OR pg_has_role(pr.oid, dp.grantee, 'USAGE'))
ORDER BY table_schem, table_name, privilege ) );
Reference XPreparedStatement statement = m_origin-prepareStatement( sSQL.makeStringAndClear() );
--
1.7.7.3
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: ByteString finally gone
On Mon, 2012-02-27 at 13:10 +0100, Chr. Rossmanith wrote: Then it can be removed from the wiki (Development/String Classes) as well? Sure, go for it. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [REVIEWED 3-5-1] Reduced loadtime of autocorrect tables
On Mon, 27 Feb 2012 13:40:21 +0100, Michael Meeks michael.me...@suse.com wrote: On Mon, 2012-02-27 at 11:47 +, Caolán McNamara wrote: Looks safe to me, +1 And of course I love it ;-) so ... I cherry-picked it - thanks Szabolcs :-) Thanks, Michael. great!!! just one more question: will it be in 3.5.1 or 3.5.2? ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Windows tinderbox on private branch
On Thu, Feb 23, 2012 at 10:11:19AM +0100, Jan Holesovsky wrote: On 2012-02-20 at 13:24 +0100, Lionel Elie Mamane wrote: Would it be possible to have a Windows tinderbox build a private branch of mine? It would roughly be libreoffice-3-5 plus most of my commits to master. As we talked on the IRC, I don't really want to load the current Windows tinderbox(es) with additional builds; with the amount of commits we are having, doubling the current build times would be risky. As I also wrote on IRC, I expected pushes to this branch to be rare enough for this not to be a significant problem, so I as trying to minimise work for you. However, since you can setup another machine, that's very good also. But - I managed to find an unused machine with Core2 Duo and 5G RAM, Fridrich will install the build prerequisites there, and measure the build time. Great, thanks. I'm impatiently waiting for it. -- Lionel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Pushed] [PATCH] Replace getLength() with isEmpty() where appropriate
Pushed. Thank you! On 02/27/2012 01:52 PM, Chr. Rossmanith wrote: Hi, some more getLength() - isEmpty() replacements. Would be nice if someone could review the patch. Christina ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH] Replace getLength() with isEmpty() where appropriate
Hi Christina, On 27.02.2012 12:22, Chr. Rossmanith wrote: some more getLength() - isEmpty() replacements. Would be nice if someone could review the patch. at least, aTextHtml and aData from your patch are 'Sequence's, Sequence has not the isEmpty method IIRC, only the string classes have it. Please, check the types. :) Thanks, Ivan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Pushed] [PATCH] Removed unused code
Pushed. Thank you! On 02/26/2012 05:47 AM, Petr Vorel wrote: Another patch removing some unused methods. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [REVIEWED 3-5-1] Reduced loadtime of autocorrect tables
On Mon, 2012-02-27 at 13:48 +0100, Tommy wrote: just one more question: will it be in 3.5.1 or 3.5.2? 3.5.1 out in around a week. ATB, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[REVIEW][3-5][3-5-1] paste into draw from writer if writer doc has tables in header/footer - kaboom
Fix for https://bugs.freedesktop.org/show_bug.cgi?id=46038 proposed is http://cgit.freedesktop.org/libreoffice/core/commit/?id=15547450bdba10959473c2cb5891f29ad5053b09 pasting any content from a writer document to draw *if* the source writer document has a table in a header/footer (even if not selected) will draw draw. Because draw has a silly way to determine if the pasted content should be inserted into a table and writer has a silly extension to rtf to try and retain its page styles in rtf. Regression triggered by my desire to put styles into the clipboard document so we get wysiwyg paste. Simplest and easiest fix is to omit the page styles from the clipboard doc, in old-school we had no styles in there, so should be fine. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH] Replace getLength() with isEmpty() where appropriate
On 27.02.2012 16:59, Ivan Timofeev wrote: Hi Christina, On 27.02.2012 12:22, Chr. Rossmanith wrote: some more getLength() - isEmpty() replacements. Would be nice if someone could review the patch. at least, aTextHtml and aData from your patch are 'Sequence's, Sequence has not the isEmpty method IIRC, only the string classes have it. fixed that now http://cgit.freedesktop.org/libreoffice/core/commit/?id=c581d33dec47a4c411a034482876543f6357d1e8 Ivan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED 3-5] [REVIEW 3.5; 3.5.1 (?)] fdo#46144: Distributy Columns Evenly does not work with the selected columns
Hello Norbert, Ivan, On Mon, Feb 27, 2012 at 13:53, Norbert Thiebaud nthieb...@gmail.com wrote: On Sun, Feb 26, 2012 at 9:39 AM, Ivan Timofeev timofeev@gmail.com wrote: Fixed invalid conversion from SvUShorts to std::vector... *sigh* Please, pick to the appropriate branches. I pushed it on the 3.5 branch. too late for 3.5.1 Sorry, but why is this too late? IIRC, we'll have RC2 next week. Best Regards, -- Korrawit Pruegsanusak ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[REVIEW:3-5-1] PostgreSQL regression wrt 3.5.0: privileges via groups
On Mon, 2012-02-27 at 13:45 +0100, Lionel Elie Mamane wrote: Forgot to regenerate the patch after last-minute fix before sending email... Missing closing parenthesis in previous patch. New patch attached. :-) so, since you're the expert here, and the patch looks sane to me - I pushed to libreoffice-3-5 - thanks for that. All the best, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[REVIEWED 3-4] fdo#31966: do not create an empty slide when printing handouts
On Mon, 2012-02-27 at 16:41 +0400, Ivan Timofeev wrote: This bug was fixed in 3-5, but I didn't propose it for 3-4, and that was confusing to the bug reporter. So, taking into account the simplicity of the patch, I'd like to see it in 3-4. The patch for the impress repository is attached. Fair enough :-) Sorry if it is insignificant for that branch. It's not that significant, but it's a trivial fix so why not, as long as we don't set the expectation that every bug will be fixed in 3.4, so I pushed it :-) Thanks. Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [libreoffice-l10n] [ANN] LibreOffice 3.5.1 RC1 available
The options tree in Writer in Czech language is completely messed up after the re-added basic fonts options, but this is probably just because the translations weren't updated yet (which they should be, at least in Czech language, considering the added strings were translated the same day they were added). ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: MinGW-Port: Problems with UnoUrlResolver
On Mon, 2012-02-27 at 13:07 +0100, Helmar Spangenberg wrote: Checking a little further, it seems that the file uno.ini in my actual working directory is analyzed to set up te local context (unfortunately I do not understand the entries in that file - any hint?) :-) So there are two unorc files (or uno.inis on windows) one next to the URE libraries, and one inside the libreoffice install itself. The ini file syntax itself is parsed / dealt with by sal/rtl/source/bootstrap.cxx IIRC, and we like to load a good handful of these files at startup (I'm afraid). I tried to find out where the ini-file is analyzed and/or the local context is created, but I got stuck - the code as a whole is somewhat confusing... Is there anybody who can tell where I should seek to find the context creation functions? :-) Stephan is really the expert here, but there are several entry points into those ini files; a: git grep -5 SAL_CONFIGFILE would prolly find a scad of this sort of thing, not all of them for that unorc ... HTH, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [libreoffice-projects] [ANN] LibreOffice 3.5.1 RC1 available
Hi, 2012/2/26 Thorsten Behrens t...@documentfoundation.org: for the upcoming new version 3.5.1, the RC1 builds now start to be available on pre-releases. This build is slated to be one of two release candidate builds on the way towards 3.5.1, please refer to our release plan timings here: http://wiki.documentfoundation.org/ReleasePlan#3.5_release Builds are now being uploaded to a public (but non-mirrored - so don't spread news too widely!) place, as soon as they're available. Grab them here: http://dev-builds.libreoffice.org/pre-releases/ If you've a bit of time, please give them a try report *critical* bugs not yet in bugzilla here, so we can incorporate them into the release notes. Please note that it takes approximately 24 hours to populate the mirrors, so that's about the time we have to collect feedback. The list of fixed bugs relative to 3.5.0 is here: http://dev-builds.libreoffice.org/pre-releases/src/bugfixes-libreoffice-3-5-1-release-3.5.1.1.log So playing with the areas touched there also greatly appreciated - and validation that those bugs are really fixed. There are some duplicate entries in the options menu for Writer here, installed in german on Windows XP32. One localized, one in english, for Mailmerge, Compatibility and AutoCaption. Volker -- Volker Merschmann Member of The Document Foundation http://www.documentfoundation.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH] Replace getLength() with isEmpty() where appropriate
@Ivan: Thanks! I missed that one. On 02/27/2012 06:45 PM, Ivan Timofeev wrote: On 27.02.2012 16:59, Ivan Timofeev wrote: Hi Christina, On 27.02.2012 12:22, Chr. Rossmanith wrote: some more getLength() - isEmpty() replacements. Would be nice if someone could review the patch. at least, aTextHtml and aData from your patch are 'Sequence's, Sequence has not the isEmpty method IIRC, only the string classes have it. fixed that now http://cgit.freedesktop.org/libreoffice/core/commit/?id=c581d33dec47a4c411a034482876543f6357d1e8 Ivan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: User installation migrated onto itself
On Mon, 2012-02-27 at 12:52 +0100, Stephan Bergmann wrote: So I dug a little deeper and noticed that, at least on Mac, the first start of LO 3.5 (or later) migrates any existing user installation in ~/Library/Application Support/LibreOffice/3 onto itself. Ho hum, migrating itself sounds like a bad idea I guess, particularly since it will break subsequent migrations for 3.6 - we'll have to change / version the MIGRATED stamp name in master I suppose. The migration happens only on the first start of LO 3.5, due to http://cgit.freedesktop.org/libreoffice/core/commit/?id=995a87e5cf63fe1626245b62fef4aa71fa02dc94 disable multiple migrations via MIGRATED stamp file. I do not understand what propblem exactly that is supposed to solve. That file was asked for by Mechtilde. IIRC she was very concerned that without tons of testing of the migration paths we can easily get into situations where migration crashes as it starts, or produces a non-working install; and then users have to be instructed to remove not only their new user directory, but every old one too. So - this turns the flow into it broke, fair enough, so just remove your settings directory and re-run and all will be well - instead of some traumatised finding of versioned settings directories. I am assuming here that we don't need to do migrations inside a major version, ie. the version is encoded in the path. And would it not be better anyway to only migrate an old user installation if the new user installation does not yet exist ? The MIGRATED stamp is to avoid doing the migration more than once ever - it is a stamp file so a user can see it and remove it if they want to re-do that. HTH, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Trying to understand why LO seems freezed for some seconds when a module is started
On Mon, 2012-02-27 at 12:45 +0100, Tommy wrote: i write a word then hit space... the cursor seems frozen for 5 to 9 seconds (depending how fast is the machine i'm working with) and then moves to the space and let you write other words. That -really- still sounds like the Java slowdown to me. That is when I'd expect languagetool to get it's clogs on. if I use a virgin setup of OOo/LibO without my user profile I do not see that freeze Sure - but then the LangaugeTool extension would be registered in your user profile too ;-) Can you check in the extension manager that it is removed from the system rather than just disabled or whatever. You can of course double check by looking at the: lsof -p `pidof soffice.bin` to see if Java is loaded before and/or after you type that word. ATB, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [REVIEW:3-5, 3-5-1][PUSHED-3-5] do not pack stdlibs twice (fdo#46658)
[Petr, I assume you meant 3-5-1 instead of 3-4-5 in the subject; changed.] On 02/27/2012 12:33 PM, Petr Mladek wrote: we moved the stdlibs into separate optional package for LO-3.5.1-rc1. Unfortunately, the related gid entries were still listed in the the ure module in scp2. It causes installation conflicts, see https://bugs.freedesktop.org/show_bug.cgi?id=46658 It should get fixed by http://cgit.freedesktop.org/libreoffice/core/commit/?id=550cc3e9dbe7a86797fc946f40d9ae5529d6ce2c Please, review this for 3-5 and 3-5-1 branches. Pushed to libreoffice-3-5 as 216e30277b06124822cccdc2a6d46de57a2f8e6e, more reviews needed for libreoffice-3-5-1. Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[REVIEWED] 3-5
Hi Fridrich, You have my ack for -3-5, the librsvg bit looked curios, but ... ;-) correct when I dug further. Thanks ! Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Disabling Temporary Files?
Hi Marc, On Mon, 2012-02-27 at 04:15 -0500, Marc-André Laverdière wrote: I am working on something for which we want the document to stay in memory, with no temp file on disk. Ho hum ;-) And the result is that we have a temporary file in C:\Users\meh\AppData|local\Temp\ Sounds normal, -hopefully- the properties on that file are such that only the user can read/write them - otherwise we have a bigger problem. Is there any PropertyValue that we can set that will disable all temporary files? It seems unlikely - we rely on tmp files quite heavily in a number of situations I think. Of course - we could try collecting those all together behind one API in sal/ and then using an in-memory storage instead I guess but ... Why do you want to keep them off the oxide ? Sorry, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Duplicate code: GlyphSet::DrawGlyphs() and GlyphSet::ImplDrawText()
Hi Christina, On Mon, 2012-02-27 at 09:49 +0100, Chr. Rossmanith wrote: the method GlyphSet::DrawGlyphs() is nearly a total subset of GlyphSet::ImplDrawText(). The only difference is the declaration of Ah - there are two of these ImplDrawText's and the latter (as you say) does look like an embarassing cut/paste job :-) Or are there reasons for not adding an additional parameter to DrawGlyphs() ? Not that I can see :-) All the best, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH] Replace getLength() with isEmpty() where appropriate
Am 27.02.2012 13:59, schrieb Ivan Timofeev: Hi Christina, On 27.02.2012 12:22, Chr. Rossmanith wrote: some more getLength() - isEmpty() replacements. Would be nice if someone could review the patch. at least, aTextHtml and aData from your patch are 'Sequence's, Sequence has not the isEmpty method IIRC, only the string classes have it. Please, check the types. :) Thanks, Ivan Sorry, I thought, if the compiler doesn't complain everything is fine - but the compiler didn't see HtmlFmtFlt.cxx and had no chance to complain. Thank you for reviewing, Christina ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] Re: [PATCH] Translated german comments in sw/source/core/layout/
Hi David, all, On 2012-02-17 at 11:26 +0100, David Vogt wrote: As Nicolas Christener and I promised to Cedric at FOSDEM, we set sail to translate the german comments in the sw/source/core/layout/ directory. We're still not quite done, but here's what we have so far. This, and any future contributions to LibreOffice are available under the MPL / LGPLv3+ unless stated otherwise. Thanks so much for this heroic work! I've pushed everything from this lot what I've found not pushed yet. All the best, Kendy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 37361] LibreOffice 3.5 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=37361 --- Comment #201 from Vossman vossma...@yahoo.com 2012-02-27 06:23:34 PST --- I would like to nominate confirmed bug #44937 for 'most annoying'. As a professor, I was using the 3.5 series, but I cannot give my lectures because of the above bug, so I have a revert back to using the 3.4 series. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] Removed unused code
On Sat, 2012-02-25 at 19:59 +0100, Bartolomé Sánchez Salado wrote: I've removed some unused virtual methods inside backends as Michael Meeks requested me: Thanks :-) we can update the unpublished interface to only implement what is actually used. Pushed, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] convert SbxFactory in BASIC module from SV_DECL_PTRARR_DEL to boost::ptr_vector
Hi
License is on file.
Regards, Noel Grandin
Disclaimer: http://www.peralex.com/disclaimer.html
From dcb00e7ca3c52d3c371eeb614629e3bcb4861e8b Mon Sep 17 00:00:00 2001
From: Noel Grandin n...@peralex.com
Date: Mon, 27 Feb 2012 16:26:41 +0200
Subject: [PATCH] Convert SbxFactory from SV_DECL_PTRARR_DEL to
boost::ptr_vector
---
basic/inc/basic/sbxbase.hxx |3 ++-
basic/source/sbx/sbxbase.cxx | 25 +++--
basic/source/sbx/sbxscan.cxx |1 +
3 files changed, 14 insertions(+), 15 deletions(-)
diff --git a/basic/inc/basic/sbxbase.hxx b/basic/inc/basic/sbxbase.hxx
index 55341fa..e760c4f 100644
--- a/basic/inc/basic/sbxbase.hxx
+++ b/basic/inc/basic/sbxbase.hxx
@@ -33,12 +33,13 @@
#include svl/svarray.hxx
#include basic/sbxdef.hxx
#include basicdllapi.h
+#include boost/ptr_container/ptr_vector.hpp
class SbxFactory;
class SbxVariable;
class SbxBasicFormater;
-SV_DECL_PTRARR_DEL(SbxFacs,SbxFactory*,5)
+typedef boost::ptr_vectorSbxFactory SbxFacs;
// AppData structure for SBX:
struct SbxAppData
diff --git a/basic/source/sbx/sbxbase.cxx b/basic/source/sbx/sbxbase.cxx
index e2987d0..048ea3c 100644
--- a/basic/source/sbx/sbxbase.cxx
+++ b/basic/source/sbx/sbxbase.cxx
@@ -36,11 +36,10 @@
#include rtl/instance.hxx
#include rtl/oustringostreaminserter.hxx
#include sal/log.hxx
+#include boost/foreach.hpp
// AppData-Structure for SBX:
-SV_IMPL_PTRARR(SbxFacs,SbxFactory*);
-
TYPEINIT0(SbxBase)
namespace
@@ -147,28 +146,27 @@ void SbxBase::ResetError()
void SbxBase::AddFactory( SbxFactory* pFac )
{
SbxAppData r = GetSbxData_Impl();
-const SbxFactory* pTemp = pFac;
// From 1996-03-06: take the HandleLast-Flag into account
-sal_uInt16 nPos = r.aFacs.Count(); // Insert position
+sal_uInt16 nPos = r.aFacs.size(); // Insert position
if( !pFac-IsHandleLast() ) // Only if not self HandleLast
{
// Rank new factory in front of factories with HandleLast
while( nPos 0
-(static_castSbxFactory*(r.aFacs.GetObject( nPos-1
)))-IsHandleLast() )
+r.aFacs[ nPos-1 ].IsHandleLast() )
nPos--;
}
-r.aFacs.Insert( pTemp, nPos );
+r.aFacs.insert( r.aFacs.begin() + nPos, pFac );
}
void SbxBase::RemoveFactory( SbxFactory* pFac )
{
SbxAppData r = GetSbxData_Impl();
-for( sal_uInt16 i = 0; i r.aFacs.Count(); i++ )
+for(SbxFacs::iterator it = r.aFacs.begin(); it != r.aFacs.end(); ++it)
{
-if( r.aFacs.GetObject( i ) == pFac )
+if( (*it) == pFac )
{
-r.aFacs.Remove( i, 1 ); break;
+r.aFacs.release( it ).release(); break;
}
}
}
@@ -200,10 +198,9 @@ SbxBase* SbxBase::Create( sal_uInt16 nSbxId, sal_uInt32
nCreator )
// Unknown type: go over the factories!
SbxAppData r = GetSbxData_Impl();
SbxBase* pNew = NULL;
-for( sal_uInt16 i = 0; i r.aFacs.Count(); i++ )
+BOOST_FOREACH(SbxFactory rFac, r.aFacs)
{
-SbxFactory* pFac = r.aFacs.GetObject( i );
-pNew = pFac-Create( nSbxId, nCreator );
+pNew = rFac.Create( nSbxId, nCreator );
if( pNew )
break;
}
@@ -215,9 +212,9 @@ SbxObject* SbxBase::CreateObject( const rtl::OUString
rClass )
{
SbxAppData r = GetSbxData_Impl();
SbxObject* pNew = NULL;
-for( sal_uInt16 i = 0; i r.aFacs.Count(); i++ )
+BOOST_FOREACH(SbxFactory rFac, r.aFacs)
{
-pNew = r.aFacs.GetObject( i )-CreateObject( rClass );
+pNew = rFac.CreateObject( rClass );
if( pNew )
break;
}
diff --git a/basic/source/sbx/sbxscan.cxx b/basic/source/sbx/sbxscan.cxx
index 18bb46d..a253377 100644
--- a/basic/source/sbx/sbxscan.cxx
+++ b/basic/source/sbx/sbxscan.cxx
@@ -43,6 +43,7 @@
#include sbxres.hxx
#include basic/sbxbase.hxx
+#include basic/sbxfac.hxx
#include basic/sbxform.hxx
#include svtools/svtools.hrc
--
1.7.5.4
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Question: How do I rasterize an SVG to a BitmapEx
Hi, const ::vcl::RenderGraphicRasterizer aRaster( image/svg+xml, aSvgData.getLength(), aSvgData.getConstArray() ); BitmapEx aBmpEx = aRaster.Rasterize( Size(200,300) ); Thanks, and finally, how do I get the aSvgData? -- Andrew Higginson ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
re-doing git patches
Hi Is there some easier git-magic available for working on and re-submitting a patch? Using git-rebase seems incredibly fragile and hacky. Regards, Noel. On 2012-02-17 17:27, Michael Meeks wrote: Pushed, Thanks, all the patches are nice cleanups. Another thing that would help, would be if you could do: git commit -a ... enter your commit message etc. ... And then mail in the result of: git format-patch -1 master or somesuch - then this can be applied with a quick and easy: git am 0001-do-foo.patch approach :-) Anyhow - a nice set of cleanups, Thanks, Michael. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 37361] LibreOffice 3.5 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=37361 --- Comment #202 from Petr Mladek pmla...@suse.cz 2012-02-27 06:57:46 PST --- (In reply to comment #201) I would like to nominate confirmed bug #44937 for 'most annoying'. As a professor, I was using the 3.5 series, but I cannot give my lectures because of the above bug, so I have a revert back to using the 3.4 series. It seems to be fixed in 3.5.1-rc1 = it does not need immediate attention = let's leave it out of the most annoying bugs. Feel free to put it into most annoying bugs if you still see it with 3.5.1-rc1 or never. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED] Change Windows newline to Unix newline
Hello Michael, On Tue, Nov 8, 2011 at 16:19, Michael Meeks michael.me...@suse.com wrote: Nice to clean things up, I wonder if we could grep all of the code for any remaining instances of this fix them ? First, sorry for this 3-months backlog. :( For the record, I've done this at http://cgit.freedesktop.org/libreoffice/core/commit/?id=7b348b9f67ca1138857c34da5b67b479c64a4901 cleaning only the files ended in /\.(h|c)xx/ Best Regards, -- Korrawit Pruegsanusak ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Sophie Gautier/license statement
Hi all, All of my past future contributions to LibreOffice may be licensed under the MPL/LGPLv3+ dual license until further notice. Kind regards Sophie -- Founding member of The Document Foundation ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[REVIEW 3.5.1 (?)] fdo#46144: Distributy Columns Evenly does not work with the selected columns
On Mon, 2012-02-27 at 00:53 -0600, Norbert Thiebaud wrote: Fixed invalid conversion from SvUShorts to std::vector... *sigh* Please, pick to the appropriate branches. I pushed it on the 3.5 branch. With one more review (preferably from a writer maintainer) we're good for 3.5.1 I think. RC2 is final though Ivan - so we're trying to reduce the number of patches between RC1 and final of our point releases. Having said that I'm not hyper-happy with not initialising the vector's contents - don't we really want: std::vectorsal_uInt16 aWish( aTablCols.Count() + 1, 0 ), aMins( aTabCols.Count() + 1, 0 ); The previous Max() of the count with 255 looks somewhat odd / disturbing - no idea what horrors that might hide ;-) sadly that sort of thing has been there since the beginning. Anyhow - thanks for fixing the bug ! Regards, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Question: How do I rasterize an SVG to a BitmapEx
Andrew Higginson wrote: Thanks, and finally, how do I get the aSvgData? Just load your file into that - this RenderGraphic just wants a const sal_uInt8* ptr with the utf-8 encoded xml stream. ;) Cheers, -- Thorsten pgpMWjjjB12TW.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 37361] LibreOffice 3.5 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Petr Mladek pmla...@suse.cz changed: What|Removed |Added Depends on||44135 --- Comment #203 from Petr Mladek pmla...@suse.cz 2012-02-27 07:14:18 PST --- (In reply to comment #199) Nominate Bug 44135 which could be related to Bug 40143: transparent color objects shows up in gray scale in PDF I am not 100% sure that the bug is in LibreOffice. Anyway, it looks annoying, has more duplicates, so let's add it here. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: re-doing git patches
On Mon, 2012-02-27 at 16:49 +0200, Noel Grandin wrote: Is there some easier git-magic available for working on and re-submitting a patch? Oh ! so, if the patch is the latest / top patch on your queue - then 'git commit --amend' will re-write the top commit on the stack - that of course is quite easy. Using git-rebase seems incredibly fragile and hacky. So - personally, since I don't entirely trust (myself) with the git tools, I would extract the last 10 patches: rm *.patch git format-patch HEAD~10 git reset --hard HEAD~10 where 10 is as many as you have un-committed ;-) and then I'd edit the patches you want to and; for a in *.patch; git am $a; done or apply all but the one you want to edit and patch -p1 $a and continue hacking, or ... No doubt git rebase -i makes this all 'easy' but ... ;-) having done the reset --hard HEAD~10 you can of course git pull -r to get to the latest stuff on master then choose what you re-apply. HTH, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] fdo44516 cleanup of direct use of RGD color in code
Thanks to Norbert Thiebauld a small patch to remove direct use of an RGB-colour from the code. WinfriedFrom 31348488869937de80ed78f49730538919f1d3be Mon Sep 17 00:00:00 2001 From: Winfried Donkers o...@dci-electronics.nl Date: Mon, 27 Feb 2012 16:21:33 +0100 Subject: [PATCH] fdo44516 cleanup of direct use of color in code --- sw/source/ui/envelp/labfmt.cxx |2 +- tools/inc/tools/color.hxx |1 + 2 files changed, 2 insertions(+), 1 deletions(-) diff --git a/sw/source/ui/envelp/labfmt.cxx b/sw/source/ui/envelp/labfmt.cxx index 6ec2a79..d5208dd 100644 --- a/sw/source/ui/envelp/labfmt.cxx +++ b/sw/source/ui/envelp/labfmt.cxx @@ -173,7 +173,7 @@ void SwLabPreview::Paint(const Rectangle ) // Labels SetClipRegion (Rectangle(Point(lX0, lY0), Size(lOutlineW, lOutlineH))); -SetFillColor( Color( 0xE0, 0xE0, 0xFF ) ); +SetFillColor( COL_LIGHTGRAYBLUE ); for (sal_uInt16 nRow = 0; nRow Min((sal_uInt16) 2, (sal_uInt16) aItem.nRows); nRow++) for (sal_uInt16 nCol = 0; nCol Min((sal_uInt16) 2, (sal_uInt16) aItem.nCols); nCol++) DrawRect(Rectangle( diff --git a/tools/inc/tools/color.hxx b/tools/inc/tools/color.hxx index a9fe589..4594de6 100644 --- a/tools/inc/tools/color.hxx +++ b/tools/inc/tools/color.hxx @@ -74,6 +74,7 @@ typedef sal_uInt32 ColorData; #define COL_LIGHTCYAN RGB_COLORDATA( 0x00, 0xFF, 0xFF ) #define COL_LIGHTREDRGB_COLORDATA( 0xFF, 0x00, 0x00 ) #define COL_LIGHTMAGENTARGB_COLORDATA( 0xFF, 0x00, 0xFF ) +#define COL_LIGHTGRAYBLUE RGB_COLORDATA( 0xE0, 0xE0, 0xFF ) #define COL_YELLOW RGB_COLORDATA( 0xFF, 0xFF, 0x00 ) #define COL_WHITE RGB_COLORDATA( 0xFF, 0xFF, 0xFF ) #define COL_TRANSPARENT TRGB_COLORDATA( 0xFF, 0xFF, 0xFF, 0xFF ) -- 1.7.7 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 37361] LibreOffice 3.5 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Petr Mladek pmla...@suse.cz changed: What|Removed |Added Depends on||45171 --- Comment #204 from Petr Mladek pmla...@suse.cz 2012-02-27 07:31:35 PST --- Add 45171: Can't open document with password; It seems to be related to a Firefox upgrade. It affects many distro builds. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Most elegant way to disable all BASIC functionality?
So maybe hard-wiring that setting for the App-Store and not offer the dialog would be enough? Yeah, that's a good start, but we would still link in the whole shebang of never reachable BASIC-related code then;) (Static linking is used for iOS.) --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Weird undefined symbol: ReferenceXInterface::operator ReferenceXInterface const() const
On 02/27/2012 01:20 PM, Tor Lillqvist wrote: Anybody have a clue what might cause this (in a build for the iOS simulator, using the llvm-g++ 4.2.1 in Xcode 4.3): Undefined symbols for architecture i386: com::sun::star::uno::Referencecom::sun::star::uno::XInterface::operator com::sun::star::uno::Referencecom::sun::star::uno::XInterface const() const, referenced from: non-virtual thunk to framework::RootItemContainer::createInstanceWithArgumentsAndContext(com::sun::star::uno::Sequencecom::sun::star::uno::Any const, com::sun::star::uno::Referencecom::sun::star::uno::XComponentContext const)in libfwilo.a(rootitemcontainer.o) non-virtual thunk to framework::RootItemContainer::createInstanceWithContext(com::sun::star::uno::Referencecom::sun::star::uno::XComponentContext const)in libfwilo.a(rootitemcontainer.o) IIRC, this is a known issue with the compiler provided by Apple (can't find any issue ID right now, though). Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[REVIEW:3-5-1] do not pack stdlibs twice (fdo#46658)
One more review required. On Mon, 2012-02-27 at 14:44 +0100, Stephan Bergmann wrote: Pushed to libreoffice-3-5 as 216e30277b06124822cccdc2a6d46de57a2f8e6e, more reviews needed for libreoffice-3-5-1. Trivial patch, ack from me. Thanks, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [REVIEW 3.5.1 (?)] fdo#46144: Distributy Columns Evenly does not work with the selected columns
On 27.02.2012 19:01, Michael Meeks wrote: Having said that I'm not hyper-happy with not initialising the vector's contents - don't we really want: std::vectorsal_uInt16 aWish( aTablCols.Count() + 1, 0 ), aMins( aTabCols.Count() + 1, 0 ); Hmm, no... From C++ standart (8.5, cl. 5): To default-initialize an object of type T means: — if T is a non-POD class type (clause 9), the default constructor for T is called (and the initialization is ill-formed if T has no accessible default constructor); — if T is an array type, each element is default-initialized; — otherwise, the storage for the object is zero-initialized. and vector has explicit vector(size_type n, const T value = T(), const Allocator = Allocator()); so, there will be zeroes by default. Regards, Ivan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED] Change Windows newline to Unix newline
On Mon, 2012-02-27 at 21:58 +0700, Korrawit Pruegsanusak wrote: On Tue, Nov 8, 2011 at 16:19, Michael Meeks michael.me...@suse.com wrote: Nice to clean things up, I wonder if we could grep all of the code for any remaining instances of this fix them ? First, sorry for this 3-months backlog. :( :-) For the record, I've done this at http://cgit.freedesktop.org/libreoffice/core/commit/?id=7b348b9f67ca1138857c34da5b67b479c64a4901 cleaning only the files ended in /\.(h|c)xx/ Wonderful, good to see them comprehensively gone. Thanks, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: MinGW-Port: Problems with UnoUrlResolver
On 02/27/2012 01:07 PM, Helmar Spangenberg wrote: Anyway - using the older toolchain I got a working testing environment and proceded a little bit. I have the impression that the difficulties rise building the local context. As far as I could debug it, everything looks fine until a UnoUrlResolver instance shall be created using the local context. That fails - obviously when checking the_instance.is(). So my guess is, the created local context is incomplete. Checking a little further, it seems that the file uno.ini in my actual working directory is analyzed to set up te local context (unfortunately I do not understand the entries in that file - any hint?); but a little bit further down in the code my debugs signal a NULL context, so that something else is created as local context. I tried to find out where the ini-file is analyzed and/or the local context is created, but I got stuck - the code as a whole is somewhat confusing... Is there anybody who can tell where I should seek to find the context creation functions? Calling defaultBootstrap_InitialComponentContext() (i.e., the variant without arguments) causes the code to pick up a uno ini file next to the cppuhelper dynamic library (see get_unorc in cppuhelper/source/bootstrap.cxx). For the relevant entries in that ini file see UNO Deployment Variables in ure/source/README. Setting up a UNO environment manually for an application is difficult and error prone. The easiest approach is to use the wrapper provided by the SDK, see http://wiki.services.openoffice.org/wiki/Documentation/DevGuide/ProUNO/C%2B%2B/Transparent_Use_of_Office_UNO_Components. Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Most elegant way to disable all BASIC functionality?
Hi, 2012/2/27 Eike Rathke er...@redhat.com: If this is only about no BASIC should be executed, there's the configuration setting behind Tools-Options-Security, Macro Security. If Security Level is set to Very High and no paths are added to Trusted Sources, then no BASIC is executed at all (which btw I strongly recommend as a developer loading bug documents from external sources). So maybe hard-wiring that setting for the App-Store and not offer the dialog would be enough? When I set Macro Security Very High, I can still run the Euro Converter Wizard (written in Basic). Andras ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[REVIEWED] Fix compiling with icecream on ubuntu
Hi Governa, On Sat, 2012-02-25 at 15:34 -0200, Governa wrote: On Ubuntu the icecream GCC_HOME should be /usr/lib/icecc. Added an test to configure.in to use this directory if it exists. Looks lovely, I was just about to commit it, and then ... I noticed that we could really use a full name and E-mail address in your git config, please use: git config user.name “Jim Bob” git config user.email “jim@easy.com And then re-commit that and/or edit the patch :-) Also - it'd really help to have an explicit MPL/LGPLv3+ license statement for all your contributions we can link into: http://wiki.documentfoundation.org/Development/Developers Anyhow - thanks for your first contribution, and looking forward to when you've got it all building. Thanks ! Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[REVIEW][3.5]fdo#46531, spell checking display fun
Hello people, Could someone review and cherry-pick -s this commit into -3-5 branch? http://cgit.freedesktop.org/libreoffice/core/commit/?id=adf45eced404c33be6db884a3e809725e7975872 Thanks, -- Cedric ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED:3-5][PUSHED:3-5-1] fix build with internal libxml on MAC PPC
On 02/27/2012 05:03 PM, Petr Mladek wrote: Fridrich Strba píše v Po 27. 02. 2012 v 12:00 +0100: Please review these three patches that are needed currently for the build of 3.5.1-rc1 with internal libxml on MacOSX 10.4 PPC The change for libcroco looks a bit hacky. Anyway, all the changes look reasonable = pushed into 3-5 branch, see http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5id=b248c3f96b0871779fb01056985413c0372cbcd9 http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5id=1ec7e749a39a39c6fb172232ca4c6a18dc8a0f4e http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5id=bc09b5b62f1eac7a59340d549a5670d732b9a47c We need one approval for 3-5-1 branch. Cherry-picked all three commits into libreoffice-3-5-1 now, too. Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [libreoffice-l10n] [ANN] LibreOffice 3.5.1 RC1 available
Carlo Strata píše v Po 27. 02. 2012 v 11:48 +0100: just installed on my notebbok upgrading a LibreOffice 3.5.0 RC3, Linux, x86-64. I got this message (I translate it from Italian): carlobook:/home/carlo/Download/office/LibreOffice/LibO_3.5.1rc1_Linux_x86-64_install-rpm_en-US/RPMS # rpm -Uvh *.rpm Preparing...### [100%] the file /opt/libreoffice3.5/ure/lib/libstdc++.so.6 conflicts during the installation of the following packages: libreoffice3.5-stdlibs-3.5.1-101.x86_64 and libreoffice3.5-ure-3.5.1-101.x86_64 Ah, it was an ugly bug. It will be fixed in rc2, see https://bugs.freedesktop.org/show_bug.cgi?id=46658 Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [REVIEW 3.5.1 (?)] fdo#46144: Distributy Columns Evenly does not work with the selected columns
On Mon, 2012-02-27 at 19:46 +0400, Ivan Timofeev wrote: On 27.02.2012 19:01, Michael Meeks wrote: Having said that I'm not hyper-happy with not initialising the vector's contents - don't we really want: std::vectorsal_uInt16 aWish( aTablCols.Count() + 1, 0 ), aMins( aTabCols.Count() + 1, 0 ); ... — otherwise, the storage for the object is zero-initialized. Fair enough :-) Patch looks great then, one more ack needed for 3.5.1. Thanks, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED][REVIEW 3.5.1 (?)] fdo#46144: Distributy Columns Evenly does not work with the selected columns
On Mon, 2012-02-27 at 16:15 +, Michael Meeks wrote: On Mon, 2012-02-27 at 19:46 +0400, Ivan Timofeev wrote: On 27.02.2012 19:01, Michael Meeks wrote: Having said that I'm not hyper-happy with not initialising the vector's contents - don't we really want: std::vectorsal_uInt16 aWish( aTablCols.Count() + 1, 0 ), aMins( aTabCols.Count() + 1, 0 ); ... — otherwise, the storage for the object is zero-initialized. Fair enough :-) Patch looks great then, one more ack needed for 3.5.1. I'm happy with this, so pushed now. Re Max and so forth, original conversion should probably have use the Max(255, number) as an input into vector.reserve and then it would have been a 1-for-1 conversion wrt. the push_backs. A good catch. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[LibreOffice] License statement
Hi, all my contributions to LibreOffice are licensed under the terms of the MPL / LGPLv3+. Best Regards, Fernando Governatore ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Ligatures in arabic fonts
Dne Po 27. února 2012 14:27:47, Khaled Hosny napsal(a): This is likely to be an ICU issue, may be it is this issue: https://www.libreoffice.org/bugzilla/show_bug.cgi?id9955 and ICU bug ticket: http://bugs.icu-project.org/trac/ticket/8764 Awesome, it is indeed the fix. Thanks a lot. Cheers Tom signature.asc Description: This is a digitally signed message part. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Fix compiling with icecream on ubuntu
On Ubuntu the icecream GCC_HOME should be /usr/lib/icecc. Added an test to configure.in to use this directory if it exists. Fixed author name and e-mail on the patch. 0001-fix-icecc-compile-in-ubuntu.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice-qa] [ANNOUNCE] libreoffice-3.5.1.1 tag created (3.5.1-rc1)
Michael Stahl píše v Pá 24. 02. 2012 v 17:25 +0100: On 24/02/12 17:19, Petr Mladek wrote: NOTE: The commit deadline for 3.5.1-rc1 is postponed to the following Wedensday/Thursday. We need to give testers some chance to check rc1. you mean the deadline for rc2, right? sure See the attached list of changes against 3.5.0-final. + accessibleTreeNode: fix headless crash (#2, #1, #15, #4, #12, #11, #5, #10, #0, #7, #16, #8, #13, #9, #14, #6, #3) [Michael Stahl] i didn't fix that many bugs, perhaps the script to generate these should assume that 1 to 3 digits are stack frame numbers and not bug ids :) It is generated by git:libreoffice/core/bin/lo-commit-stat. It malforms more commit messages. Feel free to push patches ;-) Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[REVIEWED][3.5]fdo#46531, spell checking display fun
On Mon, 2012-02-27 at 17:07 +0100, Cedric Bosdonnat wrote: Could someone review and cherry-pick -s this commit into -3-5 branch? http://cgit.freedesktop.org/libreoffice/core/commit/?id=adf45eced404c33be6db884a3e809725e7975872 Pushed; thanks :-) Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] fdo44516 cleanup of direct use of RGD color in code
On Mon, 2012-02-27 at 16:25 +0100, Winfried Donkers wrote: Thanks to Norbert Thiebauld a small patch to remove direct use of an RGB-colour from the code. Pushed, thanks :-) Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
