Re: --enable-debug vs --enable-symbols (Re: [Libreoffice-commits] .: 12 commits - config_host.mk.in configure.in filter/source oox/source sal/inc sc/source solenv/gbuild toolkit/source xmlhelp/source)
On Monday 21 of May 2012, Michael Meeks wrote: On Mon, 2012-05-21 at 18:06 +0200, Stephan Bergmann wrote: I rarely use a debugger to step through code, so I prefer to avoid the Egad - is this thread still going on :-) Could we create a set of the pros / cons a concrete proposal for the ESC call on Thursday ? I don't see the point, at least now. The thread is going on (and it's far from endless), because there is something to talk about, and it's mostly about the smaller things which wouldn't be reasonably handled within few minutes of a phone call anyway. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Critical bug in LibreOffice Calc when using mod (showstopper for 3.5.4?)
Robinson Tryon píše v Čt 24. 05. 2012 v 00:01 -0400: On Wed, May 23, 2012 at 7:59 AM, Axel Reimer lopar...@fpgas.de wrote: in LibreOffice Calc 3.5.3 there is a critical bug in the mod function. ...When using =mod=(0,3*100;10) in a cell 3,5527E-015 is displayed as result =mod=(0,6*100;10) in a cell 7,1054E-015 is displayed as result The values for 0,3*100 and 0,6*100 are definitely wrong. This could be a showstopper if this still happens in LibreOffice 3.5.4 RC1. Can someone test if this occurs in 3.5.4 RC1? Ayup. I'm seeing the same behavior in 3.5.4.1. I threw together a test document based on your examples and stapled it to a new bug here: https://bugs.freedesktop.org/show_bug.cgi?id=50299 Thanks a lot for reporting it. It looks ugly. Though, it seems to be only a rounding error. It never worked better. It happens also with other spreadsheet applications. = it can't be blocker. It probably does not cause too many problems in the real life. See https://bugs.freedesktop.org/show_bug.cgi?id=50299#c3 for more details. Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: Branch 'feature/mspub' - config_host.mk.in libmspub/makefile.mk libmspub/prj
config_host.mk.in |2 ++ libmspub/makefile.mk |6 ++ libmspub/prj/build.lst |6 +++--- 3 files changed, 7 insertions(+), 7 deletions(-) New commits: commit 79f79847d0e217e461448d375767bd78aeda2bf7 Author: Fridrich Å trba fridrich.st...@bluewin.ch Date: Thu May 24 14:41:20 2012 +0200 Fix libmspub build Change-Id: I24a1380ec61972a5c59f75a3c1f71552542bce7c diff --git a/config_host.mk.in b/config_host.mk.in index dcc8bc6..8a31f27 100644 --- a/config_host.mk.in +++ b/config_host.mk.in @@ -362,6 +362,8 @@ export MOZ_INC=@MOZ_INC@ export MOZ_LDAP_CFLAGS=@MOZ_LDAP_CFLAGS@ export MOZ_LIB=@MOZ_LIB@ export MOZ_LIB_XPCOM=@MOZ_LIB_XPCOM@ +export MSPUB_CFLAGS=@MSPUB_CFLAGS@ +export MSPUB_LIBS=@MSPUB_LIBS@ export MYSQL_DEFINES=@MYSQL_DEFINES@ export MYSQL_INC=@MYSQL_INC@ export MYSQL_LIB=@MYSQL_LIB@ diff --git a/libmspub/makefile.mk b/libmspub/makefile.mk index e2e0877..f361adc 100644 --- a/libmspub/makefile.mk +++ b/libmspub/makefile.mk @@ -27,8 +27,8 @@ PRJ=. -PRJNAME=cdr -TARGET=cdr +PRJNAME=mspub +TARGET=mspub # --- Settings - @@ -62,8 +62,6 @@ INCPRE+=$(SOLARVER)$/$(INPATH)$/inc$/zlib TARFILE_NAME=libmspub-0.0.0 TARFILE_MD5=8b72793cbe6f152f51e476da053f03bc -#PATCH_FILES=\ - BUILD_ACTION=dmake $(MFLAGS) $(CALLMACROS) BUILD_DIR=src$/lib diff --git a/libmspub/prj/build.lst b/libmspub/prj/build.lst index 151fbeb..05fb74e 100644 --- a/libmspub/prj/build.lst +++ b/libmspub/prj/build.lst @@ -1,3 +1,3 @@ -publibmspub: LIBWPD:libwpd LIBWPG:libwpg ZLIB:zlib soltools NULL -publibmspubusr1- all pub_mkout NULL -publibmspubnmake - all pub_libmspub NULL +mspub libmspub: LIBWPD:libwpd LIBWPG:libwpg ZLIB:zlib soltools NULL +mspub libmspubusr1- all mspub_mkout NULL +mspub libmspubnmake - all mspub_libmspub NULL diff --git a/libmspub/prj/dmake b/libmspub/prj/dmake new file mode 100644 index 000..e69de29 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: per-user installation context on Windows
2012/5/24 Jesús Corrius je...@softcatala.org: If we removed this choice from the UI along with the useless User name/Organization prompts (see fdo#46559), we could have one screen less in the installation wizard. If someone is insisting on installing LibreOffice in per-user context, the ALLUSERS= property can be passed in the command line (also for help packs). What about exchanging that for a language selection screen with the current locale selected automatically? It is possible to select languages in Custom Setup dialog. But most of the users choose Typical setup. What do you think about a reminder on Ready to install dialog: You are going to install the following user interface languages: Catalan, English, You can change this by Custom setup. If you want to review or change any of your installation settings, click Back. ... I cannot imagine a user-friendly language chooser, when we have 106 languages. But maybe somebody else can. :) Andras ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Excel filters for Writer
On Thu, May 24, 2012 at 7:29 AM, Kohei Yoshida kohei.yosh...@gmail.com wrote: On Thu, May 24, 2012 at 2:47 AM, Caolán McNamara caol...@redhat.com wrote: On Wed, 2012-05-23 at 15:56 -0400, Kohei Yoshida wrote: Thanks. What about this one? http://opengrok.libreoffice.org/xref/core/filter/source/config/fragments/filters/StarWriter_DOS.xcu Does the same thinking apply to this one also? I hope yes. The import excel .xls into a word processor filters are just odd in the first place. But the StarWriter for DOS filter presumably makes as much sense as any of the rest of the binfilter filters. What singles StarWriter DOS out as problematic as opposed to say StarWriter 1.0 ? It's associated with the writer_StarWriter_DOS format type which uses .txt as the only extension. So, it gets prioritized when dealing with a plain text file with.txt extension even though it's a binary format. I find that a bit odd. But let's not worry about this. As I understand it, we tend to downplay the significance of file name extensions during type detection, so it's probably not a big deal. If, for any reason a real plain text file is incorrectly classified as starwriter dos document, then we should probably fix the detection service for that format. So, let's conclude this thread. BTW, I've removed those Excel for Writer filter types. That was enough to make my bug disappear, for now. Kohei ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[ANN] LibreOffice 3.5.4 RC2 available
Dear Community, The Document Foundation is happy to announce the second release candidate of LibreOffice 3.5.4. The upcoming 3.5.4 will be the fourth in a series of frequent bugfix releases on our feature-packed 3.5 code line. Please be aware that LibreOffice 3.5.4 RC2 is not ready for production use, you should continue to use LibreOffice 3.5.3 for that. The release is available for Windows, Linux and Mac OS X from our QA builds download page at http://www.libreoffice.org/download/pre-releases/ A note for Windows users: this Release Candidate will uninstall your current stable build and replace it. If you do not wish this to happen but still would like to test, you should follow the instructions for installing in parallel: http://wiki.documentfoundation.org/Installing_in_parallel Should you find bugs, please report them to the FreeDesktop Bugzilla: https://bugs.freedesktop.org A good way to assess the RC2 quality is to run some specific manual tests on it, our TCM wiki page has more details: http://wiki.documentfoundation.org/QA/Testing/Regression_Tests#Full_Regression_Test (and the announcement mail: http://lists.freedesktop.org/archives/libreoffice/2011-December/022464.html) For other ways to get involved with this exciting project - you can e.g. contribute code: https://www.libreoffice.org/get-involved/developers/ translate LibreOffice to your language: http://wiki.documentfoundation.org/Translation_for_3.5 or help with funding our operations: http://challenge.documentfoundation.org/ A list of known issues with 3.5.4 RC2 is available from our wiki: http://wiki.documentfoundation.org/Releases/3.5.4/RC2 Please find the list of changes against LibreOffice 3.5.4 RC1 here: http://download.documentfoundation.org/libreoffice/src/bugfixes-libreoffice-3-5-4-release-3.5.4.2.log Let us close again with a BIG Thank You! to all of you having contributed to the LibreOffice project - this release would not have been possible without your help. Yours, The Document Foundation Board of Directors ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 37361] LibreOffice 3.5 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Cor Nouws c...@nouenoff.nl changed: What|Removed |Added Depends on|37606 | --- Comment #315 from Cor Nouws c...@nouenoff.nl 2012-05-24 07:14:42 PDT --- (In reply to comment #314) Nominating bug 37606 - Writer: Select All doesn't work on a document beginning with a table. It is a very old issue from OpenOffice.org. I guess it's not hard to fix. Sorry, but I removed this one. Just being an old OOo bug does not qualify for 'most annoying'. We could use an extra storage in that cast ;-) -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
minutes of ESC call...
* Present: + Rainer, Petr, David, Eike, Andras, Caolan, Kohei, Norbert, Cedric, Stephen, Michael Stahl * Completed action items + get bytemark win32 upload ssh keys sent / setup (Norbert / Thorsten) * Pending Action Items + pull up misc. internal versions for 3.6 (Fridrich) + switch to ChromeOS fonts in master if no reply from Liberation team (Caolan) + Liberation Fonts 2.0 rebased on ChromeOS will happpen soonish, at which point we'll just upgrade to it + rename VCL API to make it GetBeamerFoo fix (Michael) + [pending] add encryption default UI option in 3.6 (Thorsten) + [in-progress] think over consequences of moving master - 3.6 on release etc. (Rainer) + still finding the best sol'n + [in-progress] create new bugzilla components next week (Rainer) + low priority, still in progress + write 2 paragraph gerrit teaser to dev-list (Bjoern) + connect Rainer with sysadmins wrt. status/live issues ticker + will ping Thorsten again * GSOC update (Cedric) + coding starting, looking good + lazlo pinged + if you can't find your student, ping Fridrich or Cedric * UI / design update (Astron/Mirek) + not around * Release Engineering update (Petr) + 3.5.4 + untranslated shortcuts, can live without them for 3.5.4 + 3.6 status + an Alpha0 build due next week + this is just an early we-can-build on all platforms preparatory step * git submodules status (Norbert) + sounds good + regular stuff works, edge-cases still needs testing * build / tinderbox machines + bytemark windows box up and running and uploading + bytemark linux box pending time * QA update (Rainer) + best builds for windows testing to get backtraces ? + use bytemark box builds, tinderbox #20 + regressions + could be that up to 12 (8 in writer) regressions are border-line related (mstahl) + if we split the regressions query into crashes and non-crashes we could probably quicker chew through the crashers which are typically easy to fix (caolanm) http://wiki.documentfoundation.org/Talk:BugReport_Details * 3.5 most annoying bugs ... + 60 open (of 213) older 67/211 68/205 71/205 68/199 74/201 73/193 66/183 28% 32% 33% 35% 34%37% 38%36% + https://bugs.freedesktop.org/showdependencytree.cgi?id=37361hide_resolved=1 * QA update (Rainer) * 3.5 most annoying bugs ... + 62 open (of 219) https://bugs.freedesktop.org/showdependencytree.cgi?id=37361hide_resolved=1 * 3.5 bugs tagged with 'regression' + 161(+10) bugs open of 567(+11) total * Componentcount net * + Writer - 64 (+6) + Presentation - 18 (+0) + LibreOffice - 16 (+1) + Spreadsheet - 12 (-1) + Drawing - 9 (+0) + Database - 9 (+0) + Writer / RTF - 9 (+2) + Basic- 2 (+0) + https://bugs.freedesktop.org/buglist.cgi?keywords=regression% 2C% 20keywords_type=allwordsresolution=---query_format=advancedproduct=LibreOfficelist_id=79522 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: build time optimization
On Thu, May 24, 2012 at 2:23 AM, David Ostrovsky d.ostrov...@idaia.de wrote: Hi, I'm trying to accelerate LO (developer) build on linux_x86-64 system. Before you point me to wiki (distributed build, ccache and friends) and tell me to use ramdisk: I already did it all and it is still need to be optimized ;-) It is not that certain that ramdisk on linux really helps. ramdisk eat-up memory that cannot be used for fs-cache... so ramdisk will increase the cache-miss at the kernel level... ramdisk on Mac help tremendously because of how horrible HFS is lock-wise. I have not tested ramdisk on Windows, so I do not know how effective it is. Norbert ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: sfx2/source
sfx2/source/control/unoctitm.cxx | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) New commits: commit f6d9b4afbda6cf1a3db822b5fb5125448ef9e1d1 Author: Kohei Yoshida kohei.yosh...@gmail.com Date: Thu May 24 11:40:46 2012 -0400 Delete SfxItemSet before the current shell gets destroyed. SfxItemSet takes hold of the SfxItemPool instance from the current shell, and accesses it when it gets destroyed. The problem arises when the current shell gets destroyed before the SfxItemSet instnace does, in which case an illegal memory access ensues. This fixes intermittent crashes when opening a document in Writer. Change-Id: Ib5e74b43051f868f22f6efdb311e6c2a75326d9a diff --git a/sfx2/source/control/unoctitm.cxx b/sfx2/source/control/unoctitm.cxx index 005db6e..360590f 100644 --- a/sfx2/source/control/unoctitm.cxx +++ b/sfx2/source/control/unoctitm.cxx @@ -67,6 +67,8 @@ #include sfx2/msgpool.hxx #include sfx2/objsh.hxx +#include boost/scoped_ptr.hpp + namespace css = ::com::sun::star; using namespace ::com::sun::star::uno; using namespace ::com::sun::star::util; @@ -725,16 +727,20 @@ void SAL_CALL SfxDispatchController_Impl::dispatch( const ::com::sun::star::util } eMapUnit = GetCoreMetric( pShell-GetPool(), GetId() ); -SfxAllItemSet aSet( pShell-GetPool() ); -TransformParameters( GetId(), lNewArgs, aSet, pSlot ); -if ( aSet.Count() ) +boost::scoped_ptrSfxAllItemSet xSet(new SfxAllItemSet(pShell-GetPool())); +TransformParameters(GetId(), lNewArgs, *xSet, pSlot); +if (xSet-Count()) { // execute with arguments - call directly -pItem = pDispatcher-Execute( GetId(), nCall, aSet, aInternalSet, nModifier ); +pItem = pDispatcher-Execute(GetId(), nCall, xSet.get(), aInternalSet, nModifier); bSuccess = (pItem != NULL); } else { +// Be sure to delete this before we send a dispatch +// request, which will destroy the current shell. +xSet.reset(); + // execute using bindings, enables support for toggle/enum etc. SfxRequest aReq( GetId(), nCall, pShell-GetPool() ); aReq.SetModifier( nModifier ); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: build time optimization
On Thu, May 24, 2012 at 5:08 PM, Norbert Thiebaud nthieb...@gmail.com wrote: I have not tested ramdisk on Windows, so I do not know how effective it is. I'm running a tinderbox with a ramdisk on Windows - reduces build time dramatically. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice-qa] minutes of ESC call...
2012/5/24 Caolán McNamara caol...@redhat.com: * QA update (Rainer) + best builds for windows testing to get backtraces ? + use bytemark box builds, tinderbox #20 On Windows, symbols are not embedded in executables but they are in separate .pdb files. Please zip *.pdb from solver together and upload it next to the installer, otherwise it will not be possible to produce backtraces. Andras ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: 4 commits - sw/qa sw/source writerfilter/source
sw/qa/extras/ooxmltok/data/n652364.docx |binary sw/qa/extras/ooxmltok/data/n750255.docx |binary sw/qa/extras/ooxmltok/ooxmltok.cxx | 88 +++- sw/qa/extras/ww8tok/data/n652364.doc|binary sw/qa/extras/ww8tok/data/n750255.doc|binary sw/qa/extras/ww8tok/ww8tok.cxx | 82 ++ sw/source/filter/ww8/ww8par.cxx |6 + writerfilter/source/dmapper/PropertyMap.cxx | 18 + 8 files changed, 189 insertions(+), 5 deletions(-) New commits: commit fe7a4aad76c051bc46ae46b175fb182b6e7e3f89 Author: LuboÅ¡ LuÅák l.lu...@suse.cz Date: Thu May 24 17:58:27 2012 +0200 testcases for bnc#652364 and bnc#750255 for .docx too Change-Id: I4a98f4df6fde3f52b099fa627baa861f496bb452 diff --git a/sw/qa/extras/ooxmltok/data/n652364.docx b/sw/qa/extras/ooxmltok/data/n652364.docx new file mode 100644 index 000..0845509 Binary files /dev/null and b/sw/qa/extras/ooxmltok/data/n652364.docx differ diff --git a/sw/qa/extras/ooxmltok/data/n750255.docx b/sw/qa/extras/ooxmltok/data/n750255.docx new file mode 100644 index 000..a0c7370 Binary files /dev/null and b/sw/qa/extras/ooxmltok/data/n750255.docx differ diff --git a/sw/qa/extras/ooxmltok/ooxmltok.cxx b/sw/qa/extras/ooxmltok/ooxmltok.cxx index abd1a2d..fb5e3d2 100644 --- a/sw/qa/extras/ooxmltok/ooxmltok.cxx +++ b/sw/qa/extras/ooxmltok/ooxmltok.cxx @@ -59,6 +59,8 @@ public: void testN705956_1(); void testN705956_2(); void testN747461(); +void testN750255(); +void testN652364(); CPPUNIT_TEST_SUITE(Test); #if !defined(MACOSX) !defined(WNT) @@ -72,6 +74,8 @@ public: CPPUNIT_TEST(testN705956_1); CPPUNIT_TEST(testN705956_2); CPPUNIT_TEST(testN747461); +CPPUNIT_TEST(testN750255); +CPPUNIT_TEST(testN652364); #endif CPPUNIT_TEST_SUITE_END(); @@ -321,6 +325,84 @@ after they are loaded. CPPUNIT_ASSERT_EQUAL( OUString( Green ), descr3 ); } +void Test::testN750255() +{ +load( n750255.docx ); + +/* +Column break without columns on the page is a page break, so check those paragraphs +are on page 2 (page style 'Converted1') and page 3 (page style 'Converted2') +enum = ThisComponent.Text.createEnumeration +enum.nextElement +para1 = enum.nextElement +xray para1.String +xray para1.PageStyleName +para2 = enum.nextElement +xray para2.String +xray para2.PageStyleName +*/ +uno::Referencetext::XTextDocument textDocument(mxComponent, uno::UNO_QUERY); +uno::Referencecontainer::XEnumerationAccess paraEnumAccess(textDocument-getText(), uno::UNO_QUERY); +// list of paragraphs +uno::Referencecontainer::XEnumeration paraEnum = paraEnumAccess-createEnumeration(); +// go to 1st paragraph +(void) paraEnum-nextElement(); +// get the 2nd and 3rd paragraph +uno::Referenceuno::XInterface paragraph1(paraEnum-nextElement(), uno::UNO_QUERY); +uno::Referenceuno::XInterface paragraph2(paraEnum-nextElement(), uno::UNO_QUERY); +uno::Referencetext::XTextRange text1(paragraph1, uno::UNO_QUERY); +uno::Referencetext::XTextRange text2(paragraph2, uno::UNO_QUERY); +CPPUNIT_ASSERT_EQUAL( OUString( one ), text1-getString()); +CPPUNIT_ASSERT_EQUAL( OUString( two ), text2-getString()); +uno::Referencebeans::XPropertySet paragraphProperties1(paragraph1, uno::UNO_QUERY); +uno::Referencebeans::XPropertySet paragraphProperties2(paragraph2, uno::UNO_QUERY); +OUString pageStyle1, pageStyle2; +paragraphProperties1-getPropertyValue( PageStyleName ) = pageStyle1; +paragraphProperties2-getPropertyValue( PageStyleName ) = pageStyle2; +CPPUNIT_ASSERT_EQUAL( OUString( Converted1 ), pageStyle1 ); +CPPUNIT_ASSERT_EQUAL( OUString( Converted2 ), pageStyle2 ); + +} + +void Test::testN652364() +{ +load( n652364.docx ); + +/* +Related to 750255 above, column break with columns on the page however should be a column break. +enum = ThisComponent.Text.createEnumeration +enum.nextElement +para1 = enum.nextElement +xray para1.String +xray para1.PageStyleName +enum.nextElement +para2 = enum.nextElement +xray para2.String +xray para2.PageStyleName +*/ +uno::Referencetext::XTextDocument textDocument(mxComponent, uno::UNO_QUERY); +uno::Referencecontainer::XEnumerationAccess paraEnumAccess(textDocument-getText(), uno::UNO_QUERY); +// list of paragraphs +uno::Referencecontainer::XEnumeration paraEnum = paraEnumAccess-createEnumeration(); +// get the 2nd and 4th paragraph +(void) paraEnum-nextElement(); +uno::Referenceuno::XInterface paragraph1(paraEnum-nextElement(), uno::UNO_QUERY); +(void) paraEnum-nextElement(); +uno::Referenceuno::XInterface paragraph2(paraEnum-nextElement(), uno::UNO_QUERY); +uno::Referencetext::XTextRange text1(paragraph1, uno::UNO_QUERY); +uno::Referencetext::XTextRange text2(paragraph2, uno::UNO_QUERY); +CPPUNIT_ASSERT_EQUAL( OUString( text1 ), text1-getString()); +CPPUNIT_ASSERT_EQUAL(
[Libreoffice-commits] .: 8 commits - oox/CustomTarget_generated.mk oox/Library_oox.mk oox/Module_oox.mk oox/Package_generated.mk oox/source sc/Library_scfilt.mk
oox/CustomTarget_generated.mk | 62 oox/Library_oox.mk| 56 +- oox/Module_oox.mk |1 oox/Package_generated.mk |3 - oox/source/token/Makefile | 126 -- sc/Library_scfilt.mk |1 6 files changed, 69 insertions(+), 180 deletions(-) New commits: commit d1384b4253325764ea2cf30b7afa86ce27ef418f Author: Michael Stahl mst...@redhat.com Date: Thu May 24 16:58:46 2012 +0200 sc: fix bogus -I$(WORKDIR)/other_module diff --git a/oox/Package_generated.mk b/oox/Package_generated.mk index 25152d2..2af5832 100644 --- a/oox/Package_generated.mk +++ b/oox/Package_generated.mk @@ -29,6 +29,7 @@ $(eval $(call gb_Package_Package,oox_generated,$(call gb_CustomTarget_get_workdi $(eval $(call gb_Package_add_file,oox_generated,inc/oox/token/tokens.hxx,inc/oox/token/tokens.hxx)) $(eval $(call gb_Package_add_file,oox_generated,inc/oox/token/namespaces.hxx,inc/oox/token/namespaces.hxx)) +$(eval $(call gb_Package_add_file,oox_generated,inc/oox/token/properties.hxx,inc/oox/token/properties.hxx)) $(eval $(call gb_Package_add_file,oox_generated,inc/oox/namespaces.txt,misc/namespaces.txt)) # vim: set noet sw=4 ts=4: diff --git a/sc/Library_scfilt.mk b/sc/Library_scfilt.mk index 3d81d71..d582e22 100644 --- a/sc/Library_scfilt.mk +++ b/sc/Library_scfilt.mk @@ -29,7 +29,6 @@ $(eval $(call gb_Library_set_include,scfilt,\ -I$(SRCDIR)/sc/source/filter/inc \ -I$(SRCDIR)/sc/source/ui/inc \ -I$(SRCDIR)/sc/inc \ - -I$(WORKDIR)/oox/inc \ $$(INCLUDE) \ )) commit d89fe2764c198df405420447952aac81282e151e Author: Michael Stahl mst...@redhat.com Date: Thu May 24 15:18:14 2012 +0200 oox: remove duplicate custom makefile from writerfilter10 diff --git a/oox/source/token/Makefile b/oox/source/token/Makefile deleted file mode 100644 index cdd94e7..000 --- a/oox/source/token/Makefile +++ /dev/null @@ -1,126 +0,0 @@ -#* -# -# DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. -# -# Copyright 2009 by Sun Microsystems, Inc. -# -# OpenOffice.org - a multi-platform office productivity suite -# -# This file is part of OpenOffice.org. -# -# OpenOffice.org is free software: you can redistribute it and/or modify -# it under the terms of the GNU Lesser General Public License version 3 -# only, as published by the Free Software Foundation. -# -# OpenOffice.org is distributed in the hope that it will be useful, -# but WITHOUT ANY WARRANTY; without even the implied warranty of -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -# GNU Lesser General Public License version 3 for more details -# (a copy is included in the LICENSE file that accompanied this code). -# -# You should have received a copy of the GNU Lesser General Public License -# version 3 along with OpenOffice.org. If not, see -# http://www.openoffice.org/license.html -# for a copy of the LGPLv3 License. -# -#* - -# generate source and header files from text files - -SRCDIR_TOKEN := $(dir $(realpath $(firstword $(MAKEFILE_LIST -WORKDIR_TOKEN := . - -include $(GBUILDDIR)/Output.mk -include $(GBUILDDIR)/BuildDirs.mk -include $(GBUILDDIR)/Helper.mk - -# XML namespace identifiers and names - -$(WORKDIR_TOKEN)/namespaces.hxx : $(SRCDIR_TOKEN)/namespaces.hxx.head $(WORKDIR_TOKEN)/namespaceids.inc $(SRCDIR_TOKEN)/namespaces.hxx.tail - $(call gb_Output_announce,$@,build,CAT,1) - $(call gb_Helper_abbreviate_dirs,cat $^ $@) - -$(WORKDIR_TOKEN)/namespaceids.inc : $(SRCDIR_TOKEN)/namespaces.txt $(SRCDIR_TOKEN)/namespaces.pl - $(call gb_Output_announce,$@,build,PRL,1) - $(call gb_Helper_abbreviate_dirs, \ - mkdir -p $(dir $@) $(PERL) $(SRCDIR_TOKEN)/namespaces.pl 1 $ $@ \ - ) - -$(WORKDIR_TOKEN)/namespacenames.inc : $(SRCDIR_TOKEN)/namespaces.txt $(SRCDIR_TOKEN)/namespaces.pl - $(call gb_Output_announce,$@,build,PRL,1) - $(call gb_Helper_abbreviate_dirs, \ - mkdir -p $(dir $@) $(PERL) $(SRCDIR_TOKEN)/namespaces.pl 2 $ $@ \ - ) - -$(WORKDIR_TOKEN)/namespaces.txt : $(SRCDIR_TOKEN)/namespaces.txt $(SRCDIR_TOKEN)/namespaces.pl - $(call gb_Output_announce,$@,build,PRL,1) - $(call gb_Helper_abbreviate_dirs, \ - mkdir -p $(dir $@) $(PERL) $(SRCDIR_TOKEN)/namespaces.pl 3 $ $@ \ - ) - -# XML token identifiers and names - -$(WORKDIR_TOKEN)/tokens.hxx : $(SRCDIR_TOKEN)/tokens.hxx.head $(WORKDIR_TOKEN)/tokenids.inc $(SRCDIR_TOKEN)/tokens.hxx.tail - $(call gb_Output_announce,$@,build,CAT,1) - $(call gb_Helper_abbreviate_dirs,cat $^ $@) - -$(WORKDIR_TOKEN)/tokenids.inc : $(SRCDIR_TOKEN)/tokens.txt $(SRCDIR_TOKEN)/tokens.pl - $(call gb_Output_announce,$@,build,PRL,1) - $(call
Re: build time optimization
On Thu, May 24, 2012 at 10:44 AM, Noel Grandin noelgran...@gmail.com wrote: On Thu, May 24, 2012 at 5:08 PM, Norbert Thiebaud nthieb...@gmail.com wrote: I have not tested ramdisk on Windows, so I do not know how effective it is. I'm running a tinderbox with a ramdisk on Windows - reduces build time dramatically. can you post an How-to ? (and possibly some numbers) Note: I do not have enough memory to use it... but I may consider investing in some RAM if that is worth it... Norbert ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice-ux-advise] [PATCH] fdo#34772 Word count / statistics in the status bar
Thanks for the help! I created a followup patch that makes the strings as resources: https://bugs.freedesktop.org/attachment.cgi?id=62063 Review: https://bugs.freedesktop.org/page.cgi?id=splinter.htmlbug=34772attachment=62063 Regards, --Muhammad ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: libvisio/libvisio-0.0.16-fdo50178.patch libvisio/makefile.mk
libvisio/libvisio-0.0.16-fdo50178.patch | 29 + libvisio/makefile.mk|1 + 2 files changed, 30 insertions(+) New commits: commit 03764e29978bcf0b59a3738166b5af31d0af582a Author: Julien Nabet serval2...@yahoo.fr Date: Thu May 24 20:36:21 2012 +0200 Resolves: fdo#50178 Reading Visio file causes crash Problem with iterators, more info here : http://nabble.documentfoundation.org/PATCH-fix-proposed-for-fdo-50178-Visio-td3985678.html Change-Id: Ie7131e8bc79539b3a2a5f86608a4574e1ac0fbf8 diff --git a/libvisio/libvisio-0.0.16-fdo50178.patch b/libvisio/libvisio-0.0.16-fdo50178.patch new file mode 100644 index 000..e05887a --- /dev/null +++ b/libvisio/libvisio-0.0.16-fdo50178.patch @@ -0,0 +1,29 @@ +--- misc/build/libvisio-0.0.16/src/lib/VSDXContentCollector.cpp 2012-04-14 17:29:03.0 +0200 misc/libvisio-0.0.16/src/lib/VSDXContentCollector.cpp 2012-05-23 22:30:44.542099908 +0200 +@@ -1470,7 +1470,8 @@ + /* NURBS with incomplete data */ + void libvisio::VSDXContentCollector::collectNURBSTo(unsigned id, unsigned level, double x2, double y2, double knot, double knotPrev, double weight, double weightPrev, unsigned dataID) + { +- std::mapunsigned, NURBSData::const_iterator iter; ++ std::mapunsigned, NURBSData::const_iterator iter; ++ std::mapunsigned, NURBSData::const_iterator iterEnd; + NURBSData data; + if (dataID == 0xFFFE) // Use stencil NURBS data + { +@@ -1490,13 +1491,15 @@ + } + dataID = tmpElement-m_dataID; + iter = m_stencilShape-m_nurbsData.find(dataID); ++iterEnd = m_stencilShape-m_nurbsData.end(); + } + else // No stencils involved, directly get dataID and fill in missing parts + { + iter = m_NURBSData.find(dataID); ++iterEnd = m_NURBSData.end(); + } + +- if (iter != m_NURBSData.end()) ++ if (iter != iterEnd) + { + data = iter-second; + data.knots.push_back(knot); diff --git a/libvisio/makefile.mk b/libvisio/makefile.mk index 2a1be7e..29e8658 100644 --- a/libvisio/makefile.mk +++ b/libvisio/makefile.mk @@ -59,6 +59,7 @@ TARFILE_MD5=2fa6028324347860e684e75310818d43 PATCH_FILES=\ $(TARFILE_NAME)-nothrow.patch \ +$(TARFILE_NAME)-fdo50178.patch \ $(TARFILE_NAME).patch ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[PUSHED on master][PATCH] fix proposed for fdo#50178 (Visio)
Thank you Michael for your review. I commited and pushed it on master (http://cgit.freedesktop.org/libreoffice/core/commit/?id=03764e29978bcf0b59a3738166b5af31d0af582a) Would it be ok for 3.5 branch ? Julien. -- View this message in context: http://nabble.documentfoundation.org/PATCH-fix-proposed-for-fdo-50178-Visio-tp3985678p3985876.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice-qa] minutes of ESC call...
Hi everyone, Sorry that I didn't attend the esc call, but I had issues with the freephone service which wouldn't let me connect. Anyway, here's what I wanted to mention: 1) Wer're done with the design of the template picker (http://wiki.documentfoundation.org/Design/Templates_and_documents_rework#Tentative_Design). We already had a conversation with Rafael and there don't seem to be any issues 2) The design of the Remote Control is mostly done (http://wiki.documentfoundation.org/Design/Whiteboards/Impress_remote#Tentative_Design). We'd need to know whether the last few connections (and PINs) would be saved. That would allow automatical reconnecting without having to regenerate and enter the PIN 3) The file manager part of the Android UI is done (http://wiki.documentfoundation.org/Design/Whiteboards/File_Manager#Tentative_Design). Will the GSoC student work on that first or the GUI that actually displays the files' content? Feedback from the GSoC participants would be appreciated Templates (I'll discuss this with Bjoern next week) : - Where should source files be stored? (Blender files, SVGs used to create the backdrops) Maybe on the Wiki? = Allows others to actually improve the templates without having to redo everything - Will only master slides be included or also a new default style for Writer? - Could we drop all the old master slides? They're not very modern - I've got 8 new masterslides that are ready for inclusion ( http://wiki.documentfoundation.org/Design/Call_for_Templates ) - Is it OK to use fonts licensed under the Open Font License that are currently not included in LibO? - Is there a final decision whether we'll use flat ODF files or regular ott, otp etc.? Kind Regards Alex -- View this message in context: http://nabble.documentfoundation.org/minutes-of-ESC-call-tp3985834p3985880.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: 3.5.3rc1 win32 / debug package ...
On Wed, May 23, 2012 at 3:11 PM, Petr Mladek - pmla...@suse.cz wrote: Please consider. Always you can ask the friendly guys at Mozilla how to set this all up... Thanks for tip. What a discovery! Seems like complete how to: http://zenit.senecac.on.ca/wiki/index.php/Mozilla_Source_and_Symbol_Server Blog postings, bugs on b.m.o, other resources also worth of checking: http://crashopensource.wordpress.com/2007/09/20/starting-the-project-mozilla-source-and-symbol-server/ https://bugzilla.mozilla.org/show_bug.cgi?id=385792 https://bugzilla.mozilla.org/show_bug.cgi?id=408134 https://bugzilla.mozilla.org/show_bug.cgi?id=419904 https://bugzilla.mozilla.org/show_bug.cgi?id=424240 https://bugzilla.mozilla.org/show_bug.cgi?id=424817 https://bugzilla.mozilla.org/show_bug.cgi?id=428518 http://web.archive.org/web/20071218162257/http://www.jorgon.freeserve.co.uk/Other/pdb.htm Best regards. P.S. It would be great if ESC could go the Mozilla's path of doing things in QA department. The knowledge base is on Mozilla's wiki. Software is... open sourced and available to download. You should get connected to make LO better. Definitely. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: solenv/bin
solenv/bin/modules/installer/windows/file.pm |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit bf799459d8e8eabd764450c82450036c5d0e742f Author: Andras Timar ati...@suse.com Date: Thu May 24 22:36:21 2012 +0200 fdo#48087 fill in MsiFileHash table for unversioned files Change-Id: I7d409fbe813f07dc87301b6c6f01a40f531d368c diff --git a/solenv/bin/modules/installer/windows/file.pm b/solenv/bin/modules/installer/windows/file.pm index f694fbe..2279129 100644 --- a/solenv/bin/modules/installer/windows/file.pm +++ b/solenv/bin/modules/installer/windows/file.pm @@ -1018,7 +1018,7 @@ sub create_files_table if ( ! exists($installer::globals::languageproperties{$property}) ) { $installer::globals::languageproperties{$property} = $value; } } -if ( $installer::globals::prepare_winpatch ) +unless ( $file{'Version'} ) { my $path = $onefile-{'sourcepath'}; if ( $^O =~ /cygwin/i ) { $path = $onefile-{'cyg_sourcepath'}; } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[PATCH] fdo#35973 - [EasyHack] Remember the state of the sidebar pane in Impress
Hi All, This patch makes the SlideSorter-toolbar in Impress and Draw remember if it was visible or not for each view. When this patch is accepted then I'll create a similar patch for the ToolPanel-toolbar. -- Greetings, Rob Snelders From d0152a068a92019131032a03bf39f00fb2fc7bf5 Mon Sep 17 00:00:00 2001 From: Rob Snelders programm...@ertai.nl Date: Thu, 24 May 2012 21:59:57 +0200 Subject: [PATCH] fdo#35973 [EasyHack] Remember the state of the sidebar pane in Impress --- .../drawing/framework/XConfigurationController.idl |6 + .../data/org/openoffice/Office/Impress.xcu | 22 + .../schema/org/openoffice/Office/Impress.xcs | 44 ++- .../configuration/ConfigurationController.cxx | 10 +- sd/source/ui/framework/module/ResourceManager.cxx | 24 +- sd/source/ui/framework/module/ResourceManager.hxx |3 + .../ui/framework/module/SlideSorterModule.cxx | 31 +- .../ui/framework/module/SlideSorterModule.hxx |2 +- .../ui/inc/framework/ConfigurationController.hxx |3 + svtools/Library_svt.mk |1 + svtools/Package_inc.mk |1 + svtools/inc/svtools/slidesorterbaropt.hxx | 134 + svtools/source/config/slidesorterbaropt.cxx| 580 13 files changed, 846 insertions(+), 15 deletions(-) create mode 100644 svtools/inc/svtools/slidesorterbaropt.hxx create mode 100644 svtools/source/config/slidesorterbaropt.cxx diff --git a/offapi/com/sun/star/drawing/framework/XConfigurationController.idl b/offapi/com/sun/star/drawing/framework/XConfigurationController.idl index 4c0fd46..1e7cdb2 100644 --- a/offapi/com/sun/star/drawing/framework/XConfigurationController.idl +++ b/offapi/com/sun/star/drawing/framework/XConfigurationController.idl @@ -154,6 +154,12 @@ interface XConfigurationController interface XConfigurationControllerBroadcaster; interface XResourceFactoryManager; +/** Check if the ConfigurationController is disposing +@return +When the ConfigurationController is disposing then true else false +*/ +boolean IsDisposing (); + /** Request the activation of a resource. pThe request is processed asynchronously. Notifications about configuration changes are sent after this call returns./p diff --git a/officecfg/registry/data/org/openoffice/Office/Impress.xcu b/officecfg/registry/data/org/openoffice/Office/Impress.xcu index 6101cef..f894ccb 100644 --- a/officecfg/registry/data/org/openoffice/Office/Impress.xcu +++ b/officecfg/registry/data/org/openoffice/Office/Impress.xcu @@ -28,6 +28,28 @@ !DOCTYPE oor:component-data SYSTEM ../../../../component-update.dtd oor:component-data oor:name=Impress oor:package=org.openoffice.Office xmlns:install=http://openoffice.org/2004/installation; xmlns:oor=http://openoffice.org/2001/registry; xmlns:xs=http://www.w3.org/2001/XMLSchema; xmlns:xsi=http://www.w3.org/2001/XMLSchema-instance; node oor:name=MultiPaneGUI +node oor:name=SlideSorterBar + node oor:name=Visible +prop oor:name=ImpressView + valuetrue/value +/prop +prop oor:name=OutlineView + valuetrue/value +/prop +prop oor:name=NotesView + valuetrue/value +/prop +prop oor:name=HandoutView + valuefalse/value +/prop +prop oor:name=SlideSorterView + valuefalse/value +/prop +prop oor:name=DrawView + valuetrue/value +/prop + /node +/node node oor:name=Framework node oor:name=ResourceFactories node oor:name=F0 oor:op=replace diff --git a/officecfg/registry/schema/org/openoffice/Office/Impress.xcs b/officecfg/registry/schema/org/openoffice/Office/Impress.xcs index 094cee5..8350429 100644 --- a/officecfg/registry/schema/org/openoffice/Office/Impress.xcs +++ b/officecfg/registry/schema/org/openoffice/Office/Impress.xcs @@ -1402,11 +1402,53 @@ /info /set /group - group oor:name=SlideSorter + group oor:name=SlideSorterBar info descValues related to the slide sorter./desc labelSlide Sorter Options/label /info +group oor:name=Visible + info +descOptions that control the visibility of the slide sorter./desc +labelSlide Sorter Visibility/label + /info + prop oor:name=ImpressView oor:type=xs:boolean +info + descVisibility of the Slide Sorter in the Impress view./desc + labelSlide Sorter Visibility ImpressView/label +/info + /prop + prop oor:name=OutlineView oor:type=xs:boolean +info + descVisibility of the Slide Sorter in the Outline view./desc + labelSlide Sorter Visibility OutlineView/label +/info + /prop + prop oor:name=NotesView oor:type=xs:boolean +
[PATCH] CLucene contribs-lib artifacts were missing
Hi, just for the record, this was the missing patch for system wide CLucene installation. I'm not sure if we want it in this place. I didn't include it in the list of applied patches in CustomTarget_source.mk but I guess it wouldn't hurt. Ciao David From cfd4a041c5c6ef10701dfa0ac0027640415192d5 Mon Sep 17 00:00:00 2001 From: David Ostrovsky david.ostrov...@gmx.de Date: Thu, 24 May 2012 22:54:07 +0200 Subject: [PATCH] CLucene contribs-lib artifacts were missing during system wide installation Change-Id: I11e9b17336a16bfcaceebe7613c156ff3e2b94d1 --- clucene/patches/contribs-lib-makefile.patch | 23 +++ 1 files changed, 23 insertions(+), 0 deletions(-) create mode 100644 clucene/patches/contribs-lib-makefile.patch diff --git a/clucene/patches/contribs-lib-makefile.patch b/clucene/patches/contribs-lib-makefile.patch new file mode 100644 index 000..1d66cde --- /dev/null +++ b/clucene/patches/contribs-lib-makefile.patch @@ -0,0 +1,23 @@ +--- src/contribs-lib/CMakeLists.txt 2012-05-24 22:38:20.002443317 +0200 src/contribs-lib/CMakeLists.txt 2012-05-24 22:38:05.218443899 +0200 +@@ -113,3 +113,20 @@ + COMPILE_DEFINITIONS_DEBUG _DEBUG + ) + ++#install lib ++install(TARGETS clucene-contribs-lib ++ DESTINATION ${LIB_DESTINATION} ++ COMPONENT runtime ) ++ ++#install public headers. ++FOREACH(file ${HEADERS}) ++ get_filename_component(apath ${file} PATH) ++ get_filename_component(aname ${file} NAME) ++ file(RELATIVE_PATH relpath ${CMAKE_SOURCE_DIR}/src/contribs-lib ${apath}) ++ IF ( NOT aname MATCHES ^_.* ) ++ install(FILES ${file} ++ DESTINATION include/${relpath} ++ COMPONENT development) ++ ENDIF ( NOT aname MATCHES ^_.* ) ++ENDFOREACH(file) ++ -- 1.7.5.4 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: Branch 'feature/gsoc-calc-perf' - sc/source
sc/source/filter/xml/xmlcelli.cxx | 119 +- sc/source/filter/xml/xmlsubti.cxx |3 sc/source/filter/xml/xmlsubti.hxx |2 3 files changed, 56 insertions(+), 68 deletions(-) New commits: commit 1ddcc44190a690a3ac221a8c4b38d830046f03ef Author: Daniel Bankston daniel.e.banks...@gmail.com Date: Thu May 24 16:31:34 2012 -0500 Make suggested code style changes Change-Id: I9cd71b78098adc6b0fee1139ffb1a1202d9981dc diff --git a/sc/source/filter/xml/xmlcelli.cxx b/sc/source/filter/xml/xmlcelli.cxx index 9d1c7c0..89bf499 100644 --- a/sc/source/filter/xml/xmlcelli.cxx +++ b/sc/source/filter/xml/xmlcelli.cxx @@ -455,64 +455,61 @@ SvXMLImportContext *ScXMLTableRowCellContext::CreateChildContext( sal_uInt16 nPr return pContext; } -namespace +namespace { + +static bool ScCellExists( const ScAddress rScAddress ) { -static bool lcl_ScCellExists( const ScAddress rScAddress ) -{ -return( rScAddress.Col() = MAXCOL rScAddress.Row() = MAXROW ); -} +return( rScAddress.Col() = MAXCOL rScAddress.Row() = MAXROW ); +} -static ScRange lcl_ScGetCellRangeByPosition( const ScRange rScRange, const SCCOL nLeft, const SCROW nTop, const SCCOL nRight, const SCROW nBottom ) -throw( lang::IndexOutOfBoundsException ) +ScRange getCellRangeByPosition( const ScRange rScRange, const SCCOL nLeft, const SCROW nTop, const SCCOL nRight, const SCROW nBottom ) +{ +if( nLeft = 0 nTop = 0 nRight = 0 nBottom = 0 ) { -if( nLeft = 0 nTop = 0 nRight = 0 nBottom = 0 ) -{ -SCCOL nStartX = rScRange.aStart.Col() + nLeft; -SCROW nStartY = rScRange.aStart.Row() + nTop; -SCCOL nEndX = rScRange.aStart.Col() + nRight; -SCROW nEndY = rScRange.aStart.Row() + nBottom; - -if( nStartX = nEndX nEndX = rScRange.aEnd.Col() -nStartY = nEndY nEndY = rScRange.aEnd.Row() ) -{ -return ScRange( nStartX, nStartY, rScRange.aStart.Tab(), nEndX, nEndY, rScRange.aEnd.Tab() ); -} -} -throw lang::IndexOutOfBoundsException(); -} +SCCOL nStartX = rScRange.aStart.Col() + nLeft; +SCROW nStartY = rScRange.aStart.Row() + nTop; +SCCOL nEndX = rScRange.aStart.Col() + nRight; +SCROW nEndY = rScRange.aStart.Row() + nBottom; -static ScRange lcl_ScGetCellRangeByPosition( const ScRange rScRange, const ScAddress rScCell ) throw( lang::IndexOutOfBoundsException ) -{ -try +if( nStartX = nEndX nEndX = rScRange.aEnd.Col() +nStartY = nEndY nEndY = rScRange.aEnd.Row() ) { -return lcl_ScGetCellRangeByPosition( rScRange, rScCell.Col(), rScCell.Row(), rScCell.Col(), rScCell.Row() ); +return ScRange( nStartX, nStartY, rScRange.aStart.Tab(), nEndX, nEndY, rScRange.aEnd.Tab() ); } -catch( lang::IndexOutOfBoundsException ) { throw; } } +return ScRange( ScAddress::INITIALIZE_INVALID ); +} + +ScRange getCellRangeByPosition( const ScRange rScRange, const ScAddress rScCell ) +{ +return getCellRangeByPosition( rScRange, rScCell.Col(), rScCell.Row(), rScCell.Col(), rScCell.Row() ); +} -static void lcl_ScMerge( ScDocShell* pDocSh, const ScRange rScRange, const bool bMerge ) +void merge( ScDocShell* pDocSh, const ScRange rScRange, const bool bMerge ) +{ +if( pDocSh ) { -if( pDocSh ) -{ -ScCellMergeOption aMergeOption( -rScRange.aStart.Col(), rScRange.aStart.Row(), -rScRange.aEnd.Col(), rScRange.aEnd.Row(), false -); -aMergeOption.maTabs.insert( rScRange.aStart.Tab() ); -if ( bMerge ) -pDocSh-GetDocFunc().MergeCells( aMergeOption, false, true, true ); -else -pDocSh-GetDocFunc().UnmergeCells( aMergeOption, true, true ); -} +ScCellMergeOption aMergeOption( +rScRange.aStart.Col(), rScRange.aStart.Row(), +rScRange.aEnd.Col(), rScRange.aEnd.Row(), false +); +aMergeOption.maTabs.insert( rScRange.aStart.Tab() ); +if ( bMerge ) +pDocSh-GetDocFunc().MergeCells( aMergeOption, false, true, true ); +else +pDocSh-GetDocFunc().UnmergeCells( aMergeOption, true, true ); } } +} //anonymous namespace + bool ScXMLTableRowCellContext::IsMerged( const ScRange rScRange, const ScAddress rScCell, ScRange rScCellRange ) const { -if( lcl_ScCellExists(rScCell) ) +if( ScCellExists(rScCell) ) { ScDocument* pDoc = rXMLImport.GetDocument(); -rScCellRange = lcl_ScGetCellRangeByPosition( rScRange, rScCell ); +rScCellRange = getCellRangeByPosition( rScRange, rScCell ); +if( !rScRange.IsValid() ) return false; pDoc-ExtendOverlapped( rScCellRange ); pDoc-ExtendMerge( rScCellRange ); rScCellRange.Justify();
Best place to ask about hacking on chart2 code?
Back in the openoffice days there was a wikki site dedicated to the graphics part of openoffice code. Is there such a place for libreoffice wannabe graphics hackers? Thanks. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Best place to ask about hacking on chart2 code?
Hi there, On Thu, May 24, 2012 at 5:31 PM, walt w41...@gmail.com wrote: Back in the openoffice days there was a wikki site dedicated to the graphics part of openoffice code. Is there such a place for libreoffice wannabe graphics hackers? Well, that would be this list. This list is all inclusive as long as the topic is about hacking on this code base. Also, the openoffice wiki page you mentioned, if it's still accessible, should be still relevant for the major part of the chart code. HTH, Kohei ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] Changes to 'feature/gbuild_merge'
New branch 'feature/gbuild_merge' available with the following commits: commit a756801abac9894b89dd981470ccd22ec9b52d94 Author: David Tardon dtar...@redhat.com Date: Thu May 24 10:02:27 2012 +0200 move shell to cross_tail_build Change-Id: I52ddd365f24589ca73a4671eca84b146df82dcb1 commit cb2aaee727d7de670486a68e72ea90fc710a6207 Author: David Tardon dtar...@redhat.com Date: Thu May 24 09:58:30 2012 +0200 oovbaapi is already in tail_build Change-Id: I5746268239018a92c23e5f37d400c592d884964c commit 46ed346bec398875c1e7a949306270cb1a107cf1 Author: David Tardon dtar...@redhat.com Date: Thu May 24 09:56:42 2012 +0200 x11_extensions is already in tail_build Change-Id: I25b955ad98cdd70236765aa819f49af19c7307b7 commit 882a254e61f6be88cc9c31504055b94515485399 Author: David Tardon dtar...@redhat.com Date: Thu May 24 09:50:28 2012 +0200 xmlhelp is already in tail_build Change-Id: I7ff04b880e739e4d085f92435283569fe5bfbcf1 commit d52732a0cb89473c724a3f001730401ab2d62495 Author: David Tardon dtar...@redhat.com Date: Thu May 24 09:47:50 2012 +0200 move shell to tail_build Change-Id: I0fe4460e940afd9f9a73bd798c3a3e17eb055024 commit e1fb13c6ddde5353d674806b5562ad2231c2a30e Author: David Tardon dtar...@redhat.com Date: Thu May 24 09:41:33 2012 +0200 move unotools to tail_build Change-Id: Ib820d967acd3ec78299365d443c838cd2d3cc4de commit b09e4bd1f6f9fe02c40147782f0992de7a5f14ca Author: David Tardon dtar...@redhat.com Date: Sat May 12 17:51:04 2012 +0200 move scp2 to tail_build Change-Id: Ib1e954f51908df67d05a86189b864bf7064e59d3 commit 875dc9f5c214e6b0bb45873fa6a09d1cc0e1a66d Author: David Tardon dtar...@redhat.com Date: Sat May 12 17:44:11 2012 +0200 remove unused source files Change-Id: Ic11bfb94cbee4116fe94255f5dc7c49bf795797a commit 1723ef7430d8337d353ef33795e8d866154618cd Author: David Tardon dtar...@redhat.com Date: Sat May 12 17:43:20 2012 +0200 run silently Change-Id: I75474c2f0e938987c28dcfa1f31428e77de03e90 commit 7c2b94e376cfb6a4f0bcf2beb25e65abbde6d80b Author: David Tardon dtar...@redhat.com Date: Sat May 12 17:15:25 2012 +0200 handle silent mode Change-Id: I2ebcacc089d86c9de85b617d80d6a557498d8add commit 7932557a7982fafbe25951c2c7bf668da83879bf Author: David Tardon dtar...@redhat.com Date: Sat May 12 17:11:19 2012 +0200 show multiple assignments of gids as warning Change-Id: Iae3e78e2abe59714d5eb9fa0609861a00e85c944 commit 75e9cd740a578760a12b59425938c2644d8afa8e Author: David Tardon dtar...@redhat.com Date: Sat May 12 17:05:57 2012 +0200 allow to run par2script silently Change-Id: Ib1d9cd1dc1e9c24a5a72c51060797f2214a95c89 commit d7f50cf673144acd9cb734eeafb84695c6c1 Author: David Tardon dtar...@redhat.com Date: Sun May 6 14:50:07 2012 +0200 gbuildize scp2 Change-Id: If9a0906a76943160cfdbd647b26a801bc4389615 commit 77365a05f6b4bfbda8ada6604bd393a259712df4 Author: David Tardon dtar...@redhat.com Date: Sun May 6 14:49:41 2012 +0200 create gbuild class for install scripts commit 041f28818c4acfd63540bf5c7a3e920094c11bd0 Author: David Tardon dtar...@redhat.com Date: Wed May 9 11:08:06 2012 +0200 make the output more predictable So it is easier to check differences between install scripts generated by dmake and gbuild. Change-Id: I12bbdf481c84c896b67a94eaca6460ffb52d96ec commit 87f54aa4fb8d685715848aef6217570723ee8f97 Author: David Tardon dtar...@redhat.com Date: Sun May 6 14:48:18 2012 +0200 export ALL_LANGS commit cedaded33fb4448ec8112e421ca2a7bcd510c6d4 Author: David Tardon dtar...@redhat.com Date: Thu May 24 08:58:00 2012 +0200 do not allow both kde and tde at the same time Change-Id: I423c621c2bd543775c0d6f238fca40a64acaf0cc commit d429ec9d014e418fc0d206e48269984065292f5c Author: David Tardon dtar...@redhat.com Date: Thu May 24 07:36:04 2012 +0200 WaE: converting to non-pointer type 'long long int' from NULL Change-Id: I9d603c0d5c4920d148ec15d6368e89f9c037c26a commit 8bc2d88dbf0641a6576c5848a544c66e1d1fc61c Author: David Tardon dtar...@redhat.com Date: Wed May 23 17:24:11 2012 +0200 WaE: declaration of 'index' shadows a global declaration Change-Id: I83a0fb26b4d376a2b9e221179fdc55a6b7900649 commit 740d4d5c24c65bcc30083d7e9b4cb7635a351f08 Author: David Tardon dtar...@redhat.com Date: Mon Apr 30 17:09:13 2012 +0200 use gb_WinResTarget_use_custom_headers Change-Id: I62f63eb4eeb8d48c35bec1c8e9f05e7037ccd12c commit 4e8532b43fcd24fe3181a3a44626013a4849f4f7 Author: David Tardon dtar...@redhat.com Date: Mon Apr 30 17:08:45 2012 +0200 add gb_WinResTarget_use_custom_headers Change-Id: Ifce1f75f8de0cd35dd744dfd39af7aefef512ecc commit dfd724f9474398570db22b208afb6c48f942e88d Author: David Tardon dtar...@redhat.com Date: Mon Apr 30 16:40:54 2012 +0200 fix dep. generation
[Libreoffice-commits] .: desktop/Executable_sbase.mk desktop/Executable_scalc.mk desktop/Executable_sdraw.mk desktop/Executable_simpress.mk desktop/Executable_smath.mk desktop/Executable_sweb.mk deskt
Repository.mk |1 desktop/Executable_sbase.mk |4 + desktop/Executable_scalc.mk |4 + desktop/Executable_sdraw.mk |4 + desktop/Executable_simpress.mk |4 + desktop/Executable_smath.mk |4 + desktop/Executable_sweb.mk |4 + desktop/Executable_swriter.mk |4 + desktop/Module_desktop.mk |1 desktop/StaticLibrary_appusermodelid.mk | 38 ++ desktop/win32/source/applauncher/appusermodelid.cxx | 72 desktop/win32/source/applauncher/appusermodelid.hxx | 34 + desktop/win32/source/applauncher/launcher.cxx |6 + desktop/win32/source/applauncher/launcher.hxx |3 desktop/win32/source/applauncher/sbase.cxx |2 desktop/win32/source/applauncher/scalc.cxx |2 desktop/win32/source/applauncher/sdraw.cxx |2 desktop/win32/source/applauncher/simpress.cxx |2 desktop/win32/source/applauncher/smath.cxx |2 desktop/win32/source/applauncher/sweb.cxx |2 desktop/win32/source/applauncher/swriter.cxx|2 21 files changed, 197 insertions(+) New commits: commit 776db316d271d14e653426e21e66b983ec52100a Author: Jesús Corrius je...@softcatala.org Date: Wed May 23 22:06:44 2012 +0200 set explicit Application User Models IDs in the native Windows launchers Change-Id: Ib60a2a4f0d28a53d997731eb34b118cc9b9f822d diff --git a/Repository.mk b/Repository.mk index 535b0e1..3f641d6 100644 --- a/Repository.mk +++ b/Repository.mk @@ -121,6 +121,7 @@ $(eval $(call gb_Helper_register_static_libraries,PLAINLIBS, \ directxcanvas \ winextendloaderenv \ winlauncher \ + appusermodelid \ )) else diff --git a/desktop/Executable_sbase.mk b/desktop/Executable_sbase.mk index 375cba3..d09faf4 100644 --- a/desktop/Executable_sbase.mk +++ b/desktop/Executable_sbase.mk @@ -37,6 +37,10 @@ $(eval $(call gb_Executable_use_libraries,sbase,\ $(gb_STDLIBS) \ )) +$(eval $(call gb_Executable_use_static_libraries,sbase,\ + appusermodelid \ +)) + $(eval $(call gb_Executable_add_libs,sbase,\ $(call gb_CxxObject_get_target,desktop/win32/source/applauncher/launcher) \ )) diff --git a/desktop/Executable_scalc.mk b/desktop/Executable_scalc.mk index ce90099..6b626e5 100644 --- a/desktop/Executable_scalc.mk +++ b/desktop/Executable_scalc.mk @@ -37,6 +37,10 @@ $(eval $(call gb_Executable_use_libraries,scalc,\ $(gb_STDLIBS) \ )) +$(eval $(call gb_Executable_use_static_libraries,scalc,\ + appusermodelid \ +)) + $(eval $(call gb_Executable_add_libs,scalc,\ $(call gb_CxxObject_get_target,desktop/win32/source/applauncher/launcher) \ )) diff --git a/desktop/Executable_sdraw.mk b/desktop/Executable_sdraw.mk index 4642445..0b1b9f4 100644 --- a/desktop/Executable_sdraw.mk +++ b/desktop/Executable_sdraw.mk @@ -37,6 +37,10 @@ $(eval $(call gb_Executable_use_libraries,sdraw,\ $(gb_STDLIBS) \ )) +$(eval $(call gb_Executable_use_static_libraries,sdraw,\ + appusermodelid \ +)) + $(eval $(call gb_Executable_add_libs,sdraw,\ $(call gb_CxxObject_get_target,desktop/win32/source/applauncher/launcher) \ )) diff --git a/desktop/Executable_simpress.mk b/desktop/Executable_simpress.mk index c302643..0ad5986 100644 --- a/desktop/Executable_simpress.mk +++ b/desktop/Executable_simpress.mk @@ -37,6 +37,10 @@ $(eval $(call gb_Executable_use_libraries,simpress,\ $(gb_STDLIBS) \ )) +$(eval $(call gb_Executable_use_static_libraries,simpress,\ + appusermodelid \ +)) + $(eval $(call gb_Executable_add_libs,simpress,\ $(call gb_CxxObject_get_target,desktop/win32/source/applauncher/launcher) \ )) diff --git a/desktop/Executable_smath.mk b/desktop/Executable_smath.mk index 4c7c4af..cbbb5bd 100644 --- a/desktop/Executable_smath.mk +++ b/desktop/Executable_smath.mk @@ -37,6 +37,10 @@ $(eval $(call gb_Executable_use_libraries,smath,\ $(gb_STDLIBS) \ )) +$(eval $(call gb_Executable_use_static_libraries,smath,\ + appusermodelid \ +)) + $(eval $(call gb_Executable_add_libs,smath,\ $(call gb_CxxObject_get_target,desktop/win32/source/applauncher/launcher) \ )) diff --git a/desktop/Executable_sweb.mk b/desktop/Executable_sweb.mk index 870cf7d..dd88c31 100644 --- a/desktop/Executable_sweb.mk +++ b/desktop/Executable_sweb.mk @@ -37,6 +37,10 @@ $(eval $(call gb_Executable_use_libraries,sweb,\ $(gb_STDLIBS) \ )) +$(eval $(call gb_Executable_use_static_libraries,sweb,\ + appusermodelid \ +)) + $(eval $(call gb_Executable_add_libs,sweb,\ $(call gb_CxxObject_get_target,desktop/win32/source/applauncher/launcher) \ )) diff --git a/desktop/Executable_swriter.mk b/desktop/Executable_swriter.mk index acd299b..f0b435f 100644 ---
Re: Excel filters for Writer
On Wed, 2012-05-23 at 15:56 -0400, Kohei Yoshida wrote: Thanks. What about this one? http://opengrok.libreoffice.org/xref/core/filter/source/config/fragments/filters/StarWriter_DOS.xcu Does the same thinking apply to this one also? I hope yes. The import excel .xls into a word processor filters are just odd in the first place. But the StarWriter for DOS filter presumably makes as much sense as any of the rest of the binfilter filters. What singles StarWriter DOS out as problematic as opposed to say StarWriter 1.0 ? C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
build time optimization
Hi, I'm trying to accelerate LO (developer) build on linux_x86-64 system. Before you point me to wiki (distributed build, ccache and friends) and tell me to use ramdisk: I already did it all and it is still need to be optimized ;-) There are many disable configure options already, like disable mozilla and friends, and for some libs the combination does the job, like disable xmlsec and disable mozilla does disable nss. Then next step would be not to build external libs during LO build. There is a magic option: --with-system-libs. If you try this option on debian based systems (x86_64) you would probably end up with clucene dependency not met error. Just a matter of installing those two available clucene packages? Unfortunately not: as it turns out those packages are hopelessly outdated (2008). So, just pick the version, that is shipped with LO, apply the patches in clucene directory and make install and we are done? Unfortunately not, because the next error probably would be clucene-contrib-lib is missing. As it turns out, there is still one clucene patch missing: to force clucene-contrib-lib to be actually installed. After applying this missing patch to clucene-contrib-lib build file the installation was sucessfull, and then next missing external dependency error appears ;-) (And with other external libs you would probably end up messing around with pkg-config because pc files are missing) But wait, LO does it already during the build, doesn't it? It picks up the really fresh external lib, applies his own patches and install it to his working dir ... just to throw it away after make clean ;-( I'm thinking about another magic configure option, like --with-external-lib-directory=/opt/libo this would install all dependend libs to this directory during first build and this would *survive* the make clean call, so the next time all external lib artifacts would be reused from there. The best is, this option would also help to accelerate the build on other platforms! Unfortunately this option would not be so easy to implement, I guess. Another thoughts on that? Ciao David ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: Branch 'libreoffice-3-5' - binaryurp/source cppu/inc cppu/source cpputools/source cppu/util
binaryurp/source/bridge.cxx | 205 +++--- binaryurp/source/bridge.hxx | 25 ++-- binaryurp/source/bridgefactory.cxx|2 binaryurp/source/incomingrequest.cxx |2 binaryurp/source/reader.cxx |2 binaryurp/source/writer.cxx |2 cppu/inc/uno/threadpool.h |8 - cppu/source/threadpool/thread.cxx | 184 +- cppu/source/threadpool/thread.hxx | 52 +++- cppu/source/threadpool/threadpool.cxx | 124 ++-- cppu/source/threadpool/threadpool.hxx | 43 ++- cppu/util/makefile.mk |2 cpputools/source/unoexe/unoexe.cxx|4 13 files changed, 372 insertions(+), 283 deletions(-) New commits: commit b7721ccca2f76c52dd6c6bb9b8f673fb276fea52 Author: Stephan Bergmann sberg...@redhat.com Date: Wed May 23 09:42:37 2012 +0200 Better fix for ThreadPool/ORequestThread life cycle This is a follow up to d015384e1d98fe77fd59339044f58efb1ab9fb25 Fixed ThreadPool (and dependent ORequestThread) life cycle that still had some problems: * First, if Bridge::terminate was first entered from the reader or writer thread, it would not join on that thread, so that thread could still be running during exit. That has been addressed by giving Bridge::dispose new semantics: It waits until both Bridge::terminate has completed (even if that was called from a different thread) and all spawned threads (reader, writer, ORequestThread workers) have been joined. (This implies that Bridge::dispose must not be called from such a thread, to avoid deadlock.) * Second, if Bridge::terminate was first entered from an ORequestThread, the call to uno_threadpool_dispose(0) to join on all such worker threads could deadlock. That has been addressed by making the last call to uno_threadpool_destroy wait to join on all worker threads, and by calling uno_threadpool_destroy only from the final Bridge::terminate (from Bridge::dispose), to avoid deadlock. (The special semantics of uno_threadpool_dispose(0) are no longer needed and have been removed, as they conflicted with the fix for the third problem below.) * Third, once uno_threadpool_destroy had called uno_threadpool_dispose(0), the ThreadAdmin singleton had been disposed, so no new remote bridges could successfully be created afterwards. That has been addressed by making ThreadAdmin a member of ThreadPool, and making (only) those uno_ThreadPool handles with overlapping life spans share one ThreadPool instance (which thus is no longer a singleton, either). Additionally, ORequestThread has been made more robust (in the style of salhelper::Thread) to avoid races. (cherry picked from commit 2fa2660b55a34a5780f9ea8dbbbe92d05dc9a818) Conflicts: binaryurp/source/bridge.cxx cppu/Library_cppu.mk cppu/source/threadpool/threadpool.cxx Change-Id: I2cbd1b3f9aecc1bf4649e482d2c22b33b471788f Signed-off-by: Caolán McNamara caol...@redhat.com diff --git a/binaryurp/source/bridge.cxx b/binaryurp/source/bridge.cxx index f591fe0..13987fe 100644 --- a/binaryurp/source/bridge.cxx +++ b/binaryurp/source/bridge.cxx @@ -105,11 +105,9 @@ extern C void SAL_CALL freeProxyCallback(uno_ExtEnvironment *, void * pProxy) static_cast Proxy * (pProxy)-do_free(); } -void joinThread(osl::Thread * thread) { +bool isThread(osl::Thread * thread) { assert(thread != 0); -if (thread-getIdentifier() != osl::Thread::getCurrentIdentifier()) { -thread-join(); -} +return osl::Thread::getCurrentIdentifier() == thread-getIdentifier(); } class AttachThread: private boost::noncopyable { @@ -213,8 +211,8 @@ Bridge::Bridge( rtl::OUString( RTL_CONSTASCII_USTRINGPARAM( com.sun.star.bridge.XProtocolProperties::commitChange))), -threadPool_(0), currentContextMode_(false), proxies_(0), calls_(0), -normalCall_(false), activeCalls_(0), terminated_(false), +state_(STATE_INITIAL), threadPool_(0), currentContextMode_(false), +proxies_(0), calls_(0), normalCall_(false), activeCalls_(0), mode_(MODE_REQUESTED) { assert(factory.is() connection.is()); @@ -238,11 +236,14 @@ void Bridge::start() { rtl::Reference Writer w(new Writer(this)); { osl::MutexGuard g(mutex_); -assert(threadPool_ == 0 !writer_.is() !reader_.is()); +assert( +state_ == STATE_INITIAL threadPool_ == 0 !writer_.is() +!reader_.is()); threadPool_ = uno_threadpool_create(); assert(threadPool_ != 0); reader_ = r; writer_ = w; +state_ = STATE_STARTED; } // It is important to call reader_-create() last here; both // Writer::execute and Reader::execute can call
Re: [PUSHED][REVIEW-3-5] Better fix for ThreadPool/ORequestThread life cycle
On Wed, 2012-05-23 at 14:33 +0200, Stephan Bergmann wrote: With this second fix, however, calling unopkg add/remove of active.oxt and passive.oxt (from desktop/test/deployment/) in a tight loop revealed no anomalies any longer, on neither master nor libreoffice-3-5 (and on master, I let it burn cycles all night long Seeing as an all-night unopkg add/remove loop was the test criteria the last time this sort of thing arose, pushed this now. C. threads: more trouble than they're worth :-) ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[REVIEW 3-5] fdo#48932 speed up scrolling/typing in huge writer documents
fdo#48932 is a large 7000 page document which reacts very slowly on text input and scrolling around. It appears to be mostly managing the header/footer and page break indicators which makes it sluggish b63766b3dd453a82f59db505c736d861f662cc0f make it fast again, and seem to have no side efforts. Though I'd like to have someone else verify that. Attached is a backport to 3-5 to apply cleanly. C. From 4bada122523dfaf4441341e0f86b1ba98b5ce3b4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Caol=C3=A1n=20McNamara?= caol...@redhat.com Date: Thu, 24 May 2012 08:57:17 +0100 Subject: [PATCH] Resolves: fdo#48932 super slow typing and scrolling in large documents AFAICS it appears that theres a one to one mapping from a SwFrameControl to a SwFrm, so in any of the three given classes of Page, Footer or Header a SwFrm will have zero or one SwFrameControls and a SwFrameControl doesn't get rebound to a different SwFrm or anything like that, so we can use a map and index off the SwFrm* to find them rather than constantly looping over vectors to find the right one. Maybe could move the SwFrameControl directly in the SwPageFrm's themselves. Change-Id: I4de0a34f657143ef2d4409b604cc8e114dad132f --- sw/source/ui/docvw/FrameControlsManager.cxx | 110 --- sw/source/ui/inc/FrameControlsManager.hxx |6 +- 2 files changed, 37 insertions(+), 79 deletions(-) diff --git a/sw/source/ui/docvw/FrameControlsManager.cxx b/sw/source/ui/docvw/FrameControlsManager.cxx index 5c00b58..1413942 100644 --- a/sw/source/ui/docvw/FrameControlsManager.cxx +++ b/sw/source/ui/docvw/FrameControlsManager.cxx @@ -37,21 +37,6 @@ using namespace std; -namespace -{ -class FramePredicate -{ -const SwFrm* m_pToMatch; - -public: -FramePredicate( const SwFrm* pFrm ) : m_pToMatch( pFrm ) { }; -virtual ~FramePredicate() {}; - -virtual bool operator()( SwFrameControlPtr pToCheck ) -{ return m_pToMatch == pToCheck-GetFrame(); }; -}; -} - SwFrameControlsManager::SwFrameControlsManager( SwEditWin* pEditWin ) : m_pEditWin( pEditWin ), m_aControls( ) @@ -60,14 +45,6 @@ SwFrameControlsManager::SwFrameControlsManager( SwEditWin* pEditWin ) : SwFrameControlsManager::~SwFrameControlsManager() { -map FrameControlType, vector SwFrameControlPtr ::iterator pIt = m_aControls.begin(); - -while ( pIt != m_aControls.end() ) -{ -pIt-second.clear( ); -++pIt; -} -m_aControls.clear(); } SwFrameControlsManager::SwFrameControlsManager( const SwFrameControlsManager rCopy ) : @@ -85,75 +62,66 @@ const SwFrameControlsManager SwFrameControlsManager::operator=( const SwFrameCo SwFrameControlPtr SwFrameControlsManager::GetControl( FrameControlType eType, const SwFrm* pFrm ) { -SwFrameControlPtr pControl; - -vector SwFrameControlPtr aControls = m_aControls[eType]; +SwFrameControlPtrMap rControls = m_aControls[eType]; -vector SwFrameControlPtr ::iterator pIt = find_if( -aControls.begin(), aControls.end( ), FramePredicate( pFrm ) ); +SwFrameControlPtrMap::iterator aIt = rControls.find(pFrm); -if ( pIt != aControls.end() ) -pControl = *pIt; +if (aIt != rControls.end()) +return aIt-second; -return pControl; +return SwFrameControlPtr(); } -std::vector SwFrameControlPtr SwFrameControlsManager::GetControls( FrameControlType eType ) +SwFrameControlPtrMap SwFrameControlsManager::GetControls( FrameControlType eType ) { return m_aControls[eType]; } void SwFrameControlsManager::AddControl( FrameControlType eType, SwFrameControlPtr pControl ) { -m_aControls[eType].push_back( pControl ); +m_aControls[eType].insert(make_pair(pControl-GetFrame(), pControl)); } void SwFrameControlsManager::RemoveControls( const SwFrm* pFrm ) { -map FrameControlType, vector SwFrameControlPtr ::iterator pIt = m_aControls.begin(); +map FrameControlType, SwFrameControlPtrMap ::iterator pIt = m_aControls.begin(); while ( pIt != m_aControls.end() ) { -vector SwFrameControlPtr aVect = pIt-second; -aVect.erase( remove_if( aVect.begin(), -aVect.end(), -FramePredicate( pFrm ) ), aVect.end() ); +SwFrameControlPtrMap rMap = pIt-second; +rMap.erase(pFrm); ++pIt; } } void SwFrameControlsManager::RemoveControlsByType( FrameControlType eType, const SwFrm* pFrm ) { -vector SwFrameControlPtr aVect = m_aControls[eType]; -aVect.erase( remove_if( aVect.begin(), -aVect.end(), -FramePredicate( pFrm ) ), aVect.end() ); +SwFrameControlPtrMap rMap = m_aControls[eType]; +rMap.erase(pFrm); } - void SwFrameControlsManager::HideControls( FrameControlType eType ) { -vector SwFrameControlPtr ::iterator pIt = m_aControls[eType].begin(); +SwFrameControlPtrMap::iterator
[Libreoffice-commits] .: 2 commits - desktop/win32
desktop/win32/source/applauncher/appusermodelid.cxx |2 +- desktop/win32/source/applauncher/launcher.hxx |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) New commits: commit 8fd58d062786a44572a087f16476cd5fc01c0408 Author: Jesús Corrius je...@softcatala.org Date: Thu May 24 10:12:39 2012 +0200 replace wcscat_s - wcscat to please minGW diff --git a/desktop/win32/source/applauncher/appusermodelid.cxx b/desktop/win32/source/applauncher/appusermodelid.cxx index 721fefa..2095817 100644 --- a/desktop/win32/source/applauncher/appusermodelid.cxx +++ b/desktop/win32/source/applauncher/appusermodelid.cxx @@ -37,7 +37,7 @@ void SetExplicitAppUserModelID(PCWSTR AppID) { WCHAR szShell32[MAX_PATH]; GetSystemDirectoryW(szShell32, MAX_PATH); - wcscat_s(szShell32, MAX_PATH, L\\Shell32.dll); + wcscat(szShell32, L\\Shell32.dll); HINSTANCE hinstDll = LoadLibraryW(szShell32); commit dbbda42a4373dcd28c9f3b11a9d66fa1f69bbb85 Author: Jesús Corrius je...@softcatala.org Date: Thu May 24 10:10:28 2012 +0200 include files always in lowercase diff --git a/desktop/win32/source/applauncher/launcher.hxx b/desktop/win32/source/applauncher/launcher.hxx index 0dcf720..e602bfe 100644 --- a/desktop/win32/source/applauncher/launcher.hxx +++ b/desktop/win32/source/applauncher/launcher.hxx @@ -4,7 +4,7 @@ #error Need C++ to compile #endif -#include Windows.h +#include windows.h #ifndef _INC_TCHAR # ifdef UNICODE ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: build time optimization
On 05/24/2012 09:23 AM, David Ostrovsky wrote: I'm thinking about another magic configure option, like --with-external-lib-directory=/opt/libo this would install all dependend libs to this directory during first build and this would *survive* the make clean call, so the next time all external lib artifacts would be reused from there. The line what to keep across a make clean and what to through away could be a gray one. On the one hand, some low-level LO modules (e.g., soltools) do not really change much these days, so you could argue to not rebuild them, either. On the other hand, the external modules *do* depend on LO code (its build machinery), so not re-building them after a make clean is unsound if you modified any LO code they depend on. In the end, I'd question why you do make clean anyway, if you are after fast build times. These days, our dependency tracking has apparently become fine enough that there are hardly any apparent build failures resulting from missing dependencies any longer. (And, btw, most of the --with-external-libs should work just fine. You typically only need a few select --without-external-* overrides.) Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] Changes to 'feature/mspub'
New branch 'feature/mspub' available with the following commits: ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: 3 commits - dbaccess/source starmath/source svtools/inc svtools/source svx/inc svx/source sw/source tools/inc
dbaccess/source/ui/misc/charsets.cxx |2 +- starmath/source/parse.cxx |2 +- starmath/source/smmod.cxx |8 svtools/inc/svtools/langtab.hxx |2 +- svtools/source/misc/langtab.cxx |7 +++ svx/inc/svx/strarray.hxx |2 +- svx/inc/svx/txenctab.hxx |2 +- svx/source/dialog/strarray.cxx|5 ++--- svx/source/dialog/txenctab.cxx|7 +++ sw/source/ui/dbui/mailmergehelper.cxx |2 +- sw/source/ui/dbui/mmconfigitem.cxx|4 ++-- sw/source/ui/dbui/mmlayoutpage.cxx|4 ++-- tools/inc/tools/resary.hxx| 30 ++ 13 files changed, 28 insertions(+), 49 deletions(-) New commits: commit a16b4676a53fdc94c63821cf14e7f24e0fe20959 Author: Caolán McNamara caol...@redhat.com Date: Thu May 24 07:36:47 2012 +0100 convert ResStringArray to rtl::OUString Change-Id: I51b86a10caa5da6e12583c2b22404b0d9282b13d diff --git a/dbaccess/source/ui/misc/charsets.cxx b/dbaccess/source/ui/misc/charsets.cxx index d0789ab..e8fbf30 100644 --- a/dbaccess/source/ui/misc/charsets.cxx +++ b/dbaccess/source/ui/misc/charsets.cxx @@ -63,7 +63,7 @@ namespace dbaui if ( RTL_TEXTENCODING_DONTKNOW == _eEncoding ) return sal_True; -return 0 != GetTextString( _eEncoding ).Len(); +return !GetTextString(_eEncoding).isEmpty(); } //- diff --git a/starmath/source/parse.cxx b/starmath/source/parse.cxx index 9ecd5ae..d3999a5 100644 --- a/starmath/source/parse.cxx +++ b/starmath/source/parse.cxx @@ -2376,7 +2376,7 @@ void SmParser::Special() sal_uInt16 nCount = sal::static_int_cast sal_uInt16 (pFrom-Count()); for (sal_uInt16 i = 0; i nCount; ++i) { -if (pFrom-GetString(i) == rName) +if (pFrom-GetString(i).equals(rName)) { aNewName = pTo-GetString(i); bReplace = true; diff --git a/starmath/source/smmod.cxx b/starmath/source/smmod.cxx index 8b85ad2..d757bcb 100644 --- a/starmath/source/smmod.cxx +++ b/starmath/source/smmod.cxx @@ -100,7 +100,7 @@ const String SmLocalizedSymbolData::GetUiSymbolName( const String rExportName ) sal_uInt16 nCount = sal::static_int_cast xub_StrLen (rExportNames.Count()); for (sal_uInt16 i = 0; i nCount!aRes.Len(); ++i) { -if (rExportName == rExportNames.GetString(i)) +if (rExportNames.GetString(i).equals(rExportName)) { aRes = rUiNames.GetString(i); break; @@ -121,7 +121,7 @@ const String SmLocalizedSymbolData::GetExportSymbolName( const String rUiName ) sal_uInt16 nCount = sal::static_int_cast xub_StrLen (rUiNames.Count()); for (sal_uInt16 i = 0; i nCount!aRes.Len(); ++i) { -if (rUiName == rUiNames.GetString(i)) +if (rUiNames.GetString(i).equals(rUiName)) { aRes = rExportNames.GetString(i); break; @@ -142,7 +142,7 @@ const String SmLocalizedSymbolData::GetUiSymbolSetName( const String rExportNam sal_uInt16 nCount = sal::static_int_cast xub_StrLen (rExportNames.Count()); for (sal_uInt16 i = 0; i nCount!aRes.Len(); ++i) { -if (rExportName == rExportNames.GetString(i)) +if (rExportNames.GetString(i).equals(rExportName)) { aRes = rUiNames.GetString(i); break; @@ -163,7 +163,7 @@ const String SmLocalizedSymbolData::GetExportSymbolSetName( const String rUiNam sal_uInt16 nCount = sal::static_int_cast xub_StrLen (rUiNames.Count()); for (sal_uInt16 i = 0; i nCount!aRes.Len(); ++i) { -if (rUiName == rUiNames.GetString(i)) +if (rUiNames.GetString(i).equals(rUiName)) { aRes = rExportNames.GetString(i); break; diff --git a/svtools/inc/svtools/langtab.hxx b/svtools/inc/svtools/langtab.hxx index 5785322..0d1ab3a 100644 --- a/svtools/inc/svtools/langtab.hxx +++ b/svtools/inc/svtools/langtab.hxx @@ -49,7 +49,7 @@ public: Tools-Options-LanguageSettings-UserInterface listbox. If FALSE, do replace. */ -const String GetString( const LanguageType eType, bool bUserInterfaceSelection = false ) const; +const rtl::OUString GetString( const LanguageType eType, bool bUserInterfaceSelection = false ) const; LanguageTypeGetType( const String rStr ) const; sal_uInt32 GetEntryCount() const; diff --git a/svtools/source/misc/langtab.cxx b/svtools/source/misc/langtab.cxx index 64af70e..9168daf 100644 --- a/svtools/source/misc/langtab.cxx +++ b/svtools/source/misc/langtab.cxx @@ -135,7 +135,7 @@ SvtLanguageTable::~SvtLanguageTable() // -const String SvtLanguageTable::GetString(
[Libreoffice-commits] .: boost/makefile.mk
boost/makefile.mk | 47 +-- 1 file changed, 45 insertions(+), 2 deletions(-) New commits: commit 70eb7af641ed1c2fdc754d522472f804f80d0a9d Author: Fridrich Sch Strba fridrich.st...@bluewin.ch Date: Wed Apr 4 16:18:09 2012 +0200 Be sure all boost headers are copied to output directory Change-Id: I862b728537e9e862f1d5af78bcc87576964534d0 diff --git a/boost/makefile.mk b/boost/makefile.mk index 27e588d..6c9db56 100644 --- a/boost/makefile.mk +++ b/boost/makefile.mk @@ -107,38 +107,81 @@ $(PACKAGE_DIR)$/$(NORMALIZE_FLAG_FILE) : $(PACKAGE_DIR)$/$(BUILD_FLAG_FILE) -@$(MKDIRHIER) $(INCCOM)$/$(PRJNAME) @$(GNUCOPY) -r $(PACKAGE_DIR)$/$(TARFILE_NAME)$/boost$/*.h $(INCCOM)$/$(PRJNAME) @$(GNUCOPY) -r $(PACKAGE_DIR)$/$(TARFILE_NAME)$/boost$/*.hpp $(INCCOM)$/$(PRJNAME) +@$(GNUCOPY) -r $(PACKAGE_DIR)$/$(TARFILE_NAME)$/boost$/accumulators $(INCCOM)$/$(PRJNAME) @$(GNUCOPY) -r $(PACKAGE_DIR)$/$(TARFILE_NAME)$/boost$/algorithm $(INCCOM)$/$(PRJNAME) +@$(GNUCOPY) -r $(PACKAGE_DIR)$/$(TARFILE_NAME)$/boost$/archive $(INCCOM)$/$(PRJNAME) +@$(GNUCOPY) -r $(PACKAGE_DIR)$/$(TARFILE_NAME)$/boost$/asio $(INCCOM)$/$(PRJNAME) @$(GNUCOPY) -r $(PACKAGE_DIR)$/$(TARFILE_NAME)$/boost$/assign $(INCCOM)$/$(PRJNAME) +@$(GNUCOPY) -r $(PACKAGE_DIR)$/$(TARFILE_NAME)$/boost$/bimap $(INCCOM)$/$(PRJNAME) @$(GNUCOPY) -r $(PACKAGE_DIR)$/$(TARFILE_NAME)$/boost$/bind $(INCCOM)$/$(PRJNAME) +@$(GNUCOPY) -r $(PACKAGE_DIR)$/$(TARFILE_NAME)$/boost$/circular_buffer $(INCCOM)$/$(PRJNAME) +@$(GNUCOPY) -r $(PACKAGE_DIR)$/$(TARFILE_NAME)$/boost$/compatibility $(INCCOM)$/$(PRJNAME) @$(GNUCOPY) -r $(PACKAGE_DIR)$/$(TARFILE_NAME)$/boost$/concept $(INCCOM)$/$(PRJNAME) +@$(GNUCOPY) -r $(PACKAGE_DIR)$/$(TARFILE_NAME)$/boost$/concept_check $(INCCOM)$/$(PRJNAME) @$(GNUCOPY) -r $(PACKAGE_DIR)$/$(TARFILE_NAME)$/boost$/config $(INCCOM)$/$(PRJNAME) @$(GNUCOPY) -r $(PACKAGE_DIR)$/$(TARFILE_NAME)$/boost$/date_time $(INCCOM)$/$(PRJNAME) @$(GNUCOPY) -r $(PACKAGE_DIR)$/$(TARFILE_NAME)$/boost$/detail $(INCCOM)$/$(PRJNAME) @$(GNUCOPY) -r $(PACKAGE_DIR)$/$(TARFILE_NAME)$/boost$/dynamic_bitset $(INCCOM)$/$(PRJNAME) @$(GNUCOPY) -r $(PACKAGE_DIR)$/$(TARFILE_NAME)$/boost$/exception $(INCCOM)$/$(PRJNAME) +@$(GNUCOPY) -r $(PACKAGE_DIR)$/$(TARFILE_NAME)$/boost$/filesystem $(INCCOM)$/$(PRJNAME) +@$(GNUCOPY) -r $(PACKAGE_DIR)$/$(TARFILE_NAME)$/boost$/flyweight $(INCCOM)$/$(PRJNAME) +@$(GNUCOPY) -r $(PACKAGE_DIR)$/$(TARFILE_NAME)$/boost$/format $(INCCOM)$/$(PRJNAME) @$(GNUCOPY) -r $(PACKAGE_DIR)$/$(TARFILE_NAME)$/boost$/function $(INCCOM)$/$(PRJNAME) @$(GNUCOPY) -r $(PACKAGE_DIR)$/$(TARFILE_NAME)$/boost$/functional $(INCCOM)$/$(PRJNAME) -@$(GNUCOPY) -r $(PACKAGE_DIR)$/$(TARFILE_NAME)$/boost$/io $(INCCOM)$/$(PRJNAME) +@$(GNUCOPY) -r $(PACKAGE_DIR)$/$(TARFILE_NAME)$/boost$/function_types $(INCCOM)$/$(PRJNAME) +@$(GNUCOPY) -r $(PACKAGE_DIR)$/$(TARFILE_NAME)$/boost$/fusion $(INCCOM)$/$(PRJNAME) +@$(GNUCOPY) -r $(PACKAGE_DIR)$/$(TARFILE_NAME)$/boost$/gil $(INCCOM)$/$(PRJNAME) +@$(GNUCOPY) -r $(PACKAGE_DIR)$/$(TARFILE_NAME)$/boost$/graph $(INCCOM)$/$(PRJNAME) @$(GNUCOPY) -r $(PACKAGE_DIR)$/$(TARFILE_NAME)$/boost$/integer $(INCCOM)$/$(PRJNAME) +@$(GNUCOPY) -r $(PACKAGE_DIR)$/$(TARFILE_NAME)$/boost$/interprocess $(INCCOM)$/$(PRJNAME) +@$(GNUCOPY) -r $(PACKAGE_DIR)$/$(TARFILE_NAME)$/boost$/intrusive $(INCCOM)$/$(PRJNAME) +@$(GNUCOPY) -r $(PACKAGE_DIR)$/$(TARFILE_NAME)$/boost$/io $(INCCOM)$/$(PRJNAME) +@$(GNUCOPY) -r $(PACKAGE_DIR)$/$(TARFILE_NAME)$/boost$/iostreams $(INCCOM)$/$(PRJNAME) @$(GNUCOPY) -r $(PACKAGE_DIR)$/$(TARFILE_NAME)$/boost$/iterator $(INCCOM)$/$(PRJNAME) +@$(GNUCOPY) -r $(PACKAGE_DIR)$/$(TARFILE_NAME)$/boost$/lambda $(INCCOM)$/$(PRJNAME) +@$(GNUCOPY) -r $(PACKAGE_DIR)$/$(TARFILE_NAME)$/boost$/logic $(INCCOM)$/$(PRJNAME) +@$(GNUCOPY) -r $(PACKAGE_DIR)$/$(TARFILE_NAME)$/boost$/math $(INCCOM)$/$(PRJNAME) +@$(GNUCOPY) -r $(PACKAGE_DIR)$/$(TARFILE_NAME)$/boost$/mpi $(INCCOM)$/$(PRJNAME) @$(GNUCOPY) -r $(PACKAGE_DIR)$/$(TARFILE_NAME)$/boost$/mpl $(INCCOM)$/$(PRJNAME) +@$(GNUCOPY) -r $(PACKAGE_DIR)$/$(TARFILE_NAME)$/boost$/msm $(INCCOM)$/$(PRJNAME) @$(GNUCOPY) -r $(PACKAGE_DIR)$/$(TARFILE_NAME)$/boost$/multi_array $(INCCOM)$/$(PRJNAME) @$(GNUCOPY) -r $(PACKAGE_DIR)$/$(TARFILE_NAME)$/boost$/multi_index $(INCCOM)$/$(PRJNAME) @$(GNUCOPY) -r $(PACKAGE_DIR)$/$(TARFILE_NAME)$/boost$/numeric $(INCCOM)$/$(PRJNAME) @$(GNUCOPY) -r $(PACKAGE_DIR)$/$(TARFILE_NAME)$/boost$/optional $(INCCOM)$/$(PRJNAME) +@$(GNUCOPY) -r $(PACKAGE_DIR)$/$(TARFILE_NAME)$/boost$/parameter $(INCCOM)$/$(PRJNAME) @$(GNUCOPY) -r $(PACKAGE_DIR)$/$(TARFILE_NAME)$/boost$/pending $(INCCOM)$/$(PRJNAME) +@$(GNUCOPY) -r $(PACKAGE_DIR)$/$(TARFILE_NAME)$/boost$/polygon $(INCCOM)$/$(PRJNAME) @$(GNUCOPY) -r
[Libreoffice-commits] .: svtools/source
svtools/source/contnr/templwin.cxx |2 +- svtools/source/contnr/templwin.hxx |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) New commits: commit 226b81d0f300a62da9351d1fc011b88f93f0b2b0 Author: Stephan Bergmann sberg...@redhat.com Date: Thu May 24 10:58:31 2012 +0200 returning reference to temporary [-Werror] Change-Id: Ib37f1fc9658cb50227463cf2aa1421ba47b2ec9f diff --git a/svtools/source/contnr/templwin.cxx b/svtools/source/contnr/templwin.cxx index b1b85c2..98cf194 100644 --- a/svtools/source/contnr/templwin.cxx +++ b/svtools/source/contnr/templwin.cxx @@ -594,7 +594,7 @@ SvtDocInfoTable_Impl::SvtDocInfoTable_Impl() : } // --- -const String SvtDocInfoTable_Impl::GetString( long nId ) const +rtl::OUString SvtDocInfoTable_Impl::GetString( long nId ) const { sal_uInt32 nPos( FindIndex( nId ) ); diff --git a/svtools/source/contnr/templwin.hxx b/svtools/source/contnr/templwin.hxx index 207efeb..d945cf7 100644 --- a/svtools/source/contnr/templwin.hxx +++ b/svtools/source/contnr/templwin.hxx @@ -173,7 +173,7 @@ private: public: SvtDocInfoTable_Impl(); -const String GetString( long nId ) const; +rtl::OUString GetString( long nId ) const; }; class SvtFrameWindow_Impl : public Window ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: Branch 'feature/mspub' - 4 commits - boost/makefile.mk dbaccess/source starmath/source svtools/inc svtools/source svx/inc svx/source sw/source tools/inc
boost/makefile.mk | 47 -- dbaccess/source/ui/misc/charsets.cxx |2 - starmath/source/parse.cxx |2 - starmath/source/smmod.cxx |8 ++--- svtools/inc/svtools/langtab.hxx |2 - svtools/source/misc/langtab.cxx |7 ++--- svx/inc/svx/strarray.hxx |2 - svx/inc/svx/txenctab.hxx |2 - svx/source/dialog/strarray.cxx|5 +-- svx/source/dialog/txenctab.cxx|7 ++--- sw/source/ui/dbui/mailmergehelper.cxx |2 - sw/source/ui/dbui/mmconfigitem.cxx|4 +- sw/source/ui/dbui/mmlayoutpage.cxx|4 +- tools/inc/tools/resary.hxx| 30 - 14 files changed, 73 insertions(+), 51 deletions(-) New commits: commit 70eb7af641ed1c2fdc754d522472f804f80d0a9d Author: Fridrich Sch Strba fridrich.st...@bluewin.ch Date: Wed Apr 4 16:18:09 2012 +0200 Be sure all boost headers are copied to output directory Change-Id: I862b728537e9e862f1d5af78bcc87576964534d0 diff --git a/boost/makefile.mk b/boost/makefile.mk index 27e588d..6c9db56 100644 --- a/boost/makefile.mk +++ b/boost/makefile.mk @@ -107,38 +107,81 @@ $(PACKAGE_DIR)$/$(NORMALIZE_FLAG_FILE) : $(PACKAGE_DIR)$/$(BUILD_FLAG_FILE) -@$(MKDIRHIER) $(INCCOM)$/$(PRJNAME) @$(GNUCOPY) -r $(PACKAGE_DIR)$/$(TARFILE_NAME)$/boost$/*.h $(INCCOM)$/$(PRJNAME) @$(GNUCOPY) -r $(PACKAGE_DIR)$/$(TARFILE_NAME)$/boost$/*.hpp $(INCCOM)$/$(PRJNAME) +@$(GNUCOPY) -r $(PACKAGE_DIR)$/$(TARFILE_NAME)$/boost$/accumulators $(INCCOM)$/$(PRJNAME) @$(GNUCOPY) -r $(PACKAGE_DIR)$/$(TARFILE_NAME)$/boost$/algorithm $(INCCOM)$/$(PRJNAME) +@$(GNUCOPY) -r $(PACKAGE_DIR)$/$(TARFILE_NAME)$/boost$/archive $(INCCOM)$/$(PRJNAME) +@$(GNUCOPY) -r $(PACKAGE_DIR)$/$(TARFILE_NAME)$/boost$/asio $(INCCOM)$/$(PRJNAME) @$(GNUCOPY) -r $(PACKAGE_DIR)$/$(TARFILE_NAME)$/boost$/assign $(INCCOM)$/$(PRJNAME) +@$(GNUCOPY) -r $(PACKAGE_DIR)$/$(TARFILE_NAME)$/boost$/bimap $(INCCOM)$/$(PRJNAME) @$(GNUCOPY) -r $(PACKAGE_DIR)$/$(TARFILE_NAME)$/boost$/bind $(INCCOM)$/$(PRJNAME) +@$(GNUCOPY) -r $(PACKAGE_DIR)$/$(TARFILE_NAME)$/boost$/circular_buffer $(INCCOM)$/$(PRJNAME) +@$(GNUCOPY) -r $(PACKAGE_DIR)$/$(TARFILE_NAME)$/boost$/compatibility $(INCCOM)$/$(PRJNAME) @$(GNUCOPY) -r $(PACKAGE_DIR)$/$(TARFILE_NAME)$/boost$/concept $(INCCOM)$/$(PRJNAME) +@$(GNUCOPY) -r $(PACKAGE_DIR)$/$(TARFILE_NAME)$/boost$/concept_check $(INCCOM)$/$(PRJNAME) @$(GNUCOPY) -r $(PACKAGE_DIR)$/$(TARFILE_NAME)$/boost$/config $(INCCOM)$/$(PRJNAME) @$(GNUCOPY) -r $(PACKAGE_DIR)$/$(TARFILE_NAME)$/boost$/date_time $(INCCOM)$/$(PRJNAME) @$(GNUCOPY) -r $(PACKAGE_DIR)$/$(TARFILE_NAME)$/boost$/detail $(INCCOM)$/$(PRJNAME) @$(GNUCOPY) -r $(PACKAGE_DIR)$/$(TARFILE_NAME)$/boost$/dynamic_bitset $(INCCOM)$/$(PRJNAME) @$(GNUCOPY) -r $(PACKAGE_DIR)$/$(TARFILE_NAME)$/boost$/exception $(INCCOM)$/$(PRJNAME) +@$(GNUCOPY) -r $(PACKAGE_DIR)$/$(TARFILE_NAME)$/boost$/filesystem $(INCCOM)$/$(PRJNAME) +@$(GNUCOPY) -r $(PACKAGE_DIR)$/$(TARFILE_NAME)$/boost$/flyweight $(INCCOM)$/$(PRJNAME) +@$(GNUCOPY) -r $(PACKAGE_DIR)$/$(TARFILE_NAME)$/boost$/format $(INCCOM)$/$(PRJNAME) @$(GNUCOPY) -r $(PACKAGE_DIR)$/$(TARFILE_NAME)$/boost$/function $(INCCOM)$/$(PRJNAME) @$(GNUCOPY) -r $(PACKAGE_DIR)$/$(TARFILE_NAME)$/boost$/functional $(INCCOM)$/$(PRJNAME) -@$(GNUCOPY) -r $(PACKAGE_DIR)$/$(TARFILE_NAME)$/boost$/io $(INCCOM)$/$(PRJNAME) +@$(GNUCOPY) -r $(PACKAGE_DIR)$/$(TARFILE_NAME)$/boost$/function_types $(INCCOM)$/$(PRJNAME) +@$(GNUCOPY) -r $(PACKAGE_DIR)$/$(TARFILE_NAME)$/boost$/fusion $(INCCOM)$/$(PRJNAME) +@$(GNUCOPY) -r $(PACKAGE_DIR)$/$(TARFILE_NAME)$/boost$/gil $(INCCOM)$/$(PRJNAME) +@$(GNUCOPY) -r $(PACKAGE_DIR)$/$(TARFILE_NAME)$/boost$/graph $(INCCOM)$/$(PRJNAME) @$(GNUCOPY) -r $(PACKAGE_DIR)$/$(TARFILE_NAME)$/boost$/integer $(INCCOM)$/$(PRJNAME) +@$(GNUCOPY) -r $(PACKAGE_DIR)$/$(TARFILE_NAME)$/boost$/interprocess $(INCCOM)$/$(PRJNAME) +@$(GNUCOPY) -r $(PACKAGE_DIR)$/$(TARFILE_NAME)$/boost$/intrusive $(INCCOM)$/$(PRJNAME) +@$(GNUCOPY) -r $(PACKAGE_DIR)$/$(TARFILE_NAME)$/boost$/io $(INCCOM)$/$(PRJNAME) +@$(GNUCOPY) -r $(PACKAGE_DIR)$/$(TARFILE_NAME)$/boost$/iostreams $(INCCOM)$/$(PRJNAME) @$(GNUCOPY) -r $(PACKAGE_DIR)$/$(TARFILE_NAME)$/boost$/iterator $(INCCOM)$/$(PRJNAME) +@$(GNUCOPY) -r $(PACKAGE_DIR)$/$(TARFILE_NAME)$/boost$/lambda $(INCCOM)$/$(PRJNAME) +@$(GNUCOPY) -r $(PACKAGE_DIR)$/$(TARFILE_NAME)$/boost$/logic $(INCCOM)$/$(PRJNAME) +@$(GNUCOPY) -r $(PACKAGE_DIR)$/$(TARFILE_NAME)$/boost$/math $(INCCOM)$/$(PRJNAME) +@$(GNUCOPY) -r $(PACKAGE_DIR)$/$(TARFILE_NAME)$/boost$/mpi $(INCCOM)$/$(PRJNAME) @$(GNUCOPY) -r $(PACKAGE_DIR)$/$(TARFILE_NAME)$/boost$/mpl $(INCCOM)$/$(PRJNAME) +@$(GNUCOPY) -r $(PACKAGE_DIR)$/$(TARFILE_NAME)$/boost$/msm $(INCCOM)$/$(PRJNAME)
Re: build time optimization
On Thursday 24 of May 2012, David Ostrovsky wrote: Then next step would be not to build external libs during LO build. There is a magic option: --with-system-libs. If you try this option on debian based systems (x86_64) you would probably end up with clucene dependency not met error. ... But wait, LO does it already during the build, doesn't it? It picks up the really fresh external lib, applies his own patches and install it to his working dir ... just to throw it away after make clean ;-( I'm thinking about another magic configure option, like --with-external-lib-directory=/opt/libo this would install all dependend libs to this directory during first build and this would *survive* the make clean call, so the next time all external lib artifacts would be reused from there. The best is, this option would also help to accelerate the build on other platforms! Unfortunately this option would not be so easy to implement, I guess. Another thoughts on that? We had a discussion about this recently, in the thread started at [1]. You have roughly the following options: - do not use 'make clean' - install as many system libraries as you can (or even build them explicitly from source), use --with-system-libraries and explicit --without-system-foo as needed - implement the --with-system-libraries=auto mentioned in [2] to save you the explicit --without-system-foo hassle Implementing your suggestion is possibly more work than any of these. [1] http://lists.freedesktop.org/archives/libreoffice/2012-April/030645.html [2] http://lists.freedesktop.org/archives/libreoffice/2012-April/030897.html -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: Branch 'feature/mspub' - config_host.mk.in configure.in libmspub/makefile.mk libmspub/prj libmspub/README Makefile.top ooo.lst.in
Makefile.top |2 + config_host.mk.in |1 configure.in | 25 libmspub/README|1 libmspub/makefile.mk | 74 + libmspub/prj/build.lst |3 + libmspub/prj/d.lst |6 +++ ooo.lst.in |1 8 files changed, 113 insertions(+) New commits: commit 6fc0d54d872d88b6716fa9393f4e4156c5a0c703 Author: Fridrich Å trba fridrich.st...@bluewin.ch Date: Thu May 24 11:59:16 2012 +0200 Adding libmspub module Change-Id: Iec9c9c5419a40e7ad64af057f1bbb426ca3163b0 diff --git a/Makefile.top b/Makefile.top index 1396514..476c1aa 100644 --- a/Makefile.top +++ b/Makefile.top @@ -194,6 +194,7 @@ libcmis\ libcroco\ libexttextcat\ libgsf\ +libmspub\ libpng\ librsvg\ libvisio\ @@ -466,6 +467,7 @@ findunusedcode: | grep -v ^jvmaccess:: \ | grep -v ^libcdr:: \ | grep -v ^libcmis:: \ + | grep -v ^libmspub:: \ | grep -v ^libvisio:: \ | grep -v ^libwpg:: \ | grep -v ^libwps_tools_win:: \ diff --git a/config_host.mk.in b/config_host.mk.in index 76d4a1d..dcc8bc6 100644 --- a/config_host.mk.in +++ b/config_host.mk.in @@ -499,6 +499,7 @@ export SYSTEM_LIBCROCO=@SYSTEM_LIBCROCO@ export SYSTEM_LIBEXTTEXTCAT=@SYSTEM_LIBEXTTEXTCAT@ export SYSTEM_LIBEXTTEXTCAT_DATA=@SYSTEM_LIBEXTTEXTCAT_DATA@ export SYSTEM_LIBGSF=@SYSTEM_LIBGSF@ +export SYSTEM_LIBMSPUB=@SYSTEM_LIBMSPUB@ export SYSTEM_LIBPNG=@SYSTEM_LIBPNG@ export SYSTEM_LIBRSVG=@SYSTEM_LIBRSVG@ export SYSTEM_LIBVISIO=@SYSTEM_LIBVISIO@ diff --git a/configure.in b/configure.in index 2382c83..8983807 100644 --- a/configure.in +++ b/configure.in @@ -1219,6 +1219,11 @@ AC_ARG_WITH(system-libcdr, [Use libcdr already on system.]),, [with_system_libcdr=$with_system_libs]) +AC_ARG_WITH(system-libmspub, +AS_HELP_STRING([--with-system-libmspub], +[Use libmspub already on system.]),, +[with_system_libmspub=no]) + AC_ARG_WITH(system-libvisio, AS_HELP_STRING([--with-system-libvisio], [Use libvisio already on system.]),, @@ -6255,6 +6260,26 @@ AC_SUBST(CDR_CFLAGS) AC_SUBST(CDR_LIBS) dnl === +dnl Check for system libmspub +dnl === +AC_MSG_CHECKING([which libmspub to use]) +if test $with_system_libmspub = yes; then +AC_MSG_RESULT([external]) +SYSTEM_LIBMSPUB=YES +PKG_CHECK_MODULES( MSPUB, libmspub-0.0 ) +elif test $_os = iOS; then +# libmspub depends on libwpd and libwpg and those are LGPL +AC_MSG_RESULT([none]) +else +AC_MSG_RESULT([internal]) +SYSTEM_LIBMSPUB=NO +BUILD_TYPE=$BUILD_TYPE LIBMSPUB +fi +AC_SUBST(SYSTEM_LIBMSPUB) +AC_SUBST(MSPUB_CFLAGS) +AC_SUBST(MSPUB_LIBS) + +dnl === dnl Check for system libvisio dnl === AC_MSG_CHECKING([which libvisio to use]) diff --git a/libmspub/README b/libmspub/README new file mode 100644 index 000..6d2765a --- /dev/null +++ b/libmspub/README @@ -0,0 +1 @@ +Library parsing the Microsoft Publisher documents. diff --git a/libmspub/makefile.mk b/libmspub/makefile.mk new file mode 100644 index 000..e2e0877 --- /dev/null +++ b/libmspub/makefile.mk @@ -0,0 +1,74 @@ +#* +# +# DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. +# +# Copyright 2000, 2010 Oracle and/or its affiliates. +# +# OpenOffice.org - a multi-platform office productivity suite +# +# This file is part of OpenOffice.org. +# +# OpenOffice.org is free software: you can redistribute it and/or modify +# it under the terms of the GNU Lesser General Public License version 3 +# only, as published by the Free Software Foundation. +# +# OpenOffice.org is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU Lesser General Public License version 3 for more details +# (a copy is included in the LICENSE file that accompanied this code). +# +# You should have received a copy of the GNU Lesser General Public License +# version 3 along with OpenOffice.org. If not, see +# http://www.openoffice.org/license.html +# for a copy of the LGPLv3 License. +# +#* + +PRJ=. + +PRJNAME=cdr +TARGET=cdr + +# --- Settings - + +.INCLUDE : settings.mk + +# --- Files + +.IF $(SYSTEM_LIBMSPUB) == YES +@all: +@echo Using system libmspub... +.ENDIF + +# libcdr depends on the libwpd, libwpg and zlib +.IF $(SYSTEM_LIBWPD) == YES +INCPRE+=$(WPD_CFLAGS)
[Libreoffice-commits] .: Branch 'feature/mspub' - filter/Configuration_filter.mk filter/source postprocess/rebase RepositoryExternal.mk tail_build/prj writerperfect/Library_wpftdraw.mk writerperfect/M
RepositoryExternal.mk| 27 filter/Configuration_filter.mk |2 filter/source/config/fragments/filters/PublisherDocument.xcu | 13 filter/source/config/fragments/types/draw_Publisher_Document.xcu | 12 postprocess/rebase/coffbase.txt |1 tail_build/prj/build.lst |2 writerperfect/Library_wpftdraw.mk|2 writerperfect/Module_writerperfect.mk|2 writerperfect/prj/build.lst |2 writerperfect/source/draw/MSPUBImportFilter.cxx | 275 ++ writerperfect/source/draw/MSPUBImportFilter.hxx | 111 writerperfect/source/draw/wpftdraw_genericfilter.cxx |5 writerperfect/util/wpftdraw.component|4 13 files changed, 455 insertions(+), 3 deletions(-) New commits: commit c3d9e65a78776587b9edcb95bf1c52e5f396a08b Author: Fridrich Å trba fridrich.st...@bluewin.ch Date: Thu May 24 12:29:22 2012 +0200 Adding Publisher Import filter Change-Id: I87d648b408de2e1dcbef9a52a7cf4ba918972025 diff --git a/RepositoryExternal.mk b/RepositoryExternal.mk index 8e620bf..09ab7f4 100644 --- a/RepositoryExternal.mk +++ b/RepositoryExternal.mk @@ -729,6 +729,33 @@ endef endif # SYSTEM_LIBCDR +ifeq ($(SYSTEM_LIBMSPUB),YES) + +define gb_LinkTarget__use_mspub +$(call gb_LinkTarget_set_include,$(1),\ + $$(INCLUDE) \ +$(MSPUB_CFLAGS) \ +) +$(call gb_LinkTarget_add_libs,$(1),$(MSPUB_LIBS)) + +endef + +else # !SYSTEM_LIBMSPUB + +$(eval $(call gb_Helper_register_static_libraries,PLAINLIBS, \ + mspublib \ +)) + +define gb_LinkTarget__use_mspub +$(call gb_LinkTarget_use_static_libraries,$(1),\ + mspublib \ +) + +endef + +endif # SYSTEM_LIBMSPUB + + ifeq ($(SYSTEM_LIBVISIO),YES) define gb_LinkTarget__use_visio diff --git a/filter/Configuration_filter.mk b/filter/Configuration_filter.mk index f143840..aa689ca 100644 --- a/filter/Configuration_filter.mk +++ b/filter/Configuration_filter.mk @@ -542,6 +542,7 @@ $(call filter_Configuration_add_types,fcfg_langpack,fcfg_draw_types.xcu,filter/s draw8_template \ draw_WordPerfect_Graphics \ draw_Visio_Document \ +draw_Publisher_Document \ draw_CorelDraw_Document \ draw_Corel_Presentation_Exchange \ ) @@ -554,6 +555,7 @@ $(call filter_Configuration_add_filters,fcfg_langpack,fcfg_draw_filters.xcu,filt draw8_template \ WordPerfectGraphics \ VisioDocument \ +PublisherDocument \ CorelDrawDocument \ CorelPresentationExchange \ ) diff --git a/filter/source/config/fragments/filters/PublisherDocument.xcu b/filter/source/config/fragments/filters/PublisherDocument.xcu new file mode 100644 index 000..bb53e94 --- /dev/null +++ b/filter/source/config/fragments/filters/PublisherDocument.xcu @@ -0,0 +1,13 @@ +node oor:name=Publisher Document oor:op=replace +prop oor:name=FlagsvalueIMPORT ALIEN USESOPTIONS 3RDPARTYFILTER PREFERRED/value/prop +prop oor:name=UIComponent/ +prop oor:name=FilterServicevaluecom.sun.star.comp.Draw.MSPUBImportFilter/value/prop +prop oor:name=UserDatavalue/value/prop +prop oor:name=UIName +value xml:lang=x-defaultMicrosoft Publisher 2003/value +/prop +prop oor:name=FileFormatVersionvalue0/value/prop +prop oor:name=Typevaluedraw_Publisher_Document/value/prop +prop oor:name=TemplateName/ +prop oor:name=DocumentServicevaluecom.sun.star.drawing.DrawingDocument/value/prop +/node diff --git a/filter/source/config/fragments/types/draw_Publisher_Document.xcu b/filter/source/config/fragments/types/draw_Publisher_Document.xcu new file mode 100644 index 000..8a253a3 --- /dev/null +++ b/filter/source/config/fragments/types/draw_Publisher_Document.xcu @@ -0,0 +1,12 @@ +node oor:name=draw_Publisher_Document oor:op=replace +prop oor:name=DetectServicevaluecom.sun.star.comp.Draw.MSPUBImportFilter/value/prop +prop oor:name=URLPattern/ +prop oor:name=Extensionsvaluepub/value/prop +prop oor:name=MediaTypevalueapplication/x-mspublisher/value/prop +prop oor:name=Preferredvaluetrue/value/prop +prop oor:name=PreferredFiltervaluePublisher Document/value/prop +prop oor:name=UIName +valueMicrosoft Publisher 2003/value +/prop +prop oor:name=ClipboardFormat/ +/node diff --git a/postprocess/rebase/coffbase.txt b/postprocess/rebase/coffbase.txt index 2aa9823..4fe3a25 100644 --- a/postprocess/rebase/coffbase.txt +++ b/postprocess/rebase/coffbase.txt @@ -389,4 +389,3 @@ ucpmyucp1.uno.dll 0x580a 0x0002 vbaeventsmi.uno.dll 0x5807 0x0002
[Libreoffice-commits] .: sc/source
sc/source/core/data/attarray.cxx |7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) New commits: commit 816f65da41c8c30e5854e333a6498e58c64303aa Author: Eike Rathke er...@redhat.com Date: Thu May 24 12:37:57 2012 +0200 resolved fdo#41214 crash due to offset error diff --git a/sc/source/core/data/attarray.cxx b/sc/source/core/data/attarray.cxx index 9de2b02..f201e5d 100644 --- a/sc/source/core/data/attarray.cxx +++ b/sc/source/core/data/attarray.cxx @@ -1800,12 +1800,11 @@ bool ScAttrArray::GetLastVisibleAttr( SCROW rLastRow, SCROW nLastData, bool bFu while ( nPos nCount ) { // find range of visually equal formats -SCSIZE nStartPos = nPos; -SCSIZE nEndPos = nStartPos + 1; +SCSIZE nEndPos = nPos; while ( nEndPos nCount-1 pData[nEndPos].pPattern-IsVisibleEqual( *pData[nEndPos+1].pPattern)) ++nEndPos; -SCROW nAttrStartRow = ( nStartPos 0 ) ? ( pData[nStartPos-1].nRow + 1 ) : 0; +SCROW nAttrStartRow = ( nPos 0 ) ? ( pData[nPos-1].nRow + 1 ) : 0; if ( nAttrStartRow = nLastData ) nAttrStartRow = nLastData + 1; SCROW nAttrSize = pData[nEndPos].nRow + 1 - nAttrStartRow; @@ -1816,7 +1815,7 @@ bool ScAttrArray::GetLastVisibleAttr( SCROW rLastRow, SCROW nLastData, bool bFu rLastRow = pData[nEndPos].nRow; bFound = true; } -nPos = nEndPos; +nPos = nEndPos + 1; } return bFound; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: build time optimization
Hi David, On Thu, May 24, 2012 at 9:23 AM, David Ostrovsky d.ostrov...@idaia.de wrote: I'm trying to accelerate LO (developer) build on linux_x86-64 system. Before you point me to wiki (distributed build, ccache and friends) and tell me to use ramdisk: I already did it all and it is still need to be optimized ;-) Well - do the few external modules that you don't have in your system really matter that much with regards to build time when you're already using ccache? Given that you build in the same directory always or use ccache's prefix-option so that the cache can actually be used, the time needed to build those few external libs is negligible, isn't it? I rather have make clean really do make clean for everything. (And with other external libs you would probably end up messing around with pkg-config because pc files are missing) Nah, you would just set PKG_CONFIG_PATH accordingly. I'm thinking about another magic configure option, like --with-external-lib-directory=/opt/libo Not necessary IMHO. As you also want to be able to run your build LO on your machine, don't you? So you need those external libs available on your system, thus you need to add the library path to your ld.so.conf or similar mechanism. this would install all dependend libs to this directory during first build and this would *survive* the make clean It is pointless to have system libraries in a system that is not available in the system, but only for the build. Unfortunately this option would not be so easy to implement, I guess. Another thoughts on that? Yes, run ./configure --prefix /opt/lodpes ; make ; make install on the external libs you're missing and export PKG_CONFIG_PATH=/opt/lodeps/share/pkgconfig:/usr/share/pkgconfig before running configure/autogen.sh And see above for the runtime thing. you can also just install them to /usr/local/ so you don't have to bother with LD_LIBRARY_PATH/ld.so.conf ciao Christian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 44446] LibreOffice 3.6 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=6 Bug 6 depends on bug 50221, which changed state. Bug 50221 Summary: FILESAVE particular .xls (MSO97) will CRASH https://bugs.freedesktop.org/show_bug.cgi?id=50221 What|Old Value |New Value Status|UNCONFIRMED |NEW Status|NEW |ASSIGNED Resolution||FIXED Status|ASSIGNED|RESOLVED -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: sc/source
sc/source/filter/xml/xmlexprt.cxx |7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) New commits: commit 4d676e0fb325d3938cdc7064f9a80821fff645d3 Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Thu May 24 12:41:18 2012 +0200 export new conditional format info only into 1.2 with extension Change-Id: I4d52f5aa36785110888ca1fdd6fc85ee40406674 diff --git a/sc/source/filter/xml/xmlexprt.cxx b/sc/source/filter/xml/xmlexprt.cxx index 9c1b3bd..5951ee0 100644 --- a/sc/source/filter/xml/xmlexprt.cxx +++ b/sc/source/filter/xml/xmlexprt.cxx @@ -2851,8 +2851,11 @@ void ScXMLExport::WriteTable(sal_Int32 nTable, const Referencesheet::XSpreadshe WriteNamedRange(pRangeName); } -//export new conditional format information -ExportConditionalFormat(nTable); +if(getDefaultVersion() ODFVER_012) +{ +//export new conditional format information +ExportConditionalFormat(nTable); +} } } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: [PATCH] fix proposed for fdo#50178 (Visio)
On 23/05/12 23:08, julien2412 wrote: Hello, I took a look at the fdo#50178 Reading Visio file causes crash and put a backtrace here https://bugs.freedesktop.org/attachment.cgi?id=61938 Interesting console message : /usr/include/c++/4.6/debug/safe_iterator.h:465:error: attempt to compare iterators from different sequences. and location for bt : /libvisio/unxlngx6/misc/build/libvisio-0.0.16/src/lib/VSDXContentCollector.cpp:1499 Then here is the line which fails : 1499 if (iter != m_NURBSData.end()) The problem is iter can be initialized in both ways : - 1492 iter = m_stencilShape-m_nurbsData.find(dataID); - or 1496 iter = m_NURBSData.find(dataID); So I propose a patch which defines a variable iterEnd initialized in both specific cases and with which iter is compared. http://nabble.documentfoundation.org/file/n3985678/libvisio-0.0.16-fdo50178.patch libvisio-0.0.16-fdo50178.patch hmmm yes that looks reasonable, should fix it. PS : If the fix is right, I'm not sure how to commit push it (git add libvisio-0.0.16-fdo50178.patch then git commit -a etc.?) just git add both files, the new one and the existing one, and then git commit. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
per-user installation context on Windows
Hi, In the setup wizard of LibreOffice one can choose between installing LibreOffice for all users (per-machine context), and installing LibreOffice for the currently logged in user (per-user context). I could not find a good reason to keep this choice on the UI. Installation works from administrator account only. Non-privileged users cannot install LibreOffice even in per-user context. They can use portable versions for example. Help packs are installed in per-machine context unconditionally. If we removed this choice from the UI along with the useless User name/Organization prompts (see fdo#46559), we could have one screen less in the installation wizard. If someone is insisting on installing LibreOffice in per-user context, the ALLUSERS= property can be passed in the command line (also for help packs). Please let me know, if you disagree. Thanks, Andras ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: i18npool/source
i18npool/source/localedata/data/zh_TW.xml |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) New commits: commit 4a3e7dfb0d573cf97555822e11f816dc400b67e4 Author: Eike Rathke er...@redhat.com Date: Thu May 24 13:22:19 2012 +0200 added missing closing quotes at end of literals Change-Id: I3d204aa54dd9c13dfb87e702fa07aa4234977a49 diff --git a/i18npool/source/localedata/data/zh_TW.xml b/i18npool/source/localedata/data/zh_TW.xml index c683372..a978450 100644 --- a/i18npool/source/localedata/data/zh_TW.xml +++ b/i18npool/source/localedata/data/zh_TW.xml @@ -268,13 +268,13 @@ FormatCodeå¹´MæDæ¥ HHæMMåSSç§/FormatCode /FormatElement FormatElement msgid=DateTimeFormatskey5 default=false type=long usage=DATE_TIME formatindex=77 - FormatCodeEEå¹´MæDæ¥ HHæMMå/FormatCode + FormatCodeEEå¹´MæDæ¥ HHæMMå/FormatCode /FormatElement FormatElement msgid=DateTimeFormatskey6 default=false type=long usage=DATE_TIME formatindex=78 - FormatCodeGGEEå¹´MæDæ¥ HHæMMå/FormatCode + FormatCodeGGEEå¹´MæDæ¥ HHæMMå/FormatCode /FormatElement FormatElement msgid=DateTimeFormatskey7 default=false type=long usage=DATE_TIME formatindex=79 - FormatCodeGGGEEå¹´MæDæ¥ HHæMMå/FormatCode + FormatCodeGGGEEå¹´MæDæ¥ HHæMMå/FormatCode /FormatElement /LC_FORMAT LC_COLLATION ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: sc/source
sc/source/filter/xml/xmlexprt.cxx | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) New commits: commit cd834e5c78c65449a47a6a5310d05bf9775f2da6 Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Thu May 24 13:22:30 2012 +0200 don't export empty color formats conditional formats Change-Id: I880facafc155af2e8c67f66f9d3463daf1191207 diff --git a/sc/source/filter/xml/xmlexprt.cxx b/sc/source/filter/xml/xmlexprt.cxx index 5951ee0..2379401 100644 --- a/sc/source/filter/xml/xmlexprt.cxx +++ b/sc/source/filter/xml/xmlexprt.cxx @@ -2851,7 +2851,7 @@ void ScXMLExport::WriteTable(sal_Int32 nTable, const Referencesheet::XSpreadshe WriteNamedRange(pRangeName); } -if(getDefaultVersion() ODFVER_012) +if(getDefaultVersion() SvtSaveOptions::ODFVER_012) { //export new conditional format information ExportConditionalFormat(nTable); @@ -3823,6 +3823,16 @@ void ScXMLExport::ExportConditionalFormat(SCTAB nTab) ScColorFormatList* pColorFormatList = pDoc-GetColorScaleList(nTab); if(pCondFormatList || pColorFormatList) { +bool bExport = false; +if(pCondFormatList pCondFormatList-size()) +bExport = true; + +if(pColorFormatList pColorFormatList-size()) +bExport = true; + +if(!bExport) +return; + SvXMLElementExport aElementCondFormats(*this, XML_NAMESPACE_CALC_EXT, XML_CONDITIONAL_FORMATS, true, true); if(pCondFormatList) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: Excel filters for Writer
On Thu, May 24, 2012 at 2:47 AM, Caolán McNamara caol...@redhat.com wrote: On Wed, 2012-05-23 at 15:56 -0400, Kohei Yoshida wrote: Thanks. What about this one? http://opengrok.libreoffice.org/xref/core/filter/source/config/fragments/filters/StarWriter_DOS.xcu Does the same thinking apply to this one also? I hope yes. The import excel .xls into a word processor filters are just odd in the first place. But the StarWriter for DOS filter presumably makes as much sense as any of the rest of the binfilter filters. What singles StarWriter DOS out as problematic as opposed to say StarWriter 1.0 ? It's associated with the writer_StarWriter_DOS format type which uses .txt as the only extension. So, it gets prioritized when dealing with a plain text file with.txt extension even though it's a binary format. I find that a bit odd. Kohei ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: per-user installation context on Windows
Hi Andras, *, On Thu, May 24, 2012 at 1:21 PM, Andras Timar tima...@gmail.com wrote: [...] If we removed this choice from the UI along with the useless User name/Organization prompts (see fdo#46559), Without a user name in the Options, documents will always be opened at the very top, not at the last edit position. So it would be preferable to prompt the user when there is no previous installation. But if the user name/Organization really is not used for LO's option as you write in the bug, feel free to bin them. ciao Christian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: desktop/win32
desktop/win32/source/applauncher/launcher.cxx |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) New commits: commit f0f8576596e104549e66e62d15a262acfd70dcec Author: Jesús Corrius je...@softcatala.org Date: Thu May 24 13:33:39 2012 +0200 Don't spam fellow developers until I fix the problem in MinGW diff --git a/desktop/win32/source/applauncher/launcher.cxx b/desktop/win32/source/applauncher/launcher.cxx index 8ba9cb6..074e2b5 100644 --- a/desktop/win32/source/applauncher/launcher.cxx +++ b/desktop/win32/source/applauncher/launcher.cxx @@ -56,7 +56,8 @@ extern C int APIENTRY _tWinMain( HINSTANCE, HINSTANCE, LPTSTR, int ) { // Set an explicit Application User Model ID for the process - SetExplicitAppUserModelID(APPUSERMODELID); +// FIXME: Comment this out until I find a fix for minGW. +// SetExplicitAppUserModelID(APPUSERMODELID); // Retreive startup info ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: sc/source
sc/source/filter/excel/xetable.cxx | 53 ++--- 1 file changed, 38 insertions(+), 15 deletions(-) New commits: commit 9746c6de3a05fe9284d6d6bb2f636bfe912733cd Author: Noel Power noel.po...@novell.com Date: Thu May 24 12:44:19 2012 +0100 fix excel row height export problems ( I hope ) fdo#50304 Change-Id: I43ddb32ecba36107f5973fa5dcf2499cd1330668 diff --git a/sc/source/filter/excel/xetable.cxx b/sc/source/filter/excel/xetable.cxx index e569426..5656b71 100644 --- a/sc/source/filter/excel/xetable.cxx +++ b/sc/source/filter/excel/xetable.cxx @@ -2029,22 +2029,41 @@ void XclExpRowBuffer::Finalize( XclExpDefaultRowData rDefRowData, const ScfUInt XclExpDefaultRowData aMaxDefData; size_t nMaxDefCount = 0; // only look for default format in existing rows, if there are more than unused -for (itr = itrBeg; itr != itrEnd; ++itr) +bool bSearchExisting = ( maRowMap.size() = ( GetMaxPos().Row() - maRowMap.size() ) ); +if ( bSearchExisting ) { -const RowRef rRow = itr-second; -if (rRow-IsDefaultable()) +for (itr = itrBeg; itr != itrEnd; ++itr) { -XclExpDefaultRowData aDefData( *rRow ); -size_t rnDefCount = aDefRowMap[ aDefData ]; -++rnDefCount; -if( rnDefCount nMaxDefCount ) +const RowRef rRow = itr-second; +if (rRow-IsDefaultable()) { -nMaxDefCount = rnDefCount; -aMaxDefData = aDefData; +XclExpDefaultRowData aDefData( *rRow ); +size_t rnDefCount = aDefRowMap[ aDefData ]; +++rnDefCount; +if( rnDefCount nMaxDefCount ) +{ +nMaxDefCount = rnDefCount; +aMaxDefData = aDefData; +} +} +} +} +else +{ +// find a suitable unused row to get the default height from, +// searching backwards from max row +for ( SCROW nRow = GetMaxPos().Row(); nRow = 0; --nRow ) +{ +if ( maRowMap.find( nRow ) == maRowMap.end() ) +{ +// use first encountered unused row height as default +// I wonder should we do this always ( and abandon the search +// of exising rows ) +aMaxDefData.mnHeight = GetDoc().GetRowHeight(nRow, GetCurrScTab(), false); +break; } } } - // return the default row format to caller rDefRowData = aMaxDefData; @@ -2146,13 +2165,17 @@ XclExpDimensions* XclExpRowBuffer::GetDimensions() XclExpRow XclExpRowBuffer::GetOrCreateRow( sal_uInt32 nXclRow, bool bRowAlwaysEmpty ) { -RowMap::iterator itr = maRowMap.find(nXclRow); -if (itr == maRowMap.end()) +RowMap::iterator itr = maRowMap.begin(); +for ( size_t nFrom = maRowMap.size(); nFrom = nXclRow; ++nFrom ) { -RowRef p(new XclExpRow(GetRoot(), nXclRow, maOutlineBfr, bRowAlwaysEmpty)); -::std::pairRowMap::iterator, bool r = maRowMap.insert(RowMap::value_type(nXclRow, p)); -itr = r.first; +itr = maRowMap.find(nFrom); +if ( itr == maRowMap.end() ) +{ +RowRef p(new XclExpRow(GetRoot(), nFrom, maOutlineBfr, bRowAlwaysEmpty)); +maRowMap.insert(RowMap::value_type(nFrom, p)); +} } +itr = maRowMap.find(nXclRow); return *itr-second; } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: --enable-debug vs --enable-symbols (Re: [Libreoffice-commits] .: 12 commits - config_host.mk.in configure.in filter/source oox/source sal/inc sc/source solenv/gbuild toolkit/source xmlhelp/source)
On Tuesday 22 of May 2012, Stephan Bergmann wrote: On 05/22/2012 04:02 PM, Lubos Lunak wrote: On Tuesday 22 of May 2012, Stephan Bergmann wrote: On 05/22/2012 03:19 PM, Lubos Lunak wrote: But --enable-debug also enables asserts, logging and similar functionality that should be rather useful for developer builds, doesn't it? But --enable-dbgutil enables that as well (and more of it). Uhm? If that is the case, then no wonder people get confused, since this means that dbgutil is a superset of debug, except not quite. I've already asked Michael, so I'm going to ask you too: What is your idea about what these options do? common subset of what --enable-debug and --enable-dbgutil do: enable various assertions, warnings, etc. (technically, both enable OSL_DEBUG_LEVEL 0 and disable NDEBUG, for example) what --enable-debug does in addition: settings that aid in step-through debugging (like -O0, -fno-inline) what --enable-dbgutil does in addition: enable additional assertions, warnings, etc. that are binary incompatible Hmm. That's a completely arbitrary and non-obvious setup that I doubt anybody except for you knows or expects, but on the other hand, I think I do not care enough to do anything about it if you want it this way. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: binfilter/bf_starmath
binfilter/bf_starmath/source/starmath_parse.cxx |2 - binfilter/bf_starmath/source/starmath_smmod.cxx | 34 2 files changed, 18 insertions(+), 18 deletions(-) New commits: commit 55dbc98f225d5b2c695b3d724a1fff0e9c5e9873 Author: Caolán McNamara caol...@redhat.com Date: Thu May 24 07:37:00 2012 +0100 convert ResStringArray to rtl::OUString Change-Id: I32d51ad09e1a190d92d6e6f6c14d9f9debf7bf41 diff --git a/binfilter/bf_starmath/source/starmath_parse.cxx b/binfilter/bf_starmath/source/starmath_parse.cxx index 30f763c..2146f11 100644 --- a/binfilter/bf_starmath/source/starmath_parse.cxx +++ b/binfilter/bf_starmath/source/starmath_parse.cxx @@ -2216,7 +2216,7 @@ const sal_Int32 coNumContFlags = /*M*/ USHORT nCount = pFrom-Count(); /*M*/ for (USHORT i = 0; i nCount; ++i) /*M*/ { -/*M*/ if (pFrom-GetString(i) == rName) +/*M*/ if (pFrom-GetString(i).equals(rName)) /*M*/ { /*M*/ aNewName = pTo-GetString(i); /*M*/ bReplace = TRUE; diff --git a/binfilter/bf_starmath/source/starmath_smmod.cxx b/binfilter/bf_starmath/source/starmath_smmod.cxx index 3c1dd5e..0b6656c 100644 --- a/binfilter/bf_starmath/source/starmath_smmod.cxx +++ b/binfilter/bf_starmath/source/starmath_smmod.cxx @@ -76,10 +76,10 @@ namespace binfilter { /*N*/ const ResStringArray rExportNames = rData.GetExportSymbolNamesArray(); /*N*/ USHORT nCount = rExportNames.Count(); /*N*/ for (USHORT i = 0; i nCount!aRes.Len(); ++i) -/*N*/ { -/*N*/ if (rExportName == rExportNames.GetString(i)) +/*N*/ { +/*N*/ if (rExportNames.GetString(i).equals(rExportName)) /*N*/ { -/*N*/ aRes = rUiNames.GetString(i); +/*N*/ aRes = rUiNames.GetString(i); /*N*/ break; /*N*/ } /*N*/ } @@ -90,43 +90,43 @@ namespace binfilter { /*N*/ const String SmLocalizedSymbolData::GetExportSymbolName( const String rUiName ) const /*N*/ { -/*N*/ String aRes; +/*N*/ String aRes; /*N*/ /*N*/ const SmLocalizedSymbolData rData = SM_MOD1()-GetLocSymbolData(); /*N*/ const ResStringArray rUiNames = rData.GetUiSymbolNamesArray(); /*N*/ const ResStringArray rExportNames = rData.GetExportSymbolNamesArray(); -/*N*/ USHORT nCount = rUiNames.Count(); +/*N*/ USHORT nCount = rUiNames.Count(); /*N*/ for (USHORT i = 0; i nCount!aRes.Len(); ++i) -/*N*/ { -/*N*/ if (rUiName == rUiNames.GetString(i)) -/*N*/ { +/*N*/ { +/*N*/ if (rUiNames.GetString(i).equals(rUiName)) +/*N*/ { /*N*/ aRes = rExportNames.GetString(i); /*N*/ break; -/*N*/ } -/*N*/ } +/*N*/ } +/*N*/ } /*N*/ -/*N*/ return aRes; +/*N*/ return aRes; /*N*/ } /*N*/ const String SmLocalizedSymbolData::GetUiSymbolSetName( const String rExportName ) const /*N*/ { -/*N*/ String aRes; +/*N*/ String aRes; /*N*/ /*N*/ const SmLocalizedSymbolData rData = SM_MOD1()-GetLocSymbolData(); /*N*/ const ResStringArray rUiNames = rData.GetUiSymbolSetNamesArray(); /*N*/ const ResStringArray rExportNames = rData.GetExportSymbolSetNamesArray(); /*N*/ USHORT nCount = rExportNames.Count(); /*N*/ for (USHORT i = 0; i nCount!aRes.Len(); ++i) -/*N*/ { -/*N*/ if (rExportName == rExportNames.GetString(i)) +/*N*/ { +/*N*/ if (rExportNames.GetString(i).equals(rExportName)) /*N*/ { -/*N*/ aRes = rUiNames.GetString(i); +/*N*/ aRes = rUiNames.GetString(i); /*N*/ break; /*N*/ } -/*N*/ } +/*N*/ } /*N*/ -/*N*/ return aRes; +/*N*/ return aRes; /*N*/ } ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: [Libreoffice-qa] Spam on this list
Hi Rainer, *, On Wed, May 23, 2012 at 7:46 PM, Rainer Bielefeld libreoff...@bielefeldundbuss.de wrote: Terrence Enger schrieb: The ban list seems to be rather useless, it seems that those addresses are not added to a filter rule? Probably nobody else has seen the management interface, so no idea what ban list refers to with respect to mail delivery from the list. But regarding Mailman's privacy options category: If you're referring to the subscription banlist, then indeed it is not working as that only tells mailman to never subscribe that address. You would have to add the address to the Sender Filters, add it to the list of non-member addresses that will automatically be discarded. For more filtering, use the Spam filters option - this is limited to filter against message headers though. I am tending to make this list a closed one. This would be pointless. I can't see any good reason why that should not be done. Because the only reason to host the list on fdo and not on tdf servers was the ability to have it without the reply-to mangling, having people use reply all. That way it's easy for non-subscribers to post something and still receive answers to that specific thread. I rather use a better client-side spam-filter... ciao Christian ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] Spam on this list
Christian Lohmaier schrieb: If you're referring to the subscription banlist, then indeed it is not working as that only tells mailman to never subscribe that address. Hi Christian , I did so now after your hint. For more filtering, use the Spam filters option - this is limited to filter against message headers though. Hm, should I have been so stupid that I never saw the sub-items of Privacy options...? Seems so! That way it's easy for non-subscribers to post something and still receive answers to that specific thread. I still see that more as a disadvantage, but ... I rather use a better client-side spam-filter... My spam filter works nearby perfect, so that I was not aware of a SPAM problem. Ans So I now sort out mail what's not interesting for me by my client Thank you for the hints Rainer ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-qa] [ANN] LibreOffice 3.5.4 RC2 available
Dear Community, The Document Foundation is happy to announce the second release candidate of LibreOffice 3.5.4. The upcoming 3.5.4 will be the fourth in a series of frequent bugfix releases on our feature-packed 3.5 code line. Please be aware that LibreOffice 3.5.4 RC2 is not ready for production use, you should continue to use LibreOffice 3.5.3 for that. The release is available for Windows, Linux and Mac OS X from our QA builds download page at http://www.libreoffice.org/download/pre-releases/ A note for Windows users: this Release Candidate will uninstall your current stable build and replace it. If you do not wish this to happen but still would like to test, you should follow the instructions for installing in parallel: http://wiki.documentfoundation.org/Installing_in_parallel Should you find bugs, please report them to the FreeDesktop Bugzilla: https://bugs.freedesktop.org A good way to assess the RC2 quality is to run some specific manual tests on it, our TCM wiki page has more details: http://wiki.documentfoundation.org/QA/Testing/Regression_Tests#Full_Regression_Test (and the announcement mail: http://lists.freedesktop.org/archives/libreoffice/2011-December/022464.html) For other ways to get involved with this exciting project - you can e.g. contribute code: https://www.libreoffice.org/get-involved/developers/ translate LibreOffice to your language: http://wiki.documentfoundation.org/Translation_for_3.5 or help with funding our operations: http://challenge.documentfoundation.org/ A list of known issues with 3.5.4 RC2 is available from our wiki: http://wiki.documentfoundation.org/Releases/3.5.4/RC2 Please find the list of changes against LibreOffice 3.5.4 RC1 here: http://download.documentfoundation.org/libreoffice/src/bugfixes-libreoffice-3-5-4-release-3.5.4.2.log Let us close again with a BIG Thank You! to all of you having contributed to the LibreOffice project - this release would not have been possible without your help. Yours, The Document Foundation Board of Directors ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] Check recent master wiki-publisher.oxt
Hi Stephan, Stephan Bergmann wrote (14-05-12 10:46) So, if anybody here is experienced with wiki-publisher.oxt (aka MediaWiki extension), it would be great if they could test its functionality in very recent master builds. [...] Already got any feed back? (The issue/fix was mentioned on the blog.) -- - Cor - http://nl.libreoffice.org ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] minutes of ESC call...
2012/5/24 Caolán McNamara caol...@redhat.com: * QA update (Rainer) + best builds for windows testing to get backtraces ? + use bytemark box builds, tinderbox #20 On Windows, symbols are not embedded in executables but they are in separate .pdb files. Please zip *.pdb from solver together and upload it next to the installer, otherwise it will not be possible to produce backtraces. Andras ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-qa] XII Congreso Ciencia y Espiritu en Madrid
Vealo en directo por internet Conexión para los dos días: 11 Euros Solicite más información: i...@cienciayespiritu.com Telf. 93 362 37 00 Ponentes Enrique de Vicente Josep Pàmies Victor Brossa Albert Ronald Morales Ángel Gracia Felix Rodrigo Mora Santi Ibarretxe y Fran Rubio Javier Pérez Nieto Antonio Ortega Xavier Pedro y Blanca Coronel Diego Camacho Diana Castillo Vicente Fuentes José Luis Tejero Clara Bueno Fulgencia León Alegría Pilar Baselga Ángel Lafuente Leer más. TEMATICAS - Energia libre. El desconocido que nos rodea - Porque hicieron el 11-S , y porque sus planes van a fracasar
[Libreoffice-qa] XII Congreso Ciencia y Espiritu en Madrid
Vealo en directo por internet Conexión para los dos días: 11 Euros Solicite más información: i...@cienciayespiritu.com Telf. 93 362 37 00 Ponentes Enrique de Vicente Josep Pàmies Victor Brossa Albert Ronald Morales Ángel Gracia Felix Rodrigo Mora Santi Ibarretxe y Fran Rubio Javier Pérez Nieto Antonio Ortega Xavier Pedro y Blanca Coronel Diego Camacho Diana Castillo Vicente Fuentes José Luis Tejero Clara Bueno Fulgencia León Alegría Pilar Baselga Ángel Lafuente Leer más. TEMATICAS - Energia libre. El desconocido que nos rodea - Porque hicieron el 11-S , y porque sus planes van a fracasar
[Libreoffice-bugs] [Bug 50178] Reading Visio file causes crash
https://bugs.freedesktop.org/show_bug.cgi?id=50178 Julien Nabet serval2...@yahoo.fr changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #6 from Julien Nabet serval2...@yahoo.fr 2012-05-23 23:26:40 PDT --- I proposed a patch here http://nabble.documentfoundation.org/PATCH-fix-proposed-for-fdo-50178-Visio-tp3985678.html. I'm waiting for the comments of devs. Meanwhile, could you attach other Visio files which fail ? I'd like to test them to see if it was the same problem or if it's different. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 50301] New: : .doc file layout problem
https://bugs.freedesktop.org/show_bug.cgi?id=50301 Bug #: 50301 Summary: : .doc file layout problem Classification: Unclassified Product: LibreOffice Version: LibO 3.5.3 release Platform: Other OS/Version: All Status: UNCONFIRMED Status Whiteboard: BSA Severity: normal Priority: medium Component: Libreoffice AssignedTo: libreoffice-bugs@lists.freedesktop.org ReportedBy: smr.ash1...@gmail.com Problem description: The layout of .doc file I have isn't shown correctly (may be because of having too many tables and arts) Attached file description: After extracting zip file you will see these files: form5.doc (the main file) Needed Fonts.zip (Fonts used in the main document) form5-Microsoft Word layout.pdf (What you see in Microsoft Word) form5-Libreoffice layout.pdf (What you see in Libreoffice Writer) Steps to reproduce: 1. open the file form5.doc Current behavior: The layout as you see isn't correct (like the file form5-Microsoft word layout.pdf which is created with Microsoft Word) Expected behavior: The layout should be like form5-Microsoft Word layout.pdf Platform (if different from the browser): Browser: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:12.0) Gecko/20100101 Firefox/12.0 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 37608] Index of Tables cannot generate hyperlinks
https://bugs.freedesktop.org/show_bug.cgi?id=37608 Davide Cavestro gr...@libero.it changed: What|Removed |Added CC||gr...@libero.it --- Comment #4 from Davide Cavestro gr...@libero.it 2012-05-23 23:49:55 PDT --- Still happens on LibreOffice 3.4.6 OOO340m1 (Build:602) This feature would be very useful. See also https://bugs.freedesktop.org/show_bug.cgi?id=39904 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 45049] Non-standard caption number and reference do not appear in the insert cross-reference dialog
https://bugs.freedesktop.org/show_bug.cgi?id=45049 --- Comment #24 from andis.lazd...@gmail.com 2012-05-24 00:02:29 UTC --- The problem is still there, Ubuntu 12.04 LibreOffice 3.5.4.2 Build ID: 165a79a-7059095-e13bb37-fef39a4-9503d18 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 42709] Animated GIFs not displaying correctly.
https://bugs.freedesktop.org/show_bug.cgi?id=42709 --- Comment #37 from andis.lazd...@gmail.com 2012-05-24 00:03:42 PDT --- The problem is not solved, Ubuntu 12.04 LibreOffice 3.5.4.2 Build ID: 165a79a-7059095-e13bb37-fef39a4-9503d18 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 50299] MOD shows not existing small remainder with calculated Dividend
https://bugs.freedesktop.org/show_bug.cgi?id=50299 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added OS/Version|Linux (All) |All Severity|normal |enhancement Priority|medium |low CC||LibreOffice@bielefeldundbus ||s.de Summary|Critical bug in LibreOffice |MOD shows not existing |Calc when using MOD (the|small remainder with |modulo function)|calculated Dividend Version|LibO 3.5.3 release |LibO 3.3.0 Beta2 --- Comment #3 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 2012-05-24 00:08:53 PDT --- Effekt is reproducible with LibreOffice 3.5.4.2 (RC2) German UI/Locale [Build-ID: 165a79a-7059095-e13bb37-fef39a4-9503d18] on German WIN7 Home Premium (64bit) Please ignore formulas in original report (they are wrong), instead please use sample document. I see unexpected remainders in B6, B9, what disappear when I replace Numbers 0,3 and 0,6 by 0,30 and 0,60. But IMHO those are inevitable rounding errors inaccuracies. Those are also visible with AOOo 3.4, EXCEL 2010 and Gnumeric, but it seems EXCEL makes a smarter job during input: when I replace cell Contents 0,3 typing again 0,3 the remainder becomes 0. In LibO That never worked different, also effect reproducible with LibO 3.3.3 @Qubit Please contribute precise descriptions instead of Terrible horrible Bug in LibreOffice ;-) -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 50147] EDITING: Crash after resorting slides
https://bugs.freedesktop.org/show_bug.cgi?id=50147 Roman Eisele b...@eikota.de changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution||DUPLICATE Version|LibO 3.5.3 release |LibO 3.5.0 Release --- Comment #5 from Roman Eisele b...@eikota.de 2012-05-24 00:19:29 PDT --- Due to comment #4, I mark this bug as a duplicate of our famous bug 47368, just like bug 47569 and other bug reports about crashes on MacOS with Universal Access/accessibility enabled. Modified 'Version' according to comment #4: this issue is reproducible for the 1st time in LibO 3.5.0, but not in 3.4.x. @Frank Winklmeier: Thank you very much for your fast answer! Marking this bug as a duplicate does not make your bug report worthless etc. Your report is still a valuable contribution, and every additional duplicate should increase the weight of bug 47368 -- maybe some developer will finally find a way to fix it ... (This seems difficult, however, because bug 47368 is a really weird affair ;-( *** This bug has been marked as a duplicate of bug 47368 *** -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 47368] Many crashes when accessibility enabled on MAC
https://bugs.freedesktop.org/show_bug.cgi?id=47368 Roman Eisele b...@eikota.de changed: What|Removed |Added CC||fr...@winklmeier.name --- Comment #25 from Roman Eisele b...@eikota.de 2012-05-24 00:19:29 PDT --- *** Bug 50147 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 46517] Subscript/superscript shortcuts apply style to whole word instead of only characters written after use of shortcut
https://bugs.freedesktop.org/show_bug.cgi?id=46517 --- Comment #5 from daniel.ma...@umb.no 2012-05-24 00:22:24 PDT --- Oh my, I didn't know that there are rules! Hope the police won't arrest me for not following _your_ way of handling things ... /sarcasm I tried Autoformat, but there is no way to turn e.g. N2O into Nsubscript2/subscriptO. And I am not advanced enough to program some scripts to do the job. Apart from that, in my opinion the cursor is where text is being inserted, _after_ the cursor. That's why I assumed that subscript/superscript should apply to everything _after_ the cursor position and not the whole word. The current solution reminds me of a typical Microsoft product that behaves intelligently and anticipates what the user wants to do, before the user even knows. (more sarcasm in this sentence ;-) And again, why not have an option for this behaviour and let the user choose what is best. This way LibreOffice would be for everyone and wouldn't force rules upon anyone! -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 50287] Changecase of a single word to UPPERCASE kills LibreOffice
https://bugs.freedesktop.org/show_bug.cgi?id=50287 Roman Eisele b...@eikota.de changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution||DUPLICATE CC||b...@eikota.de --- Comment #1 from Roman Eisele b...@eikota.de 2012-05-24 00:27:17 PDT --- Thank you very much for your bug report! This crash is a known issue, therefore I mark this report as a duplicate of bug 37044 -- please refer to the later for additional details. Good news: bug 37044 is fixed, the fix should appear in the forthcoming release LibreOffice 3.5.4. Feel free to reopen this bug report if the issue is still reproducible for you with LibreOffice 3.5.4 or newer. *** This bug has been marked as a duplicate of bug 37044 *** -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 48601] FILEOPEN: Open Visio's file with bitmap's blocks
https://bugs.freedesktop.org/show_bug.cgi?id=48601 --- Comment #1 from martinsti...@gmail.com 2012-05-24 00:30:51 PDT --- Created attachment 62051 -- https://bugs.freedesktop.org/attachment.cgi?id=62051 Another file LO cannot open and crashes -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 47317] EDITING: CRASH with CHANGE CASE function
https://bugs.freedesktop.org/show_bug.cgi?id=47317 Roman Eisele b...@eikota.de changed: What|Removed |Added OS/Version|All |Mac OS X (All) Status|UNCONFIRMED |RESOLVED Resolution||DUPLICATE CC||b...@eikota.de --- Comment #1 from Roman Eisele b...@eikota.de 2012-05-24 00:31:34 UTC --- Thank you very much for your bug report! This crash is a known issue, therefore I mark this report as a duplicate of bug 37044 -- please refer to the later for additional details. Good news: bug 37044 is fixed, the fix should appear in the forthcoming release LibreOffice 3.5.4. Feel free to reopen this bug report (or bug 37044) if the issue is still reproducible for you with LibreOffice 3.5.4 or newer. *** This bug has been marked as a duplicate of bug 37044 *** -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 50294] Spellcheck shouldn't trigger on case difference if first word of sentence/heading
https://bugs.freedesktop.org/show_bug.cgi?id=50294 Roman Eisele b...@eikota.de changed: What|Removed |Added Component|Libreoffice |Linguistic --- Comment #1 from Roman Eisele b...@eikota.de 2012-05-24 00:42:35 PDT --- This is a spellcheck issue, therefore changed the Component field to 'Linguistic' (the component used For problems with spell checking, hyphenation and thesaurus). -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 50152] LibreOffice Icons are not sharp @ Ubuntu 12.04
https://bugs.freedesktop.org/show_bug.cgi?id=50152 Roman Eisele b...@eikota.de changed: What|Removed |Added OS/Version|All |Linux (All) Component|Libreoffice |UI --- Comment #1 from Roman Eisele b...@eikota.de 2012-05-24 00:45:41 UTC --- This is a UI issue, therefore changed the Component field accordingly. Changed the Platform field to Linux, because the report talks about Ubuntu (and there is no similar issue at least on MacOS X, I can confirm.) -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 50282] The template manager should allow to copy several styles at once
https://bugs.freedesktop.org/show_bug.cgi?id=50282 Roman Eisele b...@eikota.de changed: What|Removed |Added Severity|normal |enhancement CC||b...@eikota.de Summary|Copy several styles at once |The template manager should |in the template manager |allow to copy several ||styles at once --- Comment #1 from Roman Eisele b...@eikota.de 2012-05-24 00:50:30 UTC --- This is an enhancement request, therefore changed the Importance field accordingly and changed the Summary a bit, to make clear that this is a request. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 49951] Document Sign in Windows 7 (Minidriver Support)
https://bugs.freedesktop.org/show_bug.cgi?id=49951 Roman Eisele b...@eikota.de changed: What|Removed |Added OS/Version|All |Windows (All) Summary|: Document Sign in Windows |Document Sign in Windows 7 |7 (Minidriver Support) |(Minidriver Support) --- Comment #2 from Roman Eisele b...@eikota.de 2012-05-24 01:08:12 UTC --- This is a Windows issue, therefore changed the Platform field accordingly. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 49910] Libreoffice save as file dialog does not automatically fill complete filename
https://bugs.freedesktop.org/show_bug.cgi?id=49910 Roman Eisele b...@eikota.de changed: What|Removed |Added Component|Libreoffice |UI --- Comment #1 from Roman Eisele b...@eikota.de 2012-05-24 01:10:43 PDT --- This is a UI issue, therefore changed the Component field accordingly. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 49701] Provide UI to cancel opening of a file
https://bugs.freedesktop.org/show_bug.cgi?id=49701 Roman Eisele b...@eikota.de changed: What|Removed |Added Status|UNCONFIRMED |NEW Severity|normal |enhancement CC||b...@eikota.de Ever Confirmed|0 |1 Component|Libreoffice |UI --- Comment #3 from Roman Eisele b...@eikota.de 2012-05-24 01:21:59 PDT --- This is a UI issue, therefore changed the Component field accordingly. This is an enhancement request, therefore changed the Importance field accordingly. Set Status to NEW, because I can confirm that there is no 'Cancel' button for file opening ;-) Also, pressing ESC or Cmd+. (Cmd+. was the old standard cancel shortcut on MacOS) does not stop the fileopen process. So IMHO this is a reasonable enhancement request; this enhancement would be very useful with large files, esp. with some .doc and .docx file which take very long to open ... (see e.g. bug 39179). -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 49651] Bug asking for account
https://bugs.freedesktop.org/show_bug.cgi?id=49651 Roman Eisele b...@eikota.de changed: What|Removed |Added Component|Libreoffice |WWW --- Comment #3 from Roman Eisele b...@eikota.de 2012-05-24 01:25:01 PDT --- This is (if anything) a WWW issue, therefore changed Component field accordingly. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 34046] Account request
https://bugs.freedesktop.org/show_bug.cgi?id=34046 Roman Eisele b...@eikota.de changed: What|Removed |Added Component|Libreoffice |WWW --- Comment #4 from Roman Eisele b...@eikota.de 2012-05-24 01:28:28 PDT --- This is (if anything) a WWW issue, therefore changed Component field accordingly. @Guillaume Poussel: Has this issue been resolved in between? Then please close this bug report (set Status to RESOLVED/FIXED or something similar). Thank you very much! -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 33743] Add Basic Fonts function in Options of Calc and Impress
https://bugs.freedesktop.org/show_bug.cgi?id=33743 Roman Eisele b...@eikota.de changed: What|Removed |Added Severity|normal |enhancement CC||b...@eikota.de --- Comment #11 from Roman Eisele b...@eikota.de 2012-05-24 01:32:54 PDT --- This is/was an enhancement request, therefore changed the Platform field accordingly. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 46517] Subscript/superscript shortcuts apply style to whole word instead of only characters written after use of shortcut
https://bugs.freedesktop.org/show_bug.cgi?id=46517 --- Comment #6 from sasha.libreoff...@gmail.com 2012-05-24 02:08:03 PDT --- I tried Autoformat, but there is no way to turn e.g. N2O Strange. In my case it works. I assigned this formula to n2 name and when I type n2 and press F3, then n2 replaces to N2O where 2 in subscript. And again, why not have an option for this behaviour and let the user choose what is best. Very good idea. Please, create separate Functionality Request bugreport for it. IMHO changing font to subscript and again to normal font in each formula is not perfect. We should invent something what does it automatically, at least in most cases. PS: And how about Edit-FindReplace using Regular Expressions? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 49334] FORMATTING: cell border not saving.
https://bugs.freedesktop.org/show_bug.cgi?id=49334 Michael Stahl mst...@redhat.com changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution||DUPLICATE CC||mst...@redhat.com --- Comment #6 from Michael Stahl mst...@redhat.com 2012-05-24 02:44:46 PDT --- *** This bug has been marked as a duplicate of bug 46112 *** -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 46112] Formatting Cell Border
https://bugs.freedesktop.org/show_bug.cgi?id=46112 Michael Stahl mst...@redhat.com changed: What|Removed |Added CC||mwfo...@juno.com --- Comment #7 from Michael Stahl mst...@redhat.com 2012-05-24 02:44:46 PDT --- *** Bug 49334 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 46112] Cell Border double lines imported from old OOo versions
https://bugs.freedesktop.org/show_bug.cgi?id=46112 Michael Stahl mst...@redhat.com changed: What|Removed |Added CC||cedric.bosdonnat.ooo@free.f ||r, er...@redhat.com, ||markus.mohrhard@googlemail. ||com, mst...@redhat.com Summary|Formatting Cell Border |Cell Border double lines ||imported from old OOo ||versions Keywords||regression --- Comment #8 from Michael Stahl mst...@redhat.com 2012-05-24 02:46:34 PDT --- looks the same in LibreOffice 3.5.4, OOo 3.4beta, and OOo 3.3. ah, the document is produced by LibreOffice 3.5, guess then the borders as written by earlier versions don't get imported properly? oh, tried out what happens when importing various double borders written by OOo 3.3 in LO 3.5.4, what a horrible mess... -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 50284] FILEOPEN .doc/.docx (MSO2007) Bullet lists show wrong bullet symbols MacOS X
https://bugs.freedesktop.org/show_bug.cgi?id=50284 Roman Eisele b...@eikota.de changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever Confirmed|1 |0 --- Comment #8 from Roman Eisele b...@eikota.de 2012-05-24 02:52:14 PDT --- (In reply to comment #7) I have a problem to understand the FILESAVE component part of this bug. [...] @Roman Can you please explain the FILESAVE problem? @Rainer: Oh, sorry, this is my fault! I first copied the Summary field from bug 34814 (because both bugs are so similar) and then adapted it, but obviously I forgot to remove the FILESAVE. I don't see a FILESAVE component, too, only a FILEOPEN issue. (BTW: Was there really a FILESAVE issue in bug 34814? If not, we should remove FILESAVE from the Summary of that bug, too ...) Therefore, thank you for your question and for correction of the Summary field! IMHO it is correct as it stands now (FILEOPEN .doc/.docx (MSO2007) Bullet lists show wrong bullet symbols MacOS X). Set Status back to UNCONFIRMED, still looking for someone else to confirm this issue (on MacOS only, of course) ... -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 46549] Libreoffice Grammar Check returns, bad article, incorrectly
https://bugs.freedesktop.org/show_bug.cgi?id=46549 Roman Eisele b...@eikota.de changed: What|Removed |Added OS/Version|Linux (All) |All Status|UNCONFIRMED |NEW Priority|medium |low CC||b...@eikota.de Ever Confirmed|0 |1 Component|Libreoffice |Linguistic --- Comment #1 from Roman Eisele b...@eikota.de 2012-05-24 02:55:36 PDT --- REPRODUCIBLE with LibreOffice 3.5.4.1 (Build-ID: 7306755-f4f605c-738527d-1cf4bc1-9930dc8) on MacOS X 10.6.8. Therefore changed Status to NEW and Platform to All (not Linux only). NB: I can reproduce the problem only with ... an habitual ..., not with ... an historian ...: the 2nd example mentioned is not marked as wrong. So historian seems to be included within some exceptions list, but habitual not. This is a Grammer checker issue, therefore changed the Component field accordingly to Linguistic. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 50278] Provide separate dock icons for each component on Mac OS X instead of or in addition to the global launcher
https://bugs.freedesktop.org/show_bug.cgi?id=50278 Roman Eisele b...@eikota.de changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||b...@eikota.de Ever Confirmed|0 |1 --- Comment #1 from Roman Eisele b...@eikota.de 2012-05-24 03:01:33 PDT --- Set Status to NEW because this is a valid enhancement request (there are no separate dock icons for the components of LibreOffice 3.3.x, 3.4.x, or 3.5.x on MacOS X). (Personally, I don't know if this would be a good enhancement -- I prefer the way it is now --, but this does not change the fact that this is a valid request. ;-) -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 46586] FILESAVE - Save fail - Must use SaveAS if backup option is set
https://bugs.freedesktop.org/show_bug.cgi?id=46586 sasha.libreoff...@gmail.com changed: What|Removed |Added CC||sasha.libreoff...@gmail.com --- Comment #1 from sasha.libreoff...@gmail.com 2012-05-24 03:04:40 PDT --- Thanks for bugreport Please, verify if in last version of LibreOffice still reproducible -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 50035] CONFIGURATION: During initialization of Extensions several CRASHes until first launch will be successful.
https://bugs.freedesktop.org/show_bug.cgi?id=50035 --- Comment #6 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 2012-05-24 03:10:09 PDT --- @András: I found a User Profile I used until 2012-05-11 wiht what I can reproduce the crashes for [Reproducible] with parallel installation of Master LOdev 3.6.0alpha0+ – WIN7 Home Premium (64bit) ENGLISH UI [Build ID: 7e65666] (tinderbox: Win-x86@6-fast, pull time 2012-05-22 21:46:19) by simply replacing the current Profile by that one. 3.5 MB exceed Attachment limitation, may I send it to you by Mail? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 46587] : Report Displays a Number incorrectly if formatted as 'number' but correctly if format described as 'text'.
https://bugs.freedesktop.org/show_bug.cgi?id=46587 sasha.libreoff...@gmail.com changed: What|Removed |Added CC||sasha.libreoff...@gmail.com --- Comment #1 from sasha.libreoff...@gmail.com 2012-05-24 03:14:07 PDT --- Thanks for bugreport Please, verify if in last version of LibreOffice still reproducible And if reproducible, please attach screenshot where number shown correct and another where number is wrong. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 50284] FILEOPEN .doc/.docx (MSO2007) Bullet lists show wrong bullet symbols MacOS X
https://bugs.freedesktop.org/show_bug.cgi?id=50284 --- Comment #9 from Alex Thurgood ipla...@yahoo.co.uk 2012-05-24 03:16:17 PDT --- (In reply to comment #8) Hi Roman, Set Status back to UNCONFIRMED, still looking for someone else to confirm this issue (on MacOS only, of course) ... I will check it out when I get some time... Alex -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 46605] EDITING: Only the first part of a large HTML table pastes correctly when copied from Safari
https://bugs.freedesktop.org/show_bug.cgi?id=46605 sasha.libreoff...@gmail.com changed: What|Removed |Added OS/Version|All |Mac OS X (All) CC||sasha.libreoff...@gmail.com -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 41214] ODFF: implement SUMIFS(), COUNTIFS(), AVERAGEIF() and AVERAGEIFS() spreadsheet functions
https://bugs.freedesktop.org/show_bug.cgi?id=41214 Eike Rathke er...@redhat.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 41214] ODFF: implement SUMIFS(), COUNTIFS(), AVERAGEIF() and AVERAGEIFS() spreadsheet functions
https://bugs.freedesktop.org/show_bug.cgi?id=41214 Eike Rathke er...@redhat.com changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED | -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 41214] ODFF: implement SUMIFS(), COUNTIFS(), AVERAGEIF() and AVERAGEIFS() spreadsheet functions
https://bugs.freedesktop.org/show_bug.cgi?id=41214 Eike Rathke er...@redhat.com changed: What|Removed |Added Status|REOPENED|NEW -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs