Re: MSVC 2015 Error C2664

[slacka]

sberg wrote
> fixed with 
> https://cgit.freedesktop.org/libreoffice/core/commit/?id=a4d091485c1cc59a35fb3df17b23a9e10cf9c311;
>  
> "Blind fix for MSVC 2015 error C2664"

Yes that did the trick, and with Markus's commit:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=73f2944618e637762125fabd214b09b4fa50fb90
Revert "convert spell menu to .ui

I can now build successfully on MSVC 2015. 

Thanks Stephan and Markus!



--
View this message in context: 
http://nabble.documentfoundation.org/MSVC-2015-s-broken-static-initializer-list-causing-build-failure-tp4202928p4208948.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: idl/inc

[Stephan Bergmann]

 idl/inc/lex.hxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 64b68e98d215f98f72fd6493b62517ab9984a8d2
Author: Stephan Bergmann 
Date:   Sat Feb 25 10:13:17 2017 +0100

SvTokenStream::nBufPos should be sal_Int32

Change-Id: I929bb6e35a125674b1e65f00e77785b59ae6d2a0

diff --git a/idl/inc/lex.hxx b/idl/inc/lex.hxx
index 40e7fe1..20c7b43 100644
--- a/idl/inc/lex.hxx
+++ b/idl/inc/lex.hxx
@@ -99,7 +99,7 @@ inline SvToken::SvToken()
 class SvTokenStream
 {
 sal_uLong   nLine, nColumn;
-int nBufPos;
+sal_Int32   nBufPos;
 int c;  // next character
 static const sal_uInt16 nTabSize = 4;   // length of tabulator
 OString aStrTrue;
@@ -138,7 +138,7 @@ class SvTokenStream
 // if end of line spare calculation
 if( 0 != c )
 {
-sal_uInt16 n = 0;
+sal_Int32 n = 0;
 nColumn = 0;
 while( n < nBufPos )
 nColumn += aBufStr[n++] == '\t' ? nTabSize : 1;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: registry/source

[Stephan Bergmann]

 registry/source/regimpl.cxx |5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

New commits:
commit 0203b6be4bb397165d7c6c354e75409164a0e360
Author: Stephan Bergmann 
Date:   Sat Feb 25 10:14:05 2017 +0100

loplugin:loopvartoosmall

Change-Id: I8c2fcdbcfaa8ebf83a80fb99701096982b564ef1

diff --git a/registry/source/regimpl.cxx b/registry/source/regimpl.cxx
index 0065b49..aaf9f8f 100644
--- a/registry/source/regimpl.cxx
+++ b/registry/source/regimpl.cxx
@@ -1174,13 +1174,12 @@ static sal_uInt32 checkTypeReaders(RegistryTypeReader& 
reader1,
std::set< OUString >& nameSet)
 {
 sal_uInt32 count=0;
-sal_uInt16 i;
-for (i=0 ; i < reader1.getFieldCount(); i++)
+for (sal_uInt32 i=0 ; i < reader1.getFieldCount(); i++)
 {
 nameSet.insert(reader1.getFieldName(i));
 count++;
 }
-for (i=0 ; i < reader2.getFieldCount(); i++)
+for (sal_uInt32 i=0 ; i < reader2.getFieldCount(); i++)
 {
 if (nameSet.find(reader2.getFieldName(i)) == nameSet.end())
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: android/source

[aleksandar-stefanovic]

 android/source/res/menu/navigation_menu.xml   |   21 ++
 android/source/src/java/org/libreoffice/ui/LibreOfficeUIActivity.java |   85 
--
 2 files changed, 57 insertions(+), 49 deletions(-)

New commits:
commit e792eb52160a16cff3a04d9713e023230247e7c3
Author: aleksandar-stefanovic 
Date:   Thu Feb 16 20:42:45 2017 +0100

Moved navigation items to XML

I made them add programatically before, because I was unsure
whether the list was dynamic, but when I found out that the five
items on the list are actually static, I realized that it's better
to declare menu items in XML, because of the performance and
readibility.

Change-Id: I044abe356e51b26ac13328fcf451cabc9e70a3ea
Reviewed-on: https://gerrit.libreoffice.org/34342
Tested-by: Jenkins 
Reviewed-by: Aleksandar Stefanović 

diff --git a/android/source/res/menu/navigation_menu.xml 
b/android/source/res/menu/navigation_menu.xml
index 21f6860..532c9ed 100644
--- a/android/source/res/menu/navigation_menu.xml
+++ b/android/source/res/menu/navigation_menu.xml
@@ -4,7 +4,26 @@
 android:checkableBehavior="single"
 android:id="@+id/group_providers">
 
-
+
+
+
+
+
+
+
+
+
+
 
 
 
diff --git 
a/android/source/src/java/org/libreoffice/ui/LibreOfficeUIActivity.java 
b/android/source/src/java/org/libreoffice/ui/LibreOfficeUIActivity.java
index 3393484..8655e5c 100644
--- a/android/source/src/java/org/libreoffice/ui/LibreOfficeUIActivity.java
+++ b/android/source/src/java/org/libreoffice/ui/LibreOfficeUIActivity.java
@@ -29,7 +29,6 @@ import android.support.v4.widget.DrawerLayout;
 import android.support.v7.app.ActionBar;
 import android.support.v7.app.ActionBarDrawerToggle;
 import android.support.v7.app.AppCompatActivity;
-import android.support.v7.widget.AppCompatSpinner;
 import android.support.v7.widget.GridLayoutManager;
 import android.support.v7.widget.LinearLayoutManager;
 import android.support.v7.widget.RecyclerView;
@@ -45,8 +44,6 @@ import android.view.View;
 import android.view.View.OnClickListener;
 import android.view.View.OnLongClickListener;
 import android.view.ViewGroup;
-import android.widget.AdapterView;
-import android.widget.ArrayAdapter;
 import android.widget.ImageView;
 import android.widget.TextView;
 import android.widget.Toast;
@@ -68,7 +65,6 @@ import java.net.URI;
 import java.net.URISyntaxException;
 import java.text.SimpleDateFormat;
 import java.util.ArrayList;
-import java.util.Arrays;
 import java.util.Date;
 import java.util.HashSet;
 import java.util.List;
@@ -164,55 +160,48 @@ public class LibreOfficeUIActivity extends 
AppCompatActivity implements Settings
 //Setting up navigation drawer
 drawerLayout = (DrawerLayout) findViewById(R.id.drawer_layout);
 navigationDrawer = (NavigationView) 
findViewById(R.id.navigation_drawer);
-/*
- * These are the currently-known document providers (for which icons 
are assigned).
- * This is to ensure that there is an icon available if the provider 
is recognized, while
- * the unrecognized ones still appear, but without an icon. If there 
is a document provider
- * not on this list, it should be added and an icon assigned to it, in 
the if-else ladder
- * bellow. This is a hacky implementation, maybe we could make 
something better in the
- * future, i.e. we could move this into the menu file and load it that 
way.
- */
-final String LOCAL_DOCUMENTS_NAME = "Local documents";
-final String LOCAL_FILE_SYSTEM_NAME = "Local file system";
-final String EXTERNAL_SD_NAME = "External SD";
-final String OTG_FILE_SYSTEM_NAME = "OTG device (experimental)";
-final String OWNCLOUD_NAME = "Remote server";
-
-//Provider names are wrapped as a ArrayList so indexOf(Object) method 
could be used
-final ArrayList providerNames = new 
ArrayList(
-Arrays.asList(documentProviderFactory.getNames())
-);
-for (CharSequence name : providerNames) {
-int iconRes = 0;
-if (name.equals(LOCAL_DOCUMENTS_NAME)) {
-iconRes = R.drawable.ic_insert_drive_file_black_24dp;
-} else if (name.equals(LOCAL_FILE_SYSTEM_NAME)) {
-iconRes = R.drawable.ic_storage_black_24dp;
-} else if (name.equals(EXTERNAL_SD_NAME)) {
-iconRes = R.drawable.ic_sd_card_black_24dp;
-} else if (name.equals(OTG_FILE_SYSTEM_NAME)) {
-iconRes = R.drawable.ic_usb_black_24dp;
-} else if (name.equals(OWNCLOUD_NAME)) {
-iconRes = R.drawable.ic_cloud_black_24dp;
-}
-MenuItem item = 
navigationDrawer.getMenu().add(R.id.group_providers, Menu.NONE, Menu.NONE, name)
-

[Libreoffice-commits] core.git: sc/qa

[Zdeněk Crhonek]

 sc/qa/unit/data/functions/statistical/fods/chisq.dist.rt.fods | 3860 +++
 sc/qa/unit/data/functions/statistical/fods/t.dist.rt.fods | 5291 ++
 2 files changed, 9151 insertions(+)

New commits:
commit 2b3e1ce39edc5a164ffe42b2e8d49191a71cdaca
Author: Zdeněk Crhonek 
Date:   Fri Feb 24 18:58:00 2017 +0100

add CHISQ.DIST.RT T.DIST.RT testcase

Change-Id: I146e08bbe6984db0fba9e5da93db8ce8d0ef5826
Reviewed-on: https://gerrit.libreoffice.org/34630
Tested-by: Jenkins 
Reviewed-by: Zdenek Crhonek 

diff --git a/sc/qa/unit/data/functions/statistical/fods/chisq.dist.rt.fods 
b/sc/qa/unit/data/functions/statistical/fods/chisq.dist.rt.fods
new file mode 100644
index 000..daa259f
--- /dev/null
+++ b/sc/qa/unit/data/functions/statistical/fods/chisq.dist.rt.fods
@@ -0,0 +1,3860 @@
+
+
+http://www.w3.org/1999/xlink; 
xmlns:dc="http://purl.org/dc/elements/1.1/; 
xmlns:meta="urn:oasis:names:tc:opendocument:xmlns:meta:1.0" 
xmlns:number="urn:oasis:names:tc:opendocument:xmlns:datastyle:1.0" 
xmlns:presentation="urn:oasis:names:tc:opendocument:xmlns:presentation:1.0" 
xmlns:svg="urn:oasis:names:tc:opendocument:xmlns:svg-compatible:1.0" 
xmlns:chart="urn:oasis:names:tc:opendocument:xmlns:chart:1.0" 
xmlns:dr3d="urn:oasis:names:tc:opendocument:xmlns:dr3d:1.0" 
xmlns:math="http://www.w3.org/1998/Math/MathML; 
xmlns:form="urn:oasis:names:tc:opendocument:xmlns:form:1.0" xmlns:scr
 ipt="urn:oasis:names:tc:opendocument:xmlns:script:1.0" 
xmlns:config="urn:oasis:names:tc:opendocument:xmlns:config:1.0" 
xmlns:ooo="http://openoffice.org/2004/office; 
xmlns:ooow="http://openoffice.org/2004/writer; 
xmlns:oooc="http://openoffice.org/2004/calc; 
xmlns:dom="http://www.w3.org/2001/xml-events; 
xmlns:xforms="http://www.w3.org/2002/xforms; 
xmlns:xsd="http://www.w3.org/2001/XMLSchema; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xmlns:rpt="http://openoffice.org/2005/report; 
xmlns:of="urn:oasis:names:tc:opendocument:xmlns:of:1.2" 
xmlns:xhtml="http://www.w3.org/1999/xhtml; 
xmlns:grddl="http://www.w3.org/2003/g/data-view#; 
xmlns:tableooo="http://openoffice.org/2009/table; 
xmlns:drawooo="http://openoffice.org/2010/draw; 
xmlns:calcext="urn:org:documentfoundation:names:experimental:calc:xmlns:calcext:1.0"
 
xmlns:loext="urn:org:documentfoundation:names:experimental:office:xmlns:loext:1.0"
 xmlns:field="urn:openoffice:names:experimental:ooo-ms-interop:xmlns:field:1.0" 
xmlns:form
 x="urn:openoffice:names:experimental:ooxml-odf-interop:xmlns:form:1.0" 
xmlns:css3t="http://www.w3.org/TR/css3-text/; office:version="1.2" 
office:mimetype="application/vnd.oasis.opendocument.spreadsheet">
+ 
2017-02-24T18:54:26.836995622P0D1LibreOfficeDev/5.4.0.0.alpha0$Linux_X86_64
 
LibreOffice_project/36de6c50684c8241969a2064d30aff41e0bc5d97
+ 
+  
+   0
+   0
+   50173
+   6972
+   
+
+ view1
+ 
+  
+   2
+   8
+   0
+   0
+   0
+   0
+   2
+   0
+   0
+   0
+   0
+   0
+   75
+   60
+   true
+   false
+  
+  
+   4
+   1
+   0
+   0
+   0
+   0
+   2
+   0
+   0
+   0
+   0
+   0
+   75
+   60
+   true
+   false
+  
+ 
+ Sheet2
+ 1241
+ 0
+ 75
+ 60
+ false
+ true
+ true
+ true
+ 12632256
+ true
+ true
+ true
+ true
+ false
+ false
+ false
+ 1270
+ 1270
+ 1
+ 1
+ true
+ false
+
+   
+  
+  
+   7
+   false
+   false
+   true
+   true
+   false
+   false
+   false
+   1270
+   1270
+   true
+   true
+   true
+   true
+   true
+   false
+   12632256
+   false
+   Lexmark-E352dn
+   
+
+ cs
+ CZ
+ 
+ 
+ 
+
+
+ en
+ US
+ 
+ 
+ 
+
+
+ nl
+ NL
+ 
+ 
+ 
+
+   
+   true
+   true
+   3
+   1
+   true
+   1
+   true
+   sgH+/0xleG1hcmstRTM1MmRuQ1VQUzpMZXhtYXJrLUUzNTJkbgAWAAMA0wAIAFZUAAAkbQAASm9iRGF0YSAxCnByaW50ZXI9TGV4bWFyay1FMzUyZG4Kb3JpZW50YXRpb249UG9ydHJhaXQKY29waWVzPTEKY29sbGF0ZT1mYWxzZQptYXJnaW5kYWp1c3RtZW50PTAsMCwwLDAKY29sb3JkZXB0aD0yNApwc2xldmVsPTAKcGRmZGV2aWNlPTEKY29sb3JkZXZpY2U9MApQUERDb250ZXhEYXRhClBhZ2VTaXplOkxldHRlcgBJbnB1dFNsb3Q6VHJheTEARHVwbGV4Ok5vbmUAABIAQ09NUEFUX0RVUExFWF9NT0RFDwBEdXBsZXhNb2RlOjpPZmY=
+   false
+   0
+  
+ 
+ 
+  
+   http://openoffice.org/2004/office; 
xmlns:xlink="http://www.w3.org/1999/xlink;>
+
+   
+  
+ 
+ 
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+ 
+ 
+  
+   
+   
+  
+  
+   
+  
+  
+   
+
+   Kč
+  
+  
+   
+   -
+   
+
+   Kč
+   
+  
+  
+
+   
+
+  
+  
+
+   (
+   
+   )
+  
+  
+
+   -
+   
+
+  
+  
+   
+
+   
+   
+   
+  
+  
+   
+  
+  

[Libreoffice-commits] core.git: sc/qa

[Zdeněk Crhonek]

 sc/qa/unit/data/functions/statistical/fods/chisq.test.fods | 5324 +++
 sc/qa/unit/data/functions/statistical/fods/chisqdist.fods  | 4026 
 sc/qa/unit/data/functions/statistical/fods/chisqinv.fods   | 6050 +
 sc/qa/unit/data/functions/statistical/fods/chitest.fods| 5344 +++
 sc/qa/unit/data/functions/text/fods/search.fods|  160 
 5 files changed, 20813 insertions(+), 91 deletions(-)

New commits:
commit 8d5086d571c8565c63717a163cbfc00ef6f15d20
Author: Zdeněk Crhonek 
Date:   Fri Feb 24 19:16:49 2017 +0100

add CHISQ.TEST,CHISQDIST,CHISQINV,CHITEST,SEARCH test case

Change-Id: Ib0fcb9756049bc741b21fb608e1985c1f7c6e7d6
Reviewed-on: https://gerrit.libreoffice.org/34631
Tested-by: Jenkins 
Reviewed-by: Zdenek Crhonek 

diff --git a/sc/qa/unit/data/functions/statistical/fods/chisq.test.fods 
b/sc/qa/unit/data/functions/statistical/fods/chisq.test.fods
new file mode 100644
index 000..1e4ba54
--- /dev/null
+++ b/sc/qa/unit/data/functions/statistical/fods/chisq.test.fods
@@ -0,0 +1,5324 @@
+
+
+http://www.w3.org/1999/xlink; 
xmlns:dc="http://purl.org/dc/elements/1.1/; 
xmlns:meta="urn:oasis:names:tc:opendocument:xmlns:meta:1.0" 
xmlns:number="urn:oasis:names:tc:opendocument:xmlns:datastyle:1.0" 
xmlns:presentation="urn:oasis:names:tc:opendocument:xmlns:presentation:1.0" 
xmlns:svg="urn:oasis:names:tc:opendocument:xmlns:svg-compatible:1.0" 
xmlns:chart="urn:oasis:names:tc:opendocument:xmlns:chart:1.0" 
xmlns:dr3d="urn:oasis:names:tc:opendocument:xmlns:dr3d:1.0" 
xmlns:math="http://www.w3.org/1998/Math/MathML; 
xmlns:form="urn:oasis:names:tc:opendocument:xmlns:form:1.0" xmlns:scr
 ipt="urn:oasis:names:tc:opendocument:xmlns:script:1.0" 
xmlns:config="urn:oasis:names:tc:opendocument:xmlns:config:1.0" 
xmlns:ooo="http://openoffice.org/2004/office; 
xmlns:ooow="http://openoffice.org/2004/writer; 
xmlns:oooc="http://openoffice.org/2004/calc; 
xmlns:dom="http://www.w3.org/2001/xml-events; 
xmlns:xforms="http://www.w3.org/2002/xforms; 
xmlns:xsd="http://www.w3.org/2001/XMLSchema; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xmlns:rpt="http://openoffice.org/2005/report; 
xmlns:of="urn:oasis:names:tc:opendocument:xmlns:of:1.2" 
xmlns:xhtml="http://www.w3.org/1999/xhtml; 
xmlns:grddl="http://www.w3.org/2003/g/data-view#; 
xmlns:tableooo="http://openoffice.org/2009/table; 
xmlns:drawooo="http://openoffice.org/2010/draw; 
xmlns:calcext="urn:org:documentfoundation:names:experimental:calc:xmlns:calcext:1.0"
 
xmlns:loext="urn:org:documentfoundation:names:experimental:office:xmlns:loext:1.0"
 xmlns:field="urn:openoffice:names:experimental:ooo-ms-interop:xmlns:field:1.0" 
xmlns:form
 x="urn:openoffice:names:experimental:ooxml-odf-interop:xmlns:form:1.0" 
xmlns:css3t="http://www.w3.org/TR/css3-text/; office:version="1.2" 
office:mimetype="application/vnd.oasis.opendocument.spreadsheet">
+ 
2017-02-24T19:11:51.019270939P0D1LibreOfficeDev/5.4.0.0.alpha0$Linux_X86_64
 
LibreOffice_project/36de6c50684c8241969a2064d30aff41e0bc5d97
+ 
+  
+   0
+   0
+   98520
+   12262
+   
+
+ view1
+ 
+  
+   2
+   8
+   0
+   0
+   0
+   0
+   2
+   0
+   0
+   0
+   0
+   0
+   100
+   60
+   true
+   false
+  
+  
+   4
+   1
+   0
+   0
+   0
+   0
+   2
+   0
+   0
+   0
+   0
+   0
+   100
+   60
+   true
+   false
+  
+ 
+ Sheet2
+ 1241
+ 0
+ 100
+ 60
+ false
+ true
+ true
+ true
+ 12632256
+ true
+ true
+ true
+ true
+ true
+ false
+ false
+ 1270
+ 1270
+ 1
+ 1
+ true
+ false
+
+   
+  
+  
+   7
+   false
+   false
+   true
+   true
+   false
+   false
+   false
+   1270
+   1270
+   true
+   true
+   true
+   true
+   true
+   false
+   12632256
+   false
+   Lexmark-E352dn
+   
+
+ cs
+ CZ
+ 
+ 
+ 
+
+
+ de
+ DE
+ 
+ 
+ 
+
+
+ en
+ US
+ 
+ 
+ 
+
+
+ nl
+ NL
+ 
+ 
+ 
+
+   
+   true
+   true
+   3
+   1
+   true
+   1
+   true
+   sgH+/0xleG1hcmstRTM1MmRuQ1VQUzpMZXhtYXJrLUUzNTJkbgAWAAMA0wAIAFZUAAAkbQAASm9iRGF0YSAxCnByaW50ZXI9TGV4bWFyay1FMzUyZG4Kb3JpZW50YXRpb249UG9ydHJhaXQKY29waWVzPTEKY29sbGF0ZT1mYWxzZQptYXJnaW5kYWp1c3RtZW50PTAsMCwwLDAKY29sb3JkZXB0aD0yNApwc2xldmVsPTAKcGRmZGV2aWNlPTEKY29sb3JkZXZpY2U9MApQUERDb250ZXhEYXRhCkR1cGxleDpOb25lAElucHV0U2xvdDpUcmF5MQBQYWdlU2l6ZTpMZXR0ZXIAABIAQ09NUEFUX0RVUExFWF9NT0RFDwBEdXBsZXhNb2RlOjpPZmY=
+   false
+   0
+  
+ 
+ 
+  
+   http://openoffice.org/2004/office; 
xmlns:xlink="http://www.w3.org/1999/xlink;>
+
+   
+  
+ 

[Libreoffice-commits] core.git: codemaker/source

[Stephan Bergmann]

 codemaker/source/cppumaker/cppuoptions.cxx |2 +-
 codemaker/source/javamaker/javaoptions.cxx |2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 5222dd86dd3516c106a2e77e77885e074e1f7577
Author: Stephan Bergmann 
Date:   Sat Feb 25 10:10:02 2017 +0100

loplugin:loopvartoosmall

Change-Id: Ifd83cb180072304511ad8eb031dcf2a867e97e62

diff --git a/codemaker/source/cppumaker/cppuoptions.cxx 
b/codemaker/source/cppumaker/cppuoptions.cxx
index 3a0bdb5..c0b578c 100644
--- a/codemaker/source/cppumaker/cppuoptions.cxx
+++ b/codemaker/source/cppumaker/cppuoptions.cxx
@@ -35,7 +35,7 @@ using ::rtl::OString;
 bool CppuOptions::initOptions(int ac, char* av[], bool bCmdFile)
 {
 boolret = true;
-sal_uInt16  i=0;
+int i=0;
 
 if (!bCmdFile)
 {
diff --git a/codemaker/source/javamaker/javaoptions.cxx 
b/codemaker/source/javamaker/javaoptions.cxx
index 97eef36..510fedc 100644
--- a/codemaker/source/javamaker/javaoptions.cxx
+++ b/codemaker/source/javamaker/javaoptions.cxx
@@ -33,7 +33,7 @@
 bool JavaOptions::initOptions(int ac, char* av[], bool bCmdFile)
 {
 boolret = true;
-sal_uInt16  i=0;
+int i=0;
 
 if (!bCmdFile)
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: android/source

[aleksandar-stefanovic]

 android/source/res/layout/file_list_item.xml |1 +
 android/source/res/values/themes.xml |2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

New commits:
commit faeb982d2fc208a5beb22f75185b93bc3724ce03
Author: aleksandar-stefanovic 
Date:   Wed Feb 15 09:53:13 2017 +0100

Fixed text alignment in list

Changed text alignment in file browser to not center horizontally,
because it should be glanceable and therefore should be left-aligned
(ideally the start-aligned).
See https://material.io/guidelines/components/lists.html .

Change-Id: I383141bc2f49b63927c136d911f50cfd15bdef45
Reviewed-on: https://gerrit.libreoffice.org/34290
Reviewed-by: Aleksandar Stefanović 
Tested-by: Aleksandar Stefanović 

diff --git a/android/source/res/layout/file_list_item.xml 
b/android/source/res/layout/file_list_item.xml
index a2dcfdb..6ffc928 100644
--- a/android/source/res/layout/file_list_item.xml
+++ b/android/source/res/layout/file_list_item.xml
@@ -52,6 +52,7 @@
 android:layout_width="0dp"
 android:layout_weight="2"
 android:ellipsize="end"
+android:gravity="end"
 android:maxLines="1"/>
 
 
diff --git a/android/source/res/values/themes.xml 
b/android/source/res/values/themes.xml
index 4036d97..5b67264 100644
--- a/android/source/res/values/themes.xml
+++ b/android/source/res/values/themes.xml
@@ -6,7 +6,7 @@
 
 
 
-center
+center_vertical
 @android:color/black
 14sp
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - sc/source

[Markus Mohrhard]

 sc/source/core/data/document.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 96b7d1d5d6e97078508f9366b340c65ab0a0cc75
Author: Markus Mohrhard 
Date:   Fri Feb 24 23:10:57 2017 +0100

xPoolHelper is empty in a clipboard doc

Found by the crashreporter:

http://crashreport.libreoffice.org/stats/signature/ScDocument::IsClipboardSource()

Change-Id: I3fb030921b653396deb46a9e98d30d5df9c9ce15
(cherry picked from commit c63ff2a769f4601f67ffd13cb36df63c70fdd601)
Reviewed-on: https://gerrit.libreoffice.org/34641
Reviewed-by: Eike Rathke 
Tested-by: Jenkins 

diff --git a/sc/source/core/data/document.cxx b/sc/source/core/data/document.cxx
index 27456da..80fb075 100644
--- a/sc/source/core/data/document.cxx
+++ b/sc/source/core/data/document.cxx
@@ -2516,7 +2516,7 @@ void ScDocument::SetClipParam(const ScClipParam& rParam)
 bool ScDocument::IsClipboardSource() const
 {
 ScDocument* pClipDoc = ScModule::GetClipDoc();
-return pClipDoc && pClipDoc->xPoolHelper.is() &&
+return xPoolHelper.is() && pClipDoc && pClipDoc->xPoolHelper.is() &&
 xPoolHelper->GetDocPool() == pClipDoc->xPoolHelper->GetDocPool();
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: Chart test failures on mac: text size differences

[Tamas Zolnai]

Hi Khaled,

On Friday, February 24, 2017 19:40 GMT, Khaled Hosny  
wrote: 
 
> On Fri, Feb 24, 2017 at 05:41:25PM +, Tamas Zolnai wrote:
> > Hi Khaled,
> > 
> > I see you're working on text rendering, so I thought that my findings
> > might be usefull for you. I had a look at chart test failures on Mac
> > and found that it is because of text size differences. (I checked your
> > latest change [1], but the differences are still there.)
> > Both text width and height is different (comparing Windows and Mac).
> > Interestingly when I changed the font to a bundled, monospace font
> > (e.g. Liberation Mono, DejaVu Sans Mono), width differences
> > disappeared and only height differences remained. So there are at
> > least two kind of issues here. One which is about the proportional
> > fonts character width and one related to the text height.
> > I added a minimal test case to the source [2] with which it's easier
> > to debug the second issue (for the first issue the test case's font
> > need to be changed to a bundled, proportional font).
> 
> We need to first who Chart is calculating the text width and depth,
> namely which function(s) it uses from vcl, to be able to debug it and
> see where are these differences coming from.

I debugged it earlier. It was a bit hard to follow the trace from chart code to 
text rendering, but as I see the height differences coming somwhere from these 
methods (I debugged only the height difference):
ImpEditEngine::CalcTextHeight()
SvxFont::GetPhysTxtSize()
OutputDevice::GetTextHeight()

However I think it would be better to debug this problem with a unit test in 
vcl module which tests directly the text rendering. I would suggest that if you 
are working making text rendering consitent. The vcldemo does something 
similar, but it's just doing the rendering and does not compare the text size 
to expected values. That code can be reused to write some unit tests about text 
rendering.
Actually I'm a bit suprised that there is no a unit test for this (I did not 
find any in vcl module). I heard some expectations from other LO developers 
that text rendering is consistent now on different systems but I can't see how 
it can be expected if there isn't any test about it. It's hard to imagine that 
somebody can test it manually on all the three main platforms.

Best Regards,
Tamás

 
 


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: Branch 'aoo/trunk' - sal/osl

[Pedro Giffuni]

 sal/osl/unx/pipe.c |   40 
 sal/osl/unx/sockimpl.h |6 +-
 2 files changed, 17 insertions(+), 29 deletions(-)

New commits:
commit 68925500cc6652505a7f529a72fabbb9ad513e15
Author: Pedro Giffuni 
Date:   Sat Feb 25 15:46:26 2017 +

i101100 - Fix some aliasing issues.

Undo unnecessary change from r1782205: using a union in oslSocketAddrImpl
just makes the code more complex and doesn't improve aliasing.

diff --git a/sal/osl/unx/pipe.c b/sal/osl/unx/pipe.c
index 298ce85..eb48dae 100644
--- a/sal/osl/unx/pipe.c
+++ b/sal/osl/unx/pipe.c
@@ -163,11 +163,7 @@ oslPipe SAL_CALL osl_psz_createPipe(const sal_Char 
*pszPipeName, oslPipeOptions
 {
 intFlags;
 size_t len;
-union
-{
-struct sockaddr addr;
-struct sockaddr_un addr_un;
-} s;
+struct sockaddr_un addr;
 
 sal_Char name[PATH_MAX + 1];
 const sal_Char   *pPath;
@@ -222,16 +218,16 @@ oslPipe SAL_CALL osl_psz_createPipe(const sal_Char 
*pszPipeName, oslPipeOptions
 }
 }
 
-memset(_un, 0, sizeof(s.addr_un));
+memset(, 0, sizeof(addr));
 
 OSL_TRACE("osl_createPipe : Pipe Name '%s'",name);
 
-s.addr_un.sun_family = AF_UNIX;
-strncpy(s.addr_un.sun_path, name, sizeof(s.addr_un.sun_path));
+addr.sun_family = AF_UNIX;
+strncpy(addr.sun_path, name, sizeof(addr.sun_path));
 #if defined(FREEBSD)
-len = SUN_LEN(_un);
+len = SUN_LEN();
 #else
-len = sizeof(s.addr_un);
+len = sizeof(addr);
 #endif
 
 if ( Options & osl_Pipe_CREATE )
@@ -242,7 +238,7 @@ oslPipe SAL_CALL osl_psz_createPipe(const sal_Char 
*pszPipeName, oslPipeOptions
 if ( ( stat(name, ) == 0) &&
  ( S_ISSOCK(status.st_mode) || S_ISFIFO(status.st_mode) ) )
 {
-if ( connect(pPipe->m_Socket,,len) >= 0 )
+if ( connect(pPipe->m_Socket,(struct sockaddr *),len) >= 0 )
 {
 OSL_TRACE("osl_createPipe : Pipe already in use. Errno: %d; 
%s\n",errno,strerror(errno));
 close (pPipe->m_Socket);
@@ -254,7 +250,7 @@ oslPipe SAL_CALL osl_psz_createPipe(const sal_Char 
*pszPipeName, oslPipeOptions
 }
 
 /* ok, fs clean */
-if ( bind(pPipe->m_Socket, , len) < 0 )
+if ( bind(pPipe->m_Socket, (struct sockaddr *), len) < 0 )
 {
 OSL_TRACE("osl_createPipe : failed to bind socket. Errno: %d; 
%s\n",errno,strerror(errno));
 close (pPipe->m_Socket);
@@ -286,7 +282,7 @@ oslPipe SAL_CALL osl_psz_createPipe(const sal_Char 
*pszPipeName, oslPipeOptions
 {   /* osl_pipe_OPEN */
 if ( access(name, F_OK) != -1 )
 {
-if ( connect( pPipe->m_Socket, , len) >= 0 )
+if ( connect( pPipe->m_Socket, (struct sockaddr *), len) >= 0 
)
 {
 return (pPipe);
 }
@@ -325,11 +321,7 @@ void SAL_CALL osl_closePipe( oslPipe pPipe )
 int nRet;
 #if CLOSESOCKET_DOESNT_WAKE_UP_ACCEPT
 size_t len;
-union
-{
-struct sockaddr_un addr_un;
-struct sockaddr addr;
-} s;
+struct sockaddr_un addr;
 int fd;
 #endif
 int ConnFD;
@@ -356,19 +348,19 @@ void SAL_CALL osl_closePipe( oslPipe pPipe )
 pPipe->m_bIsInShutdown = sal_True;
 pPipe->m_Socket = -1;
 fd = socket(AF_UNIX, SOCK_STREAM, 0);
-memset(_un, 0, sizeof(s.addr_un));
+memset(, 0, sizeof(addr));
 
 OSL_TRACE("osl_destroyPipe : Pipe Name '%s'",pPipe->m_Name);
 
-s.addr_un.sun_family = AF_UNIX;
-strncpy(s.addr_un.sun_path, pPipe->m_Name, sizeof(s.addr_un.sun_path));
+addr.sun_family = AF_UNIX;
+strncpy(addr.sun_path, pPipe->m_Name, sizeof(addr.sun_path));
 #if defined(FREEBSD)
-len = SUN_LEN(_un);
+len = SUN_LEN();
 #else
-len = sizeof(s.addr_un);
+len = sizeof(addr);
 #endif
 
-nRet = connect( fd, , len);
+nRet = connect( fd, (struct sockaddr *), len);
 #if OSL_DEBUG_LEVEL > 1
 if ( nRet < 0 )
 {
diff --git a/sal/osl/unx/sockimpl.h b/sal/osl/unx/sockimpl.h
index 7af9733..2e80c9f 100644
--- a/sal/osl/unx/sockimpl.h
+++ b/sal/osl/unx/sockimpl.h
@@ -55,11 +55,7 @@ struct oslSocketImpl {
 struct oslSocketAddrImpl
 {
 sal_Int32 m_nRefCount;
-union
-{
-struct sockaddr m_sockaddr;
-struct sockaddr_in m_sockaddr_in;
-};
+struct sockaddr m_sockaddr;
 };
 
 struct oslPipeImpl {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: vcl/source

[Stephan Bergmann]

 vcl/source/window/menubarwindow.cxx  |2 +-
 vcl/source/window/menufloatingwindow.cxx |4 ++--
 vcl/source/window/menuitemlist.cxx   |6 +++---
 vcl/source/window/menuitemlist.hxx   |6 +++---
 4 files changed, 9 insertions(+), 9 deletions(-)

New commits:
commit ea4fdc135e879ea6087f3f4a0a6ce0f04b1d1d7d
Author: Stephan Bergmann 
Date:   Sat Feb 25 17:24:04 2017 +0100

Propagate sal_uInt16/size_t mismatch out of MenuItemList::SearchItem

Change-Id: I31ae81876c541979600ecd25ab7a6e3a0e3b0d0b

diff --git a/vcl/source/window/menubarwindow.cxx 
b/vcl/source/window/menubarwindow.cxx
index a2ad3a9..dfca714 100644
--- a/vcl/source/window/menubarwindow.cxx
+++ b/vcl/source/window/menubarwindow.cxx
@@ -825,7 +825,7 @@ bool MenuBarWindow::HandleKeyEvent( const KeyEvent& 
rKEvent, bool bFromMenu )
 sal_Unicode nCharCode = rKEvent.GetCharCode();
 if ( nCharCode )
 {
-sal_uInt16 nEntry, nDuplicates;
+size_t nEntry, nDuplicates;
 MenuItemData* pData = pMenu->GetItemList()->SearchItem( nCharCode, 
rKEvent.GetKeyCode(), nEntry, nDuplicates, nHighlightedItem );
 if ( pData && (nEntry != ITEMPOS_INVALID) )
 {
diff --git a/vcl/source/window/menufloatingwindow.cxx 
b/vcl/source/window/menufloatingwindow.cxx
index 4acbb06..32de3fd 100644
--- a/vcl/source/window/menufloatingwindow.cxx
+++ b/vcl/source/window/menufloatingwindow.cxx
@@ -1124,8 +1124,8 @@ void MenuFloatingWindow::KeyInput( const KeyEvent& 
rKEvent )
 default:
 {
 sal_Unicode nCharCode = rKEvent.GetCharCode();
-sal_uInt16 nPos = 0;
-sal_uInt16 nDuplicates = 0;
+size_t nPos = 0;
+size_t nDuplicates = 0;
 MenuItemData* pData = (nCharCode && pMenu && accel) ?
 pMenu->GetItemList()->SearchItem(nCharCode, 
rKEvent.GetKeyCode(), nPos, nDuplicates, nHighlightedItem) : nullptr;
 if (pData)
diff --git a/vcl/source/window/menuitemlist.cxx 
b/vcl/source/window/menuitemlist.cxx
index 44757a4..7316ed9 100644
--- a/vcl/source/window/menuitemlist.cxx
+++ b/vcl/source/window/menuitemlist.cxx
@@ -151,9 +151,9 @@ MenuItemData* MenuItemList::GetData( sal_uInt16 nSVId, 
size_t& rPos ) const
 MenuItemData* MenuItemList::SearchItem(
 sal_Unicode cSelectChar,
 KeyCode aKeyCode,
-sal_uInt16& rPos,
-sal_uInt16& nDuplicates,
-sal_uInt16 nCurrentPos
+size_t& rPos,
+size_t& nDuplicates,
+size_t nCurrentPos
 ) const
 {
 const vcl::I18nHelper& rI18nHelper = 
Application::GetSettings().GetUILocaleI18nHelper();
diff --git a/vcl/source/window/menuitemlist.hxx 
b/vcl/source/window/menuitemlist.hxx
index 89befc1..b06a614 100644
--- a/vcl/source/window/menuitemlist.hxx
+++ b/vcl/source/window/menuitemlist.hxx
@@ -131,9 +131,9 @@ public:
 MenuItemData*   SearchItem(
 sal_Unicode cSelectChar,
 vcl::KeyCode aKeyCode,
-sal_uInt16& rPos,
-sal_uInt16& nDuplicates,
-sal_uInt16 nCurrentPos
+size_t& rPos,
+size_t& nDuplicates,
+size_t nCurrentPos
 ) const;
 size_t  GetItemCount( sal_Unicode cSelectChar ) const;
 size_t  GetItemCount( vcl::KeyCode aKeyCode ) const;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sd/source

[Matúš Kukan]

 sd/source/filter/eppt/pptx-epptooxml.cxx |6 ++
 1 file changed, 6 insertions(+)

New commits:
commit 9cbe69f1950115e47af693bd78fc78f96f9b508e
Author: Matúš Kukan 
Date:   Sat Feb 11 16:24:37 2017 +0100

tdf#104222: Put expensive debug code behind #if again

dump_pset calls very expensive SdGenericDrawPage::getPropertyValue
doing something with GDIMetaFiles.

(regression from 5c7ce42dfc35d9cceef5f05a96e813b4e3913d38)

Change-Id: If39e9a451c87754343d77c8a1f840153c6b9de80

diff --git a/sd/source/filter/eppt/pptx-epptooxml.cxx 
b/sd/source/filter/eppt/pptx-epptooxml.cxx
index a20ead1..76e00b4 100644
--- a/sd/source/filter/eppt/pptx-epptooxml.cxx
+++ b/sd/source/filter/eppt/pptx-epptooxml.cxx
@@ -94,7 +94,9 @@ using ::com::sun::star::container::XIndexAccess;
 using ::sax_fastparser::FSHelperPtr;
 
 
+#if OSL_DEBUG_LEVEL > 1
 void dump_pset(Reference< XPropertySet > const & rXPropSet);
+#endif
 
 namespace oox {
 using namespace drawingml;
@@ -1785,7 +1787,9 @@ void PowerPointExport::ImplWritePPTXLayout( sal_Int32 
nOffset, sal_uInt32 nMaste
 
 Reference< beans::XPropertySet > xPropSet( xSlide, uno::UNO_QUERY );
 xPropSet->setPropertyValue( "Layout", makeAny( short( aLayoutInfo[ nOffset 
].nType ) ) );
+#if OSL_DEBUG_LEVEL > 1
 dump_pset(xPropSet);
+#endif
 mXPagePropSet.set( xSlide, UNO_QUERY );
 mXShapes.set( xSlide, UNO_QUERY );
 
@@ -2328,6 +2332,7 @@ SAL_DLLPUBLIC_EXPORT void* SAL_CALL 
sdfilt_component_getFactory( const sal_Char*
 
 }
 
+#if OSL_DEBUG_LEVEL > 1
 void dump_pset(Reference< XPropertySet > const & rXPropSet)
 {
 Reference< XPropertySetInfo > info = rXPropSet->getPropertySetInfo ();
@@ -2355,5 +2360,6 @@ void dump_pset(Reference< XPropertySet > const & 
rXPropSet)
 SAL_INFO("sd.eppt", "???  ");
 }
 }
+#endif
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: vcl/commonfuzzer.mk

[Caolán McNamara]

 vcl/commonfuzzer.mk |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 18eaf0c50a12fba45d26829cacc0cc69d9498a9e
Author: Caolán McNamara 
Date:   Sat Feb 25 14:53:52 2017 +

fuzzers need liblangtag now

Change-Id: Ia18ec10e0581078a22a2eead92e835dda232ef0d

diff --git a/vcl/commonfuzzer.mk b/vcl/commonfuzzer.mk
index 32a1bae..481ea23 100644
--- a/vcl/commonfuzzer.mk
+++ b/vcl/commonfuzzer.mk
@@ -21,6 +21,7 @@ fuzzer_externals = \
 icudata \
 lcms2 \
 librdf \
+liblangtag \
 libxslt \
 libxml2 \
 jpeg \
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: 3 commits - sw/inc sw/source vcl/source xmlhelp/source

[Caolán McNamara]

 sw/inc/accmap.hxx   |7 ++-
 sw/source/core/access/accdoc.cxx|2 +-
 sw/source/core/access/accmap.cxx|4 +++-
 sw/source/core/unocore/unotext.cxx  |2 +-
 sw/source/uibase/app/swdll.cxx  |7 ---
 sw/source/uibase/app/swdllimpl.hxx  |3 +++
 vcl/source/gdi/svgdata.cxx  |6 ++
 vcl/source/window/builder.cxx   |5 -
 xmlhelp/source/cxxhelp/provider/inputstream.cxx |5 ++---
 9 files changed, 22 insertions(+), 19 deletions(-)

New commits:
commit 9bc5d4cdf010091406091875e6c45d975ebc9708
Author: Caolán McNamara 
Date:   Sat Feb 25 14:49:14 2017 +

re org things a little to quieten coverity warnings

Change-Id: I3bf0840f6428ee8cefd424a486cc2f5fcfda290f

diff --git a/sw/inc/accmap.hxx b/sw/inc/accmap.hxx
index 05240c9..814b210 100644
--- a/sw/inc/accmap.hxx
+++ b/sw/inc/accmap.hxx
@@ -119,7 +119,10 @@ class SwAccessibleMap : public 
::accessibility::IAccessibleViewForwarder,
 
 //mpSelectedFrameMap contains the old selected objects.
 SwAccessibleContextMap_Impl *mpSeletedFrameMap;
-//IvalidateShapeInParaSelection() method is responsible for the updating 
the selected states of the objects.
+
+OUString maDocName;
+
+//InvalidateShapeInParaSelection() method is responsible for the updating 
the selected states of the objects.
 void InvalidateShapeInParaSelection();
 
 void InvalidateRelationSet_( const SwFrame* pFrame, bool bFrom );
@@ -261,6 +264,8 @@ public:
 
 void FireEvents();
 
+const OUString& GetDocName() const { return maDocName; }
+
 // IAccessibleViewForwarder
 
 virtual Rectangle GetVisibleArea() const override;
diff --git a/sw/source/core/access/accdoc.cxx b/sw/source/core/access/accdoc.cxx
index 9e5f0e0..94131d5 100644
--- a/sw/source/core/access/accdoc.cxx
+++ b/sw/source/core/access/accdoc.cxx
@@ -338,7 +338,7 @@ SwAccessibleDocument::SwAccessibleDocument ( 
SwAccessibleMap* pInitMap ) :
 SwAccessibleDocumentBase( pInitMap ),
 maSelectionHelper( *this )
 {
-SetName( GetResource( STR_ACCESS_DOC_NAME ) );
+SetName(pInitMap->GetDocName());
 vcl::Window *pWin = pInitMap->GetShell()->GetWin();
 if( pWin )
 {
diff --git a/sw/source/core/access/accmap.cxx b/sw/source/core/access/accmap.cxx
index 3c48470..d47e20d 100644
--- a/sw/source/core/access/accmap.cxx
+++ b/sw/source/core/access/accmap.cxx
@@ -30,6 +30,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -1641,7 +1642,8 @@ SwAccessibleMap::SwAccessibleMap( SwViewShell *pSh ) :
 mpVSh( pSh ),
 mpPreview( nullptr ),
 mbShapeSelected( false ),
-mpSeletedFrameMap(nullptr)
+mpSeletedFrameMap(nullptr),
+maDocName(SwAccessibleContext::GetResource(STR_ACCESS_DOC_NAME))
 {
 pSh->GetLayout()->AddAccessibleShell();
 }
diff --git a/sw/source/uibase/app/swdll.cxx b/sw/source/uibase/app/swdll.cxx
index 609b4ad..549df9b 100644
--- a/sw/source/uibase/app/swdll.cxx
+++ b/sw/source/uibase/app/swdll.cxx
@@ -80,6 +80,7 @@ namespace SwGlobals
 }
 
 SwDLL::SwDLL()
+: m_pAutoCorrCfg(nullptr)
 {
 if ( SfxApplication::GetModule(SfxToolsModule::Writer) )// Module 
already active
 return;
@@ -146,16 +147,16 @@ SwDLL::SwDLL()
 SvxAutoCorrCfg& rACfg = SvxAutoCorrCfg::Get();
 const SvxAutoCorrect* pOld = rACfg.GetAutoCorrect();
 rACfg.SetAutoCorrect(new SwAutoCorrect( *pOld ));
+m_pAutoCorrCfg = 
 }
 }
 
 SwDLL::~SwDLL()
 {
-if (!utl::ConfigManager::IsAvoidConfig())
+if (m_pAutoCorrCfg)
 {
 // fdo#86494 SwAutoCorrect must be deleted before FinitCore
-SvxAutoCorrCfg& rACfg = SvxAutoCorrCfg::Get();
-rACfg.SetAutoCorrect(nullptr); // delete SwAutoCorrect before exit 
handlers
+m_pAutoCorrCfg->SetAutoCorrect(nullptr); // delete SwAutoCorrect 
before exit handlers
 }
 
 // Pool has to be deleted before statics are
diff --git a/sw/source/uibase/app/swdllimpl.hxx 
b/sw/source/uibase/app/swdllimpl.hxx
index 57a34be..8f6707f 100644
--- a/sw/source/uibase/app/swdllimpl.hxx
+++ b/sw/source/uibase/app/swdllimpl.hxx
@@ -16,6 +16,8 @@
 
 namespace sw { class Filters; }
 
+class SvxAutoCorrCfg;
+
 class SwDLL
 {
 public:
@@ -33,6 +35,7 @@ private:
 SwDLL& operator=(SwDLL const&) = delete;
 
 std::unique_ptr< sw::Filters > filters_;
+SvxAutoCorrCfg *m_pAutoCorrCfg;
 };
 
 #endif
diff --git a/vcl/source/gdi/svgdata.cxx b/vcl/source/gdi/svgdata.cxx
index 155844f..27abb60d 100644
--- a/vcl/source/gdi/svgdata.cxx
+++ b/vcl/source/gdi/svgdata.cxx
@@ -44,10 +44,9 @@ BitmapEx convertPrimitive2DSequenceToBitmapEx(
 {
 // create replacement graphic from maSequence
 // create XPrimitive2DRenderer
-uno::Reference< uno::XComponentContext > 
xContext(::comphelper::getProcessComponentContext());
-
 try
 {

[Libreoffice-commits] core.git: lingucomponent/source

[Stephan Bergmann]

 lingucomponent/source/hyphenator/hyphen/hyphenimp.cxx |   27 +-
 1 file changed, 20 insertions(+), 7 deletions(-)

New commits:
commit 4520435ad59802b6a567b3bb6c77927663be0f81
Author: Stephan Bergmann 
Date:   Sat Feb 25 16:50:23 2017 +0100

Clean up use of integer types

Change-Id: I06364be5bbbe7862d20ea24ee155cf468f63f0b0

diff --git a/lingucomponent/source/hyphenator/hyphen/hyphenimp.cxx 
b/lingucomponent/source/hyphenator/hyphen/hyphenimp.cxx
index 4b13583..5bf39b1 100644
--- a/lingucomponent/source/hyphenator/hyphen/hyphenimp.cxx
+++ b/lingucomponent/source/hyphenator/hyphen/hyphenimp.cxx
@@ -50,6 +50,7 @@
 #include 
 #include 
 
+#include 
 #include 
 #include 
 #include 
@@ -617,7 +618,7 @@ Reference< XPossibleHyphens > SAL_CALL 
Hyphenator::createPossibleHyphens( const
 // now convert word to needed encoding
 OString encWord(OU2ENC(nTerm,eEnc));
 
-int wordlen = encWord.getLength();
+sal_Int32 wordlen = encWord.getLength();
 std::unique_ptr lcword(new char[wordlen+1]);
 std::unique_ptr hyphens(new char[wordlen+5]);
 char ** rep = nullptr; // replacements of discretionary hyphenation
@@ -628,7 +629,7 @@ Reference< XPossibleHyphens > SAL_CALL 
Hyphenator::createPossibleHyphens( const
 strcpy(lcword.get(),encWord.getStr());
 
 // first remove any trailing periods
-int n = wordlen-1;
+sal_Int32 n = wordlen-1;
 while((n >=0) && (lcword[n] == '.'))
 n--;
 n++;
@@ -655,14 +656,13 @@ Reference< XPossibleHyphens > SAL_CALL 
Hyphenator::createPossibleHyphens( const
 }
 }
 // now backfill hyphens[] for any removed periods
-for (int c = n; c < wordlen; c++)
+for (sal_Int32 c = n; c < wordlen; c++)
 hyphens[c] = '0';
 hyphens[wordlen] = '\0';
 
-sal_Int16 nHyphCount = 0;
-sal_Int16 i;
+sal_Int32 nHyphCount = 0;
 
-for ( i = 0; i < encWord.getLength(); i++)
+for ( sal_Int32 i = 0; i < encWord.getLength(); i++)
 {
 if (hyphens[i]&1)
 nHyphCount++;
@@ -673,12 +673,25 @@ Reference< XPossibleHyphens > SAL_CALL 
Hyphenator::createPossibleHyphens( const
 OUStringBuffer hyphenatedWordBuffer;
 nHyphCount = 0;
 
-for (i = 0; i < nWord.getLength(); i++)
+for (sal_Int32 i = 0; i < nWord.getLength(); i++)
 {
 hyphenatedWordBuffer.append(aWord[i]);
 // hyphenation position
 if (hyphens[i]&1)
 {
+// linguistic::PossibleHyphens is stuck with
+// css::uno::Sequence because of
+// css.linguistic2.XPossibleHpyhens.getHyphenationPositions, so
+// any further positions need to be ignored:
+assert(i >= SAL_MIN_INT16);
+if (i > SAL_MAX_INT16)
+{
+SAL_WARN(
+"lingucomponent",
+"hyphen pos " << i << " > SAL_MAX_INT16 in \"" << aWord
+<< "\"");
+continue;
+}
 pPos[nHyphCount] = i;
 hyphenatedWordBuffer.append('=');
 nHyphCount++;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Crash test update

[Crashtest VM]

New crashtest update available at 
http://dev-builds.libreoffice.org/crashtest/40e55cf24dd30acd6d928cd764bc597dd11f5fad/


exportCrashes.csv
Description: Binary data


importCrash.csv
Description: Binary data


validationErrors.csv
Description: Binary data
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: hwpfilter/qa hwpfilter/source

[Caolán McNamara]

 hwpfilter/qa/cppunit/data/fail/cslist-1.hwp |binary
 hwpfilter/source/hwpfile.cxx|   83 +++-
 hwpfilter/source/hwpfile.h  |   15 ++---
 3 files changed, 30 insertions(+), 68 deletions(-)

New commits:
commit 283e843be91ef4d727c0815d1b8a0420fd16a7fd
Author: Caolán McNamara 
Date:   Fri Feb 24 21:28:10 2017 +

ofz: epic slow use of std::list

Change-Id: I790a3098272101fd33f83f21bdcef1bb061efd76
Reviewed-on: https://gerrit.libreoffice.org/34635
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/hwpfilter/qa/cppunit/data/fail/cslist-1.hwp 
b/hwpfilter/qa/cppunit/data/fail/cslist-1.hwp
new file mode 100644
index 000..d491f7b
Binary files /dev/null and b/hwpfilter/qa/cppunit/data/fail/cslist-1.hwp differ
diff --git a/hwpfilter/source/hwpfile.cxx b/hwpfilter/source/hwpfile.cxx
index 3abfcac..060312a 100644
--- a/hwpfilter/source/hwpfile.cxx
+++ b/hwpfilter/source/hwpfile.cxx
@@ -70,7 +70,7 @@ HWPFile::~HWPFile()
 for (; it != plist.end(); ++it)
 delete *it;
 
-std::list < Table* >::iterator tbl = tables.begin();
+std::vector< Table* >::iterator tbl = tables.begin();
 for (; tbl != tables.end(); ++tbl)
 delete *tbl;
 
@@ -457,92 +457,53 @@ void HWPFile::AddBox(FBox * box)
 blist.push_back(box);
 }
 
-
 ParaShape *HWPFile::getParaShape(int index)
 {
-std::list::iterator it = pslist.begin();
-
-for( int i = 0; it != pslist.end(); ++it, i++ ){
-if( i == index )
-  break;
-}
-
-return it != pslist.end() ? *it : nullptr;
+if (index < 0 || static_cast(index) >= pslist.size())
+return nullptr;
+return pslist[index];
 }
 
-
 CharShape *HWPFile::getCharShape(int index)
 {
-std::list::iterator it = cslist.begin();
-
-for( int i = 0; it != cslist.end(); ++it, i++ ){
-if( i == index )
-  break;
-}
-
-return it != cslist.end() ? *it : nullptr;
+if (index < 0 || static_cast(index) >= cslist.size())
+return nullptr;
+return cslist[index];
 }
 
-
 FBoxStyle *HWPFile::getFBoxStyle(int index)
 {
-std::list::iterator it = fbslist.begin();
-
-for( int i = 0; it != fbslist.end(); ++it, i++ ){
-if( i == index )
-  break;
-}
-
-return it != fbslist.end() ? *it : nullptr;
+if (index < 0 || static_cast(index) >= fbslist.size())
+return nullptr;
+return fbslist[index];
 }
 
 DateCode *HWPFile::getDateCode(int index)
 {
-std::list::iterator it = datecodes.begin();
-
-for( int i = 0; it != datecodes.end(); ++it, i++ ){
-if( i == index )
-  break;
-}
-
-return it != datecodes.end() ? *it : nullptr;
+if (index < 0 || static_cast(index) >= datecodes.size())
+return nullptr;
+return datecodes[index];
 }
 
 HeaderFooter *HWPFile::getHeaderFooter(int index)
 {
-std::list::iterator it = headerfooters.begin();
-
-for( int i = 0; it != headerfooters.end(); ++it, i++ ){
-if( i == index )
-  break;
-}
-
-return it != headerfooters.end() ? *it : nullptr;
+if (index < 0 || static_cast(index) >= headerfooters.size())
+return nullptr;
+return headerfooters[index];
 }
 
 ShowPageNum *HWPFile::getPageNumber(int index)
 {
-std::list::iterator it = pagenumbers.begin();
-
-for( int i = 0; it != pagenumbers.end(); ++it, i++ ){
-if( i == index )
-  break;
-}
-
-return it != pagenumbers.end() ? *it : nullptr;
-
+if (index < 0 || static_cast(index) >= pagenumbers.size())
+return nullptr;
+return pagenumbers[index];
 }
 
 Table *HWPFile::getTable(int index)
 {
-std::list::iterator it = tables.begin();
-
-for( int i = 0; it != tables.end(); ++it, i++ ){
-if( i == index )
-  break;
-}
-
-return it != tables.end() ? *it : nullptr;
+if (index < 0 || static_cast(index) >= tables.size())
+return nullptr;
+return tables[index];
 }
 
 void HWPFile::AddParaShape(ParaShape * pshape)
diff --git a/hwpfilter/source/hwpfile.h b/hwpfilter/source/hwpfile.h
index 793354e4..1d8da36 100644
--- a/hwpfilter/source/hwpfile.h
+++ b/hwpfilter/source/hwpfile.h
@@ -26,6 +26,7 @@
 #define INCLUDED_HWPFILTER_SOURCE_HWPFILE_H
 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -282,13 +283,13 @@ class DLLEXPORT HWPFile
 std::list emblist;
 std::list hyperlist;
 int currenthyper;
-std::list pslist; /* 스타오피스의 
구조상 필요 */
-std::list cslist;
-std::list fbslist;
-std::list datecodes;
-std::list headerfooters;
-std::list pagenumbers;
-  

[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - download.lst

[Eike Rathke]

 download.lst |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit abd00b9229e01e67cbe071e87089fc6e29ddbbb6
Author: Eike Rathke 
Date:   Fri Feb 24 20:58:36 2017 +0100

update to language-subtag-registry-2017-01-20

(cherry picked from commit 49e6d5e49673011149c94788a86cf899a54a8085)

Change-Id: Ia62815e19b3414b6ba78c70ccb2520a0836b22c4
Reviewed-on: https://gerrit.libreoffice.org/34632
Reviewed-by: Michael Stahl 
Tested-by: Jenkins 

diff --git a/download.lst b/download.lst
index 47d313f..f91a338 100644
--- a/download.lst
+++ b/download.lst
@@ -78,8 +78,8 @@ export JPEG_MD5SUM := 3353992aecaee1805ef4109aadd433e7
 export JPEG_TARBALL := jpegsrc.v9a.tar.gz
 export JPEG_TURBO_MD5SUM := 86b0d5f7507c2e6c21c00219162c3c44
 export JPEG_TURBO_TARBALL := libjpeg-turbo-1.4.2.tar.gz
-export LANGTAGREG_MD5SUM := 8a037dc60b16bf8c5fe871b33390a4a2
-export LANGTAGREG_TARBALL := language-subtag-registry-2016-07-19.tar.bz2
+export LANGTAGREG_MD5SUM := 36b8266c1ec4a5049c3e0637a671fbd9
+export LANGTAGREG_TARBALL := language-subtag-registry-2017-01-20.tar.bz2
 export LANGUAGETOOL_TARBALL := 
b63e6340a02ff1cacfeadb2c42286161-JLanguageTool-1.7.0.tar.bz2
 export LCMS2_MD5SUM := f4c08d38ceade4a664ebff7228910a33
 export LCMS2_TARBALL := lcms2-2.6.tar.gz
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/qa

[Zdeněk Crhonek]

 sc/qa/unit/data/functions/statistical/fods/tinv.fods | 5317 +++
 1 file changed, 5317 insertions(+)

New commits:
commit 71665247aa1855b7f9a78858febfd2d43eeebe94
Author: Zdeněk Crhonek 
Date:   Sat Feb 25 19:27:47 2017 +0100

add TINV test case

Change-Id: Ic9b8398d935e32e529252f55fb09fac5e800e578
Reviewed-on: https://gerrit.libreoffice.org/34647
Tested-by: Jenkins 
Reviewed-by: Zdenek Crhonek 

diff --git a/sc/qa/unit/data/functions/statistical/fods/tinv.fods 
b/sc/qa/unit/data/functions/statistical/fods/tinv.fods
new file mode 100644
index 000..31c9cbe
--- /dev/null
+++ b/sc/qa/unit/data/functions/statistical/fods/tinv.fods
@@ -0,0 +1,5317 @@
+
+
+http://www.w3.org/1999/xlink; 
xmlns:dc="http://purl.org/dc/elements/1.1/; 
xmlns:meta="urn:oasis:names:tc:opendocument:xmlns:meta:1.0" 
xmlns:number="urn:oasis:names:tc:opendocument:xmlns:datastyle:1.0" 
xmlns:presentation="urn:oasis:names:tc:opendocument:xmlns:presentation:1.0" 
xmlns:svg="urn:oasis:names:tc:opendocument:xmlns:svg-compatible:1.0" 
xmlns:chart="urn:oasis:names:tc:opendocument:xmlns:chart:1.0" 
xmlns:dr3d="urn:oasis:names:tc:opendocument:xmlns:dr3d:1.0" 
xmlns:math="http://www.w3.org/1998/Math/MathML; 
xmlns:form="urn:oasis:names:tc:opendocument:xmlns:form:1.0" xmlns:scr
 ipt="urn:oasis:names:tc:opendocument:xmlns:script:1.0" 
xmlns:config="urn:oasis:names:tc:opendocument:xmlns:config:1.0" 
xmlns:ooo="http://openoffice.org/2004/office; 
xmlns:ooow="http://openoffice.org/2004/writer; 
xmlns:oooc="http://openoffice.org/2004/calc; 
xmlns:dom="http://www.w3.org/2001/xml-events; 
xmlns:xforms="http://www.w3.org/2002/xforms; 
xmlns:xsd="http://www.w3.org/2001/XMLSchema; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xmlns:rpt="http://openoffice.org/2005/report; 
xmlns:of="urn:oasis:names:tc:opendocument:xmlns:of:1.2" 
xmlns:xhtml="http://www.w3.org/1999/xhtml; 
xmlns:grddl="http://www.w3.org/2003/g/data-view#; 
xmlns:tableooo="http://openoffice.org/2009/table; 
xmlns:drawooo="http://openoffice.org/2010/draw; 
xmlns:calcext="urn:org:documentfoundation:names:experimental:calc:xmlns:calcext:1.0"
 
xmlns:loext="urn:org:documentfoundation:names:experimental:office:xmlns:loext:1.0"
 xmlns:field="urn:openoffice:names:experimental:ooo-ms-interop:xmlns:field:1.0" 
xmlns:form
 x="urn:openoffice:names:experimental:ooxml-odf-interop:xmlns:form:1.0" 
xmlns:css3t="http://www.w3.org/TR/css3-text/; office:version="1.2" 
office:mimetype="application/vnd.oasis.opendocument.spreadsheet">
+ 
2016-12-29T18:23:56.52200P0D1LibreOfficeDev/5.4.0.0.alpha0$Linux_X86_64
 
LibreOffice_project/36de6c50684c8241969a2064d30aff41e0bc5d97
+ 
+  
+   0
+   0
+   49420
+   21043
+   
+
+ view1
+ 
+  
+   2
+   8
+   0
+   0
+   0
+   0
+   2
+   0
+   0
+   0
+   0
+   0
+   100
+   60
+   true
+   false
+  
+  
+   2
+   37
+   0
+   0
+   0
+   0
+   2
+   0
+   0
+   0
+   24
+   0
+   100
+   60
+   true
+   false
+  
+ 
+ Sheet2
+ 1241
+ 0
+ 100
+ 60
+ false
+ true
+ true
+ true
+ 12632256
+ true
+ true
+ true
+ true
+ true
+ false
+ false
+ 1270
+ 1270
+ 1
+ 1
+ true
+ false
+
+   
+  
+  
+   7
+   false
+   false
+   true
+   true
+   false
+   false
+   false
+   1270
+   1270
+   true
+   true
+   true
+   true
+   true
+   false
+   12632256
+   false
+   Lexmark-E352dn
+   
+
+ cs
+ CZ
+ 
+ 
+ 
+
+
+ de
+ DE
+ 
+ 
+ 
+
+
+ en
+ US
+ 
+ 
+ 
+
+
+ nl
+ NL
+ 
+ 
+ 
+
+   
+   true
+   true
+   3
+   1
+   true
+   1
+   true
+   lgH+/0xleG1hcmstRTM1MmRuQ1VQUzpMZXhtYXJrLUUzNTJkbgAWAAMAtwAIAFZUAAAkbQAASm9iRGF0YSAxCnByaW50ZXI9TGV4bWFyay1FMzUyZG4Kb3JpZW50YXRpb249UG9ydHJhaXQKY29waWVzPTEKY29sbGF0ZT1mYWxzZQptYXJnaW5kYWp1c3RtZW50PTAsMCwwLDAKY29sb3JkZXB0aD0yNApwc2xldmVsPTAKcGRmZGV2aWNlPTEKY29sb3JkZXZpY2U9MApQUERDb250ZXhEYXRhClBhZ2VTaXplOkxldHRlcgAAEgBDT01QQVRfRFVQTEVYX01PREUPAER1cGxleE1vZGU6Ok9mZg==
+   false
+   0
+  
+ 
+ 
+  
+   http://openoffice.org/2004/office; 
xmlns:xlink="http://www.w3.org/1999/xlink;>
+
+   
+  
+ 
+ 
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+ 
+ 
+  
+   
+   
+  
+  
+   
+  
+  
+   
+  
+  
+   
+
+   Kč
+  
+  
+   
+   -
+   
+
+   Kč
+   
+  
+  
+
+   
+
+  
+  
+
+   (
+   
+   )
+  
+  
+
+   -
+   
+
+  
+  
+   
+
+   
+   
+   
+  
+  
+   
+  
+  
+   
+  
+  
+   
+
+   Kč
+  
+  
+   -
+   
+
+   Kč
+   
+  
+  
+ 

[Libreoffice-commits] core.git: ucb/source

[Caolán McNamara]

 ucb/source/ucp/webdav-neon/NeonSession.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit a493900e955b126d3393f376fef2ce6afbc1cdb6
Author: Caolán McNamara 
Date:   Sat Feb 25 19:32:24 2017 +

value returned from particular web server is not valid ascii

$1 = 0x1a24b90 "GET,HEAD,H\205\360),HEAD,POST,OPTIONS"

from this url to a missing resource


http://www.japan-net.ne.jp/%7Enagayama/image/14photo/omoide/0301fuji/01rot-s.jpg

seen during soffice --headless --convert odt ooo26424-5.sxw

Change-Id: If6429dc02ff42bae9372ae39cadf8b49f278f54d

diff --git a/ucb/source/ucp/webdav-neon/NeonSession.cxx 
b/ucb/source/ucp/webdav-neon/NeonSession.cxx
index 4486306..7ba44b1 100644
--- a/ucb/source/ucp/webdav-neon/NeonSession.cxx
+++ b/ucb/source/ucp/webdav-neon/NeonSession.cxx
@@ -872,8 +872,8 @@ void NeonSession::OPTIONS( const OUString & inPath,
 while ( ( cursor = ne_response_header_iterate(
   req, cursor, ,  ) ) != nullptr )
 {
-OUString aHeaderName( OUString::createFromAscii( name 
).toAsciiLowerCase() );
-OUString aHeaderValue( OUString::createFromAscii( value ) );
+OUString aHeaderName(OUString(name, strlen(name), 
RTL_TEXTENCODING_ASCII_US).toAsciiLowerCase());
+OUString aHeaderValue(value, strlen(value), 
RTL_TEXTENCODING_ASCII_US);
 
 // display the single header
 SAL_INFO( "ucb.ucp.webdav", "OPTIONS - received header: " << 
aHeaderName << ":" << aHeaderValue );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-5-2-6' - sc/source

[Markus Mohrhard]

 sc/source/ui/app/inputhdl.cxx |   11 ---
 1 file changed, 8 insertions(+), 3 deletions(-)

New commits:
commit 588db4054bd820b98fefe22acac39add42480489
Author: Markus Mohrhard 
Date:   Wed Feb 22 20:34:00 2017 +0100

fix crash in input handler code

Reported by the crashreporter:

http://crashreport.libreoffice.org/stats/signature/ScInputHandler::DataChanged(bool,bool)

Change-Id: I3038f8b66e1009f4e418b2d7fd488533162ef9d5
Reviewed-on: https://gerrit.libreoffice.org/34553
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 
(cherry picked from commit 4c4bff70665a6327614fed38028935899f6b5e70)
Reviewed-on: https://gerrit.libreoffice.org/34623
Reviewed-by: Eike Rathke 

diff --git a/sc/source/ui/app/inputhdl.cxx b/sc/source/ui/app/inputhdl.cxx
index f268dbf..a372b87 100644
--- a/sc/source/ui/app/inputhdl.cxx
+++ b/sc/source/ui/app/inputhdl.cxx
@@ -2298,10 +2298,15 @@ void ScInputHandler::DataChanged( bool bFromTopNotify, 
bool bSetModified )
 if ( pInputWin )
 pInputWin->SetTextString( aText );
 
-ScDocShell* pDocSh = pActiveViewSh->GetViewData().GetDocShell();
-ScDocument& rDoc = pDocSh->GetDocument();
 if ( comphelper::LibreOfficeKit::isActive() )
-
rDoc.GetDrawLayer()->libreOfficeKitCallback(LOK_CALLBACK_CELL_FORMULA, 
aText.toUtf8().getStr());
+{
+if (pActiveViewSh)
+{
+ScDocShell* pDocSh = 
pActiveViewSh->GetViewData().GetDocShell();
+ScDocument& rDoc = pDocSh->GetDocument();
+
rDoc.GetDrawLayer()->libreOfficeKitCallback(LOK_CALLBACK_CELL_FORMULA, 
aText.toUtf8().getStr());
+}
+}
 }
 
 // If the cursor is before the end of a paragraph, parts are being pushed 
to
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: vcl/qa

[Markus Mohrhard]

 vcl/qa/cppunit/pdfexport/pdfexport.cxx |8 
 1 file changed, 8 insertions(+)

New commits:
commit 89b64e865bfb6739be07d1fb0b5dfa5fa3651a44
Author: Markus Mohrhard 
Date:   Sat Feb 25 17:06:31 2017 +0100

the test implicitly requires pdfium

Attempt to fix build issue found by "RandomCondig" tb build #244

Change-Id: I8b6a0a3d0f812a3220fb0d7d21318871454f7eca
Reviewed-on: https://gerrit.libreoffice.org/34646
Tested-by: Jenkins 
Reviewed-by: Markus Mohrhard 

diff --git a/vcl/qa/cppunit/pdfexport/pdfexport.cxx 
b/vcl/qa/cppunit/pdfexport/pdfexport.cxx
index bcc3345..949ef61 100644
--- a/vcl/qa/cppunit/pdfexport/pdfexport.cxx
+++ b/vcl/qa/cppunit/pdfexport/pdfexport.cxx
@@ -7,6 +7,8 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/.
  */
 
+#include 
+
 #include 
 #include 
 
@@ -34,11 +36,15 @@ class PdfExportTest : public test::BootstrapFixture, public 
unotest::MacrosTest
 public:
 virtual void setUp() override;
 virtual void tearDown() override;
+#if HAVE_FEATURE_PDFIUM
 /// Tests that a pdf image is roundtripped back to PDF as a vector format.
 void testTdf106059();
+#endif
 
 CPPUNIT_TEST_SUITE(PdfExportTest);
+#if HAVE_FEATURE_PDFIUM
 CPPUNIT_TEST(testTdf106059);
+#endif
 CPPUNIT_TEST_SUITE_END();
 };
 
@@ -58,6 +64,7 @@ void PdfExportTest::tearDown()
 test::BootstrapFixture::tearDown();
 }
 
+#if HAVE_FEATURE_PDFIUM
 void PdfExportTest::testTdf106059()
 {
 // Import the bugdoc and export as PDF.
@@ -93,6 +100,7 @@ void PdfExportTest::testTdf106059()
 // This dictionary key was missing, so the XObject wasn't a reference one.
 CPPUNIT_ASSERT(pReferenceXObject->Lookup("Ref"));
 }
+#endif
 
 CPPUNIT_TEST_SUITE_REGISTRATION(PdfExportTest);
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: Chart test failures on mac: text size differences

[Khaled Hosny]

On Sat, Feb 25, 2017 at 12:04:10PM +, Tamas Zolnai wrote:
> Hi Khaled,
> 
> On Friday, February 24, 2017 19:40 GMT, Khaled Hosny  
> wrote:
> 
> > On Fri, Feb 24, 2017 at 05:41:25PM +, Tamas Zolnai wrote:
> > > Hi Khaled,
> > >
> > > I see you're working on text rendering, so I thought that my findings
> > > might be usefull for you. I had a look at chart test failures on Mac
> > > and found that it is because of text size differences. (I checked your
> > > latest change [1], but the differences are still there.)
> > > Both text width and height is different (comparing Windows and Mac).
> > > Interestingly when I changed the font to a bundled, monospace font
> 
> > > (e.g. Liberation Mono, DejaVu Sans Mono), width differences
> > > disappeared and only height differences remained. So there are at
> > > least two kind of issues here. One which is about the proportional
> 
> > > fonts character width and one related to the text height.
> > > I added a minimal test case to the source [2] with which it's easier
> > > to debug the second issue (for the first issue the test case's font
> > > need to be changed to a bundled, proportional font).
> >
> > We need to first who Chart is calculating the text width and depth,
> > namely which function(s) it uses from vcl, to be able to debug it and
> > see where are these differences coming from.
> 
> I debugged it earlier. It was a bit hard to follow the trace from
> chart code to text rendering, but as I see the height differences
> coming somwhere from these methods (I debugged only the height
> difference):
> ImpEditEngine::CalcTextHeight()
> SvxFont::GetPhysTxtSize()
> OutputDevice::GetTextHeight()

I tried to debug this, attached the diff I used to print some debug info
(and disable other chart2dump tests) as well as (cleaned) log files from
running “make CppunitTest_chart2_dump” on both Linux and Mac. There are
two main issues from the logs; we use different UI fonts and even when
using the same fonts they are at different sizes. This commit [1]
introduced an env var that should help with using different fonts, but I
didn’t try using it here. But I have no idea why the fonts are requested
at different sizes, finding the root of this difference might help.

> However I think it would be better to debug this problem with a unit
> test in vcl module which tests directly the text rendering. I would
> suggest that if you are working making text rendering consitent. The
> vcldemo does something similar, but it's just doing the rendering and
> does not compare the text size to expected values. That code can be
> reused to write some unit tests about text rendering.

If someone knows how to write text layout unit tests for VCL (i.e. by
showing some example) I might try adding some, otherwise I don’t think
OutputDevice provides much of useful API for doing layout tests that
would be helpful at VCL level.

> Actually I'm a bit suprised that there is no a unit test for this (I
> did not find any in vcl module). I heard some expectations from other
> LO developers that text rendering is consistent now on different
> systems but I can't see how it can be expected if there isn't any test
> about it. It's hard to imagine that somebody can test it manually on
> all the three main platforms.

It is supposed to be consistent and only fairly recently (in 3.5 cycle),
of course this have only been verified manually and sporadically because
that is currently the only practical way AFAIK (see above).

Regards,
Khaled

1. 
https://gerrit.libreoffice.org/gitweb?p=core.git;a=commitdiff;h=55916dfc59f05537c4e6fece77aef3cc1dbef34c
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Chart test failures on mac: text size differences

[Khaled Hosny]

I missed the attachments!

On Sat, Feb 25, 2017 at 11:23:51PM +0200, Khaled Hosny wrote:
> On Sat, Feb 25, 2017 at 12:04:10PM +, Tamas Zolnai wrote:
> > Hi Khaled,
> > 
> > On Friday, February 24, 2017 19:40 GMT, Khaled Hosny 
> >  wrote:
> > 
> > > On Fri, Feb 24, 2017 at 05:41:25PM +, Tamas Zolnai wrote:
> > > > Hi Khaled,
> > > >
> > > > I see you're working on text rendering, so I thought that my findings
> > > > might be usefull for you. I had a look at chart test failures on Mac
> > > > and found that it is because of text size differences. (I checked your
> > > > latest change [1], but the differences are still there.)
> > > > Both text width and height is different (comparing Windows and Mac).
> > > > Interestingly when I changed the font to a bundled, monospace font
> > 
> > > > (e.g. Liberation Mono, DejaVu Sans Mono), width differences
> > > > disappeared and only height differences remained. So there are at
> > > > least two kind of issues here. One which is about the proportional
> > 
> > > > fonts character width and one related to the text height.
> > > > I added a minimal test case to the source [2] with which it's easier
> > > > to debug the second issue (for the first issue the test case's font
> > > > need to be changed to a bundled, proportional font).
> > >
> > > We need to first who Chart is calculating the text width and depth,
> > > namely which function(s) it uses from vcl, to be able to debug it and
> > > see where are these differences coming from.
> > 
> > I debugged it earlier. It was a bit hard to follow the trace from
> > chart code to text rendering, but as I see the height differences
> > coming somwhere from these methods (I debugged only the height
> > difference):
> > ImpEditEngine::CalcTextHeight()
> > SvxFont::GetPhysTxtSize()
> > OutputDevice::GetTextHeight()
> 
> I tried to debug this, attached the diff I used to print some debug info
> (and disable other chart2dump tests) as well as (cleaned) log files from
> running “make CppunitTest_chart2_dump” on both Linux and Mac. There are
> two main issues from the logs; we use different UI fonts and even when
> using the same fonts they are at different sizes. This commit [1]
> introduced an env var that should help with using different fonts, but I
> didn’t try using it here. But I have no idea why the fonts are requested
> at different sizes, finding the root of this difference might help.
> 
> > However I think it would be better to debug this problem with a unit
> > test in vcl module which tests directly the text rendering. I would
> > suggest that if you are working making text rendering consitent. The
> > vcldemo does something similar, but it's just doing the rendering and
> > does not compare the text size to expected values. That code can be
> > reused to write some unit tests about text rendering.
> 
> If someone knows how to write text layout unit tests for VCL (i.e. by
> showing some example) I might try adding some, otherwise I don’t think
> OutputDevice provides much of useful API for doing layout tests that
> would be helpful at VCL level.
> 
> > Actually I'm a bit suprised that there is no a unit test for this (I
> > did not find any in vcl module). I heard some expectations from other
> > LO developers that text rendering is consistent now on different
> > systems but I can't see how it can be expected if there isn't any test
> > about it. It's hard to imagine that somebody can test it manually on
> > all the three main platforms.
> 
> It is supposed to be consistent and only fairly recently (in 3.5 cycle),
> of course this have only been verified manually and sporadically because
> that is currently the only practical way AFAIK (see above).
> 
> Regards,
> Khaled
> 
> 1. 
> https://gerrit.libreoffice.org/gitweb?p=core.git;a=commitdiff;h=55916dfc59f05537c4e6fece77aef3cc1dbef34c
diff --git a/chart2/qa/extras/chart2dump/chart2dump.cxx 
b/chart2/qa/extras/chart2dump/chart2dump.cxx
index a883ec4..152cdef 100755
--- a/chart2/qa/extras/chart2dump/chart2dump.cxx
+++ b/chart2/qa/extras/chart2dump/chart2dump.cxx
@@ -286,8 +286,6 @@ DECLARE_DUMP_TEST(ChartDataTest, Chart2DumpTest, false)
 {
 const std::vector aTestFiles =
 {
-"simple_chart.ods",
-"multiple_categories.ods"
 };
 
 for (const OUString& aTestFile : aTestFiles)
@@ -393,16 +391,9 @@ DECLARE_DUMP_TEST(ChartDataTest, Chart2DumpTest, false)
 
 DECLARE_DUMP_TEST(LegendTest, Chart2DumpTest, false)
 {
-const double fLocalEPS = 550.1;
+const double fLocalEPS = 0.0;
 const std::vector aTestFiles =
 {
-"legend_on_right_side.odp",
-"legend_on_bottom.odp",
-"legend_on_left_side.odp",
-"legend_on_top.odp",
-"many_legend_entries.odp",
-"custom_legend_position.odp",
-"multiple_categories.odp",
 "minimal_legend_test.odp"
 };
 
@@ -497,10 +488,6 @@ DECLARE_DUMP_TEST(GridTest, Chart2DumpTest, false)
 {
 const std::vector 

[Libreoffice-commits] core.git: 3 commits - filter/Library_t602filter.mk filter/source Makefile.in Repository.mk sfx2/source vcl/Executable_602fuzzer.mk vcl/Module_vcl.mk vcl/workben writerfilter/sour

[Caolán McNamara]

 Makefile.in   |2 
 Repository.mk |1 
 filter/Library_t602filter.mk  |2 
 filter/source/t602/t602filter.cxx |8 +--
 sfx2/source/control/unoctitm.cxx  |4 -
 sfx2/source/view/viewfrm.cxx  |3 -
 vcl/Executable_602fuzzer.mk   |   48 ++
 vcl/Module_vcl.mk |1 
 vcl/workben/602fuzzer.cxx |   23 
 vcl/workben/fftester.cxx  |7 +-
 writerfilter/source/ooxml/Handler.cxx |4 +
 writerfilter/source/ooxml/Handler.hxx |1 
 writerfilter/source/ooxml/OOXMLFastContextHandler.cxx |1 
 13 files changed, 92 insertions(+), 13 deletions(-)

New commits:
commit 4c0040b6f1e3137e0d40aab09088c43214db3165
Author: Caolán McNamara 
Date:   Sat Feb 25 20:53:37 2017 +

re org things a little to quieten coverity warnings

Change-Id: I97d1e5cce279031cb1d855132cc6695fc4b59c93

diff --git a/writerfilter/source/ooxml/Handler.cxx 
b/writerfilter/source/ooxml/Handler.cxx
index 0600b5b..c0d59ff 100644
--- a/writerfilter/source/ooxml/Handler.cxx
+++ b/writerfilter/source/ooxml/Handler.cxx
@@ -324,6 +324,10 @@ 
OOXMLHyperlinkHandler::OOXMLHyperlinkHandler(OOXMLFastContextHandler * pContext)
 
 OOXMLHyperlinkHandler::~OOXMLHyperlinkHandler()
 {
+}
+
+void OOXMLHyperlinkHandler::writetext()
+{
 OUString sReturn(" HYPERLINK \"");
 
 sReturn += mURL;
diff --git a/writerfilter/source/ooxml/Handler.hxx 
b/writerfilter/source/ooxml/Handler.hxx
index 80254d5..eb6b8b6 100644
--- a/writerfilter/source/ooxml/Handler.hxx
+++ b/writerfilter/source/ooxml/Handler.hxx
@@ -139,6 +139,7 @@ class OOXMLHyperlinkHandler : public Properties
 public:
 explicit OOXMLHyperlinkHandler(OOXMLFastContextHandler * pContext);
 virtual ~OOXMLHyperlinkHandler();
+void writetext();
 
 virtual void attribute(Id name, Value & val) override;
 virtual void sprm(Sprm & sprm) override;
diff --git a/writerfilter/source/ooxml/OOXMLFastContextHandler.cxx 
b/writerfilter/source/ooxml/OOXMLFastContextHandler.cxx
index 1be3fa6..bc31406 100644
--- a/writerfilter/source/ooxml/OOXMLFastContextHandler.cxx
+++ b/writerfilter/source/ooxml/OOXMLFastContextHandler.cxx
@@ -904,6 +904,7 @@ void OOXMLFastContextHandlerStream::handleHyperlink()
 {
 OOXMLHyperlinkHandler aHyperlinkHandler(this);
 getPropertySetAttrs()->resolve(aHyperlinkHandler);
+aHyperlinkHandler.writetext();
 }
 
 /*
commit f1d4c4009644a37f6d7c1981bc79b3bfb47188ac
Author: Caolán McNamara 
Date:   Fri Feb 24 14:50:36 2017 +

add 602 fuzzer

Change-Id: I91242d4647922be1c668c6a6518dedf7048801be

diff --git a/Makefile.in b/Makefile.in
index 049e1c3..7146be0 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -446,7 +446,7 @@ $(foreach ide,\
 eclipsecdt,\
 $(eval $(call gb_Top_GbuildToIdeIntegrationNS,$(ide
 
-fuzzers: Library_sal Library_salhelper Library_reg Library_store 
Library_unoidl codemaker Library_cppu Library_i18nlangtag Library_cppuhelper 
Library_comphelper StaticLibrary_ulingu StaticLibrary_jpeg 
StaticLibrary_findsofficepath Library_tl Rdb_services udkapi offapi 
Library_clew Library_gie Library_reflection Library_invocadapt 
Library_bootstrap Library_introspection Library_stocservices Library_xmlreader 
Library_gcc3_uno instsetoo_native more_fonts StaticLibrary_fuzzer 
Executable_wmffuzzer Executable_jpgfuzzer Executable_giffuzzer 
Executable_xbmfuzzer Executable_xpmfuzzer Executable_pngfuzzer 
Executable_bmpfuzzer Executable_svmfuzzer Executable_pcdfuzzer 
Executable_dxffuzzer Executable_metfuzzer Executable_ppmfuzzer 
Executable_psdfuzzer Executable_epsfuzzer Executable_pctfuzzer 
Executable_pcxfuzzer Executable_rasfuzzer Executable_tgafuzzer 
Executable_tiffuzzer Executable_hwpfuzzer
+fuzzers: Library_sal Library_salhelper Library_reg Library_store 
Library_unoidl codemaker Library_cppu Library_i18nlangtag Library_cppuhelper 
Library_comphelper StaticLibrary_ulingu StaticLibrary_jpeg 
StaticLibrary_findsofficepath Library_tl Rdb_services udkapi offapi 
Library_clew Library_gie Library_reflection Library_invocadapt 
Library_bootstrap Library_introspection Library_stocservices Library_xmlreader 
Library_gcc3_uno instsetoo_native more_fonts StaticLibrary_fuzzer 
Executable_wmffuzzer Executable_jpgfuzzer Executable_giffuzzer 
Executable_xbmfuzzer Executable_xpmfuzzer Executable_pngfuzzer 
Executable_bmpfuzzer Executable_svmfuzzer Executable_pcdfuzzer 
Executable_dxffuzzer Executable_metfuzzer Executable_ppmfuzzer 
Executable_psdfuzzer Executable_epsfuzzer Executable_pctfuzzer 
Executable_pcxfuzzer Executable_rasfuzzer Executable_tgafuzzer 
Executable_tiffuzzer Executable_hwpfuzzer Executable_602fuzzer
 
 endif # MAKE_RESTARTS
 
diff 

Re: Chart test failures on mac: text size differences

[Tamas Zolnai]

Hi Khaled,

> > However I think it would be better to debug this problem with a unit
> > test in vcl module which tests directly the text rendering. I would
> > suggest that if you are working making text rendering consitent. The
> > vcldemo does something similar, but it's just doing the rendering and
> > does not compare the text size to expected values. That code can be
> > reused to write some unit tests about text rendering.
> 
> If someone knows how to write text layout unit tests for VCL (i.e. by
> showing some example) I might try adding some, otherwise I don’t think
> OutputDevice provides much of useful API for doing layout tests that
> would be helpful at VCL level.

Is vcldemo code not good enough as example? (vcl/workben/vcldemo.cxx) Check the 
drawText() or drawComplex() method. As I see this method uses only vcl objects 
(OutputDevice, vcl::Font). OutputDevice::GetTextBoundRect() can be used to get 
the text width and height. Or did I miss something?

Best Regards,
Tamás
 
 
 
 


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Gerrit: Proposals for private changes and wip workflows

[David Ostrovsky]

Gerrit team is working on adding new workflows in Gerrit core:

* private changes workflow
* wip (work in progress) workflow

As the consequence, the draft workflow, that caused some confusion
among Gerrit users, is going to be discontinued. In fact, I removed it
already: [1].

Today, I would like to ask your opinion on those proposals. Please
comment on the proposal changes upstream, or answer on this thread:

* Proposal private changes: [2]
* Proposal wip: [3]

Thanks.

[1] https://gerrit-review.googlesource.com/97230
[2] https://gerrit-review.googlesource.com/94557
[3] https://gerrit-review.googlesource.com/97245
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: Branch 'aoo/trunk' - readlicense_oo/docs

[Matthias Seidel]

 readlicense_oo/docs/readme/readme.xrm |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit f7ce97f232160a0871fb6613517de339597f178f
Author: Matthias Seidel 
Date:   Sat Feb 25 21:39:16 2017 +

Added Windows 10 in ReadMe, fixed typo

diff --git a/readlicense_oo/docs/readme/readme.xrm 
b/readlicense_oo/docs/readme/readme.xrm
index 333a2f9..f85c0ed 100644
--- a/readlicense_oo/docs/readme/readme.xrm
+++ b/readlicense_oo/docs/readme/readme.xrm
@@ -78,7 +78,7 @@



-   Microsoft Windows XP, Vista, Windows 7 or Windows 8
+   Microsoft Windows XP, Vista, Windows 7, Windows 8 or Windows 
10

 

@@ -235,7 +235,7 @@
 

Shortcut Keys
-   Only shortcut keys (key 
combinations) not used by the operating system can be used in ${PRODUCTNAME}. 
If a key combination in ${PRODUCTNAME} does not work as described in the 
${PRODUCTNAME} Help, check if that shortcut is already used by the operating 
system. To rectify such conflicts, you can change the keys assigned by your 
operating system. Alternatively, you can change almost any key assignment in 
${PRODUCTNAME}. For more information on this topic, refer to the ${PRODUCTNAME} 
Help or the Help documention of your operating system.
+   Only shortcut keys (key 
combinations) not used by the operating system can be used in ${PRODUCTNAME}. 
If a key combination in ${PRODUCTNAME} does not work as described in the 
${PRODUCTNAME} Help, check if that shortcut is already used by the operating 
system. To rectify such conflicts, you can change the keys assigned by your 
operating system. Alternatively, you can change almost any key assignment in 
${PRODUCTNAME}. For more information on this topic, refer to the ${PRODUCTNAME} 
Help or the Help documentation of your operating system.

The 
application help of ${PRODUCTNAME} may use shortcut combinations for PC 
keyboards only.

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: 2 commits - loleaflet/build loleaflet/dist loleaflet/src

[Henry Castro]

 loleaflet/build/deps.js  |4 
 loleaflet/dist/loleaflet.css |   12 +
 loleaflet/src/control/Control.Menubar.js |2 
 loleaflet/src/core/LOUtil.js |9 +
 loleaflet/src/layer/AnnotationManager.js |   30 ++--
 loleaflet/src/layer/marker/Annotation.js |   19 ++
 loleaflet/src/layer/marker/DivOverlay.js |  125 +
 loleaflet/src/layer/tile/CalcTileLayer.js|  188 ++-
 loleaflet/src/layer/tile/ImpressTileLayer.js |7 +
 loleaflet/src/layer/tile/TileLayer.js|   11 -
 loleaflet/src/layer/tile/WriterTileLayer.js  |   33 
 11 files changed, 410 insertions(+), 30 deletions(-)

New commits:
commit 91666d7cd354ef31344cdd88b57d644820dcd52c
Author: Henry Castro 
Date:   Fri Feb 24 15:19:48 2017 -0400

loleaflet: insert Calc comments

diff --git a/loleaflet/build/deps.js b/loleaflet/build/deps.js
index 5d3c3c6..e1b2786 100644
--- a/loleaflet/build/deps.js
+++ b/loleaflet/build/deps.js
@@ -440,6 +440,10 @@ var deps = {
desc: 'Annotation to put on the map.'
},
 
+   DivOverlay: {
+   src: ['layer/marker/DivOverlay.js'],
+   desc: 'Div overlay to put on the map.'
+   }
 };
 
 if (typeof exports !== 'undefined') {
diff --git a/loleaflet/dist/loleaflet.css b/loleaflet/dist/loleaflet.css
index 956aaee..cebdde0 100644
--- a/loleaflet/dist/loleaflet.css
+++ b/loleaflet/dist/loleaflet.css
@@ -159,3 +159,15 @@ body {
resize: none;
background-color: #c0;
 }
+
+.loleaflet-cell-annotation {
+   background: red;
+   border: 1px solid red;
+   pointer-events: none;
+}
+
+.loleaflet-div-layer {
+   position: absolute;
+   left: 0;
+   top: 0;
+}
diff --git a/loleaflet/src/control/Control.Menubar.js 
b/loleaflet/src/control/Control.Menubar.js
index 9162512..01a4cb5 100644
--- a/loleaflet/src/control/Control.Menubar.js
+++ b/loleaflet/src/control/Control.Menubar.js
@@ -247,7 +247,7 @@ L.Control.Menubar = L.Control.extend({
},
{name: _('Insert'), type: 'menu', menu: [
{name: _('Image'), id: 'insertgraphic', type: 
'action'},
-   {name: _('Comment'), type: 'unocommand', uno: 
'.uno:InsertAnnotation'},
+   {name: _('Comment...'), id: 'insertcomment', 
type: 'action'},
{type: 'separator'},
{name: _('Row'), type: 'unocommand', uno: 
'.uno:InsertRows'},
{name: _('Column'), type: 'unocommand', uno: 
'.uno:InsertColumns'},
diff --git a/loleaflet/src/core/LOUtil.js b/loleaflet/src/core/LOUtil.js
index da9e323..237edbe 100644
--- a/loleaflet/src/core/LOUtil.js
+++ b/loleaflet/src/core/LOUtil.js
@@ -54,6 +54,13 @@ L.LOUtil = {
 
stringToPoint: function(point) {
var numbers = point.match(/\d+/g);
-   return L.point(numbers[0], numbers[1]);
+   return L.point(parseInt(numbers[0]), parseInt(numbers[1]));
+   },
+
+   stringToBounds: function(bounds) {
+   var numbers = bounds.match(/\d+/g);
+   var topLeft = L.point(parseInt(numbers[0]), 
parseInt(numbers[1]));
+   var bottomRight = topLeft.add(L.point(parseInt(numbers[2]), 
parseInt(numbers[3])));
+   return L.bounds(topLeft, bottomRight);
}
 };
diff --git a/loleaflet/src/layer/marker/Annotation.js 
b/loleaflet/src/layer/marker/Annotation.js
index 6e97c9a..26299b0 100644
--- a/loleaflet/src/layer/marker/Annotation.js
+++ b/loleaflet/src/layer/marker/Annotation.js
@@ -68,6 +68,10 @@ L.Annotation = L.Layer.extend({
return this;
},
 
+   isEdit: function () {
+   return this._editNode && this._editNode.style.display !== 
'none';
+   },
+
focus: function () {
this._editText.focus();
},
@@ -106,6 +110,7 @@ L.Annotation = L.Layer.extend({
 
var events = ['click', 'dblclick', 'mousedown', 'mouseup', 
'mouseover', 'mouseout', 'keydown', 'keypress', 'keyup'];
L.DomEvent.on(container, 'click', this._onMouseClick, this);
+   L.DomEvent.on(container, 'mouseleave', this._onMouseLeave, 
this);
for (var it = 0; it < events.length; it++) {
L.DomEvent.on(container, events[it], 
L.DomEvent.stopPropagation, this);
}
@@ -123,6 +128,20 @@ L.Annotation = L.Layer.extend({
this._map.fire('AnnotationClick', {annotation: this});
},
 
+   _onMouseLeave: function (e) {
+   var layerPoint = this._map.mouseEventToLayerPoint(e),
+   latlng = this._map.layerPointToLatLng(layerPoint);
+   L.DomEvent.stopPropagation(e);
+   if (this._contextMenu || this.isEdit()) {
+   

CppCheck Report Update

[cppcheck.libreoff...@gmail.com]

A new cppcheck report is available at : 
http://dev-builds.libreoffice.org/cppcheck_reports/master/


Note:
The script generating this report was run at :
2017-26-02_02:28:26 with user buildslave at host vm140 as 
/home/buildslave/source/dev-tools/cppcheck/cppcheck-report.sh -s 
/home/buildslave/source/libo-core -c /home/buildslave/source/cppcheck -w 
/home/buildslave/tmp/www

It can be found and improved here:

https://gerrit.libreoffice.org/gitweb?p=dev-tools.git;a=blob;f=cppcheck/cppcheck-report.sh


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 106184] New: VIEWING : Strange behavior when new window of a document

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106184

Bug ID: 106184
   Summary: VIEWING : Strange behavior when new window of a
document
   Product: LibreOffice
   Version: 5.2.5.1 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: eric.cout...@gmail.com

Use "Fenêtre/Nouvelle fenêtre" ("Window/New Window"). I place the two windows
side-by-side on the screen. When I zoom on a window with the mouse, there are
some modifications on the view of the other window. For example, the other
document move on the right or the left.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99784] EXTENSION MANAGER - freeze / hang when attempting to install extensions on OSX 10.11 and macOS 10.12 by double-click on oxt file

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99784

--- Comment #85 from Telesto  ---
Created attachment 131462
  --> https://bugs.documentfoundation.org/attachment.cgi?id=131462=edit
Time Profile License Agreement Dialog

An the License agreement dialog keeps consuming CPU after showing up. It keeps
hitting:
SAL_IMPLEMENT_MAIN() {
int ret = soffice_main();

Version: 5.4.0.0.alpha0+
Build ID: a8538f0774bd0fabf6012d735d1e86b3ff1c291f
CPU threads: 4; OS: Mac OS X 10.12.4; UI render: default; 
Locale: en-US (en_US.UTF-8); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102779] Notebookbar: Add spacing/padding around tab labels

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102779

Yousuf Philips (jay)  changed:

   What|Removed |Added

   Keywords|needsUXEval |needsDevEval, topicUI
 CC|libreoffice-ux-advise@lists |eszka...@gmail.com,
   |.freedesktop.org|momonas...@gmail.com,
   ||s.mehrbr...@gmail.com

--- Comment #8 from Yousuf Philips (jay)  ---
@Maxim, @Szymon, @Samuel: Any thoughts on how this can be resolved?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 102779] Notebookbar: Add spacing/padding around tab labels

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102779

Yousuf Philips (jay)  changed:

   What|Removed |Added

   Keywords|needsUXEval |needsDevEval, topicUI
 CC|libreoffice-ux-advise@lists |eszka...@gmail.com,
   |.freedesktop.org|momonas...@gmail.com,
   ||s.mehrbr...@gmail.com

--- Comment #8 from Yousuf Philips (jay)  ---
@Maxim, @Szymon, @Samuel: Any thoughts on how this can be resolved?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 102779] Notebookbar: Add spacing/padding around tab labels

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102779

--- Comment #9 from andreas_k  ---
>From the design the tabs look (in windows 7) really really ugly. Only in Gnome
they look good (in KDE it's ok, but more space could help)

As you can read different designes, different layout. Is on one hand very good
on the other hand the problem is on the most used platform windows (7) the tabs
look really ugly.

Make tham less tiny would help. Maybe we can add an action button to open the
files menubar or view, ... shown an save icon in the files tab could also help
to give the user an information what's in the tab and for save the user didn't
have to switch to the tab.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 103033] Allow scrolling through Notebookbar tabs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103033

--- Comment #4 from Yousuf Philips (jay)  ---
(In reply to Samuel Mehrbrodt (CIB) from comment #0)
> When the cursor is on the Notebookbar (tabs or content), scrolling with the
> mouse wheel should travel through the tabs.

As this functionality is both in MSO (tabs or content) and WPS (tabs), it would
be good to have this functionality for users who are use to this behaviour.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 103033] Allow scrolling through Notebookbar tabs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103033

--- Comment #4 from Yousuf Philips (jay)  ---
(In reply to Samuel Mehrbrodt (CIB) from comment #0)
> When the cursor is on the Notebookbar (tabs or content), scrolling with the
> mouse wheel should travel through the tabs.

As this functionality is both in MSO (tabs or content) and WPS (tabs), it would
be good to have this functionality for users who are use to this behaviour.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 72412] Tables in Impress: when the background is changed, the font size changes

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=72412

Justin L  changed:

   What|Removed |Added

   Keywords|bibisected, bisected,   |
   |regression  |
 CC||jl...@mail.com
Version|4.1.2.2 rc  |3.5.0 release

--- Comment #9 from Justin L  ---
Using the procedure in comment 1, I was able to reproduce in LO 3.5
(bibisect-43all).  I also used 5.4alpha with a revert of the commit from
comment 7, and that did not "fix" the problem.  Removing regression/bibisected
tags.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106185] New: Calc in libreoffice saved spreadsheet opens with blank page when google chrome +Kaspersky safe money are open

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106185

Bug ID: 106185
   Summary: Calc in libreoffice saved spreadsheet opens with blank
page when google chrome +Kaspersky safe money are open
   Product: LibreOffice
   Version: 5.2.2.2 release
  Hardware: x86 (IA32)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: minor
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: pjol...@hotmail.com

Description:
Using a saved spreadsheet on a memory stick, if I have my bank accounts open
with Google chrome (latest and former editions ) accessed through Kaspersky
internet security Safe money protected browser, recalling the spreadsheet it
comes up headed as libre office but an otherwise blank page. Closing the
browsers and then reopening the spreadsheet and it opens normally with full
detail.  This makes it difficuly to copy figures from my online accounts to my
saved libreoffice spreadsheet. (win 10 64 up to date)

Steps to Reproduce:
1.Open spreadsheet
2.Access bank account using google chrome through safe money protected browser
3.recall spreadsheet from taskbar

Actual Results:  
"Libre office"name at top left of document. the rest is totally blank

Expected Results:
displayed the spreadsheet with the saved detail


Reproducible: Always

User Profile Reset: No

Additional Info:
The saved spreadsheet (ods document ) is saved on a memory stick.
Windows 10 64 bit fully up to date with Google chrome latest version (although
this happened with previous editions) and latest version of libreoffice 5.2.5
win86.msi (although this happened with version 5.1.4 )


User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36
(KHTML, like Gecko) Chrome/56.0.2924.87 Safari/537.36

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106180] No screen reader notification that there is a comment

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106180

Aron Budea  changed:

   What|Removed |Added

 CC||ba...@caesar.elte.hu
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||2058

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102058] No screen reader notification that there is a comment

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102058

Aron Budea  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||6180

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103751] RTL outline numbering not working as expected...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103751

Nima Az  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #11 from Nima Az  ---
Hi,

Finally got to check the reported issue in 5.3.  The issue has not went away.

This is an obviously missing feature in LibreOffice.  There should be an easy
way of changing the alignment of outline numberings to right-to-left when
typing in an RTL language.  In RTL documents it's preferred that chapter
numbers appear on the right, then following by other outline levels.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103751] RTL outline numbering not working as expected...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103751

Nima Az  changed:

   What|Removed |Added

Version|5.2.2.2 release |5.3.0.3 release

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106189] Problem using the "&" in a comment

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106189

--- Comment #2 from joeperr...@gmail.com ---
(In reply to m.a.riosv from comment #1)
> What's the user interface language, and cell language?
> 
> Please try resetting the user profile, sometimes solves strange issues.
> https://wiki.documentfoundation.org/UserProfile
> Usually it's enough renaming/deleting the file
> "user/registrymodifications.xcu",  it affects all the options in
> Menu/Tools/Options, and the files "user/basic/dialog.xlc" and "scrip.xlc"
> are overwritten, additionally custom colors in "user/config/standard.soc"
> are lost.

I'm adding a comment in a cell using standard American English

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103355] Notebookbar doesnt disappear during slide show / presentation mode

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103355

--- Comment #7 from Jordan Maris  ---
I can also confirm this issue exists

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101513] Making NotebookBar customizable

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101513

--- Comment #2 from Jordan Maris  ---
This could be of interest. the notebookbar currently lacks some key functions
by defaut

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106190] New: Fraction format: insert space after fraction bar freezes LibO

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106190

Bug ID: 106190
   Summary: Fraction format: insert space after fraction bar
freezes LibO
   Product: LibreOffice
   Version: 5.3.0.3 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: jumbo4...@yahoo.fr

Description:
When modifying user-defined format, if I (accidentally) insert a space between
fraction bar and denominator string, LibO freezes

Steps to Reproduce:
1. Format > Cells > Numbers
2. Select Fraction category
3. In format code string, click just after fraction bar (/)
4. Hit space

Actual Results:  
Nothing is changing in format code and LibO freezes: no reaction of UI,
hardware temperature increases, even after several minutes. You need to kill
LibO

Expected Results:
Format code should be modified like:
# ?/ ?


Reproducible: Always

User Profile Reset: No

Additional Info:
Same bug with English or French language (in French space is also thousands
separator).

Same bug if space (or any character different from 0, ?, #, e, E or /) is
inserted in the middle of denominator string, for instance to get
# ???/?? ?

No bug if you insert space in any other places in format code.
No bug if you insert text in any other places, even between fraction bar and
denominator string.


User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:50.0) Gecko/20100101
Firefox/50.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106162] UseOpenCL reset to false

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106162

--- Comment #3 from Aron Budea  ---
You could verify if it's working with previous releases by installing a 5.2
version separately as described in [1].

In general I'm somewhat concerned there's no established way of getting details
on what was tested and what the result was, as currently there's no way to tell
whether LibreOffice or the OpenCL implementation is at fault.

[1] https://wiki.documentfoundation.org/Installing_in_parallel

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-qa] How to test tickets from old versions? example - Bug 105981

[Andrea Mussap]

Hi, folks.

I wanted to test this Bug 105981 - Recently edited documents don't show up on 
recent documents menu, but the issue was found in version 5.2.5.1.
I went to the Download LO page but I don't see this specific version there. So, 
what version should I download to test it?
* Another question: If I want to test issues from different versions, will I 
have to download, install and uninstall the different versions all the time, or 
is there a better way to do that?
BRAndrea.





___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

[Libreoffice-bugs] [Bug 106187] New: Document colors not working with text highlight and shape colors

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106187

Bug ID: 106187
   Summary: Document colors not working with text highlight and
shape colors
   Product: LibreOffice
   Version: 5.4.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: philip...@hotmail.com
Blocks: 85184

Steps:
1) Open attached doc
2) Open up the color widget and select document colors and notice that 5 colors
are shown
3) The list doesnt show the Blue highlight color or the 4 colors used in the
circle and triangle shapes

Version: 5.4.0.0.alpha0+
Build ID: 36de6c50684c8241969a2064d30aff41e0bc5d97
CPU threads: 2; OS: Linux 3.19; UI render: default; VCL: gtk2; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time:
2017-02-22_23:33:52
Locale: en-US (en_US.UTF-8); Calc: group


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=85184
[Bug 85184] [META] Color picker toolbar and sidebar drop-down widget bugs and
enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 85184] [META] Color picker toolbar and sidebar drop-down widget bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=85184

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Depends on||106187


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=106187
[Bug 106187] Document colors not working with text highlight and shape colors
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105981] Recently edited documents don' t show up on recent documents menu

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105981

m.a.riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg

--- Comment #3 from m.a.riosv  ---
Please try resetting the user profile, sometimes solves strange issues.
https://wiki.documentfoundation.org/UserProfile
Usually it's enough renaming/deleting the file
"user/registrymodifications.xcu",  it affects all the options in
Menu/Tools/Options, and the files "user/basic/dialog.xlc" and "scrip.xlc" are
overwritten, additionally custom colors in "user/config/standard.soc" are lost.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106187] Document colors not working with text highlight and shape colors

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106187

--- Comment #1 from Yousuf Philips (jay)  ---
Created attachment 131463
  --> https://bugs.documentfoundation.org/attachment.cgi?id=131463=edit
sample doc

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105981] Recently edited documents don' t show up on recent documents menu

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105981

m.a.riosv  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105981] Recently edited documents don' t show up on recent documents menu

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105981

Andrea Mussap  changed:

   What|Removed |Added

 CC||andreamus...@yahoo.com

--- Comment #4 from Andrea Mussap  ---
Created attachment 131464
  --> https://bugs.documentfoundation.org/attachment.cgi?id=131464=edit
I couldn't reproduce bug in Version 5.2.1.2

I couldn't reproduce the bug in Version: 5.2.1.2. 

Create a new file > Save it.
Create a new file > Save As.
Open a file that already exists > editi it> Save it
Open a file that already exists > editi it> Save As.
I've saved in the same folder and in another different folder.

All files are listed in the Recent Docs list, and in the start center. Please
see attachment bug-105981-LO-5.2.1.2-works-fine.png

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105981] Recently edited documents don' t show up on recent documents menu

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105981

--- Comment #5 from Andrea Mussap  ---
I couldn't reproduce the bug in Version: 5.3.0.3.

Create a new file > Save it.
Create a new file > Save As.
Open a file that already exists > editi it> Save it
Open a file that already exists > editi it> Save As.
File > Recent Documents > open a file > edit it > save in another folder

All files are listed in the Recent Docs list, and in the start center.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106186] Update notification in 5.1.75 x64 links to 5.2.5.1 x86 version

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106186

--- Comment #1 from Mike  ---
(I meant the update notification windows)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106186] Update notification in 5.1.75 x64 links to 5.2.5.1 x86 version

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106186

Mike  changed:

   What|Removed |Added

Version|5.1.2.2 release |5.1.6.2 release

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: [Libreoffice-qa] How to test tickets from old versions? example - Bug 105981

[Pedro]

Hi Andrea


Andrea Mussap wrote
> I wanted to test this Bug 105981 - Recently edited documents don't show up
> on recent documents menu, but the issue was found in version 5.2.5.1.
> I went to the Download LO page but I don't see this specific version
> there. So, what version should I download to test it?

http://downloadarchive.documentfoundation.org/libreoffice/old/


Andrea Mussap wrote
> * Another question: If I want to test issues from different versions, will
> I have to download, install and uninstall the different versions all the
> time, or is there a better way to do that?

If you are running Windows the easiest way is to get a Portable version (no
install needed).
Personally I prefer the Portable versions from winPenPack
https://sourceforge.net/projects/winpenpack/files/X-LibreOffice/releases/

but you can also get the PortableApps releases
http://download.documentfoundation.org/libreoffice/portable/
(maybe there is a more complete archive)

In any case you can install any regular version in parallel (so there is no
need to install/uninstall)
https://wiki.documentfoundation.org/Installing_in_parallel

HTH
Pedro
 



--
View this message in context: 
http://nabble.documentfoundation.org/Libreoffice-qa-How-to-test-tickets-from-old-versions-example-Bug-105981-tp4208961p4208965.html
Sent from the QA mailing list archive at Nabble.com.
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] How to test tickets from old versions? example - Bug 105981

[m.a.riosv]

Parallel installations it's easier with Separate Install GUI

https://wiki.documentfoundation.org/SI-GUI

Miguel Ángel



--
View this message in context: 
http://nabble.documentfoundation.org/Libreoffice-qa-How-to-test-tickets-from-old-versions-example-Bug-105981-tp4208961p4208966.html
Sent from the QA mailing list archive at Nabble.com.
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

[Libreoffice-bugs] [Bug 106184] VIEWING : Strange behavior when new window of a document

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106184

Jacques Guilleron  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 85184] [META] Color picker toolbar and sidebar drop-down widget bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=85184
Bug 85184 depends on bug 84579, which changed state.

Bug 84579 Summary: COLOR PICKER: Text label of currently selected color should 
appear in dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=84579

   What|Removed |Added

 Status|RESOLVED|NEW
 Resolution|WONTFIX |---

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 84579] COLOR PICKER: Text label of currently selected color should appear in dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=84579

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Status|RESOLVED|NEW
 Resolution|WONTFIX |---

--- Comment #13 from Yousuf Philips (jay)  ---
(In reply to Heiko Tietze from comment #12)
> Closing this ticket as WONTFIX since we show the hex value in the dialog now
> next to the new solid color.

This ticket is about the color picker drop down widget found in the toolbar and
sidebar and not about the area fill tab.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106186] New: Update notification in 5.1.75 x64 links to 5.2.5.1 x86 version

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106186

Bug ID: 106186
   Summary: Update notification in 5.1.75 x64 links to 5.2.5.1 x86
version
   Product: LibreOffice
   Version: 5.1.2.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: simfi...@arcor.de

Today I received an update notification and was linked to the x86 installer but
I use the x64 version of LibreOffice.
It has to be fixed that the x64 version links to x64 installers if a new
version is released.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104222] FILESAVE: PPTX: performance regression at save time in Linux, write error in Windows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104222

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|interoperability|interoperability
   ||target:5.4.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104222] FILESAVE: PPTX: performance regression at save time in Linux, write error in Windows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104222

--- Comment #10 from Commit Notification 
 ---
Matúš Kukan committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=9cbe69f1950115e47af693bd78fc78f96f9b508e

tdf#104222: Put expensive debug code behind #if again

It will be available in 5.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106184] VIEWING : Strange behavior when new window of a document

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106184

Jacques Guilleron  changed:

   What|Removed |Added

 CC||guillero...@aol.com

--- Comment #1 from Jacques Guilleron  ---
Hi eric,

I don't reproduce with
LO 5.2.5.1 Build ID: 0312e1a284a7d50ca85a365c316c7abbf20a4d22
Threads CPU : 2; Version de l'OS :Windows 6.1; UI Render : par défaut; 
Locale : fr-FR (fr_FR); Calc: single

On which OS(s) do you see this issue?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 85184] [META] Color picker toolbar and sidebar drop-down widget bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=85184

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Depends on||106188


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=106188
[Bug 106188] Unused colors not removed from document colors list
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106188] New: Unused colors not removed from document colors list

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106188

Bug ID: 106188
   Summary: Unused colors not removed from document colors list
   Product: LibreOffice
   Version: 5.4.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: philip...@hotmail.com
Blocks: 85184

Steps:
1) Open Writer
2) Type some text and set its color to Green
3) Open up the color widget and notice that Green is in the document colors
palette
4) Press undo or set the selected text color back to automatic and see that
Green wasnt removed from the document colors palette

Version: 5.4.0.0.alpha0+
Build ID: 36de6c50684c8241969a2064d30aff41e0bc5d97
CPU threads: 2; OS: Linux 3.19; UI render: default; VCL: gtk2; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time:
2017-02-22_23:33:52
Locale: en-US (en_US.UTF-8); Calc: group


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=85184
[Bug 85184] [META] Color picker toolbar and sidebar drop-down widget bugs and
enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106189] New: Problem using the "&" in a comment

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106189

Bug ID: 106189
   Summary: Problem using the "&" in a comment
   Product: LibreOffice
   Version: 5.3.0.3 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: joeperr...@gmail.com

I've run into a problem with the latest update in Calc ... when I am writing a
descriptive note in a spreadsheet and I use the "&" all of the words entered
prior to the "&" disappear and the entire line turns blue and locks.  I then
have to go back and re-enter the information that I put in leading up to the
"&" then skip past the "&" and continue the note.  

I don't remember this being a problem prior to the current release

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106189] Problem using the "&" in a comment

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106189

m.a.riosv  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||miguelangelrv@libreoffice.o
   ||rg
 Ever confirmed|0   |1

--- Comment #1 from m.a.riosv  ---
What's the user interface language, and cell language?

Please try resetting the user profile, sometimes solves strange issues.
https://wiki.documentfoundation.org/UserProfile
Usually it's enough renaming/deleting the file
"user/registrymodifications.xcu",  it affects all the options in
Menu/Tools/Options, and the files "user/basic/dialog.xlc" and "scrip.xlc" are
overwritten, additionally custom colors in "user/config/standard.soc" are lost.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 86143] Dragging merged from the corner puts it in a single cell

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=86143

m.a.riosv  changed:

   What|Removed |Added

 CC||jmadero@gmail.com

--- Comment #7 from m.a.riosv  ---
*** Bug 101229 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101229] Dragging Merged Cell Breaks Merge

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101229

m.a.riosv  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #9 from m.a.riosv  ---


*** This bug has been marked as a duplicate of bug 86143 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106190] Fraction format: insert space after fraction bar freezes LibO

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106190

V Stuart Foote  changed:

   What|Removed |Added

   Keywords||haveBacktrace
 Status|UNCONFIRMED |NEW
 CC||vstuart.fo...@utsa.edu
 Ever confirmed|0   |1

--- Comment #1 from V Stuart Foote  ---
Confirmed. On Windows 10 Pro 64-bit en-US with
Version: 5.4.0.0.alpha0+
Build ID: f0c7cbe1d8505d3c1f5a2b2253efda35542c898b
CPU threads: 8; OS: Windows 6.19; UI render: GL; 
TinderBox: Win-x86@39, Branch:master, Time: 2017-02-22_04:35:00
Locale: en-US (en_US); Calc: CL

Here is the stack when hung up. The  sal3!rtl_uStringbuffer_remove, and 
mergedlo!SvNumberformat::ImpGetFractionOutput

=-stack trace TB39 w/Symbols-=

0:013> ~* kp

   0  Id: 89c.598 Suspend: 1 Teb: 00f9a000 Unfrozen
ChildEBP RetAddr  
0198c8cc 622f8ac9 sal3!rtl_uStringbuffer_remove(struct _rtl_uString ** This =
0x0198ca3c, long start = 0n0, long len = 0n1)+0xec
[c:\cygwin\home\tinderbox\master\sal\rtl\ustrbuf.cxx @ 258]
0198c8e4 6235a182 svllo!rtl::OUStringBuffer::remove(long start = 0n0, long len
= 0n1)+0x19 [c:\cygwin\home\tinderbox\master\include\rtl\ustrbuf.hxx @ 1225]
0198cae0 62355b96 svllo!SvNumberformat::ImpGetFractionOutput(double fNumber =
0.456000307, unsigned short nIx = 0, class rtl::OUStringBuffer * sBuff
= 0x0198cb64)+0x7f2
[c:\cygwin\home\tinderbox\master\svl\source\numbers\zformat.cxx @ 2845]
0198cb8c 62340aa1 svllo!SvNumberformat::GetOutputString(double fNumber =
123.456, class rtl::OUString * OutString = 0x0198cc30, class Color ** ppColor =
0x0198cc2c)+0x796
[c:\cygwin\home\tinderbox\master\svl\source\numbers\zformat.cxx @ 2533]
0198cbdc 625807f5 svllo!SvNumberFormatter::GetPreviewString(class rtl::OUString
* sFormatString = 0x0198cc8c, double fPreviewNumber = 123.456, class
rtl::OUString * sOutString = 0x0198cc30, class Color ** ppColor = 0x0198cc2c,
unsigned short eLnge = 0, bool bUseStarFormat = true)+0x191
[c:\cygwin\home\tinderbox\master\svl\source\numbers\zforlist.cxx @ 1631]
0198cc10 594291b9 svxlo!SvxNumberFormatShell::MakePreviewString(class
rtl::OUString * rFormatStr = 0x0198cc8c, class rtl::OUString * rPreviewStr =
0x0198cc30, class Color ** rpFontColor = 0x0198cc2c)+0x65
[c:\cygwin\home\tinderbox\master\svx\source\items\numfmtsh.cxx @ 452]
0198cc40 59427681 cuilo!SvxNumberFormatTabPage::MakePreviewText(class
rtl::OUString * rFormat = 0x0198cc8c)+0x59
[c:\cygwin\home\tinderbox\master\cui\source\tabpages\numfmt.cxx @ 1752]
0198ccac 594278a3 cuilo!SvxNumberFormatTabPage::EditHdl_Impl(class Edit *
pEdFormat = 0x17ffc948)+0x161
[c:\cygwin\home\tinderbox\master\cui\source\tabpages\numfmt.cxx @ 1554]
0198ccbc 59428e5f cuilo!SvxNumberFormatTabPage::EditModifyHdl_Impl(class Edit *
rEdit = 0x17ffc948)+0x13
[c:\cygwin\home\tinderbox\master\cui\source\tabpages\numfmt.cxx @ 1537]
*** ERROR: Symbol file could not be found.  Defaulted to export symbols for
C:\LODev540_x86_20170222_TB39\program\vcllo.dll - 
0198ccc8 6095fc83 cuilo!SvxNumberFormatTabPage::LinkStubEditModifyHdl_Impl(void
* instance = 0x2534b950, class Edit * data = 0x17ffc948)+0xf
[c:\cygwin\home\tinderbox\master\cui\source\tabpages\numfmt.cxx @ 1534]
WARNING: Stack unwind information not available. Following frames may be wrong.
0198ccdc 6095f1bd vcllo!Edit::CalcSize+0x113
0198ccec 6095d486 vcllo!TextFilter::~TextFilter+0x6ad
0198ccf8 609693d2 vcllo!Control::dispose+0xcd6
0198cd04 6095a5c9 vcllo!Edit::UpdateData+0x172
0198cd10 6095b9c6 vcllo!vcl::ControlLayoutData::~ControlLayoutData+0x329
0198cd34 60968014 vcllo!Control::ImplCallEventListenersAndHandler+0x76
0198cd80 6096588c vcllo!Edit::Modify+0xc4
0198cd8c 60964909 vcllo!Edit::ImplModified+0x2c
0198ceb0 60967d78 vcllo!Edit::ImplHandleKeyEvent+0xd19
0198cec0 6092a602 vcllo!Edit::KeyInput+0x78
0198d004 6092e5e8 vcllo!vcl::Window::ImplAsyncFocusHdl+0x1dd2
0198d1fc 60da1fae vcllo!FloatingWindow::ImplSetMouseDown+0x338
0198d218 60da67c4 vcllo!CommandMediaData::CommandMediaData+0xfae
0198d2bc 60dab87f vcllo!CommandMediaData::GetPassThroughToOS+0x3b54
0198d410 60dac571 vcllo!WorkWindow::IsFullScreenMode+0x5ef
0198d460 7494d2b3 vcllo!WorkWindow::IsFullScreenMode+0x12e1
0198d48c 7492e88a USER32!_InternalCallWinProc+0x2b
0198d574 7492df17 USER32!UserCallWinProcCheckWow+0x30a
0198d5b0 5d6ece43 USER32!CallWindowProcW+0x97
0198d5f0 7494d2b3 OPENGL32!wglWndProc+0x233
0198d61c 7492e88a USER32!_InternalCallWinProc+0x2b
0198d704 7492e1e4 USER32!UserCallWinProcCheckWow+0x30a
0198d778 7492dfa0 USER32!DispatchMessageWorker+0x234
0198d784 60d675d6 USER32!DispatchMessageW+0x10
0198d798 60d67722 vcllo!WinBlocklistParser::parse+0xc926
0198d7d0 60d67481 vcllo!WinBlocklistParser::parse+0xca72
0198d804 60c4aa59 vcllo!WinBlocklistParser::parse+0xc7d1
0198da50 60c4ce5e 

[Libreoffice-bugs] [Bug 103751] RTL outline numbering not working as expected...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103751

Buovjaga  changed:

   What|Removed |Added

Version|5.3.0.3 release |5.2.2.2 release

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106186] Update notification in 5.1.75 x64 links to 5.2.5.1 x86 version

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106186

V Stuart Foote  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||vstuart.fo...@utsa.edu
 Ever confirmed|0   |1

--- Comment #2 from V Stuart Foote  ---
Please provide the build info from Help -> About, and details of your OS/DE

Otherwise can not confirm on Windows 10 Pro 64-bit en-US with
Version: 5.1.6.2 (x64)
Build ID: 07ac168c60a517dba0f0d7bc7540f5afa45f0909

the update check -> download button lands on the LibreOffice Still download
page at an annotation appropriate to select the 64-bit download, .e.g
http://www.libreoffice.org/download/libreoffice-still/?type=win-x86_64=en-US=5.2.5

while on same system with an x86 build 
Version: 5.1.0.2
Build ID: ecd3574d51754b043f865cf5bafee286d24db7cc

the update check -> download button lands configured for an x86 32-bit build
download, e.g.
http://www.libreoffice.org/download/libreoffice-fresh/?type=win-x86=en-US=5.2.5

So, this is correct and WFM with Windows builds. 

Also, update check download has never completed an automated download and
update. It is planned, including incremental updates, but is not in any sense
functional at this time. 

Landing at the download page is all that is supported for now.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106183] filenames (mostly) not displayed in title bar - title bar empty for all LO applcations

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106183

V Stuart Foote  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||vstuart.fo...@utsa.edu
 Ever confirmed|0   |1

--- Comment #1 from V Stuart Foote  ---
Please provide your Linux build and the Desktop Environment in use.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 89611] TOC: Undos lost after modifying index/table of contents

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=89611

--- Comment #9 from Johnny_M  ---
(In reply to Michael Stahl from comment #8)
> i disagree that clearing the Undo history should be considered dataLoss
> - by that logic, every crash would be a dataLoss too, and we'd need
> a new keyword for the i-load-a-file-and-store-it-and-oops-my-text-is-gone
> disasters.

I don't now. One could argue that it's worse than a crash in terms of data
loss. Because in the case of a crash there are recent backups which can be
restored on the next start. While with this issue, one would need to purposely
crash LO to get to those. A normal user would not know that - they would just
consider the data lost. And the backups would be purged on the next regular LO
shutdown.

But this might be another duplicate of the bug 38703.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 89606] [META] Table of Contents and Indexes bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=89606

Johnny_M  changed:

   What|Removed |Added

 Depends on||38703


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=38703
[Bug 38703] Indexe(s) 'Update' or change deletes 'undo - redo' stack
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 38703] Indexe(s) 'Update' or change deletes 'undo - redo' stack

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=38703

Johnny_M  changed:

   What|Removed |Added

 Blocks||89606


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=89606
[Bug 89606] [META] Table of Contents and Indexes bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105286] Ellipsis do not rotate in vertical layout.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105286

--- Comment #8 from Volga  ---
Created attachment 131465
  --> https://bugs.documentfoundation.org/attachment.cgi?id=131465=edit
Screenshot from LO 5.3.1.1

OK, they works with me on 5.3.1.1.

Version: 5.3.1.1 (x64)
Build ID: 72fee18f394a980128dc111963f2eefb05998eeb
CPU Threads: 4; OS Version: Windows 6.19; UI Render: default; Layout Engine:
new; 
Locale: zh-CN (zh_CN); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101630] Google Drive two-factor authentication (2FA) not working again

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101630

BlenderGeek  changed:

   What|Removed |Added

 CC||blenderge...@gmail.com

--- Comment #16 from BlenderGeek  ---
Just confirmed on XUbuntu 16.04.2 using the following LibreOffice build:
Version: 5.3.0.3
Build ID: 1:5.3.0~rc3-0ubuntu1~xenial1.1
CPU Threads: 4; OS Version: Linux 4.4; UI Render: default; VCL: gtk2; Layout
Engine: new; 
Locale: en-US (en_US.UTF-8); Calc: group

Further, I noticed that when I enter a wrong password with two-factor enabled,
the dialogue for two factor appears. Then I enter the six digit code and
whatever I enter in that box I get "The specified device is invalid".

I also get this error if I type an unused email address or the wrong password.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106171] Notebookbar: Drop down actions item size

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106171

Maxim Monastirsky  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO
 CC||momonas...@gmail.com

--- Comment #1 from Maxim Monastirsky  ---
Did you try to set the "Icon size" property in Glade (under the "General" tab)?
It should support the following values:

- small icons (16px), set in Glade with "Menu" or "Small Toolbar".
- large icons (26px), set in Glade with "Large Toolbar".
- extra large (32px), set in Glade with "Drag & Drop".
- default depends on what was set in Tools > Options... for
Sidebar/Notebookbar.

I implemented it some time ago with
https://cgit.freedesktop.org/libreoffice/core/commit/?id=cdf4b2bba8d694299c784f46fe3ecef2ce41171e
(see the commit message for more supported stuff).

In addition, it's possible to set the size of a button regardless of the icon
size with "Height request"/"Width request" (under the "Common" tab), but it
works only for an individual button, not for a whole toolbar control.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106188] Unused colors not removed from document colors list

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106188

Heiko Tietze  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||tietze.he...@gmail.com
 Ever confirmed|0   |1

--- Comment #1 from Heiko Tietze  ---
Confirming. The reverted color remains in the document colors even after
reloading it. The property is stored in the document as . But  isn't
used anymore in the document.

Likely the issue is true for all other properties as well. For the colors a
solution could be to compare the list of styles against what is actually used.

Version: 5.3.0.3
Build ID: 5.3.0-2
CPU Threads: 8; OS Version: Linux 4.9; UI Render: default; VCL: kde4; Layout
Engine: new; 
Locale: de-DE (en_US.UTF-8); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106191] New: Grainy icons on libreoffice 5.3.0 ( but not in libreoffice 5.2.5 on the same PC)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106191

Bug ID: 106191
   Summary: Grainy icons on libreoffice 5.3.0 (but not in
libreoffice 5.2.5 on the same PC)
   Product: LibreOffice
   Version: 5.3.0.3 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: massi...@gmail.com

Created attachment 131466
  --> https://bugs.documentfoundation.org/attachment.cgi?id=131466=edit
Screenshot

The libreoffice icons appear grainy (see attachment) This occurs with version
5.3, but not with the 5.2.

S.O. Windows 10
LO: v. 5.3.0
CPU: Intel i7-6500U
GPU-2D: Intel HD Graphics 520
GPU-3D: Nvidia GeForce 940MX

Screen resolution: 1920x1080

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106186] Update notification in 5.1.75 x64 links to 5.2.5.1 x86 version

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106186

--- Comment #3 from Mike  ---
https://de.libreoffice.org/download/libreoffice-still/
or
https://www.libreoffice.org/download/libreoffice-still/

It is correct that the download does not start immediately but the first seen
link is just called "DOWNLOAD VERSION 5.2.5" and links to the x86 version -
even if a x64-version was installed.
Therefore everyone with a x64 operating-system has to look for the x64-version
to get no "downgrade from 64 to 32 bit".
For shure this is no real bug.
Maybe it would be helpful to note that the download is the x86 version withink
the links description or mention a x64-link directly below.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106186] Update notification in 5.1.75 x64 links to 5.2.5.1 x86 version

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106186

--- Comment #4 from Mike  ---
(if an update appears it links to this webpage)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103033] Allow scrolling through Notebookbar tabs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103033

--- Comment #5 from Heiko Tietze  ---
(In reply to Yousuf Philips (jay) from comment #3)
> I've suggested that we use the mouse scrollwheel to scroll the contents of a
> tab back and forth when the contents dont fit within the window size, rather
> than the shrinking mechanism we currently have.

You mean like when the content area becomes larger and a horizontal scrollbar
appears? But without the scrollbar in case of the Notebookbar, right?
Hope I got you wrong because that would be the worst solution ever. No
indication for the user, very uncommon behavior, weird fiddling with different
concepts. 

(In reply to Yousuf Philips (jay) from comment #4)
> As this functionality is both in MSO (tabs or content) and WPS (tabs), it
> would be good to have this functionality for users who are use to this
> behaviour.

We would copy bad usability. Where does wheeling have an effect except to
scroll or zoom? Nothing to say against keyboard interactions, ctrl+tab should
be there out of the box.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 103033] Allow scrolling through Notebookbar tabs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103033

--- Comment #5 from Heiko Tietze  ---
(In reply to Yousuf Philips (jay) from comment #3)
> I've suggested that we use the mouse scrollwheel to scroll the contents of a
> tab back and forth when the contents dont fit within the window size, rather
> than the shrinking mechanism we currently have.

You mean like when the content area becomes larger and a horizontal scrollbar
appears? But without the scrollbar in case of the Notebookbar, right?
Hope I got you wrong because that would be the worst solution ever. No
indication for the user, very uncommon behavior, weird fiddling with different
concepts. 

(In reply to Yousuf Philips (jay) from comment #4)
> As this functionality is both in MSO (tabs or content) and WPS (tabs), it
> would be good to have this functionality for users who are use to this
> behaviour.

We would copy bad usability. Where does wheeling have an effect except to
scroll or zoom? Nothing to say against keyboard interactions, ctrl+tab should
be there out of the box.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 106187] Document colors not working with text highlight and shape colors

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106187

Heiko Tietze  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||tietze.he...@gmail.com
 Ever confirmed|0   |1

--- Comment #2 from Heiko Tietze  ---
Confirming. Not all colors are taken for the document colors.

Version: 5.3.0.3
Build ID: 5.3.0-2
CPU Threads: 8; OS Version: Linux 4.9; UI Render: default; VCL: kde4; Layout
Engine: new; 
Locale: de-DE (en_US.UTF-8); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106171] Notebookbar: Drop down actions item size

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106171

--- Comment #2 from andreas_k  ---
Down there is the code of the SetOutline DropDown Button and when I add
icon_size it didn't work. Sorry any idea?


   
 True
 False
 True
 .uno:SetOutline
 True
   
   
 False
 True
   


-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106186] Update notification in 5.1.75 x64 links to 5.2.5.1 x86 version

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106186

--- Comment #5 from V Stuart Foote  ---
(In reply to Mike from comment #3)
> https://de.libreoffice.org/download/libreoffice-still/

Again, NEEDINFO

What Operating System (OS) and Desktop Environment (DE) are you working with?
>From the link above assume your locale is German speaking.

For the en-US builds, on the download pages for 5.2.5 Still the correct 32-bit
or 64-bit build flavor is pre-selected, i.e. it Works For Me (WFM).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106171] Notebookbar: Drop down actions item size

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106171

--- Comment #3 from Maxim Monastirsky  ---
(In reply to andreas_k from comment #2)
> Down there is the code of the SetOutline DropDown Button and when I add
> icon_size it didn't work. Sorry any idea?
icon_size belongs to the whole toolbar control (sfxlo-SidebarToolBox or
sfxlo-NotebookbarToolBox), not to an individual button. The notebookbar.ui of
Writer has some examples of its usage. Also make sure you use a recent version
of master which has my commit. And if you're going to use Glade, also make sure
to use the Glade catalog from master, not the one from 5.3.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106191] Grainy icons on libreoffice 5.3.0 ( but not in libreoffice 5.2.5 on the same PC)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106191

V Stuart Foote  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||vstuart.fo...@utsa.edu
 Ever confirmed|0   |1

--- Comment #1 from V Stuart Foote  ---
You appear to have enabled Breeze with "Toolbar icon size" set to Small

You have a strange mix of Icon and Menu sizes showing--not clear how you have
the toolbar buttons showing in your screen clip under those main menu entries. 

Please clear/reset your user profile (remember to make a copy) and allow
defaults to assert. Alternatively, you can use the new "Restart in Safe Mode"
feature from the Help menu and temporarily use a default profile.

Let us know the results on clearing up icons in the GUI

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106192] New: Writer Page View Problem

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106192

Bug ID: 106192
   Summary: Writer Page View Problem
   Product: LibreOffice
   Version: 5.2.5.1 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: neil.calab...@gmail.com

Created attachment 131467
  --> https://bugs.documentfoundation.org/attachment.cgi?id=131467=edit
Screenshot of Writer Page View Problem

When I use Writer, the pages show in a distorted view. The first page will be
way off to the right. See screenshot. Please fix!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 37952] 3.4.0 doesn't print in landscape mode on envelopes

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=37952

Jeremy M  changed:

   What|Removed |Added

 Status|RESOLVED|UNCONFIRMED
 Resolution|INVALID |---
 Ever confirmed|1   |0

--- Comment #19 from Jeremy M  ---
This is still present in 5.3.0. Always wants to print a C5 envelope after
selecting #10. I'm not sure what else you need? Just try to print a #10
envelope for yourself (Windows or Linux, it's quite obvious it doesn't work).
If you need a specific detail, I'm happy to provide it.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106193] New: Erroneus Formula calculation containing INDIRECT(ADDRESS ()), ending in error value

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106193

Bug ID: 106193
   Summary: Erroneus Formula calculation containing
INDIRECT(ADDRESS()), ending in error value
   Product: LibreOffice
   Version: 5.2.5.1 release
  Hardware: x86 (IA32)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: jas.nu...@gmail.com

Description:
I have found that a formula like:

=INDIRECTO(DIRECCION(1;1;;;"Specs"))

produces a #REF! result.

That should be equivalent to:

=INDIRECTO(DIRECCION(1;1;;1;"Specs");1)

which also fails.

However if R1C1 notaition is used, it works fine:

=INDIRECTO(DIRECCION(1;1;;0;"Specs");0)

which produces the right result.

It looks like when the A1 style argument is ommited or set to its default value
(non zero) is not applied correctly.


Steps to Reproduce:
See Description.

Actual Results:  
#REF! result

Expected Results:
Actual value of referenced cell


Reproducible: Always

User Profile Reset: No

Additional Info:
After some testing it seems that ADDRESS function is returning the expected
value as described in the help. It looks like INDIRECT function does not work
correctly when A1 style is especified explicitly or by default.

Spreadsheets using this functions become useless due to #REF! values produced.


User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:51.0) Gecko/20100101 Firefox/51.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 87538] COLOR PICKER: New default color palette

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=87538

--- Comment #23 from Yousuf Philips (jay)  ---
Created attachment 131468
  --> https://bugs.documentfoundation.org/attachment.cgi?id=131468=edit
RYB 8 and 7 variants soc files

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-ux-advise] [Bug 87538] COLOR PICKER: New default color palette

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=87538

--- Comment #24 from Yousuf Philips (jay)  ---
Created attachment 131469
  --> https://bugs.documentfoundation.org/attachment.cgi?id=131469=edit
document with tables showing the RYB 7 and 8 variants

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise