minutes of ESC call ...

[Michael Meeks]

* Present:
+ Bjoern, JanI, Thorsten, Michael M, Sophie, Xisco, Kendy, Oivier,
  Heiko, Miklos, Stephan, Christian, Michael S, Eike

* Completed Action Items:
+ Send sorted & rated GSoC document to the mentors (Thorsten)
+ file twitter commit notification bot easy-hack (Cloph)

* Pending Action Items:
+ mass conversion of helpcontent (Cloph)
   [ still dealing with the UI bits ]
+ look at old Duden extension to see if they use UWINAPI.DLL (Thorsten)
+ release note drop of OSX 10.8 support re: thread-safe statics (Michael S)

* ESC budget tendering (Florian)
+ https://wiki.documentfoundation.org/Development/Budget2017
+ would like to gather a few ESC members for feedback, approval
  (and possibly review of bids)
+ tenders approved in the budget by the board  
https://wiki.documentfoundation.org/Development/Budget2017#Accessibility_improvements
 
* 
https://wiki.documentfoundation.org/Development/Budget2017#Image_handling_re-work
 
* 
https://wiki.documentfoundation.org/Development/Budget2017#Deprecate_SVG_filter_in_favour_of_SVGIO
 
* 
https://wiki.documentfoundation.org/Development/Budget2017#HSQLDB_binary_format_import
 
 + would like a number of experts to help spec. that out (Thorsten)
 + propose: approve specs for tender as-in the wiki &
   Florian to collect people to help out.
+ no objections.

* Release Engineering update (Christian)
+ 5.2.7 RC1 status
+ test failures, didn’t get a build that make-check worked for 1st time.
+ running checks manually – they pass.
+ issues with build parallelism here.
+ sometimes complex test or XStyleLoader2 test – only on Windows.
+ tried 4-5 times, not working – for complete check
+ is it upgrading the compiler ? (Thorsten)
+ random toolchain timing symptom (Michael)
+ random windows updates too – what changed ? (Cloph)
+ only on 5.2? (Miklos)
+ 5.3 rare to run into issues – sometimes XStyleloader2 (Cloph)
AI: + investigate signing issues around files (Cloph)
+ 5.3.3 RC1 status
+ tag yesterday – builds are currently underway
+ available tomorrow.
+ 5.4. builds / master
+ Alpha 1 – April 25th(?) - hard feature-freeze May 15th(?)
  alpha still from master , libreoffice-5-4 tag along with 
feature-freeze
+ translation problems
+ cleanup & re-shuffling in the src files
+ that changed lots of message contexts.
+ around 20k words to translate → thye’re not happy.
+ now down to 1500 – 2000 words; still some left.
+ improving quickly.
+ Android & iOS Remote
+ some patches need review, and some integrated.
+ no new builds yet.
+ online
+ propose skip 5.3.3 rc1 and do an rc2.

* Documentation (Olivier)
 + Zarro unconfirmed documentation bugs
 + thanks to Xisco mailing him the doc. bugs quickly.
 + New page on HC for Template manager (C. Vance and ohallot)
 + Need to review many other outdated/invalid pages on the subject
 + Guides: Change of templates for chapters triggers heavy work on update
  + style names changed – investigating if this is necessary
 + Fixes in help contents after translators
 + Tests LOOL to evaluate use for collaborative content insertion
   for Guides, encouraging results with track changes,
   but some issues open, e.g. protection.
+ may be better suited for doc. Authors rathern than caring about 
formats
+ have to download / edit / up-load cycle currently – which is a pain.
 + use the current site – with latest master/online builds.
+ testing some issues; been reported & fixed by Pranav
+ poking at two users – to see how they interfere – v. optimistic.

* should we have keywords not components in bugzilla (Heiko)
 + would need to move things from writer → documentation etc.
 + what’s wrong with a component ? (Xisco)
+ don’t see the problem.
 + some bugs have multiple facets: l10n, UI, documentation (Heiko)
AI: + come up with a proposal (Xisco, Heiko, Olivier)

* UX Update (Heiko)
+ Bugzilla (topicUI) statistics
248(248) (topicUI) bugs open, 470(470) (needsUXEval) needs to be 
evaluated by the UXteam
+ Updates:
BZ changes   1 week   1 month3 months   12 months
 added  3(3)  9(0)  31(-3) 490(0)
 commented 21(4)107(-36)   532(-73)   3532(-35)
   removed  0(0)  0(0)   4(-4)  38(0)
  resolved  3(-1)22(3)  82(-12)225(1)
+ top 10 contributors:
  Tietze, Heiko made 75 changes in 1 month, and 2262 changes in 1 year
  Foote, V Stuart made 37 changes in 1 month, and 670 changes in 1 year
  Philips, Yousuf made 28 changes in 1 month, and 1226 changes in 1 year
  Thomas Lendo 

[Libreoffice-commits] online.git: Branch 'refs/tags/2.1-rc2' - 0 commits -

[Unknown]

Rebased ref, commits from common ancestor:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loleaflet/src

[Henry Castro]

 loleaflet/src/layer/AnnotationManager.js|9 +
 loleaflet/src/layer/tile/WriterTileLayer.js |9 ++---
 2 files changed, 15 insertions(+), 3 deletions(-)

New commits:
commit 42091f0b2010f66d8a1a0939f7c82926ca38c89d
Author: Henry Castro 
Date:   Thu Apr 20 21:56:07 2017 -0400

loleaflet: update document size when insert new annotation

Change-Id: Iaaca82aba1c04de336e89ff4e854cc9632fbfc53

diff --git a/loleaflet/src/layer/AnnotationManager.js 
b/loleaflet/src/layer/AnnotationManager.js
index 88fbcaba..88cc2c6a 100644
--- a/loleaflet/src/layer/AnnotationManager.js
+++ b/loleaflet/src/layer/AnnotationManager.js
@@ -210,6 +210,12 @@ L.AnnotationManager = L.Class.extend({
this.layout();
},
 
+   updateDocBounds: function (count, extraSize) {
+   if (this._items.length === count) {
+   this._map._docLayer._updateMaxBounds(true, extraSize);
+   }
+   },
+
layoutUp: function (commentThread, latLng, layoutBounds) {
if (commentThread.length <= 0)
return;
@@ -473,6 +479,7 @@ L.AnnotationManager = L.Class.extend({
if (this._selected && !this._selected.isEdit()) {
this._map.focus();
}
+   this.updateDocBounds(1);
this.layout();
} else if (action === 'Remove') {
id = changetrack ? 'change-' + obj.redline.index : 
obj.comment.id;
@@ -480,6 +487,7 @@ L.AnnotationManager = L.Class.extend({
if (removed) {
this.adjustParentRemove(removed);
this._map.removeLayer(this.removeItem(id));
+   this.updateDocBounds(0);
if (this._selected === removed) {
this.unselect();
} else {
@@ -508,6 +516,7 @@ L.AnnotationManager = L.Class.extend({
_onAnnotationCancel: function (e) {
if (e.annotation._data.id === 'new') {

this._map.removeLayer(this.removeItem(e.annotation._data.id));
+   this.updateDocBounds(0);
}
if (this._selected === e.annotation) {
this.unselect();
diff --git a/loleaflet/src/layer/tile/WriterTileLayer.js 
b/loleaflet/src/layer/tile/WriterTileLayer.js
index b45f584d..5610d010 100644
--- a/loleaflet/src/layer/tile/WriterTileLayer.js
+++ b/loleaflet/src/layer/tile/WriterTileLayer.js
@@ -12,6 +12,7 @@ L.WriterTileLayer = L.TileLayer.extend({
comment.anchorPix = 
this._twipsToPixels(comment.anchorPos.min);
}
if (comment.anchorPos) {
+   this._annotations.updateDocBounds(0, 
this._annotations.options.extraSize);

this._annotations.modify(this._annotations.add(comment));
}
},
@@ -229,9 +230,11 @@ L.WriterTileLayer = L.TileLayer.extend({
this._update();
},
 
-   _updateMaxBounds: function (sizeChanged) {
-   var extraSize = this._annotations && 
this._annotations._items.length > 0 ?
-   this._annotations.options.extraSize : null;
+   _updateMaxBounds: function (sizeChanged, extraSize) {
+   if (!extraSize) {
+   extraSize = this._annotations && 
this._annotations._items.length > 0 ?
+   this._annotations.options.extraSize : null;
+   }
L.GridLayer.prototype._updateMaxBounds.call(this, sizeChanged, 
extraSize, {panInside: false});
}
 });
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: wsd/ClientSession.cpp wsd/ClientSession.hpp wsd/DocumentBroker.cpp

[Ashod Nakashian]

 wsd/ClientSession.cpp  |4 ++--
 wsd/ClientSession.hpp  |6 +++---
 wsd/DocumentBroker.cpp |2 +-
 3 files changed, 6 insertions(+), 6 deletions(-)

New commits:
commit 7019ca8c257b6f4e4b91988243da12236c9de94a
Author: Ashod Nakashian 
Date:   Thu Apr 20 22:17:08 2017 -0400

wsd: ClientSession's isLoaded -> isViewLoaded

Not to confuse with the DocumentBroker isLoaded,
this is view-specific. Except for the first view,
which is identical to the document being loaded,
subsequent view loadings are independent from,
though follow, document loading.

Change-Id: I0f21016fa84bf507ca4bc0e7a6c7d0d76b033c60
Reviewed-on: https://gerrit.libreoffice.org/36761
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/wsd/ClientSession.cpp b/wsd/ClientSession.cpp
index 8be60603..11db33af 100644
--- a/wsd/ClientSession.cpp
+++ b/wsd/ClientSession.cpp
@@ -38,7 +38,7 @@ ClientSession::ClientSession(const std::string& id,
 _uriPublic(uriPublic),
 _isDocumentOwner(false),
 _isAttached(false),
-_isLoaded(false)
+_isViewLoaded(false)
 {
 const size_t curConnections = ++LOOLWSD::NumConnections;
 LOG_INF("ClientSession ctor [" << getName() << "], current number of 
connections: " << curConnections);
@@ -632,7 +632,7 @@ bool ClientSession::handleKitToClientMessage(const char* 
buffer, const int lengt
 }
 else if (tokens[0] == "status:")
 {
-setLoaded();
+setViewLoaded();
 docBroker->setLoaded();
 
 // Forward the status response to the client.
diff --git a/wsd/ClientSession.hpp b/wsd/ClientSession.hpp
index 81c55c70..b0eefecf 100644
--- a/wsd/ClientSession.hpp
+++ b/wsd/ClientSession.hpp
@@ -39,8 +39,8 @@ public:
 void setAttached() { _isAttached = true; }
 
 /// Returns true if this session has loaded a view (i.e. we got status 
message).
-bool isLoaded() const { return _isLoaded; }
-void setLoaded() { _isLoaded = true; }
+bool isViewLoaded() const { return _isViewLoaded; }
+void setViewLoaded() { _isViewLoaded = true; }
 
 const std::string getUserId() const { return _userId; }
 const std::string getUserName() const {return _userName; }
@@ -148,7 +148,7 @@ private:
 bool _isAttached;
 
 /// If we have loaded a view.
-bool _isLoaded;
+bool _isViewLoaded;
 
 /// Wopi FileInfo object
 std::unique_ptr _wopiFileInfo;
diff --git a/wsd/DocumentBroker.cpp b/wsd/DocumentBroker.cpp
index fd3a6ea9..a2b90d50 100644
--- a/wsd/DocumentBroker.cpp
+++ b/wsd/DocumentBroker.cpp
@@ -1216,7 +1216,7 @@ void DocumentBroker::destroyIfLastEditor(const 
std::string& id)
 for (const auto& it : _sessions)
 {
 if (it.second->getId() != id &&
-it.second->isLoaded() &&
+it.second->isViewLoaded() &&
 !it.second->isReadOnly())
 {
 // Found another editable.
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: wsd/DocumentBroker.cpp

[Ashod Nakashian]

 wsd/DocumentBroker.cpp |7 ---
 1 file changed, 4 insertions(+), 3 deletions(-)

New commits:
commit 560406a3081cfc5b48f4d6900b1f3c702261f81f
Author: Ashod Nakashian 
Date:   Thu Apr 20 22:43:27 2017 -0400

wsd: don't remove session after saving unconditionally

We should only remove sessions that had already been
disconnected, which caused the saving.

Change-Id: I22fc54356af50df7a7bd2107fa17f6951d40812f
Reviewed-on: https://gerrit.libreoffice.org/36762
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/wsd/DocumentBroker.cpp b/wsd/DocumentBroker.cpp
index a2b90d50..9cd27989 100644
--- a/wsd/DocumentBroker.cpp
+++ b/wsd/DocumentBroker.cpp
@@ -562,11 +562,12 @@ bool DocumentBroker::saveToStorage(const std::string& 
sessionId,
 
 const bool res = saveToStorageInternal(sessionId, success, result);
 
-// We've saved and can safely destroy this session.
-removeSessionInternal(sessionId);
+// If marked to destroy, or session is disconnected, remove.
+const auto it = _sessions.find(sessionId);
+if (_markToDestroy || (it != _sessions.end() && 
it->second->isCloseFrame()))
+removeSessionInternal(sessionId);
 
 // If marked to destroy, then this was the last session.
-// Otherwise, check that we are (which we might be by now).
 if (_markToDestroy || _sessions.empty())
 {
 // Stop so we get cleaned up and removed.
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: wsd/LOOLWSD.cpp

[Ashod Nakashian]

 wsd/LOOLWSD.cpp |7 +++
 1 file changed, 3 insertions(+), 4 deletions(-)

New commits:
commit 15e13e58f64f6c9f6e5be706c53916649fd73257
Author: Ashod Nakashian 
Date:   Thu Apr 20 23:11:07 2017 -0400

wsd: clear the socket buffer only after processing the request

Because POST requests need to consume the complete
request message, we shouldn't clear the buffer
before handling the POST request.

Change-Id: I53f7b664378dd6614afc6983fdd10d0102b38acf
Reviewed-on: https://gerrit.libreoffice.org/36763
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/wsd/LOOLWSD.cpp b/wsd/LOOLWSD.cpp
index d109e5d2..a0529380 100644
--- a/wsd/LOOLWSD.cpp
+++ b/wsd/LOOLWSD.cpp
@@ -1579,10 +1579,6 @@ private:
 LOG_DBG("Not enough content yet: ContentLength: " << 
contentLength << ", available: " << available);
 return SocketHandlerInterface::SocketOwnership::UNCHANGED;
 }
-
-// if we succeeded - remove the request from our input buffer
-// we expect one request per socket
-in.erase(in.begin(), itBody);
 }
 catch (const std::exception& exc)
 {
@@ -1668,6 +1664,9 @@ private:
 LOOLProtocol::getAbbreviatedMessage(in) << "]: " << 
exc.what());
 }
 
+// if we succeeded - remove the request from our input buffer
+// we expect one request per socket
+in.erase(in.begin(), itBody);
 return socketOwnership;
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: wsd/DocumentBroker.cpp

[Ashod Nakashian]

 wsd/DocumentBroker.cpp |   10 +++---
 1 file changed, 3 insertions(+), 7 deletions(-)

New commits:
commit 874b86ac89e0a6cd456d5dca6dda312ab584d322
Author: Ashod Nakashian 
Date:   Thu Apr 20 23:50:03 2017 -0400

wsd: simplify

Change-Id: I7a16d82d8e9ebb120950fc1d0227ffdbe962d8e8
Reviewed-on: https://gerrit.libreoffice.org/36764
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/wsd/DocumentBroker.cpp b/wsd/DocumentBroker.cpp
index 9cd27989..999cab12 100644
--- a/wsd/DocumentBroker.cpp
+++ b/wsd/DocumentBroker.cpp
@@ -244,14 +244,10 @@ void DocumentBroker::pollThread()
 
 // First copy into local container, since removeSession
 // will erase from _sessions, but will leave the last.
-std::vector sessions;
-for (const auto& pair : _sessions)
-{
-sessions.push_back(pair.second);
-}
-
-for (const std::shared_ptr& session : sessions)
+std::map sessions = 
_sessions;
+for (const auto& pair : sessions)
 {
+std::shared_ptr session = pair.second;
 try
 {
 // Notify the client and disconnect.
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sw/qa

[Patrick Jaap]

 sw/qa/extras/ooxmlimport/data/tdf101627.docx |binary
 sw/qa/extras/ooxmlimport/ooxmlimport.cxx |8 
 2 files changed, 8 insertions(+)

New commits:
commit d862741423cdf0ef228d34b2a25b09c9401be584
Author: Patrick Jaap 
Date:   Thu Apr 20 15:31:18 2017 +0200

tdf#101627 add unit test

unit test for the patch 80b9b6761e8cb974e0cdc0c7be0eb95f8745d86f

Change-Id: I68b7eb686fa52f1851455160e1196f0748935c4c
Reviewed-on: https://gerrit.libreoffice.org/36747
Tested-by: Jenkins 
Reviewed-by: Michael Stahl 

diff --git a/sw/qa/extras/ooxmlimport/data/tdf101627.docx 
b/sw/qa/extras/ooxmlimport/data/tdf101627.docx
new file mode 100644
index ..0a1efd8f4295
Binary files /dev/null and b/sw/qa/extras/ooxmlimport/data/tdf101627.docx differ
diff --git a/sw/qa/extras/ooxmlimport/ooxmlimport.cxx 
b/sw/qa/extras/ooxmlimport/ooxmlimport.cxx
index 2a6bbf49dd05..9154ef1cfa3c 100644
--- a/sw/qa/extras/ooxmlimport/ooxmlimport.cxx
+++ b/sw/qa/extras/ooxmlimport/ooxmlimport.cxx
@@ -1304,6 +1304,14 @@ DECLARE_OOXMLIMPORT_TEST( testTdf106606, 
"tdf106606.docx" )
 CPPUNIT_ASSERT( FindGraphicBitmapPropertyInNumStyle("WWNum2") );
 }
 
+DECLARE_OOXMLIMPORT_TEST(testTdf101627, "tdf101627.docx")
+{
+// Do not shrink the textbox in the footer
+uno::Reference xFrame(getShape(1), uno::UNO_QUERY);
+CPPUNIT_ASSERT(xFrame->getString().startsWith( "1" ) );
+CPPUNIT_ASSERT_EQUAL(sal_Int32(466), getProperty(xFrame, 
"Height"));
+}
+
 // tests should only be added to ooxmlIMPORT *if* they fail round-tripping in 
ooxmlEXPORT
 
 CPPUNIT_PLUGIN_IMPLEMENT();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sal/osl

[Stephan Bergmann]

 sal/osl/unx/system.hxx |6 --
 sal/osl/unx/thread.cxx |5 +++--
 2 files changed, 3 insertions(+), 8 deletions(-)

New commits:
commit 5a155bb75b62f02c8ed16cdafd492b625ce208c0
Author: Stephan Bergmann 
Date:   Thu Apr 20 13:54:01 2017 +0200

Simplify PTHREAD_VALUE

The distinction between MACOSX and other had been introduced with
ed8110e101db5a8ea4dde43a3ec38fe40e6fe7e2 "Avoid reinterpret_cast to same 
type"
to work around a GCC 4.6 bug that is fixed since GCC 4.7.

Change-Id: I7948721d311de2622c1e08e2ee17b5ccc304b51b

diff --git a/sal/osl/unx/system.hxx b/sal/osl/unx/system.hxx
index 78d49c403ddf..a822b0a83a10 100644
--- a/sal/osl/unx/system.hxx
+++ b/sal/osl/unx/system.hxx
@@ -271,12 +271,6 @@ int macxp_resolveAlias(char *path, int buflen);
 #   define  INIT_GROUPS(name, gid)  ((setgid((gid)) == 0) && 
(initgroups((name), (gid)) == 0))
 #endif
 
-#if defined MACOSX
-#define PTHREAD_VALUE(t) reinterpret_cast(t)
-#else
-#define PTHREAD_VALUE(t) ((unsigned long) (t))
-#endif
-
 #ifndef PTHREAD_NONE
 #   define PTHREAD_NONE _pthread_none_
 #   ifndef PTHREAD_NONE_INIT
diff --git a/sal/osl/unx/thread.cxx b/sal/osl/unx/thread.cxx
index 34bf38cde607..e829b91781c6 100644
--- a/sal/osl/unx/thread.cxx
+++ b/sal/osl/unx/thread.cxx
@@ -56,7 +56,8 @@
  * (2) 'oslThreadIdentifier' and '{insert|remove|lookup}ThreadId()'
  * - cannot reliably be applied to 'alien' threads;
  * - memory leak for 'alien' thread 'HashEntry's;
- * - use 'PTHREAD_VALUE(pthread_t)' as identifier instead (?)
+ * - use 'reinterpret_cast(pthread_t)' as identifier
+ *   instead (?)
  * - if yes, change 'oslThreadIdentifier' to 'intptr_t' or similar
  * (3) 'oslSigAlarmHandler()' (#71232#)
  * - [Under Solaris we get SIGALRM in e.g. pthread_join which terminates
@@ -552,7 +553,7 @@ void SAL_CALL osl_setThreadName(char const * name) {
 /* osl_getThreadIdentifier @@@ see TODO @@@ */
 /*/
 
-#define HASHID(x) (PTHREAD_VALUE(x) % HashSize)
+#define HASHID(x) (reinterpret_cast(x) % HashSize)
 
 struct HashEntry
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Minutes of the Design Hangout: 2017-Apr-20

[Heiko Tietze]

Present: Jay, Tomaz, Steve, Heiko

Organization

 * Procedure for tickets needsUXAdvice
   + ux-advice should be added to cc list when the keyword is set but what to 
do when it's removed
   + in order to reduce the number of emails to the ux-advice ML we delete it 
from CC when the keyword is removed
   + silent readers may add themselves to CC

 * Major release update / branding for 6.0
   + OSD job submitted https://github.com/opensourcedesign/jobs/pull/197
   + blog post with invitation prepared, waiting that the job is accepted

Tickets

 * Visual design of tabs
   + https://bugs.documentfoundation.org/show_bug.cgi?id=106323
   + commented on the bug report (Jay)
   + if we improve things it, has to be the generic toolkit

 * Revert selection mode to standard when done
   + https://bugs.documentfoundation.org/show_bug.cgi?id=88474
   + currently when you cancel the selection the mode is reverted from Adding, 
for instance, to standard
   + pro reverting to standard (as today): cancel is not the normal operation 
and mostly users expect it to be reverted
   + con: other tools keep the manually set mode until the user changes it back
   + Microsoft toggles selection mode per alt (block mode) and ctrl (addition) 
(but not in combination)
   + there is an inconsistency between keyboard use that reverts the selection 
and the toolbar/menu, which keeps the mode
   + would prefer the Microsoft way to use only keyboard accelerators (that are 
by nature temporarily) (Heiko)
   + LibreOffice has shortcuts 
https://help.libreoffice.org/Common/Selection_Mode (Jay)
   + We have ctrl/shift/alt + left mouse for the different modes so could 
remove the static switch (Heiko)
   + feedback is needed, e.g. different icons in statusbar (Tomaz), and ideally 
also with the cursor (Jay)
   + decision is to keep the static selection, make it consistent over the UI, 
make it really static and keep it after escape
 but the preferred method is to use the keyboard accelerators

 * Sidebar customization settings not remembered after reopening (Steve)
   + https://bugs.documentfoundation.org/show_bug.cgi?id=67770
   + Fixed?
   + No issue in LibO fresh for sidebar open/closed, shown/hidden 
   + but the active deck is not remembered, which is required for people who 
use it only for styles
   + workaround is to disable the unneeded decks; the first deck is shown by 
default

 * Confirmation for overall actions such as deletion of comments
   + https://bugs.documentfoundation.org/show_bug.cgi?id=78302
   + Do we want to introduce a guideline to confirm actions that affect not 
only the current selection?
   + Yes means to let the user confirm 'delete all comments', for example, No 
means to keep the current behavior
   + better decide about confirmation on the particular situations
   + undo is sufficient in this particular (and most other) topic (Jay)
   => as a general rule, have a confirmation when undo is not possible




signature.asc
Description: OpenPGP digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] online.git: Changes to 'refs/tags/2.1-rc2'

[Andras Timar]

Tag '2.1-rc2' created by Andras Timar  at 
2017-04-20 11:45 +

2.1-rc2

Changes since 2.1-rc1-41:
---
 0 files changed
---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - sw/qa writerfilter/source

[Miklos Vajna]

 sw/qa/extras/rtfimport/data/tdf107116.rtf |   10 ++
 sw/qa/extras/rtfimport/rtfimport.cxx  |6 ++
 writerfilter/source/rtftok/rtfsprm.cxx|   21 -
 3 files changed, 36 insertions(+), 1 deletion(-)

New commits:
commit c8c90854506cc7f1c3d7084ab97c156aead003e2
Author: Miklos Vajna 
Date:   Wed Apr 19 09:08:46 2017 +0200

tdf#107116 RTF import: fix missing upper and lower borders around text

See commit 1be0a3fa9ebb22b607c54b47739d4467acfed259 (n#825305:
writerfilter RTF import: override style properties like Word,
2014-06-17) for the context.

Here the problem was that various details of the top border were removed
during the style deduplication, but not the top border sprm itself. That
was interpreted (correctly) by dmapper as "no border", rather than
"inherit from style".

(cherry picked from commit e9f0d8d02885eca619552b19eab30c1eade9e7ef)

Change-Id: I3dec8df789fc7b75fccfff91ce66f457fecd2f6e
Reviewed-on: https://gerrit.libreoffice.org/36692
Tested-by: Jenkins 
Reviewed-by: Michael Stahl 

diff --git a/sw/qa/extras/rtfimport/data/tdf107116.rtf 
b/sw/qa/extras/rtfimport/data/tdf107116.rtf
new file mode 100644
index ..17c2f5b61a59
--- /dev/null
+++ b/sw/qa/extras/rtfimport/data/tdf107116.rtf
@@ -0,0 +1,10 @@
+{\rtf1\ansi\ansicpg1252\uc1 \deff0\deflang1033\deflangfe1033
+{\colortbl;\red0\green0\blue0;\red0\green0\blue255;\red0\green255\blue255;\red0\green255\blue0;\red255\green0\blue255;\red255\green0\blue0;\red255\green255\blue0;
+\red255\green255\blue255;\red0\green0\blue128;\red0\green128\blue128;\red0\green128\blue0;\red128\green0\blue128;\red128\green0\blue0;\red128\green128\blue0;\red128\green128\blue128;\red192\green192\blue192;}
+{\stylesheet
+{\s15\brdrt\brdrs\brdrw15\brsp120\brdrcf15 
\brdrb\brdrs\brdrw15\brsp120\brdrcf15 \snext15 style;}
+}
+\pard\plain before\par
+\pard\plain \s15\brdrt\brdrs\brdrw15\brsp120\brdrcf15 
\brdrb\brdrs\brdrw15\brsp120\brdrcf15 border \par
+\pard\plain after\par
+}
diff --git a/sw/qa/extras/rtfimport/rtfimport.cxx 
b/sw/qa/extras/rtfimport/rtfimport.cxx
index 8fee2ab2fcd1..ca696d9c84f8 100644
--- a/sw/qa/extras/rtfimport/rtfimport.cxx
+++ b/sw/qa/extras/rtfimport/rtfimport.cxx
@@ -2760,6 +2760,12 @@ DECLARE_RTFIMPORT_TEST(testTdf106694, "tdf106694.rtf")
 CPPUNIT_ASSERT_EQUAL(static_cast(14605), aTabs[0].Position);
 }
 
+DECLARE_RTFIMPORT_TEST(testTdf107116, "tdf107116.rtf")
+{
+// This was 0, upper border around text (and its distance) was missing.
+CPPUNIT_ASSERT_EQUAL(static_cast(convertTwipToMm100(120)), 
getProperty(getParagraph(2), "TopBorderDistance"));
+}
+
 CPPUNIT_PLUGIN_IMPLEMENT();
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/writerfilter/source/rtftok/rtfsprm.cxx 
b/writerfilter/source/rtftok/rtfsprm.cxx
index 7afee14a4189..3f4f6659d2e8 100644
--- a/writerfilter/source/rtftok/rtfsprm.cxx
+++ b/writerfilter/source/rtftok/rtfsprm.cxx
@@ -170,6 +170,23 @@ static bool isSPRMDeduplicateBlacklist(Id nId)
 }
 }
 
+/// Should this SPRM be removed if all its children is removed?
+static bool isSPRMChildrenExpected(Id nId)
+{
+switch (nId)
+{
+case NS_ooxml::LN_CT_PBdr_top:
+case NS_ooxml::LN_CT_PBdr_left:
+case NS_ooxml::LN_CT_PBdr_bottom:
+case NS_ooxml::LN_CT_PBdr_right:
+// Expected children are NS_ooxml::LN_CT_Border_*.
+return true;
+
+default:
+return false;
+}
+}
+
 /// Does the clone / deduplication of a single sprm.
 static void cloneAndDeduplicateSprm(std::pair& rSprm, 
RTFSprms& ret)
 {
@@ -185,7 +202,9 @@ static void cloneAndDeduplicateSprm(std::pair& rSprm, R
 {
 RTFSprms const 
sprms(pValue->getSprms().cloneAndDeduplicate(rSprm.second->getSprms()));
 RTFSprms const 
attributes(pValue->getAttributes().cloneAndDeduplicate(rSprm.second->getAttributes()));
-ret.set(rSprm.first, 
RTFValue::Pointer_t(pValue->CloneWithSprms(attributes, sprms)));
+// Don't copy the sprm in case we expect it to have children but 
it doesn't have some.
+if (!isSPRMChildrenExpected(rSprm.first) || !sprms.empty() || 
!attributes.empty())
+ret.set(rSprm.first, 
RTFValue::Pointer_t(pValue->CloneWithSprms(attributes, sprms)));
 }
 }
 else
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-2-1' - debian/changelog debian/control loolwsd.spec.in

[Andras Timar]

 debian/changelog |6 ++
 debian/control   |2 +-
 loolwsd.spec.in  |4 ++--
 3 files changed, 9 insertions(+), 3 deletions(-)

New commits:
commit 15d152474d79d36b5803d5be7f99cb2886ad3bbb
Author: Andras Timar 
Date:   Thu Apr 20 13:45:02 2017 +0200

Bump package version for 2.1-rc2

Change-Id: Iec3fdefe43bd3fe14e1413ded6717c0531f4f0ff

diff --git a/debian/changelog b/debian/changelog
index 3dd16eb9..22ca4887 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,9 @@
+loolwsd (2.1.0-5) unstable; urgency=medium
+
+  * see the git log: http://col.la/cool21
+
+ -- Andras Timar   Tue, 20 Apr 2017 11:20:00 +0100
+
 loolwsd (2.1.0-4) unstable; urgency=medium
 
   * see the git log: http://col.la/cool21
diff --git a/debian/control b/debian/control
index 5e6f5504..2fb17bf5 100644
--- a/debian/control
+++ b/debian/control
@@ -8,7 +8,7 @@ Standards-Version: 3.9.7
 Package: loolwsd
 Section: web
 Architecture: any
-Depends: ${shlibs:Depends}, ${misc:Depends}, adduser, libsm6, libssl1.0.0, 
libodbc1, libxinerama1, libcairo2, libgl1-mesa-glx, libcups2, libdbus-glib-1-2, 
cpio, collaboraofficebasis5.3-calc (>= 5.3.10.5), collaboraofficebasis5.3-core 
(>= 5.3.10.5), collaboraofficebasis5.3-graphicfilter (>= 5.3.10.5), 
collaboraofficebasis5.3-images (>= 5.3.10.5), collaboraofficebasis5.3-impress 
(>= 5.3.10.5), collaboraofficebasis5.3-ooofonts (>= 5.3.10.5), 
collaboraofficebasis5.3-writer (>= 5.3.10.5), collaboraoffice5.3 (>= 5.3.10.5), 
collaboraoffice5.3-ure (>= 5.3.10.5), collaboraofficebasis5.3-en-us (>= 
5.3.10.5), collaboraofficebasis5.3-en-us-calc (>= 5.3.10.5), 
collaboraofficebasis5.3-en-us-res (>= 5.3.10.5), 
collaboraofficebasis5.3-noto-fonts (>= 5.3.10.5), collaboraofficebasis5.3-draw 
(>= 5.3.10.5), collaboraofficebasis5.3-extension-pdf-import (>= 5.3.10.5)
+Depends: ${shlibs:Depends}, ${misc:Depends}, adduser, libsm6, libssl1.0.0, 
libodbc1, libxinerama1, libcairo2, libgl1-mesa-glx, libcups2, libdbus-glib-1-2, 
cpio, collaboraofficebasis5.3-calc (>= 5.3.10.6), collaboraofficebasis5.3-core 
(>= 5.3.10.6), collaboraofficebasis5.3-graphicfilter (>= 5.3.10.6), 
collaboraofficebasis5.3-images (>= 5.3.10.6), collaboraofficebasis5.3-impress 
(>= 5.3.10.6), collaboraofficebasis5.3-ooofonts (>= 5.3.10.6), 
collaboraofficebasis5.3-writer (>= 5.3.10.6), collaboraoffice5.3 (>= 5.3.10.6), 
collaboraoffice5.3-ure (>= 5.3.10.6), collaboraofficebasis5.3-en-us (>= 
5.3.10.6), collaboraofficebasis5.3-en-us-calc (>= 5.3.10.6), 
collaboraofficebasis5.3-en-us-res (>= 5.3.10.6), 
collaboraofficebasis5.3-noto-fonts (>= 5.3.10.6), collaboraofficebasis5.3-draw 
(>= 5.3.10.6), collaboraofficebasis5.3-extension-pdf-import (>= 5.3.10.6)
 Description: LibreOffice Online WebSocket Daemon
  LOOLWSD is a daemon that talks to web browser clients and provides LibreOffice
  services.
diff --git a/loolwsd.spec.in b/loolwsd.spec.in
index 52428414..619ef52e 100644
--- a/loolwsd.spec.in
+++ b/loolwsd.spec.in
@@ -12,7 +12,7 @@ Name:   loolwsd%{name_suffix}
 Name:   loolwsd
 %endif
 Version:@PACKAGE_VERSION@
-Release:4%{?dist}
+Release:5%{?dist}
 Vendor: Collabora
 Summary:LibreOffice On-Line WebSocket Daemon
 License:MPL
@@ -26,7 +26,7 @@ BuildRequires:  libcap-progs systemd-rpm-macros
 %endif
 %endif
 
-Requires:   collaboraoffice5.3 >= 5.3.10.5 collaboraoffice5.3-ure >= 
5.3.10.5 collaboraofficebasis5.3-core >= 5.3.10.5 
collaboraofficebasis5.3-writer >= 5.3.10.5 collaboraofficebasis5.3-impress >= 
5.3.10.5 collaboraofficebasis5.3-graphicfilter >= 5.3.10.5 
collaboraofficebasis5.3-en-US >= 5.3.10.5 collaboraofficebasis5.3-calc >= 
5.3.10.5 collaboraofficebasis5.3-en-US-res >= 5.3.10.5 
collaboraofficebasis5.3-en-US-calc >= 5.3.10.5 collaboraofficebasis5.3-ooofonts 
>= 5.3.10.5 collaboraofficebasis5.3-images >= 5.3.10.5 
collaboraofficebasis5.3-noto-fonts >= 5.3.10.5 collaboraofficebasis5.3-draw >= 
5.3.10.5 collaboraofficebasis5.3-extension-pdf-import >= 5.3.10.5
+Requires:   collaboraoffice5.3 >= 5.3.10.6 collaboraoffice5.3-ure >= 
5.3.10.6 collaboraofficebasis5.3-core >= 5.3.10.6 
collaboraofficebasis5.3-writer >= 5.3.10.6 collaboraofficebasis5.3-impress >= 
5.3.10.6 collaboraofficebasis5.3-graphicfilter >= 5.3.10.6 
collaboraofficebasis5.3-en-US >= 5.3.10.6 collaboraofficebasis5.3-calc >= 
5.3.10.6 collaboraofficebasis5.3-en-US-res >= 5.3.10.6 
collaboraofficebasis5.3-en-US-calc >= 5.3.10.6 collaboraofficebasis5.3-ooofonts 
>= 5.3.10.6 collaboraofficebasis5.3-images >= 5.3.10.6 
collaboraofficebasis5.3-noto-fonts >= 5.3.10.6 collaboraofficebasis5.3-draw >= 
5.3.10.6 collaboraofficebasis5.3-extension-pdf-import >= 5.3.10.6
 Requires:   systemd
 Requires(post): coreutils grep sed
 %if 0%{?fedora} || 0%{?rhel} >= 7
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org

[Libreoffice-commits] core.git: sc/source

[Eike Rathke]

 sc/source/core/tool/parclass.cxx |2 ++
 1 file changed, 2 insertions(+)

New commits:
commit f0fef88b747cc4f4de7a5ccb93da9c062545dcfb
Author: Eike Rathke 
Date:   Thu Apr 20 13:52:18 2017 +0200

Resolves: tdf#99625 add parameter classification for TEXTJOIN and CONCAT

So in array context the functions return a single string instead of an 
array of
identical strings.

Change-Id: Ia6ada10be4912745b60e281fac1736c560162d3a

diff --git a/sc/source/core/tool/parclass.cxx b/sc/source/core/tool/parclass.cxx
index 2830bdc47b91..7c5ffd3aae99 100644
--- a/sc/source/core/tool/parclass.cxx
+++ b/sc/source/core/tool/parclass.cxx
@@ -80,6 +80,7 @@ const ScParameterClassification::RawData 
ScParameterClassification::pRawData[] =
 { ocCell,{{ Value, Reference   
  }, 0 }},
 { ocColumn,  {{ Reference  
  }, 0 }},
 { ocColumns, {{ Reference  
  }, 1 }},
+{ ocConcat_MS,   {{ Reference  
  }, 1 }},
 { ocCorrel,  {{ ForceArray, ForceArray 
  }, 0 }},
 { ocCount,   {{ Reference  
  }, 1 }},
 { ocCount2,  {{ Reference  
  }, 1 }},
@@ -195,6 +196,7 @@ const ScParameterClassification::RawData 
ScParameterClassification::pRawData[] =
 { ocSumXMY2, {{ ForceArray, ForceArray 
  }, 0 }},
 { ocSheet,   {{ Reference  
  }, 0 }},
 { ocSheets,  {{ Reference  
  }, 1 }},
+{ ocTextJoin_MS, {{ Reference, Value, Reference
  }, 1 }},
 { ocTrend,   {{ Reference, Reference, Reference, Value 
  }, 0 }},
 { ocTrimMean,{{ Reference, Value   
  }, 0 }},
 { ocTTest,   {{ ForceArray, ForceArray, Value, Value   
  }, 0 }},
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: cui/source framework/source include/unotools sfx2/source svtools/source unotools/source

[Noel Grandin]

 cui/source/dialogs/hldocntp.cxx  |2 
 framework/source/uielement/newmenucontroller.cxx |2 
 include/unotools/dynamicmenuoptions.hxx  |7 --
 sfx2/source/appl/shutdowniconaqua.mm |2 
 sfx2/source/appl/shutdowniconunx.cxx |2 
 sfx2/source/appl/shutdowniconw32.cxx |2 
 sfx2/source/dialog/backingwindow.cxx |2 
 svtools/source/config/test/test.cxx  |   20 +++---
 unotools/source/config/dynamicmenuoptions.cxx|   73 +++
 9 files changed, 29 insertions(+), 83 deletions(-)

New commits:
commit b2764a9b66d1bab85256e5f9c3577b994448ce4a
Author: Noel Grandin 
Date:   Thu Apr 20 12:17:30 2017 +0200

convert EDynamicMenuType to scoped enum

and drop unused E_HELPBOOKMARKS

Change-Id: I5756ea326bdc1a99f7d6f1ba43baf6aca9f7f2fc
Reviewed-on: https://gerrit.libreoffice.org/36728
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/cui/source/dialogs/hldocntp.cxx b/cui/source/dialogs/hldocntp.cxx
index 6015ef853ad8..efe4ccc75969 100644
--- a/cui/source/dialogs/hldocntp.cxx
+++ b/cui/source/dialogs/hldocntp.cxx
@@ -166,7 +166,7 @@ void SvxHyperlinkNewDocTp::FillDocumentList ()
 EnterWait();
 
 uno::Sequence< uno::Sequence< beans::PropertyValue > >
-aDynamicMenuEntries( SvtDynamicMenuOptions().GetMenu( E_NEWMENU ) );
+aDynamicMenuEntries( SvtDynamicMenuOptions().GetMenu( 
EDynamicMenuType::NewMenu ) );
 
 sal_uInt32 i, nCount = aDynamicMenuEntries.getLength();
 for ( i = 0; i < nCount; i++ )
diff --git a/framework/source/uielement/newmenucontroller.cxx 
b/framework/source/uielement/newmenucontroller.cxx
index 0d2fa663aeb4..ddc51da96d3b 100644
--- a/framework/source/uielement/newmenucontroller.cxx
+++ b/framework/source/uielement/newmenucontroller.cxx
@@ -322,7 +322,7 @@ void NewMenuController::fillPopupMenu( Reference< 
css::awt::XPopupMenu >& rPopup
 return;
 
 css::uno::Sequence< css::uno::Sequence< css::beans::PropertyValue > > 
aDynamicMenuEntries =
-SvtDynamicMenuOptions().GetMenu( m_bNewMenu ? E_NEWMENU : 
E_WIZARDMENU );
+SvtDynamicMenuOptions().GetMenu( m_bNewMenu ? 
EDynamicMenuType::NewMenu : EDynamicMenuType::WizardMenu );
 
 OUString aTitle;
 OUString aURL;
diff --git a/include/unotools/dynamicmenuoptions.hxx 
b/include/unotools/dynamicmenuoptions.hxx
index a7dfd8b813f2..56ada999fac6 100644
--- a/include/unotools/dynamicmenuoptions.hxx
+++ b/include/unotools/dynamicmenuoptions.hxx
@@ -39,11 +39,10 @@
 
/*-
 @descr  You can use these enum values to specify right menu if you 
call our interface methods.
 
*//*-*/
-enum EDynamicMenuType
+enum class EDynamicMenuType
 {
-E_NEWMENU   =   0,
-E_WIZARDMENU=   1,
-E_HELPBOOKMARKS =   2
+NewMenu   =   0,
+WizardMenu=   1
 };
 
 
/*-
diff --git a/sfx2/source/appl/shutdowniconaqua.mm 
b/sfx2/source/appl/shutdowniconaqua.mm
index cd69b46a70fe..2b082b6457dd 100644
--- a/sfx2/source/appl/shutdowniconaqua.mm
+++ b/sfx2/source/appl/shutdowniconaqua.mm
@@ -408,7 +408,7 @@ void aqua_init_systray()
 SvtModuleOptionsaModuleOptions;
 std::set< rtl::OUString > aFileNewAppsAvailable;
 SvtDynamicMenuOptions aOpt;
-css::uno::Sequence < css::uno::Sequence < 
css::beans::PropertyValue > > aNewMenu = aOpt.GetMenu( E_NEWMENU );
+css::uno::Sequence < css::uno::Sequence < 
css::beans::PropertyValue > > aNewMenu = aOpt.GetMenu( 
EDynamicMenuType::NewMenu );
 
 const css::uno::Sequence< css::beans::PropertyValue >* pNewMenu = 
aNewMenu.getConstArray();
 const css::uno::Sequence< css::beans::PropertyValue >* pNewMenuEnd 
= aNewMenu.getConstArray() + aNewMenu.getLength();
diff --git a/sfx2/source/appl/shutdowniconunx.cxx 
b/sfx2/source/appl/shutdowniconunx.cxx
index 9b5e53f5d544..fd5aa1d069f2 100644
--- a/sfx2/source/appl/shutdowniconunx.cxx
+++ b/sfx2/source/appl/shutdowniconunx.cxx
@@ -155,7 +155,7 @@ static void add_ugly_db_item( GtkMenuShell *pMenuShell, 
const char *pAsciiURL,
   sal_uInt16 nResId, GCallback pFnCallback )
 {
 SvtDynamicMenuOptions aOpt;
-Sequence < Sequence < PropertyValue > > aMenu = aOpt.GetMenu( E_NEWMENU );
+Sequence < Sequence < PropertyValue > > aMenu = aOpt.GetMenu( 
EDynamicMenuType::NewMenu );
 for ( sal_Int32 n=0; n

[Libreoffice-commits] core.git: helpcontent2

[Andras Timar]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 7bcea5c8bae73d289c5203cbc51f70605c3a3599
Author: Andras Timar 
Date:   Thu Apr 20 10:14:41 2017 +0200

Updated core
Project: help  1b5413f89863008ab15c2233506298e1a657f421

HID bookmark is not localizable

Change-Id: Iae1909e7afc7504fb53f8fa3d861419a3415ea25

diff --git a/helpcontent2 b/helpcontent2
index 9ed1958ba7f7..1b5413f89863 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 9ed1958ba7f75bb4184f09d79814849d06313d72
+Subproject commit 1b5413f89863008ab15c2233506298e1a657f421
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] help.git: source/text

[Andras Timar]

 source/text/shared/01/06140400.xhp |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 1b5413f89863008ab15c2233506298e1a657f421
Author: Andras Timar 
Date:   Thu Apr 20 10:14:41 2017 +0200

HID bookmark is not localizable

Change-Id: Iae1909e7afc7504fb53f8fa3d861419a3415ea25

diff --git a/source/text/shared/01/06140400.xhp 
b/source/text/shared/01/06140400.xhp
index 141e950e9..cdd7a1766 100644
--- a/source/text/shared/01/06140400.xhp
+++ b/source/text/shared/01/06140400.xhp
@@ -93,7 +93,7 @@
 Add Command
 Opens the Add Commands dialog. Select any command, 
then click Add to insert the command into the 
Customize dialog.
 
-
+
 Add 
Separator
 Inserts a separator line under the current toolbar 
entry.
 
@@ -128,7 +128,7 @@
 
 
 Description
-Displays a short description of the given command. 
+Displays a short description of the given command.
 For this feature 
to work the help content package for the currently used language must be 
installed.
 
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-2-1' - loleaflet/src

[Henry Castro]

 loleaflet/src/layer/AnnotationManager.js |3 ++-
 loleaflet/src/layer/marker/Annotation.js |   13 -
 loleaflet/src/layer/tile/CalcTileLayer.js|3 ++-
 loleaflet/src/layer/tile/ImpressTileLayer.js |2 +-
 4 files changed, 13 insertions(+), 8 deletions(-)

New commits:
commit 3a525c70c0a780a65b6488950a96b7f2b4bc1387
Author: Henry Castro 
Date:   Wed Apr 19 21:11:28 2017 -0400

loleaflet: add option no menu when insert new annotation

Change-Id: I0950c743f9443f85674fb087c44c8fe942bcc322
Reviewed-on: https://gerrit.libreoffice.org/36708
Reviewed-by: Jan Holesovsky 
Tested-by: Jan Holesovsky 

diff --git a/loleaflet/src/layer/AnnotationManager.js 
b/loleaflet/src/layer/AnnotationManager.js
index 54f3496b..05ad8416 100644
--- a/loleaflet/src/layer/AnnotationManager.js
+++ b/loleaflet/src/layer/AnnotationManager.js
@@ -365,7 +365,8 @@ L.AnnotationManager = L.Class.extend({
},
 
add: function (comment) {
-   var annotation = 
L.annotation(this._map.options.maxBounds.getSouthEast(), 
comment).addTo(this._map);
+   var annotation = 
L.annotation(this._map.options.maxBounds.getSouthEast(), comment,
+   comment.id === 'new' ? {noMenu: true} : 
{}).addTo(this._map);
if (comment.parent && comment.parent > '0') {
var parentIdx = this.getIndexOf(comment.parent);
this._items.splice(parentIdx + 1, 0, annotation);
diff --git a/loleaflet/src/layer/marker/Annotation.js 
b/loleaflet/src/layer/marker/Annotation.js
index 97b2d8e9..abed0b01 100644
--- a/loleaflet/src/layer/marker/Annotation.js
+++ b/loleaflet/src/layer/marker/Annotation.js
@@ -6,7 +6,8 @@ L.Annotation = L.Layer.extend({
options: {
minWidth: 160,
maxHeight: 50,
-   imgSize: L.point([32, 32])
+   imgSize: L.point([32, 32]),
+   noMenu: false
},
 
initialize: function (latlng, data, options) {
@@ -167,10 +168,12 @@ L.Annotation = L.Layer.extend({
}, this);
}
 
-   var tdMenu = L.DomUtil.create(tagTd, 
'loleaflet-annotation-menubar', tr);
-   var divMenu = L.DomUtil.create(tagDiv, this._data.trackchange ? 
'loleaflet-annotation-menu-redline' : 'loleaflet-annotation-menu', tdMenu);
-   divMenu.title = _('Open menu');
-   divMenu.annotation = this;
+   if (this.options.noMenu !== true) {
+   var tdMenu = L.DomUtil.create(tagTd, 
'loleaflet-annotation-menubar', tr);
+   var divMenu = L.DomUtil.create(tagDiv, 
this._data.trackchange ? 'loleaflet-annotation-menu-redline' : 
'loleaflet-annotation-menu', tdMenu);
+   divMenu.title = _('Open menu');
+   divMenu.annotation = this;
+   }
if (this._data.trackchange) {
this._captionNode = L.DomUtil.create(tagDiv, 
'loleaflet-annotation-caption', wrapper);
this._captionText = L.DomUtil.create(tagDiv, empty, 
this._captionNode);
diff --git a/loleaflet/src/layer/tile/CalcTileLayer.js 
b/loleaflet/src/layer/tile/CalcTileLayer.js
index d0e300bf..80c009d4 100644
--- a/loleaflet/src/layer/tile/CalcTileLayer.js
+++ b/loleaflet/src/layer/tile/CalcTileLayer.js
@@ -32,7 +32,8 @@ L.CalcTileLayer = L.TileLayer.extend({
},
 
createAnnotation: function (comment) {
-   var annotation = 
L.divOverlay(comment.cellPos).bindAnnotation(L.annotation(L.latLng(0, 0), 
comment));
+   var annotation = 
L.divOverlay(comment.cellPos).bindAnnotation(L.annotation(L.latLng(0, 0),
+   comment, comment.id === 'new' ? {noMenu: true} : {}));
annotation.mark = L.marker(comment.cellPos.getNorthEast(), {
draggable: false,
clickable: false,
diff --git a/loleaflet/src/layer/tile/ImpressTileLayer.js 
b/loleaflet/src/layer/tile/ImpressTileLayer.js
index 09f8707f..859ef679 100644
--- a/loleaflet/src/layer/tile/ImpressTileLayer.js
+++ b/loleaflet/src/layer/tile/ImpressTileLayer.js
@@ -6,7 +6,7 @@
 L.ImpressTileLayer = L.TileLayer.extend({
 
newAnnotation: function (comment) {
-   var annotation = L.annotation(this._map.getCenter(), 
comment).addTo(this._map);
+   var annotation = L.annotation(this._map.getCenter(), comment, 
{noMenu: true}).addTo(this._map);
annotation.edit();
annotation.focus();
},
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-2-1' - 2 commits - loleaflet/src wsd/ClientSession.cpp wsd/ClientSession.hpp wsd/DocumentBroker.cpp

[Ashod Nakashian]

 loleaflet/src/control/Control.ContextMenu.js |4 +---
 wsd/ClientSession.cpp|4 +++-
 wsd/ClientSession.hpp|   10 +-
 wsd/DocumentBroker.cpp   |1 +
 4 files changed, 14 insertions(+), 5 deletions(-)

New commits:
commit c1dbc3a117ef77557db10c98a9d5ca43bb2065f6
Author: Ashod Nakashian 
Date:   Thu Apr 20 00:08:13 2017 -0400

wsd: rely only on loaded sessions for saving

If a session is not loaded, it might never
do so. We should skip them when deciding
whether to save using a disconnecting
session or rely on another.

This is to avoid failing to save when
the remaining sessions never really load
the document at all, and are therefore useless.

Change-Id: I4e7127e12960a31e9f66e835bb63fb2347390711
Reviewed-on: https://gerrit.libreoffice.org/36710
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 
(cherry picked from commit f326a058d41f6a0cc334f8458d98ca68cc40f189)
Reviewed-on: https://gerrit.libreoffice.org/36713
Reviewed-by: Jan Holesovsky 
Tested-by: Jan Holesovsky 

diff --git a/wsd/ClientSession.cpp b/wsd/ClientSession.cpp
index 414f8b94..8be60603 100644
--- a/wsd/ClientSession.cpp
+++ b/wsd/ClientSession.cpp
@@ -37,7 +37,8 @@ ClientSession::ClientSession(const std::string& id,
 _docBroker(docBroker),
 _uriPublic(uriPublic),
 _isDocumentOwner(false),
-_isAttached(false)
+_isAttached(false),
+_isLoaded(false)
 {
 const size_t curConnections = ++LOOLWSD::NumConnections;
 LOG_INF("ClientSession ctor [" << getName() << "], current number of 
connections: " << curConnections);
@@ -631,6 +632,7 @@ bool ClientSession::handleKitToClientMessage(const char* 
buffer, const int lengt
 }
 else if (tokens[0] == "status:")
 {
+setLoaded();
 docBroker->setLoaded();
 
 // Forward the status response to the client.
diff --git a/wsd/ClientSession.hpp b/wsd/ClientSession.hpp
index 9cd67533..58ca0bb0 100644
--- a/wsd/ClientSession.hpp
+++ b/wsd/ClientSession.hpp
@@ -34,10 +34,14 @@ public:
 
 void setReadOnly() override;
 
-/// Returns true if a document is loaded (i.e. we got status message).
+/// Returns true if this session is added to a DocBroker.
 bool isAttached() const { return _isAttached; }
 void setAttached() { _isAttached = true; }
 
+/// Returns true if this session has loaded a view (i.e. we got status 
message).
+bool isLoaded() const { return _isLoaded; }
+void setLoaded() { _isLoaded = true; }
+
 const std::string getUserId() const { return _userId; }
 void setUserId(const std::string& userId) { _userId = userId; }
 void setUserName(const std::string& userName) { _userName = userName; }
@@ -139,8 +143,12 @@ private:
 /// The socket to which the converted (saveas) doc is sent.
 std::shared_ptr _saveAsSocket;
 
+/// If we are added to a DocBroker.
 bool _isAttached;
 
+/// If we have loaded a view.
+bool _isLoaded;
+
 /// Wopi FileInfo object
 std::unique_ptr _wopiFileInfo;
 
diff --git a/wsd/DocumentBroker.cpp b/wsd/DocumentBroker.cpp
index 1afd30f0..0c60326d 100644
--- a/wsd/DocumentBroker.cpp
+++ b/wsd/DocumentBroker.cpp
@@ -1216,6 +1216,7 @@ void DocumentBroker::destroyIfLastEditor(const 
std::string& id)
 for (const auto& it : _sessions)
 {
 if (it.second->getId() != id &&
+it.second->isLoaded() &&
 !it.second->isReadOnly())
 {
 // Found another editable.
commit e51611f289ecbc64813dc019b2a9e015d6fa0a6a
Author: Henry Castro 
Date:   Wed Apr 19 20:14:00 2017 -0400

loleaflet: remove unnecessary spreadsheet context menu items

It is replaced by interactive client side annotations

Change-Id: Ib21926bea1cf125c82b9254c536d70ec94d95f91
Reviewed-on: https://gerrit.libreoffice.org/36706
Reviewed-by: Jan Holesovsky 
Tested-by: Jan Holesovsky 

diff --git a/loleaflet/src/control/Control.ContextMenu.js 
b/loleaflet/src/control/Control.ContextMenu.js
index 4961f892..70f726f9 100644
--- a/loleaflet/src/control/Control.ContextMenu.js
+++ b/loleaflet/src/control/Control.ContextMenu.js
@@ -35,9 +35,7 @@ L.Control.ContextMenu = L.Control.extend({
   'UpdateCurIndex','RemoveTableOf',
   'ReplyComment', 'DeleteComment', 
'DeleteAuthor', 'DeleteAllNotes'],
 
-   spreadsheet: ['MergeCells', 'SplitCells',
- 'InsertAnnotation', 
'EditAnnotation', 'DeleteNote', 'ShowNote', 'HideNote',
- 'RecalcPivotTable'],
+  

[Libreoffice-commits] core.git: sw/qa writerfilter/source

[Miklos Vajna]

 sw/qa/extras/ooxmlexport/data/tdf106690-cell.docx|binary
 sw/qa/extras/ooxmlexport/ooxmlexport9.cxx|   12 
 writerfilter/source/dmapper/DomainMapperTableHandler.cxx |5 +
 writerfilter/source/dmapper/DomainMapperTableHandler.hxx |2 ++
 writerfilter/source/dmapper/DomainMapper_Impl.cxx|5 +
 writerfilter/source/dmapper/DomainMapper_Impl.hxx|4 
 writerfilter/source/dmapper/TableManager.cxx |4 
 7 files changed, 32 insertions(+)

New commits:
commit 41bc9d4d467495c9fbf05c920a41fa299ac0ace3
Author: Miklos Vajna 
Date:   Thu Apr 20 09:12:36 2017 +0200

Related: tdf#106690 DOCX import: don't reduce auto-space accross cells

As suggested at , and it
indeed matches the Word behavior.

Change-Id: I1ba5b70fc5a7acab52fa4baf816e9f6cd2f913ba
Reviewed-on: https://gerrit.libreoffice.org/36719
Reviewed-by: Miklos Vajna 
Tested-by: Jenkins 

diff --git a/sw/qa/extras/ooxmlexport/data/tdf106690-cell.docx 
b/sw/qa/extras/ooxmlexport/data/tdf106690-cell.docx
new file mode 100644
index ..e2ea6f4b0931
Binary files /dev/null and b/sw/qa/extras/ooxmlexport/data/tdf106690-cell.docx 
differ
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport9.cxx 
b/sw/qa/extras/ooxmlexport/ooxmlexport9.cxx
index a7d53cf39661..3311f1b68184 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport9.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport9.cxx
@@ -70,6 +70,18 @@ DECLARE_OOXMLEXPORT_TEST(testTdf106690, "tdf106690.docx")
 CPPUNIT_ASSERT_EQUAL(static_cast(494), 
getProperty(getParagraph(2), "ParaTopMargin"));
 }
 
+DECLARE_OOXMLEXPORT_TEST(testTdf106690Cell, "tdf106690-cell.docx")
+{
+uno::Reference xTablesSupplier(mxComponent, 
uno::UNO_QUERY);
+uno::Reference 
xTables(xTablesSupplier->getTextTables(), uno::UNO_QUERY);
+uno::Reference xTable(xTables->getByIndex(0), 
uno::UNO_QUERY);
+uno::Reference xCell(xTable->getCellByName("A1"), 
uno::UNO_QUERY);
+// This was 0, bottom margin of the second paragraph in the A1 table cell
+// had a reduced auto-space, just because of a next paragraph in the A2
+// cell.
+CPPUNIT_ASSERT_EQUAL(static_cast(494), 
getProperty(getParagraphOfText(2, xCell->getText()), 
"ParaBottomMargin"));
+}
+
 DECLARE_OOXMLEXPORT_TEST(testTdf106970, "tdf106970.docx")
 {
 // The second paragraph (first numbered one) had 0 bottom margin:
diff --git a/writerfilter/source/dmapper/DomainMapperTableHandler.cxx 
b/writerfilter/source/dmapper/DomainMapperTableHandler.cxx
index 8fa604a3710c..b79a1d71214b 100644
--- a/writerfilter/source/dmapper/DomainMapperTableHandler.cxx
+++ b/writerfilter/source/dmapper/DomainMapperTableHandler.cxx
@@ -1266,6 +1266,11 @@ void DomainMapperTableHandler::setHadFootOrEndnote(bool 
bHadFootOrEndnote)
 m_bHadFootOrEndnote = bHadFootOrEndnote;
 }
 
+DomainMapper_Impl& DomainMapperTableHandler::getDomainMapperImpl()
+{
+return m_rDMapper_Impl;
+}
+
 }}
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/writerfilter/source/dmapper/DomainMapperTableHandler.hxx 
b/writerfilter/source/dmapper/DomainMapperTableHandler.hxx
index 83dafa49a776..4881f37a8d9d 100644
--- a/writerfilter/source/dmapper/DomainMapperTableHandler.hxx
+++ b/writerfilter/source/dmapper/DomainMapperTableHandler.hxx
@@ -116,6 +116,8 @@ public:
 void endCell(const css::uno::Reference< css::text::XTextRange > & end);
 
 void setHadFootOrEndnote(bool bHadFootOrEndnote);
+
+DomainMapper_Impl& getDomainMapperImpl();
 };
 
 }}
diff --git a/writerfilter/source/dmapper/DomainMapper_Impl.cxx 
b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
index c9369de68e31..912bb6672977 100644
--- a/writerfilter/source/dmapper/DomainMapper_Impl.cxx
+++ b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
@@ -2181,6 +2181,11 @@ bool DomainMapper_Impl::IsDiscardHeaderFooter()
 return m_bDiscardHeaderFooter;
 }
 
+void DomainMapper_Impl::ClearPreviousParagraph()
+{
+m_xPreviousParagraph.clear();
+}
+
 sal_Int16 lcl_ParseNumberingType( const OUString& rCommand )
 {
 sal_Int16 nRet = style::NumberingType::PAGE_DESCRIPTOR;
diff --git a/writerfilter/source/dmapper/DomainMapper_Impl.hxx 
b/writerfilter/source/dmapper/DomainMapper_Impl.hxx
index 82547b14325b..de7c95dda550 100644
--- a/writerfilter/source/dmapper/DomainMapper_Impl.hxx
+++ b/writerfilter/source/dmapper/DomainMapper_Impl.hxx
@@ -882,6 +882,10 @@ public:
 
 void SetParaAutoBefore(bool bParaAutoBefore) { m_bParaAutoBefore = 
bParaAutoBefore; }
 
+/// Forget about the previous paragraph, as it's not inside the same
+/// start/end node.
+void ClearPreviousParagraph();
+
 private:
 void PushPageHeaderFooter(bool bHeader, SectionPropertyMap::PageType 
eType);
 std::vector > 
m_vTextFramesForChaining ;
diff --git 

[Libreoffice-commits] online.git: loleaflet/Makefile.am

[Andras Timar]

 loleaflet/Makefile.am |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit c38e5de273584a978764dd736967bd131034e319
Author: Andras Timar 
Date:   Thu Apr 20 10:58:25 2017 +0200

loleaflet: without quotes the target file name was truncated at 
'ui-bg_highlight-soft_'

Change-Id: I0f7ffb0babf4295a48e1684a24bb24a0fd7ab8f4
Reviewed-on: https://gerrit.libreoffice.org/36725
Reviewed-by: Andras Timar 
Tested-by: Andras Timar 

diff --git a/loleaflet/Makefile.am b/loleaflet/Makefile.am
index a2d4a617..4a8bd92a 100644
--- a/loleaflet/Makefile.am
+++ b/loleaflet/Makefile.am
@@ -41,7 +41,7 @@ dist-hook: build-l10n
mv po/styles/*.json $(distdir)/dist/l10n/styles/
 
mkdir -p 
$(distdir)/dist/node_modules/jquery-ui/themes/ui-lightness/images/
-   cp -a 
node_modules/jquery-ui/themes/ui-lightness/images/ui-bg_highlight-soft_100_ee_1x100.png
 $(distdir)/dist/node_modules/jquery-ui/themes/ui-lightness/images/
+   cp -a 
"node_modules/jquery-ui/themes/ui-lightness/images/ui-bg_highlight-soft_100_ee_1x100.png"
 $(distdir)/dist/node_modules/jquery-ui/themes/ui-lightness/images/
 
 pot:
xgettext --from-code=UTF-8 --keyword=_ 
--output=po/templates/loleaflet-ui.pot \
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loleaflet/po

[Andras Timar]

 loleaflet/po/help-ab.po|4 
 loleaflet/po/help-af.po|4 
 loleaflet/po/help-am.po|  108 --
 loleaflet/po/help-an.po|4 
 loleaflet/po/help-ar.po|  244 +++---
 loleaflet/po/help-as.po|4 
 loleaflet/po/help-ast.po   |4 
 loleaflet/po/help-az.po|4 
 loleaflet/po/help-be.po|4 
 loleaflet/po/help-bg.po|4 
 loleaflet/po/help-bn.po|4 
 loleaflet/po/help-bn_IN.po |4 
 loleaflet/po/help-bo.po|4 
 loleaflet/po/help-br.po|4 
 loleaflet/po/help-brx.po   |4 
 loleaflet/po/help-bs.po|4 
 loleaflet/po/help-ca.po|4 
 loleaflet/po/help-cs.po|   96 --
 loleaflet/po/help-cy.po|   96 --
 loleaflet/po/help-da.po|   29 
 loleaflet/po/help-de.po|4 
 loleaflet/po/help-dgo.po   |4 
 loleaflet/po/help-dz.po|4 
 loleaflet/po/help-el.po|4 
 loleaflet/po/help-en_GB.po |   83 --
 loleaflet/po/help-en_ZA.po |4 
 loleaflet/po/help-eo.po|   96 --
 loleaflet/po/help-es.po|4 
 loleaflet/po/help-et.po|4 
 loleaflet/po/help-eu.po|  104 --
 loleaflet/po/help-fa.po|4 
 loleaflet/po/help-fi.po|4 
 loleaflet/po/help-fr.po|4 
 loleaflet/po/help-ga.po|4 
 loleaflet/po/help-gd.po|   96 --
 loleaflet/po/help-gl.po|  162 +---
 loleaflet/po/help-gu.po|4 
 loleaflet/po/help-gug.po   |4 
 loleaflet/po/help-he.po|   48 -
 loleaflet/po/help-hi.po|4 
 loleaflet/po/help-hr.po|  185 +---
 loleaflet/po/help-hu.po|4 
 loleaflet/po/help-id.po|4 
 loleaflet/po/help-is.po|   94 --
 loleaflet/po/help-it.po|8 
 loleaflet/po/help-ja.po|4 
 loleaflet/po/help-jv.po|4 
 loleaflet/po/help-ka.po|4 
 loleaflet/po/help-kk.po|   15 
 loleaflet/po/help-kl.po|4 
 loleaflet/po/help-km.po|4 
 loleaflet/po/help-kn.po|4 
 loleaflet/po/help-ko.po|4 
 loleaflet/po/help-kok.po   |4 
 loleaflet/po/help-ks.po|4 
 loleaflet/po/help-ky.po|4 
 loleaflet/po/help-lb.po|4 
 loleaflet/po/help-lo.po|4 
 loleaflet/po/help-lt.po|4 
 loleaflet/po/help-lv.po|   34 
 loleaflet/po/help-mai.po   |4 
 loleaflet/po/help-mk.po|4 
 loleaflet/po/help-ml.po|4 
 loleaflet/po/help-mn.po|4 
 loleaflet/po/help-mni.po   |4 
 loleaflet/po/help-mr.po|4 
 loleaflet/po/help-my.po|4 
 loleaflet/po/help-nb.po|  120 ---
 loleaflet/po/help-ne.po|   10 
 loleaflet/po/help-nl.po|  122 ---
 loleaflet/po/help-nn.po|  243 --
 loleaflet/po/help-nr.po|4 
 loleaflet/po/help-nso.po   |4 
 loleaflet/po/help-oc.po|  183 +---
 loleaflet/po/help-om.po|4 
 loleaflet/po/help-or.po|4 
 loleaflet/po/help-pa_IN.po |4 
 loleaflet/po/help-pl.po|4 
 loleaflet/po/help-pt.po|   94 --
 loleaflet/po/help-pt_BR.po |4 
 loleaflet/po/help-ro.po|   94 --
 loleaflet/po/help-ru.po|   94 --
 loleaflet/po/help-rw.po|4 
 loleaflet/po/help-sa_IN.po |4 
 loleaflet/po/help-sah.po   |4 
 loleaflet/po/help-sat.po   |4 
 loleaflet/po/help-sd.po|4 
 loleaflet/po/help-si.po|4 
 loleaflet/po/help-sid.po   |4 
 loleaflet/po/help-sk.po|   92 --
 loleaflet/po/help-sq.po|4 
 loleaflet/po/help-ss.po|4 
 loleaflet/po/help-st.po|4 
 loleaflet/po/help-sv.po|   94 --
 loleaflet/po/help-sw_TZ.po |4 
 loleaflet/po/help-ta.po|4 
 loleaflet/po/help-te.po|4 
 loleaflet/po/help-tg.po|4 
 loleaflet/po/help-th.po|4 
 loleaflet/po/help-ti.po|4 
 loleaflet/po/help-tn.po|4 
 loleaflet/po/help-tr.po|4 
 loleaflet/po/help-ts.po|4 
 loleaflet/po/help-tt.po|4 
 loleaflet/po/help-ug.po|4 
 loleaflet/po/help-uk.po|4 
 loleaflet/po/help-ur.po|4 
 loleaflet/po/help-uz.po|  200 +
 loleaflet/po/help-ve.po|4 
 loleaflet/po/help-vi.po|4 
 loleaflet/po/help-xh.po|4 
 loleaflet/po/help-zh_CN.po |  140 ---
 loleaflet/po/help-zh_TW.po |  104 --
 loleaflet/po/help-zu.po|4 
 loleaflet/po/ui-ab.po  |  779 +++
 loleaflet/po/ui-af.po  |  779 +++
 loleaflet/po/ui-am.po  |  792 +++-
 loleaflet/po/ui-an.po  |  779 +++
 loleaflet/po/ui-ar.po  | 1000 ++---
 loleaflet/po/ui-as.po  |  779 +++
 loleaflet/po/ui-ast.po |  779 +++
 loleaflet/po/ui-az.po  |  779 +++
 loleaflet/po/ui-be.po  |  779 +++
 loleaflet/po/ui-bg.po  |  779 +++
 loleaflet/po/ui-bn.po  |  779 +++
 loleaflet/po/ui-bn_IN.po   |  540 -
 loleaflet/po/ui-bo.po  |  779 +++
 loleaflet/po/ui-br.po  |  779 +++
 loleaflet/po/ui-brx.po |  779 +++
 

[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-2-1' - loleaflet/src

[Pranav Kant]

 loleaflet/src/layer/AnnotationManager.js |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit b51d26720c7aa318e2850fbbe37dd1c1f0df2354
Author: Pranav Kant 
Date:   Thu Apr 20 12:39:43 2017 +0530

Surely, it is supposed to be update, not upate

Change-Id: I5d576ec0ae6976cb915b1c458546bbf82bf9fe8f
(cherry picked from commit 702bcdcf8d178fd8e82dafbcc6e9c41b5a55d4c9)
Reviewed-on: https://gerrit.libreoffice.org/36723
Reviewed-by: Jan Holesovsky 
Tested-by: Jan Holesovsky 

diff --git a/loleaflet/src/layer/AnnotationManager.js 
b/loleaflet/src/layer/AnnotationManager.js
index 05ad8416..e739930d 100644
--- a/loleaflet/src/layer/AnnotationManager.js
+++ b/loleaflet/src/layer/AnnotationManager.js
@@ -116,7 +116,7 @@ L.AnnotationManager = L.Class.extend({

this._items.push(L.annotation(this._map.options.maxBounds.getSouthEast(), 
changecomment).addTo(this._map));
}
if (this._items.length > 0) {
-   this._map._docLayer._upateMaxBounds(true);
+   this._map._docLayer._updateMaxBounds(true);
this.layout();
}
},
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/source

[Pranav Kant]

 sc/source/core/data/column2.cxx |2 ++
 1 file changed, 2 insertions(+)

New commits:
commit 2373babc6888e840d44ed2db80567acccb9ba993
Author: Pranav Kant 
Date:   Thu Apr 20 14:43:44 2017 +0530

sc lok: Notify when comment is added to destination doc

This can happen, for example, when undoing a deleted comment.

Change-Id: I4aff244f1263b650457a70334f5f4d2c75ad3b64

diff --git a/sc/source/core/data/column2.cxx b/sc/source/core/data/column2.cxx
index 553a72ed91be..e846e381d250 100644
--- a/sc/source/core/data/column2.cxx
+++ b/sc/source/core/data/column2.cxx
@@ -1784,6 +1784,8 @@ public:
 ScAddress aSrcPos(mnSrcCol, nRow, mnSrcTab);
 ScAddress aDestPos(mnDestCol, nDestRow, mnDestTab);
 miPos = mrDestNotes.set(miPos, nDestRow, p->Clone(aSrcPos, 
mrDestCol.GetDoc(), aDestPos, mbCloneCaption));
+// Notify our LOK clients also
+ScDocShell::LOKCommentNotify(LOKCommentNotificationType::Add, 
(), aDestPos, p);
 }
 };
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-2-1' - loleaflet/po

[Andras Timar]

 loleaflet/po/help-ab.po|4 
 loleaflet/po/help-af.po|4 
 loleaflet/po/help-am.po|  108 --
 loleaflet/po/help-an.po|4 
 loleaflet/po/help-ar.po|  244 +++---
 loleaflet/po/help-as.po|4 
 loleaflet/po/help-ast.po   |4 
 loleaflet/po/help-az.po|4 
 loleaflet/po/help-be.po|4 
 loleaflet/po/help-bg.po|4 
 loleaflet/po/help-bn.po|4 
 loleaflet/po/help-bn_IN.po |4 
 loleaflet/po/help-bo.po|4 
 loleaflet/po/help-br.po|4 
 loleaflet/po/help-brx.po   |4 
 loleaflet/po/help-bs.po|4 
 loleaflet/po/help-ca.po|4 
 loleaflet/po/help-cs.po|   96 --
 loleaflet/po/help-cy.po|   96 --
 loleaflet/po/help-da.po|   29 
 loleaflet/po/help-de.po|4 
 loleaflet/po/help-dgo.po   |4 
 loleaflet/po/help-dz.po|4 
 loleaflet/po/help-el.po|4 
 loleaflet/po/help-en_GB.po |   83 --
 loleaflet/po/help-en_ZA.po |4 
 loleaflet/po/help-eo.po|   96 --
 loleaflet/po/help-es.po|4 
 loleaflet/po/help-et.po|4 
 loleaflet/po/help-eu.po|  104 --
 loleaflet/po/help-fa.po|4 
 loleaflet/po/help-fi.po|4 
 loleaflet/po/help-fr.po|4 
 loleaflet/po/help-ga.po|4 
 loleaflet/po/help-gd.po|   96 --
 loleaflet/po/help-gl.po|  162 +---
 loleaflet/po/help-gu.po|4 
 loleaflet/po/help-gug.po   |4 
 loleaflet/po/help-he.po|   48 -
 loleaflet/po/help-hi.po|4 
 loleaflet/po/help-hr.po|  185 +---
 loleaflet/po/help-hu.po|4 
 loleaflet/po/help-id.po|4 
 loleaflet/po/help-is.po|   94 --
 loleaflet/po/help-it.po|8 
 loleaflet/po/help-ja.po|4 
 loleaflet/po/help-jv.po|4 
 loleaflet/po/help-ka.po|4 
 loleaflet/po/help-kk.po|   15 
 loleaflet/po/help-kl.po|4 
 loleaflet/po/help-km.po|4 
 loleaflet/po/help-kn.po|4 
 loleaflet/po/help-ko.po|4 
 loleaflet/po/help-kok.po   |4 
 loleaflet/po/help-ks.po|4 
 loleaflet/po/help-ky.po|4 
 loleaflet/po/help-lb.po|4 
 loleaflet/po/help-lo.po|4 
 loleaflet/po/help-lt.po|4 
 loleaflet/po/help-lv.po|   34 
 loleaflet/po/help-mai.po   |4 
 loleaflet/po/help-mk.po|4 
 loleaflet/po/help-ml.po|4 
 loleaflet/po/help-mn.po|4 
 loleaflet/po/help-mni.po   |4 
 loleaflet/po/help-mr.po|4 
 loleaflet/po/help-my.po|4 
 loleaflet/po/help-nb.po|  120 ---
 loleaflet/po/help-ne.po|   10 
 loleaflet/po/help-nl.po|  122 ---
 loleaflet/po/help-nn.po|  243 --
 loleaflet/po/help-nr.po|4 
 loleaflet/po/help-nso.po   |4 
 loleaflet/po/help-oc.po|  183 +---
 loleaflet/po/help-om.po|4 
 loleaflet/po/help-or.po|4 
 loleaflet/po/help-pa_IN.po |4 
 loleaflet/po/help-pl.po|4 
 loleaflet/po/help-pt.po|   94 --
 loleaflet/po/help-pt_BR.po |4 
 loleaflet/po/help-ro.po|   94 --
 loleaflet/po/help-ru.po|   94 --
 loleaflet/po/help-rw.po|4 
 loleaflet/po/help-sa_IN.po |4 
 loleaflet/po/help-sah.po   |4 
 loleaflet/po/help-sat.po   |4 
 loleaflet/po/help-sd.po|4 
 loleaflet/po/help-si.po|4 
 loleaflet/po/help-sid.po   |4 
 loleaflet/po/help-sk.po|   92 --
 loleaflet/po/help-sq.po|4 
 loleaflet/po/help-ss.po|4 
 loleaflet/po/help-st.po|4 
 loleaflet/po/help-sv.po|   94 --
 loleaflet/po/help-sw_TZ.po |4 
 loleaflet/po/help-ta.po|4 
 loleaflet/po/help-te.po|4 
 loleaflet/po/help-tg.po|4 
 loleaflet/po/help-th.po|4 
 loleaflet/po/help-ti.po|4 
 loleaflet/po/help-tn.po|4 
 loleaflet/po/help-tr.po|4 
 loleaflet/po/help-ts.po|4 
 loleaflet/po/help-tt.po|4 
 loleaflet/po/help-ug.po|4 
 loleaflet/po/help-uk.po|4 
 loleaflet/po/help-ur.po|4 
 loleaflet/po/help-uz.po|  200 +
 loleaflet/po/help-ve.po|4 
 loleaflet/po/help-vi.po|4 
 loleaflet/po/help-xh.po|4 
 loleaflet/po/help-zh_CN.po |  140 ---
 loleaflet/po/help-zh_TW.po |  104 --
 loleaflet/po/help-zu.po|4 
 loleaflet/po/ui-ab.po  |  779 +++
 loleaflet/po/ui-af.po  |  779 +++
 loleaflet/po/ui-am.po  |  792 +++-
 loleaflet/po/ui-an.po  |  779 +++
 loleaflet/po/ui-ar.po  | 1000 ++---
 loleaflet/po/ui-as.po  |  779 +++
 loleaflet/po/ui-ast.po |  779 +++
 loleaflet/po/ui-az.po  |  779 +++
 loleaflet/po/ui-be.po  |  779 +++
 loleaflet/po/ui-bg.po  |  779 +++
 loleaflet/po/ui-bn.po  |  779 +++
 loleaflet/po/ui-bn_IN.po   |  540 -
 loleaflet/po/ui-bo.po  |  779 +++
 loleaflet/po/ui-br.po  |  779 +++
 loleaflet/po/ui-brx.po |  779 +++
 

[Libreoffice-commits] core.git: officecfg/registry sc/source

[Andras Timar]

 officecfg/registry/schema/org/openoffice/Office/Calc.xcs |   20 +++
 sc/source/ui/view/viewfun2.cxx   |   10 +--
 2 files changed, 27 insertions(+), 3 deletions(-)

New commits:
commit da24355234ec12f2f4c652113dbbb1216ba5492c
Author: Andras Timar 
Date:   Wed Apr 19 13:29:21 2017 +0200

Settings for not showing Merge Cells dialog and for emptying hidden cells

By default nothing changes. But users have the possibility to avoid the
confusing (?) Merge Cell dialog. Also, when the dialog is disabled, users
may want to set the EmptyMergedCells to true, to mimic Excel's behaviour.

Change-Id: I9656ae59199bb697c45786dd478379f5c89eb08f
Reviewed-on: https://gerrit.libreoffice.org/36679
Tested-by: Jenkins 
Reviewed-by: Andras Timar 

diff --git a/officecfg/registry/schema/org/openoffice/Office/Calc.xcs 
b/officecfg/registry/schema/org/openoffice/Office/Calc.xcs
index f03fcae1e147..86d3525d8689 100644
--- a/officecfg/registry/schema/org/openoffice/Office/Calc.xcs
+++ b/officecfg/registry/schema/org/openoffice/Office/Calc.xcs
@@ -1865,6 +1865,26 @@
   
 Contains various compatibility settings.
   
+  
+
+  Contains settings for merging cells.
+  Merge cells
+
+
+  
+Specifies whether the Merge Cells dialog box is shown, when 
some cells are not empty.
+Show Merge Cells dialog
+  
+  true
+
+
+  
+Specifies whether to empty the contents of the hidden cells 
(like Excel does).
+Empty merged cells
+  
+  false
+
+  
   
 
   Contains options related to key bindings
diff --git a/sc/source/ui/view/viewfun2.cxx b/sc/source/ui/view/viewfun2.cxx
index b7ee8dd55eb6..59609fbebfe0 100644
--- a/sc/source/ui/view/viewfun2.cxx
+++ b/sc/source/ui/view/viewfun2.cxx
@@ -92,6 +92,8 @@
 #include 
 #include 
 
+#include 
+
 using namespace com::sun::star;
 using ::editeng::SvxBorderLine;
 
@@ -1096,11 +1098,12 @@ bool ScViewFunc::MergeCells( bool bApi, bool& 
rDoContents, bool bCenter )
 }
 
 bool bOk = true;
-bool bEmptyMergedCells = false;
+bool bEmptyMergedCells = 
officecfg::Office::Calc::Compatibility::MergeCells::EmptyMergedCells::get();
 
 if (bAskDialog)
 {
-if (!bApi)
+bool bShowDialog = 
officecfg::Office::Calc::Compatibility::MergeCells::ShowDialog::get();
+if (!bApi && bShowDialog)
 {
 VclPtr aBox = 
VclPtr::Create( GetViewData().GetDialogParent() );
 sal_uInt16 nRetVal = aBox->Execute();
@@ -1113,7 +1116,8 @@ bool ScViewFunc::MergeCells( bool bApi, bool& 
rDoContents, bool bCenter )
 rDoContents = true;
 break;
 case KeepContentHiddenCells:
-break; // keep default values
+bEmptyMergedCells = false;
+break;
 case EmptyContentHiddenCells:
 bEmptyMergedCells = true;
 break;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-2-1' - loleaflet/src

[Pranav Kant]

 loleaflet/src/layer/AnnotationManager.js |   22 +++---
 1 file changed, 11 insertions(+), 11 deletions(-)

New commits:
commit a3850d67b9b7d36566fdb02e8141303e2ce008ff
Author: Pranav Kant 
Date:   Thu Apr 20 12:42:16 2017 +0530

loleaflet: Fix incorrect variable usage in this loop

Change-Id: I586ad59874b901d31b6e138a74577ecf3e1920c3
(cherry picked from commit ee683c106cd8421600b2141cb43c25e5e8dd1af0)
Reviewed-on: https://gerrit.libreoffice.org/36724
Reviewed-by: Jan Holesovsky 
Tested-by: Jan Holesovsky 

diff --git a/loleaflet/src/layer/AnnotationManager.js 
b/loleaflet/src/layer/AnnotationManager.js
index e739930d..88fbcaba 100644
--- a/loleaflet/src/layer/AnnotationManager.js
+++ b/loleaflet/src/layer/AnnotationManager.js
@@ -280,7 +280,7 @@ L.AnnotationManager = L.Class.extend({
var scale = this._map.getZoomScale(this._map.getZoom(), 10);
var docRight = 
this._map.project(this._map.options.maxBounds.getNorthEast()).subtract(this.options.extraSize.multiplyBy(scale));
var topRight = docRight.add(L.point(this.options.marginX, 
this.options.marginY));
-   var latlng, layoutBounds, point, index;
+   var latlng, layoutBounds, point, idx;
if (this._selected) {
var selectIndexFirst = 
this.getRootIndexOf(this._selected._data.id);
var selectIndexLast = 
this.getLastChildIndexOf(this._selected._data.id);
@@ -293,7 +293,7 @@ L.AnnotationManager = L.Class.extend({
layoutBounds = 
this._items[selectIndexFirst].getBounds();
 
// Adjust child comments too, if any
-   for (var idx = selectIndexFirst + 1; idx <= 
selectIndexLast; idx++) {
+   for (idx = selectIndexFirst + 1; idx <= 
selectIndexLast; idx++) {
if (zoom) {
this._items[idx]._data.anchorPix = 
this._map._docLayer._twipsToPixels(this._items[idx]._data.anchorPos.min);
}
@@ -310,9 +310,9 @@ L.AnnotationManager = L.Class.extend({
layoutBounds.max = 
layoutBounds.max.add([this.options.marginX, 0]);
layoutBounds.extend(layoutBounds.min.subtract([0, 
this.options.marginY]));
layoutBounds.extend(layoutBounds.max.add([0, 
this.options.marginY]));
-   for (index = selectIndexFirst - 1; index >= 0;) {
+   for (idx = selectIndexFirst - 1; idx >= 0;) {
var commentThread = [];
-   var tmpIdx = index;
+   var tmpIdx = idx;
do {
if (zoom) {

this._items[idx]._data.anchorPix = 
this._map._docLayer._twipsToPixels(this._items[idx]._data.anchorPos.min);
@@ -324,11 +324,11 @@ L.AnnotationManager = L.Class.extend({
commentThread.reverse();
// All will have some anchor position
this.layoutUp(commentThread, 
this._map.unproject(L.point(topRight.x, commentThread[0]._data.anchorPix.y)), 
layoutBounds);
-   index = index - commentThread.length;
+   idx = idx - commentThread.length;
}
-   for (index = selectIndexLast + 1; index < 
this._items.length;) {
+   for (idx = selectIndexLast + 1; idx < 
this._items.length;) {
commentThread = [];
-   tmpIdx = index;
+   tmpIdx = idx;
do {
if (zoom) {

this._items[idx]._data.anchorPix = 
this._map._docLayer._twipsToPixels(this._items[idx]._data.anchorPos.min);
@@ -339,7 +339,7 @@ L.AnnotationManager = L.Class.extend({
 
// All will have some anchor position
this.layoutDown(commentThread, 
this._map.unproject(L.point(topRight.x, commentThread[0]._data.anchorPix.y)), 
layoutBounds);
-   index = index + commentThread.length;
+   idx = idx + commentThread.length;
}
if (!this._selected.isEdit()) {
this._selected.show();
@@ -347,9 +347,9 @@ L.AnnotationManager = L.Class.extend({
} else {
point = 
this._map.latLngToLayerPoint(this._map.unproject(topRight));
layoutBounds = L.bounds(point, point);
-   for (index 

[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-2-1' - loleaflet/src

[Henry Castro]

 loleaflet/src/control/Control.Scroll.js |1 
 loleaflet/src/layer/AnnotationManager.js|   34 +---
 loleaflet/src/layer/tile/GridLayer.js   |   14 ++-
 loleaflet/src/layer/tile/WriterTileLayer.js |6 
 loleaflet/src/map/Map.js|7 -
 5 files changed, 42 insertions(+), 20 deletions(-)

New commits:
commit 2b49c794e0cf244be23505bada0dc1ebe4921444
Author: Henry Castro 
Date:   Wed Apr 19 11:47:45 2017 -0400

loleaflet: extend document size to scroll annotations

Change-Id: I9581818628c365587a4a115b9d3f0b457b8a6905
Reviewed-on: https://gerrit.libreoffice.org/36699
Reviewed-by: Jan Holesovsky 
Tested-by: Jan Holesovsky 

diff --git a/loleaflet/src/control/Control.Scroll.js 
b/loleaflet/src/control/Control.Scroll.js
index 3d076f34..d47d422e 100644
--- a/loleaflet/src/control/Control.Scroll.js
+++ b/loleaflet/src/control/Control.Scroll.js
@@ -29,6 +29,7 @@ L.Control.Scroll = L.Control.extend({
axis: 'yx',
theme: 'minimal-dark',
scrollInertia: 0,
+   advanced:{autoExpandHorizontalScroll: true}, /* weird 
bug, it should be false */
callbacks:{
onScroll: function() {
control._onScrollEnd(this);
diff --git a/loleaflet/src/layer/AnnotationManager.js 
b/loleaflet/src/layer/AnnotationManager.js
index fc7d077c..54f3496b 100644
--- a/loleaflet/src/layer/AnnotationManager.js
+++ b/loleaflet/src/layer/AnnotationManager.js
@@ -6,14 +6,16 @@ L.AnnotationManager = L.Class.extend({
options: {
marginX: 50,
marginY: 10,
-   offset: 5
+   offset: 5,
+   extraSize: L.point(250, 0)
},
 
-   initialize: function (map) {
+   initialize: function (map, options) {
this._map = map;
this._items = [];
this._selected = null;
this._animation = new L.PosAnimation();
+   L.setOptions(this, options);
this._arrow = L.polyline([], {color: 'darkblue', weight: 1});
this._map.on('zoomend', this._onAnnotationZoom, this);
this._map.on('AnnotationCancel', this._onAnnotationCancel, 
this);
@@ -99,7 +101,10 @@ L.AnnotationManager = L.Class.extend({
this.adjustComment(comment);

this._items.push(L.annotation(this._map.options.maxBounds.getSouthEast(), 
comment).addTo(this._map));
}
-   this.layout();
+   if (this._items.length > 0) {
+   this._map._docLayer._updateMaxBounds(true);
+   this.layout();
+   }
},
 
fillChanges: function(redlines) {
@@ -110,7 +115,10 @@ L.AnnotationManager = L.Class.extend({
this.adjustRedLine(changecomment);

this._items.push(L.annotation(this._map.options.maxBounds.getSouthEast(), 
changecomment).addTo(this._map));
}
-   this.layout();
+   if (this._items.length > 0) {
+   this._map._docLayer._upateMaxBounds(true);
+   this.layout();
+   }
},
 
getItem: function (id) {
@@ -190,12 +198,11 @@ L.AnnotationManager = L.Class.extend({
 
update: function () {
if (this._selected) {
-   var point0, point1, point2;
-   var topRight = 
this._map.project(this._map.options.maxBounds.getNorthEast());
-   point0 = 
this._map._docLayer._twipsToPixels(this._selected._data.anchorPos.max);
-   point1 = L.point(point0.x, point0.y + 
this.options.offset);
-   point2 = L.point(topRight.x, point1.y);
-   this._arrow.setLatLngs([this._map.unproject(point0), 
this._map.unproject(point1), this._map.unproject(point2)]);
+   var point;
+   var scale = this._map.getZoomScale(this._map.getZoom(), 
10);
+   var docRight = 
this._map.project(this._map.options.maxBounds.getNorthEast()).subtract(this.options.extraSize.multiplyBy(scale));
+   point = 
this._map._docLayer._twipsToPixels(this._selected._data.anchorPos.min);
+   this._arrow.setLatLngs([this._map.unproject(point), 
map.unproject(L.point(docRight.x, point.y))]);
this._map.addLayer(this._arrow);
} else {
this._map.removeLayer(this._arrow);
@@ -270,7 +277,8 @@ L.AnnotationManager = L.Class.extend({
},
 
layout: function (zoom) {
-   var docRight = 

[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-2-1' - test/httpwstest.cpp

[Ashod Nakashian]

 test/httpwstest.cpp |   70 
 1 file changed, 70 insertions(+)

New commits:
commit b0a21ae1b349a4eb52d93f1b63a4f8f10463b0f2
Author: Ashod Nakashian 
Date:   Thu Apr 20 00:13:32 2017 -0400

wsd: unittest for correctly saving in presence of passive clients

Passive clients that don't load the document can
be disruptive as they are not useful for saving
the document, so we need to ignore them and
use reliable sessions.

Change-Id: I162ec00823ba5af776fcb55f6d58149f2a56d7bb
Reviewed-on: https://gerrit.libreoffice.org/36712
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 
(cherry picked from commit 876e4098357df8319bf6c721aca359cb94be9fb7)
Reviewed-on: https://gerrit.libreoffice.org/36715
Reviewed-by: Jan Holesovsky 
Tested-by: Jan Holesovsky 

diff --git a/test/httpwstest.cpp b/test/httpwstest.cpp
index 78d717fb..917a41dd 100644
--- a/test/httpwstest.cpp
+++ b/test/httpwstest.cpp
@@ -70,6 +70,7 @@ class HTTPWSTest : public CPPUNIT_NS::TestFixture
 CPPUNIT_TEST(testReload);
 CPPUNIT_TEST(testGetTextSelection);
 CPPUNIT_TEST(testSaveOnDisconnect);
+CPPUNIT_TEST(testSavePassiveOnDisconnect);
 CPPUNIT_TEST(testReloadWhileDisconnecting);
 CPPUNIT_TEST(testExcelLoad);
 CPPUNIT_TEST(testPaste);
@@ -123,6 +124,7 @@ class HTTPWSTest : public CPPUNIT_NS::TestFixture
 void testReload();
 void testGetTextSelection();
 void testSaveOnDisconnect();
+void testSavePassiveOnDisconnect();
 void testReloadWhileDisconnecting();
 void testExcelLoad();
 void testPaste();
@@ -711,6 +713,74 @@ void HTTPWSTest::testSaveOnDisconnect()
 }
 }
 
+void HTTPWSTest::testSavePassiveOnDisconnect()
+{
+const auto testname = "saveOnPassiveDisconnect ";
+
+const auto text = helpers::genRandomString(40);
+std::cerr << "Test string: [" << text << "]." << std::endl;
+
+std::string documentPath, documentURL;
+getDocumentPathAndURL("hello.odt", documentPath, documentURL, testname);
+
+int kitcount = -1;
+try
+{
+auto socket = loadDocAndGetSocket(_uri, documentURL, testname);
+
+Poco::Net::HTTPRequest request(Poco::Net::HTTPRequest::HTTP_GET, 
documentURL);
+auto socket2 = connectLOKit(_uri, request, _response);
+
+sendTextFrame(socket, "uno .uno:SelectAll", testname);
+sendTextFrame(socket, "uno .uno:Delete", testname);
+sendTextFrame(socket, "paste mimetype=text/plain;charset=utf-8\n" + 
text, testname);
+
+// Check if the document contains the pasted text.
+sendTextFrame(socket, "uno .uno:SelectAll", testname);
+sendTextFrame(socket, "gettextselection 
mimetype=text/plain;charset=utf-8", testname);
+const auto selection = assertResponseString(socket, 
"textselectioncontent:", testname);
+CPPUNIT_ASSERT_EQUAL("textselectioncontent: " + text, selection);
+
+// Closing connection too fast might not flush buffers.
+// Often nothing more than the SelectAll reaches the server before
+// the socket is closed, when the doc is not even modified yet.
+getResponseMessage(socket, "statechanged", testname);
+
+kitcount = getLoolKitProcessCount();
+
+// Shutdown abruptly.
+std::cerr << "Closing connection after pasting." << std::endl;
+socket->shutdown(); // Should trigger saving.
+socket2->shutdown();
+}
+catch (const Poco::Exception& exc)
+{
+CPPUNIT_FAIL(exc.displayText());
+}
+
+// Allow time to save and destroy before we connect again.
+testNoExtraLoolKitsLeft();
+std::cerr << "Loading again." << std::endl;
+try
+{
+// Load the same document and check that the last changes (pasted 
text) is saved.
+auto socket = loadDocAndGetSocket(_uri, documentURL, testname);
+
+// Should have no new instances.
+CPPUNIT_ASSERT_EQUAL(kitcount, countLoolKitProcesses(kitcount));
+
+// Check if the document contains the pasted text.
+sendTextFrame(socket, "uno .uno:SelectAll", testname);
+sendTextFrame(socket, "gettextselection 
mimetype=text/plain;charset=utf-8", testname);
+const auto selection = assertResponseString(socket, 
"textselectioncontent:", testname);
+CPPUNIT_ASSERT_EQUAL("textselectioncontent: " + text, selection);
+}
+catch (const Poco::Exception& exc)
+{
+CPPUNIT_FAIL(exc.displayText());
+}
+}
+
 void HTTPWSTest::testReloadWhileDisconnecting()
 {
 const auto testname = "reloadWhileDisconnecting ";
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-2-1' - wsd/DocumentBroker.cpp

[Ashod Nakashian]

 wsd/DocumentBroker.cpp |   19 +--
 1 file changed, 9 insertions(+), 10 deletions(-)

New commits:
commit a8b8ca067acd888ad5376fca497862e595f795a2
Author: Ashod Nakashian 
Date:   Thu Apr 20 00:10:30 2017 -0400

wsd: stop the DocBroker when saving session is last

When a session is disconnecting and we use it to save
(because the other sessions are not viable for saving),
then we need to correctly detect if by the time
saving is done there are no other sessions left.

Otherwise, we end up thinking there are other sessions
when the others had been disconnected during saving.

Change-Id: I55687376f5237a495ae163b53f51ee1d2414d770
Reviewed-on: https://gerrit.libreoffice.org/36711
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 
(cherry picked from commit 2a0253b76be3e329af55d0ab80157544eea2253e)
Reviewed-on: https://gerrit.libreoffice.org/36714
Reviewed-by: Jan Holesovsky 
Tested-by: Jan Holesovsky 

diff --git a/wsd/DocumentBroker.cpp b/wsd/DocumentBroker.cpp
index 94a49a1d..1afd30f0 100644
--- a/wsd/DocumentBroker.cpp
+++ b/wsd/DocumentBroker.cpp
@@ -562,16 +562,13 @@ bool DocumentBroker::saveToStorage(const std::string& 
sessionId,
 
 const bool res = saveToStorageInternal(sessionId, success, result);
 
+// We've saved and can safely destroy this session.
+removeSessionInternal(sessionId);
+
 // If marked to destroy, then this was the last session.
-// FIXME: If during that last save another client connects
-// to this doc, the _markToDestroy will be reset and we
-// will leak the last session. Need to mark the session as
-// dead and cleanup somehow.
-if (_markToDestroy)
+// Otherwise, check that we are (which we might be by now).
+if (_markToDestroy || _sessions.empty())
 {
-// We've saved and can safely destroy.
-removeSessionInternal(sessionId);
-
 // Stop so we get cleaned up and removed.
 _stop = true;
 }
@@ -866,7 +863,8 @@ size_t DocumentBroker::removeSession(const std::string& id, 
bool destroyIfLast)
 try
 {
 LOG_INF("Removing session [" << id << "] on docKey [" << _docKey <<
-"]. Have " << _sessions.size() << " sessions.");
+"]. Have " << _sessions.size() << " sessions. markToDestroy: " 
<< _markToDestroy <<
+", LastEditableSession: " << _lastEditableSession);
 
 if (!_lastEditableSession || !autoSave(true))
 return removeSessionInternal(id);
@@ -1230,7 +1228,8 @@ void DocumentBroker::destroyIfLastEditor(const 
std::string& id)
 // Last view going away, can destroy.
 _markToDestroy = (_sessions.size() <= 1);
 LOG_DBG("startDestroy on session [" << id << "] on docKey [" << _docKey <<
-"], markToDestroy: " << _markToDestroy << ", lastEditableSession: 
" << _lastEditableSession);
+"], sessions: " << _sessions.size() << " markToDestroy: " << 
_markToDestroy <<
+", lastEditableSession: " << _lastEditableSession);
 }
 
 void DocumentBroker::setModified(const bool value)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: accessibility/inc basctl/inc basic/source chart2/inc compilerplugins/clang cppcanvas/inc cui/inc dbaccess/inc dbaccess/source desktop/inc editeng/inc formula/source fra

[Noel Grandin]

 accessibility/inc/pch/precompiled_acc.hxx   |1 
 basctl/inc/pch/precompiled_basctl.hxx   |1 
 basic/source/classes/sb.cxx |1 
 chart2/inc/pch/precompiled_chartcontroller.hxx  |1 
 compilerplugins/clang/unusedmethods.py  |6 +-
 cppcanvas/inc/pch/precompiled_cppcanvas.hxx |1 
 cui/inc/pch/precompiled_cui.hxx |1 
 dbaccess/inc/pch/precompiled_dba.hxx|1 
 dbaccess/inc/pch/precompiled_dbmm.hxx   |1 
 dbaccess/inc/pch/precompiled_dbu.hxx|1 
 dbaccess/source/ui/inc/UITools.hxx  |4 -
 dbaccess/source/ui/misc/UITools.cxx |   17 --
 desktop/inc/pch/precompiled_sofficeapp.hxx  |1 
 editeng/inc/pch/precompiled_editeng.hxx |1 
 formula/source/core/api/FormulaCompiler.cxx |1 
 framework/inc/pch/precompiled_fwe.hxx   |1 
 framework/inc/pch/precompiled_fwi.hxx   |1 
 framework/inc/pch/precompiled_fwk.hxx   |1 
 framework/inc/pch/precompiled_fwl.hxx   |1 
 framework/source/uiconfiguration/ImageList.cxx  |1 
 include/sfx2/sidebar/ControllerItem.hxx |   11 
 include/svx/galtheme.hxx|3 -
 include/tools/inetmime.hxx  |   13 
 include/tools/rc.hxx|   46 -
 include/tools/resid.hxx |4 -
 include/vcl/ImageTree.hxx   |4 -
 include/vcl/menu.hxx|1 
 reportdesign/inc/pch/precompiled_rpt.hxx|1 
 reportdesign/inc/pch/precompiled_rptui.hxx  |1 
 rsc/inc/rscdb.hxx   |1 
 rsc/inc/rsctools.hxx|2 
 sc/inc/pch/precompiled_sc.hxx   |1 
 scaddins/source/analysis/analysishelper.hxx |3 -
 scaddins/source/datefunc/datefunc.hxx   |1 
 scaddins/source/pricing/pricing.hxx |1 
 sd/inc/pch/precompiled_sdui.hxx |1 
 sfx2/inc/pch/precompiled_sfx.hxx|1 
 sfx2/source/appl/shutdowniconunx.cxx|2 
 sfx2/source/dialog/styfitem.cxx |1 
 sfx2/source/inc/sfxtypes.hxx|1 
 sfx2/source/sidebar/ControllerItem.cxx  |   63 
 sfx2/source/sidebar/Theme.cxx   |1 
 slideshow/inc/pch/precompiled_slideshow.hxx |1 
 starmath/inc/pch/precompiled_sm.hxx |1 
 starmath/inc/smmod.hxx  |1 
 svtools/inc/pch/precompiled_svt.hxx |1 
 svx/inc/pch/precompiled_svx.hxx |1 
 svx/inc/pch/precompiled_svxcore.hxx |1 
 svx/source/gallery2/galtheme.cxx|6 --
 svx/source/inc/AccessibleFrameSelector.hxx  |1 
 sw/inc/pch/precompiled_msword.hxx   |1 
 sw/inc/pch/precompiled_swui.hxx |1 
 sw/inc/pch/precompiled_vbaswobj.hxx |1 
 sw/inc/shellres.hxx |1 
 sw/source/core/crsr/callnk.cxx  |8 ---
 sw/source/core/crsr/callnk.hxx  |3 -
 tools/source/inet/inetmime.cxx  |   17 --
 tools/source/rc/rc.cxx  |2 
 tools/source/rc/resmgr.cxx  |9 ---
 uui/source/iahndl.hxx   |1 
 uui/source/interactionhandler.cxx   |1 
 vbahelper/inc/pch/precompiled_msforms.hxx   |1 
 vcl/source/image/Image.cxx  |1 
 vcl/source/image/ImageTree.cxx  |5 -
 vcl/source/window/menu.cxx  |5 -
 xmlsecurity/inc/pch/precompiled_xmlsecurity.hxx |1 
 66 files changed, 10 insertions(+), 268 deletions(-)

New commits:
commit 1c5cae479bebd2d325182adc2c9821fd948fd1bd
Author: Noel Grandin 
Date:   Thu Apr 20 08:44:33 2017 +0200

loplugin:unusedmethods

Change-Id: Ib7a9b1b0802ca751da258065e89b412b090bb672
Reviewed-on: https://gerrit.libreoffice.org/36718
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/accessibility/inc/pch/precompiled_acc.hxx 
b/accessibility/inc/pch/precompiled_acc.hxx
index e50eaef3d3b7..deb737656f1f 100644
--- a/accessibility/inc/pch/precompiled_acc.hxx
+++ b/accessibility/inc/pch/precompiled_acc.hxx
@@ -317,7 +317,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
diff --git a/basctl/inc/pch/precompiled_basctl.hxx 
b/basctl/inc/pch/precompiled_basctl.hxx
index 2a097ac098d9..f51bd722a4f4 100644
--- a/basctl/inc/pch/precompiled_basctl.hxx
+++ b/basctl/inc/pch/precompiled_basctl.hxx
@@ -544,7 +544,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
diff --git a/basic/source/classes/sb.cxx 

[Libreoffice-commits] core.git: compilerplugins/clang i18nutil/source

[Noel Grandin]

 compilerplugins/clang/unusedfields.py |9 -
 i18nutil/source/utility/unicode.cxx   |7 ---
 2 files changed, 8 insertions(+), 8 deletions(-)

New commits:
commit 8411f48bfb71d5713b185b41d6519b0beb4c1e83
Author: Noel Grandin 
Date:   Thu Apr 20 09:13:34 2017 +0200

loplugin:unusedfields

Change-Id: I0026e0a1890b984675e82ab7be5cdbc56e142a87
Reviewed-on: https://gerrit.libreoffice.org/36722
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/compilerplugins/clang/unusedfields.py 
b/compilerplugins/clang/unusedfields.py
index 77e6446e18e3..3effaff38828 100755
--- a/compilerplugins/clang/unusedfields.py
+++ b/compilerplugins/clang/unusedfields.py
@@ -97,7 +97,9 @@ for d in definitionSet:
 if srcLoc.startswith("cppu/source/uno/check.cxx"):
 continue
 fieldType = definitionToTypeMap[d]
-if fieldType in set([ "class rptui::OModuleClient" ]):
+if "ModuleClient" in fieldType:
+continue
+if "::sfx2::sidebar::ControllerItem" in fieldType:
 continue
 untouchedSet.add((d[0] + " " + d[1] + " " + fieldType, srcLoc))
 
@@ -118,6 +120,11 @@ for d in definitionSet:
 or srcLoc.startswith("lotuswordpro/source/filter/lwpsdwdrawheader.hxx")
 or srcLoc.startswith("svtools/source/dialogs/insdlg.cxx")):
 continue
+fieldType = definitionToTypeMap[d]
+if "ModuleClient" in fieldType:
+continue
+if "::sfx2::sidebar::ControllerItem" in fieldType:
+continue
 
 writeonlySet.add((clazz + " " + definitionToTypeMap[d], srcLoc))
 
diff --git a/i18nutil/source/utility/unicode.cxx 
b/i18nutil/source/utility/unicode.cxx
index 496c5cb589ac..94abe5220f84 100644
--- a/i18nutil/source/utility/unicode.cxx
+++ b/i18nutil/source/utility/unicode.cxx
@@ -36,13 +36,6 @@
 
 using namespace ::com::sun::star::i18n;
 
-struct DefaultScriptTypeList {
-com::sun::star::i18n::UnicodeScript from;
-com::sun::star::i18n::UnicodeScript to;
-com::sun::star::i18n::UnicodeScript value;
-};
-
-
 template
 T getScriptType( const sal_Unicode ch, const L* typeList, T unknownType ) {
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-2-1' - wsd/LOOLWSD.cpp

[Jan Holesovsky]

 wsd/LOOLWSD.cpp |   14 ++
 1 file changed, 6 insertions(+), 8 deletions(-)

New commits:
commit 998473fa7fe6dfb68f202a464a1bb12d417d92a2
Author: Jan Holesovsky 
Date:   Thu Apr 20 17:42:31 2017 +0200

Revert "wsd: clear the incoming buffer before upgrading to WS"

This fixes image insertion.

This reverts commit 9a761ffe68b24e180dd74c0737e20cabe9dc9e1b.

Change-Id: I05c88b96e40fce820a75738485fe8599129d3e20

diff --git a/wsd/LOOLWSD.cpp b/wsd/LOOLWSD.cpp
index d109e5d2..b4db3636 100644
--- a/wsd/LOOLWSD.cpp
+++ b/wsd/LOOLWSD.cpp
@@ -1533,7 +1533,6 @@ private:
 {
 auto socket = _socket.lock();
 std::vector& in = socket->_inBuffer;
-LOG_TRC("#" << socket->getFD() << " handling incoming " << in.size() 
<< " bytes.");
 
 // Find the end of the header, if any.
 static const std::string marker("\r\n\r\n");
@@ -1541,7 +1540,7 @@ private:
   marker.begin(), marker.end());
 if (itBody == in.end())
 {
-LOG_DBG("#" << socket->getFD() << " doesn't have enough data 
yet.");
+LOG_TRC("#" << socket->getFD() << " doesn't have enough data 
yet.");
 return SocketHandlerInterface::SocketOwnership::UNCHANGED;
 }
 
@@ -1579,10 +1578,6 @@ private:
 LOG_DBG("Not enough content yet: ContentLength: " << 
contentLength << ", available: " << available);
 return SocketHandlerInterface::SocketOwnership::UNCHANGED;
 }
-
-// if we succeeded - remove the request from our input buffer
-// we expect one request per socket
-in.erase(in.begin(), itBody);
 }
 catch (const std::exception& exc)
 {
@@ -1639,8 +1634,7 @@ private:
 // All post requests have url prefix 'lool'.
 socketOwnership = handlePostRequest(request, message);
 }
-else if (reqPathTokens.count() > 2 && reqPathTokens[0] == 
"lool" && reqPathTokens[2] == "ws" &&
- request.find("Upgrade") != request.end() && 
Poco::icompare(request["Upgrade"], "websocket") == 0)
+else if (reqPathTokens.count() > 2 && reqPathTokens[0] == 
"lool" && reqPathTokens[2] == "ws")
 {
 socketOwnership = handleClientWsUpgrade(request, 
reqPathTokens[1]);
 }
@@ -1659,6 +1653,10 @@ private:
 socket->shutdown();
 }
 }
+
+// if we succeeded - remove the request from our input buffer
+// we expect one request per socket
+in.clear();
 }
 catch (const std::exception& exc)
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-2-1' - 3 commits - test/httpwstest.cpp wsd/ClientSession.cpp wsd/ClientSession.hpp wsd/DocumentBroker.cpp

[Jan Holesovsky]

 test/httpwstest.cpp|   70 -
 wsd/ClientSession.cpp  |4 --
 wsd/ClientSession.hpp  |   10 ---
 wsd/DocumentBroker.cpp |   20 +++---
 4 files changed, 12 insertions(+), 92 deletions(-)

New commits:
commit db3416c32f881e3edcffc670074874f1e074725a
Author: Jan Holesovsky 
Date:   Thu Apr 20 17:32:24 2017 +0200

Revert "wsd: unittest for correctly saving in presence of passive clients"

This reverts commit b0a21ae1b349a4eb52d93f1b63a4f8f10463b0f2.

diff --git a/test/httpwstest.cpp b/test/httpwstest.cpp
index 917a41dd..78d717fb 100644
--- a/test/httpwstest.cpp
+++ b/test/httpwstest.cpp
@@ -70,7 +70,6 @@ class HTTPWSTest : public CPPUNIT_NS::TestFixture
 CPPUNIT_TEST(testReload);
 CPPUNIT_TEST(testGetTextSelection);
 CPPUNIT_TEST(testSaveOnDisconnect);
-CPPUNIT_TEST(testSavePassiveOnDisconnect);
 CPPUNIT_TEST(testReloadWhileDisconnecting);
 CPPUNIT_TEST(testExcelLoad);
 CPPUNIT_TEST(testPaste);
@@ -124,7 +123,6 @@ class HTTPWSTest : public CPPUNIT_NS::TestFixture
 void testReload();
 void testGetTextSelection();
 void testSaveOnDisconnect();
-void testSavePassiveOnDisconnect();
 void testReloadWhileDisconnecting();
 void testExcelLoad();
 void testPaste();
@@ -713,74 +711,6 @@ void HTTPWSTest::testSaveOnDisconnect()
 }
 }
 
-void HTTPWSTest::testSavePassiveOnDisconnect()
-{
-const auto testname = "saveOnPassiveDisconnect ";
-
-const auto text = helpers::genRandomString(40);
-std::cerr << "Test string: [" << text << "]." << std::endl;
-
-std::string documentPath, documentURL;
-getDocumentPathAndURL("hello.odt", documentPath, documentURL, testname);
-
-int kitcount = -1;
-try
-{
-auto socket = loadDocAndGetSocket(_uri, documentURL, testname);
-
-Poco::Net::HTTPRequest request(Poco::Net::HTTPRequest::HTTP_GET, 
documentURL);
-auto socket2 = connectLOKit(_uri, request, _response);
-
-sendTextFrame(socket, "uno .uno:SelectAll", testname);
-sendTextFrame(socket, "uno .uno:Delete", testname);
-sendTextFrame(socket, "paste mimetype=text/plain;charset=utf-8\n" + 
text, testname);
-
-// Check if the document contains the pasted text.
-sendTextFrame(socket, "uno .uno:SelectAll", testname);
-sendTextFrame(socket, "gettextselection 
mimetype=text/plain;charset=utf-8", testname);
-const auto selection = assertResponseString(socket, 
"textselectioncontent:", testname);
-CPPUNIT_ASSERT_EQUAL("textselectioncontent: " + text, selection);
-
-// Closing connection too fast might not flush buffers.
-// Often nothing more than the SelectAll reaches the server before
-// the socket is closed, when the doc is not even modified yet.
-getResponseMessage(socket, "statechanged", testname);
-
-kitcount = getLoolKitProcessCount();
-
-// Shutdown abruptly.
-std::cerr << "Closing connection after pasting." << std::endl;
-socket->shutdown(); // Should trigger saving.
-socket2->shutdown();
-}
-catch (const Poco::Exception& exc)
-{
-CPPUNIT_FAIL(exc.displayText());
-}
-
-// Allow time to save and destroy before we connect again.
-testNoExtraLoolKitsLeft();
-std::cerr << "Loading again." << std::endl;
-try
-{
-// Load the same document and check that the last changes (pasted 
text) is saved.
-auto socket = loadDocAndGetSocket(_uri, documentURL, testname);
-
-// Should have no new instances.
-CPPUNIT_ASSERT_EQUAL(kitcount, countLoolKitProcesses(kitcount));
-
-// Check if the document contains the pasted text.
-sendTextFrame(socket, "uno .uno:SelectAll", testname);
-sendTextFrame(socket, "gettextselection 
mimetype=text/plain;charset=utf-8", testname);
-const auto selection = assertResponseString(socket, 
"textselectioncontent:", testname);
-CPPUNIT_ASSERT_EQUAL("textselectioncontent: " + text, selection);
-}
-catch (const Poco::Exception& exc)
-{
-CPPUNIT_FAIL(exc.displayText());
-}
-}
-
 void HTTPWSTest::testReloadWhileDisconnecting()
 {
 const auto testname = "reloadWhileDisconnecting ";
commit 63398891b273b78042ed49c41d8439c8384cbcd4
Author: Jan Holesovsky 
Date:   Thu Apr 20 17:32:18 2017 +0200

Revert "wsd: rely only on loaded sessions for saving"

This reverts commit c1dbc3a117ef77557db10c98a9d5ca43bb2065f6.

diff --git a/wsd/ClientSession.cpp b/wsd/ClientSession.cpp
index 8be60603..414f8b94 100644
--- a/wsd/ClientSession.cpp
+++ b/wsd/ClientSession.cpp
@@ -37,8 +37,7 @@ ClientSession::ClientSession(const std::string& id,
 _docBroker(docBroker),
 _uriPublic(uriPublic),
 _isDocumentOwner(false),
-_isAttached(false),
-_isLoaded(false)
+_isAttached(false)
 {
 const size_t curConnections = 

[Libreoffice-commits] core.git: sc/source

[Eike Rathke]

 sc/source/core/tool/parclass.cxx |   52 +++
 1 file changed, 26 insertions(+), 26 deletions(-)

New commits:
commit b15c9ed2c2cb4b6e8b61d80bae284e4ea421aff3
Author: Eike Rathke 
Date:   Thu Apr 20 15:32:38 2017 +0200

keep list sorted by alphabetical opcode

Change-Id: I8eafa00cadd6196e4e9dd87a00fd530c3945af2c

diff --git a/sc/source/core/tool/parclass.cxx b/sc/source/core/tool/parclass.cxx
index 7c5ffd3aae99..2be37c1bfe6a 100644
--- a/sc/source/core/tool/parclass.cxx
+++ b/sc/source/core/tool/parclass.cxx
@@ -69,6 +69,7 @@ const ScParameterClassification::RawData 
ScParameterClassification::pRawData[] =
 { ocTableOp, {{ Value, Value, Value, Value, Value  
  }, 0 }},
 // Operators and functions.
 { ocAdd, {{ Array, Array   
  }, 0 }},
+{ ocAggregate,   {{ Value, Value, Reference
  }, 1 }},
 { ocAmpersand,   {{ Array, Array   
  }, 0 }},
 { ocAnd, {{ Reference  
  }, 1 }},
 { ocAreas,   {{ Reference  
  }, 0 }},
@@ -105,40 +106,49 @@ const ScParameterClassification::RawData 
ScParameterClassification::pRawData[] =
 { ocDevSq,   {{ Reference  
  }, 1 }},
 { ocDiv, {{ Array, Array   
  }, 0 }},
 { ocEqual,   {{ Array, Array   
  }, 0 }},
+{ ocFTest,   {{ ForceArray, ForceArray 
  }, 0 }},
 { ocForecast,{{ Value, ForceArray, ForceArray  
  }, 0 }},
+{ ocForecast_ETS_ADD, {{ ForceArray, ForceArray, ForceArray, Value, Value, 
Value}, 0 }},
+{ ocForecast_ETS_MUL, {{ ForceArray, ForceArray, ForceArray, Value, Value, 
Value}, 0 }},
+{ ocForecast_ETS_PIA, {{ ForceArray, ForceArray, ForceArray, Value, Value, 
Value, Value }, 0 }},
+{ ocForecast_ETS_PIM, {{ ForceArray, ForceArray, ForceArray, Value, Value, 
Value, Value }, 0 }},
+{ ocForecast_ETS_SEA, {{ ForceArray, ForceArray, Value, Value  
 }, 0 }},
+{ ocForecast_ETS_STA, {{ ForceArray, ForceArray, ForceArray, Value, Value, 
Value}, 0 }},
+{ ocForecast_ETS_STM, {{ ForceArray, ForceArray, ForceArray, Value, Value, 
Value}, 0 }},
 { ocFormula, {{ Reference  
  }, 0 }},
 { ocFrequency,   {{ Reference, Reference   
  }, 0 }},
-{ ocFTest,   {{ ForceArray, ForceArray 
  }, 0 }},
-{ ocGeoMean, {{ Reference  
  }, 1 }},
 { ocGCD, {{ Reference  
  }, 1 }},
+{ ocGeoMean, {{ Reference  
  }, 1 }},
 { ocGreater, {{ Array, Array   
  }, 0 }},
 { ocGreaterEqual,{{ Array, Array   
  }, 0 }},
 { ocGrowth,  {{ Reference, Reference, Reference, Value 
  }, 0 }},
-{ ocHarMean, {{ Reference  
  }, 1 }},
 { ocHLookup, {{ Value, ReferenceOrForceArray, Value, Value 
  }, 0 }},
+{ ocHarMean, {{ Reference  
  }, 1 }},
 { ocIRR, {{ Reference, Value   
  }, 0 }},
 { ocIndex,   {{ Reference, Value, Value, Value 
  }, 0 }},
 { ocIntercept,   {{ ForceArray, ForceArray 
  }, 0 }},
 { ocIntersect,   {{ Reference, Reference   
  }, 0 }},
 { ocIsRef,   {{ Reference  
  }, 0 }},
-{ ocLCM, {{ Reference  
  }, 1 }},
 { ocKurt,{{ Reference  
  }, 1 }},
+{ ocLCM, {{ Reference  
  }, 1 }},
 { ocLarge,   {{ Reference, Value   
  }, 0 }},
 { ocLess,{{ Array, Array   
  }, 0 }},
 { ocLessEqual,   {{ Array, Array   
  }, 0 }},
+{ ocLinest,  {{ ForceArray, ForceArray, Value, Value   
  }, 0 }},
+{ ocLogest,  {{ ForceArray, ForceArray, Value, Value   
  }, 0 }},
 { ocLookup,  {{ Value, ReferenceOrForceArray, 
ReferenceOrForceArray  }, 0 }},
-{ ocMatch,   {{ Value, 

[Libreoffice-commits] core.git: chart2/source

[Tomaž Vajngerl]

 chart2/source/view/main/ChartView.cxx |   21 ++---
 1 file changed, 2 insertions(+), 19 deletions(-)

New commits:
commit f44fb845f275e9be3861bb299f2bb3689280a92e
Author: Tomaž Vajngerl 
Date:   Mon Apr 17 19:20:27 2017 +0200

tdf#107067 remove data buttons as they don't have any action

Change-Id: I91751cfc32a75ecd72dc711821d918b6a5d9f83f
Reviewed-on: https://gerrit.libreoffice.org/36736
Tested-by: Jenkins 
Reviewed-by: Tomaž Vajngerl 

diff --git a/chart2/source/view/main/ChartView.cxx 
b/chart2/source/view/main/ChartView.cxx
index 6dccabf2d74f..364828692c2c 100644
--- a/chart2/source/view/main/ChartView.cxx
+++ b/chart2/source/view/main/ChartView.cxx
@@ -2488,8 +2488,8 @@ bool lcl_createLegend( const uno::Reference< XLegend > & 
xLegend
 return true;
 }
 
-void lcl_createButtons(const uno::Reference< drawing::XShapes>& xPageShapes,
-   const uno::Reference< lang::XMultiServiceFactory>& 
xShapeFactory,
+void lcl_createButtons(const uno::Reference& xPageShapes,
+   const uno::Reference& 
xShapeFactory,
ChartModel& rModel,
awt::Rectangle& rRemainingSpace)
 {
@@ -2520,23 +2520,6 @@ void lcl_createButtons(const uno::Reference< 
drawing::XShapes>& xPageShapes,
 rRemainingSpace.Height -= (aSize.Height + 100 + 100);
 }
 
-if (xPivotTableDataProvider->getDataFields().hasElements())
-{
-x = 200;
-for (css::chart2::data::PivotTableFieldEntry const & rDataFieldEntry : 
xPivotTableDataProvider->getDataFields())
-{
-std::unique_ptr pButton(new VButton);
-pButton->init(xPageShapes, xShapeFactory);
-awt::Point aNewPosition = awt::Point(rRemainingSpace.X + x + 100, 
rRemainingSpace.Y + 100);
-pButton->setLabel(rDataFieldEntry.Name);
-pButton->setCID("FieldButton.Data." + 
OUString::number(rDataFieldEntry.DimensionIndex));
-pButton->createShapes(aNewPosition, aSize, xModelPage);
-x += aSize.Width + 100;
-}
-rRemainingSpace.Y += (aSize.Height + 100 + 100);
-rRemainingSpace.Height -= (aSize.Height + 100 + 100);
-}
-
 if (xPivotTableDataProvider->getRowFields().hasElements())
 {
 x = 200;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: chart2/source

[Tomaž Vajngerl]

 chart2/source/controller/main/ChartController_Window.cxx |8 
 1 file changed, 8 insertions(+)

New commits:
commit d30d50e2fdb84b572706f264237db5220ef17e38
Author: Tomaž Vajngerl 
Date:   Mon Apr 17 19:12:04 2017 +0200

tdf#107069 don't show "move" cursor on field buttons

Change-Id: I332cc7522eb98345d34cb411642189262d97744c
Reviewed-on: https://gerrit.libreoffice.org/36735
Tested-by: Jenkins 
Reviewed-by: Tomaž Vajngerl 

diff --git a/chart2/source/controller/main/ChartController_Window.cxx 
b/chart2/source/controller/main/ChartController_Window.cxx
index 441e8da6e682..7aa642c3cdba 100644
--- a/chart2/source/controller/main/ChartController_Window.cxx
+++ b/chart2/source/controller/main/ChartController_Window.cxx
@@ -1826,6 +1826,14 @@ void ChartController::impl_SetMousePointer( const 
MouseEvent & rEvent )
 sal_uInt16 nModifier = rEvent.GetModifier();
 bool bLeftDown = rEvent.IsLeft();
 
+// Check if object is for field button and set the normal arrow pointer in 
this case
+SdrObject* pObject = m_pDrawViewWrapper->getHitObject(aMousePos);
+if (pObject && pObject->GetName().startsWith("FieldButton"))
+{
+pChartWindow->SetPointer(Pointer(PointerStyle::Arrow));
+return;
+}
+
 if ( m_pDrawViewWrapper->IsTextEdit() )
 {
 if( m_pDrawViewWrapper->IsTextEditHit( aMousePos ) )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: chart2/source

[Tomaž Vajngerl]

 chart2/source/controller/main/ControllerCommandDispatch.cxx |   68 ++--
 1 file changed, 38 insertions(+), 30 deletions(-)

New commits:
commit df69f1c4aa8db8c9c48b364f0e8809be6d598fd9
Author: Tomaž Vajngerl 
Date:   Wed Apr 19 14:35:16 2017 +0200

tdf#107071 remove "Data Range" from context menu in a pivot chart

Change-Id: Idb0087941e64af3b3373fd9a041ac04b96705934
Reviewed-on: https://gerrit.libreoffice.org/36737
Tested-by: Jenkins 
Reviewed-by: Tomaž Vajngerl 

diff --git a/chart2/source/controller/main/ControllerCommandDispatch.cxx 
b/chart2/source/controller/main/ControllerCommandDispatch.cxx
index 35fa134db732..696c06d9e22d 100644
--- a/chart2/source/controller/main/ControllerCommandDispatch.cxx
+++ b/chart2/source/controller/main/ControllerCommandDispatch.cxx
@@ -19,6 +19,7 @@
 
 #include "ControllerCommandDispatch.hxx"
 #include "ChartModelHelper.hxx"
+#include "ChartModel.hxx"
 #include "DiagramHelper.hxx"
 #include "AxisHelper.hxx"
 #include "TitleHelper.hxx"
@@ -329,6 +330,7 @@ struct ModelState
 bool bIsReadOnly;
 bool bIsThreeD;
 bool bHasOwnData;
+bool bHasDataFromPivotTable;
 
 bool bHasMainTitle;
 bool bHasSubTitle;
@@ -361,34 +363,34 @@ struct ModelState
 };
 
 ModelState::ModelState() :
-bIsReadOnly( true ),
-bIsThreeD( false ),
-bHasOwnData( false ),
-bHasMainTitle( false ),
-bHasSubTitle( false ),
-bHasXAxisTitle( false ),
-bHasYAxisTitle( false ),
-bHasZAxisTitle( false ),
-bHasSecondaryXAxisTitle( false ),
-bHasSecondaryYAxisTitle( false ),
-bHasXAxis( false ),
-bHasYAxis( false ),
-bHasZAxis( false ),
-bHasAAxis( false ),
-bHasBAxis( false ),
-bHasMainXGrid( false ),
-bHasMainYGrid( false ),
-bHasMainZGrid( false ),
-bHasHelpXGrid( false ),
-bHasHelpYGrid( false ),
-bHasHelpZGrid( false ),
-bHasAutoScaledText( false ),
-bHasLegend( false ),
-bHasWall( false ),
-bHasFloor( false ),
-bSupportsStatistics( false ),
-bSupportsAxes( false )
-
+bIsReadOnly(true),
+bIsThreeD(false),
+bHasOwnData(false),
+bHasDataFromPivotTable(false),
+bHasMainTitle(false),
+bHasSubTitle(false),
+bHasXAxisTitle(false),
+bHasYAxisTitle(false),
+bHasZAxisTitle(false),
+bHasSecondaryXAxisTitle(false),
+bHasSecondaryYAxisTitle(false),
+bHasXAxis(false),
+bHasYAxis(false),
+bHasZAxis(false),
+bHasAAxis(false),
+bHasBAxis(false),
+bHasMainXGrid(false),
+bHasMainYGrid(false),
+bHasMainZGrid(false),
+bHasHelpXGrid(false),
+bHasHelpYGrid(false),
+bHasHelpZGrid(false),
+bHasAutoScaledText(false),
+bHasLegend(false),
+bHasWall(false),
+bHasFloor(false),
+bSupportsStatistics(false),
+bSupportsAxes(false)
 {}
 
 void ModelState::update( const Reference< frame::XModel > & xModel )
@@ -408,7 +410,12 @@ void ModelState::update( const Reference< frame::XModel > 
& xModel )
 bSupportsAxes = ChartTypeHelper::isSupportingMainAxis( xFirstChartType, 
nDimensionCount, 0 );
 
 bIsThreeD = (nDimensionCount == 3);
-bHasOwnData = (xChartDoc.is() && xChartDoc->hasInternalDataProvider());
+if (xChartDoc.is())
+{
+ChartModel* pModel = dynamic_cast(xChartDoc.get());
+bHasOwnData = pModel->hasInternalDataProvider();
+bHasDataFromPivotTable = pModel->isDataFromPivotTable();
+}
 
 bHasMainTitle =  TitleHelper::getTitle( TitleHelper::MAIN_TITLE, xModel 
).is();
 bHasSubTitle =   TitleHelper::getTitle( TitleHelper::SUB_TITLE, xModel 
).is();
@@ -613,7 +620,8 @@ void ControllerCommandDispatch::updateCommandAvailability()
 m_aCommandAvailability[ ".uno:FormatLegend" ] = m_aCommandAvailability[ 
".uno:Legend" ];
 
 // depending on own data
-m_aCommandAvailability[ ".uno:DataRanges" ] = bIsWritable && 
bModelStateIsValid && (! m_apModelState->bHasOwnData);
+m_aCommandAvailability[ ".uno:DataRanges" ] = bIsWritable && 
bModelStateIsValid &&
+  
(!m_apModelState->bHasOwnData) && (!m_apModelState->bHasDataFromPivotTable);
 m_aCommandAvailability[ ".uno:DiagramData" ] = bIsWritable && 
bModelStateIsValid &&  m_apModelState->bHasOwnData && bEnableDataTableDialog;
 
 // titles
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: Branch 'libreoffice-5-3' - loleaflet/dist

[Pranav Kant]

 loleaflet/dist/toolbar/toolbar.js |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit df488665232110dd760ad5cc56a10864fcafca68
Author: Pranav Kant 
Date:   Thu Jan 12 19:24:50 2017 +0530

loleaflet: Use tab here, not space

otherwise our linting tool will shout.

Change-Id: Ia43b0a4bfc3a1d3406a89e9bb71b05f884cce2a2
(cherry picked from commit fb967d998b64541223528dd19496597b2514aa43)
Reviewed-on: https://gerrit.libreoffice.org/36750
Reviewed-by: pranavk 
Tested-by: pranavk 

diff --git a/loleaflet/dist/toolbar/toolbar.js 
b/loleaflet/dist/toolbar/toolbar.js
index e4b7a0f3..31b9a018 100644
--- a/loleaflet/dist/toolbar/toolbar.js
+++ b/loleaflet/dist/toolbar/toolbar.js
@@ -1240,7 +1240,7 @@ function updateCommandValues() {
 }
 
 map.on('updatetoolbarcommandvalues', function(e) {
-   w2ui['toolbar-up'].refresh();
+   w2ui['toolbar-up'].refresh();
 });
 
 map.on('updateparts pagenumberchanged', function (e) {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/inc

[Eike Rathke]

 sc/inc/globstr.hrc | 1048 ++---
 1 file changed, 524 insertions(+), 524 deletions(-)

New commits:
commit e981f360c2216513469c5ff2a51350183e874436
Author: Eike Rathke 
Date:   Thu Apr 20 15:47:37 2017 +0200

renumber string IDs and close 40 gaps of resident empty strings

With the help of sc/util/number-defines-consecutively.awk

Change-Id: I1d2656ee8527cde6d6464b423a332401946f82a1

diff --git a/sc/inc/globstr.hrc b/sc/inc/globstr.hrc
index 80751fad3839..b8e6e81991d1 100644
--- a/sc/inc/globstr.hrc
+++ b/sc/inc/globstr.hrc
@@ -84,590 +84,590 @@
 #define STR_MSSG_MAKEOUTLINE_0  45
 #define STR_MSSG_REMOVEOUTLINE_046
 #define STR_MSSG_PASTEFROMCLIP_047
-#define STR_MSSG_MOVEBLOCKTO_0  49
-#define STR_MSSG_INSERTCELLS_0  50
-#define STR_MSSG_DELETECELLS_0  51
-#define STR_MSSG_MERGECELLS_0   52
-#define STR_MSSG_SOLVE_053
-#define STR_MSSG_SOLVE_154
-#define STR_MSSG_SOLVE_255
-#define STR_MSSG_SOLVE_356
-#define STR_MSSG_SOLVE_457
-
-#define STR_TABLE_GESAMTERGEBNIS58
-#define STR_TABLE_ERGEBNIS  59
-#define STR_UNDO_SPELLING   60
-#define STR_TABLE_UND   61
-#define STR_TABLE_ODER  62
-#define STR_UNDO_INSERTCELLS63
-#define STR_TABLE_DEF   64
-#define STR_MOVE_TO_END 65
-#define STR_NO_REF_TABLE67
-
-#define STR_PIVOT_TOTAL 68
-#define STR_PIVOT_DATA  69
-
-#define STR_COLUMN  72
-#define STR_ROW 73
-#define STR_LOAD_DOC74
-#define STR_SAVE_DOC75
-
-#define STR_AREA_ALREADY_INSERTED   77
-#define STR_INVALID_TABREF  78
-#define STR_INVALID_QUERYAREA   79
-
-#define STR_REIMPORT_EMPTY  80
-#define STR_NOMULTISELECT   81
-#define STR_FILL_SERIES_PROGRESS82 // documen3.cxx
-
-#define STR_COND_AND85
-
-#define STR_UNDO_PRINTRANGES86
-
-#define STR_UNDO_DEC_INDENT 87
-#define STR_UNDO_INC_INDENT 88
-#define STR_UNDO_THESAURUS  89
-
-#define STR_FILL_TAB90
-#define STR_NO_VALUE91 /* moved to compiler.src, keep 
define! */
-#define STR_UPDATE_SCENARIO 92
-#define STR_ERR_NEWSCENARIO 93
-#define STR_SCENARIO94
-#define STR_PIVOT_TABLE 95
-#define STR_NEWTABNAMENOTUNIQUE 96
-
-#define STR_FUN_TEXT_SUM97
-#define STR_FUN_TEXT_COUNT  98
-#define STR_FUN_TEXT_AVG99
-#define STR_FUN_TEXT_MEDIAN 100
-#define STR_FUN_TEXT_MAX101
-#define STR_FUN_TEXT_MIN102
-#define STR_FUN_TEXT_PRODUCT103
-#define STR_FUN_TEXT_STDDEV 104
-#define STR_FUN_TEXT_VAR105
-#define STR_DOC_STAT106
-
-#define STR_DBNAME_IMPORT   107
-
-#define STR_NOCHARTATCURSOR 108
-#define STR_NOAREASELECTED  109
-#define STR_INVALIDTABNAME  110
-
-#define STR_PIVOT_NOTFOUND  111
-#define STR_ERROR_STR   112
-#define STR_NV_STR  113 /* moved to compiler.src, keep 
define! */
-#define STR_EMPTYDATA   114
-#define STR_PIVOT_NODATA115
-#define STR_PIVOT_MOVENOTALLOWED116
-
-#define STR_PRINT_INVALID_AREA  117
-
-#define STR_PAGESTYLE   118
-#define STR_HEADER  119
-#define STR_FOOTER  120
-
-#define STR_TEXTATTRS   121
-
-#define STR_HFCMD_DELIMITER 122
-#define STR_HFCMD_PAGE  123
-#define STR_HFCMD_PAGES 124
-#define STR_HFCMD_DATE  125
-#define STR_HFCMD_TIME  126
-#define STR_HFCMD_FILE  127
-#define STR_HFCMD_TABLE 128
-
-#define STR_PROTECTIONERR   129
-
-#define STR_PAGEHEADER  130
-#define STR_PAGEFOOTER  131
-#define STR_PAGE132
-#define STR_LONG_ERR_ILL_ARG133
-#define STR_LONG_ERR_ILL_PAR134
-#define STR_LONG_ERR_ILL_FPO135
-#define STR_LONG_ERR_ILL_CHAR   136
+#define STR_MSSG_MOVEBLOCKTO_0  48
+#define STR_MSSG_INSERTCELLS_0  49
+#define STR_MSSG_DELETECELLS_0  50
+#define STR_MSSG_MERGECELLS_0   51
+#define STR_MSSG_SOLVE_052
+#define STR_MSSG_SOLVE_153
+#define STR_MSSG_SOLVE_254
+#define STR_MSSG_SOLVE_355
+#define STR_MSSG_SOLVE_456
+
+#define STR_TABLE_GESAMTERGEBNIS57
+#define STR_TABLE_ERGEBNIS  58
+#define STR_UNDO_SPELLING   59
+#define STR_TABLE_UND   60
+#define STR_TABLE_ODER  61
+#define STR_UNDO_INSERTCELLS62
+#define STR_TABLE_DEF   63
+#define STR_MOVE_TO_END 64
+#define STR_NO_REF_TABLE65
+
+#define STR_PIVOT_TOTAL 66
+#define 

[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - external/redland

[Michael Stahl]

 external/redland/UnpackedTarball_raptor.mk 
   |1 
 
external/redland/raptor/0001-Calcualte-max-nspace-declarations-correctly-for-XML-.patch.1
 |   43 ++
 2 files changed, 44 insertions(+)

New commits:
commit 8044b81f1eaa8ac40acf405d5de450e011c4a34c
Author: Michael Stahl 
Date:   Wed Apr 19 16:47:56 2017 +0200

redland: add raptor patch to fix some bugs

Change-Id: I4e3db61fdfe0b984d36b4f67f8e891da48f79ddb
(cherry picked from commit 8af6e5e0c4191b12d830b20f72ec3552eea15747)
Reviewed-on: https://gerrit.libreoffice.org/36694
Tested-by: Jenkins 
Reviewed-by: Miklos Vajna 

diff --git a/external/redland/UnpackedTarball_raptor.mk 
b/external/redland/UnpackedTarball_raptor.mk
index 762903018d43..a6260715588e 100644
--- a/external/redland/UnpackedTarball_raptor.mk
+++ b/external/redland/UnpackedTarball_raptor.mk
@@ -26,6 +26,7 @@ $(eval $(call gb_UnpackedTarball_add_patches,raptor,\
external/redland/raptor/ubsan.patch \
$(if $(SYSTEM_LIBXML),,external/redland/raptor/rpath.patch) \
external/redland/raptor/xml2-config.patch \
+   
external/redland/raptor/0001-Calcualte-max-nspace-declarations-correctly-for-XML-.patch.1
 \
 ))
 
 # vim: set noet sw=4 ts=4:
diff --git 
a/external/redland/raptor/0001-Calcualte-max-nspace-declarations-correctly-for-XML-.patch.1
 
b/external/redland/raptor/0001-Calcualte-max-nspace-declarations-correctly-for-XML-.patch.1
new file mode 100644
index ..6fa726cae6da
--- /dev/null
+++ 
b/external/redland/raptor/0001-Calcualte-max-nspace-declarations-correctly-for-XML-.patch.1
@@ -0,0 +1,43 @@
+From 590681e546cd9aa18d57dc2ea1858cb734a3863f Mon Sep 17 00:00:00 2001
+From: Dave Beckett 
+Date: Sun, 16 Apr 2017 23:15:12 +0100
+Subject: [PATCH] Calcualte max nspace declarations correctly for XML writer
+
+(raptor_xml_writer_start_element_common): Calculate max including for
+each attribute a potential name and value.
+
+Fixes Issues #617 http://bugs.librdf.org/mantis/view.php?id=617
+and #618 http://bugs.librdf.org/mantis/view.php?id=618
+---
+ src/raptor_xml_writer.c | 7 ---
+ 1 file changed, 4 insertions(+), 3 deletions(-)
+
+diff --git a/src/raptor_xml_writer.c b/src/raptor_xml_writer.c
+index 693b946..0d3a36a 100644
+--- a/src/raptor_xml_writer.c
 b/src/raptor_xml_writer.c
+@@ -181,9 +181,10 @@ raptor_xml_writer_start_element_common(raptor_xml_writer* 
xml_writer,
+   size_t nspace_declarations_count = 0;  
+   unsigned int i;
+ 
+-  /* max is 1 per element and 1 for each attribute + size of declared */
+   if(nstack) {
+-int nspace_max_count = element->attribute_count+1;
++int nspace_max_count = element->attribute_count * 2; /* attr and value */
++if(element->name->nspace)
++  nspace_max_count++;
+ if(element->declared_nspaces)
+   nspace_max_count += raptor_sequence_size(element->declared_nspaces);
+ if(element->xml_language)
+@@ -237,7 +238,7 @@ raptor_xml_writer_start_element_common(raptor_xml_writer* 
xml_writer,
+ }
+   }
+ 
+-  /* Add the attribute + value */
++  /* Add the attribute's value */
+   nspace_declarations[nspace_declarations_count].declaration=
+ raptor_qname_format_as_xml(element->attributes[i],
+
_declarations[nspace_declarations_count].length);
+-- 
+2.9.3
+
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sw/uiconfig

[Yousuf Philips]

 sw/uiconfig/swriter/toolbar/graphicobjectbar.xml |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 16e4d8004f1d6cb53efbaf026eafbea70504b154
Author: Yousuf Philips 
Date:   Thu Apr 20 17:06:59 2017 +0400

tdf87700 Hide rotate 180 in image toolbar

Change-Id: I2c956542735909f2a2eab2e261f248fec85b7211
Reviewed-on: https://gerrit.libreoffice.org/36741
Reviewed-by: Yousuf Philips 
Tested-by: Yousuf Philips 

diff --git a/sw/uiconfig/swriter/toolbar/graphicobjectbar.xml 
b/sw/uiconfig/swriter/toolbar/graphicobjectbar.xml
index d8d6b014fe77..287402963de5 100644
--- a/sw/uiconfig/swriter/toolbar/graphicobjectbar.xml
+++ b/sw/uiconfig/swriter/toolbar/graphicobjectbar.xml
@@ -28,7 +28,7 @@
  
  
  
- 
+ 
  
  
  
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: officecfg/registry sc/inc sc/sdi sc/source sc/uiconfig

[Gulsah Kose]

 officecfg/registry/data/org/openoffice/Office/UI/CalcCommands.xcu |5 ++
 sc/inc/sc.hrc |1 
 sc/sdi/cellsh.sdi |1 
 sc/sdi/scalc.sdi  |   18 
++
 sc/source/ui/view/cellsh.cxx  |1 
 sc/source/ui/view/cellsh1.cxx |   17 
+
 sc/uiconfig/scalc/menubar/menubar.xml |1 
 7 files changed, 44 insertions(+)

New commits:
commit 38ba5bfa215231f5937abebafd075a58c227e7ca
Author: Gulsah Kose 
Date:   Mon Apr 17 09:13:24 2017 +0300

tdf#107143 Add delete all comments command.

Change-Id: I1375375543172146a27ed4225f584121f9945a8c
Signed-off-by: Gulsah Kose 
Reviewed-on: https://gerrit.libreoffice.org/36623
Tested-by: Jenkins 
Reviewed-by: Eike Rathke 

diff --git a/officecfg/registry/data/org/openoffice/Office/UI/CalcCommands.xcu 
b/officecfg/registry/data/org/openoffice/Office/UI/CalcCommands.xcu
index 80cedf097f18..dc0797652f9f 100644
--- a/officecfg/registry/data/org/openoffice/Office/UI/CalcCommands.xcu
+++ b/officecfg/registry/data/org/openoffice/Office/UI/CalcCommands.xcu
@@ -961,6 +961,11 @@
   Hide All Comments
 
   
+  
+
+  Delete All Comments
+
+  
   
 
   Comm~ent
diff --git a/sc/inc/sc.hrc b/sc/inc/sc.hrc
index 83852ab497f8..aa32f3c66a42 100644
--- a/sc/inc/sc.hrc
+++ b/sc/inc/sc.hrc
@@ -643,6 +643,7 @@
 #define FID_HIDE_NOTE   (SID_NEW_SLOTS+101)
 #define FID_SHOW_ALL_NOTES  (SID_NEW_SLOTS+102)
 #define FID_HIDE_ALL_NOTES  (SID_NEW_SLOTS+103)
+#define FID_DELETE_ALL_NOTES(SID_NEW_SLOTS+104)
 
 // idl parameter
 
diff --git a/sc/sdi/cellsh.sdi b/sc/sdi/cellsh.sdi
index 96186e65fe15..8e80db555901 100644
--- a/sc/sdi/cellsh.sdi
+++ b/sc/sdi/cellsh.sdi
@@ -211,6 +211,7 @@ interface CellSelection
 FID_SHOW_NOTE   [ ExecMethod = ExecuteEdit; StateMethod = 
GetState; ]
 FID_HIDE_ALL_NOTES  [ ExecMethod = ExecuteEdit; StateMethod = 
GetState; ]
 FID_SHOW_ALL_NOTES  [ ExecMethod = ExecuteEdit; StateMethod = 
GetState; ]
+FID_DELETE_ALL_NOTES[ ExecMethod = ExecuteEdit; StateMethod = 
GetState; ]
 SID_DELETE_NOTE [ ExecMethod = ExecuteEdit; StateMethod = 
GetState; ]
 SID_DEC_INDENT  [ ExecMethod = ExecuteEdit; StateMethod = 
GetState; ]
 SID_INC_INDENT  [ ExecMethod = ExecuteEdit; StateMethod = 
GetState; ]
diff --git a/sc/sdi/scalc.sdi b/sc/sdi/scalc.sdi
index 1b3f90105ae6..f2737bffb9a2 100644
--- a/sc/sdi/scalc.sdi
+++ b/sc/sdi/scalc.sdi
@@ -3634,6 +3634,24 @@ SfxVoidItem HideAllNotes FID_HIDE_ALL_NOTES
 GroupId = GID_VIEW;
 ]
 
+SfxVoidItem DeleteAllNotes FID_DELETE_ALL_NOTES
+
+[
+AutoUpdate = FALSE,
+FastCall = FALSE,
+ReadOnlyDoc = TRUE,
+Toggle = FALSE,
+Container = FALSE,
+RecordAbsolute = FALSE,
+RecordPerSet;
+
+
+AccelConfig = TRUE,
+MenuConfig = TRUE,
+ToolBoxConfig = TRUE,
+GroupId = GID_VIEW;
+]
+
 SfxVoidItem DeleteNote SID_DELETE_NOTE
 (SvxPostItIdItem Id SID_ATTR_POSTIT_ID)
 [
diff --git a/sc/source/ui/view/cellsh.cxx b/sc/source/ui/view/cellsh.cxx
index ca710f4376c5..b432808cbebc 100644
--- a/sc/source/ui/view/cellsh.cxx
+++ b/sc/source/ui/view/cellsh.cxx
@@ -1045,6 +1045,7 @@ void ScCellShell::GetState(SfxItemSet )
 
 case FID_SHOW_ALL_NOTES:
 case FID_HIDE_ALL_NOTES:
+case FID_DELETE_ALL_NOTES:
 {
 bool bHasNotes = false;
 for (auto const& rTab : rMark.GetSelectedTabs())
diff --git a/sc/source/ui/view/cellsh1.cxx b/sc/source/ui/view/cellsh1.cxx
index f16b182ba4b3..ee3d5b714361 100644
--- a/sc/source/ui/view/cellsh1.cxx
+++ b/sc/source/ui/view/cellsh1.cxx
@@ -2379,6 +2379,23 @@ void ScCellShell::ExecuteEdit( SfxRequest& rReq )
 }
 break;
 
+case FID_DELETE_ALL_NOTES:
+{
+ScViewData* pData  = GetViewData();
+ScMarkData& rMark  = pData->GetMarkData();
+ScMarkData  aNewMark;
+ScRangeList aRangeList;
+
+for (auto const& rTab : rMark.GetSelectedTabs())
+{
+aRangeList.Append(ScRange(0,0,rTab,MAXCOL,MAXROW,rTab));
+}
+
+aNewMark.MarkFromRangeList( aRangeList, true );
+pData->GetDocShell()->GetDocFunc().DeleteContents(aNewMark, 
InsertDeleteFlags::NOTE, true, false );
+}
+break;
+
 case SID_CHARMAP:
 if( pReqArgs != nullptr )
 {
diff --git a/sc/uiconfig/scalc/menubar/menubar.xml 
b/sc/uiconfig/scalc/menubar/menubar.xml
index 647c87db3c8f..afb04b77c26b 100644
--- 

[Libreoffice-commits] libvisio.git: src/lib

[David Tardon]

 src/lib/libvisio_xml.cpp |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit ce4e77cc8c716db1080bdebd63393268ff075aa6
Author: David Tardon 
Date:   Thu Apr 20 16:04:09 2017 +0200

avoid possible null ptr deref.

Change-Id: I61807799dd0a36d9796d4580d85068207e92e26b

diff --git a/src/lib/libvisio_xml.cpp b/src/lib/libvisio_xml.cpp
index 18214b2..225d42f 100644
--- a/src/lib/libvisio_xml.cpp
+++ b/src/lib/libvisio_xml.cpp
@@ -96,7 +96,8 @@ void XMLErrorWatcher::setError()
 xmlTextReaderPtr xmlReaderForStream(librevenge::RVNGInputStream *input, const 
char *URL, const char *encoding, int options, XMLErrorWatcher *const watcher)
 {
   xmlTextReaderPtr reader = xmlReaderForIO(vsdxInputReadFunc, 
vsdxInputCloseFunc, (void *)input, URL, encoding, options);
-  xmlTextReaderSetErrorHandler(reader, vsdxReaderErrorFunc, watcher);
+  if (reader)
+xmlTextReaderSetErrorHandler(reader, vsdxReaderErrorFunc, watcher);
   return reader;
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: officecfg/registry sw/uiconfig sw/UIConfig_swriter.mk

[Yousuf Philips]

 officecfg/registry/data/org/openoffice/Office/UI/WriterWindowState.xcu |   23 
++
 sw/UIConfig_swriter.mk |1 
 sw/uiconfig/swriter/toolbar/textstylebar.xml   |   93 
++
 3 files changed, 117 insertions(+)

New commits:
commit e3cfb753524ecfabc07bccef5f5b2b54d06cd444
Author: Yousuf Philips 
Date:   Thu Apr 20 17:01:10 2017 +0400

tdf#106781 Style-focused formatting toolbar for writer

Change-Id: I941c49aa502fa2757bb7f6a1d0cba4d02f00e686
Reviewed-on: https://gerrit.libreoffice.org/36717
Reviewed-by: Yousuf Philips 
Tested-by: Yousuf Philips 

diff --git 
a/officecfg/registry/data/org/openoffice/Office/UI/WriterWindowState.xcu 
b/officecfg/registry/data/org/openoffice/Office/UI/WriterWindowState.xcu
index ac0b4c2a750c..755929281ca3 100644
--- a/officecfg/registry/data/org/openoffice/Office/UI/WriterWindowState.xcu
+++ b/officecfg/registry/data/org/openoffice/Office/UI/WriterWindowState.xcu
@@ -912,6 +912,29 @@
   false
 
   
+  
+
+  0,2
+
+
+  true
+
+
+  0
+
+
+  Formatting (Styles)
+
+
+  false
+
+
+  false
+
+
+  true
+
+  
 
   
 
diff --git a/sw/UIConfig_swriter.mk b/sw/UIConfig_swriter.mk
index 86fe9b7e503d..3be87d04f098 100644
--- a/sw/UIConfig_swriter.mk
+++ b/sw/UIConfig_swriter.mk
@@ -79,6 +79,7 @@ $(eval $(call gb_UIConfig_add_toolbarfiles,modules/swriter,\
sw/uiconfig/swriter/toolbar/symbolshapes \
sw/uiconfig/swriter/toolbar/tableobjectbar \
sw/uiconfig/swriter/toolbar/textobjectbar \
+   sw/uiconfig/swriter/toolbar/textstylebar \
sw/uiconfig/swriter/toolbar/toolbar \
sw/uiconfig/swriter/toolbar/viewerbar \
 ))
diff --git a/sw/uiconfig/swriter/toolbar/textstylebar.xml 
b/sw/uiconfig/swriter/toolbar/textstylebar.xml
new file mode 100644
index ..802a9d997721
--- /dev/null
+++ b/sw/uiconfig/swriter/toolbar/textstylebar.xml
@@ -0,0 +1,93 @@
+
+
+
+http://openoffice.org/2001/toolbar; 
xmlns:xlink="http://www.w3.org/1999/xlink; toolbar:id="toolbar">
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: 2 commits - svl/source sw/inc sw/source

[Noel Grandin]

 svl/source/fsstor/fsstorage.cxx   |   20 +++-
 sw/inc/htmltbl.hxx|   20 ++--
 sw/source/core/doc/htmltbl.cxx|   14 ++
 sw/source/filter/html/htmltab.cxx |   22 ++
 4 files changed, 25 insertions(+), 51 deletions(-)

New commits:
commit d21d14c112312c639383ba9d9091380327dc0717
Author: Noel Grandin 
Date:   Wed Apr 19 11:17:52 2017 +0200

loplugin:inlinefields in SwHTMLTableLayout

and make the memory management a little more obvious with
std::unique_ptr.

Change-Id: Ie0dad6a52f70896e144cc396d39c10e9cbff4316
Reviewed-on: https://gerrit.libreoffice.org/36667
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/sw/inc/htmltbl.hxx b/sw/inc/htmltbl.hxx
index 5dfb2eb56b57..4aec0834be6e 100644
--- a/sw/inc/htmltbl.hxx
+++ b/sw/inc/htmltbl.hxx
@@ -173,8 +173,8 @@ class SwHTMLTableLayout
 {
 Timer m_aResizeTimer; ///< Timer for DelayedResize.
 
-SwHTMLTableLayoutColumn **m_aColumns;
-SwHTMLTableLayoutCell **m_aCells;
+std::vector m_aColumns;
+std::vector   m_aCells;
 
 const SwTable *m_pSwTable;///< SwTable (Top-Table only).
 SwTableBox *m_pLeftFillerBox; ///< Left filler-box (table in table 
only).
@@ -278,10 +278,10 @@ public:
 sal_uInt16 nParentInhSpace=0 );
 
 inline SwHTMLTableLayoutColumn *GetColumn( sal_uInt16 nCol ) const;
-inline void SetColumn( SwHTMLTableLayoutColumn *pCol, sal_uInt16 nCol );
+inline void SetColumn( std::unique_ptr pCol, 
sal_uInt16 nCol );
 
 inline SwHTMLTableLayoutCell *GetCell( sal_uInt16 nRow, sal_uInt16 nCol ) 
const;
-inline void SetCell( SwHTMLTableLayoutCell *pCell, sal_uInt16 nRow, 
sal_uInt16 nCol );
+inline void SetCell( std::unique_ptr pCell, 
sal_uInt16 nRow, sal_uInt16 nCol );
 
 void SetLeftFillerBox( SwTableBox *pBox ) { m_pLeftFillerBox = pBox; }
 void SetRightFillerBox( SwTableBox *pBox ) { m_pRightFillerBox = pBox; }
@@ -410,7 +410,7 @@ inline sal_uInt16 SwHTMLTableLayout::GetInhCellSpace( 
sal_uInt16 nCol,
 
 inline SwHTMLTableLayoutColumn *SwHTMLTableLayout::GetColumn( sal_uInt16 nCol 
) const
 {
-return m_aColumns[nCol];
+return m_aColumns[nCol].get();
 }
 
 inline void SwHTMLTableLayoutColumn::SetWidthOption( sal_uInt16 nWidth )
@@ -419,20 +419,20 @@ inline void SwHTMLTableLayoutColumn::SetWidthOption( 
sal_uInt16 nWidth )
 bRelWidthOption = true;
 }
 
-inline void SwHTMLTableLayout::SetColumn( SwHTMLTableLayoutColumn *pCol, 
sal_uInt16 nCol )
+inline void SwHTMLTableLayout::SetColumn( 
std::unique_ptr pCol, sal_uInt16 nCol )
 {
-m_aColumns[nCol] = pCol;
+m_aColumns[nCol] = std::move(pCol);
 }
 
 inline SwHTMLTableLayoutCell *SwHTMLTableLayout::GetCell( sal_uInt16 nRow, 
sal_uInt16 nCol ) const
 {
-return m_aCells[nRow*m_nCols+nCol];
+return m_aCells[nRow*m_nCols+nCol].get();
 }
 
-inline void SwHTMLTableLayout::SetCell( SwHTMLTableLayoutCell *pCell,
+inline void SwHTMLTableLayout::SetCell( std::unique_ptr 
pCell,
sal_uInt16 nRow, sal_uInt16 nCol )
 {
-m_aCells[nRow*m_nCols+nCol] = pCell;
+m_aCells[nRow*m_nCols+nCol] = std::move(pCell);
 }
 
 inline long SwHTMLTableLayout::GetBrowseWidthMin() const
diff --git a/sw/source/core/doc/htmltbl.cxx b/sw/source/core/doc/htmltbl.cxx
index b29806314fa9..e15f70aae6e3 100644
--- a/sw/source/core/doc/htmltbl.cxx
+++ b/sw/source/core/doc/htmltbl.cxx
@@ -168,8 +168,8 @@ SwHTMLTableLayout::SwHTMLTableLayout( const SwTable * 
pTable,
   sal_uInt16 nRightBWidth,
   sal_uInt16 nInhLeftBWidth,
   sal_uInt16 nInhRightBWidth )
-: m_aColumns( new SwHTMLTableLayoutColumn*[nCls] )
-, m_aCells( new SwHTMLTableLayoutCell*[static_cast(nRws)*nCls] )
+: m_aColumns( nCls )
+, m_aCells( static_cast(nRws)*nCls )
 , m_pSwTable( pTable )
 , m_pLeftFillerBox( nullptr )
 , m_pRightFillerBox( nullptr )
@@ -216,16 +216,6 @@ SwHTMLTableLayout::SwHTMLTableLayout( const SwTable * 
pTable,
 
 SwHTMLTableLayout::~SwHTMLTableLayout()
 {
-sal_uInt16 i;
-
-for( i = 0; i < m_nCols; i++ )
-delete m_aColumns[i];
-delete[] m_aColumns;
-
-sal_uInt16 nCount = m_nRows*m_nCols;
-for( i=0; i

[Libreoffice-commits] core.git: editeng/source include/editeng

[Noel Grandin]

 editeng/source/editeng/edtspell.cxx |3 +--
 editeng/source/editeng/edtspell.hxx |2 +-
 editeng/source/misc/splwrap.cxx |5 ++---
 include/editeng/splwrap.hxx |2 +-
 4 files changed, 5 insertions(+), 7 deletions(-)

New commits:
commit ea537ecffa217e8ca3039998926accf27f6b12c0
Author: Noel Grandin 
Date:   Wed Apr 19 11:47:44 2017 +0200

SvxSpellWrapper::ReplaceAll doesn't use it's second param

Change-Id: I79b82d37e6cf4c1dde474f0f90b6370c2359a0b3
Reviewed-on: https://gerrit.libreoffice.org/36673
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/editeng/source/editeng/edtspell.cxx 
b/editeng/source/editeng/edtspell.cxx
index dee67164f66e..cc4095f981e1 100644
--- a/editeng/source/editeng/edtspell.cxx
+++ b/editeng/source/editeng/edtspell.cxx
@@ -136,8 +136,7 @@ bool EditSpellWrapper::SpellMore()
 return bMore;
 }
 
-void EditSpellWrapper::ReplaceAll( const OUString ,
-sal_Int16 )
+void EditSpellWrapper::ReplaceAll( const OUString  )
 {
 // Is called when the word is in ReplaceList of the spell checker
 pEditView->InsertText( rNewText );
diff --git a/editeng/source/editeng/edtspell.hxx 
b/editeng/source/editeng/edtspell.hxx
index 1a2bca363b84..23105fb84425 100644
--- a/editeng/source/editeng/edtspell.hxx
+++ b/editeng/source/editeng/edtspell.hxx
@@ -46,7 +46,7 @@ private:
 protected:
 virtual voidSpellStart( SvxSpellArea eArea ) override;
 virtual voidSpellContinue() override;// Check area
-virtual voidReplaceAll( const OUString , sal_Int16 
nLanguage ) override;
+virtual voidReplaceAll( const OUString  ) override;
 virtual boolSpellMore() override;
 virtual boolHasOtherCnt() override;
 
diff --git a/editeng/source/misc/splwrap.cxx b/editeng/source/misc/splwrap.cxx
index 0ae986e5258e..7c7169a9a53f 100644
--- a/editeng/source/misc/splwrap.cxx
+++ b/editeng/source/misc/splwrap.cxx
@@ -253,7 +253,7 @@ void SvxSpellWrapper::SpellContinue()
 {
 }
 
-void SvxSpellWrapper::ReplaceAll( const OUString &, sal_Int16 )
+void SvxSpellWrapper::ReplaceAll( const OUString & )
 {   // Replace Word from the Replace list
 }
 
@@ -471,8 +471,7 @@ bool SvxSpellWrapper::FindSpellError()
 if (xEntry.is())
 {
 // replace word without asking
-ReplaceAll( xEntry->getReplacementText(),
-LanguageTag( xAlt->getLocale() 
).getLanguageType() );
+ReplaceAll( xEntry->getReplacementText() );
 }
 else
 bSpell = false;
diff --git a/include/editeng/splwrap.hxx b/include/editeng/splwrap.hxx
index 5d40fcbf3e0e..e5c4df4b9ff5 100644
--- a/include/editeng/splwrap.hxx
+++ b/include/editeng/splwrap.hxx
@@ -107,7 +107,7 @@ protected:
 virtual void SpellStart( SvxSpellArea eSpell ); // Preparing the area
 virtual void SpellContinue(); // Check Areas
   // Result available through GetLast
-virtual void ReplaceAll( const OUString , sal_Int16 nLanguage ); 
//Replace word from the replace list
+virtual void ReplaceAll( const OUString  ); //Replace word from 
the replace list
 static css::uno::Reference< css::linguistic2::XDictionary >
  GetAllRightDic();
 virtual void SpellEnd();// Finish area
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: include/vcl vcl/source

[Noel Grandin]

 include/vcl/field.hxx |1 -
 vcl/source/control/field2.cxx |1 -
 2 files changed, 2 deletions(-)

New commits:
commit 1f73ac90da31b62ccf6f040c68e5c0150171240f
Author: Noel Grandin 
Date:   Wed Apr 19 13:33:47 2017 +0200

mnDateFormat in DateFormatter is unused

ever since it was added in

   commit c8330937878a57c74b4f3e3083c013ed0903f80d
   Author: Vladimir Glazounov 
   Date:   Wed Apr 11 16:52:58 2007 +
   INTEGRATION: CWS hedaburemove01 (1.1.2); FILE ADDED

Change-Id: Iceb44ea4da620e1e7b9c9494486954db9e5d7959
Reviewed-on: https://gerrit.libreoffice.org/36691
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/include/vcl/field.hxx b/include/vcl/field.hxx
index f78a565d9374..934f922411a4 100644
--- a/include/vcl/field.hxx
+++ b/include/vcl/field.hxx
@@ -277,7 +277,6 @@ private:
 DatemaMax;
 boolmbLongFormat;
 boolmbShowDateCentury;
-sal_uInt16  mnDateFormat;
 ExtDateFieldFormat  mnExtDateFormat;
 boolmbEnforceValidValue;
 
diff --git a/vcl/source/control/field2.cxx b/vcl/source/control/field2.cxx
index 51fc1f6607e7..da5a3aa97601 100644
--- a/vcl/source/control/field2.cxx
+++ b/vcl/source/control/field2.cxx
@@ -1415,7 +1415,6 @@ void DateFormatter::ImplInit()
 mbLongFormat= false;
 mbShowDateCentury   = true;
 mpCalendarWrapper   = nullptr;
-mnDateFormat= 0x;
 mnExtDateFormat = ExtDateFieldFormat::SystemShort;
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: 2 commits - loleaflet/src

[Pranav Kant]

 loleaflet/src/layer/AnnotationManager.js |   24 
 1 file changed, 12 insertions(+), 12 deletions(-)

New commits:
commit ee683c106cd8421600b2141cb43c25e5e8dd1af0
Author: Pranav Kant 
Date:   Thu Apr 20 12:42:16 2017 +0530

loleaflet: Fix incorrect variable usage in this loop

Change-Id: I586ad59874b901d31b6e138a74577ecf3e1920c3

diff --git a/loleaflet/src/layer/AnnotationManager.js 
b/loleaflet/src/layer/AnnotationManager.js
index e739930d..88fbcaba 100644
--- a/loleaflet/src/layer/AnnotationManager.js
+++ b/loleaflet/src/layer/AnnotationManager.js
@@ -280,7 +280,7 @@ L.AnnotationManager = L.Class.extend({
var scale = this._map.getZoomScale(this._map.getZoom(), 10);
var docRight = 
this._map.project(this._map.options.maxBounds.getNorthEast()).subtract(this.options.extraSize.multiplyBy(scale));
var topRight = docRight.add(L.point(this.options.marginX, 
this.options.marginY));
-   var latlng, layoutBounds, point, index;
+   var latlng, layoutBounds, point, idx;
if (this._selected) {
var selectIndexFirst = 
this.getRootIndexOf(this._selected._data.id);
var selectIndexLast = 
this.getLastChildIndexOf(this._selected._data.id);
@@ -293,7 +293,7 @@ L.AnnotationManager = L.Class.extend({
layoutBounds = 
this._items[selectIndexFirst].getBounds();
 
// Adjust child comments too, if any
-   for (var idx = selectIndexFirst + 1; idx <= 
selectIndexLast; idx++) {
+   for (idx = selectIndexFirst + 1; idx <= 
selectIndexLast; idx++) {
if (zoom) {
this._items[idx]._data.anchorPix = 
this._map._docLayer._twipsToPixels(this._items[idx]._data.anchorPos.min);
}
@@ -310,9 +310,9 @@ L.AnnotationManager = L.Class.extend({
layoutBounds.max = 
layoutBounds.max.add([this.options.marginX, 0]);
layoutBounds.extend(layoutBounds.min.subtract([0, 
this.options.marginY]));
layoutBounds.extend(layoutBounds.max.add([0, 
this.options.marginY]));
-   for (index = selectIndexFirst - 1; index >= 0;) {
+   for (idx = selectIndexFirst - 1; idx >= 0;) {
var commentThread = [];
-   var tmpIdx = index;
+   var tmpIdx = idx;
do {
if (zoom) {

this._items[idx]._data.anchorPix = 
this._map._docLayer._twipsToPixels(this._items[idx]._data.anchorPos.min);
@@ -324,11 +324,11 @@ L.AnnotationManager = L.Class.extend({
commentThread.reverse();
// All will have some anchor position
this.layoutUp(commentThread, 
this._map.unproject(L.point(topRight.x, commentThread[0]._data.anchorPix.y)), 
layoutBounds);
-   index = index - commentThread.length;
+   idx = idx - commentThread.length;
}
-   for (index = selectIndexLast + 1; index < 
this._items.length;) {
+   for (idx = selectIndexLast + 1; idx < 
this._items.length;) {
commentThread = [];
-   tmpIdx = index;
+   tmpIdx = idx;
do {
if (zoom) {

this._items[idx]._data.anchorPix = 
this._map._docLayer._twipsToPixels(this._items[idx]._data.anchorPos.min);
@@ -339,7 +339,7 @@ L.AnnotationManager = L.Class.extend({
 
// All will have some anchor position
this.layoutDown(commentThread, 
this._map.unproject(L.point(topRight.x, commentThread[0]._data.anchorPix.y)), 
layoutBounds);
-   index = index + commentThread.length;
+   idx = idx + commentThread.length;
}
if (!this._selected.isEdit()) {
this._selected.show();
@@ -347,9 +347,9 @@ L.AnnotationManager = L.Class.extend({
} else {
point = 
this._map.latLngToLayerPoint(this._map.unproject(topRight));
layoutBounds = L.bounds(point, point);
-   for (index = 0; index < this._items.length;) {
+   for (idx = 0; idx < this._items.length;) {
commentThread = [];
-   tmpIdx = index;
+   

[Libreoffice-commits] dictionaries.git: Changes to 'refs/tags/cp-5.3-6'

[Krunoslav Šebetić]

Tag 'cp-5.3-6' created by Andras Timar  at 
2017-04-20 07:39 +

cp-5.3-6

Changes since libreoffice-5-3-branch-point-5:
---
 0 files changed
---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] translations.git: Changes to 'refs/tags/cp-5.3-6'

[Christian Lohmaier]

Tag 'cp-5.3-6' created by Andras Timar  at 
2017-04-20 07:39 +

cp-5.3-6

Changes since cp-5.3-4-3:
---
 0 files changed
---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] help.git: Changes to 'refs/tags/cp-5.3-6'

[Andras Timar]

Tag 'cp-5.3-6' created by Andras Timar  at 
2017-04-20 07:39 +

cp-5.3-6

Changes since libreoffice-5-3-branch-point-28:
---
 0 files changed
---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/tags/cp-5.3-6'

[Christian Lohmaier]

Tag 'cp-5.3-6' created by Andras Timar  at 
2017-04-20 07:39 +

cp-5.3-6

Changes since cp-5.3-5-55:
---
 0 files changed
---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: icon-themes/breeze icon-themes/breeze_dark icon-themes/breeze_svg officecfg/registry

[andreas kainz]

 icon-themes/breeze/links.txt|2 ++
 icon-themes/breeze_dark/links.txt   |2 ++
 icon-themes/breeze_svg/links.txt|2 ++
 officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu |3 +++
 4 files changed, 9 insertions(+)

New commits:
commit b1cd3eebf74345d18b47d2de0d4d0e81ef0d7b96
Author: andreas kainz 
Date:   Thu Apr 20 00:13:35 2017 +0200

tdf#107277 add update all icon for writer menu

Change-Id: Iaada61d19c601aa01bba85323e815872feae2c4a
Reviewed-on: https://gerrit.libreoffice.org/36705
Reviewed-by: Heiko Tietze 
Tested-by: Heiko Tietze 

diff --git a/icon-themes/breeze/links.txt b/icon-themes/breeze/links.txt
index 4ed3f1e5de1a..225600825ade 100644
--- a/icon-themes/breeze/links.txt
+++ b/icon-themes/breeze/links.txt
@@ -748,12 +748,14 @@ cmd/lc_refresh.png cmd/lc_reload.png
 cmd/lc_refreshformcontrol.png cmd/lc_reload.png
 cmd/lc_draw.png cmd/lc_reload.png
 cmd/lc_updateallindexes.png cmd/lc_reload.png
+cmd/lc_updateall.png cmd/lc_reload.png
 cmd/sc_refresh.png cmd/sc_reload.png
 cmd/sc_refreshformcontrol.png cmd/sc_reload.png
 cmd/sc_styleupdatebyexample.png cmd/sc_reload.png
 cmd/sc_draw.png cmd/sc_reload.png
 cmd/sc_updatecurindex.png cmd/sc_reload.png
 cmd/sc_updateallindexes.png cmd/sc_reload.png
+cmd/sc_updateall.png cmd/sc_reload.png
 
 # Select
 cmd/lc_selectmode.png cmd/lc_selectobject.png
diff --git a/icon-themes/breeze_dark/links.txt 
b/icon-themes/breeze_dark/links.txt
index 4ed3f1e5de1a..225600825ade 100644
--- a/icon-themes/breeze_dark/links.txt
+++ b/icon-themes/breeze_dark/links.txt
@@ -748,12 +748,14 @@ cmd/lc_refresh.png cmd/lc_reload.png
 cmd/lc_refreshformcontrol.png cmd/lc_reload.png
 cmd/lc_draw.png cmd/lc_reload.png
 cmd/lc_updateallindexes.png cmd/lc_reload.png
+cmd/lc_updateall.png cmd/lc_reload.png
 cmd/sc_refresh.png cmd/sc_reload.png
 cmd/sc_refreshformcontrol.png cmd/sc_reload.png
 cmd/sc_styleupdatebyexample.png cmd/sc_reload.png
 cmd/sc_draw.png cmd/sc_reload.png
 cmd/sc_updatecurindex.png cmd/sc_reload.png
 cmd/sc_updateallindexes.png cmd/sc_reload.png
+cmd/sc_updateall.png cmd/sc_reload.png
 
 # Select
 cmd/lc_selectmode.png cmd/lc_selectobject.png
diff --git a/icon-themes/breeze_svg/links.txt b/icon-themes/breeze_svg/links.txt
index 4ed3f1e5de1a..225600825ade 100644
--- a/icon-themes/breeze_svg/links.txt
+++ b/icon-themes/breeze_svg/links.txt
@@ -748,12 +748,14 @@ cmd/lc_refresh.png cmd/lc_reload.png
 cmd/lc_refreshformcontrol.png cmd/lc_reload.png
 cmd/lc_draw.png cmd/lc_reload.png
 cmd/lc_updateallindexes.png cmd/lc_reload.png
+cmd/lc_updateall.png cmd/lc_reload.png
 cmd/sc_refresh.png cmd/sc_reload.png
 cmd/sc_refreshformcontrol.png cmd/sc_reload.png
 cmd/sc_styleupdatebyexample.png cmd/sc_reload.png
 cmd/sc_draw.png cmd/sc_reload.png
 cmd/sc_updatecurindex.png cmd/sc_reload.png
 cmd/sc_updateallindexes.png cmd/sc_reload.png
+cmd/sc_updateall.png cmd/sc_reload.png
 
 # Select
 cmd/lc_selectmode.png cmd/lc_selectobject.png
diff --git 
a/officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu 
b/officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu
index d4c6586567f0..e8ecf2769b41 100644
--- a/officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu
+++ b/officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu
@@ -344,6 +344,9 @@
 
   ~Update All
 
+
+  1
+
   
   
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 107303] Crash on opening file

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107303

Buovjaga  changed:

   What|Removed |Added

 CC||todven...@suomi24.fi

--- Comment #4 from Buovjaga  ---
No crash here.

Henry: could you please copy and paste the text from "LibreOffice - About
LibreOffice" menu?

Version: 5.3.2.2
Build ID: 6cd4f1ef626f15116896b1d8e1398b56da0d0ee1
CPU Threads: 4; OS Version: Mac OS X 10.12.4; UI Render: default; Layout
Engine: new; 
Locale: en-US (en_FI.UTF-8); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103064] Introduce a comment style

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103064

--- Comment #14 from Yousuf Philips (jay)  ---
(In reply to Thomas Lendo from comment #11)
> Now, every comment has its own character style (which are invisible for end
> users; I learned that for my research in bug 107095, comment 4).

>From what i saw in the xml file, this isnt accurate. Each character style
combination has its own character style entry, but each comment has a paragraph
style parenting all child text entries.


   Ich bin 
   noch ein Test
   .


Unfortunately, the P1 paragraph style doesnt have font name and size assigned
to them, so each character style has font name and size assigned to them.

> I would use that fact to keep work in this bug as easy/short as possible:
> - Handle comment styles as character styles in the character style list.

Exposing each comment character style combination in the character style list
would be useless to users.

> - Initially, all comments should have the same default character style.

This already happens.

> - What's possible in character styles should be possible for end users to
> format comments. (In MSO Word 2013, the same (character) formatting is
> possible for comments as for normal text.)

Ideally comments would have no formatting at all, this is how it is in Google
Docs, or alternatively font name and size would be disabled, MS Word disables
font size.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107309] VIEWING: and skip over rows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107309

Terrence Enger  changed:

   What|Removed |Added

 Attachment #132725|exampl spreadsheet  |example spreadsheet
description||

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107043] EDITING: Horizontal table borders are disappearing and reappearing with OpenGL enabled

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107043

Telesto  changed:

   What|Removed |Added

Summary|EDITING: Horizontal table   |EDITING: Horizontal table
   |borders are disappearing|borders are disappearing
   |and reappearing |and reappearing with OpenGL
   ||enabled

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106781] Addition of a style-focused formatting toolbar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106781

--- Comment #23 from Yousuf Philips (jay)  ---
(In reply to Thomas Lendo from comment #21)
> Is it possible (or is it already implemented) to only show the Style-focused
> formatting toolbar in situations when the Formatting toolbar is shown too?

I had tried to do it in the commit, but wasnt able to get that functionality
working, so i'll have to leave it to a dev to look into. So to solve the issue,
i placed the toolbar as a 3rd toolbar, so no constant jumping happens.

(In reply to LibreTraining from comment #22)
> Adobe InDesign has pre-defined and customizable Workspace options.
> This changes the toolbars and the sidebars all at once.

LibreOffice has a similar feature in the View > Toolbars and once we have
additional focused toolbars geared towards specific workflows, we'll additional
toolbar layouts for them.

> And, Yes, I did mean frame styles, object styles is the similar feature in
> InDesign. :-)

As LO doesnt have any styled predefined frame styles, it cant be incorporated
into the toolbar at present. I'd suggest you submit an enhancement request for
the creation of a good set of predefined styled frame-type styles that could be
used.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 106781] Addition of a style-focused formatting toolbar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106781

--- Comment #23 from Yousuf Philips (jay)  ---
(In reply to Thomas Lendo from comment #21)
> Is it possible (or is it already implemented) to only show the Style-focused
> formatting toolbar in situations when the Formatting toolbar is shown too?

I had tried to do it in the commit, but wasnt able to get that functionality
working, so i'll have to leave it to a dev to look into. So to solve the issue,
i placed the toolbar as a 3rd toolbar, so no constant jumping happens.

(In reply to LibreTraining from comment #22)
> Adobe InDesign has pre-defined and customizable Workspace options.
> This changes the toolbars and the sidebars all at once.

LibreOffice has a similar feature in the View > Toolbars and once we have
additional focused toolbars geared towards specific workflows, we'll additional
toolbar layouts for them.

> And, Yes, I did mean frame styles, object styles is the similar feature in
> InDesign. :-)

As LO doesnt have any styled predefined frame styles, it cant be incorporated
into the toolbar at present. I'd suggest you submit an enhancement request for
the creation of a good set of predefined styled frame-type styles that could be
used.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 107306] Need Of Italic Characters

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107306

V Stuart Foote  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||vstuart.fo...@utsa.edu
 Resolution|--- |INVALID

--- Comment #1 from V Stuart Foote  ---
Any modern OTF/TTF font installed to system will be available. Bitmap and Type1
postscript are no longer supported, but I don't believe that is what you seek.

You can use any OpenSource or commercial font foundry you would like--just be
sure to select and install TTF, OTF, or Graphite flavors.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107309] VIEWING: and skip over rows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107309

--- Comment #1 from Terrence Enger  ---
Created attachment 132725
  --> https://bugs.documentfoundation.org/attachment.cgi?id=132725=edit
exampl spreadsheet

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-qa] minutes of ESC call ...

[Michael Meeks]

* Present:
+ Bjoern, JanI, Thorsten, Michael M, Sophie, Xisco, Kendy, Oivier,
  Heiko, Miklos, Stephan, Christian, Michael S, Eike

* Completed Action Items:
+ Send sorted & rated GSoC document to the mentors (Thorsten)
+ file twitter commit notification bot easy-hack (Cloph)

* Pending Action Items:
+ mass conversion of helpcontent (Cloph)
   [ still dealing with the UI bits ]
+ look at old Duden extension to see if they use UWINAPI.DLL (Thorsten)
+ release note drop of OSX 10.8 support re: thread-safe statics (Michael S)

* ESC budget tendering (Florian)
+ https://wiki.documentfoundation.org/Development/Budget2017
+ would like to gather a few ESC members for feedback, approval
  (and possibly review of bids)
+ tenders approved in the budget by the board  
https://wiki.documentfoundation.org/Development/Budget2017#Accessibility_improvements
 
* 
https://wiki.documentfoundation.org/Development/Budget2017#Image_handling_re-work
 
* 
https://wiki.documentfoundation.org/Development/Budget2017#Deprecate_SVG_filter_in_favour_of_SVGIO
 
* 
https://wiki.documentfoundation.org/Development/Budget2017#HSQLDB_binary_format_import
 
 + would like a number of experts to help spec. that out (Thorsten)
 + propose: approve specs for tender as-in the wiki &
   Florian to collect people to help out.
+ no objections.

* Release Engineering update (Christian)
+ 5.2.7 RC1 status
+ test failures, didn’t get a build that make-check worked for 1st time.
+ running checks manually – they pass.
+ issues with build parallelism here.
+ sometimes complex test or XStyleLoader2 test – only on Windows.
+ tried 4-5 times, not working – for complete check
+ is it upgrading the compiler ? (Thorsten)
+ random toolchain timing symptom (Michael)
+ random windows updates too – what changed ? (Cloph)
+ only on 5.2? (Miklos)
+ 5.3 rare to run into issues – sometimes XStyleloader2 (Cloph)
AI: + investigate signing issues around files (Cloph)
+ 5.3.3 RC1 status
+ tag yesterday – builds are currently underway
+ available tomorrow.
+ 5.4. builds / master
+ Alpha 1 – April 25th(?) - hard feature-freeze May 15th(?)
  alpha still from master , libreoffice-5-4 tag along with 
feature-freeze
+ translation problems
+ cleanup & re-shuffling in the src files
+ that changed lots of message contexts.
+ around 20k words to translate → thye’re not happy.
+ now down to 1500 – 2000 words; still some left.
+ improving quickly.
+ Android & iOS Remote
+ some patches need review, and some integrated.
+ no new builds yet.
+ online
+ propose skip 5.3.3 rc1 and do an rc2.

* Documentation (Olivier)
 + Zarro unconfirmed documentation bugs
 + thanks to Xisco mailing him the doc. bugs quickly.
 + New page on HC for Template manager (C. Vance and ohallot)
 + Need to review many other outdated/invalid pages on the subject
 + Guides: Change of templates for chapters triggers heavy work on update
  + style names changed – investigating if this is necessary
 + Fixes in help contents after translators
 + Tests LOOL to evaluate use for collaborative content insertion
   for Guides, encouraging results with track changes,
   but some issues open, e.g. protection.
+ may be better suited for doc. Authors rathern than caring about 
formats
+ have to download / edit / up-load cycle currently – which is a pain.
 + use the current site – with latest master/online builds.
+ testing some issues; been reported & fixed by Pranav
+ poking at two users – to see how they interfere – v. optimistic.

* should we have keywords not components in bugzilla (Heiko)
 + would need to move things from writer → documentation etc.
 + what’s wrong with a component ? (Xisco)
+ don’t see the problem.
 + some bugs have multiple facets: l10n, UI, documentation (Heiko)
AI: + come up with a proposal (Xisco, Heiko, Olivier)

* UX Update (Heiko)
+ Bugzilla (topicUI) statistics
248(248) (topicUI) bugs open, 470(470) (needsUXEval) needs to be 
evaluated by the UXteam
+ Updates:
BZ changes   1 week   1 month3 months   12 months
 added  3(3)  9(0)  31(-3) 490(0)
 commented 21(4)107(-36)   532(-73)   3532(-35)
   removed  0(0)  0(0)   4(-4)  38(0)
  resolved  3(-1)22(3)  82(-12)225(1)
+ top 10 contributors:
  Tietze, Heiko made 75 changes in 1 month, and 2262 changes in 1 year
  Foote, V Stuart made 37 changes in 1 month, and 670 changes in 1 year
  Philips, Yousuf made 28 changes in 1 month, and 1226 changes in 1 year
  Thomas Lendo 

[Libreoffice-bugs] [Bug 103407] [META] Unify behaviour and functions across apps

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103407

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Depends on||107307


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=107307
[Bug 107307] Split window view for Writer
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104423] UI: Edit > Duplicate (Shft+F3) doesn' t any longer remember last used values

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104423

Laurent BP  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jumbo4...@yahoo.fr
   Assignee|libreoffice-b...@lists.free |jumbo4...@yahoo.fr
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107308] Not saving printing area when exporting to xlsx

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107308

Mikhail Novosyolov  changed:

   What|Removed |Added

   Keywords||filter:ooxml, filter:xlsx

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107309] VIEWING: and skip over rows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107309

Terrence Enger  changed:

   What|Removed |Added

   Hardware|All |x86-64 (AMD64)
 OS|All |Linux (All)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107289] Conditional formatting breaks on adding then deleting a new sheet

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107289

m.a.riosv  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||miguelangelrv@libreoffice.o
   ||rg
 Ever confirmed|0   |1

--- Comment #1 from m.a.riosv  ---
Please attach a minimal sample file where to reproduce the issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106323] tab layout in dialogues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106323

Thomas Lendo  changed:

   What|Removed |Added

 CC||thomas.le...@gmail.com

--- Comment #8 from Thomas Lendo  ---
I would vote against a minimum width of tabs because it wouldn't fit into the
OS design and the mouse ways would be longer when switching through the tabs
for searching a setting.

I also don't see much benefit in the wide tabs layout in the current tabbed
notebookbar as shown in the screenshot from Andreas. You will have too few
space on small screens and it is a design users don't know from elsewhere. MSO
2013 hasn't so wide tabs, see
https://bug-attachments.documentfoundation.org/attachment.cgi?id=132532

(In reply to Yousuf Philips (jay) from comment #7)
> We would likely be moving to horizontal tabs/tree for dialogs, similar to
> the hyperlink dialog, so that would fix the issue as it wouldnt be OS themed.
There were reasons for Mozilla switching from a vertical settings tree (sidebar
layout) to a horizontal settings tab layout long ago (the last change was an
issue of space I assume). Users are more confident with a tabbed horizontal
layout as most of LibO's dialogs have it today. Users with LTR and RTL writing
can easier search for horizontal information.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107309] New: VIEWING: and skip over rows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107309

Bug ID: 107309
   Summary: VIEWING:  and  skip over rows
   Product: LibreOffice
   Version: 4.3.0.4 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: minor
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: lo_b...@iseries-guru.com

Description:
As per summary.

Steps to Reproduce:
(1) Download and open example.ods.  Observe that cell A147 is current,
and row 137 is at the top of the data area.

(2) Unmaximize the Calc window, if necessary, and adjust window height
to make row 148 the last on shown.

(3) Type "".


Actual Results:  
Top row in the data area is row 154.

Expected Results:
Top row in the data area is row 149.


Reproducible: Always

User Profile Reset: No

Additional Info:
I see this on debian-wheezy with LibreOffice versions
(*) daily Linux dbgutil bibisect repository version 2017-04-20
(*) as delivered with debian-stretch, Version: 5.2.6.2 Build ID:
1:5.2.6-2
(*) bibisect-43max version oldest.

I am setting priority of this report to Minor.


User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
Firefox/45.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103872] Untranslatable string in Calc/Chart: "Save as Image"

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103872

Gabor Kelemen  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |kelem...@ubuntu.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107300] Bibliography database - no CANCEL button

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107300

Marco A.G.Pinto  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #3 from Marco A.G.Pinto  ---
Xisco,

Select the bibliography database and click in the last book in the list.

Below the books, in the title field, add some characters.

Close the window clicking in the "x".

Go back to the database and the title of the book will have the extra stuff you
typed.

There should be a cancel button to abort unwanted changes.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104759] Cell content not displaying in large Calc files after driver update ( NVIDIA GeForce 310M driver)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104759

--- Comment #8 from David Edwards <2davidedwa...@gmail.com> ---
Hi,

apologies - work took over and I forgot about this. At the moment I have
5.2.5.1 which is working fine but I have not tried re-updating the driver. I
will try to find time to do this over the next couple of days - after which I
once again change country, start a new activity, etc. etc. and won't have a
moment.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107308] New: Not saving printing area when exporting to xlsx

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107308

Bug ID: 107308
   Summary: Not saving printing area when exporting to xlsx
   Product: LibreOffice
   Version: 5.3.2.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: mikhail...@dumalogiya.ru

Created attachment 132724
  --> https://bugs.documentfoundation.org/attachment.cgi?id=132724=edit
example document with printing area

To reproduce:
take the example file or any other in xlsx or save the ods as xlsx, change the
printing area and exports/save as xlsx. The change of the printing area will
not be saved. However, it is not present with xls.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106323] tab layout in dialogues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106323

--- Comment #9 from Yousuf Philips (jay)  ---
(In reply to Thomas Lendo from comment #8)
> I also don't see much benefit in the wide tabs layout in the current tabbed
> notebookbar as shown in the screenshot from Andreas. You will have too few
> space on small screens and it is a design users don't know from elsewhere.
> MSO 2013 hasn't so wide tabs, see
> https://bug-attachments.documentfoundation.org/attachment.cgi?id=132532

The difference between LO and MSO is that MSO's ribbon (and entire app) is
fully themed by them, which unfortunately LO doesnt have. Tiny sized tabs are
more difficult to hit with a mouse or a with a touch screen, but we are
designing it for screens that are 1280px wide or more, but a user's OS theme
will always cause issues that we wont forsee.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107307] New: Split window view for Writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107307

Bug ID: 107307
   Summary: Split window view for Writer
   Product: LibreOffice
   Version: Inherited From OOo
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: philip...@hotmail.com
Blocks: 103407

Split Window (.uno:SplitWindow) is a function in Calc and it would be useful to
have it in a similar fashion in writer. Presently to get a similar view in
Writer is to duplicate a window of the same document ( Window > New Window ),
but this duplicates the menubar, toolbars, sidebar and statusbar.

How it looks in MS Word -
http://www.java2s.com/Tutorial/Microsoft-Office-Word-2007Images/Split_Windows___Then_Click_To_Split_Document.PNG


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103407
[Bug 103407] [META] Unify behaviour and functions across apps
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106323] tab layout in dialogues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106323

--- Comment #10 from andreas_k  ---
we can also say use gnome in gnome LibreOffice look good. If you use Microsoft
Windows it's your fault, that LibreOffice tabs look like 1999.

sorry for the hard words, but if you have a look at the attachment it didn't
look good.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107207] Applications or files don't open after a while ( and computer has slept ?)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107207

Dude76  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |NOTABUG

--- Comment #1 from Dude76  ---
This bug can be closed.
I have deleted my profile, then all seems to working properly.
Something had to gone wrong somewhere and then corrupted one or more files of
the profile.
(but it is curious that it raised only after the computer has slept).
Any way.
Sorry for the inconvenience.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103676] Toolbars background is not drawn, instead showing previously active application as a background (KDE)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103676

Hamid  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC|hamidrjaf...@gmail.com  |
 Resolution|--- |FIXED

--- Comment #26 from Hamid  ---
Update to 17.04 resolved the issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107312] New: Pivot Table fields become black as I drag fields around.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107312

Bug ID: 107312
   Summary: Pivot Table fields become black as I drag fields
around.
   Product: LibreOffice
   Version: 5.3.2.2 release
  Hardware: x86-64 (AMD64)
OS: Mac OS X (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: david.stro...@gmail.com

Description:
I select some cells, do Data -> Pivot Table.  I get the dialog box.  As I drag
items from "Available fields" to the "Row Fields", etc. boxes, the boxes become
black.

Steps to Reproduce:
See description

Actual Results:  
white boxes become black

Expected Results:
white boxes stay white


Reproducible: Always

User Profile Reset: No

Additional Info:


User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0)
Gecko/20100101 Firefox/52.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107310] Formula cell with hybrid cell token mis-calculates to #VALUE!

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107310

Kohei Yoshida  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #2 from Kohei Yoshida  ---
It's a regression from Bug 96475.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107310] Formula cell with hybrid cell token mis-calculates to #VALUE!

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107310

Kohei Yoshida  changed:

   What|Removed |Added

   Keywords||regression

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107310] New: Formula cell with hybrid cell token mis-calculates to #VALUE!

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107310

Bug ID: 107310
   Summary: Formula cell with hybrid cell token mis-calculates to
#VALUE!
   Product: LibreOffice
   Version: 5.3.0.3 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: kohei.yosh...@collabora.com

Description:
A formula cell that references another cell that has hybrid cell token as its
result sometimes mis-calculates to #VALUE!.

Steps to Reproduce:
1. Open the test document.
2. Type in 1 to B16 after the document is loaded.
3. See #VALUE! in B18.

Actual Results:  
B18 displays #VALUE!.

Expected Results:
B18 displays 1.


Reproducible: Always

User Profile Reset: 

Additional Info:


User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:52.0) Gecko/20100101
Firefox/52.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107313] New: Impress : function and button "Format mark"

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107313

Bug ID: 107313
   Summary: Impress : function and button "Format mark"
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ca...@free.fr

Request to add the function and its "Format mark" button (unprinted characters)
in Impress
To facilitate the identification of paragraphs during the animation phase of
the text blocks
A big thanks in advance

(Sorry for my bad english)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107311] New: "Named range" option always grayed out in Pivot Table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107311

Bug ID: 107311
   Summary: "Named range" option always grayed out in Pivot Table
   Product: LibreOffice
   Version: 5.3.2.2 release
  Hardware: x86-64 (AMD64)
OS: Mac OS X (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: david.stro...@gmail.com

Description:
In Calc, I make a simple spreadsheet, select two columns, and do Data -> Define
Range.  I give it a name.  I then do Data -> Pivot Table.  The "Named range"
option is always grayed out.

Steps to Reproduce:
See description.

Actual Results:  
Named Range grayed out

Expected Results:
Named Range active, I can select one.


Reproducible: Always

User Profile Reset: No

Additional Info:


User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0)
Gecko/20100101 Firefox/52.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107310] Formula cell with hybrid cell token mis-calculates to #VALUE!

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107310

Kohei Yoshida  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |kohei.yosh...@collabora.com
   |desktop.org |

--- Comment #3 from Kohei Yoshida  ---
I'm looking into this right now.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 62361] FILEOPEN without optimum row height calculation

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=62361

--- Comment #9 from Tester  ---
Bug is still present in 5.3.0.3, check this: bug 62268

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 62268] FILEOPEN: Optimum row height should be recalculated with " style:use-optimal-row-height='true'"

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=62268

--- Comment #19 from Tester  ---
(I prepared this text for the bug report and found this here... so i post my
issue. i agree with Bernhard Dippold

Calc Version: 5.3.0.3 (Bug is still present)

Issue, libreoffice-Calc should update the automatic optimal height of rows, wen
the file is opened.
This is a issue which maybe shows up only by outside generated documents (Not
saved by libreoffice-Calc).

The Rows are set to be formated in optimal height, and because the generator
can not know this hight, the data is left out.
Calc should now update the Rows heights to there optimal. But after opening a
document, all rows are in the same standard hight.
The expected behavior is that Calc updates the height from this rows
automatically by the opening of the file, in case no height is set in the XML.
So that the user don't have to take any further action to correct the heights
manually.
I speculate, a simple trigger of a "Do-Automatic-Row-Height-Correction" in the
opening process fix the bug. dependent of the code, it is maybe only 1 code
line more.

Below are the XML codes generated form external generator, and tests.
See in "office:automatic-styles" the "style:use-optimal-row-height" option in
ro1 ro2
See in "office:automatic-styles" the "style:row-height" option in r03 r04
r03 r04 are the data generated from a external generator, form him it is
impossible to predict the height.

If a automatic update is not wanted, "style:use-optimal-row-height" simply must
be "false". It is set to "false" from Calc automatically, in case a user
changes the hight manually.
If it is "true", the correct behavior is to update it on file-load.


(I ca send a exampple.ods, but a expert should unterstand the issue
immediately.)

(In case you care about details, my ODS generator is a PHP code, which
generates documentation for medical informations. The users of the generator
should not do extra work to correct the row hight after opening the document.
And the generator can not know the hight Calc will create, so can not set it in
the generation process. The update must be done by loading the file. So pleas
no work arounds.)


content.xml:
...






































Fix Hight, No Automatic
Update, Hight Hight Hight Hight Hight Hight Hight Hight Hight Hight Hight Hight
Hight Hight





Automatic Known Hight,
but Wrong, Do Automatic Update?, Hight Hight Hight Hight Hight Hight Hight
Hight Hight Hight Hight Hight Hight Hight





Automatic Unknown
Hight, Do Automatic Update!, Hight Hight Hight Hight Hight Hight Hight Hight
Hight Hight Hight Hight Hight Hight





Automatic Unknown
Hight, Do Automatic Update!, Hight Hight Hight Hight Hight Hight Hight Hight
Hight Hight Hight Hight Hight








...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107314] New: Galaxy Icon Set: Inconsistency of icon

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107314

Bug ID: 107314
   Summary: Galaxy Icon Set: Inconsistency of icon
   Product: LibreOffice
   Version: 5.3.2.1 rc
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ca...@free.fr

In the Galaxy Icon Set
The "Insert image" icon on the standard toolbar is different from the "Insert
Picture" icon in the Insert menu
The "Insert" menu icon corresponds to the icon "Open the drawing toolbar"

Thanks

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107310] Formula cell with hybrid cell token mis-calculates to #VALUE!

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107310

--- Comment #1 from Kohei Yoshida  ---
Created attachment 132726
  --> https://bugs.documentfoundation.org/attachment.cgi?id=132726=edit
test document

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107302] Can't format texte in a shape

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107302

Xisco Faulí  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||xiscofa...@libreoffice.org
 Ever confirmed|0   |1

--- Comment #1 from Xisco Faulí  ---
I can't reproduce it in

Version: 5.3.2.2
Build ID: 1:5.3.2~rc2-0ubuntu1~yakkety0
CPU Threads: 4; OS Version: Linux 4.8; UI Render: default; VCL: gtk3; Layout
Engine: new; 
Locale: es-ES (ca_ES.UTF-8); Calc: group

Could you please try to reproduce it with the version 5.3.2.2 of LibreOffice
from https://www.libreoffice.org/download/libreoffice-fresh/ ?
I have set the bug's status to 'NEEDINFO'. Please change it back to
'UNCONFIRMED' if the bug is still present in the latest version.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107300] Bibliography database - no CANCEL button

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107300

Xisco Faulí  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #2 from Xisco Faulí  ---
Hello Marco,

Thank you for reporting the bug.
Unfortunately without clear steps to reproduce it, we cannot track down the
origin of the problem.
Please provide a clearer set of step-by-step instructions on how to reproduce
the problem.
I have set the bug's status to 'NEEDINFO'. Please change it back to
'UNCONFIRMED' once the steps are provided

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 106781] Addition of a style-focused formatting toolbar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106781

--- Comment #22 from LibreTraining  ---

Regarding the eLAIX extension ...
It is just an example of a dedicated toolbar which emphasizes styles vs. direct
formatting.   
That toolbar attempts to put all the tools needed for ePub documents in one
place.
Instead of scattered around in multiple toolbars.
And it adds some missing features.

The tools developed for this styles-focused toolbar will enable other dedicated
toolbars.

For example Corel WordPerfect X8 has a Legal Toolbar.
It includes all the the tools needed by lawyers to file pleadings, etc. in one
toolbar.
It includes paragraph styles.
It includes page styles.
It includes buttons to run fill-in-the-form macros to get the document started
with proper page layout and the basic information which is needed every time.

Another example is a Long Document Toolbar.
The tools needed for long documents are scattered all over the place.

And turning all these separate toolbars on and off is a giant PITA.
Having to go back into that toolbars menu over and over again is ridiculous.
I will create a separate bug report/request for that issue - with examples from
other apps which work better.


Adobe InDesign has pre-defined and customizable Workspace options.
This changes the toolbars and the sidebars all at once.
Essentials (minimal), Digital Publishing, Book (long print docs), Advanced
(everything), etc. etc.
All toolbars can be customized and all panels turned on or off.
There a Lynda.com video on creating your own ePub workspace.
Easy to do.

MUFFIN on steroids.


And, Yes, I did mean frame styles, object styles is the similar feature in
InDesign. :-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 106781] Addition of a style-focused formatting toolbar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106781

--- Comment #22 from LibreTraining  ---

Regarding the eLAIX extension ...
It is just an example of a dedicated toolbar which emphasizes styles vs. direct
formatting.   
That toolbar attempts to put all the tools needed for ePub documents in one
place.
Instead of scattered around in multiple toolbars.
And it adds some missing features.

The tools developed for this styles-focused toolbar will enable other dedicated
toolbars.

For example Corel WordPerfect X8 has a Legal Toolbar.
It includes all the the tools needed by lawyers to file pleadings, etc. in one
toolbar.
It includes paragraph styles.
It includes page styles.
It includes buttons to run fill-in-the-form macros to get the document started
with proper page layout and the basic information which is needed every time.

Another example is a Long Document Toolbar.
The tools needed for long documents are scattered all over the place.

And turning all these separate toolbars on and off is a giant PITA.
Having to go back into that toolbars menu over and over again is ridiculous.
I will create a separate bug report/request for that issue - with examples from
other apps which work better.


Adobe InDesign has pre-defined and customizable Workspace options.
This changes the toolbars and the sidebars all at once.
Essentials (minimal), Digital Publishing, Book (long print docs), Advanced
(everything), etc. etc.
All toolbars can be customized and all panels turned on or off.
There a Lynda.com video on creating your own ePub workspace.
Easy to do.

MUFFIN on steroids.


And, Yes, I did mean frame styles, object styles is the similar feature in
InDesign. :-)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101627] FILEOPEN: Height of text box in footer in DOCX imported wrong ( thus hiding the page number)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101627

--- Comment #16 from Commit Notification 
 ---
Patrick Jaap committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=d862741423cdf0ef228d34b2a25b09c9401be584

tdf#101627 add unit test

It will be available in 5.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107306] New: Need Of Italic Characters

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107306

Bug ID: 107306
   Summary: Need Of Italic Characters
   Product: LibreOffice
   Version: 5.3.2.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: matteonardell...@gmail.com

Dear all,

In order to satisfy my different aims, I need for Calculator, Writer and
Impress many Italic Characters to be availables. I remember that once, 2-3
years ago, they were available, I don't know why you, as LibreOffice community,
decided to delete it, I need it.
Please could you make it available again for LibreOffice, you know, I mean
those characters like: Monotype Corsiva... and other that I even don't
remember.

Cheers

Matteo

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 89994] writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=89994

Telesto  changed:

   What|Removed |Added

Version|4.2.7.2 release |4.0.0.3 release

--- Comment #3 from Telesto  ---
Confirming with:
Version: 5.4.0.0.alpha0+
CPU threads: 4; OS: Windows 6.19; UI render: GL; 
TinderBox: Win-x86@42, Branch:master, Time: 2017-04-05_23:32:27
Locale: nl-NL (nl_NL); Calc: CL

and with:
Versie 4.0.0.3 (Bouw-id: 7545bee9c2a0782548772a21bc84a9dcc583b89)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 89994] writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=89994

--- Comment #4 from Telesto  ---
Created attachment 132723
  --> https://bugs.documentfoundation.org/attachment.cgi?id=132723=edit
Example file

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99625] CONCAT and TEXTJOIN return (wrongly?) an array when " text argument" is a CSE array.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99625

--- Comment #20 from Eike Rathke  ---
Finally something that sheds light.. there you linked an .xlsx
https://people.highline.edu/mgirvin/YouTubeExcelIsFun/EMT1307-1311.xlsx (why
didn't you post that link here as well?) which when opened without
recalculation on sheet '(1309an)' in cell D5 has a TEXTJOIN in array context
that delivers result in one cell and when recalculated spreads over several
rows. The Excel behaviour makes sense and we should do the same.

Btw, your comment there
> Developers persist in denying evidence.
really pisses me off. No one denied evidence here, it's just that nobody came
up with any evidence so far.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99625] CONCAT and TEXTJOIN return (wrongly?) an array when " text argument" is a CSE array.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99625

Eike Rathke  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |er...@redhat.com
   |desktop.org |

--- Comment #21 from Eike Rathke  ---
I'll take care of this.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs