[Libreoffice-commits] core.git: sfx2/source

2018-10-07 Thread Libreoffice Gerrit user
 sfx2/source/dialog/templdlg.cxx |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 94bf82a8ceba41c32cf3620529e6ce8ea94f18c0
Author: Jim Raykowski 
AuthorDate: Sun Sep 2 15:07:26 2018 -0800
Commit: Jim Raykowski 
CommitDate: Mon Oct 8 02:38:33 2018 +0200

tdf#99678 Show style in common template dialog tree box immediatly

...after creation using New Style dialog

Change-Id: Idb24f537fe7be2dfb9660a1a5de0bcd26612affc
Reviewed-on: https://gerrit.libreoffice.org/59914
Tested-by: Jenkins
Reviewed-by: Jim Raykowski 

diff --git a/sfx2/source/dialog/templdlg.cxx b/sfx2/source/dialog/templdlg.cxx
index 88042ea54ea4..448f70182d23 100644
--- a/sfx2/source/dialog/templdlg.cxx
+++ b/sfx2/source/dialog/templdlg.cxx
@@ -1704,6 +1704,7 @@ void 
SfxCommonTemplateDialog_Impl::ActionSelect(sal_uInt16 nEntry)
  aTemplName, "",
  
static_cast(GetFamilyItem_Impl()->GetFamily()),
  nFilter);
+UpdateFamily_Impl();
 }
 pStyleSheetPool->SetSearchMask( eFam, nFilter );
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: o3tl/qa vcl/source

2018-10-07 Thread Libreoffice Gerrit user
 o3tl/qa/test-lru_map.cxx  |2 +-
 vcl/source/font/fontcache.cxx |2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 67e5201cc6caee52d8e37e98a0d535c085c19cb4
Author: Julien Nabet 
AuthorDate: Sun Oct 7 13:06:05 2018 +0200
Commit: Julien Nabet 
CommitDate: Sun Oct 7 14:43:03 2018 +0200

-Werror=catch-value=

Change-Id: I58563735e6cf5004b4ac5e846885414f0c603f4c
Reviewed-on: https://gerrit.libreoffice.org/61491
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/o3tl/qa/test-lru_map.cxx b/o3tl/qa/test-lru_map.cxx
index a7f9777e2c5f..f0810084b6c7 100644
--- a/o3tl/qa/test-lru_map.cxx
+++ b/o3tl/qa/test-lru_map.cxx
@@ -261,7 +261,7 @@ void lru_map_test::testRemoveIf()
 });
 CPPUNIT_ASSERT(false); // not reached
 }
-catch (limit_except)
+catch (limit_except&)
 {
 // contains 7..4
 CPPUNIT_ASSERT_EQUAL(size_t(4), lru.size());
diff --git a/vcl/source/font/fontcache.cxx b/vcl/source/font/fontcache.cxx
index 2b2e062ecea0..b8e4bec2b5ce 100644
--- a/vcl/source/font/fontcache.cxx
+++ b/vcl/source/font/fontcache.cxx
@@ -186,7 +186,7 @@ rtl::Reference 
ImplFontCache::GetFontInstance( PhysicalFont
 return true;
 });
 }
-catch (limit_exception) {}
+catch (limit_exception&) {}
 }
 
 assert(pFontInstance);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: basegfx/source editeng/source include/basegfx sw/source vcl/win

2018-10-07 Thread Libreoffice Gerrit user
 basegfx/source/tools/systemdependentdata.cxx  |2 +-
 editeng/source/editeng/impedit4.cxx   |2 +-
 include/basegfx/utils/systemdependentdata.hxx |2 +-
 sw/source/core/txtnode/txtedt.cxx |2 +-
 vcl/win/gdi/gdiimpl.cxx   |4 ++--
 5 files changed, 6 insertions(+), 6 deletions(-)

New commits:
commit 86d9e48fc60dd7325658feca7088100c78023a7b
Author: Andrea Gelmini 
AuthorDate: Sun Oct 7 10:01:10 2018 +0200
Commit: Julien Nabet 
CommitDate: Sun Oct 7 15:28:53 2018 +0200

Fix typos

Change-Id: Ia26896cbcd8912f7cad641ea2ecf14c4ddf2d741
Reviewed-on: https://gerrit.libreoffice.org/61489
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/basegfx/source/tools/systemdependentdata.cxx 
b/basegfx/source/tools/systemdependentdata.cxx
index c727462c7191..a2ebcdf23b8a 100644
--- a/basegfx/source/tools/systemdependentdata.cxx
+++ b/basegfx/source/tools/systemdependentdata.cxx
@@ -89,7 +89,7 @@ namespace basegfx
 // a corresponding scaling factor
 const double fScaleToMB(3600.0 / (1024.0 * 1024.0 * 10.0));
 
-// also use a multiplier to move the start point higer
+// also use a multiplier to move the start point higher
 const double fMultiplierSeconds(10.0);
 
 // calculate
diff --git a/editeng/source/editeng/impedit4.cxx 
b/editeng/source/editeng/impedit4.cxx
index 6fdc00971ec5..c57ba48bd237 100644
--- a/editeng/source/editeng/impedit4.cxx
+++ b/editeng/source/editeng/impedit4.cxx
@@ -2704,7 +2704,7 @@ EditSelection ImpEditEngine::TransliterateText( const 
EditSelection& rSelection,
 
 // since we don't use Hiragana/Katakana or half-width/full-width 
transliterations here
 // it is fine to use ANYWORD_IGNOREWHITESPACES. (ANY_WORD btw is 
broken and will
-// occasionaly miss words in consecutive sentences). Also with 
ANYWORD_IGNOREWHITESPACES
+// occasionally miss words in consecutive sentences). Also with 
ANYWORD_IGNOREWHITESPACES
 // text like 'just-in-time' will be converted to 'Just-In-Time' which 
seems to be the
 // proper thing to do.
 const sal_Int16 nWordType = i18n::WordType::ANYWORD_IGNOREWHITESPACES;
diff --git a/include/basegfx/utils/systemdependentdata.hxx 
b/include/basegfx/utils/systemdependentdata.hxx
index d5cc8d645eb6..32f02bea6fa2 100644
--- a/include/basegfx/utils/systemdependentdata.hxx
+++ b/include/basegfx/utils/systemdependentdata.hxx
@@ -111,7 +111,7 @@ namespace basegfx
 
 // Calculate HoldCyclesInSeconds based on using
 // getHoldCyclesInSeconds and estimateUsageInBytes, the
-// result is crated once on-demand and buffered in
+// result is created once on-demand and buffered in
 // mnCalculatedCycles
 sal_uInt32 calculateCombinedHoldCyclesInSeconds() const;
 
diff --git a/sw/source/core/txtnode/txtedt.cxx 
b/sw/source/core/txtnode/txtedt.cxx
index d6847e65bf1d..74b33c963af8 100644
--- a/sw/source/core/txtnode/txtedt.cxx
+++ b/sw/source/core/txtnode/txtedt.cxx
@@ -1722,7 +1722,7 @@ void SwTextNode::TransliterateText(
 {
 // since we don't use Hiragana/Katakana or half-width/full-width 
transliterations here
 // it is fine to use ANYWORD_IGNOREWHITESPACES. (ANY_WORD btw is 
broken and will
-// occasionaly miss words in consecutive sentences). Also with 
ANYWORD_IGNOREWHITESPACES
+// occasionally miss words in consecutive sentences). Also with 
ANYWORD_IGNOREWHITESPACES
 // text like 'just-in-time' will be converted to 'Just-In-Time' which 
seems to be the
 // proper thing to do.
 const sal_Int16 nWordType = WordType::ANYWORD_IGNOREWHITESPACES;
diff --git a/vcl/win/gdi/gdiimpl.cxx b/vcl/win/gdi/gdiimpl.cxx
index a77e26f0e180..d11fb692dcd2 100644
--- a/vcl/win/gdi/gdiimpl.cxx
+++ b/vcl/win/gdi/gdiimpl.cxx
@@ -2042,7 +2042,7 @@ bool WinSalGraphicsImpl::drawPolyPolygon(
 aGraphics.SetTransform();
 }
 
-// prepare local instabce of Gdiplus::GraphicsPath
+// prepare local instance of Gdiplus::GraphicsPath
 std::shared_ptr pGraphicsPath;
 
 // try to access buffered data
@@ -2257,7 +2257,7 @@ bool WinSalGraphicsImpl::drawPolyLine(
 }
 }
 
-// prepare local instabce of Gdiplus::GraphicsPath
+// prepare local instance of Gdiplus::GraphicsPath
 std::shared_ptr pGraphicsPath;
 
 // try to access buffered data
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: sc/source

2018-10-07 Thread Libreoffice Gerrit user
 sc/source/ui/cctrl/checklistmenu.cxx |4 ++--
 sc/source/ui/inc/checklistmenu.hxx   |2 +-
 sc/source/ui/view/gridwin.cxx|2 +-
 sc/source/ui/view/gridwin2.cxx   |2 +-
 4 files changed, 5 insertions(+), 5 deletions(-)

New commits:
commit c666ea47bcf45b3c530778a7d0eea888e949947e
Author: Noel Grandin 
AuthorDate: Fri Oct 5 11:09:05 2018 +0200
Commit: Noel Grandin 
CommitDate: Sun Oct 7 11:47:20 2018 +0200

use more std::unique_ptr in ScCheckListMenuWindow

Change-Id: Ia63d663204af570fb0e7faa46e4925c2787fc59b
Reviewed-on: https://gerrit.libreoffice.org/61433
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/sc/source/ui/cctrl/checklistmenu.cxx 
b/sc/source/ui/cctrl/checklistmenu.cxx
index 9dcd5894baec..6a2a8b436674 100644
--- a/sc/source/ui/cctrl/checklistmenu.cxx
+++ b/sc/source/ui/cctrl/checklistmenu.cxx
@@ -2008,9 +2008,9 @@ void ScCheckListMenuWindow::close(bool bOK)
 EndPopupMode();
 }
 
-void ScCheckListMenuWindow::setExtendedData(ExtendedData* p)
+void ScCheckListMenuWindow::setExtendedData(std::unique_ptr p)
 {
-mpExtendedData.reset(p);
+mpExtendedData = std::move(p);
 }
 
 ScCheckListMenuWindow::ExtendedData* ScCheckListMenuWindow::getExtendedData()
diff --git a/sc/source/ui/inc/checklistmenu.hxx 
b/sc/source/ui/inc/checklistmenu.hxx
index 076ad2414afa..c3638b147384 100644
--- a/sc/source/ui/inc/checklistmenu.hxx
+++ b/sc/source/ui/inc/checklistmenu.hxx
@@ -355,7 +355,7 @@ public:
  * popup window class manages its life time; no explicit deletion of the
  * instance is needed in the client code.
  */
-void setExtendedData(ExtendedData* p);
+void setExtendedData(std::unique_ptr p);
 
 /**
  * Get the store auxiliary data, or NULL if no such data is stored.
diff --git a/sc/source/ui/view/gridwin.cxx b/sc/source/ui/view/gridwin.cxx
index 4bbdc97493e0..fdcdf2da7e5b 100644
--- a/sc/source/ui/view/gridwin.cxx
+++ b/sc/source/ui/view/gridwin.cxx
@@ -662,7 +662,7 @@ void ScGridWindow::LaunchAutoFilterMenu(SCCOL nCol, SCROW 
nRow)
 return;
 
 pData->mpData = pDBData;
-mpAutoFilterPopup->setExtendedData(pData.release());
+mpAutoFilterPopup->setExtendedData(std::move(pData));
 
 ScQueryParam aParam;
 pDBData->GetQueryParam(aParam);
diff --git a/sc/source/ui/view/gridwin2.cxx b/sc/source/ui/view/gridwin2.cxx
index 66e1a83ee25c..4adfc1e32f5d 100644
--- a/sc/source/ui/view/gridwin2.cxx
+++ b/sc/source/ui/view/gridwin2.cxx
@@ -470,7 +470,7 @@ void ScGridWindow::DPLaunchFieldPopupMenu(const Point& 
rScrPos, const Size& rScr
 mpDPFieldPopup.disposeAndClear();
 mpDPFieldPopup.reset(VclPtr::Create(this, 
pViewData->GetDocument()));
 mpDPFieldPopup->setName("DataPilot field member popup");
-mpDPFieldPopup->setExtendedData(pDPData.release());
+mpDPFieldPopup->setExtendedData(std::move(pDPData));
 mpDPFieldPopup->setOKAction(new DPFieldPopupOKAction(this));
 {
 // Populate field members.
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: cui/source

2018-10-07 Thread Libreoffice Gerrit user
 cui/source/tabpages/backgrnd.cxx |   68 +--
 1 file changed, 23 insertions(+), 45 deletions(-)

New commits:
commit 8a445db3bb59a3e046daa62c1a1e0e199f3977b7
Author: Noel Grandin 
AuthorDate: Fri Oct 5 14:37:00 2018 +0200
Commit: Noel Grandin 
CommitDate: Sun Oct 7 11:48:04 2018 +0200

use std::unique_ptr in SvxBackgroundTable_Impl and SvxBackgroundPage_Impl

Change-Id: I823e4ab434ac41865c8faf513769f7a985c199ea
Reviewed-on: https://gerrit.libreoffice.org/61442
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/cui/source/tabpages/backgrnd.cxx b/cui/source/tabpages/backgrnd.cxx
index 5452b11da15d..a4a3601b3aa5 100644
--- a/cui/source/tabpages/backgrnd.cxx
+++ b/cui/source/tabpages/backgrnd.cxx
@@ -69,19 +69,16 @@ const sal_uInt16 SvxBackgroundTabPage::pPageRanges[] =
 
 struct SvxBackgroundTable_Impl
 {
-SvxBrushItem*   pCellBrush;
-SvxBrushItem*   pRowBrush;
-SvxBrushItem*   pTableBrush;
+std::unique_ptr   pCellBrush;
+std::unique_ptr   pRowBrush;
+std::unique_ptr   pTableBrush;
 sal_uInt16  nCellWhich;
 sal_uInt16  nRowWhich;
 sal_uInt16  nTableWhich;
 sal_Int32   nActPos;
 
 SvxBackgroundTable_Impl()
-: pCellBrush(nullptr)
-, pRowBrush(nullptr)
-, pTableBrush(nullptr)
-, nCellWhich(0)
+: nCellWhich(0)
 , nRowWhich(0)
 , nTableWhich(0)
 , nActPos(0)
@@ -90,13 +87,8 @@ struct SvxBackgroundTable_Impl
 
 struct SvxBackgroundPage_Impl
 {
-Idle*  pLoadIdle;
-boolbIsImportDlgInExecute;
-
-SvxBackgroundPage_Impl()
-: pLoadIdle(nullptr)
-, bIsImportDlgInExecute(false)
-{}
+std::unique_ptr pLoadIdle;
+boolbIsImportDlgInExecute = false;
 };
 
 /// Returns the fill style of the currently selected entry.
@@ -357,27 +349,13 @@ SvxBackgroundTabPage::~SvxBackgroundTabPage()
 
 void SvxBackgroundTabPage::dispose()
 {
-if (pPageImpl)
-{
-delete pPageImpl->pLoadIdle;
-pPageImpl.reset();
-}
-
+pPageImpl.reset();
 pImportDlg.reset();
-
-if( pTableBck_Impl)
-{
-delete pTableBck_Impl->pCellBrush;
-delete pTableBck_Impl->pRowBrush;
-delete pTableBck_Impl->pTableBrush;
-pTableBck_Impl.reset();
-}
-
+pTableBck_Impl.reset();
 m_xPreviewWin2.reset();
 m_xPreviewWin1.reset();
 m_xBackgroundColorSetWin.reset();
 m_xWndPositionWin.reset();
-
 m_xPreview2.reset();
 m_xPreview1.reset();
 m_xBackgroundColorSet.reset();
@@ -487,9 +465,9 @@ void SvxBackgroundTabPage::Reset( const SfxItemSet* rSet )
 
 if ( pTableBck_Impl )
 {
-DELETEZ( pTableBck_Impl->pCellBrush);
-DELETEZ( pTableBck_Impl->pRowBrush);
-DELETEZ( pTableBck_Impl->pTableBrush);
+pTableBck_Impl->pCellBrush.reset();
+pTableBck_Impl->pRowBrush.reset();
+pTableBck_Impl->pTableBrush.reset();
 }
 else
 pTableBck_Impl.reset( new SvxBackgroundTable_Impl() );
@@ -500,21 +478,21 @@ void SvxBackgroundTabPage::Reset( const SfxItemSet* rSet )
 if ( rSet->GetItemState( nWhich, false ) >= SfxItemState::DEFAULT )
 {
 aBgdAttr = static_cast(rSet->Get(nWhich));
-pTableBck_Impl->pCellBrush = new SvxBrushItem(aBgdAttr);
+pTableBck_Impl->pCellBrush.reset(new SvxBrushItem(aBgdAttr));
 }
 pTableBck_Impl->nCellWhich = nWhich;
 
 if ( rSet->GetItemState( SID_ATTR_BRUSH_ROW, false ) >= 
SfxItemState::DEFAULT )
 {
 aBgdAttr = static_cast(rSet->Get(SID_ATTR_BRUSH_ROW));
-pTableBck_Impl->pRowBrush = new SvxBrushItem(aBgdAttr);
+pTableBck_Impl->pRowBrush.reset(new SvxBrushItem(aBgdAttr));
 }
 pTableBck_Impl->nRowWhich = SID_ATTR_BRUSH_ROW;
 
 if ( rSet->GetItemState( SID_ATTR_BRUSH_TABLE, false ) >= 
SfxItemState::DEFAULT )
 {
 aBgdAttr = static_cast(rSet->Get(SID_ATTR_BRUSH_TABLE));
-pTableBck_Impl->pTableBrush = new SvxBrushItem(aBgdAttr);
+pTableBck_Impl->pTableBrush.reset(new SvxBrushItem(aBgdAttr));
 }
 pTableBck_Impl->nTableWhich = SID_ATTR_BRUSH_TABLE;
 
@@ -562,7 +540,7 @@ bool SvxBackgroundTabPage::FillItemSet( SfxItemSet* 
rCoreSet )
 if ( pPageImpl->pLoadIdle && pPageImpl->pLoadIdle->IsActive() )
 {
 pPageImpl->pLoadIdle->Stop();
-LoadIdleHdl_Impl( pPageImpl->pLoadIdle );
+LoadIdleHdl_Impl( pPageImpl->pLoadIdle.get() );
 }
 
 bool bModified = false;
@@ -821,7 +799,7 @@ void SvxBackgroundTabPage::ShowSelector()
 m_xBtnPosition->connect_toggled(HDL(RadioClickHdl_Impl));
 
 // delayed loading via timer (because of UI-Update)
-

[Libreoffice-commits] core.git: sc/source sw/source

2018-10-07 Thread Libreoffice Gerrit user
 sc/source/core/data/drwlayer.cxx|1 +
 sw/source/core/doc/DocumentDrawModelManager.cxx |1 +
 2 files changed, 2 insertions(+)

New commits:
commit fbc2b2d93a091c9dba26139878dd3d0acc5f31e9
Author: Regina Henschel 
AuthorDate: Fri Oct 5 21:24:45 2018 +0200
Commit: Regina Henschel 
CommitDate: Sun Oct 7 15:11:36 2018 +0200

tdf#120317 Set control layer name if not default

In commit a9ec212c1b545d745285f0ab3119a80713b1d1f2 the internal
default name of the layer, which holds form controls, was changed to
controls, the same name as used in file format and UNO. Users of
the class SdrLayerAdmin have to set the control layer name
explicitly in case they want an own, different name.

Change-Id: Ia08a85a4d01a75ee2c5115da25b2a409204ccc01
Reviewed-on: https://gerrit.libreoffice.org/61447
Tested-by: Jenkins
Reviewed-by: Regina Henschel 

diff --git a/sc/source/core/data/drwlayer.cxx b/sc/source/core/data/drwlayer.cxx
index 7fd0e6bd6201..1e97aa0600f8 100644
--- a/sc/source/core/data/drwlayer.cxx
+++ b/sc/source/core/data/drwlayer.cxx
@@ -296,6 +296,7 @@ ScDrawLayer::ScDrawLayer( ScDocument* pDocument, const 
OUString& rName ) :
 rAdmin.NewLayer("hinten",   sal_uInt8(SC_LAYER_BACK));
 rAdmin.NewLayer("intern",   sal_uInt8(SC_LAYER_INTERN));
 rAdmin.NewLayer("Controls", sal_uInt8(SC_LAYER_CONTROLS));
+rAdmin.SetControlLayerName("Controls");
 rAdmin.NewLayer("hidden",   sal_uInt8(SC_LAYER_HIDDEN));
 // "Controls" is new - must also be created when loading
 
diff --git a/sw/source/core/doc/DocumentDrawModelManager.cxx 
b/sw/source/core/doc/DocumentDrawModelManager.cxx
index e6da069859fd..1f5f4bfa8f5a 100644
--- a/sw/source/core/doc/DocumentDrawModelManager.cxx
+++ b/sw/source/core/doc/DocumentDrawModelManager.cxx
@@ -93,6 +93,7 @@ void DocumentDrawModelManager::InitDrawModel()
 
 sLayerNm = "Controls";
 mnControls = mpDrawModel->GetLayerAdmin().NewLayer( sLayerNm )->GetID();
+mpDrawModel->GetLayerAdmin().SetControlLayerName(sLayerNm);
 
 // add invisible layers corresponding to the visible ones.
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: include/svx reportdesign/source svx/source

2018-10-07 Thread Libreoffice Gerrit user
 include/svx/fmview.hxx |2 ++
 reportdesign/source/ui/report/ReportController.cxx |4 
 svx/source/form/fmview.cxx |4 ++--
 svx/source/form/fmvwimp.cxx|6 +-
 svx/source/inc/fmvwimp.hxx |2 ++
 5 files changed, 15 insertions(+), 3 deletions(-)

New commits:
commit f2bd68c33c13b94cf844227d04a7eba9fe3723f8
Author: Julien Nabet 
AuthorDate: Sun Sep 30 01:25:48 2018 +0200
Commit: Julien Nabet 
CommitDate: Sun Oct 7 21:19:52 2018 +0200

tdf#120152: fix adding labels in reportdesign

Regression from:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=4b4942224b550235da228655677b5c068a053254

Change-Id: I7935f11e82410574e64cf3d50ea4e2e3791f0487
Reviewed-on: https://gerrit.libreoffice.org/61146
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/include/svx/fmview.hxx b/include/svx/fmview.hxx
index cec43527f499..106e83131733 100644
--- a/include/svx/fmview.hxx
+++ b/include/svx/fmview.hxx
@@ -95,6 +95,8 @@ public:
 sal_uInt16 _nControlObjectID,
 SdrInventor _nInventor,
 sal_uInt16 _nLabelObjectID,
+SdrPage* _pLabelPage,
+SdrPage* _pControlPage,
 
 // tdf#118963 Need a SdrModel for SdrObject creation. To make the
 // demand clear, hand over a SdrMldel&
diff --git a/reportdesign/source/ui/report/ReportController.cxx 
b/reportdesign/source/ui/report/ReportController.cxx
index 1319f3be33fc..c0288eb92de6 100644
--- a/reportdesign/source/ui/report/ReportController.cxx
+++ b/reportdesign/source/ui/report/ReportController.cxx
@@ -3146,6 +3146,8 @@ void OReportController::createControl(const Sequence< 
PropertyValue >& _aArgs,co
 _nObjectId,
 SdrInventor::ReportDesign,
 OBJ_DLG_FIXEDTEXT,
+nullptr,
+pSectionWindow->getReportSection().getPage(),
 
 // tdf#118963 Need a SdrModel for SdrObject creation. Dereferencing
 // m_aReportModel seems pretty safe, it's done in other places, 
initialized
@@ -3453,6 +3455,8 @@ void OReportController::addPairControls(const Sequence< 
PropertyValue >& aArgs)
 nOBJID,
 SdrInventor::ReportDesign,
 OBJ_DLG_FIXEDTEXT,
+pSectionWindow[1]->getReportSection().getPage(),
+pSectionWindow[0]->getReportSection().getPage(),
 
 // tdf#118963 Need a SdrModel for SdrObject creation. 
Dereferencing
 // m_aReportModel seems pretty safe, it's done in other 
places, initialized
diff --git a/svx/source/form/fmview.cxx b/svx/source/form/fmview.cxx
index e4670a1fb714..5f93b1750b85 100644
--- a/svx/source/form/fmview.cxx
+++ b/svx/source/form/fmview.cxx
@@ -566,7 +566,7 @@ FmFormObj* FmFormView::getMarkedGrid() const
 void FmFormView::createControlLabelPair( OutputDevice const * _pOutDev, 
sal_Int32 _nXOffsetMM, sal_Int32 _nYOffsetMM,
 const Reference< XPropertySet >& _rxField, const Reference< XNumberFormats 
>& _rxNumberFormats,
 sal_uInt16 _nControlObjectID, SdrInventor _nInventor, sal_uInt16 
_nLabelObjectID,
-SdrModel& _rModel,
+SdrPage* _pLabelPage, SdrPage* _pControlPage, SdrModel& _rModel,
 std::unique_ptr& _rpLabel,
 std::unique_ptr& _rpControl )
 {
@@ -574,7 +574,7 @@ void FmFormView::createControlLabelPair( OutputDevice const 
* _pOutDev, sal_Int3
 *_pOutDev, _nXOffsetMM, _nYOffsetMM,
 _rxField, _rxNumberFormats,
 _nControlObjectID, "", _nInventor, _nLabelObjectID,
-_rModel,
+_pLabelPage, _pControlPage, _rModel,
 _rpLabel, _rpControl
 );
 }
diff --git a/svx/source/form/fmvwimp.cxx b/svx/source/form/fmvwimp.cxx
index ec0df8ee71a7..aa953fa13616 100644
--- a/svx/source/form/fmvwimp.cxx
+++ b/svx/source/form/fmvwimp.cxx
@@ -1526,6 +1526,8 @@ bool FmXFormView::createControlLabelPair( OutputDevice 
const & _rOutDev, sal_Int
 _rFieldPostfix,
 SdrInventor::FmForm,
 OBJ_FM_FIXEDTEXT,
+nullptr,
+nullptr,
 
 // tdf#118963 Hand over a SdrModel to SdrObject-creation. It uses the 
local m_pView
 // and already returning false when nullptr == getView() could be 
done, but m_pView
@@ -1557,7 +1559,7 @@ bool FmXFormView::createControlLabelPair( OutputDevice 
const & _rOutDev, sal_Int
 const Reference< XPropertySet >& _rxField,
 const Reference< XNumberFormats >& _rxNumberFormats, sal_uInt16 
_nControlObjectID,
 const OUString& _rFieldPostfix, SdrInventor _nInventor, sal_uInt16 
_nLabelObjectID,
-SdrModel& _rModel,
+SdrPage* _pLabelPage, SdrPage* _pControlPage, SdrModel& _rModel,
 std::unique_ptr& _rpLabel, 
std::unique_ptr& _rpControl)
 {
 sal_Int32 nDataType = 0;
@@ -1604,6 +1606,7 @@ bool FmXFormView::createControlLabelPair( OutputDevice 
const & _rOutDev, sal_Int
 _rModel,
 _nInventor,
 

[Libreoffice-commits] core.git: Branch 'libreoffice-6-1' - svx/source

2018-10-07 Thread Libreoffice Gerrit user
 svx/source/dialog/srchdlg.cxx |   66 +++---
 1 file changed, 55 insertions(+), 11 deletions(-)

New commits:
commit 7dbe17d5a6b866cca9b81418f3f0cd1d32214265
Author: Caolán McNamara 
AuthorDate: Thu Oct 4 15:37:14 2018 +0100
Commit: Adolfo Jayme Barrientos 
CommitDate: Sun Oct 7 21:41:09 2018 +0200

Resolves: tdf#106340 resize dialog when search/replace labels are 
shown/hidden

Change-Id: I1e20807f613a73c7dbefcb8e331f99d484eb5c04
Reviewed-on: https://gerrit.libreoffice.org/61394
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/svx/source/dialog/srchdlg.cxx b/svx/source/dialog/srchdlg.cxx
index 6a999380ee7a..ec59bef81287 100644
--- a/svx/source/dialog/srchdlg.cxx
+++ b/svx/source/dialog/srchdlg.cxx
@@ -1103,6 +1103,8 @@ void SvxSearchDialog::InitAttrList_Impl( const 
SfxItemSet* pSSet,
 memcpy( pImpl->pRanges.get(), pTmp, sizeof(sal_uInt16) * nCnt );
 }
 
+bool bSetOptimalLayoutSize = false;
+
 // See to it that are the texts of the attributes are correct
 OUString aDesc;
 
@@ -1119,7 +1121,11 @@ void SvxSearchDialog::InitAttrList_Impl( const 
SfxItemSet* pSSet,
 
 if ( !aDesc.isEmpty() )
 {
-m_pSearchAttrText->Show();
+if (!m_pSearchAttrText->IsVisible())
+{
+m_pSearchAttrText->Show();
+bSetOptimalLayoutSize = true;
+}
 bFormat |= true;
 }
 }
@@ -1138,11 +1144,18 @@ void SvxSearchDialog::InitAttrList_Impl( const 
SfxItemSet* pSSet,
 
 if ( !aDesc.isEmpty() )
 {
-m_pReplaceAttrText->Show();
+if (!m_pReplaceAttrText->IsVisible())
+{
+m_pReplaceAttrText->Show();
+bSetOptimalLayoutSize = true;
+}
 bFormat |= true;
 }
 }
 }
+
+if (bSetOptimalLayoutSize)
+setOptimalLayoutSize();
 }
 
 
@@ -1569,8 +1582,12 @@ IMPL_LINK_NOARG(SvxSearchDialog, TemplateHdl_Impl, 
Button*, void)
 
 if(!sDesc.isEmpty())
 {
-m_pSearchAttrText->Show();
-m_pReplaceAttrText->Show();
+if (!m_pReplaceAttrText->IsVisible() || 
!m_pReplaceAttrText->IsVisible())
+{
+m_pSearchAttrText->Show();
+m_pReplaceAttrText->Show();
+setOptimalLayoutSize();
+}
 }
 }
 m_pFormatBtn->Disable();
@@ -1596,8 +1613,12 @@ IMPL_LINK_NOARG(SvxSearchDialog, TemplateHdl_Impl, 
Button*, void)
 
 if(!sDesc.isEmpty())
 {
-m_pSearchAttrText->Show();
-m_pReplaceAttrText->Show();
+if (!m_pReplaceAttrText->IsVisible() || 
!m_pReplaceAttrText->IsVisible())
+{
+m_pSearchAttrText->Show();
+m_pReplaceAttrText->Show();
+setOptimalLayoutSize();
+}
 }
 
 EnableControl_Impl(m_pFormatBtn);
@@ -2093,19 +2114,32 @@ IMPL_LINK_NOARG(SvxSearchDialog, NoFormatHdl_Impl, 
Button*, void)
 bFormat = false;
 m_pLayoutBtn->Check( false );
 
+bool bSetOptimalLayoutSize = false;
+
 if ( bSearch )
 {
 pSearchList->Clear();
 m_pSearchAttrText->SetText( "" );
-m_pSearchAttrText->Hide();
+if (m_pSearchAttrText->IsVisible())
+{
+m_pSearchAttrText->Hide();
+bSetOptimalLayoutSize = true;
+}
 }
 else
 {
 pReplaceList->Clear();
 m_pReplaceAttrText->SetText( "" );
-m_pReplaceAttrText->Hide();
+if (m_pReplaceAttrText->IsVisible())
+{
+m_pReplaceAttrText->Hide();
+bSetOptimalLayoutSize = true;
+}
 }
 
+if (bSetOptimalLayoutSize)
+setOptimalLayoutSize();
+
 pImpl->bSaveToModule = false;
 TemplateHdl_Impl(m_pLayoutBtn);
 pImpl->bSaveToModule = true;
@@ -2221,24 +2255,34 @@ void SvxSearchDialog::PaintAttrText_Impl()
 if ( !bFormat && !aDesc.isEmpty() )
 bFormat = true;
 
+bool bSetOptimalLayoutSize = false;
+
 if ( bSearch )
 {
 m_pSearchAttrText->SetText( aDesc );
-if(!aDesc.isEmpty())
+if (!aDesc.isEmpty() && !m_pSearchAttrText->IsVisible())
+{
 m_pSearchAttrText->Show();
+bSetOptimalLayoutSize = true;
+}
 
 FocusHdl_Impl(*m_pSearchLB);
 }
 else
 {
 m_pReplaceAttrText->SetText( aDesc );
-if(!aDesc.isEmpty())
+if (!aDesc.isEmpty() && !m_pReplaceAttrText->IsVisible())
+{
 m_pReplaceAttrText->Show();
+bSetOptimalLayoutSize = true;
+}
 
 FocusHdl_Impl(*m_pReplaceLB);
 }
-}
 
+if (bSetOptimalLayoutSize)
+setOptimalLayoutSize();
+}
 
 void 

[Libreoffice-commits] core.git: solenv/bin

2018-10-07 Thread Libreoffice Gerrit user
 solenv/bin/native-code.py |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit e46f8a9a4e3c5b0542c0813b476b449f3af8d607
Author: Caolán McNamara 
AuthorDate: Sun Oct 7 20:40:54 2018 +0100
Commit: Caolán McNamara 
CommitDate: Sun Oct 7 21:43:05 2018 +0200

move com_sun_star_comp_Writer_RtfExport_get_implementation to writer

Change-Id: I039d416adc23722740125c5f0845e79c47505f03
Reviewed-on: https://gerrit.libreoffice.org/61503
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/solenv/bin/native-code.py b/solenv/bin/native-code.py
index d0d236e9bc93..c552058b72bf 100755
--- a/solenv/bin/native-code.py
+++ b/solenv/bin/native-code.py
@@ -257,8 +257,6 @@ core_constructor_list = [
 
"com_sun_star_comp_oox_docprop_DocumentPropertiesImporter_get_implementation",
 "com_sun_star_comp_oox_ppt_PowerPointImport_get_implementation",
 "com_sun_star_comp_oox_ShapeContextHandler_get_implementation",
-# sw/util/msword.component
-"com_sun_star_comp_Writer_RtfExport_get_implementation",
 ]
 
 # edit group for apps, where you can edit documents
@@ -371,6 +369,8 @@ writer_constructor_list = [
 "com_sun_star_util_comp_FinalThreadManager_get_implementation",
 # sw/util/swd.component
 "com_sun_star_comp_writer_FormatDetector_get_implementation",
+# sw/util/msword.component
+"com_sun_star_comp_Writer_RtfExport_get_implementation",
 # writerfilter/util/writerfilter.component
 "com_sun_star_comp_Writer_RtfFilter_get_implementation",
 "com_sun_star_comp_Writer_WriterFilter_get_implementation",
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: sw/source

2018-10-07 Thread Libreoffice Gerrit user
 sw/source/uibase/utlui/content.cxx |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit 3250c27b86d420d4891e1f83d8b11fb2a7d0
Author: Jim Raykowski 
AuthorDate: Sat Sep 22 10:03:36 2018 -0800
Commit: Jim Raykowski 
CommitDate: Sun Oct 7 08:54:51 2018 +0200

tdf#119900 Fix Navigator Content Navigation View Headings focus

Change-Id: I884ae9d1f13646782f56a982d3d8dc0bc3aacee0
Reviewed-on: https://gerrit.libreoffice.org/60906
Tested-by: Jenkins
Reviewed-by: Jim Raykowski 

diff --git a/sw/source/uibase/utlui/content.cxx 
b/sw/source/uibase/utlui/content.cxx
index 91b1024aa9d8..a12b334dddc9 100644
--- a/sw/source/uibase/utlui/content.cxx
+++ b/sw/source/uibase/utlui/content.cxx
@@ -2108,7 +2108,6 @@ bool SwContentTree::HasContentChanged()
 const SwOutlineNodes::size_type nActPos = 
GetWrtShell()->GetOutlinePos(MAXLEVEL);
 SvTreeListEntry* pFirstEntry = First();
 
-SelectAll(false);
 while( nullptr != (pFirstEntry = Next(pFirstEntry)) )
 {
 
assert(dynamic_cast(static_cast(pFirstEntry->GetUserData(;
@@ -2120,6 +2119,8 @@ bool SwContentTree::HasContentChanged()
 MakeVisible(pFirstEntry);
 }
 }
+else
+Select(pFirstEntry, false);
 }
 
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: sc/source

2018-10-07 Thread Libreoffice Gerrit user
 sc/source/core/tool/queryparam.cxx |6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 9d8c89d9044edb5ad5c8bc4a8f0fd5868192714e
Author: Eike Rathke 
AuthorDate: Sun Oct 7 00:24:31 2018 +0200
Commit: Eike Rathke 
CommitDate: Sun Oct 7 17:46:15 2018 +0200

Resolves: tdf#73081 empty <> not-empty is also a match if numeric

This simplifies to match empty for the same conditions whether
numeric or not, an empty string does not result in numeric 0 here.

Change-Id: I923a3e1f07dd2691d3ac720fc28ba76986fe6c3d
Reviewed-on: https://gerrit.libreoffice.org/61486
Reviewed-by: Eike Rathke 
Tested-by: Jenkins

diff --git a/sc/source/core/tool/queryparam.cxx 
b/sc/source/core/tool/queryparam.cxx
index 269eb700bb83..6e2fefa3f323 100644
--- a/sc/source/core/tool/queryparam.cxx
+++ b/sc/source/core/tool/queryparam.cxx
@@ -290,9 +290,9 @@ void ScQueryParamBase::FillInExcelSyntax(
  * This could be handled independently if all queries should support
  * it, needs to be evaluated if that actually is desired. */
 
-// (empty = empty) is a match, and (empty <> not-empty) also is a match
-if (rItem.meType == ScQueryEntry::ByString)
-rItem.mbMatchEmpty = ((rEntry.eOp == SC_EQUAL && 
rItem.maString.isEmpty())
+// (empty = empty) is a match, and (empty <> not-empty) also is a
+// match. (empty = 0) is not a match.
+rItem.mbMatchEmpty = ((rEntry.eOp == SC_EQUAL && 
rItem.maString.isEmpty())
 || (rEntry.eOp == SC_NOT_EQUAL && !rItem.maString.isEmpty()));
 }
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: reportdesign/source

2018-10-07 Thread Libreoffice Gerrit user
 reportdesign/source/ui/report/ReportSection.cxx |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 8b119b972b37a7e497091167bb6944a1c167f9bb
Author: Julien Nabet 
AuthorDate: Sun Sep 30 11:56:08 2018 +0200
Commit: Julien Nabet 
CommitDate: Sun Oct 7 18:09:37 2018 +0200

tdf#120151: fix crash in edit report

Change-Id: I5ac7960233b615a3dd163cf1ab8355753948240e
Reviewed-on: https://gerrit.libreoffice.org/61152
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/reportdesign/source/ui/report/ReportSection.cxx 
b/reportdesign/source/ui/report/ReportSection.cxx
index 8170adbdfe92..e64cee395cf5 100644
--- a/reportdesign/source/ui/report/ReportSection.cxx
+++ b/reportdesign/source/ui/report/ReportSection.cxx
@@ -353,6 +353,7 @@ void OReportSection::Copy(uno::Sequence< beans::NamedValue 
>& _rAllreadyCopiedOb
 try
 {
 SdrObject* 
pNewObj(pSdrObject->CloneSdrObject(pSdrObject->getSdrModelFromSdrObject()));
+m_pPage->NbcInsertObject(pNewObj);
 aCopies.emplace_back(pNewObj->getUnoShape(),uno::UNO_QUERY);
 if ( _bEraseAnddNoClone )
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


Upstream clang compiler plugins, licensing

2018-10-07 Thread Tamás Zolnai
Hi all,

I plan to work on clang static analyzer in the next monthes and I'm
wondering whether how we can move some of the LO's compiler plugins to
upstream.

As I see LO's license is not compatible with LLVM license [1], as LLVM
license is a more permissive license which allows to make the code part of
a proprietary software for example. So I just wonder what is the best way
to integrate things to clang from LO, either as a compiler plugin or a
static analyzer check.

An idea might be to relicense the compilerplugin code with the LLVM
license, which means additional administration of course, but would make
reusing the code much easier. However I'm not sure this is the best way to
solve this licensing incompatibility.

Any idea is appreciated here or any experience with upstreaming to an open
source software with incompatible license.

Thanks,
Tamás

[1] https://opensource.org/licenses/NCSA
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: Upstream clang compiler plugins, licensing

2018-10-07 Thread Noel Grandin
IANAL, obviously, but possibly you could pick the plugins you want and ask
all the people who worked on that plugin to re-license their work (there
are not that many, and they are mostly still around)

For the record, for anything in compilerplugins/ that I have touched, I
grant you permission to submit my work to LLVM under their license.

Also, note that LLVM is likely to want you to write the plugins in quite a
different style, they don't use our style of overriding ASTVisitor anymore,
so upstreaming is not trivial, they like using some kind of matcher API for
traversing the AST, and they have a whole Checker framework for clang-tidy
stuff.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: cui/source

2018-10-07 Thread Libreoffice Gerrit user
 cui/source/inc/backgrnd.hxx  |   16 +++-
 cui/source/tabpages/backgrnd.cxx |  127 +++
 2 files changed, 63 insertions(+), 80 deletions(-)

New commits:
commit 10510c002229c63ebf04b3b2a78b3f48fd95311c
Author: Noel Grandin 
AuthorDate: Fri Oct 5 14:48:21 2018 +0200
Commit: Noel Grandin 
CommitDate: Sun Oct 7 18:08:34 2018 +0200

flatten some impls in SvxBackgroundTabPage

having not one, but two separate impl classes and then a whole bunch of
data members?

Change-Id: Icd2d4017015d277b55770aea1495366401008ed9
Reviewed-on: https://gerrit.libreoffice.org/61443
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/cui/source/inc/backgrnd.hxx b/cui/source/inc/backgrnd.hxx
index db665c4815ef..256b91f2081c 100644
--- a/cui/source/inc/backgrnd.hxx
+++ b/cui/source/inc/backgrnd.hxx
@@ -30,8 +30,6 @@
 
 class BackgroundPreviewImpl;
 class SvxOpenGraphicDialog;
-struct SvxBackgroundTable_Impl;
-struct SvxBackgroundPage_Impl;
 class SvxBrushItem;
 
 /** class SvxBackgroundTabPage 
@@ -85,10 +83,20 @@ private:
 OUStringaBgdGraphicPath;
 OUStringaBgdGraphicFilter;
 
-std::unique_ptr pPageImpl;
+std::unique_ptr m_pLoadIdle;
+boolm_bIsImportDlgInExecute = false;
+
 std::unique_ptr pImportDlg;
 
-std::unique_ptr pTableBck_Impl;///< Items for 
Sw-Table must be corrected
+///< Items for Sw-Table must be corrected
+std::unique_ptr   m_pCellBrush;
+std::unique_ptr   m_pRowBrush;
+std::unique_ptr   m_pTableBrush;
+sal_uInt16  m_nCellWhich = 0;
+sal_uInt16  m_nRowWhich = 0;
+sal_uInt16  m_nTableWhich = 0;
+sal_Int32   m_nActPos = 0;
+
 std::unique_ptr pHighlighting;
 
 std::unique_ptr m_xWndPosition;
diff --git a/cui/source/tabpages/backgrnd.cxx b/cui/source/tabpages/backgrnd.cxx
index a4a3601b3aa5..52384f3cdea5 100644
--- a/cui/source/tabpages/backgrnd.cxx
+++ b/cui/source/tabpages/backgrnd.cxx
@@ -67,24 +67,6 @@ const sal_uInt16 SvxBackgroundTabPage::pPageRanges[] =
 0
 };
 
-struct SvxBackgroundTable_Impl
-{
-std::unique_ptr   pCellBrush;
-std::unique_ptr   pRowBrush;
-std::unique_ptr   pTableBrush;
-sal_uInt16  nCellWhich;
-sal_uInt16  nRowWhich;
-sal_uInt16  nTableWhich;
-sal_Int32   nActPos;
-
-SvxBackgroundTable_Impl()
-: nCellWhich(0)
-, nRowWhich(0)
-, nTableWhich(0)
-, nActPos(0)
-{}
-};
-
 struct SvxBackgroundPage_Impl
 {
 std::unique_ptr pLoadIdle;
@@ -290,7 +272,6 @@ SvxBackgroundTabPage::SvxBackgroundTabPage(TabPageParent 
pParent, const SfxItemS
 , bHighlighting(false)
 , bCharBackColor(false)
 , m_bColorSelected(false)
-, pPageImpl(new SvxBackgroundPage_Impl)
 , m_xWndPosition(new SvxRectCtl(this))
 , m_xBackgroundColorSet(new 
ColorValueSet(m_xBuilder->weld_scrolled_window("backgroundcolorsetwin")))
 , m_xPreview1(new BackgroundPreviewImpl)
@@ -349,9 +330,11 @@ SvxBackgroundTabPage::~SvxBackgroundTabPage()
 
 void SvxBackgroundTabPage::dispose()
 {
-pPageImpl.reset();
+m_pLoadIdle.reset();
 pImportDlg.reset();
-pTableBck_Impl.reset();
+m_pCellBrush.reset();
+m_pRowBrush.reset();
+m_pTableBrush.reset();
 m_xPreviewWin2.reset();
 m_xPreviewWin1.reset();
 m_xBackgroundColorSetWin.reset();
@@ -461,40 +444,32 @@ void SvxBackgroundTabPage::Reset( const SfxItemSet* rSet )
 {
 if (m_xTblLBox->get_visible())
 {
-int nValue = m_xTblLBox->get_active();
-
-if ( pTableBck_Impl )
-{
-pTableBck_Impl->pCellBrush.reset();
-pTableBck_Impl->pRowBrush.reset();
-pTableBck_Impl->pTableBrush.reset();
-}
-else
-pTableBck_Impl.reset( new SvxBackgroundTable_Impl() );
-
-pTableBck_Impl->nActPos = nValue;
+m_pCellBrush.reset();
+m_pRowBrush.reset();
+m_pTableBrush.reset();
+m_nActPos = m_xTblLBox->get_active();
 
 nWhich = GetWhich( SID_ATTR_BRUSH );
 if ( rSet->GetItemState( nWhich, false ) >= SfxItemState::DEFAULT )
 {
 aBgdAttr = static_cast(rSet->Get(nWhich));
-pTableBck_Impl->pCellBrush.reset(new SvxBrushItem(aBgdAttr));
+m_pCellBrush.reset(new SvxBrushItem(aBgdAttr));
 }
-pTableBck_Impl->nCellWhich = nWhich;
+m_nCellWhich = nWhich;
 
 if ( rSet->GetItemState( SID_ATTR_BRUSH_ROW, false ) >= 
SfxItemState::DEFAULT )
 {
 aBgdAttr = static_cast(rSet->Get(SID_ATTR_BRUSH_ROW));
-pTableBck_Impl->pRowBrush.reset(new SvxBrushItem(aBgdAttr));
+m_pRowBrush.reset(new SvxBrushItem(aBgdAttr));
 }
-pTableBck_Impl->nRowWhich = SID_ATTR_BRUSH_ROW;
+   

[Libreoffice-commits] core.git: starmath/inc starmath/source

2018-10-07 Thread Libreoffice Gerrit user
 starmath/inc/parse.hxx|   28 +--
 starmath/source/parse.cxx |  110 ++
 2 files changed, 68 insertions(+), 70 deletions(-)

New commits:
commit 3e15dd2915f6f0ebb485781e837f1d9c94268b68
Author: Noel Grandin 
AuthorDate: Thu Oct 4 15:34:38 2018 +0200
Commit: Noel Grandin 
CommitDate: Sun Oct 7 18:08:51 2018 +0200

use more unique_ptr in SmParser

Change-Id: I132598f5829e02664040dff745011a59c6a19c1d
Reviewed-on: https://gerrit.libreoffice.org/61401
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/starmath/inc/parse.hxx b/starmath/inc/parse.hxx
index 17e20b4cdaea..851512030c5b 100644
--- a/starmath/inc/parse.hxx
+++ b/starmath/inc/parse.hxx
@@ -89,27 +89,27 @@ class SmParser
 std::unique_ptr DoSubSup(TG nActiveGroup, SmNode *pGivenNode);
 std::unique_ptr DoOpSubSup();
 std::unique_ptr DoPower();
-SmBlankNode *DoBlank();
-SmNode *DoTerm(bool bGroupNumberIdent);
-SmNode *DoEscape();
-SmOperNode *DoOperator();
+std::unique_ptr DoBlank();
+std::unique_ptr DoTerm(bool bGroupNumberIdent);
+std::unique_ptr DoEscape();
+std::unique_ptr DoOperator();
 std::unique_ptr DoOper();
-SmStructureNode *DoUnOper();
+std::unique_ptr DoUnOper();
 std::unique_ptr DoAlign(bool bUseExtraSpaces = true);
 std::unique_ptr DoFontAttribut();
 std::unique_ptr DoAttribut();
 std::unique_ptr DoFont();
 std::unique_ptr DoFontSize();
 std::unique_ptr DoColor();
-SmStructureNode *DoBrace();
-SmBracebodyNode *DoBracebody(bool bIsLeftRight);
-SmTextNode *DoFunction();
-SmTableNode *DoBinom();
-SmStructureNode *DoStack();
-SmStructureNode *DoMatrix();
-SmSpecialNode *DoSpecial();
-SmGlyphSpecialNode *DoGlyphSpecial();
-SmExpressionNode *DoError(SmParseError Error);
+std::unique_ptr DoBrace();
+std::unique_ptr DoBracebody(bool bIsLeftRight);
+std::unique_ptr DoFunction();
+std::unique_ptr DoBinom();
+std::unique_ptr DoStack();
+std::unique_ptr DoMatrix();
+std::unique_ptr DoSpecial();
+std::unique_ptr DoGlyphSpecial();
+std::unique_ptr DoError(SmParseError Error);
 // end of grammar
 
 public:
diff --git a/starmath/source/parse.cxx b/starmath/source/parse.cxx
index 56d778f9b44c..71f9a3a4dce6 100644
--- a/starmath/source/parse.cxx
+++ b/starmath/source/parse.cxx
@@ -988,7 +988,7 @@ std::unique_ptr SmParser::DoAlign(bool 
bUseExtraSpaces)
 
 // allow for just one align statement in 5.0
 if (TokenInGroup(TG::Align))
-return std::unique_ptr(DoError(SmParseError::DoubleAlign));
+return DoError(SmParseError::DoubleAlign);
 }
 
 auto pNode = DoExpression(bUseExtraSpaces);
@@ -1146,7 +1146,7 @@ std::unique_ptr SmParser::DoProduct()
 //Let the glyph node know it's a binary operation
 m_aCurToken.eType = TBOPER;
 m_aCurToken.nGroup = TG::Product;
-xOper.reset(DoGlyphSpecial());
+xOper = DoGlyphSpecial();
 break;
 
 case TOVERBRACE :
@@ -1243,7 +1243,7 @@ std::unique_ptr SmParser::DoSubSup(TG 
nActiveGroup, SmNode *pGivenNode)
 {
 // forget the earlier one, remember an error instead
 aSubNodes[nIndex].reset();
-xENode.reset(DoError(SmParseError::DoubleSubsupscript)); // this 
also skips current token.
+xENode = DoError(SmParseError::DoubleSubsupscript); // this also 
skips current token.
 }
 else
 {
@@ -1261,7 +1261,7 @@ std::unique_ptr SmParser::DoSubSup(TG 
nActiveGroup, SmNode *pGivenNode)
 xSNode = DoRelation();
 }
 else
-xSNode.reset(DoTerm(true));
+xSNode = DoTerm(true);
 
 aSubNodes[nIndex] = std::move(xENode ? xENode : xSNode);
 }
@@ -1308,7 +1308,7 @@ std::unique_ptr SmParser::DoPower()
 return xNode;
 }
 
-SmBlankNode *SmParser::DoBlank()
+std::unique_ptr SmParser::DoBlank()
 {
 DepthProtect aDepthGuard(m_nParseDepth);
 if (aDepthGuard.TooDeep())
@@ -1330,10 +1330,10 @@ SmBlankNode *SmParser::DoBlank()
 {
 pBlankNode->Clear();
 }
-return pBlankNode.release();
+return pBlankNode;
 }
 
-SmNode *SmParser::DoTerm(bool bGroupNumberIdent)
+std::unique_ptr SmParser::DoTerm(bool bGroupNumberIdent)
 {
 DepthProtect aDepthGuard(m_nParseDepth);
 if (aDepthGuard.TooDeep())
@@ -1362,18 +1362,18 @@ SmNode *SmParser::DoTerm(bool bGroupNumberIdent)
 xSNode->SetSubNodes(nullptr, nullptr);
 
 NextToken();
-return xSNode.release();
+return std::unique_ptr(xSNode.release());
 }
 
 auto pNode = DoAlign(!bNoSpace);
 if (m_aCurToken.eType == TRGROUP) {
 NextToken();
-return pNode.release();
+return pNode;
 }
 auto 

[Libreoffice-commits] core.git: 2 commits - extensions/source extensions/uiconfig include/svx sd/source svx/source svx/uiconfig

2018-10-07 Thread Libreoffice Gerrit user
 extensions/source/propctrlr/formcomponenthandler.cxx  |6 -
 extensions/source/propctrlr/listselectiondlg.cxx  |   60 +-
 extensions/source/propctrlr/listselectiondlg.hxx  |   22 +
 extensions/uiconfig/spropctrlr/ui/listselectdialog.ui |   50 +++-
 include/svx/fontworkgallery.hxx   |   20 
 sd/source/ui/dlg/RemoteDialogClientBox.hxx|1 
 svx/source/tbxctrls/fontworkgallery.cxx   |   18 +---
 svx/source/toolbars/fontworkbar.cxx   |8 -
 svx/uiconfig/ui/fontworkspacingdialog.ui  |   73 +-
 9 files changed, 132 insertions(+), 126 deletions(-)

New commits:
commit cf5a2fbbdaace0cbf0e7cbb39e280ec900a82b08
Author: Caolán McNamara 
AuthorDate: Sat Oct 6 21:23:13 2018 +0100
Commit: Caolán McNamara 
CommitDate: Sun Oct 7 19:44:44 2018 +0200

weld FontworkCharacterSpacingDialog

Change-Id: I847c705ae486f9c83877ff3092ebf904e9332e63
Reviewed-on: https://gerrit.libreoffice.org/61483
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/include/svx/fontworkgallery.hxx b/include/svx/fontworkgallery.hxx
index 58ff23d34698..610b0ad96452 100644
--- a/include/svx/fontworkgallery.hxx
+++ b/include/svx/fontworkgallery.hxx
@@ -22,40 +22,28 @@
 #define INCLUDED_SVX_FONTWORKGALLERY_HXX
 
 #include 
-
-#include 
-#include 
-#include 
-#include 
-#include 
-
 #include 
-
 #include 
-
+#include 
 #include 
 
 class FmFormModel;
 class SdrView;
-namespace vcl { class Window; }
 class SdrTextObj;
 class SdrObject;
 class SdrModel;
-
 class SfxBindings;
 
-
 namespace svx
 {
 
-class SAL_WARN_UNUSED FontworkCharacterSpacingDialog : public ModalDialog
+class SAL_WARN_UNUSED FontworkCharacterSpacingDialog : public 
weld::GenericDialogController
 {
-VclPtr m_pMtrScale;
+std::unique_ptr m_xMtrScale;
 
 public:
-FontworkCharacterSpacingDialog( vcl::Window* pParent, sal_Int32 nScale );
+FontworkCharacterSpacingDialog(weld::Window* pParent, sal_Int32 nScale);
 virtual ~FontworkCharacterSpacingDialog() override;
-virtual void dispose() override;
 
 sal_Int32 getScale() const;
 };
diff --git a/sd/source/ui/dlg/RemoteDialogClientBox.hxx 
b/sd/source/ui/dlg/RemoteDialogClientBox.hxx
index c839165a79cc..6ab8522d65f3 100644
--- a/sd/source/ui/dlg/RemoteDialogClientBox.hxx
+++ b/sd/source/ui/dlg/RemoteDialogClientBox.hxx
@@ -24,7 +24,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 
 #include 
diff --git a/svx/source/tbxctrls/fontworkgallery.cxx 
b/svx/source/tbxctrls/fontworkgallery.cxx
index 65243aad0fc2..700a0c852bc8 100644
--- a/svx/source/tbxctrls/fontworkgallery.cxx
+++ b/svx/source/tbxctrls/fontworkgallery.cxx
@@ -624,28 +624,20 @@ 
com_sun_star_comp_svx_FontworkCharacterSpacingControl_get_implementation(
 return cppu::acquire(new FontworkCharacterSpacingControl(xContext));
 }
 
-
-FontworkCharacterSpacingDialog::FontworkCharacterSpacingDialog( vcl::Window* 
pParent, sal_Int32 nScale )
-:   ModalDialog( pParent, "FontworkSpacingDialog" , 
"svx/ui/fontworkspacingdialog.ui" )
+FontworkCharacterSpacingDialog::FontworkCharacterSpacingDialog(weld::Window* 
pParent, sal_Int32 nScale)
+: GenericDialogController(pParent, "svx/ui/fontworkspacingdialog.ui", 
"FontworkSpacingDialog")
+, m_xMtrScale(m_xBuilder->weld_metric_spin_button("entry", FUNIT_PERCENT))
 {
-get(m_pMtrScale, "entry");
-m_pMtrScale->SetValue( nScale );
+m_xMtrScale->set_value(nScale, FUNIT_PERCENT);
 }
 
 FontworkCharacterSpacingDialog::~FontworkCharacterSpacingDialog()
 {
-disposeOnce();
-}
-
-void FontworkCharacterSpacingDialog::dispose()
-{
-m_pMtrScale.clear();
-ModalDialog::dispose();
 }
 
 sal_Int32 FontworkCharacterSpacingDialog::getScale() const
 {
-return static_cast(m_pMtrScale->GetValue());
+return static_cast(m_xMtrScale->get_value(FUNIT_PERCENT));
 }
 
 }
diff --git a/svx/source/toolbars/fontworkbar.cxx 
b/svx/source/toolbars/fontworkbar.cxx
index f5283818191b..90b05316fdc0 100644
--- a/svx/source/toolbars/fontworkbar.cxx
+++ b/svx/source/toolbars/fontworkbar.cxx
@@ -471,11 +471,11 @@ void FontworkBar::execute( SdrView* pSdrView, SfxRequest 
const & rReq, SfxBindin
 if( rReq.GetArgs() && ( rReq.GetArgs()->GetItemState( 
SID_FONTWORK_CHARACTER_SPACING ) == SfxItemState::SET ) )
 {
 sal_Int32 nCharSpacing = 
rReq.GetArgs()->GetItem(SID_FONTWORK_CHARACTER_SPACING)->GetValue();
-ScopedVclPtrInstance< FontworkCharacterSpacingDialog > aDlg( 
nullptr, nCharSpacing );
-sal_uInt16 nRet = aDlg->Execute();
-if( nRet != 0 )
+FontworkCharacterSpacingDialog aDlg(rReq.GetFrameWeld(), 
nCharSpacing);
+sal_uInt16 nRet = aDlg.run();
+if (nRet != RET_CANCEL)
 {
-SfxInt32Item aItem( SID_FONTWORK_CHARACTER_SPACING, 
aDlg->getScale() );

[Libreoffice-commits] core.git: 2 commits - reportdesign/source reportdesign/uiconfig sd/source

2018-10-07 Thread Libreoffice Gerrit user
 reportdesign/source/ui/dlg/PageNumber.cxx |   58 ++
 reportdesign/source/ui/inc/PageNumber.hxx |   33 +++---
 reportdesign/source/ui/report/ReportController.cxx|4 -
 reportdesign/uiconfig/dbreport/ui/pagenumberdialog.ui |   13 ++--
 sd/source/ui/func/fupoor.cxx  |   12 ---
 sd/source/ui/inc/fupoor.hxx   |3 
 6 files changed, 42 insertions(+), 81 deletions(-)

New commits:
commit 08d4100a81396c2c35f074efc41ee89c795e3ab6
Author: Caolán McNamara 
AuthorDate: Sat Oct 6 20:48:02 2018 +0100
Commit: Caolán McNamara 
CommitDate: Sun Oct 7 19:43:51 2018 +0200

weld OPageNumberDialog

Change-Id: I074dade23767e48bc1e0e311629ed4c0b55c1a00
Reviewed-on: https://gerrit.libreoffice.org/61480
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/reportdesign/source/ui/dlg/PageNumber.cxx 
b/reportdesign/source/ui/dlg/PageNumber.cxx
index 27fb930b1205..4821b7ac9d52 100644
--- a/reportdesign/source/ui/dlg/PageNumber.cxx
+++ b/reportdesign/source/ui/dlg/PageNumber.cxx
@@ -36,46 +36,30 @@ using namespace ::comphelper;
 
 // class OPageNumberDialog
 
-OPageNumberDialog::OPageNumberDialog( vcl::Window* _pParent
-   ,const uno::Reference< 
report::XReportDefinition >& _xHoldAlive
-   ,OReportController* _pController)
-: ModalDialog( _pParent, "PageNumberDialog" , 
"modules/dbreport/ui/pagenumberdialog.ui" )
-,m_pController(_pController)
-,m_xHoldAlive(_xHoldAlive)
+OPageNumberDialog::OPageNumberDialog(weld::Window* pParent,
+ const uno::Reference< 
report::XReportDefinition >& _xHoldAlive,
+ OReportController* _pController)
+: GenericDialogController(pParent, 
"modules/dbreport/ui/pagenumberdialog.ui", "PageNumberDialog")
+, m_pController(_pController)
+, m_xHoldAlive(_xHoldAlive)
+, m_xPageN(m_xBuilder->weld_radio_button("pagen"))
+, m_xPageNofM(m_xBuilder->weld_radio_button("pagenofm"))
+, m_xTopPage(m_xBuilder->weld_radio_button("toppage"))
+, m_xBottomPage(m_xBuilder->weld_radio_button("bottompage"))
+, m_xAlignmentLst(m_xBuilder->weld_combo_box("alignment"))
+, 
m_xShowNumberOnFirstPage(m_xBuilder->weld_check_button("shownumberonfirstpage"))
 {
-get(m_pPageN,"pagen");
-get(m_pPageNofM,"pagenofm");
-get(m_pTopPage,"toppage");
-get(m_pBottomPage,"bottompage");
-get(m_pAlignmentLst,"alignment");
-get(m_pShowNumberOnFirstPage,"shownumberonfirstpage");
-
-
-m_pShowNumberOnFirstPage->Hide();
-
+m_xShowNumberOnFirstPage->hide();
 }
 
-
 OPageNumberDialog::~OPageNumberDialog()
 {
-disposeOnce();
-}
-
-void OPageNumberDialog::dispose()
-{
-m_pPageN.clear();
-m_pPageNofM.clear();
-m_pTopPage.clear();
-m_pBottomPage.clear();
-m_pAlignmentLst.clear();
-m_pShowNumberOnFirstPage.clear();
-ModalDialog::dispose();
 }
 
-short OPageNumberDialog::Execute()
+void OPageNumberDialog::execute()
 {
-short nRet = ModalDialog::Execute();
-if ( nRet == RET_OK )
+short nRet = m_xDialog->run();
+if (nRet == RET_OK)
 {
 try
 {
@@ -83,7 +67,7 @@ short OPageNumberDialog::Execute()
 sal_Int32 nPosX = 0;
 sal_Int32 nPos2X = 0;
 awt::Size aRptSize = 
getStyleProperty(m_xHoldAlive,PROPERTY_PAPERSIZE);
-switch ( m_pAlignmentLst->GetSelectedEntryPos() )
+switch (m_xAlignmentLst->get_active())
 {
 case 0: // left
 nPosX = 
getStyleProperty(m_xHoldAlive,PROPERTY_LEFTMARGIN);
@@ -102,23 +86,21 @@ short OPageNumberDialog::Execute()
 default:
 break;
 }
-if ( m_pAlignmentLst->GetSelectedEntryPos() > 2 )
+if (m_xAlignmentLst->get_active() > 2)
 nPosX = nPos2X;
 
 uno::Sequence aValues( 
comphelper::InitPropertySequence({
 { PROPERTY_POSITION, uno::Any(awt::Point(nPosX,0)) },
-{ PROPERTY_PAGEHEADERON, uno::Any(m_pTopPage->IsChecked()) 
},
-{ PROPERTY_STATE, uno::Any(m_pPageNofM->IsChecked()) }
+{ PROPERTY_PAGEHEADERON, 
uno::Any(m_xTopPage->get_active()) },
+{ PROPERTY_STATE, uno::Any(m_xPageNofM->get_active()) }
 }));
 
 m_pController->executeChecked(SID_INSERT_FLD_PGNUMBER,aValues);
 }
 catch(uno::Exception&)
 {
-nRet = RET_NO;
 }
 }
-return nRet;
 }
 
 } // rptui
diff --git a/reportdesign/source/ui/inc/PageNumber.hxx 
b/reportdesign/source/ui/inc/PageNumber.hxx
index 1bfe03dfcaad..8a5150698e2d 100644
--- a/reportdesign/source/ui/inc/PageNumber.hxx
+++ b/reportdesign/source/ui/inc/PageNumber.hxx
@@ -19,14 +19,9 @@
 

[Libreoffice-commits] core.git: extensions/source extensions/uiconfig

2018-10-07 Thread Libreoffice Gerrit user
 extensions/source/propctrlr/newdatatype.cxx  |   30 +++
 extensions/source/propctrlr/newdatatype.hxx  |   21 ++-
 extensions/source/propctrlr/xsdvalidationpropertyhandler.cxx |6 +-
 extensions/uiconfig/spropctrlr/ui/datatypedialog.ui  |9 ++-
 4 files changed, 28 insertions(+), 38 deletions(-)

New commits:
commit 6846f2f204dbaaf9f32c2f717eb39d3a01711087
Author: Caolán McNamara 
AuthorDate: Sat Oct 6 20:54:44 2018 +0100
Commit: Caolán McNamara 
CommitDate: Sun Oct 7 19:44:02 2018 +0200

weld NewDataTypeDialog

Change-Id: Ice5146e72baba397e60fbcb8d64d1ddaeb32e45c
Reviewed-on: https://gerrit.libreoffice.org/61481
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/extensions/source/propctrlr/newdatatype.cxx 
b/extensions/source/propctrlr/newdatatype.cxx
index 6aa4dc633992..8c2876e73b38 100644
--- a/extensions/source/propctrlr/newdatatype.cxx
+++ b/extensions/source/propctrlr/newdatatype.cxx
@@ -28,15 +28,13 @@ namespace pcr
 //= NewDataTypeDialog
 
 
-NewDataTypeDialog::NewDataTypeDialog( vcl::Window* _pParent, const 
OUString& _rNameBase, const std::vector< OUString >& _rProhibitedNames )
-: ModalDialog( _pParent, "DataTypeDialog",
-"modules/spropctrlr/ui/datatypedialog.ui" )
+NewDataTypeDialog::NewDataTypeDialog(weld::Window* pParent, const 
OUString& _rNameBase, const std::vector< OUString >& _rProhibitedNames)
+: GenericDialogController(pParent, 
"modules/spropctrlr/ui/datatypedialog.ui", "DataTypeDialog")
 , m_aProhibitedNames( _rProhibitedNames.begin(), 
_rProhibitedNames.end() )
+, m_xName(m_xBuilder->weld_entry("entry"))
+, m_xOK(m_xBuilder->weld_button("ok"))
 {
-get(m_pName, "entry");
-get(m_pOK, "ok");
-
-m_pName->SetModifyHdl( LINK( this, NewDataTypeDialog, OnNameModified ) 
);
+m_xName->connect_changed(LINK(this, NewDataTypeDialog, 
OnNameModified));
 
 // find an initial name
 // for this, first remove trailing digits
@@ -61,32 +59,22 @@ namespace pcr
 }
 while ( m_aProhibitedNames.find( sInitialName ) != 
m_aProhibitedNames.end() );
 
-m_pName->SetText( sInitialName );
-OnNameModified( *m_pName );
+m_xName->set_text(sInitialName);
+OnNameModified(*m_xName);
 }
 
 NewDataTypeDialog::~NewDataTypeDialog()
 {
-disposeOnce();
-}
-
-void NewDataTypeDialog::dispose()
-{
-m_pName.clear();
-m_pOK.clear();
-ModalDialog::dispose();
 }
 
-IMPL_LINK_NOARG( NewDataTypeDialog, OnNameModified, Edit&, void )
+IMPL_LINK_NOARG(NewDataTypeDialog, OnNameModified, weld::Entry&, void)
 {
 OUString sCurrentName = GetName();
 bool bNameIsOK = ( !sCurrentName.isEmpty() )
   && ( m_aProhibitedNames.find( sCurrentName ) == 
m_aProhibitedNames.end() );
 
-m_pOK->Enable( bNameIsOK );
+m_xOK->set_sensitive(bNameIsOK);
 }
-
-
 } // namespace pcr
 
 
diff --git a/extensions/source/propctrlr/newdatatype.hxx 
b/extensions/source/propctrlr/newdatatype.hxx
index 9185d1f02100..19a88f31c75f 100644
--- a/extensions/source/propctrlr/newdatatype.hxx
+++ b/extensions/source/propctrlr/newdatatype.hxx
@@ -20,10 +20,7 @@
 #ifndef INCLUDED_EXTENSIONS_SOURCE_PROPCTRLR_NEWDATATYPE_HXX
 #define INCLUDED_EXTENSIONS_SOURCE_PROPCTRLR_NEWDATATYPE_HXX
 
-#include 
-#include 
-#include 
-#include 
+#include 
 
 #include 
 #include 
@@ -32,24 +29,22 @@
 namespace pcr
 {
 //= NewDataTypeDialog
-class NewDataTypeDialog : public ModalDialog
+class NewDataTypeDialog : public weld::GenericDialogController
 {
 private:
-VclPtr   m_pName;
-VclPtr   m_pOK;
-
-std::set< OUString > m_aProhibitedNames;
+std::set m_aProhibitedNames;
 
+std::unique_ptr m_xName;
+std::unique_ptr m_xOK;
 public:
-NewDataTypeDialog(vcl::Window* _pParent, const OUString& _rNameBase,
+NewDataTypeDialog(weld::Window* _pParent, const OUString& _rNameBase,
 const std::vector< OUString >& _rProhibitedNames );
 virtual ~NewDataTypeDialog() override;
-virtual void dispose() override;
 
-OUString GetName() const { return m_pName->GetText(); }
+OUString GetName() const { return m_xName->get_text(); }
 
 private:
-DECL_LINK( OnNameModified, Edit&, void );
+DECL_LINK(OnNameModified, weld::Entry&, void);
 };
 
 
diff --git a/extensions/source/propctrlr/xsdvalidationpropertyhandler.cxx 
b/extensions/source/propctrlr/xsdvalidationpropertyhandler.cxx
index 37eb19bdf6da..ec4d6c9f914a 100644
--- a/extensions/source/propctrlr/xsdvalidationpropertyhandler.cxx
+++ b/extensions/source/propctrlr/xsdvalidationpropertyhandler.cxx
@@ -488,11 +488,11 @@ namespace pcr
 std::vector< OUString > aExistentNames;
 

[Libreoffice-commits] core.git: sfx2/inc sfx2/source

2018-10-07 Thread Libreoffice Gerrit user
 sfx2/inc/pch/precompiled_sfx.hxx |1 -
 sfx2/inc/preventduplicateinteraction.hxx |2 --
 sfx2/source/appl/newhelp.hxx |1 -
 3 files changed, 4 deletions(-)

New commits:
commit 45385a532b2d4bd227d6771e54b2b8a9faca939c
Author: Caolán McNamara 
AuthorDate: Sat Oct 6 21:32:08 2018 +0100
Commit: Caolán McNamara 
CommitDate: Sun Oct 7 19:44:55 2018 +0200

drop unnecessary includes

Change-Id: I0a873ecc812f229d972f18370ff06c02f521fedb
Reviewed-on: https://gerrit.libreoffice.org/61484
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sfx2/inc/pch/precompiled_sfx.hxx b/sfx2/inc/pch/precompiled_sfx.hxx
index 51b5c8e10195..079cca3ddb51 100644
--- a/sfx2/inc/pch/precompiled_sfx.hxx
+++ b/sfx2/inc/pch/precompiled_sfx.hxx
@@ -97,7 +97,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
diff --git a/sfx2/inc/preventduplicateinteraction.hxx 
b/sfx2/inc/preventduplicateinteraction.hxx
index 8fdf8f79ea22..8a8cd91b565c 100644
--- a/sfx2/inc/preventduplicateinteraction.hxx
+++ b/sfx2/inc/preventduplicateinteraction.hxx
@@ -34,8 +34,6 @@
 
 #include 
 #include 
-#include 
-#include 
 #include 
 
 namespace com { namespace sun { namespace star { namespace uno {
diff --git a/sfx2/source/appl/newhelp.hxx b/sfx2/source/appl/newhelp.hxx
index fa660cd5f01c..a887f5d00127 100644
--- a/sfx2/source/appl/newhelp.hxx
+++ b/sfx2/source/appl/newhelp.hxx
@@ -32,7 +32,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 120392] New: PDF, ePUB button name

2018-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120392

Bug ID: 120392
   Summary: PDF, ePUB button name
   Product: LibreOffice
   Version: 6.1.2.1 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: edmund.laugas...@gmail.com

Description:
When trying to add the PDF, ePUB button to toolbar that gives a dialog box
before exporting then both buttons in settings have same name and that is
misleading. Currently only experimenting gives the answer which button does
what and it takes too much time and is very bothering.

Steps to Reproduce:
1. View->Toolbars->Customize
2. choose Standard toolbar which is chosen by default
3. open category "Documents"
4. scroll a bit down and there are two buttons with same name in both cases:
either PDF or EPUB

Actual Results:
Impossible to distinguish between buttons: direct action or settings+action. It
violates the default policy where 3 dots in name mean the dialog window with
optin to change settings and also cancel the activity.

Expected Results:
Possible to understand which button does what. Expectations are explained in
"Additional information" section together with additional explanation.


Reproducible: Always


User Profile Reset: No



Additional Info:
E.g. in case of printing there are buttons "Print" and "Print Directly" -
obviously the last one does it directly but first one gives an option to change
settings before printing. In fact would expect here also the 3 dots as it is a
common tradition to have 3 dots with choices that allow settings and do not act
immediately like choices without 3 dots. Hopefully can you fix that as well
(Print -> Print...) - will not file a new bug in case of print button.

Would expect the following names:
- PDF...  (callout text: Export to PDF...)
- PDF directly (callout text: Export to PDF directly)

- EPUB... (callout text: Export to EPUB...)
- EPUB directly (callout text: Export to EPUB directly)

Resetting user profile does not help here.
This applies to all LibreOffice modules in all platforms where is possible to
export to PDF, EPUB. Did not check but there might be similar identities in
button names.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 120394] New: FILEOPEN Strange numbers appear near numbered list in DOC

2018-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120394

Bug ID: 120394
   Summary: FILEOPEN Strange numbers appear near numbered list in
DOC
   Product: LibreOffice
   Version: Inherited From OOo
  Hardware: All
OS: All
Status: UNCONFIRMED
  Keywords: filter:doc
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ba...@caesar.elte.hu
Blocks: 112706

Created attachment 145455
  --> https://bugs.documentfoundation.org/attachment.cgi?id=145455=edit
Sample DOC

Open the attached DOC.

 Note the following discrepancies:
 - the line "IJKL:" becomes "1IJKL:"
 - the numbers 0 and 1 appear above and below the line "1.1.2 FGHIJ"

 Observed using LO 6.2.0.0.alpha0+ (2018-09-22,
8b1501d80dc9d3f42c351c6e026fa737e116cae5) & 3.3.0 / Windows 7.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=112706
[Bug 112706] [META] DOC (binary) bullet and numbering list-related issues
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 108770] [META] DOCX (OOXML) bullet and numbering list-related issues

2018-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108770

Aron Budea  changed:

   What|Removed |Added

 Depends on||108496


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=108496
[Bug 108496] FILEOPEN: DOCX file numbered list restarted from 1 following
section break assumes previous numbered list sequence after 1
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 108496] FILEOPEN: DOCX file numbered list restarted from 1 following section break assumes previous numbered list sequence after 1

2018-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108496

Aron Budea  changed:

   What|Removed |Added

 Blocks|104520  |108770


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=104520
[Bug 104520] [META] DOCX (OOXML) bug tracker
https://bugs.documentfoundation.org/show_bug.cgi?id=108770
[Bug 108770] [META] DOCX (OOXML) bullet and numbering list-related issues
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 104520] [META] DOCX (OOXML) bug tracker

2018-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104520

Aron Budea  changed:

   What|Removed |Added

 Depends on|108496  |


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=108496
[Bug 108496] FILEOPEN: DOCX file numbered list restarted from 1 following
section break assumes previous numbered list sequence after 1
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 112706] [META] DOC (binary) bullet and numbering list-related issues

2018-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=112706

Aron Budea  changed:

   What|Removed |Added

 Depends on||120394


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=120394
[Bug 120394] FILEOPEN Strange numbers appear near numbered list in DOC
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 120394] FILEOPEN Strange numbers appear near numbered list in DOC

2018-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120394

--- Comment #1 from Aron Budea  ---
Created attachment 145456
  --> https://bugs.documentfoundation.org/attachment.cgi?id=145456=edit
PDF exported in Word

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 120378] Menu option "html source" not displayed in writer

2018-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120378

Maxim Monastirsky  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #2 from Maxim Monastirsky  ---
(In reply to V Stuart Foote from comment #1)
> This is expected handling (defaulting to the active document service of an
> open module) to assure user can override defaults.  Exactly the issue of bug
> 89683 for handling delimited text with Writer when needed.
Yes, that's indeed the expected behavior when we talk about the "Open..."
toolbar and menu commands (and users can override this behavior by customizing
the UI and replacing .uno:OpenFromWriter with a plain .uno:Open).

But I'm not sure whether it's the expected behavior also for the "recent
documents" list (which is what this bug report is about). Because the whole
point of "recent documents" is to reopen documents in the same way they were
shown previously. So I would say it's a duplicate of Bug 65017.

*** This bug has been marked as a duplicate of bug 65017 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 65017] FILEOPEN : Menu "File > Recent Documents" opens rtf file as a Calc document instead of in Writer

2018-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=65017

Maxim Monastirsky  changed:

   What|Removed |Added

 CC||bty-admi...@trebly.net

--- Comment #23 from Maxim Monastirsky  ---
*** Bug 120378 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 113560] Digital signature for PDF not working with CACert

2018-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113560

--- Comment #5 from Juan Jose Pablos  ---
It works for me. 
Both the FNMT and the CACERT.org works just fine.


Versión: 6.1.2.1
Id. de compilación: 65905a128db06ba48db947242809d14d3f9a93fe
Subprocs. CPU: 8; SO: Linux 3.16; Repres. IU: predet.; VCL: gtk3; 
Flatpak
Configuración regional: es-ES (es_ES.UTF-8); Calc: group threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 119028] OpenGL: Sleeping and waking the computer up with a dialog open crashes LO

2018-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=119028

Aron Budea  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #15 from Aron Budea  ---
Let's set this to confirmed, the crash is there beyond doubt.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 120396] FILEOPEN 2nd level numbering doesn't increase properly in attached DOC

2018-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120396

--- Comment #1 from Aron Budea  ---
Created attachment 145459
  --> https://bugs.documentfoundation.org/attachment.cgi?id=145459=edit
PDF exported in Word

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 120389] Cannot edit text box content immediately after opening

2018-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120389

--- Comment #3 from conman53...@yahoo.com ---
Comment on attachment 145451
  --> https://bugs.documentfoundation.org/attachment.cgi?id=145451
ODG file that demonstrates the symptom

the automatic upload feature on the web site decided to convert this into a
PDF...so ignore this file

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 62603] Find/Replace affects formatting in undesired ways

2018-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=62603

--- Comment #21 from Luke Kendall  ---
I can confirm the bug is still there, exactly as described in the example file
supplied to reproduce the bug, RegExp-format-ruin.odt

Tested with:

Version: 6.1.2.1
Build ID: 65905a128db06ba48db947242809d14d3f9a93fe
CPU threads: 4; OS: Linux 4.4; UI render: default; VCL: gtk2; 
Locale: en-GB (en_AU.UTF-8); Calc: group threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 120327] Overlapping "dashed" lines appear as solid line

2018-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120327

--- Comment #6 from Heiko Tietze  ---
(In reply to Regina Henschel from comment #5)
> ...
> Therefore I suggest to allow the user to set an individual offset. Such
> option does not exist yet, and therefore would be an enhancement.

Too many options for my taste. Simplicity first means the lines are merged and
one (ideally the last drawn) takes the properties into the result.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 118564] FILEOPEN: DOC: Incorrect mapping for CJK numbered lists

2018-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=118564

Aron Budea  changed:

   What|Removed |Added

 Blocks||112706


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=112706
[Bug 112706] [META] DOC (binary) bullet and numbering list-related issues
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 112706] [META] DOC (binary) bullet and numbering list-related issues

2018-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=112706

Aron Budea  changed:

   What|Removed |Added

 Depends on||118564


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=118564
[Bug 118564] FILEOPEN: DOC: Incorrect mapping for CJK numbered lists
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 120386] Can not change text or style of new items added to end of document w/track changes turned on

2018-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120386

--- Comment #1 from Drew Jensen  ---
Created attachment 145457
  --> https://bugs.documentfoundation.org/attachment.cgi?id=145457=edit
propblem file from LOOL

I needed to keep working on that file so I made a copy of it, with the content
still giving problems at the end of it, and attached it here.

I was able to get around the problem on the working copy by downloading it for
editing with the desktop application. The link from the earlier comment is the
file after those changes.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 120389] Cannot edit text box content immediately after opening

2018-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120389

--- Comment #2 from conman53...@yahoo.com ---
Created attachment 145460
  --> https://bugs.documentfoundation.org/attachment.cgi?id=145460=edit
complex ODG file that exhibits symptom

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 120267] [LOCALIZATION] Some strings not translated in Calc UI menu, pl-PL

2018-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120267

Adolfo Jayme  changed:

   What|Removed |Added

 Whiteboard||target:6.1.3
 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 99678] Sidebar: New Style created from toolbar in Styles - Page Styles doesn't show it immediately

2018-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=99678

Adolfo Jayme  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED
Summary|Sidebar: New Style created  |Sidebar: New Style created
   |from toolbar in Styles and  |from toolbar in Styles -
   |Formatting - Page Styles|Page Styles doesn't show it
   |doesn't show it immediately |immediately

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 103427] [META] Styles and Formatting sidebar deck and floating window

2018-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103427
Bug 103427 depends on bug 99678, which changed state.

Bug 99678 Summary: Sidebar: New Style created from toolbar in Styles - Page 
Styles doesn't show it immediately
https://bugs.documentfoundation.org/show_bug.cgi?id=99678

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 76278] [EDITING][FIELD][UNDO] Updated user field does not respond to undo command

2018-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=76278

--- Comment #9 from János Néhrer  ---
Still reproducible

Version: 6.1.2.1 (x64)
Build ID: 65905a128db06ba48db947242809d14d3f9a93fe
CPU threads: 4; OS: Windows 6.3; UI render: default; 
Locale: hu-HU (en_US); Calc: group threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 65205] Print Component fails to recognize 'Tabloid' as 11x17, uses Letter instead

2018-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=65205

--- Comment #35 from Janny Watson  ---
These bugs are more common in, the current behaviour of the printer began to
change because of this you can try
https://hpetechnicalsupportnumber.com/blog/fix-hp-printer-error-state-problems/
that make your all problems solve and manage the print accurately.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 120389] Cannot edit text box content immediately after opening

2018-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120389

conman53...@yahoo.com changed:

   What|Removed |Added

 Attachment #145451|0   |1
is obsolete||

--- Comment #4 from conman53...@yahoo.com ---
Created attachment 145462
  --> https://bugs.documentfoundation.org/attachment.cgi?id=145462=edit
simpler test file that exhibits the symptom

I created a new ODG file using Draw, adding only a few of the same controls and
labels.  I was able to reproduce the symptom. However, with only one page of
content, I found I only needed to click anything in the navigation pane -- the
same page or any white space in the navigation pane -- to regain the ability to
enter text field content.

I added the simpler test file to simplify things.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 82091] Spelling dialog correction of Calc cells does not remove red wavy underline, but context menu spelling correction does

2018-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=82091

--- Comment #16 from János Néhrer  ---
Reproducible in LibO 6.1.2 under Win 8.1 x64 using English spell checker.

Version: 6.1.2.1 (x64)
Build ID: 65905a128db06ba48db947242809d14d3f9a93fe
CPU threads: 4; OS: Windows 6.3; UI render: default; 
Locale: hu-HU (en_US); Calc: group threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 118901] [META] Issues related to direct formatting in DOCX (OOXML) bullet and numbering list

2018-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=118901

Aron Budea  changed:

   What|Removed |Added

 Depends on||120344


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=120344
[Bug 120344] FILEOPEN DOCX Numbering font setting not imported when using
direct formatting
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 120344] FILEOPEN DOCX Numbering font setting not imported when using direct formatting

2018-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120344

Aron Budea  changed:

   What|Removed |Added

 CC||ba...@caesar.elte.hu
 Blocks||118901


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=118901
[Bug 118901] [META] Issues related to direct formatting in DOCX (OOXML) bullet
and numbering list
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 120396] New: FILEOPEN 2nd level numbering doesn't increase properly in attached DOC

2018-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120396

Bug ID: 120396
   Summary: FILEOPEN 2nd level numbering doesn't increase properly
in attached DOC
   Product: LibreOffice
   Version: Inherited From OOo
  Hardware: All
OS: All
Status: UNCONFIRMED
  Keywords: filter:doc
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ba...@caesar.elte.hu
Blocks: 112706

Created attachment 145458
  --> https://bugs.documentfoundation.org/attachment.cgi?id=145458=edit
Sample DOC

Open the attached document.

Numbering should increase like this: 1, 1.1, 2, 2.1, 2.2.
Instead it's: 1, 1.1, 2, 1.2, 1.3.

Observed using LO 6.2.0.0.alpha0+ (2018-09-22,
8b1501d80dc9d3f42c351c6e026fa737e116cae5) & 3.3.0 / Windows 7.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=112706
[Bug 112706] [META] DOC (binary) bullet and numbering list-related issues
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 104815] signing of existing PDF (version 1.6 ?) does not work

2018-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104815

--- Comment #7 from Juan Jose Pablos  ---
Hi,
Maybe is a problem with that file.

Trying to validate your document using this online test. fail
https://www.pdf-online.com/osa/validate.aspx

But, if you export using libre office. this resulted file. passed the test.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 113136] [META] Find & Replace Dialog

2018-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113136
Bug 113136 depends on bug 106340, which changed state.

Bug 106340 Summary: Buttons overlap other buttons when assigning Format options 
in Find & Replace dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=106340

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 106340] Buttons overlap other buttons when assigning Format options in Find & Replace dialog

2018-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=106340

Adolfo Jayme  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 112706] [META] DOC (binary) bullet and numbering list-related issues

2018-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=112706

Aron Budea  changed:

   What|Removed |Added

 Depends on||120396


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=120396
[Bug 120396] FILEOPEN 2nd level numbering doesn't increase properly in attached
DOC
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 52065] FORMATTING: LO loads and saves tab information incorrectly

2018-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=52065

--- Comment #9 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 63356] EDITING: Unable to change tabs in multiple paragraphs at once when paragraphs have different tab settings or some have bullets/numbering set

2018-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=63356

--- Comment #11 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 79435] DOCX - Legacy forms input fields not correctly supported

2018-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=79435

--- Comment #7 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 90142] Recovery gets to the point of "successful". After "Finish" is pressed, Writer aborts.

2018-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=90142

--- Comment #6 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 94183] LibreOffice recovery wizard initiated when trying to run as administrator and as normal user at the same time

2018-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=94183

--- Comment #2 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 60145] FILEOPEN: UTF-8 encoding without BOM is not detected

2018-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=60145

--- Comment #7 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 57987] Start Center appears in front of (and hides) document recovery window.

2018-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=57987

--- Comment #12 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 37778] FILEOPEN, UI - Read-only recommended .doc files open with protected sections

2018-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=37778

--- Comment #13 from Nicholas van Oudtshoorn  ---
Still present

Tested in latest nightly build:

Version: 6.2.0.0.alpha0+
Build ID: e7d5bad5ae083da12c3ec4a4a8bdc8b42447a242
CPU threads: 4; OS: Linux 4.18; UI render: default; VCL: kde4; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time:
2018-10-06_01:01:43
Locale: en-AU (en_AU.UTF-8); Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 119266] Nodes don't expand on double click in the Customize dialog and Navigator

2018-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=119266

--- Comment #6 from Muhammet Kara  ---
Couldn't reproduce on the navigator.

Maybe it seemed related since some nodes in the navigator have other purposes
like going to the location of the item on double click.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 119266] Nodes don't expand on double click in the Customize dialog and Navigator

2018-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=119266

Muhammet Kara  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |muhammet.k...@pardus.org.tr
   |desktop.org |
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 120394] FILEOPEN Strange numbers appear near numbered list in DOC

2018-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120394

MM  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

--- Comment #2 from MM  ---
Confirmed on windows 7 x64 with Version: 6.0.7.1 (x64)
Build ID: 5d2cb2a5dd04fe174b336488731eb50bbb5faed3
CPU threads: 3; OS: Windows 6.1; UI render: default

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 120396] FILEOPEN 2nd level numbering doesn't increase properly in attached DOC

2018-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120396

MM  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #2 from MM  ---
Confirmed on windows 7 x64 with Version: 6.0.7.1 (x64)
Build ID: 5d2cb2a5dd04fe174b336488731eb50bbb5faed3
CPU threads: 3; OS: Windows 6.1; UI render: default

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 99678] Sidebar: New Style created from toolbar in Styles and Formatting - Page Styles doesn't show it immediately

2018-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=99678

--- Comment #6 from Commit Notification 
 ---
Jim Raykowski committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=94bf82a8ceba41c32cf3620529e6ce8ea94f18c0

tdf#99678 Show style in common template dialog tree box immediatly

It will be available in 6.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 99678] Sidebar: New Style created from toolbar in Styles and Formatting - Page Styles doesn't show it immediately

2018-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=99678

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:6.2.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 62603] Find/Replace affects formatting in undesired ways

2018-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=62603

--- Comment #20 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 108318] copying an Hyperlink in a Textbox

2018-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108318

--- Comment #6 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 120398] New: [Localization] ObjectAlign

2018-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120398

Bug ID: 120398
   Summary: [Localization] ObjectAlign
   Product: LibreOffice
   Version: 6.2.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Localization
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: kain...@gmail.com

Created attachment 145463
  --> https://bugs.documentfoundation.org/attachment.cgi?id=145463=edit
Object Align

.uno:ObjectAlign is called

- Left
- Centered
- Right

- Align Top to Anchor
- Align Middle to Anchor
- Align Bottom to Anchor

My question is why .uno:AlignUp, .uno:AlignDown, .uno:AlignMiddle include the
Align in the english string?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 76134] FORMATTING: Column widths are not interpreted properly from Microsoft Word 2003 XML format

2018-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=76134

--- Comment #8 from János Néhrer  ---
Still reproducible

Version: 6.1.2.1 (x64)
Build ID: 65905a128db06ba48db947242809d14d3f9a93fe
CPU threads: 4; OS: Windows 6.3; UI render: default; 
Locale: hu-HU (en_US); Calc: group threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 120391] EDITING: Comments in Calc without background while editing.

2018-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120391

Robert Gonzalez MX  changed:

   What|Removed |Added

 CC||riggra...@gmail.com

--- Comment #1 from Robert Gonzalez MX  ---
Created attachment 145454
  --> https://bugs.documentfoundation.org/attachment.cgi?id=145454=edit
Descriptions and screenshots

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 120393] New: .cts (TreeSheets) file format import

2018-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120393

Bug ID: 120393
   Summary: .cts (TreeSheets) file format import
   Product: LibreOffice
   Version: 6.1.2.1 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: edmund.laugas...@gmail.com

Description:
There is a great program TreeSheets http://strlen.com/treesheets/
It is using a file format .cts that can be opened only with TreeSheets program.
This might be sometimes not possible but LibreOffice is much more available.

Steps to Reproduce:
1. Create a file with TreeSheets
2. Open LibreOffice
3. Try to open previously created .cts with LibreOffice

Actual Results:
LibreOffice does open the .cts file format and only bunch of garbage symbols
are seen.

Expected Results:
LibreOffice does open the .cts file format without any issues.


Reproducible: Always


User Profile Reset: No



Additional Info:
The TreeSheets program is an open-source - this .cts file format support should
be therefore possible to add - https://github.com/aardappel/treesheets/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 120391] New: EDITING: Comments in Calc without background while editing.

2018-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120391

Bug ID: 120391
   Summary: EDITING: Comments in Calc without background while
editing.
   Product: LibreOffice
   Version: 6.1.0.3 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: riggra...@gmail.com

Description:
When inserting or editing a cell comment in Calc, if the text that is written
extends more than the default space a new row is inserted to continue writing
but this new row has no background until a space in inserted or the “enter”
keystroke. In some cases, even after a space keystroke, the background is not
displayed. Also the black “shadow” of the light blue text box doesn’t adjust to
the new size of it.

This difficult the reading of the text that in written, at least in the second
row until a space keystroke refresh the yellow background.

Steps to Reproduce:
1. Open a new Calc spreadsheet.
2. Select any cell and insert a new comment with right click - insert comment.
3. Start writing some text until a new row is added.
4. Notice that the new row has no yellow background while typing until a space
keystroke
5. After that the background is repainted.
6. This also happens when editing an existing comment and adding text in the
same manner.

Actual Results:
New row added without background and transparent


Expected Results:
The text box should first add the new row with background before any text is
written independently of a space or “enter” keystroke.

The black shadow of the text box should adjust to the text box


Reproducible: Always


User Profile Reset: No



Additional Info:
Tested with Version: 6.1.2.1 (x64)
Build ID: 65905a128db06ba48db947242809d14d3f9a93fe
CPU threads: 8; OS: Windows 10.0; UI render: default; 
Locale: es-MX (es_MX); Calc: CL

and

Versión: 6.1.0.3
Id. de compilación: efb621ed25068d70781dc026f7e9c5187a4decd1
Subprocs. CPU: 4; SO: Linux 4.12; Repres. IU: predet.; VCL: kde4; 
Configuración regional: es-MX (es_MX.ISO-8859-15); Calc: group threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 101216] [META] Calc comment bugs and enhancements

2018-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=101216
Bug 101216 depends on bug 102917, which changed state.

Bug 102917 Summary: After insert of cell comment escape key causes Text 
Formatting toolbar to open/close
https://bugs.documentfoundation.org/show_bug.cgi?id=102917

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 102917] After insert of cell comment escape key causes Text Formatting toolbar to open/close

2018-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=102917

--- Comment #17 from Robert Gonzalez MX  ---
I retested this issue and its no longer present. Since my comment 15 I hadn't
have a problem with this, so I'll change status to WORKSFORME.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 102917] After insert of cell comment escape key causes Text Formatting toolbar to open/close

2018-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=102917

Robert Gonzalez MX  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 120397] New: FILESAVE doesn't save all the text in text box control

2018-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120397

Bug ID: 120397
   Summary: FILESAVE doesn't save all the text in text box control
   Product: LibreOffice
   Version: 6.0.6.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Draw
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: conman53...@yahoo.com

Description:
I added text to a text box control.  I save the file.  I later open the file
and add text to the text box.  I save the file.  I later open the file and the
added text is not displayed.

I renamed the ODG file to a ZIP file. Opened it and looked at the "content.xml"
file. After Draw saves it, there are two places where the field content is
stored. One is the full text. The other is how it's displayed.

Under this tag: Lucky: 
  Reroll attack, ability check, or saving
  throw when a 1 is rolled (must use new
  roll).
  Nimbleness: Can move
  through the space of any creature that is larger than
  me (small).
  
  Brave:
  Advantage on saving throws against being
  frightened.
  Stout: Advantage on
  saving throws against poison damage and have
  resistance against poison damage.
  
  Monk
  Unarmed Defense: if no
  armor or shield
  AC=10 + Dex mod + Wis
  mod
  
  Ki = 2
  Flurry of Blows: 1 ki
  for 2 unarmed bonus attacks
  Patient Defense: 1 ki
  for bonus dodge
  Step of the Wind: 1 ki
  to disengage or dash as a bonus action, jump distance
  is doubled for the turn
  

So the problem is that Draw doesn't save _all_ the text in the  tags...at
least not consistently. It's probably easier to see in the attachment.

Steps to Reproduce:
1. Open attached ODG file.
2. Click on 2nd page, then on the first page so you can add content in textbox
control.
3. Add text to the "Features & Traits" textbox.
4. Save file.
5. Exit Draw application.
6. Open file using Draw.
7. See that added text is not being displayed.


Actual Results:
Added text is not displayed, despite being stored in ODG's content.xml file.

Expected Results:
Display all the added text in textbox control when ODG file subsequently
opened.


Reproducible: Always


User Profile Reset: Yes


OpenGL enabled: Yes

Additional Info:
Version: 6.0.6.2
Build ID: 1:6.0.6-0ubuntu0.18.04.1
CPU threads: 8; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: en-US (en_US.UTF-8); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 120397] FILESAVE doesn't save all the text in text box control

2018-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120397

--- Comment #1 from conman53...@yahoo.com ---
Created attachment 145461
  --> https://bugs.documentfoundation.org/attachment.cgi?id=145461=edit
complex ODG file that exhibits symptom

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 94183] LibreOffice recovery wizard initiated when trying to run as administrator and as normal user at the same time

2018-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=94183

--- Comment #3 from János Néhrer  ---
Issue still reproducible in LibreOffice 6.1.2

Version: 6.1.2.1 (x64)
Build ID: 65905a128db06ba48db947242809d14d3f9a93fe
CPU threads: 4; OS: Windows 6.3; UI render: default; 
Locale: hu-HU (en_US); Calc: group threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 120393] .cts (TreeSheets) file format import

2018-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120393

Adolfo Jayme  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
   Priority|medium  |lowest
   Severity|normal  |enhancement
 Ever confirmed|0   |1

--- Comment #1 from Adolfo Jayme  ---
Thanks for sharing your request. → NEW/enhancement

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 120392] Unclear PDF, ePUB button name in Customize dialog

2018-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120392

Adolfo Jayme  changed:

   What|Removed |Added

Summary|PDF, ePUB button name   |Unclear PDF, ePUB button
   ||name in Customize dialog

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 120374] Button disappears after saving

2018-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120374

MM  changed:

   What|Removed |Added

Version|6.1.2.1 release |5.1.6.2 release
 OS|Windows (All)   |All
 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #2 from MM  ---
Confirmed on windows 7 x64 with Version: 6.0.7.1 (x64)
Build ID: 5d2cb2a5dd04fe174b336488731eb50bbb5faed3
CPU threads: 3; OS: Windows 6.1; UI render: default

and ubuntu 16.04 x64 with Version: 5.1.6.2
Build ID: 07ac168c60a517dba0f0d7bc7540f5afa45f0909
CPU Threads: 2; OS Version: Linux 4.4; UI Render: default; 
Locale: en-US (en_US.UTF-8); Calc: single

Saving as xlsm and xlsx loses the button. Saving as xls is fine, only the
button is grey instead of green.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 120328] Saving changes removes Windows NTFS encryption on a file

2018-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120328

Mike Kaganski  changed:

   What|Removed |Added

 Resolution|FIXED   |DUPLICATE

--- Comment #3 from Mike Kaganski  ---


*** This bug has been marked as a duplicate of bug 119238 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 120352] Calc does not import anymore external data from web pages

2018-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120352

Oliver Brinzing  changed:

   What|Removed |Added

   Keywords||regression
 OS|Linux (All) |All
 Status|NEEDINFO|NEW

--- Comment #3 from Oliver Brinzing  ---
i can confirm this:

> with the new version of libreoffice works:
> https://www.boursorama.com/cours/1rPRAL/

worked in LO 5.4.7.2 and LO 6.1.2 but not in LO 6.0.6

> However this link does not work also in the new version of libreoffice:
> https://finance.yahoo.com/quote/URW.AS/history?p=URW.AS

worked in LO 5.4.7.2 but not in LO 6.0.6/6.1.2

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 120372] Embedded pictures disappear from Writer when documents are opened

2018-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120372

Oliver Brinzing  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||oliver.brinz...@gmx.de
 Status|UNCONFIRMED |NEEDINFO

--- Comment #1 from Oliver Brinzing  ---
can you confirm this issue with LO 6.1.2.1 ?

with LO 6.1 image handling has been reworked: 
https://wiki.documentfoundation.org/ReleaseNotes/6.1#Image_handling_rework

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 120352] Calc does not import anymore external data from web pages

2018-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120352

--- Comment #4 from Oliver Brinzing  ---
btw: 
entering a web url is unfortune, cause one has to press 
(enter) to start the search process. 
i am missing a [Submit] button, or at least a hint.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 35287] feature request: smooth scroll

2018-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=35287

--- Comment #22 from netj...@gmail.com ---
+1

Smooth scrolling has been repeatedly shown to increase navigability in UI
design. Since calc is being used more and more for viewing all kinds of
documents, not just classical spreadsheets, this is getting increasingly
important.

Smooth scrolling (pixel) and not snapping back to cell borders should be the
default. Both vertical and horizontal, as well as in subcell content scrolling.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 120373] New: Hyperlink removal functionality "hidden" by default

2018-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120373

Bug ID: 120373
   Summary: Hyperlink removal functionality "hidden" by default
   Product: LibreOffice
   Version: 6.2.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: eyal...@technion.ac.il

Suppose I have a cell with a hyperlink. How do I remove it?

* Right-click context menu -> No removal option
* Hover -> No removal option
* Edit Menu -> Nothing to do with links
* Format Menu -> Nothing to do with links
* Any other menus -> Again, nothing to do with links

It seems like my only option, with the default menu and toolbars, is "Insert
Hyperlink" on the main toolbar, which opens the edit dialog - but even there I
don't see a Remove Link options.

What's going on here?

Even if I've missed something, I claim that the right-click menu, _and_ the
Edit (or another) menu, should both by default have some entry or button for
removing the link. Also, the link edit dialog should allow removal.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 107787] Gradients steps don't save

2018-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=107787

--- Comment #18 from Heiko Tietze  ---
(In reply to Regina Henschel from comment #17)
> (In reply to Heiko Tietze from comment #16)
> > But we are talking about a
> > piece only, meaning the gradient (and other area fill options) is always
> > bound to an object.
> 
> No, a gradient is an entity of it own. It can exists in the file without
> being used. A gradient is different from a style. A gradient is a
>  element and a style is a  element and neither
> can be a child element of the other. A style can reference a gradient by the
> gradient name.

Then it's not well defined (similarly to list styles, IMHO) and we do have to
make clear, given the implementation is done accordingly, why solid colors,
hatches, patterns etc. are not styles.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 120369] No way to load a gradient palette

2018-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120369

Heiko Tietze  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #1 from Heiko Tietze  ---
We intentionally removed the load/save functions and deliberately cleaned up
the UI. If those functions should come back it has to be as an extension, in my
opinion. OTOH, I could live without those sog files.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 120327] Overlapping "dashed" lines appear as solid line

2018-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120327

Heiko Tietze  changed:

   What|Removed |Added

 CC|libreoffice-ux-advise@lists |tietze.he...@gmail.com
   |.freedesktop.org|
   Severity|minor   |normal
 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1
   Keywords|needsUXEval |

--- Comment #2 from Heiko Tietze  ---
Yes, definitely a bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-ux-advise] [Bug 120327] Overlapping "dashed" lines appear as solid line

2018-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120327

Heiko Tietze  changed:

   What|Removed |Added

 CC|libreoffice-ux-advise@lists |tietze.he...@gmail.com
   |.freedesktop.org|
   Severity|minor   |normal
 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1
   Keywords|needsUXEval |

--- Comment #2 from Heiko Tietze  ---
Yes, definitely a bug.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-bugs] [Bug 120340] no icon exist

2018-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120340

--- Comment #4 from josefu...@gmail.com ---
1. Had an important document 5 pages long complete with images and text.  Saved
before the new update.
2  Update downloaded.
3. Opened that same doc and all images gone except a blank square with a number
e.g figure 8 in the original place.
4. Couldn't for the life of me go back to the original state.  The images never
appeared.
5. If the blank square is deleted then its place is filled with adjacent text.
6. Tried Help asked me to go to Charts and Images in the Tools.  It isn't
there!
7. It is an extremely important doc to introduce to an assembly

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 95156] Incorrect calculations on large spreadsheet

2018-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=95156

--- Comment #6 from Oliver Brinzing  ---
reproducible with

Version: 6.1.2.1 (x64)
Build-ID: 65905a128db06ba48db947242809d14d3f9a93fe
CPU-Threads: 4; BS: Windows 10.0; UI-Render: Standard; 
Gebietsschema: de-DE (de_DE); Calc: 

but *not* with:

Version: 6.2.0.0.alpha0+ (x64)
Build ID: 315e585f283e6e4a5f1ac11e7d17a638d04e82b0
CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; 
Locale: de-DE (de_DE); Calc:

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 119857] Multiple comments display and management - ability to toggle visibility of comments and see only selected one

2018-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=119857

Heiko Tietze  changed:

   What|Removed |Added

   Keywords|needsUXEval |
 CC|libreoffice-ux-advise@lists |tietze.he...@gmail.com
   |.freedesktop.org|

--- Comment #2 from Heiko Tietze  ---
(In reply to Tomasz Palutkiewicz from comment #0)
> Description:
> If there are many comments at single page of document,
> list of fields at the right side becomes quite long and lines are mixed;
> it would be very useful to hide the lines and contents of all comments
> and use comment marks to show and hide only particular one.

We collapse in case of many comments and that's suboptimal, though I disagree
with hiding lines or non-active comments. The discussion runs in bug 38295 and
bug 86888 & bug 89232.

> Additionally it would be nice to manipulate the size of comment marks,
> i.e. make it proportional to font size of text where it is placed
> or just generally (default) by some comboBox in comment options.
> Finally it may be useful to change content and format of comment header (it
> is fixed: author, date, time - font size of 12pt).

That's bug 85592, bug 81458 and basically bug 62150. And some other maybe too. 

If you agree, Thomas, we close this ticket as duplicate and you join the
others. Thanks for reporting anyway!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-ux-advise] [Bug 119857] Multiple comments display and management - ability to toggle visibility of comments and see only selected one

2018-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=119857

Heiko Tietze  changed:

   What|Removed |Added

   Keywords|needsUXEval |
 CC|libreoffice-ux-advise@lists |tietze.he...@gmail.com
   |.freedesktop.org|

--- Comment #2 from Heiko Tietze  ---
(In reply to Tomasz Palutkiewicz from comment #0)
> Description:
> If there are many comments at single page of document,
> list of fields at the right side becomes quite long and lines are mixed;
> it would be very useful to hide the lines and contents of all comments
> and use comment marks to show and hide only particular one.

We collapse in case of many comments and that's suboptimal, though I disagree
with hiding lines or non-active comments. The discussion runs in bug 38295 and
bug 86888 & bug 89232.

> Additionally it would be nice to manipulate the size of comment marks,
> i.e. make it proportional to font size of text where it is placed
> or just generally (default) by some comboBox in comment options.
> Finally it may be useful to change content and format of comment header (it
> is fixed: author, date, time - font size of 12pt).

That's bug 85592, bug 81458 and basically bug 62150. And some other maybe too. 

If you agree, Thomas, we close this ticket as duplicate and you join the
others. Thanks for reporting anyway!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-bugs] [Bug 119900] After Scrolling a Long Chapter List in the Navigator, the Focus Jumps Back to Chapter with the Cursor in Content Navigation View

2018-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=119900

Cor Nouws  changed:

   What|Removed |Added

   Keywords||regression
 CC||c...@nouenoff.nl

--- Comment #15 from Cor Nouws  ---
I've experienced the same, but not yet reported etc etc.
So thanks Harald, Xisco, Jim, * !

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-ux-advise] [Bug 120232] 'Default all columns to text' option to 'Text Import' when copypasting CSV-data

2018-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120232

Heiko Tietze  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC|libreoffice-ux-advise@lists |tietze.he...@gmail.com
   |.freedesktop.org|
   Keywords|needsUXEval |
 Resolution|--- |WORKSFORME

--- Comment #5 from Heiko Tietze  ---
Agree with Regina and Stuart, Calc is primarily dealing with numbers and we
shouldn't spoil this for the majority of users. And eventually there is not
only a workaround but the perfect way to not modify the clipboard aka make all
data text: select the table and choose text from the dropdown. So WFM.

Thanks for your suggestion anyway. Keep on sharing your use cases and proposals
for improvements.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-bugs] [Bug 120232] 'Default all columns to text' option to 'Text Import' when copypasting CSV-data

2018-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120232

Heiko Tietze  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC|libreoffice-ux-advise@lists |tietze.he...@gmail.com
   |.freedesktop.org|
   Keywords|needsUXEval |
 Resolution|--- |WORKSFORME

--- Comment #5 from Heiko Tietze  ---
Agree with Regina and Stuart, Calc is primarily dealing with numbers and we
shouldn't spoil this for the majority of users. And eventually there is not
only a workaround but the perfect way to not modify the clipboard aka make all
data text: select the table and choose text from the dropdown. So WFM.

Thanks for your suggestion anyway. Keep on sharing your use cases and proposals
for improvements.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


  1   2   3   >