[Libreoffice-commits] core.git: download.lst external/boost

[Luboš Luňák (via logerrit)]

 download.lst |5 +--
 external/boost/repack_tarball.sh |   60 +++
 2 files changed, 63 insertions(+), 2 deletions(-)

New commits:
commit 996f0e6a0f39434e6e1b1b450262d97af60d663d
Author: Luboš Luňák 
AuthorDate: Mon Mar 2 12:57:42 2020 +0100
Commit: Luboš Luňák 
CommitDate: Wed Mar 18 12:21:23 2020 +0100

repack the boost tarball to be smaller and faster

The tarball is almost 100MiB and it unpacks to roughly 0.75GiB,
because it contains tons of generated html docs and other stuff that
is not needed for building. Unpacking it on Cygwin takes several
minutes (done in parallel, but still) and even on Linux the unpacking
takes longer than the actual compilation.

Change-Id: Ied9f3059530f4e9a856170ec3fcc304631ff8e0a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89825
Tested-by: Jenkins
Reviewed-by: Luboš Luňák 

diff --git a/download.lst b/download.lst
index 9a8a6681c0e2..9983fc0386b1 100644
--- a/download.lst
+++ b/download.lst
@@ -6,8 +6,9 @@ export APR_SHA256SUM := 
1af06e1720a58851d90694a984af18355b65bb0d047be03ec7d659c7
 export APR_TARBALL := apr-1.5.2.tar.gz
 export APR_UTIL_SHA256SUM := 
976a12a59bc286d634a21d7be0841cc74289ea9077aa1af46be19d1a6e844c19
 export APR_UTIL_TARBALL := apr-util-1.5.4.tar.gz
-export BOOST_SHA256SUM := 
d73a8da01e8bf8c7eda40b4c84915071a8c8a0df4a6734537ddde4a8580524ee
-export BOOST_TARBALL := boost_1_71_0.tar.bz2
+# please repack the tarball using external/boost/repack_tarball.sh
+export BOOST_SHA256SUM := 
35e06a3bd7cd8f66be822c7d64e80c2b6051a181e9e897006917cb8e7988a543
+export BOOST_TARBALL := boost_1_71_0.tar.xz
 export BREAKPAD_SHA256SUM := 
7060149be16a8789b0ccf596bdeaf63115f03f520acb508f72a14686fb311cb9
 export BREAKPAD_TARBALL := breakpad.zip
 export BSH_SHA256SUM := 
9e93c73e23aff644b17dfff65674c14150e7f3b38b19635e622235e01c96
diff --git a/external/boost/repack_tarball.sh b/external/boost/repack_tarball.sh
new file mode 100755
index ..ed27875f6def
--- /dev/null
+++ b/external/boost/repack_tarball.sh
@@ -0,0 +1,60 @@
+#! /bin/sh
+
+# Repack the boost tarball as xz (much faster to unpack) and remove
+# a lot of needless files such as generated html docs.
+
+tarball="$1"
+
+if test -z "$tarball" -o ! -f "$tarball"; then
+echo "Usage: $0 "
+exit 1
+fi
+
+tmpdir=$(mktemp -d)
+
+if ! test -d "$tmpdir"; then
+echo mktemp failed
+exit 1
+fi
+
+echo Unpacking "$tarball" ...
+tar x -C "$tmpdir" -f "$tarball"
+if test $? -ne 0; then
+echo tar x failed
+rm -rf "$tmpdir"
+exit 1
+fi
+
+echo Removing unnecessary files ...
+find "$tmpdir" \( -name doc -o -name test -o -name example \) -type d -prune 
-print0 | xargs -0 rm -r
+if test $? -ne 0; then
+echo file removal failed
+rm -rf "$tmpdir"
+exit 1
+fi
+
+name="$(basename "$tarball" | sed 's/\.tar.*$//').tar.xz"
+dir=$(ls "$tmpdir")
+
+echo Creating "$name" ...
+# To make the tarball reproducible, use a timestamp of a file inside the 
tarball (they all seem to have the same mtime).
+if ! test -f "$tmpdir/$dir/README.md"; then
+echo timestamp retrieval failed, check the script
+rm -rf "$tmpdir"
+exit 1
+fi
+# Many of the options are to make the tarball reproducible.
+LC_ALL=C tar c -C "$tmpdir" --xz -f "$(pwd)/$name" --format=gnu --sort=name 
--owner=0 --group=0 --mode=go=rX,u=rwX --mtime "$tmpdir/$dir/README.md" "$dir"
+if test $? -ne 0; then
+echo tar c failed
+rm -rf "$tmpdir"
+exit 1
+fi
+
+echo Cleaning up ...
+rm -rf "$tmpdir"
+
+sha256sum "$name"
+
+echo Done.
+exit 0
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] help.git: source/text

[LibreOfficiant (via logerrit)]

 source/text/sbasic/shared/01020300.xhp |  164 ++---
 source/text/sbasic/shared/property.xhp |2 
 2 files changed, 92 insertions(+), 74 deletions(-)

New commits:
commit 74fc09527478fff86496efdac55f3d6d339b8537
Author: LibreOfficiant 
AuthorDate: Mon Feb 24 14:36:11 2020 +0100
Commit: Olivier Hallot 
CommitDate: Wed Mar 18 12:57:56 2020 +0100

o Property statement added in Procedures & Functions help
o Multiple layout changes
Note: Optional keyword to be referenced later in above help

o ByVal/ByRef added to Property help page


Change-Id: I30e84c1e7464b4bc101727d2d088a35173f74b34
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/89282
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/source/text/sbasic/shared/01020300.xhp 
b/source/text/sbasic/shared/01020300.xhp
index d3d1dd08e..5db47968d 100644
--- a/source/text/sbasic/shared/01020300.xhp
+++ b/source/text/sbasic/shared/01020300.xhp
@@ -17,23 +17,18 @@
  *   except in compliance with the License. You may obtain a copy of
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
 -->
-
 
   
-Using Procedures and Functions
+Using Procedures, Functions or 
Properties
 /text/sbasic/shared/01020300.xhp
   
 
-
 
-
-
-
 
   procedures
   functions;using
-  variables;passing to procedures and 
functions
-  parameters;for procedures and functions
+  variables;passing to procedures, functions, 
properties
+  parameters;for procedures, functions or 
properties
   parameters;passing by reference or value
   variables;scope
   scope of variables
@@ -43,57 +38,77 @@
   functions;return value type
   return value type of functions
 
-
-
-Using Procedures and 
Functions
-The following 
describes the basic use of procedures and functions in $[officename] 
Basic.
+
+Using 
Procedures, Functions and Properties
+The following describes the 
basic use of procedures, functions and properties in %PRODUCTNAME 
Basic.
 
-When you create a 
new module, $[officename] Basic automatically inserts a SUB called "Main". This 
default name has nothing to do with the order or the starting point of a 
$[officename] Basic project. You can also safely rename this SUB.
-Some restrictions 
apply for the names of your public variables, subs, and functions. You must not 
use the same name as one of the modules of the same library.
-Procedures 
(SUBS) and functions (FUNCTIONS) help you maintaining a structured overview by 
separating a program into logical pieces.
-One benefit of 
procedures and functions is that, once you have developed a program code 
containing task components, you can use this code in another 
project.
-
-Passing 
Variables to Procedures (SUB) and Functions (FUNCTION)
-Variables can 
be passed to both procedures and functions. The SUB or FUNCTION must be 
declared to expect parameters:
+When you create a new module, %PRODUCTNAME Basic 
automatically inserts a Sub called 
"Main". This default name has nothing to do with the order 
or the starting point of a %PRODUCTNAME Basic project. You can also safely 
rename this Subroutine.
+Some restrictions apply for the names of your 
public variables, subroutines, functions and properties. You must not use the 
same name as one of the modules of the same library.
+Procedures 
(Subroutines) functions (Function) and 
properties (Property) help you maintaining a structured 
overview by separating a program into logical pieces.
+One benefit of 
procedures, functions and properties is that, once you have developed a program 
code containing task components, you can use this code in another 
project.
+Passing Variables to Procedures, Functions or 
Properties
+Variables can 
be passed to both procedures, functions or properties. The 
Sub Function or 
Property must be declared to expect parameters:
 
-Sub SubName(Parameter1 As Type, Parameter2 As 
Type,...)
-Program 
code
-End Sub
+  Sub 
SubName(Parameter1 As TYPENAME, Parameter2 As TYPENAME,...)
+   
your code goes here
+  End 
Sub
 
-The SUB is 
called using the following syntax:
+The 
Sub is called using the following syntax:
 
-SubName(Value1, Value2,...)
+  SubName(Value1, Value2,...)
 
-The parameters 
passed to a SUB must fit to those specified in the SUB declaration.
-The same 
process applies to FUNCTIONS. In addition, functions always return a function 
result. The result of a function is defined by assigning the return value to 
the function name:
+The parameters 
passed to a Sub must fit to those specified in the 
Sub declaration.
+The same 
process applies to a Function. In addition, functions always 
return a function result. The result of a function is defined by assigning the 
return value to the function name:
 
-Function FunctionName(Parameter1 As Type, Parameter2 As 
Type,...) As Type
-Program 
code
-FunctionName=Result
-End Function
+  Function 
FunctionName(Parameter1 As TYPENAME, Parameter2 As TYPENAME,...) As 
TYPENAME
+   
your code goes 

[Libreoffice-commits] core.git: helpcontent2

[LibreOfficiant (via logerrit)]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 74fa1259eb37a0541989cf3029adfcb33fdd071e
Author: LibreOfficiant 
AuthorDate: Wed Mar 18 12:57:56 2020 +0100
Commit: Gerrit Code Review 
CommitDate: Wed Mar 18 12:57:56 2020 +0100

Update git submodules

* Update helpcontent2 from branch 'master'
  to 74fc09527478fff86496efdac55f3d6d339b8537
  - o Property statement added in Procedures & Functions help
o Multiple layout changes
Note: Optional keyword to be referenced later in above help

o ByVal/ByRef added to Property help page


Change-Id: I30e84c1e7464b4bc101727d2d088a35173f74b34
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/89282
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index 17a565a57af1..74fc09527478 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 17a565a57af1fff46b1a2ffdf4f9ab322696eb92
+Subproject commit 74fc09527478fff86496efdac55f3d6d339b8537
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-4' - unotools/source

[Caolán McNamara (via logerrit)]

 unotools/source/i18n/resmgr.cxx |3 +++
 1 file changed, 3 insertions(+)

New commits:
commit dc8db8308840516115a3f7cc9397a5c37bf99862
Author: Caolán McNamara 
AuthorDate: Tue Mar 17 20:14:17 2020 +
Commit: Adolfo Jayme Barrientos 
CommitDate: Wed Mar 18 14:01:01 2020 +0100

tdf#131069 always produce utf-8 from gettext

Change-Id: I311e647f08b4d541825e7790d971b98b5b5bfe40
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90631
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/unotools/source/i18n/resmgr.cxx b/unotools/source/i18n/resmgr.cxx
index 47069489aa41..786c83df2e7b 100644
--- a/unotools/source/i18n/resmgr.cxx
+++ b/unotools/source/i18n/resmgr.cxx
@@ -130,7 +130,10 @@ namespace Translate
 OString sPath(OUStringToOString(path, osl_getThreadTextEncoding()));
 gen.add_messages_path(sPath.getStr());
 #if defined UNX && !defined MACOSX && !defined IOS && !defined ANDROID
+// allow gettext to find these .mo files e.g. so gtk dialogs can use 
them
 bindtextdomain(pPrefixName, sPath.getStr());
+// tdf#131069 gtk, and anything sane, always wants utf-8 strings as 
output
+bind_textdomain_codeset(pPrefixName, "UTF-8");
 #endif
 gen.add_messages_domain(pPrefixName);
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.2' - sd/source

[Mert Tumer (via logerrit)]

 sd/source/ui/func/fusel.cxx |   16 
 1 file changed, 8 insertions(+), 8 deletions(-)

New commits:
commit 18ac91043d2e90b89ac56e3230d687fffeeb25a9
Author: Mert Tumer 
AuthorDate: Wed Mar 18 13:17:32 2020 +0300
Commit: Andras Timar 
CommitDate: Wed Mar 18 11:59:54 2020 +0100

mobile: fix hyperlinks are not clickable on impress

Change-Id: I77a0ef263814359607d9c1d863f93c55f3493dbb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90687
Tested-by: Andras Timar 
Reviewed-by: Andras Timar 

diff --git a/sd/source/ui/func/fusel.cxx b/sd/source/ui/func/fusel.cxx
index 81988e00a351..b5e49ef8112f 100644
--- a/sd/source/ui/func/fusel.cxx
+++ b/sd/source/ui/func/fusel.cxx
@@ -269,6 +269,14 @@ bool FuSelection::MouseButtonDown(const MouseEvent& rMEvt)
  {
 mpWindow->ReleaseMouse();
 
+// If tiled rendering, let client handles URL execution and 
early returns.
+if (comphelper::LibreOfficeKit::isActive())
+{
+SfxViewShell& rSfxViewShell = 
mpViewShell->GetViewShellBase();
+
rSfxViewShell.libreOfficeKitViewCallback(LOK_CALLBACK_HYPERLINK_CLICKED, 
aVEvt.pURLField->GetURL().toUtf8().getStr());
+return true;
+}
+
 SvtSecurityOptions aSecOpt;
 if (!rMEvt.IsMod1() && 
aSecOpt.IsOptionSet(SvtSecurityOptions::EOption::CtrlClickHyperlink))
 return true;
@@ -281,14 +289,6 @@ bool FuSelection::MouseButtonDown(const MouseEvent& rMEvt)
 SfxViewFrame* pFrame = mpViewShell->GetViewFrame();
 mpWindow->ReleaseMouse();
 
-// If tiled rendering, let client handles URL execution and 
early returns.
-if (comphelper::LibreOfficeKit::isActive())
-{
-SfxViewShell& rSfxViewShell = 
mpViewShell->GetViewShellBase();
-
rSfxViewShell.libreOfficeKitViewCallback(LOK_CALLBACK_HYPERLINK_CLICKED, 
aVEvt.pURLField->GetURL().toUtf8().getStr());
-return true;
-}
-
 if (rMEvt.IsMod1())
 {
 // Open in new frame
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] help.git: source/text

[Seth Chaiklin (via logerrit)]

 source/text/shared/00/00040502.xhp |4 +++-
 source/text/shared/01/05210400.xhp |5 +++--
 2 files changed, 6 insertions(+), 3 deletions(-)

New commits:
commit b20290463c2aee8a8fa5a8a38a42b5ccde9c2aed
Author: Seth Chaiklin 
AuthorDate: Wed Mar 18 11:44:27 2020 +0100
Commit: Olivier Hallot 
CommitDate: Wed Mar 18 13:04:42 2020 +0100

tdf#131036 add note to Hatch help page about "rename" and "delete"

  There is no indication on the Hatch tab in the Area page that it
  is possible to name/rename and/or delete existing hatch patterns.
  Adding a  about this possibility.

  Also add "howtoget" access command for Page/Slide in Writer/Draw/
  Impress.  (Calc does not have Hatch for a Sheet).

  Add missing period in first line.

Change-Id: I414c2c0527b916d24e8703915dc9ca1208342fc0
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/90633
Tested-by: Jenkins
Reviewed-by: Seth Chaiklin 

diff --git a/source/text/shared/00/00040502.xhp 
b/source/text/shared/00/00040502.xhp
index e277a896c..17b458d63 100644
--- a/source/text/shared/00/00040502.xhp
+++ b/source/text/shared/00/00040502.xhp
@@ -81,7 +81,7 @@
   
 
   Choose Table - Properties - Background 
tab.
-  Choose Format - Page - Area 
tab.
+  Choose Format - Page Style - Area 
tab.
 
 
   Choose Slide - Properties - Background 
tab.
@@ -125,6 +125,8 @@
 Object - 
Area - Gradients 
tab.
 Choose Format - Text Box and Shape - 

 Object - 
Object and Shape 
- Area - 
Hatch tab.
+Choose 
Format - Page Style - Area - Hatch 
tab.
+Choose Page - 
Properties - Background - Hatch 
tab.Choose Slide - 
Properties - Background - Hatch 
tab.
 Choose Format - Text Box and Shape - 
 Object - 
Area - Bitmaps 
tab.
 Choose Format - Text Box and Shape - Text 
Attributes
diff --git a/source/text/shared/01/05210400.xhp 
b/source/text/shared/01/05210400.xhp
index 1b65c1e06..df0ce3763 100644
--- a/source/text/shared/01/05210400.xhp
+++ b/source/text/shared/01/05210400.xhp
@@ -34,20 +34,21 @@
 
 
 Hatch
-Set the properties of a hatching pattern, or 
save a new hatching pattern
+Set the properties of a hatching pattern, or 
save a new hatching pattern.
 
 
 
+
 
 Hatch
 Lists the 
available hatching patterns. You can also modify or create your own hatching 
pattern.
 
+To rename a hatching pattern, select the 
pattern, right-click and choose Rename. To delete a 
hatching pattern, select the pattern, right-click and choose 
Delete.
 Add
 Adds a custom hatching pattern to the current list. 
Specify the properties of your hatching pattern, and then click this 
button.
 
 Modify
 Applies the current hatching properties to the 
selected hatching pattern. If you want, you can save the pattern under a 
different name.
-
 Options
 Define or 
modify a hatching pattern.
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: helpcontent2

[Seth Chaiklin (via logerrit)]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 80177eed6b0d81a314fad3117032bb0b06e80b6f
Author: Seth Chaiklin 
AuthorDate: Wed Mar 18 13:04:42 2020 +0100
Commit: Gerrit Code Review 
CommitDate: Wed Mar 18 13:04:42 2020 +0100

Update git submodules

* Update helpcontent2 from branch 'master'
  to b20290463c2aee8a8fa5a8a38a42b5ccde9c2aed
  - tdf#131036 add note to Hatch help page about "rename" and "delete"

  There is no indication on the Hatch tab in the Area page that it
  is possible to name/rename and/or delete existing hatch patterns.
  Adding a  about this possibility.

  Also add "howtoget" access command for Page/Slide in Writer/Draw/
  Impress.  (Calc does not have Hatch for a Sheet).

  Add missing period in first line.

Change-Id: I414c2c0527b916d24e8703915dc9ca1208342fc0
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/90633
Tested-by: Jenkins
Reviewed-by: Seth Chaiklin 

diff --git a/helpcontent2 b/helpcontent2
index 74fc09527478..b20290463c2a 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 74fc09527478fff86496efdac55f3d6d339b8537
+Subproject commit b20290463c2aee8a8fa5a8a38a42b5ccde9c2aed
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sd/uiconfig

[Caolán McNamara (via logerrit)]

 sd/uiconfig/sdraw/ui/breakdialog.ui |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 4ac7d1aa3fce2e0d2daefa644e87f4040c00c40a
Author: Caolán McNamara 
AuthorDate: Wed Mar 18 10:19:06 2020 +
Commit: Caolán McNamara 
CommitDate: Wed Mar 18 14:16:03 2020 +0100

give the break dialog more space for its numbers

Change-Id: I6548a40ec86ab1442642347f004eeb229d1e3c57
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90685
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/sd/uiconfig/sdraw/ui/breakdialog.ui 
b/sd/uiconfig/sdraw/ui/breakdialog.ui
index fed1c27e7f9a..4c69c54c2e9a 100644
--- a/sd/uiconfig/sdraw/ui/breakdialog.ui
+++ b/sd/uiconfig/sdraw/ui/breakdialog.ui
@@ -47,6 +47,7 @@
 False
 12
 12
+True
 
   
 True
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-4' - oox/qa oox/source

[Miklos Vajna (via logerrit)]

 oox/qa/unit/data/shape-non-autosize-with-text.docx |binary
 oox/qa/unit/vml.cxx|   18 ++
 oox/source/vml/vmlshape.cxx|6 +++---
 3 files changed, 21 insertions(+), 3 deletions(-)

New commits:
commit 29ccc5f041562305c559d0e84ed90af9ccf302f7
Author: Miklos Vajna 
AuthorDate: Mon Mar 16 21:18:25 2020 +0100
Commit: Xisco Faulí 
CommitDate: Wed Mar 18 15:32:20 2020 +0100

tdf#131118 VML import: fix size of non-autosize shapes containing text

Regression from commit b92293b3943423324064a8513c2e114d18817179
(tdf#103983 VML import: handle , 2020-01-20), the problem was that in
case we disable autosize too late, then the size will be already set
during adding text to the shape.

Do it before adding text, this way adding text won't change the shape
size, so it'll be correct at the end of the import.

(cherry picked from commit 4ee7ee1c4a515479bc174543af4dbc400035c0ba)

Change-Id: I9410fc695c3edfa5089d845864bf237e71c533c4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90602
Tested-by: Jenkins
Reviewed-by: Xisco Faulí 

diff --git a/oox/qa/unit/data/shape-non-autosize-with-text.docx 
b/oox/qa/unit/data/shape-non-autosize-with-text.docx
new file mode 100644
index ..b9ae501f4b93
Binary files /dev/null and b/oox/qa/unit/data/shape-non-autosize-with-text.docx 
differ
diff --git a/oox/qa/unit/vml.cxx b/oox/qa/unit/vml.cxx
index 01539abdfbda..b83334eeadc6 100644
--- a/oox/qa/unit/vml.cxx
+++ b/oox/qa/unit/vml.cxx
@@ -103,6 +103,24 @@ CPPUNIT_TEST_FIXTURE(OoxVmlTest, testSpt202ShapeType)
 CPPUNIT_ASSERT_EQUAL(OUString("com.sun.star.drawing.TextShape"), 
xShape->getShapeType());
 }
 
+CPPUNIT_TEST_FIXTURE(OoxVmlTest, testShapeNonAutosizeWithText)
+{
+// Load a document which has a group shape, containing a single child.
+// 17.78 cm is the full group shape width, 19431/64008 is the child 
shape's relative width inside
+// that, so 5.3975 cm should be the shape width.
+load("shape-non-autosize-with-text.docx");
+uno::Reference 
xDrawPagesSupplier(getComponent(), uno::UNO_QUERY);
+uno::Reference 
xDrawPage(xDrawPagesSupplier->getDrawPages()->getByIndex(0),
+ uno::UNO_QUERY);
+uno::Reference xGroup(xDrawPage->getByIndex(0), 
uno::UNO_QUERY);
+uno::Reference xShape(xGroup->getByIndex(0), 
uno::UNO_QUERY);
+// Without the accompanying fix in place, this test would have failed with:
+// - Actual  : 1115
+// - Expected: 5398
+// because the width was determined using its text size, not using the 
explicit size.
+CPPUNIT_ASSERT_EQUAL(static_cast(5398), 
xShape->getSize().Width);
+}
+
 CPPUNIT_PLUGIN_IMPLEMENT();
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/oox/source/vml/vmlshape.cxx b/oox/source/vml/vmlshape.cxx
index 82cacfdcaf68..45409c3f23a3 100644
--- a/oox/source/vml/vmlshape.cxx
+++ b/oox/source/vml/vmlshape.cxx
@@ -784,6 +784,9 @@ Reference< XShape > SimpleShape::implConvertAndInsert( 
const Reference< XShapes
 eTextVerticalAdjust = drawing::TextVerticalAdjust_BOTTOM;
 PropertySet(xShape).setAnyProperty(PROP_TextVerticalAdjust, 
makeAny(eTextVerticalAdjust));
 
+PropertySet(xShape).setAnyProperty(PROP_TextAutoGrowHeight,
+   makeAny(maTypeModel.mbAutoHeight));
+
 if (getTextBox())
 {
 getTextBox()->convert(xShape);
@@ -797,9 +800,6 @@ Reference< XShape > SimpleShape::implConvertAndInsert( 
const Reference< XShapes
 xShape->setSize(aSize);
 }
 }
-
-PropertySet(xShape).setAnyProperty(PROP_TextAutoGrowHeight,
-   makeAny(maTypeModel.mbAutoHeight));
 }
 
 // Import Legacy Fragments (if any)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.2' - chart2/source

[Muhammet Kara (via logerrit)]

 chart2/source/controller/sidebar/ChartElementsPanel.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 0ced5dfbef64feaf24309eecd58e3ab9d8df860b
Author: Muhammet Kara 
AuthorDate: Wed Mar 18 13:56:43 2020 +0300
Commit: Andras Timar 
CommitDate: Wed Mar 18 13:52:27 2020 +0100

Sidebar: Fix title & subtitle checkboxes on the ChartDeck

They now work as they did before the regression. An uncheck action
removes the title/subtitle, and a check action just makes the existing
title/subtitle visible or creates a new one if it doesn't exist

Change-Id: I23122d1be2d95af878b824ba194bd1aeed5f4f89
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90692
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Andras Timar 

diff --git a/chart2/source/controller/sidebar/ChartElementsPanel.cxx 
b/chart2/source/controller/sidebar/ChartElementsPanel.cxx
index 2f9d7ebaec27..28bc8c1a5469 100644
--- a/chart2/source/controller/sidebar/ChartElementsPanel.cxx
+++ b/chart2/source/controller/sidebar/ChartElementsPanel.cxx
@@ -599,7 +599,7 @@ void 
ChartElementsPanel::setTitleVisible(TitleHelper::eTitleType eTitle, bool bV
 }
 else
 {
-TitleHelper::hideTitle(eTitle, mxModel);
+TitleHelper::removeTitle(eTitle, mxModel);
 }
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-3' - dictionaries

[Andras Timar (via logerrit)]

 dictionaries |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit d8ab4f56d436381a89bce3f75ea5985f7f04419f
Author: Andras Timar 
AuthorDate: Wed Mar 18 14:05:17 2020 +0100
Commit: Gerrit Code Review 
CommitDate: Wed Mar 18 14:05:17 2020 +0100

Update git submodules

* Update dictionaries from branch 'libreoffice-6-3'
  to 6f8a006d37290a3c167ce94c9d7a5e652b33279c
  - tdf#130999 fix registration of Greek dictionary

Change-Id: I7b85d588c67c9b05f3856d92544fb0a0348594ea
Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/90627
Tested-by: Adolfo Jayme Barrientos 
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/dictionaries b/dictionaries
index b29122518a4d..6f8a006d3729 16
--- a/dictionaries
+++ b/dictionaries
@@ -1 +1 @@
-Subproject commit b29122518a4d462aad03cd8b7cb3b2aa0b4a844a
+Subproject commit 6f8a006d37290a3c167ce94c9d7a5e652b33279c
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] dictionaries.git: Branch 'libreoffice-6-3' - el_GR/META-INF

[Andras Timar (via logerrit)]

 el_GR/META-INF/manifest.xml |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 6f8a006d37290a3c167ce94c9d7a5e652b33279c
Author: Andras Timar 
AuthorDate: Tue Mar 17 12:09:00 2020 +0100
Commit: Adolfo Jayme Barrientos 
CommitDate: Wed Mar 18 14:05:17 2020 +0100

tdf#130999 fix registration of Greek dictionary

Change-Id: I7b85d588c67c9b05f3856d92544fb0a0348594ea
Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/90627
Tested-by: Adolfo Jayme Barrientos 
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/el_GR/META-INF/manifest.xml b/el_GR/META-INF/manifest.xml
index 839346e..f54199b 100644
--- a/el_GR/META-INF/manifest.xml
+++ b/el_GR/META-INF/manifest.xml
@@ -2,5 +2,5 @@
 
 http://openoffice.org/2001/manifest;>
 
-
\ No newline at end of file
+manifest:full-path="dictionaries.xcu"/>
+
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] dictionaries.git: Branch 'libreoffice-6-4' - el_GR/META-INF

[Andras Timar (via logerrit)]

 el_GR/META-INF/manifest.xml |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 390a74603cd452dc35b34bc956927d519953bcab
Author: Andras Timar 
AuthorDate: Tue Mar 17 12:09:00 2020 +0100
Commit: Adolfo Jayme Barrientos 
CommitDate: Wed Mar 18 14:04:52 2020 +0100

tdf#130999 fix registration of Greek dictionary

Change-Id: I7b85d588c67c9b05f3856d92544fb0a0348594ea
Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/90626
Tested-by: Adolfo Jayme Barrientos 
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/el_GR/META-INF/manifest.xml b/el_GR/META-INF/manifest.xml
index 839346e..f54199b 100644
--- a/el_GR/META-INF/manifest.xml
+++ b/el_GR/META-INF/manifest.xml
@@ -2,5 +2,5 @@
 
 http://openoffice.org/2001/manifest;>
 
-
\ No newline at end of file
+manifest:full-path="dictionaries.xcu"/>
+
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-4' - dictionaries

[Andras Timar (via logerrit)]

 dictionaries |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 1086318fdba1d10eeb347ea00cf0b37a8edf8814
Author: Andras Timar 
AuthorDate: Wed Mar 18 14:04:52 2020 +0100
Commit: Gerrit Code Review 
CommitDate: Wed Mar 18 14:04:52 2020 +0100

Update git submodules

* Update dictionaries from branch 'libreoffice-6-4'
  to 390a74603cd452dc35b34bc956927d519953bcab
  - tdf#130999 fix registration of Greek dictionary

Change-Id: I7b85d588c67c9b05f3856d92544fb0a0348594ea
Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/90626
Tested-by: Adolfo Jayme Barrientos 
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/dictionaries b/dictionaries
index 2e25022c7405..390a74603cd4 16
--- a/dictionaries
+++ b/dictionaries
@@ -1 +1 @@
-Subproject commit 2e25022c7405dc29aab47f26369bbcc21fbe6e68
+Subproject commit 390a74603cd452dc35b34bc956927d519953bcab
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: vcl/inc vcl/unx

[Luboš Luňák (via logerrit)]

 vcl/inc/unx/freetypetextrender.hxx |2 ++
 vcl/unx/generic/gdi/freetypetextrender.cxx |2 ++
 2 files changed, 4 insertions(+)

New commits:
commit 8ce20d3e062819fdab52d2ce47762ccc02b34ab2
Author: Luboš Luňák 
AuthorDate: Wed Mar 18 13:12:43 2020 +0100
Commit: Luboš Luňák 
CommitDate: Wed Mar 18 13:13:53 2020 +0100

fix --disable-cairo-canvas build

I dropped this in 9b231fb18a731774a1579206ef635b8b709304d2.

Change-Id: I9bdd266af70041a8c27766efb7f15352ea8fa4e0

diff --git a/vcl/inc/unx/freetypetextrender.hxx 
b/vcl/inc/unx/freetypetextrender.hxx
index c4abba43dfdc..4c15fb9bfec5 100644
--- a/vcl/inc/unx/freetypetextrender.hxx
+++ b/vcl/inc/unx/freetypetextrender.hxx
@@ -64,7 +64,9 @@ public:
 
 virtual std::unique_ptr
 GetTextLayout(int nFallbackLevel) override;
+#if ENABLE_CAIRO_CANVAS
 virtual SystemFontData  GetSysFontData( int nFallbackLevel ) const 
override;
+#endif
 };
 
 #endif
diff --git a/vcl/unx/generic/gdi/freetypetextrender.cxx 
b/vcl/unx/generic/gdi/freetypetextrender.cxx
index d7591444f5a1..7693eff8c0d8 100644
--- a/vcl/unx/generic/gdi/freetypetextrender.cxx
+++ b/vcl/unx/generic/gdi/freetypetextrender.cxx
@@ -169,6 +169,7 @@ std::unique_ptr 
FreeTypeTextRenderImpl::GetTextLayout(int nFal
 return 
std::make_unique(*mpFreetypeFont[nFallbackLevel]->GetFontInstance());
 }
 
+#if ENABLE_CAIRO_CANVAS
 SystemFontData FreeTypeTextRenderImpl::GetSysFontData( int nFallbackLevel ) 
const
 {
 SystemFontData aSysFontData;
@@ -189,6 +190,7 @@ SystemFontData FreeTypeTextRenderImpl::GetSysFontData( int 
nFallbackLevel ) cons
 
 return aSysFontData;
 }
+#endif
 
 bool FreeTypeTextRenderImpl::CreateFontSubset(
const OUString& rToFile,
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loleaflet/css

[Pedro Pinto Silva (via logerrit)]

 loleaflet/css/mobilewizard.css |8 +++-
 1 file changed, 3 insertions(+), 5 deletions(-)

New commits:
commit 82ac7f527f688a5133f0cb9516b822d87f2d7870
Author: Pedro Pinto Silva 
AuthorDate: Wed Mar 18 10:44:30 2020 +0100
Commit: Pedro Pinto da Silva 
CommitDate: Wed Mar 18 15:39:37 2020 +0100

Mobile: Writer: Fix Insert Custom Table

Change-Id: I5208a74d4806b7b661e213db0a314b944be797de
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90684
Tested-by: Jenkins CollaboraOffice 
Tested-by: Pedro Pinto da Silva 
Reviewed-by: Pedro Pinto da Silva 

diff --git a/loleaflet/css/mobilewizard.css b/loleaflet/css/mobilewizard.css
index 0782df404..899bc1959 100644
--- a/loleaflet/css/mobilewizard.css
+++ b/loleaflet/css/mobilewizard.css
@@ -519,12 +519,10 @@
margin-left: 14%;
width: 50%;
border: none;
-   top: 82px;
+   padding-top: 1.2%;
color: #555 !important;
}
-   .inserttablecontrols p.ui-text:first-child {
-   top: 21px;
-   }
+
.inserttablecontrols #rows, .inserttablecontrols #cols{
background: url('images/lc_inserttable_row_mono.svg') no-repeat 
left;
border: none !important;
@@ -537,7 +535,7 @@
}
.inserttablecontrols .spinfield{
width: 35% !important;
-   margin-left: 32% !important;
+   margin-left: 10% !important;
text-align: center;
}
.inserttablecontrols .sinfieldcontrols{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loleaflet/images

[Pedro Pinto Silva (via logerrit)]

 loleaflet/images/lc_setobjecttobackground.svg |4 
 loleaflet/images/lc_setobjecttoforeground.svg |4 
 2 files changed, 8 insertions(+)

New commits:
commit 8fa38448e9c0a0bfd6412eb9f5d46b80b8528e02
Author: Pedro Pinto Silva 
AuthorDate: Wed Mar 18 15:02:23 2020 +0100
Commit: Pedro Pinto da Silva 
CommitDate: Wed Mar 18 15:55:34 2020 +0100

Mobile: Writer: context menu: Add missing icons for set shape to background 
and foreground

Change-Id: I63408cdd8b693445a358050abee03044617c7287
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90702
Tested-by: Jenkins CollaboraOffice 
Tested-by: Pedro Pinto da Silva 
Reviewed-by: Pedro Pinto da Silva 

diff --git a/loleaflet/images/lc_setobjecttobackground.svg 
b/loleaflet/images/lc_setobjecttobackground.svg
new file mode 100644
index 0..8f96c8d07
--- /dev/null
+++ b/loleaflet/images/lc_setobjecttobackground.svg
@@ -0,0 +1,4 @@
+http://www.w3.org/2000/svg;>
+ 
+ 
+
diff --git a/loleaflet/images/lc_setobjecttoforeground.svg 
b/loleaflet/images/lc_setobjecttoforeground.svg
new file mode 100644
index 0..12c50cdeb
--- /dev/null
+++ b/loleaflet/images/lc_setobjecttoforeground.svg
@@ -0,0 +1,4 @@
+http://www.w3.org/2000/svg;>
+ 
+ 
+
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: unotools/source

[Caolán McNamara (via logerrit)]

 unotools/source/i18n/resmgr.cxx |3 +++
 1 file changed, 3 insertions(+)

New commits:
commit 49d1325ecbcbad32abd4cc55d946a720f99801f4
Author: Caolán McNamara 
AuthorDate: Tue Mar 17 20:14:17 2020 +
Commit: Caolán McNamara 
CommitDate: Wed Mar 18 12:40:43 2020 +0100

tdf#131069 always produce utf-8 from gettext

Change-Id: I311e647f08b4d541825e7790d971b98b5b5bfe40
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90668
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/unotools/source/i18n/resmgr.cxx b/unotools/source/i18n/resmgr.cxx
index df5283d71292..a1d74ec1b7cd 100644
--- a/unotools/source/i18n/resmgr.cxx
+++ b/unotools/source/i18n/resmgr.cxx
@@ -138,7 +138,10 @@ namespace Translate
 #endif
 gen.add_messages_path(sPath.getStr());
 #if defined UNX && !defined MACOSX && !defined IOS && !defined ANDROID
+// allow gettext to find these .mo files e.g. so gtk dialogs can use 
them
 bindtextdomain(pPrefixName, sPath.getStr());
+// tdf#131069 gtk, and anything sane, always wants utf-8 strings as 
output
+bind_textdomain_codeset(pPrefixName, "UTF-8");
 #endif
 gen.add_messages_domain(pPrefixName);
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sd/source

[Caolán McNamara (via logerrit)]

 sd/source/ui/dlg/brkdlg.cxx |5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

New commits:
commit b913cec377878ed640582dcf611ccf8eaf21bd85
Author: Caolán McNamara 
AuthorDate: Wed Mar 18 10:22:26 2020 +
Commit: Caolán McNamara 
CommitDate: Wed Mar 18 12:40:25 2020 +0100

tdf#131395 handle all outstanding events

to ensure the paint gets handled, if this turns out not to be sufficient 
then
next fallback is to allow a route to Dialog::ensureRepaint to be exposed

Change-Id: I3ab749170dfaeb92eae40a44bb1bde123c47f9f4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90686
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/sd/source/ui/dlg/brkdlg.cxx b/sd/source/ui/dlg/brkdlg.cxx
index 81a0251ea819..8edfac4e1aa4 100644
--- a/sd/source/ui/dlg/brkdlg.cxx
+++ b/sd/source/ui/dlg/brkdlg.cxx
@@ -21,8 +21,9 @@
 #include 
 
 #include 
-#include 
+#include 
 #include 
+#include 
 
 #include 
 #include 
@@ -125,7 +126,7 @@ IMPL_LINK( BreakDlg, UpDate, void*, nInit, bool )
 // make sure dialog gets painted, it is intended to
 // show the progress to the user. Also necessary to
 // provide a clickable cancel button
-Application::Reschedule(true);
+Scheduler::ProcessEventsToIdle();
 
 // return okay-value (-> !cancel)
 return !m_bCancel;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sw/qa

[Xisco Fauli (via logerrit)]

 sw/qa/extras/uiwriter/data3/tdf130746.odt |binary
 sw/qa/extras/uiwriter/uiwriter3.cxx   |   37 ++
 2 files changed, 37 insertions(+)

New commits:
commit b705be7c8c28c4e1c1263e476b7b9cb0d6cee089
Author: Xisco Fauli 
AuthorDate: Wed Mar 18 11:37:34 2020 +0100
Commit: Xisco Faulí 
CommitDate: Wed Mar 18 14:12:10 2020 +0100

tdf#130746: Add unittest

Change-Id: I5a3bd6ab503ecf4a48ad5123ad952b267935a573
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90688
Tested-by: Jenkins
Reviewed-by: Xisco Faulí 

diff --git a/sw/qa/extras/uiwriter/data3/tdf130746.odt 
b/sw/qa/extras/uiwriter/data3/tdf130746.odt
new file mode 100644
index ..7fcbec95b0a8
Binary files /dev/null and b/sw/qa/extras/uiwriter/data3/tdf130746.odt differ
diff --git a/sw/qa/extras/uiwriter/uiwriter3.cxx 
b/sw/qa/extras/uiwriter/uiwriter3.cxx
index 2a62ac2e9928..0a7d61695821 100644
--- a/sw/qa/extras/uiwriter/uiwriter3.cxx
+++ b/sw/qa/extras/uiwriter/uiwriter3.cxx
@@ -280,6 +280,43 @@ CPPUNIT_TEST_FIXTURE(SwUiWriterTest3, testTdf107975)
 CPPUNIT_ASSERT_EQUAL(sal_Int32(1), xIndexAccess->getCount());
 }
 
+CPPUNIT_TEST_FIXTURE(SwUiWriterTest3, testTdf130746)
+{
+load(DATA_DIRECTORY, "tdf130746.odt");
+
+SwXTextDocument* pTextDoc = 
dynamic_cast(mxComponent.get());
+CPPUNIT_ASSERT(pTextDoc);
+
+uno::Reference xTextTablesSupplier(mxComponent, 
uno::UNO_QUERY);
+uno::Reference 
xIndexAccess(xTextTablesSupplier->getTextTables(),
+ uno::UNO_QUERY);
+CPPUNIT_ASSERT_EQUAL(sal_Int32(1), xIndexAccess->getCount());
+
+dispatchCommand(mxComponent, ".uno:JumpToNextTable", {});
+
+uno::Reference xModel(mxComponent, uno::UNO_QUERY);
+uno::Reference xTextViewCursorSupplier(
+xModel->getCurrentController(), uno::UNO_QUERY);
+uno::Reference 
xCursor(xTextViewCursorSupplier->getViewCursor(),
+  uno::UNO_QUERY);
+CPPUNIT_ASSERT_EQUAL(sal_Int16(1), xCursor->getPage());
+
+pTextDoc->postKeyEvent(LOK_KEYEVENT_KEYINPUT, 0, KEY_RETURN);
+Scheduler::ProcessEventsToIdle();
+
+CPPUNIT_ASSERT_EQUAL(sal_Int16(2), xCursor->getPage());
+
+pTextDoc->postKeyEvent(LOK_KEYEVENT_KEYINPUT, 0, KEY_UP | KEY_MOD2);
+Scheduler::ProcessEventsToIdle();
+
+CPPUNIT_ASSERT_EQUAL(sal_Int16(2), xCursor->getPage());
+
+dispatchCommand(mxComponent, ".uno:Undo", {});
+
+CPPUNIT_ASSERT_EQUAL(sal_Int16(1), xCursor->getPage());
+CPPUNIT_ASSERT_EQUAL(sal_Int32(1), xIndexAccess->getCount());
+}
+
 CPPUNIT_TEST_FIXTURE(SwUiWriterTest3, testTdf130680)
 {
 load(DATA_DIRECTORY, "tdf130680.odt");
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: wsd/ClientSession.cpp

[Miklos Vajna (via logerrit)]

 wsd/ClientSession.cpp |3 +++
 1 file changed, 3 insertions(+)

New commits:
commit f32c1f2febf7d3a3bdf0c7b0afa70d69a24cc761
Author: Miklos Vajna 
AuthorDate: Wed Mar 18 09:20:31 2020 +0100
Commit: Miklos Vajna 
CommitDate: Wed Mar 18 15:17:02 2020 +0100

wsd: improve lifecycle in ClientSession::onDisconnect()

Once unit-bad-doc-load completes (with success in exitTest()), sometimes
we have an error during shutdown.

The reason seems to be that ClientSession::onDisconnect() calls
DocumentBroker::removeSession(), which may delete the ClientSession, so
by time time isCloseFrame() is called, we have trouble.

Fix the problem by keeping a reference to self before calling
removeSession().

Change-Id: If5b409822563ba5a45d453329516671065d8f054
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90681
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Miklos Vajna 

diff --git a/wsd/ClientSession.cpp b/wsd/ClientSession.cpp
index 29e420dad..f336eeec0 100644
--- a/wsd/ClientSession.cpp
+++ b/wsd/ClientSession.cpp
@@ -1638,6 +1638,9 @@ void ClientSession::onDisconnect()
 docBroker->assertCorrectThread();
 const std::string docKey = docBroker->getDocKey();
 
+// Keep self alive, so that our own dtor runs only at the end of this 
function. Without this,
+// removeSession() may destroy us and then we can't call our own member 
functions anymore.
+std::shared_ptr session = client_from_this();
 try
 {
 // Connection terminated. Destroy session.
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: cypress_test/integration_tests loleaflet/images loleaflet/src

[Pedro Pinto Silva (via logerrit)]

 cypress_test/integration_tests/mobile/writer/insert_formatting_mark_spec.js |  
 12 +-
 loleaflet/images/lc_inserthardhyphen.svg|  
  5 
 loleaflet/images/lc_insertlrm.svg   |  
  5 
 loleaflet/images/lc_insertrlm.svg   |  
  5 
 loleaflet/images/lc_insertsofthyphen.svg|  
  5 
 loleaflet/images/lc_insertzwnbsp.svg|  
  5 
 loleaflet/images/lc_insertzwsp.svg  |  
  7 +
 loleaflet/src/core/LOUtil.js|  
  6 -
 8 files changed, 38 insertions(+), 12 deletions(-)

New commits:
commit a28a759212d6b0274e33023e863fd99339595e31
Author: Pedro Pinto Silva 
AuthorDate: Tue Mar 17 17:10:31 2020 +0100
Commit: Pedro Pinto da Silva 
CommitDate: Wed Mar 18 15:35:48 2020 +0100

Mobile: Writer: Insert: Add missing icons to Formatting marks submenu

Change-Id: Ieadca0bdb5668d0bdc8ee9356879b652b540ab3c
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90659
Tested-by: Jenkins CollaboraOffice 
Tested-by: Pedro Pinto da Silva 
Reviewed-by: Pedro Pinto da Silva 

diff --git 
a/cypress_test/integration_tests/mobile/writer/insert_formatting_mark_spec.js 
b/cypress_test/integration_tests/mobile/writer/insert_formatting_mark_spec.js
index 1133eb2cd..4d8fcc9ee 100644
--- 
a/cypress_test/integration_tests/mobile/writer/insert_formatting_mark_spec.js
+++ 
b/cypress_test/integration_tests/mobile/writer/insert_formatting_mark_spec.js
@@ -46,7 +46,7 @@ describe('Insert formatting mark via insertion wizard.', 
function() {
});
 
it('Insert non-breaking hyphen.', function() {
-   cy.get('.menu-entry-no-icon')
+   cy.get('.menu-entry-with-icon')
.contains('Non-breaking hyphen')
.click();
 
@@ -60,7 +60,7 @@ describe('Insert formatting mark via insertion wizard.', 
function() {
});
 
it('Insert soft hyphen.', function() {
-   cy.get('.menu-entry-no-icon')
+   cy.get('.menu-entry-with-icon')
.contains('Soft hyphen')
.click();
 
@@ -74,7 +74,7 @@ describe('Insert formatting mark via insertion wizard.', 
function() {
});
 
it('Insert no-width optional break.', function() {
-   cy.get('.menu-entry-no-icon')
+   cy.get('.menu-entry-with-icon')
.contains('No-width optional break')
.click();
 
@@ -88,7 +88,7 @@ describe('Insert formatting mark via insertion wizard.', 
function() {
});
 
it('Insert no-width no break.', function() {
-   cy.get('.menu-entry-no-icon')
+   cy.get('.menu-entry-with-icon')
.contains('No-width no break')
.click();
 
@@ -102,7 +102,7 @@ describe('Insert formatting mark via insertion wizard.', 
function() {
});
 
it('Insert left-to-right mark.', function() {
-   cy.get('.menu-entry-no-icon')
+   cy.get('.menu-entry-with-icon')
.contains('Left-to-right mark')
.click();
 
@@ -116,7 +116,7 @@ describe('Insert formatting mark via insertion wizard.', 
function() {
});
 
it('Insert right-to-left mark.', function() {
-   cy.get('.menu-entry-no-icon')
+   cy.get('.menu-entry-with-icon')
.contains('Right-to-left mark')
.click();
 
diff --git a/loleaflet/images/lc_inserthardhyphen.svg 
b/loleaflet/images/lc_inserthardhyphen.svg
new file mode 100644
index 0..76ccba0f6
--- /dev/null
+++ b/loleaflet/images/lc_inserthardhyphen.svg
@@ -0,0 +1,5 @@
+http://www.w3.org/2000/svg;>
+ 
+ 
+ 
+
diff --git a/loleaflet/images/lc_insertlrm.svg 
b/loleaflet/images/lc_insertlrm.svg
new file mode 100644
index 0..65d8188f3
--- /dev/null
+++ b/loleaflet/images/lc_insertlrm.svg
@@ -0,0 +1,5 @@
+http://www.w3.org/2000/svg;>
+ 
+  
+ 
+
diff --git a/loleaflet/images/lc_insertrlm.svg 
b/loleaflet/images/lc_insertrlm.svg
new file mode 100644
index 0..b6428f09e
--- /dev/null
+++ b/loleaflet/images/lc_insertrlm.svg
@@ -0,0 +1,5 @@
+http://www.w3.org/2000/svg;>
+ 
+  
+ 
+
diff --git a/loleaflet/images/lc_insertsofthyphen.svg 
b/loleaflet/images/lc_insertsofthyphen.svg
new file mode 100644
index 0..198b96da3
--- /dev/null
+++ b/loleaflet/images/lc_insertsofthyphen.svg
@@ -0,0 +1,5 @@
+http://www.w3.org/2000/svg;>
+ 
+ 
+ 
+
diff --git a/loleaflet/images/lc_insertzwnbsp.svg 
b/loleaflet/images/lc_insertzwnbsp.svg
new file mode 100644
index 0..a0879e27f
--- /dev/null
+++ b/loleaflet/images/lc_insertzwnbsp.svg
@@ -0,0 +1,5 @@
+http://www.w3.org/2000/svg;>
+ 

[Libreoffice-commits] core.git: config_host/config_skia.h.in

[Luboš Luňák (via logerrit)]

 config_host/config_skia.h.in |2 --
 1 file changed, 2 deletions(-)

New commits:
commit 2b00d3deb2d637916c142ef03a5e31ac5189f314
Author: Luboš Luňák 
AuthorDate: Tue Mar 17 16:09:08 2020 +0100
Commit: Luboš Luňák 
CommitDate: Wed Mar 18 14:54:46 2020 +0100

do not use Skia's gamma correction for text

Using SK_GAMMA_APPLY_TO_A8 seems to be Skia's build default, but
it makes fonts harder to see (gray instead of black). With this change,
Skia now looks to be pixel-perfect when compared with the gen VCL
backend.

Change-Id: I4ae7a15f97c5ecb181b8c35b417496f8c631ace4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90695
Tested-by: Jenkins
Reviewed-by: Luboš Luňák 

diff --git a/config_host/config_skia.h.in b/config_host/config_skia.h.in
index 328c43f56bf1..0c843c128756 100644
--- a/config_host/config_skia.h.in
+++ b/config_host/config_skia.h.in
@@ -36,8 +36,6 @@ are the same.
 #define SK_CODEC_DECODES_PNG 1
 #define SK_ENCODE_PNG 1
 
-#define SK_GAMMA_APPLY_TO_A8
-
 #define SK_ASSUME_GL 1
 
 #define SK_ASSUME_GL_ES 0
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: external/skia

[Luboš Luňák (via logerrit)]

 external/skia/UnpackedTarball_skia.mk|1 +
 external/skia/windows-text-gamma.patch.0 |   28 
 2 files changed, 29 insertions(+)

New commits:
commit 1ad3f6b8d9e0ef1e921c3ed5526ea352d67265cf
Author: Luboš Luňák 
AuthorDate: Wed Mar 18 12:10:29 2020 +0100
Commit: Luboš Luňák 
CommitDate: Wed Mar 18 14:55:03 2020 +0100

(do not) use SK_GAMMA_APPLY_TO_A8 also for Skia text on Windows

This is the Windows variant of the SK_GAMMA_APPLY_TO_A8 disabling,
again I don't quite understand why we need to disable this,
but with this patch Skia text rendering on Windows seems to be
pixel-perfect when compared with the VCL gen backend.

Change-Id: Iafc1e6353430e695dafa67d19eefd968d4f02ae2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90696
Tested-by: Jenkins
Reviewed-by: Luboš Luňák 

diff --git a/external/skia/UnpackedTarball_skia.mk 
b/external/skia/UnpackedTarball_skia.mk
index 58818a840e3d..fd05e8d5b3e3 100644
--- a/external/skia/UnpackedTarball_skia.mk
+++ b/external/skia/UnpackedTarball_skia.mk
@@ -30,6 +30,7 @@ skia_patches := \
 clang-attributes-warning.patch.1 \
 fontconfig-get-typeface.patch.0 \
 windows-hfont-typeface.patch.0 \
+windows-text-gamma.patch.0 \
 
 $(eval $(call gb_UnpackedTarball_set_patchlevel,skia,1))
 
diff --git a/external/skia/windows-text-gamma.patch.0 
b/external/skia/windows-text-gamma.patch.0
new file mode 100644
index ..366b67f15a65
--- /dev/null
+++ b/external/skia/windows-text-gamma.patch.0
@@ -0,0 +1,28 @@
+--- ./src/ports/SkFontHost_win.cpp.sav 2020-03-18 10:26:52.470184300 +0100
 ./src/ports/SkFontHost_win.cpp 2020-03-18 12:08:04.598406700 +0100
+@@ -1215,17 +1215,23 @@
+ // since the caller may require A8 for maskfilters, we can't check 
for BW
+ // ... until we have the caller tell us that explicitly
+ const SkGdiRGB* src = (const SkGdiRGB*)bits;
++#if defined(SK_GAMMA_APPLY_TO_A8)
+ if (fPreBlend.isApplicable()) {
+ RGBToA8(src, srcRB, glyph, fPreBlend.fG);
+-} else {
++} else
++#endif
++{
+ RGBToA8(src, srcRB, glyph, fPreBlend.fG);
+ }
+ } else {// LCD16
+ const SkGdiRGB* src = (const SkGdiRGB*)bits;
+ SkASSERT(SkMask::kLCD16_Format == glyph.fMaskFormat);
++#if defined(SK_GAMMA_APPLY_TO_A8)
+ if (fPreBlend.isApplicable()) {
+ RGBToLcd16(src, srcRB, glyph, fPreBlend.fR, fPreBlend.fG, 
fPreBlend.fB);
+-} else {
++} else
++#endif
++{
+ RGBToLcd16(src, srcRB, glyph, fPreBlend.fR, fPreBlend.fG, 
fPreBlend.fB);
+ }
+ }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: include/tools

[Stephan Bergmann (via logerrit)]

 include/tools/weakbase.h |3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

New commits:
commit 498a39e5184018dd849b35d1ae4cc1c3f4115855
Author: Stephan Bergmann 
AuthorDate: Wed Mar 18 12:37:03 2020 +0100
Commit: Noel Grandin 
CommitDate: Wed Mar 18 14:08:49 2020 +0100

tools::WeakBase still needs to be TOOLS_DLLPUBLIC under --enable-mergelibs

...plus --enable-assert-always-abort:  ShapeManagerImpl::checkForImageMap in
slideshow/source/engine/slide/shapemanagerimpl.cxx in Library_slideshow 
calls
SvxShape::GetSdrObject, which calls tools::WeakBase::get
(include/tools/weakbase.hxx), which contains

> assert(dynamic_cast(pWeakBase));

requiring RTTI for tools::WeakBase.  See e.g.
.

Change-Id: I9598c14bf74eb5a28332d0beecfbe8201b39451e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90697
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/include/tools/weakbase.h b/include/tools/weakbase.h
index 648e1b77e960..458381e47fff 100644
--- a/include/tools/weakbase.h
+++ b/include/tools/weakbase.h
@@ -22,7 +22,6 @@
 #include 
 #include 
 #include 
-#include 
 
 /** the template classes in this header are helper to implement weak references
 to implementation objects that are not refcounted.
@@ -124,7 +123,7 @@ private:
 };
 
 /** derive your implementation classes from this class if you want them to 
support weak references */
-class UNLESS_MERGELIBS(TOOLS_DLLPUBLIC) WeakBase
+class TOOLS_DLLPUBLIC WeakBase
 {
 template friend class WeakReference;
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: 2 commits - vcl/inc vcl/skia

[Luboš Luňák (via logerrit)]

 vcl/inc/skia/salbmp.hxx |   26 ++--
 vcl/skia/gdiimpl.cxx|1 
 vcl/skia/salbmp.cxx |  259 
 3 files changed, 125 insertions(+), 161 deletions(-)

New commits:
commit 4020c402526c472b71729085eeed094449fe00ed
Author: Luboš Luňák 
AuthorDate: Wed Mar 18 11:38:42 2020 +0100
Commit: Luboš Luňák 
CommitDate: Wed Mar 18 14:54:26 2020 +0100

make SkiaSalBitmap always use internal buffer for pixels

The latest chrome/m82 branch of Skia now always does a deep copy
when creating SkImage from SkBitmap unless the source is immutable,
which means a copy would be done or way or another. This makes
the handling consistent, the SkBitmap is now used only for caching.

Change-Id: I8031ab7f639baee6ad9c9708b35afea384a19f65
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90689
Tested-by: Jenkins
Reviewed-by: Luboš Luňák 

diff --git a/vcl/inc/skia/salbmp.hxx b/vcl/inc/skia/salbmp.hxx
index 4550680400d7..762e45c420b8 100644
--- a/vcl/inc/skia/salbmp.hxx
+++ b/vcl/inc/skia/salbmp.hxx
@@ -70,16 +70,16 @@ public:
 #endif
 
 private:
-// Reset the cached images allocated in GetSkImage()/GetAlphaSkImage().
-void ResetSkImages();
-// Call to ensure mBitmap or mBuffer have data (will convert from mImage
-// if necessary).
+// Reset the cached images allocated in GetSkImage()/GetAlphaSkImage(),
+// and also the SkBitmap allocated in GetAsSkBitmap().
+void ResetCachedData();
+// Call to ensure mBuffer has data (will convert from mImage if necessary).
 void EnsureBitmapData();
 void EnsureBitmapData() const { return 
const_cast(this)->EnsureBitmapData(); }
 // Like EnsureBitmapData(), but will also make any shared data unique.
 // Call before changing the data.
 void EnsureBitmapUniqueData();
-// Allocate mBitmap or mBuffer (with uninitialized contents).
+// Allocate mBuffer (with uninitialized contents).
 bool CreateBitmapData();
 SkBitmap GetAsSkBitmap() const;
 #ifdef DBG_UTIL
@@ -92,11 +92,10 @@ private:
 friend inline std::basic_ostream&
 operator<<(std::basic_ostream& stream, const SkiaSalBitmap* 
bitmap)
 {
-// B - has SkBitmap, D - has data buffer, I/i - has SkImage (on 
GPU/CPU),
+// B - has SkBitmap, I/i - has SkImage (on GPU/CPU),
 // A/a - has alpha SkImage (on GPU/CPU)
 return stream << static_cast(bitmap) << " " << 
bitmap->GetSize() << "/"
   << bitmap->mBitCount << (!bitmap->mBitmap.isNull() ? "B" 
: "")
-  << (bitmap->mBuffer.get() ? "D" : "")
   << (bitmap->mImage ? (bitmap->mImage->isTextureBacked() 
? "I" : "i") : "")
   << (bitmap->mAlphaImage ? 
(bitmap->mAlphaImage->isTextureBacked() ? "A" : "a")
   : "");
@@ -106,18 +105,17 @@ private:
 int mBitCount = 0; // bpp
 Size mSize;
 // The contents of the bitmap may be stored in several different ways:
-// As SkBitmap, if format is supported by Skia.
-// As mBuffer buffer, if format is not supported by Skia.
+// As mBuffer buffer, which normally stores pixels in the given format.
 // As SkImage, as cached GPU-backed data, but sometimes also a result of 
some operation.
-// There is no "master" storage that the others would be derived from. The 
usual
-// mode of operation is that mBitmap or mBuffer hold the data, mImage is 
created
+// There is no "master" storage that the other would be derived from. The 
usual
+// mode of operation is that mBuffer holds the data, mImage is created
 // on demand as GPU-backed cached data by calling GetSkImage(), and the 
cached mImage
 // is reset by ResetCachedImage(). But sometimes only mImage will be set 
and in that case
-// mBitmap/mBuffer must be filled from it on demand if necessary by 
EnsureBitmapData().
-SkBitmap mBitmap;
-sk_sp mImage; // possibly GPU-backed
+// mBuffer must be filled from it on demand if necessary by 
EnsureBitmapData().
 boost::shared_ptr mBuffer;
 int mScanlineSize; // size of one row in mBuffer
+SkBitmap mBitmap; // cached mBuffer, if needed
+sk_sp mImage; // possibly GPU-backed
 sk_sp mAlphaImage; // cached contents as alpha image, possibly 
GPU-backed
 #ifdef DBG_UTIL
 int mWriteAccessCount = 0; // number of write AcquireAccess() that have 
not been released
diff --git a/vcl/skia/salbmp.cxx b/vcl/skia/salbmp.cxx
index 6522709a5ecd..bb173b564e5c 100644
--- a/vcl/skia/salbmp.cxx
+++ b/vcl/skia/salbmp.cxx
@@ -53,8 +53,7 @@ static bool isValidBitCount(sal_uInt16 nBitCount)
 
 SkiaSalBitmap::SkiaSalBitmap(const sk_sp& image)
 {
-ResetSkImages();
-mBitmap.reset();
+ResetCachedData();
 mBuffer.reset();
 mImage = image;
 mPalette = BitmapPalette();
@@ -68,8 +67,7 @@ SkiaSalBitmap::SkiaSalBitmap(const sk_sp& image)
 
 bool SkiaSalBitmap::Create(const 

[Libreoffice-commits] core.git: offapi/com

[Tomaž Vajngerl (via logerrit)]

 offapi/com/sun/star/graphic/XPdfDecomposer.idl |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 345116a074863e46bfb6452cfa2e9362d510f60b
Author: Tomaž Vajngerl 
AuthorDate: Wed Mar 18 14:14:13 2020 +0100
Commit: Tomaž Vajngerl 
CommitDate: Wed Mar 18 14:20:30 2020 +0100

XPdfDecomposer - fix the described property name

The propery name should be "PageIndex" and not "Page"

Change-Id: Ic8d012abcfcb3381bb287bc43ca1d776c2c4ac95

diff --git a/offapi/com/sun/star/graphic/XPdfDecomposer.idl 
b/offapi/com/sun/star/graphic/XPdfDecomposer.idl
index e0f9c8d96872..25bf8870c1ee 100644
--- a/offapi/com/sun/star/graphic/XPdfDecomposer.idl
+++ b/offapi/com/sun/star/graphic/XPdfDecomposer.idl
@@ -32,7 +32,7 @@ interface XPdfDecomposer : ::com::sun::star::uno::XInterface
 @param xDecompositionParameters
 Parameters for decomposition. Parameters include:
 
-sal_Int32 Page - which page to use
+sal_Int32 PageIndex - which page to use
  */
 sequence getDecomposition([in] sequence xPdfData,
 [in] 
sequence xDecompositionParameters);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: comphelper/source

[Stephan Bergmann (via logerrit)]

 comphelper/source/misc/debuggerinfo.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit c61ac5d16e2fe1681375a6c37f32d16b7fd2a4ef
Author: Stephan Bergmann 
AuthorDate: Wed Mar 18 13:49:57 2020 +0100
Commit: Stephan Bergmann 
CommitDate: Wed Mar 18 14:37:18 2020 +0100

comphelper::isDebuggerAttached must be defined irrespective of NDEBUG

ac9083f64fc064e4bad3dc522a90ca214b3f1c2f "make isDebuggerAttached() public
comphelper API" had forgotten to drop the NDEBUG condition, causing
--enable-dbgutil --disable-assert-always-abort builds like
 to fail 
with

> /usr/lib64/gcc/x86_64-suse-linux/9/../../../../x86_64-suse-linux/bin/ld: 
/lo/home/tdf/lode/jenkins/workspace/lo_tb_random_config_linux/workdir/CxxObject/vcl/source/app/watchdog.o:
 in function `WatchdogThread::start()':
> 
/lo/home/tdf/lode/jenkins/workspace/lo_tb_random_config_linux/vcl/source/app/watchdog.cxx:138:
 undefined reference to `comphelper::isDebuggerAttached()'
> collect2: error: ld returned 1 exit status
> 
/lo/home/tdf/lode/jenkins/workspace/lo_tb_random_config_linux/vcl/Library_vcl.mk:20:
 recipe for target 
'/lo/home/tdf/lode/jenkins/workspace/lo_tb_random_config_linux/instdir/program/libvcllo.so'
 failed

Change-Id: Ia391881f0b6a79709fbebfd204097840a9890147
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90698
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/comphelper/source/misc/debuggerinfo.cxx 
b/comphelper/source/misc/debuggerinfo.cxx
index 9d452f174ab5..07b2f0132fff 100644
--- a/comphelper/source/misc/debuggerinfo.cxx
+++ b/comphelper/source/misc/debuggerinfo.cxx
@@ -23,7 +23,7 @@
 
 namespace comphelper
 {
-#if defined DBG_UTIL && !defined NDEBUG
+#if defined DBG_UTIL
 bool isDebuggerAttached()
 {
 #if defined(_WIN32)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: xmloff/source

[Stephan Bergmann (via logerrit)]

 xmloff/source/core/xmltoken.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit d77ab56c8befc15816c7f70644dd72f4058642d1
Author: Stephan Bergmann 
AuthorDate: Wed Mar 18 14:10:33 2020 +0100
Commit: Stephan Bergmann 
CommitDate: Wed Mar 18 14:51:17 2020 +0100

Avoid -Werror=unused-but-set-variable

...in --enable-debug --enable-werror --disable-assert-always-abort builds 
like
:

> 
/lo/home/tdf/lode/jenkins/workspace/lo_tb_random_config_linux/xmloff/source/core/xmltoken.cxx:3368:18:
 error: variable ‘foundDuplicate’ set but not used 
[-Werror=unused-but-set-variable]
>  3368 | bool foundDuplicate = false;
>   |  ^~

Change-Id: If9d433082de84c433132276e171ba5c42c24b61c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90699
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/xmloff/source/core/xmltoken.cxx b/xmloff/source/core/xmltoken.cxx
index 48fc80a37b0b..92abc4cef73e 100644
--- a/xmloff/source/core/xmltoken.cxx
+++ b/xmloff/source/core/xmltoken.cxx
@@ -3357,7 +3357,7 @@ namespace xmloff::token {
 // get OUString representation of token
 const OUString& GetXMLToken( enum XMLTokenEnum eToken )
 {
-#if OSL_DEBUG_LEVEL > 0
+#if OSL_DEBUG_LEVEL > 0 && !defined NDEBUG
 static bool s_bChecked = false;
 if (!s_bChecked)
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loleaflet/css

[Tor Lillqvist (via logerrit)]

 loleaflet/css/loleaflet.css |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 40777e238494b87f6f5e0f13b42206307f5a35f0
Author: Tor Lillqvist 
AuthorDate: Wed Mar 18 16:58:14 2020 +0200
Commit: Tor Lillqvist 
CommitDate: Wed Mar 18 16:22:42 2020 +0100

Add comment to remind what "any-hover: none" means

Change-Id: I78bcdaba5b29923f552b44548524b023ecb77b9f
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90706
Tested-by: Tor Lillqvist 
Reviewed-by: Tor Lillqvist 

diff --git a/loleaflet/css/loleaflet.css b/loleaflet/css/loleaflet.css
index e43ddbaf9..a0cf27e43 100644
--- a/loleaflet/css/loleaflet.css
+++ b/loleaflet/css/loleaflet.css
@@ -215,6 +215,7 @@ body {
display: none;
}
 }
+/* any-hover: none is a "clever" trick to detect touch-only devices */
 @media (any-hover: none) {
.w2ui-tag .w2ui-tag-top{display:none !important;}
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.2' - chart2/uiconfig

[Muhammet Kara (via logerrit)]

 chart2/uiconfig/ui/sidebarelements.ui |   41 +-
 1 file changed, 21 insertions(+), 20 deletions(-)

New commits:
commit d23e6ecb497eb10156e2f77906c9364de6cfb4ed
Author: Muhammet Kara 
AuthorDate: Wed Mar 18 18:27:55 2020 +0300
Commit: Muhammet Kara 
CommitDate: Wed Mar 18 17:25:17 2020 +0100

Give the legend checkbox a label

So that we don't see a nameless checkbox on Online mobile

Change-Id: I95e8910e96335a03ebad6dd46255a902df2c47a4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90707
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Muhammet Kara 

diff --git a/chart2/uiconfig/ui/sidebarelements.ui 
b/chart2/uiconfig/ui/sidebarelements.ui
index c4ec4cd49e2d..9db51b35a5d7 100644
--- a/chart2/uiconfig/ui/sidebarelements.ui
+++ b/chart2/uiconfig/ui/sidebarelements.ui
@@ -1,5 +1,5 @@
 
-
+
 
   
   
@@ -9,9 +9,9 @@
   
 True
 False
+6
 vertical
 6
-6
 
   
 True
@@ -97,22 +97,6 @@
   
 True
 False
-
-  
-Show Legend
-True
-True
-False
-True
-0
-True
-5
-  
-  
-0
-0
-  
-
 
   
 True
@@ -123,6 +107,7 @@
 True
 False
 end
+4
 _Placement:
 True
 end
@@ -149,12 +134,28 @@
   
 False
 True
-3
+1
   
 
   
   
-1
+0
+1
+  
+
+
+  
+Show legend
+True
+True
+False
+Show Legend
+True
+0
+True
+  
+  
+0
 0
   
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

GSOC 2020 | LibreOffice Online

[Yashwant]

Hello,I am YASHWANT from TIET, Patiala, India. I want to contribute to LibreOffice for GSOC 2020.Idea : LibreOffice Online Please guide me through the next steps I should follow to contribute and to write a proposal.  Sent from Mail for Windows 10 
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] online.git: android/lib

[Jan Holesovsky (via logerrit)]

 android/lib/src/main/java/org/libreoffice/androidlib/lok/LokClipboardData.java 
|   28 ++
 1 file changed, 19 insertions(+), 9 deletions(-)

New commits:
commit 1b4e40198ccab88bf09a05bb130b8f646faa8077
Author: Jan Holesovsky 
AuthorDate: Wed Mar 18 12:08:41 2020 +0100
Commit: Jan Holesovsky 
CommitDate: Wed Mar 18 18:29:31 2020 +0100

android: Tabs to spaces.

Change-Id: I5ab52ef34126f2c3e90ff9199d2e42dd24bc6ebe
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90693
Tested-by: Jan Holesovsky 
Reviewed-by: Jan Holesovsky 

diff --git 
a/android/lib/src/main/java/org/libreoffice/androidlib/lok/LokClipboardData.java
 
b/android/lib/src/main/java/org/libreoffice/androidlib/lok/LokClipboardData.java
index 85fc62710..4ae654f6d 100644
--- 
a/android/lib/src/main/java/org/libreoffice/androidlib/lok/LokClipboardData.java
+++ 
b/android/lib/src/main/java/org/libreoffice/androidlib/lok/LokClipboardData.java
@@ -1,3 +1,12 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; 
fill-column: 100 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
 package org.libreoffice.androidlib.lok;
 
 import android.util.Base64;
@@ -42,10 +51,10 @@ public class LokClipboardData implements Serializable {
 public boolean writeToFile(File file) {
 try {
 FileOutputStream fileStream = new 
FileOutputStream(file.getAbsoluteFile());
-   ObjectOutputStream oos = new ObjectOutputStream(fileStream);
-   oos.writeObject(this);
-   oos.close();
-   fileStream.close();
+ObjectOutputStream oos = new ObjectOutputStream(fileStream);
+oos.writeObject(this);
+oos.close();
+fileStream.close();
 } catch (IOException e) {
 e.printStackTrace();
 return false;
@@ -56,11 +65,11 @@ public class LokClipboardData implements Serializable {
 public static LokClipboardData createFromFile(File file) {
 try {
 FileInputStream fileStream = new 
FileInputStream(file.getAbsoluteFile());
-   ObjectInputStream ois = new ObjectInputStream(fileStream);
-   LokClipboardData data = (LokClipboardData)ois.readObject();
-   ois.close();
-   fileStream.close();
-   return data;
+ObjectInputStream ois = new ObjectInputStream(fileStream);
+LokClipboardData data = (LokClipboardData)ois.readObject();
+ois.close();
+fileStream.close();
+return data;
 } catch (IOException e) {
 e.printStackTrace();
 return null;
@@ -78,3 +87,4 @@ public class LokClipboardData implements Serializable {
 }
 }
 
+/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s 
cinkeys+=0=break: */
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: android/lib

[Jan Holesovsky (via logerrit)]

 android/lib/src/main/res/layout/lolib_dialog_loading.xml |   35 ---
 1 file changed, 20 insertions(+), 15 deletions(-)

New commits:
commit bd3d5faef834c6bd3e5b15c2596bd39c6294d326
Author: Jan Holesovsky 
AuthorDate: Wed Mar 18 11:51:11 2020 +0100
Commit: Jan Holesovsky 
CommitDate: Wed Mar 18 18:29:13 2020 +0100

android: Always use the horizontal progress bar.

It is hard have a determinate circular progress bar, so let's use
horizontal progress bar for both determinate & indeterminate.

They both look a bit different (the indeterminate is vertically
narrower), but there was no simple trick to make them look the same, so
I gave up for the moment.

Change-Id: Ife3690204a8abd8bf17afe5c7d749a3ac2730c20
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90691
Tested-by: Jan Holesovsky 
Reviewed-by: Jan Holesovsky 

diff --git a/android/lib/src/main/res/layout/lolib_dialog_loading.xml 
b/android/lib/src/main/res/layout/lolib_dialog_loading.xml
index b0fef6554..6b07467f5 100644
--- a/android/lib/src/main/res/layout/lolib_dialog_loading.xml
+++ b/android/lib/src/main/res/layout/lolib_dialog_loading.xml
@@ -2,33 +2,38 @@
 http://schemas.android.com/apk/res/android;
 android:layout_width="match_parent"
 android:layout_height="wrap_content"
-android:orientation="horizontal"
-android:padding="20dp">
+android:orientation="vertical"
+android:padding="24dp">
+
+
 
 
 
 
+style="?android:attr/progressBarStyleHorizontal"
+android:layout_width="match_parent"
+android:layout_height="wrap_content"
+android:indeterminateOnly="true"
+android:visibility="invisible"/>
 
 
+android:min="0"
+android:visibility="visible" />
 
 
-
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loleaflet/css loleaflet/images

[Pedro Pinto Silva (via logerrit)]

 loleaflet/css/mobilewizard.css  |   14 ++
 loleaflet/images/lc_deletetable.svg |   13 -
 loleaflet/images/lc_insertcolumnsafter.svg  |9 -
 loleaflet/images/lc_insertcolumnsbefore.svg |9 -
 loleaflet/images/lc_insertrowsafter.svg |9 -
 5 files changed, 38 insertions(+), 16 deletions(-)

New commits:
commit 8f551b3253c8ff8361a872565c45bb63a7e5de0d
Author: Pedro Pinto Silva 
AuthorDate: Tue Mar 17 14:58:14 2020 +0100
Commit: Pedro Pinto da Silva 
CommitDate: Wed Mar 18 16:46:04 2020 +0100

Mobilewizard: Table properties: fix layout and icons; replace delete table 
icon; remove labels

Change-Id: I7652a5382b4a828ae21e8ce1cf6da21b7ce78b91
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90652
Tested-by: Pedro Pinto da Silva 
Reviewed-by: Pedro Pinto da Silva 

diff --git a/loleaflet/css/mobilewizard.css b/loleaflet/css/mobilewizard.css
index 899bc1959..99695142b 100644
--- a/loleaflet/css/mobilewizard.css
+++ b/loleaflet/css/mobilewizard.css
@@ -614,20 +614,10 @@
float:left;
}
#MergeCells > span{
-   color: #4d82b8;
-   text-align: end;
-   vertical-align: bottom;
-   }
-   #DeleteTable{
-   background-color: #fbf4f5;
-   border-radius: 6px;
-   padding-right: 4% !important;
+   display: none;
}
#DeleteTable > span{
-   font-weight: bold;
-   color: #e68497;
-   text-align: end;
-   vertical-align: bottom;
+   display: none;
}
.colorcontainer {
width: 120px;
diff --git a/loleaflet/images/lc_deletetable.svg 
b/loleaflet/images/lc_deletetable.svg
index 90d4e47b4..3adefd83c 100644
--- a/loleaflet/images/lc_deletetable.svg
+++ b/loleaflet/images/lc_deletetable.svg
@@ -1 +1,12 @@
-http://www.w3.org/2000/svg;>
\ No newline at end of file
+http://www.w3.org/2000/svg;>
+ 
+ 
+ 
+  
+ 
+ 
+  
+  
+  
+ 
+
diff --git a/loleaflet/images/lc_insertcolumnsafter.svg 
b/loleaflet/images/lc_insertcolumnsafter.svg
index 8e3a8059b..5a53a8903 100644
--- a/loleaflet/images/lc_insertcolumnsafter.svg
+++ b/loleaflet/images/lc_insertcolumnsafter.svg
@@ -1 +1,8 @@
-http://www.w3.org/2000/svg;>
\ No newline at end of file
+http://www.w3.org/2000/svg;>
+ 
+ 
+ 
+  
+  
+ 
+
diff --git a/loleaflet/images/lc_insertcolumnsbefore.svg 
b/loleaflet/images/lc_insertcolumnsbefore.svg
index 38a4af1d6..dcc7b9109 100644
--- a/loleaflet/images/lc_insertcolumnsbefore.svg
+++ b/loleaflet/images/lc_insertcolumnsbefore.svg
@@ -1 +1,8 @@
-http://www.w3.org/2000/svg;>
\ No newline at end of file
+http://www.w3.org/2000/svg;>
+ 
+ 
+ 
+  
+  
+ 
+
diff --git a/loleaflet/images/lc_insertrowsafter.svg 
b/loleaflet/images/lc_insertrowsafter.svg
index 9278fe221..fe1a2cf2a 100644
--- a/loleaflet/images/lc_insertrowsafter.svg
+++ b/loleaflet/images/lc_insertrowsafter.svg
@@ -1 +1,8 @@
-http://www.w3.org/2000/svg;>
\ No newline at end of file
+http://www.w3.org/2000/svg;>
+ 
+ 
+ 
+  
+  
+ 
+
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loleaflet/src

[Andras Timar (via logerrit)]

 loleaflet/src/control/Control.ContextMenu.js |2 +-
 loleaflet/src/unocommands.js |2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit c959dc2bd2fdb4705948c67d0a575dcd862bffd8
Author: Andras Timar 
AuthorDate: Wed Mar 18 16:54:36 2020 +0100
Commit: Andras Timar 
CommitDate: Wed Mar 18 16:56:29 2020 +0100

context menu contains WrapThroughTransparencyToggle, not 
WrapThroughTransparent

With this change we can have "In Background" option in Wrap context menu,
that puts the image behind the text.

Change-Id: Ibd652bb593dd5a737bed3b4447be5b4bee7d4b70

diff --git a/loleaflet/src/control/Control.ContextMenu.js 
b/loleaflet/src/control/Control.ContextMenu.js
index dfa408382..3a81d430c 100644
--- a/loleaflet/src/control/Control.ContextMenu.js
+++ b/loleaflet/src/control/Control.ContextMenu.js
@@ -26,7 +26,7 @@ L.Control.ContextMenu = L.Control.extend({
  'AnchorMenu', 'SetAnchorToPage', 
'SetAnchorToPara', 'SetAnchorAtChar',
  'SetAnchorToChar', 'SetAnchorToFrame',
  'WrapMenu', 'WrapOff', 'WrapOn', 
'WrapIdeal', 'WrapLeft', 'WrapRight', 'WrapThrough',
- 'WrapThroughTransparent', 
'WrapContour', 'WrapAnchorOnly',
+ 'WrapThroughTransparencyToggle', 
'WrapContour', 'WrapAnchorOnly',
  'ArrangeFrameMenu', 'ArrangeMenu', 
'BringToFront', 'ObjectForwardOne', 'ObjectBackOne', 'SendToBack',
  'RotateMenu', 'RotateLeft', 
'RotateRight', 'TransformDialog', 'FormatLine', 'FormatArea',
  'FormatChartArea', 'InsertTitles', 
'InsertRemoveAxes',
diff --git a/loleaflet/src/unocommands.js b/loleaflet/src/unocommands.js
index c8cf31684..8afdff7a4 100644
--- a/loleaflet/src/unocommands.js
+++ b/loleaflet/src/unocommands.js
@@ -335,7 +335,7 @@ var unoCommandsArray = {
WrapRight:{text:{menu:_('Wrap Right'),},},
WrapText:{spreadsheet:{menu:_('Wrap Text'),},},
WrapThrough:{text:{menu:_('~Wrap Through'),},},
-   WrapThroughTransparent:{text:{menu:_('In ~Background'),},},
+   WrapThroughTransparencyToggle:{text:{menu:_('In ~Background'),},},
ZoomMinus:{global:{menu:_('Zoom Out'),},},
ZoomPlus:{global:{menu:_('Zoom In'),},},
 };
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: android/lib

[Jan Holesovsky (via logerrit)]

 android/lib/src/main/java/org/libreoffice/androidlib/LOActivity.java |4 
++--
 android/lib/src/main/res/values/strings.xml  |2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 9f44d03471954686294ff6f91125c5ec7861c297
Author: Jan Holesovsky 
AuthorDate: Wed Mar 18 10:46:50 2020 +0100
Commit: Jan Holesovsky 
CommitDate: Wed Mar 18 18:28:57 2020 +0100

android: When quitting the app, use a neutral "Exiting" instead of "Saving".

Change-Id: I2fce16b74843a4ea8a3dea4471f6c9fff834f439
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90690
Tested-by: Jan Holesovsky 
Reviewed-by: Jan Holesovsky 

diff --git 
a/android/lib/src/main/java/org/libreoffice/androidlib/LOActivity.java 
b/android/lib/src/main/java/org/libreoffice/androidlib/LOActivity.java
index 54e6363ce..ca60f9b5c 100644
--- a/android/lib/src/main/java/org/libreoffice/androidlib/LOActivity.java
+++ b/android/lib/src/main/java/org/libreoffice/androidlib/LOActivity.java
@@ -421,7 +421,7 @@ public class LOActivity extends AppCompatActivity {
 }
 
 final Intent finalIntent = intent;
-mProgressDialog.indeterminate(R.string.saving);
+mProgressDialog.indeterminate(R.string.exiting);
 getMainHandler().post(new Runnable() {
 @Override
 public void run() {
@@ -676,7 +676,7 @@ public class LOActivity extends AppCompatActivity {
 
 /** Show the Saving progress and finish the app. */
 private void finishWithProgress() {
-mProgressDialog.indeterminate(R.string.saving);
+mProgressDialog.indeterminate(R.string.exiting);
 
 // The 'BYE' takes a considerable amount of time, we need to post it
 // so that it starts after the saving progress is actually shown
diff --git a/android/lib/src/main/res/values/strings.xml 
b/android/lib/src/main/res/values/strings.xml
index 176a41790..dff5fb931 100644
--- a/android/lib/src/main/res/values/strings.xml
+++ b/android/lib/src/main/res/values/strings.xml
@@ -4,7 +4,6 @@
 Failed to determine the file to 
load
 Failed to insert image
 Cannot open file chooser
-Saving...
 Preparing for 
the first start after an update.
 Rate now
 Later
@@ -13,4 +12,5 @@
 
 
 Loading...
+Exiting...
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: android/app android/lib loleaflet/po

[Weblate (via logerrit)]

 android/app/src/main/res/values-an/strings.xml |2 +
 android/app/src/main/res/values-ast/strings.xml|1 
 android/app/src/main/res/values-ca/strings.xml |1 
 android/app/src/main/res/values-cs/strings.xml |1 
 android/app/src/main/res/values-cy/strings.xml |1 
 android/app/src/main/res/values-dsb/strings.xml|1 
 android/app/src/main/res/values-en-rGB/strings.xml |1 
 android/app/src/main/res/values-es/strings.xml |1 
 android/app/src/main/res/values-eu/strings.xml |1 
 android/app/src/main/res/values-hsb/strings.xml|1 
 android/app/src/main/res/values-pl/strings.xml |1 
 android/app/src/main/res/values-pt-rBR/strings.xml |1 
 android/lib/src/main/res/values-ast/strings.xml|1 
 android/lib/src/main/res/values-ca/strings.xml |4 +++
 android/lib/src/main/res/values-cs/strings.xml |2 +
 android/lib/src/main/res/values-es/strings.xml |4 +++
 android/lib/src/main/res/values-eu/strings.xml |4 +++
 android/lib/src/main/res/values-pt-rBR/strings.xml |4 +++
 loleaflet/po/help-ca.po|6 ++--
 loleaflet/po/help-cs.po|   18 +
 loleaflet/po/help-en_GB.po |   28 +
 loleaflet/po/help-es.po|4 ---
 loleaflet/po/help-eu.po|   24 +++---
 loleaflet/po/help-hu.po|   12 -
 loleaflet/po/help-pt_BR.po |   26 ---
 loleaflet/po/ui-an.po  |4 +--
 loleaflet/po/ui-ast.po |4 +--
 loleaflet/po/ui-ca.po  |6 ++--
 loleaflet/po/ui-cy.po  |8 ++
 loleaflet/po/ui-dsb.po |4 +--
 loleaflet/po/ui-en_GB.po   |   10 +++
 loleaflet/po/ui-es.po  |6 ++--
 loleaflet/po/ui-eu.po  |4 +--
 loleaflet/po/ui-hsb.po |4 +--
 loleaflet/po/ui-pt_BR.po   |6 ++--
 loleaflet/po/ui-uk.po  |   10 +++
 36 files changed, 92 insertions(+), 124 deletions(-)

New commits:
commit ac2e0f3fe5863499ae2a42ce4457148b045cedcb
Author: Weblate 
AuthorDate: Wed Mar 18 18:29:22 2020 +0100
Commit: Andras Timar 
CommitDate: Wed Mar 18 19:35:25 2020 +0100

update translations

LibreOffice Online/android-lib (Czech)
Currently translated at 83.3% (10 of 12 strings)

Change-Id: Ic60bbaa41dfed7745258c56fcccf59a204451364

update translations

LibreOffice Online/android-lib (Asturian)
Currently translated at 41.7% (5 of 12 strings)

Change-Id: I34f5a37804d9b93e6733603a4fa41d4b45c70482

update translations

LibreOffice Online/android-lib (Catalan)
Currently translated at 100.0% (12 of 12 strings)

Change-Id: I3e4a5ac856b2c22272a2283751512ea461203375

update translations

LibreOffice Online/android-lib (Spanish)
Currently translated at 100.0% (12 of 12 strings)

Change-Id: I8bfcea884723f6f88d920e87f0409a98d8450874

update translations

LibreOffice Online/loleaflet-help (Catalan)
Currently translated at 73.8% (307 of 416 strings)

Change-Id: I560a64c3caf626a3fc65d007fa79229ac49c8806

update translations

LibreOffice Online/android-lib (Basque)
Currently translated at 100.0% (12 of 12 strings)

Change-Id: Ia8ea90608982a42040c661cdea546ddf760c7dc4

update translations

LibreOffice Online/android-lib (Portuguese (Brazil))
Currently translated at 100.0% (12 of 12 strings)

Change-Id: I2408a873216d84d6cb1cf5c28fa40e0f31e99fec

update translations

LibreOffice Online/android-app (Czech)
Currently translated at 100.0% (100 of 100 strings)

Change-Id: Id44155498d92fe1234a25489104b8662a8f198a7

update translations

LibreOffice Online/loleaflet-help (Czech)
Currently translated at 100.0% (416 of 416 strings)

Change-Id: Ia76ffa6e07afc4e8449c3511e8f1a6e1ce546b55

update translations

LibreOffice Online/loleaflet-help (Spanish)
Currently translated at 98.6% (410 of 416 strings)

Change-Id: I7d37d58fe29d379aef5f29d5f527474e52a41bcd

update translations

LibreOffice Online/loleaflet-help (Catalan)
Currently translated at 73.6% (306 of 416 strings)

Change-Id: Ie499b21d573b15460d2e95d23819263fa7d9e2df

update translations

LibreOffice Online/android-app (Welsh)
Currently translated at 100.0% (100 of 100 strings)

Change-Id: Idca78e8ccf93abade03044faddede8c0efeab9fa

update translations

LibreOffice Online/android-app (English 

[Libreoffice-commits] online.git: loleaflet/src

[Tor Lillqvist (via logerrit)]

 loleaflet/src/map/Map.js |8 
 1 file changed, 8 insertions(+)

New commits:
commit 9f0c6cb54b2fab5fedfb874da093774bcb646800
Author: Tor Lillqvist 
AuthorDate: Wed Mar 18 16:55:42 2020 +0200
Commit: Tor Lillqvist 
CommitDate: Wed Mar 18 17:30:07 2020 +0100

Add dummy (for now) style sheet programmatically specifically for mobile 
phones

Ideally, perhaps, we should avoid relying on CSS media queries to
detect mobile phones. Here I just add a placeholder to remember where
is a good (?) place to add such in JS instead.

Sadly cannot use the more elegant template literal syntax for
multi-line string literals, as some of the Jenkins builders don't seem
to like it.

Change-Id: I718f86f41cae461abbca3d7cd2751de3236bff18
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90705
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Tor Lillqvist 

diff --git a/loleaflet/src/map/Map.js b/loleaflet/src/map/Map.js
index 600a078d3..69f094070 100644
--- a/loleaflet/src/map/Map.js
+++ b/loleaflet/src/map/Map.js
@@ -231,6 +231,14 @@ L.Map = L.Evented.extend({
this._size = new L.Point(0,0);
this._onResize();
this._socket.sendMessage('uno 
.uno:LOKSetMobile');
+   // Add a style sheet for mobile phones. Just a 
placeholder so far.
+   var style = document.createElement('style');
+   style.innerHTML = ' \
+#foobar { \
+background: red; \
+} \
+';
+   document.head.appendChild(style);
}
});
this.on('updatetoolbarcommandvalues', function(e) {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loleaflet/src

[Tor Lillqvist (via logerrit)]

 loleaflet/src/control/Control.Menubar.js |3 +++
 1 file changed, 3 insertions(+)

New commits:
commit f0db3d0d51ad92011f5610ee5c3d44a2a3db2544
Author: Tor Lillqvist 
AuthorDate: Wed Mar 18 16:54:17 2020 +0200
Commit: Tor Lillqvist 
CommitDate: Wed Mar 18 16:31:33 2020 +0100

Add some comments

Change-Id: Ia7153440121acb078f299f79f46fb84d36c67647
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90704
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Tor Lillqvist 

diff --git a/loleaflet/src/control/Control.Menubar.js 
b/loleaflet/src/control/Control.Menubar.js
index 5759d2e99..add49462f 100644
--- a/loleaflet/src/control/Control.Menubar.js
+++ b/loleaflet/src/control/Control.Menubar.js
@@ -884,11 +884,14 @@ L.Control.Menubar = L.Control.extend({
 
var self = this;
// SmartMenus mobile menu toggle button
+   // No idea what the above line means. I am told "smartmenus" is 
what is used for the NON-mobile "normal"
+   // horizontal menubar. So what is a "SmartMenus mobile menu"? 
--tml
$(function() {
var $mainMenuState = $('#main-menu-state');
if ($mainMenuState.length) {
// animate mobile menu
$mainMenuState.change(function() {
+   // This code is invoked when the 
hamburger menu is opened or closed
var $menu = $('#main-menu');
var $nav = $menu.parent();
if (this.checked) {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loleaflet/src

[Michael Meeks (via logerrit)]

 loleaflet/src/control/Control.Menubar.js |   73 +--
 loleaflet/src/map/Clipboard.js   |   12 -
 2 files changed, 33 insertions(+), 52 deletions(-)

New commits:
commit 927ab64d5fe1bd32c6bede51673b6e7c559a04a3
Author: Michael Meeks 
AuthorDate: Tue Mar 17 13:31:25 2020 +
Commit: Andras Timar 
CommitDate: Wed Mar 18 17:17:39 2020 +0100

android: mend copy/paste from the hamburger menu again.

Remove grim duplicate dialog, consolidate clipboard warnings
in the clipboard code, and only show them after attempting the
copy/cut/paste and failing - rather than unconditionally.

Switch back items to use UNO commands, since we filterExecCopyPaste
in the existing _sendCommand anyway and warn suitably.

Add existing l10n hacks to the clipboard code itself.

Change-Id: Ia8befcdea3cce1934cbb9352174ba95b04eced07
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90651
Tested-by: Jenkins CollaboraOffice 
Tested-by: Andras Timar 
Reviewed-by: Andras Timar 

diff --git a/loleaflet/src/control/Control.Menubar.js 
b/loleaflet/src/control/Control.Menubar.js
index add49462f..f44092377 100644
--- a/loleaflet/src/control/Control.Menubar.js
+++ b/loleaflet/src/control/Control.Menubar.js
@@ -37,9 +37,9 @@ L.Control.Menubar = L.Control.extend({
{uno: '.uno:Redo'},
{name: _('Repair'), id: 'repair',  type: 
'action'},
{type: 'separator'},
-   {name: _UNO('.uno:Cut'), id: 'warn-copy-paste', 
 type: 'action', mobileappuno: '.uno:Cut'},
-   {name: _UNO('.uno:Copy'), id: 
'warn-copy-paste',  type: 'action', mobileappuno: '.uno:Copy'},
-   {name: _UNO('.uno:Paste'), id: 
'warn-copy-paste',  type: 'action', mobileappuno: '.uno:Paste'},
+   {uno: '.uno:Cut'},
+   {uno: '.uno:Copy'},
+   {uno: '.uno:Paste'},
{uno: '.uno:SelectAll'},
{type: 'separator'},
{uno: '.uno:SearchDialog'},
@@ -265,9 +265,9 @@ L.Control.Menubar = L.Control.extend({
{uno: '.uno:Redo'},
{name: _('Repair'), id: 'repair',  type: 
'action'},
{type: 'separator'},
-   {name: _UNO('.uno:Cut'), id: 'warn-copy-paste', 
 type: 'action', mobileappuno: '.uno:Cut'},
-   {name: _UNO('.uno:Copy'), id: 
'warn-copy-paste',  type: 'action', mobileappuno: '.uno:Copy'},
-   {name: _UNO('.uno:Paste'), id: 
'warn-copy-paste',  type: 'action', mobileappuno: '.uno:Paste'},
+   {uno: '.uno:Cut'},
+   {uno: '.uno:Copy'},
+   {uno: '.uno:Paste'},
{uno: '.uno:SelectAll'},
{type: 'separator'},
{uno: '.uno:SearchDialog'}
@@ -366,9 +366,9 @@ L.Control.Menubar = L.Control.extend({
{uno: '.uno:Redo'},
{name: _('Repair'), id: 'repair',  type: 
'action'},
{type: 'separator'},
-   {name: _UNO('.uno:Cut'), id: 'warn-copy-paste', 
 type: 'action', mobileappuno: '.uno:Cut'},
-   {name: _UNO('.uno:Copy'), id: 
'warn-copy-paste',  type: 'action', mobileappuno: '.uno:Copy'},
-   {name: _UNO('.uno:Paste'), id: 
'warn-copy-paste',  type: 'action', mobileappuno: '.uno:Paste'},
+   {uno: '.uno:Cut'},
+   {uno: '.uno:Copy'},
+   {uno: '.uno:Paste'},
{uno: '.uno:SelectAll'},
{type: 'separator'},
{uno: '.uno:SearchDialog'}
@@ -484,9 +484,9 @@ L.Control.Menubar = L.Control.extend({
{uno: '.uno:Redo'},
{name: _('Repair'), id: 'repair',  type: 
'action'},
{type: 'separator'},
-   {name: _UNO('.uno:Cut'), id: 'warn-copy-paste', 
 type: 'action', mobileappuno: '.uno:Cut'},
-   {name: _UNO('.uno:Copy'), id: 
'warn-copy-paste',  type: 'action', mobileappuno: '.uno:Copy'},
-   {name: _UNO('.uno:Paste'), id: 
'warn-copy-paste',  type: 'action', mobileappuno: '.uno:Paste'},
+   {uno: '.uno:Cut'},
+   {uno: '.uno:Copy'},
+   {uno: '.uno:Paste'},
{uno: 

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.2' - translations

[Andras Timar (via logerrit)]

 translations |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 60ababfc35eabe0fa0b6205681775085cf20da25
Author: Andras Timar 
AuthorDate: Wed Mar 18 18:07:08 2020 +0100
Commit: Gerrit Code Review 
CommitDate: Wed Mar 18 18:07:08 2020 +0100

Update git submodules

* Update translations from branch 'distro/collabora/cp-6.2'
  to 2aae293598f22fbe80a9a4d96d5f10d32cdadcfc
  - Updated Spanish translation

Change-Id: I38912c33f74b4899af4e3c678fa0256aead75b01

diff --git a/translations b/translations
index 89119ed086f2..2aae293598f2 16
--- a/translations
+++ b/translations
@@ -1 +1 @@
-Subproject commit 89119ed086f2739db3a70f62716f8ac625a8d305
+Subproject commit 2aae293598f22fbe80a9a4d96d5f10d32cdadcfc
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: cypress_test/integration_tests

[Tamás Zolnai (via logerrit)]

 cypress_test/integration_tests/common/helper.js |  
  3 +++
 cypress_test/integration_tests/mobile/calc/apply_font_spec.js   |  
  4 
 cypress_test/integration_tests/mobile/calc/focus_spec.js|  
  6 --
 cypress_test/integration_tests/mobile/calc/insertion_wizard_spec.js |  
  4 
 cypress_test/integration_tests/mobile/writer/focus_spec.js  |  
  8 
 cypress_test/integration_tests/mobile/writer/insert_field_spec.js   |  
  1 -
 cypress_test/integration_tests/mobile/writer/insert_formatting_mark_spec.js |  
  1 -
 cypress_test/integration_tests/mobile/writer/mobile_wizard_state_spec.js|  
  3 ---
 cypress_test/integration_tests/mobile/writer/table_properties_spec.js   |  
  4 
 9 files changed, 3 insertions(+), 31 deletions(-)

New commits:
commit 407f830f50b900f7f6c384f73de9ad6cff15deaf
Author: Tamás Zolnai 
AuthorDate: Wed Mar 18 11:41:16 2020 +0100
Commit: Tamás Zolnai 
CommitDate: Wed Mar 18 20:45:36 2020 +0100

cypress: mobile: add also an indicator to enableEditingMobile.

Which indicates that the application stepped into edit mode.

Change-Id: I196851c618fd3b6c670b26184e6bbca8050f2f5a
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90711
Tested-by: Tamás Zolnai 
Reviewed-by: Tamás Zolnai 

diff --git a/cypress_test/integration_tests/common/helper.js 
b/cypress_test/integration_tests/common/helper.js
index 664e5f202..d1789530d 100644
--- a/cypress_test/integration_tests/common/helper.js
+++ b/cypress_test/integration_tests/common/helper.js
@@ -55,6 +55,9 @@ function enableEditingMobile() {
.click();
}
});
+
+   cy.get('#tb_actionbar_item_mobile_wizard')
+   .should('not.have.class', 'disabled');
 }
 
 // Assert that NO keyboard input is accepted (i.e. keyboard should be HIDDEN).
diff --git a/cypress_test/integration_tests/mobile/calc/apply_font_spec.js 
b/cypress_test/integration_tests/mobile/calc/apply_font_spec.js
index 2a669f70a..c829890da 100644
--- a/cypress_test/integration_tests/mobile/calc/apply_font_spec.js
+++ b/cypress_test/integration_tests/mobile/calc/apply_font_spec.js
@@ -10,10 +10,6 @@ describe('Apply font changes.', function() {
// Click on edit button
helper.enableEditingMobile();
 
-   // Button should be enabled now
-   cy.get('#tb_actionbar_item_mobile_wizard')
-   .should('not.have.class', 'disabled');
-
calcHelper.clickOnFirstCell();
 
cy.get('.leaflet-marker-icon')
diff --git a/cypress_test/integration_tests/mobile/calc/focus_spec.js 
b/cypress_test/integration_tests/mobile/calc/focus_spec.js
index 2c23bc1a5..0ea2b3b77 100644
--- a/cypress_test/integration_tests/mobile/calc/focus_spec.js
+++ b/cypress_test/integration_tests/mobile/calc/focus_spec.js
@@ -16,9 +16,6 @@ describe('Calc focus tests', function() {
// Click on edit button
helper.enableEditingMobile();
 
-   cy.get('#tb_actionbar_item_mobile_wizard')
-   .should('not.have.class', 'disabled');
-
// Body has the focus -> can't type in the document
cy.document().its('activeElement.tagName')
.should('be.eq', 'BODY');
@@ -52,9 +49,6 @@ describe('Calc focus tests', function() {
// Click on edit button
helper.enableEditingMobile();
 
-   cy.get('#tb_actionbar_item_mobile_wizard')
-   .should('not.have.class', 'disabled');
-
// Body has the focus -> can't type in the document
cy.document().its('activeElement.tagName')
.should('be.eq', 'BODY');
diff --git 
a/cypress_test/integration_tests/mobile/calc/insertion_wizard_spec.js 
b/cypress_test/integration_tests/mobile/calc/insertion_wizard_spec.js
index 1b5d1637a..1f045440d 100644
--- a/cypress_test/integration_tests/mobile/calc/insertion_wizard_spec.js
+++ b/cypress_test/integration_tests/mobile/calc/insertion_wizard_spec.js
@@ -10,10 +10,6 @@ describe('Calc insertion wizard.', function() {
// Click on edit button
helper.enableEditingMobile();
 
-   // Button should be enabled now
-   cy.get('#tb_actionbar_item_insertion_mobile_wizard')
-   .should('not.have.class', 'disabled');
-
calcHelper.clickOnFirstCell();
 
cy.get('.leaflet-marker-icon')
diff --git a/cypress_test/integration_tests/mobile/writer/focus_spec.js 
b/cypress_test/integration_tests/mobile/writer/focus_spec.js
index 4e4d50b6d..f1efae3ee 100644
--- a/cypress_test/integration_tests/mobile/writer/focus_spec.js
+++ b/cypress_test/integration_tests/mobile/writer/focus_spec.js
@@ -15,9 +15,6 @@ describe('Focus 

[Libreoffice-commits] online.git: loleaflet/src

[Henry Castro (via logerrit)]

 loleaflet/src/layer/tile/TileLayer.js |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit 569b342c2029876b1c9ef8b54f235138bff9c792
Author: Henry Castro 
AuthorDate: Tue Mar 17 16:38:01 2020 -0400
Commit: Andras Timar 
CommitDate: Wed Mar 18 23:08:07 2020 +0100

loleaflet: do not scroll cell cursor marker if width is very large

When the cursor has a large width due to full merged row cell
it has an undesired effect that scroll to last columns

Change-Id: Ic939b8d9c3007faa46897893cc462cf3dbbee563
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90671
Tested-by: Andras Timar 
Reviewed-by: Andras Timar 

diff --git a/loleaflet/src/layer/tile/TileLayer.js 
b/loleaflet/src/layer/tile/TileLayer.js
index 7cdea620d..a398ff1bc 100644
--- a/loleaflet/src/layer/tile/TileLayer.js
+++ b/loleaflet/src/layer/tile/TileLayer.js
@@ -2863,12 +2863,13 @@ L.TileLayer = L.GridLayer.extend({
}
}
else if (horizontalDirection !== 0 || 
verticalDirection != 0) {
+   var mapX = Math.abs(mapBounds.getEast() 
- mapBounds.getWest());
var spacingX = 
Math.abs(this._cellCursor.getEast() - this._cellCursor.getWest()) / 4.0;
var spacingY = 
Math.abs((this._cellCursor.getSouth() - this._cellCursor.getNorth())) / 4.0;
 
if (this._cellCursor.getWest() < 
mapBounds.getWest()) {
scrollX = 
this._cellCursor.getWest() - mapBounds.getWest() - spacingX;
-   } else if (this._cellCursor.getEast() > 
mapBounds.getEast()) {
+   } else if (spacingX < mapX && 
this._cellCursor.getEast() > mapBounds.getEast()) {
scrollX = 
this._cellCursor.getEast() - mapBounds.getEast() + spacingX;
}
if (this._cellCursor.getNorth() > 
mapBounds.getNorth()) {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loleaflet/src

[Tor Lillqvist (via logerrit)]

 loleaflet/src/control/Control.Menubar.js |4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

New commits:
commit abf7f18d5a1d626cde2a35a595539470b0e62f59
Author: Tor Lillqvist 
AuthorDate: Wed Mar 18 20:09:25 2020 +0200
Commit: Tor Lillqvist 
CommitDate: Wed Mar 18 20:17:36 2020 +0100

Now I understand what that comment meant

Change-Id: I80b420c8f9f4ebf59b9354c435b893a4370bb217
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90713
Tested-by: Tor Lillqvist 
Reviewed-by: Tor Lillqvist 

diff --git a/loleaflet/src/control/Control.Menubar.js 
b/loleaflet/src/control/Control.Menubar.js
index f44092377..c11e54a5e 100644
--- a/loleaflet/src/control/Control.Menubar.js
+++ b/loleaflet/src/control/Control.Menubar.js
@@ -883,9 +883,7 @@ L.Control.Menubar = L.Control.extend({
$('#main-menu').parent().css('height', '0');
 
var self = this;
-   // SmartMenus mobile menu toggle button
-   // No idea what the above line means. I am told "smartmenus" is 
what is used for the NON-mobile "normal"
-   // horizontal menubar. So what is a "SmartMenus mobile menu"? 
--tml
+   // Also the vertical menu displayed when tapping the hamburger 
button is produced by SmartMenus
$(function() {
var $mainMenuState = $('#main-menu-state');
if ($mainMenuState.length) {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] help.git: source/text

[Olivier Hallot (via logerrit)]

 source/text/scalc/01/04060110.xhp  |5 --
 source/text/scalc/01/ful_func.xhp  |   73 ++---
 source/text/scalc/01/func_concat.xhp   |4 -
 source/text/scalc/01/func_textjoin.xhp |4 -
 4 files changed, 47 insertions(+), 39 deletions(-)

New commits:
commit 5708e58ddae44ea7c5f5ad2f76b47be980b53b80
Author: Olivier Hallot 
AuthorDate: Tue Mar 17 08:11:45 2020 -0300
Commit: Olivier Hallot 
CommitDate: Wed Mar 18 20:52:16 2020 +0100

tdf#131360,tdf#131361 (part) 256 arguments

- update argument limit from 30 to 256
- create embeddedable text reusable for many functions
   listed in tdf#131360 and tdf#131261 when arguments
   are strings, integes, numbers, logicals, complex and references
- with reduced translation job
- fixes CONCAT, TEXTJOIN and CONCATENATE with String arguments.

Change-Id: I8a32914c5ef31d796a21cf2ee705b92de7b58f90
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/90613
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/source/text/scalc/01/04060110.xhp 
b/source/text/scalc/01/04060110.xhp
index 5e24c67a8..b9ad5ab2e 100644
--- a/source/text/scalc/01/04060110.xhp
+++ b/source/text/scalc/01/04060110.xhp
@@ -196,9 +196,8 @@
 Combines several text strings into one 
string.
 
 
-CONCATENATE("Text1"; ...; "Text30")
- Text 1; 
Text 2; ... represent up to 30 text passages which are to be combined 
into one string.
-
+CONCATENATE( 
 
)
+
 
  =CONCATENATE("Good ";"Morning ";"Mrs. ";"Doe") returns: 
Good Morning Mrs. Doe.
 
diff --git a/source/text/scalc/01/ful_func.xhp 
b/source/text/scalc/01/ful_func.xhp
index f0bd195d8..79934d07c 100644
--- a/source/text/scalc/01/ful_func.xhp
+++ b/source/text/scalc/01/ful_func.xhp
@@ -16,50 +16,59 @@
 
 Title in descriptions of functions 

-   
-   Syntax
-   
+   Syntax


-   
-   Examples
-   
+   Examples

 
 Notes for functions 
-   
-   
-   A complex number is a string expression 
resulting in the form "a+bi" or "a+bj", where a and b are numbers.
-   
-   
-   
-   
-   If the complex number is actually a real 
number (b=0), then it can be either a string expression or a number value.
-   
-   
+   
+   A complex number 
is a string expression resulting in the form "a+bi" or "a+bj", where a and b 
are numbers.
+   
+   
+   If the complex 
number is actually a real number (b=0), then it can be either a string 
expression or a number value.
+   
 
Warnings for functions 
-   
-   
-   The function always returns a string representing a 
complex number.
-   
-   
-   
-   
-   If the result is a complex number with one of its parts 
(a or b) equal to zero, that part is not displayed.
-   
-   
+   
+   The function always returns 
a string representing a complex number.
+
+   
+   If the result is a complex 
number with one of its parts (a or b) equal to zero, that part is not 
displayed.
+   
 
 Other paragraphs 

-   
-   The imaginary part is equal to zero, so it is not 
displayed in the result.
-   
+   The imaginary part is equal to 
zero, so it is not displayed in the result.


-   
-   The result is presented in the string format and has 
the character "i" or "j" as an imaginary unit.
-   
+   The result is presented in the string format and has the 
character "i" or "j" as an imaginary unit.

+256 arguments
+String 1[, String 2][, … ,[String 256]]
+
+String 
1[, String 2][, … ,[String 256]] are strings,  references to cells or to 
cell ranges of strings.
+
+Integer 1[, Integer 2][, … ,[Integer 
256]]
+
+Integer 
1[, Integer 2][, … ,[Integer 256]] are integers, references to cells or 
to cell ranges of integers.
+
+Number 1[, Number 2][, … ,[Number 256]]
+
+Number 
1[, Number 2][, … ,[Number 256]] are numbers, references to cells or to 
cell ranges of numbers.
+
+Logical 1[, Logical 2][, … ,[Logical 
256]]
+
+Logical 
1[, Logical 2][, … ,[Logical 256]] are boolean values, references to 
cells or to cell ranges of logical values.
+
+Complex 1[, Complex 2][, … ,[Complex 
256]]
+
+Complex 
1[, Complex 2][, … ,[Complex 256]] are complex numbers, references to 
cells or to cell ranges of complex numbers.
+
+Reference 1[, Reference 2][, … ,[Reference 
256]]
+
+Reference 
1[, Reference 2][, … ,[Reference 256]] are references to 

[Libreoffice-commits] core.git: helpcontent2

[Olivier Hallot (via logerrit)]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit e9e04cc17c549e54ccf3cede00d0ce8c4c901310
Author: Olivier Hallot 
AuthorDate: Wed Mar 18 16:52:16 2020 -0300
Commit: Gerrit Code Review 
CommitDate: Wed Mar 18 20:52:16 2020 +0100

Update git submodules

* Update helpcontent2 from branch 'master'
  to 5708e58ddae44ea7c5f5ad2f76b47be980b53b80
  - tdf#131360,tdf#131361 (part) 256 arguments

- update argument limit from 30 to 256
- create embeddedable text reusable for many functions
   listed in tdf#131360 and tdf#131261 when arguments
   are strings, integes, numbers, logicals, complex and references
- with reduced translation job
- fixes CONCAT, TEXTJOIN and CONCATENATE with String arguments.

Change-Id: I8a32914c5ef31d796a21cf2ee705b92de7b58f90
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/90613
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index b20290463c2a..5708e58ddae4 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit b20290463c2aee8a8fa5a8a38a42b5ccde9c2aed
+Subproject commit 5708e58ddae44ea7c5f5ad2f76b47be980b53b80
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: connectivity/source

[Luboš Luňák (via logerrit)]

 connectivity/source/parse/sqlflex.l |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 28e72991f88b564cc184533be9a7d6ffc5f41947
Author: Luboš Luňák 
AuthorDate: Mon Feb 3 16:57:45 2020 +0100
Commit: Luboš Luňák 
CommitDate: Wed Mar 18 20:57:14 2020 +0100

avoid clang's unreachable code warning

Change-Id: I1a3aa4f560fbc2d41872a634a599226c592ddc18
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90715
Tested-by: Jenkins
Reviewed-by: Luboš Luňák 

diff --git a/connectivity/source/parse/sqlflex.l 
b/connectivity/source/parse/sqlflex.l
index 1339cc95a39d..62cdc0abb865 100644
--- a/connectivity/source/parse/sqlflex.l
+++ b/connectivity/source/parse/sqlflex.l
@@ -98,7 +98,7 @@ static void do_fatal_error(const char* msg)
 {
 xxx_pGLOBAL_SQLSCAN->SQLyyerror(msg);
 /*hack to silence -Wunused-function*/
-if (0) yy_fatal_error(msg);
+if ((0)) yy_fatal_error(msg);
 }
 
 #define YY_FATAL_ERROR(msg) \
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: common/Seccomp.cpp

[Corentin Noël (via logerrit)]

 common/Seccomp.cpp |   16 
 1 file changed, 16 insertions(+)

New commits:
commit 2edf0dcb3a2eb9ef994e6925098732d8def8aabe
Author: Corentin Noël 
AuthorDate: Wed Mar 18 20:56:55 2020 +0100
Commit: Michael Meeks 
CommitDate: Wed Mar 18 22:34:54 2020 +0100

Seccomp: Add AARCH64 support

Change-Id: I59e042b244711ef3780cee7946be78d31dca8d8d
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90717
Tested-by: Michael Meeks 
Reviewed-by: Michael Meeks 

diff --git a/common/Seccomp.cpp b/common/Seccomp.cpp
index 116056892..e868ee01e 100644
--- a/common/Seccomp.cpp
+++ b/common/Seccomp.cpp
@@ -44,6 +44,10 @@
 #  define AUDIT_ARCH_NR AUDIT_ARCH_X86_64
 #  define SECCOMP_REG(_ctx, _reg) ((_ctx)->uc_mcontext.gregs[(_reg)])
 #  define SECCOMP_SYSCALL(_ctx)   SECCOMP_REG(_ctx, REG_RAX)
+#elif defined(__aarch64__)
+#  define AUDIT_ARCH_NR AUDIT_ARCH_AARCH64
+#  define SECCOMP_REG(_ctx, _reg) ((_ctx)->uc_mcontext.regs[_reg])
+#  define SECCOMP_SYSCALL(_ctx)   SECCOMP_REG(_ctx, 8)
 #elif defined(__arm__)
 #  define AUDIT_ARCH_NR AUDIT_ARCH_ARM
 #  define SECCOMP_REG(_ctx, _reg) ((_ctx)->uc_mcontext.arm_##_reg)
@@ -119,9 +123,17 @@ bool lockdown(Type type)
 ACCEPT_SYSCALL(futex),
 
 // glibc's 'poll' has to answer for this lot:
+#if !defined(__NR_epoll_wait) && defined(__NR_epoll_pwait)
+ACCEPT_SYSCALL(epoll_pwait),
+#else
 ACCEPT_SYSCALL(epoll_wait),
+#endif
 ACCEPT_SYSCALL(epoll_ctl),
+#if !defined(__NR_epoll_create) && defined(__NR_epoll_create1)
+ACCEPT_SYSCALL(epoll_create1),
+#else
 ACCEPT_SYSCALL(epoll_create),
+#endif
 ACCEPT_SYSCALL(close),
 ACCEPT_SYSCALL(nanosleep),
 
@@ -150,7 +162,9 @@ bool lockdown(Type type)
 KILL_SYSCALL(shmctl),
 KILL_SYSCALL(ptrace), // tracing
 KILL_SYSCALL(capset),
+#ifdef __NR_uselib
 KILL_SYSCALL(uselib),
+#endif
 KILL_SYSCALL(personality), // !
 KILL_SYSCALL(vhangup),
 #ifdef __NR_modify_ldt
@@ -178,7 +192,9 @@ bool lockdown(Type type)
 KILL_SYSCALL(add_key), // kernel keyring
 KILL_SYSCALL(request_key), // kernel keyring
 KILL_SYSCALL(keyctl),  // kernel keyring
+#ifdef __NR_inotify_init
 KILL_SYSCALL(inotify_init),
+#endif
 KILL_SYSCALL(inotify_add_watch),
 KILL_SYSCALL(inotify_rm_watch),
 KILL_SYSCALL(unshare),
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.2' - 2 commits - editeng/source sc/source

[Marco Cecchetti (via logerrit)]

 editeng/source/editeng/editview.cxx |5 +
 editeng/source/editeng/impedit.cxx  |9 +++--
 sc/source/ui/app/inputwin.cxx   |2 ++
 3 files changed, 14 insertions(+), 2 deletions(-)

New commits:
commit ee81e26b1ef6e9e2dafb5bfb85014a51d116e705
Author: Marco Cecchetti 
AuthorDate: Thu Mar 5 11:43:51 2020 +0100
Commit: Jan Holesovsky 
CommitDate: Wed Mar 18 21:48:26 2020 +0100

lok: get the formula input bar focused after inserting '='

Change-Id: I7f86ea7135fcb4071cc0162c233c63be6c9485bd

diff --git a/sc/source/ui/app/inputwin.cxx b/sc/source/ui/app/inputwin.cxx
index fa84747e17be..161cb90806c1 100644
--- a/sc/source/ui/app/inputwin.cxx
+++ b/sc/source/ui/app/inputwin.cxx
@@ -450,6 +450,8 @@ void ScInputWindow::Select()
 EditView* pView = aTextWindow.GetEditView();
 if (pView)
 {
+if (comphelper::LibreOfficeKit::isActive())
+TextGrabFocus();
 pView->SetSelection( ESelection(0, nStartPos, 0, nEndPos) 
);
 pScMod->InputChanged(pView);
 SetOkCancelMode();
commit 3a7486b16ee89031ef9ae36a07474a8fa13b7de3
Author: Marco Cecchetti 
AuthorDate: Thu Mar 5 11:42:29 2020 +0100
Commit: Jan Holesovsky 
CommitDate: Wed Mar 18 21:47:48 2020 +0100

lok: avoid to grab the focus from the formula bar

Change-Id: I13a2766e3c5dfd67cc89b5303e4a06f058b43891

diff --git a/editeng/source/editeng/editview.cxx 
b/editeng/source/editeng/editview.cxx
index 24d0947d7de5..66c8ed6f5b4a 100644
--- a/editeng/source/editeng/editview.cxx
+++ b/editeng/source/editeng/editview.cxx
@@ -486,6 +486,11 @@ void EditView::ShowCursor( bool bGotoCursor, bool 
bForceVisCursor, bool bActivat
 if (pParent && pParent->GetLOKWindowId() != 0)
 return;
 
+// We need to avoid to grab the focus from the formula bar
+vcl::Window* pWindow = Application::GetFocusWindow();
+if (!pWindow || pWindow != pImpEditView->pOutWin)
+return;
+
 static const OString aPayload = OString::boolean(true);
 
pImpEditView->mpViewShell->libreOfficeKitViewCallback(LOK_CALLBACK_CURSOR_VISIBLE,
 aPayload.getStr());
 
pImpEditView->mpViewShell->NotifyOtherViews(LOK_CALLBACK_VIEW_CURSOR_VISIBLE, 
"visible", aPayload);
diff --git a/editeng/source/editeng/impedit.cxx 
b/editeng/source/editeng/impedit.cxx
index c9ad00241a55..e5bf2f3d3cf3 100644
--- a/editeng/source/editeng/impedit.cxx
+++ b/editeng/source/editeng/impedit.cxx
@@ -1196,8 +1196,13 @@ void ImpEditView::ShowCursor( bool bGotoCursor, bool 
bForceVisCursor )
 }
 }
 
-SfxLokHelper::notifyVisCursorInvalidation(mpViewShell, sRect, 
bIsWrong, sHyperlink);
-
mpViewShell->NotifyOtherViews(LOK_CALLBACK_INVALIDATE_VIEW_CURSOR, "rectangle", 
sRect);
+// We need to avoid to grab the focus from the formula bar
+vcl::Window* pWindow = Application::GetFocusWindow();
+if (pWindow && pWindow == pOutWin)
+{
+SfxLokHelper::notifyVisCursorInvalidation(mpViewShell, 
sRect, bIsWrong, sHyperlink);
+
mpViewShell->NotifyOtherViews(LOK_CALLBACK_INVALIDATE_VIEW_CURSOR, "rectangle", 
sRect);
+}
 }
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loleaflet/l10n

[Andras Timar (via logerrit)]

 loleaflet/l10n/uno/af.json  |2 ++
 loleaflet/l10n/uno/am.json  |4 +++-
 loleaflet/l10n/uno/ar.json  |2 ++
 loleaflet/l10n/uno/as.json  |2 ++
 loleaflet/l10n/uno/ast.json |2 ++
 loleaflet/l10n/uno/be.json  |4 +++-
 loleaflet/l10n/uno/bg.json  |2 ++
 loleaflet/l10n/uno/bn-IN.json   |2 ++
 loleaflet/l10n/uno/bn.json  |2 ++
 loleaflet/l10n/uno/bo.json  |2 ++
 loleaflet/l10n/uno/br.json  |2 ++
 loleaflet/l10n/uno/brx.json |2 ++
 loleaflet/l10n/uno/bs.json  |2 ++
 loleaflet/l10n/uno/ca-valencia.json |2 ++
 loleaflet/l10n/uno/ca.json  |2 ++
 loleaflet/l10n/uno/cs.json  |2 ++
 loleaflet/l10n/uno/cy.json  |2 ++
 loleaflet/l10n/uno/da.json  |2 ++
 loleaflet/l10n/uno/de.json  |2 ++
 loleaflet/l10n/uno/dgo.json |2 ++
 loleaflet/l10n/uno/dsb.json |2 ++
 loleaflet/l10n/uno/dz.json  |2 ++
 loleaflet/l10n/uno/el.json  |2 ++
 loleaflet/l10n/uno/en-GB.json   |2 ++
 loleaflet/l10n/uno/en-ZA.json   |2 ++
 loleaflet/l10n/uno/eo.json  |2 ++
 loleaflet/l10n/uno/es.json  |2 ++
 loleaflet/l10n/uno/et.json  |2 ++
 loleaflet/l10n/uno/eu.json  |2 ++
 loleaflet/l10n/uno/fa.json  |2 ++
 loleaflet/l10n/uno/fi.json  |2 ++
 loleaflet/l10n/uno/fr.json  |4 +++-
 loleaflet/l10n/uno/fy.json  |2 ++
 loleaflet/l10n/uno/ga.json  |2 ++
 loleaflet/l10n/uno/gd.json  |2 ++
 loleaflet/l10n/uno/gl.json  |2 ++
 loleaflet/l10n/uno/gu.json  |2 ++
 loleaflet/l10n/uno/gug.json |2 ++
 loleaflet/l10n/uno/he.json  |2 ++
 loleaflet/l10n/uno/hi.json  |2 ++
 loleaflet/l10n/uno/hr.json  |4 +++-
 loleaflet/l10n/uno/hsb.json |2 ++
 loleaflet/l10n/uno/hu.json  |2 ++
 loleaflet/l10n/uno/id.json  |2 ++
 loleaflet/l10n/uno/is.json  |4 +++-
 loleaflet/l10n/uno/it.json  |2 ++
 loleaflet/l10n/uno/ja.json  |2 ++
 loleaflet/l10n/uno/ka.json  |2 ++
 loleaflet/l10n/uno/kab.json |1 +
 loleaflet/l10n/uno/kk.json  |2 ++
 loleaflet/l10n/uno/km.json  |2 ++
 loleaflet/l10n/uno/kmr-Latn.json|2 ++
 loleaflet/l10n/uno/kn.json  |2 ++
 loleaflet/l10n/uno/ko.json  |2 ++
 loleaflet/l10n/uno/kok.json |2 ++
 loleaflet/l10n/uno/ks.json  |2 ++
 loleaflet/l10n/uno/lo.json  |2 ++
 loleaflet/l10n/uno/lt.json  |2 ++
 loleaflet/l10n/uno/lv.json  |2 ++
 loleaflet/l10n/uno/mai.json |2 ++
 loleaflet/l10n/uno/mk.json  |2 ++
 loleaflet/l10n/uno/ml.json  |2 ++
 loleaflet/l10n/uno/mn.json  |2 ++
 loleaflet/l10n/uno/mni.json |2 ++
 loleaflet/l10n/uno/mr.json  |2 ++
 loleaflet/l10n/uno/my.json  |2 ++
 loleaflet/l10n/uno/nb.json  |4 +++-
 loleaflet/l10n/uno/ne.json  |2 ++
 loleaflet/l10n/uno/nl.json  |2 ++
 loleaflet/l10n/uno/nn.json  |4 +++-
 loleaflet/l10n/uno/nr.json  |2 ++
 loleaflet/l10n/uno/nso.json |2 ++
 loleaflet/l10n/uno/oc.json  |4 +++-
 loleaflet/l10n/uno/om.json  |2 ++
 loleaflet/l10n/uno/or.json  |2 ++
 loleaflet/l10n/uno/pa-IN.json   |2 ++
 loleaflet/l10n/uno/pl.json  |2 ++
 loleaflet/l10n/uno/pt-BR.json   |4 +++-
 loleaflet/l10n/uno/pt.json  |4 +++-
 loleaflet/l10n/uno/ro.json  |2 ++
 loleaflet/l10n/uno/ru.json  |2 ++
 loleaflet/l10n/uno/rw.json  |2 ++
 loleaflet/l10n/uno/sa-IN.json   |2 ++
 loleaflet/l10n/uno/sd.json  |2 ++
 loleaflet/l10n/uno/si.json  |2 ++
 loleaflet/l10n/uno/sid.json |2 ++
 loleaflet/l10n/uno/sk.json  |2 ++
 loleaflet/l10n/uno/sl.json  |2 ++
 loleaflet/l10n/uno/sq.json  |2 ++
 loleaflet/l10n/uno/sr-Latn.json |2 ++
 loleaflet/l10n/uno/sr.json  |2 ++
 loleaflet/l10n/uno/ss.json  |2 ++
 loleaflet/l10n/uno/st.json  |2 ++
 loleaflet/l10n/uno/sv.json  |2 ++
 loleaflet/l10n/uno/sw-TZ.json   |2 ++
 loleaflet/l10n/uno/ta.json  |2 ++
 loleaflet/l10n/uno/te.json  |2 ++
 loleaflet/l10n/uno/tg.json  |2 ++
 loleaflet/l10n/uno/th.json  |2 ++
 loleaflet/l10n/uno/tn.json  |2 ++
 loleaflet/l10n/uno/tr.json  |2 ++
 loleaflet/l10n/uno/ts.json  |2 ++
 loleaflet/l10n/uno/ug.json  |2 ++
 loleaflet/l10n/uno/uk.json  |2 ++
 loleaflet/l10n/uno/uz.json  |2 ++
 loleaflet/l10n/uno/ve.json  |2 

[Libreoffice-commits] online.git: loleaflet/src

[Henry Castro (via logerrit)]

 loleaflet/src/control/Control.Toolbar.js |   59 ++-
 1 file changed, 35 insertions(+), 24 deletions(-)

New commits:
commit 1c4a66e736d73ab372745972a3bfcbb611e2de8a
Author: Henry Castro 
AuthorDate: Thu Mar 12 23:43:15 2020 -0400
Commit: Andras Timar 
CommitDate: Wed Mar 18 23:20:27 2020 +0100

lolealet: fill the font list when data is received

The changes only populate the font list when the data
is received by the client, the other approach iterates
all toolbar items to refresh each one.

Change-Id: I837b52275b49e025fa353dcf088f97c19779bc79
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90450
Tested-by: Andras Timar 
Reviewed-by: Andras Timar 

diff --git a/loleaflet/src/control/Control.Toolbar.js 
b/loleaflet/src/control/Control.Toolbar.js
index ea80836a4..d6e8ce67d 100644
--- a/loleaflet/src/control/Control.Toolbar.js
+++ b/loleaflet/src/control/Control.Toolbar.js
@@ -2090,6 +2090,39 @@ function onCommandValues(e) {
}
 }
 
+function updateToolbarCommandValues(e) {
+   if (e.commandName === '.uno:CharFontName') {
+   // 2) For .uno:CharFontName
+   var commandValues = map.getToolbarCommandValues(e.commandName);
+   if (typeof commandValues === 'undefined') {
+   return;
+   }
+
+   var data = []; // reset data in order to avoid that the font 
select box is populated with styles, too.
+   // Old browsers like IE11 et al don't like Object.keys with
+   // empty arguments
+   if (typeof commandValues === 'object') {
+   data = data.concat(Object.keys(commandValues));
+   }
+
+   /* debug messages it will be removed later */
+   if (data.length < 3) {
+   console.log('ALERT!, the server is sending a small font 
list');
+   }
+   /* debug end*/
+
+   $('.fonts-select').select2({
+   data: data.sort(function (a, b) {  // also 
sort(localely)
+   return a.localeCompare(b);
+   }),
+   placeholder: _('Font')
+   });
+   $('.fonts-select').on('select2:select', onFontSelect);
+   $('.fonts-select').val(fontsSelectValue).trigger('change');
+   w2ui['editbar'].resize();
+   }
+}
+
 function updateCommandValues(targetName) {
var data = [];
// 1) For .uno:StyleApply
@@ -2162,29 +2195,6 @@ function updateCommandValues(targetName) {
$('.styles-select').on('select2:select', onStyleSelect);
w2ui['editbar'].resize();
}
-
-   if (targetName === 'fonts' && $('.fonts-select option').length === 1) {
-   // 2) For .uno:CharFontName
-   commandValues = 
map.getToolbarCommandValues('.uno:CharFontName');
-   if (typeof commandValues === 'undefined') {
-   return;
-   }
-   data = []; // reset data in order to avoid that the font select 
box is populated with styles, too.
-   // Old browsers like IE11 et al don't like Object.keys with
-   // empty arguments
-   if (typeof commandValues === 'object') {
-   data = data.concat(Object.keys(commandValues));
-   }
-   $('.fonts-select').select2({
-   data: data.sort(function (a, b) {  // also 
sort(localely)
-   return a.localeCompare(b);
-   }),
-   placeholder: _('Font')
-   });
-   $('.fonts-select').on('select2:select', onFontSelect);
-   $('.fonts-select').val(fontsSelectValue).trigger('change');
-   w2ui['editbar'].resize();
-   }
 }
 
 
@@ -2683,7 +2693,8 @@ function setupToolbar(e) {
 
 
if (!window.mode.isMobile()) {
-   map.on('updatetoolbarcommandvalues', function() {
+   map.on('updatetoolbarcommandvalues', function(e) {
+   updateToolbarCommandValues(e);
w2ui['editbar'].refresh();
});
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: cypress_test/integration_tests

[Tamás Zolnai (via logerrit)]

 cypress_test/integration_tests/mobile/writer/bottom_toolbar_spec.js |   12 
 cypress_test/integration_tests/mobile/writer/writer_helper.js   |   30 
+-
 2 files changed, 39 insertions(+), 3 deletions(-)

New commits:
commit fdbca4dcf11f38c6e4da65634f88cba727ec4e9d
Author: Tamás Zolnai 
AuthorDate: Wed Mar 18 11:34:06 2020 +0100
Commit: Tamás Zolnai 
CommitDate: Wed Mar 18 20:44:48 2020 +0100

cypress: mobile: restore original selectAllMobile() in writer_helper.js.

Using CTRL+A is simpler, but with using the Hamburger menu we can
make sure that menu item is working. CTRL+A is not an actual
feature on mobile. Also it's good that we use hamburger menu, so
we can check interaction of hamburger menu and other wizards
using the same bottom panel.

Change-Id: I640e515070046ad18b00be69509ed895844962a0
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90710
Tested-by: Tamás Zolnai 
Reviewed-by: Tamás Zolnai 

diff --git 
a/cypress_test/integration_tests/mobile/writer/bottom_toolbar_spec.js 
b/cypress_test/integration_tests/mobile/writer/bottom_toolbar_spec.js
index edc05ca95..fd23fd030 100644
--- a/cypress_test/integration_tests/mobile/writer/bottom_toolbar_spec.js
+++ b/cypress_test/integration_tests/mobile/writer/bottom_toolbar_spec.js
@@ -35,6 +35,10 @@ describe('Pushing bottom toolbar items.', function() {
});
 
it('Apply bold, check keyboard.', function() {
+   cy.get('#document-container')
+   .type('{downarrow}');
+   helper.selectAllText();
+
cy.get('#tb_editbar_item_bold div table')
.should('not.have.class', 'checked');
 
@@ -71,6 +75,10 @@ describe('Pushing bottom toolbar items.', function() {
});
 
it('Apply italic, check keyboard.', function() {
+   cy.get('#document-container')
+   .type('{downarrow}');
+   helper.selectAllText();
+
cy.get('#tb_editbar_item_italic div table')
.should('not.have.class', 'checked');
 
@@ -107,6 +115,10 @@ describe('Pushing bottom toolbar items.', function() {
});
 
it('Apply underline, check keyboard.', function() {
+   cy.get('#document-container')
+   .type('{downarrow}');
+   helper.selectAllText();
+
cy.get('#tb_editbar_item_underline div table')
.should('not.have.class', 'checked');
 
diff --git a/cypress_test/integration_tests/mobile/writer/writer_helper.js 
b/cypress_test/integration_tests/mobile/writer/writer_helper.js
index e9e9ef59b..0e2385a51 100644
--- a/cypress_test/integration_tests/mobile/writer/writer_helper.js
+++ b/cypress_test/integration_tests/mobile/writer/writer_helper.js
@@ -95,13 +95,37 @@ function clearMobileWizardState() {
 }
 
 function selectAllMobile() {
+   cy.log('Select all via hamburger menu - start.');
+
// Remove selection if exist
-   //FIXME: this also gives the focus to the Writer doc,
-   // which shouldn't be needed (i.e. should have focus already).
cy.get('#document-container')
.type('{downarrow}');
+   cy.get('.leaflet-marker-icon')
+   .should('not.exist');
+
+   // Open hamburger menu
+   cy.get('#toolbar-hamburger')
+   .click();
+   cy.get('#mobile-wizard')
+   .should('be.visible', {timeout : 1});
+
+   // Open edit menu
+   cy.get('.ui-header.level-0 .menu-entry-with-icon')
+   .contains('Edit')
+   .click();
+
+   cy.get('.ui-header.level-1 .menu-entry-with-icon')
+   .should('be.visible')
+   .wait(100);
+
+   // Do the selection
+   cy.get('.ui-header.level-1 .menu-entry-with-icon')
+   .contains('Select All')
+   .click();
+   cy.get('.leaflet-marker-icon')
+   .should('exist');
 
-   helper.selectAllText();
+   cy.log('Select all via hamburger menu - end.');
 }
 
 module.exports.copyTextToClipboard = copyTextToClipboard;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sw/source

[Andrea Gelmini (via logerrit)]

 sw/source/filter/ww8/docxexport.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 1187f1d5f90296f527ba66651cd9b5b3913b597e
Author: Andrea Gelmini 
AuthorDate: Wed Mar 18 15:49:36 2020 +0100
Commit: Julien Nabet 
CommitDate: Wed Mar 18 22:12:29 2020 +0100

Fix typo

Change-Id: Id7787ef9c0d37716572f79906c129ce1b037b5df
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90703
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/sw/source/filter/ww8/docxexport.cxx 
b/sw/source/filter/ww8/docxexport.cxx
index 1e85b8ca8c70..bdb39000533b 100644
--- a/sw/source/filter/ww8/docxexport.cxx
+++ b/sw/source/filter/ww8/docxexport.cxx
@@ -1102,7 +1102,7 @@ void DocxExport::WriteSettings()
  * Its focus is on sharing files between multiple users, tracking the 
lowest supported mode in the group.
  * It is to BENEFIT older programs by not using certain new features that 
they don't understand.
  *
- * The next time the compat mode needs to be changed, I forsee the 
following steps:
+ * The next time the compat mode needs to be changed, I foresee the 
following steps:
  * 1.) Accept the new mode: Start round-tripping the new value, indicating 
we understand that format.
  * 2.) Many years later, change the TargetCompatilityMode for new 
documents, when we no longer care
  * about working with perfect compatibility with older versions of MS 
Word.
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: include/ucbhelper

[Andrea Gelmini (via logerrit)]

 include/ucbhelper/resultset.hxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 5bb1aa4dd7d97414aecfb5fab16ff9d3291f98ae
Author: Andrea Gelmini 
AuthorDate: Sun Feb 16 22:35:29 2020 +0100
Commit: Julien Nabet 
CommitDate: Wed Mar 18 22:13:13 2020 +0100

Fix typo

Change-Id: I77fc4fe10f08f3ad4eac6d2aebf546dcc709bcf9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88826
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/include/ucbhelper/resultset.hxx b/include/ucbhelper/resultset.hxx
index 2b3afd5e961f..12c83ff8e6d1 100644
--- a/include/ucbhelper/resultset.hxx
+++ b/include/ucbhelper/resultset.hxx
@@ -395,7 +395,7 @@ public:
 
 /**
  * This method is called to instruct the supplier to release the (possibly
- * presnt) property values at the given index.
+ * present) property values at the given index.
  *
  * @param nIndex is the zero-based index within the logical data array
  *   of the supplier.
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: editeng/source

[Andrea Gelmini (via logerrit)]

 editeng/source/editeng/editview.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 08ee22ba5b9e42c8f1834a816b7e41c8166aa637
Author: Andrea Gelmini 
AuthorDate: Tue Mar 17 23:08:15 2020 +0100
Commit: Julien Nabet 
CommitDate: Wed Mar 18 22:13:41 2020 +0100

Fix typo

Change-Id: I0ca59400c9e9bff95df437536a5ebdac9af1a855
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90676
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/editeng/source/editeng/editview.cxx 
b/editeng/source/editeng/editview.cxx
index e8a2b3dce0d0..bbe64366e408 100644
--- a/editeng/source/editeng/editview.cxx
+++ b/editeng/source/editeng/editview.cxx
@@ -857,7 +857,7 @@ static void LOKSendSpellPopupMenu(Menu* pMenu, LanguageType 
nGuessLangWord,
 if (!comphelper::LibreOfficeKit::isActive())
 return;
 
-// First we need to set item commends for the context menu.
+// First we need to set item commands for the context menu.
 OUString aTmpWord( SvtLanguageTable::GetLanguageString( nGuessLangWord ) );
 OUString aTmpPara( SvtLanguageTable::GetLanguageString( nGuessLangPara ) );
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: vcl/inc

[Caolán McNamara (via logerrit)]

 vcl/inc/treeglue.hxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 6388c578c672690fff662cb04b6a0436cd742f37
Author: Caolán McNamara 
AuthorDate: Wed Mar 18 20:11:28 2020 +
Commit: Caolán McNamara 
CommitDate: Wed Mar 18 22:22:06 2020 +0100

call drag end callback after superclass handler

so modifications to the model in a callback can't mangle
DragFinished's expectations.

Change-Id: I9831bbe4fe9c969307c0e7da06d579ddfa22978c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90720
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/vcl/inc/treeglue.hxx b/vcl/inc/treeglue.hxx
index ac7416590e92..d04cb2046760 100644
--- a/vcl/inc/treeglue.hxx
+++ b/vcl/inc/treeglue.hxx
@@ -93,8 +93,8 @@ public:
 
 virtual void DragFinished(sal_Int8 nDropAction) override
 {
-m_aEndDragHdl.Call(this);
 SvTabListBox::DragFinished(nDropAction);
+m_aEndDragHdl.Call(this);
 }
 
 virtual void ModelHasCleared() override
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: helpcontent2

[Seth Chaiklin (via logerrit)]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 8276fccefdefad7304f05c707f08d6d1ecaa9d55
Author: Seth Chaiklin 
AuthorDate: Thu Mar 19 03:23:08 2020 +0100
Commit: Gerrit Code Review 
CommitDate: Thu Mar 19 03:23:08 2020 +0100

Update git submodules

* Update helpcontent2 from branch 'master'
  to b6ece13cb50762fefce07a3d85f475721083fbff
  - tdf#131036 add note on "rename" and "delete" and update gradient help

   -added  about "rename" and "delete" option on Gradient
   -move "Add" and "Modify" together with Gradient and 
   -change to , , 
   -removed point about "loading gradient lists"
   -Add headings and explanations for "Gradient" and "Options"
   -update option names "To Color" and "From Color"
   -update "Preview" label
   -add "Apply" option (for Writer)

Change-Id: Iec0f29f8278e3be9dea47c69e76db3580a83e4a5
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/90636
Reviewed-by: Seth Chaiklin 
Reviewed-by: Olivier Hallot 
Tested-by: Jenkins

diff --git a/helpcontent2 b/helpcontent2
index 5708e58ddae4..b6ece13cb507 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 5708e58ddae44ea7c5f5ad2f76b47be980b53b80
+Subproject commit b6ece13cb50762fefce07a3d85f475721083fbff
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] help.git: source/text

[Seth Chaiklin (via logerrit)]

 source/text/shared/01/05210300.xhp |   58 +
 1 file changed, 34 insertions(+), 24 deletions(-)

New commits:
commit b6ece13cb50762fefce07a3d85f475721083fbff
Author: Seth Chaiklin 
AuthorDate: Thu Mar 19 00:08:14 2020 +0100
Commit: Olivier Hallot 
CommitDate: Thu Mar 19 03:23:08 2020 +0100

tdf#131036 add note on "rename" and "delete" and update gradient help

   -added  about "rename" and "delete" option on Gradient
   -move "Add" and "Modify" together with Gradient and 
   -change to , , 
   -removed point about "loading gradient lists"
   -Add headings and explanations for "Gradient" and "Options"
   -update option names "To Color" and "From Color"
   -update "Preview" label
   -add "Apply" option (for Writer)

Change-Id: Iec0f29f8278e3be9dea47c69e76db3580a83e4a5
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/90636
Reviewed-by: Seth Chaiklin 
Reviewed-by: Olivier Hallot 
Tested-by: Jenkins

diff --git a/source/text/shared/01/05210300.xhp 
b/source/text/shared/01/05210300.xhp
index 91b7e73df..bcaab24ef 100644
--- a/source/text/shared/01/05210300.xhp
+++ b/source/text/shared/01/05210300.xhp
@@ -19,10 +19,9 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  -->
 
-
 
   
- Gradients
+ Gradient
  /text/shared/01/05210300.xhp
   

@@ -30,44 +29,55 @@
   
 
 
-Gradients
- Set the 
properties of a gradient, or save and load gradient lists.
+Gradients
+ Select a 
gradient, modify the properties of a gradient, or save a new 
gradient.
   
   
  
   
+Gradient
+Lists the available 
gradients. You can also modify or create your own gradients.
+
+Add
+  Adds a custom gradient to the current list. 
Specify the properties of your gradient, and then click this 
button
+
+Modify
+  Applies the current gradient properties to the 
selected gradient. If you want, you can save the gradient under a different 
name.
+To rename a gradient, select the gradient, 
right-click and choose Rename. To delete a gradient, 
select the gradient, right-click and choose Delete.
+Options
+Use the options to 
define or modify a gradient.
 
-Type
-  Select the gradient that you want to 
apply.
+Type
+Select the gradient that you want to 
apply.
 
-Center 
X
-  Enter the horizontal offset for the 
gradient, where 0% corresponds to the current horizontal location of the 
endpoint color in the gradient. The endpoint color is the color that is 
selected in the To box.
+Center X
+  Enter the horizontal offset for the 
gradient, where 0% corresponds to the current horizontal location of the 
endpoint color in the gradient. The endpoint color is the color that is 
selected in the To Color box.
 
-Center 
Y
-  Enter the vertical offset for the 
gradient, where 0% corresponds to the current vertical location of the endpoint 
color in the gradient. The endpoint color is the color that is selected in the 
To box.
+Center Y
+  Enter the vertical offset for the 
gradient, where 0% corresponds to the current vertical location of the endpoint 
color in the gradient. The endpoint color is the color that is selected in the 
To Color box.
 
-Angle
+Angle
   Enter a rotation angle for the selected 
gradient.
 
-Border
-  Enter the amount by which you want to 
adjust the area of the endpoint color on the gradient. The endpoint color is 
the color that is selected in the To box.
-  From
+Border
+  Enter the amount by which you want to 
adjust the area of the endpoint color on the gradient. The endpoint color is 
the color that is selected in the To Color box.
+From Color
 
 Select a color for the beginning point of 
the gradient.
 
-Enter the intensity for the color in the 
From box, where 0% corresponds to black, and 100 % to the selected 
color.
-  To
+Enter the intensity for the color in the 
From Color box, where 0% corresponds to black, and 100 % to the 
selected color.
+To Color
 
 Select a color for the endpoint of the 
gradient.
 
-Enter the intensity for the color in the 
To box, where 0% corresponds to black, and 100 % to the selected 
color.
-
-Add
-  Adds a custom gradient to the current list. 
Specify the properties of your gradient, and then click this 
button
-
-Modify
-  Applies the current gradient properties to the 
selected gradient. If you want, you can save the gradient under a different 
name.
+Enter the intensity for the color in the 
To Color box, where 0% corresponds to black, and 100 % to the 
selected color.
   
-  
+  
+  
+
+  
+  
+
+

 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Minutes from the UX/design meeting 2020-Mar-18

[Heiko Tietze]

Present: Muhammet, Cor, Heiko
Comments from: MikeK, Regina

Tickets/Topic

 * Branding for 7.0
   + https://bugs.documentfoundation.org/show_bug.cgi?id=130778
   + see also https://wiki.documentfoundation.org/Marketing/Branding/Ideas
   + will be on this list until it's solved
   + CfP1 https://listarchives.libreoffice.org/global/design/msg09227.html
   + CfP2 https://listarchives.libreoffice.org/global/design/msg09272.html
   + NEXT STEPS?
   => put the ideas into the program and wait for comments

 * Overwriting Writer styles does not overwrite changes to Marginalia paragraph 
style
   + https://bugs.documentfoundation.org/show_bug.cgi?id=130719
   + define _all_ internal styles in template Style > Default?
   + MikeK: 
 1) all the styles in shipped templates (maintenance burden, possible 
implementation problem)
 2) Load Styles to always load full set of standard styles (would break 
current workflow / possible disallow the opposite need)
optionally, "[x] Overwrite standard styles absent in the template with 
defaults") 
 3) NOTABUG/WONTFIX (maybe with reanming the function "Load Styles from 
Template")
 * "Load styles" should not import content
   + https://bugs.documentfoundation.org/show_bug.cgi?id=131347
   + rename "Load Style" to "Load Template" and rename/reorganize the 
checkboxes?
   + NAB (MikeK)
 => preference to NAB (renaming/documentation) (Muhammet)

 * Make font installation optional
   + https://bugs.documentfoundation.org/show_bug.cgi?id=91886
   + big +1, ideally as extension (Heiko)
   + good idea (Muhammet)
   + disable font installation in the wizard might be unintentionally and 
cannot be reverted later (Muhammet)
   => summary "Make fonts extensionizable", hardware/platform -> All, Block -> 
clean

 * Gallery updates
   + https://bugs.documentfoundation.org/show_bug.cgi?id=131319 gallery: update 
Symbol gallery
 + looks good and could hold also what's now planned for bullets
   + https://bugs.documentfoundation.org/show_bug.cgi?id=131318 gallery: add 
Widget gallery
 + too many items, not so relevant though named as a use case some times 
   
https://design.blog.documentfoundation.org/2016/04/01/the-many-faced-god-part-2-how-libreoffice-draw-is-expected-to-evolve/
   + https://bugs.documentfoundation.org/show_bug.cgi?id=131308 Gallery: update 
Computer gallery
 + don't see any need for symbols under "Computer"
 + maybe replace COmputer by Widgets
   + any improvement is good (Cor)
   => go ahead
   + another idea for a gallery would be music notes

 * PRINTING: Option to print grid in Draw
   + https://bugs.documentfoundation.org/show_bug.cgi?id=68662
   + could be done per extension (moved), implemented to printing options 
(new), 
 or realized as a layer (wfm)
   + sounds reasonable, sometimes you want to print the grid (Cor)
   + grids are helper functions and can be complex (thickness, size, 
strightness, color etc. might need to be configurable)
   + see also https://bugs.documentfoundation.org/show_bug.cgi?id=130995
   + ship (a couple of) templates with grids to a) solve the actual problem and 
b) illustrate how its done
   + can also be shared as extension
   => do it



signature.asc
Description: OpenPGP digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: download.lst external/pdfium solenv/flatpak-manifest.in

[Miklos Vajna (via logerrit)]

 download.lst   |4 ++--
 external/pdfium/Library_pdfium.mk  |   13 ++---
 external/pdfium/inc/pch/precompiled_pdfium.hxx |   14 +++---
 solenv/flatpak-manifest.in |6 +++---
 4 files changed, 18 insertions(+), 19 deletions(-)

New commits:
commit 9054c36d4ea3bee25fb9a47a96a0ea2cd07148c3
Author: Miklos Vajna 
AuthorDate: Tue Mar 17 21:05:44 2020 +0100
Commit: Miklos Vajna 
CommitDate: Wed Mar 18 09:05:59 2020 +0100

external: update pdfium to 4083

Change-Id: Iab30effaae86a54852196d6e29d39118e0a2f70c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90667
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/download.lst b/download.lst
index 8e924262a10e..3636bd2f60b0 100644
--- a/download.lst
+++ b/download.lst
@@ -204,8 +204,8 @@ export OWNCLOUD_ANDROID_LIB_SHA256SUM := 
b18b3e3ef7fae6a79b62f2bb43cc47a5346b633
 export OWNCLOUD_ANDROID_LIB_TARBALL := 
owncloud-android-library-0.9.4-no-binary-deps.tar.gz
 export PAGEMAKER_SHA256SUM := 
66adacd705a7d19895e08eac46d1e851332adf2e736c566bef1164e7a442519d
 export PAGEMAKER_TARBALL := libpagemaker-0.0.4.tar.xz
-export PDFIUM_SHA256SUM := 
55d642468718c45fc8409537a3e8badd7e7e7be18c6e1c4be90eb278d1f1e04a
-export PDFIUM_TARBALL := pdfium-4021.tar.bz2
+export PDFIUM_SHA256SUM := 
98e3a4ddcd522fb4cebf18a7dfd0e47877e9d33e957ff47b65cb952edc89618f
+export PDFIUM_TARBALL := pdfium-4083.tar.bz2
 export PIXMAN_SHA256SUM := 
21b6b249b51c6800dc9553b65106e1e37d0e25df942c90531d4c3997aa20a88e
 export PIXMAN_TARBALL := e80ebae4da01e77f68744319f01d52a3-pixman-0.34.0.tar.gz
 export LIBPNG_SHA256SUM := 
505e70834d35383537b6491e7ae8641f1a4bed1876dbfe361201fc80868d88ca
diff --git a/external/pdfium/Library_pdfium.mk 
b/external/pdfium/Library_pdfium.mk
index 3a05bbdaaba5..8a77900c9b42 100644
--- a/external/pdfium/Library_pdfium.mk
+++ b/external/pdfium/Library_pdfium.mk
@@ -75,6 +75,7 @@ $(eval $(call 
gb_Library_add_generated_exception_objects,pdfium,\
 UnpackedTarball/pdfium/fpdfsdk/fpdf_view \
 UnpackedTarball/pdfium/fpdfsdk/cpdfsdk_pauseadapter \
 UnpackedTarball/pdfium/fpdfsdk/cpdfsdk_interactiveform \
+UnpackedTarball/pdfium/fpdfsdk/cpdfsdk_renderpage \
 ))
 
 # fdrm
@@ -268,7 +269,7 @@ $(eval $(call 
gb_Library_add_generated_exception_objects,pdfium,\
 UnpackedTarball/pdfium/core/fpdfapi/parser/cpdf_cross_ref_avail \
 UnpackedTarball/pdfium/core/fpdfapi/edit/cpdf_pagecontentmanager \
 UnpackedTarball/pdfium/core/fpdfapi/page/cpdf_transparency \
-UnpackedTarball/pdfium/core/fpdfapi/page/cpdf_dibbase \
+UnpackedTarball/pdfium/core/fpdfapi/page/cpdf_dib \
 UnpackedTarball/pdfium/core/fpdfapi/parser/cpdf_object_stream \
 UnpackedTarball/pdfium/core/fpdfapi/parser/cpdf_cross_ref_table \
 UnpackedTarball/pdfium/core/fpdfapi/edit/cpdf_stringarchivestream \
@@ -276,7 +277,7 @@ $(eval $(call 
gb_Library_add_generated_exception_objects,pdfium,\
 UnpackedTarball/pdfium/core/fpdfapi/edit/cpdf_contentstream_write_utils \
 UnpackedTarball/pdfium/core/fpdfapi/page/cpdf_annotcontext \
 UnpackedTarball/pdfium/core/fpdfapi/render/cpdf_pagerendercontext \
-UnpackedTarball/pdfium/core/fpdfapi/page/cpdf_dibtransferfunc \
+UnpackedTarball/pdfium/core/fpdfapi/page/cpdf_transferfuncdib \
 UnpackedTarball/pdfium/core/fpdfapi/page/cpdf_transferfunc \
 ))
 
@@ -285,7 +286,6 @@ $(eval $(call 
gb_Library_add_generated_exception_objects,pdfium,\
 UnpackedTarball/pdfium/core/fpdfdoc/cline \
 UnpackedTarball/pdfium/core/fpdfdoc/cpdf_aaction \
 UnpackedTarball/pdfium/core/fpdfdoc/cpdf_action \
-UnpackedTarball/pdfium/core/fpdfdoc/cpdf_actionfields \
 UnpackedTarball/pdfium/core/fpdfdoc/cpdf_annot \
 UnpackedTarball/pdfium/core/fpdfdoc/cpdf_annotlist \
 UnpackedTarball/pdfium/core/fpdfdoc/cpdf_apsettings \
@@ -293,7 +293,6 @@ $(eval $(call 
gb_Library_add_generated_exception_objects,pdfium,\
 UnpackedTarball/pdfium/core/fpdfdoc/cpdf_bookmarktree \
 UnpackedTarball/pdfium/core/fpdfdoc/cpdf_defaultappearance \
 UnpackedTarball/pdfium/core/fpdfdoc/cpdf_dest \
-UnpackedTarball/pdfium/core/fpdfdoc/cpdf_docjsactions \
 UnpackedTarball/pdfium/core/fpdfdoc/cpdf_filespec \
 UnpackedTarball/pdfium/core/fpdfdoc/cpdf_formcontrol \
 UnpackedTarball/pdfium/core/fpdfdoc/cpdf_formfield \
@@ -423,7 +422,7 @@ $(eval $(call 
gb_Library_add_generated_exception_objects,pdfium,\
 UnpackedTarball/pdfium/core/fxge/dib/cfx_bitmapstorer \
 UnpackedTarball/pdfium/core/fxge/dib/cfx_dibextractor \
 UnpackedTarball/pdfium/core/fxge/dib/cfx_dibitmap \
-UnpackedTarball/pdfium/core/fxge/dib/cfx_filtereddib \
+UnpackedTarball/pdfium/core/fxge/cfx_drawutils \
 UnpackedTarball/pdfium/core/fxge/dib/cfx_imagerenderer \
 UnpackedTarball/pdfium/core/fxge/dib/cfx_imagestretcher \
 UnpackedTarball/pdfium/core/fxge/dib/cfx_imagetransformer \
@@ -649,7 +648,7 @@ ifeq 

[Libreoffice-commits] online.git: loleaflet/src

[Ashod Nakashian (via logerrit)]

 loleaflet/src/layer/tile/TileLayer.js |   34 +-
 1 file changed, 17 insertions(+), 17 deletions(-)

New commits:
commit b0f8897b470d64053ccf3fd2bf43f614cdd511a4
Author: Ashod Nakashian 
AuthorDate: Mon Mar 9 07:50:57 2020 -0400
Commit: Ashod Nakashian 
CommitDate: Wed Mar 18 07:29:49 2020 +0100

leaflet: show/hide the keyboard with the cursor

We should only show the cursor without the keyboard
when the focus is not in the document, and even
that is highly suspecious.

Change-Id: Ibbddf24464b0b41bb0206a8d28f31aa26779fbb8
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90525
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Ashod Nakashian 

diff --git a/loleaflet/src/layer/tile/TileLayer.js 
b/loleaflet/src/layer/tile/TileLayer.js
index 4937e7c31..7cdea620d 100644
--- a/loleaflet/src/layer/tile/TileLayer.js
+++ b/loleaflet/src/layer/tile/TileLayer.js
@@ -2139,26 +2139,13 @@ L.TileLayer = L.GridLayer.extend({
_updateCursorPos: function () {
var pixBounds = 
L.bounds(this._map.latLngToLayerPoint(this._visibleCursor.getSouthWest()),

this._map.latLngToLayerPoint(this._visibleCursor.getNorthEast()));
+   var cursorSize = 
pixBounds.getSize().multiplyBy(this._map.getZoomScale(this._map.getZoom()));
var cursorPos = this._visibleCursor.getNorthWest();
 
-   var updated = true;
if (!this._cursorMarker) {
-   this._cursorMarker = L.cursor(cursorPos, 
pixBounds.getSize().multiplyBy(this._map.getZoomScale(this._map.getZoom())), 
{blink: true});
+   this._cursorMarker = L.cursor(cursorPos, cursorSize, 
{blink: true});
} else {
-   var oldLatLng = this._cursorMarker.getLatLng();
-   this._cursorMarker.setLatLng(cursorPos, 
pixBounds.getSize().multiplyBy(this._map.getZoomScale(this._map.getZoom(;
-   var newLatLng = this._cursorMarker.getLatLng();
-   // Assume the user didn't update the cursor if there is 
a selection.
-   // The update can happen when the font has changed, for 
example.
-   updated = !newLatLng.equals(oldLatLng) && 
!this.hasTextSelection();
-   }
-
-   this._map._textInput.showCursor();
-
-   if (!window.mobileWizard && updated && 
this._map.editorHasFocus()) {
-   // If the user is editing, show the keyboard, but don't 
change
-   // anything if nothing is changed, or the wizard is 
visible.
-   this._map.focus(true);
+   this._cursorMarker.setLatLng(cursorPos, cursorSize);
}
},
 
@@ -2197,11 +2184,24 @@ L.TileLayer = L.GridLayer.extend({
&& this._map.editorHasFocus()   // not when document is not 
focused
&& !this._map.isSearching() // not when searching within 
the doc
&& !this._isZooming // not when zooming
-// && !this.isGraphicVisible() // not when sizing / 
positioning graphics
&& !this._isEmptyRectangle(this._visibleCursor)) {
+
this._updateCursorPos();
+
+   // Update the cursor/keyboard only when the document 
has focus.
+   if (this._map.editorHasFocus()) {
+   this._map._textInput.showCursor();
+
+   // Don't show the keyboard when the Wizard is 
visible.
+   if (!window.mobileWizard) {
+   // If the user is editing, show the 
keyboard, but don't change
+   // anything if nothing is changed.
+   this._map.focus(true);
+   }
+   }
} else {
this._map._textInput.hideCursor();
+   this._map.focus(false);
}
},
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: cypress_test/integration_tests loleaflet/src

[Ashod Nakashian (via logerrit)]

 cypress_test/integration_tests/common/helper.js |   20 +++
 cypress_test/integration_tests/common/impress.js|2 
 cypress_test/integration_tests/mobile/writer/bottom_toolbar_spec.js |   60 
++
 loleaflet/src/control/Control.Toolbar.js|6 -
 loleaflet/src/layer/marker/TextInput.js |   15 ++
 loleaflet/src/map/Map.js|4 
 6 files changed, 105 insertions(+), 2 deletions(-)

New commits:
commit 3bafa7d4abdac77ee0e1d840096ce31536ec5acc
Author: Ashod Nakashian 
AuthorDate: Tue Mar 17 12:02:59 2020 -0400
Commit: Ashod Nakashian 
CommitDate: Wed Mar 18 07:30:08 2020 +0100

leaflet: maintain the keyboard state after toolbar actions

Previously we supressed the keyboard after toolbar
actions, but that is problematic because then the
user is unable to delete/replace selected text,
because the keyboard is hidden and there is no way
of showing keyboard without changing the selection.

Now we maintain the keyboard state, which is likely
visible, since a selection shows the keyboard.

This might not be ideal, because the user might
hide the keyboard on the device and we will restore
it after invoking a toolbar action, but at least
it's more usable now. Unfortunately, there is no
API to track the keyboard visibility.

New Cypress tests added to validate the above.

The tests depend on checking the last keyboard
visibility state in Map, because there is no
reliable (or any?) way to know whether the keyboard
is visible or not. There are many cases where we
actually hide the keyboard, while having the input
focus on the textarea element, so that is no indication
that the keyboard is visible. We do this for usability
purposes. For example, during zooming, when selecting
cells and graphics/shapes, etc.

The purpose of the cell is to validate that we restored
the keyboard visibility or we changed it, depending
on which is expected after each operation.

Change-Id: If0f2e96909ff20753043734789397d190cedb502
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90663
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Ashod Nakashian 

diff --git a/cypress_test/integration_tests/common/helper.js 
b/cypress_test/integration_tests/common/helper.js
index 01b3bbff5..849b71cab 100644
--- a/cypress_test/integration_tests/common/helper.js
+++ b/cypress_test/integration_tests/common/helper.js
@@ -57,6 +57,22 @@ function enableEditingMobile() {
});
 }
 
+// Assert that NO keyboard input is accepted (i.e. keyboard should be HIDDEN).
+function assertNoKeyboardInput() {
+   cy.window().then(win => {
+   var acceptInput = win.map._textInput.shouldAcceptInput();
+   expect(acceptInput, 'Should accept input').to.equal(false);
+   });
+}
+
+// Assert that keyboard input is accepted (i.e. keyboard should be VISIBLE).
+function assertHaveKeyboardInput() {
+   cy.window().then(win => {
+   var acceptInput = win.map._textInput.shouldAcceptInput();
+   expect(acceptInput, 'Should accept input').to.equal(true);
+   });
+}
+
 // Assert that we have cursor and focus.
 function assertCursorAndFocus() {
cy.log('Verifying Cursor and Focus.');
@@ -67,6 +83,8 @@ function assertCursorAndFocus() {
cy.get('.leaflet-cursor-container')
.should('exist');
 
+   assertHaveKeyboardInput();
+
cy.log('Cursor and Focus verified.');
 }
 
@@ -195,6 +213,8 @@ function longPressOnDocument(posX, posY) {
 module.exports.loadTestDoc = loadTestDoc;
 module.exports.enableEditingMobile = enableEditingMobile;
 module.exports.assertCursorAndFocus = assertCursorAndFocus;
+module.exports.assertNoKeyboardInput = assertNoKeyboardInput;
+module.exports.assertHaveKeyboardInput = assertHaveKeyboardInput;
 module.exports.selectAllText = selectAllText;
 module.exports.clearAllText = clearAllText;
 module.exports.getTextForClipboard = getTextForClipboard;
diff --git a/cypress_test/integration_tests/common/impress.js 
b/cypress_test/integration_tests/common/impress.js
index db06ea9ef..d6463fafc 100644
--- a/cypress_test/integration_tests/common/impress.js
+++ b/cypress_test/integration_tests/common/impress.js
@@ -12,6 +12,8 @@ function assertNotInTextEditMode() {
cy.get('.leaflet-cursor-container')
.should('not.exist');
 
+   helper.assertNoKeyboardInput();
+
cy.log('NO Text-Edit context verified.');
 }
 
diff --git 
a/cypress_test/integration_tests/mobile/writer/bottom_toolbar_spec.js 
b/cypress_test/integration_tests/mobile/writer/bottom_toolbar_spec.js
index 7bf407442..e9dfd0ebf 100644
--- a/cypress_test/integration_tests/mobile/writer/bottom_toolbar_spec.js
+++ 

[Libreoffice-commits] core.git: filter/source include/vcl offapi/com sd/qa vcl/inc vcl/source

[Tomaž Vajngerl (via logerrit)]

 filter/source/pdf/pdfdecomposer.cxx|   28 
 include/vcl/graph.hxx  |2 -
 include/vcl/vectorgraphicdata.hxx  |   12 +---
 offapi/com/sun/star/graphic/XPdfDecomposer.idl |8 +
 sd/qa/unit/import-tests.cxx|   15 ++-
 vcl/inc/impgraph.hxx   |7 +
 vcl/source/filter/ipdf/pdfread.cxx |   18 +++--
 vcl/source/gdi/graph.cxx   |7 -
 vcl/source/gdi/impgraph.cxx|   34 ++---
 vcl/source/gdi/vectorgraphicdata.cxx   |   22 
 10 files changed, 85 insertions(+), 68 deletions(-)

New commits:
commit 27ee05f860e8225a41e15e0853fcef00a9d7a621
Author: Tomaž Vajngerl 
AuthorDate: Fri Mar 13 20:04:45 2020 +0100
Commit: Tomaž Vajngerl 
CommitDate: Wed Mar 18 09:23:15 2020 +0100

pdfium: support for pages when using PDF import with pdfium

Moving PDF to use VectorGraphicData in Graphic has temporary
removed the support for showing different PDF pages when opening
the PDF using pdfium (LO_IMPORT_USE_PDFIUM=1).
This adds the support for back by specifying whcih PDF page to
render when creating the VectorGraphicData (and can't be changd
afterwards), which is used to create a Graphic and contains the
PDF source data array.

Change-Id: Ib915216b8d4c0c063d0fead44ff156b1915a35d2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90562
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl 

diff --git a/filter/source/pdf/pdfdecomposer.cxx 
b/filter/source/pdf/pdfdecomposer.cxx
index c926b1b35a9d..a03e70bd5d1a 100644
--- a/filter/source/pdf/pdfdecomposer.cxx
+++ b/filter/source/pdf/pdfdecomposer.cxx
@@ -39,8 +39,9 @@ public:
 XPdfDecomposer& operator=(const XPdfDecomposer&) = delete;
 
 // XPdfDecomposer
-uno::Sequence>
-SAL_CALL getDecomposition(const uno::Sequence& xPdfData) 
override;
+uno::Sequence> SAL_CALL
+getDecomposition(const uno::Sequence& xPdfData,
+ const uno::Sequence& 
xDecompositionParameters) override;
 
 // XServiceInfo
 OUString SAL_CALL getImplementationName() override;
@@ -50,12 +51,27 @@ public:
 
 XPdfDecomposer::XPdfDecomposer(uno::Reference const&) 
{}
 
-uno::Sequence>
-SAL_CALL XPdfDecomposer::getDecomposition(const uno::Sequence& 
xPdfData)
+uno::Sequence> SAL_CALL 
XPdfDecomposer::getDecomposition(
+const uno::Sequence& xPdfData, const 
uno::Sequence& xParameters)
 {
+sal_Int32 nPageIndex = -1;
+
+for (sal_Int32 index = 0; index < xParameters.getLength(); index++)
+{
+const beans::PropertyValue& rProperty = xParameters[index];
+
+if (rProperty.Name == "PageIndex")
+{
+rProperty.Value >>= nPageIndex;
+}
+}
+
+if (nPageIndex < 0)
+nPageIndex = 0;
+
 std::vector aBitmaps;
-vcl::RenderPDFBitmaps(xPdfData.getConstArray(), xPdfData.getLength(), 
aBitmaps, 0,
-  1 /*, fResolutionDPI*/);
+vcl::RenderPDFBitmaps(xPdfData.getConstArray(), xPdfData.getLength(), 
aBitmaps, nPageIndex, 1);
+
 BitmapEx aReplacement(aBitmaps[0]);
 
 // short form for scale and translate transformation
diff --git a/include/vcl/graph.hxx b/include/vcl/graph.hxx
index 271de60d1605..6e70f66731ac 100644
--- a/include/vcl/graph.hxx
+++ b/include/vcl/graph.hxx
@@ -204,8 +204,6 @@ public:
 
 const VectorGraphicDataPtr& getVectorGraphicData() const;
 
-/// Set the page number of the multi-page source this Graphic is rendered 
from.
-void setPageNumber(sal_Int32 nPageNumber);
 /// Get the page number of the multi-page source this Graphic is rendered 
from.
 sal_Int32 getPageNumber() const;
 
diff --git a/include/vcl/vectorgraphicdata.hxx 
b/include/vcl/vectorgraphicdata.hxx
index 096c89e1aa56..8ccf45b51e5d 100644
--- a/include/vcl/vectorgraphicdata.hxx
+++ b/include/vcl/vectorgraphicdata.hxx
@@ -70,6 +70,9 @@ private:
 // extra:
 std::unique_ptr mpExternalHeader;
 
+// If the vector format has more pages this denotes which page to render
+sal_Int32 mnPageIndex;
+
 // on demand creators
 void ensurePdfReplacement();
 void ensureReplacement();
@@ -82,10 +85,9 @@ public:
 VectorGraphicData(
 const VectorGraphicDataArray& rVectorGraphicDataArray,
 const OUString& rPath,
-VectorGraphicDataType eVectorDataType);
-VectorGraphicData(
-const OUString& rPath,
-VectorGraphicDataType eVectorDataType);
+VectorGraphicDataType eVectorDataType,
+sal_Int32 nPageIndex = -1);
+VectorGraphicData(const OUString& rPath, VectorGraphicDataType 
eVectorDataType);
 ~VectorGraphicData();
 
 /// compare op
@@ -107,6 +109,8 @@ public:
 const std::deque< css::uno::Reference< css::graphic::XPrimitive2D > >& 
getPrimitive2DSequence() const;
 const BitmapEx& 

[Libreoffice-commits] core.git: offapi/com

[Tomaž Vajngerl (via logerrit)]

 offapi/com/sun/star/graphic/PdfTools.idl   |4 +++-
 offapi/com/sun/star/graphic/XPdfDecomposer.idl |4 ++--
 2 files changed, 5 insertions(+), 3 deletions(-)

New commits:
commit 673728c9caf7b3199dd684f48a32a0f5cafd6285
Author: Tomaž Vajngerl 
AuthorDate: Wed Mar 18 09:27:52 2020 +0100
Commit: Tomaž Vajngerl 
CommitDate: Wed Mar 18 09:29:36 2020 +0100

offapi: improve description of XPDFDecomposer and PDFTools

Change-Id: I065d7c742b82f9ad19604c689a11f2e74f1ca9e0

diff --git a/offapi/com/sun/star/graphic/PdfTools.idl 
b/offapi/com/sun/star/graphic/PdfTools.idl
index b9f2e562dbf2..b2bd2c5cb22d 100644
--- a/offapi/com/sun/star/graphic/PdfTools.idl
+++ b/offapi/com/sun/star/graphic/PdfTools.idl
@@ -15,7 +15,9 @@
 module com { module sun { module star { module graphic
 {
 
-/** Service to convert a PDF stream into a bitmap primitive.
+/** Service to convert a PDF stream into a 2D primitive.
+
+@since LibreOffice 7.0
  */
 
 service PdfTools : XPdfDecomposer;
diff --git a/offapi/com/sun/star/graphic/XPdfDecomposer.idl 
b/offapi/com/sun/star/graphic/XPdfDecomposer.idl
index aae6eda55347..e0f9c8d96872 100644
--- a/offapi/com/sun/star/graphic/XPdfDecomposer.idl
+++ b/offapi/com/sun/star/graphic/XPdfDecomposer.idl
@@ -19,6 +19,8 @@ interface XPrimitive2D;
 /** XPdfDecomposer interface
 
 This renders a PDF data into a bitmap and returns it as a primitive.
+
+@since LibreOffice 7.0
  */
 interface XPdfDecomposer : ::com::sun::star::uno::XInterface
 {
@@ -31,8 +33,6 @@ interface XPdfDecomposer : ::com::sun::star::uno::XInterface
 Parameters for decomposition. Parameters include:
 
 sal_Int32 Page - which page to use
-
-@since LibreOffice 7.0
  */
 sequence getDecomposition([in] sequence xPdfData,
 [in] 
sequence xDecompositionParameters);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sw/qa sw/source writerfilter/source

[Justin Luth (via logerrit)]

 sw/qa/extras/ooxmlexport/ooxmlexport10.cxx   |7 +-
 sw/qa/extras/ooxmlexport/ooxmlexport5.cxx|5 +
 sw/source/filter/ww8/docxattributeoutput.cxx |7 +-
 sw/source/filter/ww8/docxexport.cxx  |   48 +++
 writerfilter/source/dmapper/DomainMapperTableHandler.cxx |3 
 5 files changed, 65 insertions(+), 5 deletions(-)

New commits:
commit f25985c55541cbbc9a4fc79e660592d3d0485196
Author: Justin Luth 
AuthorDate: Fri Mar 13 07:14:29 2020 +0300
Commit: Miklos Vajna 
CommitDate: Wed Mar 18 09:29:03 2020 +0100

tdf#131304 .docx: flag new files as MS Word 2019 native mode

compatibilityMode = 15: [Word 2013/2016/2019]

Up till now, documents that were exported into the docx format
were treated by default as native Word 2007 format,
since no compatibilityMode setting was provided.

(Don't worry, we still round-trip existing older values.
This patch only affects non-docx >>= .docx export.)

Ultimately, this change is for the benefit of MS Word.
It has no practical effect for LO.

NOTE: This patch depends on previous
commit 53f099c842d39266a0b4786a1af3db5628746634
which sets an appropriate value for existing .docx files.

This scary change shouldn't actually be all that scary,
since we already round-trip native 2019 files,
without any complaint from Word or our users.

The biggest change is that Word 2010 users might not be able
to open NEW files perfectly. But Microsoft has already been doing
that to them since 2013. By the time LO 7.0 hits stable version,
it will have been months since 2010 has reached end-of-life.
The vast majority of documents will still open perfectly for them.
Plus, if a Word 2010 user does modify our new document,
we will drop back down to their level.

A nice, clear explanation of what compatibilityMode does is at
howtogeek.com/256269/what-is-compatibility-mode-in-microsoft-office/

The MAIN CHANGE is that MS WORD has been DE-ACTIVATING features
when it notices that it is SHARING the document with
OLD_VERSION users. So Word is limiting what it will do
for the BENEFIT OF THE OTHER USER while collaborating.

There are a few instances where layout is affected by
compatiblityMode. For example, tdf#123116 wants compat=15
so that Word will nicely layout an oversized table-row.
tdf#131121 wants it too.
By changing to compat=15, we can help Word take advantage
of some fixes since docx 1.0, and avoid having to write
new logic to export to old formats as well as new.

Unfortunately, documentation on what layout changes are expected
has not been identified yet. But in 7 years we should have
run into most of them already... well maybe no.

Change-Id: I1ce016618a680b9842fa6828c9e87cc6b677a557
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90455
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport10.cxx 
b/sw/qa/extras/ooxmlexport/ooxmlexport10.cxx
index 1979a5180ec3..1057ab93485c 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport10.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport10.cxx
@@ -1194,13 +1194,14 @@ DECLARE_OOXMLEXPORT_TEST(testTableMarginAdjustment, 
"table.fodt")
 auto const xTable(getParagraphOrTable(1));
 CPPUNIT_ASSERT_EQUAL(sal_Int32(0), getProperty(xTable, 
"LeftMargin"));
 
-// currently no compatibilityMode is generated, it's only round-tripped if
-// it exists in the input; if it doesn't exist, the default is "12" (old)
+// Now that compatibilityMode is set to 2013's 15 (new), expect the new 
values,
+// since LO is exporting in the NEW way now instead of the OLD way.
+// This was 55 when using 2007's compatibilityMode of 12 (old)
 
 xmlDocPtr pXmlDoc = parseExport("word/document.xml");
 
 assertXPath(pXmlDoc, "//w:tbl[1]/w:tblPr[1]/w:tblInd[1]", "type", "dxa");
-assertXPath(pXmlDoc, "//w:tbl[1]/w:tblPr[1]/w:tblInd[1]", "w", "55");
+assertXPath(pXmlDoc, "//w:tbl[1]/w:tblPr[1]/w:tblInd[1]", "w", "0");
 }
 
 DECLARE_OOXMLEXPORT_TEST( testTableCellMargin, "table-cell-margin.docx" )
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport5.cxx 
b/sw/qa/extras/ooxmlexport/ooxmlexport5.cxx
index 8615ee121f01..2ba06ce0982e 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport5.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport5.cxx
@@ -1026,6 +1026,11 @@ DECLARE_OOXMLEXPORT_TEST(tdf106843, "tdf106843.fodt")
 {
 assertXPath(pXmlSettings, "/w:settings/w:documentProtection", "edit",  
 "trackedChanges");
 assertXPath(pXmlSettings, "/w:settings/w:documentProtection", 
"enforcement","1");
+
+// LO intends to export a .docx format that is natively compatible 
with 2013.
+assertXPath(pXmlSettings, "/w:settings/w:compat/w:compatSetting[1]", 
"name", 

[Libreoffice-commits] online.git: loleaflet/css

[Tor Lillqvist (via logerrit)]

 loleaflet/css/loleaflet.css |   16 
 1 file changed, 8 insertions(+), 8 deletions(-)

New commits:
commit d817fe994959226c48eec5e1e8c3e6fcbd7a45e9
Author: Tor Lillqvist 
AuthorDate: Tue Mar 17 23:27:05 2020 +0200
Commit: Tor Lillqvist 
CommitDate: Wed Mar 18 09:39:19 2020 +0100

Make contents of portrait and landscape media query blocks be in same order

This makes it easier to compare them.

Change-Id: If25f4c4dd3ee8a2a9d88d21521df6308857703a5
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90674
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Tor Lillqvist 

diff --git a/loleaflet/css/loleaflet.css b/loleaflet/css/loleaflet.css
index 1691794d1..e43ddbaf9 100644
--- a/loleaflet/css/loleaflet.css
+++ b/loleaflet/css/loleaflet.css
@@ -327,26 +327,26 @@ body {
}
 }
 @media (max-width: 767px) and (orientation: landscape), (max-device-height: 
767px) and (orientation: landscape) {
-   #document-container.parts-preview-document {
-   left: 66px !important;
+   #presentation-controls-wrapper {
+   top: 41px;
bottom: 33px;
}
 
-   #document-container.readonly.parts-preview-document {
+   #presentation-controls-wrapper.readonly {
top: 41px;
bottom: 0px;
-   width: initial;
+   max-width: 120px;
}
 
-   #presentation-controls-wrapper {
-   top: 41px;
+   #document-container.parts-preview-document {
+   left: 66px !important;
bottom: 33px;
}
 
-   #presentation-controls-wrapper.readonly {
+   #document-container.readonly.parts-preview-document {
top: 41px;
bottom: 0px;
-   max-width: 120px;
+   width: initial;
}
 
#document-container.parts-preview-document.keyboard {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: connectivity/source dbaccess/source include/connectivity vcl/inc vcl/osx vcl/source

[Noel Grandin (via logerrit)]

 connectivity/source/commontools/TSortIndex.cxx   |4 
 connectivity/source/commontools/dbtools.cxx  |   12 
 connectivity/source/drivers/calc/CTable.cxx  |   18 -
 connectivity/source/drivers/component/CColumns.cxx   |4 
 connectivity/source/drivers/component/CResultSet.cxx |2 
 connectivity/source/drivers/component/CTable.cxx |2 
 connectivity/source/drivers/dbase/DColumns.cxx   |4 
 connectivity/source/drivers/dbase/DIndex.cxx |2 
 connectivity/source/drivers/dbase/DIndexColumns.cxx  |4 
 connectivity/source/drivers/dbase/DResultSet.cxx |4 
 connectivity/source/drivers/dbase/DTable.cxx |   86 +++---
 connectivity/source/drivers/evoab2/NResultSetMetaData.cxx|2 
 connectivity/source/drivers/file/FNoException.cxx|6 
 connectivity/source/drivers/file/FPreparedStatement.cxx  |   58 ++--
 connectivity/source/drivers/file/FResultSet.cxx  |  156 +--
 connectivity/source/drivers/file/FResultSetMetaData.cxx  |   24 -
 connectivity/source/drivers/file/FStatement.cxx  |   44 +--
 connectivity/source/drivers/file/fanalyzer.cxx   |2 
 connectivity/source/drivers/file/fcode.cxx   |   12 
 connectivity/source/drivers/flat/EColumns.cxx|4 
 connectivity/source/drivers/flat/EResultSet.cxx  |2 
 connectivity/source/drivers/flat/ETable.cxx  |   44 +--
 connectivity/source/drivers/macab/MacabPreparedStatement.cxx |   14 
 connectivity/source/drivers/macab/MacabResultSetMetaData.cxx |2 
 connectivity/source/drivers/mork/MPreparedStatement.cxx  |   14 
 connectivity/source/drivers/mork/MResultSet.cxx  |   86 +++---
 connectivity/source/drivers/mork/MResultSetMetaData.cxx  |   20 -
 connectivity/source/drivers/mork/MStatement.cxx  |6 
 connectivity/source/drivers/writer/WTable.cxx|   22 -
 connectivity/source/inc/file/FResultSet.hxx  |6 
 connectivity/source/parse/PColumn.cxx|4 
 connectivity/source/parse/sqliterator.cxx|   62 ++--
 dbaccess/source/core/api/BookmarkSet.cxx |   12 
 dbaccess/source/core/api/CRowSetDataColumn.cxx   |4 
 dbaccess/source/core/api/CacheSet.cxx|   22 -
 dbaccess/source/core/api/HelperCollections.cxx   |   12 
 dbaccess/source/core/api/KeySet.cxx  |   90 +++---
 dbaccess/source/core/api/OptimisticSet.cxx   |   20 -
 dbaccess/source/core/api/RowSet.cxx  |   58 ++--
 dbaccess/source/core/api/RowSetBase.cxx  |   10 
 dbaccess/source/core/api/RowSetCache.cxx |   42 +-
 dbaccess/source/core/api/SingleSelectQueryComposer.cxx   |   38 +-
 dbaccess/source/core/api/StaticSet.cxx   |   12 
 dbaccess/source/core/api/WrappedResultSet.cxx|   12 
 include/connectivity/CommonTools.hxx |   27 -
 include/connectivity/FValue.hxx  |4 
 vcl/inc/osx/salframe.h   |2 
 vcl/inc/salframe.hxx |4 
 vcl/osx/salframe.cxx |9 
 vcl/source/window/dialog.cxx |3 
 50 files changed, 561 insertions(+), 552 deletions(-)

New commits:
commit e5230535877e30c3b874495e8794faa3a42d8017
Author: Noel Grandin 
AuthorDate: Tue Mar 17 21:34:21 2020 +0200
Commit: Noel Grandin 
CommitDate: Wed Mar 18 09:49:50 2020 +0100

simplify ORefVector code

by making it extend std::vector - it wants to be a ref-counted vector,
so let it be, and we can simplify the usage sites

Change-Id: I93ff6ee1522da965e16223dca171401d36fd67b7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90664
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/connectivity/source/commontools/TSortIndex.cxx 
b/connectivity/source/commontools/TSortIndex.cxx
index 76bbafaeb13a..6b94216a3719 100644
--- a/connectivity/source/commontools/TSortIndex.cxx
+++ b/connectivity/source/commontools/TSortIndex.cxx
@@ -85,10 +85,10 @@ struct TKeyValueFunc
 Freeze();
 
 ::rtl::Reference pKeySet = new OKeySet();
-pKeySet->get().reserve(m_aKeyValues.size());
+pKeySet->reserve(m_aKeyValues.size());
 std::transform(m_aKeyValues.begin()
 ,m_aKeyValues.end()
-,std::back_inserter(pKeySet->get())
+,std::back_inserter(*pKeySet)
 ,::o3tl::select1st());
 pKeySet->setFrozen();
 return pKeySet;
diff --git a/connectivity/source/commontools/dbtools.cxx 
b/connectivity/source/commontools/dbtools.cxx

[Libreoffice-commits] online.git: cypress_test/integration_tests

[Ashod Nakashian (via logerrit)]

 cypress_test/integration_tests/mobile/calc/apply_font_spec.js  
 |2 -
 cypress_test/integration_tests/mobile/calc/calc_helper.js  
 |8 -
 cypress_test/integration_tests/mobile/calc/focus_spec.js   
 |4 +-
 cypress_test/integration_tests/mobile/calc/insertion_wizard_spec.js
 |2 -
 cypress_test/integration_tests/mobile/writer/apply_font_spec.js
 |2 -
 
cypress_test/integration_tests/mobile/writer/apply_paragraph_properties_spec.js 
|2 -
 cypress_test/integration_tests/mobile/writer/bottom_toolbar_spec.js
 |2 -
 cypress_test/integration_tests/mobile/writer/focus_spec.js 
 |   16 +-
 cypress_test/integration_tests/mobile/writer/insert_field_spec.js  
 |2 -
 cypress_test/integration_tests/mobile/writer/insert_formatting_mark_spec.js
 |2 -
 cypress_test/integration_tests/mobile/writer/insert_object_spec.js 
 |2 -
 cypress_test/integration_tests/mobile/writer/mobile_wizard_state_spec.js   
 |6 +--
 cypress_test/integration_tests/mobile/writer/shape_properties_spec.js  
 |2 -
 cypress_test/integration_tests/mobile/writer/spellchecking_spec.js 
 |2 -
 cypress_test/integration_tests/mobile/writer/table_properties_spec.js  
 |2 -
 cypress_test/integration_tests/mobile/writer/toolbar_spec.js   
 |   16 +-
 16 files changed, 33 insertions(+), 39 deletions(-)

New commits:
commit 4ff5406701fa30b264b23d687c7b83e80e1781d5
Author: Ashod Nakashian 
AuthorDate: Mon Mar 16 14:58:32 2020 -0400
Commit: Tamás Zolnai 
CommitDate: Wed Mar 18 10:14:31 2020 +0100

cypress: reuse helper to enable editing in tests

Change-Id: I9565376bf3e34c2d95a14a5411cee732a77f9f0a
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90647
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Tamás Zolnai 

diff --git a/cypress_test/integration_tests/mobile/calc/apply_font_spec.js 
b/cypress_test/integration_tests/mobile/calc/apply_font_spec.js
index 01ddbf8a6..2a669f70a 100644
--- a/cypress_test/integration_tests/mobile/calc/apply_font_spec.js
+++ b/cypress_test/integration_tests/mobile/calc/apply_font_spec.js
@@ -8,7 +8,7 @@ describe('Apply font changes.', function() {
helper.beforeAllMobile('apply_font.ods', 'calc');
 
// Click on edit button
-   cy.get('#mobile-edit-button').click();
+   helper.enableEditingMobile();
 
// Button should be enabled now
cy.get('#tb_actionbar_item_mobile_wizard')
diff --git a/cypress_test/integration_tests/mobile/calc/calc_helper.js 
b/cypress_test/integration_tests/mobile/calc/calc_helper.js
index 2b9ee7c04..5a796cc4d 100644
--- a/cypress_test/integration_tests/mobile/calc/calc_helper.js
+++ b/cypress_test/integration_tests/mobile/calc/calc_helper.js
@@ -4,13 +4,7 @@ var helper = require('../../common/helper');
 
 function clickOnFirstCell() {
// Enable editing if it's in read-only mode
-   cy.get('#mobile-edit-button')
-   .then(function(button) {
-   if (button.css('display') !== 'none') {
-   cy.get('#mobile-edit-button')
-   .click();
-   }
-   });
+   helper.enableEditingMobile();
 
// Use the tile's edge to find the first cell's position
cy.get('.leaflet-tile-container')
diff --git a/cypress_test/integration_tests/mobile/calc/focus_spec.js 
b/cypress_test/integration_tests/mobile/calc/focus_spec.js
index 49668d5ce..2c23bc1a5 100644
--- a/cypress_test/integration_tests/mobile/calc/focus_spec.js
+++ b/cypress_test/integration_tests/mobile/calc/focus_spec.js
@@ -14,7 +14,7 @@ describe('Calc focus tests', function() {
 
it('Basic document focus.', function() {
// Click on edit button
-   cy.get('#mobile-edit-button').click();
+   helper.enableEditingMobile();
 
cy.get('#tb_actionbar_item_mobile_wizard')
.should('not.have.class', 'disabled');
@@ -50,7 +50,7 @@ describe('Calc focus tests', function() {
 
it.skip('Focus on second tap.', function() {
// Click on edit button
-   cy.get('#mobile-edit-button').click();
+   helper.enableEditingMobile();
 
cy.get('#tb_actionbar_item_mobile_wizard')
.should('not.have.class', 'disabled');
diff --git 
a/cypress_test/integration_tests/mobile/calc/insertion_wizard_spec.js 
b/cypress_test/integration_tests/mobile/calc/insertion_wizard_spec.js
index c94471133..1b5d1637a 100644
--- a/cypress_test/integration_tests/mobile/calc/insertion_wizard_spec.js
+++ b/cypress_test/integration_tests/mobile/calc/insertion_wizard_spec.js
@@ -8,7 +8,7 @@ describe('Calc insertion 

[Libreoffice-commits] online.git: cypress_test/integration_tests

[Ashod Nakashian (via logerrit)]

 cypress_test/integration_tests/common/helper.js   |6 ++-
 cypress_test/integration_tests/common/impress.js  |4 ++
 cypress_test/integration_tests/mobile/writer/writer_helper.js |   20 +-
 3 files changed, 12 insertions(+), 18 deletions(-)

New commits:
commit 6e70407ba1a24c8a83b466d4556dea37317ac502
Author: Ashod Nakashian 
AuthorDate: Mon Mar 16 16:27:00 2020 -0400
Commit: Tamás Zolnai 
CommitDate: Wed Mar 18 10:14:53 2020 +0100

cypress: reuse select-all helper

Change-Id: I96a695dd96c07ab977ea0814117c642923e2f4db
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90648
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Tamás Zolnai 

diff --git a/cypress_test/integration_tests/common/helper.js 
b/cypress_test/integration_tests/common/helper.js
index 849b71cab..664e5f202 100644
--- a/cypress_test/integration_tests/common/helper.js
+++ b/cypress_test/integration_tests/common/helper.js
@@ -94,8 +94,12 @@ function selectAllText() {
 
cy.log('Select all text');
 
+   // Trigger select all
cy.get('textarea.clipboard')
-   .type('{ctrl}a').wait(300);
+   .type('{ctrl}a');
+
+   cy.get('.leaflet-marker-icon')
+   .should('exist');
 }
 
 // Clear all text by selecting all and deleting.
diff --git a/cypress_test/integration_tests/common/impress.js 
b/cypress_test/integration_tests/common/impress.js
index d6463fafc..6e1e59c55 100644
--- a/cypress_test/integration_tests/common/impress.js
+++ b/cypress_test/integration_tests/common/impress.js
@@ -54,6 +54,10 @@ function typeTextAndVerify(text, expected) {
 
helper.selectAllText();
 
+   //FIXME: Should retry the next check instead of
+   // an unreliable sleep, but for now this will do.
+   cy.wait(600);
+
helper.expectTextForClipboard(expected);
 }
 
diff --git a/cypress_test/integration_tests/mobile/writer/writer_helper.js 
b/cypress_test/integration_tests/mobile/writer/writer_helper.js
index a80d1e89c..e9e9ef59b 100644
--- a/cypress_test/integration_tests/mobile/writer/writer_helper.js
+++ b/cypress_test/integration_tests/mobile/writer/writer_helper.js
@@ -96,26 +96,12 @@ function clearMobileWizardState() {
 
 function selectAllMobile() {
// Remove selection if exist
+   //FIXME: this also gives the focus to the Writer doc,
+   // which shouldn't be needed (i.e. should have focus already).
cy.get('#document-container')
.type('{downarrow}');
-   cy.get('.leaflet-marker-icon')
-   .should('not.exist');
 
-   // Enable editing if it's in read-only mode
-   cy.get('#mobile-edit-button')
-   .then(function(button) {
-   if (button.css('display') !== 'none') {
-   cy.get('#mobile-edit-button')
-   .click();
-   }
-   });
-
-   // Trigger select all
-   cy.get('textarea.clipboard')
-   .type('{ctrl}a');
-
-   cy.get('.leaflet-marker-icon')
-   .should('exist');
+   helper.selectAllText();
 }
 
 module.exports.copyTextToClipboard = copyTextToClipboard;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: svx/source

[Caolán McNamara (via logerrit)]

 svx/source/tbxctrls/tbcontrl.cxx |7 ++-
 1 file changed, 6 insertions(+), 1 deletion(-)

New commits:
commit f493cd83fbb2e572cf3d85aaf57fb202d763756d
Author: Caolán McNamara 
AuthorDate: Tue Mar 17 20:25:13 2020 +
Commit: Caolán McNamara 
CommitDate: Wed Mar 18 10:12:06 2020 +0100

tdf#131389 crash clearing cell bg from sidebar

Change-Id: Id246c176bf44f2eb2d2e135400974c437f583a7f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90669
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/svx/source/tbxctrls/tbcontrl.cxx b/svx/source/tbxctrls/tbcontrl.cxx
index b2781adf59fb..38d5574b745a 100644
--- a/svx/source/tbxctrls/tbcontrl.cxx
+++ b/svx/source/tbxctrls/tbcontrl.cxx
@@ -2069,9 +2069,14 @@ IMPL_LINK(ColorWindow, AutoColorClickHdl, weld::Button&, 
rButton, void)
 
 maSelectedLink.Call(aNamedColor);
 
-maColorSelectFunction(maCommand, aNamedColor);
+// deliberate take a copy here in case maMenuButton.set_inactive
+// triggers a callback that destroys ourself
+ColorSelectFunction aColorSelectFunction(maColorSelectFunction);
+OUString sCommand(maCommand);
 
 maMenuButton.set_inactive();
+
+aColorSelectFunction(sCommand, aNamedColor);
 }
 
 IMPL_LINK_NOARG(SvxColorWindow, OpenPickerClickHdl, Button*, void)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: LIBRASOffice - Vídeo - Solve MIT 2019

[Ilmari Lauhakangas]

I will include a message from Jan-Marek, who is unable to use mail 
currently. He wants to point out that tooltips can be accessed via 
accessibility APIs at least on Linux.


Ilmari

Jan-Marek says:

It took me about 15m to write a python at spi program, which will react 
to tooltip events on Linux:


#!/usr/bin/python3

import pyatspi

def f(e):
if not e.source or e.source.getRole() != pyatspi.ROLE_TOOL_TIP:
return
# e.detail1 = 1: show / = 0: hide
print(e)

pyatspi.Registry.registerEventListener(f, "object:state-changed:visible")
pyatspi.Registry.start()

Just install the python3-pyatspi package of your preferred distro and 
start the little program.


This is obviously just a very minimal POC, but it can be easily extended 
to just filter events from LO.


If I read 
https://wiki.gnome.org/Accessibility/Documentation/GNOME2/AtkGuide/MSAA 
correctly, MSAA also has show events for tooltips.


Miguel Teixeira kirjoitti 17.3.2020 klo 18.26:



-- Forwarded message -
De: *Miguel Teixeira* >

Date: seg., 16 de mar. de 2020 às 10:59
Subject: Re: LIBRASOffice - Vídeo - Solve MIT 2019
To: Olivier Hallot >
Cc: Ilmari Lauhakangas >, Daniel Silva 
mailto:daniel.l...@poli.ufrj.br>>, Lidiana 
Souza dos Anjos >, Fernando Gonçalves Severo 
mailto:sev...@cos.ufrj.br>>, Henrique Luiz 
Cukierman mailto:hcuk...@cos.ufrj.br>>, Pedro 
Braga mailto:pedrohcbu...@gmail.com>>



Hi,

*
*

I apologize forthe delay in answering.

Current assistive technologies favor better accessibility for the blind 
people. There is no such thing as a "Braille language" or "Braille 
culture". A blind person does not need to communicate through a 
"different language" or adapt to a new language that depends directly on 
a sense that he does not have and a diferent culture. Before they learn 
to write, children, in general, learn to speak. For example, a blind 
person can learn to speak a language just as children learn by listening 
to other people speak. A deaf person often learns to communicate through 
a language only after older ages (for example, many deaf people in 
Brazil only learn LIBRAS after the age of 18). In the case of deaf 
people, there is a different language and culture. A simple literal 
translation of textual elements of the interface may not be such an 
interesting idea (but in some cases it can be useful). Here, there is an 
issue where, a simple adaptation of something that already exists (like 
the current accessibility APIs) can serve as a "quick fix", but that 
does not mean that it is the best option.


*
*

I attached a PDF file talking a little more about this subject.

*
*

*
*

Best regards,


Miguel.


Em sex., 13 de mar. de 2020 às 12:54, Olivier Hallot 
mailto:olivier.hal...@libreoffice.org>> 
escreveu:


Olá Miguel

It is fundamental to clarify why the current assistive technologies are
unable to address the issue of the deafs. It has been asked in IRC and
the response has not been seen. The project will be analyzed by
knowledgeable people.

Ilmari is in copy, please switch to English and keep Ilmarin the loop.
Professor Henrique Cukierman should also be in the loop.

Kind regards

Olivier

Em 12/03/2020 16:27, Miguel Teixeira escreveu:
 > Olá Olivier,
 >
 > Estamos animados com a sua mensagem. Vamos preparar um dossier para
 > financiamento do LIBRASOffice assim como fizemos para o MIT.
 > Vamos aproveitar boa parte do que fizemos para o MIT, mas mesmo
assim,
 > não conseguiremos te entregar até o dia de hoje ou amanhã. Dou
previsão
 > para entrega do dossier até a próxima quarta-feira, mas pode ser
que já
 > esteja pronto, por exemplo, no próximo domingo. Existe algum
problema em
 > entregarmos na próxima quarta-feira?
 >
 > Cordialmente,
 > Miguel Teixeira.
 >
 >
 > Em qui., 12 de mar. de 2020 às 07:00, Olivier Hallot
 > mailto:olivier.hal...@libreoffice.org>
>>
 > escreveu:
 >
 >     Olá Miguel
 >
 >     Vocês tem condições de preparar um dossier para financiamento do
 >     LibrasOffice, assim como fizeram para o MIT? Trocaria  MIT
por TDF (The
 >     Document Foundation).
 >
 >     Creio que pode haver um caminho de financiamento a ser
explorado, e a
 >     experiencia do MIT pode ajudar a convencer.
 >
 >     Será importante ter um cronograma de entregas, e programa de
desembolso,
 >     tamanho de equipe, bolsas e tudo mais. Vejo um horizonte de
seis meses
 >     de atividades para duas pessoas.
 >
 >     OK?
 >     Olivier
 >
 >
 >
 >
 >     Em 11/03/2020 20:43, Miguel Teixeira escreveu:
 >     > Olá 

[Libreoffice-commits] core.git: 2 commits - external/skia RepositoryExternal.mk solenv/clang-format vcl/inc vcl/Library_vcl.mk vcl/Library_vclplug_gen.mk vcl/skia vcl/unx

[Luboš Luňák (via logerrit)]

 RepositoryExternal.mk  |1 
 external/skia/UnpackedTarball_skia.mk  |1 
 external/skia/fontconfig-get-typeface.patch.0  |   32 +++
 solenv/clang-format/blacklist  |2 
 vcl/Library_vcl.mk |4 
 vcl/Library_vclplug_gen.mk |9 
 vcl/inc/skia/gdiimpl.hxx   |3 
 vcl/inc/skia/x11/textrender.hxx|   40 +++
 vcl/inc/unx/cairotextrender.hxx|   42 
 vcl/inc/unx/fc_fontoptions.hxx |2 
 vcl/inc/unx/freetypetextrender.hxx |   72 +++
 vcl/inc/unx/glyphcache.hxx |4 
 vcl/skia/gdiimpl.cxx   |   44 
 vcl/skia/x11/textrender.cxx|   79 +++
 vcl/unx/generic/gdi/cairotextrender.cxx|  250 
 vcl/unx/generic/gdi/freetypetextrender.cxx |  251 +
 vcl/unx/generic/gdi/salgdi.cxx |5 
 vcl/unx/generic/glyphs/freetype_glyphcache.cxx |   18 +
 18 files changed, 566 insertions(+), 293 deletions(-)

New commits:
commit 076926cef97c685b3d9221510e7560c034ebd2ed
Author: Luboš Luňák 
AuthorDate: Tue Mar 10 12:43:45 2020 +0100
Commit: Luboš Luňák 
CommitDate: Wed Mar 18 10:47:49 2020 +0100

implement text rendering using directly Skia (X11)

The Cairo-based way reuses code that is used for OpenGL, but it's
needlessly complicated, given that Skia itself is capable of text
rendering as well.
This requires a small patch for Skia so that it uses the FcPattern*
we use for selecting a font.
The rendering with this commit is usable, but visually the result
is noticeably different, so this will need tweaks to the font
rendering (TBD).

Change-Id: I058c282307106c929ccc9faa7b2bddfabf0f0a2c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90580
Tested-by: Jenkins
Reviewed-by: Luboš Luňák 

diff --git a/RepositoryExternal.mk b/RepositoryExternal.mk
index a0de7e340de8..7079e9bcf61b 100644
--- a/RepositoryExternal.mk
+++ b/RepositoryExternal.mk
@@ -127,6 +127,7 @@ $(call gb_LinkTarget_set_include,$(1),\
-I$(call gb_UnpackedTarball_get_dir,skia)/include/effects \
-I$(call gb_UnpackedTarball_get_dir,skia)/include/gpu \
-I$(call gb_UnpackedTarball_get_dir,skia)/include/config \
+   -I$(call gb_UnpackedTarball_get_dir,skia)/include/ports \
-I$(call gb_UnpackedTarball_get_dir,skia)/include/third_party/vulkan \
-I$(call gb_UnpackedTarball_get_dir,skia)/tools/gpu \
-I$(call gb_UnpackedTarball_get_dir,skia) \
diff --git a/external/skia/UnpackedTarball_skia.mk 
b/external/skia/UnpackedTarball_skia.mk
index 33fcf05b6a81..6ffde2006590 100644
--- a/external/skia/UnpackedTarball_skia.mk
+++ b/external/skia/UnpackedTarball_skia.mk
@@ -27,6 +27,7 @@ skia_patches := \
 fix-gcc-x86.patch.1\
 msvc-vectorcall-sse.patch.1 \
 clang11-flax-vector-conversion.patch.0 \
+fontconfig-get-typeface.patch.0 \
 
 $(eval $(call gb_UnpackedTarball_set_patchlevel,skia,1))
 
diff --git a/external/skia/fontconfig-get-typeface.patch.0 
b/external/skia/fontconfig-get-typeface.patch.0
new file mode 100644
index ..a7a82bfa07f4
--- /dev/null
+++ b/external/skia/fontconfig-get-typeface.patch.0
@@ -0,0 +1,32 @@
+--- ./src/ports/SkFontMgr_fontconfig.cpp.sav   2020-01-20 16:42:51.322186451 
+0100
 ./src/ports/SkFontMgr_fontconfig.cpp   2020-03-13 11:25:15.793936659 
+0100
+@@ -699,6 +699,7 @@ class SkFontMgr_fontconfig : public SkFo
+ /** Creates a typeface using a typeface cache.
+  *  @param pattern a complete pattern from FcFontRenderPrepare.
+  */
++public:
+ sk_sp createTypefaceFromFcPattern(FcPattern* pattern) const {
+ FCLocker::AssertHeld();
+ SkAutoMutexExclusive ama(fTFCacheMutex);
+@@ -1039,3 +1040,9 @@ protected:
+ SK_API sk_sp SkFontMgr_New_FontConfig(FcConfig* fc) {
+ return sk_make_sp(fc);
+ }
++
++SK_API sk_sp SkFontMgr_createTypefaceFromFcPattern(const 
sk_sp& mgr, FcPattern* pattern)
++{
++FCLocker lock;
++return 
static_cast(mgr.get())->createTypefaceFromFcPattern(pattern);
++}
+--- ./include/ports/SkFontMgr_fontconfig.h.sav 2019-09-19 11:38:00.943185323 
+0200
 ./include/ports/SkFontMgr_fontconfig.h 2020-03-13 11:31:48.025716543 
+0100
+@@ -19,4 +19,9 @@ class SkFontMgr;
+  */
+ SK_API sk_sp SkFontMgr_New_FontConfig(FcConfig* fc);
+ 
++struct _FcPattern;
++typedef struct _FcPattern FcPattern;
++class SkTypeface;
++SK_API sk_sp SkFontMgr_createTypefaceFromFcPattern(const 
sk_sp& mgr, FcPattern* pattern);
++
+ #endif // #ifndef SkFontMgr_fontconfig_DEFINED
diff --git a/vcl/Library_vcl.mk b/vcl/Library_vcl.mk
index 9becb8efc977..39d99957883e 100644
--- a/vcl/Library_vcl.mk
+++ b/vcl/Library_vcl.mk
@@ -599,7 +599,8 @@ $(eval $(call gb_Library_add_exception_objects,vcl,\
 vcl/skia/packedsurfaceatlas \

[Libreoffice-commits] core.git: external/skia vcl/inc vcl/skia vcl/win

[Luboš Luňák (via logerrit)]

 external/skia/UnpackedTarball_skia.mk|1 
 external/skia/windows-hfont-typeface.patch.0 |  134 +++
 vcl/inc/skia/win/gdiimpl.hxx |3 
 vcl/inc/win/wingdiimpl.hxx   |3 
 vcl/skia/win/gdiimpl.cxx |   55 +++
 vcl/win/gdi/winlayout.cxx|6 -
 6 files changed, 200 insertions(+), 2 deletions(-)

New commits:
commit 271e8c99a2a1e28b7eb9fdc5fe16f8be1e8ee763
Author: Luboš Luňák 
AuthorDate: Mon Mar 16 15:08:11 2020 +0100
Commit: Luboš Luňák 
CommitDate: Wed Mar 18 10:48:19 2020 +0100

implement text rendering using directly Skia (Windows)

The Windows code needed for Skia text rendering. Like with the X11
code, the font is slightly lighter than with Skia disabled, but
otherwise it seems to work.
And like the X11 code this also requires patching Skia to use
the font we want.

Change-Id: Ib5ba52e4ba51b6523617072b77ed5446e7343f46
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90582
Tested-by: Jenkins
Reviewed-by: Luboš Luňák 

diff --git a/external/skia/UnpackedTarball_skia.mk 
b/external/skia/UnpackedTarball_skia.mk
index 6ffde2006590..42276177ab33 100644
--- a/external/skia/UnpackedTarball_skia.mk
+++ b/external/skia/UnpackedTarball_skia.mk
@@ -28,6 +28,7 @@ skia_patches := \
 msvc-vectorcall-sse.patch.1 \
 clang11-flax-vector-conversion.patch.0 \
 fontconfig-get-typeface.patch.0 \
+windows-hfont-typeface.patch.0 \
 
 $(eval $(call gb_UnpackedTarball_set_patchlevel,skia,1))
 
diff --git a/external/skia/windows-hfont-typeface.patch.0 
b/external/skia/windows-hfont-typeface.patch.0
new file mode 100644
index ..459595a7b3d6
--- /dev/null
+++ b/external/skia/windows-hfont-typeface.patch.0
@@ -0,0 +1,134 @@
+--- ./include/ports/SkTypeface_win.h.sav   2019-09-19 11:38:00.943185300 
+0200
 ./include/ports/SkTypeface_win.h   2020-03-16 15:11:38.347067100 +0100
+@@ -28,6 +28,8 @@
+  */
+ SK_API SkTypeface* SkCreateTypefaceFromLOGFONT(const LOGFONT&);
+ 
++SK_API SkTypeface* SkCreateTypefaceFromLOGFONT(const LOGFONT&, HFONT);
++
+ /**
+  *  Copy the LOGFONT associated with this typeface into the lf parameter. Note
+  *  that the lfHeight will need to be set afterwards, since the typeface does
+--- ./src/ports/SkFontHost_win.cpp.sav 2020-03-16 15:22:02.620518100 +0100
 ./src/ports/SkFontHost_win.cpp 2020-03-16 15:27:12.733594400 +0100
+@@ -215,6 +215,11 @@
+ , fFont(::CreateFontIndirect())
+ , fSavefont((HFONT)::SelectObject(fHdc, fFont))
+ { }
++explicit SkAutoHDC(const HFONT hf)
++: fHdc(::CreateCompatibleDC(nullptr))
++, fFont(nullptr)
++, fSavefont((HFONT)::SelectObject(fHdc, hf))
++{ }
+ ~SkAutoHDC() {
+ if (fHdc) {
+ ::SelectObject(fHdc, fSavefont);
+@@ -238,8 +243,22 @@
+ : SkTypeface(style, false)
+ , fLogFont(lf)
+ , fSerializeAsStream(serializeAsStream)
++, hFont(nullptr)
+ {
+ SkAutoHDC hdc(fLogFont);
++init(hdc, style, lf);
++}
++LogFontTypeface(const SkFontStyle& style, const LOGFONT& lf, HFONT hf, 
bool serializeAsStream)
++: SkTypeface(style, false)
++, fLogFont(lf)
++, fSerializeAsStream(serializeAsStream)
++, hFont(hf)
++{
++SkAutoHDC hdc(hFont);
++init(hdc, style, lf);
++}
++void init(SkAutoHDC& hdc, const SkFontStyle& style, const LOGFONT& lf)
++{
+ TEXTMETRIC textMetric;
+ if (0 == GetTextMetrics(hdc, )) {
+ call_ensure_accessible(lf);
+@@ -260,6 +279,7 @@
+ }
+ 
+ LOGFONT fLogFont;
++HFONT hFont;
+ bool fSerializeAsStream;
+ bool fCanBeLCD;
+ 
+@@ -267,6 +287,10 @@
+ return sk_sp(new LogFontTypeface(get_style(lf), lf, 
false));
+ }
+ 
++static sk_sp Make(const LOGFONT& lf, HFONT hf) {
++return sk_sp(new LogFontTypeface(get_style(lf), lf, 
hf, false));
++}
++
+ static void EnsureAccessible(const SkTypeface* face) {
+ call_ensure_accessible(static_cast(face)->fLogFont);
+ }
+@@ -348,7 +372,7 @@
+  */
+ SkTypeface* SkCreateTypefaceFromLOGFONT(const LOGFONT& origLF) {
+ LOGFONT lf = origLF;
+-make_canonical();
++//make_canonical();
+ sk_sp face = SkTypefaceCache::FindByProcAndRef(FindByLogFont, 
);
+ if (!face) {
+ face = LogFontTypeface::Make(lf);
+@@ -357,12 +381,33 @@
+ return face.release();
+ }
+ 
++static bool FindByLogFontAndHFont(SkTypeface* face, void* ctx) {
++LogFontTypeface* lface = static_cast(face);
++const std::pair* data = reinterpret_cast*>(ctx);
++const LOGFONT* lf = data->first;
++const HFONT hf = data->second;
++
++return !memcmp(>fLogFont, lf, sizeof(LOGFONT)) && lface->hFont == 
hf;
++}
++
++SkTypeface* SkCreateTypefaceFromLOGFONT(const LOGFONT& origLF, HFONT hFont) {
++LOGFONT lf = origLF;
++//make_canonical();
++  

[Libreoffice-commits] core.git: vcl/inc vcl/skia

[Luboš Luňák (via logerrit)]

 vcl/inc/skia/gdiimpl.hxx|   10 --
 vcl/skia/gdiimpl.cxx|   13 -
 vcl/skia/win/gdiimpl.cxx|3 ++-
 vcl/skia/x11/textrender.cxx |3 ++-
 4 files changed, 20 insertions(+), 9 deletions(-)

New commits:
commit 11847cc5fd22c9b98fd9c2cf1389eee6e404a4fb
Author: Luboš Luňák 
AuthorDate: Tue Mar 17 11:53:26 2020 +0100
Commit: Luboš Luňák 
CommitDate: Wed Mar 18 10:48:35 2020 +0100

fix glyph rotation for Skia text rendering on Windows

The makes the chart descriptions in tdf#114209 and e.g. Japanese
from the document from tdf#126169 be rotated correctly,

Change-Id: I09a739fea7629000f3f49e417531bc47ba99c68f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90610
Tested-by: Jenkins
Reviewed-by: Luboš Luňák 

diff --git a/vcl/inc/skia/gdiimpl.hxx b/vcl/inc/skia/gdiimpl.hxx
index a7de1cfc4872..630b7a138844 100644
--- a/vcl/inc/skia/gdiimpl.hxx
+++ b/vcl/inc/skia/gdiimpl.hxx
@@ -203,14 +203,20 @@ public:
 void drawBitmap(const SalTwoRect& rPosAry, const SkBitmap& aBitmap,
 SkBlendMode eBlendMode = SkBlendMode::kSrcOver);
 
-void drawGenericLayout(const GenericSalLayout& layout, Color textColor, 
const SkFont& font);
+enum class GlyphOrientation
+{
+Apply,
+Ignore
+};
+void drawGenericLayout(const GenericSalLayout& layout, Color textColor, 
const SkFont& font,
+   GlyphOrientation glyphOrientation);
 
 protected:
 // To be called before any drawing.
 void preDraw();
 // To be called after any drawing.
 void postDraw();
-// The canvas to drawn to. Will be diverted to a temporary for Xor mode.
+// The canvas to draw to. Will be diverted to a temporary for Xor mode.
 SkCanvas* getDrawCanvas() { return mXorMode ? getXorCanvas() : 
mSurface->getCanvas(); }
 
 virtual void createSurface();
diff --git a/vcl/skia/gdiimpl.cxx b/vcl/skia/gdiimpl.cxx
index 3bf0724de354..8ce3bf838872 100644
--- a/vcl/skia/gdiimpl.cxx
+++ b/vcl/skia/gdiimpl.cxx
@@ -1265,7 +1265,7 @@ static double toCos(int degree10th) { return 
SkScalarCos(toRadian(degree10th));
 static double toSin(int degree10th) { return 
SkScalarSin(toRadian(degree10th)); }
 
 void SkiaSalGraphicsImpl::drawGenericLayout(const GenericSalLayout& layout, 
Color textColor,
-const SkFont& font)
+const SkFont& font, 
GlyphOrientation glyphOrientation)
 {
 std::vector glyphIds;
 std::vector glyphForms;
@@ -1274,13 +1274,16 @@ void SkiaSalGraphicsImpl::drawGenericLayout(const 
GenericSalLayout& layout, Colo
 Point aPos;
 const GlyphItem* pGlyph;
 int nStart = 0;
-double orientationAngle = layout.GetOrientation(); // 10th of degree
 while (layout.GetNextGlyph(, aPos, nStart))
 {
 glyphIds.push_back(pGlyph->glyphId());
-double angle = orientationAngle;
-if (pGlyph->IsVertical())
-angle += 900; // 90 degree
+int angle = 0; // 10th of degree
+if (glyphOrientation == GlyphOrientation::Apply)
+{
+angle = layout.GetOrientation();
+if (pGlyph->IsVertical())
+angle += 900; // 90 degree
+}
 SkRSXform form = SkRSXform::Make(toCos(angle), toSin(angle), aPos.X(), 
aPos.Y());
 glyphForms.emplace_back(std::move(form));
 }
diff --git a/vcl/skia/win/gdiimpl.cxx b/vcl/skia/win/gdiimpl.cxx
index b7014ed33b48..0708c8ea633f 100644
--- a/vcl/skia/win/gdiimpl.cxx
+++ b/vcl/skia/win/gdiimpl.cxx
@@ -155,7 +155,8 @@ bool WinSkiaSalGraphicsImpl::DrawTextLayout(const 
GenericSalLayout& rLayout)
 SkiaSalGraphicsImpl* impl = 
static_cast(mWinParent.GetImpl());
 COLORREF color = ::GetTextColor(mWinParent.getHDC());
 Color salColor(GetRValue(color), GetGValue(color), GetBValue(color));
-impl->drawGenericLayout(rLayout, salColor, font);
+// The font already is set up to have glyphs rotated as needed.
+impl->drawGenericLayout(rLayout, salColor, font, 
SkiaSalGraphicsImpl::GlyphOrientation::Ignore);
 return true;
 }
 
diff --git a/vcl/skia/x11/textrender.cxx b/vcl/skia/x11/textrender.cxx
index 02911fcf5154..a980523476b3 100644
--- a/vcl/skia/x11/textrender.cxx
+++ b/vcl/skia/x11/textrender.cxx
@@ -59,7 +59,8 @@ void SkiaTextRender::DrawTextLayout(const GenericSalLayout& 
rLayout, const SalGr
 
 assert(dynamic_cast(rGraphics.GetImpl()));
 SkiaSalGraphicsImpl* impl = 
static_cast(rGraphics.GetImpl());
-impl->drawGenericLayout(rLayout, mnTextColor, font);
+impl->drawGenericLayout(rLayout, mnTextColor, font,
+SkiaSalGraphicsImpl::GlyphOrientation::Apply);
 }
 
 void SkiaTextRender::ClearDevFontCache() { fontManager.reset(); }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org

[Libreoffice-commits] core.git: vcl/win

[Luboš Luňák (via logerrit)]

 vcl/win/gdi/salfont.cxx |4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

New commits:
commit 2ff6fce634ff173b9eb8a703b7f2f265f6e3ecb1
Author: Luboš Luňák 
AuthorDate: Mon Mar 16 16:51:51 2020 +0100
Commit: Luboš Luňák 
CommitDate: Wed Mar 18 10:48:04 2020 +0100

use DEFAULT_QUALITY for font rendering with Skia on Windows

I don't know why tdf#98380 explicitly forced ANTIALIASED_QUALITY,
for OpenGL, but with Skia this breaks subpixel AA on LCDs,
where the actual value should be CLEARTYPE_QUALITY. But
DEFAULT_QUALITY simply seems to do the job no matter what.
Maybe the problem with OpenGL was that our code there handles
glyphs as monochrome, but Skia can handle colors, which is
necessary for subpixel AA.

Change-Id: Id7081b120f8e754deb4793423d157a8837e959aa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90581
Tested-by: Jenkins
Reviewed-by: Luboš Luňák 

diff --git a/vcl/win/gdi/salfont.cxx b/vcl/win/gdi/salfont.cxx
index 73c0bf7f2eb9..774178b683f8 100644
--- a/vcl/win/gdi/salfont.cxx
+++ b/vcl/win/gdi/salfont.cxx
@@ -796,9 +796,7 @@ void ImplGetLogFontFromFontSelect( HDC hDC,
 static BYTE nDefaultQuality = NONANTIALIASED_QUALITY;
 if (nDefaultQuality == NONANTIALIASED_QUALITY)
 {
-if (SkiaHelper::isVCLSkiaEnabled())
-nDefaultQuality = ANTIALIASED_QUALITY;
-else if (OpenGLWrapper::isVCLOpenGLEnabled())
+if (OpenGLWrapper::isVCLOpenGLEnabled())
 nDefaultQuality = ANTIALIASED_QUALITY;
 else
 nDefaultQuality = DEFAULT_QUALITY;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.2' - include/comphelper

[Tor Lillqvist (via logerrit)]

 include/comphelper/lok.hxx |5 +
 1 file changed, 5 insertions(+)

New commits:
commit 191d2349eeb2033ecd08e2aa293bb6413538e6c0
Author: Tor Lillqvist 
AuthorDate: Wed Mar 18 10:58:52 2020 +0200
Commit: Tor Lillqvist 
CommitDate: Wed Mar 18 11:02:52 2020 +0100

Clarify the WIP-ness of setMobilePhone() and setTablet() a bit

Change-Id: Iee8b773e23ebd3fbc1ba5bf2c56d644d0844cb2d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90682
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Tor Lillqvist 

diff --git a/include/comphelper/lok.hxx b/include/comphelper/lok.hxx
index d88ddfd1dfa5..43191db90ec0 100644
--- a/include/comphelper/lok.hxx
+++ b/include/comphelper/lok.hxx
@@ -29,6 +29,11 @@ namespace LibreOfficeKit
 
 COMPHELPER_DLLPUBLIC void setActive(bool bActive = true);
 
+// Note that currently it is undefined behaviour to call both setMobilePhone() 
and setTablet(). This
+// will be remedied in the future. For now, just make sure you call just 
either for a view, and just
+// once, with the bool parameter as true. In the future, this will probably be 
changed into using an
+// enum for the kind of the view, that can be DESKTOP, MOBILEPHONE, or TABLET.
+
 // Tell that LOK view is on a mobile phone (regardless what its pixel 
resolution is, whether its form factor is "phablet" or not)
 COMPHELPER_DLLPUBLIC void setMobilePhone(int nViewId, bool bIsMobilePhone);
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: i18npool/source sw/qa

[Miklos Vajna (via logerrit)]

 i18npool/source/defaultnumberingprovider/defaultnumberingprovider.cxx |1 
 sw/qa/extras/odfexport/data/arabic-zero3-numbering.odt|binary
 sw/qa/extras/odfexport/odfexport.cxx  |   13 
++
 3 files changed, 14 insertions(+)

New commits:
commit 086bfde59232076644995ae862cd43865419ad98
Author: Miklos Vajna 
AuthorDate: Wed Mar 18 10:18:42 2020 +0100
Commit: Miklos Vajna 
CommitDate: Wed Mar 18 11:06:55 2020 +0100

sw pad-to-3 numbering: add ODF filter

This makes the UI work as well.

Change-Id: I8d64b88e57ba3e4fd61afba892f0ee2267f1c8b2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90683
Reviewed-by: Miklos Vajna 
Tested-by: Jenkins

diff --git 
a/i18npool/source/defaultnumberingprovider/defaultnumberingprovider.cxx 
b/i18npool/source/defaultnumberingprovider/defaultnumberingprovider.cxx
index 86b64a3d23ad..9abb5ae5c051 100644
--- a/i18npool/source/defaultnumberingprovider/defaultnumberingprovider.cxx
+++ b/i18npool/source/defaultnumberingprovider/defaultnumberingprovider.cxx
@@ -1044,6 +1044,7 @@ static const Supported_NumberingType aSupportedTypes[] =
 {style::NumberingType::CHARS_GREEK_UPPER_LETTER,   C_GR_A ", " C_GR_B 
", ... (gr)", LANG_ALL},
 {style::NumberingType::CHARS_GREEK_LOWER_LETTER,   S_GR_A ", " S_GR_B 
", ... (gr)", LANG_ALL},
 {style::NumberingType::ARABIC_ZERO, "01, 02, 03, ...", LANG_ALL},
+{style::NumberingType::ARABIC_ZERO3, "001, 002, 003, ...", LANG_ALL},
 };
 static const sal_Int32 nSupported_NumberingTypes = 
SAL_N_ELEMENTS(aSupportedTypes);
 
diff --git a/sw/qa/extras/odfexport/data/arabic-zero3-numbering.odt 
b/sw/qa/extras/odfexport/data/arabic-zero3-numbering.odt
new file mode 100644
index ..0bdca270eece
Binary files /dev/null and 
b/sw/qa/extras/odfexport/data/arabic-zero3-numbering.odt differ
diff --git a/sw/qa/extras/odfexport/odfexport.cxx 
b/sw/qa/extras/odfexport/odfexport.cxx
index a89e916a2749..3c1403473515 100644
--- a/sw/qa/extras/odfexport/odfexport.cxx
+++ b/sw/qa/extras/odfexport/odfexport.cxx
@@ -2357,5 +2357,18 @@ DECLARE_ODFEXPORT_TEST(testArabicZeroNumbering, 
"arabic-zero-numbering.odt")
  aMap["NumberingType"].get());
 }
 
+DECLARE_ODFEXPORT_TEST(testArabicZero3Numbering, "arabic-zero3-numbering.odt")
+{
+auto xNumberingRules
+= 
getProperty>(getParagraph(1), 
"NumberingRules");
+comphelper::SequenceAsHashMap aMap(xNumberingRules->getByIndex(0));
+// Without the accompanying fix in place, this test would have failed with:
+// - Expected: 65
+// - Actual  : 4
+// i.e. numbering type was ARABIC, not ARABIC_ZERO3.
+
CPPUNIT_ASSERT_EQUAL(static_cast(style::NumberingType::ARABIC_ZERO3),
+ aMap["NumberingType"].get());
+}
+
 CPPUNIT_PLUGIN_IMPLEMENT();
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loleaflet/css

[Tor Lillqvist (via logerrit)]

 loleaflet/css/editor.css |2 ++
 1 file changed, 2 insertions(+)

New commits:
commit a47a09f471a65a0e8226ecf031f39e61c6301383
Author: Tor Lillqvist 
AuthorDate: Wed Mar 18 12:01:57 2020 +0200
Commit: Tor Lillqvist 
CommitDate: Wed Mar 18 12:01:57 2020 +0200

Clarify what this file is for

Change-Id: I7cd08cda289859fc272007b10df8b030411a9aa6

diff --git a/loleaflet/css/editor.css b/loleaflet/css/editor.css
index bf534498e..48a1d0128 100644
--- a/loleaflet/css/editor.css
+++ b/loleaflet/css/editor.css
@@ -1,3 +1,5 @@
+/* This CSS file contains only stuff related to the list of users ("editors") 
for a document */
+
 #userlist_table {
width: 100%;
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: android/lib

[Michael Meeks (via logerrit)]

 android/lib/src/main/java/org/libreoffice/androidlib/LOActivity.java   
 |8 -
 android/lib/src/main/java/org/libreoffice/androidlib/lok/LokClipboardData.java 
 |   49 --
 
android/lib/src/main/java/org/libreoffice/androidlib/lok/LokClipboardEntry.java 
|4 
 3 files changed, 29 insertions(+), 32 deletions(-)

New commits:
commit 10c293d014f3d95f5238a01d4071c0774f5a7a0d
Author: Michael Meeks 
AuthorDate: Tue Mar 17 21:06:50 2020 +
Commit: Andras Timar 
CommitDate: Wed Mar 18 11:27:42 2020 +0100

android: use Java object serialization instead of JSON.

This is incredibly quicker, JSON serialization was the bulk of the
performance issue, and took handful of seconds for a chart.

Change-Id: I51bebae6324c3d466f843ee737b051b911cd5fff
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90673
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Michael Meeks 

diff --git 
a/android/lib/src/main/java/org/libreoffice/androidlib/LOActivity.java 
b/android/lib/src/main/java/org/libreoffice/androidlib/LOActivity.java
index 4070f955f..54e6363ce 100644
--- a/android/lib/src/main/java/org/libreoffice/androidlib/LOActivity.java
+++ b/android/lib/src/main/java/org/libreoffice/androidlib/LOActivity.java
@@ -56,6 +56,7 @@ import java.io.FileOutputStream;
 import java.io.IOException;
 import java.io.InputStream;
 import java.io.OutputStream;
+import java.io.BufferedWriter;
 import java.net.URI;
 import java.net.URISyntaxException;
 import java.nio.ByteBuffer;
@@ -1105,10 +1106,9 @@ public class LOActivity extends AppCompatActivity {
 
 File clipboardFile = new 
File(getApplicationContext().getCacheDir(), CLIPBOARD_FILE_PATH);
 LokClipboardData clipboardData = null;
-if (clipboardFile.exists()) {
-clipboardData = new LokClipboardData();
-clipboardData.loadFromFile(clipboardFile);
-}
+if (clipboardFile.exists())
+clipboardData = 
LokClipboardData.createFromFile(clipboardFile);
+
 if (clipboardData != null) {
 LOActivity.this.setClipboardContent(clipboardData);
 LOActivity.this.postUnoCommand(".uno:Paste", null, 
false);
diff --git 
a/android/lib/src/main/java/org/libreoffice/androidlib/lok/LokClipboardData.java
 
b/android/lib/src/main/java/org/libreoffice/androidlib/lok/LokClipboardData.java
index 3d98b5dfe..85fc62710 100644
--- 
a/android/lib/src/main/java/org/libreoffice/androidlib/lok/LokClipboardData.java
+++ 
b/android/lib/src/main/java/org/libreoffice/androidlib/lok/LokClipboardData.java
@@ -4,17 +4,21 @@ import android.util.Base64;
 import android.util.JsonReader;
 import android.util.JsonWriter;
 
+import java.io.Serializable;
+import java.io.ObjectInputStream;
+import java.io.ObjectOutputStream;
 import java.io.BufferedWriter;
 import java.io.File;
 import java.io.FileReader;
-import java.io.FileWriter;
+import java.io.FileInputStream;
+import java.io.FileOutputStream;
 import java.io.IOException;
 import java.nio.charset.StandardCharsets;
 import java.util.ArrayList;
 import java.util.HashMap;
 import java.util.List;
 
-public class LokClipboardData {
+public class LokClipboardData implements Serializable {
 public ArrayList clipboardEntries = new 
ArrayList();
 
 public String getText() {
@@ -37,16 +41,11 @@ public class LokClipboardData {
 
 public boolean writeToFile(File file) {
 try {
-FileWriter fileWriter = new FileWriter(file.getAbsoluteFile());
-JsonWriter writer = new JsonWriter(fileWriter);
-writer.setIndent(" ");
-writer.beginObject();
-for (LokClipboardEntry entry : clipboardEntries) {
-writer.name(entry.mime);
-writer.value(Base64.encodeToString(entry.data, 
Base64.DEFAULT));
-}
-writer.endObject();
-writer.close();
+FileOutputStream fileStream = new 
FileOutputStream(file.getAbsoluteFile());
+   ObjectOutputStream oos = new ObjectOutputStream(fileStream);
+   oos.writeObject(this);
+   oos.close();
+   fileStream.close();
 } catch (IOException e) {
 e.printStackTrace();
 return false;
@@ -54,25 +53,21 @@ public class LokClipboardData {
 return true;
 }
 
-public boolean loadFromFile(File file) {
+public static LokClipboardData createFromFile(File file) {
 try {
-clipboardEntries.clear();
-
-FileReader fileReader= new FileReader(file.getAbsoluteFile());
-JsonReader reader = new JsonReader(fileReader);
-reader.beginObject();
-while (reader.hasNext()) {
-LokClipboardEntry entry = new LokClipboardEntry();
-entry.mime = 

[Libreoffice-commits] core.git: config_host/config_skia.h.in download.lst external/skia

[Luboš Luňák (via logerrit)]

 config_host/config_skia.h.in |5 
 download.lst |4 
 external/skia/Library_skia.mk|  134 +--
 external/skia/UnpackedTarball_skia.mk|1 
 external/skia/clang-attributes-warning.patch.1   |   31 +
 external/skia/fix-alpha-difference-copy.patch.1  |2 
 external/skia/fix-pch.patch.1|   14 --
 external/skia/inc/pch/precompiled_skia.hxx   |   65 ++-
 external/skia/no-trace-resources-on-exit.patch.1 |   12 +-
 9 files changed, 70 insertions(+), 198 deletions(-)

New commits:
commit 1e609d1c5afb0188dd8c2b211fb405627303bef4
Author: Luboš Luňák 
AuthorDate: Tue Mar 17 20:45:04 2020 +0100
Commit: Luboš Luňák 
CommitDate: Wed Mar 18 11:33:26 2020 +0100

update Skia to chrome/m82

Also don't build pdf and jpeg support, it's not needed.

Change-Id: I5f10b1279072dbaba7695aecba5e415853ae308b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90666
Tested-by: Jenkins
Reviewed-by: Luboš Luňák 

diff --git a/config_host/config_skia.h.in b/config_host/config_skia.h.in
index e31d23ad443e..328c43f56bf1 100644
--- a/config_host/config_skia.h.in
+++ b/config_host/config_skia.h.in
@@ -33,9 +33,8 @@ are the same.
 
 #define SK_VULKAN 1
 
-#define SK_HAS_JPEG_LIBRARY 1
-
-#define SK_HAS_PNG_LIBRARY 1
+#define SK_CODEC_DECODES_PNG 1
+#define SK_ENCODE_PNG 1
 
 #define SK_GAMMA_APPLY_TO_A8
 
diff --git a/download.lst b/download.lst
index 3636bd2f60b0..9a8a6681c0e2 100644
--- a/download.lst
+++ b/download.lst
@@ -233,8 +233,8 @@ export RHINO_SHA256SUM := 
1fb458d6aab06932693cc8a9b6e4e70944ee1ff052fa63606e3131
 export RHINO_TARBALL := 798b2ffdc8bcfe7bca2cf92b62caf685-rhino1_5R5.zip
 export SERF_SHA256SUM := 
6988d394b62c3494635b6f0760bc3079f9a0cd380baf0f6b075af1eb9fa5e700
 export SERF_TARBALL := serf-1.2.1.tar.bz2
-export SKIA_SHA256SUM := 
af190451976580081b0133a37ea6fa1434a8f3056f76d42ffb65ac8c79b223b7
-export SKIA_TARBALL := skia-m81-3e98c0e1d11516347ecc594959af2c1da4d04fc9.tar.xz
+export SKIA_SHA256SUM := 
2a70d467815eb3eb60ded071309eef907c6a49ce8bd5ab4595910240c75b6e19
+export SKIA_TARBALL := skia-m82-7bb74c4299b8a85de1e5718fc45da569d6dab3fc.tar.xz
 export STAROFFICE_SHA256SUM := 
6b00e1ed8194e6072be4441025d1b888e39365727ed5b23e0e8c92c4009d1ec4
 export STAROFFICE_VERSION_MICRO := 6
 export STAROFFICE_TARBALL := 
libstaroffice-0.0.$(STAROFFICE_VERSION_MICRO).tar.xz
diff --git a/external/skia/Library_skia.mk b/external/skia/Library_skia.mk
index 1325f8180c99..a86c415339d3 100644
--- a/external/skia/Library_skia.mk
+++ b/external/skia/Library_skia.mk
@@ -44,6 +44,7 @@ $(eval $(call gb_Library_use_externals,skia,\
 ))
 endif
 
+# we don't enable jpeg for skia, but it has incorrect #ifdef's in places
 $(eval $(call gb_Library_use_externals,skia,\
 zlib \
 libjpeg \
@@ -91,9 +92,6 @@ $(eval $(call 
gb_Library_add_generated_exception_objects,skia,\
 UnpackedTarball/skia/src/codec/SkColorTable \
 UnpackedTarball/skia/src/codec/SkEncodedInfo \
 UnpackedTarball/skia/src/codec/SkIcoCodec \
-UnpackedTarball/skia/src/codec/SkJpegCodec \
-UnpackedTarball/skia/src/codec/SkJpegDecoderMgr \
-UnpackedTarball/skia/src/codec/SkJpegUtility \
 UnpackedTarball/skia/src/codec/SkMasks \
 UnpackedTarball/skia/src/codec/SkMaskSwizzler \
 UnpackedTarball/skia/src/codec/SkParseEncodedOrigin \
@@ -174,6 +172,7 @@ $(eval $(call 
gb_Library_add_generated_exception_objects,skia,\
 UnpackedTarball/skia/src/core/SkFontStream \
 UnpackedTarball/skia/src/core/SkGaussFilter \
 UnpackedTarball/skia/src/core/SkGeometry \
+UnpackedTarball/skia/src/core/SkIDChangeListener \
 UnpackedTarball/skia/src/core/SkGlobalInitialization_core \
 UnpackedTarball/skia/src/core/SkGlyph \
 UnpackedTarball/skia/src/core/SkGlyphBuffer \
@@ -252,6 +251,7 @@ $(eval $(call 
gb_Library_add_generated_exception_objects,skia,\
 UnpackedTarball/skia/src/core/SkRuntimeEffect \
 UnpackedTarball/skia/src/core/SkRWBuffer \
 UnpackedTarball/skia/src/core/SkScalar \
+UnpackedTarball/skia/src/core/SkScalerCache \
 UnpackedTarball/skia/src/core/SkScalerContext \
 UnpackedTarball/skia/src/core/SkScan_AAAPath \
 UnpackedTarball/skia/src/core/SkScan_Antihair \
@@ -268,7 +268,6 @@ $(eval $(call 
gb_Library_add_generated_exception_objects,skia,\
 UnpackedTarball/skia/src/core/SkSpriteBlitter_RGB565 \
 UnpackedTarball/skia/src/core/SkStream \
 UnpackedTarball/skia/src/core/SkStrikeCache \
-UnpackedTarball/skia/src/core/SkStrike \
 UnpackedTarball/skia/src/core/SkStrikeForGPU \
 UnpackedTarball/skia/src/core/SkStrikeSpec \
 UnpackedTarball/skia/src/core/SkString \
@@ -283,7 +282,6 @@ $(eval $(call 
gb_Library_add_generated_exception_objects,skia,\
 UnpackedTarball/skia/src/core/SkTextBlobTrace \
 UnpackedTarball/skia/src/core/SkThreadID \
 UnpackedTarball/skia/src/core/SkTime 

[Libreoffice-bugs] [Bug 112969] [META] DOCX (OOXML) field-related issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112969

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||131225


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=131225
[Bug 131225] page number field in footer of docx is shown incorrect in soffice
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104522] [META] DOCX (OOXML) header & footer-related issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104522

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||131225


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=131225
[Bug 131225] page number field in footer of docx is shown incorrect in soffice
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 131402] Take Gmail Customer Service To Edit Your Privacy Security Settings

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=131402

jane watson  changed:

   What|Removed |Added

URL||https://attcustomerservicep
   ||honenumber.com/gmail-custom
   ||er-service-number/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 131402] New: Take Gmail Customer Service To Edit Your Privacy Security Settings

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=131402

Bug ID: 131402
   Summary: Take Gmail Customer Service To Edit Your Privacy
Security Settings
   Product: Impress Remote
   Version: 1.0.0
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: General
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: janewtsn...@gmail.com

Description:
Edit any of your privacy security settings on your Gmail account within a flash
by taking the world class Gmail Customer Service. After taking this service,
you will get the full access to talk with team of techies, who will help you in
managing settings within the couple of seconds. This service is available all
the time so you can take this service whenever you face issue.
https://attcustomerservicephonenumber.com/gmail-customer-service-number/

Actual Results:
error in  gmail acount

Expected Results:
we fix the error 


Reproducible: Always


User Profile Reset: No



Additional Info:
customer satisfaction

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 131365] Writer cannot display picture in the document on windows 10 platform

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=131365

ian  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #3 from ian  ---
Thank you for reporting the bug. 

As Timur mentioned earlier, please attach a sample document, as this makes it
easier for us to verify the bug. 

I have set the bug's status to 'NEEDINFO'. Please change it back to
'UNCONFIRMED' once a sample document is provided.

See
https://wiki.documentfoundation.org/QA/FAQ#How_can_I_eliminate_confidential_data_from_a_sample_document.3F
for further details regarding the removal of personal information from your
document.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 120201] [META] Update or add link to help page

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=120201

sdc.bla...@youmail.dk changed:

   What|Removed |Added

 Depends on||131403


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=131403
[Bug 131403] no help page for "Pattern" in the Area tab
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 131403] New: no help page for "Pattern" in the Area tab

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=131403

Bug ID: 131403
   Summary: no help page for "Pattern" in the Area tab
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Documentation
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: sdc.bla...@youmail.dk
CC: olivier.hal...@libreoffice.org

Open Area tab - and select Pattern - click on Help button

Goes to Area tab help page (because no Pattern help page exists).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 131403] no help page for "Pattern" in the Area tab

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=131403

sdc.bla...@youmail.dk changed:

   What|Removed |Added

 Blocks||120201, 80430


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=80430
[Bug 80430] [META] Documentation gap for new features
https://bugs.documentfoundation.org/show_bug.cgi?id=120201
[Bug 120201] [META] Update or add link to help page
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 80430] [META] Documentation gap for new features

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=80430

sdc.bla...@youmail.dk changed:

   What|Removed |Added

 Depends on||131403


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=131403
[Bug 131403] no help page for "Pattern" in the Area tab
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 131404] Opening existing document does not show its images, but new inserted images are visible

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=131404

V Stuart Foote  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||vstuart.fo...@utsa.edu
 Status|UNCONFIRMED |NEEDINFO
Summary|draw|Opening existing document
   ||does not show its images,
   ||but new inserted images are
   ||visible

--- Comment #1 from V Stuart Foote  ---
Is this for a ODF Drawing document, .odg? What version was it created with?

Aoso, please describe the type of images you are working with. Are there
"outline frame" place holdings for the images?

And, best to attach the original document, or a copy of some portion of it that
still has the issues of "images" not showing.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 131394] Norton Login

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=131394

Timur  changed:

   What|Removed |Added

  Component|General |deletionRequest
Product|libexttextcat   |LibreOffice
 Status|RESOLVED|CLOSED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125455] Setting LTR direction in mixed-RTL document gets reverted on reopen (per Comment 10)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125455

--- Comment #11 from Justin L  ---
I'm not sure how you managed to create this document. It contains columns
(which implies a section) but there is no section to manage. That ultimately
seems to be the problem.

If you explicitly but the columns in a section, then it all seems to work.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 131381] docx rendering problems

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=131381

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

   Keywords||filter:docx

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104450] [META] DOCX (OOXML) file opening issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104450

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||130775


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=130775
[Bug 130775] FILEOPEN DOCX: Crash in SwTextAdjuster::CalcRightMargin
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130775] FILEOPEN DOCX: Crash in SwTextAdjuster::CalcRightMargin

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=130775

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Blocks||104450


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=104450
[Bug 104450] [META] DOCX (OOXML) file opening issues
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103378] [META] PDF export bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103378

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||130868


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=130868
[Bug 130868] Crash when trying to convert odt to pdf
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130868] Crash when trying to convert odt to pdf

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=130868

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

   Keywords||filter:pdf
  Component|Writer  |Printing and PDF export
 Blocks||103378


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103378
[Bug 103378] [META] PDF export bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 131365] Writer cannot display picture in the document on windows 10 platform

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=131365

--- Comment #4 from me_...@126.com ---
Created attachment 158784
  --> https://bugs.documentfoundation.org/attachment.cgi?id=158784=edit
it's a sample file that has a picture

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 131401] Document locking on Linux cifs mount blocking files for MSO

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=131401

Samuel Mehrbrodt (CIB)  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||s.mehrbr...@gmail.com
 Ever confirmed|0   |1

--- Comment #1 from Samuel Mehrbrodt (CIB)  ---
(In reply to Massimo B. from comment #0)
> Opening a file on a cifs mount on Linux from libreoffice-6.3.5.2, some MS
> Office Professional Plus 2019 fails to open with  "... is currently used by
> another person. Please try again later."
> 
> 
> 1. The locking user is not reported on MSO, eventhough both locking files
> for LO and MSO are created and owned by my user.

Is the file still open in LibreOffice while you try that?
Can you try if changing the "UseDocumentSystemFileLocking" option changes the
behavior?
Does this work on another file system or is this specific to CIFS?

> 
> 2. There is no way to open a read-only copy from MSO. It can't open the file
> at all.

This is not our bug, please report this issue to Microsoft.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs