[Libreoffice-commits] help.git: source/text

2020-09-27 Thread Stanislav Horacek (via logerrit)
 source/text/simpress/guide/footer.xhp |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 77cce026db5de5f8d25ee6fe05d084e4f1f1f11b
Author: Stanislav Horacek 
AuthorDate: Sun Sep 27 18:35:32 2020 +0200
Commit: Adolfo Jayme Barrientos 
CommitDate: Sun Sep 27 20:59:06 2020 +0200

fix typo in text about master slide footer

Change-Id: Icb2c55d9cb2f59462ff6113c95c67b3002b6d045
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/103516
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/source/text/simpress/guide/footer.xhp 
b/source/text/simpress/guide/footer.xhp
index 6f9e2d6be..d9825d29a 100644
--- a/source/text/simpress/guide/footer.xhp
+++ b/source/text/simpress/guide/footer.xhp
@@ -75,7 +75,7 @@
 Click the 
Date Area and move the time and date field. Select the date/time field 
and apply some formatting to change the format for the date and time on all 
slides. The same applies to the Footer Area and the Slide Number 
Area.


-Normally the 
predefined elements of the Master side are set to visible in the presentation. 
You can control the visibility of the predefined elements by choosing 
Slide - Master Elements.
+   Normally the 
predefined elements of the master slide are set to visible in the presentation. 
You can control the visibility of the predefined elements by choosing 
Slide - Master Elements.


   
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: sw/inc sw/source

2020-09-27 Thread Bjoern Michaelsen (via logerrit)
 sw/inc/swtable.hxx   |2 -
 sw/source/core/table/swtable.cxx |   41 +++
 2 files changed, 26 insertions(+), 17 deletions(-)

New commits:
commit b3fa0c06fe153737a125c9ba6f8fcc7d0a4d391d
Author: Bjoern Michaelsen 
AuthorDate: Sun Sep 20 10:42:54 2020 +0200
Commit: Bjoern Michaelsen 
CommitDate: Sun Sep 27 23:02:33 2020 +0200

SwTable: Replace Modify with SwClientNotify

Change-Id: Ia5eccf6d13bac6a15079ad3f8c7dcbaef519c317
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103065
Tested-by: Jenkins
Reviewed-by: Bjoern Michaelsen 

diff --git a/sw/inc/swtable.hxx b/sw/inc/swtable.hxx
index a0deaf01e892..ef04b527b65b 100644
--- a/sw/inc/swtable.hxx
+++ b/sw/inc/swtable.hxx
@@ -136,7 +136,7 @@ protected:
 boolm_bModifyLocked   :1;
 boolm_bNewModel   :1; // false: old SubTableModel; true: new 
RowSpanModel
 
-virtual void Modify( const SfxPoolItem* pOld, const SfxPoolItem* pNew ) 
override;
+virtual void SwClientNotify(const SwModify&, const SfxHint&) override;
 
 public:
 enum SearchType
diff --git a/sw/source/core/table/swtable.cxx b/sw/source/core/table/swtable.cxx
index a379e6d0aa6c..a14e8060b429 100644
--- a/sw/source/core/table/swtable.cxx
+++ b/sw/source/core/table/swtable.cxx
@@ -338,30 +338,39 @@ static void lcl_ModifyBoxes( SwTableBoxes , const 
long nOld,
 }
 }
 
-void SwTable::Modify( const SfxPoolItem* pOld, const SfxPoolItem *pNew )
+void SwTable::SwClientNotify(const SwModify&, const SfxHint& rHint)
 {
+auto pLegacy = dynamic_cast();
+if(!pLegacy)
+return;
 // catch SSize changes, to adjust the lines/boxes
-const sal_uInt16 nWhich = pOld ? pOld->Which() : pNew ? pNew->Which() : 0 ;
+const sal_uInt16 nWhich = pLegacy->m_pOld ? pLegacy->m_pOld->Which() : 
pLegacy->m_pNew ? pLegacy->m_pNew->Which() : 0;
 const SwFormatFrameSize* pNewSize = nullptr, *pOldSize = nullptr;
-
-if( RES_ATTRSET_CHG == nWhich )
+switch(nWhich)
 {
-if (pOld && pNew && SfxItemState::SET == static_cast(pNew)->GetChgSet()->GetItemState(
-RES_FRM_SIZE, false, reinterpret_cast()))
+case RES_ATTRSET_CHG:
 {
-pOldSize = _cast(pOld)->GetChgSet()->GetFrameSize();
+if (pLegacy->m_pOld && pLegacy->m_pNew
+&& SfxItemState::SET == static_cast(pLegacy->m_pNew)->GetChgSet()->GetItemState(
+RES_FRM_SIZE,
+false,
+reinterpret_cast()))
+{
+pOldSize = _cast(pLegacy->m_pOld)->GetChgSet()->GetFrameSize();
+}
 }
+break;
+case RES_FRM_SIZE:
+{
+pOldSize = static_cast(pLegacy->m_pOld);
+pNewSize = static_cast(pLegacy->m_pNew);
+}
+break;
+default:
+CheckRegistration(pLegacy->m_pOld);
 }
-else if( RES_FRM_SIZE == nWhich )
-{
-pOldSize = static_cast(pOld);
-pNewSize = static_cast(pNew);
-}
-else
-CheckRegistration( pOld );
-
 if (pOldSize && pNewSize && !m_bModifyLocked)
-AdjustWidths( pOldSize->GetWidth(), pNewSize->GetWidth() );
+AdjustWidths(pOldSize->GetWidth(), pNewSize->GetWidth());
 }
 
 void SwTable::AdjustWidths( const long nOld, const long nNew )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: sw/inc sw/source

2020-09-27 Thread Bjoern Michaelsen (via logerrit)
 sw/inc/calbck.hxx|2 ++
 sw/source/core/access/accframebase.cxx   |2 +-
 sw/source/core/access/accnotextframe.cxx |2 +-
 sw/source/core/access/acctable.cxx   |2 +-
 sw/source/core/access/acctextframe.cxx   |2 +-
 sw/source/core/table/swtable.cxx |2 +-
 sw/source/core/text/txtfrm.cxx   |3 ++-
 7 files changed, 9 insertions(+), 6 deletions(-)

New commits:
commit dec9a123867dcd0fea4683beeb3b4b6659f926f3
Author: Bjoern Michaelsen 
AuthorDate: Sun Sep 20 12:03:42 2020 +0200
Commit: Bjoern Michaelsen 
CommitDate: Sun Sep 27 23:03:06 2020 +0200

Move default way to find Which to an inline function

Change-Id: Ie3aa3f8a2c34c510a391d729f3dc2286f735111a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103066
Tested-by: Jenkins
Reviewed-by: Bjoern Michaelsen 

diff --git a/sw/inc/calbck.hxx b/sw/inc/calbck.hxx
index fc17b826f965..62742cb1cab5 100644
--- a/sw/inc/calbck.hxx
+++ b/sw/inc/calbck.hxx
@@ -24,6 +24,7 @@
 
 #include 
 #include 
+#include 
 #include "swdllapi.h"
 #include "ring.hxx"
 #include 
@@ -63,6 +64,7 @@ namespace sw
 struct LegacyModifyHint final: SfxHint
 {
 LegacyModifyHint(const SfxPoolItem* pOld, const SfxPoolItem* pNew) : 
m_pOld(pOld), m_pNew(pNew) {};
+sal_uInt16 GetWhich() const { return m_pOld ? m_pOld->Which() : m_pNew 
? m_pNew->Which() : 0; };
 virtual ~LegacyModifyHint() override;
 const SfxPoolItem* m_pOld;
 const SfxPoolItem* m_pNew;
diff --git a/sw/source/core/access/accframebase.cxx 
b/sw/source/core/access/accframebase.cxx
index a0d3aeacf73a..6338ee18a5c1 100644
--- a/sw/source/core/access/accframebase.cxx
+++ b/sw/source/core/access/accframebase.cxx
@@ -215,7 +215,7 @@ void SwAccessibleFrameBase::Notify(const SfxHint& rHint)
 }
 else if(auto pLegacyModifyHint = dynamic_cast())
 {
-sal_uInt16 nWhich = pLegacyModifyHint->m_pOld ? 
pLegacyModifyHint->m_pOld->Which() : pLegacyModifyHint->m_pNew ? 
pLegacyModifyHint->m_pNew->Which() : 0;
+const sal_uInt16 nWhich = pLegacyModifyHint->GetWhich();
 const SwFlyFrame* pFlyFrame = static_cast(GetFrame());
 if(nWhich == RES_NAME_CHANGED && pFlyFrame)
 {
diff --git a/sw/source/core/access/accnotextframe.cxx 
b/sw/source/core/access/accnotextframe.cxx
index acc4f0ce31a5..3dfed9ea3303 100644
--- a/sw/source/core/access/accnotextframe.cxx
+++ b/sw/source/core/access/accnotextframe.cxx
@@ -89,7 +89,7 @@ void SwAccessibleNoTextFrame::Notify(const SfxHint& rHint)
 EndListeningAll();
 else if(auto pLegacyModifyHint = dynamic_cast())
 {
-const sal_uInt16 nWhich = pLegacyModifyHint->m_pOld ? 
pLegacyModifyHint->m_pOld->Which() : pLegacyModifyHint->m_pNew ? 
pLegacyModifyHint->m_pNew->Which() : 0;
+const sal_uInt16 nWhich = pLegacyModifyHint->GetWhich();
 if (nWhich != RES_TITLE_CHANGED && nWhich != RES_DESCRIPTION_CHANGED)
 return;
 const SwNoTextNode* pNd = GetNoTextNode();
diff --git a/sw/source/core/access/acctable.cxx 
b/sw/source/core/access/acctable.cxx
index 9e164c7c5696..457e5451dc3b 100644
--- a/sw/source/core/access/acctable.cxx
+++ b/sw/source/core/access/acctable.cxx
@@ -641,7 +641,7 @@ void SwAccessibleTable::Notify(const SfxHint& rHint)
 }
 else if(auto pLegacyHint = dynamic_cast())
 {
-sal_uInt16 nWhich = pLegacyHint->m_pOld ? pLegacyHint->m_pOld->Which() 
: pLegacyHint->m_pNew ? pLegacyHint->m_pNew->Which() : 0;
+const sal_uInt16 nWhich = pLegacyHint->GetWhich();
 const SwTabFrame* pTabFrame = static_cast(GetFrame());
 if(nWhich == RES_NAME_CHANGED && pTabFrame)
 {
diff --git a/sw/source/core/access/acctextframe.cxx 
b/sw/source/core/access/acctextframe.cxx
index 928a68677283..95937bbd1e99 100644
--- a/sw/source/core/access/acctextframe.cxx
+++ b/sw/source/core/access/acctextframe.cxx
@@ -69,7 +69,7 @@ void SwAccessibleTextFrame::Notify(const SfxHint& rHint)
 EndListeningAll();
 else if(auto pLegacyModifyHint = dynamic_cast())
 {
-const sal_uInt16 nWhich = pLegacyModifyHint->m_pOld ? 
pLegacyModifyHint->m_pOld->Which() : pLegacyModifyHint->m_pNew ? 
pLegacyModifyHint->m_pNew->Which() : 0;
+const sal_uInt16 nWhich = pLegacyModifyHint->GetWhich();
 const SwFlyFrame* pFlyFrame = static_cast(GetFrame());
 switch(nWhich)
 {
diff --git a/sw/source/core/table/swtable.cxx b/sw/source/core/table/swtable.cxx
index a14e8060b429..8d6b2b504d60 100644
--- a/sw/source/core/table/swtable.cxx
+++ b/sw/source/core/table/swtable.cxx
@@ -344,7 +344,7 @@ void SwTable::SwClientNotify(const SwModify&, const 
SfxHint& rHint)
 if(!pLegacy)
 return;
 // catch SSize changes, to adjust the lines/boxes
-const sal_uInt16 nWhich = pLegacy->m_pOld ? pLegacy->m_pOld->Which() : 
pLegacy->m_pNew ? pLegacy->m_pNew->Which() : 0;
+const sal_uInt16 nWhich = pLegacy->GetWhich();

[Libreoffice-commits] core.git: Branch 'libreoffice-7-0' - i18npool/Library_localedata_others.mk i18npool/source

2020-09-27 Thread Eike Rathke (via logerrit)
 i18npool/Library_localedata_others.mk |1 
 i18npool/source/localedata/data/en_HK.xml |   34 ++
 i18npool/source/localedata/localedata.cxx |1 
 3 files changed, 36 insertions(+)

New commits:
commit 37352332a3b6e6d068ce77b46f616e0b752e3ba8
Author: Eike Rathke 
AuthorDate: Fri Aug 21 11:51:44 2020 +0200
Commit: Adolfo Jayme Barrientos 
CommitDate: Mon Sep 28 02:09:43 2020 +0200

Resolves: tdf#135518 Add English (Hong Kong) [en-HK] locale data

Inherited from en-GB, zh-HK

Change-Id: I966d19cfa2da26d3d882af35afe79a2f77eaffa8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101139
Reviewed-by: Eike Rathke 
Tested-by: Jenkins
(cherry picked from commit 5dffb7ba361ad76aa249d6c93fd87fff67362726)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103328
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/i18npool/Library_localedata_others.mk 
b/i18npool/Library_localedata_others.mk
index f1cb28820c6d..cece0e15fc30 100644
--- a/i18npool/Library_localedata_others.mk
+++ b/i18npool/Library_localedata_others.mk
@@ -50,6 +50,7 @@ $(eval $(call 
gb_Library_add_generated_exception_objects,localedata_others,\
CustomTarget/i18npool/localedata/localedata_dz_BT \
CustomTarget/i18npool/localedata/localedata_ebo_CG \
CustomTarget/i18npool/localedata/localedata_ee_GH \
+   CustomTarget/i18npool/localedata/localedata_en_HK \
CustomTarget/i18npool/localedata/localedata_en_IN \
CustomTarget/i18npool/localedata/localedata_en_KE \
CustomTarget/i18npool/localedata/localedata_en_MY \
diff --git a/i18npool/source/localedata/data/en_HK.xml 
b/i18npool/source/localedata/data/en_HK.xml
new file mode 100644
index ..e0d913b912ac
--- /dev/null
+++ b/i18npool/source/localedata/data/en_HK.xml
@@ -0,0 +1,34 @@
+
+
+
+
+  
+
+  en
+  English
+
+
+  HK
+  Hong Kong
+
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+
+
diff --git a/i18npool/source/localedata/localedata.cxx 
b/i18npool/source/localedata/localedata.cxx
index a0fbd8361068..a25c391ac927 100644
--- a/i18npool/source/localedata/localedata.cxx
+++ b/i18npool/source/localedata/localedata.cxx
@@ -201,6 +201,7 @@ static const struct {
 { "zh_SG",  lcl_DATA_OTHERS },
 { "zh_TW",  lcl_DATA_OTHERS },
 { "zh_MO",  lcl_DATA_OTHERS },
+{ "en_HK",  lcl_DATA_OTHERS },  // needs to be in OTHERS instead of EN 
because currency inherited from zh_HK
 
 { "ar_EG",  lcl_DATA_OTHERS },
 { "ar_DZ",  lcl_DATA_OTHERS },
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: sc/qa sc/res

2020-09-27 Thread Eike Rathke (via logerrit)
 sc/qa/extras/scstylefamilyobj.cxx |6 +-
 sc/res/xml/styles.xml |4 
 2 files changed, 9 insertions(+), 1 deletion(-)

New commits:
commit 930d82550863430c9bef96ac307c3ff2cfefe4d8
Author: Eike Rathke 
AuthorDate: Sun Sep 27 20:37:34 2020 +0200
Commit: Eike Rathke 
CommitDate: Mon Sep 28 02:52:50 2020 +0200

Resolves: tdf#133812 Add the 'Result' style again used by the Subtotal tool

Necessary to also adapt the test case that checks for a defined
number of styles.

Regression from

commit 7b0aed617f1e57335837cf56ef2d222a96f8270d
CommitDate: Wed Sep 28 11:42:56 2016 +

Remove old cell styles from calc

and

commit 06f319937187f76ee402d53b3baa78c391c2af19
CommitDate: Sun Oct 2 13:51:26 2016 +

tdf#90937 Add a set of cell styles to calc

Change-Id: I3e47d8e24d375a64d9056e7a85197b89173c8e41
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103520
Tested-by: Jenkins
Reviewed-by: Eike Rathke 

diff --git a/sc/qa/extras/scstylefamilyobj.cxx 
b/sc/qa/extras/scstylefamilyobj.cxx
index a5843a8f3a1f..8597d22b0f71 100644
--- a/sc/qa/extras/scstylefamilyobj.cxx
+++ b/sc/qa/extras/scstylefamilyobj.cxx
@@ -83,10 +83,14 @@ private:
 uno::Reference m_xComponent;
 };
 
+/* TODO: this c/should be derived/defined from the real style count, default
+ * implemented plus sc/res/xml/styles.xml */
+constexpr sal_Int32 kScStyleFamilyObjCount = 20;
+
 ScStyleFamilyObj::ScStyleFamilyObj()
 : CalcUnoApiTest("/sc/qa/extras/testdocuments")
 , XElementAccess(cppu::UnoType::get())
-, XIndexAccess(19)
+, XIndexAccess(kScStyleFamilyObjCount)
 , XNameAccess("ScStyleFamilyObj")
 , XNameContainer("ScStyleFamilyObj")
 , XNameReplace("ScStyleFamilyObj")
diff --git a/sc/res/xml/styles.xml b/sc/res/xml/styles.xml
index 9bfda940c3d9..d1d1a750e241 100644
--- a/sc/res/xml/styles.xml
+++ b/sc/res/xml/styles.xml
@@ -57,4 +57,8 @@
 
 
 
+
+
+
+
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: sc/source

2020-09-27 Thread Caolán McNamara (via logerrit)
 sc/source/ui/drawfunc/chartsh.cxx  |   10 ++---
 sc/source/ui/drawfunc/drawsh.cxx   |   36 +--
 sc/source/ui/drawfunc/drawsh2.cxx  |   28 +++
 sc/source/ui/drawfunc/drawsh4.cxx  |2 -
 sc/source/ui/drawfunc/drawsh5.cxx  |   48 +-
 sc/source/ui/drawfunc/drformsh.cxx |4 +-
 sc/source/ui/drawfunc/drtxtob.cxx  |   68 ++---
 sc/source/ui/drawfunc/drtxtob1.cxx |   12 +++---
 sc/source/ui/drawfunc/drtxtob2.cxx |   18 -
 sc/source/ui/drawfunc/graphsh.cxx  |   38 ++--
 sc/source/ui/drawfunc/mediash.cxx  |8 ++--
 sc/source/ui/drawfunc/oleobjsh.cxx |4 +-
 sc/source/ui/inc/auditsh.hxx   |4 +-
 sc/source/ui/inc/cellsh.hxx|2 -
 sc/source/ui/inc/chartsh.hxx   |2 -
 sc/source/ui/inc/drawsh.hxx|6 +--
 sc/source/ui/inc/drformsh.hxx  |2 -
 sc/source/ui/inc/drtxtob.hxx   |4 +-
 sc/source/ui/inc/editsh.hxx|4 +-
 sc/source/ui/inc/graphsh.hxx   |2 -
 sc/source/ui/inc/mediash.hxx   |2 -
 sc/source/ui/inc/oleobjsh.hxx  |2 -
 sc/source/ui/view/auditsh.cxx  |   18 -
 sc/source/ui/view/cellsh.cxx   |4 +-
 sc/source/ui/view/editsh.cxx   |   64 +-
 sc/source/ui/view/tabvwsh4.cxx |   20 +-
 26 files changed, 206 insertions(+), 206 deletions(-)

New commits:
commit 3f7b48c4a726f51bdc5c78886957c08506e4d336
Author: Caolán McNamara 
AuthorDate: Sun Sep 27 14:09:02 2020 +0100
Commit: Caolán McNamara 
CommitDate: Sun Sep 27 21:27:41 2020 +0200

never null ScViewData*

Change-Id: If5ad4c637a8c4db67ca4bfe99612e90ae6237ff6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103513
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/sc/source/ui/drawfunc/chartsh.cxx 
b/sc/source/ui/drawfunc/chartsh.cxx
index 70a46b8d5e71..25b66b0fb7e2 100644
--- a/sc/source/ui/drawfunc/chartsh.cxx
+++ b/sc/source/ui/drawfunc/chartsh.cxx
@@ -49,8 +49,8 @@ void ScChartShell::InitInterface_Impl()
 }
 
 
-ScChartShell::ScChartShell(ScViewData* pData) :
-ScDrawShell(pData)
+ScChartShell::ScChartShell(ScViewData& rData) :
+ScDrawShell(rData)
 {
 SetName( "ChartObject" );
 
SfxShell::SetContextName(vcl::EnumContext::GetContextName(vcl::EnumContext::Context::Chart));
@@ -62,7 +62,7 @@ ScChartShell::~ScChartShell()
 
 void ScChartShell::GetExportAsGraphicState( SfxItemSet& rSet )
 {
-ScDrawView* pView = GetViewData()->GetScDrawView();
+ScDrawView* pView = GetViewData().GetScDrawView();
 const SdrMarkList& rMarkList = pView->GetMarkedObjectList();
 bool bEnable = false;
 if( rMarkList.GetMarkCount() == 1 )
@@ -82,7 +82,7 @@ void ScChartShell::GetExportAsGraphicState( SfxItemSet& rSet )
 
 void ScChartShell::ExecuteExportAsGraphic( SfxRequest& )
 {
-ScDrawView* pView = GetViewData()->GetScDrawView();
+ScDrawView* pView = GetViewData().GetScDrawView();
 const SdrMarkList& rMarkList = pView->GetMarkedObjectList();
 
 if( rMarkList.GetMarkCount() == 1 )
@@ -91,7 +91,7 @@ void ScChartShell::ExecuteExportAsGraphic( SfxRequest& )
 
 if( dynamic_cast( pObject) )
 {
-vcl::Window* pWin = GetViewData()->GetActiveWin();
+vcl::Window* pWin = GetViewData().GetActiveWin();
 Reference< drawing::XShape > xSourceDoc( pObject->getUnoShape(), 
UNO_QUERY_THROW );
 GraphicHelper::SaveShapeAsGraphic(pWin ? pWin->GetFrameWeld() : 
nullptr, xSourceDoc);
 }
diff --git a/sc/source/ui/drawfunc/drawsh.cxx b/sc/source/ui/drawfunc/drawsh.cxx
index 5b63d210f2df..f295e8715947 100644
--- a/sc/source/ui/drawfunc/drawsh.cxx
+++ b/sc/source/ui/drawfunc/drawsh.cxx
@@ -178,9 +178,9 @@ static void lcl_invalidateTransformAttr(const 
ScTabViewShell* pViewShell)
 void ScDrawShell::ExecDrawAttr( SfxRequest& rReq )
 {
 sal_uInt16  nSlot   = rReq.GetSlot();
-vcl::Window* pWin= pViewData->GetActiveWin();
-ScDrawView* pView   = pViewData->GetScDrawView();
-SdrModel*   pDoc= pViewData->GetDocument().GetDrawLayer();
+vcl::Window* pWin= rViewData.GetActiveWin();
+ScDrawView* pView   = rViewData.GetScDrawView();
+SdrModel*   pDoc= rViewData.GetDocument().GetDrawLayer();
 
 const SdrMarkList& rMarkList = pView->GetMarkedObjectList();
 const size_t nMarkCount = rMarkList.GetMarkCount();
@@ -299,7 +299,7 @@ void ScDrawShell::ExecDrawAttr( SfxRequest& rReq )
 
 case SID_DRAW_HLINK_EDIT:
 if ( pSingleSelectedObj )
-pViewData->GetDispatcher().Execute( SID_HYPERLINK_DIALOG );
+rViewData.GetDispatcher().Execute( SID_HYPERLINK_DIALOG );
 break;
 
 case SID_DRAW_HLINK_DELETE:
@@ -314,7 +314,7 @@ void ScDrawShell::ExecDrawAttr( SfxRequest& rReq )
 if ( 

[Libreoffice-commits] core.git: Branch 'libreoffice-7-0' - cui/uiconfig

2020-09-27 Thread Caolán McNamara (via logerrit)
 cui/uiconfig/ui/paratabspage.ui |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 1ef9c1322ce2e21cf1374535caf9c7dc0d315c44
Author: Caolán McNamara 
AuthorDate: Thu Sep 17 20:44:41 2020 +0100
Commit: Adolfo Jayme Barrientos 
CommitDate: Mon Sep 28 02:07:04 2020 +0200

tdf#136705 give tab stop treeview a small height request

so its natural height has no influence on the overall dialog height
and it will take whatever height the dialog ends up at

Change-Id: I98d6b2483f01ac2006dcc9d2ffa91824611a6d71
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102933
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/cui/uiconfig/ui/paratabspage.ui b/cui/uiconfig/ui/paratabspage.ui
index a97576c24e6a..bf3d85a1618e 100644
--- a/cui/uiconfig/ui/paratabspage.ui
+++ b/cui/uiconfig/ui/paratabspage.ui
@@ -47,6 +47,7 @@
 3
 
   
+42
 True
 False
 True
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] help.git: Branch 'libreoffice-7-0' - AllLangHelp_shared.mk AllLangPackage_html_media_lang.mk source/media source/text

2020-09-27 Thread Olivier Hallot (via logerrit)
 AllLangHelp_shared.mk  
   |1 
 AllLangPackage_html_media_lang.mk  
   |1 
 
source/media/screenshots/modules/scalc/ui/xmlsourcedialog/af/XMLSourceDialog.png
  |binary
 
source/media/screenshots/modules/scalc/ui/xmlsourcedialog/am/XMLSourceDialog.png
  |binary
 
source/media/screenshots/modules/scalc/ui/xmlsourcedialog/ar/XMLSourceDialog.png
  |binary
 
source/media/screenshots/modules/scalc/ui/xmlsourcedialog/as/XMLSourceDialog.png
  |binary
 
source/media/screenshots/modules/scalc/ui/xmlsourcedialog/ast/XMLSourceDialog.png
 |binary
 
source/media/screenshots/modules/scalc/ui/xmlsourcedialog/be/XMLSourceDialog.png
  |binary
 
source/media/screenshots/modules/scalc/ui/xmlsourcedialog/bg/XMLSourceDialog.png
  |binary
 
source/media/screenshots/modules/scalc/ui/xmlsourcedialog/bn-IN/XMLSourceDialog.png
   |binary
 
source/media/screenshots/modules/scalc/ui/xmlsourcedialog/bn/XMLSourceDialog.png
  |binary
 
source/media/screenshots/modules/scalc/ui/xmlsourcedialog/bo/XMLSourceDialog.png
  |binary
 
source/media/screenshots/modules/scalc/ui/xmlsourcedialog/br/XMLSourceDialog.png
  |binary
 
source/media/screenshots/modules/scalc/ui/xmlsourcedialog/brx/XMLSourceDialog.png
 |binary
 
source/media/screenshots/modules/scalc/ui/xmlsourcedialog/bs/XMLSourceDialog.png
  |binary
 
source/media/screenshots/modules/scalc/ui/xmlsourcedialog/ca-valencia/XMLSourceDialog.png
 |binary
 
source/media/screenshots/modules/scalc/ui/xmlsourcedialog/ca/XMLSourceDialog.png
  |binary
 
source/media/screenshots/modules/scalc/ui/xmlsourcedialog/cs/XMLSourceDialog.png
  |binary
 
source/media/screenshots/modules/scalc/ui/xmlsourcedialog/cy/XMLSourceDialog.png
  |binary
 
source/media/screenshots/modules/scalc/ui/xmlsourcedialog/da/XMLSourceDialog.png
  |binary
 
source/media/screenshots/modules/scalc/ui/xmlsourcedialog/de/XMLSourceDialog.png
  |binary
 
source/media/screenshots/modules/scalc/ui/xmlsourcedialog/dgo/XMLSourceDialog.png
 |binary
 
source/media/screenshots/modules/scalc/ui/xmlsourcedialog/dsb/XMLSourceDialog.png
 |binary
 
source/media/screenshots/modules/scalc/ui/xmlsourcedialog/dz/XMLSourceDialog.png
  |binary
 
source/media/screenshots/modules/scalc/ui/xmlsourcedialog/el/XMLSourceDialog.png
  |binary
 
source/media/screenshots/modules/scalc/ui/xmlsourcedialog/en-GB/XMLSourceDialog.png
   |binary
 
source/media/screenshots/modules/scalc/ui/xmlsourcedialog/en-ZA/XMLSourceDialog.png
   |binary
 
source/media/screenshots/modules/scalc/ui/xmlsourcedialog/eo/XMLSourceDialog.png
  |binary
 
source/media/screenshots/modules/scalc/ui/xmlsourcedialog/es/XMLSourceDialog.png
  |binary
 
source/media/screenshots/modules/scalc/ui/xmlsourcedialog/et/XMLSourceDialog.png
  |binary
 
source/media/screenshots/modules/scalc/ui/xmlsourcedialog/eu/XMLSourceDialog.png
  |binary
 
source/media/screenshots/modules/scalc/ui/xmlsourcedialog/fa/XMLSourceDialog.png
  |binary
 
source/media/screenshots/modules/scalc/ui/xmlsourcedialog/fi/XMLSourceDialog.png
  |binary
 
source/media/screenshots/modules/scalc/ui/xmlsourcedialog/fr/XMLSourceDialog.png
  |binary
 
source/media/screenshots/modules/scalc/ui/xmlsourcedialog/fy/XMLSourceDialog.png
  |binary
 
source/media/screenshots/modules/scalc/ui/xmlsourcedialog/ga/XMLSourceDialog.png
  |binary
 
source/media/screenshots/modules/scalc/ui/xmlsourcedialog/gd/XMLSourceDialog.png
  |binary
 
source/media/screenshots/modules/scalc/ui/xmlsourcedialog/gl/XMLSourceDialog.png
  |binary
 
source/media/screenshots/modules/scalc/ui/xmlsourcedialog/gu/XMLSourceDialog.png
  |binary
 
source/media/screenshots/modules/scalc/ui/xmlsourcedialog/gug/XMLSourceDialog.png
 |binary
 
source/media/screenshots/modules/scalc/ui/xmlsourcedialog/he/XMLSourceDialog.png
  |binary
 
source/media/screenshots/modules/scalc/ui/xmlsourcedialog/hi/XMLSourceDialog.png
  |binary
 
source/media/screenshots/modules/scalc/ui/xmlsourcedialog/hr/XMLSourceDialog.png
  |binary
 
source/media/screenshots/modules/scalc/ui/xmlsourcedialog/hsb/XMLSourceDialog.png
 |binary
 
source/media/screenshots/modules/scalc/ui/xmlsourcedialog/hu/XMLSourceDialog.png
  |binary
 
source/media/screenshots/modules/scalc/ui/xmlsourcedialog/id/XMLSourceDialog.png
  |binary
 
source/media/screenshots/modules/scalc/ui/xmlsourcedialog/is/XMLSourceDialog.png
  |binary
 
source/media/screenshots/modules/scalc/ui/xmlsourcedialog/it/XMLSourceDialog.png
  |binary
 
source/media/screenshots/modules/scalc/ui/xmlsourcedialog/ja/XMLSourceDialog.png
  |binary
 

[Libreoffice-commits] core.git: Branch 'libreoffice-7-0' - helpcontent2

2020-09-27 Thread Olivier Hallot (via logerrit)
 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 4f43cf8b78a49808280aeef3f11c6038dafe8ddf
Author: Olivier Hallot 
AuthorDate: Mon Sep 28 00:16:43 2020 -0300
Commit: Gerrit Code Review 
CommitDate: Mon Sep 28 05:16:43 2020 +0200

Update git submodules

* Update helpcontent2 from branch 'libreoffice-7-0'
  to 115d6f66071f551c721243f43ef8239710e08be1
  - Add Calc XML source screenshot

Change-Id: Ie39d4933a568e511b243b54a1801db869b2f74f2
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/101035
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 
(cherry picked from commit 98dbecc36765a4e82574db6e433ece4e8a5008d0)
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/101061
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/helpcontent2 b/helpcontent2
index 34b00bb82652..115d6f66071f 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 34b00bb82652966efc92051785d099eaf0681f77
+Subproject commit 115d6f66071f551c721243f43ef8239710e08be1
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Branch 'libreoffice-6-4-7' - include/unotools officecfg/registry sw/source sw/uiconfig unotools/source

2020-09-27 Thread Michael Stahl (via logerrit)
 include/unotools/compatibility.hxx|4 
 officecfg/registry/schema/org/openoffice/Office/Compatibility.xcs |8 +
 sw/source/core/doc/DocumentSettingManager.cxx |2 
 sw/source/core/view/viewsh.cxx|5 -
 sw/source/ui/config/optcomp.cxx   |   48 
--
 sw/uiconfig/swriter/ui/optcompatpage.ui   |1 
 unotools/source/config/compatibility.cxx  |2 
 7 files changed, 62 insertions(+), 8 deletions(-)

New commits:
commit d263af834a7d6b506ac72d009f7a96cebe9e4140
Author: Michael Stahl 
AuthorDate: Wed Sep 23 18:51:54 2020 +0200
Commit: Adolfo Jayme Barrientos 
CommitDate: Mon Sep 28 02:20:22 2020 +0200

tdf#134782 sw,unotools,officecfg: adapt configuration and UI

Store AddParaLineSpacingToTableCells in configuration as
"AddTableLineSpacing", consistently inconsistent like AddTableSpacing
(the  elements are not subject to translation).

Adapt SwCompatibilityOptPage with some ugly hacks to allow 3 different
states (TriState) for the corresponding checkbox that map to false/false,
true/false and true/true.

The checkbox widget doesn't allow to change *to* indeterminate but at
least the status of the document can be displayed this way,
with a non-obvious tweak to optcompatpage.ui to reference "checktri1"
column.

Change-Id: I5f32e05c93b5e16e782cba5d1d055809d9e5e251
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103318
Tested-by: Jenkins
Reviewed-by: Michael Stahl 
(cherry picked from commit 68aec8fd57eda8c05926b7f361dc102772f2c501)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103360
Reviewed-by: Thorsten Behrens 
(cherry picked from commit 70b2ee8ce4aa081a608bbde4f3125300675934c5)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103336
Reviewed-by: Miklos Vajna 
Reviewed-by: Adolfo Jayme Barrientos 
Tested-by: Adolfo Jayme Barrientos 

diff --git a/include/unotools/compatibility.hxx 
b/include/unotools/compatibility.hxx
index 24f2da53e590..812b8cc480bd 100644
--- a/include/unotools/compatibility.hxx
+++ b/include/unotools/compatibility.hxx
@@ -62,6 +62,10 @@ class UNOTOOLS_DLLPUBLIC SvtCompatibilityEntry
 MsWordTrailingBlanks,
 SubtractFlysAnchoredAtFlys,
 EmptyDbFieldHidesPara,
+/// special entry: optcomp.cxx converts the other values to
+/// integers but not this one because it doesn't have its own
+/// checkbox, so keep it at the end!
+AddTableLineSpacing,
 
 /* Should be at the end. Do not remove it. */
 INVALID
diff --git a/officecfg/registry/schema/org/openoffice/Office/Compatibility.xcs 
b/officecfg/registry/schema/org/openoffice/Office/Compatibility.xcs
index 71007f80c22e..77d33d1fbc0c 100644
--- a/officecfg/registry/schema/org/openoffice/Office/Compatibility.xcs
+++ b/officecfg/registry/schema/org/openoffice/Office/Compatibility.xcs
@@ -76,7 +76,13 @@
   
   
 
-  ???
+  Add paragraph and table spacing at bottom of table cells
+
+true
+  
+  
+
+  Add paragraph line spacing at bottom of table cells
 
 true
   
diff --git a/sw/source/core/doc/DocumentSettingManager.cxx 
b/sw/source/core/doc/DocumentSettingManager.cxx
index a29c5bc6275f..726db3242647 100644
--- a/sw/source/core/doc/DocumentSettingManager.cxx
+++ b/sw/source/core/doc/DocumentSettingManager.cxx
@@ -112,7 +112,7 @@ sw::DocumentSettingManager::DocumentSettingManager(SwDoc 
)
 mbAddExternalLeading= !aOptions.GetDefault( 
SvtCompatibilityEntry::Index::NoExtLeading );
 mbOldLineSpacing= aOptions.GetDefault( 
SvtCompatibilityEntry::Index::UseLineSpacing );
 mbAddParaSpacingToTableCells= aOptions.GetDefault( 
SvtCompatibilityEntry::Index::AddTableSpacing );
-mbAddParaLineSpacingToTableCells= aOptions.GetDefault( 
SvtCompatibilityEntry::Index::AddTableSpacing ); // FIXME? separate UI?
+mbAddParaLineSpacingToTableCells= aOptions.GetDefault( 
SvtCompatibilityEntry::Index::AddTableLineSpacing );
 mbUseFormerObjectPos= aOptions.GetDefault( 
SvtCompatibilityEntry::Index::UseObjectPositioning );
 mbUseFormerTextWrapping = aOptions.GetDefault( 
SvtCompatibilityEntry::Index::UseOurTextWrapping );
 mbConsiderWrapOnObjPos  = aOptions.GetDefault( 
SvtCompatibilityEntry::Index::ConsiderWrappingStyle );
diff --git a/sw/source/core/view/viewsh.cxx b/sw/source/core/view/viewsh.cxx
index 6ce52e5e041c..bf160861ee3c 100644
--- a/sw/source/core/view/viewsh.cxx
+++ b/sw/source/core/view/viewsh.cxx
@@ -833,10 +833,13 @@ void SwViewShell::SetUseVirDev( bool bNewVirtual )
 void 

[Libreoffice-commits] core.git: Branch 'libreoffice-6-4-7' - sw/inc sw/source writerfilter/source

2020-09-27 Thread Michael Stahl (via logerrit)
 sw/inc/IDocumentSettingAccess.hxx |1 +
 sw/source/core/doc/DocumentSettingManager.cxx |7 +++
 sw/source/core/inc/DocumentSettingManager.hxx |1 +
 sw/source/core/layout/calcmove.cxx|   16 +---
 sw/source/core/layout/flowfrm.cxx |   12 ++--
 sw/source/core/layout/frmtool.cxx |2 +-
 sw/source/filter/ww8/ww8par.cxx   |1 +
 sw/source/filter/xml/xmlimp.cxx   |7 +++
 sw/source/uibase/uno/SwXDocumentSettings.cxx  |   13 +
 writerfilter/source/filter/WriterFilter.cxx   |1 +
 10 files changed, 55 insertions(+), 6 deletions(-)

New commits:
commit be467854cd4d83ae36976db9096c77640475df81
Author: Michael Stahl 
AuthorDate: Wed Sep 23 15:14:08 2020 +0200
Commit: Adolfo Jayme Barrientos 
CommitDate: Mon Sep 28 02:17:12 2020 +0200

tdf#134782 sw: split AddParaSpacingToTableCells flag in 2

commit 3cccdabf19a99fd3f657985c1822436d7679df2b "extend
AddParaSpacingToTableCells with line spacing" changed how the
ADD_PARA_SPACING_TO_TABLE_CELLS compat flag works, to improve interop
with Word.

This commit splits out the change as a separate new compat flag
ADD_PARA_LINE_SPACING_TO_TABLE_CELLS ("AddParaLineSpacingToTableCells"),
to preserve compatibility with ODT documents that were produced
by LO < 6.4 (via SwXMLImport::SetConfigurationSettings()).

New documents and WW8/RTF/DOCX import have both flags enabled.

The combination false/true is invalid, and treated as equivalent
to false/false.

Change-Id: Ida20df8fe4a8192a714f91da95345f9726fd7d98
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103317
Tested-by: Jenkins
Reviewed-by: Michael Stahl 
(cherry picked from commit 38aa699f265c17548769aaa4f20e1ae35d18f202)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103359
Reviewed-by: Thorsten Behrens 
(cherry picked from commit d731b65d3c6b58ed98ee60488d07e5cba653ede0)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103335
Reviewed-by: Miklos Vajna 
Reviewed-by: Adolfo Jayme Barrientos 
Tested-by: Adolfo Jayme Barrientos 

diff --git a/sw/inc/IDocumentSettingAccess.hxx 
b/sw/inc/IDocumentSettingAccess.hxx
index 814f139b64fc..5b093bc0d08a 100644
--- a/sw/inc/IDocumentSettingAccess.hxx
+++ b/sw/inc/IDocumentSettingAccess.hxx
@@ -47,6 +47,7 @@ enum class DocumentSettingId
 USE_HIRES_VIRTUAL_DEVICE,
 OLD_LINE_SPACING,
 ADD_PARA_SPACING_TO_TABLE_CELLS,
+ADD_PARA_LINE_SPACING_TO_TABLE_CELLS,
 USE_FORMER_OBJECT_POS,
 USE_FORMER_TEXT_WRAPPING,
 CONSIDER_WRAP_ON_OBJECT_POSITION,
diff --git a/sw/source/core/doc/DocumentSettingManager.cxx 
b/sw/source/core/doc/DocumentSettingManager.cxx
index b7f3af73d2af..a29c5bc6275f 100644
--- a/sw/source/core/doc/DocumentSettingManager.cxx
+++ b/sw/source/core/doc/DocumentSettingManager.cxx
@@ -112,6 +112,7 @@ sw::DocumentSettingManager::DocumentSettingManager(SwDoc 
)
 mbAddExternalLeading= !aOptions.GetDefault( 
SvtCompatibilityEntry::Index::NoExtLeading );
 mbOldLineSpacing= aOptions.GetDefault( 
SvtCompatibilityEntry::Index::UseLineSpacing );
 mbAddParaSpacingToTableCells= aOptions.GetDefault( 
SvtCompatibilityEntry::Index::AddTableSpacing );
+mbAddParaLineSpacingToTableCells= aOptions.GetDefault( 
SvtCompatibilityEntry::Index::AddTableSpacing ); // FIXME? separate UI?
 mbUseFormerObjectPos= aOptions.GetDefault( 
SvtCompatibilityEntry::Index::UseObjectPositioning );
 mbUseFormerTextWrapping = aOptions.GetDefault( 
SvtCompatibilityEntry::Index::UseOurTextWrapping );
 mbConsiderWrapOnObjPos  = aOptions.GetDefault( 
SvtCompatibilityEntry::Index::ConsiderWrappingStyle );
@@ -131,6 +132,7 @@ sw::DocumentSettingManager::DocumentSettingManager(SwDoc 
)
 mbAddExternalLeading= true;
 mbOldLineSpacing= false;
 mbAddParaSpacingToTableCells= false;
+mbAddParaLineSpacingToTableCells= false;
 mbUseFormerObjectPos= false;
 mbUseFormerTextWrapping = false;
 mbConsiderWrapOnObjPos  = false;
@@ -167,6 +169,7 @@ bool sw::DocumentSettingManager::get(/*[in]*/ 
DocumentSettingId id) const
 case DocumentSettingId::OLD_NUMBERING: return mbOldNumbering;
 case DocumentSettingId::OLD_LINE_SPACING: return mbOldLineSpacing;
 case DocumentSettingId::ADD_PARA_SPACING_TO_TABLE_CELLS: return 
mbAddParaSpacingToTableCells;
+case DocumentSettingId::ADD_PARA_LINE_SPACING_TO_TABLE_CELLS: return 
mbAddParaLineSpacingToTableCells;
 case DocumentSettingId::USE_FORMER_OBJECT_POS: return 
mbUseFormerObjectPos;
 case DocumentSettingId::USE_FORMER_TEXT_WRAPPING: return 
mbUseFormerTextWrapping;
 case 

[Libreoffice-commits] core.git: helpcontent2

2020-09-27 Thread Stanislav Horacek (via logerrit)
 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 754887aa9f1c57f8f56b9099b3dcc876e5b6f89f
Author: Stanislav Horacek 
AuthorDate: Sun Sep 27 20:59:06 2020 +0200
Commit: Gerrit Code Review 
CommitDate: Sun Sep 27 20:59:06 2020 +0200

Update git submodules

* Update helpcontent2 from branch 'master'
  to 77cce026db5de5f8d25ee6fe05d084e4f1f1f11b
  - fix typo in text about master slide footer

Change-Id: Icb2c55d9cb2f59462ff6113c95c67b3002b6d045
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/103516
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/helpcontent2 b/helpcontent2
index c3a22ded0e03..77cce026db5d 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit c3a22ded0e03d1629ccfa0b3e025d1bf01c2e452
+Subproject commit 77cce026db5de5f8d25ee6fe05d084e4f1f1f11b
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: basic/source

2020-09-27 Thread Andrea Gelmini (via logerrit)
 basic/source/runtime/runtime.cxx |6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit e0ce9ec1a543d5cbb91d061db067847052bf9c7e
Author: Andrea Gelmini 
AuthorDate: Sat Sep 26 10:18:15 2020 +0200
Commit: Julien Nabet 
CommitDate: Sun Sep 27 09:48:22 2020 +0200

Fix typo in code

It passed "make check" on Linux

Change-Id: Idd33e9f70c9552c341b4d312bc33135f758715b6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103449
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/basic/source/runtime/runtime.cxx b/basic/source/runtime/runtime.cxx
index abd65aa685a8..89fc75f31e8e 100644
--- a/basic/source/runtime/runtime.cxx
+++ b/basic/source/runtime/runtime.cxx
@@ -4268,15 +4268,15 @@ void SbiRuntime::StepSTMNT( sal_uInt32 nOp1, sal_uInt32 
nOp2 )
 if( !bInError )
 {
 // (there's a difference here in case of a jump out of a loop)
-sal_uInt16 nExspectedForLevel = static_cast( nOp2 / 0x100 
);
+sal_uInt16 nExpectedForLevel = static_cast( nOp2 / 0x100 );
 if( !pGosubStk.empty() )
 {
-nExspectedForLevel = nExspectedForLevel + 
pGosubStk.back().nStartForLvl;
+nExpectedForLevel = nExpectedForLevel + 
pGosubStk.back().nStartForLvl;
 }
 
 // if the actual for-level is too small it'd jump out
 // of a loop -> corrected
-while( nForLvl > nExspectedForLevel )
+while( nForLvl > nExpectedForLevel )
 {
 PopFor();
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: comphelper/source io/source package/source

2020-09-27 Thread Noel Grandin (via logerrit)
 comphelper/source/container/embeddedobjectcontainer.cxx |2 -
 comphelper/source/misc/storagehelper.cxx|2 -
 comphelper/source/streaming/memorystream.cxx|4 +--
 comphelper/source/streaming/seekableinput.cxx   |2 -
 io/source/TextInputStream/TextInputStream.cxx   |4 +--
 io/source/acceptor/acc_pipe.cxx |6 ++--
 io/source/connector/ctr_pipe.cxx|6 ++--
 package/source/xstor/ocompinstream.cxx  |2 -
 package/source/xstor/ohierarchyholder.cxx   |4 +--
 package/source/xstor/owriteablestream.cxx   |   20 
 package/source/xstor/switchpersistencestream.cxx|2 -
 11 files changed, 27 insertions(+), 27 deletions(-)

New commits:
commit 960252e129bb72e10790672a5650c0ce24e0f1e0
Author: Noel Grandin 
AuthorDate: Sat Sep 26 21:58:18 2020 +0200
Commit: Noel Grandin 
CommitDate: Sun Sep 27 09:50:31 2020 +0200

improve some exception messages

Change-Id: Ifc5d940fbf77ae13071c299fb6168bdc55dc5c95
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103493
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/comphelper/source/container/embeddedobjectcontainer.cxx 
b/comphelper/source/container/embeddedobjectcontainer.cxx
index 92b93a1ff704..944a4dd5b25f 100644
--- a/comphelper/source/container/embeddedobjectcontainer.cxx
+++ b/comphelper/source/container/embeddedobjectcontainer.cxx
@@ -88,7 +88,7 @@ const uno::Reference < embed::XStorage >& 
EmbedImpl::GetReplacements()
 }
 
 if ( !mxImageStorage.is() )
-throw io::IOException();
+throw io::IOException("No ObjectReplacements");
 
 return mxImageStorage;
 }
diff --git a/comphelper/source/misc/storagehelper.cxx 
b/comphelper/source/misc/storagehelper.cxx
index c5bff7559f6a..6f86a56484fb 100644
--- a/comphelper/source/misc/storagehelper.cxx
+++ b/comphelper/source/misc/storagehelper.cxx
@@ -218,7 +218,7 @@ void OStorageHelper::SetCommonStorageEncryptionData(
 {
 uno::Reference< embed::XEncryptionProtectedStorage > xEncrSet( xStorage, 
uno::UNO_QUERY );
 if ( !xEncrSet.is() )
-throw io::IOException(); // TODO
+throw io::IOException("no XEncryptionProtectedStorage"); // TODO
 
 if ( aEncryptionData.getLength() == 2 &&
  aEncryptionData[0].Name == "GpgInfos" &&
diff --git a/comphelper/source/streaming/memorystream.cxx 
b/comphelper/source/streaming/memorystream.cxx
index b275ac34b06e..b8ff86e03b17 100644
--- a/comphelper/source/streaming/memorystream.cxx
+++ b/comphelper/source/streaming/memorystream.cxx
@@ -124,7 +124,7 @@ Reference< XOutputStream > SAL_CALL 
UNOMemoryStream::getOutputStream(  )
 sal_Int32 SAL_CALL UNOMemoryStream::readBytes( Sequence< sal_Int8 >& aData, 
sal_Int32 nBytesToRead )
 {
 if( nBytesToRead < 0 )
-throw IOException();
+throw IOException("nBytesToRead < 0");
 
 nBytesToRead = std::min( nBytesToRead, available() );
 aData.realloc( nBytesToRead );
@@ -149,7 +149,7 @@ sal_Int32 SAL_CALL UNOMemoryStream::readSomeBytes( 
Sequence< sal_Int8 >& aData,
 void SAL_CALL UNOMemoryStream::skipBytes( sal_Int32 nBytesToSkip )
 {
 if( nBytesToSkip < 0 )
-throw IOException();
+throw IOException("nBytesToSkip < 0");
 
 mnCursor += std::min( nBytesToSkip, available() );
 }
diff --git a/comphelper/source/streaming/seekableinput.cxx 
b/comphelper/source/streaming/seekableinput.cxx
index e4f654043dc7..905e739e85a1 100644
--- a/comphelper/source/streaming/seekableinput.cxx
+++ b/comphelper/source/streaming/seekableinput.cxx
@@ -110,7 +110,7 @@ void OSeekableInputWrapper::PrepareCopy_Impl()
 }
 
 if ( !m_xCopyInput.is() )
-throw io::IOException();
+throw io::IOException("no m_xCopyInput");
 }
 
 // XInputStream
diff --git a/io/source/TextInputStream/TextInputStream.cxx 
b/io/source/TextInputStream/TextInputStream.cxx
index 0c40aaa5935c..644db6fb3177 100644
--- a/io/source/TextInputStream/TextInputStream.cxx
+++ b/io/source/TextInputStream/TextInputStream.cxx
@@ -314,12 +314,12 @@ sal_Int32 OTextInputStream::implReadNext()
 }
 catch( NotConnectedException& )
 {
-throw IOException();
+throw IOException("Not connected");
 //throw IOException( L"OTextInputStream::implReadString failed" );
 }
 catch( BufferSizeExceededException& )
 {
-throw IOException();
+throw IOException("Buffer size exceeded");
 }
 }
 
diff --git a/io/source/acceptor/acc_pipe.cxx b/io/source/acceptor/acc_pipe.cxx
index b06b0aa678bc..69f1cad79206 100644
--- a/io/source/acceptor/acc_pipe.cxx
+++ b/io/source/acceptor/acc_pipe.cxx
@@ -73,7 +73,7 @@ namespace io_acceptor
 {
 if( m_nStatus )
 {
-throw IOException();
+throw IOException("pipe already closed");
 }
 if( aReadBytes.getLength() < nBytesToRead )
 {
@@ -93,11 

[Libreoffice-commits] core.git: bridges/source

2020-09-27 Thread Andrea Gelmini (via logerrit)
 bridges/source/cpp_uno/msvc_shared/cpp2uno.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit cceaf762a6693a60147ae49f7e004ca6ca54188b
Author: Andrea Gelmini 
AuthorDate: Sat Sep 26 21:13:31 2020 +0200
Commit: Julien Nabet 
CommitDate: Sun Sep 27 09:51:11 2020 +0200

Fix typo

Change-Id: I3792328b8e768d069e1a5a593cd811764bf7b5b9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103492
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/bridges/source/cpp_uno/msvc_shared/cpp2uno.cxx 
b/bridges/source/cpp_uno/msvc_shared/cpp2uno.cxx
index 51186d1859fc..e114a1019df7 100644
--- a/bridges/source/cpp_uno/msvc_shared/cpp2uno.cxx
+++ b/bridges/source/cpp_uno/msvc_shared/cpp2uno.cxx
@@ -96,7 +96,7 @@ cpp2uno_call(bridges::cpp_uno::shared::CppInterfaceProxy* 
pThis,
 {
 pCppArgs[nPos] = pCppIncomingParams;
 pUnoArgs[nPos] = pCppIncomingParams;
-if (sizeof(void*) == sizeof(sal_Int32)) // acccount 64bit types on 
32bit arch
+if (sizeof(void*) == sizeof(sal_Int32)) // account 64bit types on 
32bit arch
 {
 switch (pParamTD->eTypeClass)
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: oox/qa

2020-09-27 Thread Andrea Gelmini (via logerrit)
 oox/qa/unit/CryptoTest.cxx |6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 9623845206e18c6e8c76402fe538aeda95cfab9d
Author: Andrea Gelmini 
AuthorDate: Sat Sep 26 21:04:11 2020 +0200
Commit: Julien Nabet 
CommitDate: Sun Sep 27 09:52:54 2020 +0200

Fix typo in code

Tested before split here:
https://gerrit.libreoffice.org/c/core/+/103464

Change-Id: Iadc9dd49762ec63bd8b3edba322bcbf5d0f862a3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103487
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/oox/qa/unit/CryptoTest.cxx b/oox/qa/unit/CryptoTest.cxx
index c4058619e5c9..15f9ae158dc4 100644
--- a/oox/qa/unit/CryptoTest.cxx
+++ b/oox/qa/unit/CryptoTest.cxx
@@ -29,7 +29,7 @@ public:
 void testRoundUp();
 void testStandard2007();
 void testAgileEncryptionVerifier();
-void testAgileEncrpytionInfoWritingAndParsing();
+void testAgileEncryptionInfoWritingAndParsing();
 void testAgileDataIntegrityHmacKey();
 void testAgileEncryptingAndDecrypting();
 
@@ -38,7 +38,7 @@ public:
 CPPUNIT_TEST(testRoundUp);
 CPPUNIT_TEST(testStandard2007);
 CPPUNIT_TEST(testAgileEncryptionVerifier);
-CPPUNIT_TEST(testAgileEncrpytionInfoWritingAndParsing);
+CPPUNIT_TEST(testAgileEncryptionInfoWritingAndParsing);
 CPPUNIT_TEST(testAgileDataIntegrityHmacKey);
 CPPUNIT_TEST(testAgileEncryptingAndDecrypting);
 CPPUNIT_TEST_SUITE_END();
@@ -192,7 +192,7 @@ void CryptoTest::testAgileEncryptionVerifier()
 CPPUNIT_ASSERT_EQUAL(true, aEngine.decryptAndCheckVerifierHash(aPassword));
 }
 
-void CryptoTest::testAgileEncrpytionInfoWritingAndParsing()
+void CryptoTest::testAgileEncryptionInfoWritingAndParsing()
 {
 OUString aPassword("Password");
 std::vector aKeyDataSalt;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: cui/source

2020-09-27 Thread Andrea Gelmini (via logerrit)
 cui/source/inc/border.hxx  |4 ++--
 cui/source/tabpages/border.cxx |   22 +++---
 2 files changed, 13 insertions(+), 13 deletions(-)

New commits:
commit b35aefac5682d99c172bc24681200aee7b327bf3
Author: Andrea Gelmini 
AuthorDate: Sat Sep 26 22:18:50 2020 +0200
Commit: Julien Nabet 
CommitDate: Sun Sep 27 09:52:14 2020 +0200

Fix typo in code

It passed "make check" on Linux

Change-Id: I95f8fcdbfb2344624a2ec4cf0780b0af3bc7ba16
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103498
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/cui/source/inc/border.hxx b/cui/source/inc/border.hxx
index 81c0216376e5..57f5d5d0919f 100644
--- a/cui/source/inc/border.hxx
+++ b/cui/source/inc/border.hxx
@@ -152,8 +152,8 @@ private:
 std::unique_ptr m_xMergeWithNextCB;
 // #i29550#
 std::unique_ptr m_xMergeAdjacentBordersCB;
-std::unique_ptr m_xRemoveAdjcentCellBordersCB;
-std::unique_ptr m_xRemoveAdjcentCellBordersFT;
+std::unique_ptr m_xRemoveAdjacentCellBordersCB;
+std::unique_ptr m_xRemoveAdjacentCellBordersFT;
 std::unique_ptr m_xShadowControls;
 std::unique_ptr m_xMarginControls;
 
diff --git a/cui/source/tabpages/border.cxx b/cui/source/tabpages/border.cxx
index 4f42609ec0cf..0c8fda14defe 100644
--- a/cui/source/tabpages/border.cxx
+++ b/cui/source/tabpages/border.cxx
@@ -276,8 +276,8 @@ SvxBorderTabPage::SvxBorderTabPage(weld::Container* pPage, 
weld::DialogControlle
 , m_xPropertiesFrame(m_xBuilder->weld_container("properties"))
 , m_xMergeWithNextCB(m_xBuilder->weld_check_button("mergewithnext"))
 , m_xMergeAdjacentBordersCB(m_xBuilder->weld_check_button("mergeadjacent"))
-, 
m_xRemoveAdjcentCellBordersCB(m_xBuilder->weld_check_button("rmadjcellborders"))
-, 
m_xRemoveAdjcentCellBordersFT(m_xBuilder->weld_label("rmadjcellbordersft"))
+, 
m_xRemoveAdjacentCellBordersCB(m_xBuilder->weld_check_button("rmadjcellborders"))
+, 
m_xRemoveAdjacentCellBordersFT(m_xBuilder->weld_label("rmadjcellbordersft"))
 {
 static std::vector aBorderImageIds;
 
@@ -525,14 +525,14 @@ SvxBorderTabPage::SvxBorderTabPage(weld::Container* 
pPage, weld::DialogControlle
 }
 if( bIsCalcDoc )
 {
-m_xRemoveAdjcentCellBordersCB->connect_toggled(LINK(this, 
SvxBorderTabPage, RemoveAdjacentCellBorderHdl_Impl));
-m_xRemoveAdjcentCellBordersCB->show();
-m_xRemoveAdjcentCellBordersCB->set_sensitive(false);
+m_xRemoveAdjacentCellBordersCB->connect_toggled(LINK(this, 
SvxBorderTabPage, RemoveAdjacentCellBorderHdl_Impl));
+m_xRemoveAdjacentCellBordersCB->show();
+m_xRemoveAdjacentCellBordersCB->set_sensitive(false);
 }
 else
 {
-m_xRemoveAdjcentCellBordersCB->hide();
-m_xRemoveAdjcentCellBordersFT->hide();
+m_xRemoveAdjacentCellBordersCB->hide();
+m_xRemoveAdjacentCellBordersFT->hide();
 }
 }
 
@@ -820,8 +820,8 @@ void SvxBorderTabPage::Reset( const SfxItemSet* rSet )
 m_xSynchronizeCB->set_active(mbSync);
 
 mbRemoveAdjacentCellBorders = false;
-m_xRemoveAdjcentCellBordersCB->set_active(false);
-m_xRemoveAdjcentCellBordersCB->set_sensitive(false);
+m_xRemoveAdjacentCellBordersCB->set_active(false);
+m_xRemoveAdjacentCellBordersCB->set_sensitive(false);
 }
 
 void SvxBorderTabPage::ChangesApplied()
@@ -1499,12 +1499,12 @@ void SvxBorderTabPage::UpdateRemoveAdjCellBorderCB( 
sal_uInt16 nPreset )
 if( !bBorderDeletionReq && ( nPreset == IID_PRE_CELL_NONE || nPreset == 
IID_PRE_TABLE_NONE ) )
 bBorderDeletionReq = true;
 
-m_xRemoveAdjcentCellBordersCB->set_sensitive(bBorderDeletionReq);
+m_xRemoveAdjacentCellBordersCB->set_sensitive(bBorderDeletionReq);
 
 if( !bBorderDeletionReq )
 {
 mbRemoveAdjacentCellBorders = false;
-m_xRemoveAdjcentCellBordersCB->set_active(false);
+m_xRemoveAdjacentCellBordersCB->set_active(false);
 }
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Branch 'libreoffice-7-0' - sw/inc sw/source

2020-09-27 Thread Caolán McNamara (via logerrit)
 sw/inc/AnnotationWin.hxx|3 +++
 sw/source/uibase/docvw/AnnotationMenuButton.cxx |7 +++
 sw/source/uibase/docvw/AnnotationWin2.cxx   |   15 +++
 3 files changed, 21 insertions(+), 4 deletions(-)

New commits:
commit 730b66f96431a1469ac280eccdc2d24d9d41e4fe
Author: Caolán McNamara 
AuthorDate: Thu Sep 17 11:24:37 2020 +0100
Commit: Adolfo Jayme Barrientos 
CommitDate: Mon Sep 28 05:19:14 2020 +0200

tdf#136682 set the sidebar of the menubutton as active on execute command

so the command will be executed on the expected sidebar window

Change-Id: Ic7ffe363005292edeb93c5a1220a9bcb97096c4a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102772
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/sw/inc/AnnotationWin.hxx b/sw/inc/AnnotationWin.hxx
index 080d8de42ef0..32630399c9d0 100644
--- a/sw/inc/AnnotationWin.hxx
+++ b/sw/inc/AnnotationWin.hxx
@@ -194,6 +194,9 @@ class SAL_DLLPUBLIC_RTTI SwAnnotationWin : public 
vcl::Window
 bool IsResolved() const;
 bool IsThreadResolved();
 
+// Set this SwAnnotationWin as the currently active one
+void SetActiveSidebarWin();
+
 /// Find the first annotation for the thread which this annotation is 
in.
 /// This may be the same annotation as this one.
 SwAnnotationWin*   GetTopReplyNote();
diff --git a/sw/source/uibase/docvw/AnnotationMenuButton.cxx 
b/sw/source/uibase/docvw/AnnotationMenuButton.cxx
index f56e745c1641..58e4f7a8a610 100644
--- a/sw/source/uibase/docvw/AnnotationMenuButton.cxx
+++ b/sw/source/uibase/docvw/AnnotationMenuButton.cxx
@@ -67,6 +67,13 @@ void AnnotationMenuButton::dispose()
 void AnnotationMenuButton::Select()
 {
 OString sIdent = GetCurItemIdent();
+if (sIdent.isEmpty())
+return;
+
+// tdf#136682 ensure this is the currently active sidebar win so the 
command
+// operates in an active sidebar context
+mrSidebarWin.SetActiveSidebarWin();
+
 if (sIdent == "reply")
 mrSidebarWin.ExecuteCommand(FN_REPLY);
 if (sIdent == "resolve" || sIdent == "unresolve")
diff --git a/sw/source/uibase/docvw/AnnotationWin2.cxx 
b/sw/source/uibase/docvw/AnnotationWin2.cxx
index 2801159850ad..f74ff69fdb25 100644
--- a/sw/source/uibase/docvw/AnnotationWin2.cxx
+++ b/sw/source/uibase/docvw/AnnotationWin2.cxx
@@ -1326,14 +1326,21 @@ IMPL_LINK( SwAnnotationWin, WindowEventListener, 
VclWindowEvent&, rEvent, void )
 else if ( rEvent.GetId() == VclEventId::WindowActivate &&
   rEvent.GetWindow() == mpSidebarTextControl )
 {
-const bool bLockView = mrView.GetWrtShell().IsViewLocked();
-mrView.GetWrtShell().LockView( true );
-mrMgr.SetActiveSidebarWin( this );
-mrView.GetWrtShell().LockView( bLockView );
+SetActiveSidebarWin();
 mrMgr.MakeVisible( this );
 }
 }
 
+void SwAnnotationWin::SetActiveSidebarWin()
+{
+if (mrMgr.GetActiveSidebarWin() == this)
+return;
+const bool bLockView = mrView.GetWrtShell().IsViewLocked();
+mrView.GetWrtShell().LockView( true );
+mrMgr.SetActiveSidebarWin(this);
+mrView.GetWrtShell().LockView( bLockView );
+}
+
 IMPL_LINK(SwAnnotationWin, ScrollHdl, ScrollBar*, pScroll, void)
 {
 long nDiff = GetOutlinerView()->GetEditView().GetVisArea().Top() - 
pScroll->GetThumbPos();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: package/source

2020-09-27 Thread Julien Nabet (via logerrit)
 package/source/xstor/xstorage.hxx |1 -
 1 file changed, 1 deletion(-)

New commits:
commit 21484629ef81dc0d081fa07866cd164d2450cf1d
Author: Julien Nabet 
AuthorDate: Sun Sep 27 11:59:53 2020 +0200
Commit: Julien Nabet 
CommitDate: Sun Sep 27 12:42:27 2020 +0200

Remove unused std::list in package/xstorage

Change-Id: I4ac4176d60c29645bd8bc5922154cd3b83dac73e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103500
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/package/source/xstor/xstorage.hxx 
b/package/source/xstor/xstorage.hxx
index 6e19a36838f4..959a7aea72e6 100644
--- a/package/source/xstor/xstorage.hxx
+++ b/package/source/xstor/xstorage.hxx
@@ -51,7 +51,6 @@
 #include 
 #include 
 
-#include 
 #include 
 #include 
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: package/source

2020-09-27 Thread Julien Nabet (via logerrit)
 package/source/xstor/ohierarchyholder.cxx |2 +-
 package/source/xstor/ohierarchyholder.hxx |7 +++
 2 files changed, 4 insertions(+), 5 deletions(-)

New commits:
commit 5c2263fa4e6c66f9dff2d624674713dbc4fa5b5a
Author: Julien Nabet 
AuthorDate: Sun Sep 27 12:00:24 2020 +0200
Commit: Julien Nabet 
CommitDate: Sun Sep 27 12:51:28 2020 +0200

Replace list by vector in package/ohierarchyholder

+ rename OWeakStorRefList_Impl to OWeakStorRefVector_Impl
to make it more explicit

Change-Id: I231c9e582cbfb4670835fe1ef0ce41692ad8dcb3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103501
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/package/source/xstor/ohierarchyholder.cxx 
b/package/source/xstor/ohierarchyholder.cxx
index e2f629fa809a..55348f08547c 100644
--- a/package/source/xstor/ohierarchyholder.cxx
+++ b/package/source/xstor/ohierarchyholder.cxx
@@ -262,7 +262,7 @@ void SAL_CALL OHierarchyElement_Impl::disposing( const 
lang::EventObject& Source
 uno::Reference< embed::XExtendedStorageStream > 
xStream(Source.Source, uno::UNO_QUERY);
 
 m_aOpenStreams.erase(std::remove_if(m_aOpenStreams.begin(), 
m_aOpenStreams.end(),
-[](const OWeakStorRefList_Impl::value_type& rxStorage) 
{
+[](const OWeakStorRefVector_Impl::value_type& 
rxStorage) {
 return !rxStorage.get().is() || rxStorage.get() == xStream; }),
 m_aOpenStreams.end());
 }
diff --git a/package/source/xstor/ohierarchyholder.hxx 
b/package/source/xstor/ohierarchyholder.hxx
index 2c2db2662e13..97637c1a9ab0 100644
--- a/package/source/xstor/ohierarchyholder.hxx
+++ b/package/source/xstor/ohierarchyholder.hxx
@@ -30,7 +30,6 @@
 
 #include 
 
-#include 
 #include 
 #include 
 
@@ -39,8 +38,8 @@ struct OHierarchyElement_Impl;
 typedef std::unordered_map< OUString,
  ::rtl::Reference< OHierarchyElement_Impl > > 
OHierarchyElementList_Impl;
 
-typedef ::std::list< css::uno::WeakReference< 
css::embed::XExtendedStorageStream > >
-OWeakStorRefList_Impl;
+typedef ::std::vector< css::uno::WeakReference< 
css::embed::XExtendedStorageStream > >
+OWeakStorRefVector_Impl;
 
 struct OHierarchyElement_Impl : public cppu::WeakImplHelper< 
css::embed::XTransactionListener >
 {
@@ -52,7 +51,7 @@ struct OHierarchyElement_Impl : public cppu::WeakImplHelper< 
css::embed::XTransa
 
 OHierarchyElementList_Impl m_aChildren;
 
-OWeakStorRefList_Impl m_aOpenStreams;
+OWeakStorRefVector_Impl m_aOpenStreams;
 
 public:
 explicit OHierarchyElement_Impl( const css::uno::Reference< 
css::embed::XStorage >& xStorage )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Branch 'distro/lhm/libreoffice-6-4+backports' - desktop/source officecfg/registry stoc/source

2020-09-27 Thread Serge Krot (via logerrit)
 desktop/source/app/app.cxx |   51 +
 officecfg/registry/schema/org/openoffice/Office/Common.xcs |7 +
 stoc/source/javaloader/javaloader.cxx  |8 +-
 3 files changed, 65 insertions(+), 1 deletion(-)

New commits:
commit d0fdfe0e92a1989c61613fcb8deeb3256eb0816a
Author: Serge Krot 
AuthorDate: Wed Mar 25 16:56:18 2020 +0100
Commit: Thorsten Behrens 
CommitDate: Sun Sep 27 12:03:08 2020 +0200

speed-up: preload JVM when PreloadJVM is set

Change-Id: I57f77f127f7cb45fb181b755b40873d47015e5b2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91059
Tested-by: Thorsten Behrens 
Reviewed-by: Thorsten Behrens 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103390

diff --git a/desktop/source/app/app.cxx b/desktop/source/app/app.cxx
index e5d0939b2e93..2da91af2cccb 100644
--- a/desktop/source/app/app.cxx
+++ b/desktop/source/app/app.cxx
@@ -83,6 +83,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include 
 #include 
@@ -129,6 +130,7 @@
 #include 
 #include 
 #include "langselect.hxx"
+#include 
 
 #if defined MACOSX
 #include 
@@ -1217,6 +1219,38 @@ void Desktop::AppEvent( const ApplicationEvent& 
rAppEvent )
 HandleAppEvent( rAppEvent );
 }
 
+namespace {
+
+class JVMloadThread : public salhelper::Thread {
+public:
+JVMloadThread() : salhelper::Thread("Preload JVM thread")
+{
+}
+
+private:
+virtual void execute() override final
+{
+Reference< XMultiServiceFactory > xSMgr = 
comphelper::getProcessServiceFactory();
+
+Reference< css::loader::XImplementationLoader > xJavaComponentLoader(
+
xSMgr->createInstance("com.sun.star.comp.stoc.JavaComponentLoader"),
+css::uno::UNO_QUERY_THROW);
+
+if (xJavaComponentLoader.is())
+{
+const css::uno::Reference< 
::com::sun::star::registry::XRegistryKey > xRegistryKey;
+try
+{
+xJavaComponentLoader->activate("", "", "", xRegistryKey);
+}
+catch (...)
+{
+SAL_WARN("desktop.app", "Cannot activate factory during JVM 
preloading");
+}
+}
+}
+};
+
 struct ExecuteGlobals
 {
 Reference < css::document::XDocumentEventListener > xGlobalBroadcaster;
@@ -1224,12 +1258,14 @@ struct ExecuteGlobals
 bool bUseSystemFileDialog;
 std::unique_ptr pLanguageOptions;
 std::unique_ptr pPathOptions;
+rtl::Reference< JVMloadThread > xJVMloadThread;
 
 ExecuteGlobals()
 : bRestartRequested( false )
 , bUseSystemFileDialog( true )
 {}
 };
+}
 
 static ExecuteGlobals* pExecGlobals = nullptr;
 
@@ -1254,6 +1290,15 @@ int Desktop::Main()
 // Detect desktop environment - need to do this as early as possible
 css::uno::setCurrentContext( new DesktopContext( 
css::uno::getCurrentContext() ) );
 
+if (officecfg::Office::Common::Misc::PreloadJVM::get() && pExecGlobals)
+{
+SAL_INFO("desktop.app", "Preload JVM");
+
+// pre-load JVM
+pExecGlobals->xJVMloadThread = new JVMloadThread();
+pExecGlobals->xJVMloadThread->launch();
+}
+
 CommandLineArgs& rCmdLineArgs = GetCommandLineArgs();
 
 Translate::SetReadStringHook(ReplaceStringHookProc);
@@ -1663,6 +1708,12 @@ int Desktop::doShutdown()
 if (m_aUpdateThread.joinable())
 m_aUpdateThread.join();
 
+if (pExecGlobals->xJVMloadThread.is())
+{
+pExecGlobals->xJVMloadThread->join();
+pExecGlobals->xJVMloadThread.clear();
+}
+
 pExecGlobals->bRestartRequested = pExecGlobals->bRestartRequested ||
 OfficeRestartManager::get(comphelper::getProcessComponentContext())->
 isRestartRequested(true);
diff --git a/officecfg/registry/schema/org/openoffice/Office/Common.xcs 
b/officecfg/registry/schema/org/openoffice/Office/Common.xcs
index cebb7d7ec0ef..3a9472e924fc 100644
--- a/officecfg/registry/schema/org/openoffice/Office/Common.xcs
+++ b/officecfg/registry/schema/org/openoffice/Office/Common.xcs
@@ -5723,6 +5723,13 @@
 
 true
   
+  
+
+  Specifies if the JVM should be preloaded during LO start 
up.
+  PreloadJVM
+
+false
+  
   
 
   List of URLs of the places the user bookmarked in the file 
picker dialog.
diff --git a/stoc/source/javaloader/javaloader.cxx 
b/stoc/source/javaloader/javaloader.cxx
index 4af288f737b8..36b26c0a609d 100644
--- a/stoc/source/javaloader/javaloader.cxx
+++ b/stoc/source/javaloader/javaloader.cxx
@@ -311,11 +311,17 @@ sal_Bool SAL_CALL JavaComponentLoader::writeRegistryInfo(
 return loader->writeRegistryInfo(xKey, blabla, rLibName);
 }
 
-
 css::uno::Reference SAL_CALL JavaComponentLoader::activate(
 const OUString & rImplName, const OUString & blabla, const OUString & 
rLibName,
 const css::uno::Reference & xKey)
 {
+if (rImplName.isEmpty() && blabla.isEmpty() && 

[Libreoffice-commits] core.git: odk/examples

2020-09-27 Thread Stephan Bergmann (via logerrit)
 odk/examples/DevelopersGuide/Components/Thumbs/Makefile |2 ++
 1 file changed, 2 insertions(+)

New commits:
commit 37a96d9fa4f5a6dbc7e7eabed169535cf276284e
Author: Stephan Bergmann 
AuthorDate: Sun Sep 27 12:22:18 2020 +0200
Commit: Stephan Bergmann 
CommitDate: Sun Sep 27 13:40:25 2020 +0200

Fix an odk/examples dependency

ImageShrink.oxt is created in the org/openoffice/comp/test sub-make, and
CustomTarget_odk/build-examples_java had once failed for me with

> make[2]: *** No rule to make target 
'~/lo/core/workdir/CustomTarget/odk/build-examples_java/out/sdk/LINUXexample.out/bin/ImageShrink.oxt',
 needed by 'ComponentsThumbsExample'.  Stop.

Change-Id: I926d0691e7eee3506d4afe2eda1a2fc873422e18
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103502
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/odk/examples/DevelopersGuide/Components/Thumbs/Makefile 
b/odk/examples/DevelopersGuide/Components/Thumbs/Makefile
index 95adaef3d1d5..7a7ac34f7159 100644
--- a/odk/examples/DevelopersGuide/Components/Thumbs/Makefile
+++ b/odk/examples/DevelopersGuide/Components/Thumbs/Makefile
@@ -58,6 +58,8 @@ $(SUBDIRS) :
 
 org/openoffice/comp/test : org/openoffice/test
 
+$(COMP_PACKAGE): org/openoffice/comp/test
+
 ComponentsThumbsExample : $(COMP_PACKAGE)
@echo 

@echo Please use one of the following command to execute the example!
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] online.git: Branch 'distro/collabora/co-6-4' - loleaflet/l10n loleaflet/src

2020-09-27 Thread Andras Timar (via logerrit)
 loleaflet/l10n/uno/af.json  |1 +
 loleaflet/l10n/uno/am.json  |1 +
 loleaflet/l10n/uno/bg.json  |1 +
 loleaflet/l10n/uno/ca-valencia.json |1 +
 loleaflet/l10n/uno/ca.json  |1 +
 loleaflet/l10n/uno/cs.json  |1 +
 loleaflet/l10n/uno/cy.json  |1 +
 loleaflet/l10n/uno/da.json  |1 +
 loleaflet/l10n/uno/de.json  |1 +
 loleaflet/l10n/uno/dsb.json |1 +
 loleaflet/l10n/uno/el.json  |1 +
 loleaflet/l10n/uno/en-GB.json   |1 +
 loleaflet/l10n/uno/eo.json  |1 +
 loleaflet/l10n/uno/es.json  |1 +
 loleaflet/l10n/uno/et.json  |1 +
 loleaflet/l10n/uno/eu.json  |1 +
 loleaflet/l10n/uno/fi.json  |1 +
 loleaflet/l10n/uno/fr.json  |1 +
 loleaflet/l10n/uno/fy.json  |1 +
 loleaflet/l10n/uno/gl.json  |1 +
 loleaflet/l10n/uno/hr.json  |1 +
 loleaflet/l10n/uno/hsb.json |1 +
 loleaflet/l10n/uno/hu.json  |1 +
 loleaflet/l10n/uno/id.json  |1 +
 loleaflet/l10n/uno/is.json  |1 +
 loleaflet/l10n/uno/it.json  |1 +
 loleaflet/l10n/uno/ja.json  |1 +
 loleaflet/l10n/uno/kk.json  |1 +
 loleaflet/l10n/uno/lt.json  |1 +
 loleaflet/l10n/uno/lv.json  |1 +
 loleaflet/l10n/uno/nb.json  |1 +
 loleaflet/l10n/uno/nl.json  |1 +
 loleaflet/l10n/uno/nn.json  |1 +
 loleaflet/l10n/uno/pl.json  |1 +
 loleaflet/l10n/uno/pt-BR.json   |1 +
 loleaflet/l10n/uno/pt.json  |1 +
 loleaflet/l10n/uno/ru.json  |1 +
 loleaflet/l10n/uno/sk.json  |1 +
 loleaflet/l10n/uno/sl.json  |1 +
 loleaflet/l10n/uno/sv.json  |1 +
 loleaflet/l10n/uno/tr.json  |1 +
 loleaflet/l10n/uno/uk.json  |1 +
 loleaflet/l10n/uno/vec.json |1 +
 loleaflet/l10n/uno/zh-CN.json   |1 +
 loleaflet/l10n/uno/zh-TW.json   |1 +
 loleaflet/src/unocommands.js|2 +-
 46 files changed, 46 insertions(+), 1 deletion(-)

New commits:
commit 2908b23d71affd50414cec04557078245eb7dc0e
Author: Andras Timar 
AuthorDate: Sun Sep 27 13:46:04 2020 +0200
Commit: Andras Timar 
CommitDate: Sun Sep 27 13:48:09 2020 +0200

[cp] loleflet: fix l10n of 'Edit Hyperlink...' label

Change-Id: Ib461c8e134c5dc92e6933cd58007de8f49a8b10a

diff --git a/loleaflet/l10n/uno/af.json b/loleaflet/l10n/uno/af.json
index c3dd5bed7..f68d04e63 100644
--- a/loleaflet/l10n/uno/af.json
+++ b/loleaflet/l10n/uno/af.json
@@ -45,6 +45,7 @@
 "Delete index":"Skrap indeks",
 "Demote One Level":"Een vlak af",
 "Demote One Level With Subpoints":"Een vlak af met subpunte",
+"Edit Hyperlink...":"Redigeer Hiperskakel...",
 "Find Next":"Vind volgende",
 "Font Color":"Fontkleur",
 "Foote~r":"Vo~et",
diff --git a/loleaflet/l10n/uno/am.json b/loleaflet/l10n/uno/am.json
index d5ada71a1..eba3a595e 100644
--- a/loleaflet/l10n/uno/am.json
+++ b/loleaflet/l10n/uno/am.json
@@ -72,6 +72,7 @@
 "Demote One Level With Subpoints":"አንድ ደረጃ ወደ ታች በ ንዑስ ነጥብ ዝቅ ማድረጊያ",
 "Double Underline":"ከ ስሩ በ ድርብ ማስመሪያ",
 "Duplicate ~Slide":"~ተንሸራታች ማባዣ",
+"Edit Hyperlink...":"Hyperlink ማረሚያ...",
 "E~dit Style...":"ዘዴ ማ~ረሚያ...",
 "Find & Rep~lace...":"መፈለጊያ & መተ~ኪያ...",
 "Find Next":"ቀጥሎ መፈለጊያ",
diff --git a/loleaflet/l10n/uno/bg.json b/loleaflet/l10n/uno/bg.json
index 26cfc06fb..5594c30d6 100644
--- a/loleaflet/l10n/uno/bg.json
+++ b/loleaflet/l10n/uno/bg.json
@@ -73,6 +73,7 @@
 "Demote One Level With Subpoints":"Понижаване с едно ниво заедно с подточките",
 "Double Underline":"Двойно подчертан",
 "Duplicate ~Slide":"Дублиране на кадър",
+"Edit Hyperlink...":"Редактиране на хипервръзка...",
 "E~dit Style...":"Редактиране на стил...",
 "Find & Rep~lace...":"~Търсене и замяна…",
 "Find Next":"Търсене напред",
diff --git a/loleaflet/l10n/uno/ca-valencia.json 
b/loleaflet/l10n/uno/ca-valencia.json
index 0622c4931..1afa53aa6 100644
--- a/loleaflet/l10n/uno/ca-valencia.json
+++ b/loleaflet/l10n/uno/ca-valencia.json
@@ -73,6 +73,7 @@
 "Demote One Level With Subpoints":"Un nivell cap avall amb subpunts",
 "Double Underline":"Subratllat doble",
 "Duplicate ~Slide":"Duplica la ~diapositiva",
+"Edit Hyperlink...":"Edita l'enllaç...",
 "E~dit Style...":"E~dita l'estil...",
 "Find & Rep~lace...":"Busca i reemp~laça...",
 "Find Next":"Busca el següent",
diff --git a/loleaflet/l10n/uno/ca.json b/loleaflet/l10n/uno/ca.json
index de5b9d2f3..8ec250c6d 100644
--- a/loleaflet/l10n/uno/ca.json
+++ b/loleaflet/l10n/uno/ca.json
@@ -73,6 +73,7 @@
 "Demote One Level With Subpoints":"Un nivell cap avall amb subpunts",
 "Double Underline":"Subratllat doble",
 "Duplicate ~Slide":"Duplica la ~diapositiva",
+"Edit Hyperlink...":"Edita l'enllaç...",
 "E~dit Style...":"E~dita l'estil...",
 "Find & Rep~lace...":"Cerca i reemp~laça...",
 "Find Next":"Cerca el següent",
diff --git 

[Libreoffice-commits] core.git: svx/uiconfig

2020-09-27 Thread andreas kainz (via logerrit)
 svx/uiconfig/ui/sidebarstylespanel.ui |   11 +++
 1 file changed, 11 insertions(+)

New commits:
commit 397fd597c9b478f892641dc219d7d8cd1cfd5fac
Author: andreas kainz 
AuthorDate: Fri Sep 25 22:30:03 2020 +0200
Commit: Andreas Kainz 
CommitDate: Sun Sep 27 14:15:23 2020 +0200

Sidebar: add FormatPaintbrush to SidebarStylesPanel

Change-Id: I265f803432c12f39ca0025d602c2d032c549a6c5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103469
Tested-by: Jenkins
Reviewed-by: Andreas Kainz 

diff --git a/svx/uiconfig/ui/sidebarstylespanel.ui 
b/svx/uiconfig/ui/sidebarstylespanel.ui
index 66ee89676ad7..226a095b350f 100644
--- a/svx/uiconfig/ui/sidebarstylespanel.ui
+++ b/svx/uiconfig/ui/sidebarstylespanel.ui
@@ -74,9 +74,20 @@
   
 True
 True
+3
 icons
 False
 2
+
+  
+True
+False
+  
+  
+True
+True
+  
+
 
   
 True
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: odk/build-examples_common.mk

2020-09-27 Thread Stephan Bergmann (via logerrit)
 odk/build-examples_common.mk |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 36fcb8dc0c0c1c9515cdf47ce74a272469c17087
Author: Stephan Bergmann 
AuthorDate: Sun Sep 27 12:26:06 2020 +0200
Commit: Stephan Bergmann 
CommitDate: Sun Sep 27 15:03:19 2020 +0200

Restrict odk/examples to non-parallel make

At least odk/examples/DevelopersGuide/Spreadsheet/Makefile contains two
independent invocations of unopkg (i.e., $(DEPLOYTOOL)) and
CustomTarget_odk/build-examples_java had once failed for me with

> "~/lo/core/instdir/program/unopkg" add -f 
"~/lo/core/workdir/CustomTarget/odk/build-examples_java/out/sdk/LINUXexample.out/bin/ExampleDataPilotSource.oxt"
> ERROR: unopkg cannot be started. The lock file indicates it is already 
running. If this does not apply, delete the lock file at:
> ~/lo/core/workdir/CustomTarget/odk/build-examples_java/user/.lock 
~/lo/core/desktop/source/pkgchk/unopkg/unopkg_shared.h:44
> make[2]: *** [Makefile:227: 
~/lo/core/workdir/CustomTarget/odk/build-examples_java/out/sdk/LINUXexample.out/misc/DevGuideSpreadsheetExamples/devguide_ExampleDataPilotSource_register_component.flag]
 Error 1

So make sure the `make` invoked from those CustomTarget_odk/build_exmaple* 
does
not inherit any -j flag from the outer `make`.  (I had observed this with an
explicit `make -j4` and --without-parallelism, but this should also be an 
issue
for the implicit parallelism from the default --with-parallelism.)

Change-Id: Iff368dbbcad01d3841d63c2985639ba6a3dec1f5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103504
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/odk/build-examples_common.mk b/odk/build-examples_common.mk
index abcb3a3e2593..08b8d5e3c231 100644
--- a/odk/build-examples_common.mk
+++ b/odk/build-examples_common.mk
@@ -46,7 +46,7 @@ else
UserInstallation=$(call gb_Helper_make_url,$(call 
gb_CustomTarget_get_workdir,$(1))/user) \
$(foreach my_dir,$(2), \
&& (cd $(INSTDIR)/$(SDKDIRNAME)/examples/$(my_dir) \
-   && printf 'yes\n' | LC_ALL=C make \
+   && printf 'yes\n' | LC_ALL=C make -j1 \
CC="$(CXX)" LINK="$(CXX)" LIB="$(CXX)" \
$(if $(MACOSX_SHELL_HACK), SHELL="ODK_BUILD_SHELL", ))) 
\
$(if $(MACOSX_SHELL_HACK),&& rm -f "ODK_BUILD_SHELL")) \
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: filter/source

2020-09-27 Thread Andrea Gelmini (via logerrit)
 filter/source/xslt/odf2xhtml/export/xhtml/body.xsl |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit b3a251d5f4846eee3387103b8e4e89eefdabb0d9
Author: Andrea Gelmini 
AuthorDate: Sat Sep 26 21:56:16 2020 +0200
Commit: Regina Henschel 
CommitDate: Sun Sep 27 14:40:03 2020 +0200

Fix typo

Change-Id: I27c2f4377b85436a675602aade85ae69964fff74
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103491
Tested-by: Jenkins
Reviewed-by: Regina Henschel 

diff --git a/filter/source/xslt/odf2xhtml/export/xhtml/body.xsl 
b/filter/source/xslt/odf2xhtml/export/xhtml/body.xsl
index ce2a03b8499f..83171a1f4d1a 100644
--- a/filter/source/xslt/odf2xhtml/export/xhtml/body.xsl
+++ b/filter/source/xslt/odf2xhtml/export/xhtml/body.xsl
@@ -1177,7 +1177,7 @@
 
 
 
+ Linking of the table-of-content can therefore only be 
achieved by a work-around in HTML -->
 
 
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: vcl/StaticLibrary_fuzzerstubs.mk vcl/workben

2020-09-27 Thread Caolán McNamara (via logerrit)
 vcl/StaticLibrary_fuzzerstubs.mk|1 
 vcl/workben/localestub/localedata_en_KE.cxx |  143 
 2 files changed, 144 insertions(+)

New commits:
commit 6c464d777231c3ab83494bb49bbade12c188ae0a
Author: Caolán McNamara 
AuthorDate: Sun Sep 27 14:02:08 2020 +0100
Commit: Caolán McNamara 
CommitDate: Sun Sep 27 15:04:18 2020 +0200

ofz#25983 build failure

Change-Id: I639a569f9b4f88ff8a3bf7742bde042829f1433b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103510
Tested-by: Caolán McNamara 
Reviewed-by: Caolán McNamara 

diff --git a/vcl/StaticLibrary_fuzzerstubs.mk b/vcl/StaticLibrary_fuzzerstubs.mk
index f2598c48ef98..d55d26da7e47 100644
--- a/vcl/StaticLibrary_fuzzerstubs.mk
+++ b/vcl/StaticLibrary_fuzzerstubs.mk
@@ -30,6 +30,7 @@ $(eval $(call 
gb_StaticLibrary_add_exception_objects,fuzzerstubs,\
 vcl/workben/localestub/localedata_en_HK \
 vcl/workben/localestub/localedata_en_IE \
 vcl/workben/localestub/localedata_en_IN \
+vcl/workben/localestub/localedata_en_KE \
 vcl/workben/localestub/localedata_en_JM \
 vcl/workben/localestub/localedata_en_LK \
 vcl/workben/localestub/localedata_en_MW \
diff --git a/vcl/workben/localestub/localedata_en_KE.cxx 
b/vcl/workben/localestub/localedata_en_KE.cxx
new file mode 100644
index ..f6f07101f831
--- /dev/null
+++ b/vcl/workben/localestub/localedata_en_KE.cxx
@@ -0,0 +1,143 @@
+#include 
+
+#include 
+
+extern "C" {
+
+static const sal_Unicode langID[] = { 0x65, 0x6e, 0x0 };
+static const sal_Unicode langDefaultName[] = { 0x45, 0x6e, 0x67, 0x6c, 0x69, 
0x73, 0x68, 0x0 };
+static const sal_Unicode countryID[] = { 0x4b, 0x45, 0x0 };
+static const sal_Unicode countryDefaultName[] = { 0x4b, 0x65, 0x6e, 0x79, 
0x61, 0x0 };
+static const sal_Unicode Variant[] = { 0x0 };
+
+static const sal_Unicode* LCInfoArray[]
+= { langID, langDefaultName, countryID, countryDefaultName, Variant };
+
+SAL_DLLPUBLIC_EXPORT sal_Unicode** SAL_CALL getLCInfo_en_KE(sal_Int16& count)
+{
+count = SAL_N_ELEMENTS(LCInfoArray);
+return (sal_Unicode**)LCInfoArray;
+}
+extern sal_Unicode** SAL_CALL getLocaleItem_en_GB(sal_Int16& count);
+SAL_DLLPUBLIC_EXPORT sal_Unicode** SAL_CALL getLocaleItem_en_KE(sal_Int16& 
count)
+{
+return getLocaleItem_en_GB(count);
+}
+static const sal_Unicode replaceTo0[]
+= { 0x5b, 0x24, 0x4b, 0x53, 0x68, 0x2d, 0x41, 0x43, 0x30, 0x39, 0x5d, 0x0 
};
+extern sal_Unicode const* const* SAL_CALL getAllFormats0_en_GB(sal_Int16& 
count,
+   const 
sal_Unicode*& from,
+   const 
sal_Unicode*& to);
+SAL_DLLPUBLIC_EXPORT sal_Unicode const* const* SAL_CALL
+getAllFormats0_en_KE(sal_Int16& count, const sal_Unicode*& from, const 
sal_Unicode*& to)
+{
+to = replaceTo0;
+const sal_Unicode* tmp;
+return getAllFormats0_en_GB(count, from, tmp);
+}
+extern sal_Unicode** SAL_CALL getDateAcceptancePatterns_en_GB(sal_Int16& 
count);
+SAL_DLLPUBLIC_EXPORT sal_Unicode** SAL_CALL 
getDateAcceptancePatterns_en_KE(sal_Int16& count)
+{
+return getDateAcceptancePatterns_en_GB(count);
+}
+extern sal_Unicode** SAL_CALL getCollatorImplementation_en_GB(sal_Int16& 
count);
+SAL_DLLPUBLIC_EXPORT sal_Unicode** SAL_CALL 
getCollatorImplementation_en_KE(sal_Int16& count)
+{
+return getCollatorImplementation_en_GB(count);
+}
+extern sal_Unicode** SAL_CALL getCollationOptions_en_GB(sal_Int16& count);
+SAL_DLLPUBLIC_EXPORT sal_Unicode** SAL_CALL 
getCollationOptions_en_KE(sal_Int16& count)
+{
+return getCollationOptions_en_GB(count);
+}
+extern sal_Unicode** SAL_CALL getSearchOptions_en_GB(sal_Int16& count);
+SAL_DLLPUBLIC_EXPORT sal_Unicode** SAL_CALL getSearchOptions_en_KE(sal_Int16& 
count)
+{
+return getSearchOptions_en_GB(count);
+}
+extern sal_Unicode** SAL_CALL getIndexAlgorithm_en_GB(sal_Int16& count);
+SAL_DLLPUBLIC_EXPORT sal_Unicode** SAL_CALL getIndexAlgorithm_en_KE(sal_Int16& 
count)
+{
+return getIndexAlgorithm_en_GB(count);
+}
+extern sal_Unicode** SAL_CALL getUnicodeScripts_en_GB(sal_Int16& count);
+SAL_DLLPUBLIC_EXPORT sal_Unicode** SAL_CALL getUnicodeScripts_en_KE(sal_Int16& 
count)
+{
+return getUnicodeScripts_en_GB(count);
+}
+extern sal_Unicode** SAL_CALL getFollowPageWords_en_GB(sal_Int16& count);
+SAL_DLLPUBLIC_EXPORT sal_Unicode** SAL_CALL 
getFollowPageWords_en_KE(sal_Int16& count)
+{
+return getFollowPageWords_en_GB(count);
+}
+extern sal_Unicode** SAL_CALL getAllCalendars_en_GB(sal_Int16& count);
+SAL_DLLPUBLIC_EXPORT sal_Unicode** SAL_CALL getAllCalendars_en_KE(sal_Int16& 
count)
+{
+return getAllCalendars_en_GB(count);
+}
+static const sal_Unicode defaultCurrency0[] = { 1 };
+static const sal_Unicode defaultCurrencyUsedInCompatibleFormatCodes0[] = { 1 };
+static const sal_Unicode defaultCurrencyLegacyOnly0[] = { 0 };
+static const sal_Unicode currencyID0[] = { 0x4b, 0x45, 0x53, 0x0 };

[Libreoffice-commits] core.git: configure.ac download.lst external/libwps solenv/flatpak-manifest.in

2020-09-27 Thread David Tardon (via logerrit)
 configure.ac|2 +-
 download.lst|4 ++--
 external/libwps/Library_wps.mk  |1 +
 external/libwps/libtool.patch.0 |9 +
 solenv/flatpak-manifest.in  |6 +++---
 5 files changed, 12 insertions(+), 10 deletions(-)

New commits:
commit 61b05af30133622cc67304c694edad31ebff446c
Author: David Tardon 
AuthorDate: Wed Sep 9 09:07:38 2020 +0200
Commit: David Tardon 
CommitDate: Sun Sep 27 19:02:07 2020 +0200

upload libwps 0.4.12

Change-Id: Ib787098b98f68185c1b3f6b414efbec36cad02dd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102332
Tested-by: David Tardon 
Reviewed-by: David Tardon 

diff --git a/configure.ac b/configure.ac
index 1ea6b255bb23..0db50672d5fa 100644
--- a/configure.ac
+++ b/configure.ac
@@ -8837,7 +8837,7 @@ 
libo_CHECK_SYSTEM_MODULE([libwpd],[WPD],[libwpd-0.10],["-I${WORKDIR}/UnpackedTar
 libo_CHECK_SYSTEM_MODULE([libwpg],[WPG],[libwpg-0.3])
 
 libo_CHECK_SYSTEM_MODULE([libwps],[WPS],[libwps-0.4])
-libo_PKG_VERSION([WPS], [libwps-0.4], [0.4.11])
+libo_PKG_VERSION([WPS], [libwps-0.4], [0.4.12])
 
 libo_CHECK_SYSTEM_MODULE([libvisio],[VISIO],[libvisio-0.1])
 
diff --git a/download.lst b/download.lst
index 659879a530a3..560e004ed80c 100644
--- a/download.lst
+++ b/download.lst
@@ -260,8 +260,8 @@ export WPD_TARBALL := 
libwpd-0.10.$(WPD_VERSION_MICRO).tar.xz
 export WPG_SHA256SUM := 
99b3f7f8832385748582ab8130fbb9e5607bd5179bebf9751ac1d51a53099d1c
 export WPG_VERSION_MICRO := 3
 export WPG_TARBALL := libwpg-0.3.$(WPG_VERSION_MICRO).tar.xz
-export WPS_SHA256SUM := 
a8fdaabc28654a975fa78c81873ac503ba18f0d1cdbb942f470a21d29284b4d1
-export WPS_VERSION_MICRO := 11
+export WPS_SHA256SUM := 
e21afb52a06d03b774c5a8c72679687ab64891b91ce0c3bdf2d3e97231534edb
+export WPS_VERSION_MICRO := 12
 export WPS_TARBALL := libwps-0.4.$(WPS_VERSION_MICRO).tar.xz
 export XSLTML_SHA256SUM := 
75823776fb51a9c526af904f1503a7afaaab900fba83eda64f8a41073724c870
 export XSLTML_TARBALL := a7983f859eafb2677d7ff386a023bc40-xsltml_2.1.2.zip
diff --git a/external/libwps/Library_wps.mk b/external/libwps/Library_wps.mk
index 349bdbe83c43..8986ae6e6288 100644
--- a/external/libwps/Library_wps.mk
+++ b/external/libwps/Library_wps.mk
@@ -42,6 +42,7 @@ $(eval $(call gb_Library_add_generated_exception_objects,wps,\
UnpackedTarball/libwps/src/lib/LotusStyleManager \
UnpackedTarball/libwps/src/lib/MSWrite \
UnpackedTarball/libwps/src/lib/Multiplan \
+   UnpackedTarball/libwps/src/lib/PocketWord \
UnpackedTarball/libwps/src/lib/Quattro \
UnpackedTarball/libwps/src/lib/Quattro9 \
UnpackedTarball/libwps/src/lib/Quattro9Graph \
diff --git a/external/libwps/libtool.patch.0 b/external/libwps/libtool.patch.0
index f2e10ac3822f..cc4b08ba2147 100644
--- a/external/libwps/libtool.patch.0
+++ b/external/libwps/libtool.patch.0
@@ -1,11 +1,12 @@
 --- ltmain.sh.sav  2018-08-02 14:21:34.0 +0200
 +++ ltmain.sh  2019-05-05 22:04:15.433588776 +0200
-@@ -7277,7 +7277,7 @@ func_mode_link ()
+@@ -7277,7 +7277,8 @@ func_mode_link ()
+   # -stdlib=*select c++ std lib with clang
-64|-mips[0-9]|-r[0-9][0-9]*|-xarch=*|-xtarget=*|+DA*|+DD*|-q*|-m*| \

-t[45]*|-txscale*|-p|-pg|--coverage|-fprofile-*|-F*|@*|-tp=*|--sysroot=*| \
-   
-O*|-g*|-flto*|-fwhopr*|-fuse-linker-plugin|-fstack-protector*|-stdlib=*| \
--  -fsanitize=*)
-+  -fsanitize=*|-fuse-ld=*|--ld-path=*)
+-  
-O*|-g*|-flto*|-fwhopr*|-fuse-linker-plugin|-fstack-protector*|-stdlib=*)
++  
-O*|-g*|-flto*|-fwhopr*|-fuse-linker-plugin|-fstack-protector*|-stdlib=*| \
++  -fuse-ld=*|--ld-path=*)
  func_quote_for_eval "$arg"
arg=$func_quote_for_eval_result
  func_append compile_command " $arg"
diff --git a/solenv/flatpak-manifest.in b/solenv/flatpak-manifest.in
index 50cf723eb057..df77597b7158 100644
--- a/solenv/flatpak-manifest.in
+++ b/solenv/flatpak-manifest.in
@@ -327,10 +327,10 @@
 "dest-filename": "external/tarballs/libwpg-0.3.3.tar.xz"
 },
 {
-"url": 
"https://dev-www.libreoffice.org/src/libwps-0.4.11.tar.xz;,
-"sha256": 
"a8fdaabc28654a975fa78c81873ac503ba18f0d1cdbb942f470a21d29284b4d1",
+"url": 
"https://dev-www.libreoffice.org/src/libwps-0.4.12.tar.xz;,
+"sha256": 
"e21afb52a06d03b774c5a8c72679687ab64891b91ce0c3bdf2d3e97231534edb",
 "type": "file",
-"dest-filename": "external/tarballs/libwps-0.4.11.tar.xz"
+"dest-filename": "external/tarballs/libwps-0.4.12.tar.xz"
 },
 {
 "url": 
"https://dev-www.libreoffice.org/src/libzmf-0.0.2.tar.xz;,
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org

[Libreoffice-commits] core.git: filter/Configuration_filter.mk filter/source writerperfect/source

2020-09-27 Thread David Tardon (via logerrit)
 filter/Configuration_filter.mk  |2 
 filter/source/config/fragments/filters/PocketWord_File.xcu  |   29 
++
 filter/source/config/fragments/types/writer_PocketWord_File.xcu |   29 
++
 writerperfect/source/writer/MSWorksImportFilter.cxx |3 +
 4 files changed, 63 insertions(+)

New commits:
commit 1e6e891016ae926868de493ab0e29871a2d06b95
Author: David Tardon 
AuthorDate: Sun Sep 27 15:29:44 2020 +0200
Commit: David Tardon 
CommitDate: Sun Sep 27 19:03:20 2020 +0200

restore PocketWord filter, this time backed by libwps

Change-Id: If9843ae717f58e683252c8ea55360a567978395e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103514
Tested-by: Jenkins
Reviewed-by: David Tardon 

diff --git a/filter/Configuration_filter.mk b/filter/Configuration_filter.mk
index e71ffacf8f25..d53afa704fc9 100644
--- a/filter/Configuration_filter.mk
+++ b/filter/Configuration_filter.mk
@@ -367,6 +367,7 @@ $(eval $(call 
filter_Configuration_add_types,fcfg_langpack,fcfg_writer_types.xcu
Palm_Text_Document \
StarOffice_Writer \
writer_EPUB_Document \
+   writer_PocketWord_File \
 ))
 
 $(eval $(call 
filter_Configuration_add_filters,fcfg_langpack,fcfg_writer_filters.xcu,filter/source/config/fragments/filters,\
@@ -415,6 +416,7 @@ $(eval $(call 
filter_Configuration_add_filters,fcfg_langpack,fcfg_writer_filters
Palm_Text_Document \
StarOffice_Writer \
EPUB \
+   PocketWord_File \
 ))
 
 # fcfg_web
diff --git a/filter/source/config/fragments/filters/PocketWord_File.xcu 
b/filter/source/config/fragments/filters/PocketWord_File.xcu
new file mode 100644
index ..1ce83aa68fe4
--- /dev/null
+++ b/filter/source/config/fragments/filters/PocketWord_File.xcu
@@ -0,0 +1,29 @@
+
+
+0
+writer_PocketWord_File
+com.sun.star.text.TextDocument
+
+com.sun.star.comp.Writer.MSWorksImportFilter
+
+
+Pocket Word
+
+IMPORT ALIEN 
3RDPARTYFILTER
+
diff --git a/filter/source/config/fragments/types/writer_PocketWord_File.xcu 
b/filter/source/config/fragments/types/writer_PocketWord_File.xcu
new file mode 100644
index ..3f146aba5e26
--- /dev/null
+++ b/filter/source/config/fragments/types/writer_PocketWord_File.xcu
@@ -0,0 +1,29 @@
+
+
+com.sun.star.comp.Writer.MSWorksImportFilter
+
+psw
+application/x-pocket-word
+false
+PocketWord File
+
+Pocket Word
+
+doctype:pwi
+
diff --git a/writerperfect/source/writer/MSWorksImportFilter.cxx 
b/writerperfect/source/writer/MSWorksImportFilter.cxx
index 5339d9e3f202..ab0efc04f670 100644
--- a/writerperfect/source/writer/MSWorksImportFilter.cxx
+++ b/writerperfect/source/writer/MSWorksImportFilter.cxx
@@ -115,6 +115,9 @@ bool 
MSWorksImportFilter::doDetectFormat(librevenge::RVNGInputStream& rInput, OU
 case libwps::WPS_RESERVED_1:
 rTypeName = "writer_DosWord";
 break;
+case libwps::WPS_RESERVED_4:
+rTypeName = "writer_PocketWord_File";
+break;
 default:
 break;
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: writerperfect/qa

2020-09-27 Thread David Tardon (via logerrit)
 writerperfect/qa/unit/WpftWriterFilterTest.cxx   |1 +
 writerperfect/qa/unit/data/writer/libwps/pass/PocketWord.psw |binary
 2 files changed, 1 insertion(+)

New commits:
commit 9b9d668d45dce3f318d89d54725a4d6cfc750315
Author: David Tardon 
AuthorDate: Sun Sep 27 15:21:42 2020 +0200
Commit: David Tardon 
CommitDate: Sun Sep 27 19:04:06 2020 +0200

add import test file for Pocket Word

Change-Id: Idbd2ddb113f77a6dc3966110757c4037d993bd4a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103515
Tested-by: Jenkins
Reviewed-by: David Tardon 

diff --git a/writerperfect/qa/unit/WpftWriterFilterTest.cxx 
b/writerperfect/qa/unit/WpftWriterFilterTest.cxx
index 8bc4c7cadbb3..6f88c694682b 100644
--- a/writerperfect/qa/unit/WpftWriterFilterTest.cxx
+++ b/writerperfect/qa/unit/WpftWriterFilterTest.cxx
@@ -48,6 +48,7 @@ void WpftWriterFilterTest::test()
 { "Writer_3.1.sdw", REQUIRE_STAROFFICE_VERSION(0, 0, 2) },
 };
 const writerperfect::test::WpftOptionalMap_t aWpsOptional{
+{ "PocketWord.psw", REQUIRE_WPS_VERSION(0, 4, 12) },
 { "Word_5.0_DOS.doc", REQUIRE_WPS_VERSION(0, 4, 3) },
 { "Write_3.1.wri", REQUIRE_WPS_VERSION(0, 4, 2) },
 };
diff --git a/writerperfect/qa/unit/data/writer/libwps/pass/PocketWord.psw 
b/writerperfect/qa/unit/data/writer/libwps/pass/PocketWord.psw
new file mode 100644
index ..75c0b60f397c
Binary files /dev/null and 
b/writerperfect/qa/unit/data/writer/libwps/pass/PocketWord.psw differ
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: sc/source

2020-09-27 Thread Caolán McNamara (via logerrit)
 sc/source/ui/dbgui/dbnamdlg.cxx |   92 +---
 sc/source/ui/formdlg/formula.cxx|   16 +++---
 sc/source/ui/inc/crnrdlg.hxx|4 -
 sc/source/ui/inc/dbnamdlg.hxx   |4 -
 sc/source/ui/inc/formula.hxx|2 
 sc/source/ui/inc/highred.hxx|6 +-
 sc/source/ui/inc/namedefdlg.hxx |2 
 sc/source/ui/inc/namedlg.hxx|4 -
 sc/source/ui/miscdlgs/crnrdlg.cxx   |   36 +-
 sc/source/ui/miscdlgs/highred.cxx   |   10 +--
 sc/source/ui/namedlg/namedefdlg.cxx |8 +--
 sc/source/ui/namedlg/namedlg.cxx|8 +--
 sc/source/ui/view/tabvwshc.cxx  |   16 +++---
 13 files changed, 96 insertions(+), 112 deletions(-)

New commits:
commit 4abf1bdfa383a645e73563f8b0d0b1b945303360
Author: Caolán McNamara 
AuthorDate: Sat Sep 26 21:32:26 2020 +0100
Commit: Caolán McNamara 
CommitDate: Sun Sep 27 16:23:56 2020 +0200

never null ScViewData*

and so remove some never called code

Change-Id: Ia5a6501f9a5214a4069623832508a6f884cfa6ee
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103494
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/sc/source/ui/dbgui/dbnamdlg.cxx b/sc/source/ui/dbgui/dbnamdlg.cxx
index f49e6ac617fa..555b5acbacb3 100644
--- a/sc/source/ui/dbgui/dbnamdlg.cxx
+++ b/sc/source/ui/dbgui/dbnamdlg.cxx
@@ -127,11 +127,11 @@ void DBSaveData::Restore()
 
 
 ScDbNameDlg::ScDbNameDlg(SfxBindings* pB, SfxChildWindow* pCW, weld::Window* 
pParent,
-ScViewData* ptrViewData)
+ScViewData& rViewData)
 : ScAnyRefDlgController(pB, pCW, pParent,
 "modules/scalc/ui/definedatabaserangedialog.ui", 
"DefineDatabaseRangeDialog")
-, pViewData(ptrViewData)
-, rDoc(ptrViewData->GetDocument())
+, m_rViewData(rViewData)
+, rDoc(rViewData.GetDocument())
 , bRefInputMode(false)
 , aAddrDetails(rDoc.GetAddressConvention(), 0, 0)
 , aLocalDbCol(*(rDoc.GetDBCollection()))
@@ -194,56 +194,53 @@ void ScDbNameDlg::Init()
 
 OUString  theAreaStr;
 
-if ( pViewData )
-{
-SCCOL   nStartCol   = 0;
-SCROW   nStartRow   = 0;
-SCTAB   nStartTab   = 0;
-SCCOL   nEndCol = 0;
-SCROW   nEndRow = 0;
-SCTAB   nEndTab = 0;
+SCCOL   nStartCol   = 0;
+SCROW   nStartRow   = 0;
+SCTAB   nStartTab   = 0;
+SCCOL   nEndCol = 0;
+SCROW   nEndRow = 0;
+SCTAB   nEndTab = 0;
 
-ScDBCollection* pDBColl = rDoc.GetDBCollection();
-ScDBData*   pDBData = nullptr;
+ScDBCollection* pDBColl = rDoc.GetDBCollection();
+ScDBData*   pDBData = nullptr;
 
-pViewData->GetSimpleArea( nStartCol, nStartRow, nStartTab,
-  nEndCol,   nEndRow,  nEndTab );
+m_rViewData.GetSimpleArea( nStartCol, nStartRow, nStartTab,
+  nEndCol,   nEndRow,  nEndTab );
 
-theCurArea = ScRange( nStartCol, nStartRow, nStartTab, nEndCol, 
nEndRow, nEndTab);
+theCurArea = ScRange( nStartCol, nStartRow, nStartTab, nEndCol, nEndRow, 
nEndTab);
 
-theAreaStr = theCurArea.Format(rDoc, ScRefFlags::RANGE_ABS_3D, 
aAddrDetails);
+theAreaStr = theCurArea.Format(rDoc, ScRefFlags::RANGE_ABS_3D, 
aAddrDetails);
 
-if ( pDBColl )
+if ( pDBColl )
+{
+// determine if the defined DB area has been marked:
+pDBData = pDBColl->GetDBAtCursor( nStartCol, nStartRow, nStartTab, 
ScDBDataPortion::TOP_LEFT );
+if ( pDBData )
 {
-// determine if the defined DB area has been marked:
-pDBData = pDBColl->GetDBAtCursor( nStartCol, nStartRow, nStartTab, 
ScDBDataPortion::TOP_LEFT );
-if ( pDBData )
+ScAddress&  rStart = theCurArea.aStart;
+ScAddress&  rEnd   = theCurArea.aEnd;
+SCCOL nCol1;
+SCCOL  nCol2;
+SCROW  nRow1;
+SCROW  nRow2;
+SCTAB  nTab;
+
+pDBData->GetArea( nTab, nCol1, nRow1, nCol2, nRow2 );
+
+if (   (rStart.Tab() == nTab)
+&& (rStart.Col() == nCol1) && (rStart.Row() == nRow1)
+&& (rEnd.Col()   == nCol2) && (rEnd.Row()   == nRow2 ) )
 {
-ScAddress&  rStart = theCurArea.aStart;
-ScAddress&  rEnd   = theCurArea.aEnd;
-SCCOL nCol1;
-SCCOL  nCol2;
-SCROW  nRow1;
-SCROW  nRow2;
-SCTAB  nTab;
-
-pDBData->GetArea( nTab, nCol1, nRow1, nCol2, nRow2 );
-
-if (   (rStart.Tab() == nTab)
-&& (rStart.Col() == nCol1) && (rStart.Row() == nRow1)
-&& (rEnd.Col()   == nCol2) && (rEnd.Row()   == nRow2 ) )
-{
-OUString aDBName = pDBData->GetName();
-if ( aDBName != STR_DB_LOCAL_NONAME )
-m_xEdName->set_entry_text(aDBName);

[Libreoffice-commits] core.git: ucb/source

2020-09-27 Thread Julien Nabet (via logerrit)
 ucb/source/ucp/cmis/cmis_content.hxx |2 --
 1 file changed, 2 deletions(-)

New commits:
commit c955f00958bd895ac23f339f8f744dd820bc61aa
Author: Julien Nabet 
AuthorDate: Sun Sep 27 12:54:04 2020 +0200
Commit: Julien Nabet 
CommitDate: Sun Sep 27 15:09:25 2020 +0200

Remove unused include list in ucb/cmis_content

Change-Id: I7c554e883691e2f97e2f48b2a0353dfa9d4d84d5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103507
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/ucb/source/ucp/cmis/cmis_content.hxx 
b/ucb/source/ucp/cmis/cmis_content.hxx
index 61c45434e36e..20f4bfe21a98 100644
--- a/ucb/source/ucp/cmis/cmis_content.hxx
+++ b/ucb/source/ucp/cmis/cmis_content.hxx
@@ -34,8 +34,6 @@
 #pragma GCC diagnostic pop
 #endif
 
-#include 
-
 namespace com::sun::star {
 namespace beans {
 struct Property;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: vcl/unx

2020-09-27 Thread Julien Nabet (via logerrit)
 vcl/unx/gtk3/fpicker/SalGtkFolderPicker.hxx |1 -
 1 file changed, 1 deletion(-)

New commits:
commit d994c886961105408010e633ef3cb1c14f816c66
Author: Julien Nabet 
AuthorDate: Sun Sep 27 12:31:58 2020 +0200
Commit: Julien Nabet 
CommitDate: Sun Sep 27 15:08:43 2020 +0200

Remove unused include  in vcl/SalGtkFolderPicker

Change-Id: Ic411ba2c8068616d54cb448c3eb73aa5a45d8a52
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103503
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/vcl/unx/gtk3/fpicker/SalGtkFolderPicker.hxx 
b/vcl/unx/gtk3/fpicker/SalGtkFolderPicker.hxx
index 229bbe8b8749..53286f395d43 100644
--- a/vcl/unx/gtk3/fpicker/SalGtkFolderPicker.hxx
+++ b/vcl/unx/gtk3/fpicker/SalGtkFolderPicker.hxx
@@ -20,7 +20,6 @@
 #ifndef INCLUDED_VCL_UNX_GTK_FPICKER_SALGTKFOLDERPICKER_HXX
 #define INCLUDED_VCL_UNX_GTK_FPICKER_SALGTKFOLDERPICKER_HXX
 
-#include 
 #include 
 #include 
 #include 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: officecfg/registry

2020-09-27 Thread andreas kainz (via logerrit)
 officecfg/registry/data/org/openoffice/Office/UI/Sidebar.xcu |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 11fdde23f6dc2dce4bc7c4513e70780487150761
Author: andreas kainz 
AuthorDate: Fri Sep 25 23:30:43 2020 +0200
Commit: Heiko Tietze 
CommitDate: Sun Sep 27 15:18:35 2020 +0200

tdf#136946 Add Shapes sidebar from LO Draw into Impress

Change-Id: I188347935f3bdc7ee2bc5b4998f4b95807e2051d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103471
Tested-by: Jenkins
Tested-by: Heiko Tietze 
Reviewed-by: Heiko Tietze 

diff --git a/officecfg/registry/data/org/openoffice/Office/UI/Sidebar.xcu 
b/officecfg/registry/data/org/openoffice/Office/UI/Sidebar.xcu
index 11881687f1f8..12ff372f8b08 100644
--- a/officecfg/registry/data/org/openoffice/Office/UI/Sidebar.xcu
+++ b/officecfg/registry/data/org/openoffice/Office/UI/Sidebar.xcu
@@ -96,7 +96,7 @@
 
 
   
-Draw, any, visible ;
+DrawImpress, any, visible ;
   
 
 
@@ -817,7 +817,7 @@
 
 
   
-Draw, any, visible   ;
+DrawImpress, any, visible   ;
   
 
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: sc/source

2020-09-27 Thread Eike Rathke (via logerrit)
 sc/source/core/data/documen3.cxx |   14 ++
 1 file changed, 14 insertions(+)

New commits:
commit d3a8fdf3cad0e71ff5e13bb229fed6e52206c6b9
Author: Eike Rathke 
AuthorDate: Sun Sep 27 14:51:50 2020 +0200
Commit: Eike Rathke 
CommitDate: Sun Sep 27 16:06:13 2020 +0200

Resolves: tdf#67007 display sheet-local range name in Name Box for selection

Change-Id: Ia9980b13ed5c93cc72231ead532e3916e6234f56
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103509
Reviewed-by: Eike Rathke 
Tested-by: Jenkins

diff --git a/sc/source/core/data/documen3.cxx b/sc/source/core/data/documen3.cxx
index 727eff32345c..7ffd181ac502 100644
--- a/sc/source/core/data/documen3.cxx
+++ b/sc/source/core/data/documen3.cxx
@@ -238,6 +238,20 @@ bool ScDocument::InsertNewRangeName( SCTAB nTab, const 
OUString& rName, const Sc
 const ScRangeData* ScDocument::GetRangeAtBlock( const ScRange& rBlock, 
OUString* pName ) const
 {
 const ScRangeData* pData = nullptr;
+if (rBlock.aStart.Tab() == rBlock.aEnd.Tab())
+{
+const ScRangeName* pLocalNames = GetRangeName(rBlock.aStart.Tab());
+if (pLocalNames)
+{
+pData = pLocalNames->findByRange( rBlock );
+if (pData)
+{
+if (pName)
+*pName = pData->GetName();
+return pData;
+}
+}
+}
 if ( pRangeName )
 {
 pData = pRangeName->findByRange( rBlock );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: vcl/inc vcl/qt5

2020-09-27 Thread Julien Nabet (via logerrit)
 vcl/inc/qt5/Qt5VirtualDevice.hxx |4 ++--
 vcl/qt5/Qt5VirtualDevice.cxx |4 +++-
 2 files changed, 5 insertions(+), 3 deletions(-)

New commits:
commit 2a81fc0ee9478758f7a919519f922f0d4cb5f279
Author: Julien Nabet 
AuthorDate: Sun Sep 27 12:48:02 2020 +0200
Commit: Julien Nabet 
CommitDate: Sun Sep 27 16:17:04 2020 +0200

Replace list by vector in vcl/Qt5VirtualDevice

Change-Id: I137019c15d3ee2886ad1bd53e671a89990891481
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103506
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/vcl/inc/qt5/Qt5VirtualDevice.hxx b/vcl/inc/qt5/Qt5VirtualDevice.hxx
index 89251c96d783..ad0dc3c3c804 100644
--- a/vcl/inc/qt5/Qt5VirtualDevice.hxx
+++ b/vcl/inc/qt5/Qt5VirtualDevice.hxx
@@ -22,7 +22,7 @@
 #include 
 
 #include 
-#include 
+#include 
 
 #include 
 
@@ -32,7 +32,7 @@ enum class DeviceFormat;
 
 class Qt5VirtualDevice final : public SalVirtualDevice
 {
-std::list m_aGraphics;
+std::vector m_aGraphics;
 std::unique_ptr m_pImage;
 DeviceFormat m_eFormat;
 QSize m_aFrameSize;
diff --git a/vcl/qt5/Qt5VirtualDevice.cxx b/vcl/qt5/Qt5VirtualDevice.cxx
index f1c7d9606c8f..10b2066ccbf6 100644
--- a/vcl/qt5/Qt5VirtualDevice.cxx
+++ b/vcl/qt5/Qt5VirtualDevice.cxx
@@ -40,7 +40,9 @@ SalGraphics* Qt5VirtualDevice::AcquireGraphics()
 
 void Qt5VirtualDevice::ReleaseGraphics(SalGraphics* pGraphics)
 {
-m_aGraphics.remove(dynamic_cast(pGraphics));
+m_aGraphics.erase(
+std::remove(m_aGraphics.begin(), m_aGraphics.end(), 
dynamic_cast(pGraphics)),
+m_aGraphics.end());
 delete pGraphics;
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: hwpfilter/source

2020-09-27 Thread Julien Nabet (via logerrit)
 hwpfilter/source/drawing.h   |1 -
 hwpfilter/source/hbox.h  |1 -
 hwpfilter/source/hwpfile.h   |1 -
 hwpfilter/source/hwpread.cxx |1 -
 4 files changed, 4 deletions(-)

New commits:
commit 084d7e2ea236c9b24a73a374056e82e9ace2cd0c
Author: Julien Nabet 
AuthorDate: Sun Sep 27 13:04:13 2020 +0200
Commit: Julien Nabet 
CommitDate: Sun Sep 27 16:17:41 2020 +0200

Remove unused include list in hwpfilter

Change-Id: I7cac4483173e7c75413a6b17a468659ee2790768
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103508
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/hwpfilter/source/drawing.h b/hwpfilter/source/drawing.h
index 60bd74f80f80..935b33171c15 100644
--- a/hwpfilter/source/drawing.h
+++ b/hwpfilter/source/drawing.h
@@ -22,7 +22,6 @@
 
 #include "precompile.h"
 
-#include 
 #include 
 
 #include 
diff --git a/hwpfilter/source/hbox.h b/hwpfilter/source/hbox.h
index 79826d326d9d..869fedd8ba90 100644
--- a/hwpfilter/source/hbox.h
+++ b/hwpfilter/source/hbox.h
@@ -23,7 +23,6 @@
 #include 
 
 #include 
-#include 
 #include 
 
 #include 
diff --git a/hwpfilter/source/hwpfile.h b/hwpfilter/source/hwpfile.h
index 768086193523..9cc3b72a7c65 100644
--- a/hwpfilter/source/hwpfile.h
+++ b/hwpfilter/source/hwpfile.h
@@ -26,7 +26,6 @@
 #define INCLUDED_HWPFILTER_SOURCE_HWPFILE_H
 
 #include 
-#include 
 #include 
 #include 
 #include 
diff --git a/hwpfilter/source/hwpread.cxx b/hwpfilter/source/hwpread.cxx
index cbe316787dc0..98fba3016bc5 100644
--- a/hwpfilter/source/hwpread.cxx
+++ b/hwpfilter/source/hwpread.cxx
@@ -23,7 +23,6 @@
 #include 
 
 #include 
-#include 
 
 #include "hwpfile.h"
 #include "hbox.h"
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 135916] Scroll to top (to cursor) after applying page style at page break (comment 2)

2020-09-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=135916

Telesto  changed:

   What|Removed |Added

Summary|Scroll to top (to cursor)   |Scroll to top (to cursor)
   |after applying page style   |after applying page style
   |at page break   |at page break (comment 2)
 CC||caol...@redhat.com

--- Comment #3 from Telesto  ---
@Caolan
Looks like again another variant off 

author  Jan Holesovsky 2018-01-23 18:13:01 +0100
committer   Jan Holesovsky 2018-01-24 11:45:52
+0100
commit  c3a085d22742f88e91ff92f319a26d6e8d1d9a98 (patch)
tree9f84d93e9a2822760b60730e9c6130a31e0302db
parent  3bbf8d0a9b9e36299c889d8252d9a2b068f17ff6 (diff)
lokdialog: Convert the Table -> Properties... to async exec.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 136539] Unwanted scroll when changing something in the Paragraph Window using edit blue page break line (see comment 11)

2020-09-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=136539

Telesto  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=13
   ||5916

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 135916] Scroll to top (to cursor) after applying page style at page break

2020-09-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=135916

Telesto  changed:

   What|Removed |Added

Summary|Page style isn't applied|Scroll to top (to cursor)
   |after setting it in the the |after applying page style
   |flow tab|at page break

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 135916] Scroll to top (to cursor) after applying page style at page break

2020-09-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=135916

Telesto  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=13
   ||6539

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137079] New: Default zoom ignored with deactivated user-specific settings

2020-09-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137079

Bug ID: 137079
   Summary: Default zoom ignored with deactivated user-specific
settings
   Product: LibreOffice
   Version: 7.0.1.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: mila...@eclipso.de

Created attachment 165897
  --> https://bugs.documentfoundation.org/attachment.cgi?id=165897=edit
Test document opening at 120% instead of 100% default zoom

Hi

although user specific document settings are disabled, the attached document is
opened at 120% zoom (it shows 100% for a split second and then jumps to 120%
during opening).

Seems to be realted, because the document uses an own document template
(Normal...). Somehow the default zoom is only applied in the standard template
(Standard).

There are many forum posts and google results with people that want their
documents to open at a set zoom level. Suggestion is always to overwrite the
default Standard template and save it with the desired zoom level.

Guess it would be a lot easier if LibreOffice would offer a simple setting for
default zoom to avoid these issues at the beginning.

(Options --> Load/Save --> General --> Load user-specific setting =
deactivated)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 123265] Show menu icons by default in GTK3 Backend

2020-09-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123265

--- Comment #33 from hellwoodfire  ---
@Buovjaga Thank you for the information. Sorry, there is something I don't
understand. Yes I saw your comment #12. 
1) But if Inkscape and GIMP can just ignore the GTK3 Setting, why LibreOffice
Cant?

2) Also, why the right place to make a proposal would be in the issue tracker
of whichever "not GNOME, but using GTK" desktop environment (Cinnamon, MATE,
Xfce) ?

3) Can I change the status to "Reopened" and change the importance to MAJOR ?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 135916] Page style isn't applied after setting it in the the flow tab

2020-09-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=135916

--- Comment #2 from Telesto  ---
Created attachment 165893
  --> https://bugs.documentfoundation.org/attachment.cgi?id=165893=edit
Example file

1. Open the attached file
2. Hoover over blue page break line at page 3
3. Edit page break
4. Text flow tab -> Change page style from Default to Landscape

Result: scrolls the first page

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 135916] Scroll to top (to cursor) after applying page style at page break (comment 2)

2020-09-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=135916

Caolán McNamara  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #4 from Caolán McNamara  ---
I can confirm anyway, especially with the gen backend.

Maybe the thing to do here is just keep the thing affected by ok selected when
the dialog is oked. https://gerrit.libreoffice.org/c/core/+/103525 I had
earlier saved and restored where the cursor was considered to be around the ok
handler, but the very original state was to basically do this and that seems a
defensible position and solve the problem

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137078] New: Sidebar property deck string is to generic

2020-09-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137078

Bug ID: 137078
   Summary: Sidebar property deck string is to generic
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: kain...@gmail.com

the string for the property deck is very generic and didn't fit perfect, ok you
change stuff there but compare to other deck names, property is really generic.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137080] ENHANCEMENT: Make LibreOffice use built-in OpenType Feature Small Capitals (smcp tag) when the typeface has it instead of simulated Small Capitals

2020-09-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137080

--- Comment #1 from João Paulo  ---
Created attachment 165899
  --> https://bugs.documentfoundation.org/attachment.cgi?id=165899=edit
sample PDF showing the small capitals issue

As the typeface size was 12 points, maybe using a zoom of 150% when reading the
first three lines of this sample PDF will make it easier to see.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137080] New: ENHANCEMENT: Make LibreOffice use built-in OpenType Feature Small Capitals (smcp tag) when the typeface has it instead of simulated Small Capitals

2020-09-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137080

Bug ID: 137080
   Summary: ENHANCEMENT: Make LibreOffice use built-in OpenType
Feature Small Capitals (smcp tag) when the typeface
has it instead of simulated Small Capitals
   Product: LibreOffice
   Version: 6.4.0.3 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: trivial
  Priority: medium
 Component: graphics stack
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: joaopauloag-freedesk...@yahoo.com.br

Created attachment 165898
  --> https://bugs.documentfoundation.org/attachment.cgi?id=165898=edit
sample Writer document showing the small capitals issue

LibreOffice should be smart to detect when the font file has a “smcp” tag and
then apply the built-in small capitals instead of simulating the effect when
the user chooses to apply the small capitals effect:

The explanation below needs the Libertinus Serif available at
“https://github.com/alerque/libertinus/releases”, but any OpenType font with
the “smcp” tag will show the difference from simulated small capitals to real
small capitals:

The first line was directly formatted with Libertinus Serif and then applied
LibreOffice’s Small Capitals effect from Menu Format, Character, Font Effects,
Case, Small capitals. The effect applied was simulated by LibreOffice. Notice
how the small capitals have a thinner stroke than the regular capitals and even
the lowercase letters (when they should blend) and are noticeable higher than
the lowercase letters. The XML code on the document is .

The second line was directly formatted with Libertinus Serif and then applied
Advanced OpenType Feature Small Capitals (use “Libertinus Serif:smcp” as the
font name or go to Menu Format, Character, Font, Features, Lowercase to Small
Capitals). The effect applied was built-in on the typeface’s font file (true
small capitals). Notice how the built-in small capitals have the same stroke
width as the capitals and are bolder than the simulated small capitals,
blending perfectly with the capitals and the lowercase letters. The XML code on
the document is .

The third line was directly formatted with both methods: simulated and
built-in/true small capitals. LibreOffice 7.0.0.2 renders them as if it was
applied only the simulated method when it should apply the built-in/true small
capitals. The XML code on the document is  (notice
there are the two tags).

Almost all LibreOffice components which deals with choosing typefaces have this
defect that could be enhanced:  Base (when creating forms), Calc, Draw,
Impress, Writer.  Only Math does not have the common window called when Menu
Format Character is selected.

I think a good compatibility option should be accepting the documents written
with the old behavior (documents with the
“LibreOffice/7.0.1.2” or lower, for example)
so there is no text reflow, and then add to them a compatibility option similar
to the ones found at Menu Tools, Options, Load/Save, Microsoft Office and HTML
Compatibility. I suggest a new section named Advanced Typography Compatibility,
so other OpenType enhancements as true superscripts and true subscripts could
be added there too. I don't know where should be the best place/tag to save
that compatibility option on the document, but no tag written should mean no
compatibility.

And with new documents, the Menu Format, Character, Font Effects, Case, Small
Capitals should cause the documents to be saved only with
“” (even if the user goes to Menu Format,
Character, Font, Features, Lowercase to Small Capitals, which now creates the
“:smcp” code appended to the font name) and render the typeface with true
built-in small capitals (if it exists) and only fallback to simulated small
capitals if the font file does not have it.

I don’t like the “:smcp” appended on the typeface name because it creates
problems when changing fonts: it loses the “small capitals” feature, even if
the new font chosen has true small capitals, which is something that doesn’t
happen with other font attributes and effects (regular, bold, italic, italic
bold, color, underlining, etc.).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137083] New: Grid does not work in RTL sheet.

2020-09-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137083

Bug ID: 137083
   Summary: Grid does not work in RTL sheet.
   Product: LibreOffice
   Version: 7.1.0.0.alpha0+ Master
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: rb.hensc...@t-online.de

Start Calc and enable grid. That is in menu View > Grid and Helplines > Display
Grid. To make the grid better visible you might set Resolution to 5mm and
Subdivision to 5. That is in Tools > Options > Calc > Grid.

Now set right-to-left writing direction in page properties and set
"Right-To-Left" in menu Sheet.

Error: The grid is no longer displayed.

Go to menu View and make sure, that the option "Display Grid" is still enabled.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 123265] Show menu icons by default in GTK3 Backend

2020-09-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123265

--- Comment #34 from hellwoodfire  ---
(In reply to Caolán McNamara from comment #15)
> I'm not going to change this. Icons on/off currently follows the desktop
> defaults for icons on/off. It makes more sense to me to turn icons on for
> all apps at the desktop level rather than per-application.

It makes more sense ONLY TO YOU. It doesn't make sens for the rest of us.
Please put back the option at least.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-ux-advise] [Bug 136713] Standard toolbar 'Insert Table' splitbutton, with selection 'More Options' directly applies 'Convert -> Text to table' action, incorrect label?

2020-09-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=136713

--- Comment #6 from Telesto  ---
FWIW, is it allowed to create a meta-bug the keep track of the 'rejected'
stuff; even as RESOLVED NOTABUG. Simply to keep track of the rejected?

To look up to check if it already discussed before etc (I certainly will forget
it at some point); nor do I exactly now what others put forward in the past
etc.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-bugs] [Bug 132658] ENHANCEMENT: Image without resolution set should get a default fallback resolution (not based on a screen resolution)

2020-09-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132658

--- Comment #25 from Dirk Munk  ---
Why don't you use a free program like Exif Pilot to set the dpi before you
insert the image?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137077] Sidebar: remove +/- icon for open and close content panel

2020-09-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137077

andreas_k  changed:

   What|Removed |Added

   Keywords||needsUXEval
 CC||kain...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-ux-advise] [Bug 137077] Sidebar: remove +/- icon for open and close content panel

2020-09-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137077

andreas_k  changed:

   What|Removed |Added

 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-bugs] [Bug 136278] The left arrow key causes objects to disappear.

2020-09-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=136278

Horst Schirmeier  changed:

   What|Removed |Added

 CC||ho...@schirmeier.com

--- Comment #18 from Horst Schirmeier  ---
Created attachment 165896
  --> https://bugs.documentfoundation.org/attachment.cgi?id=165896=edit
simpler repro file

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137019] Absolute references in graphs move when data moves

2020-09-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137019

Jiří Hofman  changed:

   What|Removed |Added

 Status|RESOLVED|NEW
 Resolution|NOTABUG |---
 Ever confirmed|0   |1

--- Comment #2 from Jiří Hofman  ---
(In reply to m.a.riosv from comment #1)
> What it's wrong? It keeps the references where the initial data is after
> insert a row before. It's the same if you have that reference in a cell.

I hope I explained it quite clearly.

If a user makes a graph from the first x rows and updates the data by inserting
a row, the graph is not updated. He has to manually change the graph. There is
no way how to fix the data range in the graph.

It is fine that the data range changes when the references are relative but
changing it when the references are absolute makes no sense. Especially when
the relative references behave in the same way as absolute references.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 135543] Writer auto spellcheck works intermittently

2020-09-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=135543

Telesto  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=13
   ||6294

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-ux-advise] [Bug 136713] Standard toolbar 'Insert Table' splitbutton, with selection 'More Options' directly applies 'Convert -> Text to table' action, incorrect label?

2020-09-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=136713

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
   Keywords|needsUXEval |
 CC||79045_79...@mail.ru
 Resolution|--- |NOTABUG

--- Comment #5 from Roman Kuznetsov <79045_79...@mail.ru> ---
That widget inserts a table and "More option" there inserts a table too anyway,
just it makes it with more options and more input from user.
When you select a TEXT in the document and select "Insert table" then LO can do
only one thing - transform that text to table.

I close this as NOTABUG

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-bugs] [Bug 136713] Standard toolbar 'Insert Table' splitbutton, with selection 'More Options' directly applies 'Convert -> Text to table' action, incorrect label?

2020-09-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=136713

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
   Keywords|needsUXEval |
 CC||79045_79...@mail.ru
 Resolution|--- |NOTABUG

--- Comment #5 from Roman Kuznetsov <79045_79...@mail.ru> ---
That widget inserts a table and "More option" there inserts a table too anyway,
just it makes it with more options and more input from user.
When you select a TEXT in the document and select "Insert table" then LO can do
only one thing - transform that text to table.

I close this as NOTABUG

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 136713] Standard toolbar 'Insert Table' splitbutton, with selection 'More Options' directly applies 'Convert -> Text to table' action, incorrect label?

2020-09-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=136713

--- Comment #6 from Telesto  ---
FWIW, is it allowed to create a meta-bug the keep track of the 'rejected'
stuff; even as RESOLVED NOTABUG. Simply to keep track of the rejected?

To look up to check if it already discussed before etc (I certainly will forget
it at some point); nor do I exactly now what others put forward in the past
etc.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137076] New: Libre Office Base, crashed.

2020-09-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137076

Bug ID: 137076
   Summary: Libre Office Base, crashed.
   Product: LibreOffice
   Version: 7.0.1.2 release
  Hardware: Other
OS: Mac OS X (All)
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: Base
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: juanrubi...@gmail.com

Description:

Libre Office Base, from the Libre Office 7.0.1 suite, closes when wanting to
start any task, on a MacBook (13-inch, Mid 2010) using the operating system:
MacOs Hig Sierra 10.13.6 (17G14033)

Actual Results:
Libre Office Base, from the Libre Office 7.0.1 suite, closes when wanting to
start any task, on a MacBook (13-inch, Mid 2010) using the operating system:
MacOs Hig Sierra 10.13.6 (17G14033)

Expected Results:

Libre Office Base, from the Libre Office 7.0.1 suite, closes when wanting to
start any task, on a MacBook (13-inch, Mid 2010) using the operating system:
MacOs Hig Sierra 10.13.6 (17G14033)


Reproducible: Always


User Profile Reset: No



Additional Info:

Libre Office Base, from the Libre Office 7.0.1 suite, closes when wanting to
start any task, on a MacBook (13-inch, Mid 2010) using the operating system:
MacOs Hig Sierra 10.13.6 (17G14033)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 136278] The left arrow key causes objects to disappear.

2020-09-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=136278

Horst Schirmeier  changed:

   What|Removed |Added

Version|6.4.4.1 rc  |6.3.6.2 release

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 135011] [Mysterious behavior of animation effect in version 6.2 or later] in impress

2020-09-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=135011

Horst Schirmeier  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=13
   ||6278

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 136278] The left arrow key causes objects to disappear.

2020-09-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=136278

Horst Schirmeier  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=13
   ||5011

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 136782] Frame/image duplication after cut & paste in DOCX

2020-09-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=136782

Telesto  changed:

   What|Removed |Added

   Priority|medium  |high

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 71732] [META] Bugs related to text rendering, typography and font features in LO

2020-09-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=71732

João Paulo  changed:

   What|Removed |Added

 Depends on||137080


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=137080
[Bug 137080] ENHANCEMENT: Make LibreOffice use built-in OpenType Feature Small
Capitals (smcp tag) when the typeface has it instead of simulated Small
Capitals
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 136294] Red wrong spelled lining needs a trigger to get activated (spell checker)

2020-09-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=136294

Telesto  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=13
   ||5543

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 135543] Writer auto spellcheck works intermittently

2020-09-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=135543

--- Comment #6 from Telesto  ---
Maybe related to bug 135543?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137080] ENHANCEMENT: Make LibreOffice use built-in OpenType Feature Small Capitals (smcp tag) when the typeface has it instead of simulated Small Capitals

2020-09-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137080

João Paulo  changed:

   What|Removed |Added

   Severity|trivial |enhancement
 Blocks||71732
  Component|graphics stack  |UI


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=71732
[Bug 71732] [META] Bugs related to text rendering, typography and font features
in LO
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 136906] Can't download in ODS format in TDF Weblate - LibreOffice

2020-09-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=136906

--- Comment #4 from baffclan  ---
(In reply to Buovjaga from comment #3)
> Yes:
> https://wiki.documentfoundation.org/QA/BugReport#Not_all_bugs_go_to_Bugzilla

Where have you moved to?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 123265] Show menu icons by default in GTK3 Backend

2020-09-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123265

--- Comment #37 from hellwoodfire  ---
How can I "hack" my disto to show the icons?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 134628] Rename "Ignore system input language" in language options

2020-09-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=134628

--- Comment #10 from chris...@labs.epiuse.com ---
(In reply to Mike Kaganski from comment #9)

It was a way of reiterating (partial) disagreement. In comment #6 I argued that
the label should mention Writer UNTIL all modules are made to behave similarly.
I know your time is very limited, but if one of us says we should do A for this
reason and the other B for that reason without engaging with each other's
argument, I'm afraid we'll soon end up talking past each other.

When I filed this report I did not know whether this option was meant to apply
to a) Writer only or b) all modules. The response to a) would be to change the
label; the response to b) would be to extend the option to all modules.

You wrote in comment #5 that b) is true. The summary of this report has been
changed and is now about renaming, close to what would have been the response
to a), but - taking your comment into account - not quite. Should it not be
about renaming AND THEN about extending the option to the other modules?

Renaming without mentioning Writer (as you wrote in comment #5) would be fine,
IF the extension of the option to all modules were to be done soon afterwards.
This does not seem likely, however. In the meantime, how are users supposed to
find out that the option does not work in other modules? Well, they could test
it, as I did. Do you really expect that?

Again, I know time is limited. I understand that any change to labels must be
translated into many languages, so the effort is multiplied. But I believe that
labeling that reflects what the software does is best for the users. When the
software changes, the labels can change with it.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 134585] Zooming in/out a 3D cube slow

2020-09-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=134585

Telesto  changed:

   What|Removed |Added

 CC||l.lu...@collabora.com

--- Comment #4 from Telesto  ---
@Lubos
As you are optimizing Skia for polygon and images.. etc you might be interested
in this one too; some day. Bug is around a long long time already, so can wait 

Massive amount of time spend in 
drawinglayer::processor3d::CutFindProcessor::processBasePrimitive3D

Or at least based very sleepy (often slightly off)  

Probably re-rendering the full shape 3D over and over on scroll-zoom (similar
to images I speculate).

Feel free to ignore :-).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137016] Crash in: libatk-bridge-2.0.so.0.0.0, when EDITING Relationships

2020-09-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137016

--- Comment #10 from Caolán McNamara  ---
re comment #3: I think https://gerrit.libreoffice.org/c/core/+/103523 will
solve that problem

I couldn't reproduce the crash in 7-0 locally, but the problem in master of
comment #3 appears to also exist, but not as severely, in 7-0 and I have to try
a few times to get the combobox to dropdown so its plausible that the backport
of the master fix, which is need focus related, to 7-0 of
https://gerrit.libreoffice.org/c/core/+/103524 has a bearing on this

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 136278] The left arrow key causes objects to disappear.

2020-09-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=136278

BogdanB  changed:

   What|Removed |Added

   Keywords|bibisectRequest |bibisected

--- Comment #16 from BogdanB  ---
Bibisected:

019dc7f2985afffc4a18f8e126b674c373a4c6fe is the first bad commit
commit 019dc7f2985afffc4a18f8e126b674c373a4c6fe
Author: Jenkins Build User 
Date:   Sun Mar 29 18:12:12 2020 +0200

source sha:49e114d3803178f8720620834f97e2ab0962e826

source sha:49e114d3803178f8720620834f97e2ab0962e826

 instdir/program/libslideshowlo.so | Bin 2557872 -> 2557872 bytes
 instdir/program/versionrc |   2 +-
 2 files changed, 1 insertion(+), 1 deletion(-)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137078] Sidebar property deck string is to generic

2020-09-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137078

andreas_k  changed:

   What|Removed |Added

   Keywords||needsUXEval
 CC||kain...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-ux-advise] [Bug 137078] Sidebar property deck string is to generic

2020-09-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137078

andreas_k  changed:

   What|Removed |Added

 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-bugs] [Bug 136278] The left arrow key causes objects to disappear.

2020-09-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=136278

--- Comment #17 from Horst Schirmeier  ---
I can reproduce the issue with the latest LibreOffice 7.0.1.2 (DEB) from
libreoffice.org, and with Ubuntu 20.04's LibreOffice 6.4.6-0ubuntu0.20.04.1
(with KDE on Xorg).  I see this all over the place in my own presentations. 
I'll attach a much simpler file that reproduces the issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 136278] The left arrow key causes objects to disappear.

2020-09-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=136278

--- Comment #19 from Horst Schirmeier  ---
6.2.8.2 does not exhibit the bug, 6.3.6.2 does.  This must have broken
somewhere in-between.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137081] New: page anchored shapes are mirrored on reopen in a RTL sheet

2020-09-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137081

Bug ID: 137081
   Summary: page anchored shapes are mirrored on reopen in a RTL
sheet
   Product: LibreOffice
   Version: 7.1.0.0.alpha0+ Master
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: rb.hensc...@t-online.de

Start Calc. Set the writing direction to "right-to-left" in the page properties
and set the sheet to "Right-To-Left" in menu Sheet.

Insert an asymmetric shape, for example "Flash" or "Corner Right Arrow".

Save the document and reopen it.

Error: The shape is mirrored.

I don't know yet, whether the error happens on save or load.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137082] New: cell anchored shapes are shifted on reopen in a RTL sheet

2020-09-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137082

Bug ID: 137082
   Summary: cell anchored shapes are shifted on reopen in a RTL
sheet
   Product: LibreOffice
   Version: 7.1.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: rb.hensc...@t-online.de

Start Calc. Set the writing direction to "right-to-left" in the page properties
and set the sheet to "Right-To-Left" in menu Sheet.

Insert a shape e.g. "Flash" and anchor it "To Cell" or "To Cell (resize with
cell)". Save the document and reload it.

Error: The shape is at a different position.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 123265] Show menu icons by default in GTK3 Backend

2020-09-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123265

--- Comment #36 from Rizal Muttaqin  ---
(In reply to Ming Hua from comment #35)

> You are free to switch to a different (gen? x11? don't know how it's called
> now) VCL backend, and I believe the options to change the menu icons will be
> back.  You probably won't even need to change it, as the default setting
> probably shows the icons already.

No, it's not. The options has been removed even in gen backend (I have tested
it), and yes the default settings for KDE and Windows is shows by default while
its the opposite in GTK and macOS. I am not sure macOS has no such desktop
level settings and GNOME need an external tool like gconf/dconf editor or such
I don't know.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 117485] Clicking on the table border will select the full table content instead of only selecting the border (used for cut/paste)

2020-09-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=117485

Telesto  changed:

   What|Removed |Added

   Priority|medium  |high

--- Comment #5 from Telesto  ---
I'm personally inclined to increase importance.. cut or deleting a table in
Impress is cumbersome.. and annoying

Looking at the see also's.. i think there is support for it.. so i will take
the risk

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 65107] Header/Footer comments pop up on first page only

2020-09-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=65107

Dieter  changed:

   What|Removed |Added

 Resolution|FIXED   |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 133812] Style 'Result' and 'Result2' have been removed; Subtotals do not get automatic formatting any longer

2020-09-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133812

Eike Rathke  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |er...@redhat.com
   |desktop.org |
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 136539] Unwanted scroll when changing something in the Paragraph Window using edit blue page break line (see comment 11)

2020-09-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=136539

Telesto  changed:

   What|Removed |Added

 CC||caol...@redhat.com

--- Comment #14 from Telesto  ---
@Caolan
You solved; bug 134439 and bug 135636. This is bug number 3

author  Jan Holesovsky 2018-01-23 18:13:01 +0100
committer   Jan Holesovsky 2018-01-24 11:45:52
+0100
commit  c3a085d22742f88e91ff92f319a26d6e8d1d9a98 (patch)
tree9f84d93e9a2822760b60730e9c6130a31e0302db
parent  3bbf8d0a9b9e36299c889d8252d9a2b068f17ff6 (diff)
lokdialog: Convert the Table -> Properties... to async exec.

Bit of a (pointless) squabble about this, as I missed out the regression
aspect..

I believe - with Thomas - that the old behavior should restored. The behavior
isn't intentional introduced. However, you might ask Mike at the DEV chat. It
might be that he is ignoring my bug reports (e-mail filter).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137069] Inconsistent extension of section area

2020-09-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137069

--- Comment #3 from Regina Henschel  ---
(In reply to ajlittoz from comment #2)
> I don't see where I can define "padding" space around a section (but I'm on
> a trip and only have access to 4.1.6.2 - need to wait until I return to
> check with a more recent release). In 4.1.6.2, a section can't have borders,
> then there is no spacing to border (again, I must check with 6.4.6.2). In
> case there can be some padding, this padding IMHO is part of the section and
> should have the section background.

Sections have only fo:margin-left and fo:margin-right in file format. There
exist no margin-top, no margin-bottom, no border and no padding.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 93675] FILESAVE: DOCX: Diagram export working but when opened with Word displayed differently than in LO

2020-09-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=93675

--- Comment #25 from Dave Gilbert  ---
Created attachment 165895
  --> https://bugs.documentfoundation.org/attachment.cgi?id=165895=edit
Rendering on head after ungroup

There's something going on with grouping here.
Much of the diagram is in a group; ungrouping before saving gives something
which in many ways is closer to the original.
The pink vertical arrow ends up touching the pink boxes, and boxes are wide
enough to hold their text.
Heck, even a couple of the dotted lines end up in the right place.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 136983] Wrong setting for DOC properties

2020-09-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=136983

lach...@gmail.com changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

--- Comment #3 from lach...@gmail.com ---
Yes, the date of printing remains, while the DOCument hasn't been printed.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 93675] FILESAVE: DOCX: Diagram export working but when opened with Word displayed differently than in LO

2020-09-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=93675

--- Comment #24 from Dave Gilbert  ---
Created attachment 165894
  --> https://bugs.documentfoundation.org/attachment.cgi?id=165894=edit
Rendering on head unmodified

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 136083] New document with .ott file don't work

2020-09-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=136083

--- Comment #3 from Fabio Betti  ---
don't work anymore

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 48707] FILESAVE overline automatic color incorrect in pdf

2020-09-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=48707

--- Comment #9 from Patrick Charlot  ---
Hi,

I can confirm that this issue still remains in LO 7.0.1.2 with kubuntu 18.04.

regards
Patrick

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137077] New: Sidebar: remove +/- icon for open and close content panel

2020-09-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137077

Bug ID: 137077
   Summary: Sidebar: remove +/- icon for open and close content
panel
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: kain...@gmail.com

The sidebar has in each content panel title an +/- expander icon. should it be
removed to reduce noise?

I don't think so cause it will hide the open/close for content panels even
more.

Twitter feedback:
Reduce noise by making the |▸| handle invisible.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 135011] [Mysterious behavior of animation effect in version 6.2 or later] in impress

2020-09-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=135011

--- Comment #4 from Horst Schirmeier  ---
(In reply to hiro yamamoto from comment #3)
> However, when multiple objects (with animation effects) are played back in
> sequence, the objects that are not immediately before will disappear when
> "Back" is executed. This has not been improved.

I guess this is a different issue, see bug #136278.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137059] Wrong font background color in font preview

2020-09-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137059

--- Comment #5 from medmedin2014  ---
(In reply to V Stuart Foote from comment #4)
> Not necessarily set 'white', rather dialog should be aware of fg and bg
> colors of current theme and use for font preview and canvas color where
> possible.
> 
> @Tomaž?

Not always white, but I mean it should uses the background color of text used
on current selected text which is white in my case (like shown in screenshot).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-ux-advise] [Bug 137059] Wrong font background color in font preview

2020-09-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137059

--- Comment #5 from medmedin2014  ---
(In reply to V Stuart Foote from comment #4)
> Not necessarily set 'white', rather dialog should be aware of fg and bg
> colors of current theme and use for font preview and canvas color where
> possible.
> 
> @Tomaž?

Not always white, but I mean it should uses the background color of text used
on current selected text which is white in my case (like shown in screenshot).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-bugs] [Bug 136527] Resizing textboxes in LibreOffice Impress is terribly slow.

2020-09-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=136527

--- Comment #4 from Petkra Eraus  ---
I can confirm, it doesnt happen on Windows. Seems it's a thing about the Linux
rendering pipeline?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 123265] Show menu icons by default in GTK3 Backend

2020-09-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123265

--- Comment #35 from Ming Hua  ---
(In reply to hellwoodfire from comment #31)
> Why don't you just put back the option to override this. exactly where is
> was in the LibreOffice options? Please, just add the option.
Please read more carefully.  Per comment 16 that option doesn't work with GTK3
backend, which is the reason they were changed to be hidden.

You are free to switch to a different (gen? x11? don't know how it's called
now) VCL backend, and I believe the options to change the menu icons will be
back.  You probably won't even need to change it, as the default setting
probably shows the icons already.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 89606] [META] Table of Contents and Indexes bugs and enhancements

2020-09-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=89606
Bug 89606 depends on bug 37638, which changed state.

Bug 37638 Summary: Index randomly broken up with extra white space
https://bugs.documentfoundation.org/show_bug.cgi?id=37638

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 69011] How to Induce (and Fix) Character Corruption if OpenGL not used (disable and re-enable anti-aliasing)

2020-09-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=69011

--- Comment #19 from QA Administrators  ---
Dear John L. ten Wolde,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


  1   2   3   4   >