[Libreoffice-commits] core.git: 2 commits - cui/source include/sfx2 include/svl sfx2/source solenv/clang-format svl/Library_svl.mk svl/source sw/source
cui/source/options/treeopt.cxx |4 ++--
include/sfx2/app.hxx|3 +--
include/svl/isethint.hxx| 40
sfx2/source/appl/appcfg.cxx | 13 +
sfx2/source/appl/appserv.cxx|2 +-
solenv/clang-format/excludelist |1 -
svl/Library_svl.mk |1 -
svl/source/notify/isethint.cxx | 33 -
sw/source/uibase/app/apphdl.cxx |1 -
sw/source/uibase/app/appopt.cxx |4 ++--
10 files changed, 7 insertions(+), 95 deletions(-)
New commits:
commit 0df982ac881d80db7caf06ce9402691a4a0ad7fd
Author: Noel Grandin
AuthorDate: Fri Jul 21 14:41:57 2023 +0200
Commit: Noel Grandin
CommitDate: Sat Jul 22 08:51:27 2023 +0200
merge SetOptions_Nbc and SetOptions
since the Nbc variant is no longer necessary
Change-Id: I4a846dcdbe68116dd511e45f018af2cdc5fbcf48
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154725
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/include/sfx2/app.hxx b/include/sfx2/app.hxx
index 4a6e8428972d..bd214ce2f2e5 100644
--- a/include/sfx2/app.hxx
+++ b/include/sfx2/app.hxx
@@ -164,7 +164,6 @@ public:
SAL_DLLPRIVATE SfxDispatcher* GetAppDispatcher_Impl();
SAL_DLLPRIVATE SfxDispatcher* GetDispatcher_Impl();
-SAL_DLLPRIVATE static void SetOptions_Nbc(const SfxItemSet &);
SAL_DLLPRIVATE void Initialize_Impl();
SAL_DLLPRIVATE SfxAppData_Impl* Get_Impl() const { return pImpl.get(); }
diff --git a/sfx2/source/appl/appcfg.cxx b/sfx2/source/appl/appcfg.cxx
index 1f030223c2f3..679eb2cd3da9 100644
--- a/sfx2/source/appl/appcfg.cxx
+++ b/sfx2/source/appl/appcfg.cxx
@@ -231,7 +231,7 @@ void SfxApplication::GetOptions( SfxItemSet& rSet )
}
}
-void SfxApplication::SetOptions_Nbc(const SfxItemSet& rSet)
+void SfxApplication::SetOptions(const SfxItemSet )
{
std::shared_ptr< comphelper::ConfigurationChanges > batch(
comphelper::ConfigurationChanges::create());
@@ -335,12 +335,6 @@ void SfxApplication::SetOptions_Nbc(const SfxItemSet& rSet)
}
-void SfxApplication::SetOptions(const SfxItemSet )
-{
-SetOptions_Nbc( rSet );
-}
-
-
void SfxApplication::NotifyEvent( const SfxEventHint& rEventHint, bool
bSynchron )
{
SfxObjectShell *pDoc = rEventHint.GetObjShell();
diff --git a/sfx2/source/appl/appserv.cxx b/sfx2/source/appl/appserv.cxx
index b7e89ab735ad..507cc60cc672 100644
--- a/sfx2/source/appl/appserv.cxx
+++ b/sfx2/source/appl/appserv.cxx
@@ -325,7 +325,7 @@ void SfxApplication::MiscExec_Impl( SfxRequest& rReq )
case SID_SETOPTIONS:
{
if( rReq.GetArgs() )
-SetOptions_Nbc( *rReq.GetArgs() );
+SetOptions( *rReq.GetArgs() );
break;
}
commit 6d9e304d1748668cc25905945129095bd14fd1af
Author: Noel Grandin
AuthorDate: Fri Jul 21 14:39:42 2023 +0200
Commit: Noel Grandin
CommitDate: Sat Jul 22 08:51:18 2023 +0200
SfxItemSetHint is dead
since
commit 519876dffdc8c93710af543cc11332dab9a50c14
Author: Mike Kaganski
Date: Tue Jul 18 23:45:47 2023 +0300
Cleanup SfxApplication::Get/SetOptions, and drop unused SIDs
Change-Id: I8d306bf6792630cfdaa0a0ac8b77730e1e1f0070
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154724
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/cui/source/options/treeopt.cxx b/cui/source/options/treeopt.cxx
index d3c65eb0c847..3a637145e13d 100644
--- a/cui/source/options/treeopt.cxx
+++ b/cui/source/options/treeopt.cxx
@@ -1143,7 +1143,7 @@ void OfaTreeOptionsDialog::ApplyItemSet( sal_uInt16 nId,
const SfxItemSet& rSet
SfxItemSetFixed
aOptSet(SfxGetpApp()->GetPool());
aOptSet.Put(rSet);
if(aOptSet.Count())
-SfxGetpApp()->SetOptions( aOptSet );
+SfxApplication::SetOptions( aOptSet );
// get dispatcher anew, because SetOptions() might have destroyed
the dispatcher
SfxViewFrame *pViewFrame = SfxViewFrame::Current();
@@ -1193,7 +1193,7 @@ void OfaTreeOptionsDialog::ApplyItemSet( sal_uInt16 nId,
const SfxItemSet& rSet
break;
case SID_INET_DLG :
case SID_FILTER_DLG:
-SfxGetpApp()->SetOptions( rSet );
+SfxApplication::SetOptions( rSet );
break;
case SID_SB_STARBASEOPTIONS:
diff --git a/include/sfx2/app.hxx b/include/sfx2/app.hxx
index 09ddd082db31..4a6e8428972d 100644
--- a/include/sfx2/app.hxx
+++ b/include/sfx2/app.hxx
@@ -155,7 +155,7 @@ public:
// misc.
static void GetOptions(SfxItemSet &);
-voidSetOptions(const SfxItemSet &);
+static void SetOptions(const SfxItemSet &);
virtual voidInvalidate(sal_uInt16 nId = 0) override;
voidNotifyEvent(const SfxEventHint& rEvent, bool
[Libreoffice-commits] core.git: connectivity/source
connectivity/source/parse/sqlbison.y |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit f8a312617838e8626e6e406791ad8d0aac368f23
Author: jucasaca
AuthorDate: Sat Jul 22 17:40:58 2023 +0200
Commit: Lionel Mamane
CommitDate: Sat Jul 22 21:48:13 2023 +0200
fixing a typo in sqlbison.y
schema_glement_list is not registered, son can't be used.
schema_element_list is registered and defined and seems to be the correct
Change-Id: I7661532707ce6ddb32b95629192e9ba9847f21df
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154766
Reviewed-by: Julien Nabet
Reviewed-by: Lionel Mamane
Tested-by: Lionel Mamane
diff --git a/connectivity/source/parse/sqlbison.y
b/connectivity/source/parse/sqlbison.y
index 8263535dc82b..eef20bd56b4a 100644
--- a/connectivity/source/parse/sqlbison.y
+++ b/connectivity/source/parse/sqlbison.y
@@ -323,7 +323,7 @@ schema:
opt_schema_element_list:
{$$ = SQL_NEW_RULE;}
- | schema_glement_list
+ | schema_element_list
;
schema_element_list:
[Libreoffice-commits] core.git: 2 commits - drawinglayer/source include/tools tools/source
drawinglayer/source/tools/primitive2dxmldump.cxx | 10 ++
include/tools/XmlWriter.hxx | 14 +
tools/source/xml/XmlWriter.cxx | 33 ---
3 files changed, 35 insertions(+), 22 deletions(-)
New commits:
commit 81f4f1ea1d13dcdf8ea693a48ce2d753729d87aa
Author: Noel Grandin
AuthorDate: Sat Jul 22 16:23:15 2023 +0200
Commit: Noel Grandin
CommitDate: Sat Jul 22 23:01:02 2023 +0200
simplify some calls to XmlWriter::attribute
Change-Id: Ibc3aa732dec2f6c26750ba056f5f8d71ae34b63e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154765
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/drawinglayer/source/tools/primitive2dxmldump.cxx
b/drawinglayer/source/tools/primitive2dxmldump.cxx
index 38e6a3ea9773..0585ce7168f8 100644
--- a/drawinglayer/source/tools/primitive2dxmldump.cxx
+++ b/drawinglayer/source/tools/primitive2dxmldump.cxx
@@ -616,8 +616,7 @@ public:
default:
{
rWriter.startElement("unhandled");
-rWriter.attribute("id",
- OUStringToOString(sCurrentElementTag,
RTL_TEXTENCODING_UTF8));
+rWriter.attribute("id", sCurrentElementTag);
rWriter.attribute("idNumber", nId);
drawinglayer::geometry::ViewInformation3D
aViewInformation3D;
@@ -1217,8 +1216,7 @@ void Primitive2dXmlDump::decomposeAndWrite(
}
}
rWriter.startElement(aName);
-rWriter.attribute("id",
- OUStringToOString(sCurrentElementTag,
RTL_TEXTENCODING_UTF8));
+rWriter.attribute("id", sCurrentElementTag);
rWriter.attribute("idNumber", nId);
auto pBufferedDecomposition
commit 2006d7455f529d3d6f44d09a83be9a80e73b1d34
Author: Noel Grandin
AuthorDate: Sat Jul 22 16:20:16 2023 +0200
Commit: Noel Grandin
CommitDate: Sat Jul 22 23:00:53 2023 +0200
no need to create OString temporaries when calling XmlWriter methods
Change-Id: Ief1101c55a0635dac43a7c4d66dd4ed0d5be70bd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154764
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/drawinglayer/source/tools/primitive2dxmldump.cxx
b/drawinglayer/source/tools/primitive2dxmldump.cxx
index a68692649f46..38e6a3ea9773 100644
--- a/drawinglayer/source/tools/primitive2dxmldump.cxx
+++ b/drawinglayer/source/tools/primitive2dxmldump.cxx
@@ -925,7 +925,7 @@ void Primitive2dXmlDump::decomposeAndWrite(
for (size_t iDx = 0; iDx < aDx.size(); ++iDx)
{
OString sName = "dx" + OString::number(iDx);
-rWriter.attribute(sName, OUString::number(aDx[iDx]));
+rWriter.attribute(sName, OString::number(aDx[iDx]));
}
}
rWriter.endElement();
@@ -1207,7 +1207,7 @@ void Primitive2dXmlDump::decomposeAndWrite(
default:
{
-OString aName("unhandled");
+const char* aName = "unhandled";
switch (nId)
{
case PRIMITIVE2D_ID_RANGE_SVX | 14: //
PRIMITIVE2D_ID_SDRCELLPRIMITIVE2D
diff --git a/include/tools/XmlWriter.hxx b/include/tools/XmlWriter.hxx
index e8f6579b0e95..400748611bd5 100644
--- a/include/tools/XmlWriter.hxx
+++ b/include/tools/XmlWriter.hxx
@@ -44,21 +44,23 @@ public:
bool startDocument(sal_Int32 nIndent = 2, bool bWriteXmlHeader = true);
void endDocument();
+void startElement(const char* sName);
void startElement(const OString& sName);
void startElement(const OString& sPrefix, const OString& sName, const
OString& sNamespaceUri);
void endElement();
+void attribute(const char* sTagName, const OString& aValue);
void attribute(const OString& sTagName, const OString& aValue);
-void attribute(const OString& sTagName, std::u16string_view aValue);
-void attribute(const OString& sTagName, sal_Int32 aNumber);
-void attributeDouble(const OString& sTagName, double aNumber);
-void attributeBase64(const OString& sTagName, std::vector
const& rValueInBytes);
-void attributeBase64(const OString& sTagName, std::vector const&
rValueInBytes);
+void attribute(const char* sTagName, std::u16string_view aValue);
+void attribute(const char* sTagName, sal_Int32 aNumber);
+void attributeDouble(const char* sTagName, double aNumber);
+void attributeBase64(const char* sTagName, std::vector const&
rValueInBytes);
+void attributeBase64(const char* sTagName, std::vector const&
rValueInBytes);
void content(const OString& sValue);
void content(std::u16string_view sValue);
-void element(const OString& sName);
+void element(const char* sName);
};
[Libreoffice-commits] core.git: svx/uiconfig
svx/uiconfig/ui/accessibilitycheckentry.ui |1 + 1 file changed, 1 insertion(+) New commits: commit d89dc4ac09d3c2bd55174f09485173057cc1403b Author: Balazs Varga AuthorDate: Fri Jul 21 15:55:33 2023 +0200 Commit: Thorsten Behrens CommitDate: Sat Jul 22 23:45:21 2023 +0200 tdf#156137 - A11Y - Fix Long object names need to proper handling Add text wrap option (long names ends with '...') for in case of proper handling of long GOTO GtkLinkButton objects in case of accessibility sidebar. Change-Id: I3c4af522fc34289ca57b1a7878134c34353bbc47 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154726 Tested-by: Jenkins Reviewed-by: Thorsten Behrens diff --git a/svx/uiconfig/ui/accessibilitycheckentry.ui b/svx/uiconfig/ui/accessibilitycheckentry.ui index ea4b63c5fe88..3e364419fcdb 100644 --- a/svx/uiconfig/ui/accessibilitycheckentry.ui +++ b/svx/uiconfig/ui/accessibilitycheckentry.ui @@ -37,6 +37,7 @@ True start True +True none
[Libreoffice-commits] core.git: Branch 'libreoffice-7-6' - drawinglayer/source include/basegfx include/drawinglayer include/svx sc/source sd/source svx/source
drawinglayer/source/processor2d/hittestprocessor2d.cxx | 49
include/basegfx/range/Range2D.hxx |7 ++
include/drawinglayer/processor2d/hittestprocessor2d.hxx | 10 +--
include/svx/sdrhittesthelper.hxx| 12 ++-
sc/source/ui/drawfunc/fupoor.cxx|5 -
sc/source/ui/drawfunc/fusel2.cxx|5 -
sc/source/ui/unoobj/viewuno.cxx |5 -
sd/source/ui/func/fudraw.cxx| 12 +--
sd/source/ui/func/fusel.cxx | 12 +--
sd/source/ui/view/sdview3.cxx | 13 +---
svx/source/accessibility/GraphCtlAccessibleContext.cxx |2
svx/source/sdr/overlay/overlayobjectlist.cxx|2
svx/source/svdraw/sdrhittesthelper.cxx | 19 ++
svx/source/svdraw/svdetc.cxx|2
svx/source/svdraw/svdmrkv.cxx |4 -
svx/source/svdraw/svdobj.cxx|2
svx/source/svdraw/svdocapt.cxx |2
svx/source/svdraw/svdoedge.cxx | 12 +--
svx/source/svdraw/svdview.cxx | 25 +---
19 files changed, 108 insertions(+), 92 deletions(-)
New commits:
commit 79669ba9f03230de616a631e85f9dd6cb7ef117a
Author: Sarper Akdemir
AuthorDate: Tue Jul 18 16:57:59 2023 +0300
Commit: Thorsten Behrens
CommitDate: Sat Jul 22 23:43:10 2023 +0200
tdf#152992: for Impress/Draw add horizontal hit tolerance for quick text
edit
Implements horizontal hit tolerance for quick text edit in Impress & Draw
making it more forgiving. Previously it was required to click exactly on
the glyph to get a direct text cursor.
Refactors hittestprocessor2d so that it now supports pseudo per axis hit
tolerance.
i.e. underlying isInEpsilonRange hit check is still the same utilizing
the larger tolerance of the two per axis tolerance, but the preliminary
check that uses aPolygonRange.grow() and later aPolygonRange.isInside()
now filters hit misses out with respect to the per axis hit tolerance.
Utilizes hittestprocessor2d's new per axis tolerance to introduce hit
tolerance for quick text edit, making it similar to TextEdit mode hit
tolerance which only has horizontal tolerance.
Fixes wrong use of BoundRect hit to determine text frame border hits.
Which previously only made sense for TextFrame borders, and was mostly
useless for shapes with text inside.
Change-Id: I749e63752da05b01270bfcab2632c41879a848ec
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154640
Reviewed-by: Heiko Tietze
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens
(cherry picked from commit 389454dcba63565690d84d693d1d43c1b95930c3)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154694
diff --git a/drawinglayer/source/processor2d/hittestprocessor2d.cxx
b/drawinglayer/source/processor2d/hittestprocessor2d.cxx
index 9af3504a5113..6e624fa4ef97 100644
--- a/drawinglayer/source/processor2d/hittestprocessor2d.cxx
+++ b/drawinglayer/source/processor2d/hittestprocessor2d.cxx
@@ -41,27 +41,25 @@ namespace drawinglayer::processor2d
{
HitTestProcessor2D::HitTestProcessor2D(const
geometry::ViewInformation2D& rViewInformation,
const basegfx::B2DPoint& rLogicHitPosition,
-double fLogicHitTolerance,
+const basegfx::B2DVector& rLogicHitTolerance,
bool bHitTextOnly)
: BaseProcessor2D(rViewInformation),
-mfDiscreteHitTolerance(0.0),
+maDiscreteHitTolerance(rLogicHitTolerance),
mbCollectHitStack(false),
mbHit(false),
mbHitTextOnly(bHitTextOnly)
{
-// init hit tolerance
-mfDiscreteHitTolerance = fLogicHitTolerance;
+// ensure input parameters for hit tolerance is >= 0.0
+if (maDiscreteHitTolerance.getX() < 0.0)
+maDiscreteHitTolerance.setX(0.0);
+if (maDiscreteHitTolerance.getY() < 0.0)
+maDiscreteHitTolerance.setY(0.0);
-if(basegfx::fTools::less(mfDiscreteHitTolerance, 0.0))
-{
-// ensure input parameter for hit tolerance is >= 0.0
-mfDiscreteHitTolerance = 0.0;
-}
-else if(basegfx::fTools::more(mfDiscreteHitTolerance, 0.0))
+if (!maDiscreteHitTolerance.equalZero())
{
// generate discrete hit tolerance
-mfDiscreteHitTolerance =
(getViewInformation2D().getObjectToViewTransformation()
-* basegfx::B2DVector(mfDiscreteHitTolerance,
0.0)).getLength();
+maDiscreteHitTolerance
+= getViewInformation2D().getObjectToViewTransformation() *
rLogicHitTolerance;
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
2 new defect(s) introduced to LibreOffice found with Coverity Scan.
1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent
build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)
** CID 1539071: Integer handling issues (DIVIDE_BY_ZERO)
/accessibility/source/extended/accessibletablistboxtable.cxx: 328 in
accessibility::AccessibleTabListBoxTable::getSelectedAccessibleChild(long)()
*** CID 1539071: Integer handling issues (DIVIDE_BY_ZERO)
/accessibility/source/extended/accessibletablistboxtable.cxx: 328 in
accessibility::AccessibleTabListBoxTable::getSelectedAccessibleChild(long)()
322
323 sal_Int32 nRows = implGetSelRowCount();
324 if ( nRows == 0 )
325 throw IndexOutOfBoundsException();
326
327 const sal_Int32 nColCount = implGetColumnCount();
>>> CID 1539071: Integer handling issues (DIVIDE_BY_ZERO)
>>> In expression "nSelectedChildIndex / nColCount", division by expression
>>> "nColCount" which may be zero has undefined behavior.
328 const sal_Int32 nRow = implGetSelRow(nSelectedChildIndex /
nColCount);
329 const sal_Int32 nColumn = nSelectedChildIndex % nColCount;
330 return getAccessibleCellAt( nRow, nColumn );
331 }
332
333 void SAL_CALL AccessibleTabListBoxTable::deselectAccessibleChild(
sal_Int64 nSelectedChildIndex )
** CID 1539070: Null pointer dereferences (REVERSE_INULL)
/sd/source/ui/func/futext.cxx: 725 in sd::FuText::MouseButtonUp(const
MouseEvent &)()
*** CID 1539070: Null pointer dereferences (REVERSE_INULL)
/sd/source/ui/func/futext.cxx: 725 in sd::FuText::MouseButtonUp(const
MouseEvent &)()
719 }
720
721 ForcePointer();
722 mpWindow->ReleaseMouse();
723 sal_uInt16 nDrgLog1 = sal_uInt16 (
mpWindow->PixelToLogic(Size(mpView->GetDragThresholdPixels(),0)).Width() );
724
>>> CID 1539070: Null pointer dereferences (REVERSE_INULL)
>>> Null-checking "this->mpView" suggests that it may be null, but it has
>>> already been dereferenced on all paths leading to the check.
725 if ( mpView && !mpView->AreObjectsMarked() &&
726 std::abs(aMDPos.X() - aPnt.X()) < nDrgLog1 &&
727 std::abs(aMDPos.Y() - aPnt.Y()) < nDrgLog1 &&
728 !rMEvt.IsShift() && !rMEvt.IsMod2() )
729 {
730 SdrPageView* pPV2 = mpView->GetSdrPageView();
To view the defects in Coverity Scan visit,
https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DmZOW_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJizAj7K4U7LzoHJpnORrww8GbnFbzCRczyOubZ3ivnZuxJoEh8jLeAyHSSX7-2FzL2YgzK-2FC5SE-2FcHMcgtucfLH8dF2GvzvGEcFPnle3I-2FlMrflZ7bB6rXCS798C2HzDXonQaMD-2F5Z56xbUYVGAjGGiJpfZIow8lM4QcZvz7kfUQYL4-3D
Re: tdf#156333: Implementing Text Effects
Hi, On Thu, Jul 20, 2023 at 4:53 PM владислав тараканов wrote: > > Hello > > We, together with irgalie...@mail.ru, want to try adding support for various > text styles (glow, tint, shadow, etc.) in Writer. But we are still only > beginner developers, so we would like to ask where exactly in the code should > we start fixing this problem? We've previously looked at the oox and sfx2 > modules but didn't find anything relevant. Great. There are multiple things you need to do to add a missing feature like this: - extend the model to store the additional data about the feature - for example glow radius (inside sw) - use the new data in the model to influence the rendering (inside sw) - access the new data via UNO if needed (sw, offapi) - add file format support for OOXML - import and export (mainly writerfilter, also oox and sw) - add support for ODF - import and export (sw, xmloff) - extend the UI to manipulate the new data (sw) I would first make it so that you get the data into the model and that it is properly filled when you open an OOXML file and properly saved to an OOXML file when you save the document. Currently we preserve the data of text effects, but we preserve it by putting it into what we call a "GrabBag". This stores the data inside the model, but only for the purpose that it survives a import/export cycle and not to be a proper part of the model. Tests for these things are in [1] but the import is located in [2] and export is located in [3] - so first you have to change those to not use "GrabBag" anymore for the text effects you want to implement (glow for example) and store the data at the same level that the text color, outline or shadow data is already saved. One you have this, then you can look into how to actually render these things (probably very similar to how shadows are already rendered), but first I would make sure that you have properly solved the model part of this. [1] sw/qa/extras/ooxmlexport/ooxmlw14export.cxx [2] writerfilter/source/dmapper/TextEffectsHandler.cxx [3] sw/source/filter/ww8/docxattributeoutput.cxx If you have any questions, don't hesitate to ask. > -- > Vladislav Tarakanov Best regards, Tomaž Vajngerl
[Libreoffice-commits] help.git: source/text
source/text/swriter/00/0404.xhp | 30 ++ source/text/swriter/01/0412.xhp |9 + source/text/swriter/01/04120200.xhp | 14 +++--- source/text/swriter/main0104.xhp| 28 ++-- 4 files changed, 52 insertions(+), 29 deletions(-) New commits: commit acfa489281ad217a46cdfe5558a2bcdcd963d347 Author: Olivier Hallot AuthorDate: Fri Jul 21 19:52:06 2023 -0300 Commit: Olivier Hallot CommitDate: Sat Jul 22 13:16:45 2023 +0200 tdf#155875 Tab'd UI cmds Writer/Insert in Help(14) + refactoring + Writer Insert menu (part 14) Change-Id: I3e22d333174bde886ffb633568b3effc5a1cdf04 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/154751 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/source/text/swriter/00/0404.xhp b/source/text/swriter/00/0404.xhp index e40775a7b4..eb137026bb 100644 --- a/source/text/swriter/00/0404.xhp +++ b/source/text/swriter/00/0404.xhp @@ -207,8 +207,11 @@ Choose Insert - Script (only HTML documents) -Choose Insert - Table of Contents and Index - + + + + Choose Insert - Table of Contents and Index + Choose Insert - Table of Contents and Index - Index Entry @@ -229,8 +232,27 @@ -Choose Insert - Table of Contents and Index - Table of Contents, Index or Bibliography - + + + Choose Insert - Table of Contents and Index - Table of Contents, Index or Bibliography + + Choose Edit Index in the index. + + Choose Reference - Table of Contents. + On the Reference menu of the Reference tab, choose Table of Contents, Index or Bibliography. + + + + + Icon Insert Index + + + Insert Index + + + + + Choose Insert - Table of Contents and Index - Bibliography Entry Choose Insert - Table of Contents and Index - Table of Contents, Index or Bibliography diff --git a/source/text/swriter/01/0412.xhp b/source/text/swriter/01/0412.xhp index 761fb6c025..51771cf600 100644 --- a/source/text/swriter/01/0412.xhp +++ b/source/text/swriter/01/0412.xhp @@ -20,7 +20,7 @@ -Table of Contents and Index +Table of Contents and Index /text/swriter/01/0412.xhp @@ -31,21 +31,22 @@ Table of Contents and Index -Opens a menu to insert an index or bibliography entry, as well as inserting a table of contents, index, and or bibliography. +Opens a menu to insert an index or bibliography entry, as well as inserting a table of contents, index, and or bibliography. +Table of Content, Index or Bibliography + + Index Entry Bibliography Entry -Table of Content, Index or Bibliography - diff --git a/source/text/swriter/01/04120200.xhp b/source/text/swriter/01/04120200.xhp index 5cb368bf18..4b61f93df9 100644 --- a/source/text/swriter/01/04120200.xhp +++ b/source/text/swriter/01/04120200.xhp @@ -19,7 +19,7 @@ -Table of Contents, Index or Bibliography +Table of Contents, Index or Bibliography /text/swriter/01/04120200.xhp @@ -29,23 +29,23 @@ - + Table of Contents, Index or Bibliography - Inserts an index or a table of contents at the current cursor position. To edit an index or table of contents, place the cursor in the index or table of contents, and then choose Insert - Table of Contents and Index - Table of Contents, Index or Bibliography. + Inserts an index or a table of contents at the current cursor position. To edit an index or table of contents, place the cursor in the index or table of contents, and then choose Insert - Table of Contents and Index - Table of Contents, Index or Bibliography. - You can also preview the index or table in this dialog. - Depending on the type of index or table that you select, the following tabs are present. + You can also preview the index or table in this dialog. + Depending on the type of index or table that you select, the following tabs are present. - Use this tab to specify the column layout for the index or table of contents. By default, the index title is one-column wide and extends out from left page margin. + Use this tab to specify the column layout for the index or table of contents. By default, the index title is one-column wide and extends out from left page margin. -Using Tables of Content and Indexes +Using Tables of Content and Indexes diff --git a/source/text/swriter/main0104.xhp b/source/text/swriter/main0104.xhp index f4391f4981..4a0ebc8627 100644 --- a/source/text/swriter/main0104.xhp +++ b/source/text/swriter/main0104.xhp @@ -20,19 +20,19 @@ -Insert +Insert /text/swriter/main0104.xhp - -Insert -The Insert menu contains commands
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 42115cdc1d51158c49bc9fe20cce015db440710f Author: Olivier Hallot AuthorDate: Sat Jul 22 08:16:46 2023 -0300 Commit: Gerrit Code Review CommitDate: Sat Jul 22 13:16:46 2023 +0200 Update git submodules * Update helpcontent2 from branch 'master' to acfa489281ad217a46cdfe5558a2bcdcd963d347 - tdf#155875 Tab'd UI cmds Writer/Insert in Help(14) + refactoring + Writer Insert menu (part 14) Change-Id: I3e22d333174bde886ffb633568b3effc5a1cdf04 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/154751 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/helpcontent2 b/helpcontent2 index 04f63a94b233..acfa489281ad 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 04f63a94b233bd31339146384fb0f3815dead3d1 +Subproject commit acfa489281ad217a46cdfe5558a2bcdcd963d347
[Libreoffice-commits] core.git: connectivity/source
connectivity/source/drivers/firebird/StatementCommonBase.cxx |1 + 1 file changed, 1 insertion(+) New commits: commit 9b887f63147914793f881c0cf4a730a46d6f688c Author: Julien Nabet AuthorDate: Sat Jul 22 12:44:01 2023 +0200 Commit: Julien Nabet CommitDate: Sat Jul 22 15:55:15 2023 +0200 tdf#146584: FB Setting default with ALTER TABLE works but gives useless message ALTER is a DDL (DATA DEFINITION LANGAGE) instruction, no count row is expected. Change-Id: I3d5bfe240b85c5b79392c92fdd870bc045e1eb46 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154755 Reviewed-by: Julien Nabet Tested-by: Jenkins diff --git a/connectivity/source/drivers/firebird/StatementCommonBase.cxx b/connectivity/source/drivers/firebird/StatementCommonBase.cxx index 917f801c7a9d..29ef5925657d 100644 --- a/connectivity/source/drivers/firebird/StatementCommonBase.cxx +++ b/connectivity/source/drivers/firebird/StatementCommonBase.cxx @@ -453,6 +453,7 @@ sal_Int32 OStatementCommonBase::getStatementChangeCount() aDesiredInfoType = isc_info_req_delete_count; break; case isc_info_sql_stmt_exec_procedure: +case isc_info_sql_stmt_ddl: return 0; // cannot determine default: throw SQLException(); // TODO: better error message?
building error inside Skia
Hi all. I got the error when I tried to build LibreOffice on my Linux machine: I will show you only latest string from terminal output: . [CXX] codemaker/source/codemaker/typemanager.cxx [CXX] codemaker/source/codemaker/unotype.cxx [CXX] codemaker/source/codemaker/codemaker.cxx [PRJ] libgpg-error [DEP] LNK:StaticLibrary/libgraphite.a.d [LNK] StaticLibrary/libgraphite.a [CXX] tools/source/reversemap/bestreversemap.cxx [C ] UnpackedTarball/expat/lib/xmlparse.c [C ] UnpackedTarball/expat/lib/xmlrole.c [C ] UnpackedTarball/expat/lib/xmltok.c [CXX] external/skia/source/SkMemory_malloc.cxx [CXX] external/skia/source/skia_compiler.cxx In file included from /home/roman/LO/lo-source/external/skia/source/SkMemory_malloc.cxx:6: /home/roman/LO/lo-source/workdir/UnpackedTarball/skia/include/core/SkTypes.h:26:10: fatal error: 'climits' file not found #include ^ 1 error generated. make[1]: *** [/home/roman/LO/lo-source/solenv/gbuild/LinkTarget.mk:337: /home/roman/LO/lo-source/workdir/CxxObject/external/skia/source/SkMemory_malloc.o] Ошибка 1 make[1]: *** Ожидание завершения заданий… make: *** [Makefile:289: build] Ошибка 2 can anyone look at it? I saw letters by Andreas where he also had problems with LO building with Skia related messages. -- Best regards Roman Kuznetsov
[Libreoffice-commits] core.git: wizards/source
wizards/source/scriptforge/SF_FileSystem.xba | 202 --- wizards/source/scriptforge/SF_TextStream.xba |2 wizards/source/scriptforge/python/scriptforge.py |8 3 files changed, 151 insertions(+), 61 deletions(-) New commits: commit c216a5fc499dd3cd4324c30aa69df415ecf22113 Author: Jean-Pierre Ledure AuthorDate: Sat Jul 22 16:10:14 2023 +0200 Commit: Jean-Pierre Ledure CommitDate: Sat Jul 22 18:03:36 2023 +0200 ScriptForge (SF_FileSystem) IncludeSubfolders argument In the FileSystem service, the - SubFolders() - Files() methods receive an optional argument IncludeSubfolders (Boolean). That argument determines whether or not only the given FolderName is explored or also its subfolders up to the bottom of the folders structure. The argument must be used with caution as the number of returned folders or files may increase rapidly. anThis could consume excessive process time. This patch will require an update of the help page about the filesystem service. The new argument is available both for Basic and Python user scripts. Change-Id: Id2a96cd63cb51f8681f20a203a711b47a636fc3a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154763 Reviewed-by: Jean-Pierre Ledure Tested-by: Jenkins diff --git a/wizards/source/scriptforge/SF_FileSystem.xba b/wizards/source/scriptforge/SF_FileSystem.xba index bb611d69b59a..2364ec4206b1 100644 --- a/wizards/source/scriptforge/SF_FileSystem.xba +++ b/wizards/source/scriptforge/SF_FileSystem.xba @@ -84,6 +84,11 @@ Const cstForAppending= 8 Document file system Const DOCFILESYSTEM= vnd.sun.star.tdoc:/ + Folders and files scanning +Const cstSEPARATOR = //; Separates folders or files in the accumulators +Const cstFILES = 1 Caler = Files() +Const cstFOLDERS = 2 Caller = SubFolders() + REM = CONSTRUCTOR/DESTRUCTOR REM - @@ -762,11 +767,15 @@ End Function ScriptForge.SF_FileSystem.FileExists REM - Public Function Files(Optional ByVal FolderName As Variant _ , Optional ByVal Filter As Variant _ + , Optional ByVal IncludeSubfolders As Variant _ ) As Variant Return an array of the FileNames stored in the given folder. The folder must exist + Subfolders may be optionally explored too. + If the number of files exceeds a reasonable amount ( 1000 ?), the process time may become long. Args: FolderName: the folder to explore Filter: contains wildcards (? and *) to limit the list to the relevant files (default = ) + IncludeSubfolders: when True (default = False), subfolders are explored too. Returns: An array of strings, each entry is the FileName of an existing file Exceptions: @@ -775,58 +784,36 @@ Public Function Files(Optional ByVal FolderName As Variant _ Example: Dim a As Variant FSO.FileNaming = SYS - a = FSO.Files(C:\Windows\) + a = FSO.Files(C:\Windows\, IncludeSubfolders := True) Dim vFiles As VariantReturn value Dim oSfa As Object com.sun.star.ucb.SimpleFileAccess -Dim sFolderName As StringURL lias for FolderName -Dim sFile As String Single file -Dim bDocFileSystem As BooleanWhen True, a document file system is being explored +Dim sFilesColl As String cstSEPARATOR delimited string of list of files (FileNaming notation) Dim i As Long Const cstThisSub = FileSystem.Files -Const cstSubArgs = FolderName, [Filter=] +Const cstSubArgs = FolderName, [Filter=], [IncludeSubfolders=False] If SF_Utils._ErrorHandling() Then On Local Error GoTo Catch vFiles = Array() Check: If IsMissing(Filter) Or IsEmpty(Filter) Then Filter = + If IsMissing(IncludeSubfolders) Or IsEmpty(IncludeSubfolders) Then IncludeSubfolders = False If SF_Utils._EnterFunction(cstThisSub, cstSubArgs) Then If Not SF_Utils._ValidateFile(FolderName, FolderName) Then GoTo Finally If Not SF_Utils._Validate(Filter, Filter, V_STRING) Then GoTo Finally + If Not SF_Utils._Validate(IncludeSubfolders, IncludeSubfolders, V_BOOLEAN) Then GoTo Finally End If - sFolderName =
Re: tdf#156333: Implementing Text Effects
Hi, sorry that you haven't got any answer so far. Please be patient, we have weekend and summertime with lots of vacations. Unfortunately this is not my area, but this is, what I would do: We have already character effects "embossed", "engrave", "outline" and "shadow" in the Font Effects tab of the character properties. I would search for these terms. Besides the .ui and token-files, you will find some related .cxx files. I would look there, how these effects are implemented. "Implemented" includes model, rendering, load-save in ODF, import-export filter OOXML, UI. You will find then involved classes and methods and other relevant terms you can search. Do you have already looked at core/README.md? It gives an overview about most important modules and tips for further information. Kind regards, Regina владислав тараканов schrieb am 20.07.2023 um 13:52: Hello We, together with irgalie...@mail.ru, want to try adding support for various text styles (glow, tint, shadow, etc.) in Writer. But we are still only beginner developers, so we would like to ask where exactly in the code should we start fixing this problem? We've previously looked at the oox and sfx2 modules but didn't find anything relevant. -- Vladislav Tarakanov
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 4863f4fcbb48bd937283422c5d5b0c77d70db04a Author: Olivier Hallot AuthorDate: Sat Jul 22 09:42:14 2023 -0300 Commit: Gerrit Code Review CommitDate: Sat Jul 22 14:42:14 2023 +0200 Update git submodules * Update helpcontent2 from branch 'master' to ac354a87fb9f5d47d61b4532466ed5954680b5da - tdf#155875 Tab'd UI cmds Writer/Insert in Help(15) + refactoring + Writer Insert menu (part 15) Change-Id: Ic1af863bf61796af846f79e38cc793337eb8c91d Reviewed-on: https://gerrit.libreoffice.org/c/help/+/154756 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/helpcontent2 b/helpcontent2 index acfa489281ad..ac354a87fb9f 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit acfa489281ad217a46cdfe5558a2bcdcd963d347 +Subproject commit ac354a87fb9f5d47d61b4532466ed5954680b5da
[Libreoffice-commits] help.git: source/text
source/text/swriter/00/0404.xhp | 29 + source/text/swriter/01/0499.xhp | 12 ++-- 2 files changed, 31 insertions(+), 10 deletions(-) New commits: commit ac354a87fb9f5d47d61b4532466ed5954680b5da Author: Olivier Hallot AuthorDate: Sat Jul 22 08:18:48 2023 -0300 Commit: Olivier Hallot CommitDate: Sat Jul 22 14:42:13 2023 +0200 tdf#155875 Tab'd UI cmds Writer/Insert in Help(15) + refactoring + Writer Insert menu (part 15) Change-Id: Ic1af863bf61796af846f79e38cc793337eb8c91d Reviewed-on: https://gerrit.libreoffice.org/c/help/+/154756 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/source/text/swriter/00/0404.xhp b/source/text/swriter/00/0404.xhp index eb137026bb..74905f4420 100644 --- a/source/text/swriter/00/0404.xhp +++ b/source/text/swriter/00/0404.xhp @@ -31,11 +31,32 @@ Choose Insert - More Breaks + -Choose Insert - Field -Fields do not have context menus (15.01.20) -Open context menu - choose Fields (inserted fields) + + Choose Insert - Field + Fields do not have context menus (15.01.20) + + Open context menu - choose Edit Field (inserted fields) + + Choose Insert - Fields. + Choose Reference - Field. + On the References menu of the References tab, choose Field. + + + + + Icon Insert Field + + + Insert Field + + + + + CommandCtrl + F2 + Choose Insert - Field - Date Choose Insert - Field - Time Choose Insert - Field - Page Number @@ -72,7 +93,7 @@ Choose Insert - Cross-reference Choose Insert - Cross-reference. - Choose Reference - Cross-reference. + Choose References - Cross-reference. diff --git a/source/text/swriter/01/0499.xhp b/source/text/swriter/01/0499.xhp index fbf0a66410..fc320e0540 100644 --- a/source/text/swriter/01/0499.xhp +++ b/source/text/swriter/01/0499.xhp @@ -20,7 +20,7 @@ -Insert Fields (submenu) +Insert Fields (submenu) /text/swriter/01/0499.xhp @@ -29,10 +29,10 @@ - + -Field -The submenu lists the most common field types that can be inserted into a document at the current cursor position. To view all of the available fields, choose More Fields. +Field +The submenu lists the most common field types that can be inserted into a document at the current cursor position. To view all of the available fields, choose More Fields. @@ -46,7 +46,7 @@ -More Fields +More Fields - \ No newline at end of file +
[Libreoffice-commits] help.git: source/text
source/text/swriter/00/0404.xhp | 21 ++-- source/text/swriter/01/0407.xhp | 28 +++--- source/text/swriter/01/pagenumbering.xhp |1 source/text/swriter/menu/insert_header_footer.xhp | 13 ++ 4 files changed, 42 insertions(+), 21 deletions(-) New commits: commit 9f7c011c3ea533d8283b17dff0d191deb7235645 Author: Olivier Hallot AuthorDate: Sat Jul 22 09:07:50 2023 -0300 Commit: Olivier Hallot CommitDate: Sat Jul 22 14:43:13 2023 +0200 tdf#155875 Tab'd UI cmds Writer/Insert in Help(16) + refactoring + Writer Insert menu (part 16) Change-Id: Ia062ae356f3814514c2b9009bf5d50a040551e19 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/154758 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/source/text/swriter/00/0404.xhp b/source/text/swriter/00/0404.xhp index 74905f4420..396c54bcee 100644 --- a/source/text/swriter/00/0404.xhp +++ b/source/text/swriter/00/0404.xhp @@ -318,8 +318,25 @@ Choose Insert - Table of Contents and Index - Table of Contents, Index or Bibliography - Styles tab -Choose Insert - Envelope - + + + + Choose Insert - Envelope + + On the Insert menu of the Insert tab, choose Envelope. + + + + + Icon Insert Envelope + + + Insert Envelope + + + + + Choose Insert - Envelope - Envelope tab Choose Insert - Envelope - Format tab diff --git a/source/text/swriter/01/0407.xhp b/source/text/swriter/01/0407.xhp index 62f856b80c..09be4eaf0c 100644 --- a/source/text/swriter/01/0407.xhp +++ b/source/text/swriter/01/0407.xhp @@ -22,18 +22,18 @@ - Envelope + Envelope /text/swriter/01/0407.xhp -inserting;envelopes +inserting;envelopes letters;inserting envelopes envelopes MW made "envelopes;" a one level entry - + Envelope - Creates an envelope. On three tab pages, you can specify the addressee and sender, the position and format for both addresses, the size of the envelope, and the envelope orientation. + Creates an envelope. On three tab pages, you can specify the addressee and sender, the position and format for both addresses, the size of the envelope, and the envelope orientation. @@ -41,28 +41,28 @@ - + New doc. - Creates a new document and inserts the envelope. - + Creates a new document and inserts the envelope. + Insert - Inserts the envelope before the current page in the document. + Inserts the envelope before the current page in the document. To delete an envelope from a document -Click into the envelope page to make it the current page. +Click into the envelope page to make it the current page. -Right-click the field on the status line that shows "Envelope". -A submenu opens showing some page styles. +Right-click the field on the status line that shows "Envelope". +A submenu opens showing some page styles. -Choose the "Default" page style from the submenu. -This removes the special "Envelope" page formatting. +Choose the "Default" page style from the submenu. +This removes the special "Envelope" page formatting. -Delete the frames for sender and recipient. Click the border of each frame and press the Del key. +Delete the frames for sender and recipient. Click the border of each frame and press the Del key. diff --git a/source/text/swriter/01/pagenumbering.xhp b/source/text/swriter/01/pagenumbering.xhp index 7223aeedae..5e54de2baf 100644 --- a/source/text/swriter/01/pagenumbering.xhp +++ b/source/text/swriter/01/pagenumbering.xhp @@ -28,6 +28,7 @@ Choose Insert - Page Number. +Choose Layout - Page Number. In the Insert menu of the Insert tab, choose Page Numbers. diff --git a/source/text/swriter/menu/insert_header_footer.xhp b/source/text/swriter/menu/insert_header_footer.xhp index 2bc4de1643..8abe5d7861 100644 --- a/source/text/swriter/menu/insert_header_footer.xhp +++ b/source/text/swriter/menu/insert_header_footer.xhp @@ -20,22 +20,25 @@ -Header and Footer +Header and Footer /text/swriter/menu/insert_header_footer.xhp - - + Header and Footer -This submenu includes commands to add and remove page headers and footers. +This submenu includes commands to add and remove page headers and footers. + + + + Choose Insert - Header and Footer. - \ No newline
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit d9a984581319c3aacdd4852f0a4f76ddf1396262 Author: Olivier Hallot AuthorDate: Sat Jul 22 09:43:13 2023 -0300 Commit: Gerrit Code Review CommitDate: Sat Jul 22 14:43:13 2023 +0200 Update git submodules * Update helpcontent2 from branch 'master' to 9f7c011c3ea533d8283b17dff0d191deb7235645 - tdf#155875 Tab'd UI cmds Writer/Insert in Help(16) + refactoring + Writer Insert menu (part 16) Change-Id: Ia062ae356f3814514c2b9009bf5d50a040551e19 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/154758 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/helpcontent2 b/helpcontent2 index ac354a87fb9f..9f7c011c3ea5 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit ac354a87fb9f5d47d61b4532466ed5954680b5da +Subproject commit 9f7c011c3ea533d8283b17dff0d191deb7235645
[Libreoffice-commits] help.git: source/text
source/text/shared/00/0404.xhp | 16 ++- source/text/shared/01/addsignatureline.xhp | 39 ++-- source/text/shared/01/signsignatureline.xhp | 30 ++--- source/text/swriter/00/0404.xhp |2 + 4 files changed, 52 insertions(+), 35 deletions(-) New commits: commit 141b19cf577d2c6b3fb7b3c29dc67977352895c5 Author: Olivier Hallot AuthorDate: Sat Jul 22 09:40:45 2023 -0300 Commit: Olivier Hallot CommitDate: Sat Jul 22 14:44:00 2023 +0200 tdf#155875 Tab'd UI cmds Writer/Insert in Help(17) + refactoring + Writer Insert menu (part 17) Change-Id: Ia7764ad9125f14d288470b53275e626581b2534e Reviewed-on: https://gerrit.libreoffice.org/c/help/+/154759 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/source/text/shared/00/0404.xhp b/source/text/shared/00/0404.xhp index ed25587bf8..6af732dd13 100644 --- a/source/text/shared/00/0404.xhp +++ b/source/text/shared/00/0404.xhp @@ -402,7 +402,21 @@ -Choose Insert - Signature Line + +Choose Insert - Signature Line + +On the Insert menu of the Insert tab, choose Signature Line. + + + + +Icon Insert Signature Line + + +Insert Signature Line + + + diff --git a/source/text/shared/01/addsignatureline.xhp b/source/text/shared/01/addsignatureline.xhp index 247b9ed332..e329e43451 100644 --- a/source/text/shared/01/addsignatureline.xhp +++ b/source/text/shared/01/addsignatureline.xhp @@ -11,50 +11,51 @@ -Adding Signature Line in Documents +Adding Signature Line in Documents /text/shared/01/addsignatureline.xhp - - - + + + + digital signature;add signature linesignature line;adding Signature Line -Insert a graphic box representing a signature line of the document. +Insert a graphic box representing a signature line of the document. - - -Signature Line Box - - -The signature line displays an horizontal line, a location mark, the name, title and email of signer. + + +Signature Line Box + + +The signature line displays an horizontal line, a location mark, the name, title and email of signer. Name -Insert the name of the signer. The name is displayed in the signature line graphic box. +Insert the name of the signer. The name is displayed in the signature line graphic box. Title -Enter the title of the signer. The title is displayed in the signature line graphic box. +Enter the title of the signer. The title is displayed in the signature line graphic box. Email -Enter the email of the signer. The email is not displayed in the signature line graphic box, but is used for the digital signature. +Enter the email of the signer. The email is not displayed in the signature line graphic box, but is used for the digital signature. Signer can add comments -Enable signer to insert comments in the Sign Signature Line dialog at time of signature. +Enable signer to insert comments in the Sign Signature Line dialog at time of signature. Show sign date in signature line -Mark this checkbox to display the date of the signature, at the time when the document is digitally signed. +Mark this checkbox to display the date of the signature, at the time when the document is digitally signed. Instructions to the signer -Insert instructions for the signer. The instructions appears in the Sign Signature Line dialog box, at the time of signature. +Insert instructions for the signer. The instructions appears in the Sign Signature Line dialog box, at the time of signature. - - + + diff --git a/source/text/shared/01/signsignatureline.xhp b/source/text/shared/01/signsignatureline.xhp index d19c06c037..758b38f012 100644 --- a/source/text/shared/01/signsignatureline.xhp +++ b/source/text/shared/01/signsignatureline.xhp @@ -11,42 +11,42 @@ -Signing the Signature Line +Signing the Signature Line /text/shared/01/signsignatureline.xhp - - - + + + digital signature;sign signature linesignature line;signing Digitally Signing the Signature Line -%PRODUCTNAME lets you sign digitally a signature line in your document. -On signing a signature line, %PRODUCTNAME fills the line with the name of signer, adds the digital certificate issuer information and optionally insert the date of signature. +%PRODUCTNAME lets you sign digitally a signature line in your document. +
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 78fdaa670d80c880bbf07201619dc660fbf0f682 Author: Olivier Hallot AuthorDate: Sat Jul 22 09:44:00 2023 -0300 Commit: Gerrit Code Review CommitDate: Sat Jul 22 14:44:00 2023 +0200 Update git submodules * Update helpcontent2 from branch 'master' to 141b19cf577d2c6b3fb7b3c29dc67977352895c5 - tdf#155875 Tab'd UI cmds Writer/Insert in Help(17) + refactoring + Writer Insert menu (part 17) Change-Id: Ia7764ad9125f14d288470b53275e626581b2534e Reviewed-on: https://gerrit.libreoffice.org/c/help/+/154759 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/helpcontent2 b/helpcontent2 index 9f7c011c3ea5..141b19cf577d 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 9f7c011c3ea533d8283b17dff0d191deb7235645 +Subproject commit 141b19cf577d2c6b3fb7b3c29dc67977352895c5
Martin Gube License statement
All of my past & future contributions to LibreOffice may be licensed under the MPLv2/LGPLv3+ dual license. Additionally, to the extent possible under law, I waive all copyright and related or neighboring rights to my past & future Artwork and Design contributions to the LibreOffice project, and similarly to The Document Foundation, placing such contributions under CC0:https://creativecommons.org/publicdomain/zero/1.0
Re: building error inside Skia
On 22.7.2023 17.05, Roman Kuznetsov wrote: Hi all. I got the error when I tried to build LibreOffice on my Linux machine: I will show you only latest string from terminal output: . [CXX] codemaker/source/codemaker/typemanager.cxx [CXX] codemaker/source/codemaker/unotype.cxx [CXX] codemaker/source/codemaker/codemaker.cxx [PRJ] libgpg-error [DEP] LNK:StaticLibrary/libgraphite.a.d [LNK] StaticLibrary/libgraphite.a [CXX] tools/source/reversemap/bestreversemap.cxx [C ] UnpackedTarball/expat/lib/xmlparse.c [C ] UnpackedTarball/expat/lib/xmlrole.c [C ] UnpackedTarball/expat/lib/xmltok.c [CXX] external/skia/source/SkMemory_malloc.cxx [CXX] external/skia/source/skia_compiler.cxx In file included from /home/roman/LO/lo-source/external/skia/source/SkMemory_malloc.cxx:6: /home/roman/LO/lo-source/workdir/UnpackedTarball/skia/include/core/SkTypes.h:26:10: fatal error: 'climits' file not found #include ^ 1 error generated. make[1]: *** [/home/roman/LO/lo-source/solenv/gbuild/LinkTarget.mk:337: /home/roman/LO/lo-source/workdir/CxxObject/external/skia/source/SkMemory_malloc.o] Ошибка 1 make[1]: *** Ожидание завершения заданий… make: *** [Makefile:289: build] Ошибка 2 can anyone look at it? I saw letters by Andreas where he also had problems with LO building with Skia related messages. Hi, now I searched through my emails and one contributor said: "The issue is solved by installing a newer libstdc++. This is a common issue when upgrading Ubuntu to 22.04. Although we can find libstdc++ installed, they cannot be found during compilation. Reinstalling solves the issue." Ilmari
[Libreoffice-commits] core.git: tools/source
tools/source/xml/XmlWriter.cxx | 31 ++-
1 file changed, 10 insertions(+), 21 deletions(-)
New commits:
commit 60d7b73d6d92eeb331cfe48734094330546477db
Author: Noel Grandin
AuthorDate: Sat Jul 22 14:33:40 2023 +0200
Commit: Noel Grandin
CommitDate: Sat Jul 22 16:57:26 2023 +0200
avoid some unnecessary string copies in tools::XmlWriter
Change-Id: I5844a878f3e1d85956eae828e9093b2fd1f5a275
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154757
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/tools/source/xml/XmlWriter.cxx b/tools/source/xml/XmlWriter.cxx
index 85fbbf99544e..a13190ecf9d2 100644
--- a/tools/source/xml/XmlWriter.cxx
+++ b/tools/source/xml/XmlWriter.cxx
@@ -82,28 +82,21 @@ void XmlWriter::endDocument()
void XmlWriter::startElement(const OString& sPrefix, const OString& sName,
const OString& sNamespaceUri)
{
-xmlChar* xmlName = xmlCharStrdup(sName.getStr());
+xmlChar* xmlName = BAD_CAST(sName.getStr());
xmlChar* xmlPrefix = nullptr;
xmlChar* xmlNamespaceUri = nullptr;
if (!sPrefix.isEmpty())
-xmlPrefix = xmlCharStrdup(sPrefix.getStr());
+xmlPrefix = BAD_CAST(sPrefix.getStr());
if (!sNamespaceUri.isEmpty())
-xmlNamespaceUri = xmlCharStrdup(sNamespaceUri.getStr());
+xmlNamespaceUri = BAD_CAST(sNamespaceUri.getStr());
(void)xmlTextWriterStartElementNS(mpImpl->mpWriter, xmlPrefix, xmlName,
xmlNamespaceUri);
-
-xmlFree(xmlName);
-if (!sPrefix.isEmpty())
-xmlFree(xmlPrefix);
-if (!sNamespaceUri.isEmpty())
-xmlFree(xmlNamespaceUri);
}
void XmlWriter::startElement(const OString& sName)
{
-xmlChar* xmlName = xmlCharStrdup(sName.getStr());
+xmlChar* xmlName = BAD_CAST(sName.getStr());
(void)xmlTextWriterStartElement(mpImpl->mpWriter, xmlName);
-xmlFree(xmlName);
}
void XmlWriter::endElement() {
(void)xmlTextWriterEndElement(mpImpl->mpWriter); }
@@ -116,20 +109,17 @@ void XmlWriter::attributeBase64(const OString& rsName,
std::vector co
void XmlWriter::attributeBase64(const OString& rsName, std::vector
const& rValueInBytes)
{
-xmlChar* xmlName = xmlCharStrdup(rsName.getStr());
+xmlChar* xmlName = BAD_CAST(rsName.getStr());
(void)xmlTextWriterStartAttribute(mpImpl->mpWriter, xmlName);
(void)xmlTextWriterWriteBase64(mpImpl->mpWriter, rValueInBytes.data(), 0,
rValueInBytes.size());
(void)xmlTextWriterEndAttribute(mpImpl->mpWriter);
-xmlFree(xmlName);
}
void XmlWriter::attribute(const OString& name, const OString& value)
{
-xmlChar* xmlName = xmlCharStrdup(name.getStr());
-xmlChar* xmlValue = xmlCharStrdup(value.getStr());
+xmlChar* xmlName = BAD_CAST(name.getStr());
+xmlChar* xmlValue = BAD_CAST(value.getStr());
(void)xmlTextWriterWriteAttribute(mpImpl->mpWriter, xmlName, xmlValue);
-xmlFree(xmlValue);
-xmlFree(xmlName);
}
void XmlWriter::attribute(const OString& name, std::u16string_view value)
@@ -139,19 +129,18 @@ void XmlWriter::attribute(const OString& name,
std::u16string_view value)
void XmlWriter::attribute(const OString& name, const sal_Int32 aNumber)
{
-attribute(name, OUString::number(aNumber));
+attribute(name, OString::number(aNumber));
}
void XmlWriter::attributeDouble(const OString& name, const double aNumber)
{
-attribute(name, OUString::number(aNumber));
+attribute(name, OString::number(aNumber));
}
void XmlWriter::content(const OString& sValue)
{
-xmlChar* xmlValue = xmlCharStrdup(sValue.getStr());
+xmlChar* xmlValue = BAD_CAST(sValue.getStr());
(void)xmlTextWriterWriteString(mpImpl->mpWriter, xmlValue);
-xmlFree(xmlValue);
}
void XmlWriter::content(std::u16string_view sValue)
[Libreoffice-commits] core.git: comphelper/source
comphelper/source/misc/accessiblecomponenthelper.cxx |7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) New commits: commit 072ecc03c496dcf33a14f7f0ef6aab9b5766cdd0 Author: Julien Nabet AuthorDate: Sat Jul 22 12:14:58 2023 +0200 Commit: Julien Nabet CommitDate: Sat Jul 22 13:25:02 2023 +0200 Simplify a bit construction of AccessibleEventObject object Change-Id: I0012de655d2ea24c822cf10828e7a31fa2e535ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154754 Reviewed-by: Julien Nabet Tested-by: Jenkins diff --git a/comphelper/source/misc/accessiblecomponenthelper.cxx b/comphelper/source/misc/accessiblecomponenthelper.cxx index 07d05d31a31d..3922812b92af 100644 --- a/comphelper/source/misc/accessiblecomponenthelper.cxx +++ b/comphelper/source/misc/accessiblecomponenthelper.cxx @@ -121,12 +121,7 @@ namespace comphelper return; // build an event object -AccessibleEventObject aEvent; -aEvent.Source = *this; -aEvent.EventId = _nEventId; -aEvent.OldValue = _rOldValue; -aEvent.NewValue = _rNewValue; -aEvent.IndexHint = nIndexHint; +AccessibleEventObject aEvent(*this, _nEventId, _rNewValue, _rOldValue, nIndexHint); // let the notifier handle this event AccessibleEventNotifier::addEvent( m_nClientId, aEvent );
[Libreoffice-commits] core.git: 3 commits - include/vcl vcl/inc vcl/qa vcl/quartz vcl/skia vcl/source
include/vcl/outdev.hxx |2
include/vcl/vcllayout.hxx |6 +-
vcl/inc/ImplLayoutArgs.hxx |4 -
vcl/inc/font/FontMetricData.hxx |6 +-
vcl/inc/font/LogicalFontInstance.hxx|2
vcl/inc/impglyphitem.hxx| 33 ---
vcl/inc/quartz/salgdi.h |4 -
vcl/inc/sallayout.hxx | 16 +++
vcl/inc/skia/osx/gdiimpl.hxx|3 -
vcl/qa/cppunit/complextext.cxx |2
vcl/quartz/salgdi.cxx |6 +-
vcl/skia/osx/gdiimpl.cxx|4 -
vcl/source/font/LogicalFontInstance.cxx |2
vcl/source/gdi/CommonSalLayout.cxx | 16 +++
vcl/source/gdi/pdfwriter_impl.cxx |2
vcl/source/gdi/sallayout.cxx| 70 +++-
vcl/source/outdev/text.cxx | 64 +
vcl/source/text/ImplLayoutArgs.cxx |2
18 files changed, 109 insertions(+), 135 deletions(-)
New commits:
commit c46f8c356d812230c3a43cd08fb79674be88d9a8
Author: Khaled Hosny
AuthorDate: Mon Jul 17 12:16:58 2023 +0300
Commit: خالد حسني
CommitDate: Sun Jul 23 06:01:31 2023 +0200
vcl: Simplify AquaGraphics*::drawTextLayout() calling
Take TextRenderModeForResolutionIndependentLayout() from the SalLayout
argument instead of passing it separately.
Change-Id: I155ea645e401618ad884fdc36c4c1aeab69980ee
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154516
Tested-by: Jenkins
Reviewed-by: خالد حسني
diff --git a/vcl/inc/quartz/salgdi.h b/vcl/inc/quartz/salgdi.h
index 01826c5c93e0..026f5e066382 100644
--- a/vcl/inc/quartz/salgdi.h
+++ b/vcl/inc/quartz/salgdi.h
@@ -292,7 +292,7 @@ public:
const tools::Rectangle ,
ControlState nState,
const ImplControlValue ) = 0;
-virtual void drawTextLayout(const GenericSalLayout& layout, bool
bTextRenderModeForResolutionIndependentLayout) = 0;
+virtual void drawTextLayout(const GenericSalLayout& layout) = 0;
virtual void Flush() {}
virtual void Flush( const tools::Rectangle& ) {}
virtual void WindowBackingPropertiesChanged() {};
@@ -445,7 +445,7 @@ public:
ControlState nState,
const ImplControlValue ) override;
-virtual void drawTextLayout(const GenericSalLayout& layout, bool
bTextRenderModeForResolutionIndependentLayout) override;
+virtual void drawTextLayout(const GenericSalLayout& layout) override;
bool supportsOperation(OutDevSupportType eType) const override;
};
diff --git a/vcl/inc/skia/osx/gdiimpl.hxx b/vcl/inc/skia/osx/gdiimpl.hxx
index b90b576a873f..b97245e86e11 100644
--- a/vcl/inc/skia/osx/gdiimpl.hxx
+++ b/vcl/inc/skia/osx/gdiimpl.hxx
@@ -38,8 +38,7 @@ public:
const tools::Rectangle& rControlRegion,
ControlState nState,
const ImplControlValue& aValue) override;
-virtual void drawTextLayout(const GenericSalLayout& layout,
-bool
bTextRenderModeForResolutionIndependentLayout) override;
+virtual void drawTextLayout(const GenericSalLayout& layout) override;
virtual void Flush() override;
virtual void Flush(const tools::Rectangle&) override;
diff --git a/vcl/quartz/salgdi.cxx b/vcl/quartz/salgdi.cxx
index 4af4b28ffa2c..b06e0d41bdbd 100644
--- a/vcl/quartz/salgdi.cxx
+++ b/vcl/quartz/salgdi.cxx
@@ -306,10 +306,10 @@ bool
AquaSalGraphics::AddTempDevFont(vcl::font::PhysicalFontCollection*,
void AquaSalGraphics::DrawTextLayout(const GenericSalLayout& rLayout)
{
-mpBackend->drawTextLayout(rLayout,
rLayout.GetTextRenderModeForResolutionIndependentLayout());
+mpBackend->drawTextLayout(rLayout);
}
-void AquaGraphicsBackend::drawTextLayout(const GenericSalLayout& rLayout, bool
bTextRenderModeForResolutionIndependentLayout)
+void AquaGraphicsBackend::drawTextLayout(const GenericSalLayout& rLayout)
{
#ifdef IOS
if (!mrShared.checkContext())
@@ -397,7 +397,7 @@ void AquaGraphicsBackend::drawTextLayout(const
GenericSalLayout& rLayout, bool b
CGContextSetTextDrawingMode(mrShared.maContextHolder.get(),
kCGTextFillStroke);
}
-if (bTextRenderModeForResolutionIndependentLayout)
+if (rLayout.GetTextRenderModeForResolutionIndependentLayout())
{
CGContextSetAllowsFontSubpixelQuantization(mrShared.maContextHolder.get(),
false);
CGContextSetShouldSubpixelQuantizeFonts(mrShared.maContextHolder.get(), false);
diff --git a/vcl/skia/osx/gdiimpl.cxx b/vcl/skia/osx/gdiimpl.cxx
index fd0bdca04333..e392587c8836 100644
--- a/vcl/skia/osx/gdiimpl.cxx
+++ b/vcl/skia/osx/gdiimpl.cxx
@@ -294,9 +294,9 @@ bool AquaSkiaSalGraphicsImpl::drawNativeControl(ControlType
nType, ControlPart n
return bOK;
}
[Libreoffice-commits] core.git: vcl/inc vcl/source
vcl/inc/ImplLayoutArgs.hxx |6 +++---
vcl/source/gdi/CommonSalLayout.cxx |4 ++--
vcl/source/gdi/sallayout.cxx |4 ++--
vcl/source/outdev/text.cxx | 12 ++--
vcl/source/text/ImplLayoutArgs.cxx | 10 +-
5 files changed, 18 insertions(+), 18 deletions(-)
New commits:
commit 8e9b65c874d99e3302a9e7dfd0c7a30963526bc2
Author: Khaled Hosny
AuthorDate: Sun Jul 16 18:20:14 2023 +0300
Commit: خالد حسني
CommitDate: Sun Jul 23 06:00:49 2023 +0200
vcl: rename NaturalDXArray to DXArray
The unnatural DXArray is gone for a while now.
Change-Id: I6cda530f332839e49aa91da2d5e347401c4d159d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154502
Tested-by: Jenkins
Reviewed-by: خالد حسني
diff --git a/vcl/inc/ImplLayoutArgs.hxx b/vcl/inc/ImplLayoutArgs.hxx
index 381d09185563..d7100d71fd8b 100644
--- a/vcl/inc/ImplLayoutArgs.hxx
+++ b/vcl/inc/ImplLayoutArgs.hxx
@@ -35,7 +35,7 @@ public:
vcl::text::TextLayoutCache const* m_pTextLayoutCache;
// positioning related inputs
-const double* mpNaturalDXArray; // in floating point pixel units
+const double* mpDXArray; // in floating point pixel units
const sal_Bool* mpKashidaArray;
DeviceCoordinate mnLayoutWidth; // in pixel units
Degree10 mnOrientation; // in 0-3600 system
@@ -48,7 +48,7 @@ public:
LanguageTag aLanguageTag, vcl::text::TextLayoutCache const*
pLayoutCache);
void SetLayoutWidth(DeviceCoordinate nWidth);
-void SetNaturalDXArray(const double* pDXArray);
+void SetDXArray(const double* pDXArray);
void SetKashidaArray(const sal_Bool* pKashidaArray);
void SetOrientation(Degree10 nOrientation);
@@ -56,7 +56,7 @@ public:
bool GetNextPos(int* nCharPos, bool* bRTL);
bool GetNextRun(int* nMinRunPos, int* nEndRunPos, bool* bRTL);
void AddFallbackRun(int nMinRunPos, int nEndRunPos, bool bRTL);
-bool HasDXArray() const { return mpNaturalDXArray; }
+bool HasDXArray() const { return mpDXArray; }
// methods used by BiDi and glyph fallback
bool HasFallbackRun() const;
diff --git a/vcl/source/gdi/CommonSalLayout.cxx
b/vcl/source/gdi/CommonSalLayout.cxx
index c3b8fab84595..f46f4d875210 100644
--- a/vcl/source/gdi/CommonSalLayout.cxx
+++ b/vcl/source/gdi/CommonSalLayout.cxx
@@ -139,8 +139,8 @@ void
GenericSalLayout::AdjustLayout(vcl::text::ImplLayoutArgs& rArgs)
{
SalLayout::AdjustLayout(rArgs);
-if (rArgs.mpNaturalDXArray)
-ApplyDXArray(rArgs.mpNaturalDXArray, rArgs.mpKashidaArray);
+if (rArgs.mpDXArray)
+ApplyDXArray(rArgs.mpDXArray, rArgs.mpKashidaArray);
else if (rArgs.mnLayoutWidth)
Justify(rArgs.mnLayoutWidth);
// apply asian kerning if the glyphs are not already formatted
diff --git a/vcl/source/gdi/sallayout.cxx b/vcl/source/gdi/sallayout.cxx
index 3cdd71642b5b..be3506bf4e3c 100644
--- a/vcl/source/gdi/sallayout.cxx
+++ b/vcl/source/gdi/sallayout.cxx
@@ -688,11 +688,11 @@ void MultiSalLayout::AdjustLayout(
vcl::text::ImplLayoutArgs& rArgs )
for (DeviceCoordinate a : aJustificationArray)
aNaturalJustificationArray.push_back(a);
// change the DXArray temporarily (just for the justification)
-aMultiArgs.mpNaturalDXArray = aNaturalJustificationArray.data();
+aMultiArgs.mpDXArray = aNaturalJustificationArray.data();
}
}
-ImplAdjustMultiLayout(rArgs, aMultiArgs, aMultiArgs.mpNaturalDXArray);
+ImplAdjustMultiLayout(rArgs, aMultiArgs, aMultiArgs.mpDXArray);
}
void MultiSalLayout::ImplAdjustMultiLayout(vcl::text::ImplLayoutArgs& rArgs,
diff --git a/vcl/source/outdev/text.cxx b/vcl/source/outdev/text.cxx
index 2c5f9aae06aa..61d965a28b68 100644
--- a/vcl/source/outdev/text.cxx
+++ b/vcl/source/outdev/text.cxx
@@ -1363,10 +1363,10 @@ std::unique_ptr
OutputDevice::ImplLayout(const OUString& rOrigStr,
nPixelWidth, flags, pLayoutCache);
DeviceCoordinate nEndGlyphCoord(0);
-std::unique_ptr xNaturalDXPixelArray;
+std::unique_ptr xDXPixelArray;
if( !pDXArray.empty() )
{
-xNaturalDXPixelArray.reset(new double[nLen]);
+xDXPixelArray.reset(new double[nLen]);
if (mbMap)
{
@@ -1374,16 +1374,16 @@ std::unique_ptr
OutputDevice::ImplLayout(const OUString& rOrigStr,
// keeping accuracy for lower levels
int nSubPixels = pDXArray.get_factor();
for (int i = 0; i < nLen; ++i)
-xNaturalDXPixelArray[i] =
ImplLogicWidthToDeviceSubPixel(pDXArray.get_subunit(i)) / nSubPixels;
+xDXPixelArray[i] =
ImplLogicWidthToDeviceSubPixel(pDXArray.get_subunit(i)) / nSubPixels;
}
else
{
for(int i = 0; i < nLen; ++i)
-xNaturalDXPixelArray[i] = pDXArray.get(i);
+xDXPixelArray[i] = pDXArray.get(i);
}
-
[Libreoffice-commits] core.git: 2 commits - accessibility/inc basctl/inc chart2/inc compilerplugins/clang config_host/config_vcl.h.in configure.ac cui/inc dbaccess/inc framework/inc include/IwyuFilter
accessibility/inc/pch/precompiled_acc.hxx | 27 ++--- basctl/inc/pch/precompiled_basctl.hxx | 47 ++ chart2/inc/pch/precompiled_chartcontroller.hxx | 39 ++-- chart2/inc/pch/precompiled_chartcore.hxx | 115 + compilerplugins/clang/store/fpcomparison.cxx |8 - config_host/config_vcl.h.in| 14 --- configure.ac | 19 cui/inc/pch/precompiled_cui.hxx| 29 -- dbaccess/inc/pch/precompiled_dbu.hxx | 16 ++- framework/inc/pch/precompiled_fwk.hxx | 58 ++-- include/IwyuFilter_include.yaml|3 include/vcl/devicecoordinate.hxx | 27 - include/vcl/outdev.hxx |6 - include/vcl/vcllayout.hxx | 12 +- oox/inc/pch/precompiled_oox.hxx| 15 ++- reportdesign/inc/pch/precompiled_rpt.hxx | 36 ++- reportdesign/inc/pch/precompiled_rptui.hxx | 38 ++-- sd/inc/pch/precompiled_sdui.hxx| 53 +-- slideshow/inc/pch/precompiled_slideshow.hxx| 46 +- starmath/inc/pch/precompiled_sm.hxx| 47 ++ sw/inc/pch/precompiled_msword.hxx | 52 +++ sw/inc/pch/precompiled_swui.hxx| 60 ++--- sw/inc/pch/precompiled_vbaswobj.hxx| 90 ++- vbahelper/inc/pch/precompiled_msforms.hxx | 27 + vcl/inc/impglyphitem.hxx | 11 +- vcl/inc/pch/precompiled_vcl.hxx| 30 +- vcl/inc/pdf/Matrix3.hxx|4 vcl/inc/pdf/pdfwriter_impl.hxx |4 vcl/inc/sallayout.hxx |6 - vcl/qa/cppunit/complextext.cxx |4 vcl/qt5/QtGraphics_Text.cxx|2 vcl/quartz/salgdi.cxx |2 vcl/skia/gdiimpl.cxx |2 vcl/source/gdi/CommonSalLayout.cxx |6 - vcl/source/gdi/impglyphitem.cxx|3 vcl/source/gdi/pdfwriter_impl.cxx | 28 +++--- vcl/source/gdi/sallayout.cxx | 24 ++--- vcl/source/outdev/font.cxx |2 vcl/source/outdev/map.cxx |8 - vcl/source/outdev/text.cxx | 38 vcl/source/outdev/textline.cxx |8 - vcl/source/pdf/Matrix3.cxx |4 vcl/unx/generic/gdi/cairotextrender.cxx|2 vcl/unx/generic/print/genpspgraphics.cxx |2 vcl/win/gdi/DWriteTextRenderer.cxx |2 vcl/win/gdi/winlayout.cxx |2 46 files changed, 600 insertions(+), 478 deletions(-) New commits: commit 11b513da7f850307cf8371f155e87e9c52f2dd87 Author: Khaled Hosny AuthorDate: Wed Jul 19 08:50:50 2023 +0300 Commit: خالد حسني CommitDate: Sun Jul 23 06:04:31 2023 +0200 vcl: Drop now unneeded DevicePoint typedef It has been always typedef'd to basegfx::B2DPoint since: commit 5e218b5c51f7d9cd10bd9db832879efca41b9c75 Date: Wed Jan 12 21:19:32 2022 + always use B2DPoint for DevicePoint Change-Id: I9f5202d5a71c77dd79f1759923917c26bf68a9af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154632 Tested-by: Jenkins Reviewed-by: خالد حسني diff --git a/accessibility/inc/pch/precompiled_acc.hxx b/accessibility/inc/pch/precompiled_acc.hxx index fcbbd9f1f0c1..5b3bbb51d3f7 100644 --- a/accessibility/inc/pch/precompiled_acc.hxx +++ b/accessibility/inc/pch/precompiled_acc.hxx @@ -13,7 +13,7 @@ manual changes will be rewritten by the next run of update_pch.sh (which presumably also fixes all possible problems, so it's usually better to use it). - Generated on 2022-06-27 18:57:49 using: + Generated on 2023-07-19 09:19:19 using: ./bin/update_pch accessibility acc --cutoff=4 --exclude:system --include:module --include:local If after updating build fails, use the following command to locate conflicting headers: @@ -24,10 +24,7 @@ #if PCH_LEVEL >= 1 #include #include -#include -#include #include -#include #include #include #include @@ -52,7 +49,6 @@ #include #include #include -#include #include #include #endif // PCH_LEVEL >= 1 @@ -64,8 +60,6 @@ #include #include #include -#include -#include #include #include #include @@ -104,22 +98,22 @@ #include #include #include -#include #include #include #include -#include #include #include #include #include #include #include +#include #include #include #include #include #include +#include #include #include #include @@ -165,6 +159,8 @@ #if PCH_LEVEL >= 3 #include #include +#include +#include #include #include #include @@ -173,14 +169,17 @@ #include #include #include +#include
[Libreoffice-commits] core.git: 2 commits - include/vcl vcl/inc vcl/source
include/vcl/outdev.hxx|2
include/vcl/vcllayout.hxx |2
vcl/inc/sallayout.hxx |4 -
vcl/inc/textlayout.hxx|6 --
vcl/source/control/edit.cxx | 74 +++---
vcl/source/gdi/sallayout.cxx | 90 --
vcl/source/gdi/textlayout.cxx | 17 ---
vcl/source/outdev/text.cxx| 46 ++---
8 files changed, 119 insertions(+), 122 deletions(-)
New commits:
commit 21013c4662a9ab32d293de263c54ebeceb66828c
Author: Khaled Hosny
AuthorDate: Wed Jul 19 19:07:34 2023 +0300
Commit: خالد حسني
CommitDate: Sun Jul 23 06:05:02 2023 +0200
tdf#156377: Improve cursor traversal in UI widgets
Re-implement GetCaretPositions() on top of GetCharWidths() so it can
benefit from our code that handles cursor insertion in middle of
ligatures.
Change-Id: I2b76b3b0125f2454f78cb6779d88617dc29386fe
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154660
Tested-by: Jenkins
Reviewed-by: خالد حسني
diff --git a/include/vcl/outdev.hxx b/include/vcl/outdev.hxx
index 7e0a17fec545..f3d2e912d0a6 100644
--- a/include/vcl/outdev.hxx
+++ b/include/vcl/outdev.hxx
@@ -1047,7 +1047,7 @@ public:
vcl::text::TextLayoutCache
const* = nullptr,
SalLayoutGlyphs const*const
pLayoutCache = nullptr) const;
-voidGetCaretPositions( const OUString&, sal_Int32*
pCaretXArray,
+voidGetCaretPositions( const OUString&, KernArray&
rCaretXArray,
sal_Int32 nIndex, sal_Int32 nLen,
const SalLayoutGlyphs* pGlyphs =
nullptr ) const;
voidDrawStretchText( const Point& rStartPt,
sal_Int32 nWidth,
diff --git a/include/vcl/vcllayout.hxx b/include/vcl/vcllayout.hxx
index dda07f1c710e..7c7a179b9b05 100644
--- a/include/vcl/vcllayout.hxx
+++ b/include/vcl/vcllayout.hxx
@@ -96,7 +96,7 @@ public:
virtual sal_Int32 GetTextBreak(double nMaxWidth, double nCharExtra, int
nFactor) const = 0;
virtual double FillDXArray( std::vector* pDXArray, const
OUString& rStr ) const = 0;
virtual double GetTextWidth() const { return FillDXArray( nullptr, {} ); }
-virtual voidGetCaretPositions( int nArraySize, sal_Int32* pCaretXArray
) const = 0;
+virtual voidGetCaretPositions( std::vector& rCaretPositions,
const OUString& rStr ) const = 0;
virtual boolIsKashidaPosValid ( int /*nCharPos*/, int /*nNextCharPos*/
) const = 0; // i60594
// methods using glyph indexing
diff --git a/vcl/inc/sallayout.hxx b/vcl/inc/sallayout.hxx
index f96eb7df2977..dbe3000f8a83 100644
--- a/vcl/inc/sallayout.hxx
+++ b/vcl/inc/sallayout.hxx
@@ -64,7 +64,7 @@ public:
sal_Int32 GetTextBreak(double nMaxWidth, double nCharExtra, int
nFactor) const override;
double GetTextWidth() const final override;
double FillDXArray(std::vector* pDXArray, const OUString&
rStr) const override;
-voidGetCaretPositions(int nArraySize, sal_Int32* pCaretXArray)
const override;
+voidGetCaretPositions(std::vector& rCaretPositions,
const OUString& rStr) const override;
boolGetNextGlyph(const GlyphItem** pGlyph, basegfx::B2DPoint&
rPos, int& nStart,
const LogicalFontInstance** ppGlyphFont =
nullptr) const override;
boolGetOutline(basegfx::B2DPolyPolygonVector&) const override;
@@ -120,7 +120,7 @@ public:
double GetTextWidth() const final override;
double FillDXArray(std::vector* pDXArray, const OUString&
rStr) const final override;
sal_Int32 GetTextBreak(double nMaxWidth, double nCharExtra, int
nFactor) const final override;
-voidGetCaretPositions(int nArraySize, sal_Int32* pCaretXArray)
const final override;
+voidGetCaretPositions(std::vector& rCaretPositions,
const OUString& rStr) const override;
// used by display layers
LogicalFontInstance& GetFont() const
diff --git a/vcl/source/control/edit.cxx b/vcl/source/control/edit.cxx
index 10c68412a627..0db27e8a315a 100644
--- a/vcl/source/control/edit.cxx
+++ b/vcl/source/control/edit.cxx
@@ -473,20 +473,9 @@ void Edit::ImplRepaint(vcl::RenderContext& rRenderContext,
const tools::Rectangl
const OUString aText = ImplGetText();
const sal_Int32 nLen = aText.getLength();
-sal_Int32 nDXBuffer[256];
-std::unique_ptr pDXBuffer;
-sal_Int32* pDX = nDXBuffer;
-
+KernArray aDX;
if (nLen)
-{
-if (o3tl::make_unsigned(2 * nLen) > SAL_N_ELEMENTS(nDXBuffer))
-{
-pDXBuffer.reset(new sal_Int32[2 * (nLen + 1)]);
-pDX = pDXBuffer.get();
-}
-
-GetOutDev()->GetCaretPositions(aText, pDX, 0, nLen);
[Libreoffice-commits] core.git: 3 commits - drawinglayer/source include/drawinglayer include/vcl sfx2/source vcl/inc vcl/source
drawinglayer/source/primitive2d/textlayoutdevice.cxx |4 +-
include/drawinglayer/primitive2d/textlayoutdevice.hxx |4 +-
include/vcl/outdev.hxx|4 --
sfx2/source/control/thumbnailviewitem.cxx |7 ++-
vcl/inc/textlayout.hxx|7 +++
vcl/source/gdi/textlayout.cxx | 12 --
vcl/source/outdev/map.cxx | 12 --
vcl/source/outdev/text.cxx| 34 +-
vcl/source/outdev/textline.cxx| 13 ++
9 files changed, 47 insertions(+), 50 deletions(-)
New commits:
commit ecf352701411fe178b51841b5714e27bef500206
Author: Khaled Hosny
AuthorDate: Wed Jul 19 08:19:06 2023 +0300
Commit: خالد حسني
CommitDate: Sun Jul 23 06:04:17 2023 +0200
vcl: Use GetTextArray() when drawing mnemonics
Instead of using a different function to get the character width, use
the same function used for getting the character widths elsewhere.
Change-Id: I21428f34bb0f3a60fa17f5e8ecc3420545356337
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154609
Tested-by: Jenkins
Reviewed-by: خالد حسني
diff --git a/drawinglayer/source/primitive2d/textlayoutdevice.cxx
b/drawinglayer/source/primitive2d/textlayoutdevice.cxx
index ea9fed02a20f..2b0356518285 100644
--- a/drawinglayer/source/primitive2d/textlayoutdevice.cxx
+++ b/drawinglayer/source/primitive2d/textlayoutdevice.cxx
@@ -294,7 +294,7 @@ void TextLayouterDevice::addTextRectActions(const
::tools::Rectangle& rRectangle
}
std::vector TextLayouterDevice::getTextArray(const OUString& rText,
sal_uInt32 nIndex,
- sal_uInt32 nLength) const
+ sal_uInt32 nLength, bool
bCaret) const
{
std::vector aRetval;
sal_uInt32 nTextLength(nLength);
@@ -308,7 +308,7 @@ std::vector TextLayouterDevice::getTextArray(const
OUString& rText, sal_
if (nTextLength)
{
KernArray aArray;
-mrDevice.GetTextArray(rText, , nIndex, nTextLength);
+mrDevice.GetTextArray(rText, , nIndex, nTextLength, bCaret);
aRetval.reserve(aArray.size());
for (size_t i = 0, nEnd = aArray.size(); i < nEnd; ++i)
aRetval.push_back(aArray[i]);
diff --git a/include/drawinglayer/primitive2d/textlayoutdevice.hxx
b/include/drawinglayer/primitive2d/textlayoutdevice.hxx
index 6348de0ddd25..dfb5ba6c5c37 100644
--- a/include/drawinglayer/primitive2d/textlayoutdevice.hxx
+++ b/include/drawinglayer/primitive2d/textlayoutdevice.hxx
@@ -96,8 +96,8 @@ public:
void addTextRectActions(const tools::Rectangle& rRectangle, const
OUString& rText,
DrawTextFlags nStyle, GDIMetaFile& rGDIMetaFile)
const;
-::std::vector getTextArray(const OUString& rText, sal_uInt32
nIndex,
- sal_uInt32 nLength) const;
+::std::vector getTextArray(const OUString& rText, sal_uInt32
nIndex, sal_uInt32 nLength,
+ bool bCaret = false) const;
::std::vector getCaretPositions(const OUString& rText, sal_uInt32
nIndex,
sal_uInt32 nLength) const;
diff --git a/sfx2/source/control/thumbnailviewitem.cxx
b/sfx2/source/control/thumbnailviewitem.cxx
index b2c3ef75274b..ca8920acafd2 100644
--- a/sfx2/source/control/thumbnailviewitem.cxx
+++ b/sfx2/source/control/thumbnailviewitem.cxx
@@ -319,10 +319,11 @@ void ThumbnailViewItem::addTextPrimitives (const
OUString& rText, const Thumbnai
{
rSeq.resize(nFinalPrimCount + 1);
-auto aCaretPositions = aTextDev.getCaretPositions(aText,
nLineStart, nLineLength);
+auto aTextArray = aTextDev.getTextArray(aText, nLineStart,
nLineLength, true);
-auto lc_x1 = aCaretPositions[2*(nMnemonicPos - nLineStart)];
-auto lc_x2 = aCaretPositions[2*(nMnemonicPos - nLineStart)+1];
+auto nPos = nMnemonicPos - nLineStart;
+auto lc_x1 = nPos ? aTextArray[nPos - 1] : 0;
+auto lc_x2 = aTextArray[nPos];
auto fMnemonicWidth = std::abs(lc_x1 - lc_x2);
auto fMnemonicHeight = aTextDev.getUnderlineHeight();
diff --git a/vcl/inc/textlayout.hxx b/vcl/inc/textlayout.hxx
index 43757d6421b3..311938acdb18 100644
--- a/vcl/inc/textlayout.hxx
+++ b/vcl/inc/textlayout.hxx
@@ -33,6 +33,7 @@ namespace vcl
virtual voidDrawText( const Point& _rStartPoint, const
OUString& _rText, sal_Int32 _nStartIndex, sal_Int32 _nLength,
std::vector< tools::Rectangle >* _pVector,
OUString* _pDisplayText ) = 0;
virtual voidGetCaretPositions( const OUString& _rText,
sal_Int32* _pCaretXArray, sal_Int32 _nStartIndex, sal_Int32 _nLength ) const =
0;
+virtual tools::Long GetTextArray(
[Libreoffice-commits] core.git: 2 commits - vcl/source
vcl/source/outdev/text.cxx | 22 +-
1 file changed, 13 insertions(+), 9 deletions(-)
New commits:
commit 9057641f678b8e36c9dbc41960b182c6ecfdda15
Author: Khaled Hosny
AuthorDate: Wed Jul 19 05:53:09 2023 +0300
Commit: خالد حسني
CommitDate: Sun Jul 23 06:03:29 2023 +0200
vcl: SalLayout::GetTextWidth() returns double
Change-Id: I4c8cfec4160da260556615bc17939af6b20d60ba
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154596
Tested-by: Jenkins
Reviewed-by: خالد حسني
diff --git a/vcl/source/outdev/text.cxx b/vcl/source/outdev/text.cxx
index 8cf805fe4870..4a3b04121899 100644
--- a/vcl/source/outdev/text.cxx
+++ b/vcl/source/outdev/text.cxx
@@ -169,7 +169,7 @@ void OutputDevice::ImplDrawTextRect( tools::Long nBaseX,
tools::Long nBaseY,
void OutputDevice::ImplDrawTextBackground( const SalLayout& rSalLayout )
{
-const tools::Long nWidth = rSalLayout.GetTextWidth();
+const double nWidth = rSalLayout.GetTextWidth();
const DevicePoint aBase = rSalLayout.DrawBase();
const tools::Long nX = aBase.getX();
const tools::Long nY = aBase.getY();
@@ -193,7 +193,7 @@ tools::Rectangle OutputDevice::ImplGetTextBoundRect( const
SalLayout& rSalLayout
tools::Long nX = aPoint.getX();
tools::Long nY = aPoint.getY();
-tools::Long nWidth = rSalLayout.GetTextWidth();
+double nWidth = rSalLayout.GetTextWidth();
tools::Long nHeight = mpFontInstance->mnLineHeight + mnEmphasisAscent +
mnEmphasisDescent;
nY -= mpFontInstance->mxFontMetric->GetAscent() + mnEmphasisAscent;
@@ -236,7 +236,7 @@ bool OutputDevice::ImplDrawRotateText( SalLayout&
rSalLayout )
if (!rSalLayout.GetBoundRect(aBoundRect))
{
// guess vertical text extents if GetBoundRect failed
-tools::Long nRight = rSalLayout.GetTextWidth();
+double nRight = rSalLayout.GetTextWidth();
tools::Long nTop = mpFontInstance->mxFontMetric->GetAscent() +
mnEmphasisAscent;
tools::Long nHeight = mpFontInstance->mnLineHeight + mnEmphasisAscent
+ mnEmphasisDescent;
aBoundRect = tools::Rectangle( 0, -nTop, nRight, nHeight - nTop );
@@ -1055,7 +1055,7 @@ void OutputDevice::GetCaretPositions( const OUString&
rStr, sal_Int32* pCaretXAr
}
pSalLayout->GetCaretPositions( 2*nLen, pCaretXArray );
-tools::Long nWidth = pSalLayout->GetTextWidth();
+double nWidth = pSalLayout->GetTextWidth();
// fixup unknown caret positions
int i;
@@ -2303,7 +2303,7 @@ bool OutputDevice::GetTextBoundRect( tools::Rectangle&
rRect,
std::unique_ptr pSalLayout;
const Point aPoint;
// calculate offset when nBase!=nIndex
-tools::Long nXOffset = 0;
+double nXOffset = 0;
if( nBase != nIndex )
{
sal_Int32 nStart = std::min( nBase, nIndex );
@@ -2370,7 +2370,7 @@ bool OutputDevice::GetTextOutlines(
basegfx::B2DPolyPolygonVector& rVector,
std::unique_ptr pSalLayout;
// calculate offset when nBase!=nIndex
-tools::Long nXOffset = 0;
+double nXOffset = 0;
if( nBase != nIndex )
{
sal_Int32 nStart = std::min( nBase, nIndex );
@@ -2395,7 +2395,7 @@ bool OutputDevice::GetTextOutlines(
basegfx::B2DPolyPolygonVector& rVector,
// transform polygon to pixel units
basegfx::B2DHomMatrix aMatrix;
-if( nXOffset | mnTextOffX | mnTextOffY )
+if (nXOffset || mnTextOffX || mnTextOffY)
{
DevicePoint aRotatedOfs(mnTextOffX, mnTextOffY);
aRotatedOfs -=
pSalLayout->GetDrawPosition(DevicePoint(nXOffset, 0));
commit f9e993a91c2c11a17948d394bf207f836e10d28b
Author: Khaled Hosny
AuthorDate: Tue Jul 18 17:20:56 2023 +0300
Commit: خالد حسني
CommitDate: Sun Jul 23 06:03:21 2023 +0200
vcl: Don’t use nSubPixelFactor when in map mode
We are already using a subpixel factor when in map mode, so no need for
one more.
Change-Id: I704d52bf402f92f83a3d4ef40409d644921314d2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154587
Tested-by: Jenkins
Reviewed-by: خالد حسني
diff --git a/vcl/source/outdev/text.cxx b/vcl/source/outdev/text.cxx
index 8d4f557288c2..8cf805fe4870 100644
--- a/vcl/source/outdev/text.cxx
+++ b/vcl/source/outdev/text.cxx
@@ -1455,7 +1455,9 @@ sal_Int32 OutputDevice::GetTextBreak( const OUString&
rStr, tools::Long nTextWid
// NOTE: be very careful to avoid rounding errors for nCharExtra case
// problem with rounding errors especially for small nCharExtras
// TODO: remove when layout units have subpixel granularity
-tools::Long nSubPixelFactor = 64;
+tools::Long nSubPixelFactor = 1;
+if (!mbMap)
+nSubPixelFactor = 64;
double nTextPixelWidth = ImplLogicWidthToDeviceSubPixel(nTextWidth *
nSubPixelFactor);
double nExtraPixelWidth = 0;
if( nCharExtra != 0 )
@@ -1484,7 +1486,9 @@ sal_Int32
[Libreoffice-commits] core.git: 2 commits - drawinglayer/source editeng/source include/drawinglayer
drawinglayer/source/primitive2d/textlayoutdevice.cxx | 23 --
editeng/source/accessibility/AccessibleStringWrap.cxx |7 ++---
include/drawinglayer/primitive2d/textlayoutdevice.hxx |3 --
3 files changed, 3 insertions(+), 30 deletions(-)
New commits:
commit 60c8a8062cc4632b400e5498310d4ade84b8fe34
Author: Khaled Hosny
AuthorDate: Wed Jul 19 13:36:19 2023 +0300
Commit: خالد حسني
CommitDate: Sun Jul 23 06:04:47 2023 +0200
drawinglayer: Drop recently unused TextLayouterDevice::getCaretPositions()
Change-Id: I07255d45bc03a5f86a22d7f392c14053eec7f6ad
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154648
Tested-by: Jenkins
Reviewed-by: خالد حسني
diff --git a/drawinglayer/source/primitive2d/textlayoutdevice.cxx
b/drawinglayer/source/primitive2d/textlayoutdevice.cxx
index 2b0356518285..1c551ce01363 100644
--- a/drawinglayer/source/primitive2d/textlayoutdevice.cxx
+++ b/drawinglayer/source/primitive2d/textlayoutdevice.cxx
@@ -317,29 +317,6 @@ std::vector TextLayouterDevice::getTextArray(const
OUString& rText, sal_
return aRetval;
}
-std::vector TextLayouterDevice::getCaretPositions(const OUString&
rText, sal_uInt32 nIndex,
- sal_uInt32 nLength)
const
-{
-std::vector aRetval;
-sal_uInt32 nTextLength(nLength);
-const sal_uInt32 nStringLength(rText.getLength());
-
-if (nTextLength + nIndex > nStringLength)
-{
-nTextLength = nStringLength - nIndex;
-}
-
-if (nTextLength)
-{
-aRetval.reserve(2 * nTextLength);
-std::vector aArray(2 * nTextLength);
-mrDevice.GetCaretPositions(rText, aArray.data(), nIndex, nTextLength);
-aRetval.assign(aArray.begin(), aArray.end());
-}
-
-return aRetval;
-}
-
// helper methods for vcl font handling
vcl::Font getVclFontFromFontAttribute(const attribute::FontAttribute&
rFontAttribute,
diff --git a/include/drawinglayer/primitive2d/textlayoutdevice.hxx
b/include/drawinglayer/primitive2d/textlayoutdevice.hxx
index dfb5ba6c5c37..6f98b50a4f06 100644
--- a/include/drawinglayer/primitive2d/textlayoutdevice.hxx
+++ b/include/drawinglayer/primitive2d/textlayoutdevice.hxx
@@ -98,9 +98,6 @@ public:
::std::vector getTextArray(const OUString& rText, sal_uInt32
nIndex, sal_uInt32 nLength,
bool bCaret = false) const;
-
-::std::vector getCaretPositions(const OUString& rText, sal_uInt32
nIndex,
-sal_uInt32 nLength) const;
};
// helper methods for vcl font handling
commit d9ae579c8a2f5d305fd6419069ed00cf4d8bb015
Author: Khaled Hosny
AuthorDate: Wed Jul 19 10:15:26 2023 +0300
Commit: خالد حسني
CommitDate: Sun Jul 23 06:04:39 2023 +0200
editeng: Use GetTextArray() instead of GetCaretPositions()
One way of getting text widths should be enough.
Change-Id: I21e24c3f69a116e5210685d76268936219aae279
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154639
Tested-by: Jenkins
Reviewed-by: خالد حسني
diff --git a/editeng/source/accessibility/AccessibleStringWrap.cxx
b/editeng/source/accessibility/AccessibleStringWrap.cxx
index 519a1feb7b83..5461aad9f4c8 100644
--- a/editeng/source/accessibility/AccessibleStringWrap.cxx
+++ b/editeng/source/accessibility/AccessibleStringWrap.cxx
@@ -57,12 +57,11 @@ void AccessibleStringWrap::GetCharacterBounds( sal_Int32
nIndex, tools::Rectangl
}
else
{
-sal_Int32 aXArray[2];
-mrDev.GetCaretPositions( maText, aXArray, nIndex, 1 );
+KernArray aDXArray;
+mrDev.GetTextArray(maText, , nIndex, 1);
rRect.SetLeft( 0 );
rRect.SetTop( 0 );
-rRect.SetSize( Size(mrDev.GetTextHeight(), std::abs(aXArray[0] -
aXArray[1])) );
-rRect.Move( std::min(aXArray[0], aXArray[1]), 0 );
+rRect.SetSize(Size(mrDev.GetTextHeight(), aDXArray[0]));
}
if( mrFont.IsVertical() )
[Libreoffice-commits] core.git: 2 commits - include/vcl sw/qa vcl/qt5 vcl/quartz vcl/skia vcl/source vcl/unx vcl/win
include/vcl/vcllayout.hxx | 10 +++
sw/qa/extras/globalfilter/globalfilter.cxx | 41 -
vcl/qt5/QtGraphics_Text.cxx|3 --
vcl/quartz/salgdi.cxx |2 -
vcl/skia/osx/gdiimpl.cxx |2 -
vcl/skia/win/gdiimpl.cxx |2 -
vcl/skia/x11/textrender.cxx|2 -
vcl/source/gdi/sallayout.cxx |4 +-
vcl/source/outdev/text.cxx |2 -
vcl/unx/generic/gdi/cairotextrender.cxx| 12
vcl/win/gdi/winlayout.cxx |2 -
11 files changed, 44 insertions(+), 38 deletions(-)
New commits:
commit ea0f9776ed8e7e9809853d292923b86756274564
Author: Khaled Hosny
AuthorDate: Tue Jul 18 13:41:00 2023 +0300
Commit: خالد حسني
CommitDate: Sun Jul 23 06:01:46 2023 +0200
Improve CppunitTest_sw_globalfilter CPPUNIT_TEST_NAME=testListLabelPDFExport
Extract the textual content of the page using high level PDFiumDocument
API instead of fiddling with low level PDF text stream details.
Change-Id: If989addb3200e728e8ed771bfcc23cc18c7664de
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154579
Tested-by: Jenkins
Reviewed-by: Michael Stahl
Reviewed-by: خالد حسني
diff --git a/sw/qa/extras/globalfilter/globalfilter.cxx
b/sw/qa/extras/globalfilter/globalfilter.cxx
index 0c7415ddabe6..64bc2063beb1 100644
--- a/sw/qa/extras/globalfilter/globalfilter.cxx
+++ b/sw/qa/extras/globalfilter/globalfilter.cxx
@@ -1283,6 +1283,29 @@ CPPUNIT_TEST_FIXTURE(Test, testListLabelPDFExport)
css::uno::Reference xStorable(mxComponent,
css::uno::UNO_QUERY_THROW);
xStorable->storeToURL(maTempFile.GetURL(),
aMediaDescriptor.getAsConstPropertyValueList());
+// Parse the export result with pdfium.
+std::unique_ptr pPdfDocument = parsePDFExport();
+
+// The document has one page.
+CPPUNIT_ASSERT_EQUAL(1, pPdfDocument->getPageCount());
+std::unique_ptr pPdfPage =
pPdfDocument->openPage(/*nIndex=*/0);
+CPPUNIT_ASSERT(pPdfPage);
+
+std::unique_ptr pPdfTextPage =
pPdfPage->getTextPage();
+CPPUNIT_ASSERT(pPdfTextPage);
+
+int nChars = pPdfTextPage->countChars();
+CPPUNIT_ASSERT_EQUAL(22, nChars);
+
+// Check that the label strings were exported correctly
+std::vector aChars(nChars);
+for (int i = 0; i < nChars; i++)
+aChars[i] = pPdfTextPage->getUnicode(i);
+OUString aText(aChars.data(), aChars.size());
+
CPPUNIT_ASSERT_EQUAL(OUString(u"\u0623\r\n.\r\n\u0623.\u0623\r\n.\r\n\u0623.\u0623.\u0623\r\n."),
aText);
+
+// Parse the document again to get its raw content
+// TODO: get the content from PDFiumPage somehow
vcl::filter::PDFDocument aDocument;
SvFileStream aStream(maTempFile.GetURL(), StreamMode::READ);
CPPUNIT_ASSERT(aDocument.Read(aStream));
@@ -1345,10 +1368,6 @@ CPPUNIT_TEST_FIXTURE(Test, testListLabelPDFExport)
auto const endj(line.find(">Tj"));
if (endj != ::std::string_view::npos)
{
-auto const start(line.rfind("<", endj) + 1);
-// for these, expected length is 1 glyphs, each 2 digits
-// would be better to check the content but it depends on
CMap
-CPPUNIT_ASSERT_EQUAL(static_cast(1
* 2), endj - start);
state = LblFoundText;
++nLblTj;
}
@@ -1357,17 +1376,6 @@ CPPUNIT_TEST_FIXTURE(Test, testListLabelPDFExport)
auto const endJ(line.find("]TJ"));
if (endJ != ::std::string_view::npos)
{
-auto const start(line.rfind("[", endJ) + 1);
-auto i(line.find("<", start));
-auto digits(0);
-while (i != ::std::string_view::npos && i < endJ)
-{
-auto const j(line.find(">", i));
-digits += j - (i+1);
-i = line.find("<", j);
-}
-// these have list-level numbers + one less ".", each
2 digits
-
CPPUNIT_ASSERT_EQUAL(static_castnLbl/2 + 1) * 2) - 1) *
2), digits);
state = LblFoundText;
++nLblTJ;
}
@@ -1386,8 +1394,7 @@ CPPUNIT_TEST_FIXTURE(Test, testListLabelPDFExport)
// tree into 3 Lbl.
CPPUNIT_ASSERT_EQUAL(static_cast(6), nLbl);
// these are quite arbitrary?
-CPPUNIT_ASSERT_EQUAL(static_cast(2), nLblTJ);
-CPPUNIT_ASSERT_EQUAL(static_cast(4), nLblTj);
+CPPUNIT_ASSERT_EQUAL(static_cast(6), nLblTJ + nLblTj);
auto nL(0);
for (const auto& rDocElement : aDocument.GetElements())
commit dd4a3fe191aab884380784250144c9fdd9647be3
Author: Khaled Hosny
AuthorDate: Mon Jul 17
[Libreoffice-commits] core.git: 2 commits - vcl/source
vcl/source/font/LogicalFontInstance.cxx |2 +-
vcl/source/gdi/CommonSalLayout.cxx |2 ++
vcl/source/outdev/font.cxx |6 +-
vcl/source/outdev/text.cxx | 26 +-
4 files changed, 17 insertions(+), 19 deletions(-)
New commits:
commit a21958db9111e27312c6ae52e2d5e3a9e8a39e08
Author: Khaled Hosny
AuthorDate: Tue Jul 18 17:13:33 2023 +0300
Commit: خالد حسني
CommitDate: Sun Jul 23 06:02:51 2023 +0200
vcl: Use doubles in GetTextBreak()
Change-Id: I88ee2434ba6ddb41cf1983afceebe1ae72be8d9f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154584
Tested-by: Jenkins
Reviewed-by: خالد حسني
diff --git a/vcl/source/outdev/text.cxx b/vcl/source/outdev/text.cxx
index c02509718a60..8d4f557288c2 100644
--- a/vcl/source/outdev/text.cxx
+++ b/vcl/source/outdev/text.cxx
@@ -1456,14 +1456,10 @@ sal_Int32 OutputDevice::GetTextBreak( const OUString&
rStr, tools::Long nTextWid
// problem with rounding errors especially for small nCharExtras
// TODO: remove when layout units have subpixel granularity
tools::Long nSubPixelFactor = 64;
-nTextWidth *= nSubPixelFactor;
-DeviceCoordinate nTextPixelWidth = LogicWidthToDeviceCoordinate(
nTextWidth );
-DeviceCoordinate nExtraPixelWidth = 0;
+double nTextPixelWidth = ImplLogicWidthToDeviceSubPixel(nTextWidth *
nSubPixelFactor);
+double nExtraPixelWidth = 0;
if( nCharExtra != 0 )
-{
-nCharExtra *= nSubPixelFactor;
-nExtraPixelWidth = LogicWidthToDeviceCoordinate( nCharExtra );
-}
+nExtraPixelWidth = ImplLogicWidthToDeviceSubPixel(nCharExtra *
nSubPixelFactor);
nRetVal = pSalLayout->GetTextBreak( nTextPixelWidth, nExtraPixelWidth,
nSubPixelFactor );
}
@@ -1490,14 +1486,10 @@ sal_Int32 OutputDevice::GetTextBreak( const OUString&
rStr, tools::Long nTextWid
// TODO: remove when layout units have subpixel granularity
tools::Long nSubPixelFactor = 64;
-nTextWidth *= nSubPixelFactor;
-DeviceCoordinate nTextPixelWidth = LogicWidthToDeviceCoordinate(
nTextWidth );
-DeviceCoordinate nExtraPixelWidth = 0;
+double nTextPixelWidth = ImplLogicWidthToDeviceSubPixel(nTextWidth *
nSubPixelFactor);
+double nExtraPixelWidth = 0;
if( nCharExtra != 0 )
-{
-nCharExtra *= nSubPixelFactor;
-nExtraPixelWidth = LogicWidthToDeviceCoordinate( nCharExtra );
-}
+nExtraPixelWidth = ImplLogicWidthToDeviceSubPixel(nCharExtra *
nSubPixelFactor);
// calculate un-hyphenated break position
nRetVal = pSalLayout->GetTextBreak( nTextPixelWidth, nExtraPixelWidth,
nSubPixelFactor );
@@ -1508,7 +1500,7 @@ sal_Int32 OutputDevice::GetTextBreak( const OUString&
rStr, tools::Long nTextWid
if( pHyphenLayout )
{
// calculate subpixel width of hyphenation character
-tools::Long nHyphenPixelWidth = pHyphenLayout->GetTextWidth() *
nSubPixelFactor;
+double nHyphenPixelWidth = pHyphenLayout->GetTextWidth() *
nSubPixelFactor;
// calculate hyphenated break position
nTextPixelWidth -= nHyphenPixelWidth;
@@ -1689,7 +1681,7 @@ void OutputDevice::ImplDrawText( OutputDevice&
rTargetDevice, const tools::Recta
nIndex, nLineLen );
sal_Int32 lc_x1 = pCaretXArray[2*(nMnemonicPos -
nIndex)];
sal_Int32 lc_x2 = pCaretXArray[2*(nMnemonicPos -
nIndex)+1];
-nMnemonicWidth =
rTargetDevice.LogicWidthToDeviceCoordinate( std::abs(lc_x1 - lc_x2) );
+nMnemonicWidth =
rTargetDevice.ImplLogicWidthToDeviceSubPixel(std::abs(lc_x1 - lc_x2));
Point aTempPos = rTargetDevice.LogicToPixel(
aPos );
nMnemonicX = rTargetDevice.GetOutOffXPixel() +
aTempPos.X() + rTargetDevice.ImplLogicWidthToDevicePixel( std::min( lc_x1,
lc_x2 ) );
@@ -1757,7 +1749,7 @@ void OutputDevice::ImplDrawText( OutputDevice&
rTargetDevice, const tools::Recta
/*sal_Bool bRet =*/ _rLayout.GetCaretPositions( aStr,
pCaretXArray.get(), 0, aStr.getLength() );
tools::Long lc_x1 = pCaretXArray[2*nMnemonicPos];
tools::Long lc_x2 = pCaretXArray[2*nMnemonicPos+1];
-nMnemonicWidth = rTargetDevice.LogicWidthToDeviceCoordinate(
std::abs(lc_x1 - lc_x2) );
+nMnemonicWidth =
rTargetDevice.ImplLogicWidthToDeviceSubPixel(std::abs(lc_x1 - lc_x2));
Point aTempPos = rTargetDevice.LogicToPixel( aPos );
nMnemonicX = rTargetDevice.GetOutOffXPixel() + aTempPos.X() +
rTargetDevice.ImplLogicWidthToDevicePixel( std::min(lc_x1, lc_x2) );
commit 9d9e3b439883c3c315501f56bb613e080863db64
Author: Khaled Hosny
AuthorDate: Mon Jul 17 17:21:34 2023
[Libreoffice-commits] core.git: chart2/qa emfio/qa sd/qa svx/qa sw/qa vcl/source
chart2/qa/extras/xshape/data/reference/fdo75075.xml | 538 +- chart2/qa/extras/xshape/data/reference/property-mapping-bar.xml | 390 +++ chart2/qa/extras/xshape/data/reference/tdf149204.xml| 118 +- chart2/qa/extras/xshape/data/reference/tdf150832.xml|3 chart2/qa/extras/xshape/data/reference/tdf151424.xml| 471 chart2/qa/extras/xshape/data/reference/tdf90839-1.xml | 42 chart2/qa/extras/xshape/data/reference/tdf90839-2.xml | 56 - chart2/qa/extras/xshape/data/reference/tdf90839-3.xml | 56 - chart2/qa/extras/xshape/data/reference/tdf90839-4.xml | 56 - chart2/qa/extras/xshape/data/reference/testChart.xml| 442 emfio/qa/cppunit/emf/EmfImportTest.cxx |2 emfio/qa/cppunit/wmf/wmfimporttest.cxx | 24 sd/qa/unit/layout-tests.cxx | 14 svx/qa/unit/customshapes.cxx|8 sw/qa/extras/layout/layout3.cxx |4 vcl/source/gdi/CommonSalLayout.cxx | 12 vcl/source/outdev/text.cxx |8 17 files changed, 1133 insertions(+), deletions(-) New commits: commit 4b743de97fc133623e46827869c4ea3eb845ad47 Author: Khaled Hosny AuthorDate: Mon Jul 17 12:38:41 2023 +0300 Commit: خالد حسني CommitDate: Sun Jul 23 06:01:56 2023 +0200 tdf#156234: Don’t round glyph coordinates when doing subpixel positioning When doing subpixel positioning (i.e. OutputDevice is in map mode), delay the rounding of the glyph coordinates after converting from pixel to logical units to minimize the loss of precision as much as possible. Some test expectations, expectedly, changes due to the improved positioning precision. Change-Id: I2591e3c7d4923ba7886a35bf53db759273354e24 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154292 Tested-by: Jenkins Reviewed-by: Caolán McNamara Reviewed-by: خالد حسني diff --git a/chart2/qa/extras/xshape/data/reference/fdo75075.xml b/chart2/qa/extras/xshape/data/reference/fdo75075.xml index 6fbdd0f9079b..fe8cb00cf178 100644 --- a/chart2/qa/extras/xshape/data/reference/fdo75075.xml +++ b/chart2/qa/extras/xshape/data/reference/fdo75075.xml @@ -16,7 +16,7 @@ - + @@ -25,7 +25,7 @@ - + @@ -46,11 +46,11 @@ - + - + - + @@ -59,125 +59,125 @@ - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - -
[Libreoffice-commits] core.git: sw/source
sw/source/uibase/dochdl/swdtflvr.cxx |9 +++--
sw/source/uibase/docvw/edtdd.cxx |4 +---
sw/source/uibase/inc/navicont.hxx|2 +-
sw/source/uibase/utlui/content.cxx |4 +++-
4 files changed, 12 insertions(+), 7 deletions(-)
New commits:
commit c6b404c39569b6bc972b821a13f6bba0a68d8d9d
Author: Jim Raykowski
AuthorDate: Sun Jul 16 22:22:18 2023 -0800
Commit: Jim Raykowski
CommitDate: Sun Jul 23 06:48:13 2023 +0200
tdf#156111 SwNavigator hyperlink dnd enhancement
Enhancement to use the selected document text dropped on as the
hyperlink name for hyperlinks created by drag-and-drop from the
Navigator.
Change-Id: I6c458b24574cae28ab390644b8a3e1982675c4c3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154508
Tested-by: Jenkins
Reviewed-by: Jim Raykowski
diff --git a/sw/source/uibase/dochdl/swdtflvr.cxx
b/sw/source/uibase/dochdl/swdtflvr.cxx
index 201b7fa1b5d2..0974a424e921 100644
--- a/sw/source/uibase/dochdl/swdtflvr.cxx
+++ b/sw/source/uibase/dochdl/swdtflvr.cxx
@@ -1724,7 +1724,12 @@ bool SwTransferable::PasteData( TransferableDataHelper&
rData,
if( pPt )
{
// external Drop
-if( bPasteSelection ? !pMod->m_pXSelection : !pMod->m_pDragDrop )
+if ((bPasteSelection ? !pMod->m_pXSelection : !pMod->m_pDragDrop) &&
+// The following condition is used for tdf#156111 to prevent a
selection from being
+// cleared by the default case of the nDestination switch.
+!(rSh.GetCursorCnt() == 1 && rSh.TestCurrPam(*pPt) &&
+nDestination == SotExchangeDest::SWDOC_FREE_AREA &&
+nFormat == SotClipboardFormatId::SONLK))
{
switch( nDestination )
{
@@ -1929,7 +1934,7 @@ bool SwTransferable::PasteData( TransferableDataHelper&
rData,
if( pPt )
{
NaviContentBookmark aBkmk;
-if( aBkmk.Paste( rData ) )
+if (aBkmk.Paste(rData, rSh.GetSelText()))
{
if(bIsDefault)
{
diff --git a/sw/source/uibase/docvw/edtdd.cxx b/sw/source/uibase/docvw/edtdd.cxx
index bf23cc24391e..287d2969f632 100644
--- a/sw/source/uibase/docvw/edtdd.cxx
+++ b/sw/source/uibase/docvw/edtdd.cxx
@@ -260,9 +260,7 @@ SotExchangeDest SwEditWin::GetDropDestination( const Point&
rPixPnt, SdrObject *
{
SwWrtShell = m_rView.GetWrtShell();
const Point aDocPt( PixelToLogic( rPixPnt ) );
-if( rSh.TestCurrPam( aDocPt )
-|| rSh.IsOverReadOnlyPos( aDocPt )
-|| rSh.DocPtInsideInputField( aDocPt ) )
+if (rSh.IsOverReadOnlyPos(aDocPt) || rSh.DocPtInsideInputField(aDocPt))
return SotExchangeDest::NONE;
SdrObject *pObj = nullptr;
diff --git a/sw/source/uibase/inc/navicont.hxx
b/sw/source/uibase/inc/navicont.hxx
index f8c81ae3dcef..604c1c982c76 100644
--- a/sw/source/uibase/inc/navicont.hxx
+++ b/sw/source/uibase/inc/navicont.hxx
@@ -48,7 +48,7 @@ public:
const OUString& GetDescription() const { return m_aDescription; }
RegionMode GetDefaultDragType() const { return m_nDefaultDrag; }
voidCopy( TransferDataContainer& rData ) const;
-boolPaste( const TransferableDataHelper& rData );
+boolPaste( const TransferableDataHelper& rData, const
OUString& rsDesc );
};
#endif
diff --git a/sw/source/uibase/utlui/content.cxx
b/sw/source/uibase/utlui/content.cxx
index c2af6a16304d..a57df3fd0630 100644
--- a/sw/source/uibase/utlui/content.cxx
+++ b/sw/source/uibase/utlui/content.cxx
@@ -5553,7 +5553,7 @@ void NaviContentBookmark::Copy( TransferDataContainer&
rData ) const
rData.CopyByteString(SotClipboardFormatId::SONLK, sStrBuf);
}
-bool NaviContentBookmark::Paste( const TransferableDataHelper& rData )
+bool NaviContentBookmark::Paste( const TransferableDataHelper& rData, const
OUString& rsDesc )
{
OUString sStr;
bool bRet = rData.GetString( SotClipboardFormatId::SONLK, sStr );
@@ -5564,6 +5564,8 @@ bool NaviContentBookmark::Paste( const
TransferableDataHelper& rData )
m_aDescription = sStr.getToken(0, NAVI_BOOKMARK_DELIM, nPos );
m_nDefaultDrag= static_cast(
o3tl::toInt32(o3tl::getToken(sStr, 0, NAVI_BOOKMARK_DELIM, nPos )) );
m_nDocSh = o3tl::toInt32(o3tl::getToken(sStr, 0, NAVI_BOOKMARK_DELIM,
nPos ));
+if (!rsDesc.isEmpty())
+m_aDescription = rsDesc;
}
return bRet;
}
[Libreoffice-commits] core.git: 2 commits - vcl/inc vcl/qa vcl/qt5 vcl/quartz vcl/source vcl/unx vcl/win
vcl/inc/font/LogicalFontInstance.hxx |2
vcl/inc/pdf/pdfbuildin_fonts.hxx |2
vcl/inc/qt5/QtFont.hxx |1
vcl/inc/quartz/salgdi.h|2
vcl/inc/unx/freetype_glyphcache.hxx|2
vcl/inc/unx/glyphcache.hxx |1
vcl/inc/win/winlayout.hxx |1
vcl/qa/cppunit/cjktext.cxx |2
vcl/qa/cppunit/complextext.cxx | 91 +
vcl/qa/cppunit/fontmocks.hxx |3
vcl/qa/cppunit/logicalfontinstance.cxx |9 +-
vcl/qt5/QtFont.cxx |7 -
vcl/quartz/ctfonts.cxx | 21 -
vcl/source/font/LogicalFontInstance.cxx| 33 -
vcl/source/gdi/pdfbuildin_fonts.cxx|5 -
vcl/unx/generic/glyphs/freetype_glyphcache.cxx | 38 --
vcl/unx/generic/glyphs/glyphcache.cxx |8 --
vcl/win/gdi/salfont.cxx| 50 -
18 files changed, 88 insertions(+), 190 deletions(-)
New commits:
commit 2a19b5fb9af4b0d6c8903ce64ce67ccb536276e1
Author: Khaled Hosny
AuthorDate: Sun Jul 16 07:38:06 2023 +0300
Commit: خالد حسني
CommitDate: Sun Jul 23 06:00:39 2023 +0200
vcl: Set font size to UPEM in some tests
Reduces the chance of rounding differences.
Change-Id: I4ad3e00a41c2dba01fe113ba1261dcf12f0b19f0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154381
Tested-by: Jenkins
Reviewed-by: خالد حسني
diff --git a/vcl/qa/cppunit/complextext.cxx b/vcl/qa/cppunit/complextext.cxx
index bcf96cb4f99b..db8593e48fbb 100644
--- a/vcl/qa/cppunit/complextext.cxx
+++ b/vcl/qa/cppunit/complextext.cxx
@@ -72,33 +72,35 @@ CPPUNIT_TEST_FIXTURE(VclComplexTextTest, testArabic)
#if HAVE_MORE_FONTS
OUString aOneTwoThree(u"واحِدْ إثٍنين ثلاثةٌ");
-vcl::Font aFont("DejaVu Sans", "Book", Size(0, 12));
+vcl::Font aFont("DejaVu Sans", "Book", Size(0, 2048));
ScopedVclPtrInstance pOutDev;
pOutDev->SetFont( aFont );
// absolute character widths AKA text array.
-std::vector aRefCharWidths {6, 9, 16, 16, 22, 22, 26, 29, 32,
32,
- 36, 40, 49, 53, 56, 63, 63, 66, 72, 72};
+tools::Long nRefTextWidth = 12595;
+std::vector aRefCharWidths = { 989, 1558, 2824, 2824, 3899,
+3899, 4550, 5119, 5689, 5689, 6307, 6925, 8484, 9135, 9705, 10927,
+10927, 11497, 12595, 12595 };
KernArray aCharWidths;
tools::Long nTextWidth = pOutDev->GetTextArray(aOneTwoThree, );
CPPUNIT_ASSERT_EQUAL(aRefCharWidths, aCharWidths.get_subunit_array());
// this sporadically returns 75 or 74 on some of the windows tinderboxes
eg. tb73
-CPPUNIT_ASSERT_EQUAL(tools::Long(72), nTextWidth);
+CPPUNIT_ASSERT_EQUAL(nRefTextWidth, nTextWidth);
CPPUNIT_ASSERT_EQUAL(sal_Int32(nTextWidth), aCharWidths.back());
// text advance width and line height
-CPPUNIT_ASSERT_EQUAL(tools::Long(72), pOutDev->GetTextWidth(aOneTwoThree));
-CPPUNIT_ASSERT_EQUAL(tools::Long(14), pOutDev->GetTextHeight());
+CPPUNIT_ASSERT_EQUAL(nRefTextWidth, pOutDev->GetTextWidth(aOneTwoThree));
+CPPUNIT_ASSERT_EQUAL(tools::Long(2384), pOutDev->GetTextHeight());
// exact bounding rectangle, not essentially the same as text width/height
tools::Rectangle aBoundRect;
pOutDev->GetTextBoundRect(aBoundRect, aOneTwoThree);
-CPPUNIT_ASSERT_DOUBLES_EQUAL(0, aBoundRect.Left(), 1); // This sometimes
equals to 1
-CPPUNIT_ASSERT_DOUBLES_EQUAL(1, aBoundRect.Top(), 1);
-CPPUNIT_ASSERT_DOUBLES_EQUAL(71, aBoundRect.GetWidth(), 2); // This
sometimes equals to 70
-CPPUNIT_ASSERT_DOUBLES_EQUAL(15, aBoundRect.getOpenHeight(), 1);
+CPPUNIT_ASSERT_EQUAL(tools::Long(145), aBoundRect.Left());
+CPPUNIT_ASSERT_EQUAL(tools::Long(212), aBoundRect.Top());
+CPPUNIT_ASSERT_EQUAL(tools::Long(12294), aBoundRect.GetWidth());
+CPPUNIT_ASSERT_EQUAL(tools::Long(2279), aBoundRect.getOpenHeight());
// normal orientation
tools::Rectangle aInput;
@@ -242,7 +244,8 @@ CPPUNIT_TEST_FIXTURE(VclComplexTextTest, testCaret)
#if HAVE_MORE_FONTS
// Test caret placement in fonts *without* ligature carets in GDEF table.
-vcl::Font aFont("DejaVu Sans", "Book", Size(0, 200));
+// Set font size to its UPEM to decrease rounding issues
+vcl::Font aFont("DejaVu Sans", "Book", Size(0, 2048));
ScopedVclPtrInstance pOutDev;
pOutDev->SetFont( aFont );
@@ -250,38 +253,39 @@ CPPUNIT_TEST_FIXTURE(VclComplexTextTest, testCaret)
OUString aText;
KernArray aCharWidths;
std::vector aRefCharWidths;
-tools::Long nTextWidth, nTextWidth2;
+tools::Long nTextWidth, nTextWidth2, nRefTextWidth;
// A. RTL text
aText = u"لا بلا";
// 1) Regular DX array, the ligature width is given to the first components
// and the next
[Libreoffice-commits] core.git: 2 commits - svgio/qa vcl/qa
svgio/qa/cppunit/SvgImportTest.cxx |2 +- svgio/qa/cppunit/data/CssClassRedefinition.svg |2 +- vcl/qa/cppunit/pdfexport/pdfexport.cxx | 20 ++-- 3 files changed, 12 insertions(+), 12 deletions(-) New commits: commit 32144b5dc617d5a375eeadf25b5b62befb529785 Author: Khaled Hosny AuthorDate: Mon Jul 17 13:58:30 2023 +0300 Commit: خالد حسني CommitDate: Sun Jul 23 06:00:20 2023 +0200 Make CppunitTest_vcl_pdfexport CPPUNIT_TEST_NAME=testTdf108963 less sensitive The test does not need all that precision, without the bug fix for tdf#108963 it fails with: double equality assertion failed - Expected: 245 - Actual : 255.401992797852 - Delta : 0.999 Change-Id: Iae20417465e7c43f5be2819f710f768645dc3253 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154522 Tested-by: Jenkins Reviewed-by: خالد حسني diff --git a/vcl/qa/cppunit/pdfexport/pdfexport.cxx b/vcl/qa/cppunit/pdfexport/pdfexport.cxx index b2e72df31e3f..aaf3998eb99a 100644 --- a/vcl/qa/cppunit/pdfexport/pdfexport.cxx +++ b/vcl/qa/cppunit/pdfexport/pdfexport.cxx @@ -770,36 +770,36 @@ CPPUNIT_TEST_FIXTURE(PdfExportTest, testTdf108963) = pPdfPageObject->getPathSegment(0); CPPUNIT_ASSERT_EQUAL(vcl::pdf::PDFSegmentType::Moveto, pSegment->getType()); basegfx::B2DPoint aPoint = pSegment->getPoint(); -CPPUNIT_ASSERT_DOUBLES_EQUAL(245.367, aPoint.getX(), 0.0005); -CPPUNIT_ASSERT_DOUBLES_EQUAL(244.232, aPoint.getY(), 0.0005); +CPPUNIT_ASSERT_DOUBLES_EQUAL(245, aPoint.getX(), 0.999); +CPPUNIT_ASSERT_DOUBLES_EQUAL(244, aPoint.getY(), 0.999); CPPUNIT_ASSERT(!pSegment->isClosed()); pSegment = pPdfPageObject->getPathSegment(1); CPPUNIT_ASSERT_EQUAL(vcl::pdf::PDFSegmentType::Lineto, pSegment->getType()); aPoint = pSegment->getPoint(); -CPPUNIT_ASSERT_DOUBLES_EQUAL(275.216, aPoint.getX(), 0.0005); -CPPUNIT_ASSERT_DOUBLES_EQUAL(267.732, aPoint.getY(), 0.0005); +CPPUNIT_ASSERT_DOUBLES_EQUAL(275, aPoint.getX(), 0.999); +CPPUNIT_ASSERT_DOUBLES_EQUAL(267, aPoint.getY(), 0.999); CPPUNIT_ASSERT(!pSegment->isClosed()); pSegment = pPdfPageObject->getPathSegment(2); CPPUNIT_ASSERT_EQUAL(vcl::pdf::PDFSegmentType::Lineto, pSegment->getType()); aPoint = pSegment->getPoint(); -CPPUNIT_ASSERT_DOUBLES_EQUAL(287.660, aPoint.getX(), 0.0005); -CPPUNIT_ASSERT_DOUBLES_EQUAL(251.914, aPoint.getY(), 0.0005); +CPPUNIT_ASSERT_DOUBLES_EQUAL(287, aPoint.getX(), 0.999); +CPPUNIT_ASSERT_DOUBLES_EQUAL(251, aPoint.getY(), 0.999); CPPUNIT_ASSERT(!pSegment->isClosed()); pSegment = pPdfPageObject->getPathSegment(3); CPPUNIT_ASSERT_EQUAL(vcl::pdf::PDFSegmentType::Lineto, pSegment->getType()); aPoint = pSegment->getPoint(); -CPPUNIT_ASSERT_DOUBLES_EQUAL(257.811, aPoint.getX(), 0.0005); -CPPUNIT_ASSERT_DOUBLES_EQUAL(228.443, aPoint.getY(), 0.0005); +CPPUNIT_ASSERT_DOUBLES_EQUAL(257, aPoint.getX(), 0.999); +CPPUNIT_ASSERT_DOUBLES_EQUAL(228, aPoint.getY(), 0.999); CPPUNIT_ASSERT(!pSegment->isClosed()); pSegment = pPdfPageObject->getPathSegment(4); CPPUNIT_ASSERT_EQUAL(vcl::pdf::PDFSegmentType::Lineto, pSegment->getType()); aPoint = pSegment->getPoint(); -CPPUNIT_ASSERT_DOUBLES_EQUAL(245.367, aPoint.getX(), 0.0005); -CPPUNIT_ASSERT_DOUBLES_EQUAL(244.232, aPoint.getY(), 0.0005); +CPPUNIT_ASSERT_DOUBLES_EQUAL(245, aPoint.getX(), 0.999); +CPPUNIT_ASSERT_DOUBLES_EQUAL(244, aPoint.getY(), 0.999); CPPUNIT_ASSERT(pSegment->isClosed()); } } commit 7774e0bb716d6f60e32f259d49d2e07e5b0de792 Author: Khaled Hosny AuthorDate: Sun Jul 16 07:30:02 2023 +0300 Commit: خالد حسني CommitDate: Sun Jul 23 06:00:10 2023 +0200 Make CppunitTest_svgio CPPUNIT_TEST_NAME=testCssClassRedefinition more robust The commit: commit 9e83d35c4a22bcb465f0736dda9b752b29f83959 Date: Thu Jun 23 21:52:52 2022 +0200 Make CppunitTest_svgio CPPUNIT_TEST_NAME=Test::testCssClassRedefinition robust Changed the font from generic Sans to Open Symbol to avoid failure when a different font is used, but it didn’t change the text string to a one supported by Open Symbol, so font fallback would still make the test fail. Change the text string to “012” which is supported by Open Symbol. Change-Id: I6e6ba22614ef1bafe5aece05c42d57d71923380c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154492 Tested-by: Jenkins Reviewed-by: خالد حسني diff --git a/svgio/qa/cppunit/SvgImportTest.cxx b/svgio/qa/cppunit/SvgImportTest.cxx index
[Libreoffice-bugs] [Bug 156402] Deleting rows that contain images doesn't delete all the image shapes
https://bugs.documentfoundation.org/show_bug.cgi?id=156402 --- Comment #6 from m.a.riosv --- The related bug tdf#156242 it's about writer, and has nothing to do with this one. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 38046] [META] False "Libreoffice requires a Java runtime environment (JRE)" warnings
https://bugs.documentfoundation.org/show_bug.cgi?id=38046 --- Comment #27 from Christoph Anton Mitterer --- Yes. Still an issue as of 7.5.5, and just as annoying as it ever was ;-) I mean the pop up shows even twice, every start. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156427] New: support GTK Emoji Chooser
https://bugs.documentfoundation.org/show_bug.cgi?id=156427 Bug ID: 156427 Summary: support GTK Emoji Chooser Product: LibreOffice Version: 7.5.5.2 release Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: enhancement Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: cales...@scientia.org Description: GTK supports a native Emoji Chooser, which should already work with GTK 3 used by Libreoffice (on Linux) and is activated by pressing Ctrl-. or Ctrl-; . Interestingly this already works, when e.g. pressing the key sequence in the font selection drop down text field... but it does not work in the main text area. It would be nice if Libreoffice could enable support for that. Steps to Reproduce: Position cursor in e.g. a Writer document text field, press Ctrl+. . Actual Results: nothing happens Expected Results: the emoji chooser should show up Reproducible: Always User Profile Reset: No Additional Info: Version: 7.5.5.2 (X86_64) / LibreOffice Community Build ID: 50(Build:2) CPU threads: 16; OS: Linux 6.3; UI render: default; VCL: gtk3 Locale: en-US (en_DE.UTF-8); UI: en-US Debian package version: 4:7.5.5-2 Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156421] table loses format and there is no undo
https://bugs.documentfoundation.org/show_bug.cgi?id=156421 Dieter changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||dgp-m...@gmx.de Ever confirmed|0 |1 --- Comment #3 from Dieter --- J22Gim, could you please check, if it is the same as described in bug 126008? => NEEDINFO -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156426] Gregorian Date before 1582
https://bugs.documentfoundation.org/show_bug.cgi?id=156426 --- Comment #1 from ady --- I'm not sure there is a clear bug or requested behavior here. I understand the general concept, but then I wonder what exactly should be the "expected behavior" vs the "current behavior". There are several reports regarding Gregorian calendar. One of them is bug 144699. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156380] FORMATTING: images in cells should autoshrink to cell size, same as Excel behavior
https://bugs.documentfoundation.org/show_bug.cgi?id=156380 danomois changed: What|Removed |Added Severity|normal |enhancement Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #3 from danomois --- BrianP, Interesting one. I have replicated the behavior and see the situation exists. I have changed the 'Importance': medium to 'enhancement' and marked it New - because (while admittedly I am new to QA here) I believe the default setting for Anchor of the Image (see the help link below) is acting as desired. https://help.libreoffice.org/latest/hr/text/scalc/guide/change_image_anchor.html?DbPAR=CALC#bm_id471607970579914 The problem of course is it defaults to To Cell, where I would argue with you that the Anchor setting should inherit the setting from Excel if set to Fit to Cell. As for the Macro and a quick fix - there below is a link to Event Driven Macros. If you made one to execute on Start Application I think that would eliminate the need for user intervention. https://help.libreoffice.org/latest/en-US/text/sbasic/shared/0104.html Finally, let me ask - can you confirm if Excel picks up the default setting Fit to Cell if the setting is first made in LibreOffice calc? That is, if you make a LibreOffice calc sheet, and paste an image then Anchor To Cell(Fit to Cell), then save, then open in Excel - is that same image/cell formatted Fit to Cell? I'm only asking to know because I don't have Excel myself. Thank you! -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156424] Copy/paste of a row with images results in a copy with copied images positioned incorrectly
https://bugs.documentfoundation.org/show_bug.cgi?id=156424 ady changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||6402 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156402] Deleting rows that contain images doesn't delete all the image shapes
https://bugs.documentfoundation.org/show_bug.cgi?id=156402 ady changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||6424 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156426] New: Gregorian Date before 1582
https://bugs.documentfoundation.org/show_bug.cgi?id=156426 Bug ID: 156426 Summary: Gregorian Date before 1582 Product: LibreOffice Version: 7.5.2.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: rwk@zoho.com Hi, the leap year for the centuries is not calculated correctly before 1600. There should be no February 29th in the years that are multiples of 100 and not multiples of 400. This does work for the centuries 1600 and up into the future, but not going into the past(1500, 1400, 1300..., -200). In the time before 1600 every year dividable by 4 is a leap year, unfortunately all the centuries also. That ruins the day count. Thanks for considering my input rk -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156402] Deleting rows that contain images doesn't delete all the image shapes
https://bugs.documentfoundation.org/show_bug.cgi?id=156402 --- Comment #7 from Jim Connell --- I'm having a very bad day. My apologies. The similar bug is 156424. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156406] The ruler in Draw does not respond when changing the units to feet or changing the scale.
https://bugs.documentfoundation.org/show_bug.cgi?id=156406 zugbug22-...@yahoo.com changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |NOTABUG --- Comment #2 from zugbug22-...@yahoo.com --- (In reply to m.a.riosv from comment #1) > I can see the changes, select an A3 page on portrait, and you can see 1 > foot, the scale change it's in the status bar before the scale line, you can > right-click on it to change. > > Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community > Build ID: 58a4459627a92958ef133868f72af10d8d56ccad > CPU threads: 16; OS: Windows 10.0 Build 22621; UI render: default; VCL: win > Locale: es-ES (es_ES); UI: en-US Calc: CL threadedVersion: 7.6.0.1 (X86_64) > / LibreOffice Community > Build ID: 776eaf34564cbf3f034a0ba1fd1d5c32ff9ccf1c > CPU threads: 16; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: > win > Locale: es-ES (es_ES); UI: en-US Calc: CL threaded > Version: 7.5.5.2 (X86_64) / LibreOffice Community > Build ID: ca8fe7424262805f223b9a2334bc7181abbcbf5e > CPU threads: 16; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: > win > Locale: es-ES (es_ES); UI: en-US Calc: CL threaded > Version: 7.4.7.2 (x64) / LibreOffice Community > Build ID: 723314e595e8007d3cf785c16538505a1c878ca5 > CPU threads: 16; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: > win > Locale: es-ES (es_ES); UI: es-ES Calc: CL > > If doesn't work for you, please test in safe mode, Menu/Help/Restart in Safe > Mode Yes, I see the changes. Resolved. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156380] FORMATTING: images in cells should autoshrink to cell size, same as Excel behavior
https://bugs.documentfoundation.org/show_bug.cgi?id=156380 --- Comment #4 from ady --- (In reply to BrianP from comment #2) > Created attachment 188491 [details] > original excel file that can be opened to show the behaviors Is this happening also when using (saving) ods files from Excel? Or is it only reproduced with xlsx? What about xls? These questions might be relevant in order to find out whether the problem is related to import filters (only), or it is also related to images in any file format (including ods). Of course that Excel might also generate an ods file that is seen differently (in Excel itself and/or in Calc), which would add another layer to the interoperability problem. > I could only upload 1 file with original submission Simply open again the report page of this bug 156380 and click (again) on the "Add an attachment" link in order to add a new comment with an additional attachment. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156421] New: table loses format and there is no undo
https://bugs.documentfoundation.org/show_bug.cgi?id=156421 Bug ID: 156421 Summary: table loses format and there is no undo Product: LibreOffice Version: 7.5.5.2 release Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: j22...@gmail.com Description: A table completely loses its format when doing some edits. The format is lost (not reverted to the original autoformat) and this can not be undone Steps to Reproduce: 1. open a new Writer document 2. insert a table from Table > Insert table 3. change the format (eg colors, font, etc. etc.) 4. Now erase one row Actual Results: the table changes to a random-ish format. There is no undo Expected Results: the row should be erased without affecting the format. And the action should be 'undoable' Reproducible: Always User Profile Reset: Yes Additional Info: Version: 7.5.5.2 (X86_64) / LibreOffice Community Build ID: 50(Build:2) CPU threads: 4; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Ubuntu package version: 4:7.5.5~rc2-0ubuntu0.22.04.1~lo1 Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156421] table loses format and there is no undo
https://bugs.documentfoundation.org/show_bug.cgi?id=156421 --- Comment #1 from j22...@gmail.com --- Created attachment 188517 --> https://bugs.documentfoundation.org/attachment.cgi?id=188517=edit Erase a row and see what happens -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146584] Firebird: Setting default with ALTER TABLE gives useless message but sets default
https://bugs.documentfoundation.org/show_bug.cgi?id=146584 Julien Nabet changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |serval2...@yahoo.fr |desktop.org | Status|NEW |ASSIGNED --- Comment #8 from Julien Nabet --- I gave a try with https://gerrit.libreoffice.org/c/core/+/154755 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156421] table loses format and there is no undo
https://bugs.documentfoundation.org/show_bug.cgi?id=156421 --- Comment #2 from j22...@gmail.com --- Created attachment 188518 --> https://bugs.documentfoundation.org/attachment.cgi?id=188518=edit this is how I see it -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 101522] [META] Media playback bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=101522 Aron Budea changed: What|Removed |Added URL|https://instazeropro2.in/ | -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156424] Copy/paste of a row with images results in a copy with copied images positioned incorrectly
https://bugs.documentfoundation.org/show_bug.cgi?id=156424 --- Comment #2 from Jim Connell --- Similar to bug 156402. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156402] Deleting rows that contain images doesn't delete all the image shapes
https://bugs.documentfoundation.org/show_bug.cgi?id=156402 --- Comment #4 from Jim Connell --- Similar to bug 164242. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156412] base basic Libre office form wizard problem
https://bugs.documentfoundation.org/show_bug.cgi?id=156412 --- Comment #6 from Alex Thurgood --- (In reply to yolcumehmet from comment #3) > i'm not spam. Libre office base > > > > for example, for the button (people can't write macros) > add request: button (save) button (forward) button (back ) I'm not really sure why this should go into the form creation wizard when, as the YouTube link which you posted shows, you can do it manually in Form Design mode. The Form wizard code is already fairly complex (and fragile), and I would imagine that defining the scope of the functionality to be included, and writing the code to achieve that, would be a non-trivial exercise. That said, it isn't my call, just my 2 cents. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156423] New: Twice on successive days the programme has not saved my input. !st time was a new worksheet, named and saved, 2nd time ditto but on a new page in an existing work
https://bugs.documentfoundation.org/show_bug.cgi?id=156423 Bug ID: 156423 Summary: Twice on successive days the programme has not saved my input. !st time was a new worksheet, named and saved, 2nd time ditto but on a new page in an existing work book Product: LibreOffice Version: unspecified Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: simonga...@hotmail.com I have been using the various iterations of LibreOffice for as long as I can remember, this has never happened before. I can recover the new named document but all there is is a completely blank worksheet. The new sheet on the existing workbook does not even exist when I reopen the workbook -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156422] UI expanded formula dialogue uselessly expands white-space rather than formula
https://bugs.documentfoundation.org/show_bug.cgi?id=156422 m.a.riosv changed: What|Removed |Added CC||miguelangelrv@libreoffice.o ||rg Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from m.a.riosv --- *** This bug has been marked as a duplicate of bug 101876 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156425] New: Editor windows pop to top when mouse flies over them
https://bugs.documentfoundation.org/show_bug.cgi?id=156425 Bug ID: 156425 Summary: Editor windows pop to top when mouse flies over them Product: LibreOffice Version: 7.5.3.2 release Hardware: Other OS: macOS (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: dreapp...@yahoo.com Description: When I move the mouse across the screen, without pressing any keys or otherwise activating the mouse, just a move across my screen, often times any LibreOffice window the mouse passes over will pop to the top of the screen. It may not be active, but it is now occluding everything it intersects its region with. This happens with the Writer, but may be happening with other products, like Calc and Draw, as well. And it happens about 95% of the time, not all the time, just enough to be very irritating and unpredictable. Perhaps it is speed related, but I have moved the mouse both slowly and very fast across a window, and it still pops to the top. And as I cross over another Writer window, it pops to the top. It seems to happen slightly more frequently (97%) when the mouse crosses over an exposed tool bar button, but it also happens if the mouse simply passes over the edit pane. Steps to Reproduce: See description of problem. Actual Results: Just pass the mouse over a Writer window, especially any of the tool bar items. Expected Results: See description of problem. The result is that it is sometimes quite impossible to edit the window you want because you moved the mouse out of the way to type something and another window pops up so you definitely can't see what you are doing. You have to minimize the other window, which may mean you can't see other information you need to refer to. This kills productive dead. Reproducible: Sometimes User Profile Reset: Yes Additional Info: Window should only pop to the top of the display screen when they are clicked on. And if a tool bar or menu button is clicked on when the window is not active, all that should happen is the window pops to the top of the screen display and becomes active. No other action should take place. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156420] New: The results of complex number functions in Calc are always using a point as decimal separator
https://bugs.documentfoundation.org/show_bug.cgi?id=156420 Bug ID: 156420 Summary: The results of complex number functions in Calc are always using a point as decimal separator Product: LibreOffice Version: 7.5.5.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: trivial Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: arbau...@gmail.com Description: With regional settings set to have a comma as decimal separator (Windows 11 in french), numbers (real numbers) are correctly shown with a comma in Calc. However, complex number functions, such as COMPLEX.RACINE (french for IMSQRT), have results using a point as decimal separator. Those functions correctly take complex numbers with comma separator as /input/, but the output doesn't follow regional settings. As I understand it, since complex numbers in Calc are actually strings and are therefore not automatically translated when opened on a machine with different regional settings, it's necessary for those functions to accept strings with comma or point separator, and it seems to work (though I don't think thousand separators are handled correctly, but it's a minor inconvenience, and it could be ambiguous anyway). However, it would be nice to have output follow the regional settings for the decimal separator, and use a comma when needed. This behavior seems to happen with all complex number functions. I mark the severity as trivial as it does not affect numerical results. It's more a "visual bug", and it depends on regional settings. Steps to Reproduce: Set system decimal separator as comma. In any empty cell: =COMPLEXE.RACINE(-2) (french function) or =IMSQRT(-2). Actual Results: 1.4142135623731i Expected Results: 1,4142135623731i Reproducible: Always User Profile Reset: No Additional Info: Version: 7.5.5.2 (X86_64) / LibreOffice Community Build ID: ca8fe7424262805f223b9a2334bc7181abbcbf5e CPU threads: 12; OS: Windows 10.0 Build 22621; UI render: Skia/Vulkan; VCL: win Locale: fr-FR (fr_FR); UI: fr-FR Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155875] [LOCALHELP] - Writer - Help pages about dialogs should provide instructions for the Tabbed UI
https://bugs.documentfoundation.org/show_bug.cgi?id=155875 --- Comment #26 from Commit Notification --- Olivier Hallot committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/help/commit/acfa489281ad217a46cdfe5558a2bcdcd963d347 tdf#155875 Tab'd UI cmds Writer/Insert in Help(14) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156414] PNG inserted in Calc with wrong aspect ratio
https://bugs.documentfoundation.org/show_bug.cgi?id=156414 Rainer Bielefeld Retired changed: What|Removed |Added CC||LibreOffice@bielefeldundbus ||s.de --- Comment #3 from Rainer Bielefeld Retired --- REPRODUCIBLE with Server Installation of Version: 7.6.0.0.alpha0+ (X86_64) Build ID: 9f56dff12ba03b9acd7730a5a481eea045e468f3 CPU threads: 12; OS: Windows 10.0 Build 19045; UI render: default; VCL: win Locale: Locale: de-DE (de_DE); UI: de-DE; Theme: Automatic (Colibre) Calc: CL threaded – Special new User Profile for testing And: a) not limited to PNG, also observed with JPG and GIF from Wikipedia logo b) Not limited to import, also observed with copy / paste from DRAW (Paste as Bitmap, ...), but there also other effects might interfere -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 155891] Option to REQUIRE pressing F2 or Enter to switch to cell edit mode and ignore any data entry attempts otherwise
https://bugs.documentfoundation.org/show_bug.cgi?id=155891 Buovjaga changed: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 156358] VIEWING: Calc AutoInput (pop up formula editing helper) hides the formula [Flatpak]
https://bugs.documentfoundation.org/show_bug.cgi?id=156358 Buovjaga changed: What|Removed |Added CC||ilmari.lauhakangas@libreoff ||ice.org --- Comment #5 from Buovjaga --- (In reply to Moshpirit from comment #2) > I've just found out that it's the registrymodifications.xcu file what's > causing it. I use a single toolbar interface. When changing it to other > interfaces, it doesn't happen anymore. Any way to fix this while keeping the > current configuration? I modified many things there. Are you able to attach the registrymodifications.xcu file? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156420] The results of complex number functions in Calc are always using a point as decimal separator
https://bugs.documentfoundation.org/show_bug.cgi?id=156420 ady changed: What|Removed |Added Resolution|--- |DUPLICATE Status|UNCONFIRMED |RESOLVED --- Comment #1 from ady --- I'll mark this as a duplicate of bug 66319. If there is something particularly different in this bug 156420, or that deserves to be considered as a separate report, please change it back to UNCONFIRMED. *** This bug has been marked as a duplicate of bug 66319 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 66319] returned complex numbers use decimal point regardless of locale
https://bugs.documentfoundation.org/show_bug.cgi?id=66319 ady changed: What|Removed |Added CC||arbau...@gmail.com --- Comment #13 from ady --- *** Bug 156420 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156422] UI expanded formula dialogue uselessly expands white-space rather than formula
https://bugs.documentfoundation.org/show_bug.cgi?id=156422 rob...@prino.org changed: What|Removed |Added CC||rob...@prino.org --- Comment #1 from rob...@prino.org --- Created attachment 188519 --> https://bugs.documentfoundation.org/attachment.cgi?id=188519=edit Standard open of dialog -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156422] UI expanded formula dialogue uselessly expands white-space rather than formula
https://bugs.documentfoundation.org/show_bug.cgi?id=156422 --- Comment #2 from rob...@prino.org --- Created attachment 188520 --> https://bugs.documentfoundation.org/attachment.cgi?id=188520=edit Expanded open of dialog -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 101522] [META] Media playback bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=101522 james changed: What|Removed |Added URL||https://instazeropro2.in/ -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155875] [LOCALHELP] - Writer - Help pages about dialogs should provide instructions for the Tabbed UI
https://bugs.documentfoundation.org/show_bug.cgi?id=155875 --- Comment #28 from Commit Notification --- Olivier Hallot committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/help/commit/9f7c011c3ea533d8283b17dff0d191deb7235645 tdf#155875 Tab'd UI cmds Writer/Insert in Help(16) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155875] [LOCALHELP] - Writer - Help pages about dialogs should provide instructions for the Tabbed UI
https://bugs.documentfoundation.org/show_bug.cgi?id=155875 --- Comment #29 from Commit Notification --- Olivier Hallot committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/help/commit/141b19cf577d2c6b3fb7b3c29dc67977352895c5 tdf#155875 Tab'd UI cmds Writer/Insert in Help(17) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155875] [LOCALHELP] - Writer - Help pages about dialogs should provide instructions for the Tabbed UI
https://bugs.documentfoundation.org/show_bug.cgi?id=155875 --- Comment #27 from Commit Notification --- Olivier Hallot committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/help/commit/ac354a87fb9f5d47d61b4532466ed5954680b5da tdf#155875 Tab'd UI cmds Writer/Insert in Help(15) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 31480] Find/replace non-printing characters easily
https://bugs.documentfoundation.org/show_bug.cgi?id=31480 --- Comment #110 from anton --- Latest news and updates on cricket, IPL, football, WWE, basketball, tennis, and more at our comprehensive news website. We bring you all the trending stories, match analyses, player interviews, and event highlights from the world of sports. From thrilling matches to transfer rumors, injury updates to championship triumphs, we've got you covered. https://indiablogtoday.com/;>India Blog Today -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156402] Deleting rows that contain images doesn't delete all the image shapes
https://bugs.documentfoundation.org/show_bug.cgi?id=156402 --- Comment #5 from Jim Connell --- (In reply to Jim Connell from comment #4) > Similar to bug 164242. Correction: similar to bug 156242. Sorry. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156423] Twice on successive days the programme has not saved my input. !st time was a new worksheet, named and saved, 2nd time ditto but on a new page in an existing work book
https://bugs.documentfoundation.org/show_bug.cgi?id=156423 Julien Nabet changed: What|Removed |Added CC||serval2...@yahoo.fr Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #1 from Julien Nabet --- On which LO version have you got this symptom and on which Linux distrib are you + version? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156422] New: UI expanded formula dialogue uselessly expands white-space rather than formula
https://bugs.documentfoundation.org/show_bug.cgi?id=156422 Bug ID: 156422 Summary: UI expanded formula dialogue uselessly expands white-space rather than formula Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: rob...@prino.org See the two attached PNG, a picture says more than a thousand words, but if you insist: Expanding the dialog box resulting from the "fx" button on the Cals formula bar expands the white space on the right half of the resulting pop-up, rather than the text boxes that contain the formulae, which is of course utterly useless! And FWIW, there are several more, I'll post them when I encounter them again, occurrences of the same issue in other UI elements. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156424] New: Copy/paste of a row with images results in a copy with copied images positioned incorrectly
https://bugs.documentfoundation.org/show_bug.cgi?id=156424 Bug ID: 156424 Summary: Copy/paste of a row with images results in a copy with copied images positioned incorrectly Product: LibreOffice Version: 7.5.4.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: bugs.documentfoundation@exeyesoftware.com Description: In a Calc spreadsheet with columns containing images, if a row is copied and pasted elsewhere, the image(s) in the row end up positioned incorrectly. Steps to Reproduce: 1. Open attached spreadsheet. 2. Select and copy row 3. 3. Paste into row 6. Actual Results: The copy has the images in the wrong place horizontally. It's not clear if they have been moved to a different cell or if they were just positioned incorrectly. Expected Results: The row copy should look like the original. Reproducible: Always User Profile Reset: No Additional Info: Version: 7.5.4.2 (X86_64) / LibreOffice Community Build ID: 36ccfdc35048b057fd9854c757a8b67ec53977b6 CPU threads: 12; OS: Windows 10.0 Build 19045; UI render: default; VCL: win Locale: en-US (en_US); UI: en-US Calc: threaded I don't know if the images in a spreadsheet are associated with the cell explicitly or only by position. So I don't know if any actual association is correct, or if there is even a way to tell. The point is that it may not be enough to just fix the position. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156424] Copy/paste of a row with images results in a copy with copied images positioned incorrectly
https://bugs.documentfoundation.org/show_bug.cgi?id=156424 --- Comment #1 from Jim Connell --- Created attachment 188521 --> https://bugs.documentfoundation.org/attachment.cgi?id=188521=edit A Calc spreadsheet with images. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 155414] macOS's "Accessibility > Display > Reduce Motion" setting doesn't stop "Marching Ants"
https://bugs.documentfoundation.org/show_bug.cgi?id=155414 Patrick Luby changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |plub...@neooffice.org |desktop.org | --- Comment #9 from Patrick Luby --- I have uploaded the following patch that implements my proposed change: https://gerrit.libreoffice.org/c/core/+/154752 Checking the native macOS "reduce motion" preference is in the new AquaSalInstance::UseReducedAnimation() method in vcl/osx/salinst.cxx. All other platforms return false. Not sure if the following helps, but below are the SalInstance subclasses that have their own AddToRecentDocumentList() method that aren't empty and have implemented native code. Not sure if it is a useful list or not, but my guess is that the platforms that implement some native code in AddToRecentDocumentList() are the superset of platforms where it might be possible to implement of UseReducedAnimation(): vcl/inc/unx/gtk/gtkinst.hxx vcl/inc/win/salinst.h vcl/inc/osx/salinst.h And for completeness, below are the other SalInstances that are empty or have not implemented native code: vcl/inc/unx/salinst.h vcl/inc/headless/svpinst.hxx vcl/inc/qt5/QtInstance.hxx -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 155414] macOS's "Accessibility > Display > Reduce Motion" setting doesn't stop "Marching Ants"
https://bugs.documentfoundation.org/show_bug.cgi?id=155414 Patrick Luby changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |plub...@neooffice.org |desktop.org | --- Comment #9 from Patrick Luby --- I have uploaded the following patch that implements my proposed change: https://gerrit.libreoffice.org/c/core/+/154752 Checking the native macOS "reduce motion" preference is in the new AquaSalInstance::UseReducedAnimation() method in vcl/osx/salinst.cxx. All other platforms return false. Not sure if the following helps, but below are the SalInstance subclasses that have their own AddToRecentDocumentList() method that aren't empty and have implemented native code. Not sure if it is a useful list or not, but my guess is that the platforms that implement some native code in AddToRecentDocumentList() are the superset of platforms where it might be possible to implement of UseReducedAnimation(): vcl/inc/unx/gtk/gtkinst.hxx vcl/inc/win/salinst.h vcl/inc/osx/salinst.h And for completeness, below are the other SalInstances that are empty or have not implemented native code: vcl/inc/unx/salinst.h vcl/inc/headless/svpinst.hxx vcl/inc/qt5/QtInstance.hxx -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 106067] A chart in a duplicated sheet sometimes loses its data range
https://bugs.documentfoundation.org/show_bug.cgi?id=106067 --- Comment #10 from QA Administrators --- Dear david.vantyghem, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 109524] DOCX IMPORT: A table in a specific document has wrong width in Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=109524 --- Comment #10 from QA Administrators --- Dear Mike Kaganski, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 99632] EDITING: DOCX with embedded XLS: when opened to edit, the XLS-object is opened as new (readonly) file
https://bugs.documentfoundation.org/show_bug.cgi?id=99632 --- Comment #8 from QA Administrators --- Dear Marina Latini (SUSE), To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 107654] Table Design window for new table, title bar names existing Table1
https://bugs.documentfoundation.org/show_bug.cgi?id=107654 --- Comment #9 from QA Administrators --- Dear Terrence Enger, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142347] add ability to change the background and font colours of the new tabbed/ribbon view (LibreOffice writer)
https://bugs.documentfoundation.org/show_bug.cgi?id=142347 --- Comment #6 from QA Administrators --- Dear joe-pringle, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156200] Writer: Bad font rendering with anti-aliasing disabled (hinting enabled!) in Manjaro KDE system settings after update to LO 7.4.5-1
https://bugs.documentfoundation.org/show_bug.cgi?id=156200 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152925] LibreOffice: no visibility of menu when I open "Formatvorlagen verwalten"
https://bugs.documentfoundation.org/show_bug.cgi?id=152925 --- Comment #2 from QA Administrators --- Dear steam2, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151838] EDITING: Find hard carriage return does not work.
https://bugs.documentfoundation.org/show_bug.cgi?id=151838 --- Comment #3 from QA Administrators --- Dear f.pignal, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156111] Drag and drop of a bookmark from the Navigator onto a text selection should use it as the hyperlink text
https://bugs.documentfoundation.org/show_bug.cgi?id=156111 --- Comment #5 from Commit Notification --- Jim Raykowski committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/c6b404c39569b6bc972b821a13f6bba0a68d8d9d tdf#156111 SwNavigator hyperlink dnd enhancement It will be available in 24.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156111] Drag and drop of a bookmark from the Navigator onto a text selection should use it as the hyperlink text
https://bugs.documentfoundation.org/show_bug.cgi?id=156111 Commit Notification changed: What|Removed |Added Whiteboard||target:24.2.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 107654] Table Design window for new table, title bar names existing Table1
https://bugs.documentfoundation.org/show_bug.cgi?id=107654 --- Comment #10 from Robert Großkopf --- Bug is still the same in LO 7.6.0.1 on OpenSUSE 15.4 64bit rpm Linux. -- You are receiving this mail because: You are the assignee for the bug.
