Re: Machine learning is used in gerrit build
Hi Noel, The reason to choose it is that it is most likely to fail among all the builds. If it fails, then there is no need to run others. If we choose a job that is stable and likely to pass every patch, then all other builds also need to be run, saving no computation. I'm open to all advice on the build design. Best, Baole Fang On Fri, Aug 18, 2023, 4:26 AM Noel Grandin wrote: > Hi > > Why are we fronting the ml jenkins job with the least reliable subjob? > > Surely we should be using the gcc job - which is faster and more reliable. > > Regards, Noel Grandin > >
Re: Machine learning is used in gerrit build
HI My problem with this design assumes that the only thing we are optimising for is reducing the load on the build servers. But we are not a build-service organisation. Jenkins is a service that is subordinate to the needs of developers. And what developers need is feedback about which platforms their changes are working or not working on. Just recently I have to resume my builds 5 or 6 times to get past the ML stage, only then to discover that I made a mistake that affected some other platform, and then having to change things again, and restart the process. I am really sorry you went to all this effort, but I do not think that this ML plugin for jenkins is a good idea. If I had known that this was in progress, I would have spoken up sooner. If we need better jenkins throughput, TDF should just buy some more/better hardware. Regards, Noel Grandin
[Libreoffice-commits] core.git: officecfg/registry
officecfg/registry/data/org/openoffice/Office/Accelerators.xcu | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) New commits: commit 3614953bf1f4ada22247d04a772d1e3e1d361cef Author: Caolán McNamara AuthorDate: Fri Aug 18 13:27:46 2023 +0100 Commit: Caolán McNamara CommitDate: Fri Aug 18 18:17:36 2023 +0200 tdf#151059 don't use Ctrl+Alt+3 etc by default for gallery because on some keyboard layouts ctrl+alt is basically equivalent to altgr and removes the possibility to enter specific letters. use Alt+3 etc because that 1-9 sequence seems free and unproblematic vs other combinations. If that doesn't work out then maybe we don't need one per sidebar entry and just have a single entry to jump to the sidebar toolbar and a follow up of press of 1-9 to activate a specific deck. Change-Id: I676d03c7e1c7bcb3b6c08e6d30aa23cf61838b38 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155831 Tested-by: Jenkins Reviewed-by: Caolán McNamara diff --git a/officecfg/registry/data/org/openoffice/Office/Accelerators.xcu b/officecfg/registry/data/org/openoffice/Office/Accelerators.xcu index a26b90b298d6..647b46927e5f 100644 --- a/officecfg/registry/data/org/openoffice/Office/Accelerators.xcu +++ b/officecfg/registry/data/org/openoffice/Office/Accelerators.xcu @@ -344,25 +344,25 @@ Ctrl+Shift+e aka E_SHIFT_MOD1 under GTK/IBUS is for some emoji thing .uno:CommandPopup - + I10N SHORTCUTS - NO TRANSLATE .uno:SidebarDeck.PropertyDeck - + I10N SHORTCUTS - NO TRANSLATE .uno:SidebarDeck.StyleListDeck - + I10N SHORTCUTS - NO TRANSLATE .uno:SidebarDeck.GalleryDeck - + I10N SHORTCUTS - NO TRANSLATE .uno:SidebarDeck.NavigatorDeck @@ -605,7 +605,7 @@ Ctrl+Shift+e aka E_SHIFT_MOD1 under GTK/IBUS is for some emoji thing - + I10N SHORTCUTS - NO TRANSLATE .uno:SidebarDeck.ScFunctionsDeck @@ -1629,7 +1629,7 @@ Ctrl+Shift+e aka E_SHIFT_MOD1 under GTK/IBUS is for some emoji thing - + I10N SHORTCUTS - NO TRANSLATE .uno:SidebarDeck.ShapesDeck @@ -2908,25 +2908,25 @@ Ctrl+Shift+e aka E_SHIFT_MOD1 under GTK/IBUS is for some emoji thing - + I10N SHORTCUTS - NO TRANSLATE .uno:SidebarDeck.ShapesDeck - + I10N SHORTCUTS - NO TRANSLATE .uno:SidebarDeck.SdSlideTransitionDeck - + I10N SHORTCUTS - NO TRANSLATE .uno:SidebarDeck.SdCustomAnimationDeck - + I10N SHORTCUTS - NO TRANSLATE .uno:SidebarDeck.SdMasterPagesDeck @@ -6010,19 +6010,19 @@ Ctrl+Shift+e aka E_SHIFT_MOD1 under GTK/IBUS is for some emoji thing .uno:Grow - + I10N SHORTCUTS - NO TRANSLATE .uno:SidebarDeck.WriterPageDeck - + I10N SHORTCUTS - NO TRANSLATE .uno:SidebarDeck.InspectorDeck - + I10N SHORTCUTS - NO TRANSLATE .uno:SidebarDeck.A11yCheckDeck
[Libreoffice-commits] core.git: include/sfx2 sfx2/source
include/sfx2/lokhelper.hxx |3 +++
sfx2/source/view/lokhelper.cxx |9 -
2 files changed, 11 insertions(+), 1 deletion(-)
New commits:
commit 560b5112f6738f02a12adec7d5be04e2411c93b9
Author: Caolán McNamara
AuthorDate: Thu Aug 17 20:22:02 2023 +0100
Commit: Caolán McNamara
CommitDate: Fri Aug 18 18:32:18 2023 +0200
add a SfxLokHelper::notifyInvalidation which can take a 'part'
no change in behaviour intended
Change-Id: I6040eafb03bcf39724761d7708540e9b25edd8f9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155813
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/include/sfx2/lokhelper.hxx b/include/sfx2/lokhelper.hxx
index b46097938695..26b222bc8aa9 100644
--- a/include/sfx2/lokhelper.hxx
+++ b/include/sfx2/lokhelper.hxx
@@ -138,6 +138,9 @@ public:
/// Emits a LOK_CALLBACK_DOCUMENT_SIZE_CHANGED for all views of the same
document with the same part
static void notifyPartSizeChangedAllViews(vcl::ITiledRenderable* pDoc, int
nPart);
/// Emits a LOK_CALLBACK_INVALIDATE_TILES, but tweaks it according to
setOptionalFeatures() if needed.
+static void notifyInvalidation(SfxViewShell const* pThisView, int nPart,
tools::Rectangle const *);
+/// Emits a LOK_CALLBACK_INVALIDATE_TILES, but tweaks it according to
setOptionalFeatures() if needed
+/// uses the Part reported by pThisView
static void notifyInvalidation(SfxViewShell const* pThisView,
tools::Rectangle const *);
/// Notifies all views with the given type and payload.
static void notifyAllViews(int nType, const OString& rPayload);
diff --git a/sfx2/source/view/lokhelper.cxx b/sfx2/source/view/lokhelper.cxx
index 5bf6e8a1a2c4..cc3920fd0f35 100644
--- a/sfx2/source/view/lokhelper.cxx
+++ b/sfx2/source/view/lokhelper.cxx
@@ -610,12 +610,19 @@ void SfxLokHelper::notifyWindow(const SfxViewShell*
pThisView,
}
void SfxLokHelper::notifyInvalidation(SfxViewShell const* pThisView,
tools::Rectangle const* pRect)
+{
+// -1 means all parts
+const int nPart = comphelper::LibreOfficeKit::isPartInInvalidation() ?
pThisView->getPart() : INT_MIN;
+SfxLokHelper::notifyInvalidation(pThisView, nPart, pRect);
+}
+
+void SfxLokHelper::notifyInvalidation(SfxViewShell const* pThisView, const int
nInPart, tools::Rectangle const* pRect)
{
if (DisableCallbacks::disabled())
return;
// -1 means all parts
-const int nPart = comphelper::LibreOfficeKit::isPartInInvalidation() ?
pThisView->getPart() : INT_MIN;
+const int nPart = comphelper::LibreOfficeKit::isPartInInvalidation() ?
nInPart : INT_MIN;
const int nMode = pThisView->getEditMode();
pThisView->libreOfficeKitViewInvalidateTilesCallback(pRect, nPart, nMode);
}
Re: Machine learning is used in gerrit build
Hello, On 09.08.2023 10:57, Baole Fang wrote: Feel free to contact me if you have any questions! Just out of curiosity, what is the overall accuracy of your model? Do you have a confusion matrix or something similar that shows the performance of your model? Thanks, Kohei
[Libreoffice-commits] core.git: sw/qa sw/source
sw/qa/extras/layout/data/linked_frames_section_bug.odt |binary
sw/qa/extras/layout/layout3.cxx| 18 +
sw/source/core/layout/sectfrm.cxx |1
3 files changed, 19 insertions(+)
New commits:
commit 987fe1175de2db53235cc6f2441335fcc3548d64
Author: Michael Stahl
AuthorDate: Fri Aug 18 16:44:16 2023 +0200
Commit: Michael Stahl
CommitDate: Fri Aug 18 18:55:57 2023 +0200
tdf#156419 sw: layout: don't prevent moving between linked flys
... when there is a page break on the next page.
Of course you can put a section into a fly, and then link multiple flys.
(regression from commit 325fe7ab507fd8f2ca17a3db32181edf30169525)
Change-Id: I5cb854fc7ee5caa2af4e04f4da2d8a8083c0d007
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155842
Tested-by: Jenkins
Reviewed-by: Michael Stahl
diff --git a/sw/qa/extras/layout/data/linked_frames_section_bug.odt
b/sw/qa/extras/layout/data/linked_frames_section_bug.odt
new file mode 100644
index ..639332ad5516
Binary files /dev/null and
b/sw/qa/extras/layout/data/linked_frames_section_bug.odt differ
diff --git a/sw/qa/extras/layout/layout3.cxx b/sw/qa/extras/layout/layout3.cxx
index 9c75ff31a322..4ddb46b025b9 100644
--- a/sw/qa/extras/layout/layout3.cxx
+++ b/sw/qa/extras/layout/layout3.cxx
@@ -1228,6 +1228,24 @@ CPPUNIT_TEST_FIXTURE(SwLayoutWriter3, testTdf156725)
"/root/page[2]/body/txt/anchored/fly/column[2]/body/section/column[2]/body/txt",
1);
}
+CPPUNIT_TEST_FIXTURE(SwLayoutWriter3, testTdf156419)
+{
+createSwDoc("linked_frames_section_bug.odt");
+
+xmlDocUniquePtr pXmlDoc = parseLayoutDump();
+assertXPath(pXmlDoc, "/root/page", 2);
+// there are 2 flys on page 1, and 1 on page 2, all linked
+assertXPath(pXmlDoc,
"/root/page[1]/body/txt/anchored/fly[1]/section/column", 2);
+assertXPath(pXmlDoc,
"/root/page[1]/body/txt/anchored/fly[1]/section/column[1]/body/txt", 11);
+assertXPath(pXmlDoc,
"/root/page[1]/body/txt/anchored/fly[1]/section/column[2]/body/txt", 11);
+assertXPath(pXmlDoc,
"/root/page[1]/body/txt/anchored/fly[2]/section/column", 2);
+assertXPath(pXmlDoc,
"/root/page[1]/body/txt/anchored/fly[2]/section/column[1]/body/txt", 12);
+assertXPath(pXmlDoc,
"/root/page[1]/body/txt/anchored/fly[2]/section/column[2]/body/txt", 12);
+assertXPath(pXmlDoc,
"/root/page[2]/body/txt/anchored/fly[1]/section/column", 2);
+assertXPath(pXmlDoc,
"/root/page[2]/body/txt/anchored/fly[1]/section/column[1]/body/txt", 2);
+assertXPath(pXmlDoc,
"/root/page[2]/body/txt/anchored/fly[1]/section/column[2]/body/txt", 1);
+}
+
CPPUNIT_TEST_FIXTURE(SwLayoutWriter3, testTdf145826)
{
createSwDoc("tdf145826.odt");
diff --git a/sw/source/core/layout/sectfrm.cxx
b/sw/source/core/layout/sectfrm.cxx
index 9023550cacd1..7afcb6b89800 100644
--- a/sw/source/core/layout/sectfrm.cxx
+++ b/sw/source/core/layout/sectfrm.cxx
@@ -1758,6 +1758,7 @@ SwLayoutFrame *SwFrame::GetNextSctLeaf( MakePageType
eMakePage )
// creating / moving the cell frame.
// It doesn't make sense to move to a page that starts with break?
if (pNxtPg != FindPageFrame() // tdf#156725 not between columns!
+&& !FindFlyFrame() // tdf#156419 linked fly frames don't care!
&& (WrongPageDesc(pNxtPg) || HasPageBreakBefore(*pNxtPg))
&& !bLayLeafTableAllowed)
{
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-23.05' - sw/CppunitTest_sw_core_text.mk sw/qa sw/source
sw/CppunitTest_sw_core_text.mk |1
sw/qa/core/text/data/floattable-leftover-para-portion.docx |binary
sw/qa/core/text/porrst.cxx | 57 +
sw/source/core/text/porrst.cxx |2
4 files changed, 59 insertions(+), 1 deletion(-)
New commits:
commit 352bcab5bc59ef3e0042328503c6535e28dce931
Author: Miklos Vajna
AuthorDate: Wed Aug 16 09:34:49 2023 +0200
Commit: Caolán McNamara
CommitDate: Fri Aug 18 15:40:52 2023 +0200
tdf#156682 sw floattable: fix missing del of master anchor para por on split
Pressing "enter" at the end of B1 in the bugdoc resulted in a split
floating table, which had the anchor text duplicated (both on page 1 and
page2).
What happened is that the master anchor frame didn't have its paragraph
portion cleared, the follow anchor frame had a correct frame offset (of
0).
Fix the problem in SwTextFrame::FormatEmpty(), similar to what commit
00b9b4791079c2dc26b1ed4c123450cabf7d (sw: call FormatEmpty() in
SwTextFrame::Format() for split fly masters, 2023-02-09), did; here what
we want to avoid is setting some properties on the paragraph preventing
the deletion of non-last anchor paragraph portions.
As a side effect, this also fixes the hang from the bugreport, after
pressing "enter" 5 times at the end of B1.
(cherry picked from commit 1cf29168840f84c2e946e2678b99988e83503c96)
Change-Id: I16e6d786f02ad503a0fdff465ecf7716c1c5f8b7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155837
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Caolán McNamara
diff --git a/sw/CppunitTest_sw_core_text.mk b/sw/CppunitTest_sw_core_text.mk
index 477e25b91612..37b2fa566094 100644
--- a/sw/CppunitTest_sw_core_text.mk
+++ b/sw/CppunitTest_sw_core_text.mk
@@ -17,6 +17,7 @@ $(eval $(call
gb_CppunitTest_add_exception_objects,sw_core_text, \
sw/qa/core/text/frmform \
sw/qa/core/text/itratr \
sw/qa/core/text/itrform2 \
+sw/qa/core/text/porrst \
sw/qa/core/text/text \
))
diff --git a/sw/qa/core/text/data/floattable-leftover-para-portion.docx
b/sw/qa/core/text/data/floattable-leftover-para-portion.docx
new file mode 100644
index ..51eee56cf003
Binary files /dev/null and
b/sw/qa/core/text/data/floattable-leftover-para-portion.docx differ
diff --git a/sw/qa/core/text/porrst.cxx b/sw/qa/core/text/porrst.cxx
new file mode 100644
index ..1c343dc0d9f2
--- /dev/null
+++ b/sw/qa/core/text/porrst.cxx
@@ -0,0 +1,57 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#include
+
+#include
+
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+
+namespace
+{
+/// Covers sw/source/core/text/porrst.cxx fixes.
+class Test : public SwModelTestBase
+{
+public:
+Test()
+: SwModelTestBase("/sw/qa/core/text/data/")
+{
+}
+};
+
+CPPUNIT_TEST_FIXTURE(Test, testFloattableLeftoverParaPortion)
+{
+// Given a document with a multi-page floating table, the anchor of the
table has some text:
+createSwDoc("floattable-leftover-para-portion.docx");
+
+// When laying out that document:
+calcLayout();
+
+// Then make sure all anchor text goes to the second page:
+SwDoc* pDoc = getSwDoc();
+SwRootFrame* pLayout = pDoc->getIDocumentLayoutAccess().GetCurrentLayout();
+auto pPage = dynamic_cast(pLayout->Lower());
+CPPUNIT_ASSERT(pPage);
+SwFrame* pBody = pPage->FindBodyCont();
+SwFrame* pPara1 = pBody->GetLower();
+auto pPara2 = pPara1->GetNext()->DynCastTextFrame();
+CPPUNIT_ASSERT(pPara2);
+// Without the accompanying fix in place, this test would have failed, the
first page's anchor
+// also had some (duplicated) anchor text.
+CPPUNIT_ASSERT(!pPara2->GetPara());
+}
+}
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sw/source/core/text/porrst.cxx b/sw/source/core/text/porrst.cxx
index 4bdc0fa40f77..9c04fc0458c6 100644
--- a/sw/source/core/text/porrst.cxx
+++ b/sw/source/core/text/porrst.cxx
@@ -413,7 +413,7 @@ bool SwTextFrame::FormatEmpty()
// Split fly frames: non-last parts of the anchor want this optimization
to clear the old
// content.
bool bHasNonLastSplitFlyDrawObj = HasNonLastSplitFlyDrawObj();
-if ((HasFollow() && !bHasNonLastSplitFlyDrawObj) || GetMergedPara() ||
GetTextNodeFirst()->GetpSwpHints() ||
+if ((HasFollow() && !bHasNonLastSplitFlyDrawObj) || GetMergedPara() ||
(GetTextNodeFirst()->GetpSwpHints() && !bHasNonLastSplitFlyDrawObj) ||
nullptr != GetTextNodeForParaProps()->GetNumRule() ||
Cool! LibreOffice is free, open source and very good office suite!
Subject: Cool! LibreOffice is free, open source and very good office suite! Good day from Singapore, I have problems with both of my Microsoft Office Home and Business 2019 licenses. So I had installed a trial version of Microsoft Office on my refurbished Aftershock gaming laptop but it expired on 11 Aug 2023. I couldn't use it any more. I needed an office suite but I do not want to spend SGD$300++ purchasing Microsoft Office licenses. Then I thought of LibreOffice. I quickly downloaded and installed LibreOffice 7.5.5.2. With LibreOffice installed, I used LibreOffice Calc to edit and save my Excel worksheet. When I opened the edited Excel worksheet using Microsoft Excel on my Samsung Galaxy A32 5G Android phone, the Excel worksheet didn't look significantly different. In fact, the Excel worksheet edited by LibreOffice Calc looks the same as if it had been edited by Microsoft Excel. I have decided to uninstall the trial version of Microsoft Office Home and Business 2019 (as it doesn't work anymore) and use LibreOffice permanently! By the way, does LibreOffice have the equivalent of Microsoft Outlook? Thank you LibreOffice development team! Regards, Mr. Turritopsis Dohrnii Teo En Ming Targeted Individual in Singapore Blogs: https://tdtemcerts.blogspot.com https://tdtemcerts.wordpress.com GIMP also stands for Government-Induced Medical Problems.
[Libreoffice-commits] core.git: Branch 'feature/cib_contract57d' - sw/qa sw/source
sw/qa/extras/layout/data/tdf156725.fodt | 163
sw/qa/extras/layout/layout.cxx | 21
sw/source/core/layout/sectfrm.cxx |4
3 files changed, 187 insertions(+), 1 deletion(-)
New commits:
commit 807c2254ccd1a02e7af5a944f52948ef343ad384
Author: Michael Stahl
AuthorDate: Thu Aug 17 18:32:35 2023 +0200
Commit: Michael Stahl
CommitDate: Fri Aug 18 15:47:59 2023 +0200
tdf#156725 sw: layout: don't prevent moving between columns ...
... on the same page when there is a page break on the next page.
The existing, presumably pointless/always-false in case of same page,
check of WrongPageDesc() let me assume that this would only be reached
if the current page and the target page are different, but that was a
mistake.
(regression from commit 325fe7ab507fd8f2ca17a3db32181edf30169525)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155809
Tested-by: Jenkins
Reviewed-by: Michael Stahl
(cherry picked from commit db83c41d460103df5d80f5bd99816575c4ead5cd)
Change-Id: I4df53b77bed006095c34976011aa0cd5e12879e7
diff --git a/sw/qa/extras/layout/data/tdf156725.fodt
b/sw/qa/extras/layout/data/tdf156725.fodt
new file mode 100644
index ..9f60e7011954
--- /dev/null
+++ b/sw/qa/extras/layout/data/tdf156725.fodt
@@ -0,0 +1,163 @@
+
+http://www.w3.org/TR/css3-text/;
xmlns:grddl="http://www.w3.org/2003/g/data-view#;
xmlns:xhtml="http://www.w3.org/1999/xhtml;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
xmlns:xsd="http://www.w3.org/2001/XMLSchema;
xmlns:xforms="http://www.w3.org/2002/xforms;
xmlns:dom="http://www.w3.org/2001/xml-events;
xmlns:script="urn:oasis:names:tc:opendocument:xmlns:script:1.0"
xmlns:form="urn:oasis:names:tc:opendocument:xmlns:form:1.0"
xmlns:math="http://www.w3.org/1998/Math/MathML;
xmlns:office="urn:oasis:names:tc:opendocument:xmlns:office:1.0"
xmlns:ooo="http://openoffice.org/2004/office;
xmlns:fo="urn:oasis:names:tc:opendocument:xmlns:xsl-fo-compatible:1.0"
xmlns:config="urn:oasis:names:tc:opendocument:xmlns:config:1.0"
xmlns:ooow="http://openoffice.org/2004/writer;
xmlns:xlink="http://www.w3.org/1999/xlink;
xmlns:drawooo="http://openoffice.org/2010/draw;
xmlns:oooc="http://openoffice.org/2004/calc;
xmlns:dc="http://purl.org/dc/elements/1.1/; xmlns:c
alcext="urn:org:documentfoundation:names:experimental:calc:xmlns:calcext:1.0"
xmlns:style="urn:oasis:names:tc:opendocument:xmlns:style:1.0"
xmlns:text="urn:oasis:names:tc:opendocument:xmlns:text:1.0"
xmlns:of="urn:oasis:names:tc:opendocument:xmlns:of:1.2"
xmlns:tableooo="http://openoffice.org/2009/table;
xmlns:draw="urn:oasis:names:tc:opendocument:xmlns:drawing:1.0"
xmlns:dr3d="urn:oasis:names:tc:opendocument:xmlns:dr3d:1.0"
xmlns:rpt="http://openoffice.org/2005/report;
xmlns:formx="urn:openoffice:names:experimental:ooxml-odf-interop:xmlns:form:1.0"
xmlns:svg="urn:oasis:names:tc:opendocument:xmlns:svg-compatible:1.0"
xmlns:chart="urn:oasis:names:tc:opendocument:xmlns:chart:1.0"
xmlns:officeooo="http://openoffice.org/2009/office;
xmlns:table="urn:oasis:names:tc:opendocument:xmlns:table:1.0"
xmlns:field="urn:openoffice:names:experimental:ooo-ms-interop:xmlns:field:1.0"
xmlns:number="urn:oasis:names:tc:opendocument:xmlns:datastyle:1.0"
xmlns:meta="urn:oasis:names:tc:opendocument:xmlns:
meta:1.0"
xmlns:loext="urn:org:documentfoundation:names:experimental:office:xmlns:loext:1.0"
office:version="1.3" office:mimetype="application/vnd.oasis.opendocument.text">
+
2023-08-17T18:14:28.1153022102023-08-17T18:20:06.109127302PT4M30S2LibreOfficeDev/24.2.0.0.alpha0$Linux_X86_64
LibreOffice_project/79452241ad33f9eaace2ba8bd1336be69c99ed4d
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+ a
+ b
+ c
+ d
+
+
+
+
+
+
\ No newline at end of file
diff --git a/sw/qa/extras/layout/layout.cxx b/sw/qa/extras/layout/layout.cxx
index f72715fcba43..def657eec623 100644
--- a/sw/qa/extras/layout/layout.cxx
+++ b/sw/qa/extras/layout/layout.cxx
@@ -3672,6 +3672,27 @@ CPPUNIT_TEST_FIXTURE(SwLayoutWriter, testTdf156724)
assertXPath(pXmlDoc, "/root/page", 2);
}
+CPPUNIT_TEST_FIXTURE(SwLayoutWriter, testTdf156725)
+{
+
[Libreoffice-commits] core.git: filter/source
filter/source/svg/svgwriter.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 30febe5fc4ac3117ff5dabcd1fec4acfc7b759d8
Author: Caolán McNamara
AuthorDate: Wed Aug 16 15:04:58 2023 +0100
Commit: Caolán McNamara
CommitDate: Fri Aug 18 18:24:04 2023 +0200
cool#6616 compare graphics for equality with operator==...
instead of checking equal CheckSums.
For better or worse while Bitmap::operator== also considers equal
CheckSums as equal Bitmaps operator== can quickly return true if
both Bitmaps share the same underlying SalBitmap which is nearly
always true in the example here
Change-Id: I6b5cd484aeef7505721a493a3bff23ee345147dc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155740
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/filter/source/svg/svgwriter.cxx b/filter/source/svg/svgwriter.cxx
index 4f21f0493b06..62aa05115fbb 100644
--- a/filter/source/svg/svgwriter.cxx
+++ b/filter/source/svg/svgwriter.cxx
@@ -2916,7 +2916,7 @@ void SVGActionWriter::ImplWriteBmp( const BitmapEx&
rBmpEx,
if (aGraphic.GetType() == GraphicType::Bitmap)
{
const BitmapEx& rGraphicBitmap = aGraphic.GetBitmapExRef();
-if (rGraphicBitmap.GetChecksum() == rBmpEx.GetChecksum())
+if (rGraphicBitmap == rBmpEx)
{
bool bPNG = false;
GfxLink aGfxLink = aGraphic.GetGfxLink();
[Libreoffice-commits] core.git: 2 commits - desktop/source include/ucbhelper ucbhelper/source ucb/source
desktop/source/app/crashreport.cxx |6 ++---
include/ucbhelper/proxydecider.hxx |6 ++---
ucb/source/ucp/cmis/cmis_content.cxx |5
ucb/source/ucp/cmis/cmis_repo_content.cxx |5
ucb/source/ucp/webdav-curl/CurlSession.cxx | 34 +++--
ucb/source/ucp/webdav-curl/CurlSession.hxx |4 +--
ucbhelper/source/client/proxydecider.cxx | 17 ++
7 files changed, 40 insertions(+), 37 deletions(-)
New commits:
commit f88af95552f9b46e1714964d84c447327b50ed40
Author: Michael Stahl
AuthorDate: Fri Aug 18 15:09:43 2023 +0200
Commit: Noel Grandin
CommitDate: Fri Aug 18 18:33:27 2023 +0200
ucbhelper,ucb,desktop: InternetProxyServer is problematic
It turns out that every single client of InternetProxyDecider simply
concatenates the 2 members of InternetProxyServer into a single string
and passes it on to curl_easy_setopt(CURLOPT_PROXY), which will happily
take a URL including scheme and everything.
It turns out that the awful GetUnixSystemProxy() tries to cut off the
scheme in a terrible way, but GetPACProxy() does no such thing and
WINHTTP_PROXY_INFO::lpszProxy may or may not contain scheme in its
entries; fix this to only separate the port and leave the rest alone.
So why do we need a InternetProxyServer struct? Because officecfg has
separate entries that correspond to its members, and so
InternetProxyDecider gets separate events on its listener interface when
any of them changes, which is easiest to handle if it stores these
separately.
So just return a concatenated URL with or without scheme in getProxy().
Change-Id: I43c696471c8bec90667b5930fa00975adb432fe1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155840
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/desktop/source/app/crashreport.cxx
b/desktop/source/app/crashreport.cxx
index 59a2aa771b32..680492b3b80a 100644
--- a/desktop/source/app/crashreport.cxx
+++ b/desktop/source/app/crashreport.cxx
@@ -139,7 +139,7 @@ void CrashReporter::writeCommonInfo()
static constexpr OUStringLiteral url = u"crashreport.libreoffice.org";
const sal_Int32 port = 443;
-const ucbhelper::InternetProxyServer proxy_server =
proxy_decider.getProxy(protocol, url, port);
+const OUString proxy_server = proxy_decider.getProxy(protocol, url, port);
// save the new Keys
vmaKeyValues atlast = maKeyValues;
@@ -152,9 +152,9 @@ void CrashReporter::writeCommonInfo()
addKeyValue("BuildID", utl::Bootstrap::getBuildIdData(""), AddItem);
addKeyValue("URL", protocol + "://" + url + "/submit/", AddItem);
-if (!proxy_server.aName.isEmpty())
+if (!proxy_server.isEmpty())
{
-addKeyValue("Proxy", proxy_server.aName + ":" +
OUString::number(proxy_server.nPort), AddItem);
+addKeyValue("Proxy", proxy_server, AddItem);
}
// write the new keys at the end
diff --git a/include/ucbhelper/proxydecider.hxx
b/include/ucbhelper/proxydecider.hxx
index 9a1abad3264a..3fe3025833ce 100644
--- a/include/ucbhelper/proxydecider.hxx
+++ b/include/ucbhelper/proxydecider.hxx
@@ -116,10 +116,10 @@ public:
* If host is not empty this parameter must always contain a valid
* port number, for instance the default port for the requested
* protocol(i.e. 80 or http).
- * @return a InternetProxyServer struct. If member aName of the
- * InternetProxyServer is empty no proxy server is to be used.
+ * @return an URL, with or without scheme.
+ * If empty no proxy server is to be used.
*/
-InternetProxyServer
+OUString
getProxy( const OUString & rProtocol,
const OUString & rHost,
sal_Int32 nPort ) const;
diff --git a/ucb/source/ucp/cmis/cmis_content.cxx
b/ucb/source/ucp/cmis/cmis_content.cxx
index 815d89502f2c..b5ad2cb738ce 100644
--- a/ucb/source/ucp/cmis/cmis_content.cxx
+++ b/ucb/source/ucp/cmis/cmis_content.cxx
@@ -304,11 +304,8 @@ namespace cmis
// Set the proxy if needed. We are doing that all times as the proxy
data shouldn't be cached.
ucbhelper::InternetProxyDecider aProxyDecider( m_xContext );
INetURLObject aBindingUrl( m_aURL.getBindingUrl( ) );
-const ucbhelper::InternetProxyServer& rProxy = aProxyDecider.getProxy(
+const OUString sProxy = aProxyDecider.getProxy(
INetURLObject::GetScheme( aBindingUrl.GetProtocol( ) ),
aBindingUrl.GetHost(), aBindingUrl.GetPort() );
-OUString sProxy = rProxy.aName;
-if ( rProxy.nPort > 0 )
-sProxy += ":" + OUString::number( rProxy.nPort );
libcmis::SessionFactory::setProxySettings( OUSTR_TO_STDSTR( sProxy ),
std::string(), std::string(), std::string() );
// Look for a cached session, key is binding url + repo id
diff --git
[Libreoffice-commits] core.git: sc/source
sc/source/ui/inc/gridwin.hxx |2 ++
sc/source/ui/view/gridwin4.cxx | 10 --
2 files changed, 10 insertions(+), 2 deletions(-)
New commits:
commit 28d41e60416ef10ae2a59d1c4ad34a2eb75dc408
Author: Caolán McNamara
AuthorDate: Thu Aug 17 20:31:55 2023 +0100
Commit: Caolán McNamara
CommitDate: Fri Aug 18 18:32:56 2023 +0200
add a LogicInvalidatePart which can take a 'part'
no change in behaviour intended
Change-Id: Idee6615cc86cd01bea9aaf17fff2840eea6521a0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155814
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/sc/source/ui/inc/gridwin.hxx b/sc/source/ui/inc/gridwin.hxx
index ddc9815c2052..979767c6801b 100644
--- a/sc/source/ui/inc/gridwin.hxx
+++ b/sc/source/ui/inc/gridwin.hxx
@@ -320,6 +320,8 @@ class SAL_DLLPUBLIC_RTTI ScGridWindow : public
vcl::DocWindow, public DropTarget
voidSetupInitialPageBreaks(const ScDocument& rDoc, SCTAB nTab);
DECL_DLLPRIVATE_LINK(InitiatePageBreaksTimer, Timer*, void);
+voidLogicInvalidatePart(const tools::Rectangle* pRectangle,
int nPart);
+
protected:
virtual voidPrePaint(vcl::RenderContext& rRenderContext) override;
virtual voidPaint(vcl::RenderContext& rRenderContext, const
tools::Rectangle& rRect) override;
diff --git a/sc/source/ui/view/gridwin4.cxx b/sc/source/ui/view/gridwin4.cxx
index bc2521531a37..a86902d57944 100644
--- a/sc/source/ui/view/gridwin4.cxx
+++ b/sc/source/ui/view/gridwin4.cxx
@@ -1727,7 +1727,7 @@ void ScGridWindow::PaintTile( VirtualDevice& rDevice,
}
}
-void ScGridWindow::LogicInvalidate(const tools::Rectangle* pRectangle)
+void ScGridWindow::LogicInvalidatePart(const tools::Rectangle* pRectangle, int
nPart)
{
tools::Rectangle aRectangle;
tools::Rectangle* pResultRectangle;
@@ -1759,7 +1759,13 @@ void ScGridWindow::LogicInvalidate(const
tools::Rectangle* pRectangle)
}
ScTabViewShell* pViewShell = mrViewData.GetViewShell();
-SfxLokHelper::notifyInvalidation(pViewShell, pResultRectangle);
+SfxLokHelper::notifyInvalidation(pViewShell, nPart, pResultRectangle);
+}
+
+void ScGridWindow::LogicInvalidate(const tools::Rectangle* pRectangle)
+{
+ScTabViewShell* pViewShell = mrViewData.GetViewShell();
+LogicInvalidatePart(pRectangle, pViewShell->getPart());
}
void ScGridWindow::SetCellSelectionPixel(int nType, int nPixelX, int nPixelY)
[Libreoffice-commits] core.git: uui/source
uui/source/iahndl.cxx | 13 ++---
1 file changed, 10 insertions(+), 3 deletions(-)
New commits:
commit 40b2464bf346f1aeda44f719a301e2e60f4d0fd0
Author: Noel Grandin
AuthorDate: Thu Aug 17 14:06:23 2023 +0200
Commit: Noel Grandin
CommitDate: Fri Aug 18 18:34:13 2023 +0200
ignore exception in UUIInteractionHelper::handlerequest
otherwise I sometimes get a crash during
make UITest_sw_options
when an exception in configmgr goes up the stack and hits
the noexcept lamba in the vcl/
stuff that executes Application::PostUserEvent stuff
#1 in configmgr::RootAccess::getNode()
#2 in configmgr::Access::isValue()
#3 in configmgr::configuration_provider::(anonymous
namespace)::Service::createInstanceWithArguments
#4 in non-virtual thunk to configmgr::configuration_provider::(anonymous
namespace)::Service::createInstanceWithArguments
#5 in UUIInteractionHelper::getInteractionHandlerList
#6 in UUIInteractionHelper::tryOtherInteractionHandler
#6 in UUIInteractionHelper::handleRequest_impl
#7 in UUIInteractionHelper::handlerequest
Change-Id: Id90b4d27d3886984c64acdfee98d9c4696c3c03f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155766
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/uui/source/iahndl.cxx b/uui/source/iahndl.cxx
index dfa3b96742d6..b6e88bcd3e40 100644
--- a/uui/source/iahndl.cxx
+++ b/uui/source/iahndl.cxx
@@ -141,9 +141,16 @@ void UUIInteractionHelper::handlerequest(
= static_cast< UUIInteractionHelper * >(pInteractionHelper);
bool bDummy = false;
OUString aDummy;
-pHND->bHandled
-= pUUI->handleRequest_impl(pHND->m_rRequest, false, bDummy, aDummy);
-pHND->set();
+try
+{
+pHND->bHandled
+= pUUI->handleRequest_impl(pHND->m_rRequest, false, bDummy,
aDummy);
+pHND->set();
+}
+catch (css::uno::Exception&)
+{
+TOOLS_WARN_EXCEPTION("uui", "");
+}
}
bool
[Libreoffice-commits] core.git: connectivity/source
connectivity/source/parse/sqlbison.y |2 ++
connectivity/source/parse/sqlflex.l |1 +
2 files changed, 3 insertions(+)
New commits:
commit ccf30787a701860d19941a1d36ad3d1db2fb2e06
Author: jucasaca
AuthorDate: Sun Jul 30 19:20:29 2023 +0200
Commit: Julien Nabet
CommitDate: Fri Aug 18 08:23:18 2023 +0200
tdf#156534 Add Firebird's DATEADD function to SQL parser
Add DATEADD function to SQL parser, so the function can be used in
Query's Design and can produce editable queries
Change-Id: I14f9d88f6a96021b0f9199fd79df18c8f4bb5ea3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155071
Tested-by: Jenkins
Reviewed-by: Julien Nabet
diff --git a/connectivity/source/parse/sqlbison.y
b/connectivity/source/parse/sqlbison.y
index fe3b32b79ef6..00666ed87a09 100644
--- a/connectivity/source/parse/sqlbison.y
+++ b/connectivity/source/parse/sqlbison.y
@@ -156,6 +156,7 @@ using namespace connectivity;
%token SQL_TOKEN_DAYNAME SQL_TOKEN_DAYOFMONTH
SQL_TOKEN_DAYOFWEEK SQL_TOKEN_DAYOFYEAR SQL_TOKEN_EXTRACT
%token SQL_TOKEN_HOUR SQL_TOKEN_MILLISECOND SQL_TOKEN_MINUTE
SQL_TOKEN_MONTH SQL_TOKEN_MONTHNAME SQL_TOKEN_NOW SQL_TOKEN_QUARTER
SQL_TOKEN_DATEDIFF
%token SQL_TOKEN_SECOND SQL_TOKEN_TIMESTAMPADD
SQL_TOKEN_TIMESTAMPDIFF SQL_TOKEN_TIMEVALUE SQL_TOKEN_WEEK SQL_TOKEN_WEEKDAY
SQL_TOKEN_YEAR SQL_TOKEN_YEARDAY
+%token SQL_TOKEN_DATEADD
/* numeric functions */
%token SQL_TOKEN_ABS SQL_TOKEN_ACOS SQL_TOKEN_ASIN SQL_TOKEN_ATAN
SQL_TOKEN_ATAN2 SQL_TOKEN_CEILING
@@ -1978,6 +1979,7 @@ date_function_1Argument:
date_function:
SQL_TOKEN_TIMESTAMPADD
| SQL_TOKEN_TIMESTAMPDIFF
+ | SQL_TOKEN_DATEADD
;
numeric_function_0Argument:
SQL_TOKEN_PI
diff --git a/connectivity/source/parse/sqlflex.l
b/connectivity/source/parse/sqlflex.l
index 34a4067ea21c..44daeb236bf7 100644
--- a/connectivity/source/parse/sqlflex.l
+++ b/connectivity/source/parse/sqlflex.l
@@ -186,6 +186,7 @@ CURSOR {SQL_NEW_KEYWORD(SQL_TOKEN_CURSOR); }
D {SQL_NEW_KEYWORD(SQL_TOKEN_D); }
DATE{SQL_NEW_KEYWORD(SQL_TOKEN_DATE); }
+DATEADD {SQL_NEW_KEYWORD(SQL_TOKEN_DATEADD); }
DATEDIFF{SQL_NEW_KEYWORD(SQL_TOKEN_DATEDIFF); }
DATEVALUE {SQL_NEW_KEYWORD(SQL_TOKEN_DATEVALUE); }
DAY {SQL_NEW_KEYWORD(SQL_TOKEN_DAY); }
[Libreoffice-commits] core.git: basic/source comphelper/source embedserv/source oox/source scripting/source sc/source sdext/source sd/source sfx2/source sot/source svtools/source svx/source sw/source
basic/source/classes/sbxmod.cxx |4
comphelper/source/container/embeddedobjectcontainer.cxx |6 -
comphelper/source/misc/instancelocker.cxx |7 -
comphelper/source/misc/storagehelper.cxx|4
embedserv/source/embed/docholder.cxx| 31 ---
oox/source/drawingml/chart/converterbase.cxx|8 -
oox/source/ole/oleobjecthelper.cxx |8 -
oox/source/ole/vbamodule.cxx|8 -
sc/source/filter/excel/xichart.cxx | 13 ---
sc/source/filter/ftools/fapihelper.cxx |4
sc/source/filter/oox/numberformatsbuffer.cxx|8 -
sc/source/filter/oox/pivotcachebuffer.cxx |8 -
sc/source/filter/oox/pivottablebuffer.cxx |8 -
sc/source/filter/oox/worksheethelper.cxx|9 --
sc/source/filter/xml/xmlwrap.cxx| 11 +-
sc/source/ui/docshell/docsh.cxx |8 -
sc/source/ui/docshell/docsh4.cxx|8 -
sc/source/ui/vba/vbaeventshelper.cxx| 16 ---
scripting/source/vbaevents/eventhelper.cxx |9 --
sd/source/console/PresenterHelper.cxx | 15 ---
sd/source/console/PresenterScreen.cxx |4
sd/source/console/PresenterSlideShowView.cxx|4
sd/source/core/stlsheet.cxx |6 -
sd/source/filter/eppt/epptso.cxx|8 -
sd/source/ui/annotations/annotationmanager.cxx | 22 -
sd/source/ui/slideshow/slideshowviewimpl.cxx|7 -
sdext/source/minimizer/impoptimizer.cxx | 18 ++--
sdext/source/minimizer/optimizationstats.cxx|6 -
sfx2/source/dialog/filedlghelper.cxx|7 -
sfx2/source/doc/objmisc.cxx |4
sfx2/source/doc/objstor.cxx | 66 +---
sot/source/unoolestorage/xolesimplestorage.cxx |7 -
svtools/source/misc/bindablecontrolhelper.cxx |6 -
svx/source/smarttags/SmartTagMgr.cxx| 26 +-
svx/source/tbxctrls/tbcontrl.cxx|8 -
svx/source/xml/xmlxtimp.cxx |8 -
sw/source/core/ole/ndole.cxx| 10 +-
sw/source/core/swg/SwXMLTextBlocks.cxx |8 +
sw/source/core/unocore/unochart.cxx |9 --
sw/source/filter/xml/wrtxml.cxx |5 -
toolkit/source/controls/grid/gridcontrol.cxx|9 --
toolkit/source/hatchwindow/documentcloser.cxx |9 --
unotools/source/config/confignode.cxx |9 --
unotools/source/config/lingucfg.cxx |8 +
unotools/source/config/useroptions.cxx |8 -
vbahelper/source/msforms/vbauserform.cxx|6 -
vbahelper/source/vbahelper/vbacolorformat.cxx |8 -
vbahelper/source/vbahelper/vbadocumentbase.cxx | 13 ---
vbahelper/source/vbahelper/vbadocumentsbase.cxx | 31 +++
writerfilter/source/dmapper/DomainMapper_Impl.cxx |6 -
writerfilter/source/dmapper/ModelEventListener.cxx | 10 --
writerfilter/source/dmapper/OLEHandler.cxx |4
xmloff/source/chart/SchXMLTableContext.cxx |8 +
xmloff/source/core/XMLEmbeddedObjectImportContext.cxx | 14 ---
54 files changed, 167 insertions(+), 408 deletions(-)
New commits:
commit 7fc6063914432d58d86cfcbd728d967e7c86ebfd
Author: Noel Grandin
AuthorDate: Thu Aug 17 15:42:01 2023 +0200
Commit: Noel Grandin
CommitDate: Fri Aug 18 11:03:02 2023 +0200
use more Reference::query instead of UNO_QUERY_THROW
since querying with exceptions is consideably more expensive
Change-Id: I968a9a40766b2abb0d3058549b0ed44011fd5716
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155791
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/basic/source/classes/sbxmod.cxx b/basic/source/classes/sbxmod.cxx
index 15e4719569ba..020f3814ec8c 100644
--- a/basic/source/classes/sbxmod.cxx
+++ b/basic/source/classes/sbxmod.cxx
@@ -395,8 +395,8 @@ static uno::Reference< vba::XVBACompatibility >
getVBACompatibility( const uno::
uno::Reference< vba::XVBACompatibility > xVBACompat;
try
{
-uno::Reference< beans::XPropertySet > xModelProps( rxModel,
uno::UNO_QUERY_THROW );
-xVBACompat.set( xModelProps->getPropertyValue( "BasicLibraries" ),
uno::UNO_QUERY );
+if (auto xModelProps = rxModel.query() )
+xVBACompat.set( xModelProps->getPropertyValue( "BasicLibraries" ),
uno::UNO_QUERY );
}
catch(const uno::Exception& )
{
diff --git
Re: Building Doxygen documentation
On 17 Aug 2023, at 17:42, Michael Stahl wrote: > > On 17/08/2023 18:12, Chris Tapp wrote: >> I am trying to build the doxygen documentation using: >> make odk >> as instructed on https://wiki.documentfoundation.org/Development/Doxygen > > this wiki page is very confused. > > almost everything of it is about documenting *internal* LO code with doxygen, > except for the "Building" section, which is about building the *public* API > documentation with doxygen - 2 different things! > > the internal LO code documentation can be built with "make docs". Thanks, that gets me a bit further - I am now told that "You need the graphviz tools to create the nice inheritance graphs”. How do I install it into the LODE build environment? > >> However, the following is reported: >> *** Executable unoapploader must be registered in Repository.mk or >> RepositoryExternal.mk. Stop. >> What do I need to add to these files to fix this? > > the problem is, you can't just build a single module (odk is a top-level > directory aka module) without having a complete build of everything first > (just "make"). > > note that "docs" is not a module, but just a target in the top-level > makefile, so you should be able run that one without building LO (just from > memory, i haven't done this in ages). I should have mentioned that I have already run a complete build. Chris
[Libreoffice-commits] core.git: Branch 'libreoffice-7-6' - sw/qa sw/source
sw/qa/uitest/writer_tests7/tdf156783.py | 63
sw/source/core/crsr/crsrsh.cxx |2 -
2 files changed, 64 insertions(+), 1 deletion(-)
New commits:
commit 2748138cb5c1ad03ef794f8411e28e02de608f39
Author: László Németh
AuthorDate: Wed Aug 16 21:41:26 2023 +0200
Commit: László Németh
CommitDate: Fri Aug 18 11:27:39 2023 +0200
tdf#156783 sw tracked table column: fix crash setting border
or border padding without correct table cursor.
Table formatting is allowed on text selections starting
with tables, but adding border or border padding
resulted crashing. This regression became more visible
with hidden deleted table columns, where SelectTable
(e.g. Ctrl-A) doesn't select the whole table, but only
the text content of the visible cells, and in the case
of hidden right table columns, without table cursor.
Manual test: insert two tables in the document, and in the
first cell of the first table, select the whole document
by pressing Ctrl-A 2 times or more. In table settings,
enable table border or modify padding to crash LibreOffice.
Regression since version 7.5.
Change-Id: If8ebb52c7662ff37ac42348c8f412549b793b6d9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155749
Tested-by: Jenkins
Reviewed-by: László Németh
(cherry picked from commit 3a2d3926bbaf6907a50b595d867d7e36cc4ffeaa)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155773
diff --git a/sw/qa/uitest/writer_tests7/tdf156783.py
b/sw/qa/uitest/writer_tests7/tdf156783.py
new file mode 100644
index ..2ccdb7dcf6e1
--- /dev/null
+++ b/sw/qa/uitest/writer_tests7/tdf156783.py
@@ -0,0 +1,63 @@
+# -*- tab-width: 4; indent-tabs-mode: nil; py-indent-offset: 4 -*-
+#
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+from uitest.framework import UITestCase
+from uitest.uihelper.common import get_state_as_dict
+from libreoffice.uno.propertyvalue import mkPropertyValues
+from uitest.uihelper.common import select_pos
+from uitest.uihelper.common import get_url_for_data_file
+
+# Bug 156783 - crash fix: setting table border on a table without correct
table cursor
+
+class tdf156783(UITestCase):
+def test_tdf156783(self):
+with
self.ui_test.load_file(get_url_for_data_file("TC-table-del-add.docx")) as
self.document:
+
+xToolkit =
self.xContext.ServiceManager.createInstance('com.sun.star.awt.Toolkit')
+
+# accept all tracked changes
+self.xUITest.executeCommand(".uno:AcceptAllTrackedChanges")
+
+# select all tables
+self.xUITest.executeCommand(".uno:SelectAll")
+self.xUITest.executeCommand(".uno:SelectAll")
+self.xUITest.executeCommand(".uno:SelectAll")
+
+# dialog Table Properties - Borders
+with
self.ui_test.execute_dialog_through_command(".uno:TableDialog",
close_button="ok") as xDialog:
+tabcontrol = xDialog.getChild("tabcontrol")
+select_pos(tabcontrol, "3")
+
+sync = xDialog.getChild("sync")
+rightmf = xDialog.getChild("rightmf")
+leftmf = xDialog.getChild("leftmf")
+topmf = xDialog.getChild("topmf")
+bottommf = xDialog.getChild("bottommf")
+sync.executeAction("CLICK", tuple())
+
+rightmf.executeAction("TYPE",
mkPropertyValues({"KEYCODE":"CTRL+A"}))
+rightmf.executeAction("TYPE",
mkPropertyValues({"KEYCODE":"BACKSPACE"}))
+rightmf.executeAction("TYPE",
mkPropertyValues({"TEXT":"72pt"}))
+leftmf.executeAction("TYPE",
mkPropertyValues({"KEYCODE":"CTRL+A"}))
+leftmf.executeAction("TYPE",
mkPropertyValues({"KEYCODE":"BACKSPACE"}))
+leftmf.executeAction("TYPE", mkPropertyValues({"TEXT":"72pt"}))
+topmf.executeAction("TYPE",
mkPropertyValues({"KEYCODE":"CTRL+A"}))
+topmf.executeAction("TYPE",
mkPropertyValues({"KEYCODE":"BACKSPACE"}))
+topmf.executeAction("TYPE", mkPropertyValues({"TEXT":"72pt"}))
+bottommf.executeAction("TYPE",
mkPropertyValues({"KEYCODE":"CTRL+A"}))
+bottommf.executeAction("TYPE",
mkPropertyValues({"KEYCODE":"BACKSPACE"}))
+bottommf.executeAction("TYPE",
mkPropertyValues({"TEXT":"72pt"}))
+
+self.assertEqual(get_state_as_dict(rightmf)["Text"], u"72pt")
+self.assertEqual(get_state_as_dict(leftmf)["Text"], u"72pt")
+self.assertEqual(get_state_as_dict(topmf)["Text"], u"72pt")
+self.assertEqual(get_state_as_dict(bottommf)["Text"], u"72pt")
+
+#
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-23.05' - vcl/source
vcl/source/graphic/BinaryDataContainer.cxx |1 -
1 file changed, 1 deletion(-)
New commits:
commit 934d43c0834da5ee04cc7362941b8e63e44e635c
Author: Caolán McNamara
AuthorDate: Wed Aug 16 16:31:54 2023 +0100
Commit: Miklos Vajna
CommitDate: Fri Aug 18 08:22:47 2023 +0200
SAL_DEBUG "is never meant to remain in the code"
Change-Id: I8c0e513d36c087e9ea8019325cdb3122bec744be
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155772
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Miklos Vajna
diff --git a/vcl/source/graphic/BinaryDataContainer.cxx
b/vcl/source/graphic/BinaryDataContainer.cxx
index 43538f9b12fd..7af8b9149bfe 100644
--- a/vcl/source/graphic/BinaryDataContainer.cxx
+++ b/vcl/source/graphic/BinaryDataContainer.cxx
@@ -45,7 +45,6 @@ struct BinaryDataContainer::Impl
// Horrifying data loss ...
SAL_WARN_IF(pStream->GetError(), "vcl",
"Inconsistent system - failed to swap image back in");
-SAL_DEBUG("Swap in: " << pStream->GetError());
}
void swapOut()
[Libreoffice-commits] core.git: 2 commits - desktop/source vcl/source
desktop/source/lib/init.cxx| 27 ++-
vcl/source/graphic/BinaryDataContainer.cxx |1 -
2 files changed, 26 insertions(+), 2 deletions(-)
New commits:
commit a43a9dd8205f089c92737cb5519ed2a96a8d8ff2
Author: Caolán McNamara
AuthorDate: Thu Aug 17 15:57:28 2023 +0100
Commit: Caolán McNamara
CommitDate: Fri Aug 18 09:58:08 2023 +0200
logs full of "OConfigurationNode::hasByName: object is invalid"
warn:legacy.osl:3509:3314:unotools/source/config/confignode.cxx:408:
OConfigurationNode::hasByName: object is invalid!
warn:legacy.osl:3509:3314:unotools/source/config/confignode.cxx:409:
OConfigurationNode::hasByName: object is invalid!
warn:legacy.osl:3509:3314:comphelper/source/misc/types.cxx:90:
comphelper::getBOOL : invalid argument !
in cool, open a document, switch from light to dark with sidebar open,
click on a paragraph and then on another with different properties, e.g.
normal vs heading and each change of a sidebar context triggers the
warning over and over again.
The config has no mention of notebookbar_online.ui but we set
notebookbar_online.ui as the default to use for a notebookbar
so replace mentions in the config of notebookbar.ui with
notebookbar_online.ui for consistency when we do that and we
can drop the constant log spam.
Change-Id: I41860f5422d4426d8e3786b38c967e52bc803ae3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155804
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
index 6d5295222f74..86a32708e59b 100644
--- a/desktop/source/lib/init.cxx
+++ b/desktop/source/lib/init.cxx
@@ -82,6 +82,7 @@
#include
#include
#include
+#include
#include
#include
@@ -202,6 +203,7 @@
#include
#include
#include
+#include
#include
#include
#include
@@ -7427,7 +7429,23 @@ static void activateNotebookbar(std::u16string_view rApp)
if (aAppNode.isValid())
{
-aAppNode.setNodeValue("Active",
Any(OUString("notebookbar_online.ui")));
+OUString sNoteBookbarName("notebookbar_online.ui");
+aAppNode.setNodeValue("Active", Any(sNoteBookbarName));
+
+const utl::OConfigurationNode aImplsNode = aAppNode.openNode("Modes");
+const Sequence aModeNodeNames( aImplsNode.getNodeNames() );
+
+for (const auto& rModeNodeName : aModeNodeNames)
+{
+const utl::OConfigurationNode
aImplNode(aImplsNode.openNode(rModeNodeName));
+if (!aImplNode.isValid())
+continue;
+
+OUString aCommandArg =
comphelper::getString(aImplNode.getNodeValue("CommandArg"));
+if (aCommandArg == "notebookbar.ui")
+aImplNode.setNodeValue("CommandArg", Any(sNoteBookbarName));
+}
+
aAppNode.commit();
}
}
@@ -7866,6 +7884,13 @@ static int lo_initialize(LibreOfficeKit* pThis, const
char* pAppPath, const char
if (bNotebookbar)
{
+std::shared_ptr
batch(comphelper::ConfigurationChanges::create());
+
officecfg::Office::UI::ToolbarMode::ActiveWriter::set("notebookbar_online.ui",
batch);
+
officecfg::Office::UI::ToolbarMode::ActiveCalc::set("notebookbar_online.ui",
batch);
+
officecfg::Office::UI::ToolbarMode::ActiveImpress::set("notebookbar_online.ui",
batch);
+
officecfg::Office::UI::ToolbarMode::ActiveDraw::set("notebookbar_online.ui",
batch);
+batch->commit();
+
activateNotebookbar(u"Writer");
activateNotebookbar(u"Calc");
activateNotebookbar(u"Impress");
commit 60d91bed3fdfb0a3d89c51831b27d2187bd24c40
Author: Caolán McNamara
AuthorDate: Wed Aug 16 16:31:54 2023 +0100
Commit: Caolán McNamara
CommitDate: Fri Aug 18 09:58:00 2023 +0200
SAL_DEBUG "is never meant to remain in the code"
Change-Id: I8c0e513d36c087e9ea8019325cdb3122bec744be
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155743
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/vcl/source/graphic/BinaryDataContainer.cxx
b/vcl/source/graphic/BinaryDataContainer.cxx
index 83cacb491ac2..c9e75bc4ef77 100644
--- a/vcl/source/graphic/BinaryDataContainer.cxx
+++ b/vcl/source/graphic/BinaryDataContainer.cxx
@@ -45,7 +45,6 @@ struct BinaryDataContainer::Impl
// Horrifying data loss ...
SAL_WARN_IF(pStream->GetError(), "vcl",
"Inconsistent system - failed to swap image back in");
-SAL_DEBUG("Swap in: " << pStream->GetError());
}
void swapOut()
[Libreoffice-commits] core.git: cui/uiconfig
cui/uiconfig/ui/textflowpage.ui | 416 1 file changed, 208 insertions(+), 208 deletions(-) New commits: commit 5444b73219fcd50ddbb1fe5e685a401cfd8c9cf3 Author: Samuel Mehrbrodt AuthorDate: Thu Aug 17 14:28:36 2023 +0200 Commit: Samuel Mehrbrodt CommitDate: Fri Aug 18 08:28:31 2023 +0200 Resave with latest glade Change-Id: I466d873791351f1eee02cc6bff2adc43e539eece Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155768 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt diff --git a/cui/uiconfig/ui/textflowpage.ui b/cui/uiconfig/ui/textflowpage.ui index 1be6c04228b5..0115952cb0c2 100644 --- a/cui/uiconfig/ui/textflowpage.ui +++ b/cui/uiconfig/ui/textflowpage.ui @@ -1,90 +1,90 @@ - + 1 9 2 -1 -10 +1 +10 99 -1 -10 +1 +10 55535 1 -1 -10 +1 +10 1 9 2 -1 -10 +1 +10 2 9 2 -1 -10 +1 +10 2 9 2 -1 -10 +1 +10 4 99 4 -1 -10 +1 +10 55.88 -1 -10 +1 +10 - + True -False -6 -12 -12 +False +6 +12 +12 True -False +False GDK_EXPOSURE_MASK -0 -none +0 +none - + True -False -6 -12 +False 12 6 +6 +12 A_utomatically True -True -False -True +True +False +True True -True +True Automatically inserts hyphens where they are needed in a paragraph. @@ -92,20 +92,20 @@ -0 -0 +0 +0 2 True -True +True start 25 -True -adjustment7 +True True +adjustment7 Enter the minimum word length in characters that can be hyphenated. @@ -113,19 +113,19 @@ -0 -6 +0 +6 True -True +True start 25 -True -adjustment2 +True True +adjustment2 Enter the maximum number of consecutive lines that can be hyphenated. @@ -133,19 +133,19 @@ -0 -5 +0 +5 True -True +True start 25 -True -adjustment4 +True True +adjustment4 Enter the minimum number of characters that must appear at the beginning of the line after the hyphen. @@ -153,19 +153,19 @@ -0 -4 +0 +4 True -True +True start 25 -True -adjustment1 +True True +adjustment1 Enter the minimum number of characters to leave at the end of the line before a hyphen is inserted. @@ -173,78 +173,78 @@ -0 -3 +0 +3 True -False +False start C_haracters at line end -True -spinLineEnd +True +spinLineEnd -1 -3 +1 +3
[Libreoffice-commits] core.git: sc/source
sc/source/ui/view/tabvwsh3.cxx |2 ++ 1 file changed, 2 insertions(+) New commits: commit 27fa859bb85ba7ac5b8cb22db5ae85750c7effba Author: Heiko Tietze AuthorDate: Thu Jul 27 11:08:35 2023 +0200 Commit: Heiko Tietze CommitDate: Fri Aug 18 09:21:23 2023 +0200 Resolves tdf#156357 - Submit Show Formula to document Change-Id: Ic893e573b2409342d61877313a3b60e83bb13690 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154984 Tested-by: Jenkins Reviewed-by: Heiko Tietze diff --git a/sc/source/ui/view/tabvwsh3.cxx b/sc/source/ui/view/tabvwsh3.cxx index 7395325f775c..255dbed88508 100644 --- a/sc/source/ui/view/tabvwsh3.cxx +++ b/sc/source/ui/view/tabvwsh3.cxx @@ -721,6 +721,8 @@ void ScTabViewShell::Execute( SfxRequest& rReq ) ScViewOptions aSetOpts = rOpts; aSetOpts.SetOption( VOPT_FORMULAS, bFormulaMode ); rViewData.SetOptions( aSetOpts ); +ScDocument& rDoc = rViewData.GetDocument(); +rDoc.SetViewOptions(aSetOpts); rViewData.GetDocShell()->PostPaintGridAll();
[Libreoffice-commits] core.git: cui/source editeng/qa editeng/source include/svl include/svx sfx2/source starmath/source svl/Library_svl.mk svl/qa svl/source svx/source sw/qa sw/source vcl/source
cui/source/dialogs/srchxtra.cxx | 20 +- cui/source/options/optgdlg.cxx |1 editeng/qa/unit/core-test.cxx |1 editeng/source/editeng/editattr.cxx |1 editeng/source/editeng/editdoc.cxx |1 editeng/source/editeng/eerdll.cxx |1 editeng/source/editeng/impedit2.cxx |1 include/svl/itemset.hxx | 18 ++ include/svl/poolitem.hxx| 37 include/svl/voiditem.hxx| 53 ++ include/svx/srchdlg.hxx | 22 +- sfx2/source/appl/appbas.cxx |1 sfx2/source/control/bindings.cxx|1 sfx2/source/control/sfxstatuslistener.cxx |1 sfx2/source/control/shell.cxx |1 sfx2/source/control/statcach.cxx|1 sfx2/source/statbar/stbitem.cxx |1 sfx2/source/toolbox/tbxitem.cxx |1 sfx2/source/view/lokhelper.cxx |2 starmath/source/view.cxx|1 svl/Library_svl.mk |1 svl/qa/unit/items/test_itempool.cxx |1 svl/source/items/itemset.cxx| 124 ++-- svl/source/items/poolitem.cxx | 60 +++ svl/source/items/voiditem.cxx | 59 +++ svx/source/dialog/srchdlg.cxx | 52 +++--- svx/source/mnuctrls/clipboardctl.cxx|1 svx/source/stbctrls/zoomctrl.cxx|1 svx/source/svdraw/svdattr.cxx |1 sw/qa/extras/tiledrendering/tiledrendering.cxx |1 sw/source/core/bastyp/init.cxx |1 sw/source/core/doc/DocumentContentOperationsManager.cxx |7 sw/source/uibase/app/apphdl.cxx |1 sw/source/uibase/app/applab.cxx |1 sw/source/uibase/lingu/olmenu.cxx |1 sw/source/uibase/ribbar/workctrl.cxx|1 vcl/source/app/svapp.cxx| 19 ++ 37 files changed, 341 insertions(+), 157 deletions(-) New commits: commit c351f920c426542f0d3685bb9df1363d3a6393f8 Author: Armin Le Grand (allotropia) AuthorDate: Mon Aug 14 18:21:13 2023 +0200 Commit: Armin Le Grand CommitDate: Fri Aug 18 10:37:44 2023 +0200 ITEM: preparations for more/easier changes This change is not about speed improvements but diverse preparations to make changes/reading/understanding easier. It does not change speed AFAIK. Added a global static debug-only counter to allow getting an overview over number of all allocated SfxPoolItem's and the still alloated ones at office shutdown. The values are used in Application::~Application to make a short info statement. It allows to be able to quickly detect if an error in future changes may lead to memory losses - these would show in dramaitically higher numbers then (hopefully) immediately. Moved SfxVoidItem to own source/header. Added container library interface support to SfxItemSet, adapted already some methods to use it - not all possible, I will commit & get status from gerrit 1st if all still works and then continue. Changed INVALID_POOL_ITEM from -1 to use a global unique incarnation of an isolated derivation from SfxPoolItem. It allows to avoid the (-1) pointer hack. Since still just pointers are compared it's not worse. NOTE: That way, more 'special' SfxPoolItem's may be used for more States - a candidate is e.g. SfxVoidItem(0) which represents ::DISABLED state -- unfortunately not only, it is also used (mainly for UI stuff) with 'real' WhichIDs - hard to sort out, will have to stay that way for now AFAIK. Changed INVALID_POOL_ITEM stuff to use a static extern incarnated item in combination with a inline method to return it, called GetGlobalStaticInvalidItemInstance(). Isolated create/cleanup of a SfxPoolItem entry in SfxItemSet to further modularize/simplify that. It is currently from constructor & destructor but already shows that PoolDefaults are handled differently - probably an error. Still, for now, do no change in behaviour (yet). Got regular 'killed by the Kill-Wrapper' messages from gerrit, seems to have to do with UITest_sw_findReplace. That python/c++ scripting stuff is hard to debug, but finally I identified the problem has to do with the INVALID_POOL_ITEM change. It was in
[Libreoffice-commits] core.git: sw/qa sw/source
sw/qa/extras/layout/data/tdf156725.fodt | 163
sw/qa/extras/layout/layout3.cxx | 21
sw/source/core/layout/sectfrm.cxx |4
3 files changed, 187 insertions(+), 1 deletion(-)
New commits:
commit db83c41d460103df5d80f5bd99816575c4ead5cd
Author: Michael Stahl
AuthorDate: Thu Aug 17 18:32:35 2023 +0200
Commit: Michael Stahl
CommitDate: Fri Aug 18 10:58:12 2023 +0200
tdf#156725 sw: layout: don't prevent moving between columns ...
... on the same page when there is a page break on the next page.
The existing, presumably pointless/always-false in case of same page,
check of WrongPageDesc() let me assume that this would only be reached
if the current page and the target page are different, but that was a
mistake.
(regression from commit 325fe7ab507fd8f2ca17a3db32181edf30169525)
Change-Id: I4df53b77bed006095c34976011aa0cd5e12879e7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155809
Tested-by: Jenkins
Reviewed-by: Michael Stahl
diff --git a/sw/qa/extras/layout/data/tdf156725.fodt
b/sw/qa/extras/layout/data/tdf156725.fodt
new file mode 100644
index ..9f60e7011954
--- /dev/null
+++ b/sw/qa/extras/layout/data/tdf156725.fodt
@@ -0,0 +1,163 @@
+
+http://www.w3.org/TR/css3-text/;
xmlns:grddl="http://www.w3.org/2003/g/data-view#;
xmlns:xhtml="http://www.w3.org/1999/xhtml;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
xmlns:xsd="http://www.w3.org/2001/XMLSchema;
xmlns:xforms="http://www.w3.org/2002/xforms;
xmlns:dom="http://www.w3.org/2001/xml-events;
xmlns:script="urn:oasis:names:tc:opendocument:xmlns:script:1.0"
xmlns:form="urn:oasis:names:tc:opendocument:xmlns:form:1.0"
xmlns:math="http://www.w3.org/1998/Math/MathML;
xmlns:office="urn:oasis:names:tc:opendocument:xmlns:office:1.0"
xmlns:ooo="http://openoffice.org/2004/office;
xmlns:fo="urn:oasis:names:tc:opendocument:xmlns:xsl-fo-compatible:1.0"
xmlns:config="urn:oasis:names:tc:opendocument:xmlns:config:1.0"
xmlns:ooow="http://openoffice.org/2004/writer;
xmlns:xlink="http://www.w3.org/1999/xlink;
xmlns:drawooo="http://openoffice.org/2010/draw;
xmlns:oooc="http://openoffice.org/2004/calc;
xmlns:dc="http://purl.org/dc/elements/1.1/; xmlns:c
alcext="urn:org:documentfoundation:names:experimental:calc:xmlns:calcext:1.0"
xmlns:style="urn:oasis:names:tc:opendocument:xmlns:style:1.0"
xmlns:text="urn:oasis:names:tc:opendocument:xmlns:text:1.0"
xmlns:of="urn:oasis:names:tc:opendocument:xmlns:of:1.2"
xmlns:tableooo="http://openoffice.org/2009/table;
xmlns:draw="urn:oasis:names:tc:opendocument:xmlns:drawing:1.0"
xmlns:dr3d="urn:oasis:names:tc:opendocument:xmlns:dr3d:1.0"
xmlns:rpt="http://openoffice.org/2005/report;
xmlns:formx="urn:openoffice:names:experimental:ooxml-odf-interop:xmlns:form:1.0"
xmlns:svg="urn:oasis:names:tc:opendocument:xmlns:svg-compatible:1.0"
xmlns:chart="urn:oasis:names:tc:opendocument:xmlns:chart:1.0"
xmlns:officeooo="http://openoffice.org/2009/office;
xmlns:table="urn:oasis:names:tc:opendocument:xmlns:table:1.0"
xmlns:field="urn:openoffice:names:experimental:ooo-ms-interop:xmlns:field:1.0"
xmlns:number="urn:oasis:names:tc:opendocument:xmlns:datastyle:1.0"
xmlns:meta="urn:oasis:names:tc:opendocument:xmlns:
meta:1.0"
xmlns:loext="urn:org:documentfoundation:names:experimental:office:xmlns:loext:1.0"
office:version="1.3" office:mimetype="application/vnd.oasis.opendocument.text">
+
2023-08-17T18:14:28.1153022102023-08-17T18:20:06.109127302PT4M30S2LibreOfficeDev/24.2.0.0.alpha0$Linux_X86_64
LibreOffice_project/79452241ad33f9eaace2ba8bd1336be69c99ed4d
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+ a
+ b
+ c
+ d
+
+
+
+
+
+
\ No newline at end of file
diff --git a/sw/qa/extras/layout/layout3.cxx b/sw/qa/extras/layout/layout3.cxx
index 9e47f435df94..9c75ff31a322 100644
--- a/sw/qa/extras/layout/layout3.cxx
+++ b/sw/qa/extras/layout/layout3.cxx
@@ -1207,6 +1207,27 @@ CPPUNIT_TEST_FIXTURE(SwLayoutWriter3, testTdf156724)
assertXPath(pXmlDoc, "/root/page", 2);
}
+CPPUNIT_TEST_FIXTURE(SwLayoutWriter3, testTdf156725)
+{
+createSwDoc("tdf156725.fodt");
+
+xmlDocUniquePtr pXmlDoc = parseLayoutDump();
+
Re: Building Doxygen documentation
On 18.8.2023 12.02, Chris Tapp wrote: On 17 Aug 2023, at 17:42, Michael Stahl wrote: On 17/08/2023 18:12, Chris Tapp wrote: I am trying to build the doxygen documentation using: make odk as instructed on https://wiki.documentfoundation.org/Development/Doxygen this wiki page is very confused. almost everything of it is about documenting *internal* LO code with doxygen, except for the "Building" section, which is about building the *public* API documentation with doxygen - 2 different things! the internal LO code documentation can be built with "make docs". Thanks, that gets me a bit further - I am now told that "You need the graphviz tools to create the nice inheritance graphs”. How do I install it into the LODE build environment? On Windows, run the Cygwin setup and search for the graphviz package. You can also view the docs online: https://api.libreoffice.org/ Ilmari
[Libreoffice-commits] core.git: sw/source
sw/source/core/layout/fly.cxx | 13 +
1 file changed, 13 insertions(+)
New commits:
commit ee82accbd0d67eaf0f5a164a82b86abd00c3b0c9
Author: Michael Stahl
AuthorDate: Thu Aug 17 13:30:38 2023 +0200
Commit: Michael Stahl
CommitDate: Fri Aug 18 10:57:21 2023 +0200
tdf#156728 sw: layout: invalidate fly on header/footer size
On page 30 there are at-page anchored shapes Shape22, Shape23 and
Shape25.
Shape22 and Shape23 are positioned relative to the bottom of the page
text area, and that is working; Shape25 is positioned with an offset to
the top of the page text area, and that doesn't work.
The problem is that the shapes are positioned when the header on the
page hasn't been formatted yet, and once the header is formatted, the
position of the Shape25 is not invalidated, so it's a header-height too
far up.
(regression from commit 425a252c3cc5e5a79a533965026dd4af6b8df739)
Change-Id: Ic907d98b1bcd4bb544fd1af9bf93ebc7b75bf362
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155762
Tested-by: Jenkins
Reviewed-by: Michael Stahl
diff --git a/sw/source/core/layout/fly.cxx b/sw/source/core/layout/fly.cxx
index c2d27eaf2f0e..a06c2a9e7f70 100644
--- a/sw/source/core/layout/fly.cxx
+++ b/sw/source/core/layout/fly.cxx
@@ -2718,10 +2718,23 @@ void SwLayoutFrame::NotifyLowerObjs( const bool
_bUnlockPosOfObjs )
{
assert( dynamic_cast( pObj) &&
"GetFrameFormat().GetVertOrient().GetRelationOrient());
+if (nO == text::RelOrientation::PAGE_PRINT_AREA
+|| nO == text::RelOrientation::PAGE_PRINT_AREA_BOTTOM
+|| nO == text::RelOrientation::PAGE_PRINT_AREA_TOP)
+{
+isPositionedByHF = true;
+}
+}
// #i26945# - use to check, if
// fly frame is lower of layout frame resp. if fly frame is
// at a different page registered as its anchor frame is on.
if ( IsAnLower( pAnchorFrame ) ||
+ isPositionedByHF ||
pAnchorFrame->FindPageFrame() != pPageFrame )
{
// #i44016#
Re: Machine learning is used in gerrit build
> On 18 Aug 2023, at 6:21 PM, Baole Fang wrote: > > Hi Noel, > > The reason to choose it is that it is most likely to fail among all the > builds. If it fails, then there is no need to run others. This assumes it is failing because something in the change being built, but it often fails for random reasons, so it is not doing the developer any service not running the other job. Choosing a more reliable job would at least increase the chance of catching actual issues in the change quicker. Regards, Khaled
[Libreoffice-commits] core.git: 2 commits - config_host.mk.in configure.ac solenv/gbuild
config_host.mk.in |1 -
configure.ac |9 ++---
solenv/gbuild/JavaClassSet.mk |2 +-
3 files changed, 3 insertions(+), 9 deletions(-)
New commits:
commit f09e2e1d92a7d7f99b05c739952eed876f741f75
Author: Michael Weghorn
AuthorDate: Fri Aug 18 09:51:43 2023 +0200
Commit: Michael Weghorn
CommitDate: Fri Aug 18 20:14:38 2023 +0200
configure.ac: Update Java check for JDK >= 9 version string
Since Java 9, the major version number is the actual one,
while up to including Java 8, that wasn't the case
(Java 8 would use a version string of 1.8.x).
Update the version check accordingly, which was still
assuming the old versioning scheme, i.e. would pass
for any Java version >= 1.9.0.
(This shouldn't make any difference in practice yet,
but will once the minimium version is increased.)
Change-Id: I79eeb247315499caddd63d6abbb1e14ea6a72a4a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155826
Tested-by: Jenkins
Reviewed-by: Michael Weghorn
diff --git a/configure.ac b/configure.ac
index 673a16b925e3..77d916ac8b5a 100644
--- a/configure.ac
+++ b/configure.ac
@@ -8647,8 +8647,8 @@ if test "$ENABLE_JAVA" != "" -a "$cross_compiling" !=
"yes"; then
_jdk=`$JAVAINTERPRETER -version 2>&1 | $AWK -F'"' '{ print \$2 }'
| $SED '/^$/d' | $SED s/[[-A-Za-z]]*//`
_jdk_ver=`echo "$_jdk" | $AWK -F. '{ print (($1 * 100) + $2) * 100
+ $3;}'`
-if test "$_jdk_ver" -lt 10900; then
-AC_MSG_ERROR([JDK is too old, you need at least 9 ($_jdk_ver <
10900)])
+if test "$_jdk_ver" -lt 9; then
+AC_MSG_ERROR([JDK is too old, you need at least 9 ($_jdk_ver <
9)])
fi
dnl TODO: Presumably, the Security Manager will not merely be
disallowed, but be
dnl completely removed in some Java version > 18 (see
commit 94c94633a4e6f1622c7cc31ce6efd41862691d59
Author: Michael Weghorn
AuthorDate: Fri Aug 18 09:30:17 2023 +0200
Commit: Michael Weghorn
CommitDate: Fri Aug 18 20:14:30 2023 +0200
Drop JAVA_CLASSPATH_NOT_SET which is always TRUE
The variable was introduced in
commit b97cade9183d14ad21ae71892348a9a81689488b
Date: Sun Apr 7 12:14:36 2013 -0400
Supress warnings about unset classpath
I get the below warning for every single jar file without this
patch.
warning: [options] bootstrap class path not set in conjunction with
-source 1.5
1 warning
Change-Id: I71c01aeea993640f1ec86fe1d8a977656861358d
, at a time when Java 5 was the minimum version,
likely to suppress warnings with JDK versions >= 6
(greater than 1.6.0 to be exact...).
The version check was then just bumped along with the Java
baseline bumps in
commit aafc10c9edb61e13ac557c7e43c8d4a31dce4f37
Date: Fri Jul 26 10:19:39 2019 +0200
Bump Java baseline to Java 8
and
commit 941b567a41569260fef14a7337511e8f42337323
Date: Thu May 7 09:42:22 2020 +0200
tdf#131572 Add java 9 module info for libreoffice.jar
for no apparent reason.
In any case, the variable will always be set to TRUE,
since the Java version string is using the actual
major version number as the first digit since
JDK 9 (while JDK 8 would still use 1.8.x as version
string), s.a. upcoming commit
Change-Id I79eeb247315499caddd63d6abbb1e14ea6a72a4a
("configure.ac: Update Java check for JDK >= 9 version string").
Drop the variable and set the Java params
in `solenv/gbuild/JavaClassSet.mk` unconditionally.
Change-Id: Ib4aad07da3937289fc6ff29dd80abdd4c35f1773
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155825
Tested-by: Jenkins
Reviewed-by: Michael Weghorn
diff --git a/config_host.mk.in b/config_host.mk.in
index 8b345a690eff..f4e6841b22d6 100644
--- a/config_host.mk.in
+++ b/config_host.mk.in
@@ -353,7 +353,6 @@ export JAVADOCISGJDOC=@JAVADOCISGJDOC@
export JAVACFLAGS=@JAVACFLAGS@
export JAVAIFLAGS=@JAVAIFLAGS@
export JAVAIFLAGS_FOR_BUILD=@JAVAIFLAGS_FOR_BUILD@
-export JAVA_CLASSPATH_NOT_SET=@JAVA_CLASSPATH_NOT_SET@
export JAVAINTERPRETER=@JAVAINTERPRETER@
export JAVA_HOME=@JAVA_HOME@
export JAVA_HOME_FOR_BUILD=@JAVA_HOME_FOR_BUILD@
diff --git a/configure.ac b/configure.ac
index 7f5c0ff66430..673a16b925e3 100644
--- a/configure.ac
+++ b/configure.ac
@@ -5850,7 +5850,6 @@ if test "$cross_compiling" = "yes"; then
ANT
ANT_HOME
ANT_LIB
-JAVA_CLASSPATH_NOT_SET
JAVA_SOURCE_VER
JAVA_TARGET_VER
JAVACFLAGS
@@ -8651,9 +8650,6 @@ if test "$ENABLE_JAVA" != "" -a "$cross_compiling" !=
"yes"; then
if test "$_jdk_ver" -lt 10900; then
AC_MSG_ERROR([JDK is too old, you need at least 9
[Libreoffice-commits] core.git: Branch 'libreoffice-7-6' - svgio/qa svgio/source
svgio/qa/cppunit/SvgImportTest.cxx| 21 +
svgio/qa/cppunit/data/tdf117920.svg |7 +++
svgio/source/svgreader/svgdocumenthandler.cxx |7 +--
3 files changed, 29 insertions(+), 6 deletions(-)
New commits:
commit 06075cd2ffc490feb7560f92ffc894b1e6751f90
Author: Xisco Fauli
AuthorDate: Thu Aug 17 09:24:18 2023 +0200
Commit: Xisco Fauli
CommitDate: Fri Aug 18 21:38:46 2023 +0200
tdf#117920: Revert "related tdf#156579: just break for switch element"
This reverts commit e222f60ac2a71032dbdf62d7c7e28978b5a0b19c.
To make the switch element behave like a
group as least, so the transform attribute is parsed
Change-Id: Id8c21ac6da217d8f7bc350ff41022335bf1e0f1f
Change-Id: If1e53f9baad8995f26f9b885cfef6265040736bc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155770
Tested-by: Jenkins
Reviewed-by: Xisco Fauli
diff --git a/svgio/qa/cppunit/SvgImportTest.cxx
b/svgio/qa/cppunit/SvgImportTest.cxx
index bbaf2ec5d96d..73b3150b3a8d 100644
--- a/svgio/qa/cppunit/SvgImportTest.cxx
+++ b/svgio/qa/cppunit/SvgImportTest.cxx
@@ -962,6 +962,27 @@ CPPUNIT_TEST_FIXTURE(Test, testNoneColor)
assertXPath(pDocument,
"/primitive2D/transform/mask/polypolygonstroke/line", "width", "3");
}
+CPPUNIT_TEST_FIXTURE(Test, testTdf117920)
+{
+Primitive2DSequence aSequence =
parseSvg(u"/svgio/qa/cppunit/data/tdf117920.svg");
+CPPUNIT_ASSERT_EQUAL(1, static_cast(aSequence.getLength()));
+
+drawinglayer::Primitive2dXmlDump dumper;
+xmlDocUniquePtr pDocument =
dumper.dumpAndParse(Primitive2DContainer(aSequence));
+
+CPPUNIT_ASSERT (pDocument);
+
+assertXPath(pDocument, "/primitive2D/transform/transform", "xy11", "1");
+assertXPath(pDocument, "/primitive2D/transform/transform", "xy12", "0");
+assertXPath(pDocument, "/primitive2D/transform/transform", "xy13", "-18");
+assertXPath(pDocument, "/primitive2D/transform/transform", "xy21", "0");
+assertXPath(pDocument, "/primitive2D/transform/transform", "xy22", "1");
+assertXPath(pDocument, "/primitive2D/transform/transform", "xy23", "-6");
+assertXPath(pDocument, "/primitive2D/transform/transform", "xy31", "0");
+assertXPath(pDocument, "/primitive2D/transform/transform", "xy32", "0");
+assertXPath(pDocument, "/primitive2D/transform/transform", "xy33", "1");
+}
+
CPPUNIT_TEST_FIXTURE(Test, testTdf97936)
{
// check that both rectangles are rendered in the viewBox
diff --git a/svgio/qa/cppunit/data/tdf117920.svg
b/svgio/qa/cppunit/data/tdf117920.svg
new file mode 100644
index ..487e0f6cb925
--- /dev/null
+++ b/svgio/qa/cppunit/data/tdf117920.svg
@@ -0,0 +1,7 @@
+http://www.w3.org/2000/svg;
+ xmlns:xlink="http://www.w3.org/1999/xlink;>
+
+
+
+
diff --git a/svgio/source/svgreader/svgdocumenthandler.cxx
b/svgio/source/svgreader/svgdocumenthandler.cxx
index f86d2603de2a..bd7a9c5791c9 100644
--- a/svgio/source/svgreader/svgdocumenthandler.cxx
+++ b/svgio/source/svgreader/svgdocumenthandler.cxx
@@ -199,6 +199,7 @@ namespace
mpTarget->parseAttributes(xAttribs);
break;
}
+case SVGToken::Switch: //TODO: Support switch element
case SVGToken::Defs:
case SVGToken::G:
{
@@ -442,12 +443,6 @@ namespace
break;
}
-case SVGToken::Switch:
-{
-//TODO: Support switch element
-break;
-}
-
default:
{
mpTarget = new SvgNode(SVGToken::Unknown, maDocument,
mpTarget);
[Libreoffice-commits] core.git: officecfg/registry
officecfg/registry/data/org/openoffice/Office/Accelerators.xcu |6 ++ officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu |5 + 2 files changed, 11 insertions(+) New commits: commit 1d361ad42a687bd6730d251d060ce867cc0b882b Author: Caolán McNamara AuthorDate: Fri Aug 18 09:35:28 2023 +0100 Commit: Caolán McNamara CommitDate: Fri Aug 18 22:57:55 2023 +0200 Related: tdf#151059 assign Alt+7 to new manage changes deck and move a11y one to 8 to match visual order Change-Id: Ifb4e08f6214da1cdd75bd3b5aa43ac9143e70376 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155832 Tested-by: Jenkins Reviewed-by: Caolán McNamara diff --git a/officecfg/registry/data/org/openoffice/Office/Accelerators.xcu b/officecfg/registry/data/org/openoffice/Office/Accelerators.xcu index 647b46927e5f..ed3f30f8f08f 100644 --- a/officecfg/registry/data/org/openoffice/Office/Accelerators.xcu +++ b/officecfg/registry/data/org/openoffice/Office/Accelerators.xcu @@ -6023,6 +6023,12 @@ Ctrl+Shift+e aka E_SHIFT_MOD1 under GTK/IBUS is for some emoji thing + +I10N SHORTCUTS - NO TRANSLATE +.uno:SidebarDeck.SwManageChangesDeck + + + I10N SHORTCUTS - NO TRANSLATE .uno:SidebarDeck.A11yCheckDeck diff --git a/officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu b/officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu index b3e8ce0e2e94..c0d820c0e43b 100644 --- a/officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu +++ b/officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu @@ -4204,6 +4204,11 @@ Open the Style Inspector Deck + + + Open the Manage Changes Deck + + Open the Accessibility Check Deck
[Libreoffice-commits] core.git: cui/source
cui/source/dialogs/AdditionsDialog.cxx | 10 --
cui/source/inc/AdditionsDialog.hxx |1 +
2 files changed, 9 insertions(+), 2 deletions(-)
New commits:
commit 5296b0ffe3ce031cab29d64d62e1bdc3fb2595fe
Author: Caolán McNamara
AuthorDate: Fri Aug 18 11:07:07 2023 +0100
Commit: Noel Grandin
CommitDate: Fri Aug 18 19:22:53 2023 +0200
don't access network during a UITest
Change-Id: If6cc3da3e75ad7689a0de35784c2d29d5b01b96e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155833
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/cui/source/dialogs/AdditionsDialog.cxx
b/cui/source/dialogs/AdditionsDialog.cxx
index 73b16ed06e90..f0dedf626acf 100644
--- a/cui/source/dialogs/AdditionsDialog.cxx
+++ b/cui/source/dialogs/AdditionsDialog.cxx
@@ -275,6 +275,11 @@
SearchAndParseThread::SearchAndParseThread(AdditionsDialog* pDialog, const bool
, m_bExecute(true)
, m_bIsFirstLoading(isFirstLoading)
{
+// if we are running a UITest, e.g. UITest_sw_options then
+// don't attempt to downloading anything
+static const bool bUITest = getenv("LIBO_TEST_UNIT");
+
+m_bUITest = bUITest;
}
SearchAndParseThread::~SearchAndParseThread() {}
@@ -284,7 +289,8 @@ void SearchAndParseThread::Append(AdditionInfo&
additionInfo)
if (!m_bExecute)
return;
OUString aPreviewFile;
-bool bResult = getPreviewFile(additionInfo, aPreviewFile); // info vector
json data
+bool bResult
+= !m_bUITest && getPreviewFile(additionInfo, aPreviewFile); // info
vector json data
if (!bResult)
{
@@ -398,7 +404,7 @@ void SearchAndParseThread::execute()
if (m_bIsFirstLoading)
{
-std::string sResponse = ucbGet(m_pAdditionsDialog->m_sURL);
+std::string sResponse = !m_bUITest ?
ucbGet(m_pAdditionsDialog->m_sURL) : "";
parseResponse(sResponse, m_pAdditionsDialog->m_aAllExtensionsVector);
std::sort(m_pAdditionsDialog->m_aAllExtensionsVector.begin(),
m_pAdditionsDialog->m_aAllExtensionsVector.end(),
diff --git a/cui/source/inc/AdditionsDialog.hxx
b/cui/source/inc/AdditionsDialog.hxx
index 302d11bbc6ea..559a4ca911ff 100644
--- a/cui/source/inc/AdditionsDialog.hxx
+++ b/cui/source/inc/AdditionsDialog.hxx
@@ -138,6 +138,7 @@ private:
AdditionsDialog* m_pAdditionsDialog;
std::atomic m_bExecute;
bool m_bIsFirstLoading;
+bool m_bUITest;
void Search();
void Append(AdditionInfo& additionInfo);
[Libreoffice-commits] core.git: oox/source sd/qa
oox/source/export/drawingml.cxx| 15 +++
sd/qa/unit/data/pptx/tdf151134.odp |binary
sd/qa/unit/export-tests-ooxml1.cxx |9 +
3 files changed, 20 insertions(+), 4 deletions(-)
New commits:
commit 0367a168cd01f4a2c16101726714f696ba023a6f
Author: Samuel Mehrbrodt
AuthorDate: Fri Aug 18 13:42:23 2023 +0200
Commit: Samuel Mehrbrodt
CommitDate: Fri Aug 18 22:15:59 2023 +0200
tdf#151134 Always write inset properties when exporting placeholder shapes
The default value works for text boxes, but not for these special
presentation placeholder objects - here the values need to be written
explicitly.
Change-Id: Id606bd5e6b63dee2fd3b385435ce13ecec63b5f1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155838
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt
diff --git a/oox/source/export/drawingml.cxx b/oox/source/export/drawingml.cxx
index 351c1b7cf265..6b464cf774ba 100644
--- a/oox/source/export/drawingml.cxx
+++ b/oox/source/export/drawingml.cxx
@@ -4010,6 +4010,9 @@ void DrawingML::WriteText(const Reference&
rXIface, bool bBodyPr, bo
sVertOverflow = "clip";
}
+// tdf#151134 When writing placeholder shapes, inset must be
explicitly specified
+bool bRequireInset = GetProperty(rXPropSet, "IsPresentationObject") &&
rXPropSet->getPropertyValue("IsPresentationObject").get();
+
mpFS->startElementNS( (nXmlNamespace ? nXmlNamespace : XML_a),
XML_bodyPr,
XML_numCol,
sax_fastparser::UseIf(OString::number(nCols), nCols > 0),
XML_spcCol,
sax_fastparser::UseIf(OString::number(oox::drawingml::convertHmmToEmu(nColSpacing)),
nCols > 0 && nColSpacing >= 0),
@@ -4017,10 +4020,14 @@ void DrawingML::WriteText(const Reference&
rXIface, bool bBodyPr, bo
XML_horzOverflow, sHorzOverflow,
XML_vertOverflow, sVertOverflow,
XML_fromWordArt, sax_fastparser::UseIf("1",
bFromWordArt),
- XML_lIns,
sax_fastparser::UseIf(OString::number(oox::drawingml::convertHmmToEmu(nLeft)),
nLeft != constDefaultLeftRightInset),
- XML_rIns,
sax_fastparser::UseIf(OString::number(oox::drawingml::convertHmmToEmu(nRight)),
nRight != constDefaultLeftRightInset),
- XML_tIns,
sax_fastparser::UseIf(OString::number(oox::drawingml::convertHmmToEmu(nTop)),
nTop != constDefaultTopBottomInset),
- XML_bIns,
sax_fastparser::UseIf(OString::number(oox::drawingml::convertHmmToEmu(nBottom)),
nBottom != constDefaultTopBottomInset),
+ XML_lIns,
sax_fastparser::UseIf(OString::number(oox::drawingml::convertHmmToEmu(nLeft)),
+ bRequireInset
|| nLeft != constDefaultLeftRightInset),
+ XML_rIns,
sax_fastparser::UseIf(OString::number(oox::drawingml::convertHmmToEmu(nRight)),
+ bRequireInset
|| nRight != constDefaultLeftRightInset),
+ XML_tIns,
sax_fastparser::UseIf(OString::number(oox::drawingml::convertHmmToEmu(nTop)),
+ bRequireInset
|| nTop != constDefaultTopBottomInset),
+ XML_bIns,
sax_fastparser::UseIf(OString::number(oox::drawingml::convertHmmToEmu(nBottom)),
+ bRequireInset
|| nBottom != constDefaultTopBottomInset),
XML_anchor, sAnchor,
XML_anchorCtr, sax_fastparser::UseIf("1",
bAnchorCtr),
XML_vert, sWritingMode,
diff --git a/sd/qa/unit/data/pptx/tdf151134.odp
b/sd/qa/unit/data/pptx/tdf151134.odp
new file mode 100644
index ..56ea86a3144c
Binary files /dev/null and b/sd/qa/unit/data/pptx/tdf151134.odp differ
diff --git a/sd/qa/unit/export-tests-ooxml1.cxx
b/sd/qa/unit/export-tests-ooxml1.cxx
index ffc3530f40b6..1e7c05390d39 100644
--- a/sd/qa/unit/export-tests-ooxml1.cxx
+++ b/sd/qa/unit/export-tests-ooxml1.cxx
@@ -1666,6 +1666,15 @@ CPPUNIT_TEST_FIXTURE(SdOOXMLExportTest1, testTdf137675)
"none");
}
+CPPUNIT_TEST_FIXTURE(SdOOXMLExportTest1, testTdf151134)
+{
+createSdImpressDoc("pptx/tdf151134.odp");
+save("Impress Office Open XML");
+
+xmlDocUniquePtr pXmlDoc = parseExport("ppt/slides/slide1.xml");
+assertXPath(pXmlDoc, "/p:sld/p:cSld/p:spTree/p:sp[1]/p:txBody/a:bodyPr",
"lIns", "91440");
+}
+
CPPUNIT_PLUGIN_IMPLEMENT();
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
[Libreoffice-commits] core.git: vcl/source
vcl/source/window/dockmgr.cxx |8
1 file changed, 8 insertions(+)
New commits:
commit 0008ff3597e9d89481d5fccb5cefa7f058400a43
Author: Michael Weghorn
AuthorDate: Fri Aug 18 15:32:12 2023 +0100
Commit: Michael Weghorn
CommitDate: Fri Aug 18 20:13:55 2023 +0200
tdf#141101 a11y: Ensure focused event after showing popup content
If the `FloatWinPopupFlags::GrabFocus` flag is set,
don't only pass it to `FloatingWindow::StartPopupMode`,
but explicitly grab focus again after showing the
docking window (client window of the floating window).
At least proper handling for accessible focus/focused
events depends on the window being visible at the point
it receives focus.
For winaccessibility, the a11y event listener only
gets registered once the window gets shown
(`VCLXAccessibleComponent::ProcessWindowChildEvent`
forwards a `VclEventId::WindowShow` as
`accessibility::AccessibleEventId::CHILD` event, which
winaccessibility then processes and registers an
event listener for the new child).
This makes NVDA on Windows announce focus for the
"Automatic" button in the color popup in Writer's
character style dialog also when the popup shows
for the first time.
Change-Id: I2e4028eb4ec68a8b586cbd1a0dc5351d1453937e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155843
Tested-by: Jenkins
Reviewed-by: Michael Weghorn
diff --git a/vcl/source/window/dockmgr.cxx b/vcl/source/window/dockmgr.cxx
index ba9aa2aa9450..7cde1910fed3 100644
--- a/vcl/source/window/dockmgr.cxx
+++ b/vcl/source/window/dockmgr.cxx
@@ -823,6 +823,10 @@ void ImplDockingWindowWrapper::StartPopupMode( ToolBox
*pParentToolBox, FloatWin
mpFloatWin->StartPopupMode( pParentToolBox, nFlags );
GetWindow()->Show();
+// grab focus (again) after showing docking window, as e.g. a11y focus
+// events require window to be visible first
+if (nFlags & FloatWinPopupFlags::GrabFocus)
+mpFloatWin->GrabFocus();
if( pParentToolBox->IsKeyEvent() )
{
@@ -841,6 +845,10 @@ void ImplDockingWindowWrapper::StartPopupMode( const
tools::Rectangle& rRect, Fl
ImplPreparePopupMode();
mpFloatWin->StartPopupMode( rRect, nFlags );
GetWindow()->Show();
+// grab focus (again) after showing docking window, as e.g. a11y focus
+// events require window to be visible first
+if (nFlags & FloatWinPopupFlags::GrabFocus)
+mpFloatWin->GrabFocus();
}
IMPL_LINK_NOARG(ImplDockingWindowWrapper, PopupModeEnd, FloatingWindow*, void)
Re: Machine learning is used in gerrit build
Hello, On 18/8/23 18:48, Noel Grandin wrote: Just recently I have to resume my builds 5 or 6 times to get past the ML stage, only then to discover that I made a mistake that affected some other platform, and then having to change things again, and restart the process. Maybe having a way to force to build on all platforms as we do with android could help. See https://lists.freedesktop.org/archives/libreoffice/2023-August/090731.html -- Xisco Faulí LibreOffice QA Team IRC: x1sc0
[Libreoffice-commits] core.git: 2 commits - svx/source
svx/source/dialog/frmsel.cxx |5 -
1 file changed, 4 insertions(+), 1 deletion(-)
New commits:
commit 912374164f16a4157f04c74994e15f8658b37f03
Author: Michael Weghorn
AuthorDate: Fri Aug 18 20:02:17 2023 +0200
Commit: Michael Weghorn
CommitDate: Fri Aug 18 22:20:45 2023 +0200
svx: Use FRAMEBORDERTYPE_COUNT instead of magic number
... just as is used for `maAllBorders` below.
Change-Id: I0741a039cc0ee9ad01055414f471dab45f420ed6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155849
Tested-by: Jenkins
Reviewed-by: Michael Weghorn
diff --git a/svx/source/dialog/frmsel.cxx b/svx/source/dialog/frmsel.cxx
index 55e73043044b..1fde68ed7c0d 100644
--- a/svx/source/dialog/frmsel.cxx
+++ b/svx/source/dialog/frmsel.cxx
@@ -238,7 +238,7 @@ FrameSelectorImpl::FrameSelectorImpl( FrameSelector&
rFrameSel ) :
mbAutoSelect( true ),
mbHCMode( false )
#if !ENABLE_WASM_STRIP_ACCESSIBILITY
-,maChildVec( 8 )
+,maChildVec(FRAMEBORDERTYPE_COUNT)
#endif
{
maAllBorders.resize( FRAMEBORDERTYPE_COUNT, nullptr );
commit 79cc574270582d03408286544d99227881f13bb8
Author: Michael Weghorn
AuthorDate: Fri Aug 18 18:00:17 2023 +0200
Commit: Michael Weghorn
CommitDate: Fri Aug 18 22:20:37 2023 +0200
related tdf#156683 a11y: Dispose FrameSelectorImpl a11y children
Don't just invalidate, but also dispose the a11y children
in `FrameSelectorImpl::~FrameSelectorImpl`.
This fixes a crash on exit that's reproducible with
the gtk3 VCL plugin e.g. like this (maybe some
steps aren't even needed):
1) start LO Writer with the gtk3 VCL plugin
2) right-click, select "Character" > "Character"
in context menu
3) switch to "Font Effects" tab
4) press space key with focus in the font color combobox
to open the popup
5) use Tab key to get to the view of colors
6) move around with arrow keys a bit
7) close the dialog and Writer
Reverse-continuing to `atk_object_wrapper_dispose`
(frame #10 in the below backtrace) in rr
showed the involved a11y object:
uno::Reference to (svx::a11y::AccFrameSelectorChild *) 0x5557832b9150
Backtrace (somewhat similar to the one in tdf#156683):
#0 0x76b15cd6 in
comphelper::OInterfaceContainerHelper4::disposeAndClear(std::unique_lock&,
com::sun::star::lang::EventObject const&)
(this=0x7fffca88, rGuard=..., rEvt=...) at
.../include/comphelper/interfacecontainer4.hxx:397
#1 0x76b13c6f in
comphelper::AccessibleEventNotifier::revokeClientNotifyDisposing(unsigned int,
com::sun::star::uno::Reference const&)
(_nClient=1058, _rxEventSource=uno::Reference to
(svx::a11y::AccFrameSelectorChild *) 0x5cecfdf0) at
.../comphelper/source/misc/accessibleeventnotifier.cxx:204
#2 0x76b1028a in
comphelper::OCommonAccessibleComponent::disposing() (this=0x5cecfdf0) at
.../comphelper/source/misc/accessiblecomponenthelper.cxx:61
#3 0x76674aeb in cppu::WeakComponentImplHelperBase::dispose()
(this=0x5cecfdf0) at .../cppuhelper/source/implbase.cxx:104
#4 0x72ddf0e0 in
cppu::PartialWeakComponentImplHelper::dispose()
(this=0x5cecfdf0)
at .../include/cppuhelper/compbase.hxx:90
#5 0x76674834 in cppu::WeakComponentImplHelperBase::release()
(this=0x5cecfdf0) at .../cppuhelper/source/implbase.cxx:79
#6 0x72ddf642 in
cppu::PartialWeakComponentImplHelper::release()
(this=0x5cecfdf0)
at .../include/cppuhelper/compbase.hxx:86
#7 0x72ddf378 in
cppu::ImplInheritanceHelper::release()
(this=0x5cecfdf0)
at .../include/cppuhelper/implbase.hxx:171
#8 0x72ddf0a0 in
cppu::ImplInheritanceHelper::release() (this=0x5cecfdf0)
at .../include/cppuhelper/implbase.hxx:171
#9 0x7fffe3f29535 in
com::sun::star::uno::Reference::clear()
(this=0x5d40a010) at .../include/com/sun/star/uno/Reference.hxx:231
#10 0x7fffe3f288de in atk_object_wrapper_dispose(AtkObjectWrapper*)
(wrapper=0x5d409fa0) at .../vcl/unx/gtk3/a11y/atkwrapper.cxx:1078
#11 0x7fffe3f27527 in atk_object_wrapper_finalize(GObject*)
(obj=0x5d409fa0) at .../vcl/unx/gtk3/a11y/atkwrapper.cxx:674
#12 0x7138c48c in g_object_unref () at
/lib/x86_64-linux-gnu/libgobject-2.0.so.0
#13 0x7fffe3f003f7 in AtkListener::~AtkListener()
(this=0x5ce6ecb0, __in_chrg=) at
.../vcl/unx/gtk3/a11y/atklistener.cxx:57
#14 0x7fffe3f0042e in AtkListener::~AtkListener()
(this=0x5ce6ecb0, __in_chrg=) at
.../vcl/unx/gtk3/a11y/atklistener.cxx:58
#15 0x76756838 in cppu::OWeakObject::release()
(this=0x5ce6ecb0) at .../cppuhelper/source/weak.cxx:230
#16 0x7fffe3f0a7de in
cppu::WeakImplHelper::release()
(this=0x5ce6ecb0) at
[Libreoffice-commits] core.git: 2 commits - sc/source
sc/source/ui/inc/gridwin.hxx |3 +--
sc/source/ui/view/tabview3.cxx |7 ---
2 files changed, 5 insertions(+), 5 deletions(-)
New commits:
commit 34d32740d89876c3d4fd2743a07d6e2578601683
Author: Caolán McNamara
AuthorDate: Thu Aug 17 20:43:22 2023 +0100
Commit: Caolán McNamara
CommitDate: Fri Aug 18 23:00:57 2023 +0200
on invalidating other views, specific what Tab is invalidated
the other views might be viewing other tabs and it is only
the tab ('part') this view is on which is invalidated
Change-Id: I9f054ffa6158a6bc62e3eb7b7170450e26870b54
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155816
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/sc/source/ui/inc/gridwin.hxx b/sc/source/ui/inc/gridwin.hxx
index 979767c6801b..deb3264c7759 100644
--- a/sc/source/ui/inc/gridwin.hxx
+++ b/sc/source/ui/inc/gridwin.hxx
@@ -320,8 +320,6 @@ class SAL_DLLPUBLIC_RTTI ScGridWindow : public
vcl::DocWindow, public DropTarget
voidSetupInitialPageBreaks(const ScDocument& rDoc, SCTAB nTab);
DECL_DLLPRIVATE_LINK(InitiatePageBreaksTimer, Timer*, void);
-voidLogicInvalidatePart(const tools::Rectangle* pRectangle,
int nPart);
-
protected:
virtual voidPrePaint(vcl::RenderContext& rRenderContext) override;
virtual voidPaint(vcl::RenderContext& rRenderContext, const
tools::Rectangle& rRect) override;
@@ -380,6 +378,7 @@ public:
/// @see Window::LogicInvalidate().
void LogicInvalidate(const tools::Rectangle* pRectangle) override;
+void LogicInvalidatePart(const tools::Rectangle* pRectangle, int nPart);
/// Update the cell selection according to what handles have been dragged.
/// @see vcl::ITiledRenderable::setTextSelection() for the values of nType.
diff --git a/sc/source/ui/view/tabview3.cxx b/sc/source/ui/view/tabview3.cxx
index 38c8fcca449e..9a321f73eefe 100644
--- a/sc/source/ui/view/tabview3.cxx
+++ b/sc/source/ui/view/tabview3.cxx
@@ -2200,6 +2200,7 @@ void ScTabView::KillEditView( bool bNoPaint )
SCROW nRow1 = aViewData.GetEditStartRow();
SCCOL nCol2 = aViewData.GetEditEndCol();
SCROW nRow2 = aViewData.GetEditEndRow();
+SCTAB nTab = aViewData.GetTabNo();
bool bPaint[4];
bool bNotifyAcc = false;
tools::Rectangle aRectangle[4];
@@ -2237,16 +2238,16 @@ void ScTabView::KillEditView( bool bNoPaint )
if (comphelper::LibreOfficeKit::isActive())
{
const tools::Rectangle& rInvRect = aRectangle[i];
-pGridWin[i]->LogicInvalidate();
+pGridWin[i]->LogicInvalidatePart(, nTab);
// invalidate other views
auto lInvalidateWindows =
-[] (ScTabView* pTabView)
+[nTab, ] (ScTabView* pTabView)
{
for (VclPtr const & pWin:
pTabView->pGridWin)
{
if (pWin)
-pWin->LogicInvalidate();
+pWin->LogicInvalidatePart(, nTab);
}
};
commit a35311beef378c15ecbb3bb0560035c17f4657ca
Author: Caolán McNamara
AuthorDate: Thu Aug 17 20:33:14 2023 +0100
Commit: Caolán McNamara
CommitDate: Fri Aug 18 23:00:48 2023 +0200
for LibreOfficeKit::isActive we can skip to LogicInvalidate
it should be the same effect
Change-Id: I2faa0b728fdebe837855e1f23e066ae8b1a2bde6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155815
Tested-by: Caolán McNamara
Reviewed-by: Caolán McNamara
diff --git a/sc/source/ui/view/tabview3.cxx b/sc/source/ui/view/tabview3.cxx
index 03a15b4437d9..38c8fcca449e 100644
--- a/sc/source/ui/view/tabview3.cxx
+++ b/sc/source/ui/view/tabview3.cxx
@@ -2237,7 +2237,7 @@ void ScTabView::KillEditView( bool bNoPaint )
if (comphelper::LibreOfficeKit::isActive())
{
const tools::Rectangle& rInvRect = aRectangle[i];
-pGridWin[i]->Invalidate(rInvRect);
+pGridWin[i]->LogicInvalidate();
// invalidate other views
auto lInvalidateWindows =
@@ -2246,7 +2246,7 @@ void ScTabView::KillEditView( bool bNoPaint )
for (VclPtr const & pWin:
pTabView->pGridWin)
{
if (pWin)
-pWin->Invalidate(rInvRect);
+pWin->LogicInvalidate();
}
};
[Libreoffice-commits] core.git: svx/uiconfig
svx/uiconfig/ui/accessibilitycheckentry.ui |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 56d5b243688e6904620920fbbe9dc3f97f18e932 Author: Samuel Mehrbrodt AuthorDate: Tue Aug 15 10:40:01 2023 +0200 Commit: Samuel Mehrbrodt CommitDate: Fri Aug 18 12:40:41 2023 +0200 Add dots to "Fix" button to indicate it opens a dialog Change-Id: Ibafcd3998396f4d763faad4296c3f7355cd90cf1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155718 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt diff --git a/svx/uiconfig/ui/accessibilitycheckentry.ui b/svx/uiconfig/ui/accessibilitycheckentry.ui index 1eb5511cfd1d..f5b79bd9a203 100644 --- a/svx/uiconfig/ui/accessibilitycheckentry.ui +++ b/svx/uiconfig/ui/accessibilitycheckentry.ui @@ -46,7 +46,7 @@ -Fix +Fix… True True True
Re: Building Doxygen documentation
hello, was there a breaking reason to explicitely mention 7.*4* on https://api.libreoffice.org/ ? and/or does it just need a refresh with 7.*5* ? (then, how much would that cost ? ;) thx Le 18. 08. 23 à 11:44, Ilmari Lauhakangas a écrit : On 18.8.2023 12.02, Chris Tapp wrote: On 17 Aug 2023, at 17:42, Michael Stahl wrote: On 17/08/2023 18:12, Chris Tapp wrote: I am trying to build the doxygen documentation using: make odk as instructed on https://wiki.documentfoundation.org/Development/Doxygen this wiki page is very confused. almost everything of it is about documenting *internal* LO code with doxygen, except for the "Building" section, which is about building the *public* API documentation with doxygen - 2 different things! the internal LO code documentation can be built with "make docs". Thanks, that gets me a bit further - I am now told that "You need the graphviz tools to create the nice inheritance graphs”. How do I install it into the LODE build environment? On Windows, run the Cygwin setup and search for the graphviz package. You can also view the docs online: https://api.libreoffice.org/ Ilmari -- Cordialement, __ Schweizerisches Bundesgericht Service Informatique - AB Pierre-Yves Foucou f...@bger.ch+41 (21) 318 95 44
Re: Machine learning is used in gerrit build
Hi Why are we fronting the ml jenkins job with the least reliable subjob? Surely we should be using the gcc job - which is faster and more reliable. Regards, Noel Grandin
[Libreoffice-commits] core.git: vcl/source
vcl/source/app/svapp.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit c8bbabd64ca642b8e9dec5cc6479177315be1210
Author: Andrea Gelmini
AuthorDate: Fri Aug 18 11:29:43 2023 +0200
Commit: Julien Nabet
CommitDate: Fri Aug 18 13:53:57 2023 +0200
Fix typos
Change-Id: I29aa97b8072fccee24ed0053c9492d61bef44cb0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155828
Tested-by: Julien Nabet
Reviewed-by: Julien Nabet
diff --git a/vcl/source/app/svapp.cxx b/vcl/source/app/svapp.cxx
index 927cc4a32b60..541256d8c26a 100644
--- a/vcl/source/app/svapp.cxx
+++ b/vcl/source/app/svapp.cxx
@@ -189,7 +189,7 @@ Application::~Application()
// is no memory loss. These counters are more to be able to have an eye
// on amounts of SfxPoolItems used during office usage and to be able to
// detect if an error in future changes may lead to memory losses - these
-// would show in dramaitically higher numbers then imediately
+// would show in dramatically higher numbers then immediately
SAL_WARN("vcl", "ITEM: " << getAllocatedSfxPoolItemCount() << "
SfxPoolItems still allocated at shutdown");
SAL_WARN("vcl", "ITEM: " << getUsedSfxPoolItemCount() << " SfxPoolItems
were incarnated during office usage");
#endif
[Libreoffice-commits] core.git: sc/source
sc/source/filter/oox/pivotcachebuffer.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit b0cfba866a664b6d70a7b10a20da1971c891ab5e Author: Andrea Gelmini AuthorDate: Fri Aug 18 11:31:10 2023 +0200 Commit: Julien Nabet CommitDate: Fri Aug 18 13:53:26 2023 +0200 Fix typo Change-Id: I0c7e1d2c2cf9d20ca40a45d2880ff5dcea4a238d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155830 Tested-by: Julien Nabet Reviewed-by: Julien Nabet diff --git a/sc/source/filter/oox/pivotcachebuffer.cxx b/sc/source/filter/oox/pivotcachebuffer.cxx index e796cfe53da0..3655ffc40391 100644 --- a/sc/source/filter/oox/pivotcachebuffer.cxx +++ b/sc/source/filter/oox/pivotcachebuffer.cxx @@ -720,7 +720,7 @@ OUString PivotCacheField::createParentGroupField( const Reference< XDataPilotFie previous field if that is grouped too. To find the correct group, the first item used to create the group is searched. Calc provides the original item names of the base field -when the group is querried for its members. Its does not +when the group is queried for its members. Its does not provide the names of members that are already groups in the field used to create the new groups. (Is this a bug?) Therefore, a name from the passed list of original item
[Libreoffice-commits] core.git: sfx2/source
sfx2/source/view/lokhelper.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 20f6e960cda073012a56597bf6544524240ce246
Author: Miklos Vajna
AuthorDate: Thu Aug 17 08:24:05 2023 +0200
Commit: Miklos Vajna
CommitDate: Fri Aug 18 13:25:13 2023 +0200
sfx2: fix crash in SfxLokHelper::notifyOtherView()
Crashreport signature:
Fatal signal received: SIGSEGV code: 1 for address: 0x0
program/libmergedlo.so
SfxLokHelper::notifyOtherView(SfxViewShell const*, SfxViewShell
const*, int, boost::property_tree::basic_ptree > const&)
sfx2/source/view/lokhelper.cxx:473
program/libmergedlo.so
ImpEditView::ShowCursor(bool, bool)
editeng/source/editeng/impedit.cxx:1423
program/../program/libsclo.so
ScViewData::SetEditEngine(ScSplitPos, ScEditEngineDefaulter*,
vcl::Window*, short, int)
sc/source/ui/view/viewdata.cxx:1635
program/libsclo.so
ScTabView::UpdateEditView()
sc/source/ui/view/tabview3.cxx:2190
Change-Id: I219a1e9685db9bc3ea03d6ab67ff5db74aac9343
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155823
Tested-by: Jenkins
Reviewed-by: Miklos Vajna
diff --git a/sfx2/source/view/lokhelper.cxx b/sfx2/source/view/lokhelper.cxx
index a6d9ef825e35..5bf6e8a1a2c4 100644
--- a/sfx2/source/view/lokhelper.cxx
+++ b/sfx2/source/view/lokhelper.cxx
@@ -463,7 +463,7 @@ void SfxLokHelper::notifyOtherView(const SfxViewShell*
pThisView, SfxViewShell c
int nType, const
boost::property_tree::ptree& rTree)
{
assert(pThisView != nullptr && "pThisView must be valid");
-if (DisableCallbacks::disabled())
+if (DisableCallbacks::disabled() || !pOtherView)
return;
const int viewId = SfxLokHelper::getView(pThisView);
[Libreoffice-commits] core.git: vcl/source
vcl/source/app/svapp.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit bfa592ab0ce94d1adb905cbd7c1c4a2fd7f16192 Author: Andrea Gelmini AuthorDate: Fri Aug 18 11:30:18 2023 +0200 Commit: Julien Nabet CommitDate: Fri Aug 18 13:52:47 2023 +0200 Fix typo Change-Id: Ia78a6a37b21cd2e286574adcd5fa64818f7d0d75 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155829 Tested-by: Julien Nabet Reviewed-by: Julien Nabet diff --git a/vcl/source/app/svapp.cxx b/vcl/source/app/svapp.cxx index 4b7fc313bbb1..927cc4a32b60 100644 --- a/vcl/source/app/svapp.cxx +++ b/vcl/source/app/svapp.cxx @@ -185,7 +185,7 @@ Application::~Application() // const Cell OBJ_CELL_NONE; // being a static held SfxPoolItem which is not yet de-initialized here // number often is (1), even higher with other modules loaded (like 5). -// These get de-allocated reliaby in module-deinitializations, so this +// These get de-allocated reliably in module-deinitializations, so this // is no memory loss. These counters are more to be able to have an eye // on amounts of SfxPoolItems used during office usage and to be able to // detect if an error in future changes may lead to memory losses - these
Re: Building Doxygen documentation
On 18/08/2023 11:02, Chris Tapp wrote: On 17 Aug 2023, at 17:42, Michael Stahl wrote: On 17/08/2023 18:12, Chris Tapp wrote: However, the following is reported: *** Executable unoapploader must be registered in Repository.mk or RepositoryExternal.mk. Stop. What do I need to add to these files to fix this? the problem is, you can't just build a single module (odk is a top-level directory aka module) without having a complete build of everything first (just "make"). note that "docs" is not a module, but just a target in the top-level makefile, so you should be able run that one without building LO (just from memory, i haven't done this in ages). I should have mentioned that I have already run a complete build. okay i guess that means you have --disable-odk then, or i think that's the default nowadays, you'd need --enable-odk in autogen.input to be able to build that.
[Libreoffice-commits] help.git: source/text
source/text/scalc/01/04060112.xhp |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) New commits: commit 01eaa54adbab405db6aad6c2d476bd4ee775e61f Author: Olivier Hallot AuthorDate: Fri Aug 18 15:09:52 2023 +0200 Commit: Olivier Hallot CommitDate: Fri Aug 18 15:22:57 2023 +0200 Mute l10n on string Change-Id: I7c4eddb32ca0551f0683d380c202946ea754d0de Reviewed-on: https://gerrit.libreoffice.org/c/help/+/155777 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/source/text/scalc/01/04060112.xhp b/source/text/scalc/01/04060112.xhp index 42cfa5ec52..20c7f3f71e 100644 --- a/source/text/scalc/01/04060112.xhp +++ b/source/text/scalc/01/04060112.xhp @@ -116,7 +116,7 @@ void CALLTYPE fn(out, in1, in2, ...) Output: Resulting value Input: Any number of types (double, char*, double*, char**, Cell area), where the Cell area is an array of types double array, string array, or cell array. -GetFunctionCount() +GetFunctionCount() Returns the number of functions without the management functions of the reference parameter. Each function has a unique number between 0 and nCount-1. This number will be needed for the GetFunctionData and GetParameterDescription functions later. Syntax @@ -127,7 +127,7 @@ USHORT nCount: Output: Reference to a variable, which is supposed to contain the number of Add-In functions. For example: If the Add-In provides 5 functions for $[officename] Calc, then nCount=5. -GetFunctionData() +GetFunctionData() Determines all the important information about an Add-In function. Syntax @@ -148,7 +148,7 @@ char* pInternalName: Output: Function name as seen by the user, as it appears in the Function Wizard. May contain umlauts. The pFuncName and pInternalName parameters are char arrays, which are implemented with size 256 in $[officename] Calc. -GetParameterDescription() +GetParameterDescription() Provides a brief description of the Add-In function and its parameters. As an option, this function can be used to show a function and parameter description in the Function Wizard. Syntax
[Libreoffice-commits] core.git: sw/CppunitTest_sw_core_layout.mk sw/qa sw/source
sw/CppunitTest_sw_core_layout.mk |1
sw/qa/core/layout/data/split-table-border.odt |binary
sw/qa/core/layout/paintfrm.cxx| 71 +++
sw/source/core/layout/paintfrm.cxx| 80 ++
4 files changed, 152 insertions(+)
New commits:
commit 53798fef2cc0b5b0b9706081a4af5ceca964a41b
Author: Miklos Vajna
AuthorDate: Fri Aug 18 11:21:25 2023 +0200
Commit: Miklos Vajna
CommitDate: Fri Aug 18 14:52:56 2023 +0200
Related: tdf#156351 sw floattable: fix missing top border in follow table
The problem was that in case a table has a table border but no cell
border, then the follow table was missing a top border in case the
follow table had multiple rows.
This was already working for single-row follow tables since commit
a4da71fb824f2d4ecc7c01f4deb2865ba52f5f4c (INTEGRATION: CWS fmebugs04
(1.115.46); FILE MERGED 2008/05/13 13:56:19 fme 1.115.46.2: #i9860# Top
border for tables - correction 2008/05/13 13:49:23 fme 1.115.46.1:
i#9860 Top border for tables, 2008-06-06).
Fix the problem by checking for the case when the first row in a follow
table has no own bottom border and then take that bottom border from the
last row instead, if that has a bottom border.
The reported case around the missing bottom border in the master table
still needs work.
Change-Id: Ib418da99067a42efcf3bd0e2d6a9467797de619a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155824
Reviewed-by: Miklos Vajna
Tested-by: Jenkins
diff --git a/sw/CppunitTest_sw_core_layout.mk b/sw/CppunitTest_sw_core_layout.mk
index be208df04165..9431b6b83526 100644
--- a/sw/CppunitTest_sw_core_layout.mk
+++ b/sw/CppunitTest_sw_core_layout.mk
@@ -16,6 +16,7 @@ $(eval $(call
gb_CppunitTest_use_common_precompiled_header,sw_core_layout))
$(eval $(call gb_CppunitTest_add_exception_objects,sw_core_layout, \
sw/qa/core/layout/flycnt \
sw/qa/core/layout/layout \
+sw/qa/core/layout/paintfrm \
sw/qa/core/layout/tabfrm \
))
diff --git a/sw/qa/core/layout/data/split-table-border.odt
b/sw/qa/core/layout/data/split-table-border.odt
new file mode 100644
index ..743d54bd38c5
Binary files /dev/null and b/sw/qa/core/layout/data/split-table-border.odt
differ
diff --git a/sw/qa/core/layout/paintfrm.cxx b/sw/qa/core/layout/paintfrm.cxx
new file mode 100644
index ..15b9df6a4fb4
--- /dev/null
+++ b/sw/qa/core/layout/paintfrm.cxx
@@ -0,0 +1,71 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#include
+
+#include
+
+#include
+#include
+
+namespace
+{
+/// Covers sw/source/core/layout/paintfrm.cxx fixes.
+class Test : public SwModelTestBase
+{
+public:
+Test()
+: SwModelTestBase("/sw/qa/core/layout/data/")
+{
+}
+};
+
+CPPUNIT_TEST_FIXTURE(Test, testSplitTableBorder)
+{
+// Given a document with a split table, table borders are defined, but
cell borders are not:
+createSwDoc("split-table-border.odt");
+SwXTextDocument* pTextDoc =
dynamic_cast(mxComponent.get());
+SwDocShell* pShell = pTextDoc->GetDocShell();
+
+// When rendering that document:
+std::shared_ptr xMetaFile = pShell->GetPreviewMetaFile();
+
+// Then make sure that the follow table has a top border:
+MetafileXmlDump aDumper;
+xmlDocUniquePtr pXmlDoc = dumpAndParse(aDumper, *xMetaFile);
+xmlXPathObjectPtr pXmlObj = getXPathNode(pXmlDoc,
"//polyline[@style='solid']/point");
+xmlNodeSetPtr pXmlNodes = pXmlObj->nodesetval;
+int nHorizontalBorders = 0;
+// Count the horizontal borders:
+for (int i = 0; i < xmlXPathNodeSetGetLength(pXmlNodes); i += 2)
+{
+xmlNodePtr pStart = pXmlNodes->nodeTab[i];
+xmlNodePtr pEnd = pXmlNodes->nodeTab[i + 1];
+xmlChar* pStartY = xmlGetProp(pStart, BAD_CAST("y"));
+xmlChar* pEndY = xmlGetProp(pEnd, BAD_CAST("y"));
+sal_Int32 nStartY = o3tl::toInt32(reinterpret_cast(pStartY));
+sal_Int32 nEndY = o3tl::toInt32(reinterpret_cast(pEndY));
+if (nStartY != nEndY)
+{
+// Vertical border.
+continue;
+}
+
+++nHorizontalBorders;
+}
+xmlXPathFreeObject(pXmlObj);
+// Without the accompanying fix in place, this test would have failed with:
+// - Expected: 3
+// - Actual : 2
+// i.e. the top border in the follow table was missing.
+CPPUNIT_ASSERT_EQUAL(3, nHorizontalBorders);
+}
+}
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sw/source/core/layout/paintfrm.cxx
b/sw/source/core/layout/paintfrm.cxx
index e1f6e12827fe..51dabd080b01 100644
---
[Libreoffice-commits] core.git: cui/source cui/uiconfig
cui/source/inc/paragrph.hxx |8 +++
cui/source/tabpages/paragrph.cxx | 40 +++
cui/uiconfig/ui/textflowpage.ui | 16 +--
3 files changed, 34 insertions(+), 30 deletions(-)
New commits:
commit 47edf86a62784aa275de7cc89df01a4fcd4e90c8
Author: Samuel Mehrbrodt
AuthorDate: Thu Aug 17 14:56:11 2023 +0200
Commit: Samuel Mehrbrodt
CommitDate: Fri Aug 18 15:23:41 2023 +0200
tdf#156795, tdf#156109 Avoid typesetter language: orphan, widow control
Instead use descriptive language to make it obvious what these options are
for.
Also invert the logic of the "Do not split paragraph" option as suggested
in tdf#156109.
Change-Id: I619c0558597aff26b8b7fafea3548d8bf1f24a36
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155769
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt
diff --git a/cui/source/inc/paragrph.hxx b/cui/source/inc/paragrph.hxx
index 2b6f26fd25d8..9e78c8311015 100644
--- a/cui/source/inc/paragrph.hxx
+++ b/cui/source/inc/paragrph.hxx
@@ -219,7 +219,7 @@ private:
weld::TriStateEnabled aPageBreakState;
weld::TriStateEnabled aApplyCollState;
weld::TriStateEnabled aPageNumState;
-weld::TriStateEnabled aKeepTogetherState;
+weld::TriStateEnabled aAllowSplitState;
weld::TriStateEnabled aKeepParaState;
weld::TriStateEnabled aOrphanState;
weld::TriStateEnabled aWidowState;
@@ -255,7 +255,7 @@ private:
std::unique_ptr m_xPagenumEdit;
// paragraph division
-std::unique_ptr m_xKeepTogetherBox;
+std::unique_ptr m_xAllowSplitBox;
std::unique_ptr m_xKeepParaBox;
// orphan/widow
@@ -271,12 +271,12 @@ private:
void PageNumBoxClickHdl();
void ApplyCollClickHdl();
void PageBreakHdl();
-void KeepTogetherHdl();
+void AllowSplitHdl();
void OrphanHdl();
void WidowHdl();
DECL_LINK(PageBreakHdl_Impl, weld::Toggleable&, void);
-DECL_LINK(KeepTogetherHdl_Impl, weld::Toggleable&, void);
+DECL_LINK(AllowSplitHdl_Impl, weld::Toggleable&, void);
DECL_LINK(WidowHdl_Impl, weld::Toggleable&, void);
DECL_LINK(OrphanHdl_Impl, weld::Toggleable&, void);
DECL_LINK(HyphenClickHdl_Impl, weld::Toggleable&, void);
diff --git a/cui/source/tabpages/paragrph.cxx b/cui/source/tabpages/paragrph.cxx
index ff06ee623c8e..957431e565a9 100644
--- a/cui/source/tabpages/paragrph.cxx
+++ b/cui/source/tabpages/paragrph.cxx
@@ -1753,9 +1753,9 @@ bool SvxExtParagraphTabPage::FillItemSet( SfxItemSet*
rOutSet )
// paragraph split
_nWhich = GetWhich( SID_ATTR_PARA_SPLIT );
-eState = m_xKeepTogetherBox->get_state();
+eState = m_xAllowSplitBox->get_state();
-if (m_xKeepTogetherBox->get_state_changed_from_saved())
+if (m_xAllowSplitBox->get_state_changed_from_saved())
{
pOld = GetOldItem( *rOutSet, SID_ATTR_PARA_SPLIT );
@@ -2056,13 +2056,13 @@ void SvxExtParagraphTabPage::Reset( const SfxItemSet*
rSet )
{
const SvxFormatSplitItem& rSplit =
static_cast(rSet->Get( _nWhich ));
-aKeepTogetherState.bTriStateEnabled = false;
+aAllowSplitState.bTriStateEnabled = false;
if ( !rSplit.GetValue() )
-m_xKeepTogetherBox->set_state(TRISTATE_TRUE);
+m_xAllowSplitBox->set_state(TRISTATE_FALSE);
else
{
-m_xKeepTogetherBox->set_state(TRISTATE_FALSE);
+m_xAllowSplitBox->set_state(TRISTATE_TRUE);
// default widows and orphans to enabled
m_xWidowBox->set_sensitive(true);
m_xOrphanBox->set_sensitive(true);
@@ -2113,12 +2113,12 @@ void SvxExtParagraphTabPage::Reset( const SfxItemSet*
rSet )
aOrphanState.eState = m_xOrphanBox->get_state();
}
else if ( SfxItemState::DONTCARE == eItemState )
-m_xKeepTogetherBox->set_state(TRISTATE_INDET);
+m_xAllowSplitBox->set_state(TRISTATE_INDET);
else
-m_xKeepTogetherBox->set_sensitive(false);
+m_xAllowSplitBox->set_sensitive(false);
// so that everything is enabled correctly
-KeepTogetherHdl();
+AllowSplitHdl();
WidowHdl();
OrphanHdl();
ChangesApplied();
@@ -2144,7 +2144,7 @@ void SvxExtParagraphTabPage::ChangesApplied()
m_xApplyCollBox->save_value();
m_xPageNumBox->save_state();
m_xPagenumEdit->save_value();
-m_xKeepTogetherBox->save_state();
+m_xAllowSplitBox->save_state();
m_xKeepParaBox->save_state();
m_xWidowBox->save_state();
m_xOrphanBox->save_state();
@@ -2202,7 +2202,7 @@
SvxExtParagraphTabPage::SvxExtParagraphTabPage(weld::Container* pPage, weld::Dia
, m_xPageNumBox(m_xBuilder->weld_check_button("labelPageNum"))
, m_xPagenumEdit(m_xBuilder->weld_spin_button("spinPageNumber"))
// Options
-, m_xKeepTogetherBox(m_xBuilder->weld_check_button("checkSplitPara"))
+, m_xAllowSplitBox(m_xBuilder->weld_check_button("checkSplitPara"))
,
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit abff4a7423a31fc88da63ab92028c22c575131ee Author: Olivier Hallot AuthorDate: Fri Aug 18 15:22:57 2023 +0200 Commit: Gerrit Code Review CommitDate: Fri Aug 18 15:22:57 2023 +0200 Update git submodules * Update helpcontent2 from branch 'master' to 01eaa54adbab405db6aad6c2d476bd4ee775e61f - Mute l10n on string Change-Id: I7c4eddb32ca0551f0683d380c202946ea754d0de Reviewed-on: https://gerrit.libreoffice.org/c/help/+/155777 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/helpcontent2 b/helpcontent2 index ebdeebb9b004..01eaa54adbab 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit ebdeebb9b004df574ec90ead903ffa9c9b1f3235 +Subproject commit 01eaa54adbab405db6aad6c2d476bd4ee775e61f
Re: Building Doxygen documentation
> On 18 Aug 2023, at 11:57, Michael Stahl wrote: > > On 18/08/2023 11:02, Chris Tapp wrote: >> On 17 Aug 2023, at 17:42, Michael Stahl wrote: >>> >>> On 17/08/2023 18:12, Chris Tapp wrote: > However, the following is reported: *** Executable unoapploader must be registered in Repository.mk or RepositoryExternal.mk. Stop. What do I need to add to these files to fix this? >>> >>> the problem is, you can't just build a single module (odk is a top-level >>> directory aka module) without having a complete build of everything first >>> (just "make"). >>> >>> note that "docs" is not a module, but just a target in the top-level >>> makefile, so you should be able run that one without building LO (just from >>> memory, i haven't done this in ages). >> I should have mentioned that I have already run a complete build. > > okay i guess that means you have --disable-odk then, or i think that's the > default nowadays, you'd need --enable-odk in autogen.input to be able to > build that. I’ve added —enable-odk to autogen.input, run “make clean” and then “make docs”, but I’m still being told “You need the graphviz tools to create the nice inheritance graphs”. Chris
Re: Building Doxygen documentation
> On 18 Aug 2023, at 10:44, Ilmari Lauhakangas > wrote: > > On 18.8.2023 12.02, Chris Tapp wrote: >> On 17 Aug 2023, at 17:42, Michael Stahl wrote: >>> >>> On 17/08/2023 18:12, Chris Tapp wrote: I am trying to build the doxygen documentation using: make odk as instructed on https://wiki.documentfoundation.org/Development/Doxygen >>> >>> this wiki page is very confused. >>> >>> almost everything of it is about documenting *internal* LO code with >>> doxygen, except for the "Building" section, which is about building the >>> *public* API documentation with doxygen - 2 different things! >>> >>> the internal LO code documentation can be built with "make docs". >> Thanks, that gets me a bit further - I am now told that "You need the >> graphviz tools to create the nice inheritance graphs”. How do I install it >> into the LODE build environment? > > On Windows, run the Cygwin setup and search for the graphviz package. My bad - I should have said I’m building under MacOS. > You can also view the docs online: https://api.libreoffice.org/ > > Ilmari
Re: Building Doxygen documentation
On 8/18/23 7:15 PM, Chris Tapp wrote: I’ve added —enable-odk to autogen.input, run “make clean” and then “make docs”, but I’m still being told “You need the graphviz tools to create the nice inheritance graphs”. So I tried "make docs" and I get the same error. I looked at the script that make executes and it is looking for the "dot" command. Maybe the missing piece is that a "graphviz" package needs to be installed via Homebrew or MacPorts? Patrick
[Libreoffice-bugs] [Bug 139532] [META] DOCX Floating table related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=139532 Bug 139532 depends on bug 80717, which changed state. Bug 80717 Summary: FILEOPEN: DOC DOCX file has incorrect vertical position relative to 'page' of floating table (comment 28) https://bugs.documentfoundation.org/show_bug.cgi?id=80717 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 80717] FILEOPEN: DOC DOCX file has incorrect vertical position relative to 'page' of floating table (comment 28)
https://bugs.documentfoundation.org/show_bug.cgi?id=80717 Justin L changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #30 from Justin L --- Interesting fact: in MS Word 2010 these two .doc files take up two pages, while comment 12 shows it on one page. Hmmm - even more interesting is that the PDF that MSO2010 generates all fits on one page. (In reply to Justin L from comment #28) > Probably each of the duplicates here will need to be re-assessed one by one. Done > comment 11's GE Bilokin Nadia-fixed.doc had the first table hidden Fixed The DOCX version PageBug-new.docx (comment 14) looks fine in LO - one table follows the other (and spills over onto page 2). [In MSO2010, the second table splits in two, with only the first row showing up on page one as mentioned earlier.] The DOC version PageBug.doc (comment 13) looks more or less like MSO2010 - except that the second table doesn't split into two. However, all of this multi-page stuff was split off into bug 121318 which was marked as NOTOURBUG, and indeed this sounds like a Microsoft Bug since DOC files are opened differently by the latest versions of MS Word. I'm going to mark this as FIXED, since the subject and comment 0 complaint is fixed. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 112700] [META] DOC (binary) table-related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=112700 Bug 112700 depends on bug 80717, which changed state. Bug 80717 Summary: FILEOPEN: DOC DOCX file has incorrect vertical position relative to 'page' of floating table (comment 28) https://bugs.documentfoundation.org/show_bug.cgi?id=80717 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 77760] FILEOPEN: DOCX Text and Tables switch position - table with unchecked "Move with text"
https://bugs.documentfoundation.org/show_bug.cgi?id=77760 Justin L changed: What|Removed |Added CC||jl...@mail.com, ||vmik...@collabora.com --- Comment #15 from Justin L --- repro 24.2+ with comment 14's 39006 anformulairechairessud 4-6.docx Amazing - somehow this table has failed to become floating, even after all of the changes made to float them. I don't see any relevant exceptions... Block table -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 137523] Part of the footer of the first page is not shown at doc opening even is visible at save
https://bugs.documentfoundation.org/show_bug.cgi?id=137523 Michael Stahl (allotropia) changed: What|Removed |Added Attachment #166408|application/octet-stream|application/vnd.oasis.opend mime type||ocument.text -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156812] New: Installation couldn't competed because of corrupted "libreofficedev1.cab" file
https://bugs.documentfoundation.org/show_bug.cgi?id=156812 Bug ID: 156812 Summary: Installation couldn't competed because of corrupted "libreofficedev1.cab" file Product: LibreOffice Version: 24.2.0.0 alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Installation Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: rajasekara...@gmail.com Created attachment 189028 --> https://bugs.documentfoundation.org/attachment.cgi?id=189028=edit installation error Tried to install LO 24.2.0.0.alpha0 on my Windows 10(x64) system.This LO 24.2.0.0.alpha0 was released on 18.08.2023 but couldn't complete because the installation wizard showed like "libreofficedev1.cab is required for this installation is corrupted and can't be used etc".I attached the screenshots for this problem.After I clicked Abort,Retry or Ignore,it showed "Internal Error 2350". I did the typical installation but it existed again. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 137859] Imported .docx doesn't look the same
https://bugs.documentfoundation.org/show_bug.cgi?id=137859 --- Comment #10 from Justin L --- Created attachment 189030 --> https://bugs.documentfoundation.org/attachment.cgi?id=189030=edit Bug_DOCX.mso2010.pdf: LO looks like this too, after a layout refresh This looks nearly perfect now (at least compared to MSO 2010) (and DOES look perfect if you switch to View - web and then back to View - Normal). -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 102847] [META] Quick Find, Search and Replace
https://bugs.documentfoundation.org/show_bug.cgi?id=102847 BogdanB changed: What|Removed |Added Depends on||156780 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=156780 [Bug 156780] Libre Office never ends searching during Find and Replace -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 107656] [META] Frame bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107656 Bug 107656 depends on bug 156419, which changed state. Bug 156419 Summary: Section within Linked Frames Will Not Continue Beyond Page https://bugs.documentfoundation.org/show_bug.cgi?id=156419 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 107738] [META] Section bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107738 Bug 107738 depends on bug 156419, which changed state. Bug 156419 Summary: Section within Linked Frames Will Not Continue Beyond Page https://bugs.documentfoundation.org/show_bug.cgi?id=156419 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156419] Section within Linked Frames Will Not Continue Beyond Page
https://bugs.documentfoundation.org/show_bug.cgi?id=156419 Michael Stahl (allotropia) changed: What|Removed |Added Status|NEW |RESOLVED Assignee|libreoffice-b...@lists.free |michael.st...@allotropia.de |desktop.org | Resolution|--- |FIXED --- Comment #5 from Michael Stahl (allotropia) --- fixed on master -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156806] in German translation of UI dialogue for deleting whole colums lacks a word
https://bugs.documentfoundation.org/show_bug.cgi?id=156806 Julien Nabet changed: What|Removed |Added CC||serval2...@yahoo.fr --- Comment #1 from Julien Nabet --- On pc Debian x86-64 with master sources updated today, I don't reproduce this. It seems already fixed according to https://translations.documentfoundation.org/translate/libo_ui-master/officecfgregistrydataorgopenofficeofficeui/de/?checksum=8dbd2d936db28535=note%3AAG4Qy_by=-priority%2Cposition -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] Cool! LibreOffice is free, open source and very good office suite!
Subject: Cool! LibreOffice is free, open source and very good office suite! Good day from Singapore, I have problems with both of my Microsoft Office Home and Business 2019 licenses. So I had installed a trial version of Microsoft Office on my refurbished Aftershock gaming laptop but it expired on 11 Aug 2023. I couldn't use it any more. I needed an office suite but I do not want to spend SGD$300++ purchasing Microsoft Office licenses. Then I thought of LibreOffice. I quickly downloaded and installed LibreOffice 7.5.5.2. With LibreOffice installed, I used LibreOffice Calc to edit and save my Excel worksheet. When I opened the edited Excel worksheet using Microsoft Excel on my Samsung Galaxy A32 5G Android phone, the Excel worksheet didn't look significantly different. In fact, the Excel worksheet edited by LibreOffice Calc looks the same as if it had been edited by Microsoft Excel. I have decided to uninstall the trial version of Microsoft Office Home and Business 2019 (as it doesn't work anymore) and use LibreOffice permanently! By the way, does LibreOffice have the equivalent of Microsoft Outlook? Thank you LibreOffice development team! Regards, Mr. Turritopsis Dohrnii Teo En Ming Targeted Individual in Singapore Blogs: https://tdtemcerts.blogspot.com https://tdtemcerts.wordpress.com GIMP also stands for Government-Induced Medical Problems.
[Libreoffice-bugs] [Bug 156810] FILESAVE
https://bugs.documentfoundation.org/show_bug.cgi?id=156810 m.a.riosv changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC||miguelangelrv@libreoffice.o ||rg Resolution|--- |DUPLICATE --- Comment #1 from m.a.riosv --- *** This bug has been marked as a duplicate of bug 148170 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148170] Calc: setting print range with the whole column not remember in XLS/X
https://bugs.documentfoundation.org/show_bug.cgi?id=148170 m.a.riosv changed: What|Removed |Added CC||cbuat...@free.fr --- Comment #7 from m.a.riosv --- *** Bug 156810 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-qa] Cool! LibreOffice is free, open source and very good office suite!
Subject: Cool! LibreOffice is free, open source and very good office suite! Good day from Singapore, I have problems with both of my Microsoft Office Home and Business 2019 licenses. So I had installed a trial version of Microsoft Office on my refurbished Aftershock gaming laptop but it expired on 11 Aug 2023. I couldn't use it any more. I needed an office suite but I do not want to spend SGD$300++ purchasing Microsoft Office licenses. Then I thought of LibreOffice. I quickly downloaded and installed LibreOffice 7.5.5.2. With LibreOffice installed, I used LibreOffice Calc to edit and save my Excel worksheet. When I opened the edited Excel worksheet using Microsoft Excel on my Samsung Galaxy A32 5G Android phone, the Excel worksheet didn't look significantly different. In fact, the Excel worksheet edited by LibreOffice Calc looks the same as if it had been edited by Microsoft Excel. I have decided to uninstall the trial version of Microsoft Office Home and Business 2019 (as it doesn't work anymore) and use LibreOffice permanently! By the way, does LibreOffice have the equivalent of Microsoft Outlook? Thank you LibreOffice development team! Regards, Mr. Turritopsis Dohrnii Teo En Ming Targeted Individual in Singapore Blogs: https://tdtemcerts.blogspot.com https://tdtemcerts.wordpress.com GIMP also stands for Government-Induced Medical Problems.
[Libreoffice-bugs] [Bug 75331] FILEOPEN: DOCX - floating table with text wrapping 'around' and vertical position relative to 'page' position is wrong (see Comment 15)
https://bugs.documentfoundation.org/show_bug.cgi?id=75331 Justin L changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #31 from Justin L --- *** This bug has been marked as a duplicate of bug 55160 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 55160] Fileopen: docx layout not imported correctly - support for nested floating tables
https://bugs.documentfoundation.org/show_bug.cgi?id=55160 Justin L changed: What|Removed |Added CC||mikhail.v.gavri...@gmail.co ||m --- Comment #16 from Justin L --- *** Bug 75331 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 120466] [META] DOCX (OOXML) anchor and text wrapping bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=120466 Bug 120466 depends on bug 75331, which changed state. Bug 75331 Summary: FILEOPEN: DOCX - floating table with text wrapping 'around' and vertical position relative to 'page' position is wrong (see Comment 15) https://bugs.documentfoundation.org/show_bug.cgi?id=75331 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139532] [META] DOCX Floating table related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=139532 Bug 139532 depends on bug 75331, which changed state. Bug 75331 Summary: FILEOPEN: DOCX - floating table with text wrapping 'around' and vertical position relative to 'page' position is wrong (see Comment 15) https://bugs.documentfoundation.org/show_bug.cgi?id=75331 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151059] Can't type "^" character with AltGr+3 using Slovenian keyboard, opening Gallery instead
https://bugs.documentfoundation.org/show_bug.cgi?id=151059 Commit Notification changed: What|Removed |Added Whiteboard||target:24.2.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151059] Can't type "^" character with AltGr+3 using Slovenian keyboard, opening Gallery instead
https://bugs.documentfoundation.org/show_bug.cgi?id=151059 --- Comment #7 from Commit Notification --- Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/3614953bf1f4ada22247d04a772d1e3e1d361cef tdf#151059 don't use Ctrl+Alt+3 etc by default for gallery It will be available in 24.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156812] Installation couldn't competed because of corrupted "libreofficedev1.cab" file
https://bugs.documentfoundation.org/show_bug.cgi?id=156812 --- Comment #1 from Rajasekaran Karunanithi --- Created attachment 189029 --> https://bugs.documentfoundation.org/attachment.cgi?id=189029=edit installation error2 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 108357] [META] Writer frame/image/OLE style bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108357 BogdanB changed: What|Removed |Added Depends on||137981 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=137981 [Bug 137981] Image inside frame still present after cutting frame (but invisible) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 137981] Image inside frame still present after cutting frame (but invisible)
https://bugs.documentfoundation.org/show_bug.cgi?id=137981 BogdanB changed: What|Removed |Added Blocks||108357 CC||buzea.bog...@libreoffice.or ||g --- Comment #7 from BogdanB --- Still in Version: 7.5.5.2 (X86_64) / LibreOffice Community Build ID: ca8fe7424262805f223b9a2334bc7181abbcbf5e CPU threads: 4; OS: Linux 6.2; UI render: default; VCL: gtk3 Locale: ro-RO (ro_RO.UTF-8); UI: en-US Calc: threaded Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=108357 [Bug 108357] [META] Writer frame/image/OLE style bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156419] Section within Linked Frames Will Not Continue Beyond Page
https://bugs.documentfoundation.org/show_bug.cgi?id=156419 Commit Notification changed: What|Removed |Added Whiteboard||target:24.2.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139532] [META] DOCX Floating table related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=139532 Bug 139532 depends on bug 141348, which changed state. Bug 141348 Summary: Fileopen DOCX: Floating tables overlap since 4.3 https://bugs.documentfoundation.org/show_bug.cgi?id=141348 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141348] Fileopen DOCX: Floating tables overlap since 4.3
https://bugs.documentfoundation.org/show_bug.cgi?id=141348 Justin L changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #12 from Justin L --- Fixed via backports to LO 7.6 I focused on the overlapping tables on page 3. That was fixed by 24.2 commit a4af5432753408c4eea8a8d56c2f48202160c5fe Author: Miklos Vajna on Mon Jul 17 09:00:33 2023 +0200 tdf#120262 sw floattable, legacy: fix text wrap around fly when no content fits -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 116292] FILEOPEN DOCX: floating table near bottom of page doesn't split across pages
https://bugs.documentfoundation.org/show_bug.cgi?id=116292 Justin L changed: What|Removed |Added CC||jl...@mail.com, ||vmik...@collabora.com --- Comment #12 from Justin L --- still repro 24.2+ @Miklos: I think you want to look at this bug report, as it shows situations where a floating table should flow to the next page when reaching bottom margin. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156810] New: FILESAVE
https://bugs.documentfoundation.org/show_bug.cgi?id=156810 Bug ID: 156810 Summary: FILESAVE Product: LibreOffice Version: 7.5.5.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: cbuat...@free.fr Print Ranges are correctly memorised in format .xls, but not in .xlsx after a file save. The Print ranges "user defined" is reset to "entire sheet" clearing all the ranges defined. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156809] CALC VLOOKUP() & HLOOKUP() column or row insertion corrupts references - they do not expand
https://bugs.documentfoundation.org/show_bug.cgi?id=156809 m.a.riosv changed: What|Removed |Added Resolution|--- |NOTABUG Status|UNCONFIRMED |RESOLVED CC||miguelangelrv@libreoffice.o ||rg --- Comment #2 from m.a.riosv --- You have defined the third parameter with a value, so it doesn't change, no matter what you do inserting/deleting rows/columns. In S4 use a formula like =VLOOKUP(A1;E2:H13;COLUMNS(E1:H1)) In the future, please go to ask.libreoffice.org and ask your question before come here. So you can confirm it is really a bug. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156811] New: Document wrongly marked as modified, only because template has changed.
https://bugs.documentfoundation.org/show_bug.cgi?id=156811 Bug ID: 156811 Summary: Document wrongly marked as modified, only because template has changed. Product: LibreOffice Version: 7.3.7.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: minor Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: 2pet...@gmx.co.uk Description: I often need to consult old reference Writer documents. On opening, I get a dialogue, "Template has been modified". I click Keep Old Styles, but the document is marked as modified (orange dot on the Save icon) immediately it appears. When I exit, I annoyingly get the "Save document?" dialogue. I DO NOT want to change the document because its Modify date may be important. Is it possible to not modify the document if that is what I intend? Steps to Reproduce: 1.Find an old document 2.Change the template 3.Open the document, selecting Keep Old Styles from the Template Changed dialogue 4.Notice the document is marked as modified. Actual Results: The "Save document?" dialogue appears on exit, even though the document has not been changed. Expected Results: You should be able to exit with being prompted to save. Reproducible: Always User Profile Reset: Yes Additional Info: Exit immediately when the document has not been changed. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156310] Cross reference does not jump to number range in a frame
https://bugs.documentfoundation.org/show_bug.cgi?id=156310 --- Comment #5 from Miklos Vajna --- Hm, I don't recall an intentional change from me here. But we could bibisect it. :-) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 156310] Cross reference does not jump to number range in a frame
https://bugs.documentfoundation.org/show_bug.cgi?id=156310 --- Comment #5 from Miklos Vajna --- Hm, I don't recall an intentional change from me here. But we could bibisect it. :-) -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 88173] [META] DOCX (OOXML) format limitations
https://bugs.documentfoundation.org/show_bug.cgi?id=88173 Justin L changed: What|Removed |Added Depends on||91178 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=91178 [Bug 91178] FILEOPEN: docx table export loses inline table spacing (b/c MS formats can't define top/bottom margin for inline tables) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139532] [META] DOCX Floating table related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=139532 Justin L changed: What|Removed |Added Depends on|91178 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=91178 [Bug 91178] FILEOPEN: docx table export loses inline table spacing (b/c MS formats can't define top/bottom margin for inline tables) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 91178] FILEOPEN: docx table export loses inline table spacing (b/c MS formats can't define top/bottom margin for inline tables)
https://bugs.documentfoundation.org/show_bug.cgi?id=91178 Justin L changed: What|Removed |Added Priority|medium |lowest Status|NEW |RESOLVED Resolution|--- |NOTABUG Summary|FILEOPEN: docx table export |FILEOPEN: docx table export |loses table spacing |loses inline table spacing ||(b/c MS formats can't ||define top/bottom margin ||for inline tables) Hardware|Other |All Blocks|139532 |88173 --- Comment #8 from Justin L --- While Gabor's comment 7 may be correct, I'm quite sure this report should just be closed as NOTABUG. Isn't this a limitation of the MS formats? I mean, what is the DOCX setting that would do such a thing? In the UI I don't notice anything that allows a top and bottom margin for an inline table. Floating a table simply to preserve top and bottom margins is a very heavy price to pay - it will cause many more problems than what it is worth. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=88173 [Bug 88173] [META] DOCX (OOXML) format limitations https://bugs.documentfoundation.org/show_bug.cgi?id=139532 [Bug 139532] [META] DOCX Floating table related issues -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 88173] [META] DOCX (OOXML) format limitations
https://bugs.documentfoundation.org/show_bug.cgi?id=88173 Bug 88173 depends on bug 91178, which changed state. Bug 91178 Summary: FILEOPEN: docx table export loses inline table spacing (b/c MS formats can't define top/bottom margin for inline tables) https://bugs.documentfoundation.org/show_bug.cgi?id=91178 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |NOTABUG -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 116583] When using special condensed spacing, underlined text leads to a gap toward the end of the word
https://bugs.documentfoundation.org/show_bug.cgi?id=116583 BogdanB changed: What|Removed |Added Blocks||71732 Summary|When utilizing special |When using special |condensed spacing, |condensed spacing, |underlined text results in |underlined text leads to a |having a gap toward the end |gap toward the end of the |of the word.|word CC||buzea.bog...@libreoffice.or ||g --- Comment #8 from BogdanB --- Aslo in Version: 7.5.5.2 (X86_64) / LibreOffice Community Build ID: ca8fe7424262805f223b9a2334bc7181abbcbf5e CPU threads: 4; OS: Linux 6.2; UI render: default; VCL: gtk3 Locale: ro-RO (ro_RO.UTF-8); UI: en-US Calc: threaded Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=71732 [Bug 71732] [META] Bugs related to text rendering, typography and font features in LO -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 71732] [META] Bugs related to text rendering, typography and font features in LO
https://bugs.documentfoundation.org/show_bug.cgi?id=71732 BogdanB changed: What|Removed |Added Depends on||116583 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=116583 [Bug 116583] When using special condensed spacing, underlined text leads to a gap toward the end of the word -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 131470] Swapping columns across multiple sheets works correctly only on the active sheet
https://bugs.documentfoundation.org/show_bug.cgi?id=131470 BogdanB changed: What|Removed |Added CC||buzea.bog...@libreoffice.or ||g Summary|Swapping columns across |Swapping columns across |multiple sheets works |multiple sheets works |correctly only on the |correctly only on the |active sheet. |active sheet Blocks||108364 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=108364 [Bug 108364] [META] Table/Row/Column/Cell management function bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 60251] [META] ACCESSIBILITY: Tracking Windows OS accessibility and AT issues
https://bugs.documentfoundation.org/show_bug.cgi?id=60251 Bug 60251 depends on bug 156561, which changed state. Bug 156561 Summary: NVDA doesn't announce popup content when it's made visible after the parent widget https://bugs.documentfoundation.org/show_bug.cgi?id=156561 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156770] Sidebar doesn't maintain its user fixed size for example after reload the document or the next time it opens.
https://bugs.documentfoundation.org/show_bug.cgi?id=156770 --- Comment #2 from Davide --- This issue appears from release 7.5.4.2. I just checked 7.6.0.3 and it remains. The same is true for the horizontal space in the gallery side bar of Draw, but I'll post a different bug report for this. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 108519] [META] Page break bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108519 Bug 108519 depends on bug 156728, which changed state. Bug 156728 Summary: Document layout changed: shape is vertically centered instead of aligned to bottom https://bugs.documentfoundation.org/show_bug.cgi?id=156728 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156728] Document layout changed: shape is vertically centered instead of aligned to bottom
https://bugs.documentfoundation.org/show_bug.cgi?id=156728 Michael Stahl (allotropia) changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED Assignee|libreoffice-b...@lists.free |michael.st...@allotropia.de |desktop.org | --- Comment #2 from Michael Stahl (allotropia) --- fixed on master -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156783] LO crash selecting table with the whole document and changing table border
https://bugs.documentfoundation.org/show_bug.cgi?id=156783 Commit Notification changed: What|Removed |Added Whiteboard|target:24.2.0 |target:24.2.0 target:7.6.1 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153718] EDITING In a Calc table, the default document language setting is not honored throughout the table. Instead, some cells are set to English(USA)
https://bugs.documentfoundation.org/show_bug.cgi?id=153718 --- Comment #8 from Buovjaga --- (In reply to Ben Opp from comment #4) > Created attachment 186296 [details] > This sample document exhibited the described behavior, but does not when I > open it now. So you don't see the problem anymore? I see German (Austria) as the language in the cells. (In reply to Ben Opp from comment #7) > Created attachment 186298 [details] > clicking on document language in bottom UI panel, these are the choices > available > > 4 more German dictionaries and English(USA) dictionary are installed, but > not available for selecting. > There is a mismatch between the installed dictionaries and the ones I can > set as document language What if you click Mehr... and select from there? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 108253] [META] Calc cell formula bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108253 Bug 108253 depends on bug 156357, which changed state. Bug 156357 Summary: Cannot copy formula by copying cell when displaying with Show Formula https://bugs.documentfoundation.org/show_bug.cgi?id=156357 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156803] New: Table Cell Background Color select does not remember selected color
https://bugs.documentfoundation.org/show_bug.cgi?id=156803 Bug ID: 156803 Summary: Table Cell Background Color select does not remember selected color Product: LibreOffice Version: 7.5.5.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: vkera...@gmail.com I am creating lots of Writer tables and I use different colors for various cells/rows/columns. If I start working with one color, I think LO should remember my last choice. But when I click somewhere out of the table the selector is going back to yellow. Even when I click on a cell which already has some background color the selector stays on yellow. I think it should stay on the selected color or if it has to change I think it should only change when the user clicks on a cell with background and to choose this particular color. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156789] CALC FORMATTING: Cell background color not rendered when OS high contrast display mode is on
https://bugs.documentfoundation.org/show_bug.cgi?id=156789 --- Comment #17 from Heiko Tietze --- Agree with Ady that this is implemented in a weird way. Plus, switching on via "[x] Automatically detect high contrast mode of OS" under tools > options > a11y is pretty awkward. Besides the question if we need to modify colors at all I believe the configuration should not be affected, in other words the dialog should still show the actual color. Michael, what is your recommendation? Keep colors depending on HC and fix issues (see c14) or drop it and limit HC to the UI only (my preference). -- You are receiving this mail because: You are the assignee for the bug.
