Re: LO 24.2 C++20 baseline

[Miklos Vajna]

Hi Stephan,

On Fri, Sep 22, 2023 at 10:20:31AM +0300, Stephan Bergmann 
 wrote:
> I just submitted
> 
> "Bump baseline to C++20" to master.

gcc-12 looks fine here, but I hit an interesting problem with clang-15
(which worked fine before pulling):

$ make animations
make -j 16 -f 
/home/vmiklos/git/libreoffice/core-clang/compilerplugins/Makefile-clang.mk 
compilerplugins
make[1]: Entering directory '/home/vmiklos/git/libreoffice/core-clang'
make[1]: Nothing to be done for 'compilerplugins'.
make[1]: Leaving directory '/home/vmiklos/git/libreoffice/core-clang'
cd /home/vmiklos/git/libreoffice/core-clang/animations && make -j 16 -rs
[CXX] animations/source/animcore/animcore.cxx
[LOC] top level modules: animations
In file included from 
/home/vmiklos/git/libreoffice/core-clang/animations/source/animcore/animcore.cxx:20:
In file included from 
/home/vmiklos/git/libreoffice/core-clang/workdir/UnoApiHeadersTarget/offapi/normal/com/sun/star/util/XCloneable.hpp:8:
/home/vmiklos/git/libreoffice/core-clang/workdir/UnoApiHeadersTarget/udkapi/normal/com/sun/star/uno/XInterface.hpp:32:65:
 error: invalid application of 'sizeof' to an incomplete type 
'animcore::(anonymous namespace)::AnimationNode'
template inline constexpr auto isUnoInterfaceType = sizeof (T) && 
IsUnoInterfaceType::value;
^~
/home/vmiklos/git/libreoffice/core-clang/include/unotools/weakref.hxx:119:33: 
note: in instantiation of variable template specialization 
'cppu::detail::isUnoInterfaceType' requested here
requires(!cppu::detail::isUnoInterfaceType)
^
/home/vmiklos/git/libreoffice/core-clang/animations/source/animcore/animcore.cxx:309:44:
 note: in instantiation of template class 
'unotools::WeakReference' 
requested here
unotools::WeakReference mxParent;
   ^
/home/vmiklos/git/libreoffice/core-clang/animations/source/animcore/animcore.cxx:121:7:
 note: definition of 'animcore::(anonymous namespace)::AnimationNode' is not 
complete until the closing '}'
class AnimationNode final:  public AnimationNodeBase
  ^
1 error generated.
make[1]: *** 
[/home/vmiklos/git/libreoffice/core-clang/solenv/gbuild/LinkTarget.mk:340: 
/home/vmiklos/git/libreoffice/core-clang/workdir/CxxObject/animations/source/animcore/animcore.o]
 Error 1
make: *** [Makefile:121: animations] Error 2

Given that AnimationNode refers to itself, we probably can't provide a
full type for unotools::WeakReference. But then how to get around this?

Thanks,

Miklos

[Libreoffice-commits] core.git: Branch 'distro/collabora/co-22.05' - desktop/source sfx2/source uui/source

[Szymon Kłos (via logerrit)]

 desktop/source/lib/lokinteractionhandler.cxx |   21 +
 desktop/source/lib/lokinteractionhandler.hxx |2 ++
 sfx2/source/doc/sfxbasemodel.cxx |4 +++-
 uui/source/iahndl.cxx|2 +-
 4 files changed, 27 insertions(+), 2 deletions(-)

New commits:
commit 0121412b57b0be847474547f00686aa335dcd2a5
Author: Szymon Kłos 
AuthorDate: Fri Sep 22 11:11:06 2023 +0200
Commit: Szymon Kłos 
CommitDate: Mon Sep 25 15:34:40 2023 +0200

lok: add broken package interaction handler

in case of repair don't use template flag to not make
file readonly so we can overwrite it and upload to storage
updated version

Change-Id: Ia460009fc3b77582dde06dd6f94a85aef3aee11b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157168
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Ashod Nakashian 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157240

diff --git a/desktop/source/lib/lokinteractionhandler.cxx 
b/desktop/source/lib/lokinteractionhandler.cxx
index 1e794c0ff651..deebb5d2a30a 100644
--- a/desktop/source/lib/lokinteractionhandler.cxx
+++ b/desktop/source/lib/lokinteractionhandler.cxx
@@ -24,6 +24,7 @@
 #include 
 #include 
 
+#include 
 #include 
 #include 
 #include 
@@ -351,6 +352,23 @@ bool 
LOKInteractionHandler::handleMacroConfirmationRequest(const uno::Reference<
 return false;
 }
 
+bool LOKInteractionHandler::handlePackageReparationRequest(const 
uno::Reference& xRequest)
+{
+uno::Any const request(xRequest->getRequest());
+
+document::BrokenPackageRequest aBrokenPackageRequest;
+if (request >>= aBrokenPackageRequest)
+{
+auto 
xInteraction(task::InteractionHandler::createWithParent(comphelper::getProcessComponentContext(),
 nullptr));
+
+if (xInteraction.is())
+xInteraction->handleInteractionRequest(xRequest);
+
+return true;
+}
+return false;
+}
+
 bool LOKInteractionHandler::handleFilterOptionsRequest(const 
uno::Reference& xRequest)
 {
 document::FilterOptionsRequest aFilterOptionsRequest;
@@ -390,6 +408,9 @@ sal_Bool SAL_CALL 
LOKInteractionHandler::handleInteractionRequest(
 if (handleMacroConfirmationRequest(xRequest))
 return true;
 
+if (handlePackageReparationRequest(xRequest))
+return true;
+
 // TODO: perform more interactions 'for real' like the above
 selectApproved(rContinuations);
 
diff --git a/desktop/source/lib/lokinteractionhandler.hxx 
b/desktop/source/lib/lokinteractionhandler.hxx
index 108343ec22e3..fdbea01c64f6 100644
--- a/desktop/source/lib/lokinteractionhandler.hxx
+++ b/desktop/source/lib/lokinteractionhandler.hxx
@@ -78,6 +78,8 @@ private:
 
 static bool handleFilterOptionsRequest(const 
::com::sun::star::uno::Reference<::com::sun::star::task::XInteractionRequest>& 
Request);
 
+static bool handlePackageReparationRequest(const 
css::uno::Reference& xRequest);
+
 public:
 void SetPassword(char const* pPassword);
 
diff --git a/sfx2/source/doc/sfxbasemodel.cxx b/sfx2/source/doc/sfxbasemodel.cxx
index 6554ed1f317e..c5768afc7493 100644
--- a/sfx2/source/doc/sfxbasemodel.cxx
+++ b/sfx2/source/doc/sfxbasemodel.cxx
@@ -1941,9 +1941,11 @@ void SAL_CALL SfxBaseModel::load(   const Sequence< 
beans::PropertyValue >& seqA
 xHandler->handle( aRequest.GetRequest() );
 if( aRequest.isApproved() )
 {
+// lok: we want to overwrite file in jail, so don't use 
template flag
+bool bIsLOK = comphelper::LibreOfficeKit::isActive();
 // broken package: try second loading and allow repair
 pMedium->GetItemSet()->Put( SfxBoolItem( 
SID_REPAIRPACKAGE, true ) );
-pMedium->GetItemSet()->Put( SfxBoolItem( SID_TEMPLATE, 
true ) );
+pMedium->GetItemSet()->Put( SfxBoolItem( SID_TEMPLATE, 
!bIsLOK ) );
 pMedium->GetItemSet()->Put( SfxStringItem( 
SID_DOCINFO_TITLE, aDocName ) );
 
 // the error must be reset and the storage must be 
reopened in new mode
diff --git a/uui/source/iahndl.cxx b/uui/source/iahndl.cxx
index 251a642e509f..a01e090c5d4c 100644
--- a/uui/source/iahndl.cxx
+++ b/uui/source/iahndl.cxx
@@ -948,7 +948,7 @@ executeMessageBox(
 SolarMutexGuard aGuard;
 
 std::unique_ptr 
xBox(Application::CreateMessageDialog(pParent, eMessageType,
-eMessageType == VclMessageType::Question ? VclButtonsType::YesNo : 
VclButtonsType::Ok, rMessage));
+eMessageType == VclMessageType::Question ? VclButtonsType::YesNo : 
VclButtonsType::Ok, rMessage, GetpApp()));
 xBox->set_title(rTitle);
 
 short nMessResult = xBox->run();

[Libreoffice-commits] core.git: Branch 'distro/collabora/co-23.05' - cui/source

[Balazs Varga (via logerrit)]

 cui/source/inc/QrCodeGenDialog.hxx |2 ++
 1 file changed, 2 insertions(+)

New commits:
commit 21554305046e7faeb6d64c4eea622b968db1f474
Author: Balazs Varga 
AuthorDate: Mon Sep 25 14:07:21 2023 +0200
Commit: Miklos Vajna 
CommitDate: Mon Sep 25 15:28:12 2023 +0200

COWASM-02 - Fix wasm build for co-23.05

"Undeclared identifier mpParent in GetParent()"

Change-Id: Ib613b2cf303b0ac50c6e899deda25d99c7e22343
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157245
Reviewed-by: Miklos Vajna 
Tested-by: Jenkins CollaboraOffice 

diff --git a/cui/source/inc/QrCodeGenDialog.hxx 
b/cui/source/inc/QrCodeGenDialog.hxx
index e477c0b44879..02037ad4cdf6 100644
--- a/cui/source/inc/QrCodeGenDialog.hxx
+++ b/cui/source/inc/QrCodeGenDialog.hxx
@@ -28,7 +28,9 @@ public:
  const std::function& rFunc);
 
 void Apply();
+#if ENABLE_ZXING
 weld::Widget* GetParent() { return mpParent; }
+#endif
 
 private:
 css::uno::Reference m_xModel;

TB Linux WASM fails to build because obsolete gcc

[Julien Nabet]

Hello Christian, Guilhem

Would it be possible to upgrade gcc version on TB 481 (Linux-WASM) ?

Indeed the error is quite explicit:

"configure: error: GCC 7.5.0 is too old, must be at least GCC 12"

(see 
https://ci.libreoffice.org/view/tb%20platform%20status/job/lo_daily_tb_linux_wasm/481/console)


I don't know who's responsible for this one, I didn't find infos about 
this TB in https://wiki.documentfoundation.org/Development/Tinderbox


Julien

[Libreoffice-commits] core.git: download.lst

[Michael Stahl (via logerrit)]

 download.lst |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 3daab618c759be2b93ad337061ef347c76229a22
Author: Michael Stahl 
AuthorDate: Mon Sep 25 14:22:40 2023 +0200
Commit: Michael Stahl 
CommitDate: Mon Sep 25 16:07:12 2023 +0200

libtommath: upgrade to release 1.2.1

Fixes CVE-2023-36328.

Change-Id: I1193f5df789c7dd10855e35936fc2697697c464e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157246
Tested-by: Jenkins
Reviewed-by: Michael Stahl 

diff --git a/download.lst b/download.lst
index 71ab2bd818d5..decd950eace6 100644
--- a/download.lst
+++ b/download.lst
@@ -334,8 +334,8 @@ LIBNUMBERTEXT_TARBALL := libnumbertext-1.0.11.tar.xz
 # three static lines
 # so that git cherry-pick
 # will not run into conflicts
-LIBTOMMATH_SHA256SUM := 
b7c75eecf680219484055fcedd686064409254ae44bc31a96c5032843c0e18b1
-LIBTOMMATH_TARBALL := ltm-1.2.0.tar.xz
+LIBTOMMATH_SHA256SUM := 
986025d7b374276fee2e30e99f3649e4ac0db8a02257a37ee10eae72abed0d1f
+LIBTOMMATH_TARBALL := ltm-1.2.1.tar.xz
 # three static lines
 # so that git cherry-pick
 # will not run into conflicts

[Libreoffice-commits] core.git: download.lst external/poppler

[Michael Stahl (via logerrit)]

 download.lst  |4 ++--
 external/poppler/StaticLibrary_poppler.mk |6 +-
 external/poppler/disable-freetype.patch.1 |2 +-
 external/poppler/poppler-config.patch.1   |   27 +++
 4 files changed, 19 insertions(+), 20 deletions(-)

New commits:
commit 3d31dfa9b99d0df5e400c1a6d7e8df6c46129b3c
Author: Michael Stahl 
AuthorDate: Mon Sep 25 15:50:43 2023 +0200
Commit: Michael Stahl 
CommitDate: Mon Sep 25 17:06:25 2023 +0200

poppler: upgrade to release 23.09.0

Fixes CVE-2023-34872

Change-Id: I289b3016695a01aff7d393cb09d66cd726d9b592
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157247
Tested-by: Jenkins
Reviewed-by: Michael Stahl 

diff --git a/download.lst b/download.lst
index decd950eace6..a046718e0151 100644
--- a/download.lst
+++ b/download.lst
@@ -463,8 +463,8 @@ LIBTIFF_TARBALL := tiff-4.5.1.tar.xz
 # three static lines
 # so that git cherry-pick
 # will not run into conflicts
-POPPLER_SHA256SUM := 
d38c6b2f31c8f6f3727fb60a011a0e6c567ebf56ef1ccad36263ca9ed6448a65
-POPPLER_TARBALL := poppler-23.06.0.tar.xz
+POPPLER_SHA256SUM := 
80d1d44dd8bdf4ac1a47d56c5065075eb9991790974b1ed7d14b972acde88e55
+POPPLER_TARBALL := poppler-23.09.0.tar.xz
 POPPLER_DATA_SHA256SUM := 
c835b640a40ce357e1b83666aabd95edffa24d49b8daff63adb851cdab74
 POPPLER_DATA_TARBALL := poppler-data-0.4.12.tar.gz
 # three static lines
diff --git a/external/poppler/StaticLibrary_poppler.mk 
b/external/poppler/StaticLibrary_poppler.mk
index c8c2e47c43d1..7b6f958245ac 100644
--- a/external/poppler/StaticLibrary_poppler.mk
+++ b/external/poppler/StaticLibrary_poppler.mk
@@ -13,7 +13,10 @@ $(eval $(call gb_StaticLibrary_use_unpacked,poppler,poppler))
 
 $(eval $(call 
gb_StaticLibrary_set_precompiled_header,poppler,external/poppler/inc/pch/precompiled_poppler))
 
-$(eval $(call gb_StaticLibrary_use_external,poppler,libjpeg))
+$(eval $(call gb_StaticLibrary_use_externals,poppler,\
+   libjpeg \
+   zlib \
+))
 
 $(eval $(call gb_StaticLibrary_set_warnings_disabled,poppler))
 
@@ -92,6 +95,7 @@ $(eval $(call 
gb_StaticLibrary_add_generated_exception_objects,poppler,\
UnpackedTarball/poppler/poppler/FDPDFDocBuilder \
UnpackedTarball/poppler/poppler/FILECacheLoader \
UnpackedTarball/poppler/poppler/FileSpec \
+   UnpackedTarball/poppler/poppler/FlateEncoder \
UnpackedTarball/poppler/poppler/FontEncodingTables \
UnpackedTarball/poppler/poppler/FontInfo \
UnpackedTarball/poppler/poppler/Form \
diff --git a/external/poppler/disable-freetype.patch.1 
b/external/poppler/disable-freetype.patch.1
index 77c643de40f5..3c4d1d0f7a8a 100644
--- a/external/poppler/disable-freetype.patch.1
+++ b/external/poppler/disable-freetype.patch.1
@@ -19,9 +19,9 @@ disable freetype dependent code
 -#include FT_FREETYPE_H
 +//#include 
 +//#include FT_FREETYPE_H
+ #include 
  
  // helper for using std::visit to get a dependent false for static_asserts
- // to help get compile errors if one ever extends variants
 @@ -2760,6 +2760,8 @@
  
  Form::AddFontResult Form::addFontToDefaultResources(const std::string 
, int faceIndex, const std::string , const std::string 
, bool forceName)
diff --git a/external/poppler/poppler-config.patch.1 
b/external/poppler/poppler-config.patch.1
index be8fc98556a7..8f71e987b2b9 100644
--- a/external/poppler/poppler-config.patch.1
+++ b/external/poppler/poppler-config.patch.1
@@ -2,7 +2,7 @@
 
 note: to get the 3rd one, use -DENABLE_CPP=on
 
-mkdir build && cd build && cmake .. -DENABLE_DCTDECODER=libjpeg 
-DHAVE_CAIRO=off -DENABLE_LIBOPENJPEG=none -DENABLE_CMS=none 
-DENABLE_LIBCURL=off -DENABLE_ZLIB=off -DENABLE_ZLIB_UNCOMPRESS=off 
-DENABLE_GPGME=off -DENABLE_NSS3=off -DENABLE_LIBPNG=off -DENABLE_LIBTIFF=off 
-DENABLE_SPLASH=off -DENABLE_UTILS=off -DENABLE_CPP=off -DENABLE_GLIB=off 
-DENABLE_GOBJECT_INTROSPECTION=off -DENABLE_GTK_DOC=off -DENABLE_QT5=off 
-DENABLE_QT6
+mkdir build && cd build && cmake .. -DENABLE_DCTDECODER=libjpeg 
-DHAVE_CAIRO=off -DENABLE_LIBOPENJPEG=none -DENABLE_CMS=none 
-DENABLE_LIBCURL=off -DENABLE_ZLIB_UNCOMPRESS=off -DENABLE_GPGME=off 
-DENABLE_NSS3=off -DENABLE_LIBPNG=off -DENABLE_LIBTIFF=off -DENABLE_SPLASH=off 
-DENABLE_UTILS=off -DENABLE_CPP=off -DENABLE_GLIB=off 
-DENABLE_GOBJECT_INTROSPECTION=off -DENABLE_GTK_DOC=off -DENABLE_QT5=off 
-DENABLE_QT6=off
 
 manually disabled these because cmake failed to do it:
 HAVE_CAIRO
@@ -37,9 +37,6 @@ index 0fbd336a..451213f8 100644
 +/* Do not hardcode the library location */
 +/* #undef ENABLE_RELOCATABLE */
 +
-+/* Build against zlib. */
-+/* #undef ENABLE_ZLIB */
-+
 +/* Use zlib instead of builtin zlib decoder to uncompress flate streams. */
 +/* #undef ENABLE_ZLIB_UNCOMPRESS */
 +
@@ -182,7 +179,7 @@ index 0fbd336a..451213f8 100644
 +#define PACKAGE_NAME "poppler"
 +
 +/* Define to the full name and version of this package. */
-+#define PACKAGE_STRING "poppler 23.06.0"
++#define PACKAGE_STRING 

[Libreoffice-commits] core.git: sw/source

[Caolán McNamara (via logerrit)]

 sw/source/core/text/pormulti.cxx |   13 +
 1 file changed, 9 insertions(+), 4 deletions(-)

New commits:
commit cc564cea7eda29ed7e98ea27056f3ab57a6e2027
Author: Caolán McNamara 
AuthorDate: Mon Sep 25 11:15:36 2023 +0100
Commit: Caolán McNamara 
CommitDate: Mon Sep 25 15:06:19 2023 +0200

ofz#62688 Null-dereference READ in SwRubyPortion::SwRubyPortion

seen with fodt2pdf fuzzer

Change-Id: If761f5ecc473f4c936db82f3fcb7dd891e82573f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157243
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/sw/source/core/text/pormulti.cxx b/sw/source/core/text/pormulti.cxx
index bccc8f6b02c2..2067adcfc155 100644
--- a/sw/source/core/text/pormulti.cxx
+++ b/sw/source/core/text/pormulti.cxx
@@ -2385,6 +2385,11 @@ bool SwTextFormatter::BuildMultiPortion( 
SwTextFormatInfo ,
 return bRet;
 }
 
+static bool IsIncompleteRuby(const SwMultiPortion& rHelpMulti)
+{
+return rHelpMulti.IsRuby() && static_cast(rHelpMulti).GetRubyOffset() < TextFrameIndex(COMPLETE_STRING);
+}
+
 // When a fieldportion at the end of line breaks and needs a following
 // fieldportion in the next line, then the "restportion" of the formatinfo
 // has to be set. Normally this happens during the formatting of the first
@@ -2493,19 +2498,19 @@ SwLinePortion* SwTextFormatter::MakeRestPortion( const 
SwLineLayout* pLine,
 if (!pCreate)
 return pRest;
 
-if( pRest || nMultiPos > nPosition || ( pHelpMulti->IsRuby() &&
-static_cast(pHelpMulti)->GetRubyOffset() < 
TextFrameIndex(COMPLETE_STRING)))
+if( pRest || nMultiPos > nPosition || IsIncompleteRuby(*pHelpMulti))
 {
 SwMultiPortion* pTmp;
 if( pHelpMulti->IsDouble() )
 pTmp = new SwDoubleLinePortion( *pCreate, nMultiPos );
 else if( pHelpMulti->IsBidi() )
 pTmp = new SwBidiPortion( nMultiPos, pCreate->nLevel );
-else if( pHelpMulti->IsRuby() )
+else if (IsIncompleteRuby(*pHelpMulti))
 {
+TextFrameIndex nRubyOffset = static_cast(pHelpMulti)->GetRubyOffset();
 pTmp = new SwRubyPortion( *pCreate, *GetInfo().GetFont(),

m_pFrame->GetDoc().getIDocumentSettingAccess(),
-   nMultiPos, static_cast(pHelpMulti)->GetRubyOffset(),
+   nMultiPos, nRubyOffset,
GetInfo() );
 }
 else if( pHelpMulti->HasRotation() )

Re: LO 24.2 C++20 baseline

[Caolán McNamara]

On Mon, 2023-09-25 at 08:30 +0200, Miklos Vajna wrote:
> /home/vmiklos/git/libreoffice/core-
> clang/workdir/UnoApiHeadersTarget/offapi/normal/com/sun/star/util/XCl
> oneable.hpp:8:
> /home/vmiklos/git/libreoffice/core-
> clang/workdir/UnoApiHeadersTarget/udkapi/normal/com/sun/star/uno/XInt
> erface.hpp:32:65: error: invalid application of 'sizeof' to an
> incomplete type 'animcore::(anonymous namespace)::AnimationNode'

I'm guessing that https://gerrit.libreoffice.org/c/core/+/157250 would
workaround this by just extending:

commit 5831d5f03a5ea5b89984574ffe436f38500726da
Date:   Tue Aug 1 15:37:45 2023 +0200

Don't enable the requires clause for some Xcode Clang

which mentions the same error message, to extend from clang <= 14 to
clang <= 15

Re: LO 24.2 C++20 baseline

[Stephan Bergmann]

On 9/25/23 16:47, Caolán McNamara wrote:

I'm guessing that https://gerrit.libreoffice.org/c/core/+/157250 would
workaround this by just extending:

commit 5831d5f03a5ea5b89984574ffe436f38500726da
Date:   Tue Aug 1 15:37:45 2023 +0200

 Don't enable the requires clause for some Xcode Clang

which mentions the same error message, to extend from clang <= 14 to
clang <= 15


So my dim memories had not failed me :)  Thanks!

[Libreoffice-commits] core.git: Branch 'libreoffice-7-6' - download.lst

[Michael Stahl (via logerrit)]

 download.lst |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 05c7f25b699edff9fa188e09c923b2bf3411ff54
Author: Michael Stahl 
AuthorDate: Mon Sep 25 14:22:40 2023 +0200
Commit: Xisco Fauli 
CommitDate: Mon Sep 25 21:52:23 2023 +0200

libtommath: upgrade to release 1.2.1

Fixes CVE-2023-36328.

Change-Id: I1193f5df789c7dd10855e35936fc2697697c464e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157246
Tested-by: Jenkins
Reviewed-by: Michael Stahl 
(cherry picked from commit 3daab618c759be2b93ad337061ef347c76229a22)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157217
Reviewed-by: Taichi Haradaguchi <20001...@ymail.ne.jp>

diff --git a/download.lst b/download.lst
index ad8d97ebdce4..0044c6a8f3ab 100644
--- a/download.lst
+++ b/download.lst
@@ -329,8 +329,8 @@ LIBNUMBERTEXT_TARBALL := libnumbertext-1.0.11.tar.xz
 # three static lines
 # so that git cherry-pick
 # will not run into conflicts
-LIBTOMMATH_SHA256SUM := 
b7c75eecf680219484055fcedd686064409254ae44bc31a96c5032843c0e18b1
-LIBTOMMATH_TARBALL := ltm-1.2.0.tar.xz
+LIBTOMMATH_SHA256SUM := 
986025d7b374276fee2e30e99f3649e4ac0db8a02257a37ee10eae72abed0d1f
+LIBTOMMATH_TARBALL := ltm-1.2.1.tar.xz
 # three static lines
 # so that git cherry-pick
 # will not run into conflicts

[Libreoffice-commits] core.git: sw/source

[Jim Raykowski (via logerrit)]

 sw/source/uibase/utlui/content.cxx |   21 -
 1 file changed, 16 insertions(+), 5 deletions(-)

New commits:
commit 5e9c8d21874eea8cb5adf2ecab1905295af2308f
Author: Jim Raykowski 
AuthorDate: Sun Sep 24 12:58:04 2023 -0800
Commit: Jim Raykowski 
CommitDate: Tue Sep 26 02:47:10 2023 +0200

tdf#152029 Fix sections not brought to attention in master document

SwSectionFormats::FindFormatByName doesn't seem to find section formats
by name for sections of a document contained in a master document. This
causes the document sections to not be brought to attention by hovering
the mouse over the section entry in the Navigator. This patch makes the
document sections be brought to attention by using an approach similiar
to what is done to fill the sections entries in the Navigator content
tree.

Change-Id: I10e265d23a311440ac91d44b3185f807b205edb3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157231
Tested-by: Jenkins
Reviewed-by: Jim Raykowski 

diff --git a/sw/source/uibase/utlui/content.cxx 
b/sw/source/uibase/utlui/content.cxx
index d8a6e71daa04..77fd3a6f5eb8 100644
--- a/sw/source/uibase/utlui/content.cxx
+++ b/sw/source/uibase/utlui/content.cxx
@@ -5719,12 +5719,23 @@ void SwContentTree::BringEntryToAttention(const 
weld::TreeIter& rEntry)
 {
 BringBookmarksToAttention(std::vector 
{pCnt->GetName()});
 }
-else if (nType == ContentTypeId::REGION|| nType == 
ContentTypeId::INDEX)
+else if (nType == ContentTypeId::REGION || nType == 
ContentTypeId::INDEX)
 {
-const SwSectionFormats& rFormats = 
m_pActiveShell->GetDoc()->GetSections();
-const SwSectionFormat* pFormat = 
rFormats.FindFormatByName(pCnt->GetName());
-if (pFormat)
-
BringTypesWithFlowFramesToAttention({pFormat->GetSectionNode()});
+size_t nSectionFormatCount = 
m_pActiveShell->GetSectionFormatCount();
+for (size_t i = 0; i < nSectionFormatCount; ++i)
+{
+const SwSectionFormat& rSectionFormat = 
m_pActiveShell->GetSectionFormat(i);
+if (!rSectionFormat.IsInNodesArr())
+continue;
+const SwSection* pSection = rSectionFormat.GetSection();
+if (!pSection)
+continue;
+if (pCnt->GetName() == pSection->GetSectionName())
+{
+
BringTypesWithFlowFramesToAttention({rSectionFormat.GetSectionNode()});
+break;
+}
+}
 }
 else if (nType == ContentTypeId::URLFIELD)
 {

[Libreoffice-commits] core.git: 2 commits - include/oox oox/source sc/source sw/source writerfilter/source

[Tomaž Vajngerl (via logerrit)]

 include/oox/export/drawingml.hxx  |6 ++---
 oox/source/export/drawingml.cxx   |   26 --
 oox/source/export/vmlexport.cxx   |4 +--
 sc/source/filter/excel/xeescher.cxx   |2 -
 sw/source/filter/ww8/docxattributeoutput.cxx  |6 ++---
 writerfilter/source/dmapper/DomainMapper_Impl.cxx |   19 
 writerfilter/source/dmapper/DomainMapper_Impl.hxx |8 +-
 7 files changed, 36 insertions(+), 35 deletions(-)

New commits:
commit c90de36ede6d35e2cf1ebea195e0ff28f618f319
Author: Tomaž Vajngerl 
AuthorDate: Wed Sep 20 21:22:54 2023 +0200
Commit: Tomaž Vajngerl 
CommitDate: Mon Sep 25 20:26:31 2023 +0200

change bool header or footer parameter to use enum type instead

Is much more readable.

Change-Id: Ie81aaf344758182915796b18efbe25d3f45df4b6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157236
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl 

diff --git a/writerfilter/source/dmapper/DomainMapper_Impl.cxx 
b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
index 72b35d7d544d..13836906c53e 100644
--- a/writerfilter/source/dmapper/DomainMapper_Impl.cxx
+++ b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
@@ -3460,21 +3460,22 @@ void 
DomainMapper_Impl::ConvertHeaderFooterToTextFrame(bool bDynamicHeightTop, b
 }
 }
 
-void DomainMapper_Impl::PushPageHeaderFooter(bool bHeader, 
SectionPropertyMap::PageType eType)
+void DomainMapper_Impl::PushPageHeaderFooter(PagePartType ePagePartType, 
SectionPropertyMap::PageType eType)
 {
 m_bSaveParaHadField = m_bParaHadField;
 m_aHeaderFooterStack.push(HeaderFooterContext(m_bTextInserted, 
m_nTableDepth));
 m_bTextInserted = false;
 m_nTableDepth = 0;
 
-const PropertyIds ePropIsOn = bHeader? PROP_HEADER_IS_ON: 
PROP_FOOTER_IS_ON;
-const PropertyIds ePropShared = bHeader? PROP_HEADER_IS_SHARED: 
PROP_FOOTER_IS_SHARED;
-const PropertyIds ePropTextLeft = bHeader? PROP_HEADER_TEXT_LEFT: 
PROP_FOOTER_TEXT_LEFT;
-const PropertyIds ePropText = bHeader? PROP_HEADER_TEXT: PROP_FOOTER_TEXT;
+bool bHeader = ePagePartType == PagePartType::Header;
+
+const PropertyIds ePropIsOn = bHeader ? PROP_HEADER_IS_ON: 
PROP_FOOTER_IS_ON;
+const PropertyIds ePropShared = bHeader ? PROP_HEADER_IS_SHARED: 
PROP_FOOTER_IS_SHARED;
+const PropertyIds ePropTextLeft = bHeader ? PROP_HEADER_TEXT_LEFT: 
PROP_FOOTER_TEXT_LEFT;
+const PropertyIds ePropText = bHeader ? PROP_HEADER_TEXT: PROP_FOOTER_TEXT;
 
 m_bDiscardHeaderFooter = true;
-m_eInHeaderFooterImport
-= bHeader ? HeaderFooterImportState::header : 
HeaderFooterImportState::footer;
+m_eInHeaderFooterImport = bHeader ? HeaderFooterImportState::header : 
HeaderFooterImportState::footer;
 
 //get the section context
 PropertyMapPtr pContext = 
DomainMapper_Impl::GetTopContextOfType(CONTEXT_SECTION);
@@ -3560,12 +3561,12 @@ void DomainMapper_Impl::PushPageHeaderFooter(bool 
bHeader, SectionPropertyMap::P
 
 void DomainMapper_Impl::PushPageHeader(SectionPropertyMap::PageType eType)
 {
-PushPageHeaderFooter(/* bHeader = */ true, eType);
+PushPageHeaderFooter(PagePartType::Header, eType);
 }
 
 void DomainMapper_Impl::PushPageFooter(SectionPropertyMap::PageType eType)
 {
-PushPageHeaderFooter(/* bHeader = */ false, eType);
+PushPageHeaderFooter(PagePartType::Footer, eType);
 }
 
 void DomainMapper_Impl::PopPageHeaderFooter()
diff --git a/writerfilter/source/dmapper/DomainMapper_Impl.hxx 
b/writerfilter/source/dmapper/DomainMapper_Impl.hxx
index c19de5a5c4b9..676a0d3196d9 100644
--- a/writerfilter/source/dmapper/DomainMapper_Impl.hxx
+++ b/writerfilter/source/dmapper/DomainMapper_Impl.hxx
@@ -426,6 +426,12 @@ struct SymbolData
 { }
 };
 
+enum class PagePartType
+{
+Header,
+Footer
+};
+
 class DomainMapper;
 class DomainMapper_Impl final
 {
@@ -1194,7 +1200,7 @@ public:
 OUString getFontNameForTheme(const Id id);
 
 private:
-void PushPageHeaderFooter(bool bHeader, SectionPropertyMap::PageType 
eType);
+void PushPageHeaderFooter(PagePartType ePagePartType, 
SectionPropertyMap::PageType eType);
 // Start a new index section; if needed, finish current paragraph
 css::uno::Reference 
StartIndexSectionChecked(const OUString& sServiceName);
 std::vector > 
m_vTextFramesForChaining ;
commit 33c347fb3b0fbbae9c1005b1ca7a6105284a6d31
Author: Tomaž Vajngerl 
AuthorDate: Sun Sep 17 23:00:17 2023 +0200
Commit: Tomaž Vajngerl 
CommitDate: Mon Sep 25 20:26:24 2023 +0200

oox: remove returning sRelId and rename WriteImage

Rename WriteImage -> writeGraphicToStorage to make it more clear
what the method does.

Remove returning the rel ID string in some methods that write the
graphic into the stream (or the call chain), as it is never used
later on, so it is better to not return it if it is not used (it
could be abused).

[Libreoffice-commits] core.git: include/unotools

[Caolán McNamara (via logerrit)]

 include/unotools/weakref.hxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 7f75bfd0f6b1bf4debb69e96c114e453c62685f8
Author: Caolán McNamara 
AuthorDate: Mon Sep 25 15:40:27 2023 +0100
Commit: Caolán McNamara 
CommitDate: Mon Sep 25 20:39:05 2023 +0200

Don't enable the requires clause for Clang 15

similar to 5831d5f03a5ea5b89984574ffe436f38500726da
Don't enable the requires clause for some Xcode Clang

Step #3 - "compile-honggfuzz-address-x86_64": checking whether Clang is new 
enough... yes (15.0.0)

In file included from 
libreoffice/core-clang/animations/source/animcore/animcore.cxx:20:
In file included from 
libreoffice/core-clang/workdir/UnoApiHeadersTarget/offapi/normal/com/sun/star/util/XCloneable.hpp:8:

libreoffice/core-clang/workdir/UnoApiHeadersTarget/udkapi/normal/com/sun/star/uno/XInterface.hpp:32:65:
 error: invalid application of 'sizeof' to an incomplete type 
'animcore::(anonymous namespace)::AnimationNode'
template inline constexpr auto isUnoInterfaceType = sizeof (T) 
&& IsUnoInterfaceType::value;
^~
libreoffice/core-clang/include/unotools/weakref.hxx:119:33: note: in 
instantiation of variable template specialization 
'cppu::detail::isUnoInterfaceType' requested here
requires(!cppu::detail::isUnoInterfaceType)
^
libreoffice/core-clang/animations/source/animcore/animcore.cxx:309:44: 
note: in instantiation of template class 
'unotools::WeakReference' 
requested here
unotools::WeakReference mxParent;
   ^
libreoffice/core-clang/animations/source/animcore/animcore.cxx:121:7: note: 
definition of 'animcore::(anonymous namespace)::AnimationNode' is not complete 
until the closing '}'
class AnimationNode final:  public AnimationNodeBase
  ^

Change-Id: I4feb54d5739464d356e2769eeb368c368cc29104
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157250
Tested-by: Caolán McNamara 
Reviewed-by: Caolán McNamara 

diff --git a/include/unotools/weakref.hxx b/include/unotools/weakref.hxx
index 9679579feb1e..14ee6d424f62 100644
--- a/include/unotools/weakref.hxx
+++ b/include/unotools/weakref.hxx
@@ -115,7 +115,7 @@ public:
  @return hard reference or null, if the weakly referenced interface 
has gone
 */
 rtl::Reference SAL_CALL get() const
-#if __cplusplus >= 202002L && !(defined __clang__ && __clang_major__ <= 14)
+#if __cplusplus >= 202002L && !(defined __clang__ && __clang_major__ <= 15)
 requires(!cppu::detail::isUnoInterfaceType)
 #endif
 {

[Libreoffice-commits] core.git: cui/uiconfig

[Heiko Tietze (via logerrit)]

 cui/uiconfig/ui/imagetabpage.ui |  176 
 1 file changed, 88 insertions(+), 88 deletions(-)

New commits:
commit 3575abbab1994aa1e0ccd8774a7d7fafb22d79e0
Author: Heiko Tietze 
AuthorDate: Sat Sep 23 14:24:58 2023 +0300
Commit: Heiko Tietze 
CommitDate: Tue Sep 26 07:57:02 2023 +0200

Resolves tdf#154019 - Better label in Area dialog more informative

Change-Id: Iaa20a88f42e056c6fa005df9854ae0b83d6ce662
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157184
Tested-by: Jenkins
Reviewed-by: Heiko Tietze 

diff --git a/cui/uiconfig/ui/imagetabpage.ui b/cui/uiconfig/ui/imagetabpage.ui
index f4574f298560..f83ea9a5df74 100644
--- a/cui/uiconfig/ui/imagetabpage.ui
+++ b/cui/uiconfig/ui/imagetabpage.ui
@@ -1,49 +1,49 @@
 
-
+
 
   
   
 100
-1
-10
+1
+10
   
   
 True
-False
+False
 True
 True
-6
+6
 6
 
   
 True
-False
-0
-none
+False
+0
+none
 
   
 True
-False
-vertical
-6
+False
 12
 6
+vertical
+6
 
   
 True
-True
+True
 True
-never
-never
-in
+never
+never
+in
 
   
 True
-False
+False
 
   
 True
-True
+True
 GDK_BUTTON_MOTION_MASK | 
GDK_BUTTON_PRESS_MASK | GDK_BUTTON_RELEASE_MASK | GDK_STRUCTURE_MASK
 True
   
@@ -61,8 +61,8 @@
   
 Add / Import
 True
-True
-True
+True
+True
 
   
 Locate the 
image that you want to import, and then click Open. The image is added to the 
end of the list of available images.
@@ -80,7 +80,7 @@
 
   
 True
-False
+False
 Image
 0
 
@@ -98,35 +98,35 @@
 
   
 True
-False
+False
 True
 True
-0
-none
+0
+none
 
   
 True
-False
+False
 start
+12
+6
 True
 True
 vertical
 6
-12
-6
 
   
 True
-False
+False
 vertical
 3
 
   
 True
-False
+False
 Style:
-True
-imagestyle
+True
+imagestyle
 0
   
   
@@ -138,7 +138,7 @@
 
   
 True
-False
+False
 
   Custom position/size
   Tiled
@@ -161,13 +161,13 @@
 
   
 True
-False
+False
 vertical
 3
 
   
 True
-False
+False
 Size:
 0
   
@@ -180,15 +180,15 @@
 
   
 True
-False
+False
 6
 
   
 True
-False
+False
 Width:
-True
-width
+True
+width
   
   
 False
@@ -199,9 +199,9 @@
 
   
 True
-True
-True
+True
 True
+True
   
   
 False
@@ -219,15 +219,15 @@
 
   
 True
-False
+False
 6
 
   
 True
-False
+   

[Libreoffice-commits] core.git: Branch 'libreoffice-7-6' - dbaccess/source

[Julien Nabet (via logerrit)]

 dbaccess/source/ui/dlg/DbAdminImpl.cxx |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit 93fa91130cf41ae3cb2f8ef6eb596d34db55c7d1
Author: Julien Nabet 
AuthorDate: Sat Sep 23 17:23:36 2023 +0200
Commit: Michael Weghorn 
CommitDate: Mon Sep 25 09:19:10 2023 +0200

tdf#157260: don't add a "port" param if already present in the connection 
DB url

Regression of 
https://cgit.freedesktop.org/libreoffice/core/commit/?id=afe99617707c92460e66486c0057ef327e8aa017
"tdf#43369: Specific UI for collecting PostgreSQL connection settings"
in 2023-04

Change-Id: Id6e9c9a1aa8586cb4081e22988060476183369d2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157193
Reviewed-by: Julien Nabet 
Tested-by: Jenkins
(cherry picked from commit 3399854b66bb1fb175b8504c964008e53167ca7b)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157129
Reviewed-by: Michael Weghorn 

diff --git a/dbaccess/source/ui/dlg/DbAdminImpl.cxx 
b/dbaccess/source/ui/dlg/DbAdminImpl.cxx
index 0ce7a06afdb4..7e8aa1f0d1ef 100644
--- a/dbaccess/source/ui/dlg/DbAdminImpl.cxx
+++ b/dbaccess/source/ui/dlg/DbAdminImpl.cxx
@@ -539,7 +539,8 @@ OUString 
ODbDataSourceAdministrationHelper::getConnectionURL() const
 hostname = "'" + hostname + "'";
 rURL += " host=" + hostname;
 }
-if (pPortNumber && pPortNumber->GetValue())
+// tdf#157260: if port is already in the URL, don't add 
another one
+if (pPortNumber && pPortNumber->GetValue() && 
(rURL.indexOf("port=") == -1))
 {
 OUString port = "'" + 
OUString::number(pPortNumber->GetValue()) + "'";
 rURL += " port=" + port;

[Libreoffice-commits] core.git: configure.ac download.lst external/libwps

[Taichi Haradaguchi (via logerrit)]

 configure.ac|2 +-
 download.lst|4 ++--
 external/libwps/README  |2 +-
 external/libwps/inc/pch/precompiled_wps.hxx |3 ++-
 external/libwps/libtool.patch.0 |   13 ++---
 5 files changed, 12 insertions(+), 12 deletions(-)

New commits:
commit 6acdde8006e6b59758b00bc178f15f32796a1987
Author: Taichi Haradaguchi <20001...@ymail.ne.jp>
AuthorDate: Thu Sep 21 20:23:26 2023 +0900
Commit: Taichi Haradaguchi <20001...@ymail.ne.jp>
CommitDate: Mon Sep 25 09:20:24 2023 +0200

upload libwps 0.4.14

Change-Id: I0d10aafa17afaaef9b154255bf17638dd67070e1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157149
Tested-by: Jenkins
Reviewed-by: Taichi Haradaguchi <20001...@ymail.ne.jp>

diff --git a/configure.ac b/configure.ac
index 93e6bd11bfca..4931ad5bf4bc 100644
--- a/configure.ac
+++ b/configure.ac
@@ -9589,7 +9589,7 @@ libo_CHECK_SYSTEM_MODULE([libwpd],[WPD],[libwpd-0.10])
 libo_CHECK_SYSTEM_MODULE([libwpg],[WPG],[libwpg-0.3])
 
 libo_CHECK_SYSTEM_MODULE([libwps],[WPS],[libwps-0.4])
-libo_PKG_VERSION([WPS], [libwps-0.4], [0.4.12])
+libo_PKG_VERSION([WPS], [libwps-0.4], [0.4.14])
 
 libo_CHECK_SYSTEM_MODULE([libvisio],[VISIO],[libvisio-0.1])
 
diff --git a/download.lst b/download.lst
index 1c65320be412..71ab2bd818d5 100644
--- a/download.lst
+++ b/download.lst
@@ -549,8 +549,8 @@ WPG_TARBALL := libwpg-0.3.$(WPG_VERSION_MICRO).tar.xz
 # three static lines
 # so that git cherry-pick
 # will not run into conflicts
-WPS_SHA256SUM := 
e21afb52a06d03b774c5a8c72679687ab64891b91ce0c3bdf2d3e97231534edb
-WPS_VERSION_MICRO := 12
+WPS_SHA256SUM := 
365b968e270e85a8469c6b160aa6af5619a4e6c995dbb04c1ecc1b4dd13e80de
+WPS_VERSION_MICRO := 14
 WPS_TARBALL := libwps-0.4.$(WPS_VERSION_MICRO).tar.xz
 # three static lines
 # so that git cherry-pick
diff --git a/external/libwps/README b/external/libwps/README
index 3ce52187d520..1354aaa24db2 100644
--- a/external/libwps/README
+++ b/external/libwps/README
@@ -1 +1 @@
-Microsoft Works file word processor format import library from 
[http://libwps.sourceforge.net/].
+Microsoft Works file word processor format import library from 
[https://sourceforge.net/projects/libwps/].
diff --git a/external/libwps/inc/pch/precompiled_wps.hxx 
b/external/libwps/inc/pch/precompiled_wps.hxx
index 77d92f7615b6..e25d81e9c6ca 100644
--- a/external/libwps/inc/pch/precompiled_wps.hxx
+++ b/external/libwps/inc/pch/precompiled_wps.hxx
@@ -13,13 +13,14 @@
  manual changes will be rewritten by the next run of update_pch.sh (which 
presumably
  also fixes all possible problems, so it's usually better to use it).
 
- Generated on 2019-10-13 10:00:18 using:
+ Generated on 2023-09-21 20:32:22 using:
  ./bin/update_pch external/libwps wps --cutoff=1 --exclude:system 
--include:module --include:local
 
  If after updating build fails, use the following command to locate 
conflicting headers:
  ./bin/update_pch_bisect ./external/libwps/inc/pch/precompiled_wps.hxx "make 
external/libwps.build" --find-conflicts
 */
 
+#include 
 #if PCH_LEVEL >= 1
 #include 
 #include 
diff --git a/external/libwps/libtool.patch.0 b/external/libwps/libtool.patch.0
index cc4b08ba2147..bccd0ebdbc06 100644
--- a/external/libwps/libtool.patch.0
+++ b/external/libwps/libtool.patch.0
@@ -1,12 +1,11 @@
 ltmain.sh.sav  2018-08-02 14:21:34.0 +0200
-+++ ltmain.sh  2019-05-05 22:04:15.433588776 +0200
-@@ -7277,7 +7277,8 @@ func_mode_link ()
-   # -stdlib=*select c++ std lib with clang
+--- ltmain.sh.sav  2023-05-03 21:29:15.0 +0900
 ltmain.sh  2023-09-21 20:13:31.766938069 +0900
+@@ -7277,7 +7277,7 @@ func_mode_link ()
-64|-mips[0-9]|-r[0-9][0-9]*|-xarch=*|-xtarget=*|+DA*|+DD*|-q*|-m*| \

-t[45]*|-txscale*|-p|-pg|--coverage|-fprofile-*|-F*|@*|-tp=*|--sysroot=*| \
--  
-O*|-g*|-flto*|-fwhopr*|-fuse-linker-plugin|-fstack-protector*|-stdlib=*)
-+  
-O*|-g*|-flto*|-fwhopr*|-fuse-linker-plugin|-fstack-protector*|-stdlib=*| \
-+  -fuse-ld=*|--ld-path=*)
+   
-O*|-g*|-flto*|-fwhopr*|-fuse-linker-plugin|-fstack-protector*|-stdlib=*| \
+-  -fsanitize=*)
++  -fsanitize=*|-fuse-ld=*|--ld-path=*)
  func_quote_for_eval "$arg"
arg=$func_quote_for_eval_result
  func_append compile_command " $arg"

[Libreoffice-commits] core.git: sw/qa sw/source

[Miklos Vajna (via logerrit)]

 sw/qa/core/layout/data/table-missing-join.docx |binary
 sw/qa/core/layout/tabfrm.cxx   |   28 +
 sw/source/core/layout/tabfrm.cxx   |9 
 3 files changed, 37 insertions(+)

New commits:
commit b8521d969ab5be4fc947e467d4afe969f9d3b563
Author: Miklos Vajna 
AuthorDate: Mon Sep 25 08:38:28 2023 +0200
Commit: Miklos Vajna 
CommitDate: Mon Sep 25 09:41:41 2023 +0200

tdf#157263 sw floattable: prefer join over split after moving fwd

Regression from commit a4af5432753408c4eea8a8d56c2f48202160c5fe
(tdf#120262 sw floattable, legacy: fix text wrap around fly when no
content fits, 2023-07-17), the bugdoc was of 3 pages in both Word and
Writer, but is now of 4 pages in Writer.

The above commit fixed the layout, so the first row of the table around
the page 1 -> page 2 boundary goes to the start of page 2 instead of to
the end of page 1. This matches the Word layout, so a wanted change on
its own, but it regressed the page acount. The reason for this is that
the table has a single row on page 2 and its follow on page 3 is not
joined, even if there would be still space on page 2. A reduced bugdoc
appears to reproduce this problem even without floating tables, also
with old versions, so it's not a new problem, but it's now more visible.

Fix the problem by tweaking what to do in the next iteration in the loop
of SwTabFrame::MakeAll() after moving forward. Moving forward is
followed by a next iteration in that function, but it does both a
MakePos() and a Format(), so it'll be the last iteration in the "is the
postion / size of this tab frame valid" loop. We used to hit the "bSplit
== true" case, there we found that there is enough remaining space, so
no need to split and we quit the loop. This is now changed, so in case
we moved the table forward and there is still enough space for the
follow to be next to us, then the last iteration will try to join
instead of trying to split.

Note that probably split almost never makes sense after moving forward
in the !HasNext() && HasFollow() case, but let's stay on the safe side
and only do this when the follow definitely fits, which is enough for
our needs here.

Change-Id: I64b0a7d257b0ab01353741506969a287b361c5ff
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157233
Reviewed-by: Miklos Vajna 
Tested-by: Jenkins

diff --git a/sw/qa/core/layout/data/table-missing-join.docx 
b/sw/qa/core/layout/data/table-missing-join.docx
new file mode 100644
index ..1fabb9e5b27c
Binary files /dev/null and b/sw/qa/core/layout/data/table-missing-join.docx 
differ
diff --git a/sw/qa/core/layout/tabfrm.cxx b/sw/qa/core/layout/tabfrm.cxx
index 4b991c27dbf8..705bf47af4bc 100644
--- a/sw/qa/core/layout/tabfrm.cxx
+++ b/sw/qa/core/layout/tabfrm.cxx
@@ -9,6 +9,13 @@
 
 #include 
 
+#include 
+#include 
+#include 
+#include 
+
+namespace
+{
 /// Covers sw/source/core/layout/tabfrm.cxx fixes.
 class Test : public SwModelTestBase
 {
@@ -35,4 +42,25 @@ CPPUNIT_TEST_FIXTURE(Test, testTablePrintAreaLeft)
 CPPUNIT_ASSERT_EQUAL(static_cast(5), nTablePrintLeft);
 }
 
+CPPUNIT_TEST_FIXTURE(Test, testTableMissingJoin)
+{
+// Given a document with a table on page 2:
+// When laying out that document:
+createSwDoc("table-missing-join.docx");
+
+// Then make sure that the table fits page 2:
+SwDoc* pDoc = getSwDoc();
+SwRootFrame* pLayout = pDoc->getIDocumentLayoutAccess().GetCurrentLayout();
+auto pPage1 = pLayout->Lower()->DynCastPageFrame();
+CPPUNIT_ASSERT(pPage1);
+auto pPage2 = pPage1->GetNext()->DynCastPageFrame();
+CPPUNIT_ASSERT(pPage2);
+SwFrame* pBody = pPage2->FindBodyCont();
+auto pTab = pBody->GetLower()->DynCastTabFrame();
+// Without the accompanying fix in place, this test would have failed, the 
table continued on
+// page 3.
+CPPUNIT_ASSERT(!pTab->HasFollow());
+}
+}
+
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sw/source/core/layout/tabfrm.cxx b/sw/source/core/layout/tabfrm.cxx
index 68bb19b7f39d..693c180154df 100644
--- a/sw/source/core/layout/tabfrm.cxx
+++ b/sw/source/core/layout/tabfrm.cxx
@@ -2872,6 +2872,15 @@ void SwTabFrame::MakeAll(vcl::RenderContext* 
pRenderContext)
 if ( GetFollow() )
 Join();
 }
+else if (!GetNext() && !HasFollowFlowLine() && GetFollow()
+ && (getFrameArea().Bottom() + 
GetFollow()->getFrameArea().Height())
+< GetUpper()->getFrameArea().Bottom())
+{
+// We're the last lower of the upper, no split row and we have a 
follow.  That follow
+// fits our upper, still.  Prefer joining that follow in the next 
iteration, instead of
+// trying to split the current table.
+bSplit = false;
+}
 
 if ( bMovedBwd 

[Libreoffice-commits] help.git: source/text

[Stéphane Guillou (via logerrit)]

 source/text/swriter/01/04120210.xhp |2 +-
 source/text/swriter/guide/main.xhp  |4 +++-
 2 files changed, 4 insertions(+), 2 deletions(-)

New commits:
commit 5f90597efbc302b0cbf46acd07cfbe22cc445a28
Author: Stéphane Guillou 
AuthorDate: Fri Sep 15 14:02:14 2023 +0200
Commit: Olivier Hallot 
CommitDate: Mon Sep 25 10:26:22 2023 +0200

link to relevant Index section rather than whole guide

Change-Id: I49eb397264a8ba72a58a16b5fbf8a03b22086f8e
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/156952
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/source/text/swriter/01/04120210.xhp 
b/source/text/swriter/01/04120210.xhp
index f33f0ffd1d..cb0c186756 100644
--- a/source/text/swriter/01/04120210.xhp
+++ b/source/text/swriter/01/04120210.xhp
@@ -56,7 +56,7 @@
   
 
 
-Using Tables of Content and 
Indexes
+Using Tables of 
Content and Indexes
 Insert - Table of Contents and Index - 
Index Entry
 
 
diff --git a/source/text/swriter/guide/main.xhp 
b/source/text/swriter/guide/main.xhp
index ba6e748850..4db3b836b0 100644
--- a/source/text/swriter/guide/main.xhp
+++ b/source/text/swriter/guide/main.xhp
@@ -126,7 +126,9 @@
 
 
 
-Table of Contents, Index
+
+  Table of Contents, Index
+
 
 
 

[Libreoffice-commits] core.git: helpcontent2

[Stéphane Guillou (via logerrit)]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit a499a3f2486b44c8b1918e69490f9d26bdb0e1f5
Author: Stéphane Guillou 
AuthorDate: Mon Sep 25 10:26:23 2023 +0200
Commit: Gerrit Code Review 
CommitDate: Mon Sep 25 10:26:23 2023 +0200

Update git submodules

* Update helpcontent2 from branch 'master'
  to 5f90597efbc302b0cbf46acd07cfbe22cc445a28
  - link to relevant Index section rather than whole guide

Change-Id: I49eb397264a8ba72a58a16b5fbf8a03b22086f8e
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/156952
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index a4952ec1b49a..5f90597efbc3 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit a4952ec1b49ab70ba0271b5ff3f5e34e0405c82d
+Subproject commit 5f90597efbc302b0cbf46acd07cfbe22cc445a28

[Libreoffice-commits] core.git: include/svx svx/source

[Miklos Vajna (via logerrit)]

 include/svx/svdhdl.hxx   |   14 +++---
 svx/source/svdraw/svdhdl.cxx |   26 +-
 2 files changed, 20 insertions(+), 20 deletions(-)

New commits:
commit d6a1324380cc8362d509a1f29dcd2ca4ad4bee9d
Author: Miklos Vajna 
AuthorDate: Mon Sep 25 08:09:02 2023 +0200
Commit: Miklos Vajna 
CommitDate: Mon Sep 25 09:16:40 2023 +0200

svx: prefix members of SdrHdlColor

See tdf#94879 for motivation.

Change-Id: Ic987e38bb2f1a23504e27a32062df75215de6b3d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157232
Reviewed-by: Miklos Vajna 
Tested-by: Jenkins

diff --git a/include/svx/svdhdl.hxx b/include/svx/svdhdl.hxx
index 8824a65b4986..abd5a060f5aa 100644
--- a/include/svx/svdhdl.hxx
+++ b/include/svx/svdhdl.hxx
@@ -255,16 +255,16 @@ public:
 class SVXCORE_DLLPUBLIC SdrHdlColor final : public SdrHdl
 {
 // size of colr markers
-SizeaMarkerSize;
+Sizem_aMarkerSize;
 
 // color
-Color   aMarkerColor;
+Color   m_aMarkerColor;
 
 // callback link when value changed
-Link aColorChangeHdl;
+Link m_aColorChangeHdl;
 
 // use luminance values only
-boolbUseLuminance : 1;
+boolm_bUseLuminance : 1;
 
 // create marker for this kind
 SVX_DLLPRIVATE virtual void CreateB2dIAObject() override;
@@ -277,14 +277,14 @@ public:
 explicit SdrHdlColor(const Point& rRef, Color aCol, const Size& rSize, 
bool bLuminance);
 virtual ~SdrHdlColor() override;
 
-bool IsUseLuminance() const { return bUseLuminance; }
+bool IsUseLuminance() const { return m_bUseLuminance; }
 
-const Color& GetColor() const { return aMarkerColor; }
+const Color& GetColor() const { return m_aMarkerColor; }
 void SetColor(Color aNew, bool bCallLink = false);
 
 void SetSize(const Size& rNew);
 
-void SetColorChangeHdl(const Link& rLink) { 
aColorChangeHdl = rLink; }
+void SetColorChangeHdl(const Link& rLink) { 
m_aColorChangeHdl = rLink; }
 };
 
 
diff --git a/svx/source/svdraw/svdhdl.cxx b/svx/source/svdraw/svdhdl.cxx
index 27b94f83d67a..77904d411a9f 100644
--- a/svx/source/svdraw/svdhdl.cxx
+++ b/svx/source/svdraw/svdhdl.cxx
@@ -1112,14 +1112,14 @@ void SdrHdl::insertNewlyCreatedOverlayObjectForSdrHdl(
 
 SdrHdlColor::SdrHdlColor(const Point& rRef, Color aCol, const Size& rSize, 
bool bLum)
 :   SdrHdl(rRef, SdrHdlKind::Color),
-aMarkerSize(rSize),
-bUseLuminance(bLum)
+m_aMarkerSize(rSize),
+m_bUseLuminance(bLum)
 {
 if(IsUseLuminance())
 aCol = GetLuminance(aCol);
 
 // remember color
-aMarkerColor = aCol;
+m_aMarkerColor = aCol;
 }
 
 SdrHdlColor::~SdrHdlColor()
@@ -1153,7 +1153,7 @@ void SdrHdlColor::CreateB2dIAObject()
 const rtl::Reference< sdr::overlay::OverlayManager >& xManager = 
rPageWindow.GetOverlayManager();
 if (xManager.is())
 {
-BitmapEx aBmpCol(CreateColorDropper(aMarkerColor));
+BitmapEx aBmpCol(CreateColorDropper(m_aMarkerColor));
 basegfx::B2DPoint aPosition(m_aPos.X(), m_aPos.Y());
 std::unique_ptr 
pNewOverlayObject(new
 sdr::overlay::OverlayBitmapEx(
@@ -1177,13 +1177,13 @@ BitmapEx SdrHdlColor::CreateColorDropper(Color aCol)
 {
 // get the Bitmap
 VclPtr pWrite(VclPtr::Create());
-pWrite->SetOutputSizePixel(aMarkerSize);
+pWrite->SetOutputSizePixel(m_aMarkerSize);
 pWrite->SetBackground(aCol);
 pWrite->Erase();
 
 // draw outer border
-sal_Int32 nWidth = aMarkerSize.Width();
-sal_Int32 nHeight = aMarkerSize.Height();
+sal_Int32 nWidth = m_aMarkerSize.Width();
+sal_Int32 nHeight = m_aMarkerSize.Height();
 
 pWrite->SetLineColor(COL_LIGHTGRAY);
 pWrite->DrawLine(Point(0, 0), Point(0, nHeight - 1));
@@ -1210,7 +1210,7 @@ BitmapEx SdrHdlColor::CreateColorDropper(Color aCol)
 pWrite->DrawLine(Point(2, nHeight - 2), Point(nWidth - 2, nHeight - 2));
 pWrite->DrawLine(Point(nWidth - 2, 2), Point(nWidth - 2, nHeight - 3));
 
-return pWrite->GetBitmapEx(Point(0,0), aMarkerSize);
+return pWrite->GetBitmapEx(Point(0,0), m_aMarkerSize);
 }
 
 Color SdrHdlColor::GetLuminance(const Color& rCol)
@@ -1225,26 +1225,26 @@ void SdrHdlColor::SetColor(Color aNew, bool bCallLink)
 if(IsUseLuminance())
 aNew = GetLuminance(aNew);
 
-if(aMarkerColor != aNew)
+if(m_aMarkerColor != aNew)
 {
 // remember new color
-aMarkerColor = aNew;
+m_aMarkerColor = aNew;
 
 // create new display
 Touch();
 
 // tell about change
 if(bCallLink)
-aColorChangeHdl.Call(this);
+m_aColorChangeHdl.Call(this);
 }
 }
 
 void SdrHdlColor::SetSize(const Size& rNew)
 {
-if(rNew != aMarkerSize)
+if(rNew != m_aMarkerSize)
 {
 // 

[Libreoffice-commits] core.git: Branch 'distro/collabora/co-23.05' - sw/source

[Miklos Vajna (via logerrit)]

 sw/source/uibase/shells/textfld.cxx |   14 +-
 1 file changed, 9 insertions(+), 5 deletions(-)

New commits:
commit 6c39caedbe08f44683f14eabae4e96c3642c4e44
Author: Miklos Vajna 
AuthorDate: Fri Sep 22 15:40:17 2023 +0200
Commit: Caolán McNamara 
CommitDate: Mon Sep 25 09:52:25 2023 +0200

sw: fix crash in SwTextShell::ExecField()

Crashreport signature:

Fatal signal received: SIGSEGV code: 128 for address: 0x0

program/libswlo.so
SwTextShell::ExecField(SfxRequest&)
sw/source/uibase/shells/textfld.cxx:456
program/libmergedlo.so
SfxDispatcher::Call_Impl(SfxShell&, SfxSlot const&, SfxRequest&, 
bool)
sfx2/source/control/dispatch.cxx:257
program/libmergedlo.so
SfxDispatcher::Execute(unsigned short, SfxCallMode, SfxItemSet 
const*, SfxItemSet const*, unsigned short)
sfx2/source/control/dispatch.cxx:814
program/libmergedlo.so
SfxDispatchController_Impl::dispatch(com::sun::star::util::URL 
const&, com::sun::star::uno::Sequence 
const&, 
com::sun::star::uno::Reference 
const&)
sfx2/source/control/unoctitm.cxx:682

Change-Id: I359f9ee643daff9acfb67800e38666cce060c0b6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157171
Tested-by: Jenkins CollaboraOffice 
Tested-by: Caolán McNamara 
Reviewed-by: Caolán McNamara 

diff --git a/sw/source/uibase/shells/textfld.cxx 
b/sw/source/uibase/shells/textfld.cxx
index b0603d4eed96..9a5d1ac5ee73 100644
--- a/sw/source/uibase/shells/textfld.cxx
+++ b/sw/source/uibase/shells/textfld.cxx
@@ -452,13 +452,17 @@ void SwTextShell::ExecField(SfxRequest )
 pMgr->RegisterAnswerText(sText);
 pWin->ExecuteCommand(nSlot);
 
-// Set the parent postit id of the reply.
-
GetView().GetPostItMgr()->GetLatestPostItField()->SetParentPostItId(pIdItem->GetValue().toUInt32());
+SwPostItField* pLatestPostItField = 
pMgr->GetLatestPostItField();
+if (pLatestPostItField)
+{
+// Set the parent postit id of the reply.
+
pLatestPostItField->SetParentPostItId(pIdItem->GetValue().toUInt32());
 
-// If name of the replied comment is empty, we need to 
set a name in order to connect them in the xml file.
-pWin->GeneratePostItName(); // Generates a name if the 
current name is empty.
+// If name of the replied comment is empty, we 
need to set a name in order to connect them in the xml file.
+pWin->GeneratePostItName(); // Generates a name if 
the current name is empty.
 
-
GetView().GetPostItMgr()->GetLatestPostItField()->SetParentName(pWin->GetPostItField()->GetName());
+
pLatestPostItField->SetParentName(pWin->GetPostItField()->GetName());
+}
 }
 }
 }

[Libreoffice-commits] core.git: framework/qa odk/examples qadevOOo/tests

[apurvapriyadarshi (via logerrit)]

 framework/qa/complex/contextMenuInterceptor/ContextMenuInterceptor.java   |
4 ++--
 odk/examples/DevelopersGuide/OfficeDev/DesktopEnvironment/StatusView.java |   
10 +-
 qadevOOo/tests/java/mod/_sd/SdUnoDrawView.java|
2 +-
 qadevOOo/tests/java/mod/_svx/SvxGraphCtrlAccessibleContext.java   |
2 +-
 4 files changed, 9 insertions(+), 9 deletions(-)

New commits:
commit 31ca96ff3075343c8d0c334fc77a9d0969986d77
Author: apurvapriyadarshi 
AuthorDate: Wed Sep 20 23:37:21 2023 +0530
Commit: Ilmari Lauhakangas 
CommitDate: Mon Sep 25 13:04:27 2023 +0200

tdf#146150 Use dispatch cmd for the corresponding SID

Change-Id: I0d987a8b10f2c69192d080b534a1d6aa71a6cf4d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157105
Tested-by: Ilmari Lauhakangas 
Reviewed-by: Ilmari Lauhakangas 

diff --git 
a/framework/qa/complex/contextMenuInterceptor/ContextMenuInterceptor.java 
b/framework/qa/complex/contextMenuInterceptor/ContextMenuInterceptor.java
index 7496b58e080b..b376b715a1eb 100644
--- a/framework/qa/complex/contextMenuInterceptor/ContextMenuInterceptor.java
+++ b/framework/qa/complex/contextMenuInterceptor/ContextMenuInterceptor.java
@@ -72,7 +72,7 @@ public class ContextMenuInterceptor implements 
XContextMenuInterceptor
 // entry "Content"
 XPropertySet xMenuEntry = 
UnoRuntime.queryInterface(XPropertySet.class, 
xMenuElementFactory.createInstance("com.sun.star.ui.ActionTrigger"));
 xMenuEntry.setPropertyValue("Text", "Content");
-xMenuEntry.setPropertyValue("CommandURL", "slot:5401");
+xMenuEntry.setPropertyValue("CommandURL", ".uno:HelpIndex");
 xMenuEntry.setPropertyValue("HelpURL", "5401");
 
 // insert menu entry to sub menu
@@ -91,7 +91,7 @@ public class ContextMenuInterceptor implements 
XContextMenuInterceptor
 // entry "Tips"
 xMenuEntry = 
UnoRuntime.queryInterface(com.sun.star.beans.XPropertySet.class, 
xMenuElementFactory.createInstance("com.sun.star.ui.ActionTrigger"));
 xMenuEntry.setPropertyValue("Text", "Tips");
-xMenuEntry.setPropertyValue("CommandURL", "slot:5404");
+xMenuEntry.setPropertyValue("CommandURL", ".uno:HelpTip");
 xMenuEntry.setPropertyValue("HelpURL", "5404");
 
 // insert menu entry to sub menu
diff --git 
a/odk/examples/DevelopersGuide/OfficeDev/DesktopEnvironment/StatusView.java 
b/odk/examples/DevelopersGuide/OfficeDev/DesktopEnvironment/StatusView.java
index 92ae178adc59..076669014d83 100644
--- a/odk/examples/DevelopersGuide/OfficeDev/DesktopEnvironment/StatusView.java
+++ b/odk/examples/DevelopersGuide/OfficeDev/DesktopEnvironment/StatusView.java
@@ -67,11 +67,11 @@ public class StatusView extendsJPanel
  * const
  * These URL's describe available feature states.
  */
-private static final String FEATUREURL_FONT  = "slot:10007";
-private static final String FEATUREURL_SIZE  = "slot:10015";
-private static final String FEATUREURL_BOLD  = "slot:10009";
-private static final String FEATUREURL_ITALIC= "slot:10008";
-private static final String FEATUREURL_UNDERLINE = "slot:10014";
+private static final String FEATUREURL_FONT  = ".uno:CharFontName";
+private static final String FEATUREURL_SIZE  = ".uno:FontHeight";
+private static final String FEATUREURL_BOLD  = ".uno:Bold";
+private static final String FEATUREURL_ITALIC= ".uno:Italic";
+private static final String FEATUREURL_UNDERLINE = ".uno:Underline";
 
 
 
diff --git a/qadevOOo/tests/java/mod/_sd/SdUnoDrawView.java 
b/qadevOOo/tests/java/mod/_sd/SdUnoDrawView.java
index fc4bd27c1a88..dd4e0298e125 100644
--- a/qadevOOo/tests/java/mod/_sd/SdUnoDrawView.java
+++ b/qadevOOo/tests/java/mod/_sd/SdUnoDrawView.java
@@ -214,7 +214,7 @@ public class SdUnoDrawView extends TestCase {
 XController secondController = aModel.getCurrentController();
 tEnv.addObjRelation("SecondController", secondController);
 tEnv.addObjRelation("XDispatchProvider.URL",
-"slot:27009");
+".uno:DrawingMode");
 
 //Adding relations for DrawingDocumentDrawView
 XDrawPage new_page = the_pages.insertNewByIndex(1);
diff --git a/qadevOOo/tests/java/mod/_svx/SvxGraphCtrlAccessibleContext.java 
b/qadevOOo/tests/java/mod/_svx/SvxGraphCtrlAccessibleContext.java
index e2b3581d4a06..64eb954aae1e 100644
--- a/qadevOOo/tests/java/mod/_svx/SvxGraphCtrlAccessibleContext.java
+++ b/qadevOOo/tests/java/mod/_svx/SvxGraphCtrlAccessibleContext.java
@@ -100,7 +100,7 @@ public class SvxGraphCtrlAccessibleContext extends TestCase{
 
 //Opening ImageMapDialog
 try {
-String aSlotID = "slot:10371";
+String aSlotID = ".uno:ImageMapDialog";
   

[Libreoffice-commits] core.git: Branch 'libreoffice-7-6' - svx/source

[Khaled Hosny (via logerrit)]

 svx/source/styles/CommonStylePreviewRenderer.cxx |   16 
 1 file changed, 8 insertions(+), 8 deletions(-)

New commits:
commit b44af80f0aa1ce93193f0edb107f17edbabba17a
Author: Khaled Hosny 
AuthorDate: Sun Sep 24 18:10:21 2023 +0300
Commit: Michael Stahl 
CommitDate: Mon Sep 25 13:33:15 2023 +0200

tdf#157067: Fix missing background color in style preview

Set the colors after setting the font not before as otherwise they seem
to get overridden.

Change-Id: I258cb762fd2328369bd8adae63e94ec87c666bb7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157208
Tested-by: Jenkins
Reviewed-by: خالد حسني 
(cherry picked from commit 841d4634d3c1be48e8106899275f0ef176a377ce)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157211
Reviewed-by: Michael Stahl 

diff --git a/svx/source/styles/CommonStylePreviewRenderer.cxx 
b/svx/source/styles/CommonStylePreviewRenderer.cxx
index c23861e92a72..d92aac21d89c 100644
--- a/svx/source/styles/CommonStylePreviewRenderer.cxx
+++ b/svx/source/styles/CommonStylePreviewRenderer.cxx
@@ -335,12 +335,6 @@ bool CommonStylePreviewRenderer::render(const 
tools::Rectangle& aRectangle, Rend
 mrOutputDev.DrawRect(aRectangle);
 }
 
-if (maFontColor != COL_AUTO)
-mrOutputDev.SetTextColor(maFontColor);
-
-if (maHighlightColor != COL_AUTO)
-mrOutputDev.SetTextFillColor(maHighlightColor);
-
 Point aFontDrawPosition = aRectangle.TopLeft();
 aFontDrawPosition.AdjustY(mnBaseLine);
 if (eRenderAlign == RenderAlign::CENTER)
@@ -376,10 +370,16 @@ bool CommonStylePreviewRenderer::render(const 
tools::Rectangle& aRectangle, Rend
 mrOutputDev.Push(vcl::PushFlags::FONT);
 
 if (oFont)
-{
 mrOutputDev.SetFont(*oFont);
+
+if (maFontColor != COL_AUTO)
+mrOutputDev.SetTextColor(maFontColor);
+
+if (maHighlightColor != COL_AUTO)
+mrOutputDev.SetTextFillColor(maHighlightColor);
+
+if (oFont)
 oFont->QuickDrawText(, aFontDrawPosition, rText, 
nStart, nEnd - nStart, {});
-}
 else
 mrOutputDev.DrawText(aFontDrawPosition, rText, nStart, nEnd - 
nStart);
 

[Libreoffice-commits] core.git: Branch 'libreoffice-7-5' - svx/source

[Khaled Hosny (via logerrit)]

 svx/source/styles/CommonStylePreviewRenderer.cxx |   16 
 1 file changed, 8 insertions(+), 8 deletions(-)

New commits:
commit 0cdb364d0f8b30f857da212e6c663f36b91087d1
Author: Khaled Hosny 
AuthorDate: Sun Sep 24 18:10:21 2023 +0300
Commit: Michael Stahl 
CommitDate: Mon Sep 25 13:33:41 2023 +0200

tdf#157067: Fix missing background color in style preview

Set the colors after setting the font not before as otherwise they seem
to get overridden.

Change-Id: I258cb762fd2328369bd8adae63e94ec87c666bb7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157208
Tested-by: Jenkins
Reviewed-by: خالد حسني 
(cherry picked from commit d9eed9b489d8ad208df307588595f3a8d3b7539b)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157212
Reviewed-by: Michael Stahl 

diff --git a/svx/source/styles/CommonStylePreviewRenderer.cxx 
b/svx/source/styles/CommonStylePreviewRenderer.cxx
index c23861e92a72..d92aac21d89c 100644
--- a/svx/source/styles/CommonStylePreviewRenderer.cxx
+++ b/svx/source/styles/CommonStylePreviewRenderer.cxx
@@ -335,12 +335,6 @@ bool CommonStylePreviewRenderer::render(const 
tools::Rectangle& aRectangle, Rend
 mrOutputDev.DrawRect(aRectangle);
 }
 
-if (maFontColor != COL_AUTO)
-mrOutputDev.SetTextColor(maFontColor);
-
-if (maHighlightColor != COL_AUTO)
-mrOutputDev.SetTextFillColor(maHighlightColor);
-
 Point aFontDrawPosition = aRectangle.TopLeft();
 aFontDrawPosition.AdjustY(mnBaseLine);
 if (eRenderAlign == RenderAlign::CENTER)
@@ -376,10 +370,16 @@ bool CommonStylePreviewRenderer::render(const 
tools::Rectangle& aRectangle, Rend
 mrOutputDev.Push(vcl::PushFlags::FONT);
 
 if (oFont)
-{
 mrOutputDev.SetFont(*oFont);
+
+if (maFontColor != COL_AUTO)
+mrOutputDev.SetTextColor(maFontColor);
+
+if (maHighlightColor != COL_AUTO)
+mrOutputDev.SetTextFillColor(maHighlightColor);
+
+if (oFont)
 oFont->QuickDrawText(, aFontDrawPosition, rText, 
nStart, nEnd - nStart, {});
-}
 else
 mrOutputDev.DrawText(aFontDrawPosition, rText, nStart, nEnd - 
nStart);
 

[Libreoffice-commits] core.git: Branch 'libreoffice-7-6' - vcl/unx

[Caolán McNamara (via logerrit)]

 vcl/unx/generic/gdi/cairotextrender.cxx |   11 +++
 1 file changed, 7 insertions(+), 4 deletions(-)

New commits:
commit fdcea7929e3e795a3fd0ec884d80181c3cd15d8c
Author: Caolán McNamara 
AuthorDate: Sat Sep 23 07:16:06 2023 +0100
Commit: Michael Stahl 
CommitDate: Mon Sep 25 13:35:59 2023 +0200

tdf#152675 treat all cairo versions <= 1.17.8 the same

wrt unwanted sideeffects of CAIRO_HINT_METRICS_OFF seen
in https://gitlab.freedesktop.org/cairo/cairo/-/issues/643
and https://bugs.documentfoundation.org/show_bug.cgi?id=152675

Change-Id: Ib3f43fd3832083f1768b737e3a5fb28063c0ae23
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157177
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
(cherry picked from commit 1dd357ccf7ca9edbe5f2ef60465c2559f678d306)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157179
Reviewed-by: Michael Stahl 

diff --git a/vcl/unx/generic/gdi/cairotextrender.cxx 
b/vcl/unx/generic/gdi/cairotextrender.cxx
index f962c21d39ed..719b5085fcc5 100644
--- a/vcl/unx/generic/gdi/cairotextrender.cxx
+++ b/vcl/unx/generic/gdi/cairotextrender.cxx
@@ -433,14 +433,17 @@ void CairoTextRender::DrawTextLayout(const 
GenericSalLayout& rLayout, const SalG
 cairo_font_options_set_antialias(pOptions, 
CAIRO_ANTIALIAS_NONE);
 if (!bAllowedHintStyle)
 cairo_font_options_set_hint_style(pOptions, 
CAIRO_HINT_STYLE_SLIGHT);
-// Disable private CAIRO_ROUND_GLYPH_POS_ON by merging with font 
options known to have
-// CAIRO_ROUND_GLYPH_POS_OFF
 if (bResolutionIndependentLayoutEnabled)
 {
+// Disable private CAIRO_ROUND_GLYPH_POS_ON by merging with
+// font options known to have CAIRO_ROUND_GLYPH_POS_OFF
 cairo_font_options_merge(pOptions, CairoFontOptions::get());
-// tdf#153699 skip this with cairo 1.17.8 as it has a problem
+
+// a) tdf#153699 skip this with cairo 1.17.8 as it has a 
problem
 // See: https://gitlab.freedesktop.org/cairo/cairo/-/issues/643
-if (cairo_version() != CAIRO_VERSION_ENCODE(1,17,8))
+// b) tdf#152675 a similar report for cairo: 1.16.0-4ubuntu1,
+// assume that everything <= 1.17.8 is unsafe to disable this
+if (cairo_version() <= CAIRO_VERSION_ENCODE(1, 17, 8))
 cairo_font_options_set_hint_metrics(pOptions, 
CAIRO_HINT_METRICS_OFF);
 }
 cairo_set_font_options(cr, pOptions);

[Libreoffice-commits] core.git: Branch 'libreoffice-7-5' - vcl/unx

[Caolán McNamara (via logerrit)]

 vcl/unx/generic/gdi/cairotextrender.cxx |   11 +++
 1 file changed, 7 insertions(+), 4 deletions(-)

New commits:
commit 865893432c4037f534ee28ea794e888e5ce7702b
Author: Caolán McNamara 
AuthorDate: Sat Sep 23 07:16:06 2023 +0100
Commit: Michael Stahl 
CommitDate: Mon Sep 25 13:35:54 2023 +0200

tdf#152675 treat all cairo versions <= 1.17.8 the same

wrt unwanted sideeffects of CAIRO_HINT_METRICS_OFF seen
in https://gitlab.freedesktop.org/cairo/cairo/-/issues/643
and https://bugs.documentfoundation.org/show_bug.cgi?id=152675

Change-Id: Ib3f43fd3832083f1768b737e3a5fb28063c0ae23
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157177
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
(cherry picked from commit 1dd357ccf7ca9edbe5f2ef60465c2559f678d306)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157126
Reviewed-by: Michael Stahl 

diff --git a/vcl/unx/generic/gdi/cairotextrender.cxx 
b/vcl/unx/generic/gdi/cairotextrender.cxx
index 0a10f6708faf..9c8b3b6563de 100644
--- a/vcl/unx/generic/gdi/cairotextrender.cxx
+++ b/vcl/unx/generic/gdi/cairotextrender.cxx
@@ -311,14 +311,17 @@ void CairoTextRender::DrawTextLayout(const 
GenericSalLayout& rLayout, const SalG
 cairo_font_options_set_antialias(pOptions, 
CAIRO_ANTIALIAS_NONE);
 if (!bAllowedHintStyle)
 cairo_font_options_set_hint_style(pOptions, 
CAIRO_HINT_STYLE_SLIGHT);
-// Disable private CAIRO_ROUND_GLYPH_POS_ON by merging with font 
options known to have
-// CAIRO_ROUND_GLYPH_POS_OFF
 if (bResolutionIndependentLayoutEnabled)
 {
+// Disable private CAIRO_ROUND_GLYPH_POS_ON by merging with
+// font options known to have CAIRO_ROUND_GLYPH_POS_OFF
 cairo_font_options_merge(pOptions, CairoFontOptions::get());
-// tdf#153699 skip this with cairo 1.17.8 as it has a problem
+
+// a) tdf#153699 skip this with cairo 1.17.8 as it has a 
problem
 // See: https://gitlab.freedesktop.org/cairo/cairo/-/issues/643
-if (cairo_version() != CAIRO_VERSION_ENCODE(1,17,8))
+// b) tdf#152675 a similar report for cairo: 1.16.0-4ubuntu1,
+// assume that everything <= 1.17.8 is unsafe to disable this
+if (cairo_version() <= CAIRO_VERSION_ENCODE(1, 17, 8))
 cairo_font_options_set_hint_metrics(pOptions, 
CAIRO_HINT_METRICS_OFF);
 }
 cairo_set_font_options(cr, pOptions);

[Libreoffice-commits] core.git: sw/source

[Miklos Vajna (via logerrit)]

 sw/source/uibase/shells/textfld.cxx |   14 +-
 1 file changed, 9 insertions(+), 5 deletions(-)

New commits:
commit fca39498dfc29a1c026ff854ca797ea39161124b
Author: Miklos Vajna 
AuthorDate: Fri Sep 22 15:40:17 2023 +0200
Commit: Caolán McNamara 
CommitDate: Mon Sep 25 11:14:39 2023 +0200

sw: fix crash in SwTextShell::ExecField()

Crashreport signature:

Fatal signal received: SIGSEGV code: 128 for address: 0x0

program/libswlo.so
SwTextShell::ExecField(SfxRequest&)
sw/source/uibase/shells/textfld.cxx:456
program/libmergedlo.so
SfxDispatcher::Call_Impl(SfxShell&, SfxSlot const&, SfxRequest&, 
bool)
sfx2/source/control/dispatch.cxx:257
program/libmergedlo.so
SfxDispatcher::Execute(unsigned short, SfxCallMode, SfxItemSet 
const*, SfxItemSet const*, unsigned short)
sfx2/source/control/dispatch.cxx:814
program/libmergedlo.so
SfxDispatchController_Impl::dispatch(com::sun::star::util::URL 
const&, com::sun::star::uno::Sequence 
const&, 
com::sun::star::uno::Reference 
const&)
sfx2/source/control/unoctitm.cxx:682

Change-Id: I359f9ee643daff9acfb67800e38666cce060c0b6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157171
Tested-by: Jenkins CollaboraOffice 
Tested-by: Caolán McNamara 
Reviewed-by: Caolán McNamara 
(cherry picked from commit 1dc16c277107f8f67b52c1b3eaef21e0f2d20fde)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157213
Tested-by: Jenkins

diff --git a/sw/source/uibase/shells/textfld.cxx 
b/sw/source/uibase/shells/textfld.cxx
index 53fd4471ce37..d8da30749cc7 100644
--- a/sw/source/uibase/shells/textfld.cxx
+++ b/sw/source/uibase/shells/textfld.cxx
@@ -462,13 +462,17 @@ void SwTextShell::ExecField(SfxRequest )
 pMgr->RegisterAnswerText(sText);
 pWin->ExecuteCommand(nSlot);
 
-// Set the parent postit id of the reply.
-
GetView().GetPostItMgr()->GetLatestPostItField()->SetParentPostItId(pIdItem->GetValue().toUInt32());
+SwPostItField* pLatestPostItField = 
pMgr->GetLatestPostItField();
+if (pLatestPostItField)
+{
+// Set the parent postit id of the reply.
+
pLatestPostItField->SetParentPostItId(pIdItem->GetValue().toUInt32());
 
-// If name of the replied comment is empty, we need to 
set a name in order to connect them in the xml file.
-pWin->GeneratePostItName(); // Generates a name if the 
current name is empty.
+// If name of the replied comment is empty, we 
need to set a name in order to connect them in the xml file.
+pWin->GeneratePostItName(); // Generates a name if 
the current name is empty.
 
-
GetView().GetPostItMgr()->GetLatestPostItField()->SetParentName(pWin->GetPostItField()->GetName());
+
pLatestPostItField->SetParentName(pWin->GetPostItField()->GetName());
+}
 }
 }
 }

[Libreoffice-commits] core.git: cui/source sc/source sd/source sfx2/source starmath/source svx/source sw/source

[Bayram Çiçek (via logerrit)]

 cui/source/options/connpooloptions.cxx  |   10 +++
 cui/source/options/dbregister.cxx   |5 +
 cui/source/options/fontsubs.cxx |   10 +++
 cui/source/options/optaccessibility.cxx |   10 +++
 cui/source/options/optasian.cxx |   10 +++
 cui/source/options/optbasic.cxx |   10 +++
 cui/source/options/optchart.cxx |   10 +++
 cui/source/options/optcolor.cxx |5 +
 cui/source/options/optctl.cxx   |   15 -
 cui/source/options/optdeepl.cxx |8 ++-
 cui/source/options/optfltr.cxx  |   20 ++-
 cui/source/options/optgdlg.cxx  |   33 ++--
 cui/source/options/optgenrl.cxx |5 +
 cui/source/options/opthtml.cxx  |   10 +++
 cui/source/options/optinet2.cxx |   28 --
 cui/source/options/optjava.cxx  |   15 -
 cui/source/options/optjsearch.cxx   |   10 +++
 cui/source/options/optlanguagetool.cxx  |   13 +++--
 cui/source/options/optlingu.cxx |5 +
 cui/source/options/optopencl.cxx|5 +
 cui/source/options/optpath.cxx  |4 +
 cui/source/options/optsave.cxx  |   10 +++
 cui/source/options/optupdt.cxx  |   15 -
 cui/source/options/personalization.cxx  |8 ++-
 cui/source/tabpages/tparea.cxx  |5 +
 sc/source/ui/optdlg/opredlin.cxx|5 +
 sc/source/ui/optdlg/tpcalc.cxx  |   15 -
 sc/source/ui/optdlg/tpcompatibility.cxx |5 +
 sc/source/ui/optdlg/tpdefaults.cxx  |5 +
 sc/source/ui/optdlg/tpformula.cxx   |   15 -
 sc/source/ui/optdlg/tpprint.cxx |   10 +++
 sc/source/ui/optdlg/tpusrlst.cxx|   10 +++
 sc/source/ui/optdlg/tpview.cxx  |   25 +++--
 sd/source/ui/dlg/prntopts.cxx   |   15 -
 sd/source/ui/dlg/tpoption.cxx   |   20 ++-
 sfx2/source/dialog/printopt.cxx |   15 -
 starmath/source/dialog.cxx  |   15 -
 svx/source/dialog/optgrid.cxx   |   10 +++
 sw/source/ui/config/mailconfigpage.cxx  |   15 -
 sw/source/ui/config/optcomp.cxx |5 +
 sw/source/ui/config/optload.cxx |   23 ++--
 sw/source/ui/config/optpage.cxx |   83 +---
 42 files changed, 452 insertions(+), 118 deletions(-)

New commits:
commit 0eb05b47a6d89fdfc533515483584fc739962b65
Author: Bayram Çiçek 
AuthorDate: Wed Sep 20 14:37:08 2023 +0300
Commit: Andreas Heinisch 
CommitDate: Mon Sep 25 11:05:25 2023 +0200

tdf#49895: search in Options: check if label exists (related to tdf#157266)

- since ids in ui files can be changed or removed,
we have to check if they are exits or not, to prevent
any crash or misbehavior.
- Proper solution will be iterating over the
widget ids and collecting their strings without
based on a list of identifiers.

Change-Id: I2088af6842ad0acd00838a37295dc2e6140096f2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157103
Reviewed-by: Andreas Heinisch 
Tested-by: Andreas Heinisch 

diff --git a/cui/source/options/connpooloptions.cxx 
b/cui/source/options/connpooloptions.cxx
index b13561898ab0..00101bed4fb6 100644
--- a/cui/source/options/connpooloptions.cxx
+++ b/cui/source/options/connpooloptions.cxx
@@ -165,12 +165,18 @@ namespace offapp
 OUString labels[] = { "label1", "driverslabel", "driverlabel", 
"timeoutlabel", "driver" };
 
 for (const auto& label : labels)
-sAllStrings += m_xBuilder->weld_label(label)->get_label() + " ";
+{
+if (const auto& pString = m_xBuilder->weld_label(label))
+sAllStrings += pString->get_label() + " ";
+}
 
 OUString checkButton[] = { "connectionpooling", "enablepooling" };
 
 for (const auto& check : checkButton)
-sAllStrings += m_xBuilder->weld_check_button(check)->get_label() + 
" ";
+{
+if (const auto& pString = m_xBuilder->weld_check_button(check))
+sAllStrings += pString->get_label() + " ";
+}
 
 return sAllStrings.replaceAll("_", "");
 }
diff --git a/cui/source/options/dbregister.cxx 
b/cui/source/options/dbregister.cxx
index d1c8abb4d102..8386cc546595 100644
--- a/cui/source/options/dbregister.cxx
+++ b/cui/source/options/dbregister.cxx
@@ -133,7 +133,10 @@ std::unique_ptr 
DbRegistrationOptionsPage::Create( weld::Container*
 
 OUString DbRegistrationOptionsPage::GetAllStrings()
 {
-OUString sAllStrings = m_xBuilder->weld_label("label1")->get_label() + " ";
+OUString sAllStrings;
+
+if (const auto& pString = m_xBuilder->weld_label("label1"))
+sAllStrings += pString->get_label() + " ";
 
 return sAllStrings.replaceAll("_", "");
 }
diff --git a/cui/source/options/fontsubs.cxx b/cui/source/options/fontsubs.cxx
index b2fb0604dcf8..eaf00e2364dd 100644
--- a/cui/source/options/fontsubs.cxx
+++ b/cui/source/options/fontsubs.cxx
@@ -146,12 +146,18 @@ OUString 

[Libreoffice-commits] core.git: Branch 'libreoffice-7-5' - vcl/unx

[Caolán McNamara (via logerrit)]

 vcl/unx/gtk3/gtkinst.cxx |   13 +
 1 file changed, 1 insertion(+), 12 deletions(-)

New commits:
commit 4ca16def0e375f6e190870b2d20ac50ad834d8e3
Author: Caolán McNamara 
AuthorDate: Fri Sep 22 19:59:31 2023 +0100
Commit: Caolán McNamara 
CommitDate: Mon Sep 25 12:17:12 2023 +0200

tdf#157168 GtkSpinButton ignores out-of-range value instead of limiting

(to range)

Change-Id: Ib25276ccea18b45756ac2769cb00cb9d7db0c400
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157125
Tested-by: Jenkins
Reviewed-by: Justin Luth 

diff --git a/vcl/unx/gtk3/gtkinst.cxx b/vcl/unx/gtk3/gtkinst.cxx
index dcfae5690d8f..38e56c87723a 100644
--- a/vcl/unx/gtk3/gtkinst.cxx
+++ b/vcl/unx/gtk3/gtkinst.cxx
@@ -17444,11 +17444,6 @@ public:
 m_aCustomFont.use_custom_font(, u"spinbutton");
 }
 
-void set_update_policy_if_valid()
-{
-gtk_spin_button_set_update_policy(m_pButton, GTK_UPDATE_IF_VALID);
-}
-
 virtual void disable_notify_events() override
 {
 g_signal_handler_block(m_pButton, m_nValueChangedSignalId);
@@ -24295,13 +24290,7 @@ public:
 
 virtual std::unique_ptr 
weld_metric_spin_button(const OString& id, FieldUnit eUnit) override
 {
-std::unique_ptr xButton(weld_spin_button(id));
-if (xButton)
-{
-GtkInstanceSpinButton& rButton = 
dynamic_cast(*xButton);
-rButton.set_update_policy_if_valid();
-}
-return std::make_unique(std::move(xButton), 
eUnit);
+return std::make_unique(weld_spin_button(id), 
eUnit);
 }
 
 virtual std::unique_ptr 
weld_formatted_spin_button(const OString ) override

[Libreoffice-commits] core.git: Branch 'libreoffice-7-6' - vcl/unx

[Caolán McNamara (via logerrit)]

 vcl/unx/gtk3/gtkinst.cxx |   13 +
 1 file changed, 1 insertion(+), 12 deletions(-)

New commits:
commit d7443d6a3191e37e1e2ad2f2f2d9310e0198b9bf
Author: Caolán McNamara 
AuthorDate: Fri Sep 22 19:59:31 2023 +0100
Commit: Caolán McNamara 
CommitDate: Mon Sep 25 12:17:20 2023 +0200

tdf#157168 GtkSpinButton ignores out-of-range value instead of limiting

(to range)

Change-Id: Ib25276ccea18b45756ac2769cb00cb9d7db0c400
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157124
Tested-by: Jenkins
Reviewed-by: Justin Luth 

diff --git a/vcl/unx/gtk3/gtkinst.cxx b/vcl/unx/gtk3/gtkinst.cxx
index 5920480e5eaa..5eb5b15d03ed 100644
--- a/vcl/unx/gtk3/gtkinst.cxx
+++ b/vcl/unx/gtk3/gtkinst.cxx
@@ -17517,11 +17517,6 @@ public:
 m_aCustomFont.use_custom_font(, u"spinbutton");
 }
 
-void set_update_policy_if_valid()
-{
-gtk_spin_button_set_update_policy(m_pButton, GTK_UPDATE_IF_VALID);
-}
-
 virtual void disable_notify_events() override
 {
 g_signal_handler_block(m_pButton, m_nValueChangedSignalId);
@@ -24351,13 +24346,7 @@ public:
 
 virtual std::unique_ptr 
weld_metric_spin_button(const OUString& id, FieldUnit eUnit) override
 {
-std::unique_ptr xButton(weld_spin_button(id));
-if (xButton)
-{
-GtkInstanceSpinButton& rButton = 
dynamic_cast(*xButton);
-rButton.set_update_policy_if_valid();
-}
-return std::make_unique(std::move(xButton), 
eUnit);
+return std::make_unique(weld_spin_button(id), 
eUnit);
 }
 
 virtual std::unique_ptr 
weld_formatted_spin_button(const OUString ) override

[Libreoffice-commits] core.git: Branch 'distro/allotropia/zeta-7-4' - 11 commits - bin/symstore.sh configure.ac download.lst external/openssl external/python3 readlicense_oo/license

[Taichi Haradaguchi (via logerrit)]

 bin/symstore.sh
|4 
 configure.ac   
|3 
 download.lst   
|4 
 
external/openssl/0001-x509-excessive-resource-use-verifying-policy-constra.patch.1
 |  222 --
 external/openssl/ExternalPackage_openssl.mk
|8 
 external/openssl/README
|2 
 external/openssl/UnpackedTarball_openssl.mk
|4 
 external/openssl/configurable-z-option.patch.0 
|6 
 external/openssl/openssl-no-_umul128-on-aarch64.patch.1
|   58 --
 external/openssl/openssl-no-ipc-cmd.patch.0
|   83 +++
 external/openssl/openssl-no-multilib.patch.0   
|   24 -
 external/openssl/system-cannot-find-path-for-move.patch.0  
|   11 
 external/python3/python-3.7.6-msvc-ssl.patch.1 
|6 
 readlicense_oo/license/license.xml 
|   73 ---
 14 files changed, 128 insertions(+), 380 deletions(-)

New commits:
commit 929ee378ce7536f3acd82b3669c09db8e96b7875
Author: Taichi Haradaguchi <20001...@ymail.ne.jp>
AuthorDate: Sun Aug 6 01:57:31 2023 +0900
Commit: Michael Stahl 
CommitDate: Mon Sep 25 12:36:42 2023 +0200

openssl: upgrade to release 3.0.10

Change-Id: Iee5716bdd111e2f30cb38d48a86104da52872dd5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155382
Tested-by: Jenkins
Reviewed-by: Taichi Haradaguchi <20001...@ymail.ne.jp>
(cherry picked from commit 72f28e12b15823197e42265af1f8dda21224c90a)

diff --git a/download.lst b/download.lst
index 58d5b64e265e..d269f5cfd3c3 100644
--- a/download.lst
+++ b/download.lst
@@ -439,8 +439,8 @@ OPENLDAP_TARBALL := openldap-2.4.59.tgz
 # three static lines
 # so that git cherry-pick
 # will not run into conflicts
-OPENSSL_SHA256SUM := 
eb1ab04781474360f77c318ab89d8c5a03abc38e63d65a603cabbf1b00a1dc90
-OPENSSL_TARBALL := openssl-3.0.9.tar.gz
+OPENSSL_SHA256SUM := 
1761d4f5b13a1028b9b6f3d4b8e17feb0cedc9370f6afe61d7193d2cdce83323
+OPENSSL_TARBALL := openssl-3.0.10.tar.gz
 # three static lines
 # so that git cherry-pick
 # will not run into conflicts
commit 78dee1875be7cd7f13a4d8727c152fd4241c403c
Author: Christian Lohmaier 
AuthorDate: Sat Mar 11 21:22:55 2023 +0100
Commit: Michael Stahl 
CommitDate: Mon Sep 25 12:35:15 2023 +0200

cross-compiling on windows needs openssl to build internal python

→ add back OPENSSL as a permissable sub-build target and explicitly
enable openssl when cross-compiling for windows_aarch64

partially reverts 4132bd5477c25a505f7bfbee1e7dcf6602c927d3

Change-Id: Ic162a2f0c6db377eadedb149fb428f0f015539f9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148688
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier 
(cherry picked from commit 5f20f4ff21f597e55d899f5ea4dfe1c1fa5824bc)

diff --git a/configure.ac b/configure.ac
index b222b378e3b1..0c94e04acaca 100644
--- a/configure.ac
+++ b/configure.ac
@@ -5629,6 +5629,9 @@ if test "$cross_compiling" = "yes"; then
 if test "$_os" = "Emscripten"; then
 sub_conf_opts="$sub_conf_opts --without-system-libxml 
--without-system-fontconfig --without-system-freetype --without-system-zlib"
 fi
+# windows uses full-internal python and that in turn relies on openssl, so 
also enable openssl
+# when cross-compiling for aarch64, overriding the defaults below
+test "${PLATFORMID}" = "windows_aarch64" && sub_conf_opts="$sub_conf_opts 
--enable-openssl --with-tls=openssl"
 
 # Don't bother having configure look for stuff not needed for the build 
platform anyway
 # WARNING: any option with an argument containing spaces must be handled 
separately (see --with-theme)
commit bc527b17dddfe8eb204c1702bf28bfc7c1c564ba
Author: Andras Timar 
AuthorDate: Sun Feb 26 23:04:54 2023 +0100
Commit: Michael Stahl 
CommitDate: Mon Sep 25 12:34:57 2023 +0200

OpenSSL 3 is covered by Apache License v2

Change-Id: I20b30ce01b08787f560cd00cd87db9cec1699240
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147746
Tested-by: Jenkins
Reviewed-by: Andras Timar 
(cherry picked from commit 62d3da841b402f7cc9421d87f3f1db714b278d40)

diff --git a/readlicense_oo/license/license.xml 
b/readlicense_oo/license/license.xml
index d1dec6ad962f..5fdcdad12d0a 100644
--- a/readlicense_oo/license/license.xml
+++ b/readlicense_oo/license/license.xml
@@ -1525,78 +1525,7 @@
 OpenSSL
 The following software may be included in this product: OpenSSL. 
Use of any of this software is governed by
 the terms of 

Re: LO 24.2 C++20 baseline

[Stephan Bergmann]

On 9/25/23 08:30, Miklos Vajna wrote:

gcc-12 looks fine here, but I hit an interesting problem with clang-15
(which worked fine before pulling):

$ make animations
make -j 16 -f 
/home/vmiklos/git/libreoffice/core-clang/compilerplugins/Makefile-clang.mk 
compilerplugins
make[1]: Entering directory '/home/vmiklos/git/libreoffice/core-clang'
make[1]: Nothing to be done for 'compilerplugins'.
make[1]: Leaving directory '/home/vmiklos/git/libreoffice/core-clang'
cd /home/vmiklos/git/libreoffice/core-clang/animations && make -j 16 -rs
[CXX] animations/source/animcore/animcore.cxx
[LOC] top level modules: animations
In file included from 
/home/vmiklos/git/libreoffice/core-clang/animations/source/animcore/animcore.cxx:20:
In file included from 
/home/vmiklos/git/libreoffice/core-clang/workdir/UnoApiHeadersTarget/offapi/normal/com/sun/star/util/XCloneable.hpp:8:
/home/vmiklos/git/libreoffice/core-clang/workdir/UnoApiHeadersTarget/udkapi/normal/com/sun/star/uno/XInterface.hpp:32:65:
 error: invalid application of 'sizeof' to an incomplete type 
'animcore::(anonymous namespace)::AnimationNode'
template inline constexpr auto isUnoInterfaceType = sizeof (T) && 
IsUnoInterfaceType::value;
 ^~
/home/vmiklos/git/libreoffice/core-clang/include/unotools/weakref.hxx:119:33: 
note: in instantiation of variable template specialization 
'cppu::detail::isUnoInterfaceType' requested here
 requires(!cppu::detail::isUnoInterfaceType)
 ^
/home/vmiklos/git/libreoffice/core-clang/animations/source/animcore/animcore.cxx:309:44:
 note: in instantiation of template class 
'unotools::WeakReference' 
requested here
 unotools::WeakReference mxParent;
^
/home/vmiklos/git/libreoffice/core-clang/animations/source/animcore/animcore.cxx:121:7:
 note: definition of 'animcore::(anonymous namespace)::AnimationNode' is not 
complete until the closing '}'
class AnimationNode final:  public AnimationNodeBase
   ^
1 error generated.
make[1]: *** 
[/home/vmiklos/git/libreoffice/core-clang/solenv/gbuild/LinkTarget.mk:340: 
/home/vmiklos/git/libreoffice/core-clang/workdir/CxxObject/animations/source/animcore/animcore.o]
 Error 1
make: *** [Makefile:121: animations] Error 2

Given that AnimationNode refers to itself, we probably can't provide a
full type for unotools::WeakReference. But then how to get around this?


Was that maybe an intermittent Clang bug?  It apparently doesn't hit the 
Jenkins Clang builds, and I don't see it with trunk Clang 18 either, but 
have dim memories that there was some issue with too-eager evaluation 
causing something like this at some point.  Do you have a way to check 
with another Clang version, to substantiate that assumption?

Re: LO 24.2 C++20 baseline

[Caolán McNamara]

On Mon, 2023-09-25 at 13:48 +0300, Stephan Bergmann wrote:
> Was that maybe an intermittent Clang bug?  It apparently doesn't hit
> the Jenkins Clang builds, and I don't see it with trunk Clang 18
> either

I'm seeing it in oss-fuzz too FWIW, like
https://oss-fuzz-build-logs.storage.googleapis.com/log-d8e659e6-8b3e-45b0-9676-ceb57d8152f4.txt

[Libreoffice-commits] core.git: Branch 'libreoffice-7-6' - sw/CppunitTest_sw_core_layout.mk sw/qa sw/source

[Miklos Vajna (via logerrit)]

 sw/CppunitTest_sw_core_layout.mk   |1 
 sw/qa/core/layout/data/floattable-next-row-invalidate-pos.docx |binary
 sw/qa/core/layout/layact.cxx   |   78 
++
 sw/source/core/layout/layact.cxx   |   40 +
 4 files changed, 118 insertions(+), 1 deletion(-)

New commits:
commit 1b6ed32cd87c40e3b3de4dac4efa035c6394a1d5
Author: Miklos Vajna 
AuthorDate: Tue Sep 19 08:33:45 2023 +0200
Commit: Xisco Fauli 
CommitDate: Mon Sep 25 14:06:45 2023 +0200

tdf#157005 sw floattable: fix missing format of next row in follow fly

The bugdoc has a multi-page floating table, the B1 cell is on page 1.
Pressing enter at the end of the cell first creates a split cell (on
page 1 and page 2), but then pressing enter once more leads to
overlapping text.

The trouble seems to be that the second row has its
mbFrameAreaPositionValid set to false, but nobody formats the row, that
would recalc its position.

Fix the problem by relaxing the check in SwLayAction::FormatContent(),
so we do a full format not only in case there are to-para anchored
objects to the current content frame, but also do the same in case it's
a follow and the matching master has some draw objects that are
effectively anchored in the current content frame.

Previously this wasn't a problem, because split flys are the only
construct where a follow frame can have to-para anchored objects.

Change-Id: I0893aced3ad59963f87874c5aff0e57ad325c01b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157039
Reviewed-by: Miklos Vajna 
Tested-by: Jenkins
Signed-off-by: Xisco Fauli 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157132

diff --git a/sw/CppunitTest_sw_core_layout.mk b/sw/CppunitTest_sw_core_layout.mk
index 9431b6b83526..ae945c89ee43 100644
--- a/sw/CppunitTest_sw_core_layout.mk
+++ b/sw/CppunitTest_sw_core_layout.mk
@@ -15,6 +15,7 @@ $(eval $(call 
gb_CppunitTest_use_common_precompiled_header,sw_core_layout))
 
 $(eval $(call gb_CppunitTest_add_exception_objects,sw_core_layout, \
 sw/qa/core/layout/flycnt \
+sw/qa/core/layout/layact \
 sw/qa/core/layout/layout \
 sw/qa/core/layout/paintfrm \
 sw/qa/core/layout/tabfrm \
diff --git a/sw/qa/core/layout/data/floattable-next-row-invalidate-pos.docx 
b/sw/qa/core/layout/data/floattable-next-row-invalidate-pos.docx
new file mode 100644
index ..bbc7114b8e20
Binary files /dev/null and 
b/sw/qa/core/layout/data/floattable-next-row-invalidate-pos.docx differ
diff --git a/sw/qa/core/layout/layact.cxx b/sw/qa/core/layout/layact.cxx
new file mode 100644
index ..64262977f7fe
--- /dev/null
+++ b/sw/qa/core/layout/layact.cxx
@@ -0,0 +1,78 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#include 
+
+#include 
+
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+
+namespace
+{
+/// Covers sw/source/core/layout/layact.cxx fixes.
+class Test : public SwModelTestBase
+{
+public:
+Test()
+: SwModelTestBase("/sw/qa/core/layout/data/")
+{
+}
+};
+
+CPPUNIT_TEST_FIXTURE(Test, testSplitFlyNextRowInvalidatePos)
+{
+// Given a multi-page floating table, row1 is split, i.e. is both on page 
1 and page 2:
+createSwDoc("floattable-next-row-invalidate-pos.docx");
+// Make sure the follow anchor's IsCompletePaint() reaches its false 
state, as it happens in the
+// interactive case.
+Scheduler::ProcessEventsToIdle();
+SwDoc* pDoc = getSwDoc();
+SwRootFrame* pLayout = pDoc->getIDocumentLayoutAccess().GetCurrentLayout();
+auto pPage1 = pLayout->Lower()->DynCastPageFrame();
+CPPUNIT_ASSERT(pPage1);
+auto pPage2 = pPage1->GetNext()->DynCastPageFrame();
+CPPUNIT_ASSERT(pPage2);
+CPPUNIT_ASSERT(pPage2->GetSortedObjs());
+SwSortedObjs& rPage2Objs = *pPage2->GetSortedObjs();
+auto pFly2 = rPage2Objs[0]->DynCastFlyFrame();
+auto pTable2 = pFly2->GetLower()->DynCastTabFrame();
+auto pRow2 = pTable2->GetLastLower()->DynCastRowFrame();
+SwTwips nOldRow2Top = pRow2->getFrameArea().Top();
+
+// When adding a new paragraph at the end of B1:
+// Go to the table: A1 cell.
+SwWrtShell* pWrtShell = getSwDocShell()->GetWrtShell();
+pWrtShell->GotoTable("Table1");
+// Go to the column: B1 cell.
+pWrtShell->GoNextCell();
+// Go to the end of the B1 cell, on page 2.
+pWrtShell->EndOfSection();
+// Add a new paragraph at the cell end.
+pWrtShell->SplitNode();
+
+// Then make sure row 2 is shifted down:
+SwTwips 

[Libreoffice-commits] core.git: Branch 'distro/allotropia/zeta-7-4' - 5 commits - connectivity/source editeng/source sc/source sd/qa sfx2/source slideshow/source starmath/source vcl/source

[Stephan Bergmann (via logerrit)]

 connectivity/source/manager/mdrivermanager.cxx  |7 +++
 editeng/source/accessibility/AccessibleEditableTextPara.cxx |3 -
 sc/source/ui/drawfunc/drtxtob.cxx   |3 -
 sc/source/ui/view/editsh.cxx|3 -
 sd/qa/unit/tiledrendering/tiledrendering.cxx|8 +--
 sfx2/source/view/viewfrm.cxx|3 -
 slideshow/source/engine/eventqueue.cxx  |4 -
 starmath/source/unomodel.cxx|   27 +--
 vcl/source/window/layout.cxx|   28 
 9 files changed, 49 insertions(+), 37 deletions(-)

New commits:
commit 230e3fc3bd9197f93b11136e27949e8a7bb6f51d
Author: Stephan Bergmann 
AuthorDate: Thu Nov 3 17:11:01 2022 +0100
Commit: Michael Stahl 
CommitDate: Mon Sep 25 14:07:23 2023 +0200

Reinstate removal of lcl_GuessPaperSize

...originally done with 1d7964c5ff579ff93067dc1c3e45b522e3cb2b4e 
"CWS-TOOLING:
integrate CWS unifypaper01" on 2009-06-12.  However, the removed
lcl_GuessPaperSize then reappeared, apparently with the merge commit
4563270cfd37f1a08e0315a5624affa3a7680771 "CWS-TOOLING: integrate CWS
printerpullpages" on 2010-01-15, presumably due to a mis-merge somewhere 
along
the way.

SmModel::getRenderer and SmModel::render are e.g. called when doing "Export 
as
PDF..." of a Math Formula, but it seems a bit hard to get into the "no real
printer" branches there that would actually have called lcl_GuessPaperSize. 
 But
anyway, it looks reasonable to replace that function with the more elaborate
SvxPaperInfo::GetDefaultPaperSize.

(I stumbled over this when the code in lcl_GuessPaperSize caused a newly
introduced -Werror=dangling-reference with GCC 13 trunk, similar to
e0121b2478526d803681d57d59af0cbf9cf602b4 "-Werror=dangling-reference".  So I
figured I'd remove that code as apparently intended back in 2009 rather 
than try
to fix it now.)

Change-Id: Ia73d9ece8429bbeccd4f65a9efc156c0dee52c01
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142246
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 
(cherry picked from commit 20926c0a7559ea9c4f82c662f11a395fa1eb79a3)

diff --git a/starmath/source/unomodel.cxx b/starmath/source/unomodel.cxx
index 42f377f27ce9..0f15abf2e24c 100644
--- a/starmath/source/unomodel.cxx
+++ b/starmath/source/unomodel.cxx
@@ -40,6 +40,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -898,28 +899,6 @@ sal_Int32 SAL_CALL SmModel::getRendererCount(
 return 1;
 }
 
-
-static Size lcl_GuessPaperSize()
-{
-Size aRes;
-const LocaleDataWrapper& rLocWrp( AllSettings().GetLocaleDataWrapper() );
-if( MeasurementSystem::Metric == rLocWrp.getMeasurementSystemEnum() )
-{
-// in 100th mm
-PaperInfo aInfo( PAPER_A4 );
-aRes.setWidth( aInfo.getWidth() );
-aRes.setHeight( aInfo.getHeight() );
-}
-else
-{
-// in 100th mm
-PaperInfo aInfo( PAPER_LETTER );
-aRes.setWidth( aInfo.getWidth() );
-aRes.setHeight( aInfo.getHeight() );
-}
-return aRes;
-}
-
 uno::Sequence< beans::PropertyValue > SAL_CALL SmModel::getRenderer(
 sal_Int32 nRenderer,
 const uno::Any& /*rSelection*/,
@@ -941,7 +920,7 @@ uno::Sequence< beans::PropertyValue > SAL_CALL 
SmModel::getRenderer(
 // if paper size is 0 (usually if no 'real' printer is found),
 // guess the paper size
 if (aPrtPaperSize.IsEmpty())
-aPrtPaperSize = lcl_GuessPaperSize();
+aPrtPaperSize = SvxPaperInfo::GetDefaultPaperSize(MapUnit::Map100thMM);
 awt::Size   aPageSize( aPrtPaperSize.Width(), aPrtPaperSize.Height() );
 
 uno::Sequence< beans::PropertyValue > aRenderer(1);
@@ -1015,7 +994,7 @@ void SAL_CALL SmModel::render(
 // no real printer ??
 if (aPrtPaperSize.IsEmpty())
 {
-aPrtPaperSize = lcl_GuessPaperSize();
+aPrtPaperSize = SvxPaperInfo::GetDefaultPaperSize(MapUnit::Map100thMM);
 // factors from Windows DIN A4
 aOutputSize= Size( static_cast(aPrtPaperSize.Width()  
* 0.941),
static_cast(aPrtPaperSize.Height() 
* 0.961));
commit 24f31d62b15d162632198cbe9e689d871f11194b
Author: Stephan Bergmann 
AuthorDate: Tue Aug 23 15:37:06 2022 +0200
Commit: Michael Stahl 
CommitDate: Mon Sep 25 13:55:47 2023 +0200

-Werror=redundant-move

...with recent GCC 16 trunk.  Introduced with
1a2926a995fdbdcdae0ca6407877084f3520e539 "use std::move when popping stuff 
off
stacks" but which doesn't make sense here where std::priority_queue's top()
unconditionally returns a const reference (unlike std::stack's top()).

Change-Id: I408920220e3b7ffe775fa87f9edbfdc7721058db
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138732
Tested-by: 

[Libreoffice-commits] core.git: framework/source include/unotools sfx2/source unotools/source

[Andreas Heinisch (via logerrit)]

 framework/source/uielement/recentfilesmenucontroller.cxx |2 
 include/unotools/historyoptions.hxx  |5 
 sfx2/source/control/recentdocsview.cxx   |2 
 sfx2/source/dialog/backingwindow.cxx |2 
 unotools/source/config/historyoptions.cxx|   88 ++-
 5 files changed, 65 insertions(+), 34 deletions(-)

New commits:
commit 71cae3a219ff1629368b8f324d0de89afc9445e9
Author: Andreas Heinisch 
AuthorDate: Fri Sep 22 12:06:50 2023 +0200
Commit: Andreas Heinisch 
CommitDate: Mon Sep 25 14:15:37 2023 +0200

tdf#155698 - Start Center: Retain pinned items when clearing the list

Change-Id: Ife54845e020977cdb80a7fcc1fa6afc17b32
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157169
Tested-by: Jenkins
Reviewed-by: Andreas Heinisch 

diff --git a/framework/source/uielement/recentfilesmenucontroller.cxx 
b/framework/source/uielement/recentfilesmenucontroller.cxx
index 75d13407ad93..9c8eea5ef694 100644
--- a/framework/source/uielement/recentfilesmenucontroller.cxx
+++ b/framework/source/uielement/recentfilesmenucontroller.cxx
@@ -383,7 +383,7 @@ void SAL_CALL RecentFilesMenuController::itemSelected( 
const css::awt::MenuEvent
 
 if ( aCommand == CMD_CLEAR_LIST )
 {
-SvtHistoryOptions::Clear( EHistoryType::PickList );
+SvtHistoryOptions::Clear( EHistoryType::PickList, false );
 dispatchCommand(
 "vnd.org.libreoffice.recentdocs:ClearRecentFileList",
 css::uno::Sequence< css::beans::PropertyValue >() );
diff --git a/include/unotools/historyoptions.hxx 
b/include/unotools/historyoptions.hxx
index b2388de2ad4b..3eb8162ee0b5 100644
--- a/include/unotools/historyoptions.hxx
+++ b/include/unotools/historyoptions.hxx
@@ -44,7 +44,7 @@ namespace SvtHistoryOptions
 
 @param  eHistory select right history.
 */
-UNOTOOLS_DLLPUBLIC void Clear(EHistoryType eHistory);
+UNOTOOLS_DLLPUBLIC void Clear(EHistoryType eHistory, const bool 
bClearPinnedItems = true);
 
 /** Return the complete specified history list.
 
@@ -81,7 +81,8 @@ namespace SvtHistoryOptions
 
 /** Delete item from the specified list.
 */
-UNOTOOLS_DLLPUBLIC void DeleteItem(EHistoryType eHistory, const OUString& 
sURL);
+UNOTOOLS_DLLPUBLIC void DeleteItem(EHistoryType eHistory, const OUString& 
sURL,
+   const bool bClearPinned = true);
 
 // tdf#38742 - toggle pinned state of an item
 UNOTOOLS_DLLPUBLIC void TogglePinItem(EHistoryType eHistory, const 
OUString& sURL);
diff --git a/sfx2/source/control/recentdocsview.cxx 
b/sfx2/source/control/recentdocsview.cxx
index f2c58cf6e12e..cc2e80de17e9 100644
--- a/sfx2/source/control/recentdocsview.cxx
+++ b/sfx2/source/control/recentdocsview.cxx
@@ -191,7 +191,7 @@ void RecentDocsView::clearUnavailableFiles(){
 {
 const SvtHistoryOptions::HistoryItem& rPickListEntry = aHistoryList[i];
 if ( !comphelper::DirectoryHelper::fileExists(rPickListEntry.sURL) ){
-
SvtHistoryOptions::DeleteItem(EHistoryType::PickList,rPickListEntry.sURL);
+
SvtHistoryOptions::DeleteItem(EHistoryType::PickList,rPickListEntry.sURL, 
false);
 }
 }
 Reload();
diff --git a/sfx2/source/dialog/backingwindow.cxx 
b/sfx2/source/dialog/backingwindow.cxx
index fbae5e1af221..553577a846df 100644
--- a/sfx2/source/dialog/backingwindow.cxx
+++ b/sfx2/source/dialog/backingwindow.cxx
@@ -647,7 +647,7 @@ IMPL_LINK (BackingWindow, MenuSelectHdl, const OUString&, 
rId, void)
 {
 if (rId == "clear_all")
 {
-SvtHistoryOptions::Clear(EHistoryType::PickList);
+SvtHistoryOptions::Clear(EHistoryType::PickList, false);
 mxAllRecentThumbnails->Reload();
 return;
 }
diff --git a/unotools/source/config/historyoptions.cxx 
b/unotools/source/config/historyoptions.cxx
index 2cda950858d2..8361aa6bc358 100644
--- a/unotools/source/config/historyoptions.cxx
+++ b/unotools/source/config/historyoptions.cxx
@@ -68,27 +68,49 @@ static sal_uInt32 GetCapacity(const 
uno::Reference& xCom
 namespace SvtHistoryOptions
 {
 
-void Clear( EHistoryType eHistory )
+void Clear(EHistoryType eHistory, const bool bClearPinnedItems)
 {
 try
 {
 uno::Reference xCfg = GetConfig();
 uno::Reference xListAccess(GetListAccess(xCfg, 
eHistory));
 
-// clear ItemList
-uno::Reference xNode;
-xListAccess->getByName(s_sItemList) >>= xNode;
-Sequence aStrings(xNode->getElementNames());
+// Retrieve order and item lists using name access to check properties 
of individual items
+uno::Reference xItemList;
+uno::Reference xOrderList;
+xListAccess->getByName(s_sItemList)  >>= xItemList;
+xListAccess->getByName(s_sOrderList) >>= xOrderList;
 
-for (const auto& rString : std::as_const(aStrings))
-xNode->removeByName(rString);
+

[Libreoffice-commits] core.git: vcl/source

[Caolán McNamara (via logerrit)]

 vcl/source/gdi/TypeSerializer.cxx |4 
 1 file changed, 4 insertions(+)

New commits:
commit 788ef4f347d8a3c87d45d38ce6bf13cdd3dd76a2
Author: Caolán McNamara 
AuthorDate: Mon Sep 25 10:40:50 2023 +0100
Commit: Caolán McNamara 
CommitDate: Mon Sep 25 14:17:17 2023 +0200

ofz#62439 Integer-overflow on scale using SAL_MIN_INT32

Change-Id: Ib26feee174caab9f515cd88cc3cb4a83debb0d99
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157242
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/vcl/source/gdi/TypeSerializer.cxx 
b/vcl/source/gdi/TypeSerializer.cxx
index 9144650154af..49890fc38ea0 100644
--- a/vcl/source/gdi/TypeSerializer.cxx
+++ b/vcl/source/gdi/TypeSerializer.cxx
@@ -435,6 +435,10 @@ static bool UselessScaleForMapMode(const Fraction& rScale)
 {
 if (!rScale.IsValid())
 return true;
+// ofz#62439 negative numbers are multiplied by -1, MIN_INT32 * -1
+// cannot be expressed as an int
+if (rScale.GetNumerator() == std::numeric_limits::min())
+return true;
 if (static_cast(rScale) < 0.0)
 return true;
 return false;

[Libreoffice-bugs] [Bug 157423] New: No entry possible directly after opening a CALC-file

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157423

Bug ID: 157423
   Summary: No entry possible directly after opening a CALC-file
   Product: LibreOffice
   Version: 7.5.4.2 release
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: rp.wh...@e-mail.de

Description:
Start LO-session. After opening a file for the first time in this session no
entry is possible, neither alphanumeric nor , ,  or
whatever, except(!) arrow keys. To enable entries, first press an arrow key.
In some cases I found that this problem does not appear after opening the same
file for the second time in the actual session.
Note: Release is 7.5.4.1

Steps to Reproduce:
1. Start LO-session
2. Open a calc file for the first time in the actual session
3. Try to enter something (causes no reaction)
4. Press arrow key
5. Enter something

Actual Results:
No entry possible after opening file.

Expected Results:
Entry possible directly after opening file.


Reproducible: Always


User Profile Reset: No

Additional Info:
Note: Release is 7.5.4.1, which is not a listed above.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 85059] FILEOPEN: Document wont load on Windows with LO's default MS embedded objects settings

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=85059

--- Comment #31 from Sophie Sipasseuth  ---
Repro, I have just tried to open the biggest file (Attached MS file), and LO
has stopped running.

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: df3b95a39472e18ea8acdaae447b7176e37a9256
CPU threads: 8; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win
Locale: fr-FR (fr_FR); UI: fr-FR
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 66870] Add export menu to enhance export capabilities in SVG format.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=66870

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 CC||stephane.guillou@libreoffic
   ||e.org

--- Comment #5 from Stéphane Guillou (stragu) 
 ---
Heiko, you also have bug 117708 comment 4 on a very similar topic.

Could you maybe clarify what is preferred now? Contrary to back in 2018, we now
have a "File > Export as..." submenu in Impress. So do we want to show a new
dialog:
- both with a new "Export as SVG..." entry in that submenu, and the usual "File
> Export > SVG"; or
- only when using "File > Export > SVG"
?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 39750] [META] General Math formula editor improvements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=39750
Bug 39750 depends on bug 127873, which changed state.

Bug 127873 Summary: Wrong spacing with comma in formulae
https://bugs.documentfoundation.org/show_bug.cgi?id=127873

   What|Removed |Added

 Status|VERIFIED|REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154977] Changing the paragraph area of a style makes LO crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=154977

--- Comment #18 from Stéphane Guillou (stragu) 
 ---
Thank you for the video.
Let's see if someone with Skia/Vulkan can confirm.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157403] UI: Navigator in Sidebar does not show new slide/page after file reload (Impress/Draw)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157403

m.a.riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg

--- Comment #1 from m.a.riosv  ---
Seems sometimes it takes a couple of seconds, but works for me with
Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: b97f7b6bee733e108d8214d5387b2dc019d93d8f
CPU threads: 16; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win
Locale: es-ES (es_ES); UI: en-US Calc: CL threaded Jumbo
and
Version: 7.6.2.0.0+ (X86_64) / LibreOffice Community
Build ID: 0842e6ae7db830b7ccf540685174af101dc68bc0
CPU threads: 16; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win
Locale: es-ES (es_ES); UI: en-US Calc: CL threaded
and
Version: 7.6.1.2 (X86_64) / LibreOffice Community
Build ID: f5defcebd022c5bc36bbb79be232cb6926d8f674
CPU threads: 16; OS: Windows 10.0 Build 22621; UI render: default; VCL: win
Locale: es-ES (es_ES); UI: en-US Calc: CL threaded

reproducible

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157410] Use SVG instead of bitmap when possible for HTML filters

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157410

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 CC||xiscofa...@libreoffice.org
 Blocks||108799, 156066
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||7323


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=108799
[Bug 108799] [META] HTML and XHTML export bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=156066
[Bug 156066] [META] SVG filters
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 156066] [META] SVG filters

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=156066

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on||157410


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=157410
[Bug 157410] Use SVG instead of bitmap when possible for HTML filters
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 108799] [META] HTML and XHTML export bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108799

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on||157410


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=157410
[Bug 157410] Use SVG instead of bitmap when possible for HTML filters
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157323] QR codes generated in Calc and exported to SVG or pasted elsewhere are too small

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157323

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||7410

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157340] On Calc disfonction with keys numbers on keyboard. It's correct only with keypad numbers. I checked with 2 cumputers and it's same problem

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157340

m.a.riosv  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #4 from m.a.riosv  ---

Please test in safe mode, Menu/Help/Restart in Safe Mode
But looks as if you have an issue with the keyboard, or their configuration. If
safe mode doesn't help, try changing the keyboard layout.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 96000] [META] Spelling and grammar checking bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96000

Vladislav Tarakanov  changed:

   What|Removed |Added

 Depends on||157442


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=157442
[Bug 157442] Incorrect check of a misspelled word written before an erroneous
word with a number
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157442] Incorrect check of a misspelled word written before an erroneous word with a number

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157442

Vladislav Tarakanov  changed:

   What|Removed |Added

 Blocks||96000


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=96000
[Bug 96000] [META] Spelling and grammar checking bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157422] Wrap cell contents not being retained on libreoffice Calc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157422

m.a.riosv  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||miguelangelrv@libreoffice.o
   ||rg
 Status|UNCONFIRMED |NEEDINFO

--- Comment #1 from m.a.riosv  ---
You can edit 'Default style', to have it as default, it is the root of all
other styles and direct format.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157432] Expert config: Allow filtering by changed values

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157432

m.a.riosv  changed:

   What|Removed |Added

   Keywords||needsUXEval
 CC||miguelangelrv@libreoffice.o
   ||rg

--- Comment #1 from m.a.riosv  ---
+1

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157439] Properties sidebar deck Position & Size doesn't have position controls

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157439

Eyal Rozenberg  changed:

   What|Removed |Added

 Blocks||104809


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=104809
[Bug 104809] [META] Position and Size content panel of the Properties deck/tab
of the sidebar
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157439] Properties sidebar deck Position & Size doesn't have position controls

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157439

Eyal Rozenberg  changed:

   What|Removed |Added

 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org
   Keywords||needsUXEval

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 108799] [META] HTML and XHTML export bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108799

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

Version|unspecified |Inherited From OOo

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 127873] Wrong spacing with comma in formulae

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=127873

Eike Rathke  changed:

   What|Removed |Added

   Assignee|er...@redhat.com|libreoffice-b...@lists.free
   ||desktop.org

--- Comment #17 from Eike Rathke  ---
Unassigning myself from this, someone else can investigate.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157429] Writer freezes repeatedly when scrolling through a document at speed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157429

m.a.riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg

--- Comment #1 from m.a.riosv  ---
Looks like a duplicate of tdf#156179

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 111836] Outline view: Sidebar font name toolbox is empty, however text is selected

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=111836

--- Comment #8 from Sophie Sipasseuth  ---
The bug seems resolved in the last version of LO:

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: df3b95a39472e18ea8acdaae447b7176e37a9256
CPU threads: 8; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win
Locale: fr-FR (fr_FR); UI: fr-FR
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157440] New: Impress slide images, group exported by HTML are different than single slide export, causing transition bleed through in Shotcut.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157440

Bug ID: 157440
   Summary: Impress slide images, group exported by HTML are
different than single slide export, causing transition
bleed through in Shotcut.
   Product: LibreOffice
   Version: 7.5.3.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: c...@eml.cc

Description:
I've been making presentation videos for a speaker, adding the slides from
a PowerPoint presentation over the video of the speaker at the appropriate time
for over a year.  I'd import the PowerPoint presentation into Impress, reformat
them to a size that fit the video dimensions and output the slides for the
video. It seems the only way to do a group export is outputting the
presentation to an html by following the help article "Export LibreOffice
Impress Slides as Images," getting img0, img1, ..., and deleting all the extra
file types.  But those slide/images are not the same .jpg or .png as I would
get if I exported them one at a time. This shows up in Shotcut when I
transition from one slide to the next (like when adding a bullet point). During
the dissolve the speaker shows up as a background ghost. (Shotcut notes. These
slides are on V2 above V1 so I can move the slides backwards and forward to
time the transitions with the speaker's voice.) This doesn't happen if the
slides are output from Impress as single slides. I did not have this problem
the start of last spring but I'm not sure what I might have been doing
differently or what versions I was running. There are often 40-60 slides to a
presentation so I'm sure I didn't export them all one at a time. 

Steps to Reproduce:
1.Output presentation as HTML (or as singles for comparison). I've output jpg
and png with same results
2. Pull them into shotcut. place them on V2 track, and slide to overlap them
for a transition. 
3.

Actual Results:
 If either one of the 2 images were put out as html the image below bleeds
through. 

Expected Results:
 If neither were made by html export then they transition fully opaque as they
should. 


Reproducible: Always


User Profile Reset: No

Additional Info:
Found it with LibreOffice 7.5.3.2 (x86_64), Shotcut 23.07.23, Win10 Pro 64bit
on a Dell Optiplex 7040. 
  This behavior is the same in LibreOffice 7.6.1.
  Opening the "see through" image in Gimp and exporting it to the same or
another file type, edited or unedited, did not fix the problem. 
  I've done over 40 presentations using Impress, but had taken the summer off
and  this problem was there when I started late Aug and I just figured out it
wasn't Shotcuts problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157264] Impress: Cannot change Presentation Styles via Sidebar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157264

Timur  changed:

   What|Removed |Added

 Blocks||103427


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103427
[Bug 103427] [META] Styles and Formatting sidebar deck and floating window
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103427] [META] Styles and Formatting sidebar deck and floating window

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103427

Timur  changed:

   What|Removed |Added

 Depends on||157264


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=157264
[Bug 157264] Impress: Cannot change Presentation Styles via Sidebar
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 122975] CALC: Filter should be applied to the whole column, not just to the last cell with value

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=122975

--- Comment #8 from Regis Perdreau  ---
Created attachment 189809
  --> https://bugs.documentfoundation.org/attachment.cgi?id=189809=edit
standard filter color background

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 60129] VIEWING: Window -> New window command disabled in "Web layout" view mode

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=60129

--- Comment #21 from j22...@gmail.com ---
(In reply to Mike Kaganski from comment #18)
> (In reply to Simeon Maryasin from comment #2)
> > In Print layout mode you see document as it would be printed (split to
> > pages, etc), while in Web layout mode it isn't split and its formatting
> > depends on window size.
> 
> I *guess* this is exactly the reason why it's disabled: our Web view mode is
> an imitation, implemented using some dynamically-changing pages with width
> equal to the window, and height of 10 meters. In this case, two different
> windows would conflict trying to re-format the same document to two
> different page widths at the same time.
> 
> Gülşah might have better understanding of the problem; I wonder if the
> change mentioned in comment 13 was abandoned because of some conflict of
> this kind?

I don't see the conflict here. For example, in a web browser, you can open the
same website in two different windows and see them simultaneously. If there are
changes in one of them, what is the (conceptual) problem reflecting this change
in the other one on Writer?

The point of having two windows is, for example, being able to inspect
different parts of the document at the same time. It should be independent of
the viewing mode. And it would be very useful if it could be done in Web mode.
For example in 'normal' mode, even if yo hide the 'in between pages' spaces,
you still see a lot of information (mostly formatting) that is not relevant
when you want to focus on what you write. And in many cases you want to see one
section of the text (e.g. references section?) while writing on another section
of the same document. That is when WEB view would be a great addition.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 66870] Add SVG export dialog to Impress

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=66870

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

Summary|Add export menu to enhance  |Add SVG export dialog to
   |export capabilities in SVG  |Impress
   |format. |
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||5303

--- Comment #6 from Stéphane Guillou (stragu) 
 ---
I was going to open a new bug report about making "all slides" the default when
exporting as SVG, as a first step, but it's not satisfactory as some users
might want a single slide, and the "selection" option is for selected objects,
not slides.

I like the idea of the "File > Export as" submenu listing the recommended
formats for an all-slides export (PDF and SVG).

I guess a first version of such a dialog can be quite simple, basing it on the
current PDF dialog:

Range:
(·) All slides
( ) Slides: [ ] (could be auto-populated by the current Slide Pane selection)
( ) Selected objects only

Alternatively:

Range:
(·) All slides
( ) Slides: [ ]
( ) Selected slides
( ) Current slide
( ) Selected objects only

Further options can be added later, but my understanding is that this issue now
has more priority given that the HTML export wizard was removed for bug 105303.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 105303] Drop html export wizard

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105303

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=66
   ||870

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157442] New: Incorrect check of a misspelled word written before an erroneous word with a number

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157442

Bug ID: 157442
   Summary: Incorrect check of a misspelled word written before an
erroneous word with a number
   Product: LibreOffice
   Version: 7.6.0.0 alpha1+
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: vladislav.taraka...@bk.ru

Description:
Words with an error are not underlined with a red line and successfully pass
the test in "tools -> spelling..." if they are followed by a digit or a word
with a digit, the part of which before the first digit is also a misspelled
word (in this case, both words are not underlined ). After saving and reopening
the file, the problem still remains.

Steps to Reproduce:
1. Open Writer
2. Write a misspelled word, press space
3. Write a number or misspelled word ending with a number

Actual Results:
Misspelled words are not recognized

Expected Results:
At least the first word is recognized as misspelled


Reproducible: Always


User Profile Reset: No

Additional Info:
Version: 7.6.0.0.alpha1 (X86_64) / LibreOffice Community
Build ID: 9366f83c88fc93d40ea0c0035508f24ad5dcb144
CPU threads: 12; OS: Linux 6.1; UI render: default; VCL: gtk3
Locale: ru-RU (ru_RU.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 96000] [META] Spelling and grammar checking bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96000
Bug 96000 depends on bug 157442, which changed state.

Bug 157442 Summary: Incorrect check of a misspelled word written before an 
erroneous word with a number
https://bugs.documentfoundation.org/show_bug.cgi?id=157442

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |NOTABUG

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157442] Incorrect check of a misspelled word written before an erroneous word with a number

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157442

raal  changed:

   What|Removed |Added

 CC||r...@post.cz
 Resolution|--- |NOTABUG
 Status|UNCONFIRMED |RESOLVED

--- Comment #3 from raal  ---
Hello,
set Tools> Spelling > Options > Check words with numbers.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157430] How can I enable search in UI to match the displayed format of formatted currencies, including trailing zeroes, instead of only matching based on the stored format?

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157430

--- Comment #2 from Lennard Lehnen  ---
Enter 123,33 in A1.
Enter 123,30 in A2.
Format all as Currency.
Search for 123,33.
Search for 123,30.
Search for 123,3.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157439] New: Properties sidebar deck Position & Size doesn't have position controls

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157439

Bug ID: 157439
   Summary: Properties sidebar deck Position & Size doesn't have
position controls
   Product: LibreOffice
   Version: 7.6.0.3 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: minor
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: eyalr...@gmx.com

If I select an object such as a textbox or an image, choose the Properties
sidebar deck and expand the Position section - I get size controls, but I
don't get position controls. So I can only control the position from the
dialog, which is a problem, since it often hides my object and certain hides
its surroundings.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 104809] [META] Position and Size content panel of the Properties deck/tab of the sidebar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104809

Eyal Rozenberg  changed:

   What|Removed |Added

 Depends on||157439


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=157439
[Bug 157439] Properties sidebar deck Position & Size doesn't have position
controls
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 157439] Properties sidebar deck Position & Size doesn't have position controls

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157439

Eyal Rozenberg  changed:

   What|Removed |Added

 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org
   Keywords||needsUXEval

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 122975] CALC: Filter should be applied to the whole column, not just to the last cell with value

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=122975

--- Comment #9 from Regis Perdreau  ---
See screenshot to see what expected : all colors should be in the background
color list

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 112064] FORMATTING Multiple footnotes per line in the footer, rather than the default one footnote per line.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112064

--- Comment #17 from j22...@gmail.com ---
Not sure if this comment belongs here or if I should create another thread, but
the title ('FORMATTING Multiple footnotes per line in the footer, rather than
the default one footnote per line.) seems reasonably close.

Sometimes we write applications or documents with limited space (eg. maximum
page number allowed) so we have to be creative so use space efficiently.
Usually, I try to avoid footnotes because they are very inefficient in this
sense. But.. I need them!

I would love to be able to format the footnotes to be consecutive. For example,
instead of: 


[Main text]
__
1. First footnote.
2. Second footnote.
3. Third footnote (and waste of space to my right)
4. More wasting of space on the right side of the page
5. So on.




I would really appreciate it if footnotes could be formatted like this:



[Main text]
__
1. First footnote. | 2. Second footnote. | 3. Third footnote (note how I use
all the available space!) | 4. No more wasting space, now we use the full width
of the available space for text. | 5. I'm using less than 5 lines now.



In this case, I used the '|' character, but ideally, the user would be able to
set an (arbitrary? or from a set of options) separator (e.g. space, semicolon,
'|', etc.)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103378] [META] PDF export bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103378

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on||156863


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=156863
[Bug 156863] Warning message reported during PDF/A-1b (ISO 19005) export
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 156863] Warning message reported during PDF/A-1b (ISO 19005) export

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=156863

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Blocks||103378
   Keywords||needsDevEval
 CC||hoss...@libreoffice.org,
   ||stephane.guillou@libreoffic
   ||e.org
 Status|UNCONFIRMED |NEW
   Priority|medium  |low
   Severity|normal  |trivial

--- Comment #7 from Stéphane Guillou (stragu) 
 ---
Ricky, no need to be quite so verbose.
I understand the issue you describe is:

The current warning says "PDF/A" when it should be more specific and say
"PDF/A-1b", given that 2b and 3b exports do support transparent objects and
don't show the warning.

Is that correct?
I can confirm that in:

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 19e9fe7c8c89399753ac1730e1c76378b18418bc
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Hossein, an easyHack?

Code pointer:

https://opengrok.libreoffice.org/xref/core/filter/inc/strings.hrc?r=53fc5fa0=5642=70#70

Other strings around that one might need updating too.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103378
[Bug 103378] [META] PDF export bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157442] Incorrect check of a misspelled word written before an erroneous word with a number

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157442

--- Comment #2 from Vladislav Tarakanov  ---
Also reproduced in windows. Libreoffice version 7.6.1

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 108392] [META] Master slide bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108392

raal  changed:

   What|Removed |Added

 Depends on||157433


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=157433
[Bug 157433] Slide design theme master slide appears blue
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157433] Slide design theme master slide appears blue

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157433

raal  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Blocks||108392
 Resolution|--- |DUPLICATE
 CC||r...@post.cz

--- Comment #2 from raal  ---
I can confirm with Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 0c4913e03e8427a576138601958f2dbf13b8c37b
CPU threads: 4; OS: Linux 6.2; UI render: default; VCL: gtk3
Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US
Calc: threaded

*** This bug has been marked as a duplicate of bug 122080 ***


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=108392
[Bug 108392] [META] Master slide bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 108392] [META] Master slide bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108392
Bug 108392 depends on bug 157433, which changed state.

Bug 157433 Summary: Slide design theme master slide appears blue
https://bugs.documentfoundation.org/show_bug.cgi?id=157433

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 122080] Changing master slide template back and forth leads to broken result (comment 5)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=122080

raal  changed:

   What|Removed |Added

 CC||mihai.vasiliu...@gmail.com

--- Comment #19 from raal  ---
*** Bug 157433 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157418] EDITING: when you copy sheets with a Pivot table to another spreadsheet, the copy is not a Pivot table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157418

m.a.riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg
 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #1 from m.a.riosv  ---
Reproducible
Version: 7.6.1.2 (X86_64) / LibreOffice Community
Build ID: f5defcebd022c5bc36bbb79be232cb6926d8f674
CPU threads: 16; OS: Windows 10.0 Build 22621; UI render: default; VCL: win
Locale: es-ES (es_ES); UI: en-US Calc: CL threaded
and
Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: b97f7b6bee733e108d8214d5387b2dc019d93d8f
CPU threads: 16; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win
Locale: es-ES (es_ES); UI: en-US Calc: CL threaded Jumbo

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 72857] EDITING: Freeform Lines don't save to PPT in Impress

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=72857

--- Comment #9 from Sophie Sipasseuth  ---
Repro

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: df3b95a39472e18ea8acdaae447b7176e37a9256
CPU threads: 8; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win
Locale: fr-FR (fr_FR); UI: fr-FR
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157427] vspace inconsistency when opening same ODP presentation on same version on different machines

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157427

--- Comment #2 from V Stuart Foote  ---
sorry fat fingers...

s/1200 x 800 (1.6 ratio)/1280 x 800 (1.6 ratio)

s/between the 1.5 (WXGA) and/between the 1.6 (WXGA) and/

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 119846] Writer jumps to the end of the file when changing paragraph attributes

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=119846

--- Comment #12 from j22...@gmail.com ---
Sill present

Version: 7.3.7.2 / LibreOffice Community
Build ID: 30(Build:2)
CPU threads: 24; OS: Linux 6.2; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Ubuntu package version: 1:7.3.7-0ubuntu0.22.04.3
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157442] Incorrect check of a misspelled word written before an erroneous word with a number

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157442

--- Comment #4 from Vladislav Tarakanov  ---
Yes, this does indeed fix the problem. But I don’t understand why, without this
setting, the word preceding the word with a number is not recognized as a
misspelled in some cases.

For example, the combination "ErrorError tree2" recognizes "ErrorError" as a
misspelled word, but the combination "ErrorError treee2" no longer recognizes.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157413] URLlink Button placed on top of a chart presents a URL tip popup when the mouse hovers anywhere over the chart

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157413

m.a.riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg
 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #4 from m.a.riosv  ---
Please attach a sample file, so someone can test.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157423] No entry possible directly after opening a CALC-file

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157423

raal  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEEDINFO
 CC||r...@post.cz

--- Comment #1 from raal  ---
No repro with Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 0c4913e03e8427a576138601958f2dbf13b8c37b
CPU threads: 4; OS: Linux 6.2; UI render: default; VCL: gtk3
Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US
Calc: threaded

Please copy and paste here the contents of your Help - About from your
LibreOffice. This allows us to know more about your system.

Set to NEEDINFO.
Change back to UNCONFIRMED after you have provided the information.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157417] A table becomes write protected without the user choosing to set write protection.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157417

m.a.riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg
 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEEDINFO

--- Comment #1 from m.a.riosv  ---
Please, could you attach a sample file with the issue, so someone can test.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157413] URLlink Button placed on top of a chart presents a URL tip popup when the mouse hovers anywhere over the chart

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157413

--- Comment #5 from Colin  ---
Created attachment 189812
  --> https://bugs.documentfoundation.org/attachment.cgi?id=189812=edit
Simple Demo File

The Web links will only take you to the public facing logon page that's freely
available to everybody on the planet - with a computer and web service that is.

Obviously, the "local" links will bomb-out because the tester's local
environment will not match mine.

All aspects of the "feature" including the inability to scroll through the
button editing pane when editing is enabled.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 71732] [META] Bugs related to text rendering, typography and font features in LO

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=71732
Bug 71732 depends on bug 152675, which changed state.

Bug 152675 Summary: font clipped at top pixel row at certain zoom-levels (kf5 
and qt5 with Cairo, gtk3)
https://bugs.documentfoundation.org/show_bug.cgi?id=152675

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 89049] Data Bar on merged cells

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=89049

--- Comment #14 from Sophie Sipasseuth  ---
The second issue seems resolved in the last version of LO, indeed, there is now
a pop-up where we can define if we want to put together the content of the
cells or choose just one content (and hide the other one or delete the other
one).

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: df3b95a39472e18ea8acdaae447b7176e37a9256
CPU threads: 8; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win
Locale: fr-FR (fr_FR); UI: fr-FR
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 156881] Background padding is green on 7.6.0.3 with Skia/Metal

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=156881

--- Comment #24 from Patrick Luby  ---
I recently fixed Skia bug
https://bugs.documentfoundation.org/show_bug.cgi?id=157312. The fix for that
bug probably unrelated to this bug, but still I am curious if the other bug fix
causes any change to this bug.

Can you install this morning's (25 September 2023) nightly master build and see
if the areas that have green background have changed when using Skia/Metal?

Also, does the window still redraw without any green background when you resize
the window?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157425] Multi-Page Text/word file to PNG Conversion using LibreOffice API's

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157425

m.a.riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg

--- Comment #1 from m.a.riosv  ---
Looks like a duplicate of tdf#137601

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157413] URLlink Button placed on top of a chart presents a URL tip popup when the mouse hovers anywhere over the chart

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157413

--- Comment #6 from Colin  ---
Correction: It produces the invalid tip syphoned from the first button wherever
the mouse is located over the chart. It doesn't just produce the tip for the
button immediately below the mouse.

Whilst this is having a limited cosmetic effect it may be symptomatic of a
bigger problem - like the "side-effect" of no longer being able to scroll
through the panes and then focus the mouse-scroll onto the input box detected
purely upon the current location of the mouse.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157443] New: Selecing another open document in Window menu does nothing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157443

Bug ID: 157443
   Summary: Selecing another open document in Window menu does
nothing
   Product: LibreOffice
   Version: 7.5.6.2 release
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: minor
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: wsand...@wsanders.net

Description:
Seleting another document in the lower part of the window menu does nothing.
Formerly, it switch the active window to the one selected in the menu.
(Incidentally it's not clear what the radio buttons are for in this menu.)

This is in a Wayland system running Fedora 38:

Operating System: Fedora Linux 38
KDE Plasma Version: 5.27.8
KDE Frameworks Version: 5.109.0
Qt Version: 5.15.10
Kernel Version: 6.4.15-200.fc38.x86_64 (64-bit)
Graphics Platform: Wayland
Processors: 12 × AMD Ryzen 5 6600H with Radeon Graphics
Memory: 14.4 GiB of RAM
Graphics Processor: AMD Radeon Graphics


Steps to Reproduce:
1. Open two or more sheets in calc, they will be name "Untitled 1", "Untitled
2", etc.
2. Try to switch the active window using the Window menu to "Untitled [N-1]".


Actual Results:
3. Nothing happens

Expected Results:
Selecting another document in the Windows menau should make it the active
window. Topmost too, in the absece of nondefault user settings that affect
window raising and lowering.


Reproducible: Always


User Profile Reset: No

Additional Info:
Easy workaround to find other docs in taskbar, or my manually shuffling
windows.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157435] Use numeric field when editing integer typed config items

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157435

m.a.riosv  changed:

   What|Removed |Added

   Keywords||needsUXEval
 CC||miguelangelrv@libreoffice.o
   ||rg

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157436] Expert config: Enumerations should be editable in a dropdown

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157436

m.a.riosv  changed:

   What|Removed |Added

   Keywords||needsUXEval
 CC||miguelangelrv@libreoffice.o
   ||rg

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157437] The bug is a fascinating creature found

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157437

Julien Nabet  changed:

   What|Removed |Added

 Resolution|--- |INVALID
 Status|UNCONFIRMED |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157437] The bug is a fascinating creature found

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157437

Julien Nabet  changed:

   What|Removed |Added

 Status|RESOLVED|CLOSED

-- 
You are receiving this mail because:
You are the assignee for the bug.