date:20231021

[Libreoffice-commits] core.git: bin/find-can-be-private-symbols.functions.results sw/inc

2023-10-21 Thread Mike Kaganski (via logerrit)

 bin/find-can-be-private-symbols.functions.results |2 --
 sw/inc/doc.hxx|2 +-
 sw/inc/editsh.hxx |2 +-
 3 files changed, 2 insertions(+), 4 deletions(-)

New commits:
commit d861fff5e3419e28edcfdf17c4863ec8c9618502
Author: Mike Kaganski 
AuthorDate: Sat Oct 21 14:28:27 2023 +0300
Commit: Mike Kaganski 
CommitDate: Sat Oct 21 14:53:53 2023 +0200

Make ConvertFieldsToText private

Change-Id: Ie3d22b63260d2b2b05a46c5b2a6ca915cf9d4bcd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158304
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/bin/find-can-be-private-symbols.functions.results 
b/bin/find-can-be-private-symbols.functions.results
index bce1550fd63c..02cd245cbb54 100644
--- a/bin/find-can-be-private-symbols.functions.results
+++ b/bin/find-can-be-private-symbols.functions.results
@@ -11939,7 +11939,6 @@ SwDoc::CloneSdrObj(SdrObject const&, bool, bool)
 SwDoc::CompareDoc(SwDoc const&)
 SwDoc::ContainsHiddenChars() const
 SwDoc::ContainsPageDesc(SwPageDesc const*, unsigned long*) const
-SwDoc::ConvertFieldsToText(SwRootFrame const&)
 SwDoc::CopyCharFormat(SwCharFormat const&)
 SwDoc::CopyFormat(SwFormat const&, SwFormatsBase const&, SwFormat* 
(SwDoc::*)(rtl::OUString const&, SwFormat*, bool, bool), SwFormat const&)
 SwDoc::CopyFormatArr(SwFormatsBase const&, SwFormatsBase const&, SwFormat* 
(SwDoc::*)(rtl::OUString const&, SwFormat*, bool, bool), SwFormat&)
@@ -12354,7 +12353,6 @@ SwEditShell::ClearAutomaticContour()
 SwEditShell::CollectAdvancedClassification()
 SwEditShell::CollectParagraphClassification()
 SwEditShell::CompareDoc(SwDoc const&)
-SwEditShell::ConvertFieldsToText()
 SwEditShell::Copy(SwEditShell&)
 SwEditShell::CopySelToDoc(SwDoc&)
 SwEditShell::CreateExtTextInput(o3tl::strong_int)
diff --git a/sw/inc/doc.hxx b/sw/inc/doc.hxx
index 5fd6b58064c3..c40abf7a1581 100644
--- a/sw/inc/doc.hxx
+++ b/sw/inc/doc.hxx
@@ -1445,7 +1445,7 @@ public:
 // restore the invisible content if it's available on the undo stack
 bool RestoreInvisibleContent();
 
-bool ConvertFieldsToText(SwRootFrame const& rLayout);
+SAL_DLLPRIVATE bool ConvertFieldsToText(SwRootFrame const& rLayout);
 
 // Create sub-documents according to given collection.
 // If no collection is given, use chapter styles for 1st level.
diff --git a/sw/inc/editsh.hxx b/sw/inc/editsh.hxx
index a3b181440237..1fb9ff3a5bae 100644
--- a/sw/inc/editsh.hxx
+++ b/sw/inc/editsh.hxx
@@ -190,7 +190,7 @@ public:
 void CountWords( SwDocStat& rStat ) const;
 
 /// Replace fields by text - mailmerge support.
-bool ConvertFieldsToText();
+SAL_DLLPRIVATE bool ConvertFieldsToText();
 
 /// Set all numbering start points to a fixed value - mailmerge support.
 void SetNumberingRestart();

[Libreoffice-commits] core.git: download.lst external/mariadb-connector-c RepositoryExternal.mk

2023-10-21 Thread Mike Kaganski (via logerrit)

 RepositoryExternal.mk |1 +
 download.lst  |4 ++--
 external/mariadb-connector-c/StaticLibrary_mariadb-connector-c.mk |8 
+++-
 external/mariadb-connector-c/configs/wnt_ma_config.h  |4 
 4 files changed, 6 insertions(+), 11 deletions(-)

New commits:
commit 5a0498ded11d514c21e3124333a3560da1373202
Author: Mike Kaganski 
AuthorDate: Fri Oct 20 08:52:46 2023 +0300
Commit: Mike Kaganski 
CommitDate: Sat Oct 21 08:43:44 2023 +0200

mariadb connector: upgrade to release 3.3.7 (fixes tdf#157826)

Change-Id: I053b827b7bc14535760236fcb057c154c359f4dd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158252
Tested-by: Mike Kaganski 
Reviewed-by: Mike Kaganski 

diff --git a/RepositoryExternal.mk b/RepositoryExternal.mk
index 82a3478a1ac4..744353b58fe3 100644
--- a/RepositoryExternal.mk
+++ b/RepositoryExternal.mk
@@ -312,6 +312,7 @@ $(call gb_LinkTarget_use_system_win32_libs,$(1),\
kernel32 \
shlwapi \
crypt32 \
+   bcrypt \
 )
 
 endef
diff --git a/download.lst b/download.lst
index ad03e50a6ad4..07b4934cf760 100644
--- a/download.lst
+++ b/download.lst
@@ -436,8 +436,8 @@ LXML_TARBALL := lxml-4.9.2.tgz
 # three static lines
 # so that git cherry-pick
 # will not run into conflicts
-MARIADB_CONNECTOR_C_SHA256SUM := 
431434d3926f4bcce2e5c97240609983f60d7ff50df5a72083934759bb863f7b
-MARIADB_CONNECTOR_C_TARBALL := mariadb-connector-c-3.1.8-src.tar.gz
+MARIADB_CONNECTOR_C_SHA256SUM := 
975a9a862fed80f84e0206373f7ef05537aada5b65d99b71b36ab892b44240bf
+MARIADB_CONNECTOR_C_TARBALL := mariadb-connector-c-3.3.7-src.tar.gz
 # three static lines
 # so that git cherry-pick
 # will not run into conflicts
diff --git a/external/mariadb-connector-c/StaticLibrary_mariadb-connector-c.mk 
b/external/mariadb-connector-c/StaticLibrary_mariadb-connector-c.mk
index 3458089ce99e..b8802e16695e 100644
--- a/external/mariadb-connector-c/StaticLibrary_mariadb-connector-c.mk
+++ b/external/mariadb-connector-c/StaticLibrary_mariadb-connector-c.mk
@@ -21,12 +21,10 @@ $(eval $(call 
gb_StaticLibrary_set_include,mariadb-connector-c,\
 # This is needed for MSVC 2008: it somehow finds a dlopen somewhere
 # but the static library then contains unreferenced symbols.
 # This macro enables a re-definition to native Win32 APIs in my_global.h.
-## TODO missing enable: -D HAVE_COMPRESS
-## (but then need to add "-lz" to mysqlcppconn linking)
-$(eval $(call gb_StaticLibrary_add_cflags,mariadb-connector-c,-DHAVE_DLOPEN -D 
ENABLED_LOCAL_INFILE -D LIBMARIADB -D THREAD -DSQLITE_ENABLE_COLUMN_METADATA=1))
+$(eval $(call gb_StaticLibrary_add_cflags,mariadb-connector-c,-DHAVE_DLOPEN 
-DHAVE_COMPRESS -D ENABLED_LOCAL_INFILE -D LIBMARIADB -D THREAD 
-DSQLITE_ENABLE_COLUMN_METADATA=1))
 
 ifeq ($(OS),WNT)
-$(eval $(call 
gb_StaticLibrary_add_cflags,mariadb-connector-c,-D_TIMESPEC_DEFINED 
-DHAVE_STRTOULL))
+$(eval $(call 
gb_StaticLibrary_add_cflags,mariadb-connector-c,-D_TIMESPEC_DEFINED 
-DHAVE_STRTOULL -DHAVE_WINCRYPT))
 $(eval $(call gb_StaticLibrary_set_include,mariadb-connector-c,\
$$(INCLUDE) \
-I$(call gb_UnpackedTarball_get_dir,mariadb-connector-c)/win-iconv \
@@ -46,7 +44,7 @@ $(eval $(call 
gb_StaticLibrary_add_generated_cobjects,mariadb-connector-c,\
UnpackedTarball/mariadb-connector-c/libmariadb/ma_default \
UnpackedTarball/mariadb-connector-c/libmariadb/ma_dtoa \
UnpackedTarball/mariadb-connector-c/libmariadb/ma_errmsg \
-   UnpackedTarball/mariadb-connector-c/libmariadb/ma_hash \
+   UnpackedTarball/mariadb-connector-c/libmariadb/ma_hashtbl \
UnpackedTarball/mariadb-connector-c/libmariadb/ma_init \
UnpackedTarball/mariadb-connector-c/libmariadb/ma_io \
UnpackedTarball/mariadb-connector-c/libmariadb/ma_list \
diff --git a/external/mariadb-connector-c/configs/wnt_ma_config.h 
b/external/mariadb-connector-c/configs/wnt_ma_config.h
index d06393509881..acd08c125a95 100644
--- a/external/mariadb-connector-c/configs/wnt_ma_config.h
+++ b/external/mariadb-connector-c/configs/wnt_ma_config.h
@@ -72,11 +72,7 @@
 # define HAVE_LONG 1
 #endif
 
-#ifdef _M_X64
 #define SIZEOF_LONG_LONG 8
-#else
-#define SIZEOF_LONG_LONG 4
-#endif
 #if defined(SIZEOF_LONG_LONG)
 # define HAVE_LONG_LONG 1
 #endif

[Libreoffice-commits] core.git: compilerplugins/clang

2023-10-21 Thread Stephan Bergmann (via logerrit)

 compilerplugins/clang/ostr.cxx  |  237 +++-
 compilerplugins/clang/test/ostr.cxx |   17 ++
 2 files changed, 248 insertions(+), 6 deletions(-)

New commits:
commit 769899853557831ae53d020497e81c8fe572874b
Author: Stephan Bergmann 
AuthorDate: Thu Oct 19 10:33:19 2023 +0200
Commit: Stephan Bergmann 
CommitDate: Sat Oct 21 08:54:33 2023 +0200

Extended loplugin:ostr: Automatic rewrite some O[U]StringLiteral -> 
O[U]String

Change-Id: I8c08bf41b96d4a6085e7d72cb39e629efa556d09
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158300
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/compilerplugins/clang/ostr.cxx b/compilerplugins/clang/ostr.cxx
index 462916641421..9675913c8576 100644
--- a/compilerplugins/clang/ostr.cxx
+++ b/compilerplugins/clang/ostr.cxx
@@ -37,9 +37,125 @@ public:
 
 void run() override
 {
-if (compiler.getLangOpts().CPlusPlus)
+if (compiler.getLangOpts().CPlusPlus
+&& TraverseDecl(compiler.getASTContext().getTranslationUnitDecl()))
 {
-TraverseDecl(compiler.getASTContext().getTranslationUnitDecl());
+for (auto const& i : vars_)
+{
+auto const utf16
+= 
bool(loplugin::TypeCheck(i.first->getType()).Class("OUStringLiteral"));
+if (i.second.singleUse == nullptr)
+{
+if (!(i.first->getDeclContext()->isFunctionOrMethod()
+  || 
compiler.getSourceManager().isInMainFile(i.first->getLocation())
+  || compiler.getDiagnosticOpts().VerifyDiagnostics))
+{
+//TODO, rewriting these in include files could trigger
+// loplugin:redundantfcast in other translation units:
+continue;
+}
+if (rewriter != nullptr)
+{
+auto e = i.first->getInit()->IgnoreParenImpCasts();
+if (auto const e2 = dyn_cast(e))
+{
+e = e2->getSubExpr()->IgnoreParenImpCasts();
+}
+if (auto const e2 = dyn_cast(e))
+{
+assert(e2->getNumArgs() == 1);
+e = e2->getArg(0)->IgnoreParenImpCasts();
+}
+e = dyn_cast(e);
+// e is null when this OUStringLiteral is initialized 
with another
+// OUStringLiteral:
+if (e == nullptr
+|| insertTextAfterToken(e->getEndLoc(), utf16 ? 
"_ustr" : "_ostr"))
+{
+auto ok = true;
+for (auto d = i.first->getMostRecentDecl(); d != 
nullptr;
+ d = d->getPreviousDecl())
+{
+auto const l1 = d->getTypeSpecStartLoc();
+auto l2 = d->getTypeSpecEndLoc();
+l2 = 
l2.getLocWithOffset(Lexer::MeasureTokenLength(
+l2, compiler.getSourceManager(), 
compiler.getLangOpts()));
+if (!replaceText(l1, delta(l1, l2), utf16 ? 
"OUString" : "OString"))
+{
+ok = false;
+}
+}
+for (auto const i : i.second.explicitConversions)
+{
+auto const e2 = i->getArg(0);
+auto l1 = i->getBeginLoc();
+auto l2 = e2->getBeginLoc();
+auto l3 = e2->getEndLoc();
+auto l4 = i->getEndLoc();
+while 
(compiler.getSourceManager().isMacroArgExpansion(l1)
+   && 
compiler.getSourceManager().isMacroArgExpansion(l2)
+   && 
compiler.getSourceManager().isMacroArgExpansion(l3)
+   && 
compiler.getSourceManager().isMacroArgExpansion(l4))
+//TODO: check all four locations are part of 
the same macro argument
+// expansion
+{
+l1 = 
compiler.getSourceManager().getImmediateMacroCallerLoc(l1);
+l2 = 
compiler.getSourceManager().getImmediateMacroCallerLoc(l2);
+l3 = 
compiler.getSourceManager().getImmediateMacroCallerLoc(l3);
+l4 =

[Libreoffice-commits] core.git: sw/qa

2023-10-21 Thread Stephan Bergmann (via logerrit)

 sw/qa/uitest/navigator/tdf137274.py |9 +
 1 file changed, 9 insertions(+)

New commits:
commit 00286e56d17090ffdf0abd76ba3c236126f8c116
Author: Stephan Bergmann 
AuthorDate: Sat Oct 21 08:05:46 2023 +0200
Commit: Stephan Bergmann 
CommitDate: Sat Oct 21 08:54:59 2023 +0200

tdf#153519 Another TreeListEntryUIObject heap-use-after-free

...similar to the one addressed with the commits leading up to
9a23ded27470a4c57015e9e5d686259a60d464f2 "Fix thinko when to sleep"

Change-Id: Iecf0146c4c079ae95f980128531ac8f51b4b8535
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158302
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/sw/qa/uitest/navigator/tdf137274.py 
b/sw/qa/uitest/navigator/tdf137274.py
index 5273ddcb2f91..9bd780a7e5c2 100644
--- a/sw/qa/uitest/navigator/tdf137274.py
+++ b/sw/qa/uitest/navigator/tdf137274.py
@@ -42,6 +42,15 @@ class tdf137274(UITestCase):
 # wait until the navigator panel is available
 xNavigatorPanel = 
self.ui_test.wait_until_child_is_available('NavigatorPanel')
 
+# HACK, see the `m_aUpdTimer.SetTimeout(1000)` in the 
SwContentTree ctor in
+# sw/source/uibase/utlui/content.cxx, where that m_aUpdTimer is 
started by
+# SwContentTree::ShowTree triggered from the SIDEBAR action above, 
and which can
+# invalidate the TreeListEntryUIObjects used by the below code (see
+# 2798430c8a711861fdcdfbf9ac00a0527abd3bfc "Mark the uses of 
TreeListEntryUIObject as
+# dubious"); lets double that 1000 ms timeout value here to 
hopefully be on the safe
+# side:
+time.sleep(2)
+
 xContentTree = xNavigatorPanel.getChild("contenttree")
 xComments = self.get_item(xContentTree, 'Comments')
 self.assertEqual('Comments', get_state_as_dict(xComments)['Text'])

[Libreoffice-commits] core.git: 2 commits - include/vcl vcl/qt5 vcl/source winaccessibility/source

2023-10-21 Thread Michael Weghorn (via logerrit)

 include/vcl/accessibility/AccessibleTextAttributeHelper.hxx |   32 ++
 vcl/qt5/QtAccessibleWidget.cxx  |6 
 vcl/source/accessibility/AccessibleTextAttributeHelper.cxx  |  158 +++-
 winaccessibility/source/UAccCOM/AccTextBase.cxx |4 
 4 files changed, 135 insertions(+), 65 deletions(-)

New commits:
commit b0bf4043d320f69d1cf9dfcbcd6a8eac4df94015
Author: Michael Weghorn 
AuthorDate: Fri Oct 20 13:09:39 2023 +0200
Commit: Michael Weghorn 
CommitDate: Sat Oct 21 13:48:31 2023 +0200

tdf#135922 a11y: Report IA2 "text-align" attr

Map the "ParaAlign" UNO text attribute to the
IAccessibl2 *object* attribute "text-align",
as specified in the IAccessible2 object
attributes specification. [1]

This causes the corresponding "justification" AT-SPI text
attribute to be reported when using the qt6 VCL
plugin on Linux.

For Windows, bridging this to the platform a11y
will be implemented in an upcoming change.

See the commmit message of the previous change

Change-Id Ief7c840d3c5274714a914ca0e56df0c5eaffb06d
tdf#135922 a11y: Prepare reporting text attrs as IA2 obj attrs

for more details.

[1] 
https://wiki.linuxfoundation.org/accessibility/iaccessible2/objectattributes

Change-Id: I6a0478a4ac37f69393e995602ed698b5a78488e5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158256
Tested-by: Jenkins
Reviewed-by: Michael Weghorn 

diff --git a/vcl/source/accessibility/AccessibleTextAttributeHelper.cxx 
b/vcl/source/accessibility/AccessibleTextAttributeHelper.cxx
index ebce733fa491..5647dc972ba5 100644
--- a/vcl/source/accessibility/AccessibleTextAttributeHelper.cxx
+++ b/vcl/source/accessibility/AccessibleTextAttributeHelper.cxx
@@ -25,6 +25,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -219,6 +220,25 @@ OUString lcl_ConvertColor(Color aColor)
+ OUString::number(aColor.GetGreen()) + u"\\," + 
OUString::number(aColor.GetBlue())
+ u")";
 }
+
+OUString lcl_ConvertParagraphAdjust(css::style::ParagraphAdjust eParaAdjust)
+{
+switch (eParaAdjust)
+{
+case css::style::ParagraphAdjust_LEFT:
+return u"left"_ustr;
+case css::style::ParagraphAdjust_RIGHT:
+return u"right"_ustr;
+case css::style::ParagraphAdjust_BLOCK:
+case css::style::ParagraphAdjust_STRETCH:
+return u"justify"_ustr;
+case css::style::ParagraphAdjust_CENTER:
+return u"center"_ustr;
+default:
+assert(false && "Unhandled ParagraphAdjust value");
+return u""_ustr;
+}
+}
 }
 
 OUString AccessibleTextAttributeHelper::ConvertUnoToIAccessible2TextAttributes(
@@ -297,6 +317,17 @@ OUString 
AccessibleTextAttributeHelper::ConvertUnoToIAccessible2TextAttributes(
 }
 }
 
+// so far, "ParaAdjust" is the only UNO text attribute that
+// maps to an object attribute for IAccessible2 ("text-align")
+if (sAttribute.isEmpty() && (eAttributeType & 
IA2AttributeType::ObjectAttributes)
+&& prop.Name == "ParaAdjust")
+{
+sAttribute = "text-align";
+const css::style::ParagraphAdjust eParaAdjust
+= 
static_cast(*o3tl::doAccess(prop.Value));
+sValue = lcl_ConvertParagraphAdjust(eParaAdjust);
+}
+
 if (!sAttribute.isEmpty() && !sValue.isEmpty())
 aRet += sAttribute + ":" + sValue + ";";
 }
commit 9362766b94a4627db0d8adfac4285388970d1fba
Author: Michael Weghorn 
AuthorDate: Fri Oct 20 12:41:15 2023 +0200
Commit: Michael Weghorn 
CommitDate: Sat Oct 21 13:48:22 2023 +0200

tdf#135922 a11y: Prepare reporting text attrs as IA2 obj attrs

According to the IAccessible2 specification, some
of the attributes that LibreOffice handles as text
attributes are mapped to IAccessible2 text attributes
as well [1], but others should be reported as object
attributes [2], e.g. text alignment
is reported via the "text-align" object attribute on
the paragraph object.

So far, `AccessibleTextAttributeHelper` was only handling
attributes that are mapped to IAccessible2 text attributes.

Prepare for reporting object attributes as well, which
will be required to report text alignment on Windows
in a compliant way (s. tdf#135922).

On the other hand, Qt also expects
`QAccessibleTextInterface::attributes` to return
text formatting using the attributes specified in the
IAccessible2 attribute specifications and maps that to the
platform-specific attributes (AT-SPI text attributes
on Linux), but currently does not provide any way
to report object attributes in addition to text
attributes. It however supports e.g. the
"text-align" attribute mentioned in the
IAccessible2 object attribute

[Libreoffice-commits] core.git: winaccessibility/source

2023-10-21 Thread Michael Weghorn (via logerrit)

 winaccessibility/source/UAccCOM/MAccessible.cxx |   12 
 1 file changed, 12 insertions(+)

New commits:
commit 701563366c717c21ffa0588de6be1005df92a779
Author: Michael Weghorn 
AuthorDate: Fri Oct 20 13:43:56 2023 +0100
Commit: Michael Weghorn 
CommitDate: Sat Oct 21 13:49:32 2023 +0200

tdf#135922 wina11y: Report text-related IA2 obj attrs

Extend `CMAccessible::get_attributes` so that
it also reports the text-related IAccessible2
object attributes, since what is meant to be
reported as a text attribute and what is meant
to be reported as an object attribute differs
between the IAccessible2 specificiation and what
LibreOffice does on the UNO level, s. the commit message
in this previous change for more details:

Change-Id Ief7c840d3c5274714a914ca0e56df0c5eaffb06d
tdf#135922 a11y: Prepare reporting text attrs as IA2 obj attrs

Just use a character offset of 0 when querying via the
`XAccessibleText` interface here. The exct offset used
used shouldn't make any difference for paragraph-specific
attributes.

With this and the NVDA pull request [1] to evaluate attributes
according to the IAccessible2 text attributes and
IAccessible2 object attributes specifications, NVDA
now reports the alignment of paragraphs in Writer, e.g.
says "align center" since the corresponding attribute is
now reported for the paragraph object, as can also
be seen by querying the IAccessible2 interface manually
in NVDA's Python console:

>>> focus.IAccessibleObject.attributes
'heading-level:;level:;text-align:center;'

("text-align:center;" was not yet reported without
this change in place.)

[1] https://github.com/nvaccess/nvda/pull/15649

Change-Id: I5723797232f89db6a2b74d4a601344f2078ee630
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158260
Tested-by: Jenkins
Reviewed-by: Michael Weghorn 

diff --git a/winaccessibility/source/UAccCOM/MAccessible.cxx 
b/winaccessibility/source/UAccCOM/MAccessible.cxx
index 30e9b043b0fb..e4b17fa43826 100644
--- a/winaccessibility/source/UAccCOM/MAccessible.cxx
+++ b/winaccessibility/source/UAccCOM/MAccessible.cxx
@@ -38,6 +38,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -2735,6 +2736,17 @@ COM_DECLSPEC_NOTHROW STDMETHODIMP 
CMAccessible::get_attributes(/*[out]*/ BSTR *p
 sAttributes += val;
 }
 
+// some text-specific IAccessible2 object attributes (like text 
alignment
+// of a paragraph) are handled as text attributes in LibreOffice
+Reference xText(pRContext, UNO_QUERY);
+if (xText.is())
+{
+sal_Int32 nStartOffset = 0;
+sal_Int32 nEndOffset = 0;
+sAttributes += 
AccessibleTextAttributeHelper::GetIAccessible2TextAttributes(
+xText, IA2AttributeType::ObjectAttributes, 0, nStartOffset, 
nEndOffset);
+}
+
 if (*pAttr)
 SysFreeString(*pAttr);
 *pAttr = SysAllocString(o3tl::toW(sAttributes.getStr()));

[Libreoffice-commits] core.git: 2 commits - winaccessibility/source

2023-10-21 Thread Michael Weghorn (via logerrit)

 winaccessibility/source/UAccCOM/MAccessible.cxx |   43 
 1 file changed, 22 insertions(+), 21 deletions(-)

New commits:
commit a8e75a8ac93c18a7e955e448bfd120d0ed9ef0b0
Author: Michael Weghorn 
AuthorDate: Fri Oct 20 12:56:39 2023 +0100
Commit: Michael Weghorn 
CommitDate: Sat Oct 21 13:48:50 2023 +0200

wina11y: Just return empty attr string when none present

If the `XAccessibleExtendedAttributes` interface
isn't implemented, just return an empty string
for the attributes instead of an error code.

(This seems like a totally valid case to me,
no need to report an error.)

Change-Id: I986f030bc7a01da0fdd92a5aa2b4cf3c0d6a9200
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158258
Tested-by: Jenkins
Reviewed-by: Michael Weghorn 

diff --git a/winaccessibility/source/UAccCOM/MAccessible.cxx 
b/winaccessibility/source/UAccCOM/MAccessible.cxx
index 98f15fdf230b..30e9b043b0fb 100644
--- a/winaccessibility/source/UAccCOM/MAccessible.cxx
+++ b/winaccessibility/source/UAccCOM/MAccessible.cxx
@@ -2721,10 +2721,10 @@ COM_DECLSPEC_NOTHROW STDMETHODIMP 
CMAccessible::get_attributes(/*[out]*/ BSTR *p
 {
 return E_FAIL;
 }
+
+OUString sAttributes;
 Reference pRXI(pRContext,UNO_QUERY);
-if( !pRXI.is() )
-return E_FAIL;
-else
+if (pRXI.is())
 {
 
css::uno::Reference pRXAttr;
 pRXAttr = pRXI.get();
@@ -2732,13 +2732,14 @@ COM_DECLSPEC_NOTHROW STDMETHODIMP 
CMAccessible::get_attributes(/*[out]*/ BSTR *p
 
 OUString val;
 anyVal >>= val;
+sAttributes += val;
+}
 
-if(*pAttr)
-SysFreeString(*pAttr);
-*pAttr = SysAllocString(o3tl::toW(val.getStr()));
+if (*pAttr)
+SysFreeString(*pAttr);
+*pAttr = SysAllocString(o3tl::toW(sAttributes.getStr()));
 
-return S_OK;
-}
+return S_OK;
 } catch(...) { return E_FAIL; }
 }
 
commit eff3e9b8a576863c01f4244a5628cda64f48a363
Author: Michael Weghorn 
AuthorDate: Fri Oct 20 12:52:03 2023 +0100
Commit: Michael Weghorn 
CommitDate: Sat Oct 21 13:48:42 2023 +0200

wina11y: Indent try block

Change-Id: I89a4ed514e1c24e683b081d04f72cd62ede80065
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158257
Tested-by: Jenkins
Reviewed-by: Michael Weghorn 

diff --git a/winaccessibility/source/UAccCOM/MAccessible.cxx 
b/winaccessibility/source/UAccCOM/MAccessible.cxx
index e8f29c8192d2..98f15fdf230b 100644
--- a/winaccessibility/source/UAccCOM/MAccessible.cxx
+++ b/winaccessibility/source/UAccCOM/MAccessible.cxx
@@ -2711,34 +2711,34 @@ COM_DECLSPEC_NOTHROW STDMETHODIMP 
CMAccessible::get_attributes(/*[out]*/ BSTR *p
 SolarMutexGuard g;
 
 try {
-if (m_isDestroy) return S_FALSE;
+if (m_isDestroy) return S_FALSE;
 
-if (!m_xAccessible.is())
-return E_FAIL;
+if (!m_xAccessible.is())
+return E_FAIL;
 
-Reference pRContext = 
m_xAccessible->getAccessibleContext();
-if( !pRContext.is() )
-{
-return E_FAIL;
-}
-Reference pRXI(pRContext,UNO_QUERY);
-if( !pRXI.is() )
-return E_FAIL;
-else
-{
-css::uno::Reference 
pRXAttr;
-pRXAttr = pRXI.get();
-css::uno::Any  anyVal = pRXAttr->getExtendedAttributes();
+Reference pRContext = 
m_xAccessible->getAccessibleContext();
+if( !pRContext.is() )
+{
+return E_FAIL;
+}
+Reference pRXI(pRContext,UNO_QUERY);
+if( !pRXI.is() )
+return E_FAIL;
+else
+{
+
css::uno::Reference pRXAttr;
+pRXAttr = pRXI.get();
+css::uno::Any  anyVal = pRXAttr->getExtendedAttributes();
 
-OUString val;
-anyVal >>= val;
+OUString val;
+anyVal >>= val;
 
-if(*pAttr)
-SysFreeString(*pAttr);
-*pAttr = SysAllocString(o3tl::toW(val.getStr()));
+if(*pAttr)
+SysFreeString(*pAttr);
+*pAttr = SysAllocString(o3tl::toW(val.getStr()));
 
-return S_OK;
-}
+return S_OK;
+}
 } catch(...) { return E_FAIL; }
 }

[Libreoffice-commits] core.git: offapi/com

2023-10-21 Thread Michael Weghorn (via logerrit)

 offapi/com/sun/star/accessibility/XAccessibleExtendedAttributes.idl |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit cfaa52ed74278aab0e44f7cc9a66afe1c4166715
Author: Michael Weghorn 
AuthorDate: Fri Oct 20 13:22:16 2023 +0100
Commit: Michael Weghorn 
CommitDate: Sat Oct 21 13:48:59 2023 +0200

a11y: Improve XAccessibleExtendedAttributes doc

The existing

// MT: I guess it's not formula only?

comment was justified.

`XAccessibleExtendedAttributes::getExtendedAttributes`,
is not only used to report formulae, but e.g. used to
report a heading level by Writer paragraphs
(s. `SwAccessibleParagraph::getExtendedAttributes`),
so adjust the documentation and align it with
the `IAcccessible2::attributes` one [1] that also
uses the cell formula as an example.

[1] 
https://accessibility.linuxfoundation.org/a11yspecs/ia2/docs/html/interface_i_accessible2.html#a0d51b0c189a000ee3b6ddf7f68da2009

Change-Id: I2d6f38911c3802edb55f9426a35b8986dd6e399a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158259
Tested-by: Jenkins
Reviewed-by: Michael Weghorn 

diff --git 
a/offapi/com/sun/star/accessibility/XAccessibleExtendedAttributes.idl 
b/offapi/com/sun/star/accessibility/XAccessibleExtendedAttributes.idl
index ec5f2f7176a9..3ba748f9f574 100644
--- a/offapi/com/sun/star/accessibility/XAccessibleExtendedAttributes.idl
+++ b/offapi/com/sun/star/accessibility/XAccessibleExtendedAttributes.idl
@@ -21,7 +21,7 @@ module com { module sun { module star { module accessibility {
 
 interface XAccessibleExtendedAttributes : ::com::sun::star::uno::XInterface
 {
-/* Returns the attribute of this object' formula */ // MT: I guess it's 
not formula only?
+/** Returns the attributes specific to this object, like a cell's formula. 
*/
 any getExtendedAttributes() raises 
(::com::sun::star::lang::IndexOutOfBoundsException);
 };

[Libreoffice-commits] core.git: sal/rtl solenv/clang-format

2023-10-21 Thread Mike Kaganski (via logerrit)

 sal/rtl/math.cxx|  259 
 solenv/clang-format/excludelist |1 
 2 files changed, 108 insertions(+), 152 deletions(-)

New commits:
commit 8b327dd75caf3fd3374ad92f84a70c276678a046
Author: Mike Kaganski 
AuthorDate: Sat Oct 21 11:44:17 2023 +0300
Commit: Mike Kaganski 
CommitDate: Sat Oct 21 12:46:44 2023 +0200

clang-format sal/rtl/math.cxx

Change-Id: I0e807118e6a2196d2f2858ed195782a90572a2e9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158303
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/sal/rtl/math.cxx b/sal/rtl/math.cxx
index 32507b619ff7..68068eaf979f 100644
--- a/sal/rtl/math.cxx
+++ b/sal/rtl/math.cxx
@@ -102,8 +102,8 @@ static double getN10Exp(int nExp)
 return n10s[nExp - minExp];
 }
 
-namespace {
-
+namespace
+{
 /** If value (passed as absolute value) is an integer representable as double,
 which we handle explicitly at some places.
  */
@@ -113,8 +113,8 @@ bool isRepresentableInteger(double fAbsValue)
   && std::numeric_limits::digits == 53);
 assert(fAbsValue >= 0.0);
 if (fAbsValue >= 0x1p53)
-  return false;
-sal_Int64 nInt = static_cast< sal_Int64 >(fAbsValue);
+return false;
+sal_Int64 nInt = static_cast(fAbsValue);
 return nInt == fAbsValue;
 }
 
@@ -138,7 +138,7 @@ int getBitsInFracPart(double fAbsValue)
 assert(std::isfinite(fAbsValue) && fAbsValue >= 0.0);
 if (fAbsValue == 0.0)
 return 0;
-auto pValParts = reinterpret_cast< const sal_math_Double * >();
+auto pValParts = reinterpret_cast();
 int nExponent = pValParts->inf_parts.exponent - 1023;
 if (nExponent >= 52)
 return 0; // All bits in fraction are in integer part of the number
@@ -156,61 +156,49 @@ int getBitsInFracPart(double fAbsValue)
 
 return std::max(nBitsInFracPart, 0);
 }
-
 }
 
-void SAL_CALL rtl_math_doubleToString(rtl_String ** pResult,
-  sal_Int32 * pResultCapacity,
+void SAL_CALL rtl_math_doubleToString(rtl_String** pResult, sal_Int32* 
pResultCapacity,
   sal_Int32 nResultOffset, double fValue,
-  rtl_math_StringFormat eFormat,
-  sal_Int32 nDecPlaces,
-  char cDecSeparator,
-  sal_Int32 const * pGroups,
-  char cGroupSeparator,
-  sal_Bool bEraseTrailingDecZeros)
+  rtl_math_StringFormat eFormat, sal_Int32 
nDecPlaces,
+  char cDecSeparator, sal_Int32 const* 
pGroups,
+  char cGroupSeparator, sal_Bool 
bEraseTrailingDecZeros)
 SAL_THROW_EXTERN_C()
 {
-rtl::str::doubleToString(
-pResult, pResultCapacity, nResultOffset, fValue, eFormat, nDecPlaces,
-cDecSeparator, pGroups, cGroupSeparator, bEraseTrailingDecZeros);
+rtl::str::doubleToString(pResult, pResultCapacity, nResultOffset, fValue, 
eFormat, nDecPlaces,
+ cDecSeparator, pGroups, cGroupSeparator, 
bEraseTrailingDecZeros);
 }
 
-void SAL_CALL rtl_math_doubleToUString(rtl_uString ** pResult,
-   sal_Int32 * pResultCapacity,
+void SAL_CALL rtl_math_doubleToUString(rtl_uString** pResult, sal_Int32* 
pResultCapacity,
sal_Int32 nResultOffset, double fValue,
-   rtl_math_StringFormat eFormat,
-   sal_Int32 nDecPlaces,
-   sal_Unicode cDecSeparator,
-   sal_Int32 const * pGroups,
-   sal_Unicode cGroupSeparator,
-   sal_Bool bEraseTrailingDecZeros)
+   rtl_math_StringFormat eFormat, 
sal_Int32 nDecPlaces,
+   sal_Unicode cDecSeparator, sal_Int32 
const* pGroups,
+   sal_Unicode cGroupSeparator, sal_Bool 
bEraseTrailingDecZeros)
 SAL_THROW_EXTERN_C()
 {
-rtl::str::doubleToString(
-pResult, pResultCapacity, nResultOffset, fValue, eFormat, nDecPlaces,
-cDecSeparator, pGroups, cGroupSeparator, bEraseTrailingDecZeros);
+rtl::str::doubleToString(pResult, pResultCapacity, nResultOffset, fValue, 
eFormat, nDecPlaces,
+ cDecSeparator, pGroups, cGroupSeparator, 
bEraseTrailingDecZeros);
 }
 
-namespace {
-
-template< typename CharT >
-double stringToDouble(CharT const * pBegin, CharT const * pEnd,
- CharT cDecSeparator, CharT cGroupSeparator,
- rtl_math_ConversionStatus * pStatus,
- CharT

[Libreoffice-commits] core.git: Branch 'libreoffice-7-6' - sc/source

2023-10-21 Thread Xisco Fauli (via logerrit)

 sc/source/ui/app/inputhdl.cxx |   34 +-
 1 file changed, 17 insertions(+), 17 deletions(-)

New commits:
commit f7d71fe0641995344eac290effa3c1552454fb36
Author: Xisco Fauli 
AuthorDate: Wed Oct 18 17:28:37 2023 +0200
Commit: Noel Grandin 
CommitDate: Sat Oct 21 12:51:22 2023 +0200

fix crash in ScInputHandler::ImplCreateEditEngine()

See 
https://crashreport.libreoffice.org/stats/crash_details/1b2c45b0-6053-4628-94cc-f639899ceb39

Regression from 5484657d2b1677b7e385ab6ef87ad64dcb9934e4
"tdf#156209 Font size increases when copying from cell in edit mode"

Change-Id: I84cac26087b0c8908c22bbb45056e309cd66a016
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158123
Tested-by: Jenkins
Reviewed-by: Noel Grandin 
(cherry picked from commit 51678d9cf57085bac3c7eba998e0a6d364d36cb2)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158049

diff --git a/sc/source/ui/app/inputhdl.cxx b/sc/source/ui/app/inputhdl.cxx
index 1267509d4e5f..0735feb01a9b 100644
--- a/sc/source/ui/app/inputhdl.cxx
+++ b/sc/source/ui/app/inputhdl.cxx
@@ -3068,6 +3068,9 @@ void ScInputHandler::EnterHandler( ScEnterMode 
nBlockMode, bool bBeforeSavingInL
 && pActiveViewSh != SfxViewShell::Current())
 return;
 
+if (!pActiveViewSh)
+return;
+
 // Macro calls for validity can cause a lot of problems, so inhibit
 // nested calls of EnterHandler().
 if (bInEnterHandler) return;
@@ -3097,7 +3100,7 @@ void ScInputHandler::EnterHandler( ScEnterMode 
nBlockMode, bool bBeforeSavingInL
 lcl_SelectionToEnd(pTableView);
 }
 
-vcl::Window* pFrameWin = pActiveViewSh ? pActiveViewSh->GetFrameWin() 
: nullptr;
+vcl::Window* pFrameWin = pActiveViewSh->GetFrameWin();
 
 if (pTopView)
 pTopView->CompleteAutoCorrect(); // CompleteAutoCorrect for both 
Views
@@ -3109,7 +3112,7 @@ void ScInputHandler::EnterHandler( ScEnterMode 
nBlockMode, bool bBeforeSavingInL
 lcl_RemoveTabs(aPreAutoCorrectString);
 
 // Test if valid (always with simple string)
-if (bModified && nValidation && pActiveViewSh)
+if (bModified && nValidation)
 {
 ScDocument& rDoc = pActiveViewSh->GetViewData().GetDocument();
 const ScValidationData* pData = rDoc.GetValidationEntry( nValidation );
@@ -3159,7 +3162,7 @@ void ScInputHandler::EnterHandler( ScEnterMode 
nBlockMode, bool bBeforeSavingInL
 }
 
 // Check for input into DataPilot table
-if ( bModified && pActiveViewSh && !bForget )
+if ( bModified && !bForget )
 {
 ScDocument& rDoc = pActiveViewSh->GetViewData().GetDocument();
 ScDPObject* pDPObj = rDoc.GetDPAtCursor( aCursorPos.Col(), 
aCursorPos.Row(), aCursorPos.Tab() );
@@ -3181,21 +3184,18 @@ void ScInputHandler::EnterHandler( ScEnterMode 
nBlockMode, bool bBeforeSavingInL
 {
 //  #i3820# If the spell checker flags numerical input as error,
 //  it still has to be treated as number, not EditEngine object.
-if ( pActiveViewSh )
+ScDocument& rDoc = pActiveViewSh->GetViewData().GetDocument();
+// #i67990# don't use pLastPattern in EnterHandler
+const ScPatternAttr* pPattern = rDoc.GetPattern( aCursorPos.Col(), 
aCursorPos.Row(), aCursorPos.Tab() );
+if (pPattern)
 {
-ScDocument& rDoc = pActiveViewSh->GetViewData().GetDocument();
-// #i67990# don't use pLastPattern in EnterHandler
-const ScPatternAttr* pPattern = rDoc.GetPattern( aCursorPos.Col(), 
aCursorPos.Row(), aCursorPos.Tab() );
-if (pPattern)
+SvNumberFormatter* pFormatter = rDoc.GetFormatTable();
+// without conditional format, as in ScColumn::SetString
+sal_uInt32 nFormat = pPattern->GetNumberFormat( pFormatter );
+double nVal;
+if ( pFormatter->IsNumberFormat( aString, nFormat, nVal ) )
 {
-SvNumberFormatter* pFormatter = rDoc.GetFormatTable();
-// without conditional format, as in ScColumn::SetString
-sal_uInt32 nFormat = pPattern->GetNumberFormat( pFormatter );
-double nVal;
-if ( pFormatter->IsNumberFormat( aString, nFormat, nVal ) )
-{
-bSpellErrors = false;   // ignore the spelling errors
-}
+bSpellErrors = false;   // ignore the spelling errors
 }
 }
 }
@@ -3229,7 +3229,7 @@ void ScInputHandler::EnterHandler( ScEnterMode 
nBlockMode, bool bBeforeSavingInL
 const SfxPoolItem* pItem = nullptr;
 
 // Find common (cell) attributes before RemoveAdjust
-if ( pActiveViewSh && bUniformAttribs )
+if ( bUniformAttribs )
 {
 std::optional pCommonAttrs;
 for (sal_uInt16 nId = EE_CHAR_START; nId <= EE_CHAR_END; nId++)

[Libreoffice-commits] core.git: vcl/unx

2023-10-21 Thread Caolán McNamara (via logerrit)

 vcl/unx/gtk3/gtkinst.cxx |   11 +++
 1 file changed, 11 insertions(+)

New commits:
commit a8c30238bc91f7bb7a5462c608eb27dd74c73db0
Author: Caolán McNamara 
AuthorDate: Fri Oct 20 14:38:29 2023 +0100
Commit: Caolán McNamara 
CommitDate: Sat Oct 21 17:16:57 2023 +0200

Resolves: tdf#157849 gtk_spin_button_update callback can delete widget

so later GtkInstanceEditable::signal_activate is on deleted widget

Change-Id: I9bb9848b4554792db11fc7b0e2d3491a94975b3f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158262
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/vcl/unx/gtk3/gtkinst.cxx b/vcl/unx/gtk3/gtkinst.cxx
index 12519a8dfd93..aaddf24bce32 100644
--- a/vcl/unx/gtk3/gtkinst.cxx
+++ b/vcl/unx/gtk3/gtkinst.cxx
@@ -17324,6 +17324,12 @@ IMPL_LINK_NOARG(GtkInstanceIconView, 
async_signal_selection_changed, void*, void
 
 namespace {
 
+void signalDestroyFlag(GtkWidget*, gpointer destroyed)
+{
+bool* pDestroyed = static_cast(destroyed);
+*pDestroyed = true;
+}
+
 class GtkInstanceSpinButton : public GtkInstanceEditable, public virtual 
weld::SpinButton
 {
 private:
@@ -17378,7 +17384,12 @@ private:
 
 virtual void signal_activate() override
 {
+bool bActivateDestroy(false);
+gulong nDestroySignalId = g_signal_connect(m_pButton, "destroy", 
G_CALLBACK(signalDestroyFlag), );
 gtk_spin_button_update(m_pButton);
+if (bActivateDestroy)
+return;
+g_signal_handler_disconnect(m_pButton, nDestroySignalId);
 GtkInstanceEditable::signal_activate();
 }

[Libreoffice-commits] core.git: Branch 'libreoffice-7-6' - sc/source

2023-10-21 Thread Eike Rathke (via logerrit)

 sc/source/core/tool/interpr4.cxx |4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

New commits:
commit 1ed6f4ba6fcae232705d005de6fcbdcc8769585f
Author: Eike Rathke 
AuthorDate: Mon Oct 16 20:35:13 2023 +0200
Commit: Caolán McNamara 
CommitDate: Sat Oct 21 17:31:48 2023 +0200

Resolves: tdf#157797 Let GetCellValue() propagate previous error, if any

Change-Id: I27ee8d19e4f45bef81e133c82ac17b825790208f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158064
Reviewed-by: Eike Rathke 
Tested-by: Jenkins
(cherry picked from commit aa2632885d8b169016ce8f888cc04796544213b0)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158040
Reviewed-by: Caolán McNamara 

diff --git a/sc/source/core/tool/interpr4.cxx b/sc/source/core/tool/interpr4.cxx
index 45ae430f5025..29072181bd91 100644
--- a/sc/source/core/tool/interpr4.cxx
+++ b/sc/source/core/tool/interpr4.cxx
@@ -180,7 +180,9 @@ double ScInterpreter::GetCellValue( const ScAddress& rPos, 
ScRefCellValue& rCell
 FormulaError nErr = nGlobalError;
 nGlobalError = FormulaError::NONE;
 double nVal = GetCellValueOrZero(rPos, rCell);
-if ( nGlobalError == FormulaError::NONE || nGlobalError == 
FormulaError::CellNoValue )
+// Propagate previous error, if any; nGlobalError==CellNoValue is not an
+// error here, preserve previous error or non-error.
+if (nErr != FormulaError::NONE || nGlobalError == 
FormulaError::CellNoValue)
 nGlobalError = nErr;
 return nVal;
 }

[Libreoffice-commits] core.git: Branch 'libreoffice-7-6' - 2 commits - svx/source

2023-10-21 Thread Julien Nabet (via logerrit)

 svx/source/customshapes/EnhancedCustomShape3d.cxx |   24 +++---
 1 file changed, 21 insertions(+), 3 deletions(-)

New commits:
commit 249751d2bc4c6c6704c00c83a807a3a0c0a31288
Author: Julien Nabet 
AuthorDate: Fri Oct 6 17:19:28 2023 +0200
Commit: Caolán McNamara 
CommitDate: Sat Oct 21 17:31:26 2023 +0200

tdf#157532: deal "ProjectionMode" for extruded custom shapes via BASIC macro

I took example on SdrTextAniDirectionItem::PutValue from 
svx/source/svdraw/svdattr.cxx

Change-Id: I9165b9a310ff6bee287e7fb817502c0c99f0747b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157654
Tested-by: Jenkins
Reviewed-by: Julien Nabet 
(cherry picked from commit 1f7220ffdf0a6188c30402cf38dab7b1f8142390)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157623
Reviewed-by: Patrick Luby 
Reviewed-by: Caolán McNamara 

diff --git a/svx/source/customshapes/EnhancedCustomShape3d.cxx 
b/svx/source/customshapes/EnhancedCustomShape3d.cxx
index 758953a0f64e..a401246277cc 100644
--- a/svx/source/customshapes/EnhancedCustomShape3d.cxx
+++ b/svx/source/customshapes/EnhancedCustomShape3d.cxx
@@ -341,8 +341,17 @@ rtl::Reference 
EnhancedCustomShape3d::Create3DObject(
 
 drawing::ProjectionMode eProjectionMode( 
drawing::ProjectionMode_PARALLEL );
 const Any* pAny = rGeometryItem.GetPropertyValueByName( "Extrusion", 
"ProjectionMode" );
-if ( pAny )
-*pAny >>= eProjectionMode;
+if (pAny)
+{
+if(!(*pAny >>= eProjectionMode))
+{
+sal_Int32 nEnum = 0;
+if(*pAny >>= nEnum)
+{
+eProjectionMode = 
static_cast(nEnum);
+}
+}
+}
 // pShape2d Convert in scenes which include 3D Objects
 E3dDefaultAttributes a3DDefaultAttr;
 a3DDefaultAttr.SetDefaultLatheCharacterMode( true );
commit 03d40c7e9cb377a1aa93a431f8f670f78aa6fe38
Author: Julien Nabet 
AuthorDate: Fri Oct 6 17:29:54 2023 +0200
Commit: Caolán McNamara 
CommitDate: Sat Oct 21 17:31:13 2023 +0200

Related tdf#157532: deal "ShadeMode" for extruded custom shapes via BASIC 
macro

Change-Id: I9ff65f58d48c2b61819533f62c42e2ab07ad4fb1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157655
Tested-by: Jenkins
Reviewed-by: Julien Nabet 
(cherry picked from commit ba86d112d01db86c1269a2db9cdb9b89e4845bbf)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157625
Reviewed-by: Patrick Luby 
Reviewed-by: Caolán McNamara 

diff --git a/svx/source/customshapes/EnhancedCustomShape3d.cxx 
b/svx/source/customshapes/EnhancedCustomShape3d.cxx
index 468a1c66fa93..758953a0f64e 100644
--- a/svx/source/customshapes/EnhancedCustomShape3d.cxx
+++ b/svx/source/customshapes/EnhancedCustomShape3d.cxx
@@ -141,7 +141,16 @@ drawing::ShadeMode GetShadeMode( const 
SdrCustomShapeGeometryItem& rItem, const
 drawing::ShadeMode eRet( eDefault );
 const Any* pAny = rItem.GetPropertyValueByName( "Extrusion", "ShadeMode" );
 if ( pAny )
-*pAny >>= eRet;
+{
+if (!(*pAny >>= eRet))
+{
+sal_Int32 nEnum = 0;
+if(*pAny >>= nEnum)
+{
+eRet = static_cast(nEnum);
+}
+}
+}
 return eRet;
 }

[Libreoffice-commits] core.git: sd/qa

2023-10-21 Thread Sarper Akdemir (via logerrit)

 sd/qa/unit/data/pptx/tdf144092-tableHeight.pptx |binary
 sd/qa/unit/import-tests2.cxx|4 ++--
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 676e0527d2f31556eccae314fbb12ce204f02ec7
Author: Sarper Akdemir 
AuthorDate: Fri Oct 20 12:03:25 2023 +0300
Commit: Sarper Akdemir 
CommitDate: Sat Oct 21 22:58:39 2023 +0200

use Liberation Sans instead of Calibri in the test for tdf#144092

based on Stephan Bergmann's point on:


the font used in the test file was Calibri, which likely was
being replaced with the best approximation on a given system.
Changed that to Liberation Sans which is a font that is bundled
with LibreOffice to improve the test's robustness.

Change-Id: I7ff75baeb9259dea244913ca9d5025948291f1e2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158234
Reviewed-by: Stephan Bergmann 
Tested-by: Jenkins

diff --git a/sd/qa/unit/data/pptx/tdf144092-tableHeight.pptx 
b/sd/qa/unit/data/pptx/tdf144092-tableHeight.pptx
index c597abf9a620..949a0561b25c 100644
Binary files a/sd/qa/unit/data/pptx/tdf144092-tableHeight.pptx and 
b/sd/qa/unit/data/pptx/tdf144092-tableHeight.pptx differ
diff --git a/sd/qa/unit/import-tests2.cxx b/sd/qa/unit/import-tests2.cxx
index 525177ba44da..0ca3513ae00c 100644
--- a/sd/qa/unit/import-tests2.cxx
+++ b/sd/qa/unit/import-tests2.cxx
@@ -1771,10 +1771,10 @@ CPPUNIT_TEST_FIXTURE(SdImportTest2, 
testTdf144092TableHeight)
 uno::Reference xTableShape(getShapeFromPage(0, 0), 
uno::UNO_QUERY);
 
 // Without the accompanying fix in place, this test would have failed with:
-// - Expected: 7208
+// - Expected: 7606
 // - Actual  : 4595
 // i.e. the table height wasn't corrected by expanding less than minimum 
sized rows.
-CPPUNIT_ASSERT_EQUAL(sal_Int32(7208), xTableShape->getSize().Height);
+CPPUNIT_ASSERT_EQUAL(sal_Int32(7606), xTableShape->getSize().Height);
 }
 
 CPPUNIT_TEST_FIXTURE(SdImportTest2, testTdf89928BlackWhiteThreshold)

New Defects reported by Coverity Scan for LibreOffice

2023-10-21 Thread scan-admin

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found 
with Coverity Scan.

1 new defect(s) introduced to LibreOffice found with Coverity Scan.
5 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent 
build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)


** CID 1548028:  Null pointer dereferences  (FORWARD_NULL)
/sd/source/ui/sidebar/LayoutMenu.cxx: 534 in sd::sidebar::LayoutMenu::Fill()()



*** CID 1548028:  Null pointer dereferences  (FORWARD_NULL)
/sd/source/ui/sidebar/LayoutMenu.cxx: 534 in sd::sidebar::LayoutMenu::Fill()()
528 pInfo = standard;
529 }
530 
531 Clear();
532 for (size_t i = 0; i < pInfo.size(); i++)
533 {
>>> CID 1548028:  Null pointer dereferences  (FORWARD_NULL)
>>> Dereferencing null pointer "pInfo[i]".
534 if ((WritingMode_TB_RL != pInfo[i].meWritingMode) || bVertical)
535 {
536 Image aImg(OUString::Concat("private:graphicrepository/") + 
pInfo[i].msBmpResId);
537 
538 if (bRightToLeft && (WritingMode_TB_RL != 
pInfo[i].meWritingMode))
539 { // FIXME: avoid interpolating RTL layouts.



To view the defects in Coverity Scan visit, 
https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNnPiSHxWPOELPnIxzXoBNaw-3D_ciS_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJiSHhe9Wg-2FPnsc7UhTzovCpfyVTuEnUpg25la-2Bm-2F4-2B9DrIs-2FJPt-2FC3Ee8HW4Im7iDDW9EgozI-2BdJbG6eN-2FFL421Gikc-2BxPdL77TBu6VCN7GYFdXnEoldYiphhV-2BhPY0TExJxSeDLpFD3UpFp7gi2zy6Vo4RqO2cRmSAFIMiu-2FsPOg-3D

[Libreoffice-commits] core.git: editeng/source

2023-10-21 Thread Caolán McNamara (via logerrit)

 editeng/source/items/textitem.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit dffe85aaf3443ab2286eb9990c1c7faa692ec96f
Author: Caolán McNamara 
AuthorDate: Sat Oct 21 16:15:53 2023 +0100
Commit: Caolán McNamara 
CommitDate: Sat Oct 21 20:45:33 2023 +0200

ofz#63406 Timeouts with huge fonts

reduce limit further when fuzzing

Change-Id: I66345f78a5375a6415f0b25ba736c41fd27ce8d9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158308
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/editeng/source/items/textitem.cxx 
b/editeng/source/items/textitem.cxx
index 813f907fb784..cac394c119c4 100644
--- a/editeng/source/items/textitem.cxx
+++ b/editeng/source/items/textitem.cxx
@@ -813,7 +813,7 @@ bool SvxFontHeightItem::PutValue( const uno::Any& rVal, 
sal_uInt8 nMemberId )
 if (fPoint < 0. || fPoint > 1.)
 return false;
 static bool bFuzzing = utl::ConfigManager::IsFuzzing();
-if (bFuzzing && fPoint > 500)
+if (bFuzzing && fPoint > 240)
 {
 SAL_WARN("editeng.items", "SvxFontHeightItem ignoring font 
size of " << fPoint << " for performance");
 return false;

[Libreoffice-commits] core.git: officecfg/registry sw/inc sw/source

2023-10-21 Thread Mike Kaganski (via logerrit)

 officecfg/registry/schema/org/openoffice/Office/Writer.xcs |6 
 sw/inc/doc.hxx |1 
 sw/source/core/doc/doc.cxx |  128 +++--
 3 files changed, 83 insertions(+), 52 deletions(-)

New commits:
commit 562856a8bca0869a04147fbc05a1eece9193
Author: Mike Kaganski 
AuthorDate: Sat Oct 21 17:42:56 2023 +0300
Commit: Mike Kaganski 
CommitDate: Sat Oct 21 21:48:34 2023 +0200

Related: tdf#89178 Add an option to avoid converting some fields into text

... during mail merge.

In some modes (generating individual documents; creating PDF) the mail merge
process converts all fields into text. But sometimes it is undesirable for
fields not involved into mail merge itself:

* It is inconsistent with how MS Word behaves;
* The generated editable documents could benefit from having other fields
  kept as fields;
* Some fields, when exported to PDF, produce different results: e.g.,
  placeholder fields are output as empty spaces, not as placeholder text.

An expert boolean configuration option is added:
Office/Writer/FormLetter/ConvertToTextOnlyMMFields; it is false by default,
in which case, the behavior is unchanged. When true, all fields in the mail
merge document, except for database fields and hidden text fields, are not
converted to text during mail merge process.

Change-Id: Ibdb505ed3f2762db063bb0a91b674d27ecbc2e7f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158306
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/officecfg/registry/schema/org/openoffice/Office/Writer.xcs 
b/officecfg/registry/schema/org/openoffice/Office/Writer.xcs
index 75a019c63c73..c9da17b65c9e 100644
--- a/officecfg/registry/schema/org/openoffice/Office/Writer.xcs
+++ b/officecfg/registry/schema/org/openoffice/Office/Writer.xcs
@@ -6014,6 +6014,12 @@
   
 
   
+  
+
+  When true, only fields that can be used in mail merge will be 
converted to text; all other fields will be kept as fields in the Mail Merge 
output
+
+false
+  
 
 
   
diff --git a/sw/inc/doc.hxx b/sw/inc/doc.hxx
index c40abf7a1581..5d1814210801 100644
--- a/sw/inc/doc.hxx
+++ b/sw/inc/doc.hxx
@@ -1445,6 +1445,7 @@ public:
 // restore the invisible content if it's available on the undo stack
 bool RestoreInvisibleContent();
 
+// Replace fields by text - mailmerge support
 SAL_DLLPRIVATE bool ConvertFieldsToText(SwRootFrame const& rLayout);
 
 // Create sub-documents according to given collection.
diff --git a/sw/source/core/doc/doc.cxx b/sw/source/core/doc/doc.cxx
index da14a84674e3..4bcb2a35e856 100644
--- a/sw/source/core/doc/doc.cxx
+++ b/sw/source/core/doc/doc.cxx
@@ -53,6 +53,8 @@
 #include 
 #include 
 
+#include 
+
 #include 
 #include 
 #include 
@@ -1618,12 +1620,32 @@ bool SwDoc::RestoreInvisibleContent()
 return false;
 }
 
+static bool IsMailMergeField(SwFieldIds fieldId)
+{
+switch (fieldId)
+{
+case SwFieldIds::Database: // Mail merge fields
+case SwFieldIds::DatabaseName: // Database name
+case SwFieldIds::HiddenText: // Hidden text may use database fields in 
condition
+case SwFieldIds::HiddenPara: // Hidden paragraph may use database 
fields in condition
+case SwFieldIds::DbNextSet: // Moving to next mail merge record
+case SwFieldIds::DbNumSet: // Moving to a specific mail merge record
+case SwFieldIds::DbSetNumber: // Number of current mail merge record
+return true;
+default:
+return false;
+}
+}
+
 bool SwDoc::ConvertFieldsToText(SwRootFrame const& rLayout)
 {
 bool bRet = false;
 getIDocumentFieldsAccess().LockExpFields();
 GetIDocumentUndoRedo().StartUndo( SwUndoId::UI_REPLACE, nullptr );
 
+const bool bOnlyConvertDBFields
+= 
officecfg::Office::Writer::FormLetter::ConvertToTextOnlyMMFields::get();
+
 const SwFieldTypes* pMyFieldTypes = 
getIDocumentFieldsAccess().GetFieldTypes();
 const SwFieldTypes::size_type nCount = pMyFieldTypes->size();
 //go backward, field types are removed
@@ -1634,6 +1656,9 @@ bool SwDoc::ConvertFieldsToText(SwRootFrame const& 
rLayout)
 if ( SwFieldIds::Postit == pCurType->Which() )
 continue;
 
+if (bOnlyConvertDBFields && !IsMailMergeField(pCurType->Which()))
+continue;
+
 std::vector vFieldFormats;
 pCurType->GatherFields(vFieldFormats, false);
 for(const auto& rpFieldFormat : vFieldFormats)
@@ -1644,67 +1669,66 @@ bool SwDoc::ConvertFieldsToText(SwRootFrame const& 
rLayout)
 
 bool bSkip = !pTextField ||
  !pTextField->GetpTextNode()->GetNodes().IsDocNodes();
+if (bSkip)
+continue;
 
-if (!bSkip)
+bool bInHeaderFooter =

[Libreoffice-bugs] [Bug 114783] Display size of document on a HDMI attached Monitor is more than twice the expected size

2023-10-21 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114783

--- Comment #13 from Alex Thurgood  ---
Still present in 7621.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157852] Table Rows are not displayed

2023-10-21 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=157852

--- Comment #6 from ⁨خالد حسني⁩  ---
(In reply to raal from comment #5)
> (In reply to ⁨خالد حسني⁩ from comment #4)
> > The original report was on Windows, the bisected commit is a Unix-only
> > change (and code that is long gone, anyway).
> 
> Thanks Khaled. Deleting regression tags. Probably as a coincidence, it's
> just about height of row and position of the table. For example when I
> change font size inside table to 6 pt, the table is correctly rendered on
> second page and all rows are visible. Still the bug, rows should not
> disappear.


I think the bug here is that a table that should be split across pages is not
split, if you change the table settings to not split, it will move to the next
page and all rows will appear.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 133881] Kerning changed in exported PDF. Kerning in ODT looks smooth. Kerning in PDF chaotic

2023-10-21 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=133881

BogdanB  changed:

   What|Removed |Added

Version|7.1.0.0.alpha0+ |6.4.4.2 release
 CC||buzea.bog...@libreoffice.or
   ||g

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 137271] CTRL+SHIFT+UP select includes a element of start of a line (containing formatting)

2023-10-21 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137271

BogdanB  changed:

   What|Removed |Added

Version|7.1.0.0.alpha0+ |4.4.7.2 release
 CC||buzea.bog...@libreoffice.or
   ||g

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 134372] FILESAVE RTF: Only a field is stored

2023-10-21 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=134372

BogdanB  changed:

   What|Removed |Added

Version|7.1.0.0.alpha0+ |6.4.0.3 release
 CC||buzea.bog...@libreoffice.or
   ||g

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157877] New: Random thickness of Footnote separator lines

2023-10-21 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=157877

Bug ID: 157877
   Summary: Random thickness of Footnote separator lines
   Product: LibreOffice
   Version: 7.3.7.2 release
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: trid...@gmail.com

Random thickness of Footnote separator lines

In a Writer document I’m seeing Footnote separator lines of different
thickness, seemingly randomly

I have reported this on https://ask.libreoffice.org and received a response
that it's a screen glitch.  I don't believe it is as the problem is visible on
a printed page.

This is a link to my report and the following conversation
https://ask.libreoffice.org/t/random-thickness-of-footnote-separator-lines/97103

Summary

--

My document has three page styles, First Page, Left Page, Right Page

In each style I’ve used Format → Page Style → Footnote to set the footnote line
to be 0.1pt thick

However regardless of the Page Style, the footnote separator line will be
either the correct thickness, or noticeably thicker, randomly.

It’s also noticeable that as I edit the document the footnote separator line
can change from thick to thin and vice versa. I’ve not seen any pattern to
this.

I’ve tried unpacking the ODT file to look at the ‘content.xml’ file but I can’t
see anything obviously different between when the line is thick and when it is
thin.

I export the ODT to PDF and the thick and thin lines in the PDF match the state
of the ODT at the time of export.

--

Two replies said it was a screen glitch however the problem is still there on a
printed page.

It is identical in the ODT and PDF
It is random within the document
It can change during editing
It is still visible at high magnification (ODT file at 550%, PDF at 400%)
I’ve printed the PDF and what is on screen is still evident on the printed
copy.

So I think it's a bug

Thank you for any help

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 135658] Column width value on side bar is larger than table size, as single column table and alignment to center

2023-10-21 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=135658

BogdanB  changed:

   What|Removed |Added

 Blocks||103428

--- Comment #7 from BogdanB  ---
This is the bug (see comment 3):
"But in the sidebar there is 16 cm column width."


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103428
[Bug 103428] [META] Properties deck/tab of the sidebar
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103428] [META] Properties deck/tab of the sidebar

2023-10-21 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103428

BogdanB  changed:

   What|Removed |Added

 Depends on||135658


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=135658
[Bug 135658] Column width value on side bar is larger than table size, as
single column table and alignment to center
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 135100] PASTE RTF: Images disappearing when pasting from DOCX

2023-10-21 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=135100

BogdanB  changed:

   What|Removed |Added

Version|7.1.0.0.alpha0+ |5.2 all versions

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157878] New: AUTOFILTER : Doesn't work with dash beetween 2 words like "CP" and "Mi-CP"

2023-10-21 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=157878

Bug ID: 157878
   Summary: AUTOFILTER : Doesn't work with dash beetween 2 words
like "CP" and "Mi-CP"
   Product: LibreOffice
   Version: 7.6.2.1 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: thierry.mu...@free.fr

Created attachment 190365
  --> https://bugs.documentfoundation.org/attachment.cgi?id=190365=edit
Sheet with autofilter and entries "CP" and "Mi-CP" on the column B

Hi,

When I use the autofilter with the words "CP" and "Mi-CP" listed, and I choose
"CP", the result returns all the entries with CP inside so I have "CP" and
"Mi-CP" entries.
I should obtain only "CP" entries not "Mi-CP" entries.

When I choose "Mi-CP", only the "Mi-CP" entries are returned : no problem here.

See the attachment.

Regards,

ThierryM

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 135100] PASTE RTF: Images disappearing when pasting from DOCX

2023-10-21 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=135100

BogdanB  changed:

   What|Removed |Added

 Blocks|102593  |109040

--- Comment #6 from BogdanB  ---
Still in
Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 3a1cf7a24cfbf65adbbe692ac6f8c1b55c7807fe
CPU threads: 16; OS: Linux 6.2; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=102593
[Bug 102593] [META] Paste bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=109040
[Bug 109040] [META] RTF paste special bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 102593] [META] Paste bugs and enhancements

2023-10-21 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=102593

BogdanB  changed:

   What|Removed |Added

 Depends on|135100  |


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=135100
[Bug 135100] PASTE RTF: Images disappearing when pasting from DOCX
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 109040] [META] RTF paste special bugs and enhancements

2023-10-21 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=109040

BogdanB  changed:

   What|Removed |Added

 Depends on||135100


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=135100
[Bug 135100] PASTE RTF: Images disappearing when pasting from DOCX
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152745] File - Save Remote in a new document generate a OfficeControlAccess.cxx warning in console with debug LO

2023-10-21 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=152745

--- Comment #3 from BogdanB  ---
Warnings from description are still here from Writer - File - Save Remote.

Warnings from comment 2 are from StartCenter - Remote Files.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157877] Random thickness of Footnote separator lines

2023-10-21 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=157877

Mike Kaganski  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from Mike Kaganski  ---
Yes, it is in print and PDF. But the same is said in later comments in
tdf#94015. This is a duplicate of the latter.

*** This bug has been marked as a duplicate of bug 94015 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 94015] Footnote separator line shows wrong on screen

2023-10-21 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=94015

Mike Kaganski  changed:

   What|Removed |Added

 CC||trid...@gmail.com

--- Comment #6 from Mike Kaganski  ---
*** Bug 157877 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152750] File - Digital Signatures generate a warning in console with debug LO: DBG_UNHANDLED_EXCEPTION in ReadAndVerifySignature

2023-10-21 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=152750

--- Comment #3 from BogdanB  ---
warn:xmlsecurity.helper:241078:241078:xmlsecurity/source/helper/xmlsignaturehelper.cxx:280:
DBG_UNHANDLED_EXCEPTION in ReadAndVerifySignature exception:
com.sun.star.xml.sax.SAXParseException message: "[ line 1]: no elementserror at
/home/tdf/lode/jenkins/workspace/lo_gerrit/tb/src_master/sax/source/expatwrap/sax_expat.cxx:674"
wrapped: com.sun.star.xml.sax.SAXParseException message: "at
/home/tdf/lode/jenkins/workspace/lo_gerrit/tb/src_master/sax/source/expatwrap/sax_expat.cxx:469"
wrapped: void message: "at
/home/tdf/lode/jenkins/workspace/lo_gerrit/tb/src_master/comphelper/source/misc/diagnose_ex.cxx:66"
PublicId:  SystemId:  LineNumber: 0 ColumnNumber: 0 PublicId:  SystemId: 
LineNumber: 1 ColumnNumber: 0
warn:ucb.ucp.webdav.curl:241078:241227:ucb/source/ucp/webdav-curl/CurlSession.cxx:960:
curl_easy_perform failed: (60) SSL certificate problem: unable to get local
issuer certificate
warn:ucb.ucp.webdav:241078:241227:ucb/source/ucp/webdav-curl/webdavcontent.cxx:4058:
OPTIONS - DAVException: DAV_HTTP_TIMEOUT or DAV_HTTP_CONNECT for URL


Restested with
Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 9a0018a356c89baf600a72eed8ee4ac927815b9b
CPU threads: 16; OS: Linux 6.2; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 94015] Footnote separator line shows wrong on screen

2023-10-21 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=94015

Mike Kaganski  changed:

   What|Removed |Added

   Severity|minor   |normal

--- Comment #7 from Mike Kaganski  ---
As mentioned in comment 3, and also in bug 134208 comment 8, and in bug 157877,
this shows not only on screen, but also in PDF and on print. Thus, this is not
minor.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 156996] Pie chart: Source format keeps cheked, even if it is disabled by user

2023-10-21 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=156996

--- Comment #4 from BogdanB  ---
Created attachment 190366
  --> https://bugs.documentfoundation.org/attachment.cgi?id=190366=edit
Demo document

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 135725] Chapter numbering cannot be compared

2023-10-21 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=135725

BogdanB  changed:

   What|Removed |Added

Version|7.1.0.0.alpha0+ |7.0.0.3 release

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157615] Marking parts of text with the mouse does not work any longer reliably

2023-10-21 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=157615

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Resolution|FIXED   |WORKSFORME

--- Comment #7 from Stéphane Guillou (stragu) 
 ---
Thank you for the thorough testing and for reporting back!
The right resolution is "works for me" as we're not sure what fixed it.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 101646] UI option "Scaling" was removed

2023-10-21 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=101646

--- Comment #85 from V Stuart Foote  ---
(In reply to Mike Kaganski from comment #84)

> ... Any case when LibreOffice doesn't follow system preferences
> is a bug, so people setting their environment according to their preference,
> should not need to tweak LibreOffice UI settings personally.

Agree with that, however there are substantial Accessibility and other use
cases (e.g. preparing documentation by screen capture, or live
instruction/demos) where ability for LO to selectively scale class (menu, TB,
dialog) of UI elements remains legitimate enhancement outside scope of average
usage provided by os/DE scaling methods. As enhancement still valid.

> 
> The SAL_FORCEDPI workaround is enough (needs better documenting?) for cases
> not properly supported for now. ...

Unfortunately SAL_FORCEDPI environment variable does nothing for Windows os/DE
(just verified it does not [1]). Documentation [2] indicates support for gtk3 &
qt5/kf5 plugins only--so not a global workaround.


=-ref-=
[1] Version: 7.6.2.1 (X86_64) / LibreOffice Community
Build ID: 56f7684011345957bbf33a7ee678afaf4d2ba333
CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded

no visible change to UI with default, SAL_FORCEDPI=160, or SAL_FORCEDPI=220 env
set.

[2] https://wiki.documentfoundation.org/Development/Environment_variables

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152571] Very slow save (macOS, ARM)

2023-10-21 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=152571

--- Comment #12 from Stéphane Guillou (stragu) 
 ---
(In reply to Alex Thurgood from comment #11)
> @Stéphane: for me, the problem isn't on first save. Every save operation
> causes the spinning beach all, even after minor changes to a Draw file.
I understand that's the same as in bug 157582.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157878] AUTOFILTER : Doesn't work with dash beetween 2 words like "CP" and "Mi-CP"

2023-10-21 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=157878

Thierry Munoz  changed:

   What|Removed |Added

 CC||thierry.mu...@free.fr

--- Comment #1 from Thierry Munoz  ---
The problem exist too with "CP" and "MiCP". It's not a dash beetween words
problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157878] AUTOFILTER : Doesn't work with 2 words like "CP" and "Mi-CP" or "MiCP"

2023-10-21 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=157878

Thierry Munoz  changed:

   What|Removed |Added

Summary|AUTOFILTER : Doesn't work   |AUTOFILTER : Doesn't work
   |with dash beetween 2 words  |with 2 words like "CP" and
   |like "CP" and "Mi-CP"   |"Mi-CP" or "MiCP"

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149671] Oversized spaces at the margin

2023-10-21 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=149671

BogdanB  changed:

   What|Removed |Added

   Keywords||bibisected, bisected,
   ||regression
 CC||attila.sz...@collabora.com,
   ||nagytibor0...@gmail.com

--- Comment #2 from BogdanB  ---
author  Attila Szűcs 2022-05-27 13:12:27 +0200
committer   László Németh2022-06-07 19:28:48
+0200
commit  8741fd0e0ae9e346de2e09887f0668b831c9b48b (patch)
tree97cf3bb7a883c9e119debe6678e0cca57bdf1faf
parent  5a079652c1b1f968a851f47995b0a65b84d2d192 (diff)
tdf#43244 sw: show stripped line-end spaces on margin
in View->Formatting Marks mode instead of hiding them
This way it's possible to avoid interoperability issues
better, when these (now visible) spaces are stripped only
in Writer, but not in MSO, resulting different layout,
i.e. bad paragraph alignment, because the users can
notice the extra spaces and remove them in Writer.

Extend SwHolePortion::Paint() to paint its text,
what is probably just a bunch of spaces.

It's an initial fix for tdf#43100, tdf#120715 and tdf#104683
(cursor movement on the hidden spaces, end of paragraph sign
before the hidden spaces, unable to select spaces after the margin).

Follow-up to commit 93d7bdcb855362b88cdcfcb18ea401d89da973fb
"fdo#33167, i#20878: Show spaces at the end of line".

Co-authored-by: Tibor Nagy (NISZ)

Change-Id: I48df3b41af37c77fd594bb6776ca30e845c51490
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135104
Tested-by: László Németh 
Reviewed-by: László Németh 

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 107733] [META] Hyperlink bugs and enhancements

2023-10-21 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=107733

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on||39015


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=39015
[Bug 39015] EDITING: drag-and-drop selection of (part) of hyperlink drags the
hyperlink itself (comment 14)
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 107733] [META] Hyperlink bugs and enhancements

2023-10-21 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=107733
Bug 107733 depends on bug 39015, which changed state.

Bug 39015 Summary: EDITING: drag-and-drop selection of (part) of hyperlink 
drags the hyperlink itself (comment 14)
https://bugs.documentfoundation.org/show_bug.cgi?id=39015

   What|Removed |Added

 Status|RESOLVED|NEW
 Resolution|NOTABUG |---

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 112182] [META] Text and object selection issues

2023-10-21 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=112182
Bug 112182 depends on bug 39015, which changed state.

Bug 39015 Summary: EDITING: drag-and-drop selection of (part) of hyperlink 
drags the hyperlink itself (comment 14)
https://bugs.documentfoundation.org/show_bug.cgi?id=39015

   What|Removed |Added

 Status|RESOLVED|NEW
 Resolution|NOTABUG |---

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 39015] EDITING: drag-and-drop selection of (part) of hyperlink drags the hyperlink itself (comment 14)

2023-10-21 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=39015

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 OS|Windows (All)   |All
Version|3.4.0 release   |Inherited From OOo
 Resolution|NOTABUG |---
 Status|RESOLVED|NEW
 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org,
   ||stephane.guillou@libreoffic
   ||e.org
   Keywords||needsUXEval
 Blocks||107733
Summary|EDITING: Can not select |EDITING: drag-and-drop
   |text starting with the  |selection of (part) of
   |beginning of a line |hyperlink drags the
   ||hyperlink itself (comment
   ||14)

--- Comment #15 from Stéphane Guillou (stragu) 
 ---
Thanks everyone, and Timur especially for clarifying.

I've changed the summary to be more descriptive of the issue.

As I was looking into this area, and seeing a couple of duplicate, I'm setting
to "new" again to check with the UX/Design team what their opinion is.

My questions to the team:
1. should this inherited feature remain, i.e. the dragging of whole hyperlink
instead of the drag-and-drop selection of part of it?
2. should we offer an option to deactivate it, given that several users are
confused by it / think it's a bug / don't like it?
3. if we offer an option, which should be the default?

App comparison:

Google Sheets, OnlyOffice, MS 365, Calligra Words and even Collabora Online
_all_ have drag-selection of part of a hyperlink as the default, just like
normal text

Happy to set this back to "not a bug" and open a new enhancement request if
that's what the team prefers.

Keep in mind: please test with a VCL plugin that is _not GTK_ as there is some
inconsistency there. (Selection of part of hyperlink sometimes _does_ work.)


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=107733
[Bug 107733] [META] Hyperlink bugs and enhancements
-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 39015] EDITING: drag-and-drop selection of (part) of hyperlink drags the hyperlink itself (comment 14)

2023-10-21 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=39015

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 OS|Windows (All)   |All
Version|3.4.0 release   |Inherited From OOo
 Resolution|NOTABUG |---
 Status|RESOLVED|NEW
 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org,
   ||stephane.guillou@libreoffic
   ||e.org
   Keywords||needsUXEval
 Blocks||107733
Summary|EDITING: Can not select |EDITING: drag-and-drop
   |text starting with the  |selection of (part) of
   |beginning of a line |hyperlink drags the
   ||hyperlink itself (comment
   ||14)

--- Comment #15 from Stéphane Guillou (stragu) 
 ---
Thanks everyone, and Timur especially for clarifying.

I've changed the summary to be more descriptive of the issue.

As I was looking into this area, and seeing a couple of duplicate, I'm setting
to "new" again to check with the UX/Design team what their opinion is.

My questions to the team:
1. should this inherited feature remain, i.e. the dragging of whole hyperlink
instead of the drag-and-drop selection of part of it?
2. should we offer an option to deactivate it, given that several users are
confused by it / think it's a bug / don't like it?
3. if we offer an option, which should be the default?

App comparison:

Google Sheets, OnlyOffice, MS 365, Calligra Words and even Collabora Online
_all_ have drag-selection of part of a hyperlink as the default, just like
normal text

Happy to set this back to "not a bug" and open a new enhancement request if
that's what the team prefers.

Keep in mind: please test with a VCL plugin that is _not GTK_ as there is some
inconsistency there. (Selection of part of hyperlink sometimes _does_ work.)


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=107733
[Bug 107733] [META] Hyperlink bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 114220] [META] Drag and drop bugs and enhancements

2023-10-21 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114220
Bug 114220 depends on bug 39015, which changed state.

Bug 39015 Summary: EDITING: drag-and-drop selection of (part) of hyperlink 
drags the hyperlink itself (comment 14)
https://bugs.documentfoundation.org/show_bug.cgi?id=39015

   What|Removed |Added

 Status|RESOLVED|NEW
 Resolution|NOTABUG |---

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149671] Oversized spaces at the margin

2023-10-21 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=149671

BogdanB  changed:

   What|Removed |Added

 Blocks||102345


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=102345
[Bug 102345] [META] Formatting marks (aka Non-printing characters) bugs and
enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 102345] [META] Formatting marks (aka Non-printing characters) bugs and enhancements

2023-10-21 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=102345

BogdanB  changed:

   What|Removed |Added

 Depends on||149671


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=149671
[Bug 149671] Oversized spaces at the margin
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 101646] UI option "Scaling" was removed

2023-10-21 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=101646

--- Comment #84 from Mike Kaganski  ---
IMO, this needs to be closed; and instead, every specific case (like comment 73
for Qt5 having different fonts in different UI elements; comment 80 about XFCE,
etc.) need own issues about improper handling of system preferences (bugs in
existing VCL plugins, or missing integration for some environments). Any case
when LibreOffice doesn't follow system preferences is a bug, so people setting
their environment according to their preference, should not need to tweak
LibreOffice UI settings personally.

The SAL_FORCEDPI workaround is enough (needs better documenting?) for cases not
properly supported for now. The projector argument is IMO not a valid one,
because it would apply to any displayed software (so any software would need
that configuration?), and actually needs setting the projector's resolution
accordingly, so that UI elements have a readable size.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 39015] EDITING: drag-and-drop selection of (part) of hyperlink drags the hyperlink itself (comment 14)

2023-10-21 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=39015

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 CC||bordfe...@web.de

--- Comment #16 from Stéphane Guillou (stragu) 
 ---
*** Bug 72266 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 107733] [META] Hyperlink bugs and enhancements

2023-10-21 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=107733
Bug 107733 depends on bug 72266, which changed state.

Bug 72266 Summary: EDITING: problems with selecting single characters in a 
hyperlink with the mouse
https://bugs.documentfoundation.org/show_bug.cgi?id=72266

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 112182] [META] Text and object selection issues

2023-10-21 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=112182
Bug 112182 depends on bug 72266, which changed state.

Bug 72266 Summary: EDITING: problems with selecting single characters in a 
hyperlink with the mouse
https://bugs.documentfoundation.org/show_bug.cgi?id=72266

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 39015] EDITING: drag-and-drop selection of (part) of hyperlink drags the hyperlink itself (comment 14)

2023-10-21 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=39015

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 CC||bordfe...@web.de

--- Comment #16 from Stéphane Guillou (stragu) 
 ---
*** Bug 72266 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-ux-advise] [Bug 39015] EDITING: drag-and-drop selection of (part) of hyperlink drags the hyperlink itself (comment 14)

2023-10-21 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=39015

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 CC||j...@encremento.com

--- Comment #17 from Stéphane Guillou (stragu) 
 ---
*** Bug 82700 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 72266] EDITING: problems with selecting single characters in a hyperlink with the mouse

2023-10-21 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=72266

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED

--- Comment #20 from Stéphane Guillou (stragu) 
 ---
(In reply to Stéphane Guillou (stragu) from comment #19)
> - The inherited behaviour of not allowing selecting a part of a hyperlink
> (for other VCL plugins like win or gen), maybe what m.a.riosv sees on
> Windows? This is exactly what the duplicate bug 82700 describes - and is not
> necessarily seen as a bug by some.

Consolidating this issue into earlier bug 39015.

*** This bug has been marked as a duplicate of bug 39015 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 82700] EDITING: Unable to select part of a hyperlink

2023-10-21 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=82700

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 CC||stephane.guillou@libreoffic
   ||e.org

--- Comment #11 from Stéphane Guillou (stragu) 
 ---
Consolidation into earlier bug 39015.

*** This bug has been marked as a duplicate of bug 39015 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 39015] EDITING: drag-and-drop selection of (part) of hyperlink drags the hyperlink itself (comment 14)

2023-10-21 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=39015

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 CC||j...@encremento.com

--- Comment #17 from Stéphane Guillou (stragu) 
 ---
*** Bug 82700 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157826] MariaDB, direct Connection, Windows-Server: Data could be read by Base through Tools → SQL, but not by the GUI (table, form …)

2023-10-21 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=157826

--- Comment #5 from Commit Notification 
 ---
Mike Kaganski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/5a0498ded11d514c21e3124333a3560da1373202

mariadb connector: upgrade to release 3.3.7 (fixes tdf#157826)

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157826] MariaDB, direct Connection, Windows-Server: Data could be read by Base through Tools → SQL, but not by the GUI (table, form …)

2023-10-21 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=157826

Mike Kaganski  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157826] MariaDB, direct Connection, Windows-Server: Data could be read by Base through Tools → SQL, but not by the GUI (table, form …)

2023-10-21 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=157826

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:24.2.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 112182] [META] Text and object selection issues

2023-10-21 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=112182

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on||157871


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=157871
[Bug 157871] Inconsistent drag selection vs drag and drop of hyperlink for gtk3
VCL plugin
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 107733] [META] Hyperlink bugs and enhancements

2023-10-21 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=107733

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on||157871


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=157871
[Bug 157871] Inconsistent drag selection vs drag and drop of hyperlink for gtk3
VCL plugin
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157871] New: Inconsistent drag selection vs drag and drop of hyperlink for gtk3 VCL plugin

2023-10-21 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=157871

Bug ID: 157871
   Summary: Inconsistent drag selection vs drag and drop of
hyperlink for gtk3 VCL plugin
   Product: LibreOffice
   Version: 7.2.0.4 release
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: stephane.guil...@libreoffice.org
CC: caolan.mcnam...@collabora.com
Blocks: 107733, 112182

This is a follow-up on bug 116384, as part of the issue remains.

Steps:
1. Open attachment 190359
2. Drag-select inside the hyperlink many times, in different directions
(avoiding the first and last characters)

Result: inconsistent behaviour, sometimes it drags the hyperlink, sometimes it
selects a text section.

With other VCL plugins that gtk, the behaviour is to only drag-and-drop the
whole hyperlink, so it should be made consistent with them for the time being
(regardless of what happens with bug 39015).

Caolán, thought you might be interested.

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: b83f069101f1e6d8aaac09a805f02bbc4c619e7a
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Version: 7.2.0.4 / LibreOffice Community
Build ID: 9a9c6381e3f7a62afc1329bd359cc48accb6435b
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=107733
[Bug 107733] [META] Hyperlink bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=112182
[Bug 112182] [META] Text and object selection issues
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157872] New: Drag-and-dropping a hyperlink from its last character onto itself makes it disappear

2023-10-21 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=157872

Bug ID: 157872
   Summary: Drag-and-dropping a hyperlink from its last character
onto itself makes it disappear
   Product: LibreOffice
   Version: Inherited From OOo
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: stephane.guil...@libreoffice.org
Blocks: 107733, 112182, 114220

Trying to select a hyperlink from its last character will drag and drop it
instead (not really a bug, see bug 39015), but will make it disappear if
dropped onto itself (the bug).

Steps:
1. Open attachment 190359
2. Drag and drop from the last "e" of the hyperlink to anywhere on the
hyperlink
3. Wait a second or refresh the view with a scroll

Result: link is removed.

Reproduced in OOo 3.3 and a recent master build:

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: b83f069101f1e6d8aaac09a805f02bbc4c619e7a
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Note: don't test with a gtk VCL plugin while bug 157871 is no solved.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=107733
[Bug 107733] [META] Hyperlink bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=112182
[Bug 112182] [META] Text and object selection issues
https://bugs.documentfoundation.org/show_bug.cgi?id=114220
[Bug 114220] [META] Drag and drop bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 112182] [META] Text and object selection issues

2023-10-21 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=112182

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on||157872


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=157872
[Bug 157872] Drag-and-dropping a hyperlink from its last character onto itself
makes it disappear
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 114220] [META] Drag and drop bugs and enhancements

2023-10-21 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114220

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on||157872


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=157872
[Bug 157872] Drag-and-dropping a hyperlink from its last character onto itself
makes it disappear
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 39015] EDITING: drag-and-drop selection of (part) of hyperlink drags the hyperlink itself (comment 14)

2023-10-21 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=39015

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||7872

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157871] Inconsistent drag selection vs drag and drop of hyperlink for gtk3 VCL plugin

2023-10-21 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=157871

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||7872

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 39015] EDITING: drag-and-drop selection of (part) of hyperlink drags the hyperlink itself (comment 14)

2023-10-21 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=39015

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||7872

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 39015] EDITING: drag-and-drop selection of (part) of hyperlink drags the hyperlink itself (comment 14)

2023-10-21 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=39015

--- Comment #19 from Stéphane Guillou (stragu) 
 ---
(In reply to Stéphane Guillou (stragu) from comment #18)
> (don't test with gtk VCL plugin)
gtk issue reported in bug 157871.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 39015] EDITING: drag-and-drop selection of (part) of hyperlink drags the hyperlink itself (comment 14)

2023-10-21 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=39015

--- Comment #19 from Stéphane Guillou (stragu) 
 ---
(In reply to Stéphane Guillou (stragu) from comment #18)
> (don't test with gtk VCL plugin)
gtk issue reported in bug 157871.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 107733] [META] Hyperlink bugs and enhancements

2023-10-21 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=107733

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on||157872


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=157872
[Bug 157872] Drag-and-dropping a hyperlink from its last character onto itself
makes it disappear
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157391] Access items in the Navigator window programatically

2023-10-21 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=157391

--- Comment #7 from fuzzybear  ---
There's various information available there, unfortunately I am not
sufficiently knowledgeable with regard to what of that information is available
through pre existing APIs within the tool. Hyperlink enumeration is an obvious
example but I expect that there are others.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 39015] EDITING: drag-and-drop selection of (part) of hyperlink drags the hyperlink itself (comment 14)

2023-10-21 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=39015

--- Comment #18 from Stéphane Guillou (stragu) 
 ---
Created attachment 190359
  --> https://bugs.documentfoundation.org/attachment.cgi?id=190359=edit
simple sample ODT with hyperlink

(don't test with gtk VCL plugin)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 39015] EDITING: drag-and-drop selection of (part) of hyperlink drags the hyperlink itself (comment 14)

2023-10-21 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=39015

--- Comment #18 from Stéphane Guillou (stragu) 
 ---
Created attachment 190359
  --> https://bugs.documentfoundation.org/attachment.cgi?id=190359=edit
simple sample ODT with hyperlink

(don't test with gtk VCL plugin)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 157874] Link text should "prefer" breaking at word boundary

2023-10-21 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=157874

--- Comment #2 from Eyal Rozenberg  ---
Created attachment 190362
  --> https://bugs.documentfoundation.org/attachment.cgi?id=190362=edit
Text box in an Impress document, expect break at slash

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157852] Table Rows are not displayed

2023-10-21 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=157852

BogdanB  changed:

   What|Removed |Added

 CC||buzea.bog...@libreoffice.or
   ||g
Version|4.2.0.4 release |4.1 all versions
   Keywords|bibisectRequest |bibisected, bisected

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157876] New: When selection only has variants of same font family, don't show empty box

2023-10-21 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=157876

Bug ID: 157876
   Summary: When selection only has variants of same font family,
don't show empty box
   Product: LibreOffice
   Version: 24.2.0.0 alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: eyalr...@gmx.com

Created attachment 190364
  --> https://bugs.documentfoundation.org/attachment.cgi?id=190364=edit
Presentation with text in three variants of OpenSans

One of the main problems of font handling in LibreOffice is the poor support
for font family variants beyond R/I/B/BI (bug 35538 and many related bugs
linked from there). One aspect of this support is the splitting of variants
into separate font "families" in font selection UI. Example: "Open Sans Light",
"Open Sans Semibold" - both variants of the "Open Sans" family, with different
entries in the list of font families.

Now, when one selects some text in the same font family, but with some of the
text being, say, Italic, and the rest being Roman (non-Italic) - the font
family box shows the family name. But if one selects some text in the Open Sans
family, some of which being Light and the rest being Semibold - the font family
box shows noting, as though you'd selected text from different font families -
even though you haven't.

I would like, even if we don't have proper UI for working with weights and
other variants, to at least see the common single font family when making such
selections.

Attaching a document with text in the three variants mentioned. You can get the
Open Sans fonts from here: https://fonts.google.com/specimen/Open+Sans

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157876] When selection only has variants of same font family, don't show empty box

2023-10-21 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=157876

Eyal Rozenberg  changed:

   What|Removed |Added

 Blocks||113438


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=113438
[Bug 113438] [META] Font name combobox bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 113438] [META] Font name combobox bugs and enhancements

2023-10-21 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=113438

Eyal Rozenberg  changed:

   What|Removed |Added

 Depends on||157876


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=157876
[Bug 157876] When selection only has variants of same font family, don't show
empty box
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157875] Selecting text in two font families shows first family

2023-10-21 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=157875

Eyal Rozenberg  changed:

   What|Removed |Added

 Blocks||113638


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=113638
[Bug 113638] [META] Fonts listed in LibreOffice
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 113638] [META] Fonts listed in LibreOffice

2023-10-21 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=113638

Eyal Rozenberg  changed:

   What|Removed |Added

 Depends on||157875


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=157875
[Bug 157875] Selecting text in two font families shows first family
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 33961] cross reference to a list number, dot bug

2023-10-21 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=33961

Amina Raifi  changed:

   What|Removed |Added

URL|https://www.ukassignmentshe |https://perfectcvmaker.ae/c
   |lp.co.uk/   |over-letter-writing

--- Comment #13 from Amina Raifi  ---
Amina Raifi

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157874] Link text should "prefer" breaking at word boundary

2023-10-21 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=157874

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 CC||stephane.guillou@libreoffic
   ||e.org

--- Comment #4 from Stéphane Guillou (stragu) 
 ---
Note we already have bug 40563 for Impress.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 124835] Contextual toolbars make UI jumping

2023-10-21 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=124835

--- Comment #33 from Eyal Rozenberg  ---
(author of bug 157866)

The way this bug seems to stand right now, the title seems to be more general.
I'm reading about all sorts of suggestions that involve:

* using another UI mode
* placing contextual controls in the sidebar
* new/weird docking for contextual controls

etc.

Personally, I don't (think I) like any of these options; although maybe I'm not
fully following all suggestions. Mock-ups or other illustrations of what's
currently on the agenda would be appreciated.

Anyway, I filed bug 157866 so that the content doesn't jump around when the
contextual UI appears; followers of this bug are kindly requested to also give
some thought to that issue, independently of this one.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157866] Toolbar dis/appearance must neither shift nor scale the slide display

2023-10-21 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=157866

Eyal Rozenberg  changed:

   What|Removed |Added

 Resolution|DUPLICATE   |---
 Status|RESOLVED|UNCONFIRMED

--- Comment #4 from Eyal Rozenberg  ---
This bug is not a dupe, since it is not about the jumpiness of the _UI_. It is
strictly about the _content_. I am not requesting that that the contextual UI
not appear, or appear differently. The request here is that _when_ it appears,
just as it appears now, the position (and scale) of the content on my PC
monitor does not change. The other bug does not discuss this at all, it only
discusses how to change the UI behavior. This bug does not require any changes
to the UI.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103239] [META] Toolbars bugs and enhancements

2023-10-21 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103239
Bug 103239 depends on bug 157866, which changed state.

Bug 157866 Summary: Toolbar dis/appearance must neither shift nor scale the 
slide display
https://bugs.documentfoundation.org/show_bug.cgi?id=157866

   What|Removed |Added

 Status|RESOLVED|UNCONFIRMED
 Resolution|DUPLICATE   |---

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 157866] Toolbar dis/appearance must neither shift nor scale the slide display

2023-10-21 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=157866

Eyal Rozenberg  changed:

   What|Removed |Added

 Resolution|DUPLICATE   |---
 Status|RESOLVED|UNCONFIRMED

--- Comment #4 from Eyal Rozenberg  ---
This bug is not a dupe, since it is not about the jumpiness of the _UI_. It is
strictly about the _content_. I am not requesting that that the contextual UI
not appear, or appear differently. The request here is that _when_ it appears,
just as it appears now, the position (and scale) of the content on my PC
monitor does not change. The other bug does not discuss this at all, it only
discusses how to change the UI behavior. This bug does not require any changes
to the UI.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 157873] New: Link text should not extend over textbox boundaries when editing the textbox, not the link

2023-10-21 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=157873

Bug ID: 157873
   Summary: Link text should not extend over textbox boundaries
when editing the textbox, not the link
   Product: LibreOffice
   Version: 7.6.0.3 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: minor
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: eyalr...@gmx.com

Consider the attached single-slide presentation. If you double-click the text
box to edit its text, the link extends past the textbox's edges, rather than
being wrapped like it is when we exit the textbox. This is detrimental to the
editing, as it reflows everything after the link, preventing me from seeing how
it would be laid out eventually. Only if I'm editing the link text itself do I
want it all laid out on the same line (which I get through the link properties
dialog; and maybe I don't care even then).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157873] Link text should not extend over textbox boundaries when editing the textbox, not the link

2023-10-21 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=157873

--- Comment #1 from Eyal Rozenberg  ---
Created attachment 190360
  --> https://bugs.documentfoundation.org/attachment.cgi?id=190360=edit
Presentation exhibiting the problem

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103494] [META] Textbox bugs and enhancements

2023-10-21 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103494

Eyal Rozenberg  changed:

   What|Removed |Added

 Depends on||157873


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=157873
[Bug 157873] Link text should not extend over textbox boundaries when editing
the textbox, not the link
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 107733] [META] Hyperlink bugs and enhancements

2023-10-21 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=107733

Eyal Rozenberg  changed:

   What|Removed |Added

 Depends on||157873


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=157873
[Bug 157873] Link text should not extend over textbox boundaries when editing
the textbox, not the link
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157873] Link text should not extend over textbox boundaries when editing the textbox, not the link

2023-10-21 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=157873

Eyal Rozenberg  changed:

   What|Removed |Added

 Blocks||107733, 103494


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103494
[Bug 103494] [META] Textbox bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107733
[Bug 107733] [META] Hyperlink bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157874] Link text should "prefer" breaking at word boundary

2023-10-21 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=157874

Eyal Rozenberg  changed:

   What|Removed |Added

 Blocks||87740, 107733


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=87740
[Bug 87740] [META] Anchor and text wrapping bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107733
[Bug 107733] [META] Hyperlink bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 87740] [META] Anchor and text wrapping bugs and enhancements

2023-10-21 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=87740

Eyal Rozenberg  changed:

   What|Removed |Added

 Depends on||157874


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=157874
[Bug 157874] Link text should "prefer" breaking at word boundary
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 107733] [META] Hyperlink bugs and enhancements

2023-10-21 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=107733

Eyal Rozenberg  changed:

   What|Removed |Added

 Depends on||157874


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=157874
[Bug 157874] Link text should "prefer" breaking at word boundary
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157874] New: Link text should "prefer" breaking at word boundary

2023-10-21 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=157874

Bug ID: 157874
   Summary: Link text should "prefer" breaking at word boundary
   Product: LibreOffice
   Version: 7.6.0.3 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: eyalr...@gmx.com

Text entered in a textbox breaks at word boundaries. However, if the same text
is a hyperlink - it breaks at the last insertable character. That's usually a
poor choice. It's usually better to break at spaces, or slashes, for example.

-- 
You are receiving this mail because:
You are the assignee for the bug.

1 2 >

1 - 100 of 187 matches

Mail list logo