core.git: 2 commits - sax/source unoxml/source
sax/source/expatwrap/sax_expat.cxx |1 -
sax/source/expatwrap/saxwriter.cxx |2 --
sax/source/tools/converter.cxx |1 -
unoxml/source/xpath/xpathapi.cxx |1 -
4 files changed, 5 deletions(-)
New commits:
commit 828ad91196826cda970f3894de516f91a82fd7de
Author: Gabor Kelemen
AuthorDate: Fri Mar 29 13:59:24 2024 +0100
Commit: Gabor Kelemen
CommitDate: Sun Mar 31 09:41:18 2024 +0200
tdf#146619 Drop unused 'using namespace' in: sax/
Change-Id: I1959402cb06f051ffe5f4a7e2e9f591b4908ea21
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165521
Tested-by: Jenkins
Reviewed-by: Gabor Kelemen
diff --git a/sax/source/expatwrap/sax_expat.cxx
b/sax/source/expatwrap/sax_expat.cxx
index 9a82b8703644..885e2910ba0c 100644
--- a/sax/source/expatwrap/sax_expat.cxx
+++ b/sax/source/expatwrap/sax_expat.cxx
@@ -46,7 +46,6 @@
#include
#include
-using namespace ::osl;
using namespace ::cppu;
using namespace ::com::sun::star::lang;
using namespace ::com::sun::star::xml::sax;
diff --git a/sax/source/expatwrap/saxwriter.cxx
b/sax/source/expatwrap/saxwriter.cxx
index 55608101faf5..c1f9db44330d 100644
--- a/sax/source/expatwrap/saxwriter.cxx
+++ b/sax/source/expatwrap/saxwriter.cxx
@@ -43,12 +43,10 @@
#include
-using namespace ::osl;
using namespace ::cppu;
using namespace ::com::sun::star::uno;
using namespace ::com::sun::star::lang;
using namespace ::com::sun::star::xml::sax;
-using namespace ::com::sun::star::util;
using namespace ::com::sun::star::io;
#define LINEFEED 10
diff --git a/sax/source/tools/converter.cxx b/sax/source/tools/converter.cxx
index 818d04a9bd1a..09156a0a9405 100644
--- a/sax/source/tools/converter.cxx
+++ b/sax/source/tools/converter.cxx
@@ -42,7 +42,6 @@
using namespace com::sun::star;
using namespace com::sun::star::uno;
using namespace com::sun::star::util;
-using namespace ::com::sun::star::i18n;
namespace sax {
commit 2f068b2182955362526641da3b1e9f3207aab4b3
Author: Gabor Kelemen
AuthorDate: Fri Mar 29 13:31:26 2024 +0100
Commit: Gabor Kelemen
CommitDate: Sun Mar 31 09:41:07 2024 +0200
tdf#146619 Drop unused 'using namespace' in: unoxml/
Change-Id: I66da7093f1ccb144e2831c6e20220cbd27e58c46
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165518
Tested-by: Jenkins
Reviewed-by: Gabor Kelemen
diff --git a/unoxml/source/xpath/xpathapi.cxx b/unoxml/source/xpath/xpathapi.cxx
index c2b753783176..e20282565644 100644
--- a/unoxml/source/xpath/xpathapi.cxx
+++ b/unoxml/source/xpath/xpathapi.cxx
@@ -41,7 +41,6 @@
#include
#include
-using namespace css::io;
using namespace css::uno;
using namespace css::xml::dom;
using namespace css::xml::xpath;
core.git: sdext/IwyuFilter_sdext.yaml sdext/qa sdext/source
sdext/IwyuFilter_sdext.yaml|2 +-
sdext/qa/unit/pdfimport.cxx|1 -
sdext/source/minimizer/fileopendialog.cxx |1 -
sdext/source/minimizer/impoptimizer.cxx|1 -
sdext/source/minimizer/informationdialog.cxx |3 ---
sdext/source/minimizer/optimizerdialog.cxx |3 ---
sdext/source/minimizer/optimizerdialogcontrols.cxx |3 ---
sdext/source/minimizer/pagecollector.cxx |2 --
8 files changed, 1 insertion(+), 15 deletions(-)
New commits:
commit 3b85fd8a27edb7b9a0d92bad7969ef551d11450f
Author: Gabor Kelemen
AuthorDate: Fri Mar 29 14:01:43 2024 +0100
Commit: Gabor Kelemen
CommitDate: Sun Mar 31 19:22:57 2024 +0200
tdf#146619 Drop unused 'using namespace' in: sdext/
Change-Id: I8c5012958f6e59ec11c8a7bd52592e30cce4117a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165525
Tested-by: Jenkins
Reviewed-by: Gabor Kelemen
diff --git a/sdext/IwyuFilter_sdext.yaml b/sdext/IwyuFilter_sdext.yaml
index 9a0aaea804cc..2b00c256b4d2 100644
--- a/sdext/IwyuFilter_sdext.yaml
+++ b/sdext/IwyuFilter_sdext.yaml
@@ -1,5 +1,5 @@
---
-assumeFilename: sdext/source/presenter/PresenterSlideSorter.cxx
+assumeFilename: sdext/source/pdfimport/pdfiadaptor.cxx
excludelist:
sdext/source/pdfimport/odf/odfemitter.cxx:
# Actually in use
diff --git a/sdext/qa/unit/pdfimport.cxx b/sdext/qa/unit/pdfimport.cxx
index 18988d6845de..462edf2e7772 100644
--- a/sdext/qa/unit/pdfimport.cxx
+++ b/sdext/qa/unit/pdfimport.cxx
@@ -54,7 +54,6 @@
#include
#include
-using namespace ::pdfparse;
using namespace ::pdfi;
using namespace ::com::sun::star;
diff --git a/sdext/source/minimizer/fileopendialog.cxx
b/sdext/source/minimizer/fileopendialog.cxx
index 44dfb51bc74f..7ae877b13549 100644
--- a/sdext/source/minimizer/fileopendialog.cxx
+++ b/sdext/source/minimizer/fileopendialog.cxx
@@ -35,7 +35,6 @@ using namespace ::com::sun::star::uno;
using namespace ::com::sun::star::lang;
using namespace ::com::sun::star::beans;
using namespace ::com::sun::star::container;
-using namespace ::com::sun::star::view;
using namespace ::com::sun::star::ui::dialogs;
FileOpenDialog::FileOpenDialog( const Reference< XComponentContext >&
rxContext )
diff --git a/sdext/source/minimizer/impoptimizer.cxx
b/sdext/source/minimizer/impoptimizer.cxx
index c46617175e1c..abf54e296a77 100644
--- a/sdext/source/minimizer/impoptimizer.cxx
+++ b/sdext/source/minimizer/impoptimizer.cxx
@@ -63,7 +63,6 @@ using namespace ::com::sun::star::frame;
using namespace ::com::sun::star::beans;
using namespace ::com::sun::star::drawing;
using namespace ::com::sun::star::graphic;
-using namespace ::com::sun::star::document;
using namespace ::com::sun::star::container;
using namespace ::com::sun::star::presentation;
diff --git a/sdext/source/minimizer/informationdialog.cxx
b/sdext/source/minimizer/informationdialog.cxx
index caea0fc1d787..9872990a0f45 100644
--- a/sdext/source/minimizer/informationdialog.cxx
+++ b/sdext/source/minimizer/informationdialog.cxx
@@ -29,13 +29,10 @@
#include
using namespace ::com::sun::star;
-using namespace ::com::sun::star::ui;
using namespace ::com::sun::star::awt;
using namespace ::com::sun::star::uno;
using namespace ::com::sun::star::util;
using namespace ::com::sun::star::lang;
-using namespace ::com::sun::star::beans;
-using namespace ::com::sun::star::container;
static OUString ImpValueOfInMB( sal_Int64 rVal )
{
diff --git a/sdext/source/minimizer/optimizerdialog.cxx
b/sdext/source/minimizer/optimizerdialog.cxx
index 773970a41b05..7efef618af9b 100644
--- a/sdext/source/minimizer/optimizerdialog.cxx
+++ b/sdext/source/minimizer/optimizerdialog.cxx
@@ -47,13 +47,10 @@
using namespace ::com::sun::star::io;
using namespace ::com::sun::star::ui;
using namespace ::com::sun::star::awt;
-using namespace ::com::sun::star::ucb;
using namespace ::com::sun::star::uno;
using namespace ::com::sun::star::util;
-using namespace ::com::sun::star::lang;
using namespace ::com::sun::star::frame;
using namespace ::com::sun::star::beans;
-using namespace ::com::sun::star::container;
IntroPage::IntroPage(weld::Container* pPage, OptimizerDialog& rOptimizerDialog)
: vcl::OWizardPage(pPage, ,
"modules/simpress/ui/pmintropage.ui", "PMIntroPage")
diff --git a/sdext/source/minimizer/optimizerdialogcontrols.cxx
b/sdext/source/minimizer/optimizerdialogcontrols.cxx
index 5ed2dd942b7e..d2c4e49f3b95 100644
--- a/sdext/source/minimizer/optimizerdialogcontrols.cxx
+++ b/sdext/source/minimizer/optimizerdialogcontrols.cxx
@@ -37,10 +37,7 @@
#include
#include
-using namespace ::com::sun::star::awt;
using namespace ::com::sun::star::uno;
-using namespace ::com::sun::star::util;
-using namespace ::com::sun::star::lang;
using namespace ::com::sun::star::frame;
using namespace ::com::sun::star::beans;
using namespace ::com::sun::star::drawing;
diff --git
core.git: fpicker/source
fpicker/source/office/OfficeFilePicker.cxx |1 -
fpicker/source/office/OfficeFolderPicker.cxx |1 -
fpicker/source/office/fileview.cxx |1 -
fpicker/source/office/fpsmartcontent.cxx |1 -
fpicker/source/office/iodlg.cxx |1 -
fpicker/source/office/iodlgimp.cxx |2 --
6 files changed, 7 deletions(-)
New commits:
commit 193bb41859a8b29904685bc6c544809fcb4b8f50
Author: Gabor Kelemen
AuthorDate: Fri Mar 29 14:02:09 2024 +0100
Commit: Gabor Kelemen
CommitDate: Sun Mar 31 19:22:40 2024 +0200
tdf#146619 Drop unused 'using namespace' in: fpicker/
Change-Id: Ie090afbe19bffc493918ca19318ed16ac569bb83
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165526
Tested-by: Jenkins
Reviewed-by: Gabor Kelemen
diff --git a/fpicker/source/office/OfficeFilePicker.cxx
b/fpicker/source/office/OfficeFilePicker.cxx
index 723a8a279918..c0ba40632a0c 100644
--- a/fpicker/source/office/OfficeFilePicker.cxx
+++ b/fpicker/source/office/OfficeFilePicker.cxx
@@ -45,7 +45,6 @@ using namespace ::com::sun::star::ui::dialogs;
using namespace ::com::sun::star::uno;
using namespace ::com::sun::star::beans;
using namespace ::com::sun::star::awt;
-using namespace ::utl;
struct FilterEntry
diff --git a/fpicker/source/office/OfficeFolderPicker.cxx
b/fpicker/source/office/OfficeFolderPicker.cxx
index c941d6cb63c3..779bbffda7ad 100644
--- a/fpicker/source/office/OfficeFolderPicker.cxx
+++ b/fpicker/source/office/OfficeFolderPicker.cxx
@@ -30,7 +30,6 @@
using namespace ::com::sun::star::container;
using namespace ::com::sun::star::lang;
using namespace ::com::sun::star::uno;
-using namespace ::com::sun::star::beans;
SvtFolderPicker::SvtFolderPicker()
{
diff --git a/fpicker/source/office/fileview.cxx
b/fpicker/source/office/fileview.cxx
index 1fa1c4dafcd3..6a77f9154ac8 100644
--- a/fpicker/source/office/fileview.cxx
+++ b/fpicker/source/office/fileview.cxx
@@ -64,7 +64,6 @@
#include
#include "fileview.hxx"
-using namespace ::com::sun::star::lang;
using namespace ::com::sun::star::sdbc;
using namespace ::com::sun::star::task;
using namespace ::com::sun::star::ucb;
diff --git a/fpicker/source/office/fpsmartcontent.cxx
b/fpicker/source/office/fpsmartcontent.cxx
index 4cc504ddaa14..66f531ec5732 100644
--- a/fpicker/source/office/fpsmartcontent.cxx
+++ b/fpicker/source/office/fpsmartcontent.cxx
@@ -38,7 +38,6 @@ namespace svt
using namespace ::com::sun::star::uno;
using namespace ::com::sun::star::task;
using namespace ::com::sun::star::ucb;
-using namespace ::com::sun::star::lang;
using namespace ::com::sun::star::container;
diff --git a/fpicker/source/office/iodlg.cxx b/fpicker/source/office/iodlg.cxx
index b3e279f6b471..801bf0080917 100644
--- a/fpicker/source/office/iodlg.cxx
+++ b/fpicker/source/office/iodlg.cxx
@@ -81,7 +81,6 @@
using namespace ::com::sun::star::beans;
using namespace ::com::sun::star::ui::dialogs;
using namespace ::com::sun::star::uno;
-using namespace ::com::sun::star::lang;
using namespace ::com::sun::star::ucb;
using namespace ::com::sun::star::container;
using namespace ::com::sun::star::task;
diff --git a/fpicker/source/office/iodlgimp.cxx
b/fpicker/source/office/iodlgimp.cxx
index 5b2a67e38de5..1802d9c8d65b 100644
--- a/fpicker/source/office/iodlgimp.cxx
+++ b/fpicker/source/office/iodlgimp.cxx
@@ -33,8 +33,6 @@
#include
using namespace ::com::sun::star::uno;
-using namespace ::com::sun::star::lang;
-using namespace ::utl;
SvtFileDialogFilter_Impl::SvtFileDialogFilter_Impl( OUString aName, OUString
aType )
: m_aName(std::move( aName ))
core.git: vcl/unx
vcl/unx/gtk3/gtkframe.cxx | 22 +-
1 file changed, 17 insertions(+), 5 deletions(-)
New commits:
commit bee080ab7ca21d05de0519361a19724ef609a86b
Author: Caolán McNamara
AuthorDate: Sun Mar 31 18:11:42 2024 +0100
Commit: Caolán McNamara
CommitDate: Sun Mar 31 20:31:29 2024 +0200
Resolves: tdf#154072 no effect when clicking some dropdown buttons
when toolbar overflows.
A problem since:
commit b534ee2e972711af2dbaadf2190813054adda902
Date: Tue Nov 22 11:33:23 2022 +
Resolves: tdf#152155 use gtk's knowledge of relative widget positions
rather than effectively emulate it poorly
Change-Id: I18c08e43e9c0b642f2a30b5114d6f0a53f18a331
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165595
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/vcl/unx/gtk3/gtkframe.cxx b/vcl/unx/gtk3/gtkframe.cxx
index f44abeeeb78b..a1b7f619983d 100644
--- a/vcl/unx/gtk3/gtkframe.cxx
+++ b/vcl/unx/gtk3/gtkframe.cxx
@@ -3958,12 +3958,24 @@ void GtkSalFrame::signalRealize(GtkWidget*, gpointer
frame)
}
AbsoluteScreenPixelRectangle aFloatRect =
FloatingWindow::ImplConvertToAbsPos(pVclParent, pThis->m_aFloatRect);
-if
(gdk_window_get_window_type(widget_get_surface(pThis->m_pParent->m_pWindow)) !=
GDK_WINDOW_TOPLEVEL)
+switch
(gdk_window_get_window_type(widget_get_surface(pThis->m_pParent->m_pWindow)))
{
-// See tdf#152155 for an example
-gtk_coord nX(0), nY(0.0);
-gtk_widget_translate_coordinates(pThis->m_pParent->m_pWindow,
widget_get_toplevel(pThis->m_pParent->m_pWindow), 0, 0, , );
-aFloatRect.Move(nX, nY);
+case GDK_WINDOW_TOPLEVEL:
+break;
+case GDK_WINDOW_CHILD:
+{
+// See tdf#152155 for an example
+gtk_coord nX(0), nY(0.0);
+gtk_widget_translate_coordinates(pThis->m_pParent->m_pWindow,
widget_get_toplevel(pThis->m_pParent->m_pWindow), 0, 0, , );
+aFloatRect.Move(nX, nY);
+break;
+}
+default:
+{
+// See tdf#154072 for an example
+aFloatRect.Move(-pThis->m_pParent->maGeometry.x(),
-pThis->m_pParent->maGeometry.y());
+break;
+}
}
GdkRectangle rect {static_cast(aFloatRect.Left()),
static_cast(aFloatRect.Top()),
core.git: Branch 'libreoffice-24-2' - toolkit/source
toolkit/source/awt/vclxmenu.cxx | 23 +--
1 file changed, 21 insertions(+), 2 deletions(-)
New commits:
commit 161bcfa1c8687570acde0947b0350c70e7021d85
Author: Caolán McNamara
AuthorDate: Sat Mar 30 20:56:37 2024 +
Commit: Adolfo Jayme Barrientos
CommitDate: Sun Mar 31 20:49:32 2024 +0200
Resolves: tdf#157258 "Always autocorrect to" deletes the word
instead of replacing it, affecting extensions like Grammalecte,
LanguageTool, Antidote
this began in:
commit afa35742a4633db31b6d6c72cf45741506e9edfb
Date: Sat Dec 11 21:09:39 2021 +
prefer more css::awt::XPopupMenu api
but the underlying trap was introduced in:
commit 6c84dc18062ec6aad71fd65a409373c274402991
Date: Wed Oct 6 10:16:39 2010 +0100
initial commit for vba blob ( not including container_control stuff )
which added creating a VCLXPopupMenu in VCLXMenu::getPopupMenu if there
was a vcl PopupMenu in the vcl Menu which hadn't been created by calling
VCLXMenu::setPopupMenu. That didn't take into account that VCLXPopupMenu
(like VCLXMenu) takes ownership of the PopupMenu and will destroy it in
its own dtor, so the sub menu Popup get destroyed if the VCLXPopupMenu
is shorter lived than the VCLXMenu wrapping the parent Menu.
Change-Id: Ic28c27670d846ee9d2ff77d834e43fc157924eb6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165484
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos
diff --git a/toolkit/source/awt/vclxmenu.cxx b/toolkit/source/awt/vclxmenu.cxx
index 20d3d5d2d18a..6515258861b4 100644
--- a/toolkit/source/awt/vclxmenu.cxx
+++ b/toolkit/source/awt/vclxmenu.cxx
@@ -413,11 +413,30 @@ css::uno::Reference< css::awt::XPopupMenu >
VCLXMenu::getPopupMenu(
break;
}
}
-// it seems the popup menu is not insert into maPopupMenuRefs
-// if the popup men is not created by stardiv.Toolkit.VCLXPopupMenu
+/*
+ If the popup menu is not inserted via setPopupMenu then
+ maPopupMenuRefs won't have an entry for it, so create an XPopupMenu
+ for it now.
+
+ This means that this vcl PopupMenu "pMenu" either existed as a child
+ of the vcl Menu "mpMenu" before the VCLXMenu was created for that or
+ it was added directly via vcl.
+*/
if( !aRef.is() )
{
aRef = new VCLXPopupMenu( static_cast(pMenu) );
+/*
+ In any case, the VCLXMenu has ownership of "mpMenu" and will
+ destroy it in the VCLXMenu dtor.
+
+ Similarly because VCLXPopupMenu takes ownership of the vcl
+ PopupMenu "pMenu", the underlying vcl popup will be destroyed
+ when VCLXPopupMenu is, so we should add it now to
+ maPopupMenuRefs to ensure its lifecycle is at least bound to
+ the VCLXMenu that owns the parent "mpMenu" similarly to
+ PopupMenus added via the more conventional setPopupMenu.
+*/
+maPopupMenuRefs.push_back( aRef );
}
}
return aRef;
core.git: Branch 'libreoffice-24-2' - vcl/unx
vcl/unx/gtk3/gtkframe.cxx | 22 +-
1 file changed, 17 insertions(+), 5 deletions(-)
New commits:
commit f409cc5d0c671d0428f709523238f551f9a5fd69
Author: Caolán McNamara
AuthorDate: Sun Mar 31 18:11:42 2024 +0100
Commit: Adolfo Jayme Barrientos
CommitDate: Sun Mar 31 20:44:54 2024 +0200
Resolves: tdf#154072 no effect when clicking some dropdown buttons
when toolbar overflows.
A problem since:
commit b534ee2e972711af2dbaadf2190813054adda902
Date: Tue Nov 22 11:33:23 2022 +
Resolves: tdf#152155 use gtk's knowledge of relative widget positions
rather than effectively emulate it poorly
Change-Id: I18c08e43e9c0b642f2a30b5114d6f0a53f18a331
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165610
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos
diff --git a/vcl/unx/gtk3/gtkframe.cxx b/vcl/unx/gtk3/gtkframe.cxx
index f996b4359b1d..8c097c526c5b 100644
--- a/vcl/unx/gtk3/gtkframe.cxx
+++ b/vcl/unx/gtk3/gtkframe.cxx
@@ -3953,12 +3953,24 @@ void GtkSalFrame::signalRealize(GtkWidget*, gpointer
frame)
}
AbsoluteScreenPixelRectangle aFloatRect =
FloatingWindow::ImplConvertToAbsPos(pVclParent, pThis->m_aFloatRect);
-if
(gdk_window_get_window_type(widget_get_surface(pThis->m_pParent->m_pWindow)) !=
GDK_WINDOW_TOPLEVEL)
+switch
(gdk_window_get_window_type(widget_get_surface(pThis->m_pParent->m_pWindow)))
{
-// See tdf#152155 for an example
-gtk_coord nX(0), nY(0.0);
-gtk_widget_translate_coordinates(pThis->m_pParent->m_pWindow,
widget_get_toplevel(pThis->m_pParent->m_pWindow), 0, 0, , );
-aFloatRect.Move(nX, nY);
+case GDK_WINDOW_TOPLEVEL:
+break;
+case GDK_WINDOW_CHILD:
+{
+// See tdf#152155 for an example
+gtk_coord nX(0), nY(0.0);
+gtk_widget_translate_coordinates(pThis->m_pParent->m_pWindow,
widget_get_toplevel(pThis->m_pParent->m_pWindow), 0, 0, , );
+aFloatRect.Move(nX, nY);
+break;
+}
+default:
+{
+// See tdf#154072 for an example
+aFloatRect.Move(-pThis->m_pParent->maGeometry.x(),
-pThis->m_pParent->maGeometry.y());
+break;
+}
}
GdkRectangle rect {static_cast(aFloatRect.Left()),
static_cast(aFloatRect.Top()),
core.git: Branch 'libreoffice-24-2' - vcl/source
vcl/source/treelist/iconviewimpl.cxx |1 +
1 file changed, 1 insertion(+)
New commits:
commit 57428bfc71762687594c3c0fa62cdff391dda3f9
Author: Caolán McNamara
AuthorDate: Sat Mar 30 21:25:51 2024 +
Commit: Adolfo Jayme Barrientos
CommitDate: Sun Mar 31 20:46:35 2024 +0200
Resolves: tdf#157587 IconView scoll range not updated
IconView::SetUpdateMode(true) doesn't update the scroll
range for any changes that might have taken place while
updates were suspended.
The similar SvImpLBox::UpdateAll() for "normal" lists
does this update, so do the equivalent update here too.
Noticeable since:
commit 666925f2ab06e690c41c470713dc83f2d752bfb7
Date: Sat Jun 3 15:23:15 2023 +0100
perf: use freeze/thaw around block insert of multiple icons
Change-Id: I318fc4509c6906161eabf3b312f311cb97ac063a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165485
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos
diff --git a/vcl/source/treelist/iconviewimpl.cxx
b/vcl/source/treelist/iconviewimpl.cxx
index 048e193d4f4b..35025d1c81f4 100644
--- a/vcl/source/treelist/iconviewimpl.cxx
+++ b/vcl/source/treelist/iconviewimpl.cxx
@@ -467,6 +467,7 @@ void IconViewImpl::SyncVerThumb()
void IconViewImpl::UpdateAll()
{
FindMostRight();
+AdjustScrollBars(m_aOutputSize);
SyncVerThumb();
FillView();
ShowVerSBar();
core.git: sfx2/source
sfx2/source/doc/SfxDocumentMetaData.cxx | 391
1 file changed, 197 insertions(+), 194 deletions(-)
New commits:
commit 35fbe29161871b107f0aabf810a2537df378374d
Author: Noel Grandin
AuthorDate: Sat Mar 30 21:11:09 2024 +0200
Commit: Noel Grandin
CommitDate: Sun Mar 31 08:21:20 2024 +0200
Convert SfxDocumentMetaData to comphelper::WeakComponentImplHelper
Change-Id: Ib633595008224ff11486e9ff72b6801d2dbfb887
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165580
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sfx2/source/doc/SfxDocumentMetaData.cxx
b/sfx2/source/doc/SfxDocumentMetaData.cxx
index 35f769dd14a5..7ebd0842e092 100644
--- a/sfx2/source/doc/SfxDocumentMetaData.cxx
+++ b/sfx2/source/doc/SfxDocumentMetaData.cxx
@@ -20,7 +20,7 @@
#include
#include
-#include
+#include
#include
#include
#include
@@ -67,7 +67,6 @@
#include
#include
#include
-#include
#include
#include
#include
@@ -122,7 +121,7 @@ namespace {
typedef std::vector > >
AttrVector;
-typedef ::cppu::WeakComponentImplHelper<
+typedef ::comphelper::WeakComponentImplHelper<
css::lang::XServiceInfo,
css::document::XDocumentProperties2,
css::lang::XInitialization,
@@ -132,7 +131,6 @@ typedef ::cppu::WeakComponentImplHelper<
SfxDocumentMetaData_Base;
class SfxDocumentMetaData:
-private ::cppu::BaseMutex,
public SfxDocumentMetaData_Base
{
public:
@@ -149,7 +147,7 @@ public:
getSupportedServiceNames() override;
// css::lang::XComponent:
-virtual void SAL_CALL dispose() override;
+virtual void disposing(std::unique_lock& rGuard) override;
// css::document::XDocumentProperties:
virtual OUString SAL_CALL getAuthor() override;
@@ -257,7 +255,7 @@ protected:
const css::uno::Reference< css::uno::XComponentContext > m_xContext;
/// for notification
-::comphelper::OInterfaceContainerHelper3
m_NotifyListeners;
+::comphelper::OInterfaceContainerHelper4
m_NotifyListeners;
/// flag: false means not initialized yet, or disposed
bool m_isInitialized;
/// flag
@@ -284,38 +282,42 @@ protected:
OUString m_DefaultTarget;
/// check if we are initialized properly
-void checkInit() const;
+void checkInit(std::unique_lock& rGuard) const;
/// initialize state from given DOM tree
-void init(const css::uno::Reference& i_xDom);
+void init(std::unique_lock& rGuard, const
css::uno::Reference& i_xDom);
/// update element in DOM tree
-void updateElement(const OUString & i_name,
+void updateElement(std::unique_lock& rGuard,
+const OUString & i_name,
std::vector >* i_pAttrs = nullptr);
/// update user-defined meta data and attributes in DOM tree
-void updateUserDefinedAndAttributes();
+void updateUserDefinedAndAttributes(std::unique_lock& rGuard);
/// create empty DOM tree (XDocument)
css::uno::Reference createDOM() const;
/// extract base URL (necessary for converting relative links)
css::uno::Reference getURLProperties(
+std::unique_lock& rGuard,
const css::uno::Sequence & i_rMedium) const;
/// get text of standard meta data element
-OUString getMetaText(const char* i_name) const;
+OUString getMetaText(std::unique_lock& rGuard, const char*
i_name) const;
/// set text of standard meta data element iff not equal to existing text
-bool setMetaText(const OUString& i_name,
+bool setMetaText(std::unique_lock& g, const OUString& i_name,
const OUString & i_rValue);
/// set text of standard meta data element iff not equal to existing text
void setMetaTextAndNotify(const OUString& i_name,
const OUString & i_rValue);
/// get text of standard meta data element's attribute
-OUString getMetaAttr(const OUString& i_name,
+OUString getMetaAttr(std::unique_lock& rGuard,
+const OUString& i_name,
const OUString& i_attr) const;
/// get text of a list of standard meta data elements (multiple occ.)
css::uno::Sequence< OUString > getMetaList(
+std::unique_lock& rGuard,
const char* i_name) const;
/// set text of a list of standard meta data elements (multiple occ.)
-bool setMetaList(const OUString& i_name,
+bool setMetaList(std::unique_lock& rGuard, const OUString&
i_name,
const css::uno::Sequence< OUString > & i_rValue,
AttrVector const*);
-void createUserDefined();
+void createUserDefined(std::unique_lock& rGuard);
};
typedef ::cppu::ImplInheritanceHelper< SfxDocumentMetaData,
css::document::XCompatWriterDocProperties > CompatWriterDocPropsImpl_BASE;
@@ -606,6 +608,7 @@ OUString durationToText(sal_Int32 i_value) noexcept
// extract base URL (necessary for converting relative links)
css::uno::Reference< css::beans::XPropertySet >
SfxDocumentMetaData::getURLProperties(
+
core.git: vcl/qt5 vcl/source vcl/unx
vcl/qt5/QtAccessibleWidget.cxx |1 -
vcl/source/app/svdata.cxx |2 --
vcl/source/cnttype/mcnttfactory.cxx |1 -
vcl/source/control/fmtfield.cxx |1 -
vcl/source/filter/FilterConfigItem.cxx |1 -
vcl/source/font/fontmetric.cxx |1 -
vcl/source/gdi/configsettings.cxx |1 -
vcl/source/gdi/oldprintadaptor.cxx |1 -
vcl/source/helper/displayconnectiondispatch.cxx |1 -
vcl/source/helper/svtaccessiblefactory.cxx |1 -
vcl/source/window/accessibility.cxx |1 -
vcl/source/window/printdlg.cxx |1 -
vcl/source/window/stacking.cxx |1 -
vcl/source/window/syswin.cxx|1 -
vcl/unx/generic/app/i18n_im.cxx |2 --
vcl/unx/generic/dtrans/X11_clipboard.cxx|1 -
vcl/unx/generic/dtrans/X11_service.cxx |1 -
vcl/unx/generic/dtrans/X11_transferable.cxx |2 --
vcl/unx/generic/dtrans/config.cxx |1 -
vcl/unx/generic/fontmanager/fontconfig.cxx |1 -
vcl/unx/generic/fontmanager/fontmanager.cxx |3 ---
vcl/unx/generic/printer/cpdmgr.cxx |1 -
22 files changed, 27 deletions(-)
New commits:
commit da4f91bd4042f2c0ddd65c76d4ad5c35dbf3e1aa
Author: Gabor Kelemen
AuthorDate: Fri Mar 29 14:00:41 2024 +0100
Commit: Gabor Kelemen
CommitDate: Sun Mar 31 11:31:09 2024 +0200
tdf#146619 Drop unused 'using namespace' in: vcl/
Change-Id: Id25d5e3dbf84dea1f9aca5a6ec921d30cbe84bf7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165524
Tested-by: Jenkins
Reviewed-by: Gabor Kelemen
diff --git a/vcl/qt5/QtAccessibleWidget.cxx b/vcl/qt5/QtAccessibleWidget.cxx
index 790e200929b1..4065e6ca2307 100644
--- a/vcl/qt5/QtAccessibleWidget.cxx
+++ b/vcl/qt5/QtAccessibleWidget.cxx
@@ -58,7 +58,6 @@
using namespace css;
using namespace css::accessibility;
-using namespace css::beans;
using namespace css::uno;
QtAccessibleWidget::QtAccessibleWidget(const Reference
xAccessible, QObject* pObject)
diff --git a/vcl/source/app/svdata.cxx b/vcl/source/app/svdata.cxx
index e919bfda7c3d..26bf023ce848 100644
--- a/vcl/source/app/svdata.cxx
+++ b/vcl/source/app/svdata.cxx
@@ -57,8 +57,6 @@
#include
using namespace com::sun::star::uno;
-using namespace com::sun::star::lang;
-using namespace com::sun::star::awt;
namespace
{
diff --git a/vcl/source/cnttype/mcnttfactory.cxx
b/vcl/source/cnttype/mcnttfactory.cxx
index 4a3e6fbb4d95..de8f3489d95a 100644
--- a/vcl/source/cnttype/mcnttfactory.cxx
+++ b/vcl/source/cnttype/mcnttfactory.cxx
@@ -22,7 +22,6 @@
#include "mcnttfactory.hxx"
#include "mcnttype.hxx"
-using namespace ::osl;
using namespace ::cppu;
using namespace com::sun::star::uno;
using namespace com::sun::star::lang;
diff --git a/vcl/source/control/fmtfield.cxx b/vcl/source/control/fmtfield.cxx
index e8b02a29c111..b8c561e206b3 100644
--- a/vcl/source/control/fmtfield.cxx
+++ b/vcl/source/control/fmtfield.cxx
@@ -45,7 +45,6 @@
#include
using namespace ::com::sun::star::lang;
-using namespace ::com::sun::star::util;
// hmm. No support for regular expression. Well, I always (not really :)
wanted to write a finite automat
// so here comes a finite automat ...
diff --git a/vcl/source/filter/FilterConfigItem.cxx
b/vcl/source/filter/FilterConfigItem.cxx
index 41eaac04e1d4..5137a2f87016 100644
--- a/vcl/source/filter/FilterConfigItem.cxx
+++ b/vcl/source/filter/FilterConfigItem.cxx
@@ -39,7 +39,6 @@ using namespace ::com::sun::star::lang ; //
XMultiServiceFactory
using namespace ::com::sun::star::beans ; // PropertyValue
using namespace ::com::sun::star::uno ; // Reference
using namespace ::com::sun::star::util ; // XChangesBatch
-using namespace ::com::sun::star::awt ; // Size
using namespace ::com::sun::star::container ;
using namespace ::com::sun::star::configuration;
using namespace ::com::sun::star::task ; // XStatusIndicator
diff --git a/vcl/source/font/fontmetric.cxx b/vcl/source/font/fontmetric.cxx
index 3c6e5be96f8a..6ce4b1309e43 100644
--- a/vcl/source/font/fontmetric.cxx
+++ b/vcl/source/font/fontmetric.cxx
@@ -40,7 +40,6 @@
using namespace ::com::sun::star;
using namespace ::com::sun::star::uno;
using namespace ::rtl;
-using namespace ::utl;
FontMetric::FontMetric()
: mnAscent( 0 ),
diff --git a/vcl/source/gdi/configsettings.cxx
b/vcl/source/gdi/configsettings.cxx
index 5586f67a610a..b39adbf54118 100644
--- a/vcl/source/gdi/configsettings.cxx
+++ b/vcl/source/gdi/configsettings.cxx
@@ -30,7 +30,6 @@
using namespace utl;
using namespace vcl;
using namespace com::sun::star::uno;
-using namespace com::sun::star::lang;
using namespace com::sun::star::beans;
using namespace com::sun::star::container;
diff --git a/vcl/source/gdi/oldprintadaptor.cxx
core.git: 2 commits - toolkit/source
toolkit/source/awt/vclxtoolkit.cxx | 160 --
toolkit/source/controls/grid/sortablegriddatamodel.cxx | 252 +
2 files changed, 211 insertions(+), 201 deletions(-)
New commits:
commit d4bcb8b4fb23a62e3b75a686263006c47ad8c04b
Author: Noel Grandin
AuthorDate: Wed Mar 27 15:25:34 2024 +0200
Commit: Noel Grandin
CommitDate: Sun Mar 31 13:03:24 2024 +0200
convert SortableGridDataModel to comphelper::WeakComponentImplHelper
Change-Id: If399c0fb6b82672edccbefa2b980737ccca98c30
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165546
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/toolkit/source/controls/grid/sortablegriddatamodel.cxx
b/toolkit/source/controls/grid/sortablegriddatamodel.cxx
index 5eac49f47550..2d5056a8a0ab 100644
--- a/toolkit/source/controls/grid/sortablegriddatamodel.cxx
+++ b/toolkit/source/controls/grid/sortablegriddatamodel.cxx
@@ -30,11 +30,10 @@
#include
#include
-#include
-#include
+#include
+#include
#include
#include
-#include
#include
#include
#include
@@ -52,16 +51,14 @@ using namespace css::uno;
namespace {
class SortableGridDataModel;
-class MethodGuard;
-typedef ::cppu::WeakComponentImplHelper<
css::awt::grid::XSortableMutableGridDataModel
+typedef ::comphelper::WeakComponentImplHelper<
css::awt::grid::XSortableMutableGridDataModel
, css::lang::XServiceInfo
, css::lang::XInitialization
> SortableGridDataModel_Base;
typedef ::cppu::ImplHelper1 < css::awt::grid::XGridDataListener
> SortableGridDataModel_PrivateBase;
-class SortableGridDataModel :public ::cppu::BaseMutex
-,public SortableGridDataModel_Base
+class SortableGridDataModel :public SortableGridDataModel_Base
,public SortableGridDataModel_PrivateBase
{
public:
@@ -103,7 +100,7 @@ public:
virtual css::uno::Sequence< css::uno::Any > SAL_CALL getRowData(
::sal_Int32 RowIndex ) override;
// OComponentHelper
-virtual void SAL_CALL disposing() override;
+virtual void disposing(std::unique_lock& rGuard) override;
// XCloneable
virtual css::uno::Reference< css::util::XCloneable > SAL_CALL createClone(
) override;
@@ -139,7 +136,7 @@ private:
@throws css::lang::IndexOutOfBoundsException
if the given index does not denote a valid row
*/
-::sal_Int32 impl_getPrivateRowIndex_throw( ::sal_Int32 const
i_publicRowIndex ) const;
+::sal_Int32 impl_getPrivateRowIndex_throw( std::unique_lock&
rGuard, ::sal_Int32 const i_publicRowIndex ) const;
/** translates the given private row index to a public one
*/
@@ -155,7 +152,7 @@ private:
Neither m_currentSortColumn nor
m_sortAscending are touched by this method.
Also, the given column index is not checked, this is the
responsibility of the caller.
*/
-boolimpl_reIndex_nothrow( ::sal_Int32 const i_columnIndex, bool const
i_sortAscending );
+boolimpl_reIndex_nothrow( std::unique_lock& rGuard,
::sal_Int32 const i_columnIndex, bool const i_sortAscending );
/** translates the given event, obtained from our delegator, to a version
which can be broadcasted to our own
clients.
@@ -168,7 +165,7 @@ private:
voidimpl_broadcast(
void ( SAL_CALL
css::awt::grid::XGridDataListener::*i_listenerMethod )( const
css::awt::grid::GridDataEvent & ),
css::awt::grid::GridDataEvent const & i_publicEvent,
-MethodGuard& i_instanceLock
+std::unique_lock& i_instanceLock
);
/** rebuilds our indexes, notifying row removal and row addition events
@@ -178,16 +175,22 @@ private:
Only to be called when we're sorted.
*/
-voidimpl_rebuildIndexesAndNotify( MethodGuard& i_instanceLock );
+voidimpl_rebuildIndexesAndNotify( std::unique_lock&
i_instanceLock );
/** removes the current sorting, and notifies a change of all data
*/
-voidimpl_removeColumnSort( MethodGuard& i_instanceLock );
+voidimpl_removeColumnSort( std::unique_lock&
i_instanceLock );
/** removes the current sorting, without any broadcast
*/
voidimpl_removeColumnSort_noBroadcast();
+void throwIfNotInitialized()
+{
+if (!isInitialized())
+throw css::lang::NotInitializedException( OUString(), *this );
+}
+
private:
css::uno::Reference< css::uno::XComponentContext >m_xContext;
bool
m_isInitialized;
@@ -197,17 +200,7 @@ private:
boolm_sortAscending;
::std::vector< ::sal_Int32 >
core.git: 2 commits - vcl/skia
vcl/skia/gdiimpl.cxx| 15 ---
vcl/skia/win/gdiimpl.cxx| 31 +--
vcl/skia/x11/textrender.cxx | 10 +-
3 files changed, 26 insertions(+), 30 deletions(-)
New commits:
commit 2b427f319a7a95c48beda13913a067d24bd82cf8
Author: Mike Kaganski
AuthorDate: Sun Mar 31 10:57:43 2024 +0100
Commit: Mike Kaganski
CommitDate: Sun Mar 31 15:38:56 2024 +0200
Simplify a bit
And make font size calculations consistent between SkiaTextRender (x11)
and WinSkiaSalGraphicsImpl (win). They already did ~the same, the win
case just used an intermediate 'getHScale' coefficient.
Change-Id: I90ad4d9c49427465ef3263843b34bd9bc0d762eb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165488
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/vcl/skia/win/gdiimpl.cxx b/vcl/skia/win/gdiimpl.cxx
index 651f294add0e..0451307b7bdf 100644
--- a/vcl/skia/win/gdiimpl.cxx
+++ b/vcl/skia/win/gdiimpl.cxx
@@ -217,19 +217,21 @@ catch (const sal::systools::ComError& e)
bool WinSkiaSalGraphicsImpl::DrawTextLayout(const GenericSalLayout& rLayout)
{
assert(dynamic_cast(()));
-SkiaWinFontInstance* pWinFont =
static_cast(());
-const HFONT hLayoutFont = pWinFont->GetHFONT();
-double hScale = pWinFont->getHScale();
+SkiaWinFontInstance& rWinFont =
static_cast(rLayout.GetFont());
+const vcl::font::FontSelectPattern& rFSD = rWinFont.GetFontSelectPattern();
+if (rFSD.mnHeight == 0)
+return false;
+const HFONT hLayoutFont = rWinFont.GetHFONT();
LOGFONTW logFont;
if (GetObjectW(hLayoutFont, sizeof(logFont), ) == 0)
{
assert(false);
return false;
}
-sk_sp typeface = pWinFont->GetSkiaTypeface();
+sk_sp typeface = rWinFont.GetSkiaTypeface();
if (!typeface)
{
-typeface = createDirectWriteTypeface(pWinFont);
+typeface = createDirectWriteTypeface();
bool dwrite = true;
if (!typeface) // fall back to GDI text rendering
{
@@ -250,7 +252,7 @@ bool WinSkiaSalGraphicsImpl::DrawTextLayout(const
GenericSalLayout& rLayout)
return false;
}
// Cache the typeface.
-pWinFont->SetSkiaTypeface(typeface, dwrite);
+rWinFont.SetSkiaTypeface(typeface, dwrite);
}
SkFont font(typeface);
@@ -267,21 +269,14 @@ bool WinSkiaSalGraphicsImpl::DrawTextLayout(const
GenericSalLayout& rLayout)
font.setEdging(logFont.lfQuality == NONANTIALIASED_QUALITY ?
SkFont::Edging::kAlias
:
ePreferredAliasing);
-const vcl::font::FontSelectPattern& rFSD =
pWinFont->GetFontSelectPattern();
-int nHeight = rFSD.mnHeight;
-int nWidth = rFSD.mnWidth ? rFSD.mnWidth : nHeight;
-if (nWidth == 0 || nHeight == 0)
-return false;
+double nHeight = rFSD.mnHeight;
+double nWidth = rFSD.mnWidth ? rFSD.mnWidth *
rWinFont.GetAverageWidthFactor() : nHeight;
font.setSize(nHeight);
-font.setScaleX(hScale);
+font.setScaleX(nWidth / nHeight);
-// Unlike with Freetype-based font handling, use height even in vertical
mode,
-// additionally multiply it by horizontal scale to get the proper
-// size and then scale the width back, otherwise the height would
-// not be correct. I don't know why this is inconsistent.
SkFont verticalFont(font);
-verticalFont.setSize(nHeight * hScale);
-verticalFont.setScaleX(1.0 / hScale);
+verticalFont.setSize(nWidth);
+verticalFont.setScaleX(nHeight / nWidth);
assert(dynamic_cast(mWinParent.GetImpl()));
SkiaSalGraphicsImpl* impl =
static_cast(mWinParent.GetImpl());
diff --git a/vcl/skia/x11/textrender.cxx b/vcl/skia/x11/textrender.cxx
index acc930e070e5..425710626fb5 100644
--- a/vcl/skia/x11/textrender.cxx
+++ b/vcl/skia/x11/textrender.cxx
@@ -51,10 +51,10 @@ void SkiaTextRender::DrawTextLayout(const GenericSalLayout&
rLayout, const SalGr
const FreetypeFontInstance& rInstance =
static_cast(rLayout.GetFont());
const FreetypeFont& rFont = rInstance.GetFreetypeFont();
const vcl::font::FontSelectPattern& rFSD =
rInstance.GetFontSelectPattern();
-int nHeight = rFSD.mnHeight;
-int nWidth = rFSD.mnWidth ? rFSD.mnWidth : nHeight;
-if (nWidth == 0 || nHeight == 0)
+if (rFSD.mnHeight == 0)
return;
+double nHeight = rFSD.mnHeight;
+double nWidth = rFSD.mnWidth ? rFSD.mnWidth : nHeight;
if (!fontManager)
{
@@ -65,7 +65,7 @@ void SkiaTextRender::DrawTextLayout(const GenericSalLayout&
rLayout, const SalGr
= SkFontMgr_createTypefaceFromFcPattern(fontManager,
rFont.GetFontOptions()->GetPattern());
SkFont font(typeface);
font.setSize(nHeight);
-font.setScaleX(1.0 * nWidth / nHeight);
+font.setScaleX(nWidth / nHeight);
if (rInstance.NeedsArtificialItalic())
font.setSkewX(-1.0 * ARTIFICIAL_ITALIC_SKEW);
if
core.git: toolkit/source
toolkit/source/awt/vclxmenu.cxx | 23 +--
1 file changed, 21 insertions(+), 2 deletions(-)
New commits:
commit 7f7a7cf0eca793a9efb8456f96ccfece07f6f9d9
Author: Caolán McNamara
AuthorDate: Sat Mar 30 20:56:37 2024 +
Commit: Caolán McNamara
CommitDate: Sun Mar 31 12:01:27 2024 +0200
Resolves: tdf#157258 "Always autocorrect to" deletes the word
instead of replacing it, affecting extensions like Grammalecte,
LanguageTool, Antidote
this began in:
commit afa35742a4633db31b6d6c72cf45741506e9edfb
Date: Sat Dec 11 21:09:39 2021 +
prefer more css::awt::XPopupMenu api
but the underlying trap was introduced in:
commit 6c84dc18062ec6aad71fd65a409373c274402991
Date: Wed Oct 6 10:16:39 2010 +0100
initial commit for vba blob ( not including container_control stuff )
which added creating a VCLXPopupMenu in VCLXMenu::getPopupMenu if there
was a vcl PopupMenu in the vcl Menu which hadn't been created by calling
VCLXMenu::setPopupMenu. That didn't take into account that VCLXPopupMenu
(like VCLXMenu) takes ownership of the PopupMenu and will destroy it in
its own dtor, so the sub menu Popup get destroyed if the VCLXPopupMenu
is shorter lived than the VCLXMenu wrapping the parent Menu.
Change-Id: Ic28c27670d846ee9d2ff77d834e43fc157924eb6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165582
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/toolkit/source/awt/vclxmenu.cxx b/toolkit/source/awt/vclxmenu.cxx
index 20d3d5d2d18a..6515258861b4 100644
--- a/toolkit/source/awt/vclxmenu.cxx
+++ b/toolkit/source/awt/vclxmenu.cxx
@@ -413,11 +413,30 @@ css::uno::Reference< css::awt::XPopupMenu >
VCLXMenu::getPopupMenu(
break;
}
}
-// it seems the popup menu is not insert into maPopupMenuRefs
-// if the popup men is not created by stardiv.Toolkit.VCLXPopupMenu
+/*
+ If the popup menu is not inserted via setPopupMenu then
+ maPopupMenuRefs won't have an entry for it, so create an XPopupMenu
+ for it now.
+
+ This means that this vcl PopupMenu "pMenu" either existed as a child
+ of the vcl Menu "mpMenu" before the VCLXMenu was created for that or
+ it was added directly via vcl.
+*/
if( !aRef.is() )
{
aRef = new VCLXPopupMenu( static_cast(pMenu) );
+/*
+ In any case, the VCLXMenu has ownership of "mpMenu" and will
+ destroy it in the VCLXMenu dtor.
+
+ Similarly because VCLXPopupMenu takes ownership of the vcl
+ PopupMenu "pMenu", the underlying vcl popup will be destroyed
+ when VCLXPopupMenu is, so we should add it now to
+ maPopupMenuRefs to ensure its lifecycle is at least bound to
+ the VCLXMenu that owns the parent "mpMenu" similarly to
+ PopupMenus added via the more conventional setPopupMenu.
+*/
+maPopupMenuRefs.push_back( aRef );
}
}
return aRef;
core.git: 2 commits - package/source svl/source
package/source/manifest/ManifestReader.cxx |1 - package/source/manifest/ManifestWriter.cxx |1 - svl/source/config/cjkoptions.cxx |2 -- svl/source/numbers/supservs.cxx|1 - svl/source/passwordcontainer/passwordcontainer.cxx |2 -- 5 files changed, 7 deletions(-) New commits: commit 35fbbbe12d101a626fcb1679cc6c0d79922a4cc3 Author: Gabor Kelemen AuthorDate: Fri Mar 29 14:00:11 2024 +0100 Commit: Gabor Kelemen CommitDate: Sun Mar 31 09:41:44 2024 +0200 tdf#146619 Drop unused 'using namespace' in: svl/ Change-Id: I5629f6d5940ebc76be72970606111459d21ee1fb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165523 Tested-by: Jenkins Reviewed-by: Gabor Kelemen diff --git a/svl/source/config/cjkoptions.cxx b/svl/source/config/cjkoptions.cxx index e43d379f7e66..3cc774e4268c 100644 --- a/svl/source/config/cjkoptions.cxx +++ b/svl/source/config/cjkoptions.cxx @@ -26,8 +26,6 @@ #include #include -using namespace ::com::sun::star::uno; - static void SvtCJKOptions_Load(); namespace SvtCJKOptions diff --git a/svl/source/numbers/supservs.cxx b/svl/source/numbers/supservs.cxx index 5a51158a2beb..e5402f0fdb06 100644 --- a/svl/source/numbers/supservs.cxx +++ b/svl/source/numbers/supservs.cxx @@ -34,7 +34,6 @@ using namespace ::com::sun::star::uno; using namespace ::com::sun::star::lang; using namespace ::com::sun::star::beans; using namespace ::com::sun::star::util; -using namespace ::utl; SvNumberFormatsSupplierServiceObject::SvNumberFormatsSupplierServiceObject(css::uno::Reference< css::uno::XComponentContext > _xORB) diff --git a/svl/source/passwordcontainer/passwordcontainer.cxx b/svl/source/passwordcontainer/passwordcontainer.cxx index 68afc328935d..4d93a8aa3a7e 100644 --- a/svl/source/passwordcontainer/passwordcontainer.cxx +++ b/svl/source/passwordcontainer/passwordcontainer.cxx @@ -43,11 +43,9 @@ #include #include -using namespace osl; using namespace utl; using namespace com::sun::star; using namespace com::sun::star::uno; -using namespace com::sun::star::registry; using namespace com::sun::star::lang; using namespace com::sun::star::task; using namespace com::sun::star::ucb; commit 9a5b67ea271afc4449638207eecc52e88a7a891e Author: Gabor Kelemen AuthorDate: Fri Mar 29 13:59:40 2024 +0100 Commit: Gabor Kelemen CommitDate: Sun Mar 31 09:41:32 2024 +0200 tdf#146619 Drop unused 'using namespace' in: package/ Change-Id: I635a5c4bc988bff5a99f7d8487eb7c0f67c15d0e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165522 Tested-by: Jenkins Reviewed-by: Gabor Kelemen diff --git a/package/source/manifest/ManifestReader.cxx b/package/source/manifest/ManifestReader.cxx index 2a60feff02d4..d21748889082 100644 --- a/package/source/manifest/ManifestReader.cxx +++ b/package/source/manifest/ManifestReader.cxx @@ -33,7 +33,6 @@ using namespace ::com::sun::star::uno; using namespace ::com::sun::star::beans; using namespace ::com::sun::star::io; using namespace ::com::sun::star::lang; -using namespace ::com::sun::star::registry; using namespace ::com::sun::star::packages; using namespace ::com::sun::star::xml::sax; diff --git a/package/source/manifest/ManifestWriter.cxx b/package/source/manifest/ManifestWriter.cxx index 5515cc26df07..e4a4b480dfbb 100644 --- a/package/source/manifest/ManifestWriter.cxx +++ b/package/source/manifest/ManifestWriter.cxx @@ -33,7 +33,6 @@ using namespace ::com::sun::star::uno; using namespace ::com::sun::star::beans; using namespace ::com::sun::star::io; using namespace ::com::sun::star::lang; -using namespace ::com::sun::star::registry; using namespace ::com::sun::star::packages; using namespace ::com::sun::star::xml::sax;
Re: [GSoC] Requesting feedback on the proposal
Sent with Proton Mail secure email. On Thursday, March 28th, 2024 at 7:47 PM, Sarper Akdemir wrote: > Hello Mohit, > > On 3/28/24 15:40, Mohit Marathe wrote: > > > I am excited to submit my proposal for the "Comments in sidebar" > > project as part of the Google Summer of Code program. I would be > > grateful if you could take the time to review it and provide me with > > some feedback. Here's my proposal: > > https://docs.google.com/document/d/1jg1gJGTuMa2iN3jk4D6g2TMtvL_KWpx46HXL_37kq-w/edit?usp=sharing > > Thanks for the proposal, added some comments inline. If anything is > unclear feel free to ask and poke me :) > > Not looking for exact answers there! Thanks for reviewing, and sorry for responding late as I was traveling. > Cheers, > Sarper > > -- > > Sarper Akdemir > > LibreOffice engineer > ––– > > allotropia logo > > allotropia software GmbH > Versmannstr. 4 > 20457 Hamburg > Germany > ––– > T +49 (0) 40 2093 4085 10 > > sarper.akdemir.ext...@allotropia.de > www.allotropia.de https://www.allotropia.de > > ––– > Registered office: Hamburg, Germany > Registration court Hamburg, HRB 165405 > Managing director: Thorsten Behrens > VAT-ID: DE 335606919 > –––
core.git: download.lst external/lcms2
download.lst |4 +--
external/lcms2/0001-Added-missing-export.patch.1 | 25 +++
external/lcms2/ExternalPackage_lcms2.mk |2 -
external/lcms2/UnpackedTarball_lcms2.mk |4 ++-
external/lcms2/c++17.patch.1 | 13 ---
5 files changed, 31 insertions(+), 17 deletions(-)
New commits:
commit c2db961ee69c4fe6a7f7162f2adf712651b6ffcc
Author: Taichi Haradaguchi <20001...@ymail.ne.jp>
AuthorDate: Tue Mar 26 16:49:26 2024 +0100
Commit: Taichi Haradaguchi <20001...@ymail.ne.jp>
CommitDate: Mon Apr 1 00:58:52 2024 +0200
lcms2: upgrade to 2.16
* backport 0001-Added-missing-export.patch to fix the Windows build.
* drop c++17.patch.1, which fixed uptream.
Change-Id: Ib658ba3067c35ca5cd1ccb7b3f0f2f3bc9f82a43
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165350
Tested-by: Jenkins
Reviewed-by: Taichi Haradaguchi <20001...@ymail.ne.jp>
diff --git a/download.lst b/download.lst
index 6e60d5f53234..c872b55c92df 100644
--- a/download.lst
+++ b/download.lst
@@ -364,8 +364,8 @@ LANGTAGREG_TARBALL :=
language-subtag-registry-2023-08-02.tar.bz2
# three static lines
# so that git cherry-pick
# will not run into conflicts
-LCMS2_SHA256SUM :=
b20cbcbd0f503433be2a4e81462106fa61050a35074dc24a4e356792d971ab39
-LCMS2_TARBALL := lcms2-2.15.tar.gz
+LCMS2_SHA256SUM :=
d873d34ad8b9b4cea010631f1a6228d2087475e4dc5e763eb81acc23d9d45a51
+LCMS2_TARBALL := lcms2-2.16.tar.gz
# three static lines
# so that git cherry-pick
# will not run into conflicts
diff --git a/external/lcms2/0001-Added-missing-export.patch.1
b/external/lcms2/0001-Added-missing-export.patch.1
new file mode 100644
index ..ad131e9533d3
--- /dev/null
+++ b/external/lcms2/0001-Added-missing-export.patch.1
@@ -0,0 +1,25 @@
+From f7b3c637c20508655f8b49935a4b556d52937b69 Mon Sep 17 00:00:00 2001
+From: Dirk Lemstra
+Date: Sun, 10 Dec 2023 20:31:32 +0100
+Subject: [PATCH] Added missing export.
+
+---
+ src/cmsvirt.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/src/cmsvirt.c b/src/cmsvirt.c
+index 3d662b2..6615604 100644
+--- a/src/cmsvirt.c
b/src/cmsvirt.c
+@@ -676,7 +676,7 @@ cmsHPROFILE CMSEXPORT cmsCreate_sRGBProfile(void)
+ *
+ * This virtual profile cannot be saved as an ICC file
+ */
+-cmsHPROFILE cmsCreate_OkLabProfile(cmsContext ctx)
++cmsHPROFILE CMSEXPORT cmsCreate_OkLabProfile(cmsContext ctx)
+ {
+ cmsStage* XYZPCS = _cmsStageNormalizeFromXyzFloat(ctx);
+ cmsStage* PCSXYZ = _cmsStageNormalizeToXyzFloat(ctx);
+--
+2.44.0.windows.1
+
diff --git a/external/lcms2/ExternalPackage_lcms2.mk
b/external/lcms2/ExternalPackage_lcms2.mk
index a2c051f6eb9a..62e2ebad8981 100644
--- a/external/lcms2/ExternalPackage_lcms2.mk
+++ b/external/lcms2/ExternalPackage_lcms2.mk
@@ -17,7 +17,7 @@ $(eval $(call
gb_ExternalPackage_add_file,lcms2,$(LIBO_LIB_FOLDER)/liblcms2.2.dy
else ifeq ($(COM),MSC)
$(eval $(call
gb_ExternalPackage_add_file,lcms2,$(LIBO_LIB_FOLDER)/lcms2.dll,bin/lcms2.dll))
else
-$(eval $(call
gb_ExternalPackage_add_file,lcms2,$(LIBO_LIB_FOLDER)/liblcms2.so.2,src/.libs/liblcms2.so.2.0.15))
+$(eval $(call
gb_ExternalPackage_add_file,lcms2,$(LIBO_LIB_FOLDER)/liblcms2.so.2,src/.libs/liblcms2.so.2.0.16))
endif
endif # $(DISABLE_DYNLOADING)
diff --git a/external/lcms2/UnpackedTarball_lcms2.mk
b/external/lcms2/UnpackedTarball_lcms2.mk
index 28b30ef3acee..745da1a0a782 100644
--- a/external/lcms2/UnpackedTarball_lcms2.mk
+++ b/external/lcms2/UnpackedTarball_lcms2.mk
@@ -15,10 +15,12 @@ $(eval $(call
gb_UnpackedTarball_update_autoconf_configs,lcms2))
$(eval $(call gb_UnpackedTarball_set_patchlevel,lcms2,3))
+# external/lcms2/0001-Added-missing-export.patch.1:
+# backport of
https://github.com/mm2/Little-CMS/commit/f7b3c637c20508655f8b49935a4b556d52937b69
$(eval $(call gb_UnpackedTarball_add_patches,lcms2,\
+ external/lcms2/0001-Added-missing-export.patch.1 \
external/lcms2/lcms2-2.4-windows.patch \
external/lcms2/lcms2-windows_aarch64_outdir.patch.1 \
- external/lcms2/c++17.patch.1 \
))
# vim: set noet sw=4 ts=4:
diff --git a/external/lcms2/c++17.patch.1 b/external/lcms2/c++17.patch.1
deleted file mode 100644
index dc5b2ccde46c..
--- a/external/lcms2/c++17.patch.1
+++ /dev/null
@@ -1,13 +0,0 @@
-diff --git a/include/lcms2.h b/include/lcms2.h
-index cf52014..926e2a0 100644
a/include/lcms2.h
-+++ b/include/lcms2.h
-@@ -62,7 +62,7 @@
- // #define CMS_RELY_ON_WINDOWS_STATIC_MUTEX_INIT
-
- // Uncomment this to remove the "register" storage class
--// #define CMS_NO_REGISTER_KEYWORD 1
-+#define CMS_NO_REGISTER_KEYWORD 1
-
- // ** End of configuration toggles **
-
core.git: Branch 'distro/collabora/co-23.05' - desktop/source sfx2/source
desktop/source/lib/init.cxx |2 ++
sfx2/source/control/unoctitm.cxx |2 ++
2 files changed, 4 insertions(+)
New commits:
commit f74a502670dc7b4cba3100df58ed0d07b6906c67
Author: Aron Budea
AuthorDate: Tue Mar 12 18:20:24 2024 +1030
Commit: Aron Budea
CommitDate: Mon Apr 1 02:18:18 2024 +0200
lok: Send Accept / RejectTrackedChangedToNext state change
Change-Id: I194c0c3260fe90273f5b5f50c18a63e48ae85449
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164699
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Aron Budea
(cherry picked from commit ee979fc26c6509e077be0b746d907d6e13619954)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165586
diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
index 323d0751cb6d..a81b0410d81e 100644
--- a/desktop/source/lib/init.cxx
+++ b/desktop/source/lib/init.cxx
@@ -3755,6 +3755,8 @@ static void doc_iniUnoCommands ()
OUString(".uno:ParaspaceDecrease"),
OUString(".uno:AcceptTrackedChange"),
OUString(".uno:RejectTrackedChange"),
+OUString(".uno:AcceptTrackedChangeToNext"),
+OUString(".uno:RejectTrackedChangeToNext"),
OUString(".uno:ShowResolvedAnnotations"),
OUString(".uno:InsertBreak"),
OUString(".uno:InsertEndnote"),
diff --git a/sfx2/source/control/unoctitm.cxx b/sfx2/source/control/unoctitm.cxx
index 10d2230007db..0e3a092cd8b3 100644
--- a/sfx2/source/control/unoctitm.cxx
+++ b/sfx2/source/control/unoctitm.cxx
@@ -1037,6 +1037,8 @@ static void InterceptLOKStateChangeEvent(sal_uInt16 nSID,
SfxViewFrame* pViewFra
aEvent.FeatureURL.Path == "RejectAllTrackedChanges" ||
aEvent.FeatureURL.Path == "AcceptTrackedChange" ||
aEvent.FeatureURL.Path == "RejectTrackedChange" ||
+ aEvent.FeatureURL.Path == "AcceptTrackedChangeToNext" ||
+ aEvent.FeatureURL.Path == "RejectTrackedChangeToNext" ||
aEvent.FeatureURL.Path == "NextTrackedChange" ||
aEvent.FeatureURL.Path == "PreviousTrackedChange" ||
aEvent.FeatureURL.Path == "FormatGroup" ||
core.git: svx/qa
svx/qa/unit/customshapes.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit b7d6f7e2ef4e89607d7886e821be977c50f11843 Author: Andrea Gelmini AuthorDate: Sun Mar 31 11:24:55 2024 +0200 Commit: Adolfo Jayme Barrientos CommitDate: Sun Mar 31 21:06:01 2024 +0200 Fix typo Change-Id: I606c3eb804cba508638ac401b35a8bea4e961807 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165588 Tested-by: Adolfo Jayme Barrientos Reviewed-by: Adolfo Jayme Barrientos diff --git a/svx/qa/unit/customshapes.cxx b/svx/qa/unit/customshapes.cxx index 92770e9f2320..f8df68fb3138 100644 --- a/svx/qa/unit/customshapes.cxx +++ b/svx/qa/unit/customshapes.cxx @@ -59,7 +59,7 @@ protected: uno::Reference getShape(sal_uInt8 nShapeIndex); sal_uInt8 countShapes(); // fX and fY are positions relative to the size of the bitmap of the shape -// Thus the position is indepedent from DPI +// Thus the position is independent from DPI Color getColor(uno::Reference xShape, const double& fX, const double& fY); };
core.git: Branch 'libreoffice-7-6' - ucb/source
ucb/source/ucp/webdav-curl/CurlSession.cxx | 15 +--
1 file changed, 5 insertions(+), 10 deletions(-)
New commits:
commit 780aeb304eaf6c90c18ca001e54708f5b6c78c0c
Author: Michael Stahl
AuthorDate: Thu Mar 14 15:47:28 2024 +0100
Commit: Caolán McNamara
CommitDate: Sun Mar 31 22:38:46 2024 +0200
ucb: webdav-curl: always set CURLOPT_NOBODY for HEAD
Otherwise there will be timeout that depends on when the server will
close the connection, which varies by server but can be several minutes;
getting a potential error document from the server for this one request
when logging is enabled is less important.
Change-Id: I505b014b148ba009c400d37d826c9edb8c3a6da2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164838
Tested-by: Jenkins
Reviewed-by: Michael Stahl
(cherry picked from commit c8400f5acc36d2cf0c007260bdc94534a53bba90)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164823
Reviewed-by: Caolán McNamara
diff --git a/ucb/source/ucp/webdav-curl/CurlSession.cxx
b/ucb/source/ucp/webdav-curl/CurlSession.cxx
index 1ca713337d60..260bfd97c446 100644
--- a/ucb/source/ucp/webdav-curl/CurlSession.cxx
+++ b/ucb/source/ucp/webdav-curl/CurlSession.cxx
@@ -165,15 +165,6 @@ struct CurlOption
}
};
-// NOBODY will prevent logging the response body in ProcessRequest() exception
-// handler, so only use it if logging is disabled
-const CurlOption g_NoBody{ CURLOPT_NOBODY,
- sal_detail_log_report(SAL_DETAIL_LOG_LEVEL_INFO,
"ucb.ucp.webdav.curl")
- == SAL_DETAIL_LOG_ACTION_IGNORE
- ? 1L
- : 0L,
- nullptr };
-
/// combined guard class to ensure things are released in correct order,
/// particularly in ProcessRequest() error handling
class Guard
@@ -1853,7 +1844,11 @@ auto CurlSession::HEAD(OUString const& rURIReference,
::std::vector co
CurlUri const uri(CurlProcessor::URIReferenceToURI(*this, rURIReference));
::std::vector const options{
-g_NoBody, { CURLOPT_CUSTOMREQUEST, "HEAD", "CURLOPT_CUSTOMREQUEST" }
+// NOBODY will prevent logging the response body in ProcessRequest()
+// exception, but omitting it here results in a long timeout until the
+// server closes the connection, which is worse
+{ CURLOPT_NOBODY, 1L, nullptr },
+{ CURLOPT_CUSTOMREQUEST, "HEAD", "CURLOPT_CUSTOMREQUEST" }
};
::std::pair<::std::vector const&, DAVResource&> const
headers(rHeaderNames,
core.git: Branch 'libreoffice-7-6' - 2 commits - ucb/source
ucb/source/ucp/webdav-curl/CurlSession.cxx | 24 +++-
1 file changed, 11 insertions(+), 13 deletions(-)
New commits:
commit 012aa0a6e454fd15f91ac89d98faa30339e145c1
Author: Michael Stahl
AuthorDate: Fri Mar 8 11:20:45 2024 +0100
Commit: Caolán McNamara
CommitDate: Sun Mar 31 22:38:38 2024 +0200
ucb: webdav-curl: only set CURLOPT_NOBODY for HEAD
Some testing with Apache httpd+mod_dav reveals that it usually sends a
body with a 401 status, which causes the CURLE_WEIRD_SERVER_REPLY error
code from curl.
So we should either ignore this error in case there's a HTTP status too,
or stop using CURLOPT_NOBODY.
The latter seems to have no downside, except for HEAD requests, where
strangely the server keeps the connection open and curl waits for 5
seconds for no body to arrive, blocking the UI, so continue to use
CURLOPT_NOBODY for HEAD.
The other methods don't seem to block.
It turns out that the SAL_LOG-dependent setting of g_NoBody turned HEAD
into GET anyway if logging is enabled, so explicitly set the method.
Change-Id: Ibe2eef8e7a827d4e356ba37c4b56bee0be3b9c13
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164569
Tested-by: Jenkins
Reviewed-by: Michael Stahl
(cherry picked from commit e0259d4c0951c4dd77c74d08b9d905728d4c8dfd)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164508
Reviewed-by: Caolán McNamara
diff --git a/ucb/source/ucp/webdav-curl/CurlSession.cxx
b/ucb/source/ucp/webdav-curl/CurlSession.cxx
index 34fb5438150e..1ca713337d60 100644
--- a/ucb/source/ucp/webdav-curl/CurlSession.cxx
+++ b/ucb/source/ucp/webdav-curl/CurlSession.cxx
@@ -1852,7 +1852,9 @@ auto CurlSession::HEAD(OUString const& rURIReference,
::std::vector co
CurlUri const uri(CurlProcessor::URIReferenceToURI(*this, rURIReference));
-::std::vector const options{ g_NoBody };
+::std::vector const options{
+g_NoBody, { CURLOPT_CUSTOMREQUEST, "HEAD", "CURLOPT_CUSTOMREQUEST" }
+};
::std::pair<::std::vector const&, DAVResource&> const
headers(rHeaderNames,
io_rResource);
@@ -2087,9 +2089,8 @@ auto CurlSession::MKCOL(OUString const& rURIReference,
DAVRequestEnvironment con
CurlUri const uri(CurlProcessor::URIReferenceToURI(*this, rURIReference));
-::std::vector const options{
-g_NoBody, { CURLOPT_CUSTOMREQUEST, "MKCOL", "CURLOPT_CUSTOMREQUEST" }
-};
+::std::vector const options{ { CURLOPT_CUSTOMREQUEST, "MKCOL",
+ "CURLOPT_CUSTOMREQUEST" } };
CurlProcessor::ProcessRequest(*this, uri, "MKCOL", options, ,
nullptr, nullptr, nullptr,
nullptr);
@@ -2117,9 +2118,8 @@ auto CurlProcessor::MoveOrCopy(CurlSession& rSession,
std::u16string_view rSourc
throw uno::RuntimeException("curl_slist_append failed");
}
-::std::vector const options{
-g_NoBody, { CURLOPT_CUSTOMREQUEST, pMethod, "CURLOPT_CUSTOMREQUEST" }
-};
+::std::vector const options{ { CURLOPT_CUSTOMREQUEST, pMethod,
+ "CURLOPT_CUSTOMREQUEST" } };
CurlProcessor::ProcessRequest(rSession, uriSource,
OUString::createFromAscii(pMethod), options,
, ::std::move(pList), nullptr, nullptr,
nullptr);
@@ -2149,9 +2149,8 @@ auto CurlSession::DESTROY(OUString const& rURIReference,
DAVRequestEnvironment c
CurlUri const uri(CurlProcessor::URIReferenceToURI(*this, rURIReference));
-::std::vector const options{
-g_NoBody, { CURLOPT_CUSTOMREQUEST, "DELETE", "CURLOPT_CUSTOMREQUEST" }
-};
+::std::vector const options{ { CURLOPT_CUSTOMREQUEST, "DELETE",
+ "CURLOPT_CUSTOMREQUEST" } };
CurlProcessor::ProcessRequest(*this, uri, "DESTROY", options, ,
nullptr, nullptr, nullptr,
nullptr);
commit fd9ad62bb93a44e3deadaef7f84f916c7ab19a51
Author: Michael Stahl
AuthorDate: Thu Mar 7 20:10:48 2024 +0100
Commit: Caolán McNamara
CommitDate: Sun Mar 31 22:38:29 2024 +0200
ucb: webdav-curl: don't set CURLOPT_NOBODY for OPTIONS
The problem is that if the server does send a body, then curl returns
CURLE_WEIRD_SERVER_REPLY error code, which is translated to
DAVException; this looks unnecessary now because write_callback
will just return if there's no stream to write to anyway.
Change-Id: Iddaee9778ac7bbd538b64584f822f65ab0e395c2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164550
Tested-by: Jenkins
Reviewed-by: Michael Stahl
(cherry picked from commit 980ca3953084560806cd980d2ec16951d9e30c2b)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164502
Reviewed-by: Caolán McNamara
diff --git
core.git: sc/source
sc/source/ui/StatisticsDialogs/RegressionDialog.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 069bf61cea5e3aea07ffd5a1bb9f55324651cb35
Author: Andrea Gelmini
AuthorDate: Sun Mar 31 11:25:36 2024 +0200
Commit: Taichi Haradaguchi <20001...@ymail.ne.jp>
CommitDate: Mon Apr 1 01:00:01 2024 +0200
Fix abbr.
Change-Id: Ia1f8f1527e76f2a721d42f6de11122f8c167bc96
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165589
Tested-by: Jenkins
Reviewed-by: Taichi Haradaguchi <20001...@ymail.ne.jp>
diff --git a/sc/source/ui/StatisticsDialogs/RegressionDialog.cxx
b/sc/source/ui/StatisticsDialogs/RegressionDialog.cxx
index 547866cf010c..2031bae10ff5 100644
--- a/sc/source/ui/StatisticsDialogs/RegressionDialog.cxx
+++ b/sc/source/ui/StatisticsDialogs/RegressionDialog.cxx
@@ -368,7 +368,7 @@ void
ScRegressionDialog::WriteRawRegressionResults(AddressWalkerWriter& rOutput,
mbCalcIntercept ?
std::u16string_view(u"TRUE") : std::u16string_view(u"FALSE")));
rOutput.writeMatrixFormula(rTemplate.getTemplate(), 1 +
mnNumIndependentVars, 5);
// Add LINEST result components to template
-// 1. Add ranges for coefficients and standard errors for indep. vars and
the intercept.
+// 1. Add ranges for coefficients and standard errors for independent vars
and the intercept.
// Note that these two are in the reverse order(m_n, m_n-1, ..., m_1, b)
w.r.t what we expect.
rTemplate.autoReplaceRange("%COEFFICIENTS_REV_RANGE%",
ScRange(rOutput.current(), rOutput.current(mnNumIndependentVars)));
rTemplate.autoReplaceRange("%SERRORSX_REV_RANGE%",
ScRange(rOutput.current(0, 1), rOutput.current(mnNumIndependentVars, 1)));
core.git: Branch 'libreoffice-24-2' - download.lst
download.lst |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit c3020e41cf95e974f0ff12c78ca841eb8cc4e9f3 Author: Xisco Fauli AuthorDate: Thu Mar 28 11:40:25 2024 +0100 Commit: Taichi Haradaguchi <20001...@ymail.ne.jp> CommitDate: Mon Apr 1 00:59:23 2024 +0200 curl: upgrade to release 8.7.1 Change-Id: I0064b4cf6baf1ccd951c95945539961fe72c2a28 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165455 Tested-by: Jenkins Reviewed-by: Xisco Fauli (cherry picked from commit 2c1a7cb13629177f824ed35138907aef10714e89) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165489 Reviewed-by: Taichi Haradaguchi <20001...@ymail.ne.jp> diff --git a/download.lst b/download.lst index 245cc68d424b..95ae9c41f3d4 100644 --- a/download.lst +++ b/download.lst @@ -80,8 +80,8 @@ CPPUNIT_TARBALL := cppunit-1.15.1.tar.gz # three static lines # so that git cherry-pick # will not run into conflicts -CURL_SHA256SUM := 3ccd55d91af9516539df80625f818c734dc6f2ecf9bada33c76765e99121db15 -CURL_TARBALL := curl-8.6.0.tar.xz +CURL_SHA256SUM := 6fea2aac6a4610fbd0400afb0bcddbe7258a64c63f1f68e5855ebc0c659710cd +CURL_TARBALL := curl-8.7.1.tar.xz # three static lines # so that git cherry-pick # will not run into conflicts
core.git: Branch 'libreoffice-24-2' - sw/qa sw/source
sw/qa/core/accessibilitycheck/AccessibilityCheckTest.cxx | 11 +++
sw/qa/core/accessibilitycheck/data/Tabs-in-TOC.odt |binary
sw/source/core/access/AccessibilityCheck.cxx |5 +
3 files changed, 16 insertions(+)
New commits:
commit 7a61065bb8ccf33fb1918218bf2febd30e786bf4
Author: Samuel Mehrbrodt
AuthorDate: Mon Mar 18 15:19:42 2024 +0100
Commit: Caolán McNamara
CommitDate: Sun Mar 31 22:37:34 2024 +0200
tdf#159918 a11y check: Don't warn about tabs in ToC
Change-Id: Ifde41deb66c8dcb72842e18e539609ff351be832
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164972
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt
(cherry picked from commit c6075e716200e9c6bae1b10be2cf10013958e83a)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165424
Reviewed-by: Caolán McNamara
diff --git a/sw/qa/core/accessibilitycheck/AccessibilityCheckTest.cxx
b/sw/qa/core/accessibilitycheck/AccessibilityCheckTest.cxx
index 117b48d01661..bfe2e08d8543 100644
--- a/sw/qa/core/accessibilitycheck/AccessibilityCheckTest.cxx
+++ b/sw/qa/core/accessibilitycheck/AccessibilityCheckTest.cxx
@@ -251,6 +251,17 @@ scanAccessibilityIssuesOnNodes(SwDoc* pDocument)
return aIssues;
}
+CPPUNIT_TEST_FIXTURE(AccessibilityCheckTest, testCheckTabsinTOC)
+{
+createSwDoc("Tabs-in-TOC.odt");
+SwDoc* pDoc = getSwDoc();
+CPPUNIT_ASSERT(pDoc);
+sw::AccessibilityCheck aCheck(pDoc);
+aCheck.check();
+auto& aIssues = aCheck.getIssueCollection().getIssues();
+CPPUNIT_ASSERT_EQUAL(size_t(0), aIssues.size());
+}
+
void checkIssuePosition(std::shared_ptr const&
pIssue, int nLine,
sal_Int32 nStart, sal_Int32 nEnd, SwNodeOffset nIndex)
{
diff --git a/sw/qa/core/accessibilitycheck/data/Tabs-in-TOC.odt
b/sw/qa/core/accessibilitycheck/data/Tabs-in-TOC.odt
new file mode 100644
index ..2b3ce54cc5a3
Binary files /dev/null and b/sw/qa/core/accessibilitycheck/data/Tabs-in-TOC.odt
differ
diff --git a/sw/source/core/access/AccessibilityCheck.cxx
b/sw/source/core/access/AccessibilityCheck.cxx
index e515b5cae7ed..dfa94c3ed9ab 100644
--- a/sw/source/core/access/AccessibilityCheck.cxx
+++ b/sw/source/core/access/AccessibilityCheck.cxx
@@ -901,6 +901,11 @@ public:
}
case ' ':
{
+// Don't warn about tabs in ToC
+auto pSection =
SwDoc::GetCurrSection(SwPosition(*pTextNode, 0));
+if (pSection && pSection->GetTOXBase())
+continue;
+
if (bPreviousWasChar)
{
++nTabCount;
core.git: vcl/unx
vcl/unx/gtk3/gtkinst.cxx | 77 ---
1 file changed, 40 insertions(+), 37 deletions(-)
New commits:
commit 601dc3ef9bd74b1948274c104c6c2ec877bc812c
Author: Caolán McNamara
AuthorDate: Sun Mar 31 11:32:22 2024 +0100
Commit: Caolán McNamara
CommitDate: Sun Mar 31 18:00:16 2024 +0200
Resolves: tdf#152438 constrain popups from MenuButtons with toplevel parent
if the toplevel parent is the application window, then under wayland
constrain the popup within the toplevel window, but allow it to escape
if the parent isn't the application, e.g. a dialog
Change-Id: I8d5c423a2c8e034464f110e51df04dee587f40dd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165590
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/vcl/unx/gtk3/gtkinst.cxx b/vcl/unx/gtk3/gtkinst.cxx
index f966496b9ff7..ea58dd62b659 100644
--- a/vcl/unx/gtk3/gtkinst.cxx
+++ b/vcl/unx/gtk3/gtkinst.cxx
@@ -10532,6 +10532,37 @@ void MoveWindowContentsToPopover(GtkWindow* pMenuHack,
GtkWidget* pPopover, GtkW
}
}
+// tdf#153885/tdf#152438 for wayland if the popover window is the application
+// window, constrain it within the application window so it won't be cut off
+// screen. Leave dialog hosted ones alone, like format, watermark, which are
+// likely presented in the middle of the screen and are too small to constrain
+// the popover inside.
+void ConstrainApplicationWindowPopovers(GtkWidget* pItem)
+{
+#if defined(GDK_WINDOWING_WAYLAND)
+GdkDisplay *pDisplay = gtk_widget_get_display(pItem);
+if (DLSYM_GDK_IS_WAYLAND_DISPLAY(pDisplay) && GTK_IS_MENU_BUTTON(pItem))
+{
+GtkMenuButton* pMenuButton = GTK_MENU_BUTTON(pItem);
+if (GtkPopover* pPopover = gtk_menu_button_get_popover(pMenuButton))
+{
+if (gtk_popover_get_constrain_to(pPopover) ==
GTK_POPOVER_CONSTRAINT_NONE)
+{
+GtkWidget* pTopLevel = widget_get_toplevel(pItem);
+GtkSalFrame* pFrame = pTopLevel ?
GtkSalFrame::getFromWindow(pTopLevel) : nullptr;
+if (pFrame)
+{
+// the toplevel is an application window
+gtk_popover_set_constrain_to(pPopover,
GTK_POPOVER_CONSTRAINT_WINDOW);
+}
+}
+}
+}
+#else
+(void)pItem;
+#endif
+}
+
#endif
/* four types of uses of this
@@ -10573,9 +10604,14 @@ private:
#endif
#if !GTK_CHECK_VERSION(4, 0, 0)
-static void signalMenuButtonToggled(GtkWidget*, gpointer widget)
+static void signalMenuButtonToggled(GtkWidget* pItem, gpointer widget)
{
GtkInstanceMenuButton* pThis =
static_cast(widget);
+if (!pThis->m_pMenuHack)
+{
+ConstrainApplicationWindowPopovers(pItem);
+return;
+}
SolarMutexGuard aGuard;
pThis->menu_toggled();
}
@@ -10584,8 +10620,6 @@ private:
#if !GTK_CHECK_VERSION(4, 0, 0)
void menu_toggled()
{
-if (!m_pMenuHack)
-return;
if (!get_active())
{
m_nButtonPressSeen = false;
@@ -10916,6 +10950,8 @@ public:
return;
}
+m_nSignalId = g_signal_connect(GTK_TOGGLE_BUTTON(m_pMenuButton),
"toggled", G_CALLBACK(signalMenuButtonToggled), this);
+
if (!m_pMenuHack)
{
//under wayland a Popover will work to "escape" the parent dialog,
not
@@ -10928,7 +10964,6 @@ public:
// See writer "format, watermark" for true here. Can't
interact with the replacement popover otherwise.
gtk_window_set_modal(m_pMenuHack, true);
gtk_window_set_resizable(m_pMenuHack, false);
-m_nSignalId =
g_signal_connect(GTK_TOGGLE_BUTTON(m_pMenuButton), "toggled",
G_CALLBACK(signalMenuButtonToggled), this);
g_signal_connect(m_pMenuHack, "key-press-event",
G_CALLBACK(keyPress), this);
g_signal_connect(m_pMenuHack, "grab-broken-event",
G_CALLBACK(signalGrabBroken), this);
g_signal_connect(m_pMenuHack, "button-press-event",
G_CALLBACK(signalButtonPress), this);
@@ -11794,38 +11829,6 @@ public:
#endif
return eRet;
}
-
-// tdf#153885 for wayland if the popover window is the application
-// window, constrain it within the application window so it won't
-// be cut off screen. Leave dialog hosted ones alone, like
-// format, watermark, which are likely presented in the middle
-// of the screen and are too small to constrain the popover inside.
-void ConstrainApplicationWindowPopovers(GtkToggleButton* pItem)
-{
-#if defined(GDK_WINDOWING_WAYLAND)
-GdkDisplay *pDisplay = gtk_widget_get_display(GTK_WIDGET(pItem));
-if (DLSYM_GDK_IS_WAYLAND_DISPLAY(pDisplay) &&
GTK_IS_MENU_BUTTON(pItem))
-{
-GtkMenuButton* pMenuButton = GTK_MENU_BUTTON(pItem);
-if
core.git: vcl/source
vcl/source/treelist/iconviewimpl.cxx |1 +
1 file changed, 1 insertion(+)
New commits:
commit 0544fb193b949dbcff97e8c475063dd72583ad1d
Author: Caolán McNamara
AuthorDate: Sat Mar 30 21:25:51 2024 +
Commit: Caolán McNamara
CommitDate: Sun Mar 31 18:00:33 2024 +0200
Resolves: tdf#157587 IconView scoll range not updated
IconView::SetUpdateMode(true) doesn't update the scroll
range for any changes that might have taken place while
updates were suspended.
The similar SvImpLBox::UpdateAll() for "normal" lists
does this update, so do the equivalent update here too.
Noticeable since:
commit 666925f2ab06e690c41c470713dc83f2d752bfb7
Date: Sat Jun 3 15:23:15 2023 +0100
perf: use freeze/thaw around block insert of multiple icons
Change-Id: I318fc4509c6906161eabf3b312f311cb97ac063a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165584
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/vcl/source/treelist/iconviewimpl.cxx
b/vcl/source/treelist/iconviewimpl.cxx
index 048e193d4f4b..35025d1c81f4 100644
--- a/vcl/source/treelist/iconviewimpl.cxx
+++ b/vcl/source/treelist/iconviewimpl.cxx
@@ -467,6 +467,7 @@ void IconViewImpl::SyncVerThumb()
void IconViewImpl::UpdateAll()
{
FindMostRight();
+AdjustScrollBars(m_aOutputSize);
SyncVerThumb();
FillView();
ShowVerSBar();
core.git: svl/source
svl/source/numbers/zforlist.cxx |1 +
1 file changed, 1 insertion(+)
New commits:
commit f558872f9184d35c6ef21823645e0297165b2ca5
Author: Caolán McNamara
AuthorDate: Sat Mar 30 22:08:13 2024 +
Commit: Caolán McNamara
CommitDate: Sun Mar 31 18:03:46 2024 +0200
crashtesting: crash seen with multiple threads calling GetTheCurrencyTable
seen with soffice --convert-to xlsx forum-mso-en4-207468.xls
Change-Id: I89d16938b3f8780776f38b0e94ce3885d93ac252
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165585
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/svl/source/numbers/zforlist.cxx b/svl/source/numbers/zforlist.cxx
index 5939e93bd67a..02e48b8468cc 100644
--- a/svl/source/numbers/zforlist.cxx
+++ b/svl/source/numbers/zforlist.cxx
@@ -3988,6 +3988,7 @@ SvNFEngine::Accessor
SvNFEngine::GetRWPolicy(SvNFFormatData& rFormatData)
SvNFEngine::Accessor SvNFEngine::GetROPolicy(const SvNFFormatData&
rFormatData, SvNFFormatData::DefaultFormatKeysMap& rFormatCache)
{
+SvNumberFormatter::GetTheCurrencyTable(); // create this now so threads
don't attempt to create it simultaneously
return
{
std::bind(SvNFEngine::GetCLOffsetRO, std::ref(rFormatData),
std::placeholders::_1, std::placeholders::_2, std::placeholders::_3),
core.git: schema/libreoffice sc/qa sc/source
sc/qa/unit/data/ods/NamedExpressionsHidden.ods |binary
sc/qa/unit/subsequent_filters_test.cxx | 59
sc/source/filter/xml/xmlexprt.cxx |4
sc/source/filter/xml/xmlnexpi.cxx |4
schema/libreoffice/OpenDocument-v1.3+libreoffice-schema.rng | 19 +++
5 files changed, 86 insertions(+)
New commits:
commit 350c590620226c4d5b94aa01d3853e15af3cebb0
Author: Rafael Lima
AuthorDate: Mon Mar 25 15:24:30 2024 +0100
Commit: Tomaž Vajngerl
CommitDate: Mon Apr 1 05:56:10 2024 +0200
tdf#160356 Add support for hidden named expressions in Calc
Since bug 154449 was fixed, Calc now supports hidden named ranges. However,
named expressions were not considered in the original patch and it would be
useful to support hidden named expressions as well.
This patch adds suppport for hidden named expressions (import and export).
Change-Id: I2580416dcd5db0fcb2aa9061085cdc9975fb03c1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165239
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/sc/qa/unit/data/ods/NamedExpressionsHidden.ods
b/sc/qa/unit/data/ods/NamedExpressionsHidden.ods
new file mode 100644
index ..61e6d1feac6b
Binary files /dev/null and b/sc/qa/unit/data/ods/NamedExpressionsHidden.ods
differ
diff --git a/sc/qa/unit/subsequent_filters_test.cxx
b/sc/qa/unit/subsequent_filters_test.cxx
index 87e00ac7f3f0..a0cbd4f0780c 100644
--- a/sc/qa/unit/subsequent_filters_test.cxx
+++ b/sc/qa/unit/subsequent_filters_test.cxx
@@ -703,6 +703,65 @@ CPPUNIT_TEST_FIXTURE(ScFiltersTest,
testHiddenRangeNameXLSX)
pRangeData2->GetUnoType() &
sheet::NamedRangeFlag::HIDDEN);
}
+CPPUNIT_TEST_FIXTURE(ScFiltersTest, testHiddenNamedExpression)
+{
+createScDoc();
+ScDocument* pDoc = getScDoc();
+
+// Adds two hidden named expressions and two non-hidden named expressions
+ScRangeName* pNamedRanges = pDoc->GetRangeName();
+ScRangeData* pRangeData1 = new ScRangeData(*pDoc, "NAME1", "100");
+pRangeData1->AddType(ScRangeData::Type::Hidden);
+pNamedRanges->insert(pRangeData1);
+ScRangeData* pRangeData2 = new ScRangeData(*pDoc, "NAME2", "text1");
+pRangeData2->AddType(ScRangeData::Type::Hidden);
+pNamedRanges->insert(pRangeData2);
+ScRangeData* pRangeData3 = new ScRangeData(*pDoc, "NAME3", "200");
+pNamedRanges->insert(pRangeData3);
+ScRangeData* pRangeData4 = new ScRangeData(*pDoc, "NAME4", "text2");
+pNamedRanges->insert(pRangeData4);
+CPPUNIT_ASSERT_EQUAL(size_t(4), pNamedRanges->size());
+
+// Save and reload to test whether the named expressions retain the hidden
where applicable
+saveAndReload("calc8");
+pDoc = getScDoc();
+pNamedRanges = pDoc->GetRangeName();
+CPPUNIT_ASSERT_EQUAL(size_t(4), pNamedRanges->size());
+pRangeData1 = pNamedRanges->findByUpperName(OUString("NAME1"));
+CPPUNIT_ASSERT(pRangeData1);
+CPPUNIT_ASSERT_EQUAL(ScRangeData::Type::Hidden, pRangeData1->GetType());
+CPPUNIT_ASSERT_EQUAL(OUString("100"), pRangeData1->GetSymbol());
+pRangeData2 = pNamedRanges->findByUpperName(OUString("NAME2"));
+CPPUNIT_ASSERT(pRangeData2);
+CPPUNIT_ASSERT_EQUAL(ScRangeData::Type::Hidden, pRangeData2->GetType());
+CPPUNIT_ASSERT_EQUAL(OUString("text1"), pRangeData2->GetSymbol());
+pRangeData3 = pNamedRanges->findByUpperName(OUString("NAME3"));
+CPPUNIT_ASSERT(pRangeData3);
+CPPUNIT_ASSERT_EQUAL(ScRangeData::Type::Name, pRangeData3->GetType());
+CPPUNIT_ASSERT_EQUAL(OUString("200"), pRangeData3->GetSymbol());
+pRangeData4 = pNamedRanges->findByUpperName(OUString("NAME4"));
+CPPUNIT_ASSERT(pRangeData4);
+CPPUNIT_ASSERT_EQUAL(ScRangeData::Type::Name, pRangeData4->GetType());
+CPPUNIT_ASSERT_EQUAL(OUString("text2"), pRangeData4->GetSymbol());
+}
+
+CPPUNIT_TEST_FIXTURE(ScFiltersTest, testHiddenNamedExpressionODS)
+{
+createScDoc("ods/NamedExpressionsHidden.ods");
+ScDocument* pDoc = getScDoc();
+
+// The document has 2 named expressions; the first is hidden; the second
is visible
+ScRangeName* pNamedRanges = pDoc->GetRangeName();
+ScRangeData* pRangeData1 =
pNamedRanges->findByUpperName(OUString("NAME1"));
+CPPUNIT_ASSERT(pRangeData1);
+CPPUNIT_ASSERT_EQUAL(ScRangeData::Type::Hidden, pRangeData1->GetType());
+CPPUNIT_ASSERT_EQUAL(OUString("100"), pRangeData1->GetSymbol());
+ScRangeData* pRangeData2 =
pNamedRanges->findByUpperName(OUString("NAME2"));
+CPPUNIT_ASSERT(pRangeData2);
+CPPUNIT_ASSERT_EQUAL(ScRangeData::Type::Name, pRangeData2->GetType());
+CPPUNIT_ASSERT_EQUAL(OUString("200"), pRangeData2->GetSymbol());
+}
+
CPPUNIT_TEST_FIXTURE(ScFiltersTest, testHyperlinksXLSX)
{
createScDoc("xlsx/hyperlinks.xlsx");
diff --git a/sc/source/filter/xml/xmlexprt.cxx
b/sc/source/filter/xml/xmlexprt.cxx
index abef9391b1fb..e776c006643a 100644
[Bug 144557] Pasting slides into another LO instance pastes truncated content
https://bugs.documentfoundation.org/show_bug.cgi?id=144557 --- Comment #5 from Aron Budea --- Still the same in LO 24.8.0.0.alpha0+ (110eb4f6f8ed43faf7d2a4e74bfdcb93934f6439) / Ubuntu. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160441] New: favorite styles
https://bugs.documentfoundation.org/show_bug.cgi?id=160441 Bug ID: 160441 Summary: favorite styles Product: LibreOffice Version: 24.8.0.0 alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: j...@cspv.hu hi, it would be great if we could see our favorite styles... if we could mark them as favs, and activate a view with our fav styles listed... Alternatively, instead of marking styles as favs, we could just add styles in the fav styles pane (tab) to the list... - - - - thank you for developing libreoffice and writer -- -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160442] New: export "style sheets" and import them -- a long way to go yet, isn't it?
https://bugs.documentfoundation.org/show_bug.cgi?id=160442 Bug ID: 160442 Summary: export "style sheets" and import them -- a long way to go yet, isn't it? Product: LibreOffice Version: 24.8.0.0 alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: j...@cspv.hu Hi, I'm sure that this part of the development is even more complex than other aspects... But sooner or later we'll get to using style sheets anyway... So, why not make steps in that direction... or even leaps... The Master Document already implies that style sheets as such do exist :) Only we call them templates, still. I guess, based on just a superficial glance, that there are styles that are mandatory for any Writer document. This is what makes it (at the moment, still) hard to make a step toward bare documents with default style sheets... (instead of templates) Templates and style sheets (or styles) are totally different things per def. A template has content elements. It's a page with some elements already in it. A style or a bunch of them is something that you apply afterwards, when some content is there. Totally different functionalities. Therefore, one day or another, it will be necessary to dump template culture and start the new style sheet culture, which will be cleaner and simpler, like HMTL5 compared to html4... This evolution could begin with style sheets... meaning: • being able to export them • being able to import them • being able to edit them, including copying and pasting sections fro one to another... THIS would, I guess, need • the phenomenon of the bare document • the set of basic styles that are mandatory to have for any document • establishing two views for styles: |-> an advanced view with all the style details, without the editing option |-> the "simplified" (valid / practical) view... with editable aattributes -- RIGHT now, as I see, the style sheet as such already exists, as styles.xml However, it's pretty messy as it is, especially with all the Asian stuff... see: What I see as a layman is that opacity, for example shouldn't be defined within a style. Not to mention the Chinese and INdian references... and Hyphenation methods... which also should be defined per section, whatever... "font language" also seems made up... etc, etc... I mean, there's a lot to do to get to using styles... as style sheets... I wonder if it will ever happen? (When I started this post, I thought if was about 1000x simpler to achieve the goal, exporting and importing style sheets. Now even I can answer: yes, it's a very long way to go.) - - - thank you for developing libreoffice and writer - - - -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160444] New: Crash on closing the 3D-Effects Window
https://bugs.documentfoundation.org/show_bug.cgi?id=160444 Bug ID: 160444 Summary: Crash on closing the 3D-Effects Window Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: rb.hensc...@t-online.de Created attachment 193414 --> https://bugs.documentfoundation.org/attachment.cgi?id=193414=edit Callstack from VS Start Draw. Open the "3D Effects" dialog window. Close it with the cross in its title bar or with shortcut Alt+F4. => Crash. If you do not have the icon in a toolbar insert a 3D-object e.g. a 3D cube. Its context menu has the icon for the "3D Effects" dialog window. I see the crash e.g in Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: c9d4f99b2bb54ac7735b3e0d0cadbafbd0279518 CPU threads: 32; OS: Windows 10.0 Build 22631; UI render: Skia/Vulkan; VCL: win Locale: de-DE (de_DE); UI: en-US Calc: threaded I get no crash in Version: 7.6.4.1 (X86_64) / LibreOffice Community Build ID: e19e193f88cd6c0525a17fb7a176ed8e6a3e2aa1 CPU threads: 32; OS: Windows 10.0 Build 22631; UI render: Skia/Vulkan; VCL: win Locale: de-DE (de_DE); UI: en-US Calc: threaded With a debug build I get the attached call stack. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160433] „Clear direct formatting“ (Ctrl+M) doesn’t clear „List Style Name“ attribute
https://bugs.documentfoundation.org/show_bug.cgi?id=160433 Haris changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #1 from Haris --- Hi Tyler, Thank you for reporting the bug. I can confirm that the bug is present in Stable Build Version: 24.2.1.2 (AARCH64) / LibreOffice Community Build ID: db4def46b0453cc22e2d0305797cf981b68ef5ac CPU threads: 10; OS: macOS 14.1.2; UI render: Skia/Metal; VCL: osx Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded Master/Daily Build Version: 24.8.0.0.alpha0+ (AARCH64) / LibreOffice Community Build ID: c4023d3ec604abfff38be2053e2989c7ec2ba8c1 CPU threads: 10; OS: macOS 14.1.2; UI render: Skia/Metal; VCL: osx Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded Note: I used MacOS Sonoma 14.1.2 to test. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 152438] Improvement needed in LibreOffice submenu
https://bugs.documentfoundation.org/show_bug.cgi?id=152438 Caolán McNamara changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #7 from Caolán McNamara --- Yeah, like last time "This is one of those blasted wayland+gtk things where its very hard to win" -- You are receiving this mail because: You are the assignee for the bug.
[Bug 108456] [META] Style modify dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108456 Bug 108456 depends on bug 145081, which changed state. Bug 145081 Summary: Line spacing style type "Fixed" is exposed on the property side bar but not on the style sheet dialog https://bugs.documentfoundation.org/show_bug.cgi?id=145081 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 109235] [META] Paragraph line spacing bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=109235 Bug 109235 depends on bug 145081, which changed state. Bug 145081 Summary: Line spacing style type "Fixed" is exposed on the property side bar but not on the style sheet dialog https://bugs.documentfoundation.org/show_bug.cgi?id=145081 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160445] change default of Settings > Application Colors > Custom Colors > Automatic from "Light" to "System Theme"
https://bugs.documentfoundation.org/show_bug.cgi?id=160445 --- Comment #1 from steve --- Created attachment 193415 --> https://bugs.documentfoundation.org/attachment.cgi?id=193415=edit Screenshot 2024-03-31 default "light" but why? -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160448] New: WRITER: when applying a style, the list of styles will autoscroll so that this style would be on top (annoying)
https://bugs.documentfoundation.org/show_bug.cgi?id=160448 Bug ID: 160448 Summary: WRITER: when applying a style, the list of styles will autoscroll so that this style would be on top (annoying) Product: LibreOffice Version: 7.6.5.2 release Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: minor Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: j...@cspv.hu Description: as in the subject Steps to Reproduce: 1. apply a style to a paragraph 2. now... pick another one and apply that 3. look at your list of styles Actual Results: on applying a style the list autoscrolls Expected Results: the list of styles should remain unmoved (there's no logical reason to make it jump to the top at all... I mean, if you clicked on it, it was in view, so there's no need to reposition the list.. it really should work without that "reload" glitch) Reproducible: Always User Profile Reset: No Additional Info: [Information automatically included from LibreOffice] Locale: en-US Module: TextDocument [Information guessed from browser] OS: Linux (All) OS is 64bit: yes -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160447] styles: allow us to copy, clone styles, plz
https://bugs.documentfoundation.org/show_bug.cgi?id=160447 V Stuart Foote changed: What|Removed |Added CC||vsfo...@libreoffice.org --- Comment #1 from V Stuart Foote --- Umm, we already have this. Not by copy/clone, rather the New... dialog from the F11 Stylist. --Select the Text run or Paragraph to be styled --F11 (or Alt+2 accelerator) to shift to SB Stylist deck --Dbl-Click to apply existing style to selection --Context menu, New... dialog --'Organizer' tab, apply a new style Name and Next style (or come back to it) --Adjust values for the new style from any of the other tabs as desired --OK to apply (you'll see the new style immediately in the list) --apply as style where needed to document (or template) -- You are receiving this mail because: You are the assignee for the bug.
[Bug 146619] Remove unused #includes from C/C++ files
https://bugs.documentfoundation.org/show_bug.cgi?id=146619 --- Comment #47 from Commit Notification --- Gabor Kelemen committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/193bb41859a8b29904685bc6c544809fcb4b8f50 tdf#146619 Drop unused 'using namespace' in: fpicker/ It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160446] LibreOffice Calc crashes when control is remove with a popup up menu displayed
https://bugs.documentfoundation.org/show_bug.cgi?id=160446 Mike Kaganski changed: What|Removed |Added Crash report or||https://crashreport.libreof crash signature||fice.org/stats/crash_detail ||s/78e6d02a-bb9a-4633-af9a-8 ||b5e6b8cbe9e -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160446] LibreOffice Calc crashes when control is remove with a popup up menu displayed
https://bugs.documentfoundation.org/show_bug.cgi?id=160446 --- Comment #1 from Mike Kaganski --- Created attachment 193417 --> https://bugs.documentfoundation.org/attachment.cgi?id=193417=edit A simpler self-contained reproducer This is a document with a single textbox; its "when losing focus" event is bound to this macro: sub OnFocusLost(evt) doc = ThisComponent src = evt.Source drawPage = doc.DrawPages(0) txtbox = drawPage(0) drawPage.remove(txtbox) end sub -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160446] LibreOffice Calc crashes when control is remove with a popup up menu displayed
https://bugs.documentfoundation.org/show_bug.cgi?id=160446 Mike Kaganski changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160054] Glitching windows frames ,when i want checking a details and properties of the any document.
https://bugs.documentfoundation.org/show_bug.cgi?id=160054 Dariusz changed: What|Removed |Added Component|UI |graphics stack -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160438] Unwanted preceding dot *after* fill characters but *before* page numbers in table of contents
https://bugs.documentfoundation.org/show_bug.cgi?id=160438 --- Comment #7 from ProfYaffle --- It might be a scaling issue, as - as you say - it's not apparent at different zoom levels. However, be aware that it appears on Print Previews, and kind-of-appears on a PDF export, which suggests that it's more than just a rendering issue. I don't have a printer to hand to see if it appears on paper as well. New attachment: PDF showing the bug, but only on one entry for some reason... -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160438] Unwanted preceding dot *after* fill characters but *before* page numbers in table of contents
https://bugs.documentfoundation.org/show_bug.cgi?id=160438 --- Comment #8 from ProfYaffle --- Created attachment 193418 --> https://bugs.documentfoundation.org/attachment.cgi?id=193418=edit Sample PDF export showing that the formatting isn't just on-screen rendering (but for only one entry) -- You are receiving this mail because: You are the assignee for the bug.
[Bug 118006] Add support for Quattro Pro .qpw format, looking for sample documents[libwps]
https://bugs.documentfoundation.org/show_bug.cgi?id=118006 --- Comment #7 from Devansh Varshney --- Is this related to the request of this enhancement request? https://wiki.documentfoundation.org/Development/GSoC/Ideas_without_a_mentor#Implement_Quattro_Pro_Import_filter http://web.archive.org/web/20021022012118/http://www.corel.com/partners_developers/ds/CO32SDK/docs/qp7/Qpf2intr.htm -- You are receiving this mail because: You are the assignee for the bug.
[Bug 146619] Remove unused #includes from C/C++ files
https://bugs.documentfoundation.org/show_bug.cgi?id=146619 --- Comment #48 from Commit Notification --- Gabor Kelemen committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/3b85fd8a27edb7b9a0d92bad7969ef551d11450f tdf#146619 Drop unused 'using namespace' in: sdext/ It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160445] change default of Settings > Application Colors > Custom Colors > Automatic from "Light" to "System Theme"
https://bugs.documentfoundation.org/show_bug.cgi?id=160445 V Stuart Foote changed: What|Removed |Added OS|macOS (All) |All Keywords||needsUXEval CC||libreoffice-ux-advise@lists ||.freedesktop.org, ||vsfo...@libreoffice.org --- Comment #2 from V Stuart Foote --- Same situation for Windows builds. Application Colors - the 'Automatic' scheme defaults to the Light color theme by default. Setting 'System Theme' might be more appealing (though it is by default a dark document canvas which may be a little jarring for folks). Setting Automatic -> 'Light' as current is safe and comfortable, and it is trivial for users to select 'Dark' But Automatic -> 'System Theme' might be more in line with os/DE norms? -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160445] change default of Settings > Application Colors > Custom Colors > Automatic from "Light" to "System Theme"
https://bugs.documentfoundation.org/show_bug.cgi?id=160445 V Stuart Foote changed: What|Removed |Added OS|macOS (All) |All Keywords||needsUXEval CC||libreoffice-ux-advise@lists ||.freedesktop.org, ||vsfo...@libreoffice.org --- Comment #2 from V Stuart Foote --- Same situation for Windows builds. Application Colors - the 'Automatic' scheme defaults to the Light color theme by default. Setting 'System Theme' might be more appealing (though it is by default a dark document canvas which may be a little jarring for folks). Setting Automatic -> 'Light' as current is safe and comfortable, and it is trivial for users to select 'Dark' But Automatic -> 'System Theme' might be more in line with os/DE norms? -- You are receiving this mail because: You are on the CC list for the bug.
[Bug 160449] New: tools / options, tools / customize --- export settings
https://bugs.documentfoundation.org/show_bug.cgi?id=160449 Bug ID: 160449 Summary: tools / options, tools / customize --- export settings Product: LibreOffice Version: 24.2.0.1 rc Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: j...@cspv.hu hi, It'd be great if we could export out settings. Imagine: tools / options... and after you have set what and how you want... you could select in that menu (Tools / options): "EXPORT settings" I'd love that :) and the same with customization... - - - thank you for developing Libreoffice and especially Writer :) - - - -- You are receiving this mail because: You are the assignee for the bug.
[Bug 100156] [META] Wayland-related bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=100156 Bug 100156 depends on bug 154072, which changed state. Bug 154072 Summary: crash / no effect when clicking some dropdown buttons when toolbar overflows https://bugs.documentfoundation.org/show_bug.cgi?id=154072 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 107237] [META] Notebookbar Tabbed
https://bugs.documentfoundation.org/show_bug.cgi?id=107237 Bug 107237 depends on bug 154072, which changed state. Bug 154072 Summary: crash / no effect when clicking some dropdown buttons when toolbar overflows https://bugs.documentfoundation.org/show_bug.cgi?id=154072 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 112974] [META] Toolbar overflow/wrap/chevron button bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=112974 Bug 112974 depends on bug 154072, which changed state. Bug 154072 Summary: crash / no effect when clicking some dropdown buttons when toolbar overflows https://bugs.documentfoundation.org/show_bug.cgi?id=154072 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 103182] [META] GTK3-specific bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=103182 Bug 103182 depends on bug 154072, which changed state. Bug 154072 Summary: crash / no effect when clicking some dropdown buttons when toolbar overflows https://bugs.documentfoundation.org/show_bug.cgi?id=154072 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160440] New: Paste as bitmap of a chart is incorrect when source is filtered
https://bugs.documentfoundation.org/show_bug.cgi?id=160440 Bug ID: 160440 Summary: Paste as bitmap of a chart is incorrect when source is filtered Product: LibreOffice Version: 7.6.5.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Chart Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: jollyt...@freemail.hu Created attachment 193413 --> https://bugs.documentfoundation.org/attachment.cgi?id=193413=edit Example for incorrect copy/paste Please see the attached spreadsheet. Just do a filter (e.g. to TRUE only) and then select the chart and anywhere (on the same sheet or LO Writer) paste it as a bitmap image. You can also paste it in a bitmap handling software like gnome-paint. The problem is that the bitmap renders a chart that includes the filtered out datapoints as well. Doing more research, I found that: When the file is saved with the filter on and then the file is loaded (and I guess the chart is rendered freshly with only the filtered data) then the filtered chart is copied/pasted properly. If then I touch the filter (e.g. select all, but also if I just remove the current and add the other value, e.g. unmark TRUE and mark FALSE), then the chart as an object will always be correct, but the copied/pasted image will always be with the unfiltered dataset. As a side question: Within LO Calc I can choose a paste special as a PNG object (btw. with the same problems as a BMP). However in LO Writer I can only paste it as a BMP, not as a PNG. Why is that? P.S. I use this approach, so not the whole object is copied to a text document, but only the image. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 116643] Crash when playing PPTX slide with MP4 video (comment 7)
https://bugs.documentfoundation.org/show_bug.cgi?id=116643 Aron Budea changed: What|Removed |Added Component|Writer |Impress Hardware|x86-64 (AMD64) |All OS|macOS (All) |Linux (All) -- You are receiving this mail because: You are the assignee for the bug.
[Bug 152110] LanguageTool extension (version <6.0) prevents adding words to dictionaries via context menu with 2+ dictionaries present
https://bugs.documentfoundation.org/show_bug.cgi?id=152110 --- Comment #15 from Caolán McNamara --- given that bug #157258 was bisected to the same commit, perhaps the new fix for that also fixes this? -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160443] DDE Links to Documents with non-latin characters don't work
https://bugs.documentfoundation.org/show_bug.cgi?id=160443 Mike Kaganski changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||1429 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160442] export "style sheets" and import them -- a long way to go yet, isn't it?
https://bugs.documentfoundation.org/show_bug.cgi?id=160442 V Stuart Foote changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=95 ||861 CC||libreoffice-ux-advise@lists ||.freedesktop.org, ||vsfo...@libreoffice.org Keywords||needsUXEval --- Comment #1 from V Stuart Foote --- We are bound by what ODF framework supports, all other styling schemas need filter based translation--import and export (and why our CSS is not native and integration of HTML5/CSS3 is missing, see also bug 95861). Template ODF documents (nothing to do with the Master document .ODM) is much more efficient to store and exchange style details. Trivial to describe minimalistic ODF archives (especially with ODF Flat XML) as containers of styled paragraphs, tables, page layouts that can be applied to new documents or pasted as new elements on an existing document (opened in any of the LibreOffice moduels, not just Writer). So, beside improving the import/export *filters* for HTML5 and CSS (2.1 or 3) and a browser like "Web" viewing of that rendering, how much advantage is there really to implementing something more than current ODF template documents to hold applicable ODF styling? Not seeing a need to split out handling of our ODF 1.3 compliant styling--too much dev work for something that would be alien to all external "style" implementations, W3C CSS or other. Template archives are enough. -- You are receiving this mail because: You are on the CC list for the bug.
[Bug 160442] export "style sheets" and import them -- a long way to go yet, isn't it?
https://bugs.documentfoundation.org/show_bug.cgi?id=160442 V Stuart Foote changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=95 ||861 CC||libreoffice-ux-advise@lists ||.freedesktop.org, ||vsfo...@libreoffice.org Keywords||needsUXEval --- Comment #1 from V Stuart Foote --- We are bound by what ODF framework supports, all other styling schemas need filter based translation--import and export (and why our CSS is not native and integration of HTML5/CSS3 is missing, see also bug 95861). Template ODF documents (nothing to do with the Master document .ODM) is much more efficient to store and exchange style details. Trivial to describe minimalistic ODF archives (especially with ODF Flat XML) as containers of styled paragraphs, tables, page layouts that can be applied to new documents or pasted as new elements on an existing document (opened in any of the LibreOffice moduels, not just Writer). So, beside improving the import/export *filters* for HTML5 and CSS (2.1 or 3) and a browser like "Web" viewing of that rendering, how much advantage is there really to implementing something more than current ODF template documents to hold applicable ODF styling? Not seeing a need to split out handling of our ODF 1.3 compliant styling--too much dev work for something that would be alien to all external "style" implementations, W3C CSS or other. Template archives are enough. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 95861] Writer Web -- rework HTML export and import filters to use HTML 5 and inline CSS3 styles
https://bugs.documentfoundation.org/show_bug.cgi?id=95861 V Stuart Foote changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=16 ||0442 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160445] New: change default of Settings > Application Colors > Custom Colors > Automatic from "Light" to "System Theme"
https://bugs.documentfoundation.org/show_bug.cgi?id=160445 Bug ID: 160445 Summary: change default of Settings > Application Colors > Custom Colors > Automatic from "Light" to "System Theme" Product: LibreOffice Version: 24.8.0.0 alpha0+ Master Hardware: All OS: macOS (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: l...@disr.it Description: This has been an ongoing issue since dark mode support was introduced for macOS in LibreOffice. The reason users go for dark mode is often because they prefer a dark work environment. The reasons for that may vary but one main reason certainly would be, that working late at night in a dark surrounding, working with software that uses large while UI elements is hurtful to the eyes. This is explained in the following gif: https://media1.tenor.com/m/nhc2g3Hvy8sC/flash-dark-theme.gif The current defualt in LibreOffice does not at all serve this use case. Actually quite the opposite. And it is very inconsequential. While Scheme defaults to "Automatic" meaning it caters two the two use cases a) users defaulting to dark mode b) users automatically switching light + dark mode depending on day time, the fact that Automatic is set to Light spoils the effort, since e.g. the writer page or the spreadsheet will be white resulting in the cat falling off the chair as per gif linked above. Please change the default. Just follow the user system. Trust your users, chances are, they do know what's best for them. So no need to force defaults on them. Instead follow their system defaults to be a good platform citizen and blend in as best as possible on the respective OS. Thanks for considering. Steps to Reproduce: install a fresh main build and look at Settings > Application Colors > Custom Colors > Automatic. Actual Results: Set to "Light" Expected Results: Should be "System Theme" Reproducible: Always User Profile Reset: No Additional Info: Version: 24.8.0.0.alpha0+ (AARCH64) / LibreOffice Community Build ID: c9d4f99b2bb54ac7735b3e0d0cadbafbd0279518 CPU threads: 12; OS: macOS 14.4.1; UI render: Skia/Metal; VCL: osx Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160445] change default of Settings > Application Colors > Custom Colors > Automatic from "Light" to "System Theme"
https://bugs.documentfoundation.org/show_bug.cgi?id=160445 steve changed: What|Removed |Added Blocks||118017 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=118017 [Bug 118017] [META] macOS Dark Mode bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Bug 118017] [META] macOS Dark Mode bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=118017 steve changed: What|Removed |Added Depends on||160445 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=160445 [Bug 160445] change default of Settings > Application Colors > Custom Colors > Automatic from "Light" to "System Theme" -- You are receiving this mail because: You are the assignee for the bug.
[Bug 152686] UI: Hamburger menu looks like gray square in start center with macOS dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=152686 steve changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #9 from steve --- @Telesto: is this still a problem? Using Settings > View > Appearance > Mode > System (set to dark mode) and Icon Theme > Theme to Automatic (Sukapuara (dark)) this looks fine to my eyes. Please re-open if I am mistaken. The screenshot you posted does not seem to be from start center but writer or another component since a ruler UI is visible. Or am I seeing that in a wrong way? -- You are receiving this mail because: You are the assignee for the bug.
[Bug 103341] [META] AutoCorrect and Word Completion bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103341 Bug 103341 depends on bug 157258, which changed state. Bug 157258 Summary: "Always autocorrect to" deletes the word instead of replacing (affects extensions like Grammalecte, LanguageTool, Antidote) https://bugs.documentfoundation.org/show_bug.cgi?id=157258 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 86349] [META] Context menu bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=86349 Bug 86349 depends on bug 157258, which changed state. Bug 157258 Summary: "Always autocorrect to" deletes the word instead of replacing (affects extensions like Grammalecte, LanguageTool, Antidote) https://bugs.documentfoundation.org/show_bug.cgi?id=157258 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160443] New: DDE Links to Documents with non-latin characters don't work
https://bugs.documentfoundation.org/show_bug.cgi?id=160443 Bug ID: 160443 Summary: DDE Links to Documents with non-latin characters don't work Product: LibreOffice Version: 24.2.1.2 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: raphaels...@freenet.de Description: I am using a Microsoft Surface Laptop with an up-to-date WIndows 10 (german instal) and LibreOffice 24.2.1.2 (fresh install). When I create a calc file and use e.g. armenian or russian letters in the filename and then try to import some data into writer via DDE-Link, it shows "" as the file name and only imports an empty table. It works fine for docs with latin characters as the filename. None of the folders where the doc is located in, have non-latin characters, just the filename itself. Other than that, I can work with these files without any issue, saving, opening and so on. I can import pics into writer with non-latin characters in the filename. A friend of mine uses MacOS and tried to replicate the issue, but it works fine for him. Steps to Reproduce: 1.create new calc file with eg. armenian letters in the filename 2.input some numbers and copy the cells 3.create new wirter file and try to import the copied data via DDE-Link Actual Results: Filename is shown as question marks and an empty table is imported. Expected Results: The copied data is properly imported. Reproducible: Always User Profile Reset: No Additional Info: none -- You are receiving this mail because: You are the assignee for the bug.
[Bug 118017] [META] macOS Dark Mode bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=118017 Bug 118017 depends on bug 152260, which changed state. Bug 152260 Summary: Template Name Has Dark Text on Dark https://bugs.documentfoundation.org/show_bug.cgi?id=152260 What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.
[Bug 152260] Template Name Has Dark Text on Dark
https://bugs.documentfoundation.org/show_bug.cgi?id=152260 --- Comment #8 from steve --- Created attachment 193416 --> https://bugs.documentfoundation.org/attachment.cgi?id=193416=edit Screenshot 2024-03-31 worksforme -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160441] F11 Stylist deck -- provide a user's "favorite" style grouping for each style category
https://bugs.documentfoundation.org/show_bug.cgi?id=160441 V Stuart Foote changed: What|Removed |Added Keywords||needsUXEval Component|Writer |UI CC||libreoffice-ux-advise@lists ||.freedesktop.org, ||vsfo...@libreoffice.org Summary|favorite styles |F11 Stylist deck -- provide ||a user's "favorite" style ||grouping for each style ||category --- Comment #1 from V Stuart Foote --- +1, like the idea. Expect this would need to be per user and cached to user profile. Unsure if we could currently assign within individual document or template, so may be limited and only annotate styles from current project default styles as localized. Need dev advice on effort to add per document and user's custom styles. Either case, could be a good UI enhancement to the F11 Stylist to read as users 'favorites' from their profile and show just those styles to compose with. At least for Paragraph and Character styles. But possibly all style categories. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160441] F11 Stylist deck -- provide a user's "favorite" style grouping for each style category
https://bugs.documentfoundation.org/show_bug.cgi?id=160441 V Stuart Foote changed: What|Removed |Added Keywords||needsUXEval Component|Writer |UI CC||libreoffice-ux-advise@lists ||.freedesktop.org, ||vsfo...@libreoffice.org Summary|favorite styles |F11 Stylist deck -- provide ||a user's "favorite" style ||grouping for each style ||category --- Comment #1 from V Stuart Foote --- +1, like the idea. Expect this would need to be per user and cached to user profile. Unsure if we could currently assign within individual document or template, so may be limited and only annotate styles from current project default styles as localized. Need dev advice on effort to add per document and user's custom styles. Either case, could be a good UI enhancement to the F11 Stylist to read as users 'favorites' from their profile and show just those styles to compose with. At least for Paragraph and Character styles. But possibly all style categories. -- You are receiving this mail because: You are on the CC list for the bug.
[Bug 152260] Template Name Has Dark Text on Dark
https://bugs.documentfoundation.org/show_bug.cgi?id=152260 steve changed: What|Removed |Added Status|NEEDINFO|RESOLVED CC||l...@disr.it Resolution|--- |WORKSFORME --- Comment #9 from steve --- Setting to worksforme - see screenshot. This can no longer be reproduced. Version: 24.8.0.0.alpha0+ (AARCH64) / LibreOffice Community Build ID: c9d4f99b2bb54ac7735b3e0d0cadbafbd0279518 CPU threads: 12; OS: macOS 14.4.1; UI render: Skia/Metal; VCL: osx Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160443] DDE Links to Documents with non-latin characters don't work
https://bugs.documentfoundation.org/show_bug.cgi?id=160443 Mike Kaganski changed: What|Removed |Added Resolution|--- |DUPLICATE See Also|https://bugs.documentfounda | |tion.org/show_bug.cgi?id=15 | |1429| Status|UNCONFIRMED |RESOLVED --- Comment #1 from Mike Kaganski --- *** This bug has been marked as a duplicate of bug 151413 *** -- You are receiving this mail because: You are the assignee for the bug.
[Bug 151413] Unable to create a DDE link to a file with special characters in name on Windows
https://bugs.documentfoundation.org/show_bug.cgi?id=151413 Mike Kaganski changed: What|Removed |Added CC||raphaels...@freenet.de --- Comment #4 from Mike Kaganski --- *** Bug 160443 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Bug 146619] Remove unused #includes from C/C++ files
https://bugs.documentfoundation.org/show_bug.cgi?id=146619 --- Comment #42 from Commit Notification --- Gabor Kelemen committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/2f068b2182955362526641da3b1e9f3207aab4b3 tdf#146619 Drop unused 'using namespace' in: unoxml/ It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 146619] Remove unused #includes from C/C++ files
https://bugs.documentfoundation.org/show_bug.cgi?id=146619 --- Comment #44 from Commit Notification --- Gabor Kelemen committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/9a5b67ea271afc4449638207eecc52e88a7a891e tdf#146619 Drop unused 'using namespace' in: package/ It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 146619] Remove unused #includes from C/C++ files
https://bugs.documentfoundation.org/show_bug.cgi?id=146619 --- Comment #43 from Commit Notification --- Gabor Kelemen committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/828ad91196826cda970f3894de516f91a82fd7de tdf#146619 Drop unused 'using namespace' in: sax/ It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 146619] Remove unused #includes from C/C++ files
https://bugs.documentfoundation.org/show_bug.cgi?id=146619 --- Comment #45 from Commit Notification --- Gabor Kelemen committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/35fbbbe12d101a626fcb1679cc6c0d79922a4cc3 tdf#146619 Drop unused 'using namespace' in: svl/ It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 137525] Update ColumnValueSet drawing to use the Push/Pop API
https://bugs.documentfoundation.org/show_bug.cgi?id=137525 Ritobroto Mukherjee changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |ritobrot...@gmail.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.
[Bug 146619] Remove unused #includes from C/C++ files
https://bugs.documentfoundation.org/show_bug.cgi?id=146619 --- Comment #46 from Commit Notification --- Gabor Kelemen committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/da4f91bd4042f2c0ddd65c76d4ad5c35dbf3e1aa tdf#146619 Drop unused 'using namespace' in: vcl/ It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 107642] [META] Paragraph dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107642 Bug 107642 depends on bug 145081, which changed state. Bug 145081 Summary: Line spacing style type "Fixed" is exposed on the property side bar but not on the style sheet dialog https://bugs.documentfoundation.org/show_bug.cgi?id=145081 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 103494] [META] Textbox bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103494 Bug 103494 depends on bug 145081, which changed state. Bug 145081 Summary: Line spacing style type "Fixed" is exposed on the property side bar but not on the style sheet dialog https://bugs.documentfoundation.org/show_bug.cgi?id=145081 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 118017] [META] macOS Dark Mode bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=118017 Bug 118017 depends on bug 152686, which changed state. Bug 152686 Summary: UI: Hamburger menu looks like gray square in start center with macOS dark mode https://bugs.documentfoundation.org/show_bug.cgi?id=152686 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159199] Improve loading time for simple, large presentation document
https://bugs.documentfoundation.org/show_bug.cgi?id=159199 --- Comment #5 from Laurent Balland --- (In reply to Stéphane Guillou (stragu) from comment #3) > In the console, I get 16 times: > > warn:sd.filter:202522:202522:sd/source/filter/xml/sdxmlwrp.cxx:436: Fixing > inconsistent outline numbering placeholder preview Fixed in https://gerrit.libreoffice.org/c/core/+/165602 But loading time seems the same for the template -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160451] New: Garbled & overlaid text in Writer.
https://bugs.documentfoundation.org/show_bug.cgi?id=160451 Bug ID: 160451 Summary: Garbled & overlaid text in Writer. Product: LibreOffice Version: 7.6.5.2 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: dougsweene...@gmail.com Description: Text is overlaid & unreadable & therefore cannot be edited in imported scanned or downloaded documents. Steps to Reproduce: 1.Import document from Quick Access into Writer. 2. 3. Actual Results: Garbled & overlaid text. Expected Results: Text could not be edited. It should have produced a complete pge with certain blank fields in which Text could be typed. Reproducible: Always User Profile Reset: No Additional Info: Version: 7.6.5.2 (X86_64) / LibreOffice Community Build ID: 38d5f62f85355c192ef5f1dd47c5c0c0c6d6598b CPU threads: 2; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160444] Crash on closing the 3D-Effects Window
https://bugs.documentfoundation.org/show_bug.cgi?id=160444 Julien Nabet changed: What|Removed |Added Keywords||haveBacktrace Version|unspecified |24.8.0.0 alpha0+ Master Status|UNCONFIRMED |NEW Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160444] Crash on closing the 3D-Effects Window
https://bugs.documentfoundation.org/show_bug.cgi?id=160444 Julien Nabet changed: What|Removed |Added CC||serval2...@yahoo.fr --- Comment #1 from Julien Nabet --- Created attachment 193419 --> https://bugs.documentfoundation.org/attachment.cgi?id=193419=edit bt On pc Debian x86-64 with master sources updated today, I could reproduce this with gen rendering (not with gtk3 one). -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160450] New: Calc 7.6 Guide, Chapter 3 errors
https://bugs.documentfoundation.org/show_bug.cgi?id=160450 Bug ID: 160450 Summary: Calc 7.6 Guide, Chapter 3 errors Product: LibreOffice Version: 7.6.0.1 rc Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Documentation Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ndma...@juno.com CC: olivier.hal...@libreoffice.org Description: First, thank you for the EXCELLENT documentation. I have the downloaded and purchased versions. In Calc chapter 3 the page references are wrong (maybe from a different version of the book). Also the note on page 154, difference between Line and XY charts both say the same thing - X-axis. Thank you again for an Excellent office Suite!!! Actual Results: N/A Expected Results: N/A Reproducible: Always User Profile Reset: No Additional Info: N/A -- You are receiving this mail because: You are the assignee for the bug.
[Bug 42082] [META] Make LibreOffice shine and glow on macOS
https://bugs.documentfoundation.org/show_bug.cgi?id=42082 Sierk Bornemann changed: What|Removed |Added Depends on||147615 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=147615 [Bug 147615] PRINTING: macOS Impress print dialog does not provide access to select printer's Paper Size -- You are receiving this mail because: You are the assignee for the bug.
[Bug 147615] PRINTING: macOS Impress print dialog does not provide access to select printer's Paper Size
https://bugs.documentfoundation.org/show_bug.cgi?id=147615 Sierk Bornemann changed: What|Removed |Added Blocks||42082 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=42082 [Bug 42082] [META] Make LibreOffice shine and glow on macOS -- You are receiving this mail because: You are the assignee for the bug.
[Bug 45495] FILEOPEN .pptx: 3D rotated object shown without rotation
https://bugs.documentfoundation.org/show_bug.cgi?id=45495 --- Comment #20 from Regina Henschel --- (In reply to Regina Henschel from comment #17) > 3D rotation is only possible for custom-shapes in extrusion mode. So this > issue has two steps: > 1. import shapes from pptx so, that the 3D rotation are rendered. ==> bug > 70039 > 2. import a 3D-rotated image not as image-frame but as custom shape with > image background. During implementation of fixes for bug 70039 it becomes clear, that MS Office has so many 3D features for which LibreOffice has nothing corresponding, that larger changes in LibreOffice and in the ODF standard are needed. That is not possible for version 24.8 and likely not even for version 25.2. So this is more an enhancement request than a bug. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160452] New: Calc: default anchor everything to CELL
https://bugs.documentfoundation.org/show_bug.cgi?id=160452
Bug ID: 160452
Summary: Calc: default anchor everything to CELL
Product: LibreOffice
Version: 24.2.1.2 release
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: normal
Priority: medium
Component: Calc
Assignee: libreoffice-bugs@lists.freedesktop.org
Reporter: bud.mcclur...@gmail.com
Description:
Not a bug but a much desired feature.
In Calc: default anchor to cell for everything {lines, text boxes, plots,
graphics and groups}
Presently, only graphics have 'cell' as default anchor. However, if a line or
text is grouped with the graphic the group defaults to the anchor of the line
or test which is 'page'. Even if the lines and text anchors are changed to
'cell' a group of lines, text and graphic (all now having cell anchors) will
be assigned a 'page' anchor. Indeed, every edit one does to add lines or text
to a group will cause it to revert to a page anchor.
Steps to Reproduce:
1. fail to manually set every single object and group of objects' anchor to
"cell"
2. insert or delete rows or columns
3.
Actual Results:
For all column and row indexes greater than those changed
the layout is scrambled for all objects not anchored to cell.
Expected Results:
To work like Excel where everything is anchored to cell.
Reproducible: Always
User Profile Reset: No
Additional Info:
Version: 24.2.1.2 (X86_64) / LibreOffice Community
Build ID: db4def46b0453cc22e2d0305797cf981b68ef5ac
CPU threads: 16; OS: Windows 10.0 Build 19045; UI render: default; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL threaded
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 157480] Testing Mail Merge Email settings fails with ssl.SSLCertVerificationError
https://bugs.documentfoundation.org/show_bug.cgi?id=157480 --- Comment #6 from Caolán McNamara --- The linux case should already work in 24.2 since: https://gerrit.libreoffice.org/c/core/+/159149 so lets backport that at least for 7-6 too: https://gerrit.libreoffice.org/c/core/+/165597 This one was was osx however and the issue remains on at least that platform. I find that with: https://gerrit.libreoffice.org/c/core/+/165599 then smtp.gmail.com at least works with "test settings" for me -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160444] Crash on closing the 3D-Effects Window
https://bugs.documentfoundation.org/show_bug.cgi?id=160444 --- Comment #2 from Julien Nabet --- Created attachment 193420 --> https://bugs.documentfoundation.org/attachment.cgi?id=193420=edit Valgrind trace -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160446] New: LibreOffice Calc crashes when control is remove with a popup up menu displayed
https://bugs.documentfoundation.org/show_bug.cgi?id=160446 Bug ID: 160446 Summary: LibreOffice Calc crashes when control is remove with a popup up menu displayed Product: LibreOffice Version: 7.6.0.3 release Hardware: x86-64 (AMD64) OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: vibrationofl...@pm.me Description: LibreOffice Calc crashes when control is remove with a popup up menu displayed. This behaviour can be see in my Cell Controls Example: https://github.com/Amourspirit/python-ooouno-ex/tree/34108410d0c4b52a2d9668c961813fa8529f991b/ex/auto/calc/odev_cell_controls In the example controls are dynamically added to the sheet when a cell is clicked. I set an event to remove the control when it looses focus. This seems to work fine with the following excptions. If the control popup menu is activated (right click) then the control loose focus and tries to remove itself from the sheet. When the menu active this causes a crash and LibreOffice Calc completly disappears. Also, if I recall correctly if the control is not removed before switching sheets it will also crash. But, I put in an event handler to make sure the control is removed before sheet activation changes This crash may happen in other LibreOffice Applications, I did not test for this. Related Bug: Forms Listeners stop working after a different sheet is activated. https://bugs.documentfoundation.org/show_bug.cgi?id=159134 Related: How to stop Menu activation for a control? https://ask.libreoffice.org/t/how-to-stop-menu-activation-for-a-control/104160 Steps to Reproduce: 1. Start the example, link in description. 2. Click on a cell in COL B or C, this will insert a control. 3. Right click on the control, Calc will crash. Actual Results: Calc will crash Expected Results: Popup menu just exits gracefuly if the control is removed. Reproducible: Always User Profile Reset: No Additional Info: Related Bug: Forms Listeners stop working after a different sheet is activated. https://bugs.documentfoundation.org/show_bug.cgi?id=159134 Related: How to stop Menu activation for a control? https://ask.libreoffice.org/t/how-to-stop-menu-activation-for-a-control/104160 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 103428] [META] Properties deck/tab of the sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=103428 Bug 103428 depends on bug 152438, which changed state. Bug 152438 Summary: Improvement needed in LibreOffice submenu https://bugs.documentfoundation.org/show_bug.cgi?id=152438 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 152438] Improvement needed in LibreOffice submenu
https://bugs.documentfoundation.org/show_bug.cgi?id=152438 --- Comment #8 from Commit Notification --- Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/601dc3ef9bd74b1948274c104c6c2ec877bc812c Resolves: tdf#152438 constrain popups from MenuButtons with toplevel parent It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 152438] Improvement needed in LibreOffice submenu
https://bugs.documentfoundation.org/show_bug.cgi?id=152438 Commit Notification changed: What|Removed |Added Whiteboard||target:24.8.0 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 107237] [META] Notebookbar Tabbed
https://bugs.documentfoundation.org/show_bug.cgi?id=107237 Bug 107237 depends on bug 157587, which changed state. Bug 157587 Summary: Tabbed UI: Cannot scroll through all Style Preview options with up/down arrow button https://bugs.documentfoundation.org/show_bug.cgi?id=157587 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 107328] [META] Style preview bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107328 Bug 107328 depends on bug 157587, which changed state. Bug 157587 Summary: Tabbed UI: Cannot scroll through all Style Preview options with up/down arrow button https://bugs.documentfoundation.org/show_bug.cgi?id=157587 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
