[Libreoffice-commits] core.git: basic/source cui/source dbaccess/source include/tools sc/inc sc/source sd/source sfx2/source starmath/source svx/source sw/inc sw/source

2016-10-18 Thread Jacek Fraczek
 basic/source/basmgr/basmgr.cxx |4 -
 basic/source/classes/eventatt.cxx  |2 
 basic/source/classes/sbunoobj.cxx  |   34 
+-
 basic/source/runtime/runtime.cxx   |   21 +++---
 basic/source/sbx/sbxarray.cxx  |6 -
 cui/source/dialogs/linkdlg.cxx |4 -
 dbaccess/source/ui/browser/dbexchange.cxx  |2 
 include/tools/ref.hxx  |2 
 sc/inc/document.hxx|4 -
 sc/source/ui/docshell/externalrefmgr.cxx   |2 
 sc/source/ui/view/drawvie4.cxx |2 
 sd/source/ui/app/sdxfer.cxx|2 
 sd/source/ui/slidesorter/view/SlsInsertionIndicatorOverlay.cxx |2 
 sfx2/source/appl/linksrc.cxx   |4 -
 sfx2/source/doc/objmisc.cxx|2 
 starmath/source/eqnolefilehdr.cxx  |2 
 starmath/source/mathtype.cxx   |4 -
 svx/source/fmcomp/gridctrl.cxx |8 +-
 svx/source/gallery2/galmisc.cxx|2 
 sw/inc/section.hxx |4 -
 sw/inc/swtable.hxx |4 -
 sw/source/core/crsr/bookmrk.cxx|2 
 sw/source/core/doc/swserv.cxx  |2 
 sw/source/core/docnode/section.cxx |   12 +--
 sw/source/core/graphic/ndgrf.cxx   |   12 +--
 sw/source/core/inc/bookmrk.hxx |9 --
 sw/source/core/table/swtable.cxx   |2 
 sw/source/filter/ww8/wrtww8.cxx|   12 +--
 sw/source/filter/ww8/ww8glsy.cxx   |2 
 sw/source/filter/ww8/ww8par.cxx|6 -
 sw/source/uibase/dochdl/swdtflvr.cxx   |8 +-
 sw/source/uibase/docvw/edtwin.cxx  |   28 
 sw/source/uibase/uiview/view2.cxx  |4 -
 sw/source/uibase/uno/unoatxt.cxx   |   10 +-
 34 files changed, 112 insertions(+), 114 deletions(-)

New commits:
commit 398d641664baa6eaeb34789f0aebfd21e73edef3
Author: Jacek Fraczek <fraczek.ja...@gmail.com>
Date:   Wed Oct 12 20:04:41 2016 +0200

tdf#89307: Removed T* SvRef::opeartor &()

Usage has been replaced with SvRef::get() or removed where applicable.

Change-Id: I49f108910b668466134c40940b53fc3ab2acd816
Reviewed-on: https://gerrit.libreoffice.org/29780
Tested-by: Jenkins <c...@libreoffice.org>
Reviewed-by: Stephan Bergmann <sberg...@redhat.com>

diff --git a/basic/source/basmgr/basmgr.cxx b/basic/source/basmgr/basmgr.cxx
index 37bf1aa..6e29cae 100644
--- a/basic/source/basmgr/basmgr.cxx
+++ b/basic/source/basmgr/basmgr.cxx
@@ -1011,9 +1011,9 @@ bool BasicManager::ImplLoadBasic( SvStream& rStrm, 
StarBASICRef& rOldBasic ) con
 bool bLoaded = false;
 if( xNew.Is() )
 {
-if( nullptr != dynamic_cast(  ) )
+if( nullptr != dynamic_cast( xNew.get() ) )
 {
-StarBASIC* pNew = static_cast<StarBASIC*>(xNew.get());
+StarBASIC* pNew = static_cast<StarBASIC*>( xNew.get() );
 // Use the Parent of the old BASICs
 if( rOldBasic.Is() )
 {
diff --git a/basic/source/classes/eventatt.cxx 
b/basic/source/classes/eventatt.cxx
index a90adf8..e5c428e 100644
--- a/basic/source/classes/eventatt.cxx
+++ b/basic/source/classes/eventatt.cxx
@@ -431,7 +431,7 @@ void RTL_Impl_CreateUnoDialog( StarBASIC* pBasic, SbxArray& 
rPar, bool bWrite )
 
 // Get dialog
 SbxBaseRef pObj = rPar.Get( 1 )->GetObject();
-if( !(pObj.Is() && nullptr != dynamic_cast(  )) )
+if( !(pObj.Is() && nullptr != dynamic_cast( pObj.get() 
)) )
 {
 StarBASIC::Error( ERRCODE_BASIC_BAD_ARGUMENT );
 return;
diff --git a/basic/source/classes/sbunoobj.cxx 
b/basic/source/classes/sbunoobj.cxx
index 561767a..141a308 100644
--- a/basic/source/classes/sbunoobj.cxx
+++ b/basic/source/classes/sbunoobj.cxx
@@ -868,7 +868,7 @@ Type getUnoTypeForSbxValue( const SbxValue* pVal )
 return aRetType;
 }
 
-if( nullptr != dynamic_cast( ) )
+if( nullptr != dynamic_cast( xObj.get() ) )
 {
 SbxBase* pObj = xObj.get();
 SbxDimArray* pArray = static_cast<SbxDimArray*>(pObj);
@@ -962,12 +962,12 @@ Type getUnoTypeForSbxValue( const SbxValue* pVal )
 }
 }

[Libreoffice-commits] core.git: basctl/source basic/qa basic/source chart2/source dbaccess/source filter/source idl/inc idl/source include/basic include/sfx2 include/svl include/svx include/tools repo

2016-10-10 Thread Jacek Fraczek
   |6 
 sc/source/ui/view/drawvie4.cxx|2 
 sc/source/ui/view/gridwin4.cxx|2 
 sc/source/ui/view/viewdata.cxx|2 
 sc/source/ui/view/viewfun2.cxx|2 
 sc/source/ui/view/viewfun3.cxx|6 
 sc/source/ui/view/viewfun5.cxx|2 
 scripting/source/basprov/basmodnode.cxx   |4 
 scripting/source/basprov/basscript.cxx|   18 -
 sd/qa/unit/HtmlExportTest.cxx |2 
 sd/qa/unit/export-tests-ooxml1.cxx|   46 ++--
 sd/qa/unit/export-tests-ooxml2.cxx|   42 +--
 sd/qa/unit/export-tests.cxx   |   14 -
 sd/qa/unit/import-tests.cxx   |2 
 sd/source/core/drawdoc.cxx|2 
 sd/source/filter/eppt/eppt.cxx|6 
 sd/source/filter/ppt/pptin.cxx|2 
 sd/source/filter/ppt/propread.cxx |4 
 sd/source/ui/app/sdxfer.cxx   |2 
 sd/source/ui/slidesorter/controller/SlsClipboard.cxx  |2 
 sd/source/ui/slidesorter/controller/SlsSlotManager.cxx|6 
 sd/source/ui/view/ViewClipboard.cxx   |2 
 sd/source/ui/view/sdview3.cxx |4 
 sfx2/source/appl/macroloader.cxx  |4 
 sfx2/source/appl/xpackcreator.cxx |2 
 sfx2/source/bastyp/progress.cxx   |   18 -
 sfx2/source/doc/docfile.cxx   |2 
 sfx2/source/doc/doctempl.cxx  |2 
 sfx2/source/doc/printhelper.cxx   |   10 
 sfx2/source/doc/sfxbasemodel.cxx  |   74 +++---
 sfx2/source/view/viewfrm.cxx  |6 
 sot/source/sdstor/storage.cxx |4 
 sot/source/sdstor/ucbstorage.cxx  |8 
 starmath/qa/cppunit/test_cursor.cxx   |8 
 starmath/qa/cppunit/test_node.cxx |2 
 starmath/qa/cppunit/test_nodetotextvisitors.cxx   |8 
 starmath/qa/cppunit/test_parse.cxx|2 
 starmath/qa/extras/mmlexport-test.cxx |2 
 starmath/qa/extras/mmlimport-test.cxx |2 
 starmath/source/document.cxx  |2 
 starmath/source/smdetect.cxx  |2 
 starmath/source/unofilter.cxx |2 
 svl/source/items/lckbitem.cxx |4 
 svx/source/dialog/charmap.cxx |6 
 svx/source/fmcomp/fmgridif.cxx|2 
 svx/source/fmcomp/gridctrl.cxx|   12 -
 svx/source/gallery2/galtheme.cxx  |4 
 sw/source/core/crsr/bookmrk.cxx   |2 
 sw/source/core/doc/DocumentLinksAdministrationManager.cxx |4 
 sw/source/core/docnode/section.cxx|8 
 sw/source/core/fields/ddefld.cxx  |   10 
 sw/source/core/graphic/ndgrf.cxx  |   28 +-
 sw/source/filter/basflt/shellio.cxx   |2 
 sw/source/filter/ww8/wrtww8gr.cxx |2 
 sw/source/filter/ww8/ww8glsy.cxx  |2 
 sw/source/filter/ww8/ww8par.cxx   |   10 
 sw/source/filter/ww8/ww8par4.cxx  |6 
 sw/source/filter/ww8/ww8par5.cxx  |2 
 sw/source/ui/index/cnttab.cxx |   18 -
 sw/source/uibase/dbui/dbmgr.cxx   |   14 -
 sw/source/uibase/uno/unomailmerge.cxx |6 
 unotools/source/ucbhelper/ucblockbytes.cxx|4 
 unotools/source/ucbhelper/ucbstreamhelper.cxx |   11 -
 vcl/quartz/salgdi.cxx |8 
 vcl/source/outdev/font.cxx|2 
 vcl/unx/generic/glyphs/freetype_glyphcache.cxx|6 
 vcl/win/gdi/salfont.cxx   |   14 -
 writerperfect/source/common/WPXSvInputStream.cxx  |2 
 141 files changed, 685 insertions(+), 684 deletions(-)

New commits:
commit f004aa99514d385f3ee254bba735f5eaeb7d9ad8
Author: Jacek Fraczek <fraczek.ja...@gmail.com>
Date:   Wed Oct 5 22:00:51 2016 +0200

tdf#89307: Removed SvRef::operator T*()

Conditional statements are using SvRef::Is() method.
Changed static_cast<T*>(svRef) occurances to svRef.get().
Added operator == and != to SvRef.

SbxObject::Execute is using SbxVariableRe

[Libreoffice-commits] core.git: desktop/source

2018-07-02 Thread Jacek Fraczek
 desktop/source/migration/migration.cxx   |   30 ++-
 desktop/source/pkgchk/unopkg/unopkg_misc.cxx |7 +-
 2 files changed, 14 insertions(+), 23 deletions(-)

New commits:
commit 10b34eb9f33a19e1189bd822244c04484ae06404
Author: Jacek Fraczek 
Date:   Sat Jun 23 21:28:30 2018 +0200

tdf#88205 Adapt uses of css::uno::Sequence to use initializer_list ctor

Change-Id: Ib06c8ed707bdfd87b294b2597614249fac2c1f18
Reviewed-on: https://gerrit.libreoffice.org/56342
Tested-by: Jenkins
Reviewed-by: Michael Stahl 

diff --git a/desktop/source/migration/migration.cxx 
b/desktop/source/migration/migration.cxx
index a42602bc7204..c40993338e46 100644
--- a/desktop/source/migration/migration.cxx
+++ b/desktop/source/migration/migration.cxx
@@ -240,10 +240,9 @@ bool MigrationImpl::doMigration()
 if (sModuleIdentifier.isEmpty())
 continue;
 
-uno::Sequence< uno::Any > lArgs(2);
-OUString aOldCfgDataPath = m_aInfo.userdata + 
"/user/config/soffice.cfg/modules/";
-lArgs[0] <<= aOldCfgDataPath + i.sModuleShortName;
-lArgs[1] <<= embed::ElementModes::READ;
+
+OUString aOldCfgDataPath = m_aInfo.userdata + 
"/user/config/soffice.cfg/modules/" + i.sModuleShortName;
+uno::Sequence< uno::Any > lArgs {uno::makeAny(aOldCfgDataPath), 
uno::makeAny(embed::ElementModes::READ)};
 
 uno::Reference< uno::XComponentContext > 
xContext(comphelper::getProcessComponentContext());
 uno::Reference< lang::XSingleServiceFactory > 
xStorageFactory(embed::FileSystemStorageFactory::create(xContext));
@@ -769,8 +768,7 @@ uno::Reference< XNameAccess > 
MigrationImpl::getConfigAccess(const sal_Char* pPa
 comphelper::getProcessComponentContext()));
 
 // access the provider
-uno::Sequence< uno::Any > theArgs(1);
-theArgs[ 0 ] <<= sConfigURL;
+uno::Sequence< uno::Any > theArgs {uno::makeAny(sConfigURL)};
 xNameAccess.set(
 theConfigProvider->createInstanceWithArguments(
 sAccessSrvc, theArgs ), uno::UNO_QUERY_THROW );
@@ -870,9 +868,8 @@ std::vector< MigrationModuleInfo > 
MigrationImpl::dectectUIChangesForAllModules(
 const OUString MENUBAR("menubar");
 const OUString TOOLBAR("toolbar");
 
-uno::Sequence< uno::Any > lArgs(2);
-lArgs[0] <<= m_aInfo.userdata + "/user/config/soffice.cfg/modules";
-lArgs[1] <<= embed::ElementModes::READ;
+uno::Sequence< uno::Any > lArgs {uno::makeAny(m_aInfo.userdata + 
"/user/config/soffice.cfg/modules"),
+ uno::makeAny(embed::ElementModes::READ)};
 
 uno::Reference< lang::XSingleServiceFactory > xStorageFactory(
 
embed::FileSystemStorageFactory::create(comphelper::getProcessComponentContext()));
@@ -1046,17 +1043,14 @@ void MigrationImpl::mergeOldToNewVersion(const 
uno::Reference< ui::XUIConfigurat
 }
 }
 
-} while (nIndex>=0);
+} while (nIndex >= 0);
 
 if (nIndex == -1) {
-uno::Sequence< beans::PropertyValue > aPropSeq(3);
-
-aPropSeq[0].Name = ITEM_DESCRIPTOR_COMMANDURL;
-aPropSeq[0].Value <<= elem.m_sCommandURL;
-aPropSeq[1].Name = ITEM_DESCRIPTOR_LABEL;
-aPropSeq[1].Value <<= retrieveLabelFromCommand(elem.m_sCommandURL, 
sModuleIdentifier);
-aPropSeq[2].Name = ITEM_DESCRIPTOR_CONTAINER;
-aPropSeq[2].Value <<= elem.m_xPopupMenu;
+uno::Sequence< beans::PropertyValue > aPropSeq {
+beans::PropertyValue(ITEM_DESCRIPTOR_COMMANDURL, 0, 
uno::makeAny(elem.m_sCommandURL), beans::PropertyState_DIRECT_VALUE),
+beans::PropertyValue(ITEM_DESCRIPTOR_LABEL, 0, 
uno::makeAny(retrieveLabelFromCommand(elem.m_sCommandURL, sModuleIdentifier)), 
beans::PropertyState_DIRECT_VALUE),
+beans::PropertyValue(ITEM_DESCRIPTOR_CONTAINER, 0, 
uno::makeAny(elem.m_xPopupMenu), beans::PropertyState_DIRECT_VALUE)
+};
 
 if (elem.m_sPrevSibling.isEmpty())
 xTemp->insertByIndex(0, uno::makeAny(aPropSeq));
diff --git a/desktop/source/pkgchk/unopkg/unopkg_misc.cxx 
b/desktop/source/pkgchk/unopkg/unopkg_misc.cxx
index 70c8ac5249ee..4a68a61aa52d 100644
--- a/desktop/source/pkgchk/unopkg/unopkg_misc.cxx
+++ b/desktop/source/pkgchk/unopkg/unopkg_misc.cxx
@@ -353,16 +353,13 @@ Reference connectToOffice(
 Reference const & xLocalComponentContext,
 bool verbose )
 {
-Sequence args( 3 );
-args[ 0 ] = "--nologo";
-args[ 1 ] = "--nodefault";
-
 OUString pipeId( ::dp_misc::generateRandomPipeId() );
 OUStringBuffer buf;
 buf.append( "--accept=