[Bug 141908] CppUnittests: replace usage of sal_Int32 with colors
https://bugs.documentfoundation.org/show_bug.cgi?id=141908 --- Comment #48 from Commit Notification --- Rafał Dobrakowski committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/c8b8a2c2cb34a1ae0b0aeee0564b39260258f184 tdf#141908 - CppUnittests: replace usage of sal_Int32 with colors It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 141908] CppUnittests: replace usage of sal_Int32 with colors
https://bugs.documentfoundation.org/show_bug.cgi?id=141908 --- Comment #47 from Commit Notification --- Rafał Dobrakowski committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/72f1800ad2f3717192287ae2678e8209e66e35d1 tdf#141908 - CppUnittests: replace usage of sal_Int32 with colors It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 141908] CppUnittests: replace usage of sal_Int32 with colors
https://bugs.documentfoundation.org/show_bug.cgi?id=141908 Buovjaga changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #46 from Buovjaga --- This is more or less done now, so let's close. Thanks to all involved :) -- You are receiving this mail because: You are the assignee for the bug.
[Bug 141908] CppUnittests: replace usage of sal_Int32 with colors
https://bugs.documentfoundation.org/show_bug.cgi?id=141908 --- Comment #45 from Commit Notification --- Ilmari Lauhakangas committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/9798f383f82897b0021665f50f3a9f8153febbe8 tdf#141908 replace usage of sal_Int32 with colors in xmloff It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 141908] CppUnittests: replace usage of sal_Int32 with colors
https://bugs.documentfoundation.org/show_bug.cgi?id=141908 --- Comment #44 from Commit Notification --- varshneydevansh committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/b370357b40b55cece8407eea2dc0014a5aec0d17 tdf#141908: replace usage of sal_Int32 with colors It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 141908] CppUnittests: replace usage of sal_Int32 with colors
https://bugs.documentfoundation.org/show_bug.cgi?id=141908 --- Comment #43 from Commit Notification --- Luv Sharma committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/ac20b8a470706d239d8782696c6d5fab0d705a2f tdf#141908: replace hex colors with color keywords It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 141908] CppUnittests: replace usage of sal_Int32 with colors
https://bugs.documentfoundation.org/show_bug.cgi?id=141908 --- Comment #42 from Commit Notification --- Kira Tubo committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/8555c3180c367d684af48b7ecb7ceb333fcd0962 tdf#141908: replace hex colors with color keywords It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 141908] CppUnittests: replace usage of sal_Int32 with colors
https://bugs.documentfoundation.org/show_bug.cgi?id=141908 Commit Notification changed: What|Removed |Added Whiteboard|target:7.3.0 target:7.4.0 |target:7.3.0 target:7.4.0 |reviewed:2022 target:7.5.0 |reviewed:2022 target:7.5.0 |target:7.6.0 target:24.2.0 |target:7.6.0 target:24.2.0 ||target:24.8.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141908] CppUnittests: replace usage of sal_Int32 with colors
https://bugs.documentfoundation.org/show_bug.cgi?id=141908 --- Comment #41 from Commit Notification --- khushishikhu committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/3d0a8020f932c0e39a69e555ca4cc4ba7084d2cd tdf#141908 change sal_Int32 to Color It will be available in 24.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141908] CppUnittests: replace usage of sal_Int32 with colors
https://bugs.documentfoundation.org/show_bug.cgi?id=141908 --- Comment #40 from Commit Notification --- Joel Puronaho committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/4bb809f4d1d4316d9723fe6d3c8064c3d974392c tdf#141908: CppUnittests: replace usage of sal_Int32 with colors It will be available in 24.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141908] CppUnittests: replace usage of sal_Int32 with colors
https://bugs.documentfoundation.org/show_bug.cgi?id=141908 --- Comment #39 from Commit Notification --- Ankit_Jaipuriar committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/64fc701388d1dcf8ae36ba2cc73eb5416a7c3374 tdf#141908: CppUnittests: replace usage of sal_Int32 with colors It will be available in 24.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141908] CppUnittests: replace usage of sal_Int32 with colors
https://bugs.documentfoundation.org/show_bug.cgi?id=141908 Commit Notification changed: What|Removed |Added Whiteboard|target:7.3.0 target:7.4.0 |target:7.3.0 target:7.4.0 |reviewed:2022 target:7.5.0 |reviewed:2022 target:7.5.0 |target:7.6.0|target:7.6.0 target:24.2.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141908] CppUnittests: replace usage of sal_Int32 with colors
https://bugs.documentfoundation.org/show_bug.cgi?id=141908 --- Comment #38 from Commit Notification --- Shady Mohamed committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/7228fd770396885bcbee972dbf432f834de19fc5 tdf#141908: CppUnittests: replace usage of sal_Int32 with colors It will be available in 7.6.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141908] CppUnittests: replace usage of sal_Int32 with colors
https://bugs.documentfoundation.org/show_bug.cgi?id=141908 --- Comment #37 from Commit Notification --- Vinit Agarwal committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/df28c5ac2d4883706556772462933f70151fa379 tdf#141908 - CppUnittests: replace usage of sal_Int32 with colors It will be available in 7.6.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141908] CppUnittests: replace usage of sal_Int32 with colors
https://bugs.documentfoundation.org/show_bug.cgi?id=141908 --- Comment #36 from Commit Notification --- ektagoel12 committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/21fbb4b952c7ba5d580c71150ffe9423aaf57f9e tdf#141908 Replace usage of sal_Int32 with Color It will be available in 7.6.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141908] CppUnittests: replace usage of sal_Int32 with colors
https://bugs.documentfoundation.org/show_bug.cgi?id=141908 Commit Notification changed: What|Removed |Added Whiteboard|target:7.3.0 target:7.4.0 |target:7.3.0 target:7.4.0 |reviewed:2022 target:7.5.0 |reviewed:2022 target:7.5.0 ||target:7.6.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141908] CppUnittests: replace usage of sal_Int32 with colors
https://bugs.documentfoundation.org/show_bug.cgi?id=141908 Buovjaga changed: What|Removed |Added Assignee|pramodhkannan1...@gmail.com |libreoffice-b...@lists.free ||desktop.org Status|ASSIGNED|NEW --- Comment #35 from Buovjaga --- Multi-hacks are not assigned. Pramodh: feel free to email me, if you want to start having mentoring sessions. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141908] CppUnittests: replace usage of sal_Int32 with colors
https://bugs.documentfoundation.org/show_bug.cgi?id=141908 Pramodh changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |pramodhkannan1...@gmail.com |desktop.org | --- Comment #34 from Pramodh --- I am starting my work on this bug. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141908] CppUnittests: replace usage of sal_Int32 with colors
https://bugs.documentfoundation.org/show_bug.cgi?id=141908 --- Comment #33 from Commit Notification --- Nalini Prasad Dash committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/aa5e2b24ebca3b36becf77e466eb1702e1f97301 tdf#141908 - CppUnittests: replace usage of sal_Int32 with colors It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141908] CppUnittests: replace usage of sal_Int32 with colors
https://bugs.documentfoundation.org/show_bug.cgi?id=141908 --- Comment #32 from Buovjaga --- As the topic of missing library inclusion came up in a recent patch, I will summarise a discussion that happened on the developer list. Windows builds were failing for a patch and when I asked about the reason, Stephan Bergmann told me that oox/CppunitTest_oox_drawingml.mk needed to have a missing library added to its gb_CppunitTest_use_libraries section. This would allow MSVC compiler to find definitions of SAL_DLLPUBLIC inline functions. I could see the color stuff was in include/tools, but I did not know how to express this in the .mk file. Thinking that the same issue might have appeared before with this easy hack, I checked the result of git log --all --grep=141908 -- '*.mk' Indeed, there was an earlier commit that also had to add the missing library and I learned it has the nickname tl. So this was a quick and dirty way that worked in this case, but surely there are better ways for discovery. Others gave more advice in the developer chat: - Sometimes the gbuild library name can be immediately seen in a file name, in this case tools/Library_tl.mk This is not always the case and the real name can be verified by looking at the $(eval $(call gb_Library_Library,tl)) line in the .mk file - Find the .cxx file that implements the thing you want to link to, in this case tools/source/generic/color.cxx and do a search like: git grep -l tools/source/generic/color -- '*.mk' This will reveal the gbuild library name you want. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141908] CppUnittests: replace usage of sal_Int32 with colors
https://bugs.documentfoundation.org/show_bug.cgi?id=141908 --- Comment #31 from Nalini --- (In reply to Buovjaga from comment #30) > (In reply to Nalini from comment #29) > > Looks like all instances of 'sal_Int32' have been replaced by 'Color'(The > > three remaining are from commented out portions). > > You are right. However, it looks like there are some of these still: > > (In reply to Xisco Faulí from comment #1) > > While on it, 0xff can be converted to COL_WHITE and 0x00 to > > COL_BLACK > > Found via: > git grep -Fn "0xff" */qa*.cxx > git grep -Fn "0x00" */qa*.cxx I have submitted a patch related to this, please review it. Link:https://gerrit.libreoffice.org/c/core/+/141685 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141908] CppUnittests: replace usage of sal_Int32 with colors
https://bugs.documentfoundation.org/show_bug.cgi?id=141908 Buovjaga changed: What|Removed |Added CC||nalinid...@protonmail.ch --- Comment #30 from Buovjaga --- (In reply to Nalini from comment #29) > Looks like all instances of 'sal_Int32' have been replaced by 'Color'(The > three remaining are from commented out portions). You are right. However, it looks like there are some of these still: (In reply to Xisco Faulí from comment #1) > While on it, 0xff can be converted to COL_WHITE and 0x00 to COL_BLACK Found via: git grep -Fn "0xff" */qa*.cxx git grep -Fn "0x00" */qa*.cxx -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141908] CppUnittests: replace usage of sal_Int32 with colors
https://bugs.documentfoundation.org/show_bug.cgi?id=141908 --- Comment #29 from Nalini --- Looks like all instances of 'sal_Int32' have been replaced by 'Color'(The three remaining are from commented out portions). -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141908] CppUnittests: replace usage of sal_Int32 with colors
https://bugs.documentfoundation.org/show_bug.cgi?id=141908 --- Comment #28 from Commit Notification --- cutamar committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/45394fcf7e45f623add7ed3c6dc43e6d6f89158c tdf#141908 Replace usage of sal_Int32 with Color in unit tests It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141908] CppUnittests: replace usage of sal_Int32 with colors
https://bugs.documentfoundation.org/show_bug.cgi?id=141908 Commit Notification changed: What|Removed |Added Whiteboard|target:7.3.0 target:7.4.0 |target:7.3.0 target:7.4.0 |reviewed:2022 |reviewed:2022 target:7.5.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141908] CppUnittests: replace usage of sal_Int32 with colors
https://bugs.documentfoundation.org/show_bug.cgi?id=141908 --- Comment #27 from Amar --- Hi I've added a patch for most of the 23 occurrences, and left one question. Can somebody review it? https://gerrit.libreoffice.org/c/core/+/138938 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141908] CppUnittests: replace usage of sal_Int32 with colors
https://bugs.documentfoundation.org/show_bug.cgi?id=141908 Hossein changed: What|Removed |Added Status|ASSIGNED|NEW Assignee|robertnyamug...@gmail.com |libreoffice-b...@lists.free ||desktop.org --- Comment #26 from Hossein --- (In reply to robertnyamugada from comment #25) > I'm getting my hands on this bug OK, go on! But please let it remain in the NEW status, as multiple people can work on this issue at the same time. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141908] CppUnittests: replace usage of sal_Int32 with colors
https://bugs.documentfoundation.org/show_bug.cgi?id=141908 robertnyamug...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |robertnyamug...@gmail.com |desktop.org | CC||robertnyamug...@gmail.com -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141908] CppUnittests: replace usage of sal_Int32 with colors
https://bugs.documentfoundation.org/show_bug.cgi?id=141908 Hossein changed: What|Removed |Added Whiteboard|target:7.3.0 target:7.4.0 |target:7.3.0 target:7.4.0 ||reviewed:2022 --- Comment #24 from Hossein --- Re-evaluating the EasyHack in 2022 This issue is still relevant. The below search shows 23 instances: $ git grep -Fn "CPPUNIT_ASSERT_EQUAL(sal_Int32(0x"|grep -i color -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141908] CppUnittests: replace usage of sal_Int32 with colors
https://bugs.documentfoundation.org/show_bug.cgi?id=141908 Aron Budea changed: What|Removed |Added Blocks||143781 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=143781 [Bug 143781] [META] Development- and code-related bug reports and tasks -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141908] CppUnittests: replace usage of sal_Int32 with colors
https://bugs.documentfoundation.org/show_bug.cgi?id=141908 --- Comment #23 from Commit Notification --- Siddhant Chaudhary committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/8351179b787a10167e9e68584d3b3573fbdb6ebc tdf#141908 Replaced usage of sal_Int32 and sal_uInt32 with Color in unit tests. It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141908] CppUnittests: replace usage of sal_Int32 with colors
https://bugs.documentfoundation.org/show_bug.cgi?id=141908 --- Comment #22 from Commit Notification --- Tushar Jham committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/00937d1207394433970a4711fa4f51b072341290 tdf#141908:CppUnittests: replace usage of sal_Int32 with Color It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141908] CppUnittests: replace usage of sal_Int32 with colors
https://bugs.documentfoundation.org/show_bug.cgi?id=141908 --- Comment #21 from Siddhant Chaudhary --- Hi. I've added a patch for this on gerrit: https://gerrit.libreoffice.org/c/core/+/131408/1. Can someone please review it? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141908] CppUnittests: replace usage of sal_Int32 with colors
https://bugs.documentfoundation.org/show_bug.cgi?id=141908 Buovjaga changed: What|Removed |Added Assignee|urss...@gmail.com |libreoffice-b...@lists.free ||desktop.org --- Comment #20 from Buovjaga --- Multi-hacks not assigned -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141908] CppUnittests: replace usage of sal_Int32 with colors
https://bugs.documentfoundation.org/show_bug.cgi?id=141908 Siddhant Chaudhary changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |urss...@gmail.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141908] CppUnittests: replace usage of sal_Int32 with colors
https://bugs.documentfoundation.org/show_bug.cgi?id=141908 --- Comment #18 from Commit Notification --- Harshita Nag committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/6125517102493341b8172acd463dd9126afa7a64 tdf#141908: CppUnittests: replace usage of sal_Int32 with Color It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141908] CppUnittests: replace usage of sal_Int32 with colors
https://bugs.documentfoundation.org/show_bug.cgi?id=141908 --- Comment #17 from Libreoffice user SSO --- I would like to work on it -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141908] CppUnittests: replace usage of sal_Int32 with colors
https://bugs.documentfoundation.org/show_bug.cgi?id=141908 --- Comment #16 from Commit Notification --- VaibhavMalik4187 committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/c02dc02a98ff58e88cf0d6f805fcb5c2b7fb1cc7 tdf#141908: CppUnittests: replace usage of sal_Int32 with Color It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141908] CppUnittests: replace usage of sal_Int32 with colors
https://bugs.documentfoundation.org/show_bug.cgi?id=141908 --- Comment #15 from Commit Notification --- VaibhavMalik4187 committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/5fa0f02dace4538b0948bceddc23a9f55e1bf8a3 tdf#141908: CppUnittests: replace usage of sal_Int32 with Color It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141908] CppUnittests: replace usage of sal_Int32 with colors
https://bugs.documentfoundation.org/show_bug.cgi?id=141908 --- Comment #14 from Commit Notification --- VaibhavMalik4187 committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/bbfce0b49fb11997af8eb03d40431b6a78f2aebe tdf#141908 replaced sal_Int32 with Color It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141908] CppUnittests: replace usage of sal_Int32 with colors
https://bugs.documentfoundation.org/show_bug.cgi?id=141908 Commit Notification changed: What|Removed |Added Whiteboard|target:7.3.0|target:7.3.0 target:7.4.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141908] CppUnittests: replace usage of sal_Int32 with colors
https://bugs.documentfoundation.org/show_bug.cgi?id=141908 --- Comment #13 from Commit Notification --- Rishav Chattopadhya committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/7a8cbfafca1906baad2bcbf8aa6717d197ae423a tdf#141908: CppUnittests: replace usage of sal_Int32 with colors It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141908] CppUnittests: replace usage of sal_Int32 with colors
https://bugs.documentfoundation.org/show_bug.cgi?id=141908 --- Comment #12 from Commit Notification --- Henrik Palomäki committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/1637f4449c10ec1f8869498ba0cafc61a8a77bbf tdf#141908 replace usage of sal_Int32 with colors in htmlexport It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141908] CppUnittests: replace usage of sal_Int32 with colors
https://bugs.documentfoundation.org/show_bug.cgi?id=141908 --- Comment #11 from Commit Notification --- 4k5h1t committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/179e0c0cc5d3fd9610574e45a5204584f0e39176 tdf#141908: CppUnittests: replace usage of sal_Int32 with colors It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141908] CppUnittests: replace usage of sal_Int32 with colors
https://bugs.documentfoundation.org/show_bug.cgi?id=141908 --- Comment #10 from Commit Notification --- 4k5h1t committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/31ded6f8718a90c7b3b9eb36909c2b7a0c6e9b68 tdf#141908 - CppUnittests: replace usage of sal_Int32 with color It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141908] CppUnittests: replace usage of sal_Int32 with colors
https://bugs.documentfoundation.org/show_bug.cgi?id=141908 --- Comment #9 from Rishav Chattopadhya --- (In reply to Buovjaga from comment #8) Thanks! -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141908] CppUnittests: replace usage of sal_Int32 with colors
https://bugs.documentfoundation.org/show_bug.cgi?id=141908 --- Comment #8 from Buovjaga --- (In reply to Rishav Chattopadhya from comment #7) > (In reply to Xisco Faulí from comment #0) > I have submitted a patch related to this. Please review it. It is my first > time submitting a patch on gerrit. You forgot to mention the link, but here it is https://gerrit.libreoffice.org/c/core/+/124091 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141908] CppUnittests: replace usage of sal_Int32 with colors
https://bugs.documentfoundation.org/show_bug.cgi?id=141908 --- Comment #7 from rishavchatterjee1...@gmail.com --- (In reply to Xisco Faulí from comment #0) I have submitted a patch related to this. Please review it. It is my first time submitting a patch on gerrit. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141908] CppUnittests: replace usage of sal_Int32 with colors
https://bugs.documentfoundation.org/show_bug.cgi?id=141908 --- Comment #6 from Commit Notification --- Baran Aytas committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/7b3a681a867eeb2d68abd4ce33b07cabfff224ef tdf#141908: replace usage of sal_Int32 with colors It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141908] CppUnittests: replace usage of sal_Int32 with colors
https://bugs.documentfoundation.org/show_bug.cgi?id=141908 Hossein changed: What|Removed |Added Assignee|fsociety...@hotmail.com |libreoffice-b...@lists.free ||desktop.org Status|ASSIGNED|NEW -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141908] CppUnittests: replace usage of sal_Int32 with colors
https://bugs.documentfoundation.org/show_bug.cgi?id=141908 Prasad Chavan changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |fsociety...@hotmail.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141908] CppUnittests: replace usage of sal_Int32 with colors
https://bugs.documentfoundation.org/show_bug.cgi?id=141908 --- Comment #3 from Xisco Faulí --- (In reply to Radhey Parekh from comment #2) > I would like to look in to this issue. Sure, looking forward to seeing a patch submitted to gerrit -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141908] CppUnittests: replace usage of sal_Int32 with colors
https://bugs.documentfoundation.org/show_bug.cgi?id=141908 Radhey Parekh changed: What|Removed |Added Status|NEW |ASSIGNED CC||radhey.par...@gmail.com -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141908] CppUnittests: replace usage of sal_Int32 with colors
https://bugs.documentfoundation.org/show_bug.cgi?id=141908 --- Comment #2 from Radhey Parekh --- I would like to look in to this issue. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141908] CppUnittests: replace usage of sal_Int32 with colors
https://bugs.documentfoundation.org/show_bug.cgi?id=141908 --- Comment #1 from Xisco Faulí --- While on it, 0xff can be converted to COL_WHITE and 0x00 to COL_BLACK -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141908] CppUnittests: replace usage of sal_Int32 with colors
https://bugs.documentfoundation.org/show_bug.cgi?id=141908 Xisco Faulí changed: What|Removed |Added Keywords||difficultyBeginner, ||easyHack, skillCpp, ||topicCleanup Ever confirmed|0 |1 Status|UNCONFIRMED |NEW CC||xiscofa...@libreoffice.org -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
