[Bug 158353] FILEOPEN XLSX Wrong round

2024-03-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158353

--- Comment #12 from Mike Kaganski  ---
Aha: I already tried to fix the save problem in
https://gerrit.libreoffice.org/c/core/+/151383 ...

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158353] FILEOPEN XLSX Wrong round

2024-03-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158353

--- Comment #11 from Mike Kaganski  ---
https://gerrit.libreoffice.org/c/core/+/165142 will take care of the display
issue. However, let me make this issue strictly about the problem of wrong
number roundtrip: the value of 57.3749993, that is stored in the
original file, must stay 57.3749993 (or 57.374999, which
represents the same IEEE 754 64-bit binary value) on export, and must not be
rounded to 57.375 in the file.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158353] FILEOPEN XLSX Wrong round

2024-03-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158353

Mike Kaganski  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=16
   ||0306

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158353] FILEOPEN XLSX Wrong round

2024-03-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158353

--- Comment #10 from Mike Kaganski  ---
(In reply to Thorsten Behrens (allotropia) from comment #9)

:-) It may be true, but completely orthogonal to the clarification requested in
my question? ;-)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158353] FILEOPEN XLSX Wrong round

2024-03-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158353

Thorsten Behrens (allotropia)  changed:

   What|Removed |Added

 CC||er...@redhat.com,
   ||t...@libreoffice.org

--- Comment #9 from Thorsten Behrens (allotropia)  ---
(In reply to Mike Kaganski from comment #6)
> (In reply to Gabor Kelemen (allotropia) from comment #5)
> > Seems to have started with:
> 
> Started specifically what? The more numerically correct display, or the
> wrong save?

I guess for an XLSX file, the only correct way is to load & display it as Excel
does?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158353] FILEOPEN XLSX Wrong round

2023-11-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158353

--- Comment #8 from ady  ---
(In reply to Gabor Kelemen (allotropia) from comment #7)
> Did not check what happens after save.

Please see comment 4. According to Mike, the problem is about either the file
save or the file open, not really about the rounded result (57.37).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158353] FILEOPEN XLSX Wrong round

2023-11-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158353

--- Comment #7 from Gabor Kelemen (allotropia)  ---
(In reply to Mike Kaganski from comment #6)
> (In reply to Gabor Kelemen (allotropia) from comment #5)
> > Seems to have started with:
> 
> Started specifically what? The more numerically correct display, or the
> wrong save?

The fileopen difference on the attached file.
In 7.3 all 4 cells were displayed as 57.38
Since 7.4 the first two A1:A2 are 57.37 the second two A3:A4 are 57.38.
Did not check what happens after save.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158353] FILEOPEN XLSX Wrong round

2023-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158353

--- Comment #6 from Mike Kaganski  ---
(In reply to Gabor Kelemen (allotropia) from comment #5)
> Seems to have started with:

Started specifically what? The more numerically correct display, or the wrong
save?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158353] FILEOPEN XLSX Wrong round

2023-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158353

Gabor Kelemen (allotropia)  changed:

   What|Removed |Added

 Blocks||108897
 CC||kelem...@ubuntu.com
   Keywords||bibisected, bisected,
   ||regression

--- Comment #5 from Gabor Kelemen (allotropia)  ---
Seems to have started with:

https://git.libreoffice.org/core/+/9eb9083ff2fdaeb96399a0830a4394de4e29ef64

author  Mike Kaganski  Tue Feb 15 09:20:52
2022 +0300
committer   Mike Kaganski  Thu Feb 17
21:46:58 2022 +0100

Use Dragonbox to implement doubleTo*String*


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=108897
[Bug 108897] [META] XLSX (OOXML) bug tracker
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158353] FILEOPEN XLSX Wrong round

2023-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158353

Mike Kaganski  changed:

   What|Removed |Added

 Status|RESOLVED|NEW
 Ever confirmed|0   |1
 Resolution|DUPLICATE   |---

--- Comment #4 from Mike Kaganski  ---
Yes you are right. It is different.

While rounding to 2 decimals here looks technically correct (it is smaller than
57.375), the problem of changing the value on save-and-reload is real.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158353] FILEOPEN XLSX Wrong round

2023-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158353

--- Comment #3 from Maxim Britov  ---
(In reply to Mike Kaganski from comment #2)
> 
> *** This bug has been marked as a duplicate of bug 158190 ***

Is this issue really dup of round() issue?
Here is not used round(). This is just a file from Excel.

1. Excel show 57.38 and LO show 57.37
2. If I change value, but restore 57.375 and save cell, I see 57.38
3. If I save and reopen I see 57.38
4. If I set option "Precision as shown" then =A1*100 will be 5738
   This is really wrong!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158353] FILEOPEN XLSX Wrong round

2023-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158353

Mike Kaganski  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|UNCONFIRMED |RESOLVED

--- Comment #2 from Mike Kaganski  ---


*** This bug has been marked as a duplicate of bug 158190 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158353] FILEOPEN XLSX Wrong round

2023-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158353

--- Comment #1 from Maxim Britov  ---
Created attachment 191019
  --> https://bugs.documentfoundation.org/attachment.cgi?id=191019=edit
Simple sample

Open in with LO >=7.4 and in LO 7.3. See difference

-- 
You are receiving this mail because:
You are the assignee for the bug.