[Bug 158407] Deactivate "Toggle Point Edit Mode" (.uno:ToggleObjectBezierMode ) for selected shapes that cannot use the "Edit Points" toolbar
https://bugs.documentfoundation.org/show_bug.cgi?id=158407 --- Comment #12 from Regina Henschel --- (In reply to sdc.blanco from comment #8) > 2. Shapes (i.e., Basic Shapes, Symbol Shapes, Block Arrows, Stars and > Banners, Callout Shapes, Flowchart) > 3. Fontwork Text > 6. Custom Shapes The category 'Basic Shapes' contains the legacy arc and segment. All other shapes in your point 2 are 'Custom Shapes' 'Fontwork Text' shapes are 'Custom Shapes' from a technical point of view. In general, 'Custom Shapes' are all shapes, for which the icon 'Toggle Extrusion' is enabled. [..] > > Math-objects and comments in Calc are rendered as if mode (B) exists, but > > the handle is not moveable. => Bug > Will you file a ticket for this? bug 158640 and bug 158641. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158407] Deactivate "Toggle Point Edit Mode" (.uno:ToggleObjectBezierMode ) for selected shapes that cannot use the "Edit Points" toolbar
https://bugs.documentfoundation.org/show_bug.cgi?id=158407 --- Comment #11 from Heiko Tietze --- (In reply to sdc.blanco from comment #10) > ...this option is not in the menus Good point, the menubar has this command only for Calc, Draw, and Impress (and some/all notebookbar variants). Toolbars with the command in sw/uiconfig/swriter/toolbar/ are bezierobjectbar.xml singlemode-draw.xml drawbar.xml drawingobjectbar.xml -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158407] Deactivate "Toggle Point Edit Mode" (.uno:ToggleObjectBezierMode ) for selected shapes that cannot use the "Edit Points" toolbar
https://bugs.documentfoundation.org/show_bug.cgi?id=158407 --- Comment #10 from sdc.bla...@youmail.dk --- (In reply to Heiko Tietze from comment #9) Thanks Heiko. > (In reply to sdc.blanco from comment #2) > > There is no need/reason for this option in the context menu. > I would remove the toggle from the context menu. Further experience and better understanding leads me to believe that it is appropriate to leave the option in the context menu, but deactivate it as noted in comment 8. Reason: If Drawing bar is not open, then there would be no way to get to the Toggle icon (without opening the Drawing bar), because this option is not in the menus. The need to use the context menu is particularly relevant for lines, curves, and polygons, where the icon in the context menu would be used to open the "Edit Points" toolbar. As bug 154934 notes, there is no way to keep the "Edit Points" toolbar open, after leaving the edit points mode, so for lines, curves, polygons, it would be preferable/easier to use the context menu, rather than keep the Drawing bar open, and use it to toggle. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158407] Deactivate "Toggle Point Edit Mode" (.uno:ToggleObjectBezierMode ) for selected shapes that cannot use the "Edit Points" toolbar
https://bugs.documentfoundation.org/show_bug.cgi?id=158407 Heiko Tietze changed: What|Removed |Added Keywords||difficultyMedium, easyHack, ||skillCpp, topicUI CC||mentoring@documentfoundatio ||n.org --- Comment #9 from Heiko Tietze --- (In reply to sdc.blanco from comment #8) > > If a point edit mode is not possible for an object, then the icon "Toggle > > Point Edit Mode" in a toolbar should be drawn as inactive. > ... > @Heiko – maybe this is an EasyHack? svx.sdi -> SfxVoidItem ToggleObjectBezierMode SID_BEZIER_EDIT in sw/source/uibase/shells/drawsh.cxx ... case SID_BEZIER_EDIT: (In reply to sdc.blanco from comment #2) > There is no need/reason for this option in the context menu. I would remove the toggle from the context menu. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158407] Deactivate "Toggle Point Edit Mode" (.uno:ToggleObjectBezierMode ) for selected shapes that cannot use the "Edit Points" toolbar
https://bugs.documentfoundation.org/show_bug.cgi?id=158407 --- Comment #8 from sdc.bla...@youmail.dk --- (In reply to Regina Henschel from comment #7) Many thanks for the detailed comments. Very helpful. Now I will try to summarise what is needed. > If a point edit mode is not possible for an object, then the icon "Toggle > Point Edit Mode" in a toolbar should be drawn as inactive. This is the main point of this ticket, where both the context menu and the toolbar would show the icon/command as inactive. iiuc, this command (.uno:ToggleObjectBezierMode) should be INACTIVE for: 1. Textboxes 2. Shapes (i.e., Basic Shapes, Symbol Shapes, Block Arrows, Stars and Banners, Callout Shapes, Flowchart) 3. Fontwork Text 4. QR codes 5. Connectors 6. Custom Shapes The command should remain active for: 1. legacy rectangles 2. legacy arc, pie and segment 3. lines 4. polygons, polylines, Bezier curves, freeform objects @Heiko – maybe this is an EasyHack? > Math-objects and comments in Calc are rendered as if mode (B) exists, but > the handle is not moveable. => Bug Will you file a ticket for this? -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158407] Deactivate "Toggle Point Edit Mode" (.uno:ToggleObjectBezierMode ) for selected shapes that cannot use the "Edit Points" toolbar
https://bugs.documentfoundation.org/show_bug.cgi?id=158407 --- Comment #7 from Regina Henschel --- The point edit mode is not only used to edit points (A), but it is used to enable handles (B) for some shape types as well. In the latter case the command does not open a toolbar, but changes the shape view between 'handle' and 'normal'. The point edit mode is needed for the shape types: legacy rectangles (B) legacy arc, pie and segment (B) lines (A) Polygons, polylines, Bezier curves, freeform objects (A) Text box shapes, related callout shapes, and presentation objects (title, ... in Impress) are always in mode (B). The toolbar icon has no effect. The icon is not drawn as 'on'. Not sure how to handle the icon. A point edit mode does not exist for custom shapes, including Fontwork shapes. The toggle item should be removed from context menu. Users coming from PowerPoint might expect it, but it is not implemented in LibreOffice. Feature request is in bug 144041. A point edit mode does note exist for measure lines, not for connectors and not for QR-code shapes. The toggle item should be removed from context menu. A point edit mode does not exist for controls, images and media shapes. But they have already no item in context menu, so nothing to do for them. Math-objects and comments in Calc are rendered as if mode (B) exists, but the handle is not moveable. => Bug If a point edit mode is not possible for an object, then the icon "Toggle Point Edit Mode" in a toolbar should be drawn as inactive. I have tested the above with current master. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158407] Deactivate "Toggle Point Edit Mode" (.uno:ToggleObjectBezierMode ) for selected shapes that cannot use the "Edit Points" toolbar
https://bugs.documentfoundation.org/show_bug.cgi?id=158407 --- Comment #6 from sdc.bla...@youmail.dk --- (In reply to Dieter from comment #3) > command should be at least greyed out and docmentation should be updated. bug 130024 notes many other problems in help for "Edit Points" toolbar. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158407] Deactivate "Toggle Point Edit Mode" (.uno:ToggleObjectBezierMode ) for selected shapes that cannot use the "Edit Points" toolbar
https://bugs.documentfoundation.org/show_bug.cgi?id=158407 sdc.bla...@youmail.dk changed: What|Removed |Added Summary|Deactivate "Toggle Point|Deactivate "Toggle Point |Edit Mode" |Edit Mode" |(.uno:ToggleBezierEditMode) |(.uno:ToggleObjectBezierMod |for selected shapes that|e ) for selected shapes |cannot use the "Edit|that cannot use the "Edit |Points" toolbar |Points" toolbar --- Comment #5 from sdc.bla...@youmail.dk --- In reply to sdc.blanco from comment #4) > 1. The "Toggle Point Edit Mode" (.uno:ToggleBezierEditMode) Spelling clarification: should be: .uno:ToggleObjectBezierMode -- You are receiving this mail because: You are the assignee for the bug.
