[Bug 158773] FILEOPEN PPTX Slow loading of file with lots of unused master pages
https://bugs.documentfoundation.org/show_bug.cgi?id=158773 --- Comment #35 from Commit Notification --- Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/41581fe7d782f261c19594c89875666f99c91af1 fix 'tdf#158773 reduce dynamic_cast'ing in CustomShapeProperties::Notify' It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158773] FILEOPEN PPTX Slow loading of file with lots of unused master pages
https://bugs.documentfoundation.org/show_bug.cgi?id=158773 --- Comment #34 from Timur --- I do not think it is realistic to expect more speed up here. Not it is useful to keep this open for a long time. Should someone want to speed up more, ticket remains here for a reference. IMO way to go is warning to remove excessive unused slides, bug 159860. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158773] FILEOPEN PPTX Slow loading of file with lots of unused master pages
https://bugs.documentfoundation.org/show_bug.cgi?id=158773 --- Comment #33 from Gerald Pfeifer --- (In reply to Gerald Pfeifer from comment #30) > As for closing this issue - isn't it still to flow from a user > perspective? ...too slow... -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158773] FILEOPEN PPTX Slow loading of file with lots of unused master pages
https://bugs.documentfoundation.org/show_bug.cgi?id=158773 --- Comment #32 from Commit Notification --- Noel Grandin committed a patch related to this issue. It has been pushed to "libreoffice-24-2": https://git.libreoffice.org/core/commit/d83d68f120ad3ccfc036e25cf9d5b04fb36f7c8b tdf#158773 reduce cost of TextProperties::Notify It will be available in 24.2.3. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158773] FILEOPEN PPTX Slow loading of file with lots of unused master pages
https://bugs.documentfoundation.org/show_bug.cgi?id=158773 Commit Notification changed: What|Removed |Added Whiteboard|target:24.8.0 |target:24.8.0 target:24.2.3 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158773] FILEOPEN PPTX Slow loading of file with lots of unused master pages
https://bugs.documentfoundation.org/show_bug.cgi?id=158773 --- Comment #31 from Xisco Faulí --- I backported 3b784236d7c3bf386deeeadcf79d9e9b289bf991 to libreoffice-24-2 -> https://gerrit.libreoffice.org/c/core/+/165112 which for me reduces the import time from 30 seconds to 22 seconds. I'm hesitant to backport all the commits... -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158773] FILEOPEN PPTX Slow loading of file with lots of unused master pages
https://bugs.documentfoundation.org/show_bug.cgi?id=158773 --- Comment #30 from Gerald Pfeifer --- (In reply to Timur from comment #27) > All this improved load time from 18 to 8 seconds for me. Meaning that > improvemnt is very tangible. I suggest this be closed as Fixed. The improvement is great, and I am very grateful to Noel and his meticulous persistence. As for closing this issue - isn't it still to flow from a user perspective? -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158773] FILEOPEN PPTX Slow loading of file with lots of unused master pages
https://bugs.documentfoundation.org/show_bug.cgi?id=158773 Julien Nabet changed: What|Removed |Added Attachment #193044|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158773] FILEOPEN PPTX Slow loading of file with lots of unused master pages
https://bugs.documentfoundation.org/show_bug.cgi?id=158773 --- Comment #29 from Julien Nabet --- Created attachment 193108 --> https://bugs.documentfoundation.org/attachment.cgi?id=193108=edit Flamegraph 3 Here's an updated Flamegraph retrieved on pc Debian x86-64 with master sources updated today. Just in case if someone has some idea to improve perf even more. Of course, perfs already improved greatly, thank you Noel! :-) -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158773] FILEOPEN PPTX Slow loading of file with lots of unused master pages
https://bugs.documentfoundation.org/show_bug.cgi?id=158773 --- Comment #28 from Gerald Pfeifer --- That's been a great job, chiselling at it piece by piece, Noel - kudos and thank you! Some timings (user, not system) on a 13th Gen Intel(R) Core(TM) i5-1345U: 20240301: 19,008s 20240307: 13,427s 20240308: 11,790s 20240309: 7,767s 20240310: 7,568s 20240311: 7,087s 20240312: 7,127s Once nice "side effect" of this - which you (or we, as in LibreOffice) should promote - is that this also helps simpler documents. It is an improvement across the board! -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158773] FILEOPEN PPTX Slow loading of file with lots of unused master pages
https://bugs.documentfoundation.org/show_bug.cgi?id=158773 --- Comment #27 from Timur --- All this improved load time from 18 to 8 seconds for me. Meaning that improvemnt is very tangible. I suggest this be closed as Fixed. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158773] FILEOPEN PPTX Slow loading of file with lots of unused master pages
https://bugs.documentfoundation.org/show_bug.cgi?id=158773 Timur changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||9860 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158773] FILEOPEN PPTX Slow loading of file with lots of unused master pages
https://bugs.documentfoundation.org/show_bug.cgi?id=158773 --- Comment #26 from Commit Notification --- Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/ae351d9d5fc4fc3c0e02853e0a974791e41786fe tdf#158773 reduce cost of importing binary data It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158773] FILEOPEN PPTX Slow loading of file with lots of unused master pages
https://bugs.documentfoundation.org/show_bug.cgi?id=158773 --- Comment #25 from Julien Nabet --- Thank you Noel for all the optimizations. I read your last comment about the fact you saw no other paths to optimize, but, just in case, I've submitted a new Flamegraph. Thank you again! :-) -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158773] FILEOPEN PPTX Slow loading of file with lots of unused master pages
https://bugs.documentfoundation.org/show_bug.cgi?id=158773 Julien Nabet changed: What|Removed |Added Attachment #192982|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158773] FILEOPEN PPTX Slow loading of file with lots of unused master pages
https://bugs.documentfoundation.org/show_bug.cgi?id=158773 --- Comment #24 from Julien Nabet --- Created attachment 193044 --> https://bugs.documentfoundation.org/attachment.cgi?id=193044=edit Flamegraph 2 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158773] FILEOPEN PPTX Slow loading of file with lots of unused master pages
https://bugs.documentfoundation.org/show_bug.cgi?id=158773 --- Comment #23 from Noel Grandin --- I'm done with this for now. I don't see any paths to further progress, but someone else might have more luck, -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158773] FILEOPEN PPTX Slow loading of file with lots of unused master pages
https://bugs.documentfoundation.org/show_bug.cgi?id=158773 --- Comment #22 from Commit Notification --- Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/5f62629af6d12d505b029db85c276daedf5017b1 tdf#158773 avoid Reindex() until we are done renaming It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158773] FILEOPEN PPTX Slow loading of file with lots of unused master pages
https://bugs.documentfoundation.org/show_bug.cgi?id=158773 --- Comment #21 from Commit Notification --- Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/959b30841ae9c5cc1f43928f5e7780abaab4a087 tdf#158773 avoid some OUString construction It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158773] FILEOPEN PPTX Slow loading of file with lots of unused master pages
https://bugs.documentfoundation.org/show_bug.cgi?id=158773 --- Comment #20 from Commit Notification --- Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/632fc28fda03e312b2eb2d5843459b3ceee43534 tdf#158773 add a set to sd::ShapeList It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158773] FILEOPEN PPTX Slow loading of file with lots of unused master pages
https://bugs.documentfoundation.org/show_bug.cgi?id=158773 --- Comment #19 from Commit Notification --- Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/6a3b20b14d32922c99df4ad65271499d0a8d663e tdf#158773 do the cheap checks first It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158773] FILEOPEN PPTX Slow loading of file with lots of unused master pages
https://bugs.documentfoundation.org/show_bug.cgi?id=158773 --- Comment #18 from Commit Notification --- Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/6441778b61d1c6737947551e55d2c27e79260142 tdf#158773 reduce size of IndexedStyleSheets It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158773] FILEOPEN PPTX Slow loading of file with lots of unused master pages
https://bugs.documentfoundation.org/show_bug.cgi?id=158773 --- Comment #17 from Commit Notification --- Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/02f88f45e681beacf611f7c20f7903916b7e7374 tdf#158773 reduce cost of stylesheet lookup It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158773] FILEOPEN PPTX Slow loading of file with lots of unused master pages
https://bugs.documentfoundation.org/show_bug.cgi?id=158773 --- Comment #16 from Commit Notification --- Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/5cd557a512551ae5033957e22ea5c5f285518be3 tdf#158773 GetNumberOfStyleSheets can be an inline method It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158773] FILEOPEN PPTX Slow loading of file with lots of unused master pages
https://bugs.documentfoundation.org/show_bug.cgi?id=158773 --- Comment #15 from Commit Notification --- Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/1406e7b2f01a88377649c763cd65d20803c3c3a6 tdf#158773 flatten data of IndexedStyleSheets It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158773] FILEOPEN PPTX Slow loading of file with lots of unused master pages
https://bugs.documentfoundation.org/show_bug.cgi?id=158773 --- Comment #14 from Commit Notification --- Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/4a30c919373940025024442d9607da06258bb552 tdf#158773 reduce dynamic_cast in AttributeProperties::Notify It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158773] FILEOPEN PPTX Slow loading of file with lots of unused master pages
https://bugs.documentfoundation.org/show_bug.cgi?id=158773 --- Comment #13 from Commit Notification --- Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/34017b14d866e99aff466ff200b60b3e2d509a30 tdf#158773 reduce time spent in IndexedStyleSheets::Reindex It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158773] FILEOPEN PPTX Slow loading of file with lots of unused master pages
https://bugs.documentfoundation.org/show_bug.cgi?id=158773 --- Comment #12 from Commit Notification --- Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/06d444e9a102569aa6cf429079036fc95482cc7f tdf#158773 reduce dynamic_cast'ing in TextProperties::Notify It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158773] FILEOPEN PPTX Slow loading of file with lots of unused master pages
https://bugs.documentfoundation.org/show_bug.cgi?id=158773 --- Comment #11 from Xisco Faulí --- Using 'time OOO_EXIT_POST_STARTUP=1 instdir/program/soffice /home/xisco/Descargas/rogueimage.pptx' it takes real0m37,018s user0m36,065s sys 0m0,927s in LibreOfficeDev 24.8.0.0.alpha0 e66f5cb353bc0ea1020061bab4981380f98499b9 while it takes real0m18,879s user0m18,051s sys 0m0,952s in LibreOfficeDev 24.8.0.0.alpha0 825dde03999a55d02e4d5bc88a4d5beacb65e67f -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158773] FILEOPEN PPTX Slow loading of file with lots of unused master pages
https://bugs.documentfoundation.org/show_bug.cgi?id=158773 --- Comment #10 from Commit Notification --- Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/9c5fda14fff397d5d503f749ad019791d7e4ef83 tdf#158773 reduce dynamic_cast'ing in CustomShapeProperties::Notify It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158773] FILEOPEN PPTX Slow loading of file with lots of unused master pages
https://bugs.documentfoundation.org/show_bug.cgi?id=158773 --- Comment #9 from Commit Notification --- Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/3b784236d7c3bf386deeeadcf79d9e9b289bf991 tdf#158773 reduce cost of TextProperties::Notify It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158773] FILEOPEN PPTX Slow loading of file with lots of unused master pages
https://bugs.documentfoundation.org/show_bug.cgi?id=158773 --- Comment #8 from Commit Notification --- Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/f1552be34859d92865067c296b328770c83580e7 tdf#158773 reduce dynamic_cast'ing in CustomShapeProperties::Notify It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158773] FILEOPEN PPTX Slow loading of file with lots of unused master pages
https://bugs.documentfoundation.org/show_bug.cgi?id=158773 --- Comment #7 from Commit Notification --- Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/6f8073caf0d6b331232f6edb5f18d14ddefdb465 tdf#158773 reduce cost of ContentInfo::GetText It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158773] FILEOPEN PPTX Slow loading of file with lots of unused master pages
https://bugs.documentfoundation.org/show_bug.cgi?id=158773 Commit Notification changed: What|Removed |Added Whiteboard||target:24.8.0 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158773] FILEOPEN PPTX Slow loading of file with lots of unused master pages
https://bugs.documentfoundation.org/show_bug.cgi?id=158773 --- Comment #6 from Julien Nabet --- Created attachment 192982 --> https://bugs.documentfoundation.org/attachment.cgi?id=192982=edit Flamegraph Flamegraph retrieved on pc Debian x86-64 with master sources updated today. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158773] FILEOPEN PPTX Slow loading of file with lots of unused master pages
https://bugs.documentfoundation.org/show_bug.cgi?id=158773 Xisco Faulí changed: What|Removed |Added CC||serval2...@yahoo.fr, ||xiscofa...@libreoffice.org --- Comment #5 from Xisco Faulí --- Hi Julien, Would it be possible to have a perf graph for this issue ? -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158773] FILEOPEN PPTX Slow loading of file with lots of unused master pages
https://bugs.documentfoundation.org/show_bug.cgi?id=158773 Timur changed: What|Removed |Added Keywords|regression | Regression By|Henry Castro| --- Comment #4 from Timur --- Prior to these changes, master slides were not imported and they are many in this file. Now they load and LO is slow to load with them. I remove regression here. OTOH, MSO loads that fast, and for some PPTX with many unused slides it even asks if a cleanup should be done. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158773] FILEOPEN PPTX Slow loading of file with lots of unused master pages
https://bugs.documentfoundation.org/show_bug.cgi?id=158773 Justin L changed: What|Removed |Added CC||jl...@mail.com, ||noelgran...@gmail.com Summary|FILEOPEN PPTX Slow loading |FILEOPEN PPTX Slow loading |of file with image |of file with lots of unused ||master pages See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||7691 --- Comment #3 from Justin L --- I saw the same problem in bug 137691 comment 0's attachment 166646 (chartlegendmissing.pptx). In bug 137691 comment 10's attachment 191778 (chartlegendmissing-min.pptx) I minimized by removing the unused master/layout pages which immensely improved the load time. I really noticed it in my development build with debugging turned on. -- You are receiving this mail because: You are the assignee for the bug.
