[Bug 159515] Custom shape with bitmap fill with image with transparent parts is wrongly rendered in extrusion mode
https://bugs.documentfoundation.org/show_bug.cgi?id=159515 Patrick Luby changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED Assignee|libreoffice-b...@lists.free |guibomac...@gmail.com |desktop.org | --- Comment #16 from Patrick Luby --- I think I have fixed this bug in the following patch: https://gerrit.libreoffice.org/c/core/+/164322 @Regina Your fix for tdf#159912 looks like it is unaffected by my patch but maybe I am missing some subtle differences. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159515] Custom shape with bitmap fill with image with transparent parts is wrongly rendered in extrusion mode
https://bugs.documentfoundation.org/show_bug.cgi?id=159515 --- Comment #15 from Regina Henschel --- When this bug is fixed, the patch for the blocked bug 159912 has to be adapted. For details how to do that see the comment there. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159515] Custom shape with bitmap fill with image with transparent parts is wrongly rendered in extrusion mode
https://bugs.documentfoundation.org/show_bug.cgi?id=159515 Regina Henschel changed: What|Removed |Added Blocks||159912 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=159912 [Bug 159912] FILEOPEN: wrong rotation of 3D object -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159515] Custom shape with bitmap fill with image with transparent parts is wrongly rendered in extrusion mode
https://bugs.documentfoundation.org/show_bug.cgi?id=159515 --- Comment #14 from Patrick Luby --- One more detail: I unzipped both of the attached sample documents and opened the .png files within the documents in LibreOffice. All render correctly so I suspect that alpha inversion of the rose image is occurring when the extrusion process copies the loaded .png data. Not sure if that helps. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159515] Custom shape with bitmap fill with image with transparent parts is wrongly rendered in extrusion mode
https://bugs.documentfoundation.org/show_bug.cgi?id=159515 --- Comment #13 from Patrick Luby --- OK. The stack traces to my debug patch are nearly identical except that the cat photo in attachment #192332 goes through the GroupPrimitive2D class. That seems reasonable so maybe the inverted alpha channel happens at document load or change. Not sure where to look for that: frame #20: 0x000111a99a34 libdrawinglayerlo.dylib`drawinglayer::primitive2d::GroupPrimitive2D::getChildren(this=0x657af480, rVisitor=0x65f90f50) const at groupprimitive2d.hxx:76:90 frame #21: 0x000111ad5e60 libdrawinglayerlo.dylib`drawinglayer::primitive2d::GroupPrimitive2D::get2DDecomposition(this=0x657af480, rVisitor=0x65f90f50, (null)=0x65f90f58) const at groupprimitive2d.cxx:53:13 frame #22: 0x000111b576c4 libdrawinglayerlo.dylib`drawinglayer::processor2d::BaseProcessor2D::process(this=0x65f90f50, rCandidate=0x657af480) at baseprocessor2d.cxx:46:24 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159515] Custom shape with bitmap fill with image with transparent parts is wrongly rendered in extrusion mode
https://bugs.documentfoundation.org/show_bug.cgi?id=159515
--- Comment #12 from Patrick Luby ---
(In reply to Patrick Luby from comment #11)
> Created attachment 192809 [details]
> Stack trace where extruded shapes alpha mask is created
I have done some debugging and I narrowed down where in the code the bug is
occurring. Using the following debug patch, the roses in the two attached
sample documents render correctly, but the debug patch makes the cat photo in
attachment #192332 completely transparent. So, I am guessing that the alpha
channel needs to be inverted higher up the stack in attachment #192809:
diff --git a/drawinglayer/source/processor3d/zbufferprocessor3d.cxx
b/drawinglayer/source/processor3d/zbufferprocessor3d.cxx
index b9cb8ffb7a1d..2f24b916e587 100644
--- a/drawinglayer/source/processor3d/zbufferprocessor3d.cxx
+++ b/drawinglayer/source/processor3d/zbufferprocessor3d.cxx
@@ -302,7 +302,8 @@ void ZBufferRasterConverter3D::processLineSpan(const
basegfx::RasterConversionLi
if(nNewZ > rOldZ)
{
// detect color and opacity for this pixel
-const sal_uInt16 nOpacity(std::max(sal_Int16(0), static_cast<
sal_Int16 >(decideColorAndOpacity(aNewColor) * 255.0)));
+// try inverting the opacity value
+const sal_uInt16 nOpacity(255 - std::max(sal_Int16(0),
static_cast< sal_Int16 >(decideColorAndOpacity(aNewColor) * 255.0)));
if(nOpacity > 0)
{
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 159515] Custom shape with bitmap fill with image with transparent parts is wrongly rendered in extrusion mode
https://bugs.documentfoundation.org/show_bug.cgi?id=159515 --- Comment #11 from Patrick Luby --- Created attachment 192809 --> https://bugs.documentfoundation.org/attachment.cgi?id=192809=edit Stack trace where extruded shapes alpha mask is created -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159515] Custom shape with bitmap fill with image with transparent parts is wrongly rendered in extrusion mode
https://bugs.documentfoundation.org/show_bug.cgi?id=159515 --- Comment #10 from Patrick Luby --- I can reproduce this as well. It looks like an inverted alpha mask to me. When I get some time, I'll see if I can locate where the alpha mask is created for the two attachments. Version: 24.8.0.0.alpha0+ (AARCH64) / LibreOffice Community Build ID: 833abb4a197561c34ec59cceb9d7d8a46f6b17ce CPU threads: 8; OS: macOS 14.2.1; UI render: Skia/Metal; VCL: osx Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159515] Custom shape with bitmap fill with image with transparent parts is wrongly rendered in extrusion mode
https://bugs.documentfoundation.org/show_bug.cgi?id=159515 Gerald Pfeifer changed: What|Removed |Added CC||guibomac...@gmail.com --- Comment #9 from Gerald Pfeifer --- (In reply to Aron Budea from comment #7) > Bibisected to the following commit, using repo bibisect-linux-64-24.2. : > Convert internal vcl bitmap formats transparency->alpha (II) Patrick Luby heroically fixed tons of regressions cause by that change last year; copying for potential advice. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159515] Custom shape with bitmap fill with image with transparent parts is wrongly rendered in extrusion mode
https://bugs.documentfoundation.org/show_bug.cgi?id=159515 Stéphane Guillou (stragu) changed: What|Removed |Added CC||noelgran...@gmail.com --- Comment #8 from Stéphane Guillou (stragu) --- (Actually adding Noel to CC. Thanks Aron for the bisect.) -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159515] Custom shape with bitmap fill with image with transparent parts is wrongly rendered in extrusion mode
https://bugs.documentfoundation.org/show_bug.cgi?id=159515 Aron Budea changed: What|Removed |Added Keywords|bibisectRequest |bibisected, bisected CC||aron.bu...@gmail.com Regression By||Noel Grandin --- Comment #7 from Aron Budea --- Bibisected to the following commit, using repo bibisect-linux-64-24.2. Adding CC: to Noel Grandin. https://cgit.freedesktop.org/libreoffice/core/commit/?id=81994cb2b8b32453a92bcb011830fcb884f22ff3 author Noel Grandin 2021-04-16 20:33:10 +0200 committer Noel Grandin 2023-07-25 08:38:12 +0200 Convert internal vcl bitmap formats transparency->alpha (II) -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159515] Custom shape with bitmap fill with image with transparent parts is wrongly rendered in extrusion mode
https://bugs.documentfoundation.org/show_bug.cgi?id=159515 Stéphane Guillou (stragu) changed: What|Removed |Added CC||stephane.guillou@libreoffic ||e.org Whiteboard| QA:needsComment| Version|unspecified |24.2.0.0 alpha0+ Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #6 from Stéphane Guillou (stragu) --- Repro in: Version: 24.2.0.3 (X86_64) / LibreOffice Community Build ID: da48488a73ddd66ea24cf16bbc4f7b9c08e9bea1 CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded No repro in: Version: 7.6.4.1 (X86_64) / LibreOffice Community Build ID: e19e193f88cd6c0525a17fb7a176ed8e6a3e2aa1 CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159515] Custom shape with bitmap fill with image with transparent parts is wrongly rendered in extrusion mode
https://bugs.documentfoundation.org/show_bug.cgi?id=159515 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159515] Custom shape with bitmap fill with image with transparent parts is wrongly rendered in extrusion mode
https://bugs.documentfoundation.org/show_bug.cgi?id=159515 --- Comment #5 from Regina Henschel --- >From the versions I have locally available the last good one is from about 2023-07-25 Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 42f0422d19c4d0a2fb09654fb6d1d92e50f6dd5c CPU threads: 32; OS: Windows 10.0 Build 22631; UI render: Skia/Vulkan; VCL: win Locale: de-DE (de_DE); UI: en-US Calc: threaded and the first bad on is from about 2023-08-10 Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 218a7650a5cf03f895bed19c68d6f02daec536e9 CPU threads: 32; OS: Windows 10.0 Build 22631; UI render: Skia/Vulkan; VCL: win Locale: de-DE (de_DE); UI: en-US Calc: threaded I hope it helps to bibisect it. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159515] Custom shape with bitmap fill with image with transparent parts is wrongly rendered in extrusion mode
https://bugs.documentfoundation.org/show_bug.cgi?id=159515 --- Comment #4 from Regina Henschel --- The error is visible too in Version: 24.2.0.3 (X86_64) / LibreOffice Community Build ID: da48488a73ddd66ea24cf16bbc4f7b9c08e9bea1 CPU threads: 32; OS: Windows 10.0 Build 22631; UI render: Skia/Vulkan; VCL: win Locale: de-DE (de_DE); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159515] Custom shape with bitmap fill with image with transparent parts is wrongly rendered in extrusion mode
https://bugs.documentfoundation.org/show_bug.cgi?id=159515 --- Comment #3 from Regina Henschel --- Created attachment 192381 --> https://bugs.documentfoundation.org/attachment.cgi?id=192381=edit Extrusion with true 3DScene There error affects true 3D-scenes too, see attachment. It is OK in Version: 7.6.4.1 (X86_64) / LibreOffice Community Build ID: e19e193f88cd6c0525a17fb7a176ed8e6a3e2aa1 CPU threads: 32; OS: Windows 10.0 Build 22631; UI render: default; VCL: win Locale: de-DE (de_DE); UI: en-US Calc: threaded The problem is not related to Skia. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159515] Custom shape with bitmap fill with image with transparent parts is wrongly rendered in extrusion mode
https://bugs.documentfoundation.org/show_bug.cgi?id=159515 Regina Henschel changed: What|Removed |Added Blocks||70039 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=70039 [Bug 70039] FILEOPEN: PPTX Import does not show 3D elements in 3D -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159515] Custom shape with bitmap fill with image with transparent parts is wrongly rendered in extrusion mode
https://bugs.documentfoundation.org/show_bug.cgi?id=159515 Regina Henschel changed: What|Removed |Added Keywords||bibisectRequest, regression --- Comment #2 from Regina Henschel --- It was OK in Version: 6.5.0.0.alpha0+ (x64) Build ID: 147af9e2cf7f937ed83ab00574b6a418a2cb629e CPU threads: 32; OS: Windows 10.0 Build 22631; UI render: default; VCL: win; Locale: de-DE (de_DE); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159515] Custom shape with bitmap fill with image with transparent parts is wrongly rendered in extrusion mode
https://bugs.documentfoundation.org/show_bug.cgi?id=159515 --- Comment #1 from Regina Henschel --- The transparency was correct in Version: 5.4.3.2 (x64) Build ID: 92a7159f7e4af62137622921e809f8546db437e5 CPU threads: 32; OS: Windows 6.19; UI render: default; Locale: de-DE (de_DE); Calc: group Because this simple extrusion fill shifts the image from front to back you see the rose two times. Nevertheless using an image fill is useful to get a 3D-rotated image. Use a small extrusion depth e.g 1mm. -- You are receiving this mail because: You are the assignee for the bug.
