[Libreoffice-bugs] [Bug 100582] FILESAVE Formula in some cells not saved in .XLS format

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100582

Eike Rathke  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |er...@redhat.com
   |desktop.org |

--- Comment #10 from Eike Rathke  ---
Taking.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100582] FILESAVE Formula in some cells not saved in .XLS format

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100582

Eike Rathke  changed:

   What|Removed |Added

 Attachment #125882|application/x-ole-storage   |application/vnd.ms-excel
  mime type||

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100582] FILESAVE Formula in some cells not saved in .XLS format

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100582

Luke  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=86
   ||215

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100582] FILESAVE Formula in some cells not saved in .XLS format

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100582

--- Comment #9 from Luke  ---
I just verified that source of this bug is
https://cgit.freedesktop.org/libreoffice/core/commit/?id=80ea2822c368e6655d216c32904268fc335ef6a4

Reverting 80ea2822c368e6655d216c32904268fc335ef6a4 fixes both the #VALUE in all
cells bug and the XLS format saves correctly.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100582] FILESAVE Formula in some cells not saved in .XLS format

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100582

Luke  changed:

   What|Removed |Added

 CC||er...@redhat.com,
   ||hcas...@collabora.com,
   ||tima...@gmail.com
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=80
   ||137

--- Comment #8 from Luke  ---
++
Copy/Paste of Formulas results in #VALUE in all cells

https://cgit.freedesktop.org/libreoffice/core/log/?id=2e3bc9fcee1c728d9fe91cbdf92b15d090c2b619=range=4f3012fc05fa0eeae412d9e2bfca3d7e60914a8c..f1b1e73227471192682d303a58618ca8bd65a74d

Points to
https://cgit.freedesktop.org/libreoffice/core/commit/?id=80ea2822c368e6655d216c32904268fc335ef6a4

author  Kohei Yoshida  
Optimize copy-n-pasting of single cell replicated over a range. Let's speed it
up a bit.


Eike,
This optimization is responsible for other issues like a crash reported in Bug
86215 that you fixed. Since Kohei is no longer active, is it worth keeping this
troublesome optimization? 

+++
Copy/Paste Not Retained on Save/Open

https://cgit.freedesktop.org/libreoffice/core/commit/?id=097a16b59884c777f724cec6c5d42734974ed44b

Henry or Andras,
Could you please take a look at this?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100582] FILESAVE Formula in some cells not saved in .XLS format

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100582

Joel Madero  changed:

   What|Removed |Added

   Keywords||bibisected
Version|5.1.3.2 release |5.0.6.3 release

--- Comment #7 from Joel Madero  ---
Two different bibisects needed because of two different issues:

Also - changing the version to at least 5.0 because the problem was there then.

++
Copy/Paste of Formulas results in #VALUE in all cells
0d4c20a601a3cfff27d6685d0e81463086bd9d74 is the first bad commit
commit 0d4c20a601a3cfff27d6685d0e81463086bd9d74
Author: Bjoern Michaelsen 
Date:   Sun May 11 05:25:38 2014 +

source-hash-f1b1e73227471192682d303a58618ca8bd65a74d

commit f1b1e73227471192682d303a58618ca8bd65a74d
Author: Caolán McNamara 
AuthorDate: Sat Jan 25 20:19:29 2014 +
Commit: Caolán McNamara 
CommitDate: Sat Jan 25 20:56:30 2014 +

coverity#1158347 Uncaught exception

Change-Id: Iacaf59724b71d810270545d1e9dd04d59125cc92

:100644 100644 368976e6dbd4cdb43e492ba5eadabe099660a339
70730e767408d2206d17bf278178d2d9909ba37f M  ccache.log
:100644 100644 acdce77d197e69bf89e98f6a3b6423de34b1754b
2e178fe08a1d28d341e79db69400a2cfe0ed6c96 M  commitmsg
:100644 100644 1d0e4ca60cc4187e89af26fcb86e7d165af0bd7b
f5beaf27de34aa7963d0b561b320c3ac0246b81e M  make.log
:04 04 253f4f4a2f845ca9d4e9765c9d9e96828b22d64d
8871808799c896d3651d27d2b44f5f041296070c M  opt


# bad: [423a84c4f7068853974887d98442bc2a2d0cc91b]
source-hash-c15927f20d4727c3b8de68497b6949e72f9e6e9e
# good: [65fd30f5cb4cdd37995a33420ed8273c0a29bf00]
source-hash-d6cde02dbce8c28c6af836e2dc1120f8a6ef9932
git bisect start 'latest' 'oldest'
# good: [e02439a3d6297a1f5334fa558ddec5ef4212c574]
source-hash-6b8393474974d2af7a2cb3c47b3d5c081b550bdb
git bisect good e02439a3d6297a1f5334fa558ddec5ef4212c574
# good: [4850941efe43ae800be5c76e1102ab80ac2c085d]
source-hash-980a6e552502f02f12c15bfb1c9f8e6269499f4b
git bisect good 4850941efe43ae800be5c76e1102ab80ac2c085d
# bad: [a900e72b6357882284c5955bdf939bf14269f5fb]
source-hash-dd1050b182260a26a1d0ba6d0ef3a6fecc3f4e07
git bisect bad a900e72b6357882284c5955bdf939bf14269f5fb
# bad: [e1d0365cd2b073a859f59ad0a4584385a66dc611]
source-hash-2eea96c702a44ab009743b0d22ef639127f0b57b
git bisect bad e1d0365cd2b073a859f59ad0a4584385a66dc611
# bad: [98a55bf95f3ec29298751fd8fba76dd2236dce43]
source-hash-58dfc97ca697875c36b7ddf14f5505a93d7b9cf8
git bisect bad 98a55bf95f3ec29298751fd8fba76dd2236dce43
# good: [92ca7e7dd4470107453ce3e99f3675387f91bf24]
source-hash-ed5065d8b080bfaf51ea1232cebf3ff72af1e640
git bisect good 92ca7e7dd4470107453ce3e99f3675387f91bf24
# good: [c3997dfb709772c28f4b90559431662e3a81d651]
source-hash-d803483f6a5938b0d0708b8db74b30c511dd8e31
git bisect good c3997dfb709772c28f4b90559431662e3a81d651
# good: [5d0e5af3cc4db0c25b97ec65cc5258b07daca350]
source-hash-4f3012fc05fa0eeae412d9e2bfca3d7e60914a8c
git bisect good 5d0e5af3cc4db0c25b97ec65cc5258b07daca350
# bad: [60932907a26d372fa1481b2249bb915e14dc94aa]
source-hash-8df4ce0ebe1240ed8f6def3af8f810e3f207555f
git bisect bad 60932907a26d372fa1481b2249bb915e14dc94aa
# bad: [0d4c20a601a3cfff27d6685d0e81463086bd9d74]
source-hash-f1b1e73227471192682d303a58618ca8bd65a74d
git bisect bad 0d4c20a601a3cfff27d6685d0e81463086bd9d74
# first bad commit: [0d4c20a601a3cfff27d6685d0e81463086bd9d74]
source-hash-f1b1e73227471192682d303a58618ca8bd65a74d

+++
Copy/Paste Not Retained on Save/Open

5cb76d671e58899205f164079d68c166f231a57c is the first bad commit
commit 5cb76d671e58899205f164079d68c166f231a57c
Author: Matthew Francis 
Date:   Wed May 27 19:53:49 2015 +0800

source-hash-097a16b59884c777f724cec6c5d42734974ed44b

commit 097a16b59884c777f724cec6c5d42734974ed44b
Author: Henry Castro 
AuthorDate: Fri Mar 6 13:51:25 2015 -0400
Commit: Andras Timar 
CommitDate: Mon Mar 9 09:38:51 2015 +

Resolves tdf#80137 Paste array formula into range pastes as non-array
formula

Change-Id: I58b32e5af07702b76afb901a3ec270453462
Reviewed-on: https://gerrit.libreoffice.org/14770
Tested-by: Jenkins 
Reviewed-by: Andras Timar 

:04 04 8b64c828de745082022fbb645cf0fb5711c75e3a
cece670df23368b75bda81608e465c6151d7b3a0 M  opt

# bad: [dda106fd616b7c0b8dc2370f6f1184501b01a49e]
source-hash-0db96caf0fcce09b87621c11b584a6d81cc7df86
# good: [5b9dd620df316345477f0b6e6c9ed8ada7b6c091]

[Libreoffice-bugs] [Bug 100582] FILESAVE Formula in some cells not saved in .XLS format

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100582

Joel Madero  changed:

   What|Removed |Added

   Keywords||regression

--- Comment #6 from Joel Madero  ---
This worked fine in 3.3 - so regression. Trying to bibisect now

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100582] FILESAVE Formula in some cells not saved in .XLS format

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100582

--- Comment #5 from Joel Madero  ---
More investigating:

This only happens when you copy/paste in one go. So steps:

1. Download sheet;
2. Copy C10
3. Select C10:H14
4. Paste
5. Save and close
6. Open

Observed: Missing values for all "inner" values (values on the outside of the
square are preserved)

7. Go to C10
8. Copy
9. Paste 1 value at a time for C10 through H14
10. Save and close
11. Open

Observed: Values preserved

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100582] FILESAVE Formula in some cells not saved in .XLS format

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100582

Joel Madero  changed:

   What|Removed |Added

   Priority|medium  |high
 Status|UNCONFIRMED |NEW
 CC||jmadero@gmail.com
 Ever confirmed|0   |1
   Severity|normal  |major

--- Comment #4 from Joel Madero  ---
Version: 5.3.0.0.alpha0+
Build ID: c89294233b6a9ffc1bd75e6e9226ad723b7d5538
CPU Threads: 2; OS Version: Linux 3.16; UI Render: default; 
Locale: en-US (en_US.UTF-8)

Confirmed.

This is quite nasty. Going to see if it's a regression and go from there.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100582] FILESAVE Formula in some cells not saved in .XLS format

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100582

--- Comment #3 from Barrie  ---
Also appears to be related to the array formula - if C10 is replaced with a
simple formula, the problem doesn't occur.

Copying differently (e.g. one cell at a time) I still see problems but
typically a different set of cells is blank.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100582] FILESAVE Formula in some cells not saved in .XLS format

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100582

--- Comment #2 from Barrie  ---
select C10 and Ctrl-C
select C10:H14 and Ctrl-V

The formulae obviously fill the cells immediately, but if I save as .XLS and
close and reopen the file typically cells D11:G13 are blank.

If I save as .ODS I don't see any problem, so it's related to the .XLS format I
think.

I am using Win 10 Home, Samsung laptop, i5-3210M, 64 bit OS.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100582] FILESAVE Formula in some cells not saved in .XLS format

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100582

Buovjaga  changed:

   What|Removed |Added

 CC||todven...@suomi24.fi

--- Comment #1 from Buovjaga  ---
I do not reproduce the problem.

What copying method did you use?
I tried both dragging from the corner and also by first filling down and then
filling right for each row.

64-bit, KDE Plasma 5
Build ID: 5.1.4.2 Arch Linux build-1
CPU Threads: 8; OS Version: Linux 4.6; UI Render: default; 
Locale: fi-FI (fi_FI.UTF-8)

Arch Linux 64-bit, KDE Plasma 5
Version: 5.3.0.0.alpha0+
Build ID: ff25ea3d5ccf3a990767cbb1ef99037d3f84b072
CPU Threads: 8; OS Version: Linux 4.6; UI Render: default; 
Locale: fi-FI (fi_FI.UTF-8)
Built on June 26th 2016

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs