[Libreoffice-bugs] [Bug 101443] Wrong width/placement of Calc multiline scrollbar
https://bugs.documentfoundation.org/show_bug.cgi?id=101443 Xisco Faulí changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |thorsten.wagne...@gmail.com |desktop.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101443] Wrong width/placement of Calc multiline scrollbar
https://bugs.documentfoundation.org/show_bug.cgi?id=101443 --- Comment #37 from Thorsten Wagner --- Change committed to Gerrit: https://gerrit.libreoffice.org/71937 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101443] Wrong width/placement of Calc multiline scrollbar
https://bugs.documentfoundation.org/show_bug.cgi?id=101443 --- Comment #34 from Thorsten Wagner --- Created attachment 151227 --> https://bugs.documentfoundation.org/attachment.cgi?id=151227=edit Collapsed selected input bar on Linux -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101443] Wrong width/placement of Calc multiline scrollbar
https://bugs.documentfoundation.org/show_bug.cgi?id=101443 --- Comment #36 from Thorsten Wagner --- Created attachment 151229 --> https://bugs.documentfoundation.org/attachment.cgi?id=151229=edit Expanded selected input bar on Linux -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101443] Wrong width/placement of Calc multiline scrollbar
https://bugs.documentfoundation.org/show_bug.cgi?id=101443 --- Comment #35 from Thorsten Wagner --- Created attachment 151228 --> https://bugs.documentfoundation.org/attachment.cgi?id=151228=edit Expanded input bar on Linux -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101443] Wrong width/placement of Calc multiline scrollbar
https://bugs.documentfoundation.org/show_bug.cgi?id=101443 --- Comment #33 from Thorsten Wagner --- Created attachment 151226 --> https://bugs.documentfoundation.org/attachment.cgi?id=151226=edit Collapsed input bar on Linux -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101443] Wrong width/placement of Calc multiline scrollbar
https://bugs.documentfoundation.org/show_bug.cgi?id=101443 --- Comment #30 from Thorsten Wagner --- Created attachment 151223 --> https://bugs.documentfoundation.org/attachment.cgi?id=151223=edit Collapsed selected input bar on macOS -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101443] Wrong width/placement of Calc multiline scrollbar
https://bugs.documentfoundation.org/show_bug.cgi?id=101443 --- Comment #32 from Thorsten Wagner --- Created attachment 151225 --> https://bugs.documentfoundation.org/attachment.cgi?id=151225=edit Expanded selected input bar on macOS -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101443] Wrong width/placement of Calc multiline scrollbar
https://bugs.documentfoundation.org/show_bug.cgi?id=101443 --- Comment #31 from Thorsten Wagner --- Created attachment 151224 --> https://bugs.documentfoundation.org/attachment.cgi?id=151224=edit Expanded input bar on macOS -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101443] Wrong width/placement of Calc multiline scrollbar
https://bugs.documentfoundation.org/show_bug.cgi?id=101443 --- Comment #29 from Thorsten Wagner --- Created attachment 151222 --> https://bugs.documentfoundation.org/attachment.cgi?id=151222=edit Collapsed input bar on macOS -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101443] Wrong width/placement of Calc multiline scrollbar
https://bugs.documentfoundation.org/show_bug.cgi?id=101443 --- Comment #28 from Thorsten Wagner --- After a lot of platform upgrades I was able to continue working on this issue. Build platforms are now macOS 10.14 and Debian 10. As Gerrit change 58659 has been abandoned in the meantime, I will commit a new change to Gerrit in short. To remove assertion failure found by Heiko I investigated vcl/source/window/toolbox.cxx. Beside the assertion failure it was possible to fix the behaviour of OK and Cancel icons, which were dangling in some situations, at this place too. With the introduction of a dropdown menu at the Sum button, button width changes when the text input field is selected. Left border of text input field changes accordingly. To ensure text input field's position after selection/deselection, a redesigned layout mode handling for Calc's formula bar was introduced in toolbox.cxx. New Screenshots of collapsed/expanded formula bar with/without selection for macOS and Linux are attached. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101443] Wrong width/placement of Calc multiline scrollbar
https://bugs.documentfoundation.org/show_bug.cgi?id=101443 Adolfo Jayme changed: What|Removed |Added Attachment #144001|Expanded input bar on macOS |Expanded input bar on Linux description|| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101443] Wrong width/placement of Calc multiline scrollbar
https://bugs.documentfoundation.org/show_bug.cgi?id=101443 --- Comment #27 from Thorsten Wagner --- I have to rebuild for debugging - this will take a while. To clarify things I attached an overview of possibile design options (see attached file "Design Options.odg"). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101443] Wrong width/placement of Calc multiline scrollbar
https://bugs.documentfoundation.org/show_bug.cgi?id=101443 --- Comment #26 from Thorsten Wagner --- Created attachment 144019 --> https://bugs.documentfoundation.org/attachment.cgi?id=144019=edit Design options -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101443] Wrong width/placement of Calc multiline scrollbar
https://bugs.documentfoundation.org/show_bug.cgi?id=101443 --- Comment #25 from Heiko Tietze --- (In reply to Thorsten Wagner from comment #24) > What OS platform do you use? Linux, unfortunately dont have time to look into details. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101443] Wrong width/placement of Calc multiline scrollbar
https://bugs.documentfoundation.org/show_bug.cgi?id=101443 --- Comment #24 from Thorsten Wagner --- Switching the expander column with scrollbar means reducing width of triangle to scrollbar width? This does not work with very thin scollbars (dependent on the widget set used). There is an assertion failure using the patch. I‘m unable to reproduce this failure neither on macOS nor on Linux (Debian). What OS platform do you use? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101443] Wrong width/placement of Calc multiline scrollbar
https://bugs.documentfoundation.org/show_bug.cgi?id=101443 --- Comment #23 from Heiko Tietze --- (In reply to Thorsten Wagner from comment #22) > Triangle is needed to expand/collapse. Right. How about switching the expander column with the scrollbar? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101443] Wrong width/placement of Calc multiline scrollbar
https://bugs.documentfoundation.org/show_bug.cgi?id=101443 --- Comment #22 from Thorsten Wagner --- Link to Gerrit: https://gerrit.libreoffice.org/#/c/58659 Triangle is needed to expand/collapse. I don’t see any other solution how to keep scrollbar width consistent with all other scrollbars within the application while keeping width of triangle (as desired above within this ticket). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101443] Wrong width/placement of Calc multiline scrollbar
https://bugs.documentfoundation.org/show_bug.cgi?id=101443 --- Comment #21 from Heiko Tietze --- (In reply to Thorsten Wagner from comment #20) > Patch has been submitted to Gerrit. Link please. On the first glance I don't like the horizontal shift and wonder why you keep the triangle (haven't looked into the issue again in detail). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101443] Wrong width/placement of Calc multiline scrollbar
https://bugs.documentfoundation.org/show_bug.cgi?id=101443 --- Comment #20 from Thorsten Wagner --- Patch has been submitted to Gerrit. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101443] Wrong width/placement of Calc multiline scrollbar
https://bugs.documentfoundation.org/show_bug.cgi?id=101443 --- Comment #18 from Thorsten Wagner --- Created attachment 144000 --> https://bugs.documentfoundation.org/attachment.cgi?id=144000=edit Collapsed input bar on Linux -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101443] Wrong width/placement of Calc multiline scrollbar
https://bugs.documentfoundation.org/show_bug.cgi?id=101443 --- Comment #19 from Thorsten Wagner --- Created attachment 144001 --> https://bugs.documentfoundation.org/attachment.cgi?id=144001=edit Expanded input bar on macOS -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101443] Wrong width/placement of Calc multiline scrollbar
https://bugs.documentfoundation.org/show_bug.cgi?id=101443 --- Comment #17 from Thorsten Wagner --- Created attachment 143999 --> https://bugs.documentfoundation.org/attachment.cgi?id=143999=edit Expanded input bar on macOS -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101443] Wrong width/placement of Calc multiline scrollbar
https://bugs.documentfoundation.org/show_bug.cgi?id=101443 --- Comment #16 from Thorsten Wagner --- Created attachment 143998 --> https://bugs.documentfoundation.org/attachment.cgi?id=143998=edit Collapsed input bar on macOS -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101443] Wrong width/placement of Calc multiline scrollbar
https://bugs.documentfoundation.org/show_bug.cgi?id=101443 --- Comment #15 from Thorsten Wagner --- Scrollbars of consistent width while keeping button large required a somewhat larger redesign. My proposed solution is integrating scrollbar with text input field while keeping button separate. I attached screenshots for macOS as well as for Linux with input bar collapsed as well as expanded. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101443] Wrong width/placement of Calc multiline scrollbar
https://bugs.documentfoundation.org/show_bug.cgi?id=101443 Heiko Tietze changed: What|Removed |Added CC|libreoffice-ux-advise@lists |tietze.he...@gmail.com |.freedesktop.org| Priority|medium |low Keywords|needsUXEval | --- Comment #14 from Heiko Tietze --- Alignment is definitely a good to have, though not crucial. Removing needsUX, setting importance to low. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101443] Wrong width/placement of Calc multiline scrollbar
https://bugs.documentfoundation.org/show_bug.cgi?id=101443 --- Comment #13 from Adolfo Jayme--- I am a fan of dropping the button border, but we should stick a colorful icon to it so it remains noticeable. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101443] Wrong width/placement of Calc multiline scrollbar
https://bugs.documentfoundation.org/show_bug.cgi?id=101443 Heiko Tietzechanged: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101443] Wrong width/placement of Calc multiline scrollbar
https://bugs.documentfoundation.org/show_bug.cgi?id=101443 --- Comment #12 from Heiko Tietze--- Created attachment 137452 --> https://bugs.documentfoundation.org/attachment.cgi?id=137452=edit Without left offset Agree with the OP that it looks not too good. Tried with LEFT_OFFSET 0 and that solves the situation on Linux (Qt) but not really on macOS. Screenshot from left to right: current situation, how it looks with zero offset on Linux and on macOS. Patch is here https://gerrit.libreoffice.org/#/c/44205/ Proper solution would be to place the scrollbar right hand of the button above. Guess this is the code pointer where SetPosPixel() could be replaced. void ScInputBarGroup::Resize() ... long nWidth = pParent->GetSizePixel().Width(); long nLeft = GetPosPixel().X(); Size aSize = GetSizePixel(); aSize.Width() = std::max(long(nWidth - nLeft - LEFT_OFFSET), long(0)); maScrollbar->SetPosPixel(Point( aSize.Width() - maButton->GetSizePixel().Width(), maButton->GetSizePixel().Height() ) ); -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101443] Wrong width/placement of Calc multiline scrollbar
https://bugs.documentfoundation.org/show_bug.cgi?id=101443 --- Comment #11 from Jean-Francois Nifenecker--- Agreed with JBF. The proposed change makes the button way too small. The current situation makes it prominent. On a user POV, the change would lead users to overlook this widget (well, some already do). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101443] Wrong width/placement of Calc multiline scrollbar
https://bugs.documentfoundation.org/show_bug.cgi?id=101443 Xisco Faulíchanged: What|Removed |Added Keywords||needsUXEval CC||libreoffice-ux-advise@lists ||.freedesktop.org, ||xiscofa...@libreoffice.org --- Comment #10 from Xisco Faulí --- Adding UX team... -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101443] Wrong width/placement of Calc multiline scrollbar
https://bugs.documentfoundation.org/show_bug.cgi?id=101443 Jean-Baptiste Faurechanged: What|Removed |Added CC||jbfa...@libreoffice.org See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=99 ||701 --- Comment #9 from Jean-Baptiste Faure --- I prefer the current state which make the dropdown button more visible. Best regards. JBF -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101443] Wrong width/placement of Calc multiline scrollbar
https://bugs.documentfoundation.org/show_bug.cgi?id=101443 --- Comment #8 from Thorsten Wagner--- Created attachment 126743 --> https://bugs.documentfoundation.org/attachment.cgi?id=126743=edit Screenshot 2 on Linux with patch -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101443] Wrong width/placement of Calc multiline scrollbar
https://bugs.documentfoundation.org/show_bug.cgi?id=101443 --- Comment #7 from Thorsten Wagner--- Created attachment 126742 --> https://bugs.documentfoundation.org/attachment.cgi?id=126742=edit Screenshot 1 on Linux with patch -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101443] Wrong width/placement of Calc multiline scrollbar
https://bugs.documentfoundation.org/show_bug.cgi?id=101443 --- Comment #6 from Thorsten Wagner--- Created attachment 126741 --> https://bugs.documentfoundation.org/attachment.cgi?id=126741=edit Screenshot 2 on Linux without patch -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101443] Wrong width/placement of Calc multiline scrollbar
https://bugs.documentfoundation.org/show_bug.cgi?id=101443 --- Comment #5 from Thorsten Wagner--- Created attachment 126740 --> https://bugs.documentfoundation.org/attachment.cgi?id=126740=edit Screenshot 1 on Linux without patch -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101443] Wrong width/placement of Calc multiline scrollbar
https://bugs.documentfoundation.org/show_bug.cgi?id=101443 --- Comment #4 from Thorsten Wagner--- Screenshots for Linux will be added in brief -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101443] Wrong width/placement of Calc multiline scrollbar
https://bugs.documentfoundation.org/show_bug.cgi?id=101443 --- Comment #3 from Thorsten Wagner--- Created attachment 126739 --> https://bugs.documentfoundation.org/attachment.cgi?id=126739=edit Screenshot 2 on OS X with patch -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101443] Wrong width/placement of Calc multiline scrollbar
https://bugs.documentfoundation.org/show_bug.cgi?id=101443 --- Comment #2 from Thorsten Wagner--- Created attachment 126738 --> https://bugs.documentfoundation.org/attachment.cgi?id=126738=edit Screenshot 1 on OS X with patch -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101443] Wrong width/placement of Calc multiline scrollbar
https://bugs.documentfoundation.org/show_bug.cgi?id=101443 --- Comment #1 from Thorsten Wagner--- Created attachment 126737 --> https://bugs.documentfoundation.org/attachment.cgi?id=126737=edit Screenshot 2 on OS X without patch -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs