[Libreoffice-bugs] [Bug 101826] textbox background fill lost when round-tripping in .doc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101826

Justin L  changed:

   What|Removed |Added

 Resolution|--- |FIXED
   Assignee|libreoffice-b...@lists.free |jl...@mail.com
   |desktop.org |
 Status|NEW |RESOLVED

--- Comment #13 from Justin L  ---
There is still a possible outstanding edge case. If the parents have a
transparency, but some XATTR is set but without setting the transparency, then
the inherited transparency might be lost (at least based on the previous code
path). I couldn't create/find an example document of that though.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101826] textbox background fill lost when round-tripping in .doc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101826

--- Comment #12 from Commit Notification 
 ---
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/3de954c90abf46219b57f9fce2332ef7ede146e7%5E%21

tdf#101826 ww8import: Fly - do convert XATTR if FILLSTYLE==NONE

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101826] textbox background fill lost when round-tripping in .doc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101826

--- Comment #11 from Commit Notification 
 ---
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/cc899c6967238877f0094bcf00627145e484ffec%5E%21

tdf#101826 ww8import: Fly - don't convert XATTR back and forth

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101826] textbox background fill lost when round-tripping in .doc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101826

Justin L  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101826] textbox background fill lost when round-tripping in .doc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101826

Justin L  changed:

   What|Removed |Added

   Assignee|jl...@mail.com  |libreoffice-b...@lists.free
   ||desktop.org

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101826] textbox background fill lost when round-tripping in .doc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101826

Justin L  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |jl...@mail.com
   |desktop.org |

--- Comment #7 from Justin L  ---
magic fix proposed at https://gerrit.libreoffice.org/66310

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101826] textbox background fill lost when round-tripping in .doc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101826

--- Comment #6 from Luke  ---
Created attachment 140527
  --> https://bugs.documentfoundation.org/attachment.cgi?id=140527=edit
All fill types are lost on roundtrip

Here is an example with gradient, pattern, and picture fills.

Miklos, 

I know you have done a lot of work in this area. Any idea why Armin's commit
would have broken this functionality?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101826] textbox background fill lost when round-tripping in .doc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101826

Xisco Faulí  changed:

   What|Removed |Added

 Blocks||116112


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=116112
[Bug 116112] [META] Regressions introduced by alg_writerframes
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101826] textbox background fill lost when round-tripping in .doc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101826

--- Comment #5 from Xisco Faulí  ---
*** Bug 112618 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101826] textbox background fill lost when round-tripping in .doc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101826

Aron Budea  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||2618

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101826] textbox background fill lost when round-tripping in .doc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101826

Telesto  changed:

   What|Removed |Added

 Blocks||88171, 103494


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=88171
[Bug 88171] [Meta] Tracking bug for limitations of binary DOC format
https://bugs.documentfoundation.org/show_bug.cgi?id=103494
[Bug 103494] [META] Textbox bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101826] textbox background fill lost when round-tripping in .doc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101826

Xisco Faulí  changed:

   What|Removed |Added

   Keywords||regression

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101826] textbox background fill lost when round-tripping in .doc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101826

--- Comment #3 from Aron Budea  ---
Other bugs connected to this commit: bug 94287, bug 85283, bug 92095, bug
80294.
(might not be that useful to know, since it's a large commit, but still
interesting)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101826] textbox background fill lost when round-tripping in .doc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101826

Aron Budea  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||armin.le.gr...@me.com,
   ||ba...@caesar.elte.hu
 Ever confirmed|0   |1

--- Comment #2 from Aron Budea  ---
Confirmed in 5.2.1.2 / Ubuntu.

Let's add Armin to the loop, then.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101826] textbox background fill lost when round-tripping in .doc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101826

Justin L  changed:

   What|Removed |Added

 OS|Linux (All) |All

--- Comment #1 from Justin L  ---
I can't figure this one out and didn't have any success hacking the source
code.  I'm guessing that it is a transition from SvxBrushItem to
XATTR_FILLCOLOR (XFillColorItem) and XATTR_FILLSTYLE (XFillStyleItem). 
However, ADDING these attributes to the frame during import didn't help (and
seemed to get lost).

The frame's Area-Fill-Tab and the sidebar do not recognize the current color or
fillstyle either.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101826] textbox background fill lost when round-tripping in .doc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101826

Justin L  changed:

   What|Removed |Added

   Keywords||bibisected, bisected,
   ||filter:doc
 CC||jl...@mail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs