[Libreoffice-bugs] [Bug 102277] Saving a version deletes the Digital Signature

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102277

Cor Nouws  changed:

   What|Removed |Added

 Resolution|NOTABUG |WONTFIX

--- Comment #8 from Cor Nouws  ---
(In reply to Ferry Toth from comment #7)

> The current behaviour restricts the usefulness of versions and forces users
> to keep different files for each signed version.

Reading comments, I conclude that it is doubtful if can work at all.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102277] Saving a version deletes the Digital Signature

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102277

--- Comment #7 from Ferry Toth  ---
I get that it is not a bug, it is a request for enhancement.

To me it sounds logical that currently the file (package) is signed, while it
sounds more logical that the document (stream) needs to be signed. Opening a
previous version (other stream) should then just show the signature of the
previous version.

The current behaviour restricts the usefulness of versions and forces users to
keep different files for each signed version.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102277] Saving a version deletes the Digital Signature

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102277

Cor Nouws  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |NOTABUG

--- Comment #6 from Cor Nouws  ---
per advice: NotABug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102277] Saving a version deletes the Digital Signature

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102277

--- Comment #5 from Thorsten Behrens (CIB)  ---
(In reply to Miklos Vajna from comment #4)
> Signing happens at an ODF package level, while versions add new streams in
> the ODF package, so this works as expected.
> 

In addition, saving (even if nothing has changed in the document)
never reuses the xml streams, but creates them from internal state. So
it is not guaranteed that the same xml is written at two different
times, or even less so from two different libreoffice versions. So
likely the signature will be inadvertedly invalidated.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102277] Saving a version deletes the Digital Signature

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102277

--- Comment #4 from Miklos Vajna  ---
Signing happens at an ODF package level, while versions add new streams in the
ODF package, so this works as expected.

You can't really swap this (sign first, versions later) as an unsigned stream
invalidates the signature in ODF. I would suggest to close this as a not-a-bug.

In theory you could have this feature (if you ignore backwards compatibility),
but then you would loose the ability to say that if a stream is not signed, the
signature is not valid.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102277] Saving a version deletes the Digital Signature

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102277

Cor Nouws  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||vmik...@collabora.co.uk
 Ever confirmed|0   |1

--- Comment #3 from Cor Nouws  ---
A popup appears:
" Saving will remove all existing signatures. Do you want to ... "

Version: 6.1.0.0.alpha0+
Build ID: 7a6df88f2579c4fcfa81eb27f6db9e8e21c9a6f8
CPU threads: 4; OS: Linux 4.13; UI render: default; VCL: gtk2; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time:
2018-01-14_22:46:48
Locale: nl-NL (nl_NL.UTF-8); Calc: group threaded

@miklos, @samuel: what are your ideas

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102277] Saving a version deletes the Digital Signature

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102277

Xisco Faulí  changed:

   What|Removed |Added

 CC||xiscofa...@libreoffice.org

--- Comment #2 from Xisco Faulí  ---
(In reply to Cor Nouws from comment #1)
> (In reply to Ferry Toth from comment #0)
> > This is a shame as 'versions' are made read only anyway and could easily
> > have the old signature intact.
> 
> I'm not sure if the file structure of a 'versioned' document supports the
> needs of digital signatures. But it's an interesting thing indeed.
> 
> (Can test later, I think)

Hi Cor,
Did you have the chance to test it?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102277] Saving a version deletes the Digital Signature

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102277

Samuel Mehrbrodt (CIB)  changed:

   What|Removed |Added

 CC||s.mehrbr...@gmail.com
 Blocks||105605


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=105605
[Bug 105605] [META] Digital signatures bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102277] Saving a version deletes the Digital Signature

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102277

Cor Nouws  changed:

   What|Removed |Added

 CC||c...@nouenoff.nl
Version|5.2.0.4 release |unspecified

--- Comment #1 from Cor Nouws  ---
(In reply to Ferry Toth from comment #0)
> This is a shame as 'versions' are made read only anyway and could easily
> have the old signature intact.

I'm not sure if the file structure of a 'versioned' document supports the needs
of digital signatures. But it's an interesting thing indeed.

(Can test later, I think)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs