[Libreoffice-bugs] [Bug 103158] Pressing ctrl+shift switches to LTR

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103158

--- Comment #7 from Maxim Monastirsky  ---
So I did some testing with old versions:

4.3.7, 4.4.3, 5.0.6 - Ctrl+Shift works with key-up (correct).
5.1.5, 5.1.6 - does not work at all.
5.2.2, master - works with key-down (wrong).

So would be interesting to find out both what broke it in 5.1, and what "fixed"
it in 5.2 the wrong way...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103158] Pressing ctrl+shift switches to LTR

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103158

--- Comment #6 from kompilainenn <79045_79...@mail.ru> ---
(In reply to Yousuf Philips (jay) from comment #5)
> This also negatively affects users who are using the Ctrl + Shift
> combination with other keyboard layouts (bug 88027).

hmm.. i don't think, that my bug and this bug linked. In my bug shortcut simple
don't work in RU keyboard layout (by default on my computer). Even shortcut
"Ctrl + ," without key "Shift". And after switch keyboard layout to EN
(Ctrl+Shift), shortcuts work.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103158] Pressing ctrl+shift switches to LTR

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103158

--- Comment #5 from Yousuf Philips (jay)  ---
This also negatively affects users who are using the Ctrl + Shift combination
with other keyboard layouts (bug 88027).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103158] Pressing ctrl+shift switches to LTR

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103158

--- Comment #4 from Yousuf Philips (jay)  ---
(In reply to Maxim Monastirsky from comment #3)
> Alt+Shift is for switching input languages (not just RTL/LTR), Ctrl+Shift is
> for changing direction. These two are unrelated:

Yep true, i normally never use the keyboard for that option. :D

> Then the solution would be to make Ctrl+Shift work on key-up event, similar
> to Windows, as now it seems to work on key-down, and so is toggling every
> time you try to use some defined Ctrl+Shift+something shortcut.

Yes i was going to suggest that in my last comment but left it out, as i wasnt
sure if it was possible to do that as i tested Ctrl+B and it takes affect on
key-down and not key release.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103158] Pressing ctrl+shift switches to LTR

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103158

--- Comment #3 from Maxim Monastirsky  ---
(In reply to Yousuf Philips (jay) from comment #2)
> The standard shortcut on windows is Left Alt+Shift for switching back and
> forth between RTL/LTR languages,
Alt+Shift is for switching input languages (not just RTL/LTR), Ctrl+Shift is
for changing direction. These two are unrelated:

https://blogs.technet.microsoft.com/office_global_experience/2010/02/19/useful-tricks-and-shortcuts-for-users-around-the-world/

As I said it also works in Notepad, and even flips the side of the scrollbar.
It has the same effect as choosing "Right to left Reading order" from the
context menu.

> But with ctrl+shift toggling LTR rather than only working with its defined
> shortcut key, it makes it quite a chore to select text with the keyboard for
> RTL users, because one it switches to LTR you have to select in the opposite
> direction to get what you were expecting to select and you also have to
> switch the paragraph back to RTL once you are finished.
Then the solution would be to make Ctrl+Shift work on key-up event, similar to
Windows, as now it seems to work on key-down, and so is toggling every time you
try to use some defined Ctrl+Shift+something shortcut.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103158] Pressing ctrl+shift switches to LTR

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103158

--- Comment #2 from Yousuf Philips (jay)  ---
(In reply to Maxim Monastirsky from comment #1)
> That's a feature, see here:
> 
> http://opengrok.libreoffice.org/xref/core/sw/source/uibase/docvw/edtwin.
> cxx#5535
> 
> But this code is there since 2002, so not sure what was changed since 4.3.

Well that is strange.

> BTW Ctrl+Shift is a standard shortcut in Windows to change text direction
> (in Notepad, Word etc.). Left Ctrl+Shift change to LTR, and the right ones
> to RTL.

The standard shortcut on windows is Left Alt+Shift for switching back and forth
between RTL/LTR languages, atleast thats what i've been using for years. I use
the same one on linux.

http://www.digitalcitizen.life/sites/default/files/img/win8_inputlang/change_keyboard10.png

But with ctrl+shift toggling LTR rather than only working with its defined
shortcut key, it makes it quite a chore to select text with the keyboard for
RTL users, because one it switches to LTR you have to select in the opposite
direction to get what you were expecting to select and you also have to switch
the paragraph back to RTL once you are finished.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103158] Pressing ctrl+shift switches to LTR

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103158

Maxim Monastirsky  changed:

   What|Removed |Added

 CC||momonas...@gmail.com

--- Comment #1 from Maxim Monastirsky  ---
That's a feature, see here:

http://opengrok.libreoffice.org/xref/core/sw/source/uibase/docvw/edtwin.cxx#5535

But this code is there since 2002, so not sure what was changed since 4.3.

BTW Ctrl+Shift is a standard shortcut in Windows to change text direction (in
Notepad, Word etc.). Left Ctrl+Shift change to LTR, and the right ones to RTL.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103158] Pressing ctrl+shift switches to LTR

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103158

Khaled Hosny  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||khaledho...@eglug.org
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs