[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

⁨خالد حسني⁩  changed:

   What|Removed |Added

 Resolution|WONTFIX |---
   Assignee|libreoffice-b...@lists.free |kha...@libreoffice.org
   |desktop.org |
 Status|RESOLVED|NEW

--- Comment #52 from ⁨خالد حسني⁩  ---
Re-opening as I’m working again on this and the results are encouraging so far.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

--- Comment #51 from Victor Patrick  ---
You there, this is really good post here. Thanks for taking the time to post
such valuable information. Quality content is what always gets the visitors
coming. https://rainbowfriendschapter2.com/

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

Luke  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||2079

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

--- Comment #50 from خالد حسني  ---
(In reply to Mike Kaganski from comment #49)
> (In reply to خالد حسني from comment #45)
> 
> IIUC, this still forces integral pixels on the start/end of any text run,
> right? So only the middle of the text benefits from whatever library may
> provide. And the bounds would still suffer from the same problem? I might of
> course misunderstand how it is implemented.

I don’t know.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

--- Comment #49 from Mike Kaganski  ---
(In reply to خالد حسني from comment #45)

IIUC, this still forces integral pixels on the start/end of any text run,
right? So only the middle of the text benefits from whatever library may
provide. And the bounds would still suffer from the same problem? I might of
course misunderstand how it is implemented.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

--- Comment #48 from Eyal Rozenberg  ---
(In reply to خالد حسني from comment #47)

Ok, I see... well, in that case, I have to open a separate bug about
positioning/coordinate precision that's not specific to text glyph
positioning... some of you on the CC list may be interested in 152079, and
sorry for the spam.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

Eyal Rozenberg  changed:

   What|Removed |Added

 Blocks|44267   |


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=44267
[Bug 44267] Add Option to Change Number of Decimal Places in Draw
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

--- Comment #47 from خالد حسني  ---
(In reply to Eyal Rozenberg from comment #46)
> (In reply to خالد حسني from comment #45)
> > This bug is about subpixel glyph positioning, floating point coordinates is
> > one way to fix it but it isn’t going to happen and we now have achieved this
> > using something closer to what is described in comment 14.
> 
> Ah, so coordinates are now scaled fixed-point? 

Yes, though I think this is done selectively (e.g. inside the documents but not
for UI text, or something like that). There are quite a few bug reports that
track this.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

--- Comment #46 from Eyal Rozenberg  ---
(In reply to خالد حسني from comment #45)
> This bug is about subpixel glyph positioning, floating point coordinates is
> one way to fix it but it isn’t going to happen and we now have achieved this
> using something closer to what is described in comment 14.

Ah, so coordinates are now scaled fixed-point? Or is it just something being
planned?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

--- Comment #45 from خالد حسني  ---
(In reply to Eyal Rozenberg from comment #44)
> (In reply to خالد حسني from comment #43)
> > and we have better fix in 7.4/7.5 already.
> 
> No, we don't. Can you explain what you mean and why you suddenly closed this
> bug?

This bug is about subpixel glyph positioning, floating point coordinates is one
way to fix it but it isn’t going to happen and we now have achieved this using
something closer to what is described in comment 14.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

--- Comment #44 from Eyal Rozenberg  ---
(In reply to خالد حسني from comment #43)
> and we have better fix in 7.4/7.5 already.

No, we don't. Can you explain what you mean and why you suddenly closed this
bug?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

خالد حسني  changed:

   What|Removed |Added

 Resolution|--- |WONTFIX
 Status|NEW |RESOLVED

--- Comment #43 from خالد حسني  ---
This is not going to happen, and we have better fix in 7.4/7.5 already.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

Johnny_M  changed:

   What|Removed |Added

URL||https://www.bountysource.co
   ||m/issues/93297186-use-float
   ||ing-point-for-glyph-positio
   ||ning-in-vcl

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

Xisco Faulí  changed:

   What|Removed |Added

URL|https://www.regainsoftware. |
   |com/office365-to-pst-conver |
   |ter.html|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

Regain Software  changed:

   What|Removed |Added

URL|https://www.regainsoftware. |https://www.regainsoftware.
   |com/ost-to-pst-converter.ht |com/office365-to-pst-conver
   |ml  |ter.html

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

Regain Software  changed:

   What|Removed |Added

URL|https://www.bountysource.co |https://www.regainsoftware.
   |m/issues/93297186-use-float |com/ost-to-pst-converter.ht
   |ing-point-for-glyph-positio |ml
   |ning-in-vcl |
  Component|graphics stack  |LibreOffice

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

--- Comment #42 from shoviv  ---
Often occurs it sometimes good to see file this bug here. 
https://www.shoviv.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

mj.Jernigan  changed:

   What|Removed |Added

 CC||mj_jerni...@yahoo.com

--- Comment #41 from mj.Jernigan  ---
Created attachment 182345
  --> https://bugs.documentfoundation.org/attachment.cgi?id=182345=edit
Tahoma example text in LO 5.1, 7.1, and 7.4

I hope the attached image helps.  To me, at least, the kerning issue appears
resolved in LO 7.4.  Previously, I had _mostly_ noticed kerning issues around
punctuation in the Tahoma font, as you can see in the attached image of text
taken from the same document as rendered in PDF (which pretty well shows
something more than just a sub-pixel issue).  You can also see that 7.4 is
nearly the same as 5.1 with some minor sub-pixel differences.  Kerning between
letters (such as "fa") also appears better.

I looked at the previous mention of "California" in Liberation Sans, 12pt, 120%
zoom, and it appears better as well in 7.4--although, that "rn" will likely
always be a bit hard to discern.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

Aron Budea  changed:

   What|Removed |Added

   See Also|https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=11 |
   |1631,   |
   |https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=12 |
   |3182,   |
   |https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=12 |
   |2626,   |
   |https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=14 |
   |0083|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

Aron Budea  changed:

   What|Removed |Added

   See Also|https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=96 |
   |892,|
   |https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=65 |
   |972,|
   |https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=12 |
   |1761,   |
   |https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=12 |
   |1952,   |
   |https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=12 |
   |2638,   |
   |https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=12 |
   |3071,   |
   |https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=13 |
   |0018,   |
   |https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=14 |
   |0101,   |
   |https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=14 |
   |0161,   |
   |https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=12 |
   |8987,   |
   |https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=13 |
   |2705|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

--- Comment #40 from Khaled Hosny  ---
I agree with Aron’s comment above. I think folks are overemphasizing what kind
of issues this change can fix. To be honest, I don’t expect it to fix any
glaring issues any more, possibly only subtler sub-pixel positioning issues.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

Aron Budea  changed:

   What|Removed |Added

 Blocks|142940  |


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=142940
[Bug 142940] Fonts are poorly rendered to display with pair kerning enabled,
means to control without losing published quality
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

Aron Budea  changed:

   What|Removed |Added

 Blocks|133276  |


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=133276
[Bug 133276] Wrong characters formatting (kerning) after odt file opened in LO
Writer > 5.3 release (harfbuzz)
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

Aron Budea  changed:

   What|Removed |Added

 Blocks|88991   |


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=88991
[Bug 88991] VIEWING: Kerning issues with certain fonts like Arial
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

Aron Budea  changed:

   What|Removed |Added

 Blocks|133273  |


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=133273
[Bug 133273] When I write a text in Writer and use the font Tahoma, then some
letters stick together.
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

Aron Budea  changed:

   What|Removed |Added

   See Also|https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=11 |
   |5939|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

Aron Budea  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||4862

--- Comment #39 from Aron Budea  ---
A lot of issues associated with this enhancement should be fixed in 7.4 by
Caolán's fix to bug 144862. Would be good to systematically retest these bugs,
and if they're indeed fixed, mark as duplicates of that, and clean up the see
also/duplicate/blocked bugs.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

Aron Budea  changed:

   What|Removed |Added

 Blocks|128987  |


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=128987
[Bug 128987] Bad font rendering in Writer, mainly with serif fonts: it seems
like font kerning has gone awry
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

Aron Budea  changed:

   What|Removed |Added

 Blocks|123182  |


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=123182
[Bug 123182] Very Bad Character Kerning in Verdana pt11 in writer especially
Letter 'm' (depending on zoom level)
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

V Stuart Foote  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||0263

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

Iandol  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=13
   ||2705

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

Iandol  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||8987

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

V Stuart Foote  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||9700

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

Adam Fontenot  changed:

   What|Removed |Added

 CC||adam.m.fontenot+docfo@gmail
   ||.com

--- Comment #38 from Adam Fontenot  ---
Created attachment 176857
  --> https://bugs.documentfoundation.org/attachment.cgi?id=176857=edit
"California" rendered in Liberation Serif at 12pt, 120% zoom on my screen

During some work on related Bug 142940, I came across a particularly bad
example of the issues caused by this bug and wanted to add it as an example.

It's the single word "California" rendered in Liberation Serif at 12pt, 120%
zoom on my screen. In this case, among many other issues, the renderer has
chosen to place the 'r' and 'n' characters so close together that they actually
overlap and appear to be an 'm'. It's a good illustration of how the lack of
subpixel positioning for glyphs ruins any attempt at proper kerning.

Incidentally, the related bug is about the fact that disabling pair kerning
ameliorates some of these problems. In this case, an extra pixel is placed
between the 'r' and 'n', probably because kerning nudges them slightly closer
together and creates situations where rounding will force them to overlap.

This specific image was created with a script I wrote to rerender a screenshot
as virtual subpixels with the same RGB alignment as my actual screen, and then
point upscaled three times. This allows users who may be on very different
screens to see exactly what rendering decisions Libreoffice + Fontconfig is
making for my screen.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

Telesto  changed:

   What|Removed |Added

 Blocks||145962


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=145962
[Bug 145962] [META] Bugs related to kerning/font spacing (cramped/to
width/wiggling)
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

Telesto  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||3765

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

Telesto  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||0161

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

--- Comment #37 from gibt...@gmx.de ---
I noticed that using FreeType and HarfBuzz in OpenCV, it is possible to write
strings with integer precision to images that look absolutely fine. Still, the
whole string is put as a whole to the image, please refer to the OpenCV
documentation for or details:
https://docs.opencv.org/3.4/d9/dfa/classcv_1_1freetype_1_1FreeType2.html

Thus I thought that the reason for this ugly rendering might simply be that
LibreOffice splits the whole strings into individual characters that are 
written individually? For example, instead of writing "Hello world!" as a
whole, LibreOffice puts all chars/glyphs "H", "e", "l", "l", "o", etc. one
after another and recalculates the glyph position every time again in integer
arithmetic only? Even if the latter was replaced by floats, I don't know if
this even fixes the problem if HarfBuzz still uses integers for the initial
rendering of the string... I don't know LibreOffice's code, still if FreeType /
HarfBuzz is used correctly, rounding issues coming from integer instead of
floating point accuracy should only influence the initial position of the
string (i.e. a whole line of text), but not between characters / words.
I might be wrong, still this seems rather plausible to me such that a fix might
be even easier than migrating all of LibreOffice's code to floats...

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

--- Comment #36 from Buovjaga  ---
*** Bug 135127 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

V Stuart Foote  changed:

   What|Removed |Added

 Blocks||142940


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=142940
[Bug 142940] Enabling pair kerning breaks rendering of many common fonts
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

bugzi...@tofof.com changed:

   What|Removed |Added

 Attachment #171469|171468: Libre Calc, |Libre Calc, toggling
description|toggling between good and   |between good and bad
   |bad kerning |kerning

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

bugzi...@tofof.com changed:

   What|Removed |Added

 Attachment #171468|0   |1
is obsolete||

--- Comment #35 from bugzi...@tofof.com ---
Created attachment 171469
  --> https://bugs.documentfoundation.org/attachment.cgi?id=171469=edit
171468: Libre Calc, toggling between good and bad kerning

Replacing poorly encoded gif.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

--- Comment #34 from bugzi...@tofof.com ---
Created attachment 171468
  --> https://bugs.documentfoundation.org/attachment.cgi?id=171468=edit
Libre Calc, toggling between good and bad kerning

In Libre Calc, pressing F2 to edit text produces mostly-accurate kerning until
editing mode is escaped. See attachment.
Libre build ID: 3d775be2011f3886db32dfd395a6a6d1ca2630ff

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

--- Comment #33 from Telesto  ---
FYI, I'm inclined to blame:
fdo#52028: sw: let text formatting ignore RSID in automatic styles
A suprising regression from 062eaeffe7cb986255063bb9b0a5f3fb3fc8e34c:
The RSID text attributes that are inserted for every user-inserted text
cause the text formatting (SwAttrIter) to create a lot more text portions,
and the portion breaks make font kerning impossible.

based on bug 140161. The whole floating point topic might not solve the issue
at all.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

steve  changed:

   What|Removed |Added

URL||https://www.bountysource.co
   ||m/issues/93297186-use-float
   ||ing-point-for-glyph-positio
   ||ning-in-vcl

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

Telesto  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||0083

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

--- Comment #32 from lvcivs  ---
The bug bounty on this has been raised to $250 USD:

https://www.bountysource.com/issues/93297186-use-floating-point-for-glyph-positioning-in-vcl

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

Telesto  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||0101

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

V Stuart Foote  changed:

   What|Removed |Added

 Blocks||133273


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=133273
[Bug 133273] When I write a text in Writer and use the font Tahoma, then some
letters stick together.
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

--- Comment #31 from R  ---
Hey it took me a while but I finally found this bug.

I experience this too, on Linux, and it's really debilitating - it's why I
still run MS Office through Wine.

Is using floating point numbers going to be much of an issue?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

--- Comment #30 from Buovjaga  ---
(In reply to P. Rosquin from comment #29)
> I just posted a humble bounty on this in bountysource. Don't forget to claim
> it when it is solved!

I found it:
https://www.bountysource.com/issues/93297186-use-floating-point-for-glyph-positioning-in-vcl

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

--- Comment #29 from P. Rosquin  ---
I just posted a humble bounty on this in bountysource. Don't forget to claim it
when it is solved!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

--- Comment #28 from Telesto  ---
Created attachment 166100
  --> https://bugs.documentfoundation.org/attachment.cgi?id=166100=edit
Another example file

First off, sorry for noise; but like add/collect examples

STR:
Problem occurs depending zoom level. In my case 23" 96 DPI at 140% they 'l' in
beleid' is not properly spaced. On my 11 macbook they c in protocol nearly
overlapping to o.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

--- Comment #27 from Telesto  ---
Created attachment 163982
  --> https://bugs.documentfoundation.org/attachment.cgi?id=163982=edit
Example file (vertical spacing)

STR
1. Open the attached file
2. Zoom out so you can see the full page
3. Select the the table
4. Apply different table styles from sidebar -> Table styles. Notice shifting
text (vertical)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

--- Comment #26 from V Stuart Foote  ---
*** Bug 135445 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

--- Comment #25 from Telesto  ---
Created attachment 163521
  --> https://bugs.documentfoundation.org/attachment.cgi?id=163521=edit
Screencast

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

--- Comment #24 from Telesto  ---
Created attachment 163520
  --> https://bugs.documentfoundation.org/attachment.cgi?id=163520=edit
Example file

1. Open the attached file
2. Select the dot & space between "lost. After"
3. Press bold
4. CTRL+Z
5. CTRL+Y

Everything will shift from 5.3 (Harfbuzz). To 'o' of you will jiggle with older
versions.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

Caolán McNamara  changed:

   What|Removed |Added

   See Also|https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=13 |
   |4326|

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

V Stuart Foote  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=13
   ||4326

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

V Stuart Foote  changed:

   What|Removed |Added

 Blocks||133276


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=133276
[Bug 133276] Wrong characters formatting (kerning) after odt file opened in LO
Writer > 5.3 release (harfbuzz)
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

--- Comment #23 from shack...@gmail.com ---
Created attachment 157431
  --> https://bugs.documentfoundation.org/attachment.cgi?id=157431=edit
Artifact when scrolling text

Adding this image to this bug because the one I opened depends on it. It shows
an artifact that I get when I scroll a document: text gets deformed, with
elongated characters, often unaligned. I think it's related to the problem with
using integers rather than floating points for glyph positioning.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

V Stuart Foote  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=13
   ||0018

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

V Stuart Foote  changed:

   What|Removed |Added

 Blocks||123182


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=123182
[Bug 123182] Very Bad Character Kerning in Verdana pt11 in writer especially
Letter 'm' (depending on zoom level)
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

V Stuart Foote  changed:

   What|Removed |Added

 Blocks||128987


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=128987
[Bug 128987] Bad font rendering in Writer, mainly with serif fonts: it seems
like font kerning has gone awry
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

Xisco Faulí  changed:

   What|Removed |Added

 CC||xiscofa...@libreoffice.org
   Priority|medium  |high

--- Comment #22 from Xisco Faulí  ---
Changing enhancement priority to 'high' since the number of people in CC is
higher than 20

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

--- Comment #21 from gibt...@gmx.de ---
I also noticed this bug and finally found this thread... Two points from my
side: First, I do not really understand how this is a desktop scaling / HiDPI
bug? For me this would mean that at 100% desktop scaling this issue should not
appear, or am I wrong here? I also tested two different Full HD screens and an
old 1280x1024 screen that all use desktop scaling 100% (here I'm referring to
the 100% scale that can be configured under Windows' screen properties) - and
the issue is definitely visible. How can this happen if it is a HiDPI issue?

And then my second question, where I'm especially referring to Rachel's
comment. I didn't look into the code, but if the whole coordinate stuff has to
be migrated from int to float (or double), wouldn't it be a feasible approach
to start with changing "only" any involved variable definition from int to
float as a first step, without changing anything else? So we would only save
our ints in float-valued variables (maybe introducing implicit cast warnings)
but once done, the positioning code could be migrated step by step to fully
support float?

Also hoping this issue gets fixed soon. Especially for Impress presentations it
can really be a show stopper if the slides are not properly rendered...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

V Stuart Foote  changed:

   What|Removed |Added

 Blocks||127186


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=127186
[Bug 127186] FORMATTING: underbrace/overbrace too narrow(tiny height) to be
legible
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

V Stuart Foote  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||2626

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

Dieter Praas  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||3182

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

--- Comment #20 from horus  ---
(In reply to Buovjaga from comment #18)
> 
> Please revisit after this report is marked RESOLVED FIXED

OK

(In reply to V Stuart Foote from comment #19)
> 
> It remains the same, the commit in comment 16 is only a part [1] of what
> will be a major refactoring--functionally nothing has changed yet in
> composing what displays.
> 
> Hang in there!

Alright

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

--- Comment #19 from V Stuart Foote  ---
(In reply to horus from comment #17)
> So, maybe that bug is actually not related to this bug?

It remains the same, the commit in comment 16 is only a part [1] of what will
be a major refactoring--functionally nothing has changed yet in composing what
displays.

Hang in there!

=-ref-=
https://gerrit.libreoffice.org/#/c/70436/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

Buovjaga  changed:

   What|Removed |Added

 CC||todven...@suomi24.fi

--- Comment #18 from Buovjaga  ---
(In reply to horus from comment #17)
> I'm the reporter of bug 113665 which was marked as a duplicate of this bug.
> 
> I have tried the following daily builds but the problem described in bug
> 113665  is still present:
> * libo-master64~2019-05-22_00.57.02_LibreOfficeDev_6.3.0.0.alpha1_Win_x64.msi
> * libo-master64~2019-05-29_09.41.50_LibreOfficeDev_6.3.0.0.alpha1_Win_x64.msi
> *
> master~2019-05-24_22.08.51_LibreOfficeDev_6.3.0.0.alpha1_Win_x64_en-
> US_de_ar_ja_ru_vec_qtz.msi
> *
> master~2019-05-29_04.28.58_LibreOfficeDev_6.3.0.0.alpha1_Win_x64_en-
> US_de_ar_ja_ru_vec_qtz.msi
> 
> So, maybe that bug is actually not related to this bug?

Please revisit after this report is marked RESOLVED FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

--- Comment #17 from horus  ---
I'm the reporter of bug 113665 which was marked as a duplicate of this bug.

I have tried the following daily builds but the problem described in bug 113665
 is still present:
* libo-master64~2019-05-22_00.57.02_LibreOfficeDev_6.3.0.0.alpha1_Win_x64.msi
* libo-master64~2019-05-29_09.41.50_LibreOfficeDev_6.3.0.0.alpha1_Win_x64.msi
*
master~2019-05-24_22.08.51_LibreOfficeDev_6.3.0.0.alpha1_Win_x64_en-US_de_ar_ja_ru_vec_qtz.msi
*
master~2019-05-29_04.28.58_LibreOfficeDev_6.3.0.0.alpha1_Win_x64_en-US_de_ar_ja_ru_vec_qtz.msi

So, maybe that bug is actually not related to this bug?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

Dieter Praas  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||3071

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:6.3.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

--- Comment #16 from Commit Notification 
 ---
Alexander Farrow committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/a39f2e1943c7092dd32bd1f4e480ee6da54a80e4%5E%21

tdf#103322 GlyphItem::m_aLinearPos use getX() instead of X()

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

--- Comment #15 from Telesto  ---
*** Bug 108484 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

Telesto  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||2638

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

Mike Kaganski  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||1761,
   ||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||1952

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

Mike Kaganski  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||9887

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

V Stuart Foote  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||9070

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

Telesto  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=65
   ||972

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

--- Comment #14 from Khaled Hosny  ---
Another alternative to floating point, is to keep using integers but use a
scale, so instead of shaping at 10 pixels and drawing at the coordinates we
get, we shape at 10 * SCALE and shape ant coordinates / SCALE. Which is what
many other libraries do, and I vaguely remember that we have something similar
by may be we are not using it thoroughly. Worth investigating.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

--- Comment #13 from Rachel Greenham  ---
For me it presents as a HiDPI bug, in that it's when desktop scaling is at
200%, 300%, text (any font) can be quite a reasonable editing size on screen
but show this poor positioning of glyphs within each word, making it
headache-inducing to look at, and actually a serious impediment to wanting to
use the software. Of course it was there before, HiDPI just amplifies it,
making it a problem at larger font sizes as displayed on screen.

As the worst problem is just the positioning of glyphs within words I looked
for the code that does that. It seems to be mostly in
vcl/source/gdi/CommonSalLayout.cxx, where the actual work is delegated to
Harfbuzz, which appears to work in integers, but I think at a very high
resolution (whatever a upem is). The values that then come out of that then
have a scale applied at double, rounded, and I suspect subject to more scaling
later, in particular with respect to the desktop scaling factor in HiDPI modes.
And that's probably where it's going wrong.

I had a play with trying to fix things locally in here and in
vcl/source/gdi/sallayout.cxx, changing all the glyph positioning code to use
doubles (and B2DPoint etc), including changing GlyphItem (sallayout.hxx) to use
those types for its positions, widths and offsets and rounding as necessary at
the edges of that, but I did rather get lost in the weeds, specifically, where
to find the edges of it, to minimise the disruption to the rest of the
codebase.

I suspect a fix can't really be confined like that, and it's probably
undesirable anyway. It looks like we'd probably want to make DeviceCoordinate a
double (as controlled in config_host/config_vcl.h.in showing this has been at
least partially prepared-for) and follow *everywhere* that leads, one such
place being the text functions in outdev.hxx of course.

Then final rounding to integers for actual pixels on screen would probably want
to happen in platform specific code. As absolutely late as possible, at the
moment of output, anyway. Then if and when there's a platform that takes double
coordinates that rounding simply doesn't have to happen there.

Regarding the suggestion of going via B2IPoint and friends as an intermediate
step towards B2DPoint and friends, I note that the B2I types are carefully
defined to use 32-bit ints (sal_Int32), whereas Point, Rectangle et al use long
(which let's face it *is* 64-bit almost everywhere that matters now) as does
much existing position-calculating code. So I'd worry that we'd be setting
ourselves up for a fight to resolve issues relating to that loss of range when
it's only needed as an intermediate step.

... All of which would be an absolutely gigantic changeset, no wonder no-one
who knows the code wants to do it! The more I poked around in this the more I
thought, "Oh God, no..." and "Can we *really* not localise this fix in
sallayout?" :-) But no, ultimately changing *all* the device coordinate code to
double is probably what has to happen one day.

Another thought I had, noticing that in OpenOffice.org Writer on a 4K screen of
course has no HiDPI awareness to speak of, so its user interface is unusable,
but zoom in on the text to an editing size and it looks fine - at 240% zoom you
would expect that, of course. Pretty much the same applies in LibreOffice
Writer if you set your desktop scaling to 100% on a 4K screen. So I wondered,
what if instead you just *not* apply desktop scaling on the document view
panes/frames whatever they're called here, and, um, *lie* on the user
interface, ie: multiply the user selected zoom by the desktop scaling factor?
:-)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

--- Comment #12 from Khaled Hosny  ---
(In reply to Mike Kaganski from comment #11)
> Do we have a (compact) API subset that needs to be changed from int to
> double to start the change?

I’d start with the “Text functions” section in include/vcl/outdev.hxx and go
down and up from there.

We will need to switch from tools::Point, tools::Rectangle etc. to
basegfx::B2DPoint, basegfx::B2DRectangle, not just int to float/double. May be
using basegfx::B2IPoint first since they are still int-based, so the first
round would focus on the difference in semantics and API between tools and
basegfx, then next round would tackle the actual floating pint conversion.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

--- Comment #11 from Mike Kaganski  ---
Do we have a (compact) API subset that needs to be changed from int to double
to start the change?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

V Stuart Foote  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||5939

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

Telesto  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||1631

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

V Stuart Foote  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=96
   ||892

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

Buovjaga  changed:

   What|Removed |Added

 CC||lapsap7+...@gmail.com

--- Comment #10 from Buovjaga  ---
*** Bug 113665 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

--- Comment #9 from Khaled Hosny  ---
(In reply to Yousuf Philips (jay) from comment #8)
> Caolan may have fixed this here.
> 
> tdf#107249 round ascent/descent/extleading on conversion to int
> http://cgit.freedesktop.org/libreoffice/core/commit/
> ?id=0c8b749e602b6743857a9bc4efb24b6183690311

That is a different issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

Yousuf Philips (jay)  changed:

   What|Removed |Added

 CC||philip...@hotmail.com

--- Comment #8 from Yousuf Philips (jay)  ---
Caolan may have fixed this here.

tdf#107249 round ascent/descent/extleading on conversion to int
http://cgit.freedesktop.org/libreoffice/core/commit/?id=0c8b749e602b6743857a9bc4efb24b6183690311

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

V Stuart Foote  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||7249

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

V Stuart Foote  changed:

   What|Removed |Added

 Blocks||44267


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=44267
[Bug 44267] Two decimal digits are probably not enough to specify object
position and size
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

--- Comment #7 from Khaled Hosny  ---
No one is currently working on this, feel free to work on it yourself or
recruit someone to work on it.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

--- Comment #6 from DeepFlight5  ---
Sorry, my commentary from February had an error. It should read:

"I assume the "float" problem lies in the LibreOffice code and not in HarfBuzz,
since HarfBuzz is used in Firefox and Chrome also, which have no problems with
accurate glyph display. Will this "float" bug of LibreOffice be fixed anywhere
soon?"

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

Khaled Hosny  changed:

   What|Removed |Added

   See Also|https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=10 |
   |6653|

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

V Stuart Foote  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||6653

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

Khaled Hosny  changed:

   What|Removed |Added

 CC||gilward.ku...@gmail.com

--- Comment #5 from Khaled Hosny  ---
*** Bug 106495 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103322

--- Comment #4 from DeepFlight5  ---
I assume the "float" problem lies in the Firefox code, since HarfBuzz is used
in Firefox and Chrome also, which have no problems with glyph display. Will
this "float" bug be fixed anywhere soon?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs