[Libreoffice-bugs] [Bug 103679] Session dropped on PutFile error

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103679

Pranav Kant  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103679] Session dropped on PutFile error

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103679

Xisco Faulí  changed:

   What|Removed |Added

 CC||xiscofa...@libreoffice.org

--- Comment #9 from Xisco Faulí  ---
Hello,
Is this bug fixed?
If so, could you please close it as RESOLVED FIXED?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103679] Session dropped on PutFile error

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103679

--- Comment #8 from Commit Notification 
 ---
Pranav Kant committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/online/commit/?id=a149a0c2e164bd42677aec3a50c9a8a0421d1105

tdf#103679: Don't always change document permission on error

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103679] Session dropped on PutFile error

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103679

--- Comment #7 from Commit Notification 
 ---
Pranav Kant committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/online/commit/?id=f8e0b8c11e94810fdde73f8b4d27b80a989670cb

tdf#103679: Handle storage diskfull & other PutFile errors

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103679] Session dropped on PutFile error

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103679

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:5.3.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103679] Session dropped on PutFile error

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103679

--- Comment #6 from Aleksander Machniak  ---
(In reply to Pranav Kant from comment #5)
> What happens if the document owner loses the connection for some reason ?

What happens if there's only one user and he loses connection?

> Would no one be able to save the document, or all other sessions should also
> be terminated (Document owner didn't send a 'Close_Session', its just some
> connectivity issue).
> 
> What should ideally happen in such a case ?

I think we should NOT close the session. We may wait for the owner (or other
session member with write rights) to join again the session and save the
document state. Anyway, users with no write rights can still use "Download as"
feature to save the document current state locally, to not loose the data.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103679] Session dropped on PutFile error

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103679

--- Comment #5 from Pranav Kant  ---
What happens if the document owner loses the connection for some reason ? Would
no one be able to save the document, or all other sessions should also be
terminated (Document owner didn't send a 'Close_Session', its just some
connectivity issue).

What should ideally happen in such a case ?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103679] Session dropped on PutFile error

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103679

--- Comment #4 from Aleksander Machniak  ---
(In reply to Tor Lillqvist from comment #3)
> I think the problem here is that the message should say something about "or
> other server error", not just disk space?

Yes, but the error is only a part of the story. Also, if you check WOPI docs
there's 413 error code specifically for "Entity too large", which is not
exactly "No disk space", but close.

Anyway, in Kolab we have such scenario:
1. User A creates a document editing session on his file and invites User B
2. User B has no permission to that file (even read-only), just have no access
to the file,
3. However, because he was invited he can join the session and edit the
document with its owner,
4. But he has no permission to the file, he can't use the Save button. So, if
he click Save and we send the PutFile request it will respond with 404 or 500,
maybe 503.

In that scenario switching to read-only mode is not what we want. User B needs
to still be able to edit the document but he needs to ask User A to save
changes they both made.

I could consider disabling the Save button for User B on the host page, but
this is not really a solution.

On the other hand if the error happens for User A, do we really want to broke
the session? No. We should warn the user and give him possibility to download
current document state or close the session.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103679] Session dropped on PutFile error

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103679

--- Comment #3 from Tor Lillqvist  ---
I think the problem here is that the message should say something about "or
other server error", not just disk space?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103679] Session dropped on PutFile error

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103679

Michael Meeks  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||t...@iki.fi
 Ever confirmed|0   |1

--- Comment #2 from Michael Meeks  ---
Any thoughts Tor ? also - Alek - what reasons is there for returning an
internal server error ? and what do you suggest we do instead here ? if we
can't save - stopping users from editing the document further (so they loose
more data) seems reasonable - right ?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103679] Session dropped on PutFile error

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103679

--- Comment #1 from Aleksander Machniak  ---
I forgot to say that the other user can work with the document, but the faulty
user is removed from the users list.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs