[Libreoffice-bugs] [Bug 104242] Drop OpenGL as the default rendering on Windows builds and use GDI based rendering for its better layout support

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104242

--- Comment #5 from V Stuart Foote  ---
(In reply to Michael Meeks from comment #2)
> Moving away from DirectWrite sounds like going -horribly- backwards...

Sorry, I was not suggesting we could abandon DirectWrite. I was suggesting that
until we can improve our DirectWrite implementation--and ideally restore a GDI+
rendering--that the default rendering on Windows build should not be OpenGL
when a user's hardware supports it.

IIUC at 5.3.0 with Default rendering on Windows, we've reverted to "legacy"
GDI. The DirectWrite based GDI+ that was providing better sub-pixel rendering
had to be dropped as our GDI+ implementation was not behaving well with
HarfBuzz. Likewise misbehaving with HarfBuzz our OpenGL rendering remains
DirectWrite dependent--but that can not be changed.

So the choice for users who have OpenGL capable hardware is between a less than
perfect script layout with OpenGL rendering enabled, or a somewhat reduced font
rendering quality with "default" rendering now missing better DirectWrite GDI+
sub-pixel rendering.  

What rendering should Windows configuration enable by default--Default or
OpenGL?

Suspect at 5.3.0 we will be hearing quickly from users _without_ OpenGL capable
hardware about losses in their text quality. Can't be avoided, and can't be
corrected until we can improve our DirectWrite implementation.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104242] Drop OpenGL as the default rendering on Windows builds and use GDI based rendering for its better layout support

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104242

Buovjaga  changed:

   What|Removed |Added

   Keywords|needsDevEval|needsDevAdvice
 Status|NEEDINFO|UNCONFIRMED
 CC||todven...@suomi24.fi
 Ever confirmed|1   |0

--- Comment #4 from Buovjaga  ---
Let's keep NEEDINFO only for requests aimed at reporters. needsDevEval is for
potential easyhax.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104242] Drop OpenGL as the default rendering on Windows builds and use GDI based rendering for its better layout support

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104242

tommy27  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #3 from tommy27  ---
let's set status to NEEDINFO then.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104242] Drop OpenGL as the default rendering on Windows builds and use GDI based rendering for its better layout support

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104242

tommy27  changed:

   What|Removed |Added

   Keywords||needsDevEval
 CC||ba...@quipo.it

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104242] Drop OpenGL as the default rendering on Windows builds and use GDI based rendering for its better layout support

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104242

--- Comment #2 from Michael Meeks  ---
Moving away from DirectWrite sounds like going -horribly- backwards; there is
no good physical font API prior to DirectWrite - so we will continue to encode
rubbish font metrics into documents and create an ongoing support nightmare. I
would strongly prefer to use eg. freetype everywhere than existing legacy GDI
font rendering APIs.

This needs some serious thought, code reading, and ideally some better hardware
for Khaled - which I'm working on.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104242] Drop OpenGL as the default rendering on Windows builds and use GDI based rendering for its better layout support

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104242

V Stuart Foote  changed:

   What|Removed |Added

 CC||khaledho...@eglug.org,
   ||martin_hos...@sil.org,
   ||michael.me...@collabora.com
   ||, mikekagan...@hotmail.com,
   ||qui...@gmail.com,
   ||s.mehrbr...@gmail.com,
   ||tim_e...@sil.org,
   ||t...@iki.fi,
   ||vstuart.fo...@utsa.edu
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||4159
 Blocks||71732, 93529, 103729
Summary|Drop OpenGL default |Drop OpenGL as the default
   |rendering on Windows builds |rendering on Windows builds
   ||and use GDI based rendering
   ||for its better layout
   ||support
 OS|All |Windows (All)

--- Comment #1 from V Stuart Foote  ---
Kind of in a hard place here, achieved much of what the new HarfBuzz layout
engine promised. But its cost on Windows has been spotty support using our
DirectWrite and OpenGL rendering.

Khaled is not really able to resolve issues with the OpenGL rendering as he
lacks the hardware support needed to develop for it.

IIRC while implementing OpengGL rendering it was decided to make it configure
by default on the Windows builds (and catch poor GPU/driver OpenGL support with
our blacklist mechanism) and fall back to default GDI+ rendering.

In finalizing the new layout engine Khaled has gutted the DirectWrite from the
GDI rendering so it offers stable layout in all areas of the UI. 

Question is what to do about the OpenGL rendering that remains dependent on
DirectWrite calls. Believe that until it can be fixed correctly, we would
probably be better to not enable it by default on the Windows builds.

But only fair that the Devs more heavily invested in implementing OpenGL
support (and likely having to fix it) should make the call.

Thoughts?


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=71732
[Bug 71732] [META] Bugs related to text rendering, typography and font features
in LO
https://bugs.documentfoundation.org/show_bug.cgi?id=93529
[Bug 93529] [META] VCL/OpenGL tracker bug for 5.0+
https://bugs.documentfoundation.org/show_bug.cgi?id=103729
[Bug 103729] [META] tracker HarfBuzz common text layout regressions
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs