[Libreoffice-bugs] [Bug 104597] RTL script text runs are reversed on PDF import, PDFIProcessor::mirrorString misbehaving

2023-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104597

Eyal Rozenberg  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||3967

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 104597] RTL script text runs are reversed on PDF import, PDFIProcessor::mirrorString misbehaving

2022-12-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104597

خالد حسني  changed:

   What|Removed |Added

 CC||sergst...@yahoo.com

--- Comment #113 from خالد حسني  ---
*** Bug 152670 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 104597] RTL script text runs are reversed on PDF import, PDFIProcessor::mirrorString misbehaving

2022-12-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104597

خالد حسني  changed:

   What|Removed |Added

 CC||te...@danwin1210.me

--- Comment #112 from خالد حسني  ---
*** Bug 131022 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 104597] RTL script text runs are reversed on PDF import, PDFIProcessor::mirrorString misbehaving

2022-11-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104597

--- Comment #111 from Commit Notification 
 ---
Kevin Suo committed a patch related to this issue.
It has been pushed to "libreoffice-7-4":

https://git.libreoffice.org/core/commit/0a19375b73b12885f9022d82cb51e9c268cc0d6a

tdf#104597 related: restore the mirroring of Bidi_Mirrored characters

It will be available in 7.4.4.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 104597] RTL script text runs are reversed on PDF import, PDFIProcessor::mirrorString misbehaving

2022-11-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104597

--- Comment #110 from Commit Notification 
 ---
Kevin Suo committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/e788317bb58f4e4ad3bf57ee7b0e995cb4407ede

tdf#104597 related: restore the mirroring of Bidi_Mirrored characters

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 104597] RTL script text runs are reversed on PDF import, PDFIProcessor::mirrorString misbehaving

2022-11-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104597

--- Comment #109 from Kevin Suo  ---
(In reply to Hanan Sela from comment #108)
So I guess the doc will look ok when you have the David font installed on your
linux system.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 104597] RTL script text runs are reversed on PDF import, PDFIProcessor::mirrorString misbehaving

2022-11-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104597

--- Comment #108 from Hanan Sela  ---
(In reply to Hanan Sela from comment #107)
> (In reply to Kevin Suo from comment #106)
> > (In reply to Hanan Sela from comment #105)
> > 
> > As I requested earlier:
> > "Also, when testing please make sure you have the correct fonts installed on
> > your linux system (e.g. this pdf file uses Arial font in the text مكتب on
> > the header section so you should at least have Arial font instaled)."
> > 
> > The screenshot you have provided indicates that fallback font rather than
> > Arial is used.
> 
> I installed all MS fonts. Ariel is Installed. However, The Hebrew fonts does
> not seem to be Ariel but David,  but Draw selects some thing similar to
> Ariel called Liberation Serif.

The same document seems OK in Windows installation.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 104597] RTL script text runs are reversed on PDF import, PDFIProcessor::mirrorString misbehaving

2022-11-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104597

--- Comment #107 from Hanan Sela  ---
(In reply to Kevin Suo from comment #106)
> (In reply to Hanan Sela from comment #105)
> 
> As I requested earlier:
> "Also, when testing please make sure you have the correct fonts installed on
> your linux system (e.g. this pdf file uses Arial font in the text مكتب on
> the header section so you should at least have Arial font instaled)."
> 
> The screenshot you have provided indicates that fallback font rather than
> Arial is used.

I installed all MS fonts. Ariel is Installed. However, The Hebrew fonts does
not seem to be Ariel but David,  but Draw selects some thing similar to Ariel
called Liberation Serif.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 104597] RTL script text runs are reversed on PDF import, PDFIProcessor::mirrorString misbehaving

2022-11-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104597

--- Comment #106 from Kevin Suo  ---
(In reply to Hanan Sela from comment #105)

As I requested earlier:
"Also, when testing please make sure you have the correct fonts installed on
your linux system (e.g. this pdf file uses Arial font in the text مكتب on the
header section so you should at least have Arial font instaled)."

The screenshot you have provided indicates that fallback font rather than Arial
is used.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 104597] RTL script text runs are reversed on PDF import, PDFIProcessor::mirrorString misbehaving

2022-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104597

--- Comment #105 from Hanan Sela  ---
Created attachment 183883
  --> https://bugs.documentfoundation.org/attachment.cgi?id=183883=edit
screen shot of Hebrew pdf file  opened with evince (left) and draw  (right;
last build 28/11/22))

Screen shot of Hebrew pdf file  opened with evince (left) and draw  (right;
last build 28/11/22))

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 104597] RTL script text runs are reversed on PDF import, PDFIProcessor::mirrorString misbehaving

2022-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104597

--- Comment #104 from Hanan Sela  ---
Th(In reply to Kevin Suo from comment #103)
> (In reply to Hanan Sela from comment #102)
> Could you explain what is the problem in this Hebrew pdf file when open with
> Draw? I tested and most of the text are shown correctly with current master
> build as of Sat Nov 26 00:27:23 2022 +0300. Also, when testing please make
> sure you have the correct fonts installed on your linux system (e.g. this
> pdf file uses Arial font in the text مكتب on the header section so you
> should at least have Arial font instaled).

The are two problems: 1) In lines where there  is mixed text of Hebrew and 
Arabic numbers, the numbers and the  Hebrew text overlap. In some cases white
space are missing. It is more obvious in  the file I uploaded on 28/11/22.
Please see comparison screenshot.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 104597] RTL script text runs are reversed on PDF import, PDFIProcessor::mirrorString misbehaving

2022-11-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104597

--- Comment #103 from Kevin Suo  ---
(In reply to Hanan Sela from comment #102)
Could you explain what is the problem in this Hebrew pdf file when open with
Draw? I tested and most of the text are shown correctly with current master
build as of Sat Nov 26 00:27:23 2022 +0300. Also, when testing please make sure
you have the correct fonts installed on your linux system (e.g. this pdf file
uses Arial font in the text مكتب on the header section so you should at least
have Arial font instaled).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 104597] RTL script text runs are reversed on PDF import, PDFIProcessor::mirrorString misbehaving

2022-11-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104597

--- Comment #102 from Hanan Sela  ---
Created attachment 183844
  --> https://bugs.documentfoundation.org/attachment.cgi?id=183844=edit
screen shot of Hebrew pdf file

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 104597] RTL script text runs are reversed on PDF import, PDFIProcessor::mirrorString misbehaving

2022-11-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104597

--- Comment #101 from Hanan Sela  ---
Created attachment 183843
  --> https://bugs.documentfoundation.org/attachment.cgi?id=183843=edit
Hebrew PDF file

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 104597] RTL script text runs are reversed on PDF import, PDFIProcessor::mirrorString misbehaving

2022-11-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104597

V Stuart Foote  changed:

   What|Removed |Added

 CC||baruch.bern...@gmail.com

--- Comment #100 from V Stuart Foote  ---
*** Bug 152258 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 104597] RTL script text runs are reversed on PDF import, PDFIProcessor::mirrorString misbehaving

2022-11-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104597

--- Comment #99 from Commit Notification 
 ---
Stephan Bergmann committed a patch related to this issue.
It has been pushed to "libreoffice-7-4":

https://git.libreoffice.org/core/commit/f1db364f294d2d9a40d77004aeeb36729ae1c4ca

Related tdf#104597, tdf#151546: Introduce comphelper::string::reverseCodePoints

It will be available in 7.4.4.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 104597] RTL script text runs are reversed on PDF import, PDFIProcessor::mirrorString misbehaving

2022-11-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104597

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:7.5.0 target:7.4.3   |target:7.5.0 target:7.4.3
   ||target:7.4.4

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 104597] RTL script text runs are reversed on PDF import, PDFIProcessor::mirrorString misbehaving

2022-11-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104597

--- Comment #98 from V Stuart Foote  ---
*** Bug 149457 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 104597] RTL script text runs are reversed on PDF import, PDFIProcessor::mirrorString misbehaving

2022-11-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104597

V Stuart Foote  changed:

   What|Removed |Added

 CC||h...@013.net

--- Comment #97 from V Stuart Foote  ---
*** Bug 151950 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 104597] RTL script text runs are reversed on PDF import, PDFIProcessor::mirrorString misbehaving

2022-11-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104597

Hossein  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||2143

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 104597] RTL script text runs are reversed on PDF import, PDFIProcessor::mirrorString misbehaving

2022-11-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104597

--- Comment #96 from Commit Notification 
 ---
Stephan Bergmann committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/50d73574b6c3d71f9a539c895a15d6fcda22390b

Related tdf#104597, tdf#151546: Introduce comphelper::string::reverseCodePoints

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 104597] RTL script text runs are reversed on PDF import, PDFIProcessor::mirrorString misbehaving

2022-11-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104597

Hossein  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||2083

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 104597] RTL script text runs are reversed on PDF import, PDFIProcessor::mirrorString misbehaving

2022-11-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104597

--- Comment #95 from Commit Notification 
 ---
Kevin Suo committed a patch related to this issue.
It has been pushed to "libreoffice-7-4":

https://git.libreoffice.org/core/commit/bcb4fef4e321c6c0f1f9edd05b2f18ddb34792ed

sdext.pdfimport: resolves tdf#104597: RTL script text runs are reversed

It will be available in 7.4.3.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 104597] RTL script text runs are reversed on PDF import, PDFIProcessor::mirrorString misbehaving

2022-11-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104597

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:7.5.0|target:7.5.0 target:7.4.3

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 104597] RTL script text runs are reversed on PDF import, PDFIProcessor::mirrorString misbehaving

2022-10-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104597

Buovjaga  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 104597] RTL script text runs are reversed on PDF import, PDFIProcessor::mirrorString misbehaving

2022-10-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104597
Bug 104597 depends on bug 151546, which changed state.

Bug 151546 Summary: PDF poppler based filter import to Writer canvas reverses 
RTL script
https://bugs.documentfoundation.org/show_bug.cgi?id=151546

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 104597] RTL script text runs are reversed on PDF import, PDFIProcessor::mirrorString misbehaving

2022-10-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104597

Eyal Rozenberg  changed:

   What|Removed |Added

 Resolution|FIXED   |---
 Status|RESOLVED|REOPENED

--- Comment #94 from Eyal Rozenberg  ---
I see the dupes just fine. I will remind you that I'm one of the most active
member of the RTL languages discussion channel over the past several years. And
in this capacity I can tell you the reason Draw is mentioned in the dupes is
not because people wanted to separate the bug for Draw and for Writer, but
because of bug 141732, i.e. the fact that opening a PDF file from Writer (or
from Impress for that matter) opens it in Draw.

Nobody ever suggested to separate these two bugs and make this one Draw-only.
The title does not limit it to draw; and the opening comment doesn't limit it
to Draw. It is only with the potential prize of closing this long-standing and
widely-followed bug that this suggestion was first made.

I have no issue with tracking the Word part in a blocker bug, but RTL script
text runs are still reversed on PDF import. When that stops happening, then the
bug can be marked as fixed.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 104597] RTL script text runs are reversed on PDF import, PDFIProcessor::mirrorString misbehaving

2022-10-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104597

V Stuart Foote  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||9457
 Blocks|149457  |


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=149457
[Bug 149457] Arabic Text Scrambled and Unreadable in PDF Files Opened by
LibreOffice Draw
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 104597] RTL script text runs are reversed on PDF import, PDFIProcessor::mirrorString misbehaving

2022-10-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104597

V Stuart Foote  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #93 from V Stuart Foote  ---
(In reply to Eyal Rozenberg from comment #92)
> 
> No, it's not fixed: RTL text runs are still reversed on PDF import. You
> can't reduce the scope of this bug retroactively because you believe one of
> the PDF import filters is not important.

Don't believe I said that. And, as a routine QA matter we edit the BZ issues to
keep them crisp.

This TLDR; bug is now 92 comments long and the original issue(s) (see dupes)
with the DRAW import filter is fixed.

At comment 86 you highjacked the issue expanding scope to Writer. We knew the
writer import filter needed the same rework, but this bug was already unwieldy
and there will probably be substantive issues other than RTL handling (masking,
font handling, transforms) for the Writer import filter.

Accordingly opened a new clean issue for import filter work on the residual
WRITER issues, including RTL, and that needs a clean and concise BZ issue to
track.

CLOSING THIS AGAIN  => FIXED

Please don't reopen.

@Xisco?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 104597] RTL script text runs are reversed on PDF import, PDFIProcessor::mirrorString misbehaving

2022-10-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104597

Eyal Rozenberg  changed:

   What|Removed |Added

 Blocks|151546  |
 Depends on||151546


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=151546
[Bug 151546] PDF poppler based filter import to Writer canvas reverses RTL
script
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 104597] RTL script text runs are reversed on PDF import, PDFIProcessor::mirrorString misbehaving

2022-10-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104597

Eyal Rozenberg  changed:

   What|Removed |Added

 Status|RESOLVED|NEW
 Resolution|FIXED   |---

--- Comment #92 from Eyal Rozenberg  ---
(In reply to V Stuart Foote from comment #89)
> Wrong tool for the job!

Right too for the job.

>  The PDF Import filter was designed to extract all
> the presentation elements of a PDF as *Draw shape objects*--onto the Draw
> canvas. 

There are different import filters for Draw and for Writer. The project -
correctly-  decided to support opening PDFs in Writer - which means editing the
opened PDFs in Writer, as Writer documents.

If you believe that should be dropped, please open a separate bug and we can
argue about it there.

> You should not expect directly "edit" the PDF text runs as laid down as draw
> Shape textboxes as if they were text strings. They are a facsimile of the
> original PDF publishing--not intended to be editable.

I should, and I do. But regardless - I expect the PDF import filters not to
reverse text runs, which is what this bug is about.

> And of course using the ... neglected,
> PDF Import to Writer
> filter and placing thousand of draw shapes onto a Writer document canvas, it
> is going to bog things down.

The neglect is indeed a separate issue, as is the excessive use of draw shapes.

> To what end? The result of PDF import is not editable text! 

Completely disagree, but again - you're sneaking in an argument here about
wanting to drop the Writer PDF import filter. That's inappropriate.


> As an alternative, perhaps explore the very functional PDF "Insert as image"
> filter.

Can we find that in the list of import filters right now?

> Going to close this Resolved Fixed again.

No, it's not fixed: RTL text runs are still reversed on PDF import. You can't
reduce the scope of this bug retroactively because you believe one of the PDF
import filters is not important.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 104597] RTL script text runs are reversed on PDF import, PDFIProcessor::mirrorString misbehaving

2022-10-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104597

V Stuart Foote  changed:

   What|Removed |Added

   See Also|https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=15 |
   |1546|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 104597] RTL script text runs are reversed on PDF import, PDFIProcessor::mirrorString misbehaving

2022-10-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104597

V Stuart Foote  changed:

   What|Removed |Added

 Blocks||151546


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=151546
[Bug 151546] PDF poppler based filter import to Writer canvas mishandles RTL
script text order
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 104597] RTL script text runs are reversed on PDF import, PDFIProcessor::mirrorString misbehaving

2022-10-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104597

V Stuart Foote  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||1546

--- Comment #91 from V Stuart Foote  ---
Additional work needed for RTL scripts using the poppler based PDF import
filter for Writer is open as bug 151546

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 104597] RTL script text runs are reversed on PDF import, PDFIProcessor::mirrorString misbehaving

2022-10-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104597

--- Comment #90 from Kevin Suo  ---
> Open the exported PDF file using the PDF import filter targeting Writer
I submitted another patch related to the Writer part, please review and test:
https://gerrit.libreoffice.org/c/core/+/141420

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 104597] RTL script text runs are reversed on PDF import, PDFIProcessor::mirrorString misbehaving

2022-10-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104597

V Stuart Foote  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

--- Comment #89 from V Stuart Foote  ---
(In reply to Eyal Rozenberg from comment #88)
> 
> That's probably because it's problematic and Writer's performance on the
> document it produces is kind of dismal. When I open the "PDF file"
> attachment in Writer - only 7 pages - it slows to a crawl with scroll delay
> times of ~ 10 seconds or higher. Is there a separate bug about that?
> 
> 
> Also, the Writer PDF import filter is hidden away; and when you try to open
> a PDF from Writer it defaults to opening in Draw for some reason; I'm sure I
> opened a bug about this at some point.
> 

Wrong tool for the job!  The PDF Import filter was designed to extract all the
presentation elements of a PDF as *Draw shape objects*--onto the Draw canvas.
Text runs recorded into the PDF (as either char sequences from the PDFs
ToUnicode chart, or as PDF /ActualText tags) are imported to draw textboxes.
The reconstructed textboxes sometimes contain just one glyph with *NO* lexical
context--just the sequence of characters as published into the PDF.

You should not expect directly "edit" the PDF text runs as laid down as draw
Shape textboxes as if they were text strings. They are a facsimile of the
original PDF publishing--not intended to be editable.

And of course using the alternate, and neglected, PDF Import to Writer filter
and placing thousand of draw shapes onto a Writer document canvas, it is going
to bog things down. Shapes including textboxes on Writer canvas are expensive
and nonperformant.


> If those two issues were resolved, I believe opening a PDF in Writer would
> become a common use case as well

To what end? The result of PDF import is not editable text! Even in Draw where
using the rudimentary "Consolidate text" utility (.uno:TextCombine, for bug
118370) takes the lexically broken text runs of multiple textboxes and merges
them, they are still in a textbox--no paragraph controls, minimal formatting,
etc.  To understand what you get to work with (Draw, Impress or Writer), open
the SB Navigator deck. Every shape object would need to be 

As an alternative, perhaps explore the very functional PDF "Insert as image"
filter. Completely different source based on pdfium rather than poppler but
very high fidelity to the original PDF, with its own set of enhancements, e.g.
bug 114234 bug 115811 and need to manually set the 'PDFIMPORT_RESOLUTION_DPI'
for more than the 96dpi default. 

Going to close this Resolved Fixed again. PDF Filter import for Draw and
Impress are addressed, opening a new issue for the refactoring of the Writer
import filter 'PDF - Portable Document Format (Writer) (*.pdf)'

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 104597] RTL script text runs are reversed on PDF import, PDFIProcessor::mirrorString misbehaving

2022-10-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104597

--- Comment #88 from Eyal Rozenberg  ---
(In reply to Kevin Suo from comment #87)
> However I guess very fewer people use the Writer pdf import filter.

That's probably because it's problematic and Writer's performance on the
document it produces is kind of dismal. When I open the "PDF file" attachment
in Writer - only 7 pages - it slows to a crawl with scroll delay times of ~ 10
seconds or higher. Is there a separate bug about that?


Also, the Writer PDF import filter is hidden away; and when you try to open a
PDF from Writer it defaults to opening in Draw for some reason; I'm sure I
opened a bug about this at some point.

If those two issues were resolved, I believe opening a PDF in Writer would
become a common use case as well.

Regardless of all this - I'm not capable of helping with the code, but everyone
is encouraged to go onto the LO RTL channel and ask for help with verification.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 104597] RTL script text runs are reversed on PDF import, PDFIProcessor::mirrorString misbehaving

2022-10-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104597

--- Comment #87 from Kevin Suo  ---
Eyal Rozenberg, you are right. There are two pdf imprort filters in sdext, one
is Draw, and another is Writer. My patch was targeted in Dwaw only, the fix was
in code
https://opengrok.libreoffice.org/xref/core/sdext/source/pdfimport/tree/drawtreevisiting.cxx?r=69e9925d.
The Writer related code is in
https://opengrok.libreoffice.org/xref/core/sdext/source/pdfimport/tree/writertreevisiting.cxx?r=3fe18ba1.
While these two files are similar in many inspects, are are different somehow
as it seems many changes for Draw side were not backported in the Writer side
historically.

However I guess very fewer people use the Writer pdf import filter. Yes, this
bug may stay open, and I may take a look of the Writer side, but I can not
guarantee. Anyone else are welcome to do this, the codes share the similar
logic on both sides.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 104597] RTL script text runs are reversed on PDF import, PDFIProcessor::mirrorString misbehaving

2022-10-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104597

Eyal Rozenberg  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

--- Comment #86 from Eyal Rozenberg  ---
I'm sorry, but this is not fully fixed - at least with the latest nightly, from
2022-10-14 09:02.

While the attachment 129523 (PDF file) does not exhibit reversed text runs, I
get text runs reversed with a simple PDF file created in LO. Instructions:

1. Start Writer
2. Switch paragraph direction to RTL
3. Enter the phrase "שלום"
4. Export to PDF (using File | Export As | Export as PDF)
5. Open the exported PDF file using the PDF import filter targeting Writer

... and you get the reversed "םולש".

Note that if you open the file without specifying an import filter, it opens in
LO Draw, and the text run is not reversed. So it may just be the case that the
patch doesn't cover the relevant code paths.

Build ID:

Version: 7.5.0.0.alpha0+ / LibreOffice Community
Build ID: a09c5c69e3b5fbf448cae1d6c476f39067e40023
CPU threads: 4; OS: Linux 5.19; UI render: default; VCL: gtk3
Locale: en-IL (en_IL); UI: en-US

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 104597] RTL script text runs are reversed on PDF import, PDFIProcessor::mirrorString misbehaving

2022-10-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104597

--- Comment #85 from Kevin Suo  ---
(In reply to V Stuart Foote from comment #84)
OK, good to hear that. Maybe more people can test to see if there are
regressions caused by this.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 104597] RTL script text runs are reversed on PDF import, PDFIProcessor::mirrorString misbehaving

2022-10-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104597

--- Comment #84 from V Stuart Foote  ---
IMHO this is fixed now. The import to Draw of Persian and Arabic sample PDFs
match pretty closely their layout and rendering in Adobe Acrobat, MS Edge, or
FireFox

There are occasional font fallback issues, and a lot of spots where combining
diacritics get separated from their root glyph garbling the text.

But much better than it was.

Unfortunately "Consolidate text" (bug 118370) of the runs will need some
additional work to keep the runs RTL, and otherwise remains a challenge to
select the draw text objects for the runs--but that is more bug 32249 related. 

The bug 151473 issues with bracketing punctuation is present, guess issues in
the poppler libs could also be the reason for the orphaned combining
diacritics.

Thanks Kevin!

=-testing-=
2022-10-14 nightly
Version: 7.5.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 8991cbb7986d3967bc6c3719d95254ff04428d1a
CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 104597] RTL script text runs are reversed on PDF import, PDFIProcessor::mirrorString misbehaving

2022-10-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104597

--- Comment #83 from Eyal Rozenberg  ---
(In reply to Kevin Suo from comment #78)
> https://gerrit.libreoffice.org/c/core/+/141231
> 
> should be a fix. Could someone review and test.

I will try this out when it makes a nightly. However - could you explain why
this was not considered to be a fix so far? Thorsten seemed to suggest that
this was more complicated than one might think because of various implications
I did not have the time to ask him about.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 104597] RTL script text runs are reversed on PDF import, PDFIProcessor::mirrorString misbehaving

2022-10-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104597

Kevin Suo  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #82 from Kevin Suo  ---
This is now fixed on master branch. There is another issue in bug 151473.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 104597] RTL script text runs are reversed on PDF import, PDFIProcessor::mirrorString misbehaving

2022-10-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104597

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.5.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 104597] RTL script text runs are reversed on PDF import, PDFIProcessor::mirrorString misbehaving

2022-10-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104597

--- Comment #81 from Commit Notification 
 ---
Kevin Suo committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/69e9925ded584113e52f84ef0ed7c224079fa061

sdext.pdfimport: resolves tdf#104597: RTL script text runs are reversed

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 104597] RTL script text runs are reversed on PDF import, PDFIProcessor::mirrorString misbehaving

2022-10-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104597

--- Comment #80 from Kevin Suo  ---
Created attachment 182981
  --> https://bugs.documentfoundation.org/attachment.cgi?id=182981=edit
output.xml

xml output of unit test testTdf104597_textrun.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 104597] RTL script text runs are reversed on PDF import, PDFIProcessor::mirrorString misbehaving

2022-10-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104597

Kevin Suo  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||1473

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 104597] RTL script text runs are reversed on PDF import, PDFIProcessor::mirrorString misbehaving

2022-10-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104597

--- Comment #79 from Kevin Suo  ---
Created attachment 182980
  --> https://bugs.documentfoundation.org/attachment.cgi?id=182980=edit
tdf104597_textrun.odt

I upload the odt file (used to generate the
sdext/source/pdfimport/test/testdocs/tdf104597_textrun.pdf) here for the
record, so that someone, when revising the unit test "testTdf104597_textrun",
can regenerate the PDF file using this ODT.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 104597] RTL script text runs are reversed on PDF import, PDFIProcessor::mirrorString misbehaving

2022-10-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104597

--- Comment #78 from Kevin Suo  ---
The proposed patch in:
https://gerrit.libreoffice.org/c/core/+/141231

should be a fix. Could someone review and test.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 104597] RTL script text runs are reversed on PDF import, PDFIProcessor::mirrorString misbehaving

2022-09-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104597

Eyal Rozenberg  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||1247

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 104597] RTL script text runs are reversed on PDF import, PDFIProcessor::mirrorString misbehaving

2022-09-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104597

Eyal Rozenberg  changed:

   What|Removed |Added

 Blocks||149457


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=149457
[Bug 149457] Arabic Text Scrambled and Unreadable in PDF Files Opened by
LibreOffice Draw
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 104597] RTL script text runs are reversed on PDF import, PDFIProcessor::mirrorString misbehaving

2022-07-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104597

--- Comment #77 from V Stuart Foote  ---
(In reply to Eyal Rozenberg from comment #76)
> Ping.

.

@Thorsten, @Armin have you any cycles to revisit this. It is problematic that
the PDF import filter mishandles the RTL text runs so badly. Haven't seen much
of Kevin Suo of late hope he's OK.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 104597] RTL script text runs are reversed on PDF import, PDFIProcessor::mirrorString misbehaving

2022-07-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104597

--- Comment #76 from Eyal Rozenberg  ---
(In reply to Eyal Rozenberg from comment #73)
> So, any news about this? A discussion had started last year about a proposed
> patch, and has somehow died off.

Ping.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 104597] RTL script text runs are reversed on PDF import, PDFIProcessor::mirrorString misbehaving

2022-07-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104597

Eyal Rozenberg  changed:

   What|Removed |Added

 CC||vgtv...@gmail.com

--- Comment #75 from Eyal Rozenberg  ---
*** Bug 149516 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 104597] RTL script text runs are reversed on PDF import, PDFIProcessor::mirrorString misbehaving

2022-06-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104597

V Stuart Foote  changed:

   What|Removed |Added

 CC||kni...@gmail.com

--- Comment #74 from V Stuart Foote  ---
*** Bug 149457 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 104597] RTL script text runs are reversed on PDF import, PDFIProcessor::mirrorString misbehaving

2022-06-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104597

Gabor Kelemen (allotropia)  changed:

   What|Removed |Added

  Regression By||Thorsten Behrens
 CC||kelem...@ubuntu.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 104597] RTL script text runs are reversed on PDF import, PDFIProcessor::mirrorString misbehaving

2022-04-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104597

Eyal Rozenberg  changed:

   What|Removed |Added

Summary|Text runs of RTL scripts|RTL script text runs are
   |(e.g. Arabic, Hebrew,   |reversed on PDF import,
   |Persian) from imported PDF  |PDFIProcessor::mirrorString
   |are reversed,   |misbehaving
   |PDFIProcessor::mirrorString |
   |misbehaving |

-- 
You are receiving this mail because:
You are the assignee for the bug.