[Libreoffice-bugs] [Bug 104816] Inserting a user field will lose the condition of section

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104816

Justin L  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |jl...@mail.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104816] Inserting a user field will lose the condition of section

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104816

Justin L  changed:

   What|Removed |Added

 CC||s...@s73.work

--- Comment #13 from Justin L  ---
*** Bug 125658 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104816] Inserting a user field will lose the condition of section

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104816

Oliver Brinzing  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||5658

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104816] Inserting a user field will lose the condition of section

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104816

Justin L  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #12 from Justin L  ---
A temporary work-around is to ensure that the section is not at the end of the
document.  You can insert a space after the section with an alt-enter.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104816] Inserting a user field will lose the condition of section

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104816

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:6.3.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104816] Inserting a user field will lose the condition of section

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104816

--- Comment #11 from Commit Notification 
 ---
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/85bd9d81e1dafdef5b868637ebb34f22282befab%5E%21

tdf#104816 sw: if non-section content, let all sections hide.

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104816] Inserting a user field will lose the condition of section

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104816

Justin L  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=55
   ||814

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104816] Inserting a user field will lose the condition of section

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104816

--- Comment #10 from Justin L  ---
proposed fix at https://gerrit.libreoffice.org/66128

The (In reply to Justin L from comment #9)
> make sure deleting all visible paragraphs doesn't crash Writer
This was from an assert, so it doesn't crash non-debug builds.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104816] Inserting a user field will lose the condition of section

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104816

Justin L  changed:

   What|Removed |Added

 CC||jl...@mail.com

--- Comment #9 from Justin L  ---
Created attachment 148200
  --> https://bugs.documentfoundation.org/attachment.cgi?id=148200=edit
hidden_section_crash.odt: solution test document - make sure deleting all
visible paragraphs doesn't crash Writer

Currently this document does not crash, because it refuses to allow you to
delete the paragraph entirely. However, if comment 6's fix is reverted, then
deleting all non-section content results in a crash.

That makes this a bit more complicated, because even if the document is
currently OK to allow all of the sections to be hidden, the possibility of a
crash is again opened up.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104816] Inserting a user field will lose the condition of section

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104816

Justin L  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=53
   ||210

--- Comment #8 from Justin L  ---
confirmed that comment 6 has identified the correct commit. The code is now
found in sw/source/core/doc/DocumentFieldsManager.cxx 
DocumentFieldsManager::UpdateExpFieldsImpl().

confirmed that without that fix, Writer still crashes if every part of the
document belongs to hidden sections. The trick here will be to find out if any
of the document is NOT covered by sections (which would be the normal case) and
then allow all the sections to be hidden.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104816] Inserting a user field will lose the condition of section

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104816

--- Comment #7 from Oliver Brinzing  ---
still reproducible in LO 6.0.6.1 and 
6.2.0.0.alpha0+ (x64)
Build ID: cbc992e7370ab006ea7c0f8520896845f79f7749

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104816] Inserting a user field will lose the condition of section

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104816

Buovjaga  changed:

   What|Removed |Added

 CC||vmik...@collabora.co.uk
   Keywords|bibisectRequest |bibisected

--- Comment #6 from Buovjaga  ---
Bibisected with Linux 43all and blamed range is
https://cgit.freedesktop.org/libreoffice/core/log/?qt=range=57c3b583f1f69edd32b2a54253850e1b3b202255...75df7739309ccc5342084e668d9d869620cb3233

The commit that stands out is
https://cgit.freedesktop.org/libreoffice/core/commit/?id=bb6bd1ff9cd3eecec7eb2cd7bd0a4dcef584c903

commit  bb6bd1ff9cd3eecec7eb2cd7bd0a4dcef584c903 (patch)
tree673e5844d1b9f146557d8870678d6f076f38271b
parent  369da987d373bdf5bdabfeb11d4b2562c916f372 (diff)
fdo#53210 SwDoc::UpdateExpFlds don't crash when hiding all sections

Adding Cc: to Miklos Vajna

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104816] Inserting a user field will lose the condition of section

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104816

Buovjaga  changed:

   What|Removed |Added

 Blocks||107738

--- Comment #5 from Buovjaga  ---
Still repro.

Arch Linux 64-bit
Version: 6.1.0.0.alpha1+
Build ID: 5956828c88501ef1366e60010b05053a8e1e642e
CPU threads: 8; OS: Linux 4.16; UI render: default; VCL: kde4; 
Locale: fi-FI (fi_FI.UTF-8); Calc: group
Built on May 23rd 2018


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=107738
[Bug 107738] [META] Section bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104816] Inserting a user field will lose the condition of section

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104816

Oliver Brinzing  changed:

   What|Removed |Added

 CC||oliver.brinz...@gmx.de

--- Comment #4 from Oliver Brinzing  ---
confirming with lo 5.3.2.2 and lo 5.4.0.0.alpha0+
(Build ID: c2511f27768341e33b452429b6dac38efa039804)

adding variable "Test" with a value greater "0"
will destory the condition.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104816] Inserting a user field will lose the condition of section

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104816

Buovjaga  changed:

   What|Removed |Added

   Keywords||bibisectRequest, regression
 Status|UNCONFIRMED |NEW
Version|5.4.0.0.alpha0+ Master  |3.6.7.2 release
Summary|insert userfield will   |Inserting a user field will
   |losing condition of section |lose the condition of
   ||section
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs