[Libreoffice-bugs] [Bug 104825] UI: field for SMTP server port number is spin button

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104825

Aron Budea  changed:

   What|Removed |Added

   Keywords|easyHack|
 Status|NEW |RESOLVED
 Resolution|--- |NOTABUG

--- Comment #9 from Aron Budea  ---
(In reply to Heiko Tietze from comment #8)
> The pure edit is not better as it gives no clue about numerical and
> constrained input. So odd yes, but better than ordinary edit.

Considering a slider wouldn't be useful in this case, let's close this as
NOTABUG.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104825] UI: field for SMTP server port number is spin button

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104825

Heiko Tietze  changed:

   What|Removed |Added

   Keywords|needsUXEval |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104825] UI: field for SMTP server port number is spin button

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104825

--- Comment #8 from Heiko Tietze  ---
Wrote on the KDE HIG:
* Use spin boxes for numerical input only. Use a list or option menu when you
need the user to select from fixed data sets of other types.
* Use a spin box if the numerical value is meaningful or useful for the user to
know, and the valid input range is unlimited or fixed at one end only. For
example, a control for specifying the number of iterations of some action, or a
time-out value.
* If the range is fixed at both ends, or the numerical values are arbitrary
(for example, a volume control), use a Slider control instead.
* For cases where the values are constrained at both ends and there large
ranges of integers (more than about 20) or floating-point values that require
precise control, consider providing both a Slider and Spin Box. This allows the
user to quickly set or fine-tune the setting more easily than they could with
the slider control alone.

The pure edit is not better as it gives no clue about numerical and constrained
input. So odd yes, but better than ordinary edit.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104825] UI: field for SMTP server port number is spin button

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104825

Xisco Faulí  changed:

   What|Removed |Added

   Keywords|needsDevEval|needsUXEval
 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org

--- Comment #7 from Xisco Faulí  ---
(In reply to Aron Budea from comment #6)
> So I just encountered port fields in Firefox proxy settings and Ubuntu
> network settings, and they're all spin buttons. Maybe this is NOTABUG?

Adding UX team for the final decision. I think we can live with it if we just
leave it...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104825] UI: field for SMTP server port number is spin button

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104825

--- Comment #6 from Aron Budea  ---
So I just encountered port fields in Firefox proxy settings and Ubuntu network
settings, and they're all spin buttons. Maybe this is NOTABUG?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104825] UI: field for SMTP server port number is spin button

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104825

--- Comment #5 from Terrence Enger  ---
Yes, Xisco, the bug was introduced by 43f2c887:

commit 43f2c887a0ed365c2f06d29bb5fa5512cbcaf542
Author: Csikós Tamás 
AuthorDate: Tue Jul 9 14:53:49 2013 +0200
Commit: Caolán McNamara 
CommitDate: Wed Jul 10 14:27:31 2013 +

modern .ui widgetlayout for mailconfigpage

Change-Id: I1e7dae74e20f9133f3c4f6319bc294ea5bec22f6
Reviewed-on: https://gerrit.libreoffice.org/4783
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104825] UI: field for SMTP server port number is spin button

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104825

Xisco Faulí  changed:

   What|Removed |Added

 CC||xiscofa...@libreoffice.org

--- Comment #4 from Xisco Faulí  ---
(In reply to Terrence Enger from comment #3)
> Created attachment 130065 [details]
> details from bibisect-42max
> 
> Working on debian-stretch in bibisect-42max repository, I see the spin
> button come into LibreOffice ...
> 
> status   commits-h   date
> --       ---
> good 11f7d374  9579db98  2013-07-10 14:17:46
> bad  4445ac65  43f2c887  2013-07-10 14:27:31
> 
> I am removing keyword bibisectRequest and adding bisected.
> 
> Guessing that this might not be too hard to fix, I am adding keyword
> needsDevEval.

Hi Terrence,
It doesn't seem the problem was introduced by 9579db98 but it was by 43f2c887,
am I correct?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104825] UI: field for SMTP server port number is spin button

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104825

Aron Budea  changed:

   What|Removed |Added

   Keywords||bibisected

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104825] UI: field for SMTP server port number is spin button

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104825

Aron Budea  changed:

   What|Removed |Added

   Keywords||easyHack

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104825] UI: field for SMTP server port number is spin button

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104825

Terrence Enger  changed:

   What|Removed |Added

   Keywords|bibisectRequest |bisected, needsDevEval

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104825] UI: field for SMTP server port number is spin button

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104825

Terrence Enger  changed:

   What|Removed |Added

 CC||lo_b...@iseries-guru.com

--- Comment #3 from Terrence Enger  ---
Created attachment 130065
  --> https://bugs.documentfoundation.org/attachment.cgi?id=130065=edit
details from bibisect-42max

Working on debian-stretch in bibisect-42max repository, I see the spin
button come into LibreOffice ...

status   commits-h   date
--       ---
good 11f7d374  9579db98  2013-07-10 14:17:46
bad  4445ac65  43f2c887  2013-07-10 14:27:31

I am removing keyword bibisectRequest and adding bisected.

Guessing that this might not be too hard to fix, I am adding keyword
needsDevEval.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104825] UI: field for SMTP server port number is spin button

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104825

Yousuf Philips (jay)  changed:

   What|Removed |Added

   Keywords||bibisectRequest
 Status|UNCONFIRMED |NEW
 Blocks||102187
 Ever confirmed|0   |1

--- Comment #2 from Yousuf Philips (jay)  ---
(In reply to Cor Nouws from comment #0)
> A spin button may make sense for e.g. font size, but for a server port
> number..

We debated this issue in the file services dialog in the CMIS and changed the
port control from a spinbox to a regular input field.

(In reply to Aron Budea from comment #1)
> Interesting, this was changed from a regular text field to a spin button in
> 4.2. No idea why, but indeed, the old field suited better for the task.

Can you bibisect this so we can see what changed, so we can easily revert it?


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=102187
[Bug 102187] [META] Options dialog bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104825] UI: field for SMTP server port number is spin button

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104825

Aron Budea  changed:

   What|Removed |Added

 CC||ba...@caesar.elte.hu,
   ||philip...@hotmail.com
Version|5.4.0.0.alpha0+ Master  |4.2.0.4 release

--- Comment #1 from Aron Budea  ---
Interesting, this was changed from a regular text field to a spin button in
4.2. No idea why, but indeed, the old field suited better for the task.

Jay, what do you think?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs