[Libreoffice-bugs] [Bug 104884] When View-Sidebar is on, after Print Preview is shown and closed, key F11 has no effect

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104884

Caolán McNamara  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |caol...@redhat.com
   |desktop.org |
 OS|Windows (All)   |All

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104884] When View-Sidebar is on, after Print Preview is shown and closed, key F11 has no effect

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104884

--- Comment #8 from Caolán McNamara  ---
when we go to print preview mode we change the controller of the frame and on
return we change it again, but the sidebar foo remains listening to the
original controller. Currently it doesn't even have  way to know this happened
because framework/source/services/ContextChangeEventMultiplexer.cxx::disposing
won't tell it that the original controller is gone, see "Should we notify the
remaining listeners"

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104884] When View-Sidebar is on, after Print Preview is shown and closed, key F11 has no effect

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104884

Aron Budea  changed:

   What|Removed |Added

 CC||ba...@caesar.elte.hu

--- Comment #7 from Aron Budea  ---
The crash is resolved by the following commit:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=5768416761756a386cba54314f783cb9c0d0d093
author  Caolán McNamara 2016-12-09 11:09:21 (GMT)
committer   Caolán McNamara 2016-12-09 11:14:53
(GMT)

"Related: rhbz#1397939 crash with null pSidebarController"

Commit has been cherry-picked into 5.2 branch:
https://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-5-2=3e60ccb74ac6589e14a479c6646c63a4e5ac4e35

It's not in 5.2.4 branch, though (branch-off: 2016-11-29).
=> crash should be gone in 5.2.5.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104884] When View-Sidebar is on, after Print Preview is shown and closed, key F11 has no effect

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104884

--- Comment #6 from Aron Budea  ---
Reverse bibisect log for the crash using repo bibisect-win32-5.3.

78aa55cc8eab2be8ca1a4c23d658b38affd45f2f is the first bad commit
commit 78aa55cc8eab2be8ca1a4c23d658b38affd45f2f
Author: Norbert Thiebaud 
Date:   Fri Dec 9 13:34:18 2016 -0800

source sha:5768416761756a386cba54314f783cb9c0d0d093

# bad: [166286094e583fb471c9500fdbddee4e83ef478c] source
sha:70b3dd697cb248fb56830db691269fe9e78c57fb
# good: [479ca41474b9720803421ab7717aa69fa6c60528] source
sha:f8c463b393885b660500bf4f7f73b4fb90ce2389
git bisect start '166286094e583fb471c9500fdbddee4e83ef478c'
'479ca41474b9720803421ab7717aa69fa6c60528'
# bad: [af99ef748ba2c46c574a6668439f27e2b3b74158] source
sha:83675eeb30c92a17dd272894df34b89628de0142
git bisect bad af99ef748ba2c46c574a6668439f27e2b3b74158
# bad: [626369369677df78749af63bbd005a8e1f25b615] source
sha:6238f71ddbdc766e733b1c808a4fa7d66f7bde87
git bisect bad 626369369677df78749af63bbd005a8e1f25b615
# good: [14ccfca54c2c9f6f02204b0381d7409ade16ad8f] source
sha:7f47d68c4310b8bae09286a81036a6fa669a1705
git bisect good 14ccfca54c2c9f6f02204b0381d7409ade16ad8f
# bad: [8e27d55c66beffb3377925bac1d4eb2ca3058e16] source
sha:1093721a260d25f986fd794acd914b8fb7bcf92a
git bisect bad 8e27d55c66beffb3377925bac1d4eb2ca3058e16
# bad: [949bab15e5a2d57ef8b5b58762f1e2783dcf1bf0] source
sha:b832d7019f7e7499f5fb3da5d5f49ddbf0f35585
git bisect bad 949bab15e5a2d57ef8b5b58762f1e2783dcf1bf0
# good: [2644da24d79bd49ca52f94d8799d66da01b593cc] source
sha:987984ea21f1688eddfc124292f5e4b931d7d138
git bisect good 2644da24d79bd49ca52f94d8799d66da01b593cc
# bad: [4f84486bebe27e5010d877b6e8b1ffede23cf2ef] source
sha:56261b0bb06e29b71e2cc555086100282e54d62e
git bisect bad 4f84486bebe27e5010d877b6e8b1ffede23cf2ef
# bad: [78aa55cc8eab2be8ca1a4c23d658b38affd45f2f] source
sha:5768416761756a386cba54314f783cb9c0d0d093
git bisect bad 78aa55cc8eab2be8ca1a4c23d658b38affd45f2f
# first bad commit: [78aa55cc8eab2be8ca1a4c23d658b38affd45f2f] source
sha:5768416761756a386cba54314f783cb9c0d0d093

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104884] When View-Sidebar is on, after Print Preview is shown and closed, key F11 has no effect

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104884

V Stuart Foote  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||5092

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104884] When View-Sidebar is on, after Print Preview is shown and closed, key F11 has no effect

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104884

Timur  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||2045

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104884] When View-Sidebar is on, after Print Preview is shown and closed, key F11 has no effect

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104884

Timur  changed:

   What|Removed |Added

Summary|When View-Sidebar is on,|When View-Sidebar is on,
   |after Print Preview is  |after Print Preview is
   |shown and closed, key F11   |shown and closed, key F11
   |have no effect  |has no effect

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs